[Koha-bugs] [Bug 17499] Koha objects for messaging preferences

bugzilla-daemon at bugs.koha-community.org bugzilla-daemon at bugs.koha-community.org
Thu Jun 1 13:56:32 CEST 2017


https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17499

Lari Taskula <lari.taskula at jns.fi> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #63878|0                           |1
        is obsolete|                            |

--- Comment #34 from Lari Taskula <lari.taskula at jns.fi> ---
Created attachment 63895
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=63895&action=edit
Bug 17499: (follow-up) Bugfix for validation, 2

Remove duplicate validation for digest availability. This is already checked in
$preference->validate().

Set values for current object before validating messaging transport types, not
the other way around as it was before this patch.

Also prevents a crash when patron has messaging transport type selected for
a message for which it should not be available. This patch logs it with as
a warning, and only throws an exception when attempting to set it.

To test:
1. prove t/db_dependent/Koha/Patron/Message/*

-- 
You are receiving this mail because:
You are watching all bug changes.


More information about the Koha-bugs mailing list