[Koha-bugs] [Bug 15326] Add CMS feature

[bugzilla-daemon at bugs.koha-community.org]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15326

Josef Moravec <josef.moravec at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Needs Signoff               |Failed QA

--- Comment #14 from Josef Moravec <josef.moravec at gmail.com> ---
It basically works, but need more improvements:

- the action buttons should be in dropdown and contain also delete button
- both test fail
- there are also many issues from koha qa test tool:

 FAIL   Koha/CmsPages.pm
   FAIL   critic
                "return" statement with explicit "undef" at line 93, column 17.
See page 199 of PBP.
                "return" statement with explicit "undef" at line 80, column 13.
See page 199 of PBP.
   FAIL   pod
                *** ERROR: 


                Apparent command =cut not preceded by blank line
                 in file Koha/CmsPages.pm
   FAIL   spelling
                 paramters  ==> parameters


 FAIL   koha-tmpl/intranet-tmpl/prog/en/modules/tools/cmspages.tt
   FAIL   forbidden patterns
                forbidden pattern: Contains old bootstrap style for buttons
(see bug 16239) (line 284)
                forbidden pattern: Contains old bootstrap style for buttons
(see bug 16239) (line 286)
                forbidden pattern: Contains old bootstrap style for buttons
(see bug 16239) (line 288)
                forbidden pattern: Contains old bootstrap style for buttons
(see bug 16239) (line 281)
                forbidden pattern: Contains old bootstrap style for buttons
(see bug 16239) (line 283)
                forbidden pattern: Contains old bootstrap style for buttons
(see bug 16239) (line 92)


 FAIL   t/db_dependent/Pages.t
   FAIL   forbidden patterns
                forbidden pattern: tab char (line 78)
                forbidden pattern: tab char (line 49)
                forbidden pattern: tab char (line 85)
                forbidden pattern: tab char (line 54)
                forbidden pattern: tab char (line 72)
                forbidden pattern: tab char (line 84)
                forbidden pattern: tab char (line 62)
                forbidden pattern: tab char (line 82)
                forbidden pattern: tab char (line 68)
                forbidden pattern: tab char (line 70)
                forbidden pattern: tab char (line 73)
                forbidden pattern: tab char (line 50)
                forbidden pattern: tab char (line 59)
                forbidden pattern: tab char (line 52)
                forbidden pattern: tab char (line 71)
                forbidden pattern: tab char (line 79)
                forbidden pattern: tab char (line 61)
                forbidden pattern: tab char (line 75)
                forbidden pattern: tab char (line 58)
                forbidden pattern: tab char (line 60)
                forbidden pattern: tab char (line 63)
                forbidden pattern: tab char (line 48)
                forbidden pattern: tab char (line 64)
                forbidden pattern: tab char (line 53)
                forbidden pattern: tab char (line 55)
                forbidden pattern: tab char (line 83)
                forbidden pattern: tab char (line 74)
                forbidden pattern: tab char (line 81)
                forbidden pattern: tab char (line 80)
                forbidden pattern: tab char (line 69)
                forbidden pattern: tab char (line 65)
                forbidden pattern: tab char (line 51)

-- 
You are receiving this mail because:
You are watching all bug changes.