[Koha-bugs] [Bug 18292] t/db_dependent/Circulation.t doesn't need to return 1;

bugzilla-daemon at bugs.koha-community.org bugzilla-daemon at bugs.koha-community.org
Wed Jun 7 19:58:06 CEST 2017


https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18292

M. Tompsett <mtompset at hotmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |mtompset at hotmail.com

--- Comment #5 from M. Tompsett <mtompset at hotmail.com> ---
(In reply to Marc Véron from comment #3)
> What about the tons of *.t files with 1; as last line?
> 
> git grep '^1;' -- *.t

Comparing
git grep '^1;' -- *.t | wc
with
git grep -- *.t | wc

I believe 'tons' is an exaggeration. :)
This is a small patch. It doesn't hurt.

P.S.

for i in `git grep -l '^1;' -- *.t`; do git blame $i | tail -1 | cut -f2 -d'('
| cut -f1 -d2 | sed -e "s#\s*\$##g"; done | sort -u
Alex Sassmannshausen
A. Sassmannshausen
Charles Farmer
Emmanuele Somma
Galen Charlton
Jacek Ablewicz
Jared Camins-Esakov
Jonathan Druart
Kyle M Hall
Lari Taskula
Marcel de Rooy
Martin Renvoize
Paul Poulain
Ryan Higgins
Tomás Cohen Arazi

-- 
You are receiving this mail because:
You are watching all bug changes.


More information about the Koha-bugs mailing list