[Koha-bugs] [Bug 18771] CGI.pm: Subroutine multi_param redefined

[bugzilla-daemon at bugs.koha-community.org]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18771

--- Comment #1 from M. Tompsett <mtompset at hotmail.com> ---
Created attachment 64165
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=64165&action=edit
Bug 18771: CGI.pm: Subroutine multi_param redefined

The commands in the test plan are examples, and may need varying
depending on your installation. This was created as a result
of attempting to clean the installation process up. However,
I believe the redefine might exist normally too. I just didn't
check. This is tested on a Debian 8 box sudo apt-get update'd
fully.

TEST PLAN
---------
empty error log
$ echo > ~/koha-dev/var/log/koha-error_log

drop and recreate and empty db
> drop database koha_library;
> create database koha_library;
> quit

run the web installer, but DO NOT LOG IN!
*opening chrome to Staff Client URL*

check the error log
$ less ~/koha-dev/var/log/koha-error_log
...
[Fri Jun 09 13:08:52.793627 2017] [cgi:error] [pid 5802] [client
192.168.71.101:58169] AH01215: [Fri Jun  9 13:08:52 2017] CGI.pm: Subroutine
multi_param redefined at /usr/share/perl5/CGI.pm line 419.
...

apply first patch

empty error log
$ echo > ~/koha-dev/var/log/koha-error_log

refresh the installation login page

recheck the error log
$ less ~/koha-dev/var/log/koha-error_log

[Fri Jun 09 12:59:06.705954 2017] [cgi:error] [pid 5692] [client
192.168.71.101:57887] AH01215: Low version
[Fri Jun 09 12:59:06.723323 2017] [cgi:error] [pid 5692] [client
192.168.71.101:57887] AH01215: Is actually: 4.09
...

notice that 4.09 is bigger than the 4.08 condition, and that
the code was triggered because $CGI::VERSION is undefined,
since there was no require to set the VERSION value.

apply second patch

empty error log
$ echo > ~/koha-dev/var/log/koha-error_log

refresh the installation login page

recheck the error log
$ less ~/koha-dev/var/log/koha-error_log

notice no reference to "Subroutine multi_param redefined"

run koha qa test tools

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.