[Koha-bugs] [Bug 18331] CSV exports need to be fixed once and for all

[bugzilla-daemon at bugs.koha-community.org]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18331

Marc Véron <veron at veron.ch> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |veron at veron.ch

--- Comment #4 from Marc Véron <veron at veron.ch> ---
I first tested English CSV export of late orders with two items and got
everything on one line.

Just for testing, I
- removed the chomps from line 3, changed to:
[% INCLUDE empty_line.inc %]
-> Fail, same result (one line)

- added an empty line above line 3 (just for testing, it makes no sense with
the intention of an empty line include)
[%- USE KohaDates -%]
[%- INCLUDE csv_headers/acqui/lateorders.tt -%]

[% INCLUDE empty_line.inc %]
[%- FOREACH o IN orders -%]
-> Fail CSV-Export with header on one line, contents (both items on one line

- additionally added an empty line above line above the second empty line
include:
(...)unt %]","[% o.claimed_date %]"

[% INCLUDE empty_line.inc %]
[%- END -%]
,,Total orders in late, [% orders.size %]

-> CSV-Export OK, 1 header line, 2 lines for 2 orders, 1 line for Total

Result: The trick with the empty line include did not to work.

Then I reseted all, applied the patch again and added the following to the
first and only line of koha-tmpl/intranet-tmpl/prog/en/includes/empty_line.inc
[% '' %]

Result: CSV Export worked as expected (for late orders, English)
Then I tested with a translation and it worked as well.

-- 
You are receiving this mail because:
You are watching all bug changes.