[Koha-bugs] [Bug 18732] Noisy t/ SMS.t triggered by koha_conf.xml without sms_send_config

[bugzilla-daemon at bugs.koha-community.org]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18732

M. Tompsett <mtompset at hotmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|ASSIGNED                    |In Discussion

--- Comment #13 from M. Tompsett <mtompset at hotmail.com> ---
(In reply to Jonathan Druart from comment #11)
> (In reply to Marcel de Rooy from comment #10)
> > (In reply to Jonathan Druart from comment #8)
> > > I do not think the behaviour is correct, C4::SMS::send_sms should just do
> > > nothing if the config is missing.
> > 
> > Could be discussed on another report and perhaps solved. At first glance,
> > the config seems to be something additional not required.
> > This just deals with eliminating a uninit warn.
> 
> Nope, please fix it here.

"Any parameters with a leading underscore are considered private
driver-specific options and will be passed through without alteration.

Any other parameters without a leading underscore will be silently stripped out
and not passed through to the driver." (SMS::Send -
http://search.cpan.org/~adamk/SMS-Send-1.06/lib/SMS/Send.pm)

The configuration file is used to set extraneous parameters based on the
driver. It has nothing to do whether sending a message should be attempted or
not.

In the case of SMS::Send::Test, it won't matter because it is a test driver. 

In the case of driver where it matters, they may not take extra parameters, so
the configuration file is pointless and should be sent.

In the case where it matters, and the extra parameters are needed, the sending
will fail and the warn $@; return; will be triggered.

This patch is correct.

-- 
You are receiving this mail because:
You are watching all bug changes.