[Koha-bugs] [Bug 18254] Remove C4::Items:: GetItemsByBiblioitemnumber call from additem.pl

bugzilla-daemon at bugs.koha-community.org bugzilla-daemon at bugs.koha-community.org
Thu Jun 15 21:08:44 CEST 2017


https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18254

Kyle M Hall <kyle at bywatersolutions.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #62207|0                           |1
        is obsolete|                            |
                 CC|                            |kyle at bywatersolutions.com
             Status|Signed Off                  |Passed QA

Jonathan Druart <jonathan.druart at bugs.koha-community.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Passed QA                   |Pushed to Master

--- Comment #3 from Kyle M Hall <kyle at bywatersolutions.com> ---
Created attachment 64329
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=64329&action=edit
Bug 18254: Remove call to GetItemsByBiblioitemnumber call from additem.pl

The code from additem to delete all the items of a bibliographic record
is very ackward.
This patch simplifies the algorithm and make the code more readable.

Test plan:
Remove all the items of a bibliographic records
If at least 1 item is checked out you should get an error.

No change with the current behavior is expected.

Signed-off-by: Alex Buckley <alexbuckley at catalyst.net.nz>

Signed-off-by: Kyle M Hall <kyle at bywatersolutions.com>

--- Comment #4 from Jonathan Druart <jonathan.druart at bugs.koha-community.org> ---
Pushed to master for 17.11, thanks to everybody involved!

-- 
You are receiving this mail because:
You are watching all bug changes.


More information about the Koha-bugs mailing list