[Koha-bugs] [Bug 18651] Move of checkouts is still not correctly handled

[bugzilla-daemon at bugs.koha-community.org]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18651

DEVINIM <kohadevinim at devinim.com.tr> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |kohadevinim at devinim.com.tr

--- Comment #55 from DEVINIM <kohadevinim at devinim.com.tr> ---
(In reply to Marcel de Rooy from comment #54)
> (In reply to DEVINIM from comment #53)
> > Created attachment 64490 [details] [review] [review]
> > Bug 18651: [QA Follow-up] Fix the MAX(issue_id) calculation
> > 
> > Found this by inserting the same issue_id in old_issues before checkin:
> > The call to ->search( )->get_column is in scalar context and will
> > return the number of results, i.e. always 1.
> > If you have an issue_id 2 in old_issues, it will crash:
> >     DBIx::Class::Storage::DBI::_dbh_execute(): Duplicate entry '2' for key
> > 'PRIMARY'
> > 
> > The fix is fairly simple: Put get_column in list context and pick the first
> > array entry.
> > NOTE: Using DBIx's get_column()->max here might look simpler here.
> > 
> > Signed-off-by: Marcel de Rooy <m.de.rooy at rijksmuseum.nl>
> 
> What's up, DEVINIM ?

Hi Marcel,
So sorry. How can I delete this attachment, I don't know.
Can you tell me?

-- 
You are receiving this mail because:
You are watching all bug changes.