[Koha-bugs] [Bug 18465] Patron card creator: Print on duplex card printer

[bugzilla-daemon at bugs.koha-community.org]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18465

--- Comment #16 from Marc Véron <veron at veron.ch> ---
(In reply to Nick Clemens from comment #15)
> create-pdf.pl
> 
> 135 	#my $print_layout_xml = $layout_back_xml;
> 
> 136 	my $print_layout_xml = (( ($cardscount % 2  == 1) && ( $layout_back_id
> ) ) ?
> 
> 137 	clone($layout_back_xml) : clone($layout_xml) );
> 
> Fist line looks like debug, is Clone being added as a dependency here? can
> we just make a copy?
> 
> Otherwise worked well in testing

- Yes, #135 is a reminder of my tests and superfluous. As far as I remember it
was not possible to have a simple copy like in line 135, that's why I used
clone for a deep copy.

- Clone is used at other places as well (git grep 'use Clone'). Should it be
added to the dependencies? I would propose to do that in a separate bug.

-- 
You are receiving this mail because:
You are watching all bug changes.