[Koha-bugs] [Bug 18799] XSLTresultsdisplay hides the icons

[bugzilla-daemon at bugs.koha-community.org]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18799

Owen Leonard <oleonard at myacpl.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Needs Signoff               |In Discussion
             Status|In Discussion               |Needs Signoff

M. Tompsett <mtompset at hotmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #64327|0                           |1
        is obsolete|                            |
                 CC|                            |mtompset at hotmail.com

--- Comment #10 from Owen Leonard <oleonard at myacpl.org> ---
I think this bug can be fixed in a different way which will be acceptable to
all. I'm preparing an alternate patch.

--- Comment #11 from Owen Leonard <oleonard at myacpl.org> ---
Created attachment 64327
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=64327&action=edit
Alternate patch which preserves status quo on biblio vs. item-level itemtypes

    Bug 18799 [ Alternate ] XSLTresultsdisplay hides the icons

    If item-level_itypes is turned off and  XSLTResultsDisplay is turned on,
    biblio-level itemtype images are not shown in staff client search
    results. This patch corrects the problem.

    This patch also adds some markup and CSS to the itemtype image to make
    it look a litte cleaner and work better in result sets in which some
    titles have images and some don't.

    To test, apply the patch and view the staff client search results page
    with various settings:

    - XSLT turned on and off
    - item-level_itypes turned on and off
    - noItemTypeImages turned on and off

    Confirm that item type images are shown or not shown correctly according
    to each setting.

    The difference between this patch and the other patch currently on this
    bug is that this patch continues the practice of hiding biblio-level
    itemtype information when item-level_itypes is ON.

--- Comment #12 from M. Tompsett <mtompset at hotmail.com> ---
Created attachment 64728
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=64728&action=edit
Alternate patch which preserves status quo on biblio vs. item-level itemtypes

Hopefully this makes Owen's patch a nice patch.

-- 
You are receiving this mail because:
You are watching all bug changes.