From bugzilla-daemon at bugs.koha-community.org Wed Mar 1 00:03:36 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 28 Feb 2017 23:03:36 +0000 Subject: [Koha-bugs] [Bug 3935] Schedule tasks periodically In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=3935 Cab Vinton changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |bibliwho at gmail.com -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Mar 1 00:05:35 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 28 Feb 2017 23:05:35 +0000 Subject: [Koha-bugs] [Bug 1993] Task Scheduler Needs Re-write In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=1993 Cab Vinton changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |bibliwho at gmail.com -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Mar 1 00:10:51 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 28 Feb 2017 23:10:51 +0000 Subject: [Koha-bugs] [Bug 1993] Task Scheduler Needs Re-write In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=1993 --- Comment #49 from Cab Vinton --- This is a minor issue, but trivial to implement once the gory work on the scheduler itself is complete -- When scheduling reports the list of reports in the drop-down menu should be alphabetized. Most libraries have a large inventory of reports, so having them in alphabetical order makes a lot of sense. -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Mar 1 01:05:17 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 01 Mar 2017 00:05:17 +0000 Subject: [Koha-bugs] [Bug 16034] Integration with OverDrive Patron API In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16034 --- Comment #73 from Srdjan Jankovic --- Is there a standard way we skip that kind of tests? -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Mar 1 01:07:38 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 01 Mar 2017 00:07:38 +0000 Subject: [Koha-bugs] [Bug 16588] Remove the Readonly dependency (again) In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16588 --- Comment #31 from Srdjan Jankovic --- (In reply to Jonathan Druart from comment #30) > (In reply to Srdjan Jankovic from comment #29) > > Is there any reason we have BIBLIOS_INDEX and AUTHORITIES_INDEX defined in > > Koha::SearchEngine::Elasticsearch? > > Where do you want to have them defined? Well they are already defined with the same values in Koha::SearchEngine. I just wanted to know if they relate to the same thing. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Mar 1 03:05:10 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 01 Mar 2017 02:05:10 +0000 Subject: [Koha-bugs] [Bug 14576] Allow arbitrary automatic update of location on checkin In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14576 --- Comment #48 from Nick Clemens --- Created attachment 60747 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=60747&action=edit Bug 14576 (QA Followup) Remove C4:::Items::ShelfToCart -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Mar 1 03:05:18 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 01 Mar 2017 02:05:18 +0000 Subject: [Koha-bugs] [Bug 14576] Allow arbitrary automatic update of location on checkin In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14576 --- Comment #49 from Nick Clemens --- Created attachment 60748 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=60748&action=edit Bug 14576 (QA Followup) Fix issue.t -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Mar 1 03:07:27 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 01 Mar 2017 02:07:27 +0000 Subject: [Koha-bugs] [Bug 14576] Allow arbitrary automatic update of location on checkin In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14576 --- Comment #50 from Nick Clemens --- (In reply to Jonathan Druart from comment #47) > C4::Items::ShelfToCart is no longer in used. Removed > Tests do not pass. Indeed, Returns.t is failing, but I have no idea why - the expected and received warning look the same to me - I will try again tomorrow -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Mar 1 03:46:40 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 01 Mar 2017 02:46:40 +0000 Subject: [Koha-bugs] [Bug 9988] Leave larger authority merges to merge_authorities cronjob ( pref AuthorityMergeLimit) In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9988 David Cook changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |dcook at prosentient.com.au --- Comment #38 from David Cook --- Sounds like another use case for having a task scheduler and message queue in the background... -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Mar 1 04:30:15 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 01 Mar 2017 03:30:15 +0000 Subject: [Koha-bugs] [Bug 18185] New: Clears loan history Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18185 Bug ID: 18185 Summary: Clears loan history Change sponsored?: --- Product: Koha Version: 16.11 Hardware: All OS: Linux Status: NEW Severity: critical Priority: P5 - low Component: Circulation Assignee: koha-bugs at lists.koha-community.org Reporter: freddyguerr at gmail.com QA Contact: testopia at bugs.koha-community.org CC: gmcharlt at gmail.com, kyle.m.hall at gmail.com When returning an item and reviewing the loan history, it does not appear in the loan history, I use koha v. 16.11, Debian 8. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Wed Mar 1 05:09:39 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 01 Mar 2017 04:09:39 +0000 Subject: [Koha-bugs] [Bug 18185] Clears loan history In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18185 Fred changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |freddyguerr at gmail.com --- Comment #1 from Fred --- Created attachment 60749 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=60749&action=edit Chronology of error Chronology of error in image -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Wed Mar 1 09:12:15 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 01 Mar 2017 08:12:15 +0000 Subject: [Koha-bugs] [Bug 16034] Integration with OverDrive Patron API In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16034 --- Comment #74 from Jonathan Druart --- (In reply to Srdjan Jankovic from comment #73) > Is there a standard way we skip that kind of tests? We already kind of the same thing in C4::Members for the Norvegian specific ft. I guess thing like: use Module::Load::Conditional qw( can_load ); if ( ! can_load( modules => { 'WebService::ILS::OverDrive::Patron' => undef } ) ) { warn "Unable to load WebService::ILS::OverDrive::Patron"; } in place of the use statement would do the trick. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Mar 1 09:30:19 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 01 Mar 2017 08:30:19 +0000 Subject: [Koha-bugs] [Bug 18185] Clears loan history In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18185 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |jonathan.druart at bugs.koha-c | |ommunity.org --- Comment #2 from Jonathan Druart --- Something in the logs? -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Mar 1 11:17:22 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 01 Mar 2017 10:17:22 +0000 Subject: [Koha-bugs] [Bug 10486] Allow external Z39.50 targets to be searched from the OPAC In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10486 --- Comment #107 from Zeno Tajoli --- Hi to all, I have same update. 1)With new bugfix of bug 17871 now you can install PazPar2 and Zebra on the same server. 2) I have update my howto on the topic: https://wiki.koha-community.org/wiki/PazPar_to_search_external_Z39_50_on_OPAC 3)In the last year we have many discusion inside my firm in what is proprietary and what not, but now a news: they said me that I will have a definitve answer for 06-March-2017. Bye Zeno Tajoli -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Mar 1 11:24:40 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 01 Mar 2017 10:24:40 +0000 Subject: [Koha-bugs] [Bug 17992] REST api: Cities controller should not use ->unblessed In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17992 Matthias Meusburger changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #59548|0 |1 is obsolete| | --- Comment #2 from Matthias Meusburger --- Created attachment 60750 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=60750&action=edit Bug 17992: REST api: Remove the use of ->unblessed from Cities controller As bug 17932 adds TO_JSON to Koha::Object(s), there's no need for using it. Also, as this is a reference implementation for developers to copy and paste it is sensible to make this change even when this is not causing any bug. To test: - Apply the patch - Run: $ sudo koha-shell kohadev k$ cd kohaclone k$ prove t/db_dependent/api/v1/cities.t => SUCCESS: Tests still pass! - Sign off :-D Signed-off-by: Matthias Meusburger -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Mar 1 11:25:10 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 01 Mar 2017 10:25:10 +0000 Subject: [Koha-bugs] [Bug 17992] REST api: Cities controller should not use ->unblessed In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17992 Matthias Meusburger changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off CC| |matthias.meusburger at biblibr | |e.com -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Mar 1 11:41:41 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 01 Mar 2017 10:41:41 +0000 Subject: [Koha-bugs] [Bug 14576] Allow arbitrary automatic update of location on checkin In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14576 --- Comment #51 from Nick Clemens --- Created attachment 60751 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=60751&action=edit Bug 14576 - (QA Followup) Fix Returns.t Two warnings, not one -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Mar 1 11:41:36 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 01 Mar 2017 10:41:36 +0000 Subject: [Koha-bugs] [Bug 14576] Allow arbitrary automatic update of location on checkin In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14576 Nick Clemens changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |Signed Off -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Mar 1 11:41:59 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 01 Mar 2017 10:41:59 +0000 Subject: [Koha-bugs] [Bug 13920] API authentication system - proposal In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13920 --- Comment #30 from Olli-Antti Kivilahti --- tcohen and ashimema are cooking something as we speak. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Mar 1 12:16:05 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 01 Mar 2017 11:16:05 +0000 Subject: [Koha-bugs] [Bug 18186] New: Amounts with decimal comma instead of decimal dot breaking payments Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18186 Bug ID: 18186 Summary: Amounts with decimal comma instead of decimal dot breaking payments Change sponsored?: --- Product: Koha Version: 3.22 Hardware: All OS: All Status: NEW Severity: major Priority: P5 - low Component: Circulation Assignee: koha-bugs at lists.koha-community.org Reporter: katrin.fischer at bsz-bw.de QA Contact: testopia at bugs.koha-community.org CC: gmcharlt at gmail.com, kyle.m.hall at gmail.com In our current installations running under Plack, the amounts on the pay and paycollect pages suddenly started showing with a decimal comma instead of a decimal point. This causes quite a bit of trouble, as Koha expects a . and amounts entered didn't result in the expected payments. We got several reports about payments being broken in Koha. Test plan: - Add manual invoice - View the "fines" tag - Verify that individual fees and totals display with , instead of . - Pay selected or any amount - Verify that the input field for the amount is also showing the , - Verify that paying something like 1,10 doesn't work as expected. The problem with the test plan is, that you might not see the ,. This appears only on our productions servers, but not in my development environment. We tested: - different language settings in Koha - different language settings in the browser - verified that CurrencyFormat isn't used in the code on those page - verified that all the formatting done was using the TT filter format('%.2f') In the end the problem turned out to be related to Plack. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Mar 1 12:25:06 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 01 Mar 2017 11:25:06 +0000 Subject: [Koha-bugs] [Bug 18186] Amounts with decimal comma instead of decimal dot breaking payments In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18186 Mirko Tietgen changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |mirko at abunchofthings.net -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Mar 1 12:26:21 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 01 Mar 2017 11:26:21 +0000 Subject: [Koha-bugs] [Bug 14365] SQL Reports Last Edit Date column In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14365 --- Comment #5 from Kyle M Hall --- Created attachment 60752 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=60752&action=edit Bug 14365 - Change 'Last modified' to 'Last edit' for terseness -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Mar 1 13:05:07 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 01 Mar 2017 12:05:07 +0000 Subject: [Koha-bugs] [Bug 18144] Removal of persona broke openidconnect In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18144 M. Tompsett changed: What |Removed |Added ---------------------------------------------------------------------------- Severity|normal |critical --- Comment #2 from M. Tompsett --- Increasing priority, as a broken authentication method is kind of important to fix. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Mar 1 13:11:24 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 01 Mar 2017 12:11:24 +0000 Subject: [Koha-bugs] [Bug 17992] REST api: Cities controller should not use ->unblessed In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17992 Marcel de Rooy changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA Patch complexity|--- |Small patch -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Mar 1 13:11:26 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 01 Mar 2017 12:11:26 +0000 Subject: [Koha-bugs] [Bug 17992] REST api: Cities controller should not use ->unblessed In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17992 Marcel de Rooy changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #60750|0 |1 is obsolete| | --- Comment #3 from Marcel de Rooy --- Created attachment 60753 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=60753&action=edit Bug 17992: REST api: Remove the use of ->unblessed from Cities controller As bug 17932 adds TO_JSON to Koha::Object(s), there's no need for using it. Also, as this is a reference implementation for developers to copy and paste it is sensible to make this change even when this is not causing any bug. To test: - Apply the patch - Run: $ sudo koha-shell kohadev k$ cd kohaclone k$ prove t/db_dependent/api/v1/cities.t => SUCCESS: Tests still pass! - Sign off :-D Signed-off-by: Matthias Meusburger Signed-off-by: Marcel de Rooy -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Mar 1 13:11:36 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 01 Mar 2017 12:11:36 +0000 Subject: [Koha-bugs] [Bug 17992] REST api: Cities controller should not use ->unblessed In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17992 Marcel de Rooy changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |m.de.rooy at rijksmuseum.nl QA Contact|testopia at bugs.koha-communit |m.de.rooy at rijksmuseum.nl |y.org | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Mar 1 13:41:54 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 01 Mar 2017 12:41:54 +0000 Subject: [Koha-bugs] [Bug 18187] New: finishreceive.pl: Save bookseller name into items acquisition source field Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18187 Bug ID: 18187 Summary: finishreceive.pl: Save bookseller name into items acquisition source field Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Acquisitions Assignee: koha-bugs at lists.koha-community.org Reporter: m.de.rooy at rijksmuseum.nl QA Contact: testopia at bugs.koha-community.org -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Mar 1 13:50:22 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 01 Mar 2017 12:50:22 +0000 Subject: [Koha-bugs] [Bug 18188] New: Working title Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18188 Bug ID: 18188 Summary: Working title Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Architecture, internals, and plumbing Assignee: gmcharlt at gmail.com Reporter: m.de.rooy at rijksmuseum.nl QA Contact: testopia at bugs.koha-community.org -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Mar 1 14:03:12 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 01 Mar 2017 13:03:12 +0000 Subject: [Koha-bugs] [Bug 18187] finishreceive.pl: Save bookseller name into items acquisition source field In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18187 --- Comment #1 from Marcel de Rooy --- Created attachment 60754 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=60754&action=edit Bug 18187: finishreceive.pl: Save bookseller name into items acquisition source field Currently, finishreceive saves the literal booksellerid (a number) into the item text field labeled as "Source of acquisition", unfortunately called booksellerid. (This is the case for AcqCreateItem == receiving.) I opened up another report for renaming this item field (18188). On this report we make finishreceive.pl save the name of the bookseller into the item field. This is more informative. But I could imagine that we need a broader solution: [1] Do we really always want that information in an item? [2] Should orderreceive not put this information in the item field? Now we postpone that to finishreceive; finishreceive just overwrites these fields, completely ignoring what was there. Any feedback is welcome. Test plan: [1] Set AcqCreateItem to receiving. [2] Receive an order. Check 952$e in the resulting item. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Mar 1 14:03:10 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 01 Mar 2017 13:03:10 +0000 Subject: [Koha-bugs] [Bug 18187] finishreceive.pl: Save bookseller name into items acquisition source field In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18187 Marcel de Rooy changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff Patch complexity|--- |Trivial patch -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Wed Mar 1 14:03:22 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 01 Mar 2017 13:03:22 +0000 Subject: [Koha-bugs] [Bug 18187] finishreceive.pl: Save bookseller name into items acquisition source field In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18187 Marcel de Rooy changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|koha-bugs at lists.koha-commun |m.de.rooy at rijksmuseum.nl |ity.org | -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Wed Mar 1 14:05:02 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 01 Mar 2017 13:05:02 +0000 Subject: [Koha-bugs] [Bug 18188] Should we rename items.booksellerid to items.acqsource ? In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18188 Marcel de Rooy changed: What |Removed |Added ---------------------------------------------------------------------------- Summary|Working title |Should we rename | |items.booksellerid to | |items.acqsource ? -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Mar 1 14:14:12 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 01 Mar 2017 13:14:12 +0000 Subject: [Koha-bugs] [Bug 18188] Should we rename items.booksellerid to items.acqsource ? In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18188 --- Comment #1 from Marcel de Rooy --- See also bug 18187. This field in items is labeled as Source of acquisition. Since it is a free text field, we can imagine that any information may be entered into this field. You could e.g. also enter a name of someone who donated a book. Unfortunately its literal name is booksellerid. Originally, it may have been the intention to really save the booksellerid; but making it an editable text field was a bad choice. Note: MARC21 maps 952$e to booksellerid, French UNIMARC maps 995a to it. Would you agree with renaming the field to acqsource? -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Mar 1 14:18:18 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 01 Mar 2017 13:18:18 +0000 Subject: [Koha-bugs] [Bug 18188] Should we rename items.booksellerid to items.acqsource ? In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18188 Marcel de Rooy changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on| |18187 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18187 [Bug 18187] finishreceive.pl: Save bookseller name into items acquisition source field -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Mar 1 14:18:18 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 01 Mar 2017 13:18:18 +0000 Subject: [Koha-bugs] [Bug 18187] finishreceive.pl: Save bookseller name into items acquisition source field In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18187 Marcel de Rooy changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |18188 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18188 [Bug 18188] Should we rename items.booksellerid to items.acqsource ? -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Mar 1 14:47:40 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 01 Mar 2017 13:47:40 +0000 Subject: [Koha-bugs] [Bug 18068] Elasticsearch (ES): Location and (home|holding) branch facets mixed In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18068 Nick Clemens changed: What |Removed |Added ---------------------------------------------------------------------------- Summary|ES: Location and |Elasticsearch (ES): |(home|holding)branch facets |Location and |mixed |(home|holding)branch facets | |mixed -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Mar 1 15:01:13 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 01 Mar 2017 14:01:13 +0000 Subject: [Koha-bugs] [Bug 15707] Add ability to define hierarchical groups of libraries In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15707 Kyle M Hall changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #60573|0 |1 is obsolete| | Attachment #60574|0 |1 is obsolete| | Attachment #60575|0 |1 is obsolete| | Attachment #60576|0 |1 is obsolete| | Attachment #60577|0 |1 is obsolete| | Attachment #60578|0 |1 is obsolete| | Attachment #60579|0 |1 is obsolete| | Attachment #60580|0 |1 is obsolete| | Attachment #60581|0 |1 is obsolete| | Attachment #60582|0 |1 is obsolete| | Attachment #60583|0 |1 is obsolete| | Attachment #60584|0 |1 is obsolete| | Attachment #60585|0 |1 is obsolete| | Attachment #60586|0 |1 is obsolete| | Attachment #60587|0 |1 is obsolete| | --- Comment #149 from Kyle M Hall --- Created attachment 60755 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=60755&action=edit Bug 15707 - Update DB Signed-off-by: Mark Tompsett -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Mar 1 15:02:02 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 01 Mar 2017 14:02:02 +0000 Subject: [Koha-bugs] [Bug 15707] Add ability to define hierarchical groups of libraries In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15707 Kyle M Hall changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |Signed Off -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Mar 1 15:02:07 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 01 Mar 2017 14:02:07 +0000 Subject: [Koha-bugs] [Bug 15707] Add ability to define hierarchical groups of libraries In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15707 Kyle M Hall changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #60755|0 |1 is obsolete| | --- Comment #150 from Kyle M Hall --- Created attachment 60756 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=60756&action=edit Bug 15707 - Update DB Signed-off-by: Mark Tompsett -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Mar 1 15:02:18 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 01 Mar 2017 14:02:18 +0000 Subject: [Koha-bugs] [Bug 15707] Add ability to define hierarchical groups of libraries In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15707 --- Comment #151 from Kyle M Hall --- Created attachment 60757 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=60757&action=edit Bug 15707 - Add new modules Signed-off-by: Mark Tompsett -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Mar 1 15:02:24 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 01 Mar 2017 14:02:24 +0000 Subject: [Koha-bugs] [Bug 15707] Add ability to define hierarchical groups of libraries In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15707 --- Comment #152 from Kyle M Hall --- Created attachment 60758 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=60758&action=edit Bug 15707 - Add editor Signed-off-by: Mark Tompsett -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Mar 1 15:02:29 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 01 Mar 2017 14:02:29 +0000 Subject: [Koha-bugs] [Bug 15707] Add ability to define hierarchical groups of libraries In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15707 --- Comment #153 from Kyle M Hall --- Created attachment 60759 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=60759&action=edit Bug 15707 - Unit Tests Signed-off-by: Mark Tompsett -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Mar 1 15:02:34 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 01 Mar 2017 14:02:34 +0000 Subject: [Koha-bugs] [Bug 15707] Add ability to define hierarchical groups of libraries In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15707 --- Comment #154 from Kyle M Hall --- Created attachment 60760 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=60760&action=edit Bug 15707: Fix conflict with bug 15446 (type vs _type) -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Mar 1 15:02:40 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 01 Mar 2017 14:02:40 +0000 Subject: [Koha-bugs] [Bug 15707] Add ability to define hierarchical groups of libraries In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15707 --- Comment #155 from Kyle M Hall --- Created attachment 60761 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=60761&action=edit Bug 15707 [QA Followup] - Switch to treetable which Koha already uses -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Mar 1 15:02:46 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 01 Mar 2017 14:02:46 +0000 Subject: [Koha-bugs] [Bug 15707] Add ability to define hierarchical groups of libraries In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15707 --- Comment #156 from Kyle M Hall --- Created attachment 60762 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=60762&action=edit Bug 15707: QA follow-up - Drop table if exists 1/ DROP table if exists 2/ FAIL spelling decendents ==> descendants -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Mar 1 15:02:51 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 01 Mar 2017 14:02:51 +0000 Subject: [Koha-bugs] [Bug 15707] Add ability to define hierarchical groups of libraries In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15707 --- Comment #157 from Kyle M Hall --- Created attachment 60763 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=60763&action=edit Bug 15707 [QA Followup] - Fix UI issues -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Mar 1 15:02:57 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 01 Mar 2017 14:02:57 +0000 Subject: [Koha-bugs] [Bug 15707] Add ability to define hierarchical groups of libraries In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15707 --- Comment #158 from Kyle M Hall --- Created attachment 60764 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=60764&action=edit Bug 15707 [QA Followup] - Remove class for treegrid -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Mar 1 15:03:03 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 01 Mar 2017 14:03:03 +0000 Subject: [Koha-bugs] [Bug 15707] Add ability to define hierarchical groups of libraries In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15707 --- Comment #159 from Kyle M Hall --- Created attachment 60765 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=60765&action=edit Bug 15707 [QA Followup] - Allow object names to be styled without impeding translation -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Mar 1 15:03:09 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 01 Mar 2017 14:03:09 +0000 Subject: [Koha-bugs] [Bug 15707] Add ability to define hierarchical groups of libraries In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15707 --- Comment #160 from Kyle M Hall --- Created attachment 60766 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=60766&action=edit Bug 15707 - Update Schema Files -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Mar 1 15:03:14 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 01 Mar 2017 14:03:14 +0000 Subject: [Koha-bugs] [Bug 15707] Add ability to define hierarchical groups of libraries In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15707 --- Comment #161 from Kyle M Hall --- Created attachment 60767 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=60767&action=edit Bug 15707: Followup - use cat-search instead of cities-search in header -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Mar 1 15:03:19 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 01 Mar 2017 14:03:19 +0000 Subject: [Koha-bugs] [Bug 15707] Add ability to define hierarchical groups of libraries In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15707 --- Comment #162 from Kyle M Hall --- Created attachment 60768 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=60768&action=edit Bug 15707 - Switch datetimes to timestamps -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Mar 1 15:03:25 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 01 Mar 2017 14:03:25 +0000 Subject: [Koha-bugs] [Bug 15707] Add ability to define hierarchical groups of libraries In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15707 --- Comment #163 from Kyle M Hall --- Created attachment 60769 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=60769&action=edit Bug 15707 - Add UNIQUE constraint to library groups table -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Mar 1 15:03:30 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 01 Mar 2017 14:03:30 +0000 Subject: [Koha-bugs] [Bug 15707] Add ability to define hierarchical groups of libraries In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15707 --- Comment #164 from Kyle M Hall --- Created attachment 60770 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=60770&action=edit Bug 15707 - Updates for Bootstrap 3 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Mar 1 15:03:37 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 01 Mar 2017 14:03:37 +0000 Subject: [Koha-bugs] [Bug 15707] Add ability to define hierarchical groups of libraries In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15707 --- Comment #165 from Kyle M Hall --- Created attachment 60771 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=60771&action=edit Bug 15707 - Display error if group title is already used -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Mar 1 15:08:25 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 01 Mar 2017 14:08:25 +0000 Subject: [Koha-bugs] [Bug 16735] Replace existing library search groups functionality with the new hierarchical groups system In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16735 Kyle M Hall changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #60497|0 |1 is obsolete| | Attachment #60498|0 |1 is obsolete| | Attachment #60499|0 |1 is obsolete| | Attachment #60500|0 |1 is obsolete| | Attachment #60501|0 |1 is obsolete| | Attachment #60502|0 |1 is obsolete| | Attachment #60503|0 |1 is obsolete| | --- Comment #32 from Kyle M Hall --- Created attachment 60772 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=60772&action=edit Bug 16735 - Remove modules no longer needed Signed-off-by: Josef Moravec -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Mar 1 15:08:34 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 01 Mar 2017 14:08:34 +0000 Subject: [Koha-bugs] [Bug 16735] Replace existing library search groups functionality with the new hierarchical groups system In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16735 --- Comment #33 from Kyle M Hall --- Created attachment 60773 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=60773&action=edit Bug 16735 - Remove tables no longer needed Signed-off-by: Josef Moravec -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Mar 1 15:08:39 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 01 Mar 2017 14:08:39 +0000 Subject: [Koha-bugs] [Bug 16735] Replace existing library search groups functionality with the new hierarchical groups system In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16735 --- Comment #34 from Kyle M Hall --- Created attachment 60774 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=60774&action=edit Bug 16735 - Clean up sample data Signed-off-by: Josef Moravec -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Mar 1 15:08:43 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 01 Mar 2017 14:08:43 +0000 Subject: [Koha-bugs] [Bug 16735] Replace existing library search groups functionality with the new hierarchical groups system In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16735 --- Comment #35 from Kyle M Hall --- Created attachment 60775 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=60775&action=edit Bug 16735 - Replace existing library search groups functionality with the new hierarchical groups system Test Plan: 1) Apply this patch set 2) Note your existing search groups have been ported over to the new __SEARCH_GROUPS__ group if you had any 3) Create the group __SEARCH_GROUPS__ if one does not already exist 4) Add some first level subgroups to this group, add libraries to those groups 5) Search the library group searching in the intranet and opac 6) Note you get the same results as pre-patch Signed-off-by: Josef Moravec -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Mar 1 15:08:48 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 01 Mar 2017 14:08:48 +0000 Subject: [Koha-bugs] [Bug 16735] Replace existing library search groups functionality with the new hierarchical groups system In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16735 --- Comment #36 from Kyle M Hall --- Created attachment 60776 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=60776&action=edit Bug 16735 - Don't use objects for database update -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Mar 1 15:08:52 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 01 Mar 2017 14:08:52 +0000 Subject: [Koha-bugs] [Bug 16735] Replace existing library search groups functionality with the new hierarchical groups system In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16735 --- Comment #37 from Kyle M Hall --- Created attachment 60777 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=60777&action=edit Bug 16735 - Remove use of get_categories Feature using it is completely undocumented as far as my research has shown. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Mar 1 15:08:55 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 01 Mar 2017 14:08:55 +0000 Subject: [Koha-bugs] [Bug 16735] Replace existing library search groups functionality with the new hierarchical groups system In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16735 --- Comment #38 from Kyle M Hall --- Created attachment 60778 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=60778&action=edit Bug 16735 - Filter individual libraries from search group pulldown -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Mar 1 15:08:59 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 01 Mar 2017 14:08:59 +0000 Subject: [Koha-bugs] [Bug 16735] Replace existing library search groups functionality with the new hierarchical groups system In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16735 --- Comment #39 from Kyle M Hall --- Created attachment 60779 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=60779&action=edit Bug 16735 - Filter groups without immediate child libraries from group pulldown -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Mar 1 15:09:51 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 01 Mar 2017 14:09:51 +0000 Subject: [Koha-bugs] [Bug 15707] Add ability to define hierarchical groups of libraries In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15707 --- Comment #166 from Kyle M Hall --- (In reply to Jonathan Druart from comment #146) > - Empty groups (without libraries) are displayed in the adv search form, I > do not think they should. Fixed! > - If Search groups contain several levels of subgroups, only the first one > will be used. Not sure it's the expected behaviour. > > Example: > __SEARCH_GROUP__ > Group 1 > Library 1 > Subgroup > Library 2 > > Search on "Group 1" will search in library 1. That is expected behavior and will be documented in the manual. There is no additional utility for this particular feature to sub-groups. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Mar 1 15:10:20 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 01 Mar 2017 14:10:20 +0000 Subject: [Koha-bugs] [Bug 16735] Replace existing library search groups functionality with the new hierarchical groups system In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16735 --- Comment #40 from Kyle M Hall --- (In reply to Jonathan Druart from comment #31) > (In reply to Jonathan Druart from comment #29) > > You should also add the btn-default class to the buttons to make them look > > like other Koha buttons. > > This is still valid. Fixed! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Mar 1 15:33:03 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 01 Mar 2017 14:33:03 +0000 Subject: [Koha-bugs] [Bug 18189] New: Elasticsearch sorting broken Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18189 Bug ID: 18189 Summary: Elasticsearch sorting broken Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Searching Assignee: gmcharlt at gmail.com Reporter: nick at bywatersolutions.com QA Contact: testopia at bugs.koha-community.org Current setting in elasticsearch mapping use 'text' type for sort fields, this seems like extra overhead. If the fields are only used for sorting we can index them as 'keyword' (exact phrase) and this has the side effect of fixing sorting -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Mar 1 15:37:23 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 01 Mar 2017 14:37:23 +0000 Subject: [Koha-bugs] [Bug 18189] Elasticsearch sorting broken In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18189 --- Comment #1 from Nick Clemens --- Created attachment 60780 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=60780&action=edit Bug 18189 - Elasticsearch sorting broken To test: 1 - Have ES enabled and biblios and authorities indexed 2 - Perform a catalog search 3 - Try to sort results by author, it will fail 4 - Perform an authority search with sorting enabled, it will fail 5 - Apply patch 6 - Reindex, deleting current indexes perl /home/vagrant/kohaclone/misc/search_tools/rebuild_elastic_search.pl -d -v 7 - Repeat 3&4, they should succeed -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Mar 1 15:37:19 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 01 Mar 2017 14:37:19 +0000 Subject: [Koha-bugs] [Bug 18189] Elasticsearch sorting broken In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18189 Nick Clemens changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff Patch complexity|--- |Trivial patch -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Mar 1 15:41:21 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 01 Mar 2017 14:41:21 +0000 Subject: [Koha-bugs] [Bug 7534] New OPACAllowUserToChooseBranch setting for only showing libraries allowing holds In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7534 Lari Taskula changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #60022|0 |1 is obsolete| | --- Comment #13 from Lari Taskula --- Created attachment 60781 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=60781&action=edit Bug 7534: Display pickup locations instead of all libraries in opac-reserve.pl This patch sets opac-reserve.tt to use the list of pickup libraries instead of every library in the system. To test: 1. Go to cgi-bin/koha/admin/branches.pl 2. Configure one of your libraries to "Pickup location" => "No" 3. Go to OPAC and place a hold 4. See the provided Pickup location list 5. Observe the library that you configured is not present in the list -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Mar 1 15:42:27 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 01 Mar 2017 14:42:27 +0000 Subject: [Koha-bugs] [Bug 18189] Elasticsearch sorting broken In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18189 Nick Clemens changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|gmcharlt at gmail.com |nick at bywatersolutions.com --- Comment #2 from Nick Clemens --- Note this won't fix all sorting options unless they are defined as sortable in the config. acqdate fails out of the box - set acqdate as sortable - reindex - it should now work I suppose we either don't allow altering sortability for some fields, or the dropdown must populate based on what is defined as sortable. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Mar 1 15:43:17 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 01 Mar 2017 14:43:17 +0000 Subject: [Koha-bugs] [Bug 7534] New OPACAllowUserToChooseBranch setting for only showing libraries allowing holds In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7534 --- Comment #14 from Lari Taskula --- (In reply to Chris Kirby from comment #12) > Applying patches, failed to merge changes for > "Bug 7534: Display pickup locations instead of all libraries in > opac-reserve.pl" > > Failed to merge in changes. Thanks for reporting! I fixed the conflict as promised yesterday in IRC. Does it apply now? -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Wed Mar 1 15:49:41 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 01 Mar 2017 14:49:41 +0000 Subject: [Koha-bugs] [Bug 18072] Add Koha objects for Branch Transfer Limits In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18072 Lari Taskula changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #60011|0 |1 is obsolete| | --- Comment #13 from Lari Taskula --- Created attachment 60782 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=60782&action=edit Bug 18072: Add Koha::Item->can_be_transferred This patch adds a new method Koha::Item->can_be_transferred. Includes unit test. To test: 1. prove t/db_dependent/Koha/Items.t Signed-off-by: Josef Moravec -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Mar 1 15:51:14 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 01 Mar 2017 14:51:14 +0000 Subject: [Koha-bugs] [Bug 18072] Add Koha objects for Branch Transfer Limits In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18072 Lari Taskula changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #60116|0 |1 is obsolete| | --- Comment #14 from Lari Taskula --- Created attachment 60783 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=60783&action=edit Bug 18072: (QA-follow-up) let Koha::Item->can_be_transferred take HASHref as param This patch changes Koha::Item->can_be_transferred to accept a HASHref as follows: $item->can_be_transferred({ to => $library, from => $library2 }) To test: 1. prove t/db_dependent/Koha/Items.t -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Mar 1 15:51:27 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 01 Mar 2017 14:51:27 +0000 Subject: [Koha-bugs] [Bug 18072] Add Koha objects for Branch Transfer Limits In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18072 Lari Taskula changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #60117|0 |1 is obsolete| | --- Comment #15 from Lari Taskula --- Created attachment 60784 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=60784&action=edit Bug 18072: Add Koha::Biblio->can_be_transferred This patch adds a new method Koha::Biblio->can_be_transferred. The method checks if at least one of the item of that biblio can be transferred to desired location. This method will be useful for building a smarter pickup location list for holds, because we will be able to hide those libraries to which none of the items of this biblio can be transferred to due to branch transfer limits (see Bug 7614). To test: 1. prove t/db_dependent/Koha/Biblios.t -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Mar 1 15:51:45 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 01 Mar 2017 14:51:45 +0000 Subject: [Koha-bugs] [Bug 18072] Add Koha objects for Branch Transfer Limits In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18072 --- Comment #16 from Lari Taskula --- Rebased on top of current master. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Mar 1 15:55:10 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 01 Mar 2017 14:55:10 +0000 Subject: [Koha-bugs] [Bug 7614] Branch transfer limit and holds In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7614 Lari Taskula changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #60143|0 |1 is obsolete| | --- Comment #10 from Lari Taskula --- Created attachment 60785 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=60785&action=edit Bug 7614: Check branch transfer limits in opac-reserve.pl -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Mar 1 15:55:25 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 01 Mar 2017 14:55:25 +0000 Subject: [Koha-bugs] [Bug 7614] Branch transfer limit and holds In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7614 Lari Taskula changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #60144|0 |1 is obsolete| | --- Comment #11 from Lari Taskula --- Created attachment 60786 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=60786&action=edit Bug 7614: Consider transfer limits in Koha::Template::Plugin::Branches Consider transfer limits in Koha::Template::Plugin::Branches->pickup_locations. This patch modified the mentioned method to consider branch transfer limits and does not include any library in the returned list of libraries in case a branch transfer limit applies for a given book or item. To be tested in following patches. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Mar 1 15:55:45 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 01 Mar 2017 14:55:45 +0000 Subject: [Koha-bugs] [Bug 7614] Branch transfer limit and holds In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7614 Lari Taskula changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #60145|0 |1 is obsolete| | --- Comment #12 from Lari Taskula --- Created attachment 60787 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=60787&action=edit Bug 7614: Build a list of pickup locations in OPAC considering transfer limits This patch enables the checks for transfer limits for given biblionumber in OPAC when patron proceeds to place a hold. In case none of the items of that biblio can be transferred to a library, that library will not be included in the list of pickup locations. To test: 1. Make sure you meet the following requirements: 1.1: You are able to make holds in OPAC 1.2: System preference UseBranchTransferLimits set to "Enforce" 1.3: System preference BranchTransferLimitsType set to "item type" (for the sake of simplicity of this test plan, but you may also set it to "collection code" and deal with ccodes instead) 1.4: System preference item-level_itypes set to "specific item" 1.5: You have the default libraries and item types, otherwise replace the branchcodes and itemtypes in this test plan with your own 2. Make sure 'Fairfield' in cgi-bin/koha/admin/branches.pl has not disabled its ability to act as a "Pickup location" 3. Have a biblio with exactly one item of item-level itemtype 'BK' 4. Set item holdingbranch as 'CPL' 5. Go to cgi-bin/koha/admin/branch_transfer_limits.pl (keep this page open in a second tab for faster testing) 6. Select library 'Centerville' 7. Uncheck the checkbox 'FFL - Fairfield' and click Save 8. Go to OPAC and find your biblio, and start placing a hold on it 9. Click at the list of "Pick up location"s. 10. Observe that it is missing 'Fairfield' 11. Go back to cgi-bin/koha/admin/branch_transfer_limits.pl 12. Repeat step 6 and this time, check the checkbox 'FFL - Fairfield' 13. Refresh the page you arrived at step 8 14. Observe that it now includes 'Fairfield' -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Mar 1 15:59:06 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 01 Mar 2017 14:59:06 +0000 Subject: [Koha-bugs] [Bug 18137] REST API: Migrate from Mojolicious::Plugin:: Swagger2 to Mojolicious::Plugin::OpenAPI In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18137 --- Comment #10 from Lari Taskula --- I would like to point out that I am experiencing an issue with JSON::Validator, where $refs are sometimes left unresolved in our spec and it causes some error messages and crashes. This issue is being tracked at https://github.com/jhthorsen/json-validator/pull/52. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Mar 1 16:01:50 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 01 Mar 2017 15:01:50 +0000 Subject: [Koha-bugs] =?utf-8?q?=5BBug_18190=5D_New=3A_the_=22Delete=22__ac?= =?utf-8?q?tion_on_Home_=E2=80=BA_Reports_=E2=80=BA_Guided_reports_wizard_?= =?utf-8?q?=E2=80=BA_Saved_reports_should_hide_reports_rather_than_deletin?= =?utf-8?q?g_them?= Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18190 Bug ID: 18190 Summary: the "Delete" action on Home ? Reports ? Guided reports wizard ? Saved reports should hide reports rather than deleting them Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Reports Assignee: gmcharlt at gmail.com Reporter: barton at bywatersolutions.com QA Contact: testopia at bugs.koha-community.org Reports in the 'saved_sql' don't hold sensitive information, and they're not large. It is entirely possible for staff members to accidentally delete reports, which then requires the reports to be restored from backups (assuming that a backup has even been made). If we could hide the reports rather than deleting them, that would make it easier to recover in this situation. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Mar 1 16:05:26 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 01 Mar 2017 15:05:26 +0000 Subject: [Koha-bugs] =?utf-8?q?=5BBug_14772=5D__Remove_or_clarify_checkbox?= =?utf-8?q?_=C2=ABflagged=C2=BB_on_subfield_visibility_frameworks?= In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14772 Marcel de Rooy changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |m.de.rooy at rijksmuseum.nl, | |mtompset at hotmail.com --- Comment #1 from Marcel de Rooy --- See also bug 15870/11592. As far as I can tell, there is no difference between -8 (flagged) and 8 (all checkboxes are unchecked). -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Wed Mar 1 16:12:27 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 01 Mar 2017 15:12:27 +0000 Subject: [Koha-bugs] [Bug 18191] New: REST API: Add endpoint to list valid pickup locations Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18191 Bug ID: 18191 Summary: REST API: Add endpoint to list valid pickup locations Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Web services Assignee: koha-bugs at lists.koha-community.org Reporter: lari.taskula at jns.fi QA Contact: testopia at bugs.koha-community.org Bug 7534, Bug 7614 and Bug 18072 let us limit the choices of pickup location when placing a hold. Add a REST API endpoint that uses this functionality. GET /biblios/{biblionumber}/pickuplocations GET /item/{itemnumber}/pickuplocations Returns an array of library-objects that represent a set of libraries that can be used as pickup locations for hold of the given biblio/item. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Mar 1 16:12:35 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 01 Mar 2017 15:12:35 +0000 Subject: [Koha-bugs] [Bug 18191] REST API: Add endpoint to list valid pickup locations In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18191 Lari Taskula changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|koha-bugs at lists.koha-commun |lari.taskula at jns.fi |ity.org | -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Mar 1 16:17:24 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 01 Mar 2017 15:17:24 +0000 Subject: [Koha-bugs] [Bug 18192] New: Add form for fast changes to tab/ visibility in marc frameworks Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18192 Bug ID: 18192 Summary: Add form for fast changes to tab/visibility in marc frameworks Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: System Administration Assignee: koha-bugs at lists.koha-community.org Reporter: m.de.rooy at rijksmuseum.nl QA Contact: testopia at bugs.koha-community.org CC: gmcharlt at gmail.com It would be nice to have a form where we can quickly change tab/visibility (especially the last one) for a larger number of fields and subfields in a particular framework. Often you want to hide a (sub)field and set tab to -1. Or unhide a (sub)field by restoring tab and setting hidden to 0 (or possibly another value). In order to select fields we could use constructions like: 100|110a|200|300abc etc. Or regexp based: /^1|^20|300[ab]|500a/ etc. And all fields selected, perform a hide or unhide operation. Do you have suggestions about its interface? -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Wed Mar 1 16:19:19 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 01 Mar 2017 15:19:19 +0000 Subject: [Koha-bugs] [Bug 18191] REST API: Add endpoint to list valid pickup locations In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18191 Lari Taskula changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on| |7614, 17371, 16825, 16497 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7614 [Bug 7614] Branch transfer limit and holds https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16497 [Bug 16497] REST API: add routes to list libraries https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16825 [Bug 16825] REST API: Add API route for getting an item https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17371 [Bug 17371] REST API: add CRUD for biblios -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Mar 1 16:19:19 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 01 Mar 2017 15:19:19 +0000 Subject: [Koha-bugs] [Bug 7614] Branch transfer limit and holds In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7614 Lari Taskula changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |18191 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18191 [Bug 18191] REST API: Add endpoint to list valid pickup locations -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Mar 1 16:19:19 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 01 Mar 2017 15:19:19 +0000 Subject: [Koha-bugs] [Bug 16497] REST API: add routes to list libraries In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16497 Lari Taskula changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |18191 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18191 [Bug 18191] REST API: Add endpoint to list valid pickup locations -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Mar 1 16:19:19 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 01 Mar 2017 15:19:19 +0000 Subject: [Koha-bugs] [Bug 16825] REST API: Add API route for getting an item In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16825 Lari Taskula changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |18191 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18191 [Bug 18191] REST API: Add endpoint to list valid pickup locations -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Mar 1 16:19:19 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 01 Mar 2017 15:19:19 +0000 Subject: [Koha-bugs] [Bug 17371] REST API: add CRUD for biblios In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17371 Lari Taskula changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |18191 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18191 [Bug 18191] REST API: Add endpoint to list valid pickup locations -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Mar 1 16:35:39 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 01 Mar 2017 15:35:39 +0000 Subject: [Koha-bugs] [Bug 18193] New: Elasticsearch - adding new records from Z39.50 results in ' internal server error' Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18193 Bug ID: 18193 Summary: Elasticsearch - adding new records from Z39.50 results in 'internal server error' Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Searching Assignee: gmcharlt at gmail.com Reporter: nick at bywatersolutions.com QA Contact: testopia at bugs.koha-community.org To recreate: 1 - Go to cataloging 2 - Select 'New from Z39/50' 3 - Search, find a record, import 4 - Save the record 5 - Error! Checking the logs you should see a dump of the record in xml - Koha chokes trying to access it as a MARC::Record In C4/Search.pm: 2492 If we are using elasticsearch, it'll already be a MARC::Record and this 2493 function needs a new name. 2494 2495 =cut 2496 2497 sub new_record_from_zebra { 2498 2499 my $server = shift; 2500 my $raw_data = shift; 2501 # Set the default indexing modes 2502 my $search_engine = C4::Context->preference("SearchEngine"); 2503 if ($search_engine eq 'Elasticsearch') { 2504 return $raw_data; 2505 } However, that doesn't seem to be the case, we are still getting marc XML, adding "&& 0" to the if and nullifying that section (or removing it) seems to solve the issue -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Mar 1 16:40:04 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 01 Mar 2017 15:40:04 +0000 Subject: [Koha-bugs] [Bug 18194] New: Elasticsearch should be able to add new indexes Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18194 Bug ID: 18194 Summary: Elasticsearch should be able to add new indexes Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Searching Assignee: gmcharlt at gmail.com Reporter: nick at bywatersolutions.com QA Contact: testopia at bugs.koha-community.org Bug 14899 added a configuration page for elastic search indexes. It would be nice to allow for the addition/deletion of indexes as well as their configuration -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Mar 1 17:10:36 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 01 Mar 2017 16:10:36 +0000 Subject: [Koha-bugs] [Bug 7534] New OPACAllowUserToChooseBranch setting for only showing libraries allowing holds In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7534 --- Comment #15 from Chris Kirby --- Conflict is now fixed. Prior to rebase, I ran perl installer/data/mysql/updatedatabase.pl prove t/db_dependent/Template/Plugin/Branches.t results in "All tests successful" However, Going to cgi-bin/koha/admin/branches.pl causes "internal server error". -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Mar 1 17:16:17 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 01 Mar 2017 16:16:17 +0000 Subject: [Koha-bugs] [Bug 18115] Fix use of Objects as hashref in acqui/ addorderiso2709.pl - Bug 15503 followup In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18115 --- Comment #4 from Matthias Meusburger --- With the patch applied, after validating the items informations, I have a "The method gstrate is not covered by tests!" error message. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Mar 1 17:26:18 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 01 Mar 2017 16:26:18 +0000 Subject: [Koha-bugs] [Bug 7534] New OPACAllowUserToChooseBranch setting for only showing libraries allowing holds In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7534 --- Comment #16 from Lari Taskula --- (In reply to Chris Kirby from comment #15) > Conflict is now fixed. > Prior to rebase, I ran perl installer/data/mysql/updatedatabase.pl > > prove t/db_dependent/Template/Plugin/Branches.t results in > "All tests successful" > > However, Going to cgi-bin/koha/admin/branches.pl > causes "internal server error". Thank you for the details. I can't reproduce this issue. Is there a more detailed description of the error in the log files? -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Mar 1 18:20:42 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 01 Mar 2017 17:20:42 +0000 Subject: [Koha-bugs] [Bug 18195] New: Charge for expired holds per patron category Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18195 Bug ID: 18195 Summary: Charge for expired holds per patron category Change sponsored?: --- Product: Koha Version: unspecified Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Hold requests Assignee: koha-bugs at lists.koha-community.org Reporter: sally.healey at cheshiresharedservices.gov.uk QA Contact: testopia at bugs.koha-community.org CC: gmcharlt at gmail.com ExpireReservesMaxPickUpDelayCharge allows one charge to be applied to all holds that expire. However, each patron category can have a unique hold fee. It would be preferable if each patron category could also have a unique 'hold expired' fee, so different patron categories could be charged different amounts (or not at all) for expired holds. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Wed Mar 1 20:38:01 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 01 Mar 2017 19:38:01 +0000 Subject: [Koha-bugs] [Bug 18196] New: Holds Queue table should link to Holds table by reserve_id Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18196 Bug ID: 18196 Summary: Holds Queue table should link to Holds table by reserve_id Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: normal Priority: P5 - low Component: Hold requests Assignee: koha-bugs at lists.koha-community.org Reporter: kyle at bywatersolutions.com QA Contact: testopia at bugs.koha-community.org CC: gmcharlt at gmail.com Now that the 'reserves' table has an id column, it would be nice to link the tmp_holdsqueue table to it using reserves_id as a foreign key. Furthermore, we could require the tmp+holdsqueue column to be unique, as we can only have a single line in tmp_holdsqueue for any given rserve_id. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Wed Mar 1 21:24:22 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 01 Mar 2017 20:24:22 +0000 Subject: [Koha-bugs] [Bug 15030] Certain values in serials' items are lost on next edit In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15030 J Schmidt changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |jschmidt at switchinc.org -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Mar 1 21:55:37 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 01 Mar 2017 20:55:37 +0000 Subject: [Koha-bugs] [Bug 18197] New: Make borrowers-force-messaging-defaults a bit more standard Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18197 Bug ID: 18197 Summary: Make borrowers-force-messaging-defaults a bit more standard Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Command-line Utilities Assignee: gmcharlt at gmail.com Reporter: liz at catalyst.net.nz QA Contact: testopia at bugs.koha-community.org CC: robin at catalyst.net.nz Possible tasks to do: - Make it .pl - give it better help documentation - make sure it's presence is noted in the manual - make it so that optionally, if a borrower has preferences set that don't match the default, that borrower is skipped for re-setting (as they have likely set their preferences). For another time, but just noting it: put a function that does this into the web interface for superlibrarians. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Mar 1 22:04:12 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 01 Mar 2017 21:04:12 +0000 Subject: [Koha-bugs] [Bug 18001] LocalHoldsPriority can cause multiple holds queue lines for same hold request In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18001 George Williams (NEKLS) changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |george at nekls.org -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Mar 1 23:19:28 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 01 Mar 2017 22:19:28 +0000 Subject: [Koha-bugs] [Bug 16834] Changing the "Set Inventory Date to" date doesn't do anything, date last seen always defaults to current date. In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16834 --- Comment #9 from Blou --- Created attachment 60788 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=60788&action=edit Bug 16834 inventory.pl's Set Inventory Date to is ignored When entering a value in "Set Inventory date to" at the top of the UI, this value is ignored and the items are always updated with today. This is (in part) caused by ModDateLastSeen not allowing to set current day. This patch: - Makes relevant the date entered at the top (Set Inventory date to). - Makes relevant the date entered at the bottow (Inventory date). - Doesn't brake most functionalities. - Doesn't fix any of the many other bugs and issues with this broken tool. - remove a warning that was flooding the logs on every call. - Just makes the UI intuitive for common usage regarding dates. TEST: 1) find a barcode in your db, write it in a text file - set item.datelastseen to some date in the past 2) go to tools/inventory 3) Browse to select the file from 1) 4) Select a date (top) before today, and after the datelastseen entered. 5) Click submit. 6) Validate: - Datelastseen specified at the top is the one you entered. - Date Last Seen in the table is the old from the DB - item.datelastseen is now today 7) Apply the patch. Validate: - item.datelastseen is now the date you entered. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Mar 1 23:23:55 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 01 Mar 2017 22:23:55 +0000 Subject: [Koha-bugs] [Bug 16834] Changing the "Set Inventory Date to" date doesn't do anything, date last seen always defaults to current date. In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16834 Blou changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|gmcharlt at gmail.com |philippe.blouin at inlibro.com Status|NEW |Needs Signoff --- Comment #10 from Blou --- This is by no mean a great patch. But our users encountered the problem, and this fixes it. When debugging, I found MANY other issues, but I tried to stay focused on just what was needed for their usage. A complete overhaul would be needed to make this tool intuitive. That's not the goal here. Just get the users the basics they need. If more problem encountered (or side effects), we'll fix... -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Mar 1 23:40:41 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 01 Mar 2017 22:40:41 +0000 Subject: [Koha-bugs] [Bug 18001] LocalHoldsPriority can cause multiple holds queue lines for same hold request In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18001 Joel Sasse changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |jsasse at plumcreeklibrary.net -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Mar 1 23:42:43 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 01 Mar 2017 22:42:43 +0000 Subject: [Koha-bugs] [Bug 7534] New OPACAllowUserToChooseBranch setting for only showing libraries allowing holds In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7534 --- Comment #17 from Chris Kirby --- I don't get the "internal server error" on an old ubuntu system (14.04 LTS) but I DO get it on kohadevbox with a Windows host and Debian Jessie guest. On the Kohadevbox, Debian Jessie, koha-plack-err: Template process failed: undef error- The method pickup_location is not covered by tests! at /usr/share/koha/lib/C4/Templates.pm line 121. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Mar 2 01:33:35 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 02 Mar 2017 00:33:35 +0000 Subject: [Koha-bugs] [Bug 17168] Add a command line script for updating patron category based on status In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17168 Liz Rea changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |liz at catalyst.net.nz --- Comment #8 from Liz Rea --- Hi Nick, I think this exists already in the form of j2a.pl, though it may not be as extensible as this verison. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Mar 2 01:33:43 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 02 Mar 2017 00:33:43 +0000 Subject: [Koha-bugs] [Bug 16034] Integration with OverDrive Patron API In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16034 --- Comment #75 from Srdjan Jankovic --- Created attachment 60789 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=60789&action=edit Bug 16034 follow-up: better handling of absence of WebService::ILS::OverDrive::Patron at testing -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Mar 2 04:16:08 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 02 Mar 2017 03:16:08 +0000 Subject: [Koha-bugs] [Bug 11897] Stock Rotation for Koha In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11897 Liz Rea changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |liz at catalyst.net.nz Status|Needs Signoff |Failed QA --- Comment #32 from Liz Rea --- Hi, Quick comments, as I have a client interested in this patch: - the changes to the .sql files are missing comments at the end of the lines, so they cause the installer to throw a fit, please fix. - The stages cannot be reordered, the ajax response says Saving changes... Error: Method Not Allowed - the button styles in the toolbar need to be consistent with the rest of Koha please. - it is a nice to have to eliminate "submit" and swap for the button label "Save" I'll add more as I find them and I am sure my client will bring up whatever they find as well. Cheers, Liz -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Mar 2 10:08:33 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 02 Mar 2017 09:08:33 +0000 Subject: [Koha-bugs] [Bug 17015] New Koha Calendar In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17015 --- Comment #50 from Olli-Antti Kivilahti --- (In reply to Blou from comment #49) > I admit not understanding exactly your need, but I liked the use of > "interact in interesting ways". I mean there are different types of opening hours in a library. Different services are available on different hours. > One thing I'd bet on is that this new calendar would make it > much easier for you to stack on extra constraints. What I am concerned is the choice of GUI technologies, if they allow easily to set different types of opening hours in the calendar and can visualize those to the user. I was dabbling with https://fullcalendar.io/ on our overduenotices rewrite. It is pretty cool. > But adding an extra column to the > "discrete_calendar" table to represent a combo (branch, checkouttype) would > be easy. Not in this patch, though :) Adding a new column was what I was thinking of. Should be rather simple. We can provide a followup when we start working on that. Also popped into my head. You should add a REST API endpoint for CRUD:ing the calendar entries. Then write the GUI on top of the REST API. This way you have architecturally solid separation of backend-logic from front-end logic. And can make some super snappy UIs using AJAX. Also we can write our own GUI to interface with the discrete_calendar if we want. Our pretty much anybody can do it on top a of a well defined API. ...but maybe not in this rewrite. Up to you how you want to upgrade your workflow. Atomicupdate: installer/data/mysql/atomicupdate/generate_discrete_calendar.perl Not sure what is the community recommendation for naming conventions here. I find it polite to include the ticket number there, eg: installer/data/mysql/atomicupdate/Bug-17015-generate_discrete_calendar.perl tests++ -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Mar 2 10:24:38 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 02 Mar 2017 09:24:38 +0000 Subject: [Koha-bugs] [Bug 11897] Stock Rotation for Koha In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11897 Jonathan Field changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |jonathan.field at ptfs-europe. | |com -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Mar 2 10:58:39 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 02 Mar 2017 09:58:39 +0000 Subject: [Koha-bugs] [Bug 15854] Race condition for sending renewal/check-in notices In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15854 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Summary|Possible race condition for |Race condition for sending |sending renewal/check-in |renewal/check-in notices |notices | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Mar 2 11:32:28 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 02 Mar 2017 10:32:28 +0000 Subject: [Koha-bugs] [Bug 17168] Add a command line script for updating patron category based on status In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17168 --- Comment #9 from Nick Clemens --- (In reply to Liz Rea from comment #8) > Hi Nick, > > I think this exists already in the form of j2a.pl, though it may not be as > extensible as this verison. Yup, the idea was initially to make a script to update new patrons to regular patrons after a period of time. I added as much flexibility as possible, and included the j2a functionality so we could have a single script instead of two -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Mar 2 12:55:55 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 02 Mar 2017 11:55:55 +0000 Subject: [Koha-bugs] [Bug 11897] Stock Rotation for Koha In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11897 --- Comment #33 from Alex Sassmannshausen --- Hi Liz, Thank you for the comments! (In reply to Liz Rea from comment #32) > Hi, > > Quick comments, as I have a client interested in this patch: > > - the changes to the .sql files are missing comments at the end of the > lines, so they cause the installer to throw a fit, please fix. Indeed, I've fixed this bug in my local dev version, will push it shortly to this patch. > - The stages cannot be reordered, the ajax response says Saving changes... > Error: Method Not Allowed This is an error in the koha-httpd config for standard and single installs I've submitted a bug report for the Makefile that will fix this. (https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18175) Just to be sure ? what kind of install did you use to test this? > - the button styles in the toolbar need to be consistent with the rest of > Koha please. Will fix :-) > - it is a nice to have to eliminate "submit" and swap for the button label > "Save" Agreed, will fix this too. > I'll add more as I find them and I am sure my client will bring up whatever > they find as well. Thanks, keep 'em coming :-) -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Mar 2 12:58:54 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 02 Mar 2017 11:58:54 +0000 Subject: [Koha-bugs] [Bug 18198] New: MARC21: Further improve handling of 5XX$u in GetMarcNotes Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18198 Bug ID: 18198 Summary: MARC21: Further improve handling of 5XX$u in GetMarcNotes Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: MARC Bibliographic data support Assignee: gmcharlt at gmail.com Reporter: m.de.rooy at rijksmuseum.nl QA Contact: testopia at bugs.koha-community.org This actually is a follow-up of bug 14306. That report only touched field 555 in MARC21. But a lot of other 5XX fields have a $u subfield for URIs. This patch generalizes the change made for 555 and extends it to all 5XX $u. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Mar 2 12:59:16 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 02 Mar 2017 11:59:16 +0000 Subject: [Koha-bugs] [Bug 18198] MARC21: Further improve handling of 5XX$u in GetMarcNotes In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18198 Marcel de Rooy changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |https://bugs.koha-community | |.org/bugzilla3/show_bug.cgi | |?id=14306 Assignee|gmcharlt at gmail.com |m.de.rooy at rijksmuseum.nl Status|NEW |ASSIGNED Patch complexity|--- |Small patch -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Mar 2 12:59:16 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 02 Mar 2017 11:59:16 +0000 Subject: [Koha-bugs] [Bug 14306] Show URL from MARC21 field 555$u in basket and detail In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14306 Marcel de Rooy changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |https://bugs.koha-community | |.org/bugzilla3/show_bug.cgi | |?id=18198 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Mar 2 13:10:02 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 02 Mar 2017 12:10:02 +0000 Subject: [Koha-bugs] [Bug 18198] MARC21: Further improve handling of 5XX$u in GetMarcNotes In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18198 --- Comment #1 from Marcel de Rooy --- Created attachment 60790 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=60790&action=edit Bug 18198: MARC21: Further improve handling of 5XX$u in GetMarcNotes Bug 14306 only handled field 555 in MARC21 as an URI. But a lot of other 5XX fields have a $u subfield for URIs; actually $u is not used in any other way. This patch generalizes the change made for 555 and extends it to all 5XX $u. Test plan: [1] Run t/Biblio.t [2] Run t/db_dependent/Biblio.t [3] Edit a MARC21 record. Add a URL into 505u, 520u, 555u. [4] Check presentation on opac-detail (tab Title notes) [5] Check presentation on catalogue/detail (tab Descriptions) Signed-off-by: Marcel de Rooy -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Mar 2 13:09:59 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 02 Mar 2017 12:09:59 +0000 Subject: [Koha-bugs] [Bug 18198] MARC21: Further improve handling of 5XX$u in GetMarcNotes In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18198 Marcel de Rooy changed: What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Mar 2 13:47:48 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 02 Mar 2017 12:47:48 +0000 Subject: [Koha-bugs] [Bug 12836] SRU Explain file needs to be rewritten In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12836 Magnus Enger changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Mar 2 13:47:52 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 02 Mar 2017 12:47:52 +0000 Subject: [Koha-bugs] [Bug 12836] SRU Explain file needs to be rewritten In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12836 Magnus Enger changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #60732|0 |1 is obsolete| | --- Comment #9 from Magnus Enger --- Created attachment 60791 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=60791&action=edit Bug 12836 - Add script to rewrite SRU Explain file The standard SRU Explain files provided with Koha is static and out of date. This patch does two things - Add a script in misc/maintenance/generate_explain.pl that can generate a new Explain file, based on Koha's config files and an optional extra config file. See the POD in the script for more details. - Replace the old Explain files provided with Koha with two new files, generated by the script described above and based on the standard Koha/Zebra config. To test: - Have a look at etc/zebradb/explain-authorities.xml and etc/zebradb/explain-biblios.xml and see if they make sense as example files. Check that the list of indexes corresponds to the indexes set up in etc/zebradb/pqf.properties. - Run "perldoc misc/maintenance/generate_explain.pl" to see available options and a decription of the config file. - Run generate_explain.pl with different options and settings in the config file, and check that the output Explain docs make sense. This patch will not break anything. It is more about documentation. The Explain file documents the SRU server, it does not configure it. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Mar 2 13:50:41 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 02 Mar 2017 12:50:41 +0000 Subject: [Koha-bugs] [Bug 12836] SRU Explain file needs to be rewritten In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12836 --- Comment #10 from Magnus Enger --- My patch does not take into account the need for per-instance Explain docs. That will have to be a separate bug. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Mar 2 14:13:55 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 02 Mar 2017 13:13:55 +0000 Subject: [Koha-bugs] [Bug 18199] New: Proxy support for UsageStats Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18199 Bug ID: 18199 Summary: Proxy support for UsageStats Change sponsored?: --- Product: Koha Version: unspecified Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Tools Assignee: gmcharlt at gmail.com Reporter: tkalix at bredex.de QA Contact: testopia at bugs.koha-community.org Hello, I have had problems uploading the usage stats. The monthly script failed with some error message. The solution was to edit the file UsageStats.pm and insert my http proxy after line 347. And now it is working fine. It would be good if the utility uses the proxy support I configured in Koha, so one does not need to use the workaround I did. Thanks, Torsten. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Mar 2 14:15:25 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 02 Mar 2017 13:15:25 +0000 Subject: [Koha-bugs] [Bug 18199] Proxy support for UsageStats In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18199 --- Comment #1 from Tolsti --- Created attachment 60792 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=60792&action=edit Changes in UsageStats.pm -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Mar 2 14:22:38 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 02 Mar 2017 13:22:38 +0000 Subject: [Koha-bugs] [Bug 18200] New: Fix a potential issue with preceding space in GetMarcUrls Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18200 Bug ID: 18200 Summary: Fix a potential issue with preceding space in GetMarcUrls Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: MARC Bibliographic data support Assignee: gmcharlt at gmail.com Reporter: m.de.rooy at rijksmuseum.nl QA Contact: testopia at bugs.koha-community.org Saw a small issue with a preceding space in 856$u once. Obviously, it is quite simple to prevent it. The current code puts http:// in front for that space. Proposed patch trims the url and adds few trivial tests in Biblio.t. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Mar 2 14:36:58 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 02 Mar 2017 13:36:58 +0000 Subject: [Koha-bugs] [Bug 18200] Fix a potential issue with preceding space in GetMarcUrls In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18200 --- Comment #1 from Marcel de Rooy --- Created attachment 60793 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=60793&action=edit Bug 18200: Fix a potential issue with preceding space in GetMarcUrls Trims the URL in order prevent prefixing a space with http:// Normally you won't have a preceding space here, but I saw it happening one day and it does not cost much to resolve it. Bonus: Adding few simple tests in t/db_dependent/Biblio.t. Test plan: [1] Run t/db_dependent/Biblio.t [2] Add a 856$u with preceding space (MARC21) [3] Check opac-detail, Online access with OPACXSLTDetailsDisplay empty. Signed-off-by: Marcel de Rooy -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Mar 2 14:36:55 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 02 Mar 2017 13:36:55 +0000 Subject: [Koha-bugs] [Bug 18200] Fix a potential issue with preceding space in GetMarcUrls In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18200 Marcel de Rooy changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Mar 2 14:37:14 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 02 Mar 2017 13:37:14 +0000 Subject: [Koha-bugs] [Bug 18200] Fix a potential issue with preceding space in GetMarcUrls In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18200 Marcel de Rooy changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|gmcharlt at gmail.com |m.de.rooy at rijksmuseum.nl Patch complexity|--- |Trivial patch -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Mar 2 16:33:22 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 02 Mar 2017 15:33:22 +0000 Subject: [Koha-bugs] [Bug 17318] Make 'Normalization rule' configurable on matchpoint definition In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17318 J Schmidt changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |jschmidt at switchinc.org -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Mar 2 17:08:15 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 02 Mar 2017 16:08:15 +0000 Subject: [Koha-bugs] [Bug 7534] New OPACAllowUserToChooseBranch setting for only showing libraries allowing holds In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7534 Lari Taskula changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #60014|0 |1 is obsolete| | --- Comment #18 from Lari Taskula --- Created attachment 60794 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=60794&action=edit Bug 7534: Add new column "pickup_location" to branches This patch adds a new column "pickup_location" for each library. This value defines whether a library can be used as a pickup location or not. For extended configurability, this flag could perhaps be considered as a part of issuing rules, but as of now, this patch only offers a simple flag into each library. This method also allows easy way for REST API to determine valid pickup locations by querying the /libraries endpoint. To test: 1. perl installer/data/mysql/updatedatabase.pl 2. Observe DEV atomic update: bug_7534.perl Upgrade to XXX done (Bug 7534 - Let libraries have configuration for pickup locations) https://bugs.koha-community.org/show_bug.cgi?id=7354 -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Mar 2 17:08:31 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 02 Mar 2017 16:08:31 +0000 Subject: [Koha-bugs] [Bug 7534] New OPACAllowUserToChooseBranch setting for only showing libraries allowing holds In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7534 Lari Taskula changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #60015|0 |1 is obsolete| | --- Comment #19 from Lari Taskula --- Created attachment 60795 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=60795&action=edit Bug 7534: Add method Koha::Template::Plugin::Branches->pickup_locations This patch adds a new method Koha::Template::Plugin::Branches->pickup_locations. Unit tests included. To test: 1. prove t/db_dependent/Template/Plugin/Branches.t -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Mar 2 17:08:55 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 02 Mar 2017 16:08:55 +0000 Subject: [Koha-bugs] [Bug 7534] New OPACAllowUserToChooseBranch setting for only showing libraries allowing holds In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7534 Lari Taskula changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #60016|0 |1 is obsolete| | --- Comment #20 from Lari Taskula --- Created attachment 60796 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=60796&action=edit Bug 7534: Add configuration to admin/branches.pl This patch adds a configuration option for pickup locations. To test: 1. Apply patch 2. Go to cgi-bin/koha/admin/branches.pl 3. Observe there is a new column "Pickup location" 4. Click "Edit" for any library 5. Scroll to bottom of the page and select "No" 6. Click "Submit" 7. Observe your library in Libraries-table, notice the value of "Pickup location" has changed to "No" -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Thu Mar 2 17:09:09 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 02 Mar 2017 16:09:09 +0000 Subject: [Koha-bugs] [Bug 7534] New OPACAllowUserToChooseBranch setting for only showing libraries allowing holds In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7534 Lari Taskula changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #60023|0 |1 is obsolete| | --- Comment #21 from Lari Taskula --- Created attachment 60797 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=60797&action=edit Bug 7534: Display pickup locations instead of all libraries in request.pl This patch sets request.tt to use the list of pickup libraries instead of every library in the system. To test: 1. Go to cgi-bin/koha/admin/branches.pl 2. Configure one of your libraries to "Pickup location" => "No" 3. Go place a hold in intranet 4. See the provided "Pickup at" list 5. Observe the library that you configured is not present in the list 6. Place the hold 7. See list of existing holds on that biblio 8. See "Pickup library" column and observe your configured library is not included in the list -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Thu Mar 2 17:09:21 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 02 Mar 2017 16:09:21 +0000 Subject: [Koha-bugs] [Bug 7534] New OPACAllowUserToChooseBranch setting for only showing libraries allowing holds In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7534 Lari Taskula changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #60781|0 |1 is obsolete| | --- Comment #22 from Lari Taskula --- Created attachment 60798 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=60798&action=edit Bug 7534: Display pickup locations instead of all libraries in opac-reserve.pl This patch sets opac-reserve.tt to use the list of pickup libraries instead of every library in the system. To test: 1. Go to cgi-bin/koha/admin/branches.pl 2. Configure one of your libraries to "Pickup location" => "No" 3. Go to OPAC and place a hold 4. See the provided Pickup location list 5. Observe the library that you configured is not present in the list -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Thu Mar 2 17:18:03 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 02 Mar 2017 16:18:03 +0000 Subject: [Koha-bugs] [Bug 7534] New OPACAllowUserToChooseBranch setting for only showing libraries allowing holds In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7534 --- Comment #23 from Lari Taskula --- Created attachment 60799 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=60799&action=edit Bug 7534: Add pickup_location to kohastructure.sql -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Mar 2 17:18:51 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 02 Mar 2017 16:18:51 +0000 Subject: [Koha-bugs] [Bug 7534] New OPACAllowUserToChooseBranch setting for only showing libraries allowing holds In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7534 --- Comment #24 from Lari Taskula --- Changed pickup_location column type to TINYINT(1) since that's what we generally use for "booleans" and added it to kohastructure.sql (forgot to add it there before!) (In reply to Chris Kirby from comment #17) > I don't get the "internal server error" on an old ubuntu system (14.04 LTS) > but I DO get it on kohadevbox with a Windows host and Debian Jessie guest. > > On the Kohadevbox, Debian Jessie, > koha-plack-err: > Template process failed: undef error- The method pickup_location is not > covered by tests! at /usr/share/koha/lib/C4/Templates.pm line 121. Sent you a message on IRC! -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Mar 2 17:43:37 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 02 Mar 2017 16:43:37 +0000 Subject: [Koha-bugs] [Bug 17776] Shibboleth Authentication is broken in plack In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17776 --- Comment #3 from Martin Renvoize --- Created attachment 60800 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=60800&action=edit Enable Shibboleth for Plack -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Mar 2 17:44:17 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 02 Mar 2017 16:44:17 +0000 Subject: [Koha-bugs] [Bug 17776] Shibboleth Authentication is broken in plack In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17776 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Mar 2 17:47:42 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 02 Mar 2017 16:47:42 +0000 Subject: [Koha-bugs] [Bug 17776] Shibboleth Authentication is broken in plack In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17776 --- Comment #4 from Martin Renvoize --- To test: 1) Enable plack 2) Alter the apache config block to ensure shibboleth is passing attributes via headers instead of environment. (when running under plack, apache act's merely as a Proxy and so cannot pass environment to the separate plack process). 3) Checkin shibboleth logins are now working using the plack instance. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Mar 2 18:21:00 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 02 Mar 2017 17:21:00 +0000 Subject: [Koha-bugs] [Bug 16497] REST API: add routes to list libraries In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16497 Lari Taskula changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #54943|0 |1 is obsolete| | --- Comment #12 from Lari Taskula --- Created attachment 60801 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=60801&action=edit Bug 16497: [REST] Add /api/v1/libraries CRUD for libraries via REST API. GET /api/v1/libraries - List all libraries GET /api/v1/libraries/{branchcode} - Get one Library POST /api/v1/libraries - Add new Library DELETE /api/v1/libraries/{branchcode} - Delete Library Test plan: - apply patch - run tests: t/db_dependent/api/v1/libraries.t - test API with some API tool or simple curl e.g.: curl http://host:port/api/v1/libraries curl http://host:port/api/v1/libraries/cpl -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Thu Mar 2 18:21:20 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 02 Mar 2017 17:21:20 +0000 Subject: [Koha-bugs] [Bug 16497] REST API: add routes to list libraries In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16497 Lari Taskula changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |Needs Signoff -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Mar 2 18:21:23 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 02 Mar 2017 17:21:23 +0000 Subject: [Koha-bugs] [Bug 16497] REST API: add routes to list libraries In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16497 --- Comment #13 from Lari Taskula --- Created attachment 60802 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=60802&action=edit Bug 16497: Sort definitions.json Before this file grows, we should sort it alphabetically. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Mar 2 18:30:46 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 02 Mar 2017 17:30:46 +0000 Subject: [Koha-bugs] [Bug 16497] REST API: add routes to list libraries In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16497 Lari Taskula changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |In Discussion --- Comment #14 from Lari Taskula --- Here is CRUD. I switched this bug report to Needs Signoff without thinking first; we should do the migration from Swagger2 to Mojolicious::Plugin::OpenAPI before pushing adding more REST API stuff. See Bug 18137. So I am going to revert the status of this bug report back to In Discussion until we proceed with the migration. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Mar 2 19:27:41 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 02 Mar 2017 18:27:41 +0000 Subject: [Koha-bugs] [Bug 14697] Extend and enhance "Claims returned" lost status In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14697 Cheryl changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |clackman at cityoffargo.com -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Mar 2 19:51:08 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 02 Mar 2017 18:51:08 +0000 Subject: [Koha-bugs] [Bug 17349] Add item screen does not populate in serials module when multiple late issues exist In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17349 J Schmidt changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |jschmidt at switchinc.org -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Mar 2 19:51:08 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 02 Mar 2017 18:51:08 +0000 Subject: [Koha-bugs] [Bug 17349] Add item screen does not populate in serials module when multiple late issues exist In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17349 J Schmidt changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |jschmidt at switchinc.org -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Mar 2 22:11:53 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 02 Mar 2017 21:11:53 +0000 Subject: [Koha-bugs] [Bug 18201] New: Confusing language on Export data - bibliographic records " Remove non-local items" Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18201 Bug ID: 18201 Summary: Confusing language on Export data - bibliographic records "Remove non-local items" Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: normal Priority: P5 - low Component: Tools Assignee: gmcharlt at gmail.com Reporter: nick at bywatersolutions.com QA Contact: testopia at bugs.koha-community.org When exporting records and selecting branches many users (and myself) assume that 'Remove non-local items' means: remove items not belonging the branches i am exporting But it actually means: Remove items not belonging to the branch I am logged in as At a minimum I think we need to update the language, ideally I think we should provide the expected behavior as an option. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Mar 2 22:32:09 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 02 Mar 2017 21:32:09 +0000 Subject: [Koha-bugs] [Bug 17855] Updated Koha web installer and new onboarding tool feature to guide users through setting up Koha In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17855 Alex Buckley changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks|18060 | Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18060 [Bug 18060] Add onboarding functionality to guide users through setting up labels for the first time -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Mar 2 22:32:09 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 02 Mar 2017 21:32:09 +0000 Subject: [Koha-bugs] [Bug 18002] Make onboarding tool include framework to be embedded in Acquisitions to help the users set up Acquisitions for the first time In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18002 Alex Buckley changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |18060 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18060 [Bug 18060] Add onboarding functionality to guide users through setting up labels for the first time -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Mar 2 22:32:09 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 02 Mar 2017 21:32:09 +0000 Subject: [Koha-bugs] [Bug 18060] Add onboarding functionality to guide users through setting up labels for the first time In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18060 Alex Buckley changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on|17855 |18002 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17855 [Bug 17855] Updated Koha web installer and new onboarding tool feature to guide users through setting up Koha https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18002 [Bug 18002] Make onboarding tool include framework to be embedded in Acquisitions to help the users set up Acquisitions for the first time -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Mar 2 23:52:30 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 02 Mar 2017 22:52:30 +0000 Subject: [Koha-bugs] [Bug 13153] Waiting hold checked in at different library doesn' t re-route item to correct library In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13153 Christopher Brannon changed: What |Removed |Added ---------------------------------------------------------------------------- Severity|normal |major --- Comment #9 from Christopher Brannon --- This issue needs to be addressed. This has been a time waster for support staff trying to figure out why these things happen each time. A waiting item triggered at another library needs to be routed back to its intended destination and the waiting status needs to be set back to priority 1. Christopher -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Mar 3 00:04:07 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 02 Mar 2017 23:04:07 +0000 Subject: [Koha-bugs] [Bug 13153] Waiting hold checked in at different library doesn' t re-route item to correct library In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13153 George Williams (NEKLS) changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |george at nekls.org --- Comment #10 from George Williams (NEKLS) --- I agree with Christopher. This has been a problem for a long time. George -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Fri Mar 3 00:56:00 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 02 Mar 2017 23:56:00 +0000 Subject: [Koha-bugs] [Bug 13094] Cancel all holds button text needs .class or at least an html tag. In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13094 Aleisha Amohia changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |aleishaamohia at hotmail.com --- Comment #1 from Aleisha Amohia --- is this still valid? -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Mar 3 01:25:37 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 03 Mar 2017 00:25:37 +0000 Subject: [Koha-bugs] [Bug 18096] BnF Authorities Z39.50 search and access In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18096 David Cook changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |dcook at prosentient.com.au --- Comment #1 from David Cook --- I've been thinking about server profiles, but I don't understand this one. 2016 and 2017 aren't standard bib-1 attributes (http://www.loc.gov/z3950/agency/defns/bib1.html), so I'm guessing BnF have added them, but I don't see how you'd use these attributes in a query... -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Mar 3 02:10:07 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 03 Mar 2017 01:10:07 +0000 Subject: [Koha-bugs] [Bug 18202] New: Define profiles for Z39.50 server targets Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18202 Bug ID: 18202 Summary: Define profiles for Z39.50 server targets Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Z39.50 / SRU / OpenSearch Servers Assignee: gmcharlt at gmail.com Reporter: dcook at prosentient.com.au QA Contact: testopia at bugs.koha-community.org CC: m.de.rooy at rijksmuseum.nl Different Z39.50 servers support different use attributes using different profiles. NorZIG: http://www.norzig.no/profiles/profile2.1.html Libraries Australia (LA): http://www.nla.gov.au/librariesaustralia/services/search/z3950/ Library of Congress (LOC): https://www.loc.gov/z3950/lcserver.html More profiles: https://www.loc.gov/z3950/agency/profiles/profiles.html In the case of Libraries Australia and Library of Congress, the profiles are different between bibliographic databases and authority databases, and this can be traced back to differences in the functional areas of the Bath profile: http://web.archive.org/web/20080218122658/http://www.collectionscanada.gc.ca/bath/tp-bath2-e.htm For instance, Libraries Australia claims to support "Functional Area D (Authority Record Search & Retrieval) to Level 1" http://web.archive.org/web/20080219085710/http://www.collectionscanada.gc.ca/bath/tp-bath2.18-e.htm#a It doesn't appear to in reality as it doesn't support use attribute 1002 (while the Library of Congress does support this use attribute). The Library of Congress appears to be more in line with Functional Area D (Authority Record Search & Retrieval) to Level 2: http://web.archive.org/web/20080219085716/http://www.collectionscanada.gc.ca/bath/tp-bath2.21-e.htm It doesn't look like LOC perfectly adheres to Level 2, but I'd say it does up to 99.99%. It also supports a extra attributes belonging to local indexes. Anyway, here's the problem: LOC use attributes 1,2, and 3, but LA does not support these attributes. On the other hand, LA supports 1003, 1004, 1005, and 1006, but LOC does not. LOC supports 1002, but LA does not. We need to be able to define profiles on a server by server basis. In fact, this is even recommended by Libraries Australia: "Step 4. Configure your Bib-1 Search Attributes (if required):". -- I don't think it would be that difficult to define profiles. We'd have a table with id, profile name, a name/index/description column, and a use attribute column. Then we could add a foreign key to z3950servers to specify the profile. We'd need to do a different query for each server target but that would be easy enough on its own. The difficulty may lie in what to do about the Z39.50 search form. Not all "names" would be supported by all targets. Bug 18096 (https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18096) also mentions some local attributes. We don't have a way of specifying those in the search form at the moment, and obviously those local attributes would be local to that particular server. I suppose we could dynamically create the search form... but again not all names will correspond to all servers. I suppose we could just add that caveat. We could also be better with our presentation of results. If we get an error code of unsupported use attribute from a target server, we could surface that to users. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Mar 3 02:35:12 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 03 Mar 2017 01:35:12 +0000 Subject: [Koha-bugs] [Bug 4969] Vendors can not be deleted / show only active vendors In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=4969 Aleisha Amohia changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff Patch complexity|Medium patch |Small patch -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. You are the QA Contact for the bug. From bugzilla-daemon at bugs.koha-community.org Fri Mar 3 02:35:16 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 03 Mar 2017 01:35:16 +0000 Subject: [Koha-bugs] [Bug 4969] Vendors can not be deleted / show only active vendors In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=4969 --- Comment #22 from Aleisha Amohia --- Created attachment 60803 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=60803&action=edit Bug 4969: Toggle showing of all/active vendors This patch provides the functionality to hide inactive vendors from the vendor search. To test: 1) Make sure at least one vendor is inactive 2) Do a vendor search 3) Confirm the link to show only active vendors works, and is replaced with a link to show all vendors when clicked 4) Confirm the link to show all vendors works, and is replaced with a link to show only active vendors when clicked Sponsored-by: Catalyst IT -- You are receiving this mail because: You are the QA Contact for the bug. You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Mar 3 02:38:33 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 03 Mar 2017 01:38:33 +0000 Subject: [Koha-bugs] [Bug 4969] Vendors can not be deleted / show only active vendors In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=4969 Aleisha Amohia changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |aleishaamohia at hotmail.com Change sponsored?|--- |Sponsored Assignee|koha-bugs at lists.koha-commun |aleishaamohia at hotmail.com |ity.org | -- You are receiving this mail because: You are the QA Contact for the bug. You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Mar 3 02:41:06 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 03 Mar 2017 01:41:06 +0000 Subject: [Koha-bugs] [Bug 11897] Stock Rotation for Koha In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11897 --- Comment #34 from Liz Rea --- Ah, it's probably because my apache configs are older, I'll add those paths and try it again. (and make a note that they need to be added in upgrades) -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Mar 3 03:00:41 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 03 Mar 2017 02:00:41 +0000 Subject: [Koha-bugs] [Bug 1356] Lose original search term when select "More options" In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=1356 --- Comment #5 from Aleisha Amohia --- Created attachment 60804 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=60804&action=edit Bug 1356: Use JS to show more/less options in advanced search Patch for STAFF SIDE ONLY. Not ready for sign-off. Sponsored-by: Catalyst IT -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Mar 3 03:00:53 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 03 Mar 2017 02:00:53 +0000 Subject: [Koha-bugs] [Bug 1356] Lose original search term when select "More options" In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=1356 Aleisha Amohia changed: What |Removed |Added ---------------------------------------------------------------------------- Change sponsored?|--- |Sponsored CC| |aleishaamohia at hotmail.com Assignee|gmcharlt at gmail.com |aleishaamohia at hotmail.com -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Mar 3 04:42:24 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 03 Mar 2017 03:42:24 +0000 Subject: [Koha-bugs] [Bug 18185] Clears loan history In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18185 --- Comment #3 from Fred --- (In reply to Jonathan Druart from comment #2) > Something in the logs? In the log you do not see any errors -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Fri Mar 3 08:43:01 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 03 Mar 2017 07:43:01 +0000 Subject: [Koha-bugs] [Bug 18203] New: Add per borrower category restrictions on ILL placement. Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18203 Bug ID: 18203 Summary: Add per borrower category restrictions on ILL placement. Change sponsored?: --- Product: Koha Version: unspecified Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Circulation Assignee: koha-bugs at lists.koha-community.org Reporter: alex.sassmannshausen at ptfs-europe.com QA Contact: testopia at bugs.koha-community.org CC: gmcharlt at gmail.com, kyle.m.hall at gmail.com The ILLModule currently allows any borrower category to request new ILLs. This may not be what is required in many places as ILLs can be very expensive. This bug should implement a method by which entire borrower categories can be prevented from creating new ILL requests. Alex -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Fri Mar 3 08:43:13 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 03 Mar 2017 07:43:13 +0000 Subject: [Koha-bugs] [Bug 7317] Add an Interlibrary Loan Module to Circulation and OPAC In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7317 Alex Sassmannshausen changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |18203 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18203 [Bug 18203] Add per borrower category restrictions on ILL placement. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Mar 3 08:43:13 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 03 Mar 2017 07:43:13 +0000 Subject: [Koha-bugs] [Bug 18203] Add per borrower category restrictions on ILL placement. In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18203 Alex Sassmannshausen changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|koha-bugs at lists.koha-commun |alex.sassmannshausen at ptfs-e |ity.org |urope.com Depends on| |7317 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7317 [Bug 7317] Add an Interlibrary Loan Module to Circulation and OPAC -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Fri Mar 3 08:50:00 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 03 Mar 2017 07:50:00 +0000 Subject: [Koha-bugs] [Bug 18203] Add per borrower category restrictions on ILL placement. In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18203 --- Comment #1 from Alex Sassmannshausen --- Created attachment 60805 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=60805&action=edit Add per borrower category create ILL privilege. * admin/categories.pl: Add validation & update for `canplaceill`. * koha-tmpl/intranet-tmpl/prog/en/modules/admin/categories.tt: Add `canplaceill` handling. * ill/ill-requests.pl: Pass `canplaceill` to template. * koha-tmpl/intranet-tmpl/prog/en/includes/ill-toolbar.inc: Check for `canplaceill`. * opac/opac-illrequests.pl: Pass `canplaceill` to template. * koha-tmpl/opac-tmpl/bootstrap/en/modules/opac-illrequests.tt: Check for `canplaceill`. * installer/data/mysql/kohastructure.sql: Create `canplaceill` column. * installer/data/mysql/atomicupdate/ill_cat_permission.sql: New file. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Mar 3 08:50:04 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 03 Mar 2017 07:50:04 +0000 Subject: [Koha-bugs] [Bug 18203] Add per borrower category restrictions on ILL placement. In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18203 --- Comment #2 from Alex Sassmannshausen --- Created attachment 60806 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=60806&action=edit DO NOT PUSH: Schema changes. * Koha/Schema/Result/Category.pm: Add `canplaceill`. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Mar 3 08:53:52 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 03 Mar 2017 07:53:52 +0000 Subject: [Koha-bugs] [Bug 18203] Add per borrower category restrictions on ILL placement. In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18203 --- Comment #3 from Alex Sassmannshausen --- Test Plan: - Have ILLModule working - With any non-database user verify you can place new ILL requests in OPAC and Intranet - Apply patches here - Run dbupdate - Verify you can no longer place new ILL requests in OPAC and Intranet - In borrower categories, set 'Can place ILL' to yes. - Verify you can place new ILL requests in OPAC and Intranet. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Mar 3 10:12:01 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 03 Mar 2017 09:12:01 +0000 Subject: [Koha-bugs] [Bug 18186] Amounts with decimal comma instead of decimal dot breaking payments In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18186 Ulrich Kleiber changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |ulrich.kleiber at bsz-bw.de --- Comment #1 from Ulrich Kleiber --- The 'comma problem' started on our production servers after we have enabled Plack. It seems that the CGI version is using locale C whereas Plack is using the default locale of the server. After we have chosen None as our default locale, the decimal point was back again (partly a reboot was required). Apart from this, the default locale None is also recommended here: https://wiki.debian.org/Locale -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Fri Mar 3 10:53:42 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 03 Mar 2017 09:53:42 +0000 Subject: [Koha-bugs] [Bug 17776] Shibboleth Authentication is broken in plack In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17776 Zeno Tajoli changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |z.tajoli at cineca.it -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Mar 3 11:33:16 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 03 Mar 2017 10:33:16 +0000 Subject: [Koha-bugs] [Bug 17776] Shibboleth Authentication is broken in plack In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17776 --- Comment #5 from Zeno Tajoli --- Do you think we can use http://www.ssocircle.com/en/portfolio/publicidp/ for testing ? Or is better to use https://www.testshib.org/ ? -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Mar 3 13:08:28 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 03 Mar 2017 12:08:28 +0000 Subject: [Koha-bugs] [Bug 4969] Vendors can not be deleted / show only active vendors In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=4969 Marc V?ron changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #60803|0 |1 is obsolete| | --- Comment #23 from Marc V?ron --- Created attachment 60807 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=60807&action=edit Bug 4969: Toggle showing of all/active vendors This patch provides the functionality to hide inactive vendors from the vendor search. To test: 1) Make sure at least one vendor is inactive 2) Do a vendor search 3) Confirm the link to show only active vendors works, and is replaced with a link to show all vendors when clicked 4) Confirm the link to show all vendors works, and is replaced with a link to show only active vendors when clicked Sponsored-by: Catalyst IT Followed test plan, works as expected Signed-off-by: Marc V?ron -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Mar 3 13:09:08 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 03 Mar 2017 12:09:08 +0000 Subject: [Koha-bugs] [Bug 4969] Vendors can not be deleted / show only active vendors In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=4969 Marc V?ron changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off CC| |veron at veron.ch -- You are receiving this mail because: You are watching all bug changes. You are the QA Contact for the bug. From bugzilla-daemon at bugs.koha-community.org Fri Mar 3 13:27:09 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 03 Mar 2017 12:27:09 +0000 Subject: [Koha-bugs] [Bug 18200] Fix a potential issue with preceding space in GetMarcUrls In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18200 Marc V?ron changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #60793|0 |1 is obsolete| | --- Comment #2 from Marc V?ron --- Created attachment 60808 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=60808&action=edit Bug 18200: Fix a potential issue with preceding space in GetMarcUrls Trims the URL in order prevent prefixing a space with http:// Normally you won't have a preceding space here, but I saw it happening one day and it does not cost much to resolve it. Bonus: Adding few simple tests in t/db_dependent/Biblio.t. Test plan: [1] Run t/db_dependent/Biblio.t [2] Add a 856$u with preceding space (MARC21) [3] Check opac-detail, Online access with OPACXSLTDetailsDisplay empty. Signed-off-by: Marcel de Rooy Followed test plan, works as expected Signed-off-by: Marc V?ron -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Mar 3 13:27:34 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 03 Mar 2017 12:27:34 +0000 Subject: [Koha-bugs] [Bug 18200] Fix a potential issue with preceding space in GetMarcUrls In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18200 Marc V?ron changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |veron at veron.ch Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Mar 3 13:33:16 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 03 Mar 2017 12:33:16 +0000 Subject: [Koha-bugs] [Bug 18200] Fix a potential issue with preceding space in GetMarcUrls In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18200 --- Comment #3 from Marc V?ron --- Question: The biblionumber is always added to the link, something like: http://XXXXXXXXXXX/cgi-bin/koha/tracklinks.pl?uri=http://www.yyyyyyyyyy.com&biblionumber=52 It happens with and without patch (with OPACXSLTDetailsDisplay empty). Is this behaviour expected? -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Mar 3 13:40:45 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 03 Mar 2017 12:40:45 +0000 Subject: [Koha-bugs] [Bug 18204] New: Authority searches are not saved in Search history Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18204 Bug ID: 18204 Summary: Authority searches are not saved in Search history Change sponsored?: --- Product: Koha Version: 16.11 Hardware: PC OS: Windows Status: NEW Severity: normal Priority: P5 - low Component: OPAC Assignee: oleonard at myacpl.org Reporter: leire at scanbit.net QA Contact: testopia at bugs.koha-community.org When you search an authority in Authority search, this search is not saved in Search history. EnableOpacSearchHistory is enabled Steps to test: 1- Login your account (opac) 2- Search an authority in Authority search 3- Go to Search history -> Authority 4- It says "Your authority search history is empty" Tested on 16.11.04 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Mar 3 13:41:56 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 03 Mar 2017 12:41:56 +0000 Subject: [Koha-bugs] [Bug 18204] Authority searches are not saved in Search history In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18204 ldiez changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |ASSIGNED Assignee|oleonard at myacpl.org |leire at scanbit.net -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Mar 3 13:46:14 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 03 Mar 2017 12:46:14 +0000 Subject: [Koha-bugs] [Bug 18204] Authority searches are not saved in Search history In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18204 --- Comment #1 from leire at scanbit.net --- Created attachment 60809 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=60809&action=edit Bug 18204 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Mar 3 13:46:40 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 03 Mar 2017 12:46:40 +0000 Subject: [Koha-bugs] [Bug 18204] Authority searches are not saved in Search history In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18204 leire at scanbit.net changed: What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Mar 3 14:22:45 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 03 Mar 2017 13:22:45 +0000 Subject: [Koha-bugs] [Bug 18205] New: REST interface to Koha::Logger Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18205 Bug ID: 18205 Summary: REST interface to Koha::Logger Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Web services Assignee: koha-bugs at lists.koha-community.org Reporter: lari.taskula at jns.fi QA Contact: testopia at bugs.koha-community.org Add interface 'rest' for Koha logger. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Fri Mar 3 14:24:09 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 03 Mar 2017 13:24:09 +0000 Subject: [Koha-bugs] [Bug 18206] New: REST API: Default exception handling Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18206 Bug ID: 18206 Summary: REST API: Default exception handling Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Web services Assignee: koha-bugs at lists.koha-community.org Reporter: lari.taskula at jns.fi QA Contact: testopia at bugs.koha-community.org Improve exception handling in REST controllers. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Fri Mar 3 15:28:46 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 03 Mar 2017 14:28:46 +0000 Subject: [Koha-bugs] [Bug 14973] Suggestions - Search and warn user about existing biblio when submitting a suggestion In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14973 Koha Team Lyon 3 changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |koha at univ-lyon3.fr -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Mar 3 15:36:43 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 03 Mar 2017 14:36:43 +0000 Subject: [Koha-bugs] [Bug 14049] Personalized OPAC purchase suggestion fields In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14049 Koha Team Lyon 3 changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |koha at univ-lyon3.fr -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Mar 3 15:55:39 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 03 Mar 2017 14:55:39 +0000 Subject: [Koha-bugs] [Bug 13937] Add a Z39.50 daemon that can inject item status MARC subfields In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13937 Tom?s Cohen Arazi changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |tomascohen at gmail.com Version|unspecified |master -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Mar 3 16:02:24 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 03 Mar 2017 15:02:24 +0000 Subject: [Koha-bugs] [Bug 12972] Transfer slip and transfer message (blue box) can conflict In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12972 Nick Clemens changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Fri Mar 3 16:02:27 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 03 Mar 2017 15:02:27 +0000 Subject: [Koha-bugs] [Bug 12972] Transfer slip and transfer message (blue box) can conflict In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12972 --- Comment #1 from Nick Clemens --- Created attachment 60810 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=60810&action=edit Bug 12972 - Transfer slip and transfer message (blue box) can conflict Instead of passing the homebranch to the slip, let's pass TransferWaitingAt (the value we display) To test: 1 - Check in an item that will initiate a transfer (hold or automatic item return) 2 - Note the transfer message and receipt match 3 - Remove the reason for transfer (bot don't cancel transfer) i.e. cancel hold or change homebranch of item to current library 4 - Check the item in again 5 - Note the message displays the transfer destination and the slip shows the homebranch 6 - Apply patch 7 - Repeat 5 but note slip and message match 8 - Test any edge cases for correctness 9 - sign off -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Fri Mar 3 16:03:10 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 03 Mar 2017 15:03:10 +0000 Subject: [Koha-bugs] [Bug 18207] New: smart-rules.pl should validate that all branches / patron categories / item types are covered by circ rules. Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18207 Bug ID: 18207 Summary: smart-rules.pl should validate that all branches / patron categories / item types are covered by circ rules. Change sponsored?: --- Product: Koha Version: unspecified Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Staff Client Assignee: koha-bugs at lists.koha-community.org Reporter: barton at bywatersolutions.com QA Contact: testopia at bugs.koha-community.org CC: gmcharlt at gmail.com At present, It's possible to have combinations of branch / category / item type that are not covered by circulation rules. This may cause issues with circulation, holds and fines; we should require that all are covered. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Fri Mar 3 16:03:34 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 03 Mar 2017 15:03:34 +0000 Subject: [Koha-bugs] [Bug 12972] Transfer slip and transfer message (blue box) can conflict In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12972 Nick Clemens changed: What |Removed |Added ---------------------------------------------------------------------------- Patch complexity|--- |Trivial patch CC| |jzairo at bywatersolutions.com | |, nick at bywatersolutions.com Severity|enhancement |minor Assignee|koha-bugs at lists.koha-commun |nick at bywatersolutions.com |ity.org | -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Fri Mar 3 16:16:49 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 03 Mar 2017 15:16:49 +0000 Subject: [Koha-bugs] [Bug 18115] Fix use of Objects as hashref in acqui/ addorderiso2709.pl - Bug 15503 followup In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18115 Kyle M Hall changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Failed QA -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Mar 3 17:11:20 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 03 Mar 2017 16:11:20 +0000 Subject: [Koha-bugs] [Bug 18115] Fix use of Objects as hashref in acqui/ addorderiso2709.pl - Bug 15503 followup In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18115 Nick Clemens changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Mar 3 17:11:22 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 03 Mar 2017 16:11:22 +0000 Subject: [Koha-bugs] [Bug 18115] Fix use of Objects as hashref in acqui/ addorderiso2709.pl - Bug 15503 followup In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18115 Nick Clemens changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #60249|0 |1 is obsolete| | --- Comment #5 from Nick Clemens --- Created attachment 60811 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=60811&action=edit Bug 18115 - Fix use of Objects as hashref in acqui/addorderiso2709.pl - Bug 15503 followup Fix use of 'gstrate' for 'tax_rate' -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Mar 3 17:47:38 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 03 Mar 2017 16:47:38 +0000 Subject: [Koha-bugs] [Bug 17260] updatedatabase.pl fails on invalid entries in ENUM and BOOLEAN columns In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17260 Kyle M Hall changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |kyle at bywatersolutions.com Status|Passed QA |Pushed to Master --- Comment #12 from Kyle M Hall --- Pushed to master for 17.05, thanks Phillipe, Jonathan! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Mar 3 17:52:04 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 03 Mar 2017 16:52:04 +0000 Subject: [Koha-bugs] [Bug 17941] CanBookBeRenewed is very inefficient/slow In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17941 Kyle M Hall changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |kyle at bywatersolutions.com Status|Passed QA |Pushed to Master --- Comment #37 from Kyle M Hall --- Pushed to master for 17.05, thanks Francesco! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Mar 3 17:54:43 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 03 Mar 2017 16:54:43 +0000 Subject: [Koha-bugs] [Bug 18160] Error when OverDriveCirculation not enabled In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18160 Kyle M Hall changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |kyle at bywatersolutions.com Status|Passed QA |Pushed to Master --- Comment #14 from Kyle M Hall --- Pushed to master for 17.05, thanks Nick, Mark! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Mar 3 17:57:53 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 03 Mar 2017 16:57:53 +0000 Subject: [Koha-bugs] [Bug 17992] REST api: Cities controller should not use ->unblessed In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17992 Kyle M Hall changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to Master CC| |kyle at bywatersolutions.com --- Comment #4 from Kyle M Hall --- Pushed to master for 17.05, thanks Tomas! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Mar 3 18:08:02 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 03 Mar 2017 17:08:02 +0000 Subject: [Koha-bugs] [Bug 18087] Clarification on File type when using file of biblionumbers to export data In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18087 Kyle M Hall changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |kyle at bywatersolutions.com Status|Passed QA |Pushed to Master --- Comment #21 from Kyle M Hall --- Pushed to master for 17.05, thanks Joy, Jonathan! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Mar 3 18:09:06 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 03 Mar 2017 17:09:06 +0000 Subject: [Koha-bugs] [Bug 13968] Branch email hints are misleading In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13968 Kyle M Hall changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |kyle at bywatersolutions.com Status|Passed QA |Pushed to Master --- Comment #10 from Kyle M Hall --- Pushed to master for 17.05, thanks Marc, Mark! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Mar 3 18:20:46 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 03 Mar 2017 17:20:46 +0000 Subject: [Koha-bugs] [Bug 16966] Koha:: Patrons - Move GetBorrowersWithIssuesHistoryOlderThan to search_patrons_to_anonymise In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16966 Kyle M Hall changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to Master --- Comment #59 from Kyle M Hall --- Pushed to master for 17.05, thanks Jonathan, Marcel! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Mar 3 18:52:02 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 03 Mar 2017 17:52:02 +0000 Subject: [Koha-bugs] [Bug 17334] members-update.pl should show timestamp In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17334 Kyle M Hall changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to Master CC| |kyle at bywatersolutions.com --- Comment #16 from Kyle M Hall --- Pushed to master for 17.05, thanks Alex! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Mar 3 18:56:55 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 03 Mar 2017 17:56:55 +0000 Subject: [Koha-bugs] [Bug 17840] Add classes to internal and public notes in checkouts table In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17840 Kyle M Hall changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to Master CC| |kyle at bywatersolutions.com --- Comment #13 from Kyle M Hall --- Pushed to master for 17.05, thanks Emma! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Mar 3 19:11:10 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 03 Mar 2017 18:11:10 +0000 Subject: [Koha-bugs] [Bug 18037] Hold notes template cleanup (from 15545) In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18037 Kyle M Hall changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |kyle at bywatersolutions.com Status|Passed QA |Pushed to Master --- Comment #4 from Kyle M Hall --- Pushed to master for 17.05, thanks Marcel! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Mar 3 19:13:13 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 03 Mar 2017 18:13:13 +0000 Subject: [Koha-bugs] [Bug 18070] Support clean removal of authority records In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18070 Kyle M Hall changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |kyle at bywatersolutions.com Status|Passed QA |Pushed to Master --- Comment #32 from Kyle M Hall --- Pushed to master for 17.05, thanks Marcel! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Mar 3 19:14:23 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 03 Mar 2017 18:14:23 +0000 Subject: [Koha-bugs] [Bug 13685] Sorting Patron Reading History In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13685 Kyle M Hall changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |kyle at bywatersolutions.com Status|Passed QA |Pushed to Master --- Comment #17 from Kyle M Hall --- Pushed to master for 17.05, thanks Aleisha! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Mar 3 19:14:40 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 03 Mar 2017 18:14:40 +0000 Subject: [Koha-bugs] [Bug 18108] Sorting by author in opac summary In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18108 Kyle M Hall changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to Master CC| |kyle at bywatersolutions.com --- Comment #4 from Kyle M Hall --- Pushed to master for 17.05, thanks Aleisha! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Mar 3 19:16:03 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 03 Mar 2017 18:16:03 +0000 Subject: [Koha-bugs] [Bug 18122] Audio alerts: Add hint on where to enable sounds In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18122 Kyle M Hall changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to Master CC| |kyle at bywatersolutions.com --- Comment #7 from Kyle M Hall --- Pushed to master for 17.05, thanks Marc! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Mar 3 19:17:06 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 03 Mar 2017 18:17:06 +0000 Subject: [Koha-bugs] [Bug 18169] Date like 2999 should not be used arbitrarily In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18169 Kyle M Hall changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to Master CC| |kyle at bywatersolutions.com --- Comment #8 from Kyle M Hall --- Pushed to master for 17.05, thanks Jonathan! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Mar 3 19:18:36 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 03 Mar 2017 18:18:36 +0000 Subject: [Koha-bugs] [Bug 7663] batch add barcodes to a list In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7663 Kyle M Hall changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to Master CC| |kyle at bywatersolutions.com --- Comment #11 from Kyle M Hall --- Pushed to master for 17.05, thanks Nick, Jonathan! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Mar 3 19:27:10 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 03 Mar 2017 18:27:10 +0000 Subject: [Koha-bugs] [Bug 18098] Add an index with the count of not onloan items In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18098 Tom?s Cohen Arazi changed: What |Removed |Added ---------------------------------------------------------------------------- Summary|Add an index with the count |Add an index with the count |of available items |of not onloan items Assignee|gmcharlt at gmail.com |tomascohen at gmail.com -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Mar 3 19:27:22 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 03 Mar 2017 18:27:22 +0000 Subject: [Koha-bugs] [Bug 18098] Add an index with the count of not onloan items In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18098 Tom?s Cohen Arazi changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |nick at bywatersolutions.com -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Mar 3 19:27:21 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 03 Mar 2017 18:27:21 +0000 Subject: [Koha-bugs] [Bug 10978] redirect to basket list of a supplier after deleting a basket In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10978 Kyle M Hall changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to Master CC| |kyle at bywatersolutions.com --- Comment #10 from Kyle M Hall --- Pushed to master for 17.05, thanks Aleisha! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Mar 3 19:29:29 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 03 Mar 2017 18:29:29 +0000 Subject: [Koha-bugs] [Bug 18208] New: Add RecordProcessor filter to inject not onloan count to MARC records Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18208 Bug ID: 18208 Summary: Add RecordProcessor filter to inject not onloan count to MARC records Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Architecture, internals, and plumbing Assignee: gmcharlt at gmail.com Reporter: tomascohen at gmail.com QA Contact: testopia at bugs.koha-community.org -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Mar 3 19:29:41 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 03 Mar 2017 18:29:41 +0000 Subject: [Koha-bugs] [Bug 18208] Add RecordProcessor filter to inject not onloan count to MARC records In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18208 Tom?s Cohen Arazi changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |nick at bywatersolutions.com Assignee|gmcharlt at gmail.com |tomascohen at gmail.com -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Mar 3 19:30:24 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 03 Mar 2017 18:30:24 +0000 Subject: [Koha-bugs] [Bug 14764] Add OPAC News branch selector In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14764 Kyle M Hall changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |kyle at bywatersolutions.com Status|Passed QA |Pushed to Master --- Comment #48 from Kyle M Hall --- Pushed to master for 17.05, thanks Liz! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Mar 3 19:33:25 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 03 Mar 2017 18:33:25 +0000 Subject: [Koha-bugs] [Bug 15427] Allow db connections using TLS In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15427 Kyle M Hall changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to Master CC| |kyle at bywatersolutions.com --- Comment #16 from Kyle M Hall --- Pushed to master for 17.05, thanks Dimitris! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Mar 3 19:37:05 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 03 Mar 2017 18:37:05 +0000 Subject: [Koha-bugs] [Bug 16530] Add a circ sidebar navigation menu In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16530 Kyle M Hall changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |kyle at bywatersolutions.com Status|Passed QA |Pushed to Master --- Comment #18 from Kyle M Hall --- Pushed to master for 17.05, thanks Aleisha, Jonathan! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Mar 3 19:38:02 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 03 Mar 2017 18:38:02 +0000 Subject: [Koha-bugs] [Bug 18135] Can submit batch deletion for authorities without selecting any In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18135 Kyle M Hall changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |kyle at bywatersolutions.com Status|Passed QA |Pushed to Master --- Comment #5 from Kyle M Hall --- Pushed to master for 17.05, thanks Aleisha! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Mar 3 19:43:04 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 03 Mar 2017 18:43:04 +0000 Subject: [Koha-bugs] [Bug 18208] Add RecordProcessor filter to inject not onloan count to MARC records In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18208 Tom?s Cohen Arazi changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Mar 3 19:43:07 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 03 Mar 2017 18:43:07 +0000 Subject: [Koha-bugs] [Bug 18208] Add RecordProcessor filter to inject not onloan count to MARC records In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18208 --- Comment #1 from Tom?s Cohen Arazi --- Created attachment 60812 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=60812&action=edit Bug 18208: Add RecordProcessor filter to inject not onloan count to MARC records This patch adds a new filter for MARC records to be used with Koha::RecordProcessor. It's purpose is to inject the information about items not-onloan in a fixed subfield, 999$x. To test: - Apply the patch - Run: $ prove t/db_dependent/Koha/Filter/EmbedItemsAvailability.t => SUCCESS: Tests pass! - Sign off :-D Sponsored-by: ByWater Solutions -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Mar 3 20:23:46 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 03 Mar 2017 19:23:46 +0000 Subject: [Koha-bugs] [Bug 15854] Race condition for sending renewal/check-in notices In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15854 Marc V?ron changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #60057|0 |1 is obsolete| | --- Comment #6 from Marc V?ron --- Created attachment 60813 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=60813&action=edit Bug 15854: Simplify the code to limit race conditions There is an obvious race condition when CHECKIN and RENEWAL are generated from circulation.pl calling svc/renew or svc/checkin in AJAX. The 2 first queries will try to get the id of the last message (find_last_message) and if it does not exist, they will insert it. Theorically that could be lead to have several "digest" messages for a given patron. I did not recreate more than 2 messages, from the third one at least one of the two firsts existed in the DB already. This patch just simplifies the code to make the SELECT and INSERT or UPDATE closer and limit the race condition possibilities. Test plan: 0. Set RenewalSendNotice and circ rules to have a lot of renewals available 1. Use batch checkouts (or one by one) to check out several items to a patron 2. Empty message_queue (at least of this patron) 3. Renew them all at once ("select all" link, "renew or check in" button) 4. Check the message_queue Without this patch you have lot of chances to faced a race condition and get at least 2 messages for the same patron. This is not expected, we expect 1 digest with all the messages. With this patch apply you have lot of chances not to face it, but it's not 100% safe as we do not use a mechanism to lock the table at the DBMS level. Tested both patches together, works as expected. Signed-off-by: Marc V?ron -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Mar 3 20:25:08 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 03 Mar 2017 19:25:08 +0000 Subject: [Koha-bugs] [Bug 15854] Race condition for sending renewal/check-in notices In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15854 Marc V?ron changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #60058|0 |1 is obsolete| | --- Comment #7 from Marc V?ron --- Created attachment 60814 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=60814&action=edit Bug 15854: Use a READ and WRITE LOCK on message_queue To make sure we will not never get a race conditions for these kinds of notices, we need to add a LOCK on the message_queue table. This does not smell the best way to do that, but I faced deadlock issues when I tried to use "UPDATE FOR" https://dev.mysql.com/doc/refman/5.7/en/innodb-locking-reads.html https://dev.mysql.com/doc/refman/5.7/en/lock-tables.html https://dev.mysql.com/doc/refman/5.7/en/commit.html To test this patch, or another solution, you need to apply manually this change: my $message = C4::Message->find_last_message($borrower, $type, $mtt); unless ( $message ) { + sleep(1); C4::Message->enqueue($letter, $borrower, $mtt); } else { And repeat the test plan from first patch. Do not forget to truncate the message_queue table. Followed test plans, works as expected. Signed-off-by: Marc V?ron -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Mar 3 20:25:34 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 03 Mar 2017 19:25:34 +0000 Subject: [Koha-bugs] [Bug 15854] Race condition for sending renewal/check-in notices In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15854 Marc V?ron changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |veron at veron.ch Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Mar 3 20:29:16 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 03 Mar 2017 19:29:16 +0000 Subject: [Koha-bugs] [Bug 16202] Rental fees can be generated for fractions of a penny/cent In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16202 Kyle M Hall changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to Master CC| |kyle at bywatersolutions.com --- Comment #18 from Kyle M Hall --- Pushed to master for 17.05, thanks Colin! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Mar 3 20:29:58 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 03 Mar 2017 19:29:58 +0000 Subject: [Koha-bugs] [Bug 18208] Add RecordProcessor filter to inject not onloan count to MARC records In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18208 Marc V?ron changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #60812|0 |1 is obsolete| | --- Comment #2 from Marc V?ron --- Created attachment 60815 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=60815&action=edit Bug 18208: Add RecordProcessor filter to inject not onloan count to MARC records This patch adds a new filter for MARC records to be used with Koha::RecordProcessor. It's purpose is to inject the information about items not-onloan in a fixed subfield, 999$x. To test: - Apply the patch - Run: $ prove t/db_dependent/Koha/Filter/EmbedItemsAvailability.t => SUCCESS: Tests pass! - Sign off :-D Sponsored-by: ByWater Solutions Followed test plan, test passes OK Signed-off-by: Marc V?ron -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Mar 3 20:30:23 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 03 Mar 2017 19:30:23 +0000 Subject: [Koha-bugs] [Bug 18208] Add RecordProcessor filter to inject not onloan count to MARC records In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18208 Marc V?ron changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off CC| |veron at veron.ch -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Mar 3 20:46:35 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 03 Mar 2017 19:46:35 +0000 Subject: [Koha-bugs] [Bug 7611] Show the NOT_LOAN authorised values for item status in XSLT OPAC search results. In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7611 Mehdi Hamidi changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #7907|0 |1 is obsolete| | --- Comment #9 from Mehdi Hamidi --- Created attachment 60816 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=60816&action=edit Bug 7611 - Show the NOT_LOAN authorised values for item status in XSLT OPAC search results Added : Call number for all not for loan status XSLT Results template improvement : Use the NOT_LOAN authorised values Improvement : Use the NOT_LOAN authorised values when showing items status in the OPAC search results. Before this patch, these items were only considered as "unavailable". Note : This patch only affects the OPAC XSLT search results template for MARC21 records. This patch was not tested on UNIMARC or NORMARC records. I won't be able to support these formats, so I'm hoping someone could do the same for these other record formats. Patch sponsored by the CCSR ( http://www.ccsr.qc.ca ) -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Mar 3 20:46:32 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 03 Mar 2017 19:46:32 +0000 Subject: [Koha-bugs] [Bug 7611] Show the NOT_LOAN authorised values for item status in XSLT OPAC search results. In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7611 Mehdi Hamidi changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Mar 3 20:46:55 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 03 Mar 2017 19:46:55 +0000 Subject: [Koha-bugs] [Bug 7611] Show the NOT_LOAN authorised values for item status in XSLT OPAC search results. In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7611 Mehdi Hamidi changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |mehdi.hamidi at inlibro.com -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Mar 3 20:50:51 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 03 Mar 2017 19:50:51 +0000 Subject: [Koha-bugs] [Bug 8995] Show OpenURL links in OPAC search results In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8995 M. Tompsett changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |mtompset at hotmail.com --- Comment #62 from M. Tompsett --- If one fixes the opac.less (easy to fix), and recompiles the opac.css (easy to do in kohadevbox -- mine isn't booted), this patch set could be rescued. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Mar 3 20:51:35 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 03 Mar 2017 19:51:35 +0000 Subject: [Koha-bugs] [Bug 7534] New OPACAllowUserToChooseBranch setting for only showing libraries allowing holds In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7534 --- Comment #25 from Chris Kirby --- Hi Lari, On my kohadevbox, I am still getting plack errors: Template process failed: undef error - The method pickup_location is not covered by tests! at /usr/share/koha/lib/C4/Templates.pm line 121. If there is something else you would like me to try testing for this, let me know. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Fri Mar 3 22:24:16 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 03 Mar 2017 21:24:16 +0000 Subject: [Koha-bugs] [Bug 18209] New: Patron's card manage.pl page is not fully translatable Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18209 Bug ID: 18209 Summary: Patron's card manage.pl page is not fully translatable Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: minor Priority: P5 - low Component: Label/patron card printing Assignee: cnighswonger at foundations.edu Reporter: philippe.blouin at inlibro.com QA Contact: testopia at bugs.koha-community.org The headers of the tables displayed in patroncards/manage.tt are hardcoded in the .pl and thus cannot be translated. This simple fix reuse the translate_card_element tool already in the code to make the strings translatable. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Mar 3 22:26:20 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 03 Mar 2017 21:26:20 +0000 Subject: [Koha-bugs] [Bug 18209] Patron's card manage.pl page is not fully translatable In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18209 --- Comment #1 from Blou --- Created attachment 60817 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=60817&action=edit Bug 18209 - Patron's card manage.pl page is not fully translatable The headers of the tables displayed in patroncards/manage.tt are hardcoded in the .pl and thus cannot be translated. This simple fix reuse the translate_card_element tool already in the code to make the strings translatable. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Mar 3 22:28:15 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 03 Mar 2017 21:28:15 +0000 Subject: [Koha-bugs] [Bug 18209] Patron's card manage.pl page is not fully translatable In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18209 Blou changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |francois.charbonnier at inlibr | |o.com, | |philippe.blouin at inlibro.com Status|NEW |Needs Signoff Patch complexity|--- |Trivial patch Assignee|cnighswonger at foundations.ed |philippe.blouin at inlibro.com |u | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Mar 3 22:42:19 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 03 Mar 2017 21:42:19 +0000 Subject: [Koha-bugs] [Bug 15438] Checking out an on-hold item sends holder' s borrowernumber in AF (screen message) field. In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15438 --- Comment #17 from rkuiper at roundrocktexas.gov --- Do we have any movement on this bug fix. This is a privacy concern for our patrons. Rhonda Kuiper -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Mar 3 22:54:40 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 03 Mar 2017 21:54:40 +0000 Subject: [Koha-bugs] [Bug 18098] Add an index with the count of not onloan items In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18098 Tom?s Cohen Arazi changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #60123|0 |1 is obsolete| | --- Comment #3 from Tom?s Cohen Arazi --- Created attachment 60818 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=60818&action=edit Bug 18098: Add an index with the count of not onloan items This patch adds a numeric index 'not-onloan-count' containing the value of 999$x. This subfield is filled by 'rebuild_zebra.pl' by making use of (bug's 18208) 'EmbedItemsAvailability' filter. bib1.att and indexes definitions are updated accordingly. To test: - Apply the patch - Pick the right biblio-zebra-indexdefs.xsl file for your setup and replace the one your Zebra uses [1] - Replace your bib1.att - Replace your ccl.properties - Have at least one record with more than one item, checkout some item(s) from that record(s). - Rebuild zebra's indexes: $ sudo koha-shell kohadev k$ cd kohaclone k$ misc/migration_tools/rebuild_zebra.pl -r -b -v -k (notice the dump directory is kept, you can try the XSLT yourself running: $ xsltproc \ etc/zebradb/marc_defs/marc21/biblios/biblio-zebra-indexdefs.xsl \ /tmp/the_dump_dir/biblios/exported_records | less => SUCCESS: There are records with the not-onloan-count index, and the value is correct! - Check Zebra yourself: $ yaz-client unix:/var/run/koha/kohadev/bibliosocket Z> base biblios Z> find @attr 1=9013 @attr 2=5 @attr 4=109 0 => SUCCESS: The search matches the amount of records with not-onloan items. Z> s 1+1 => SUCCESS: Records with 999$x having a value higher than 0 are rendered - Sign off :-D Note: While this work is complete on its purpose, it is part of an attempt to create a better way of filtering by availability. Sponsored-by: ByWater Solutions [1] In kohadevbox this would be /etc/koha/zebradb/marc_defs/marc21/biblios/biblio-zebra-indexdefs.xsl -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Mar 3 22:55:12 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 03 Mar 2017 21:55:12 +0000 Subject: [Koha-bugs] [Bug 18208] Add RecordProcessor filter to inject not onloan count to MARC records In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18208 Tom?s Cohen Arazi changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |18098 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18098 [Bug 18098] Add an index with the count of not onloan items -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Mar 3 22:55:12 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 03 Mar 2017 21:55:12 +0000 Subject: [Koha-bugs] [Bug 18098] Add an index with the count of not onloan items In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18098 Tom?s Cohen Arazi changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on| |18208 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18208 [Bug 18208] Add RecordProcessor filter to inject not onloan count to MARC records -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Mar 3 22:55:27 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 03 Mar 2017 21:55:27 +0000 Subject: [Koha-bugs] [Bug 18098] Add an index with the count of not onloan items In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18098 Tom?s Cohen Arazi changed: What |Removed |Added ---------------------------------------------------------------------------- Change sponsored?|--- |Sponsored Patch complexity|--- |Small patch -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Mar 3 22:56:01 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 03 Mar 2017 21:56:01 +0000 Subject: [Koha-bugs] [Bug 18098] Add an index with the count of not onloan items In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18098 Tom?s Cohen Arazi changed: What |Removed |Added ---------------------------------------------------------------------------- See Also|https://bugs.koha-community | |.org/bugzilla3/show_bug.cgi | |?id=17297 | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Mar 3 22:56:01 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 03 Mar 2017 21:56:01 +0000 Subject: [Koha-bugs] [Bug 17297] Give librarians the ability to add messages to an item In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17297 Tom?s Cohen Arazi changed: What |Removed |Added ---------------------------------------------------------------------------- See Also|https://bugs.koha-community | |.org/bugzilla3/show_bug.cgi | |?id=18098 | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Mar 4 00:10:45 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 03 Mar 2017 23:10:45 +0000 Subject: [Koha-bugs] [Bug 18182] TestBuilder should be able to return Koha::Object objects In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18182 --- Comment #1 from Tom?s Cohen Arazi --- Created attachment 60819 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=60819&action=edit Bug 18182: Make TestBuilder capable of returning Koha::Object This patch adds a new method to t::lib::TestBuilder so it can return Koha::Object-derived objects. The new method is called ->build_object and requires the plural of the target class to be passed, along with the field to be used as id on searching the object. The plural is because the singular form is not aware of its plural (I always thought we should move plural stuff into the singular class, this is one of the reasons). The id is required because that's the way to find the recently created object. If any of those parameters is ommited, a warning is raised and undef is returned. To test: - Apply the patches - Run: $ sudo koha-shell kohadev k$ cd kohaclone k$ prove t/db_dependent/TestBuilder.t => SUCCESS: Tests pass! - Sign off :-D Sponsored-by: ByWater Solutions -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Mar 4 00:10:50 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 03 Mar 2017 23:10:50 +0000 Subject: [Koha-bugs] [Bug 18182] TestBuilder should be able to return Koha::Object objects In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18182 --- Comment #2 from Tom?s Cohen Arazi --- Created attachment 60820 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=60820&action=edit Bug 18182: (followup) Add POD -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Mar 4 00:13:03 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 03 Mar 2017 23:13:03 +0000 Subject: [Koha-bugs] [Bug 18182] TestBuilder should be able to return Koha::Object objects In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18182 Tom?s Cohen Arazi changed: What |Removed |Added ---------------------------------------------------------------------------- Change sponsored?|--- |Sponsored Patch complexity|--- |Small patch -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Mar 4 00:13:11 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 03 Mar 2017 23:13:11 +0000 Subject: [Koha-bugs] [Bug 18182] TestBuilder should be able to return Koha::Object objects In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18182 Tom?s Cohen Arazi changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Mar 4 10:27:53 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 04 Mar 2017 09:27:53 +0000 Subject: [Koha-bugs] [Bug 7611] Show the NOT_LOAN authorised values for item status in XSLT OPAC search results. In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7611 Marcel de Rooy changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |m.de.rooy at rijksmuseum.nl -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Mar 4 13:43:53 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 04 Mar 2017 12:43:53 +0000 Subject: [Koha-bugs] [Bug 18210] New: Allow API to update/ merge bibliographic records & not just replace Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18210 Bug ID: 18210 Summary: Allow API to update/ merge bibliographic records & not just replace Change sponsored?: --- Product: Koha Version: unspecified Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Cataloging Assignee: gmcharlt at gmail.com Reporter: bibliwho at gmail.com QA Contact: testopia at bugs.koha-community.org CC: m.de.rooy at rijksmuseum.nl The Koha API allows for existing records to be replaced/ overlaid wholesale with data provided. It would be great to have the option of updating records as well, i.e., changing only data/ fields that are included in a source file while preserving all data/ fields not in the source file. This would require a means of identifying fields that are protected from overlay on import. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Mar 4 17:51:16 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 04 Mar 2017 16:51:16 +0000 Subject: [Koha-bugs] [Bug 18185] Clears loan history In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18185 Ricardo Vargas changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |ricvargasmed at gmail.com --- Comment #4 from Ricardo Vargas --- To reproduce this error I did the following. - Provide a copy to a user - Check movement history - All loans that the user has - Return the sample - Check movement history - The user loans will be displayed, without the last one returned Note: sometimes I save the returns, but the 3 exercises reproduced the error. Tested on Koha 16.05 and 16.11 installed by packages in Debian 8 and Ubuntu 16.04 LTS -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Mar 4 18:16:08 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 04 Mar 2017 17:16:08 +0000 Subject: [Koha-bugs] [Bug 18200] Fix a potential issue with preceding space in GetMarcUrls In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18200 --- Comment #4 from Marcel de Rooy --- (In reply to Marc V?ron from comment #3) > Question: The biblionumber is always added to the link, something like: > > http://XXXXXXXXXXX/cgi-bin/koha/tracklinks.pl?uri=http://www.yyyyyyyyyy. > com&biblionumber=52 > > It happens with and without patch (with OPACXSLTDetailsDisplay empty). > > Is this behaviour expected? This behavior is triggered by pref TrackClicks. It manipulates the URL and appends a biblionumber. Thanks for testing. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Mar 4 20:21:14 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 04 Mar 2017 19:21:14 +0000 Subject: [Koha-bugs] [Bug 18211] New: Circulation.pl / Moremember.pl has errors in table row id Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18211 Bug ID: 18211 Summary: Circulation.pl / Moremember.pl has errors in table row id Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: minor Priority: P5 - low Component: Circulation Assignee: koha-bugs at lists.koha-community.org Reporter: cbrannon at cdalibrary.org QA Contact: testopia at bugs.koha-community.org CC: gmcharlt at gmail.com, kyle.m.hall at gmail.com The table row showing the label "Today's checkouts" shows the id of "group-id-issues-table_-strong-today-s-checkouts-strong-" The id is inaccurate and is taking on values from a child cell. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Mar 4 22:44:45 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 04 Mar 2017 21:44:45 +0000 Subject: [Koha-bugs] [Bug 18212] New: Move SQL code from aqplan.pl administrative script into a C4 perl module Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18212 Bug ID: 18212 Summary: Move SQL code from aqplan.pl administrative script into a C4 perl module Change sponsored?: --- Product: Koha Version: 17.05 Hardware: All OS: All Status: ASSIGNED Severity: enhancement Priority: P5 - low Component: Architecture, internals, and plumbing Assignee: alexbuckley at catalyst.net.nz Reporter: alexbuckley at catalyst.net.nz QA Contact: testopia at bugs.koha-community.org This bug report requires the removal of SQL code out of the administrative script aqplan.pl and placed into a perl module in C4 directory. Instead of placing the SQL code directly into a subroutine in a C4 module the database query will be re-written as a DBIx query. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Mar 5 11:37:44 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 05 Mar 2017 10:37:44 +0000 Subject: [Koha-bugs] [Bug 18188] Should we rename items.booksellerid to items.acqsource ? In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18188 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |katrin.fischer at bsz-bw.de --- Comment #2 from Katrin Fischer --- At the moment we use it in both ways in our library. Libraries not using the acquisitions module use it as a free text field adding the name of the vendor there. In libraries using the acquisitions module the booksellerid of the vendor is added by the acquisitions module. I am not sure what we will win by renaming it? -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Mar 5 11:42:03 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 05 Mar 2017 10:42:03 +0000 Subject: [Koha-bugs] [Bug 18187] finishreceive.pl: Save bookseller name into items acquisition source field In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18187 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |katrin.fischer at bsz-bw.de --- Comment #2 from Katrin Fischer --- I think we do want the information in the item, as some libraries might not keep the acquisitions information forever. A clean solution might be to have a free text field to use manually and a proper booksellerid field. As receiving is the last step, I think overwriting there with the latest vendor makes kind of sense to me. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Mar 5 11:44:27 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 05 Mar 2017 10:44:27 +0000 Subject: [Koha-bugs] =?utf-8?q?=5BBug_18190=5D_the_=22Delete=22__action_on?= =?utf-8?q?_Home_=E2=80=BA_Reports_=E2=80=BA_Guided_reports_wizard_?= =?utf-8?q?=E2=80=BA_Saved_reports_should_hide_reports_rather_than_deletin?= =?utf-8?q?g_them?= In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18190 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |katrin.fischer at bsz-bw.de --- Comment #1 from Katrin Fischer --- I am not sure about this one. Another idea: Make delete reports a separate permission. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Mar 5 17:00:11 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 05 Mar 2017 16:00:11 +0000 Subject: [Koha-bugs] [Bug 18213] New: Add language facets to Elasticsearch Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18213 Bug ID: 18213 Summary: Add language facets to Elasticsearch Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Searching Assignee: gmcharlt at gmail.com Reporter: nick at bywatersolutions.com QA Contact: testopia at bugs.koha-community.org -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Mar 5 17:00:22 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 05 Mar 2017 16:00:22 +0000 Subject: [Koha-bugs] [Bug 18213] Add language facets to Elasticsearch In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18213 Nick Clemens changed: What |Removed |Added ---------------------------------------------------------------------------- Change sponsored?|--- |Sponsored Assignee|gmcharlt at gmail.com |nick at bywatersolutions.com -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Mar 5 19:44:06 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 05 Mar 2017 18:44:06 +0000 Subject: [Koha-bugs] [Bug 18125] Edit button can duplicate some circulation rule In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18125 --- Comment #5 from Andreas Hedstr?m Mace --- I see your point Baptiste! This could be an interim solution, rather than rewriting the whole circulation rules. But is it perhaps possible to gray out the two dropdowns (patron category and item type) or similar, so that it will be apparent to the users that these are actually not clickable when editing a rule? -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Mar 5 20:09:21 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 05 Mar 2017 19:09:21 +0000 Subject: [Koha-bugs] [Bug 14907] Item search: Call Numbers in Item search results are ordered alphabetically In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14907 Indranil Das Gupta changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |indradg at l2c2.co.in Assignee|gmcharlt at gmail.com |indradg at l2c2.co.in -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Mar 6 09:33:46 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 06 Mar 2017 08:33:46 +0000 Subject: [Koha-bugs] [Bug 13417] New permission to allow staff to remove public lists In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13417 Marcel de Rooy changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |frederic at tamil.fr --- Comment #48 from Marcel de Rooy --- *** Bug 5763 has been marked as a duplicate of this bug. *** -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Mar 6 09:33:46 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 06 Mar 2017 08:33:46 +0000 Subject: [Koha-bugs] [Bug 5763] Add users private list management functionality for administrators In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5763 Marcel de Rooy changed: What |Removed |Added ---------------------------------------------------------------------------- Resolution|--- |DUPLICATE Status|NEW |RESOLVED --- Comment #9 from Marcel de Rooy --- (In reply to Katrin Fischer from comment #8) > There is now a way to delete public lists covered by a separate permission. We can close this bug now. See bug 13417. *** This bug has been marked as a duplicate of bug 13417 *** -- You are receiving this mail because: You are watching all bug changes. You are the QA Contact for the bug. From bugzilla-daemon at bugs.koha-community.org Mon Mar 6 09:33:48 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 06 Mar 2017 08:33:48 +0000 Subject: [Koha-bugs] [Bug 7310] Improving permissions on lists (virtual shelves) In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7310 Bug 7310 depends on bug 5763, which changed state. Bug 5763 Summary: Add users private list management functionality for administrators https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5763 What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |RESOLVED Resolution|--- |DUPLICATE -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Mar 6 09:33:58 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 06 Mar 2017 08:33:58 +0000 Subject: [Koha-bugs] [Bug 5763] Add users private list management functionality for administrators In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5763 Marcel de Rooy changed: What |Removed |Added ---------------------------------------------------------------------------- Status|RESOLVED |CLOSED -- You are receiving this mail because: You are watching all bug changes. You are the QA Contact for the bug. From bugzilla-daemon at bugs.koha-community.org Mon Mar 6 09:44:25 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 06 Mar 2017 08:44:25 +0000 Subject: [Koha-bugs] [Bug 18214] New: Cannot edit list permissions of a private list Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18214 Bug ID: 18214 Summary: Cannot edit list permissions of a private list Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: normal Priority: P5 - low Component: Lists Assignee: gmcharlt at gmail.com Reporter: m.de.rooy at rijksmuseum.nl QA Contact: testopia at bugs.koha-community.org CC: m.de.rooy at rijksmuseum.nl If you have disabled the pref OpacAllowPublicListCreation, your users are not able to edit the list permissions for private/shared lists. For a private list they may only be theoretically relevant, but for a shared list they are relevant. Since we do not always know the history of a list (has it been public or shared, does it contains entries from other users) and therefore permissions are even relevant for a currently private list, we should just allow editing these permissions. Trivial change in opac-shelves template. No need to change staff side. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Mar 6 09:44:39 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 06 Mar 2017 08:44:39 +0000 Subject: [Koha-bugs] [Bug 18214] Cannot edit list permissions of a private list In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18214 Marcel de Rooy changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |ASSIGNED Assignee|gmcharlt at gmail.com |m.de.rooy at rijksmuseum.nl -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Mar 6 09:52:13 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 06 Mar 2017 08:52:13 +0000 Subject: [Koha-bugs] [Bug 18214] Cannot edit list permissions of a private list In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18214 Marcel de Rooy changed: What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Mar 6 09:52:16 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 06 Mar 2017 08:52:16 +0000 Subject: [Koha-bugs] [Bug 18214] Cannot edit list permissions of a private list In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18214 --- Comment #1 from Marcel de Rooy --- Created attachment 60821 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=60821&action=edit Bug 18214: Cannot edit list permissions of a private list If you have disabled the pref OpacAllowPublicListCreation, your users are not able to edit the list permissions for private/shared lists. For a private list they may only be theoretically relevant, but for a shared list they are relevant. Since we do not always know the history of a list (has it been public or shared, does it contains entries from other users) and therefore permissions are even relevant for a currently private list, we should just allow editing these permissions. Test plan: [1] Do not yet apply this patch. [2] Disable OpacAllowPublicListCreation. [3] Create a private list in OPAC. Edit the list. Verify that you do not see the permission combo boxes. [4] Apply this patch. Edit the list again. Do they appear now? Signed-off-by: Marcel de Rooy -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Mar 6 09:52:33 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 06 Mar 2017 08:52:33 +0000 Subject: [Koha-bugs] [Bug 18214] Cannot edit list permissions of a private list In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18214 Marcel de Rooy changed: What |Removed |Added ---------------------------------------------------------------------------- Patch complexity|--- |Trivial patch -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Mar 6 09:55:35 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 06 Mar 2017 08:55:35 +0000 Subject: [Koha-bugs] [Bug 18210] Allow API to update/ merge bibliographic records & not just replace In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18210 Magnus Enger changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |magnus at libriotech.no See Also| |https://bugs.koha-community | |.org/bugzilla3/show_bug.cgi | |?id=14957 --- Comment #1 from Magnus Enger --- (In reply to Cab Vinton from comment #0) > This would require a means of identifying fields that are protected from > overlay on import. Have you looked at "Bug 14957 - Write protecting MARC fields based on source of import"? -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Mar 6 09:55:35 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 06 Mar 2017 08:55:35 +0000 Subject: [Koha-bugs] [Bug 14957] Write protecting MARC fields based on source of import In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14957 Magnus Enger changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |https://bugs.koha-community | |.org/bugzilla3/show_bug.cgi | |?id=18210 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Mar 6 10:17:59 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 06 Mar 2017 09:17:59 +0000 Subject: [Koha-bugs] [Bug 13913] Renewal error message in OPAC is confusing In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13913 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Summary|Renewal error message in |Renewal error message in |OPAC is not correct |OPAC is confusing --- Comment #2 from Katrin Fischer --- We have another report on this. Currently, all reasons why a renewal failed are listed as unformatted text and it's very hard to see, which message applies to which checkout. We shoudl fix this to show the specific reasons with the issues and only a general message on top. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Mar 6 10:25:27 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 06 Mar 2017 09:25:27 +0000 Subject: [Koha-bugs] [Bug 18214] Cannot edit list permissions of a private list In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18214 Magnus Enger changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Mar 6 10:25:30 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 06 Mar 2017 09:25:30 +0000 Subject: [Koha-bugs] [Bug 18214] Cannot edit list permissions of a private list In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18214 Magnus Enger changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #60821|0 |1 is obsolete| | --- Comment #2 from Magnus Enger --- Created attachment 60822 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=60822&action=edit Bug 18214: Cannot edit list permissions of a private list If you have disabled the pref OpacAllowPublicListCreation, your users are not able to edit the list permissions for private/shared lists. For a private list they may only be theoretically relevant, but for a shared list they are relevant. Since we do not always know the history of a list (has it been public or shared, does it contains entries from other users) and therefore permissions are even relevant for a currently private list, we should just allow editing these permissions. Test plan: [1] Do not yet apply this patch. [2] Disable OpacAllowPublicListCreation. [3] Create a private list in OPAC. Edit the list. Verify that you do not see the permission combo boxes. [4] Apply this patch. Edit the list again. Do they appear now? Signed-off-by: Marcel de Rooy Signed-off-by: Magnus Enger Works as advertised. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Mar 6 10:40:04 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 06 Mar 2017 09:40:04 +0000 Subject: [Koha-bugs] [Bug 18215] New: Resolve warning on $tls in Database.pm Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18215 Bug ID: 18215 Summary: Resolve warning on $tls in Database.pm Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Architecture, internals, and plumbing Assignee: gmcharlt at gmail.com Reporter: m.de.rooy at rijksmuseum.nl QA Contact: testopia at bugs.koha-community.org updatedatabase.pl: Use of uninitialized value $tls in string eq at /usr/share/koha/masterclone/Koha/Database.pm line 63. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Mar 6 10:41:34 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 06 Mar 2017 09:41:34 +0000 Subject: [Koha-bugs] [Bug 18215] Resolve warning on $tls in Database.pm In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18215 Marcel de Rooy changed: What |Removed |Added ---------------------------------------------------------------------------- Patch complexity|--- |Trivial patch Status|NEW |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Mar 6 10:41:36 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 06 Mar 2017 09:41:36 +0000 Subject: [Koha-bugs] [Bug 18215] Resolve warning on $tls in Database.pm In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18215 --- Comment #1 from Marcel de Rooy --- Created attachment 60823 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=60823&action=edit Bug 18215: Resolve warning on $tls in Database.pm Resolve this warning: updatedatabase.pl: Use of uninitialized value $tls in string eq at /usr/share/koha/masterclone/Koha/Database.pm line 63. Test plan: [1] Check if you do not see the warning anymore. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Mar 6 10:43:27 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 06 Mar 2017 09:43:27 +0000 Subject: [Koha-bugs] [Bug 18215] Resolve warning on $tls in Database.pm In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18215 Marcel de Rooy changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|gmcharlt at gmail.com |m.de.rooy at rijksmuseum.nl Severity|enhancement |normal -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Mar 6 10:55:45 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 06 Mar 2017 09:55:45 +0000 Subject: [Koha-bugs] [Bug 18202] Define profiles for Z39.50 server targets In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18202 --- Comment #1 from Marcel de Rooy --- Not for this specific issue, but note that we have defined a field for SRU search mappings in the z3950servers table. If you add a new SRU server, you can open the admin/sru_modmapping.pl form. This sounds like something similar for Z3950. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Mar 6 10:59:24 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 06 Mar 2017 09:59:24 +0000 Subject: [Koha-bugs] [Bug 14957] Write protecting MARC fields based on source of import In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14957 David Gustafsson changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #60711|0 |1 is obsolete| | --- Comment #45 from David Gustafsson --- Created attachment 60824 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=60824&action=edit Bug 14957 - Rule based permission for MARC fields Add a rule based permission system for MARC field modifications. Test plan: 1. Apply this patch 2. Run updatedatabase.pl 3. Log in to staff client 4. Enable new syspref MARCPermissions 5. You should see a new link "MARC field permissions" in the "Catalog" section under "Koha administrtion". 6. Go to the "MARC field permissions" page 7. Next to the page heading ("Manage MARC field permissions") there is a button with a question mark, click this for more information about the rule system. 8. Add desired rules to the rule table, press the +-button to add. 9. Clicking the pen-icon (edit) should allow you to edit corresponding rule. 10. Clicking the x-icon should remove corresponding rule after confirmation. 11. Selecting one or more rules followed by clicking the trash-icon should remove all selected rules after confirmation. 12. To test your rules, import or in other way modify a record. 13. Check that the record was modified as defined by your rules. Sponsored-by: Halland County Library -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Mar 6 11:00:30 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 06 Mar 2017 10:00:30 +0000 Subject: [Koha-bugs] [Bug 14957] Write protecting MARC fields based on source of import In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14957 --- Comment #46 from David Gustafsson --- Screwed up the last merge. Should be fixed now. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Mar 6 11:03:43 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 06 Mar 2017 10:03:43 +0000 Subject: [Koha-bugs] [Bug 14957] Write protecting MARC fields based on source of import In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14957 --- Comment #47 from David Gustafsson --- Nope, still managed to screw it up. Should be ok now. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Mar 6 11:04:35 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 06 Mar 2017 10:04:35 +0000 Subject: [Koha-bugs] [Bug 14957] Write protecting MARC fields based on source of import In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14957 David Gustafsson changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #60824|0 |1 is obsolete| | --- Comment #48 from David Gustafsson --- Created attachment 60825 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=60825&action=edit Bug 14957 - Rule based permission for MARC fields Add a rule based permission system for MARC field modifications. Test plan: 1. Apply this patch 2. Run updatedatabase.pl 3. Log in to staff client 4. Enable new syspref MARCPermissions 5. You should see a new link "MARC field permissions" in the "Catalog" section under "Koha administrtion". 6. Go to the "MARC field permissions" page 7. Next to the page heading ("Manage MARC field permissions") there is a button with a question mark, click this for more information about the rule system. 8. Add desired rules to the rule table, press the +-button to add. 9. Clicking the pen-icon (edit) should allow you to edit corresponding rule. 10. Clicking the x-icon should remove corresponding rule after confirmation. 11. Selecting one or more rules followed by clicking the trash-icon should remove all selected rules after confirmation. 12. To test your rules, import or in other way modify a record. 13. Check that the record was modified as defined by your rules. Sponsored-by: Halland County Library -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Mar 6 11:28:05 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 06 Mar 2017 10:28:05 +0000 Subject: [Koha-bugs] [Bug 12904] Force browser to load new javascript files after upgrade In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12904 Olli-Antti Kivilahti changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #58393|0 |1 is obsolete| | --- Comment #66 from Olli-Antti Kivilahti --- Created attachment 60826 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=60826&action=edit Bug 12904 - Force browser to load new javascript files after upgrade A common issue with Koha seems to be that the web browsers continue to use cached js files after an upgrade. If we append the version as a parameter, we can force the browser to update the javascript files. 1) Apply this patch on a new branch based on master. 2) In a separate branch check out a previous version of Koha and go through the installation process on an empty database. 3) After logging into Koha, turn on Firebug's Net panel (or Chrome's Network panel) and turn on the filter for JavaScript files. 4) Clear the browser cache and navigate to a page, for instance Circulation. In Firebug the Net panel should show a status of "200 OK" for all files, indicating that the file was downloaded, not loaded from the cache. In Chrome the "size" column will show a file size if the file was downloaded. 5) Navigate to another page and confirm that scripts are being loaded from the cache: Scripts like jquery.js and jquery-ui.js which are loaded on every page should have a status in the Firebug Net panel of "304 Not Modified." In Chrome the "size" columns should show "from cache." 6) Check out the branch you created for testing this patch. 7) In order to preserve the state of your browser cache for accurate testing, open a different browser from the one you were previously testing with, load Koha, and run through the database update. 8) Return to your original testing browser and navigate to another Koha page. Firebug's Net panel should show that script files are now being downloaded with a "koha_version" query string. These files should have a status of "200 OK" indicating that they are being downloaded, not loaded from the cache. 9) Navigate to another page and conifrm that the new versions of the scripts are being loaded from the cache. To confirm that all affected JavaScripts links are working correctly, test these pages by checking the Firebug Net panel for errors: - Administration -> Currencies and exchange rates (jquery.dataTables.colvis.js) - Tools -> Stage MARC records for import (ajaxfileupload.js) or another page which performs a file upload. - Catalog -> Detail page -> MARC Preview (greybox JS) - Help -> Any help page - Any page which loads DataTables (Circulation in the staff client, for instance, and a title's detail page in the OPAC) - Bonus points if you check the various conditional JS includes controlled by the many OPAC feature preferences Signed-off-by: Nick Clemens Signed-off-by: Olli-Antti Kivilahti -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Mar 6 11:28:50 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 06 Mar 2017 10:28:50 +0000 Subject: [Koha-bugs] [Bug 12904] Force browser to load new javascript files after upgrade In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12904 Olli-Antti Kivilahti changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #58394|0 |1 is obsolete| | --- Comment #67 from Olli-Antti Kivilahti --- Created attachment 60827 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=60827&action=edit Bug 12904 - Update template css and js file references Signed-off-by: Nick Clemens Signed-off-by: Olli-Antti Kivilahti -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Mar 6 11:28:52 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 06 Mar 2017 10:28:52 +0000 Subject: [Koha-bugs] [Bug 18173] Remove issues.return In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18173 Magnus Enger changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #60696|0 |1 is obsolete| | --- Comment #2 from Magnus Enger --- Created attachment 60828 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=60828&action=edit Bug 18173: Remove DB field issues.return The DB field issues.return has never really been used apparently. I found the first occurrence of this field in commit eac3a7b19a8aa7cda34aac396f5093c213a4aa5a CommitDate: Mon Mar 12 22:43:47 2001 +0000 Database definition file, checked into cvs to make keeping database current easier Since I did not find any use of this field. I guess it can be removed safely. There is no proper test plan here. Just make sure this field has never been used. Signed-off-by: Magnus Enger I have not found any use of issues.return or old_issues.return. In all my live instances the column is always NULL. Issuing and returning seems to work as expected after the columns have been removed. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Mar 6 11:29:26 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 06 Mar 2017 10:29:26 +0000 Subject: [Koha-bugs] [Bug 18173] Remove issues.return In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18173 Magnus Enger changed: What |Removed |Added ---------------------------------------------------------------------------- Patch complexity|--- |Trivial patch Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Mar 6 11:29:29 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 06 Mar 2017 10:29:29 +0000 Subject: [Koha-bugs] [Bug 18173] Remove issues.return In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18173 Magnus Enger changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #60828|0 |1 is obsolete| | --- Comment #3 from Magnus Enger --- Created attachment 60829 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=60829&action=edit Bug 18173: Remove DB field issues.return The DB field issues.return has never really been used apparently. I found the first occurrence of this field in commit eac3a7b19a8aa7cda34aac396f5093c213a4aa5a CommitDate: Mon Mar 12 22:43:47 2001 +0000 Database definition file, checked into cvs to make keeping database current easier Since I did not find any use of this field. I guess it can be removed safely. There is no proper test plan here. Just make sure this field has never been used. Signed-off-by: Magnus Enger I have not found any use of issues.return or old_issues.return. In all my live instances the column is always NULL. Issuing and returning seems to work as expected after the columns have been removed. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Mar 6 11:29:45 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 06 Mar 2017 10:29:45 +0000 Subject: [Koha-bugs] [Bug 12904] Force browser to load new javascript files after upgrade In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12904 Olli-Antti Kivilahti changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #58395|0 |1 is obsolete| | --- Comment #68 from Olli-Antti Kivilahti --- Created attachment 60830 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=60830&action=edit Bug 12904 [QA Followup] - Don't send 301 status Signed-off-by: Nick Clemens Signed-off-by: Olli-Antti Kivilahti -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Mar 6 11:33:44 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 06 Mar 2017 10:33:44 +0000 Subject: [Koha-bugs] [Bug 12904] Force browser to load new javascript files after upgrade In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12904 --- Comment #69 from Olli-Antti Kivilahti --- Created attachment 60831 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=60831&action=edit Bug 12904 - Add mod_expire to etc/koha-httpd.conf Has a positive effect on page loads for crazy dev-installs as well. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Mar 6 11:38:12 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 06 Mar 2017 10:38:12 +0000 Subject: [Koha-bugs] [Bug 18215] Resolve warning on $tls in Database.pm In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18215 Magnus Enger changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Mar 6 11:38:15 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 06 Mar 2017 10:38:15 +0000 Subject: [Koha-bugs] [Bug 18215] Resolve warning on $tls in Database.pm In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18215 Magnus Enger changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #60823|0 |1 is obsolete| | --- Comment #2 from Magnus Enger --- Created attachment 60832 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=60832&action=edit Bug 18215: Resolve warning on $tls in Database.pm Resolve this warning: updatedatabase.pl: Use of uninitialized value $tls in string eq at /usr/share/koha/masterclone/Koha/Database.pm line 63. Test plan: [1] Check if you do not see the warning anymore. Signed-off-by: Magnus Enger Warning disappears after applying the patch. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Mar 6 11:38:43 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 06 Mar 2017 10:38:43 +0000 Subject: [Koha-bugs] [Bug 12904] Force browser to load new javascript files after upgrade In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12904 --- Comment #70 from Olli-Antti Kivilahti --- Rebased to master. (In reply to Jonathan Druart from comment #65) > Can you explain this patch? Yes. Without this bad things will happen when caching is used. Our page load times drop at best 2-4 seconds depending on the env we run Koha. Better than plack :) When the Koha-version changes, the urls for all static web-assets dynamically change to point at the new Koha-version. This forces the browser to reload new versions of javascript-code. You cannot really cache static web-content without a way of invalidating the user's cache, because then after version upgrades, some browsers would use old javascript code and bad things would happen. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Mar 6 11:52:06 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 06 Mar 2017 10:52:06 +0000 Subject: [Koha-bugs] [Bug 18216] New: Apache2.4 403 errors for Gitified or git clone installs Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18216 Bug ID: 18216 Summary: Apache2.4 403 errors for Gitified or git clone installs Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Installation and upgrade (command-line installer) Assignee: gmcharlt at gmail.com Reporter: olli-antti.kivilahti at jns.fi QA Contact: testopia at bugs.koha-community.org Fixes this install step for dev installs: https://wiki.koha-community.org/wiki/Koha_on_ubuntu_-_packages#403_errors_for_Gitified_or_git_clone_installs --SNIP-- 403 errors for Gitified or git clone installs In Ubuntu 14.04 you may discover that your gitified install returns 403 errors - this is because of the changes to Apache directory security. A possible fix includes adding the following stanza to apache2.conf (could be added in the virtualhost, or in one of the koha-shared*.conf files as well): Options Indexes FollowSymLinks AllowOverride None Require all granted --SNAP-- -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Mar 6 11:53:20 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 06 Mar 2017 10:53:20 +0000 Subject: [Koha-bugs] [Bug 18216] Apache2.4 403 errors for Gitified or git clone installs In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18216 --- Comment #1 from Olli-Antti Kivilahti --- Created attachment 60833 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=60833&action=edit Bug 18216 - Apache2 grants access to Koha modules and templates Fixes this install step for dev installs: https://wiki.koha-community.org/wiki/Koha_on_ubuntu_-_packages#403_errors_for_Gitified_or_git_clone_installs --SNIP-- 403 errors for Gitified or git clone installs In Ubuntu 14.04 you may discover that your gitified install returns 403 errors - this is because of the changes to Apache directory security. A possible fix includes adding the following stanza to apache2.conf (could be added in the virtualhost, or in one of the koha-shared*.conf files as well): Options Indexes FollowSymLinks AllowOverride None Require all granted --SNAP-- -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Mar 6 12:01:59 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 06 Mar 2017 11:01:59 +0000 Subject: [Koha-bugs] [Bug 18216] Apache2.4 403 errors for Gitified or git clone installs In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18216 Olli-Antti Kivilahti changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Mar 6 12:07:25 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 06 Mar 2017 11:07:25 +0000 Subject: [Koha-bugs] [Bug 18115] Fix use of Objects as hashref in acqui/ addorderiso2709.pl - Bug 15503 followup In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18115 Matthias Meusburger changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #60811|0 |1 is obsolete| | --- Comment #6 from Matthias Meusburger --- Created attachment 60834 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=60834&action=edit Bug 18115 - Fix use of Objects as hashref in acqui/addorderiso2709.pl - Bug 15503 followup Fix use of 'gstrate' for 'tax_rate' Signed-off-by: Matthias Meusburger -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Mar 6 12:07:39 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 06 Mar 2017 11:07:39 +0000 Subject: [Koha-bugs] [Bug 18115] Fix use of Objects as hashref in acqui/ addorderiso2709.pl - Bug 15503 followup In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18115 Matthias Meusburger changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Mar 6 12:36:04 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 06 Mar 2017 11:36:04 +0000 Subject: [Koha-bugs] [Bug 15108] OAI-PMH provider improvements In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15108 --- Comment #87 from Olli-Antti Kivilahti --- Created attachment 60835 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=60835&action=edit Bug 15108 - OAI-PMH provider improvements - Fixed date handling to use UTC as specs require. - Added support for second precision in time stamps. - Added support for marc21 metadata prefix as recommended in the guidelines (synonym for marcxml). - Improved performance of database queries especially for large collections. - Unified functionality of ListRecords and ListIdentifiers to a common base class. - If items are included in the records, their timestamps are taken into account everywhere so that whichever is the most recent (timestamp of biblioitem or any of its items) is considered the record's timestamp. - Fixed OAI.xslt to show correct record range. - Incorporated extended tests from Bug 17493 and their tweaks from Bug 15108. Signed-off-by: Josef Moravec Signed-off-by: Olli-Antti Kivilahti -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Mar 6 12:36:32 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 06 Mar 2017 11:36:32 +0000 Subject: [Koha-bugs] [Bug 15108] OAI-PMH provider improvements In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15108 Olli-Antti Kivilahti changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #60835|0 |1 is obsolete| | --- Comment #88 from Olli-Antti Kivilahti --- Created attachment 60836 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=60836&action=edit Bug 15108 - OAI-PMH provider improvements Fixed OAI-PMH Server tests to delete any existing issues before deleting biblios, to delete oai_sets to avoid sets in the responses and to work with UNIMARC and NORMARC as well as MARC 21. Signed-off-by: Olli-Antti Kivilahti -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Mar 6 12:42:57 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 06 Mar 2017 11:42:57 +0000 Subject: [Koha-bugs] [Bug 18137] REST API: Migrate from Mojolicious::Plugin:: Swagger2 to Mojolicious::Plugin::OpenAPI In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18137 Olli-Antti Kivilahti changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #60490|0 |1 is obsolete| | --- Comment #11 from Olli-Antti Kivilahti --- Created attachment 60837 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=60837&action=edit Bug 18137: List Mojolicious::Plugin::OpenAPI as Perl dependency This patch also upgrades Mojolicious version requirement to 6.40 as it is the minimum requirement set by Mojolicious::Plugin::OpenAPI. To test: 1. sudo cpanm Mojolicious::Plugin::OpenAPI at 1.10 Signed-off-by: Olli-Antti Kivilahti -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Mar 6 12:43:21 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 06 Mar 2017 11:43:21 +0000 Subject: [Koha-bugs] [Bug 18137] REST API: Migrate from Mojolicious::Plugin:: Swagger2 to Mojolicious::Plugin::OpenAPI In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18137 Olli-Antti Kivilahti changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #60491|0 |1 is obsolete| | --- Comment #12 from Olli-Antti Kivilahti --- Created attachment 60838 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=60838&action=edit Bug 18137: Add useful Koha::Exceptions Signed-off-by: Olli-Antti Kivilahti -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Mar 6 12:43:40 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 06 Mar 2017 11:43:40 +0000 Subject: [Koha-bugs] [Bug 18137] REST API: Migrate from Mojolicious::Plugin:: Swagger2 to Mojolicious::Plugin::OpenAPI In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18137 Olli-Antti Kivilahti changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #60492|0 |1 is obsolete| | --- Comment #13 from Olli-Antti Kivilahti --- Created attachment 60839 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=60839&action=edit Bug 18137: Migrate from Swagger2 to Mojolicious::Plugin::OpenAPI This patch migrates from Swagger2 to Mojolicious::Plugin::OpenAPI as Swagger2 is no longer actively maintained. This migration involves some minor changes to our Swagger specification documents and to controllers. Each operation is migrated in following patches separately. Please see Mojolicious::Plugin::OpenAPI and its tutorial for more documentation. The patch also refactors some API authentication -related code by taking advantage of Koha::Exceptions. Authentication is now handled via Mojolicious's "under->to" functionality. The actual authentication & authorization checks are moved to Koha::REST::V1::Auth. Added a HTTP 503 response for when database update is required, instead of returning an authentication failure as before. To test: 1. prove t/db_dependent/api/v1/auth.t Signed-off-by: Olli-Antti Kivilahti -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Mar 6 12:44:13 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 06 Mar 2017 11:44:13 +0000 Subject: [Koha-bugs] [Bug 18137] REST API: Migrate from Mojolicious::Plugin:: Swagger2 to Mojolicious::Plugin::OpenAPI In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18137 Olli-Antti Kivilahti changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #60493|0 |1 is obsolete| | --- Comment #14 from Olli-Antti Kivilahti --- Created attachment 60840 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=60840&action=edit Bug 18137: Make /patrons Mojolicious::Plugin::OpenAPI compatible Also: - adding some missing and new response definitions into Swagger spec. - fixing failing test due to Bug 17932's change of boolean values To test: 1. prove t/db_dependent/api/v1/patrons.t Signed-off-by: Olli-Antti Kivilahti -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Mar 6 12:44:44 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 06 Mar 2017 11:44:44 +0000 Subject: [Koha-bugs] [Bug 18137] REST API: Migrate from Mojolicious::Plugin:: Swagger2 to Mojolicious::Plugin::OpenAPI In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18137 Olli-Antti Kivilahti changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #60494|0 |1 is obsolete| | --- Comment #15 from Olli-Antti Kivilahti --- Created attachment 60841 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=60841&action=edit Bug 18137: Make /cities Mojolicious::Plugin::OpenAPI compatible Also: - adding some missing and new response definitions into Swagger spec. To test: 1. prove t/db_dependent/api/v1/cities.t Signed-off-by: Olli-Antti Kivilahti -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Mar 6 12:45:06 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 06 Mar 2017 11:45:06 +0000 Subject: [Koha-bugs] [Bug 18137] REST API: Migrate from Mojolicious::Plugin:: Swagger2 to Mojolicious::Plugin::OpenAPI In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18137 Olli-Antti Kivilahti changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #60495|0 |1 is obsolete| | --- Comment #16 from Olli-Antti Kivilahti --- Created attachment 60842 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=60842&action=edit Bug 18137: Make /holds Mojolicious::Plugin::OpenAPI compatible Also - adding some missing and new response definitions into Swagger spec. - fixing failing tests due to Bug 17932's change of boolean values To test: 1. prove t/db_dependent/api/v1/holds.t Signed-off-by: Olli-Antti Kivilahti -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Mar 6 12:45:29 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 06 Mar 2017 11:45:29 +0000 Subject: [Koha-bugs] [Bug 18137] REST API: Migrate from Mojolicious::Plugin:: Swagger2 to Mojolicious::Plugin::OpenAPI In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18137 Olli-Antti Kivilahti changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #60533|0 |1 is obsolete| | --- Comment #17 from Olli-Antti Kivilahti --- Created attachment 60843 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=60843&action=edit Bug 18137: Remove x-mojo-around-action Mojolicious::Plugin::OpenAPI does not support x-mojo-around action. This patch removes it from our specification document. Signed-off-by: Olli-Antti Kivilahti -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Mar 6 12:53:41 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 06 Mar 2017 11:53:41 +0000 Subject: [Koha-bugs] [Bug 18137] REST API: Migrate from Mojolicious::Plugin:: Swagger2 to Mojolicious::Plugin::OpenAPI In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18137 --- Comment #18 from Lari Taskula --- (In reply to Lari Taskula from comment #10) > I would like to point out that I am experiencing an issue with > JSON::Validator, where $refs are sometimes left unresolved in our spec and > it causes some error messages and crashes. This issue is being tracked at > https://github.com/jhthorsen/json-validator/pull/52. The developer of JSON::Validator has been working hard on it and it now seems to have been fixed. The fix will appear in version 0.96 of JSON::Validator. That should probably be added as dependency once it is released. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Mar 6 14:35:53 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 06 Mar 2017 13:35:53 +0000 Subject: [Koha-bugs] [Bug 18215] Resolve warning on $tls in Database.pm In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18215 Kyle M Hall changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |kyle at bywatersolutions.com Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Mar 6 14:36:30 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 06 Mar 2017 13:36:30 +0000 Subject: [Koha-bugs] [Bug 18215] Resolve warning on $tls in Database.pm In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18215 Kyle M Hall changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to Master -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Mar 6 14:36:32 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 06 Mar 2017 13:36:32 +0000 Subject: [Koha-bugs] [Bug 18215] Resolve warning on $tls in Database.pm In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18215 Kyle M Hall changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #60832|0 |1 is obsolete| | --- Comment #3 from Kyle M Hall --- Created attachment 60844 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=60844&action=edit Bug 18215: Resolve warning on $tls in Database.pm Resolve this warning: updatedatabase.pl: Use of uninitialized value $tls in string eq at /usr/share/koha/masterclone/Koha/Database.pm line 63. Test plan: [1] Check if you do not see the warning anymore. Signed-off-by: Magnus Enger Warning disappears after applying the patch. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Mar 6 14:37:03 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 06 Mar 2017 13:37:03 +0000 Subject: [Koha-bugs] [Bug 18215] Resolve warning on $tls in Database.pm In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18215 --- Comment #4 from Kyle M Hall --- Pushed to master for 17.05, thanks Marcel! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Mar 6 15:02:38 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 06 Mar 2017 14:02:38 +0000 Subject: [Koha-bugs] [Bug 18104] allow SIP2 field AE (personal name ) to be customized In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18104 Kyle M Hall changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Mar 6 15:02:40 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 06 Mar 2017 14:02:40 +0000 Subject: [Koha-bugs] [Bug 18104] allow SIP2 field AE (personal name ) to be customized In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18104 --- Comment #1 from Kyle M Hall --- Created attachment 60845 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=60845&action=edit Bug 18104 - allow SIP2 field AE (personal name ) to be customized -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Mar 6 15:03:24 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 06 Mar 2017 14:03:24 +0000 Subject: [Koha-bugs] [Bug 18182] TestBuilder should be able to return Koha::Object objects In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18182 --- Comment #3 from Marcel de Rooy --- Great, Tomas. Few remarks: I would rather remove the id column. We c/should take care of that in the code. Like: my @pk = $schema->source('Borrower')->primary_columns; Note that we theoretically can have multiple columns. (We don't have such Koha objects, but iirc we have one or two tables like that.) Similarly, it would be more consistent and less confusing to use the singular form. We do so in build; I would expect the same for build_object. Additionally, you return just one singular object. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Mar 6 15:10:05 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 06 Mar 2017 14:10:05 +0000 Subject: [Koha-bugs] [Bug 18182] TestBuilder should be able to return Koha::Object objects In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18182 --- Comment #4 from Tom?s Cohen Arazi --- (In reply to Marcel de Rooy from comment #3) > Great, Tomas. > > Few remarks: > I would rather remove the id column. We c/should take care of that in the > code. > Like: > my @pk = $schema->source('Borrower')->primary_columns; > Note that we theoretically can have multiple columns. (We don't have such > Koha objects, but iirc we have one or two tables like that.) I agree. Read the next answer to have context. > Similarly, it would be more consistent and less confusing to use the > singular form. We do so in build; I would expect the same for build_object. > Additionally, you return just one singular object. Singular classes are not aware of the plural class name. And we need the plural to ->find the created object. That's the design decision I don't like about koha::object(s). I'm open to opinions, but the only solutions are -annotate singular classes so they know their plural -move the plural methods to the singular classes and get rid of plural I vote for the latter, of course. But that would be a bigger dev. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Mar 6 15:10:54 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 06 Mar 2017 14:10:54 +0000 Subject: [Koha-bugs] [Bug 18215] Resolve warning on $tls in Database.pm In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18215 Kyle M Hall changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #60844|0 |1 is obsolete| | --- Comment #5 from Kyle M Hall --- Created attachment 60846 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=60846&action=edit Bug 18215: Resolve warning on $tls in Database.pm Resolve this warning: updatedatabase.pl: Use of uninitialized value $tls in string eq at /usr/share/koha/masterclone/Koha/Database.pm line 63. Test plan: [1] Check if you do not see the warning anymore. Signed-off-by: Magnus Enger Warning disappears after applying the patch. Signed-off-by: Kyle M Hall -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Mar 6 15:22:24 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 06 Mar 2017 14:22:24 +0000 Subject: [Koha-bugs] [Bug 18182] TestBuilder should be able to return Koha::Object objects In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18182 --- Comment #5 from Marcel de Rooy --- (In reply to Tom?s Cohen Arazi from comment #4) > Singular classes are not aware of the plural class name. And we need the > plural to ->find the created object. That's the design decision I don't like > about koha::object(s). I'm open to opinions, but the only solutions are > -annotate singular classes so they know their plural > -move the plural methods to the singular classes and get rid of plural > > I vote for the latter, of course. But that would be a bigger dev. Did you look at this one: sub _get_objects_class $ git grep koha_objects_class Koha/Objects.pm: if( $type->can('koha_objects_class') ) { Koha/Objects.pm: return $type->koha_objects_class; Koha/Schema/Result/Borrower.pm:sub koha_objects_class { Koha/Schema/Result/Branch.pm:sub koha_objects_class { Koha/Schema/Result/OldIssue.pm:sub koha_objects_class { So cool :) -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Mar 6 15:24:52 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 06 Mar 2017 14:24:52 +0000 Subject: [Koha-bugs] [Bug 17941] CanBookBeRenewed is very inefficient/slow In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17941 --- Comment #38 from Petter Goks?yr ?sen --- > Pushed to master for 17.05, thanks Francesco! It does not appear to be pushed: http://git.koha-community.org/gitweb/?p=koha.git;a=shortlog -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Mar 6 15:25:45 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 06 Mar 2017 14:25:45 +0000 Subject: [Koha-bugs] [Bug 17941] CanBookBeRenewed is very inefficient/slow In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17941 --- Comment #39 from Petter Goks?yr ?sen --- (In reply to Petter Goks?yr ?sen from comment #38) > > Pushed to master for 17.05, thanks Francesco! > > It does not appear to be pushed: > http://git.koha-community.org/gitweb/?p=koha.git;a=shortlog Forget it, I'm blind! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Mar 6 16:37:54 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 06 Mar 2017 15:37:54 +0000 Subject: [Koha-bugs] [Bug 18217] New: SMS alert number should be grouped with other borrower contact information. Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18217 Bug ID: 18217 Summary: SMS alert number should be grouped with other borrower contact information. Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Staff Client Assignee: koha-bugs at lists.koha-community.org Reporter: barton at bywatersolutions.com QA Contact: testopia at bugs.koha-community.org CC: gmcharlt at gmail.com SMS alert number is currently grouped with borrower messing preferences. This is inconsistent with the rest of the borrower contact information. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Mon Mar 6 17:08:20 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 06 Mar 2017 16:08:20 +0000 Subject: [Koha-bugs] [Bug 18182] TestBuilder should be able to return Koha::Object objects In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18182 --- Comment #6 from Tom?s Cohen Arazi --- (In reply to Marcel de Rooy from comment #5) > (In reply to Tom?s Cohen Arazi from comment #4) > > Singular classes are not aware of the plural class name. And we need the > > plural to ->find the created object. That's the design decision I don't like > > about koha::object(s). I'm open to opinions, but the only solutions are > > -annotate singular classes so they know their plural > > -move the plural methods to the singular classes and get rid of plural > > > > I vote for the latter, of course. But that would be a bigger dev. > > Did you look at this one: sub _get_objects_class > $ git grep koha_objects_class > Koha/Objects.pm: if( $type->can('koha_objects_class') ) { > Koha/Objects.pm: return $type->koha_objects_class; > Koha/Schema/Result/Borrower.pm:sub koha_objects_class { > Koha/Schema/Result/Branch.pm:sub koha_objects_class { > Koha/Schema/Result/OldIssue.pm:sub koha_objects_class { > > So cool :) So we annotate our singular classes. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Mar 6 17:16:57 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 06 Mar 2017 16:16:57 +0000 Subject: [Koha-bugs] [Bug 15524] Set limit on maximum possible holds per patron by category In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15524 Kyle M Hall changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on|15521, 15522 | CC| |kyle at bywatersolutions.com Blocks| |15521, 15522 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15521 [Bug 15521] Make circulation rules backend more granular https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15522 [Bug 15522] New interface for revamped circulation rules -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Mar 6 17:16:57 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 06 Mar 2017 16:16:57 +0000 Subject: [Koha-bugs] [Bug 15521] Make circulation rules backend more granular In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15521 Kyle M Hall changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks|15524 | Depends on| |15524 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15524 [Bug 15524] Set limit on maximum possible holds per patron by category -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Mar 6 17:16:57 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 06 Mar 2017 16:16:57 +0000 Subject: [Koha-bugs] [Bug 15522] New interface for revamped circulation rules In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15522 Kyle M Hall changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks|15524 | Depends on| |15524 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15524 [Bug 15524] Set limit on maximum possible holds per patron by category -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Mar 6 17:17:04 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 06 Mar 2017 16:17:04 +0000 Subject: [Koha-bugs] [Bug 15524] Set limit on maximum possible holds per patron by category In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15524 Kyle M Hall changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|jweaver at bywatersolutions.co |kyle at bywatersolutions.com |m | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Mar 6 17:38:12 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 06 Mar 2017 16:38:12 +0000 Subject: [Koha-bugs] [Bug 18218] New: Contact information (borrower, branch, acquisitions), should be centralized into a single table Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18218 Bug ID: 18218 Summary: Contact information (borrower, branch, acquisitions), should be centralized into a single table Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Architecture, internals, and plumbing Assignee: gmcharlt at gmail.com Reporter: barton at bywatersolutions.com QA Contact: testopia at bugs.koha-community.org The borrowers table contains three sets of contact information -- primary (streetnumber, streettype, address, etc... no prefix), secondary (B_streetnumber, B_streettype, etc) and alternate (altcontactaddress1, altcontactaddress2, etc.)... there are also the emailpro and phonepro fields. These should be moved into a 'contacts' table. I think that it would be reasonable to re-factor the aqcontacts table so that generic contact information was in the contacts table, as well as pulling branch contact information into contacts as well. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Mar 6 17:43:34 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 06 Mar 2017 16:43:34 +0000 Subject: [Koha-bugs] [Bug 17776] Shibboleth Authentication is broken in plack In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17776 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #60800|0 |1 is obsolete| | --- Comment #6 from Martin Renvoize --- Created attachment 60847 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=60847&action=edit Enable Shibboleth for Plack -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Mar 6 17:47:05 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 06 Mar 2017 16:47:05 +0000 Subject: [Koha-bugs] [Bug 17776] Shibboleth Authentication is broken in plack In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17776 --- Comment #7 from Martin Renvoize --- So after more local testing, i found that the plack environment could be a little more complex than my initial tests. This patch obsoletes the original and calls 'get_shib_login' later in the runtime (i.e. outside of the begin block) so we have a valid environment by the time the routine run. In short, it should all work now so long as you've updated your Apache configs as per the inline perldoc documentation. I believe the UseHeaders and UseEnvironment variables for the shibboleth service provider software are mutually exclusive (they appeared to be in my brief testing), so I don't believe it is possible to run in a half and half setup (unless you have two entirely separate vhosts.. one for plack and one for non-plack running). -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Mar 6 17:48:15 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 06 Mar 2017 16:48:15 +0000 Subject: [Koha-bugs] [Bug 17776] Shibboleth Authentication is broken in plack In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17776 --- Comment #8 from Martin Renvoize --- (In reply to Zeno Tajoli from comment #5) > Do you think we can use http://www.ssocircle.com/en/portfolio/publicidp/ for > testing ? > > Or is better to use https://www.testshib.org/ ? Either IdP should work perfectly happily. I've tested here against teshshib, openfiede and some customer systems using simplesamlphp and ms active directory services. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Mar 6 18:48:21 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 06 Mar 2017 17:48:21 +0000 Subject: [Koha-bugs] [Bug 18215] Resolve warning on $tls in Database.pm In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18215 Tom?s Cohen Arazi changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |tomascohen at gmail.com Depends on| |15427 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15427 [Bug 15427] Allow db connections using TLS -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Mar 6 18:48:21 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 06 Mar 2017 17:48:21 +0000 Subject: [Koha-bugs] [Bug 15427] Allow db connections using TLS In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15427 Tom?s Cohen Arazi changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |18215 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18215 [Bug 18215] Resolve warning on $tls in Database.pm -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Mar 6 19:05:21 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 06 Mar 2017 18:05:21 +0000 Subject: [Koha-bugs] [Bug 18205] REST interface to Koha::Logger In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18205 --- Comment #1 from Lari Taskula --- Created attachment 60848 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=60848&action=edit Bug 18205: Add interface 'rest' for Koha::Logger This patch adds an interface 'rest' for Koha::Logger. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Mon Mar 6 19:05:38 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 06 Mar 2017 18:05:38 +0000 Subject: [Koha-bugs] [Bug 18205] REST interface to Koha::Logger In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18205 --- Comment #2 from Lari Taskula --- Created attachment 60849 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=60849&action=edit Bug 18205: Unit tests To test: 1. prove t/db_dependent/Log.t -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Mar 6 19:05:57 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 06 Mar 2017 18:05:57 +0000 Subject: [Koha-bugs] [Bug 18205] REST interface to Koha::Logger In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18205 --- Comment #3 from Lari Taskula --- Created attachment 60850 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=60850&action=edit Bug 18205: Mojo::Log with Koha::Logger::Mojo This patch adds a new module, Koha::Logger::Mojo, based on MojoX::Log::Log4perl. This module allows us to use log4perl configurations with Mojolicious on the freshly introduced 'rest' interface in log4perl.conf. $c->app->log->warn will then use Log4perl as the underlying log mechanism and those log events will point to the appropriate log file. To test: 1. prove t/Koha/Logger/Mojo.t -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Mon Mar 6 19:10:23 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 06 Mar 2017 18:10:23 +0000 Subject: [Koha-bugs] [Bug 18205] REST interface to Koha::Logger In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18205 Lari Taskula changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|koha-bugs at lists.koha-commun |lari.taskula at jns.fi |ity.org | -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Mon Mar 6 19:10:37 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 06 Mar 2017 18:10:37 +0000 Subject: [Koha-bugs] [Bug 18206] REST API: Default exception handling In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18206 Lari Taskula changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|koha-bugs at lists.koha-commun |lari.taskula at jns.fi |ity.org | -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Mar 6 20:44:53 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 06 Mar 2017 19:44:53 +0000 Subject: [Koha-bugs] [Bug 18120] REST API: CRUD endpoint for vendors In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18120 --- Comment #1 from Tom?s Cohen Arazi --- Created attachment 60851 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=60851&action=edit Bug 18120: REST api | /acquisitions/vendors unit tests This patch introduces unit tests that need to be passed by an /acquisitions/vendors/ REST endpoint. To test: - Apply the patch - Run: $ sudo koha-shell kohadev k$ prove t/db_dependent/api/v1/acquisitions_vendors.t => FAIL: The endpoint is not present, should fail. Sponsored-by: ByWater Solutions -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Mar 6 20:44:59 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 06 Mar 2017 19:44:59 +0000 Subject: [Koha-bugs] [Bug 18120] REST API: CRUD endpoint for vendors In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18120 --- Comment #2 from Tom?s Cohen Arazi --- Created attachment 60852 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=60852&action=edit Bug 18120: REST api | Add a 'vendors' endpoint This patch introduces an /acquisitions/vendors endpoint. To test: - Apply the patch - Run: $ sudo koha-shell kohadev k$ prove t/db_dependent/api/v1/acquisitions_vendors.t => SUCCESS: Tests pass - Sign off :-D Sponsored-by: ByWater Solutions -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Mar 6 20:45:45 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 06 Mar 2017 19:45:45 +0000 Subject: [Koha-bugs] [Bug 18120] REST API: CRUD endpoint for vendors In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18120 Tom?s Cohen Arazi changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff Patch complexity|--- |Medium patch -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Mar 7 00:34:31 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 06 Mar 2017 23:34:31 +0000 Subject: [Koha-bugs] [Bug 18150] CanItemBeReserved doesn't work with ( IndependentBranches AND ! canreservefromotherbranches) In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18150 Christopher Brannon changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Mar 7 00:34:34 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 06 Mar 2017 23:34:34 +0000 Subject: [Koha-bugs] [Bug 18150] CanItemBeReserved doesn't work with ( IndependentBranches AND ! canreservefromotherbranches) In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18150 --- Comment #3 from Christopher Brannon --- Created attachment 60853 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=60853&action=edit [SIGNED OFF] Bug 18150 - CanItemBeReserved doesn't work with (IndependentBranches AND ! canreservefromotherbranches) The variable $item used to be a hash, but at the end of the function, it's a Koha object. As $item->{homebranch} doesn't yield anything and should be $item->homebranch. It prevents people using different branches without holds between branches from placing a hold on an item they should be able to place hold on. Test plan: 1. Before patch a. with IndependantBranches off b. try to place hold on an item you should be able to place hold on c. it should work d. put IndependantBranches on and canreservefromotherbranches off e. shouldn't work 2. after patches redo steps from (1) and everything should be working fine. Signed-off-by: Your Full Name -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Mar 7 00:39:12 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 06 Mar 2017 23:39:12 +0000 Subject: [Koha-bugs] [Bug 18150] CanItemBeReserved doesn't work with ( IndependentBranches AND ! canreservefromotherbranches) In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18150 Christopher Brannon changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #60853|0 |1 is obsolete| | --- Comment #4 from Christopher Brannon --- Created attachment 60854 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=60854&action=edit [SIGNED OFF] Bug 18150 - CanItemBeReserved doesn't work with (IndependentBranches AND ! canreservefromotherbranches) The variable $item used to be a hash, but at the end of the function, it's a Koha object. As $item->{homebranch} doesn't yield anything and should be $item->homebranch. It prevents people using different branches without holds between branches from placing a hold on an item they should be able to place hold on. Test plan: 1. Before patch a. with IndependantBranches off b. try to place hold on an item you should be able to place hold on d. put IndependantBranches on and canreservefromotherbranches off e. shouldn't work 2. after patches redo steps from (1) and everything should be working fine. Signed-off-by: Christopher Brannon -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Mar 7 00:49:33 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 06 Mar 2017 23:49:33 +0000 Subject: [Koha-bugs] [Bug 18219] New: "Not checked out." problem message displays twice on local use. Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18219 Bug ID: 18219 Summary: "Not checked out." problem message displays twice on local use. Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Circulation Assignee: koha-bugs at lists.koha-community.org Reporter: cbrannon at cdalibrary.org QA Contact: testopia at bugs.koha-community.org CC: gmcharlt at gmail.com, kyle.m.hall at gmail.com When checking in an item that is not checked out, the problem message "Not checked out appears twice. This seems to have occured with the last update to the master. I did not see this before my master was updated. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Mar 7 00:49:58 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 06 Mar 2017 23:49:58 +0000 Subject: [Koha-bugs] [Bug 18219] "Not checked out." problem message displays twice on local use. In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18219 Christopher Brannon changed: What |Removed |Added ---------------------------------------------------------------------------- Severity|enhancement |minor -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Tue Mar 7 01:01:40 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 07 Mar 2017 00:01:40 +0000 Subject: [Koha-bugs] [Bug 18220] New: OPAC login appears to be linked to staff login Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18220 Bug ID: 18220 Summary: OPAC login appears to be linked to staff login Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: major Priority: P5 - low Component: OPAC Assignee: oleonard at myacpl.org Reporter: cbrannon at cdalibrary.org QA Contact: testopia at bugs.koha-community.org On current master, I am noticing that after I login to Koha staff, when I open a new tab in the browser, I am logged into the OPAC. If I log off the OPAC, it logs me off the staff as well. I tested the same browser (Chrome) with our 3.22 production server and it does not have this issue. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Mar 7 05:09:26 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 07 Mar 2017 04:09:26 +0000 Subject: [Koha-bugs] [Bug 17602] Integrate support for ONeclickDigital/Recorded Books API In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17602 Srdjan Jankovic changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #57402|0 |1 is obsolete| | --- Comment #5 from Srdjan Jankovic --- Created attachment 60855 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=60855&action=edit Bug 17602 : Add OneClickDigital Integration to Koha Koha::ExternalContent::OneClickDigital - a wrapper around WebService::ILS::OneClickDigital::PartnerPatron Nothing functional to test with this patch yet. But you can run the tests that come with it t/db_dependent/Koha_ExternalContent_OneClickDigital.t -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Mar 7 05:09:44 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 07 Mar 2017 04:09:44 +0000 Subject: [Koha-bugs] [Bug 17602] Integrate support for ONeclickDigital/Recorded Books API In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17602 Srdjan Jankovic changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #57403|0 |1 is obsolete| | --- Comment #6 from Srdjan Jankovic --- Created attachment 60856 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=60856&action=edit Bug 17602 OneClickDigital* sysprefs -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Mar 7 05:12:14 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 07 Mar 2017 04:12:14 +0000 Subject: [Koha-bugs] [Bug 17602] Integrate support for ONeclickDigital/Recorded Books API In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17602 Srdjan Jankovic changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #57404|0 |1 is obsolete| | --- Comment #7 from Srdjan Jankovic --- Created attachment 60857 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=60857&action=edit Bug 17602 Add Oneclickdigital integration to Koha Add OneClickdigital to the users page in the public interface To Test: 1/ Apply all 3 patches 2/ Set the sysprefs to valid values (you will need a test account with Oneclickdigital) 3/ Try a search 4/ Login to the OPAC, try to place a hold, or check an item out 5/ Check the opac-user page, see if your items are showing on the oneclickdigital tab -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Mar 7 05:12:12 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 07 Mar 2017 04:12:12 +0000 Subject: [Koha-bugs] [Bug 17602] Integrate support for ONeclickDigital/Recorded Books API In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17602 Srdjan Jankovic changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |Signed Off -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Mar 7 08:37:33 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 07 Mar 2017 07:37:33 +0000 Subject: [Koha-bugs] [Bug 10486] Allow external Z39.50 targets to be searched from the OPAC In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10486 --- Comment #108 from Zeno Tajoli --- Hi all, I have the authorization. I will publish my code in github (I hope soon). -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Mar 7 10:17:33 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 07 Mar 2017 09:17:33 +0000 Subject: [Koha-bugs] [Bug 17908] Authority merge omnibus In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17908 --- Comment #17 from Marcel de Rooy --- Progress update: Bug 18070 has been pushed. The next step is to refine the merge functionality in bug 9988. It is waiting for your signoff. Please help to get this further. Thanks! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Mar 7 10:44:26 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 07 Mar 2017 09:44:26 +0000 Subject: [Koha-bugs] [Bug 16758] Caching issues in scripts running in daemon mode In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16758 Marcel de Rooy changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #55564|0 |1 is obsolete| | --- Comment #8 from Marcel de Rooy --- Created attachment 60858 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=60858&action=edit Bug 16758 - Caching issues in scripts running in daemon mode As L1 cache does not have expiration mechanism, scripts running in daemon mode (rebuild_zebra.pl -daemon, sip server ?, ...) would not be aware of any possible changes in the data being cached in upstream L2 cache. This patch adds ->flush_L1_caches() call in rebuild_zebra.pl inside daemon mode loop. To test: 1) apply patch 2) ensure that rebuild_zebra.pl -daemon is still working properly, without any noticeable performance degradation 3) stop memcached daemon and try to run rebuild_zebra.pl -daemon again: there should be a warning emitted stating that the script is running in daemon mode but without recommended caching system -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Mar 7 10:44:42 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 07 Mar 2017 09:44:42 +0000 Subject: [Koha-bugs] [Bug 16758] Caching issues in scripts running in daemon mode In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16758 Marcel de Rooy changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |m.de.rooy at rijksmuseum.nl --- Comment #9 from Marcel de Rooy --- Simple rebase -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Mar 7 10:47:12 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 07 Mar 2017 09:47:12 +0000 Subject: [Koha-bugs] [Bug 18219] "Not checked out." problem message displays twice on local use. In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18219 Marc V?ron changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |veron at veron.ch --- Comment #1 from Marc V?ron --- Confirmed. The duplication occurs in returns.tt lines 610 and 645. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Mar 7 10:56:48 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 07 Mar 2017 09:56:48 +0000 Subject: [Koha-bugs] [Bug 18137] REST API: Migrate from Mojolicious::Plugin:: Swagger2 to Mojolicious::Plugin::OpenAPI In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18137 Josef Moravec changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |josef.moravec at gmail.com --- Comment #19 from Josef Moravec --- Just tested, looks good for me, just a minor issue found by qa test tool: FAIL Koha/REST/V1/Auth.pm FAIL pod in file Koha/REST/V1/Auth.pm *** WARNING: =head3 without preceding higher level -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Mar 7 11:04:16 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 07 Mar 2017 10:04:16 +0000 Subject: [Koha-bugs] [Bug 18219] "Not checked out." problem message displays twice on local use. In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18219 Marc V?ron changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |https://bugs.koha-community | |.org/bugzilla3/show_bug.cgi | |?id=16530 --- Comment #2 from Marc V?ron --- Introduced by following Bug? Bug 16530 - Add a circ sidebar navigation menu There seem to be more duplications, e.g. [% IF ( errmsgloo.prevdebarred ) %] -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Tue Mar 7 11:04:16 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 07 Mar 2017 10:04:16 +0000 Subject: [Koha-bugs] [Bug 16530] Add a circ sidebar navigation menu In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16530 Marc V?ron changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |https://bugs.koha-community | |.org/bugzilla3/show_bug.cgi | |?id=18219 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Mar 7 11:13:04 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 07 Mar 2017 10:13:04 +0000 Subject: [Koha-bugs] [Bug 13913] Renewal error message in OPAC is confusing In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13913 Marc V?ron changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |veron at veron.ch -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Mar 7 11:13:37 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 07 Mar 2017 10:13:37 +0000 Subject: [Koha-bugs] [Bug 18098] Add an index with the count of not onloan items In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18098 Josef Moravec changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Mar 7 11:13:40 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 07 Mar 2017 10:13:40 +0000 Subject: [Koha-bugs] [Bug 18098] Add an index with the count of not onloan items In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18098 Josef Moravec changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #60818|0 |1 is obsolete| | --- Comment #4 from Josef Moravec --- Created attachment 60859 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=60859&action=edit [SIGNED-OFF] Bug 18098: Add an index with the count of not onloan items This patch adds a numeric index 'not-onloan-count' containing the value of 999$x. This subfield is filled by 'rebuild_zebra.pl' by making use of (bug's 18208) 'EmbedItemsAvailability' filter. bib1.att and indexes definitions are updated accordingly. To test: - Apply the patch - Pick the right biblio-zebra-indexdefs.xsl file for your setup and replace the one your Zebra uses [1] - Replace your bib1.att - Replace your ccl.properties - Have at least one record with more than one item, checkout some item(s) from that record(s). - Rebuild zebra's indexes: $ sudo koha-shell kohadev k$ cd kohaclone k$ misc/migration_tools/rebuild_zebra.pl -r -b -v -k (notice the dump directory is kept, you can try the XSLT yourself running: $ xsltproc \ etc/zebradb/marc_defs/marc21/biblios/biblio-zebra-indexdefs.xsl \ /tmp/the_dump_dir/biblios/exported_records | less => SUCCESS: There are records with the not-onloan-count index, and the value is correct! - Check Zebra yourself: $ yaz-client unix:/var/run/koha/kohadev/bibliosocket Z> base biblios Z> find @attr 1=9013 @attr 2=5 @attr 4=109 0 => SUCCESS: The search matches the amount of records with not-onloan items. Z> s 1+1 => SUCCESS: Records with 999$x having a value higher than 0 are rendered - Sign off :-D Note: While this work is complete on its purpose, it is part of an attempt to create a better way of filtering by availability. Sponsored-by: ByWater Solutions [1] In kohadevbox this would be /etc/koha/zebradb/marc_defs/marc21/biblios/biblio-zebra-indexdefs.xsl Signed-off-by: Josef Moravec -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Mar 7 11:34:54 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 07 Mar 2017 10:34:54 +0000 Subject: [Koha-bugs] [Bug 18221] New: Wrong form action in checkout table (/tools/export.pl) Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18221 Bug ID: 18221 Summary: Wrong form action in checkout table (/tools/export.pl) Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: minor Priority: P5 - low Component: Architecture, internals, and plumbing Assignee: gmcharlt at gmail.com Reporter: veron at veron.ch QA Contact: testopia at bugs.koha-community.org Created attachment 60860 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=60860&action=edit Screenshot checkout table with form action detail The checkout table on /circ/circulation.pl has following form action: action="/cgi-bin/koha/tools/export.pl" See screenshot attached and includes/checkout-table.inc line 9 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Mar 7 11:36:50 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 07 Mar 2017 10:36:50 +0000 Subject: [Koha-bugs] [Bug 18218] Contact information (borrower, branch, acquisitions), should be centralized into a single table In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18218 Marc V?ron changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |veron at veron.ch -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Mar 7 11:41:53 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 07 Mar 2017 10:41:53 +0000 Subject: [Koha-bugs] [Bug 17297] Give librarians the ability to add messages to an item In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17297 Josef Moravec changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Mar 7 11:41:56 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 07 Mar 2017 10:41:56 +0000 Subject: [Koha-bugs] [Bug 17297] Give librarians the ability to add messages to an item In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17297 Josef Moravec changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #55544|0 |1 is obsolete| | --- Comment #6 from Josef Moravec --- Created attachment 60861 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=60861&action=edit [SIGNED-OFF] Bug 17297 - Add npm and webpack config files Signed-off-by: Josef Moravec -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Mar 7 11:42:06 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 07 Mar 2017 10:42:06 +0000 Subject: [Koha-bugs] [Bug 17297] Give librarians the ability to add messages to an item In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17297 Josef Moravec changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #55545|0 |1 is obsolete| | --- Comment #7 from Josef Moravec --- Created attachment 60862 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=60862&action=edit [SIGNED-OFF] Bug 17297 [POC] - Add React based item message editor Signed-off-by: Josef Moravec -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Mar 7 11:42:22 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 07 Mar 2017 10:42:22 +0000 Subject: [Koha-bugs] [Bug 17297] Give librarians the ability to add messages to an item In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17297 Josef Moravec changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #55546|0 |1 is obsolete| | --- Comment #8 from Josef Moravec --- Created attachment 60863 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=60863&action=edit [SIGNED-OFF] Bug 17297 [POC] - Add minified js file Signed-off-by: Josef Moravec -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Mar 7 11:45:25 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 07 Mar 2017 10:45:25 +0000 Subject: [Koha-bugs] =?utf-8?q?=5BBug_18190=5D_the_=22Delete=22__action_on?= =?utf-8?q?_Home_=E2=80=BA_Reports_=E2=80=BA_Guided_reports_wizard_?= =?utf-8?q?=E2=80=BA_Saved_reports_should_hide_reports_rather_than_deletin?= =?utf-8?q?g_them?= In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18190 Marc V?ron changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |veron at veron.ch --- Comment #2 from Marc V?ron --- BTW: If you activate syspref ReportsLog, deleted reports are logged including their SQL statment. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Mar 7 11:54:19 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 07 Mar 2017 10:54:19 +0000 Subject: [Koha-bugs] =?utf-8?q?=5BBug_18190=5D_the_=22Delete=22__action_on?= =?utf-8?q?_Home_=E2=80=BA_Reports_=E2=80=BA_Guided_reports_wizard_?= =?utf-8?q?=E2=80=BA_Saved_reports_should_hide_reports_rather_than_deletin?= =?utf-8?q?g_them?= In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18190 --- Comment #3 from Katrin Fischer --- Good point, Marc! So actually we are already doing this in a way and it's optional. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Mar 7 11:59:17 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 07 Mar 2017 10:59:17 +0000 Subject: [Koha-bugs] [Bug 12972] Transfer slip and transfer message (blue box) can conflict In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12972 Josef Moravec changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Mar 7 11:59:20 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 07 Mar 2017 10:59:20 +0000 Subject: [Koha-bugs] [Bug 12972] Transfer slip and transfer message (blue box) can conflict In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12972 Josef Moravec changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #60810|0 |1 is obsolete| | --- Comment #2 from Josef Moravec --- Created attachment 60864 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=60864&action=edit [SIGNED-OFF] Bug 12972 - Transfer slip and transfer message (blue box) can conflict Instead of passing the homebranch to the slip, let's pass TransferWaitingAt (the value we display) To test: 1 - Check in an item that will initiate a transfer (hold or automatic item return) 2 - Note the transfer message and receipt match 3 - Remove the reason for transfer (bot don't cancel transfer) i.e. cancel hold or change homebranch of item to current library 4 - Check the item in again 5 - Note the message displays the transfer destination and the slip shows the homebranch 6 - Apply patch 7 - Repeat 5 but note slip and message match 8 - Test any edge cases for correctness 9 - sign off Signed-off-by: Josef Moravec -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Mar 7 12:15:58 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 07 Mar 2017 11:15:58 +0000 Subject: [Koha-bugs] [Bug 18137] REST API: Migrate from Mojolicious::Plugin:: Swagger2 to Mojolicious::Plugin::OpenAPI In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18137 Lari Taskula changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |18205 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18205 [Bug 18205] REST interface to Koha::Logger -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Mar 7 12:15:58 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 07 Mar 2017 11:15:58 +0000 Subject: [Koha-bugs] [Bug 18205] REST interface to Koha::Logger In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18205 Lari Taskula changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on| |18137 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18137 [Bug 18137] REST API: Migrate from Mojolicious::Plugin::Swagger2 to Mojolicious::Plugin::OpenAPI -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Mar 7 12:22:09 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 07 Mar 2017 11:22:09 +0000 Subject: [Koha-bugs] [Bug 18207] smart-rules.pl should validate that all branches / patron categories / item types are covered by circ rules. In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18207 Marc V?ron changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |veron at veron.ch -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Mar 7 12:23:45 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 07 Mar 2017 11:23:45 +0000 Subject: [Koha-bugs] [Bug 14049] Personalized OPAC purchase suggestion fields In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14049 Marc V?ron changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |veron at veron.ch -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Mar 7 12:25:21 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 07 Mar 2017 11:25:21 +0000 Subject: [Koha-bugs] [Bug 18222] New: Fix tests broken by Buug 18026 Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18222 Bug ID: 18222 Summary: Fix tests broken by Buug 18026 Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Installation and upgrade (command-line installer) Assignee: gmcharlt at gmail.com Reporter: olli-antti.kivilahti at jns.fi QA Contact: testopia at bugs.koha-community.org root at koha_ci_1:/home/koha/Koha# KOHA_CONF=$KOHA_CONF perl t/Koha_Template_Plugin_Koha.t 1..3 ok 1 - use Koha::Template::Plugin::Koha; ok 2 # Subtest: Koha::Template::Plugin::Koha::Version tests 1..2 not ok 1 - Correct development version # Failed test 'Correct development version' # at t/Koha_Template_Plugin_Koha.t line 54. # Structures begin differing at: # $got->{minor} = '24' # $expected->{minor} = Does not exist not ok 2 - Correct maintenance version # Failed test 'Correct maintenance version' # at t/Koha_Template_Plugin_Koha.t line 69. # Structures begin differing at: # $got->{minor} = '07' # $expected->{minor} = Does not exist # Looks like you failed 2 tests of 2. not ok 3 - Koha::Template::Plugin::Koha::Version tests # Failed test 'Koha::Template::Plugin::Koha::Version tests' # at t/Koha_Template_Plugin_Koha.t line 76. # Looks like you failed 1 test of 3. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Mar 7 12:28:32 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 07 Mar 2017 11:28:32 +0000 Subject: [Koha-bugs] [Bug 18222] Fix tests broken by Buug 18026 In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18222 --- Comment #1 from Olli-Antti Kivilahti --- Created attachment 60865 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=60865&action=edit Bug 18222 - Fix tests broken by Buug 18026 root at koha_ci_1:/home/koha/Koha# KOHA_CONF=$KOHA_CONF perl t/Koha_Template_Plugin_Koha.t 1..3 ok 1 - use Koha::Template::Plugin::Koha; ok 2 1..2 ok 1 - Correct development version ok 2 - Correct maintenance version ok 3 - Koha::Template::Plugin::Koha::Version tests -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Mar 7 12:28:46 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 07 Mar 2017 11:28:46 +0000 Subject: [Koha-bugs] [Bug 18026] URL to database columns link in system preferences is incorrect In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18026 Olli-Antti Kivilahti changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |olli-antti.kivilahti at jns.fi Blocks| |18222 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18222 [Bug 18222] Fix tests broken by Buug 18026 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Mar 7 12:28:46 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 07 Mar 2017 11:28:46 +0000 Subject: [Koha-bugs] [Bug 18222] Fix tests broken by Buug 18026 In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18222 Olli-Antti Kivilahti changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on| |18026 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18026 [Bug 18026] URL to database columns link in system preferences is incorrect -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Mar 7 12:31:43 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 07 Mar 2017 11:31:43 +0000 Subject: [Koha-bugs] [Bug 16758] Caching issues in scripts running in daemon mode In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16758 Marcel de Rooy changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |mirko at abunchofthings.net Patch complexity|Trivial patch |Small patch --- Comment #10 from Marcel de Rooy --- (In reply to Jacek Ablewicz from comment #5) > BTW, I'm wondering what is an order of starting koha-common && memcached in > debian packaged installs? If on server reboot indexer daemon gets started > before memcached is up and running, it will default to Cache::Memory as > well, even if the MEMCACHED_* variables are set up properly. In my rc5.d I have: S01koha-common S03memcached So yes, koha-common (including indexer, sip) starts before memcached. I added a debug print in get_instance and saw a few lines with Cache::Memory in the logs when rebooting. We probably should use update-rc.d to lower the priority of koha-common in the Debian package install. Patch complexity is definitely not trivial ;) -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Mar 7 12:38:23 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 07 Mar 2017 11:38:23 +0000 Subject: [Koha-bugs] [Bug 18192] Add form for fast changes to tab/visibility in marc frameworks In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18192 Marc V?ron changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |veron at veron.ch -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Mar 7 12:45:25 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 07 Mar 2017 11:45:25 +0000 Subject: [Koha-bugs] [Bug 15521] Make circulation rules backend more granular In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15521 Marc V?ron changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |veron at veron.ch -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Mar 7 12:46:11 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 07 Mar 2017 11:46:11 +0000 Subject: [Koha-bugs] [Bug 18207] smart-rules.pl should validate that all branches / patron categories / item types are covered by circ rules. In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18207 --- Comment #1 from Marc V?ron --- Related to Bug 15521? -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Tue Mar 7 12:47:43 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 07 Mar 2017 11:47:43 +0000 Subject: [Koha-bugs] [Bug 18201] Confusing language on Export data - bibliographic records " Remove non-local items" In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18201 Marc V?ron changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |veron at veron.ch -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Mar 7 13:00:08 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 07 Mar 2017 12:00:08 +0000 Subject: [Koha-bugs] [Bug 18137] REST API: Migrate from Mojolicious::Plugin:: Swagger2 to Mojolicious::Plugin::OpenAPI In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18137 --- Comment #20 from Lari Taskula --- Created attachment 60866 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=60866&action=edit Bug 18137: (follow-up) Fix handling DBIx::Class::Exception messages - DBIx::Class::Exception should use ->{msg} -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Mar 7 13:00:25 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 07 Mar 2017 12:00:25 +0000 Subject: [Koha-bugs] [Bug 18137] REST API: Migrate from Mojolicious::Plugin:: Swagger2 to Mojolicious::Plugin::OpenAPI In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18137 --- Comment #21 from Lari Taskula --- Created attachment 60867 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=60867&action=edit Bug 18137: (QA-follow-up) Fix pod fail -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Mar 7 13:39:54 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 07 Mar 2017 12:39:54 +0000 Subject: [Koha-bugs] [Bug 18222] Fix tests broken by Buug 18026 In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18222 Marcel de Rooy changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|gmcharlt at gmail.com |olli-antti.kivilahti at jns.fi Status|NEW |Needs Signoff Patch complexity|--- |Trivial patch CC| |m.de.rooy at rijksmuseum.nl -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Mar 7 13:40:04 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 07 Mar 2017 12:40:04 +0000 Subject: [Koha-bugs] [Bug 18222] Fix tests broken by Bug 18026 In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18222 Marcel de Rooy changed: What |Removed |Added ---------------------------------------------------------------------------- Summary|Fix tests broken by Buug |Fix tests broken by Bug |18026 |18026 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Mar 7 13:40:19 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 07 Mar 2017 12:40:19 +0000 Subject: [Koha-bugs] [Bug 18222] Fix tests broken by Bug 18026 In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18222 Marcel de Rooy changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Mar 7 13:40:22 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 07 Mar 2017 12:40:22 +0000 Subject: [Koha-bugs] [Bug 18222] Fix tests broken by Bug 18026 In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18222 Marcel de Rooy changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #60865|0 |1 is obsolete| | --- Comment #2 from Marcel de Rooy --- Created attachment 60868 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=60868&action=edit Bug 18222 - Fix tests broken by Buug 18026 root at koha_ci_1:/home/koha/Koha# KOHA_CONF=$KOHA_CONF perl t/Koha_Template_Plugin_Koha.t 1..3 ok 1 - use Koha::Template::Plugin::Koha; ok 2 1..2 ok 1 - Correct development version ok 2 - Correct maintenance version ok 3 - Koha::Template::Plugin::Koha::Version tests Signed-off-by: Marcel de Rooy -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Mar 7 13:40:38 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 07 Mar 2017 12:40:38 +0000 Subject: [Koha-bugs] [Bug 18222] Fix tests broken by Bug 18026 In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18222 Marcel de Rooy changed: What |Removed |Added ---------------------------------------------------------------------------- Component|Installation and upgrade |Test Suite |(command-line installer) | QA Contact|testopia at bugs.koha-communit |gmcharlt at gmail.com |y.org | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Mar 7 13:40:45 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 07 Mar 2017 12:40:45 +0000 Subject: [Koha-bugs] [Bug 18222] Fix tests broken by Bug 18026 In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18222 Marcel de Rooy changed: What |Removed |Added ---------------------------------------------------------------------------- QA Contact|gmcharlt at gmail.com |m.de.rooy at rijksmuseum.nl -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Mar 7 13:41:40 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 07 Mar 2017 12:41:40 +0000 Subject: [Koha-bugs] [Bug 18222] Fix tests broken by Bug 18026 In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18222 Marcel de Rooy changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA --- Comment #3 from Marcel de Rooy --- Combining SO and QA here Passed QA -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Mar 7 14:14:17 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 07 Mar 2017 13:14:17 +0000 Subject: [Koha-bugs] [Bug 16034] Integration with OverDrive Patron API In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16034 --- Comment #76 from Marcel de Rooy --- =head1 L METHODS =item C sub return { Definitely a fine name for a method ;) -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Mar 7 14:27:17 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 07 Mar 2017 13:27:17 +0000 Subject: [Koha-bugs] [Bug 18222] Fix tests broken by Bug 18026 In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18222 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #60868|0 |1 is obsolete| | --- Comment #4 from Jonathan Druart --- Created attachment 60869 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=60869&action=edit Bug 18222 - Fix tests broken by Buug 18026 root at koha_ci_1:/home/koha/Koha# KOHA_CONF=$KOHA_CONF perl t/Koha_Template_Plugin_Koha.t 1..3 ok 1 - use Koha::Template::Plugin::Koha; ok 2 1..2 ok 1 - Correct development version ok 2 - Correct maintenance version ok 3 - Koha::Template::Plugin::Koha::Version tests Signed-off-by: Marcel de Rooy Signed-off-by: Jonathan Druart -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Mar 7 14:27:45 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 07 Mar 2017 13:27:45 +0000 Subject: [Koha-bugs] [Bug 18222] Fix tests broken by Bug 18026 In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18222 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |jonathan.druart at bugs.koha-c | |ommunity.org --- Comment #5 from Jonathan Druart --- (In reply to Marcel de Rooy from comment #3) > Combining SO and QA here > Passed QA Did not see it, I was going to do the same :) -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Mar 7 14:31:44 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 07 Mar 2017 13:31:44 +0000 Subject: [Koha-bugs] [Bug 18173] Remove issues.return In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18173 Marcel de Rooy changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |m.de.rooy at rijksmuseum.nl --- Comment #4 from Marcel de Rooy --- Looking around for return: offline_circ/process_koc.pl: 'return' => \&kocReturnItem, Definitely a bad choice for a hash key, but not relevant here. >From bug 16034 / Koha/ExternalContent/OverDrive.pm: =item C opac/svc/overdrive: $data{action} = eval { $od->return($id) }; A method called return ;) Not relevant too here. Found nothing special with ->return or {return too. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Mar 7 14:35:32 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 07 Mar 2017 13:35:32 +0000 Subject: [Koha-bugs] [Bug 18173] Remove issues.return In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18173 Marcel de Rooy changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA Patch complexity|Trivial patch |Small patch -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Mar 7 14:35:35 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 07 Mar 2017 13:35:35 +0000 Subject: [Koha-bugs] [Bug 18173] Remove issues.return In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18173 Marcel de Rooy changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #60829|0 |1 is obsolete| | --- Comment #5 from Marcel de Rooy --- Created attachment 60870 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=60870&action=edit Bug 18173: Remove DB field issues.return The DB field issues.return has never really been used apparently. I found the first occurrence of this field in commit eac3a7b19a8aa7cda34aac396f5093c213a4aa5a CommitDate: Mon Mar 12 22:43:47 2001 +0000 Database definition file, checked into cvs to make keeping database current easier Since I did not find any use of this field. I guess it can be removed safely. There is no proper test plan here. Just make sure this field has never been used. Signed-off-by: Magnus Enger I have not found any use of issues.return or old_issues.return. In all my live instances the column is always NULL. Issuing and returning seems to work as expected after the columns have been removed. Signed-off-by: Marcel de Rooy -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Mar 7 14:35:40 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 07 Mar 2017 13:35:40 +0000 Subject: [Koha-bugs] [Bug 18173] Remove issues.return In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18173 --- Comment #6 from Marcel de Rooy --- Created attachment 60871 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=60871&action=edit Bug 18173: DBIx schema changes Signed-off-by: Marcel de Rooy -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Mar 7 14:35:57 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 07 Mar 2017 13:35:57 +0000 Subject: [Koha-bugs] [Bug 18173] Remove issues.return In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18173 Marcel de Rooy changed: What |Removed |Added ---------------------------------------------------------------------------- QA Contact|testopia at bugs.koha-communit |m.de.rooy at rijksmuseum.nl |y.org | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Mar 7 14:49:07 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 07 Mar 2017 13:49:07 +0000 Subject: [Koha-bugs] [Bug 15253] Add Koha::Logger based logging for SIP2 In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15253 --- Comment #16 from Olli-Antti Kivilahti --- Created attachment 60872 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=60872&action=edit Bug 15253 - Add Koha::Logger based logging for SIP2 - Fix circular module dependency. Now t/00-load.t passes -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Mar 7 14:51:02 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 07 Mar 2017 13:51:02 +0000 Subject: [Koha-bugs] [Bug 18209] Patron's card manage.pl page is not fully translatable In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18209 Marc V?ron changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #60817|0 |1 is obsolete| | --- Comment #2 from Marc V?ron --- Created attachment 60873 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=60873&action=edit Bug 18209 - Patron's card manage.pl page is not fully translatable The headers of the tables displayed in patroncards/manage.tt are hardcoded in the .pl and thus cannot be translated. This simple fix reuse the translate_card_element tool already in the code to make the strings translatable. Applied patch and verified that table headers on manage.pl display the same as before. Signed-off-by: Marc V?ron -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Mar 7 14:51:25 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 07 Mar 2017 13:51:25 +0000 Subject: [Koha-bugs] [Bug 18209] Patron's card manage.pl page is not fully translatable In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18209 Marc V?ron changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off CC| |veron at veron.ch -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Mar 7 14:58:40 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 07 Mar 2017 13:58:40 +0000 Subject: [Koha-bugs] [Bug 10865] Don't show list permissions when adding public lists/ sharing lists is not allowed In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10865 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |https://bugs.koha-community | |.org/bugzilla3/show_bug.cgi | |?id=18214 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Mar 7 14:58:40 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 07 Mar 2017 13:58:40 +0000 Subject: [Koha-bugs] [Bug 18214] Cannot edit list permissions of a private list In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18214 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |https://bugs.koha-community | |.org/bugzilla3/show_bug.cgi | |?id=10865 CC| |jonathan.druart at bugs.koha-c | |ommunity.org --- Comment #3 from Jonathan Druart --- There is a Koha::VirtualShelf->is_shared method, should not we use it to know if the permissions must be displayed or not? -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Mar 7 14:59:28 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 07 Mar 2017 13:59:28 +0000 Subject: [Koha-bugs] [Bug 18069] koha-rebuild-zebra still calls rebuild_zebra with -x In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18069 Marcel de Rooy changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Mar 7 14:59:31 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 07 Mar 2017 13:59:31 +0000 Subject: [Koha-bugs] [Bug 18069] koha-rebuild-zebra still calls rebuild_zebra with -x In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18069 Marcel de Rooy changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #60556|0 |1 is obsolete| | --- Comment #3 from Marcel de Rooy --- Created attachment 60874 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=60874&action=edit Bug 18069: Remove residue of rebuild_zebra -x Bug 17731 removed the -x option of rebuild_zebra but koha-rebuild-zebra still cals the script with this option. "Warning: You passed -x which is already the default and is now deprecated" Test plan: sudo koha-rebuild-zebra -f should no longer raise the warning Signed-off-by: Mason James Signed-off-by: Marcel de Rooy -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Mar 7 14:59:48 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 07 Mar 2017 13:59:48 +0000 Subject: [Koha-bugs] [Bug 18069] koha-rebuild-zebra still calls rebuild_zebra with -x In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18069 Marcel de Rooy changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |m.de.rooy at rijksmuseum.nl QA Contact|testopia at bugs.koha-communit |m.de.rooy at rijksmuseum.nl |y.org | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Mar 7 14:59:54 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 07 Mar 2017 13:59:54 +0000 Subject: [Koha-bugs] [Bug 18069] koha-rebuild-zebra still calls rebuild_zebra with -x In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18069 Marcel de Rooy changed: What |Removed |Added ---------------------------------------------------------------------------- Patch complexity|--- |Small patch -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Mar 7 15:12:35 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 07 Mar 2017 14:12:35 +0000 Subject: [Koha-bugs] [Bug 18214] Cannot edit list permissions of a private list In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18214 --- Comment #4 from Marcel de Rooy --- (In reply to Jonathan Druart from comment #3) > There is a Koha::VirtualShelf->is_shared method, should not we use it to > know if the permissions must be displayed or not? You dont need the check, opac-shelves will already say: You do not have permission to update this list. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Mar 7 15:14:07 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 07 Mar 2017 14:14:07 +0000 Subject: [Koha-bugs] [Bug 18214] Cannot edit list permissions of a private list In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18214 --- Comment #5 from Marcel de Rooy --- (In reply to Jonathan Druart from comment #3) > There is a Koha::VirtualShelf->is_shared method, should not we use it to > know if the permissions must be displayed or not? And it may have been shared. Or it was a public list. So the list may contain items from other people.. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Mar 7 15:32:56 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 07 Mar 2017 14:32:56 +0000 Subject: [Koha-bugs] [Bug 18185] Clears loan history In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18185 --- Comment #5 from Jonathan Druart --- Ricardo, I cannot recreate on 16.11.04 (using MariaDB). Can you confirm that you are not using MySQL in strict mode? See https://wiki.koha-community.org/wiki/Koha_on_ubuntu_-_packages#Ubuntu_16.04_and_MySQL_5.7 -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Tue Mar 7 15:35:24 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 07 Mar 2017 14:35:24 +0000 Subject: [Koha-bugs] [Bug 16755] allow SIP2 field DA ( hold patron name ) to be customized In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16755 Kyle M Hall changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Mar 7 15:35:27 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 07 Mar 2017 14:35:27 +0000 Subject: [Koha-bugs] [Bug 16755] allow SIP2 field DA ( hold patron name ) to be customized In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16755 Kyle M Hall changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #58489|0 |1 is obsolete| | --- Comment #3 from Kyle M Hall --- Created attachment 60875 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=60875&action=edit Bug 16755 - allow SIP2 field DA ( hold patron name ) to be customized The SIP2 DA field that Koha transmits is an odd and arbitrary format that some SIP2 clients cannot handle. It would be best if this format were customizable on a per-login basis in the same manner as the AV field. Test Plan: 1) Find an item that is checked out with holds 2) Return the item via SIP2 ( using the SIP2 cli emulator ) 3) Note the value of the DA field 4) Apply this patch, restart your SIP2 server 5) Repeat step 2 6) Note the DA field value has not changed 7) Add this parameter to the login stanza you are using: da_field_template="[% patron.surname %][% IF patron.firstname %], [% patron.firstname %][% END %]" 8) Restart the SIP2 server again 9) Repeat step 2 10) Note the DA field returned is now in the format "$surname, $firstname" Signed-off-by: Kyle M Hall Signed-off-by: Benjamin Daeuber -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Mar 7 15:39:58 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 07 Mar 2017 14:39:58 +0000 Subject: [Koha-bugs] [Bug 18104] allow SIP2 field AE (personal name ) to be customized In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18104 Kyle M Hall changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on| |16755 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16755 [Bug 16755] allow SIP2 field DA ( hold patron name ) to be customized -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Mar 7 15:39:58 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 07 Mar 2017 14:39:58 +0000 Subject: [Koha-bugs] [Bug 16755] allow SIP2 field DA ( hold patron name ) to be customized In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16755 Kyle M Hall changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |18104 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18104 [Bug 18104] allow SIP2 field AE (personal name ) to be customized -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Mar 7 15:40:03 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 07 Mar 2017 14:40:03 +0000 Subject: [Koha-bugs] [Bug 18104] allow SIP2 field AE (personal name ) to be customized In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18104 Kyle M Hall changed: What |Removed |Added ---------------------------------------------------------------------------- See Also|https://bugs.koha-community | |.org/bugzilla3/show_bug.cgi | |?id=16755 | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Mar 7 15:40:03 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 07 Mar 2017 14:40:03 +0000 Subject: [Koha-bugs] [Bug 16755] allow SIP2 field DA ( hold patron name ) to be customized In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16755 Kyle M Hall changed: What |Removed |Added ---------------------------------------------------------------------------- See Also|https://bugs.koha-community | |.org/bugzilla3/show_bug.cgi | |?id=18104 | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Mar 7 15:40:27 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 07 Mar 2017 14:40:27 +0000 Subject: [Koha-bugs] [Bug 18104] allow SIP2 field AE (personal name ) to be customized In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18104 Kyle M Hall changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Mar 7 15:40:29 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 07 Mar 2017 14:40:29 +0000 Subject: [Koha-bugs] [Bug 18104] allow SIP2 field AE (personal name ) to be customized In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18104 Kyle M Hall changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #60845|0 |1 is obsolete| | --- Comment #2 from Kyle M Hall --- Created attachment 60876 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=60876&action=edit Bug 18104 - allow SIP2 field AE (personal name ) to be customized Koha's SIP2 server sends the patron's name in the format "Firstname Surname" which is not very good for machine reading. We need to allow the format of the patron name to be customized in a manner similar to what is done with the DA field on bug 16755. Test Plan: 1) Apply this patch, start or restart your SIP server 2) Find a patron with a first and last name 3) Send a patron information request via the sip2 cli tool 4) Note the AE field has the format " " ( i.e. the current behavior ) 5) Add this parameter to the login stanza you are using: ae_field_template="[% patron.surname %][% IF patron.firstname %], [% patron.firstname %][% END %]" 6) Restart your SIP server 7) Repeat step 3 8) Note the AE field now has the format ", " Signed-off-by: Kyle M Hall Signed-off-by: Benjamin Daeuber -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Mar 7 16:39:11 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 07 Mar 2017 15:39:11 +0000 Subject: [Koha-bugs] [Bug 14973] Suggestions - Search and warn user about existing biblio when submitting a suggestion In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14973 Alex Arnaud changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #44334|0 |1 is obsolete| | Attachment #44335|0 |1 is obsolete| | --- Comment #19 from Alex Arnaud --- Created attachment 60877 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=60877&action=edit Bug 14973: Check existing biblio when submitting a purchase suggestion (opac side) Test plan: - Go to opac suggestions page (opac-suggestions.pl) and click on "New purchase suggestion", - type the title (and author?) of a document that stand in you database - you should get a warning message about an exiting biblio. - clicking on confirm your suggestion add it, cancel does nothing Signed-off-by: Nicole Engard -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Mar 7 16:46:05 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 07 Mar 2017 15:46:05 +0000 Subject: [Koha-bugs] [Bug 14328] sendbasket: Sent cart does not contain a name In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14328 Marcel de Rooy changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |RESOLVED Resolution|--- |FIXED --- Comment #4 from Marcel de Rooy --- Closing this one now. Seems fixed; can always reopen if needed. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Mar 7 16:46:18 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 07 Mar 2017 15:46:18 +0000 Subject: [Koha-bugs] [Bug 14328] sendbasket: Sent cart does not contain a name In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14328 Marcel de Rooy changed: What |Removed |Added ---------------------------------------------------------------------------- Status|RESOLVED |CLOSED -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Mar 7 17:02:23 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 07 Mar 2017 16:02:23 +0000 Subject: [Koha-bugs] [Bug 18219] "Not checked out." problem message displays twice on local use. In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18219 --- Comment #3 from Christopher Brannon --- (In reply to Marc V?ron from comment #2) > Introduced by following Bug? > > Bug 16530 - Add a circ sidebar navigation menu > > There seem to be more duplications, e.g. > [% IF ( errmsgloo.prevdebarred ) %] Marc, Thanks for finding this. Do you mind if I try my hand at writing a patch for this? This will be my first attempt. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Tue Mar 7 17:06:54 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 07 Mar 2017 16:06:54 +0000 Subject: [Koha-bugs] [Bug 16588] Remove the Readonly dependency (again) In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16588 --- Comment #32 from Jonathan Druart --- (In reply to Srdjan Jankovic from comment #31) > (In reply to Jonathan Druart from comment #30) > > (In reply to Srdjan Jankovic from comment #29) > > > Is there any reason we have BIBLIOS_INDEX and AUTHORITIES_INDEX defined in > > > Koha::SearchEngine::Elasticsearch? > > > > Where do you want to have them defined? > > Well they are already defined with the same values in Koha::SearchEngine. I > just wanted to know if they relate to the same thing. Yes, in my understanding they are. One could be removed. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Mar 7 17:11:36 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 07 Mar 2017 16:11:36 +0000 Subject: [Koha-bugs] [Bug 7534] New OPACAllowUserToChooseBranch setting for only showing libraries allowing holds In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7534 Lari Taskula changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #60794|0 |1 is obsolete| | --- Comment #26 from Lari Taskula --- Created attachment 60878 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=60878&action=edit Bug 7534: Add new column "pickup_location" to branches This patch adds a new column "pickup_location" for each library. This value defines whether a library can be used as a pickup location or not. For extended configurability, this flag could perhaps be considered as a part of issuing rules, but as of now, this patch only offers a simple flag into each library. This method also allows easy way for REST API to determine valid pickup locations by querying the /libraries endpoint. To test: 1. perl installer/data/mysql/updatedatabase.pl 2. Observe DEV atomic update: bug_7534.perl Upgrade to XXX done (Bug 7534 - Let libraries have configuration for pickup locations) https://bugs.koha-community.org/show_bug.cgi?id=7354 -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Tue Mar 7 17:11:57 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 07 Mar 2017 16:11:57 +0000 Subject: [Koha-bugs] [Bug 7534] New OPACAllowUserToChooseBranch setting for only showing libraries allowing holds In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7534 Lari Taskula changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #60795|0 |1 is obsolete| | --- Comment #27 from Lari Taskula --- Created attachment 60879 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=60879&action=edit Bug 7534: Use search parameters for Koha::Template::Plugin::Branches->all This lets us query libraries with additional search parameters and is useful for this particular Bug by allowing us to select pickup locations. Unit tests included. To test: 1. prove t/db_dependent/Template/Plugin/Branches.t -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Tue Mar 7 17:12:10 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 07 Mar 2017 16:12:10 +0000 Subject: [Koha-bugs] [Bug 7534] New OPACAllowUserToChooseBranch setting for only showing libraries allowing holds In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7534 Lari Taskula changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #60796|0 |1 is obsolete| | --- Comment #28 from Lari Taskula --- Created attachment 60880 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=60880&action=edit Bug 7534: Add configuration to admin/branches.pl This patch adds a configuration option for pickup locations. To test: 1. Apply patch 2. Go to cgi-bin/koha/admin/branches.pl 3. Observe there is a new column "Pickup location" 4. Click "Edit" for any library 5. Scroll to bottom of the page and select "No" 6. Click "Submit" 7. Observe your library in Libraries-table, notice the value of "Pickup location" has changed to "No" -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Mar 7 17:12:24 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 07 Mar 2017 16:12:24 +0000 Subject: [Koha-bugs] [Bug 7534] New OPACAllowUserToChooseBranch setting for only showing libraries allowing holds In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7534 Lari Taskula changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #60797|0 |1 is obsolete| | --- Comment #29 from Lari Taskula --- Created attachment 60881 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=60881&action=edit Bug 7534: Display pickup locations instead of all libraries in request.pl This patch sets request.tt to use the list of pickup libraries instead of every library in the system. To test: 1. Go to cgi-bin/koha/admin/branches.pl 2. Configure one of your libraries to "Pickup location" => "No" 3. Go place a hold in intranet 4. See the provided "Pickup at" list 5. Observe the library that you configured is not present in the list 6. Place the hold 7. See list of existing holds on that biblio 8. See "Pickup library" column and observe your configured library is not included in the list -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Tue Mar 7 17:12:40 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 07 Mar 2017 16:12:40 +0000 Subject: [Koha-bugs] [Bug 7534] New OPACAllowUserToChooseBranch setting for only showing libraries allowing holds In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7534 Lari Taskula changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #60798|0 |1 is obsolete| | --- Comment #30 from Lari Taskula --- Created attachment 60882 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=60882&action=edit Bug 7534: Display pickup locations instead of all libraries in opac-reserve.pl This patch sets opac-reserve.tt to use the list of pickup libraries instead of every library in the system. To test: 1. Go to cgi-bin/koha/admin/branches.pl 2. Configure one of your libraries to "Pickup location" => "No" 3. Go to OPAC and place a hold 4. See the provided Pickup location list 5. Observe the library that you configured is not present in the list -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Tue Mar 7 17:12:54 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 07 Mar 2017 16:12:54 +0000 Subject: [Koha-bugs] [Bug 7534] New OPACAllowUserToChooseBranch setting for only showing libraries allowing holds In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7534 --- Comment #31 from Lari Taskula --- Created attachment 60883 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=60883&action=edit Bug 7534: (QA-follow-up) Default pickup location to Yes when adding a new library To test: 1. Apply the patches before this one 2. Go to /cgi-bin/koha/admin/branches.pl 3. Press New library button 4. Scroll down the page and observe Pickup location defaults to No 5. Apply this patch 6. Go to /cgi-bin/koha/admin/branches.pl 7. Press New library button 8. Scroll down the page and observe Pickup location now defaults to Yes -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Mar 7 17:14:27 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 07 Mar 2017 16:14:27 +0000 Subject: [Koha-bugs] [Bug 18223] New: Request for ID to be included on patron details of overdue report Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18223 Bug ID: 18223 Summary: Request for ID to be included on patron details of overdue report Change sponsored?: --- Product: Koha Version: unspecified Hardware: PC OS: Linux Status: NEW Severity: enhancement Priority: P5 - low Component: Notices Assignee: koha-bugs at lists.koha-community.org Reporter: caroline.stone at wiltshire.ac.uk QA Contact: testopia at bugs.koha-community.org Request for patron ID to be included on patron details of overdue report in future enhancement. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Mar 7 17:15:04 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 07 Mar 2017 16:15:04 +0000 Subject: [Koha-bugs] [Bug 7534] New OPACAllowUserToChooseBranch setting for only showing libraries allowing holds In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7534 --- Comment #32 from Lari Taskula --- - Rebased on master - Removed Koha::Template::Plugin::Branches->pickup_locations and replaced it by adding ability to use search parameters in all. The removed function is used in Bug 7614 and therefore should not be added in this bug yet. - Fixed a bug, reported by Jonathan, when adding a new library the pickup location selection would default to "No". -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Tue Mar 7 17:16:17 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 07 Mar 2017 16:16:17 +0000 Subject: [Koha-bugs] [Bug 18223] Request for ID to be included on patron details of overdue report In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18223 Caroline changed: What |Removed |Added ---------------------------------------------------------------------------- OS|Linux |Windows CC| |caroline.stone at wiltshire.ac | |.uk -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Mar 7 17:17:14 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 07 Mar 2017 16:17:14 +0000 Subject: [Koha-bugs] [Bug 7534] New OPACAllowUserToChooseBranch setting for only showing libraries allowing holds In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7534 Lari Taskula changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #60799|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Tue Mar 7 17:17:31 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 07 Mar 2017 16:17:31 +0000 Subject: [Koha-bugs] [Bug 15707] Add ability to define hierarchical groups of libraries In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15707 --- Comment #167 from Jonathan Druart --- (In reply to Kyle M Hall from comment #166) > > - If Search groups contain several levels of subgroups, only the first one > > will be used. Not sure it's the expected behaviour. > > > > Example: > > __SEARCH_GROUP__ > > Group 1 > > Library 1 > > Subgroup > > Library 2 > > > > Search on "Group 1" will search in library 1. > > That is expected behavior and will be documented in the manual. There is no > additional utility for this particular feature to sub-groups. If L1 is in a subgroup that is in a group, L1 is not considered part of the group? This behaviour sounds very weird. Why did you choose this behaviour? -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Mar 7 17:20:41 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 07 Mar 2017 16:20:41 +0000 Subject: [Koha-bugs] [Bug 18224] New: Cleanup after Buug 14778 Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18224 Bug ID: 18224 Summary: Cleanup after Buug 14778 Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Staff Client Assignee: koha-bugs at lists.koha-community.org Reporter: olli-antti.kivilahti at jns.fi QA Contact: testopia at bugs.koha-community.org CC: gmcharlt at gmail.com Fixtures introduce biblios but they are not used in the whole test case. Remove unnecessary code. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Tue Mar 7 17:21:37 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 07 Mar 2017 16:21:37 +0000 Subject: [Koha-bugs] [Bug 18224] Cleanup after Buug 14778 In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18224 --- Comment #1 from Olli-Antti Kivilahti --- Created attachment 60884 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=60884&action=edit Bug 18224 - Cleanup after Buug 14778 Removes unnecessary test context clutter. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Tue Mar 7 17:21:53 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 07 Mar 2017 16:21:53 +0000 Subject: [Koha-bugs] [Bug 18224] Cleanup after Buug 14778 In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18224 Olli-Antti Kivilahti changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on| |14778 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14778 [Bug 14778] DBIC should create/own the DB handler -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Tue Mar 7 17:21:53 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 07 Mar 2017 16:21:53 +0000 Subject: [Koha-bugs] [Bug 14778] DBIC should create/own the DB handler In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14778 Olli-Antti Kivilahti changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |18224 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18224 [Bug 18224] Cleanup after Buug 14778 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Mar 7 17:22:19 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 07 Mar 2017 16:22:19 +0000 Subject: [Koha-bugs] [Bug 18224] Cleanup after Buug 14778 In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18224 Olli-Antti Kivilahti changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Tue Mar 7 17:25:13 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 07 Mar 2017 16:25:13 +0000 Subject: [Koha-bugs] [Bug 18225] New: Return date to be same as issue date after holiday closed period Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18225 Bug ID: 18225 Summary: Return date to be same as issue date after holiday closed period Change sponsored?: --- Product: Koha Version: unspecified Hardware: PC OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Holidays Assignee: koha-bugs at lists.koha-community.org Reporter: caroline.stone at wiltshire.ac.uk QA Contact: testopia at bugs.koha-community.org Request for return date to be same as issue date after holiday closed period. Currently having to manually change each Hard Due Date via Circulation and Fine Rules for every variation of Patron Category and item type with 21 day loans and 7 day loans before holiday closed period. Then return to "none defined" manually. Due to having students that do not attend every day of the week, we need return dates to be on the same day of the week as the day they are issued. This works until we have a closed period when the return date automatically goes to the first day that we are open. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Tue Mar 7 17:29:10 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 07 Mar 2017 16:29:10 +0000 Subject: [Koha-bugs] [Bug 18219] "Not checked out." problem message displays twice on local use. In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18219 --- Comment #4 from Marc V?ron --- (In reply to Christopher Brannon from comment #3) > (In reply to Marc V?ron from comment #2) > > Introduced by following Bug? > > > > Bug 16530 - Add a circ sidebar navigation menu > > > > There seem to be more duplications, e.g. > > [% IF ( errmsgloo.prevdebarred ) %] > > Marc, > Thanks for finding this. Do you mind if I try my hand at writing a patch > for this? This will be my first attempt. Hi Christopher, That is perfect, go ahead :-) -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Mar 7 17:53:40 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 07 Mar 2017 16:53:40 +0000 Subject: [Koha-bugs] [Bug 7614] Branch transfer limit and holds In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7614 Koha Team AMU changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |koha.aixmarseille at gmail.com -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Mar 7 17:55:34 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 07 Mar 2017 16:55:34 +0000 Subject: [Koha-bugs] [Bug 18226] New: Remove "use Test::DBIx::Class" instantiations' dangerous code duplication Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18226 Bug ID: 18226 Summary: Remove "use Test::DBIx::Class" instantiations' dangerous code duplication Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Architecture, internals, and plumbing Assignee: gmcharlt at gmail.com Reporter: olli-antti.kivilahti at jns.fi QA Contact: testopia at bugs.koha-community.org Everywhere where Test::DBIx::Class is used, a following blob of code follows: use Test::DBIx::Class { schema_class => 'Koha::Schema', connect_info => ['dbi:SQLite:dbname=:memory:','',''], connect_opts => { name_sep => '.', quote_char => '`', }, fixture_class => '::Populate', }, 'SocialData', 'Biblioitem' ; Instead of duplicating this same code everywhere, use a default configuration for a Test::DBIx::Class in t/etc/schema.pl -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Mar 7 17:58:39 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 07 Mar 2017 16:58:39 +0000 Subject: [Koha-bugs] [Bug 18226] Remove "use Test::DBIx::Class" instantiations' dangerous code duplication In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18226 --- Comment #1 from Olli-Antti Kivilahti --- Created attachment 60885 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=60885&action=edit Bug 18226 - Remove "use Test::DBIx::Class" instantiations' dangerous code duplication Is 'instantiations' even a word? Use a Test::DBIx::Class defaults instead. Save your keyboard and prevent horrible bugs from emerging from rampant code duplication. This change doesn't seem to have any impact on the speed of executing those tests. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Mar 7 17:59:43 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 07 Mar 2017 16:59:43 +0000 Subject: [Koha-bugs] [Bug 18226] Remove "use Test::DBIx::Class" instantiations' dangerous code duplication In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18226 Olli-Antti Kivilahti changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on| |18089 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18089 [Bug 18089] All XSLT testing singleBranchMode = 0 fails to show even if install has only 1 branch -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Mar 7 17:59:43 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 07 Mar 2017 16:59:43 +0000 Subject: [Koha-bugs] [Bug 18089] All XSLT testing singleBranchMode = 0 fails to show even if install has only 1 branch In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18089 Olli-Antti Kivilahti changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |18226 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18226 [Bug 18226] Remove "use Test::DBIx::Class" instantiations' dangerous code duplication -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Mar 7 17:59:52 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 07 Mar 2017 16:59:52 +0000 Subject: [Koha-bugs] [Bug 18226] Remove "use Test::DBIx::Class" instantiations' dangerous code duplication In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18226 Olli-Antti Kivilahti changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Mar 7 18:00:53 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 07 Mar 2017 17:00:53 +0000 Subject: [Koha-bugs] [Bug 14778] DBIC should create/own the DB handler In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14778 Olli-Antti Kivilahti changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |18226 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18226 [Bug 18226] Remove "use Test::DBIx::Class" instantiations' dangerous code duplication -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Mar 7 18:00:53 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 07 Mar 2017 17:00:53 +0000 Subject: [Koha-bugs] [Bug 18226] Remove "use Test::DBIx::Class" instantiations' dangerous code duplication In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18226 Olli-Antti Kivilahti changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on| |14778 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14778 [Bug 14778] DBIC should create/own the DB handler -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Mar 7 18:11:43 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 07 Mar 2017 17:11:43 +0000 Subject: [Koha-bugs] [Bug 7534] New OPACAllowUserToChooseBranch setting for only showing libraries allowing holds In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7534 --- Comment #33 from Koha Team AMU --- Test on sandbox1 ByWater Solutions This patch adds a configuration option for pickup locations. To test: 1. Apply patch 2. Go to cgi-bin/koha/admin/branches.pl 3. Observe there is a new column "Pickup location" 4. Click "Edit" for any library 5. Scroll to bottom of the page and select "No" 6. Click "Submit" 7. Observe your library in Libraries-table, notice the value of "Pickup location" has changed to "No" --> OK This patch sets request.tt to use the list of pickup libraries instead of every library in the system. To test: 1. Go to cgi-bin/koha/admin/branches.pl 2. Configure one of your libraries to "Pickup location" => "No" 3. Go place a hold in intranet 4. See the provided "Pickup at" list 5. Observe the library that you configured is not present in the list 6. Place the hold 7. See list of existing holds on that biblio 8. See "Pickup library" column and observe your configured library is not included in the list --> OK This patch sets opac-reserve.tt to use the list of pickup libraries instead of every library in the system. To test: 1. Go to cgi-bin/koha/admin/branches.pl 2. Configure one of your libraries to "Pickup location" => "No" 3. Go to OPAC and place a hold 4. See the provided Pickup location list 5. Observe the library that you configured is not present in the list --> OK To test: 1. Apply the patches before this one 2. Go to /cgi-bin/koha/admin/branches.pl 3. Press New library button 4. Scroll down the page and observe Pickup location defaults to No 5. Apply this patch 6. Go to /cgi-bin/koha/admin/branches.pl 7. Press New library button 8. Scroll down the page and observe Pickup location now defaults to Yes --> OK I don't change status to signed off because I can't test on sandbox 2 elements : https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7534#c18 https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7534#c19 -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Tue Mar 7 18:22:11 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 07 Mar 2017 17:22:11 +0000 Subject: [Koha-bugs] [Bug 18226] Remove "use Test::DBIx::Class" instantiations' dangerous code duplication In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18226 --- Comment #2 from Olli-Antti Kivilahti --- Created attachment 60886 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=60886&action=edit Bug 18226 - Remove "use Test::DBIx::Class" instantiations' dangerous code duplication. Replace mock_dbh 1 t/00-load.t already checks if all of the perl modules can be compiled. The tests deleted in this commit do a duplicate test with t/00-load.t Hence they have become unnecessary. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Mar 7 18:28:02 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 07 Mar 2017 17:28:02 +0000 Subject: [Koha-bugs] [Bug 18226] Remove "use Test::DBIx::Class" instantiations' dangerous code duplication In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18226 --- Comment #3 from Olli-Antti Kivilahti --- t/db_dependent/Circulation/CalcDateDue.t fails with date calculus. SQLite is peculiar with date calculus. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Mar 7 18:49:00 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 07 Mar 2017 17:49:00 +0000 Subject: [Koha-bugs] [Bug 18209] Patron's card manage.pl page is not fully translatable In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18209 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |jonathan.druart at bugs.koha-c | |ommunity.org Status|Signed Off |Failed QA --- Comment #3 from Jonathan Druart --- Philippe, This is done differently in labels/label-manage.tt We should stay consistent and use the same way to make these strings translatable in both template files. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Mar 7 18:55:07 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 07 Mar 2017 17:55:07 +0000 Subject: [Koha-bugs] [Bug 12972] Transfer slip and transfer message (blue box) can conflict In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12972 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Mar 7 18:55:12 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 07 Mar 2017 17:55:12 +0000 Subject: [Koha-bugs] [Bug 12972] Transfer slip and transfer message (blue box) can conflict In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12972 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #60864|0 |1 is obsolete| | --- Comment #3 from Jonathan Druart --- Created attachment 60887 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=60887&action=edit Bug 12972 - Transfer slip and transfer message (blue box) can conflict Instead of passing the homebranch to the slip, let's pass TransferWaitingAt (the value we display) To test: 1 - Check in an item that will initiate a transfer (hold or automatic item return) 2 - Note the transfer message and receipt match 3 - Remove the reason for transfer (bot don't cancel transfer) i.e. cancel hold or change homebranch of item to current library 4 - Check the item in again 5 - Note the message displays the transfer destination and the slip shows the homebranch 6 - Apply patch 7 - Repeat 5 but note slip and message match 8 - Test any edge cases for correctness 9 - sign off Signed-off-by: Josef Moravec Signed-off-by: Jonathan Druart -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Mar 7 18:55:24 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 07 Mar 2017 17:55:24 +0000 Subject: [Koha-bugs] [Bug 12972] Transfer slip and transfer message (blue box) can conflict In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12972 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |jonathan.druart at bugs.koha-c | |ommunity.org Severity|minor |normal -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Mar 7 19:10:23 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 07 Mar 2017 18:10:23 +0000 Subject: [Koha-bugs] [Bug 18115] Fix use of Objects as hashref in acqui/ addorderiso2709.pl - Bug 15503 followup In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18115 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Mar 7 19:10:28 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 07 Mar 2017 18:10:28 +0000 Subject: [Koha-bugs] [Bug 18115] Fix use of Objects as hashref in acqui/ addorderiso2709.pl - Bug 15503 followup In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18115 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #60834|0 |1 is obsolete| | --- Comment #7 from Jonathan Druart --- Created attachment 60888 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=60888&action=edit Bug 18115 - Fix use of Objects as hashref in acqui/addorderiso2709.pl - Bug 15503 followup Fix use of 'gstrate' for 'tax_rate' Signed-off-by: Matthias Meusburger Signed-off-by: Jonathan Druart -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Mar 7 19:20:36 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 07 Mar 2017 18:20:36 +0000 Subject: [Koha-bugs] [Bug 18174] Add update to Koha::Object In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18174 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #60721|0 |1 is obsolete| | --- Comment #6 from Jonathan Druart --- Created attachment 60889 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=60889&action=edit Bug 18174: Add update to Koha::Object Since Koha::Objects has a update method, we should allow it too in Koha::Object. Note that it is just redirecting to DBIx immediately. Changed the exception when the method generates an error. The previous code suggested that the method was not found, but this is not the case. Test plan: Run t/db_dependent/Koha/Object.t Followed test plan, tests passes OK. Signed-off-by: Marc V?ron Signed-off-by: Jonathan Druart -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Mar 7 19:20:31 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 07 Mar 2017 18:20:31 +0000 Subject: [Koha-bugs] [Bug 18174] Add update to Koha::Object In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18174 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Mar 7 19:35:53 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 07 Mar 2017 18:35:53 +0000 Subject: [Koha-bugs] [Bug 17169] Add facets for ccode to elasticsearch In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17169 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Mar 7 19:35:58 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 07 Mar 2017 18:35:58 +0000 Subject: [Koha-bugs] [Bug 17169] Add facets for ccode to elasticsearch In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17169 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #59946|0 |1 is obsolete| | Attachment #59947|0 |1 is obsolete| | Attachment #60741|0 |1 is obsolete| | --- Comment #15 from Jonathan Druart --- Created attachment 60890 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=60890&action=edit Bug 17169: Add a facet for ccode fields to ElasticSearch To test: 1 - Apply patch 2 - Backup your db 3 - Drop and create a new db to ensure your mappings are refreshed from the patch 4 - add some titles with items with collection codes 5 - search and see collection code facets 6 - sign off Work to be done: 1 - Replace codes with descriptions Signed-off-by: Tomas Cohen Arazi Signed-off-by: Jonathan Druart -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Mar 7 19:36:04 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 07 Mar 2017 18:36:04 +0000 Subject: [Koha-bugs] [Bug 17169] Add facets for ccode to elasticsearch In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17169 --- Comment #16 from Jonathan Druart --- Created attachment 60891 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=60891&action=edit Bug 17169: (QA followup) Add NORMARC and UNIMARC definitions for CCODE Signed-off-by: Tomas Cohen Arazi Signed-off-by: Jonathan Druart -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Mar 7 19:36:09 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 07 Mar 2017 18:36:09 +0000 Subject: [Koha-bugs] [Bug 17169] Add facets for ccode to elasticsearch In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17169 --- Comment #17 from Jonathan Druart --- Created attachment 60892 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=60892&action=edit Bug 17169 - Use CCODE descriptions instead of codes Signed-off-by: Jonathan Druart -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Mar 7 19:52:40 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 07 Mar 2017 18:52:40 +0000 Subject: [Koha-bugs] [Bug 4969] Vendors can not be deleted / show only active vendors In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=4969 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. You are the QA Contact for the bug. From bugzilla-daemon at bugs.koha-community.org Tue Mar 7 19:52:44 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 07 Mar 2017 18:52:44 +0000 Subject: [Koha-bugs] [Bug 4969] Vendors can not be deleted / show only active vendors In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=4969 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #60807|0 |1 is obsolete| | --- Comment #24 from Jonathan Druart --- Created attachment 60893 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=60893&action=edit Bug 4969: Toggle showing of all/active vendors This patch provides the functionality to hide inactive vendors from the vendor search. To test: 1) Make sure at least one vendor is inactive 2) Do a vendor search 3) Confirm the link to show only active vendors works, and is replaced with a link to show all vendors when clicked 4) Confirm the link to show all vendors works, and is replaced with a link to show only active vendors when clicked Sponsored-by: Catalyst IT Followed test plan, works as expected Signed-off-by: Marc V?ron Signed-off-by: Jonathan Druart -- You are receiving this mail because: You are watching all bug changes. You are the QA Contact for the bug. From bugzilla-daemon at bugs.koha-community.org Tue Mar 7 19:52:55 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 07 Mar 2017 18:52:55 +0000 Subject: [Koha-bugs] [Bug 4969] Vendors can not be deleted / show only active vendors In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=4969 --- Comment #25 from Jonathan Druart --- Created attachment 60894 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=60894&action=edit Bug 4969: Cursor should be pointer for links Signed-off-by: Jonathan Druart -- You are receiving this mail because: You are watching all bug changes. You are the QA Contact for the bug. From bugzilla-daemon at bugs.koha-community.org Tue Mar 7 19:52:59 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 07 Mar 2017 18:52:59 +0000 Subject: [Koha-bugs] [Bug 4969] Vendors can not be deleted / show only active vendors In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=4969 --- Comment #26 from Jonathan Druart --- Created attachment 60895 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=60895&action=edit Bug 4969: Do not jump to the top on click Signed-off-by: Jonathan Druart -- You are receiving this mail because: You are watching all bug changes. You are the QA Contact for the bug. From bugzilla-daemon at bugs.koha-community.org Tue Mar 7 19:53:04 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 07 Mar 2017 18:53:04 +0000 Subject: [Koha-bugs] [Bug 4969] Vendors can not be deleted / show only active vendors In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=4969 --- Comment #27 from Jonathan Druart --- Created attachment 60896 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=60896&action=edit Bug 4969: Do not display the new link if we are seeing all baskets of a given vendor Signed-off-by: Jonathan Druart -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Mar 7 19:59:01 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 07 Mar 2017 18:59:01 +0000 Subject: [Koha-bugs] [Bug 5111] no way to delete a vendor In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5111 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Resolution|DUPLICATE |INVALID Status|CLOSED |RESOLVED CC| |jonathan.druart at bugs.koha-c | |ommunity.org -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Mar 7 19:59:23 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 07 Mar 2017 18:59:23 +0000 Subject: [Koha-bugs] [Bug 5111] no way to delete a vendor In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5111 --- Comment #3 from Jonathan Druart --- Marked as invalid instead of duplicate. -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Mar 7 20:10:05 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 07 Mar 2017 19:10:05 +0000 Subject: [Koha-bugs] [Bug 13937] Add a Z39.50 daemon that can inject item status MARC subfields In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13937 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Failed QA --- Comment #35 from Jonathan Druart --- (In reply to Jonathan Druart from comment #23) > Waiting for test coverage. Hum? -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Mar 7 20:16:02 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 07 Mar 2017 19:16:02 +0000 Subject: [Koha-bugs] [Bug 7534] New OPACAllowUserToChooseBranch setting for only showing libraries allowing holds In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7534 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |jonathan.druart at bugs.koha-c | |ommunity.org Assignee|koha-bugs at lists.koha-commun |lari.taskula at jns.fi |ity.org | -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Mar 7 20:30:06 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 07 Mar 2017 19:30:06 +0000 Subject: [Koha-bugs] [Bug 17361] Add item messages table and rest api endpoints In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17361 --- Comment #1 from Tom?s Cohen Arazi --- Created attachment 60897 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=60897&action=edit Bug 17361: Update database -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Mar 7 20:30:10 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 07 Mar 2017 19:30:10 +0000 Subject: [Koha-bugs] [Bug 17361] Add item messages table and rest api endpoints In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17361 --- Comment #2 from Tom?s Cohen Arazi --- Created attachment 60898 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=60898&action=edit Bug 17361: Update existing schema -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Mar 7 20:30:14 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 07 Mar 2017 19:30:14 +0000 Subject: [Koha-bugs] [Bug 17361] Add item messages table and rest api endpoints In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17361 --- Comment #3 from Tom?s Cohen Arazi --- Created attachment 60899 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=60899&action=edit Bug 17361: Add Koha::Item::Message(s) -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Mar 7 20:30:19 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 07 Mar 2017 19:30:19 +0000 Subject: [Koha-bugs] [Bug 17361] Add item messages table and rest api endpoints In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17361 --- Comment #4 from Tom?s Cohen Arazi --- Created attachment 60900 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=60900&action=edit Bug 17361: REST api | Add /items/messages endpoints This patch adds the following endpoints: - /items/{itemnumber}/messages - /items/{itemnumber}/messages/{item_message_id} for CRUD operation on item messages. Unit tests to come. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Mar 7 20:46:49 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 07 Mar 2017 19:46:49 +0000 Subject: [Koha-bugs] [Bug 17361] Add item messages table and rest api endpoints In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17361 Tom?s Cohen Arazi changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |17297 CC| |tomascohen at gmail.com Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17297 [Bug 17297] Give librarians the ability to add messages to an item -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Mar 7 20:46:49 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 07 Mar 2017 19:46:49 +0000 Subject: [Koha-bugs] [Bug 17297] Give librarians the ability to add messages to an item In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17297 Tom?s Cohen Arazi changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on| |17361 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17361 [Bug 17361] Add item messages table and rest api endpoints -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Mar 7 20:49:00 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 07 Mar 2017 19:49:00 +0000 Subject: [Koha-bugs] [Bug 7534] New OPACAllowUserToChooseBranch setting for only showing libraries allowing holds In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7534 --- Comment #34 from Jonathan Druart --- (In reply to Koha Team AMU from comment #33) > I don't change status to signed off because I can't test on sandbox 2 > elements : > https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7534#c18 This is done automatically on a sandbox. > https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7534#c19 This is for the QA step. Go ahead :) -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Mar 7 20:56:44 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 07 Mar 2017 19:56:44 +0000 Subject: [Koha-bugs] [Bug 18150] CanItemBeReserved doesn't work with ( IndependentBranches AND ! canreservefromotherbranches) In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18150 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Mar 7 20:56:48 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 07 Mar 2017 19:56:48 +0000 Subject: [Koha-bugs] [Bug 18150] CanItemBeReserved doesn't work with ( IndependentBranches AND ! canreservefromotherbranches) In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18150 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #60542|0 |1 is obsolete| | Attachment #60854|0 |1 is obsolete| | --- Comment #5 from Jonathan Druart --- Created attachment 60901 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=60901&action=edit Bug 18150 - CanItemBeReserved doesn't work with (IndependentBranches AND ! canreservefromotherbranches) The variable $item used to be a hash, but at the end of the function, it's a Koha object. As $item->{homebranch} doesn't yield anything and should be $item->homebranch. It prevents people using different branches without holds between branches from placing a hold on an item they should be able to place hold on. Test plan: 1. Before patch a. with IndependantBranches off b. try to place hold on an item you should be able to place hold on c. it should work d. put IndependantBranches on and canreservefromotherbranches off e. shouldn't work 2. after patches redo steps from (1) and everything should be working fine. Signed-off-by: Christopher Brannon Signed-off-by: Jonathan Druart Note: Item is fetched twice, it's not necessary. But out of the scope of this patch. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Mar 7 21:09:49 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 07 Mar 2017 20:09:49 +0000 Subject: [Koha-bugs] [Bug 17015] New Koha Calendar In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17015 Mehdi Hamidi changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #59520|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Tue Mar 7 21:09:55 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 07 Mar 2017 20:09:55 +0000 Subject: [Koha-bugs] [Bug 17015] New Koha Calendar In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17015 Mehdi Hamidi changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #59889|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Tue Mar 7 21:09:52 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 07 Mar 2017 20:09:52 +0000 Subject: [Koha-bugs] [Bug 17015] New Koha Calendar In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17015 Mehdi Hamidi changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #59888|0 |1 is obsolete| | -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Mar 7 21:09:59 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 07 Mar 2017 20:09:59 +0000 Subject: [Koha-bugs] [Bug 17015] New Koha Calendar In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17015 Mehdi Hamidi changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #59518|0 |1 is obsolete| | -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Mar 7 21:10:02 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 07 Mar 2017 20:10:02 +0000 Subject: [Koha-bugs] [Bug 17015] New Koha Calendar In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17015 Mehdi Hamidi changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #59519|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Tue Mar 7 21:10:49 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 07 Mar 2017 20:10:49 +0000 Subject: [Koha-bugs] [Bug 17015] New Koha Calendar In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17015 --- Comment #51 from Mehdi Hamidi --- Created attachment 60902 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=60902&action=edit Bug 17015 - DiscreteCalendar UI, Back-End and necessary scripts -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Tue Mar 7 21:10:57 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 07 Mar 2017 20:10:57 +0000 Subject: [Koha-bugs] [Bug 17015] New Koha Calendar In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17015 --- Comment #52 from Mehdi Hamidi --- Created attachment 60903 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=60903&action=edit Bug 17015 - Tests for DiscreteCalendar -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Tue Mar 7 21:13:10 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 07 Mar 2017 20:13:10 +0000 Subject: [Koha-bugs] [Bug 17015] New Koha Calendar In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17015 --- Comment #53 from Mehdi Hamidi --- Created attachment 60904 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=60904&action=edit Bug 17015 - Koha now uses the new DiscreteCalendar module -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Tue Mar 7 21:13:16 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 07 Mar 2017 20:13:16 +0000 Subject: [Koha-bugs] [Bug 17015] New Koha Calendar In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17015 --- Comment #54 from Mehdi Hamidi --- Created attachment 60905 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=60905&action=edit Bug 17015 - Updated Koha tests to use the new DiscreteCalendar module -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Tue Mar 7 21:13:23 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 07 Mar 2017 20:13:23 +0000 Subject: [Koha-bugs] [Bug 17015] New Koha Calendar In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17015 --- Comment #55 from Mehdi Hamidi --- Created attachment 60906 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=60906&action=edit Bug 17015 - Peformance tests for Koha::DiscreteCalendar -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Mar 7 21:25:48 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 07 Mar 2017 20:25:48 +0000 Subject: [Koha-bugs] [Bug 17015] New Koha Calendar In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17015 --- Comment #56 from Mehdi Hamidi --- There was a bug with the current patches when using the calendar without a library set. The calendar uses a default (DFLT) branch when no branchcode is passed. It now displays a message indicating that you are using the default calendar without having a library set. (In reply to Olli-Antti Kivilahti from comment #50) > Atomicupdate: > installer/data/mysql/atomicupdate/generate_discrete_calendar.perl I renamed the file so it matches the SQL, it's now : installer/data/mysql/atomicupdate/bug_17015_generate_discrete_calendar.perl I will be adding a screencast soon to display the features and the behavior of our calendar. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Mar 7 21:25:55 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 07 Mar 2017 20:25:55 +0000 Subject: [Koha-bugs] [Bug 18219] "Not checked out." problem message displays twice on local use. In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18219 --- Comment #5 from Christopher Brannon --- Created attachment 60907 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=60907&action=edit Bug 18219: Remove duplicated code in returns.tt Removed lines of code that were duplicated in bug 16530. Fixes alignment of a few lines of code surrounding duplication. Modifies returns.tt To test: 1) Check in items that are not checked out. 2) Note duplicated problem message (i.e. "Not checked out.") 3) Apply patch. 4) Repeat step 1. 5) Note the problem message is no longer duplicated. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Mar 7 21:26:29 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 07 Mar 2017 20:26:29 +0000 Subject: [Koha-bugs] [Bug 18219] "Not checked out." problem message displays twice on local use. In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18219 Christopher Brannon changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Tue Mar 7 21:44:08 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 07 Mar 2017 20:44:08 +0000 Subject: [Koha-bugs] [Bug 18219] "Not checked out." problem message displays twice on local use. In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18219 Marc V?ron changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #60907|0 |1 is obsolete| | --- Comment #6 from Marc V?ron --- Created attachment 60908 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=60908&action=edit Bug 18219: Remove duplicated code in returns.tt Removed lines of code that were duplicated in bug 16530. Fixes alignment of a few lines of code surrounding duplication. Modifies returns.tt To test: 1) Check in items that are not checked out. 2) Note duplicated problem message (i.e. "Not checked out.") 3) Apply patch. 4) Repeat step 1. 5) Note the problem message is no longer duplicated. Followed test plan, works as expected. Signed-off-by: Marc V?ron -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Mar 7 21:45:20 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 07 Mar 2017 20:45:20 +0000 Subject: [Koha-bugs] [Bug 18219] "Not checked out." problem message displays twice on local use. In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18219 Marc V?ron changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|koha-bugs at lists.koha-commun |cbrannon at cdalibrary.org |ity.org | Status|Needs Signoff |Signed Off Patch complexity|--- |Trivial patch -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Tue Mar 7 23:11:08 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 07 Mar 2017 22:11:08 +0000 Subject: [Koha-bugs] [Bug 13153] Waiting hold checked in at different library doesn' t re-route item to correct library In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13153 Nick Clemens changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Mar 7 23:11:12 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 07 Mar 2017 22:11:12 +0000 Subject: [Koha-bugs] [Bug 13153] Waiting hold checked in at different library doesn' t re-route item to correct library In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13153 --- Comment #11 from Nick Clemens --- Created attachment 60909 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=60909&action=edit Bug 13153 - Waiting hold checked in at different library doesn't re-route item to correct library This patch changes AddReturn to revert a waiting hold whenchecked in at another branch To test: 1 - Place a hold for pickup at current branch 2 - Check in and confirm hold 3 - Change branch 4 - Checkin the item again 5 - Note there is no message to transfer or hold 6 - Note current location (holdingbranch) has changed though status indicates waitingat original branch 7 - Apply patch 8 - Checkin the item again 9 - Note hold is reverted 10 - Note message to confirm hold/transfer 11 - Sign off -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Tue Mar 7 23:20:54 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 07 Mar 2017 22:20:54 +0000 Subject: [Koha-bugs] [Bug 18219] "Not checked out." problem message displays twice on local use. In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18219 Christopher Brannon changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Mar 7 23:20:56 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 07 Mar 2017 22:20:56 +0000 Subject: [Koha-bugs] [Bug 18219] "Not checked out." problem message displays twice on local use. In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18219 --- Comment #7 from Christopher Brannon --- Created attachment 60910 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=60910&action=edit Bug 18219: Remove extra whitespace from returns.tt -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Mar 7 23:30:25 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 07 Mar 2017 22:30:25 +0000 Subject: [Koha-bugs] [Bug 18219] "Not checked out." problem message displays twice on local use. In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18219 Christopher Brannon changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Mar 8 01:54:25 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 08 Mar 2017 00:54:25 +0000 Subject: [Koha-bugs] [Bug 16034] Integration with OverDrive Patron API In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16034 --- Comment #77 from Srdjan Jankovic --- (In reply to Marcel de Rooy from comment #76) > =head1 L METHODS > =item C > > sub return { > > Definitely a fine name for a method ;) Oh why cannot life be simple... I think it is safe, there are some rules and Perl knows which one's which. However, if it is making you uneasy, I can rename it to return_checkout() or something. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Mar 8 02:20:46 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 08 Mar 2017 01:20:46 +0000 Subject: [Koha-bugs] [Bug 10662] Build OAI-PMH Harvesting Client In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10662 Eugene Espinoza changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |eugenegf at yahoo.com --- Comment #113 from Eugene Espinoza --- Hi David! Any update on this? I'm interested on this feature. Thanks! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Mar 8 08:06:56 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 08 Mar 2017 07:06:56 +0000 Subject: [Koha-bugs] [Bug 16034] Integration with OverDrive Patron API In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16034 --- Comment #78 from Marcel de Rooy --- (In reply to Srdjan Jankovic from comment #77) > (In reply to Marcel de Rooy from comment #76) > > =head1 L METHODS > > =item C > > > > sub return { > > > > Definitely a fine name for a method ;) > > Oh why cannot life be simple... I think it is safe, there are some rules and > Perl knows which one's which. However, if it is making you uneasy, I can > rename it to return_checkout() or something. No worries. But we should not use reserved words for methods, columns, etc. In another report we just removed a 'return' column from issues.. As you will understand, git grepping on return is laborious. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Mar 8 10:25:02 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 08 Mar 2017 09:25:02 +0000 Subject: [Koha-bugs] [Bug 13153] Waiting hold checked in at different library doesn' t re-route item to correct library In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13153 Marc V?ron changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #60909|0 |1 is obsolete| | --- Comment #12 from Marc V?ron --- Created attachment 60911 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=60911&action=edit Bug 13153 - Waiting hold checked in at different library doesn't re-route item to correct library This patch changes AddReturn to revert a waiting hold whenchecked in at another branch To test: 1 - Place a hold for pickup at current branch 2 - Check in and confirm hold 3 - Change branch 4 - Checkin the item again 5 - Note there is no message to transfer or hold 6 - Note current location (holdingbranch) has changed though status indicates waitingat original branch 7 - Apply patch 8 - Checkin the item again 9 - Note hold is reverted 10 - Note message to confirm hold/transfer 11 - Sign off Followed test plan, item gos to 'In transit' as expected. Signed-off-by: Marc V?ron -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Mar 8 11:49:53 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 08 Mar 2017 10:49:53 +0000 Subject: [Koha-bugs] [Bug 18227] New: Koha::Logger utf8 handling defeating " wide characters in print" Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18227 Bug ID: 18227 Summary: Koha::Logger utf8 handling defeating "wide characters in print" Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Architecture, internals, and plumbing Assignee: gmcharlt at gmail.com Reporter: olli-antti.kivilahti at jns.fi QA Contact: testopia at bugs.koha-community.org One must explicitly tell the Log4perl-appenders to deal with utf8. Poor Log4perl. Poor utf8 in Perl. this patch adds utf8=1 to log4perl.conf -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Mar 8 11:52:28 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 08 Mar 2017 10:52:28 +0000 Subject: [Koha-bugs] [Bug 18227] Koha::Logger utf8 handling defeating "wide characters in print " In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18227 --- Comment #1 from Olli-Antti Kivilahti --- Created attachment 60912 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=60912&action=edit Bug 18227 - Koha::Logger utf8 handling defeating "wide characters in print" No more wide characters in print when logging to a file with Koha::Logger. Test with this string "?Turpo :" -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Mar 8 11:55:03 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 08 Mar 2017 10:55:03 +0000 Subject: [Koha-bugs] [Bug 15253] Add Koha::Logger based logging for SIP2 In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15253 Olli-Antti Kivilahti changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |https://bugs.koha-community | |.org/bugzilla3/show_bug.cgi | |?id=18227 CC| |olli-antti.kivilahti at jns.fi -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Mar 8 11:55:03 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 08 Mar 2017 10:55:03 +0000 Subject: [Koha-bugs] [Bug 18227] Koha::Logger utf8 handling defeating "wide characters in print " In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18227 Olli-Antti Kivilahti changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |https://bugs.koha-community | |.org/bugzilla3/show_bug.cgi | |?id=15253 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Mar 8 11:56:22 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 08 Mar 2017 10:56:22 +0000 Subject: [Koha-bugs] [Bug 18227] Koha::Logger utf8 handling defeating "wide characters in print " In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18227 Olli-Antti Kivilahti changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |https://bugs.koha-community | |.org/bugzilla3/show_bug.cgi | |?id=18205 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Mar 8 11:56:22 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 08 Mar 2017 10:56:22 +0000 Subject: [Koha-bugs] [Bug 18205] REST interface to Koha::Logger In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18205 Olli-Antti Kivilahti changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |olli-antti.kivilahti at jns.fi See Also| |https://bugs.koha-community | |.org/bugzilla3/show_bug.cgi | |?id=18227 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Mar 8 12:23:42 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 08 Mar 2017 11:23:42 +0000 Subject: [Koha-bugs] [Bug 14973] Suggestions - Search and warn user about existing biblio when submitting a suggestion In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14973 --- Comment #20 from Alex Arnaud --- Created attachment 60913 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=60913&action=edit Bug 14973: Check existing biblio when submitting a purchase suggestion (staff side) -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Mar 8 12:24:04 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 08 Mar 2017 11:24:04 +0000 Subject: [Koha-bugs] [Bug 14973] Suggestions - Search and warn user about existing biblio when submitting a suggestion In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14973 Alex Arnaud changed: What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Mar 8 14:07:19 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 08 Mar 2017 13:07:19 +0000 Subject: [Koha-bugs] [Bug 18228] New: Working title Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18228 Bug ID: 18228 Summary: Working title Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Lists Assignee: gmcharlt at gmail.com Reporter: m.de.rooy at rijksmuseum.nl QA Contact: testopia at bugs.koha-community.org CC: m.de.rooy at rijksmuseum.nl -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Mar 8 14:41:45 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 08 Mar 2017 13:41:45 +0000 Subject: [Koha-bugs] [Bug 18137] REST API: Migrate from Mojolicious::Plugin:: Swagger2 to Mojolicious::Plugin::OpenAPI In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18137 Tom?s Cohen Arazi changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |tomascohen at gmail.com --- Comment #22 from Tom?s Cohen Arazi --- I like it, and I'm testing it. My only concern is dependencies. I tried to install Mojolicious 6.40 along with Mojolicious::Plugin::OpenAPI 1.10 and it wouldn't install. 1.10 needs newer Mojo (7.something). -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Mar 8 14:58:40 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 08 Mar 2017 13:58:40 +0000 Subject: [Koha-bugs] [Bug 17835] Move C4::Koha::GetItemTypes to Koha::ItemTypes In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17835 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #60050|0 |1 is obsolete| | --- Comment #21 from Jonathan Druart --- Created attachment 60914 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=60914&action=edit Bug 17835: Replace GetItemTypes with Koha::ItemTypes Signed-off-by: Josef Moravec -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Mar 8 14:58:50 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 08 Mar 2017 13:58:50 +0000 Subject: [Koha-bugs] [Bug 17835] Move C4::Koha::GetItemTypes to Koha::ItemTypes In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17835 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #60052|0 |1 is obsolete| | --- Comment #23 from Jonathan Druart --- Created attachment 60916 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=60916&action=edit Bug 17835: Add an additional LEFT JOIN condition using DBIx::Class The previous query was wrong. If an item type did not contain the translation in the interface's language, the ->search_with_localization did not return it at all. What we need is definitely to add a second condition on the join. For reference: http://search.cpan.org/dist/DBIx-Class/lib/DBIx/Class/Relationship/Base.pm#condition https://blog.afoolishmanifesto.com/posts/dbix-class-parameterized-relationships/ That sounds hacky but seems to be the DBIx::Class path to follow. Bug 17835: follow-up Signed-off-by: Josef Moravec -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Mar 8 14:58:45 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 08 Mar 2017 13:58:45 +0000 Subject: [Koha-bugs] [Bug 17835] Move C4::Koha::GetItemTypes to Koha::ItemTypes In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17835 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #60051|0 |1 is obsolete| | --- Comment #22 from Jonathan Druart --- Created attachment 60915 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=60915&action=edit Bug 17835: Remove the subroutine GetItemTypes At this point the subroutine is no longer in used. Signed-off-by: Josef Moravec -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Mar 8 14:58:53 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 08 Mar 2017 13:58:53 +0000 Subject: [Koha-bugs] [Bug 17835] Move C4::Koha::GetItemTypes to Koha::ItemTypes In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17835 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #60053|0 |1 is obsolete| | --- Comment #24 from Jonathan Druart --- Created attachment 60917 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=60917&action=edit Bug 17835: Mock language pref value That way if prefs contain other languages, the test will still pass. Signed-off-by: Josef Moravec -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Mar 8 16:21:58 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 08 Mar 2017 15:21:58 +0000 Subject: [Koha-bugs] [Bug 18229] New: update_dbix_class_files.pl loads defaults from ~/.my.cnf Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18229 Bug ID: 18229 Summary: update_dbix_class_files.pl loads defaults from ~/.my.cnf Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Command-line Utilities Assignee: gmcharlt at gmail.com Reporter: olli-antti.kivilahti at jns.fi QA Contact: testopia at bugs.koha-community.org CC: robin at catalyst.net.nz I am so frustrated having to write those elongated --db_name, --db* parameters. This patch automatically loads defaults from your ~/.my.cnf so you don't have to copypaste stuff or write ad-hoc bash scripts. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Mar 8 16:25:54 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 08 Mar 2017 15:25:54 +0000 Subject: [Koha-bugs] [Bug 18229] update_dbix_class_files.pl loads defaults from ~/.my.cnf In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18229 --- Comment #1 from Olli-Antti Kivilahti --- Created attachment 60918 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=60918&action=edit Bug 18229 - update_dbix_class_files.pl loads defaults from ~/.my.cnf A) Put this to your ~/.my.cnf [client] host = 10.0.3.10 port = 3306 user = koha_ci password = "Mr. senior plays with his junior" database = koha_ci B) Then run update_dbix_class_files.pl perl misc/devel/update_dbix_class_files.pl --tablename issuingrules C) Update DBIx::Class files like a boss -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Mar 8 16:27:39 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 08 Mar 2017 15:27:39 +0000 Subject: [Koha-bugs] [Bug 18000] Add --tablename option to misc/devel/ update_dbix_class_files.pl script In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18000 Olli-Antti Kivilahti changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #59585|0 |1 is obsolete| | --- Comment #6 from Olli-Antti Kivilahti --- Created attachment 60919 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=60919&action=edit Bug 18000 - Add --tablename option to misc/devel/update_dbix_class_files.pl script Signed-off-by: Olli-Antti Kivilahti Makes life working with DBIx::Class less miserable. perl misc/devel/update_dbix_class_files.pl --tablename issuingrules Works as advertised. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Mar 8 16:30:27 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 08 Mar 2017 15:30:27 +0000 Subject: [Koha-bugs] [Bug 18000] Add --tablename option to misc/devel/ update_dbix_class_files.pl script In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18000 Olli-Antti Kivilahti changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |olli-antti.kivilahti at jns.fi Status|Needs Signoff |Signed Off --- Comment #7 from Olli-Antti Kivilahti --- This is a much needed improvement. Typically we only alter one table at a time so multiple table updating is not very important for most developers. If you are a RM, you prolly use this without --tablename. See Bug 18229 to make this even more approachable. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Mar 8 16:30:41 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 08 Mar 2017 15:30:41 +0000 Subject: [Koha-bugs] [Bug 18229] update_dbix_class_files.pl loads defaults from ~/.my.cnf In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18229 Olli-Antti Kivilahti changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on| |18000 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18000 [Bug 18000] Add --tablename option to misc/devel/update_dbix_class_files.pl script -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Mar 8 16:30:41 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 08 Mar 2017 15:30:41 +0000 Subject: [Koha-bugs] [Bug 18000] Add --tablename option to misc/devel/ update_dbix_class_files.pl script In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18000 Olli-Antti Kivilahti changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |18229 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18229 [Bug 18229] update_dbix_class_files.pl loads defaults from ~/.my.cnf -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Mar 8 16:35:19 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 08 Mar 2017 15:35:19 +0000 Subject: [Koha-bugs] [Bug 18226] Remove "use Test::DBIx::Class" instantiations' dangerous code duplication In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18226 --- Comment #4 from Olli-Antti Kivilahti --- Created attachment 60920 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=60920&action=edit Bug 18226 - Remove "use Test::DBIx::Class" instantiations' dangerous code duplication. Replace mock_dbh 2 Couldn't make the tests pass using Test::DBIx::Class, so reverted to the "usual way" since these tests are in db_dependent anyway. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Mar 8 16:35:32 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 08 Mar 2017 15:35:32 +0000 Subject: [Koha-bugs] [Bug 18230] New: Generate Koha::Patron:: Modification verification_token in ->new Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18230 Bug ID: 18230 Summary: Generate Koha::Patron::Modification verification_token in ->new Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Architecture, internals, and plumbing Assignee: gmcharlt at gmail.com Reporter: lari.taskula at jns.fi QA Contact: testopia at bugs.koha-community.org Currently verification_token is generated outside of the class. Move this logic into Koha::Patron::Modification->new. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Mar 8 16:36:13 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 08 Mar 2017 15:36:13 +0000 Subject: [Koha-bugs] [Bug 18229] update_dbix_class_files.pl loads defaults from ~/.my.cnf In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18229 Olli-Antti Kivilahti changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |https://bugs.koha-community | |.org/bugzilla3/show_bug.cgi | |?id=14967 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Mar 8 16:36:13 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 08 Mar 2017 15:36:13 +0000 Subject: [Koha-bugs] [Bug 14967] update_dbix_class_files.pl should have a default DB name In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14967 Olli-Antti Kivilahti changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |olli-antti.kivilahti at jns.fi See Also| |https://bugs.koha-community | |.org/bugzilla3/show_bug.cgi | |?id=18229 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Mar 8 16:36:56 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 08 Mar 2017 15:36:56 +0000 Subject: [Koha-bugs] [Bug 14967] update_dbix_class_files.pl should have a default DB name In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14967 --- Comment #1 from Olli-Antti Kivilahti --- See the Bug 18229. It has nifty defaults for you Tom?s! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Mar 8 16:40:31 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 08 Mar 2017 15:40:31 +0000 Subject: [Koha-bugs] [Bug 18231] New: Add the missing id-column to koha.issuingrules-table for DBIC fixtures Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18231 Bug ID: 18231 Summary: Add the missing id-column to koha.issuingrules-table for DBIC fixtures Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Circulation Assignee: koha-bugs at lists.koha-community.org Reporter: olli-antti.kivilahti at jns.fi QA Contact: testopia at bugs.koha-community.org CC: gmcharlt at gmail.com, kyle.m.hall at gmail.com Test::DBIx::Class fixtures won't work if the resultset doesn't support last_insert_id. This is only supported with a integer primary key. This patch adds one to issuingrules. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Wed Mar 8 16:41:26 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 08 Mar 2017 15:41:26 +0000 Subject: [Koha-bugs] [Bug 18231] Add the missing id-column to koha.issuingrules-table for DBIC fixtures In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18231 --- Comment #1 from Olli-Antti Kivilahti --- Created attachment 60921 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=60921&action=edit Bug 18231 - Add the missing id-column to koha.issuingrules-table for DBIC fixtures Many DBIx-stuffs depend on last_insert_id -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Mar 8 16:41:57 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 08 Mar 2017 15:41:57 +0000 Subject: [Koha-bugs] [Bug 13153] Waiting hold checked in at different library doesn' t re-route item to correct library In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13153 Christopher Brannon changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off --- Comment #13 from Christopher Brannon --- Found a problem scenario, may have to open another ticket, as this patch pretty much takes care of what is described. Item from Library B checked in at Library A. There is a hold for a patron at Library C. It is accidently transferred to Library B or any other library other than A or C. A transfer message comes up saying to transfer the item to Library C, saying there is a hold, but the patron name and barcode are blank (Patron category shows). There is also a blank bullet after the patron line. This may be a transfer message, but because it is showing that there is a hold, and the patron name and barcode are blank, I am not sure if it is part of this bug or something new. Issue: Transfer message does not show patron name or barcode. Extra bullet shown. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Mar 8 16:41:57 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 08 Mar 2017 15:41:57 +0000 Subject: [Koha-bugs] [Bug 18226] Remove "use Test::DBIx::Class" instantiations' dangerous code duplication In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18226 Olli-Antti Kivilahti changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |https://bugs.koha-community | |.org/bugzilla3/show_bug.cgi | |?id=18231 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Mar 8 16:41:57 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 08 Mar 2017 15:41:57 +0000 Subject: [Koha-bugs] [Bug 18231] Add the missing id-column to koha.issuingrules-table for DBIC fixtures In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18231 Olli-Antti Kivilahti changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |https://bugs.koha-community | |.org/bugzilla3/show_bug.cgi | |?id=18226 -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Mar 8 16:42:30 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 08 Mar 2017 15:42:30 +0000 Subject: [Koha-bugs] [Bug 18231] Add the missing id-column to koha.issuingrules-table for DBIC fixtures In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18231 Olli-Antti Kivilahti changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Mar 8 16:42:49 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 08 Mar 2017 15:42:49 +0000 Subject: [Koha-bugs] [Bug 18227] Koha::Logger utf8 handling defeating "wide characters in print " In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18227 Olli-Antti Kivilahti changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Mar 8 16:42:58 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 08 Mar 2017 15:42:58 +0000 Subject: [Koha-bugs] [Bug 18229] update_dbix_class_files.pl loads defaults from ~/.my.cnf In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18229 Olli-Antti Kivilahti changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Mar 8 16:48:18 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 08 Mar 2017 15:48:18 +0000 Subject: [Koha-bugs] [Bug 18232] New: Koha::Cache::flush - Simply flush all caches Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18232 Bug ID: 18232 Summary: Koha::Cache::flush - Simply flush all caches Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Architecture, internals, and plumbing Assignee: gmcharlt at gmail.com Reporter: olli-antti.kivilahti at jns.fi QA Contact: testopia at bugs.koha-community.org This is handy when upgrading Koha or fiddling with config. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Mar 8 16:49:16 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 08 Mar 2017 15:49:16 +0000 Subject: [Koha-bugs] [Bug 18229] update_dbix_class_files.pl loads defaults from ~/.my.cnf In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18229 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |jonathan.druart at bugs.koha-c | |ommunity.org --- Comment #2 from Jonathan Druart --- See: commit e0b0ae20531736ede2cd1113baf16323cb69b3d9 bug 8798: (follow-up) pass DB connection params to DBIC schema updater explicitly This patch changes update_dbix_class_files.pl so that the connection parameters to the reference database must be passed explicitly via command-line switches, rather than grabbing them from the current Koha context. The purpose of this is to intentionally put up a roadblock to reduce the chance that a developer (or release manager) accidentally updates the schema files to include local testing cruft such as temporary tables. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Mar 8 16:50:19 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 08 Mar 2017 15:50:19 +0000 Subject: [Koha-bugs] [Bug 18232] Koha::Cache::flush - Simply flush all caches In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18232 --- Comment #1 from Olli-Antti Kivilahti --- Created attachment 60922 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=60922&action=edit Bug 18232 - Koha::Cache::flush - Simply flush all caches So we can easily and without reading the code, figure out how to flush all caches. perl -e 'use Koha::Caches; Koha::Caches::flush();' This is handy dandy when upgrading Koha or fiddling with configs. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Mar 8 16:52:22 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 08 Mar 2017 15:52:22 +0000 Subject: [Koha-bugs] [Bug 18232] Koha::Cache::flush - Simply flush all caches In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18232 Olli-Antti Kivilahti changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff --- Comment #2 from Olli-Antti Kivilahti --- This might work or might not :) flush is needed however. I'll keep posting followups if this doesn't. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Mar 8 16:52:42 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 08 Mar 2017 15:52:42 +0000 Subject: [Koha-bugs] [Bug 18232] Koha::Cache::flush - Simply flush all caches In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18232 Olli-Antti Kivilahti changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on| |16140 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16140 [Bug 16140] Only clear L1 cache when needed -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Mar 8 16:52:42 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 08 Mar 2017 15:52:42 +0000 Subject: [Koha-bugs] [Bug 16140] Only clear L1 cache when needed In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16140 Olli-Antti Kivilahti changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |18232 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18232 [Bug 18232] Koha::Cache::flush - Simply flush all caches -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Mar 8 16:55:51 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 08 Mar 2017 15:55:51 +0000 Subject: [Koha-bugs] [Bug 13153] Waiting hold checked in at different library doesn' t re-route item to correct library In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13153 --- Comment #14 from Nick Clemens --- (In reply to Christopher Brannon from comment #13) > Found a problem scenario Is this a scenario in master, or a side effect of this patch? -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Wed Mar 8 17:07:39 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 08 Mar 2017 16:07:39 +0000 Subject: [Koha-bugs] [Bug 18226] Remove "use Test::DBIx::Class" instantiations' dangerous code duplication In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18226 Olli-Antti Kivilahti changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #60885|0 |1 is obsolete| | --- Comment #5 from Olli-Antti Kivilahti --- Created attachment 60923 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=60923&action=edit Bug 18226 - Remove "use Test::DBIx::Class" instantiations' dangerous code duplication Is 'instantiations' even a word? Use a Test::DBIx::Class defaults instead. Save your keyboard and prevent horrible bugs from emerging from rampant code duplication. This change doesn't seem to have any impact on the speed of executing those tests. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Mar 8 17:12:38 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 08 Mar 2017 16:12:38 +0000 Subject: [Koha-bugs] [Bug 18233] New: t/db_dependent/ 00-strict.t has non-existant resetversion.pl Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18233 Bug ID: 18233 Summary: t/db_dependent/00-strict.t has non-existant resetversion.pl Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Test Suite Assignee: chris at bigballofwax.co.nz Reporter: olli-antti.kivilahti at jns.fi QA Contact: gmcharlt at gmail.com Prior to pthis patch root at koha_ci_1:/home/koha/Koha# su -c "prove t/db_dependent" koha t/db_dependent/00-strict.t ............................... Can't stat resetversion.pl: No such file or directory at /usr/share/perl5/Test/Strict.pm line 151. After this patch, that funky warning has disappeared. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Mar 8 17:13:44 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 08 Mar 2017 16:13:44 +0000 Subject: [Koha-bugs] [Bug 18233] t/db_dependent/00-strict.t has non-existant resetversion.pl In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18233 --- Comment #1 from Olli-Antti Kivilahti --- Created attachment 60924 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=60924&action=edit Bug 18233 - t/db_dependent/00-strict.t has non-existant resetversion.pl Removes a warning. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Mar 8 17:15:04 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 08 Mar 2017 16:15:04 +0000 Subject: [Koha-bugs] [Bug 18233] t/db_dependent/00-strict.t has non-existant resetversion.pl In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18233 Olli-Antti Kivilahti changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Mar 8 17:21:31 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 08 Mar 2017 16:21:31 +0000 Subject: [Koha-bugs] [Bug 18229] update_dbix_class_files.pl loads defaults from ~/.my.cnf In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18229 Olli-Antti Kivilahti changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |RESOLVED Resolution|--- |WORKSFORME --- Comment #3 from Olli-Antti Kivilahti --- If you feel like that. I don't mind forking this feature. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Mar 8 17:33:57 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 08 Mar 2017 16:33:57 +0000 Subject: [Koha-bugs] [Bug 18234] New: After the last update, the program stopped reserving the literature. When I try to backup I get an error : No homebranch at /usr/share/koha/lib/C4/Reserves.pm line 2119. Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18234 Bug ID: 18234 Summary: After the last update, the program stopped reserving the literature. When I try to backup I get an error: No homebranch at /usr/share/koha/lib/C4/Reserves.pm line 2119. Change sponsored?: --- Product: Koha Version: 16.11 Hardware: All OS: Linux Status: NEW Severity: critical Priority: P5 - low Component: Hold requests Assignee: koha-bugs at lists.koha-community.org Reporter: sergeinik at tut.by QA Contact: testopia at bugs.koha-community.org CC: gmcharlt at gmail.com -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Mar 8 18:04:26 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 08 Mar 2017 17:04:26 +0000 Subject: [Koha-bugs] [Bug 18229] update_dbix_class_files.pl loads defaults from ~/.my.cnf In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18229 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Resolution|WORKSFORME |--- Status|RESOLVED |REOPENED --- Comment #4 from Jonathan Druart --- Actually I already wrote such a patch, but when I say Galen's patch I did not submit mine. I think this could be re-discussed. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Mar 8 18:04:41 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 08 Mar 2017 17:04:41 +0000 Subject: [Koha-bugs] [Bug 18229] update_dbix_class_files.pl loads defaults from ~/.my.cnf In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18229 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Status|REOPENED |In Discussion CC| |tomascohen at gmail.com -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Mar 8 18:09:35 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 08 Mar 2017 17:09:35 +0000 Subject: [Koha-bugs] [Bug 17674] Allow UI to delete serials in batch In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17674 Bouzid changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #58264|0 |1 is obsolete| | --- Comment #7 from Bouzid --- Created attachment 60925 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=60925&action=edit Bug 17674 - Add unit tests -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Mar 8 19:14:03 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 08 Mar 2017 18:14:03 +0000 Subject: [Koha-bugs] [Bug 17297] Give librarians the ability to add messages to an item In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17297 Kyle M Hall changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #60861|0 |1 is obsolete| | Attachment #60862|0 |1 is obsolete| | Attachment #60863|0 |1 is obsolete| | --- Comment #9 from Kyle M Hall --- Created attachment 60926 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=60926&action=edit Bug 17297 - Add npm and webpack config files -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Mar 8 19:14:00 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 08 Mar 2017 18:14:00 +0000 Subject: [Koha-bugs] [Bug 17297] Give librarians the ability to add messages to an item In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17297 Kyle M Hall changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Mar 8 19:14:10 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 08 Mar 2017 18:14:10 +0000 Subject: [Koha-bugs] [Bug 17297] Give librarians the ability to add messages to an item In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17297 --- Comment #10 from Kyle M Hall --- Created attachment 60927 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=60927&action=edit Bug 17297 - Add React based item message editor Signed-off-by: Josef Moravec -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Mar 8 19:14:13 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 08 Mar 2017 18:14:13 +0000 Subject: [Koha-bugs] [Bug 17297] Give librarians the ability to add messages to an item In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17297 --- Comment #11 from Kyle M Hall --- Created attachment 60928 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=60928&action=edit Bug 17297 - Add minified js file -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Mar 8 19:21:53 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 08 Mar 2017 18:21:53 +0000 Subject: [Koha-bugs] [Bug 15654] Integrating a cash register system into Koha: An Example In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15654 Lisette changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |lisetteslatah at gmail.com -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Mar 8 19:23:59 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 08 Mar 2017 18:23:59 +0000 Subject: [Koha-bugs] [Bug 11887] Add script for collections agency reports In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11887 Lisette changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |lisetteslatah at gmail.com -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Mar 8 19:24:55 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 08 Mar 2017 18:24:55 +0000 Subject: [Koha-bugs] [Bug 11887] Add script for collections agency reports In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11887 --- Comment #9 from Lisette --- (In reply to Owen Leonard from comment #8) > Should this be 'Needs signoff?' I agree with Owen, it looks like this should be "Needs Signoff" instead of assigned. Nick? -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Mar 8 19:48:08 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 08 Mar 2017 18:48:08 +0000 Subject: [Koha-bugs] [Bug 18174] Add the Koha::Object->update method In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18174 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |https://bugs.koha-community | |.org/bugzilla3/show_bug.cgi | |?id=16961 Summary|Add update to Koha::Object |Add the | |Koha::Object->update method CC| |jonathan.druart at bugs.koha-c | |ommunity.org -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Mar 8 19:48:08 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 08 Mar 2017 18:48:08 +0000 Subject: [Koha-bugs] [Bug 16961] Add the Koha::Objects->update method In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16961 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |https://bugs.koha-community | |.org/bugzilla3/show_bug.cgi | |?id=18174 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Mar 8 19:57:38 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 08 Mar 2017 18:57:38 +0000 Subject: [Koha-bugs] [Bug 18235] New: Elastic search - Configurable facets Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18235 Bug ID: 18235 Summary: Elastic search - Configurable facets Change sponsored?: --- Product: Koha Version: unspecified Hardware: All OS: All Status: ASSIGNED Severity: enhancement Priority: P5 - low Component: Searching Assignee: jonathan.druart at bugs.koha-community.org Reporter: jonathan.druart at bugs.koha-community.org QA Contact: testopia at bugs.koha-community.org Depends on: 14899, 17169, 18174 >From the Elastic mappings configuration page, the librarians should be able to manage facets (display/hide and order). Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14899 [Bug 14899] Mapping configuration page for Elastic search https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17169 [Bug 17169] Add facets for ccode to elasticsearch https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18174 [Bug 18174] Add the Koha::Object->update method -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Mar 8 19:57:38 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 08 Mar 2017 18:57:38 +0000 Subject: [Koha-bugs] [Bug 14899] Mapping configuration page for Elastic search In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14899 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |18235 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18235 [Bug 18235] Elastic search - Configurable facets -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Mar 8 19:57:38 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 08 Mar 2017 18:57:38 +0000 Subject: [Koha-bugs] [Bug 17169] Add facets for ccode to elasticsearch In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17169 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |18235 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18235 [Bug 18235] Elastic search - Configurable facets -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Mar 8 19:57:38 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 08 Mar 2017 18:57:38 +0000 Subject: [Koha-bugs] [Bug 18174] Add the Koha::Object->update method In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18174 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |18235 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18235 [Bug 18235] Elastic search - Configurable facets -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Mar 8 20:00:16 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 08 Mar 2017 19:00:16 +0000 Subject: [Koha-bugs] [Bug 12446] Enable an adult to have a guarantor In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12446 Bouzid changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #53536|0 |1 is obsolete| | --- Comment #43 from Bouzid --- Created attachment 60929 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=60929&action=edit Bug 12446 - Enable an adult to have a guarantor Concflicts has been fixed. Also attributes in system preference : AdditionalGuarantorField are now displayed correctly in all scenerios. I have rebased every patch. This includes all the features from the previous patches. Removed the dollar signs and stopped using C4::Category On the patron category page, there is a new field to specify whether patrons can be guarantee or not. The atomic update SQL script adds this new field and sets it to true for categories of type "C" and "P". 1) Apply the patch 2) Run updatedatabase.pl to add AdditionalGuarantorField to preferences and canbeguarantee to categories. 3) Go to patron category administration, edit a category and change the value of Can Be Guarantee to yes (for Child and Professional mostly to set it by default) 4) See below to test various scenarios - Enable an adult to have a guarantor: 0.0) Create or edit a patron category of type 'A'. 0.1) Set the "Can be guarantee" field to "Yes" and save. 1) Select an adult patron -> details tab; 2) Click edit button; 3) validate "guarantor information" fieldset; - Shows guarantees' fines in the guarantor's page: 4) Click Set to patron button and select a guarantor; 5) Generate a fine; 6) Select guarantor patron -> details tab; 7) Validate guarantee's fine information. - Transfer some guarantor's information to the guarantee while adding a guarantiee: 0) Select an adult patron; 1) Insert all information; 2) Click Add guarantiee bouton; 3) Validade Garantor information/Main address/Contact fieldsets filled; - Transfer some guarantor's information to the guarantee while creating a new patron 0) Select an adult patron; 1) Insert all information; 2) Add a new adult patron; 3) Click "Set to patron" button; 4) Select the adult patron from 0); 5) Validade Garantor information/Main address/Contact fieldsets filled; - Transfer some guarantor's information to the guarantee while adding a guarantiee: 0) Select an adult patron; 1) Insert all information; 2) Click Add guarantiee bouton; 3) Validade Garantor information/Main address/Contact fieldsets filled; - Transfer guarantor's alternate address/contact to the guarantee while creating a new patron: 0) Search AdditionalGuarantorField preference; 1) Insert some additional database columns from alternate address/contact to be transferred from guarantor; 2) Select an adult patron; 3) Insert all information; 4) Add a new adult patron; 5) Click "Set to patron" button; 6) Select the adult patron from 0); 7) Validade Garantor information/Main address/Contact fieldsets filled; 8) Validade Garantor additional alternate address/contact filled; - Transfer guarantor's alternate address/contact to the guarantee while adding a guarantiee: 0) Search AdditionalGuarantorField preference; 1) Insert some additional database columns from alternate address/contact to be transferred from guarantor; 3) Select an adult patron; 4) Insert all information; 5) Click Add guarantiee bouton; 6) Validade Garantor information/Main address/Contact fieldsets filled; 7) Validade Garantor additional alternate address/contact filled; -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Mar 8 20:01:56 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 08 Mar 2017 19:01:56 +0000 Subject: [Koha-bugs] [Bug 12446] Enable an adult to have a guarantor In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12446 Bouzid changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #53913|0 |1 is obsolete| | Attachment #60929|0 |1 is obsolete| | --- Comment #44 from Bouzid --- Created attachment 60930 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=60930&action=edit Bug 12446 - Enable an adult to have a guarantor Concflicts has been fixed. Also attributes in system preference : AdditionalGuarantorField are now displayed correctly in all scenerios. I have rebased every patch. This includes all the features from the previous patches. Removed the dollar signs and stopped using C4::Category On the patron category page, there is a new field to specify whether patrons can be guarantee or not. The atomic update SQL script adds this new field and sets it to true for categories of type "C" and "P". 1) Apply the patch 2) Run updatedatabase.pl to add AdditionalGuarantorField to preferences and canbeguarantee to categories. 3) Go to patron category administration, edit a category and change the value of Can Be Guarantee to yes (for Child and Professional mostly to set it by default) 4) See below to test various scenarios - Enable an adult to have a guarantor: 0.0) Create or edit a patron category of type 'A'. 0.1) Set the "Can be guarantee" field to "Yes" and save. 1) Select an adult patron -> details tab; 2) Click edit button; 3) validate "guarantor information" fieldset; - Shows guarantees' fines in the guarantor's page: 4) Click Set to patron button and select a guarantor; 5) Generate a fine; 6) Select guarantor patron -> details tab; 7) Validate guarantee's fine information. - Transfer some guarantor's information to the guarantee while adding a guarantiee: 0) Select an adult patron; 1) Insert all information; 2) Click Add guarantiee bouton; 3) Validade Garantor information/Main address/Contact fieldsets filled; - Transfer some guarantor's information to the guarantee while creating a new patron 0) Select an adult patron; 1) Insert all information; 2) Add a new adult patron; 3) Click "Set to patron" button; 4) Select the adult patron from 0); 5) Validade Garantor information/Main address/Contact fieldsets filled; - Transfer some guarantor's information to the guarantee while adding a guarantiee: 0) Select an adult patron; 1) Insert all information; 2) Click Add guarantiee bouton; 3) Validade Garantor information/Main address/Contact fieldsets filled; - Transfer guarantor's alternate address/contact to the guarantee while creating a new patron: 0) Search AdditionalGuarantorField preference; 1) Insert some additional database columns from alternate address/contact to be transferred from guarantor; 2) Select an adult patron; 3) Insert all information; 4) Add a new adult patron; 5) Click "Set to patron" button; 6) Select the adult patron from 0); 7) Validade Garantor information/Main address/Contact fieldsets filled; 8) Validade Garantor additional alternate address/contact filled; - Transfer guarantor's alternate address/contact to the guarantee while adding a guarantiee: 0) Search AdditionalGuarantorField preference; 1) Insert some additional database columns from alternate address/contact to be transferred from guarantor; 3) Select an adult patron; 4) Insert all information; 5) Click Add guarantiee bouton; 6) Validade Garantor information/Main address/Contact fieldsets filled; 7) Validade Garantor additional alternate address/contact filled; -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Mar 8 20:07:27 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 08 Mar 2017 19:07:27 +0000 Subject: [Koha-bugs] [Bug 18235] Elastic search - Configurable facets In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18235 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Mar 8 20:07:39 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 08 Mar 2017 19:07:39 +0000 Subject: [Koha-bugs] [Bug 18235] Elastic search - Configurable facets In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18235 --- Comment #2 from Jonathan Druart --- Created attachment 60932 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=60932&action=edit Bug 18235: DB changes -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Mar 8 20:07:34 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 08 Mar 2017 19:07:34 +0000 Subject: [Koha-bugs] [Bug 18235] Elastic search - Configurable facets In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18235 --- Comment #1 from Jonathan Druart --- Created attachment 60931 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=60931&action=edit Bug 18235: DBIx::Class schema changes -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Mar 8 20:07:46 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 08 Mar 2017 19:07:46 +0000 Subject: [Koha-bugs] [Bug 18235] Elastic search - Configurable facets In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18235 --- Comment #3 from Jonathan Druart --- Created attachment 60933 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=60933&action=edit Bug 18235: ES - Facets configurable This patch adds a new section 'Facet order' in the Biblio tab of the 'Search engine configuration' admin page of the Elastic mappings. The idea is to let the librarians define the facet to display and order them as their needs. The ergonomic is not perfect and I am open to any suggestions. Test plan: Move up and down the field list to order the facets Hide/show some facets At the OPAC and the staff interface you should see the changes on the search result page. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Mar 8 20:08:22 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 08 Mar 2017 19:08:22 +0000 Subject: [Koha-bugs] [Bug 13153] Waiting hold checked in at different library doesn' t re-route item to correct library In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13153 Christopher Brannon changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |In Discussion --- Comment #15 from Christopher Brannon --- There seems to be an intermittent problem with routing/information. I tried my previous scenario again, and it worked fine this time, but then I got the same failure through a different scenario. 1) Checked in item with no checkouts or holds belonging to Library B at Library A for transfer. Item is now in transit to Library B. 2) Placed a hold on item to be picked up at Library C. 3) Triggered hold at Library A and was routed to Library C. Item is in transit to Library C. 4) Signed in as Library D, checked in item and it routed Library C fine. 5) Signed in as Library C and triggered the hold. Item is now waiting. 6) Signed in as Library D, checked in item. The modal doesn't come up, and the transfer message is on the screen to got to transfer the item to Library C, but patron barcode and name are missing. 7) If I cancel the transfer and check it in again, the modal comes up and patron information shows properly. I think there is a conflict with an initial transfer that doesn't get cleared out in the whole process. On master, if I follow the same steps, this is what I see: 1) Checked in item with no checkouts or holds belonging to Library B at Library A for transfer. Item is now in transit to Library B. 2) Placed a hold on item to be picked up at Library C. 3) Triggered hold at Library A and was routed to Library C. Item is in transit to Library C. 4) Signed in as Library D, checked in item and it wants to go home to Library B. WRONG 5) Signed in as Library C and triggered the hold. Item is now waiting. 6) Signed in as Library D, checked in item. The modal doesn't come up, and the transfer message is on the screen to got to transfer the item HOME to Library B, AND to confirm hold for patron. The library the patron is picking up at is NOT showing, but patron name and barcode ARE showing. The extra bullet is showing and is a pre-existing issue. 7) If I cancel the transfer and check it in again, there are no messages and a local use is recorded. WRONG -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Mar 8 20:17:20 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 08 Mar 2017 19:17:20 +0000 Subject: [Koha-bugs] [Bug 12446] Enable an adult to have a guarantor In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12446 Bouzid changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #60930|0 |1 is obsolete| | --- Comment #45 from Bouzid --- Created attachment 60934 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=60934&action=edit Bug 12446 - Enable an adult to have a guarantor Concflicts has been fixed. Also attributes in system preference : AdditionalGuarantorField are now displayed correctly in all scenerios. I have rebased every patch. This includes all the features from the previous patches. Removed the dollar signs and stopped using C4::Category On the patron category page, there is a new field to specify whether patrons can be guarantee or not. The atomic update SQL script adds this new field and sets it to true for categories of type "C" and "P". 1) Apply the patch 2) Run updatedatabase.pl to add AdditionalGuarantorField to preferences and canbeguarantee to categories. 3) Go to patron category administration, edit a category and change the value of Can Be Guarantee to yes (for Child and Professional mostly to set it by default) 4) See below to test various scenarios - Enable an adult to have a guarantor: 0.0) Create or edit a patron category of type 'A'. 0.1) Set the "Can be guarantee" field to "Yes" and save. 1) Select an adult patron -> details tab; 2) Click edit button; 3) validate "guarantor information" fieldset; - Shows guarantees' fines in the guarantor's page: 4) Click Set to patron button and select a guarantor; 5) Generate a fine; 6) Select guarantor patron -> details tab; 7) Validate guarantee's fine information. - Transfer some guarantor's information to the guarantee while adding a guarantiee: 0) Select an adult patron; 1) Insert all information; 2) Click Add guarantiee bouton; 3) Validade Garantor information/Main address/Contact fieldsets filled; - Transfer some guarantor's information to the guarantee while creating a new patron 0) Select an adult patron; 1) Insert all information; 2) Add a new adult patron; 3) Click "Set to patron" button; 4) Select the adult patron from 0); 5) Validade Garantor information/Main address/Contact fieldsets filled; - Transfer some guarantor's information to the guarantee while adding a guarantiee: 0) Select an adult patron; 1) Insert all information; 2) Click Add guarantiee bouton; 3) Validade Garantor information/Main address/Contact fieldsets filled; - Transfer guarantor's alternate address/contact to the guarantee while creating a new patron: 0) Search AdditionalGuarantorField preference; 1) Insert some additional database columns from alternate address/contact to be transferred from guarantor; 2) Select an adult patron; 3) Insert all information; 4) Add a new adult patron; 5) Click "Set to patron" button; 6) Select the adult patron from 0); 7) Validade Garantor information/Main address/Contact fieldsets filled; 8) Validade Garantor additional alternate address/contact filled; - Transfer guarantor's alternate address/contact to the guarantee while adding a guarantiee: 0) Search AdditionalGuarantorField preference; 1) Insert some additional database columns from alternate address/contact to be transferred from guarantor; 3) Select an adult patron; 4) Insert all information; 5) Click Add guarantiee bouton; 6) Validade Garantor information/Main address/Contact fieldsets filled; 7) Validade Garantor additional alternate address/contact filled; -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Mar 8 20:18:30 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 08 Mar 2017 19:18:30 +0000 Subject: [Koha-bugs] [Bug 12446] Enable an adult to have a guarantor In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12446 Bouzid changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Patch doesn't apply |Needs Signoff CC| |bouzid.fergani at inlibro.com -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Mar 8 22:50:30 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 08 Mar 2017 21:50:30 +0000 Subject: [Koha-bugs] [Bug 18209] Patron's card manage.pl page is not fully translatable In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18209 Blou changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #60873|0 |1 is obsolete| | --- Comment #4 from Blou --- Created attachment 60935 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=60935&action=edit Bug 18209 - Patron's card manage.pl page is not fully translatable The headers of the tables displayed in patroncards/manage.tt are hardcoded in the .pl and thus cannot be translated. This simple fix reuse the translate_card_element tool already in the code to make the strings translatable. Applied patch and verified that table headers on manage.pl display the same as before. Signed-off-by: Marc V?ron -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Mar 8 22:51:27 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 08 Mar 2017 21:51:27 +0000 Subject: [Koha-bugs] [Bug 18209] Patron's card manage.pl page is not fully translatable In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18209 Blou changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Mar 9 00:21:24 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 08 Mar 2017 23:21:24 +0000 Subject: [Koha-bugs] [Bug 18137] REST API: Migrate from Mojolicious::Plugin:: Swagger2 to Mojolicious::Plugin::OpenAPI In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18137 Tom?s Cohen Arazi changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Failed QA --- Comment #23 from Tom?s Cohen Arazi --- Pleaes provide feedback about the dependencies so I can test it. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Mar 9 00:46:23 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 08 Mar 2017 23:46:23 +0000 Subject: [Koha-bugs] [Bug 18185] Clears loan history In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18185 --- Comment #6 from Fred --- Change from mysql to mariaDB without success, the error is maintained, I have Debian 8 -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Mar 9 00:48:17 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 08 Mar 2017 23:48:17 +0000 Subject: [Koha-bugs] [Bug 18185] Clears loan history In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18185 --- Comment #7 from Fred --- mysql Ver 15.1 Distrib 10.0.29-MariaDB, for debian-linux-gnu (x86_64) using readline 5.2 Server version: Apache/2.4.10 (Debian) -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Mar 9 01:08:41 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 09 Mar 2017 00:08:41 +0000 Subject: [Koha-bugs] [Bug 16034] Integration with OverDrive Patron API In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16034 --- Comment #79 from Srdjan Jankovic --- (In reply to Marcel de Rooy from comment #78) > > In another report we just removed a 'return' column from issues.. As you > will understand, git grepping on return is laborious. Ah right, of course, I had to do it myself when figuring out how difficult it would be to replace it. To my defence, I was grepping for "sub return" and "\->return". -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Mar 9 09:42:45 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 09 Mar 2017 08:42:45 +0000 Subject: [Koha-bugs] [Bug 9988] Leave larger authority merges to merge_authorities cronjob ( pref AuthorityMergeLimit) In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9988 Jacek Ablewicz changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |abl at biblos.pk.edu.pl -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Mar 9 10:38:11 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 09 Mar 2017 09:38:11 +0000 Subject: [Koha-bugs] [Bug 18209] Patron's card manage.pl page is not fully translatable In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18209 Marc V?ron changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #60935|0 |1 is obsolete| | --- Comment #5 from Marc V?ron --- Created attachment 60936 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=60936&action=edit Bug 18209 - Patron's card manage.pl page is not fully translatable The headers of the tables displayed in patroncards/manage.tt are hardcoded in the .pl and thus cannot be translated. This simple fix reuse the translate_card_element tool already in the code to make the strings translatable. Applied patch and verified that table headers on manage.pl display the same as before. Signed-off-by: Marc V?ron Re-tested, works as expected. Signed-off-by: Marc V?ron -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Mar 9 10:38:33 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 09 Mar 2017 09:38:33 +0000 Subject: [Koha-bugs] [Bug 18209] Patron's card manage.pl page is not fully translatable In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18209 Marc V?ron changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Mar 9 10:56:11 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 09 Mar 2017 09:56:11 +0000 Subject: [Koha-bugs] [Bug 7534] New OPACAllowUserToChooseBranch setting for only showing libraries allowing holds In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7534 Koha Team AMU changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off --- Comment #35 from Koha Team AMU --- (In reply to Jonathan Druart from comment #34) > (In reply to Koha Team AMU from comment #33) > > I don't change status to signed off because I can't test on sandbox 2 > > elements : > > https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7534#c18 > > This is done automatically on a sandbox. > > > https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7534#c19 > > This is for the QA step. > > Go ahead :) Thank you very much for the explanations ! :-) So, it works as expected and I change status to signed off ! :-) -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Mar 9 11:07:00 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 09 Mar 2017 10:07:00 +0000 Subject: [Koha-bugs] [Bug 18236] New: Add classes to material type icons on result lists and detail pages Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18236 Bug ID: 18236 Summary: Add classes to material type icons on result lists and detail pages Change sponsored?: --- Product: Koha Version: 3.22 Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: OPAC Assignee: oleonard at myacpl.org Reporter: katrin.fischer at bsz-bw.de QA Contact: testopia at bugs.koha-community.org Some libraries would prefer to show different material type icons in the result lists and detail pages in OPAC in staff. In order to make this possible with CSS, it would be nice if every icon had its own specific class so it's easy to target them. Something like: mt_icon_book, mt_icon_film, mt_icon_... -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Mar 9 11:07:09 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 09 Mar 2017 10:07:09 +0000 Subject: [Koha-bugs] [Bug 18236] Add classes to material type icons on result lists and detail pages In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18236 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Keywords| |Academy -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Mar 9 11:07:15 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 09 Mar 2017 10:07:15 +0000 Subject: [Koha-bugs] [Bug 18236] Add classes to material type icons on result lists and detail pages In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18236 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Version|3.22 |master -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Mar 9 11:07:44 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 09 Mar 2017 10:07:44 +0000 Subject: [Koha-bugs] [Bug 7614] Branch transfer limit and holds In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7614 --- Comment #13 from Koha Team AMU --- I tried to test in sandbox but failed : The sandbox you've requested is not ready. Some problems occurred applying patches from bug 7614:

Something went wrong !

Applying: Bug 7614: Add a new method Koha::Libraries->pickup_locations Applying: Bug 7614: Check transfer limit in CanBookBeReserved and CanItemBeReserved Applying: Bug 7614: Check branch transfer limits in opac-reserve.pl Applying: Bug 7614: Consider transfer limits in Koha::Template::Plugin::Branches fatal: sha1 information is lacking or useless (Koha/Template/Plugin/Branches.pm). Repository lacks necessary blobs to fall back on 3-way merge. Cannot fall back to three-way merge. Patch failed at 0001 Bug 7614: Consider transfer limits in Koha::Template::Plugin::Branches When you have resolved this problem run git bz apply --continue. If you would prefer to skip this patch, instead run git bz apply --skip. To restore the original branch and stop patching run git bz apply --abort. Bug 7614 - Branch transfer limit and holds 60141 - Bug 7614: Add a new method Koha::Libraries->pickup_locations 60142 - Bug 7614: Check transfer limit in CanBookBeReserved and CanItemBeReserved 60785 - Bug 7614: Check branch transfer limits in opac-reserve.pl 60786 - Bug 7614: Consider transfer limits in Koha::Template::Plugin::Branches 60787 - Bug 7614: Build a list of pickup locations in OPAC considering transfer limits Apply? [(y)es, (n)o, (i)nteractive] Patch left in /tmp/Bug-7614-Consider-transfer-limits-in-KohaTemplateP-J1NHLc.patch . -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Mar 9 11:08:36 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 09 Mar 2017 10:08:36 +0000 Subject: [Koha-bugs] [Bug 18072] Add Koha objects for Branch Transfer Limits In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18072 Koha Team AMU changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |koha.aixmarseille at gmail.com -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Mar 9 11:28:14 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 09 Mar 2017 10:28:14 +0000 Subject: [Koha-bugs] [Bug 18137] REST API: Migrate from Mojolicious::Plugin:: Swagger2 to Mojolicious::Plugin::OpenAPI In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18137 --- Comment #24 from Mirko Tietgen --- I submitted Mojolicious::Plugin::OpenAPI to Debian a few days ago (1.10). 1.13 is out by now. And both versions depend on versions of libjson-validator-perl not yet in Debian unstable, and the tests in the latest version are broken. Can't build at the moment, but it seemed possible to get everything working in Jessie (including Mojolicious 7.x). I'll give an update when I know more. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Mar 9 11:36:03 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 09 Mar 2017 10:36:03 +0000 Subject: [Koha-bugs] [Bug 15399] MARCXML records larger than 1 MB (1048576 bytes) are not searchable. In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15399 alfre69 changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |alfre at ibdinternet.com -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Mar 9 11:36:13 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 09 Mar 2017 10:36:13 +0000 Subject: [Koha-bugs] [Bug 17098] Validation problems with form field type "number" ( decimal separator) In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17098 --- Comment #4 from Katrin Fischer --- At the moment this problem exists in 2 files: maninvoice.tt and mancredit.tt. Pasting the fix we did on our installations here for making a proper patch later: --- a/koha-tmpl/intranet-tmpl/prog/en/modules/members/maninvoice.tt +++ b/koha-tmpl/intranet-tmpl/prog/en/modules/members/maninvoice.tt @@ -70,7 +70,7 @@ type_fees['[% invoice_types_loo.authorised_value %]'] = "[% invoice_types_loo.li
  • -
  • Example: 5.00
  • +
  • Example: 5.00
  • Cancel
    -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Mar 9 11:45:37 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 09 Mar 2017 10:45:37 +0000 Subject: [Koha-bugs] [Bug 15399] MARCXML records larger than 1 MB (1048576 bytes) are not searchable. In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15399 --- Comment #9 from alfre69 --- If you increase $max_record_size too much it breaks the Z39.50 server. A yaz-client search report this: Target has closed the association. Reason: protocolError, message: Incoming package too large -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Mar 9 11:50:00 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 09 Mar 2017 10:50:00 +0000 Subject: [Koha-bugs] [Bug 12478] Elasticsearch support for Koha In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12478 alfre69 changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |alfre at ibdinternet.com -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Mar 9 11:58:45 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 09 Mar 2017 10:58:45 +0000 Subject: [Koha-bugs] [Bug 15399] MARCXML records larger than 1 MB (1048576 bytes) are not searchable. In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15399 --- Comment #10 from Olli-Antti Kivilahti --- Created attachment 60937 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=60937&action=edit Bug 15399 - MARCXML records larger than 1 MB (1048576 bytes) are not searchable. fka. KD-1512 - Remove items from the search index for serial mothers Make stuff searchable again. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Mar 9 11:59:21 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 09 Mar 2017 10:59:21 +0000 Subject: [Koha-bugs] [Bug 15399] MARCXML records larger than 1 MB (1048576 bytes) are not searchable. In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15399 --- Comment #11 from Olli-Antti Kivilahti --- This is how we fixed this issue. Looking forward to ElasticSearch and it's peculiarities. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Mar 9 12:07:15 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 09 Mar 2017 11:07:15 +0000 Subject: [Koha-bugs] [Bug 7614] Branch transfer limit and holds In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7614 --- Comment #14 from Olli-Antti Kivilahti --- Created attachment 60938 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=60938&action=edit Bug 7614 - Fix my variable earlier declaration bug. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Mar 9 12:13:35 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 09 Mar 2017 11:13:35 +0000 Subject: [Koha-bugs] [Bug 17297] Give librarians the ability to add messages to an item In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17297 Josef Moravec changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |josef.moravec at gmail.com Status|Needs Signoff |Failed QA --- Comment #12 from Josef Moravec --- Just few things, qa tools complain: FAIL catalogue/moredetail.pl FAIL forbidden patterns forbidden pattern: Data::Dumper::Dumper (line 268) And the test plan does not mention the need of ITEM_MESSAGE_TYPE authorised values category. The input field get's smaller when I start to write a message. Maybe the trash icon would be better for removing messages... Do you have plan to show some messages summary information on normal detail page? Failed QA because of the usage of Data::Dumper -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Mar 9 12:29:26 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 09 Mar 2017 11:29:26 +0000 Subject: [Koha-bugs] [Bug 18228] Make list permissions easier to use/understand In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18228 Marcel de Rooy changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |ASSIGNED Summary|Working title |Make list permissions | |easier to use/understand Assignee|gmcharlt at gmail.com |m.de.rooy at rijksmuseum.nl --- Comment #1 from Marcel de Rooy --- Bug 7310 introduced new list permissions in 3.8. Somehow these permissions were not clearly understood by everyone. Bug 10865 hid these permissions in various circumstances again in 3.16 (and 3.14). On a few reports we felt the need to simplify (bug 18214, 10679 as examples). This report proposes the following: [1] Allow three permissions (instead of the current 8 possibilities): N=Nobody changes list contents, O=Owner only makes changes, A=Anyone who sees the list, makes changes [2] The distinction between adding or deleting an entry is no longer made. If you now have change permission, you can do both. [3] Also deleting an entry does no longer depend on who added the entry. This especially confused users. [4] Formerly, the owner could always add entries. It is now possible to make a list readonly (again; concept before 3.8 iirc). -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Mar 9 12:29:52 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 09 Mar 2017 11:29:52 +0000 Subject: [Koha-bugs] [Bug 18228] Make list permissions easier to use/understand In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18228 --- Comment #2 from Marcel de Rooy --- Created attachment 60939 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=60939&action=edit Bug 18228: Table revision of virtualshelves In order to make the permissions easier, we will replace the columns allow_add, allow_delete_own and allow_delete_other by two new columns allow_change_from_owner and allow_change_from_others. The distinction between adding or deleting an entry is no longer made. If you have change permission, you can do both. Also deleting an entry does no longer depend on who added the entry. Formerly, the owner could always add entries. It is now possible to make a list readonly. We will not use the combination of owner=no and other=yes. This will leave us three possibilities: [1] owner=no, other=no: The list is read-only. No one can change contents of the list. Naturally, the owner can edit permissions. [2] owner=yes, other=no: Only the owner can change contents. [3] owner=yes, other=yes: Anyone seeing the list can change contents. This especially applies to shared lists and public lists. The two database columns will be presented in the interface as one permission field offering the three abovementioned options. Test plan: [1] Run the db rev. Signed-off-by: Marcel de Rooy -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Mar 9 12:29:56 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 09 Mar 2017 11:29:56 +0000 Subject: [Koha-bugs] [Bug 18228] Make list permissions easier to use/understand In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18228 --- Comment #3 from Marcel de Rooy --- Created attachment 60940 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=60940&action=edit Bug 18228: DBIx schema changes for Virtualshelve.pm No test plan. Signed-off-by: Marcel de Rooy -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Mar 9 12:29:59 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 09 Mar 2017 11:29:59 +0000 Subject: [Koha-bugs] [Bug 18228] Make list permissions easier to use/understand In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18228 --- Comment #4 from Marcel de Rooy --- Created attachment 60941 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=60941&action=edit Bug 18228: Implement the new columns in code The two new columns as mentioned in the commit message of the table revision must be used in the codebase now. Highlighting some changes in Koha::VirtualShel[f|ves]: [1] Additional methods is_public and is_private. [2] Method add_biblio did not check permissions. Does now. No impact on the interface, but one call in the unit test was affected. [3] Method remove_biblios is signficantly simplified. Removed a FIXME. [4] Method can_biblios_be_removed now redirects to can_biblios_be_added. A followup report may deal with unifying those routines. [5] Condition in get_some_shelves changed. [6] The reference to allow_add in get_shelves_containing_record can simply be removed. opac-shelves.pl and shelves.pl now pass the default setting of Owner only to the template. Templates shelves.tt and opac-shelves.tt now include the new permission field with three choices as mentioned in the table revision patch. opac-addbybiblionumber.pl and addbybiblionumber now need a check on allow_change_from_owner; search conditions slightly adjusted to the new permission scheme. Test plan: When we refer to visibility in the test plan, please check the Add to-combo on opac search results and staff results. And check opac-addbybiblionumber by clicking Save to Lists from opac results. The step 'Check delete' means: open the list in opac and check if you see the Delete button below the entries (only check, do not delete). [ 1] Create private list I01 (perm=Owner) [ 2] Check visibility: Seen. [ 3] Add a book. (Change by owner should be allowed.) [ 4] Check delete: Yes. [ 5] Edit list I01, set perm=Nobody [ 6] Check visibility: Not seen. [ 7] Check delete: No. [ 8] Share list I01 with another patron. [ 9] Check visibility for the other patron: Not seen. [10] Check delete for the other patron: No. [11] Change permission of list I01 to Anyone (by owner). [12] Check visibility for the other patron: Seen. [13] Let other patron add a book (change is allowed). [14] Let owner delete the same book again (change allowed). [15] Create public list U01 (perm=Owner) [16] Check visibility: Seen. [17] Add a book. (Change by owner should be allowed.) [18] Login as other user. Check visibility: Not seen. Check delete: No. [19] Change permission of U01 to Nobody (by owner) [20] As owner: Check visibility: Not seen. Check delete: No. [21] As other user: Check visibility: Not seen. Check delete: No. [22] Create public list U02 (perm=Anyone) [23] Add a book by owner. [24] Delete the same book by other user. Add another book. Signed-off-by: Marcel de Rooy -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Mar 9 12:30:03 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 09 Mar 2017 11:30:03 +0000 Subject: [Koha-bugs] [Bug 18228] Make list permissions easier to use/understand In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18228 --- Comment #5 from Marcel de Rooy --- Created attachment 60942 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=60942&action=edit Bug 18228: Adjust Virtualshelves.t Test plan: Run t/db_dependent/Virtualshelves.t Signed-off-by: Marcel de Rooy -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Mar 9 12:30:21 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 09 Mar 2017 11:30:21 +0000 Subject: [Koha-bugs] [Bug 18228] Make list permissions easier to use/understand In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18228 Marcel de Rooy changed: What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Mar 9 12:31:20 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 09 Mar 2017 11:31:20 +0000 Subject: [Koha-bugs] [Bug 10679] Lists interface offers delete option when user doesn' t have permission In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10679 --- Comment #9 from Marcel de Rooy --- Please look at my proposal on bug 18228 to make things a bit easier. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Mar 9 12:31:39 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 09 Mar 2017 11:31:39 +0000 Subject: [Koha-bugs] [Bug 18228] Make list permissions easier to use/understand In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18228 Marcel de Rooy changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |https://bugs.koha-community | |.org/bugzilla3/show_bug.cgi | |?id=10679 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Mar 9 12:31:39 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 09 Mar 2017 11:31:39 +0000 Subject: [Koha-bugs] [Bug 10679] Lists interface offers delete option when user doesn' t have permission In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10679 Marcel de Rooy changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |https://bugs.koha-community | |.org/bugzilla3/show_bug.cgi | |?id=18228 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Mar 9 12:31:50 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 09 Mar 2017 11:31:50 +0000 Subject: [Koha-bugs] [Bug 18228] Make list permissions easier to use/understand In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18228 Marcel de Rooy changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |https://bugs.koha-community | |.org/bugzilla3/show_bug.cgi | |?id=18214 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Mar 9 12:31:50 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 09 Mar 2017 11:31:50 +0000 Subject: [Koha-bugs] [Bug 18214] Cannot edit list permissions of a private list In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18214 Marcel de Rooy changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |https://bugs.koha-community | |.org/bugzilla3/show_bug.cgi | |?id=18228 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Mar 9 12:32:42 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 09 Mar 2017 11:32:42 +0000 Subject: [Koha-bugs] [Bug 18214] Cannot edit list permissions of a private list In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18214 Marcel de Rooy changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |BLOCKED --- Comment #6 from Marcel de Rooy --- Temporarily blocking this one in favor of bug 18228. That bug includes this change too, but simplifies things. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Mar 9 12:33:07 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 09 Mar 2017 11:33:07 +0000 Subject: [Koha-bugs] [Bug 18228] Make list permissions easier to use/understand In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18228 Marcel de Rooy changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |https://bugs.koha-community | |.org/bugzilla3/show_bug.cgi | |?id=10865 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Mar 9 12:33:07 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 09 Mar 2017 11:33:07 +0000 Subject: [Koha-bugs] [Bug 10865] Don't show list permissions when adding public lists/ sharing lists is not allowed In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10865 Marcel de Rooy changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |https://bugs.koha-community | |.org/bugzilla3/show_bug.cgi | |?id=18228 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Mar 9 12:33:27 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 09 Mar 2017 11:33:27 +0000 Subject: [Koha-bugs] [Bug 7310] Improving permissions on lists (virtual shelves) In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7310 Marcel de Rooy changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |https://bugs.koha-community | |.org/bugzilla3/show_bug.cgi | |?id=18228 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Mar 9 12:33:27 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 09 Mar 2017 11:33:27 +0000 Subject: [Koha-bugs] [Bug 18228] Make list permissions easier to use/understand In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18228 Marcel de Rooy changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |https://bugs.koha-community | |.org/bugzilla3/show_bug.cgi | |?id=7310 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Mar 9 12:35:31 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 09 Mar 2017 11:35:31 +0000 Subject: [Koha-bugs] [Bug 18228] Make list permissions easier to use/understand In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18228 Marcel de Rooy changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |aleishaamohia at hotmail.com, | |jonathan.druart at bugs.koha-c | |ommunity.org, | |katrin.fischer at bsz-bw.de, | |oleonard at myacpl.org -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Mar 9 12:36:38 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 09 Mar 2017 11:36:38 +0000 Subject: [Koha-bugs] [Bug 18228] Make list permissions easier to use/understand In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18228 --- Comment #6 from Marcel de Rooy --- Owen and Katrin, please take a look here. Since you were involved on bug 10865, your feedback is appreciated. Others: please test ! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Mar 9 12:39:01 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 09 Mar 2017 11:39:01 +0000 Subject: [Koha-bugs] [Bug 18228] Make list permissions easier to use/understand In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18228 --- Comment #7 from Marcel de Rooy --- Created attachment 60943 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=60943&action=edit New edit list form -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Mar 9 12:56:50 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 09 Mar 2017 11:56:50 +0000 Subject: [Koha-bugs] [Bug 18228] Make list permissions easier to use/understand In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18228 Marcel de Rooy changed: What |Removed |Added ---------------------------------------------------------------------------- Patch complexity|--- |Small patch -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Mar 9 13:08:11 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 09 Mar 2017 12:08:11 +0000 Subject: [Koha-bugs] [Bug 17533] Syncing private to public list or adding more specific permissions? In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17533 Marcel de Rooy changed: What |Removed |Added ---------------------------------------------------------------------------- Resolution|--- |WONTFIX Status|NEW |RESOLVED --- Comment #3 from Marcel de Rooy --- On second thought, I dont think it would be a good idea to check this permission for each list we show in the opac. Maybe I will open a new report for facilitating import/export list contents between lists. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Mar 9 13:09:35 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 09 Mar 2017 12:09:35 +0000 Subject: [Koha-bugs] [Bug 17533] Syncing private to public list or adding more specific permissions? In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17533 Marcel de Rooy changed: What |Removed |Added ---------------------------------------------------------------------------- Status|RESOLVED |CLOSED -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Mar 9 13:25:18 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 09 Mar 2017 12:25:18 +0000 Subject: [Koha-bugs] [Bug 18237] New: Can't use a hash as a reference at docs/CAS/CASProxy/ examples/proxy_cas_data.pl line 60. Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18237 Bug ID: 18237 Summary: Can't use a hash as a reference at docs/CAS/CASProxy/examples/proxy_cas_data.pl line 60. Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Authentication Assignee: gmcharlt at gmail.com Reporter: olli-antti.kivilahti at jns.fi QA Contact: testopia at bugs.koha-community.org CC: dpavlin at rot13.org Fixes t/db_dependent/00-strict.t -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Mar 9 13:26:01 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 09 Mar 2017 12:26:01 +0000 Subject: [Koha-bugs] [Bug 18237] Can't use a hash as a reference at docs/CAS/CASProxy/examples/ proxy_cas_data.pl line 60. In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18237 --- Comment #1 from Olli-Antti Kivilahti --- Created attachment 60944 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=60944&action=edit Bug 18237 - Can't use a hash as a reference at docs/CAS/CASProxy/examples/proxy_cas_data.pl line 60. Fixes t/db_dependent/00-strict.t -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Mar 9 13:26:55 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 09 Mar 2017 12:26:55 +0000 Subject: [Koha-bugs] [Bug 5630] CAS improvements In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5630 Olli-Antti Kivilahti changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |18237 CC| |olli-antti.kivilahti at jns.fi Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18237 [Bug 18237] Can't use a hash as a reference at docs/CAS/CASProxy/examples/proxy_cas_data.pl line 60. -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Mar 9 13:26:55 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 09 Mar 2017 12:26:55 +0000 Subject: [Koha-bugs] [Bug 18237] Can't use a hash as a reference at docs/CAS/CASProxy/examples/ proxy_cas_data.pl line 60. In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18237 Olli-Antti Kivilahti changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on| |5630 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5630 [Bug 5630] CAS improvements -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Mar 9 13:27:48 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 09 Mar 2017 12:27:48 +0000 Subject: [Koha-bugs] [Bug 18237] Can't use a hash as a reference at docs/CAS/CASProxy/examples/ proxy_cas_data.pl line 60. In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18237 Olli-Antti Kivilahti changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff --- Comment #2 from Olli-Antti Kivilahti --- root at koha_ci_1:/home/koha/Koha# cat /etc/lsb-release DISTRIB_ID=Ubuntu DISTRIB_RELEASE=16.04 DISTRIB_CODENAME=xenial DISTRIB_DESCRIPTION="Ubuntu 16.04.1 LTS" root at koha_ci_1:/home/koha/Koha# perl -v This is perl 5, version 22, subversion 1 (v5.22.1) built for x86_64-linux-gnu-thread-multi -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Mar 9 13:28:40 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 09 Mar 2017 12:28:40 +0000 Subject: [Koha-bugs] [Bug 17311] koha-common service should be restarted on upgrade In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17311 Mirko Tietgen changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|koha-bugs at lists.koha-commun |mirko at abunchofthings.net |ity.org | -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Mar 9 13:29:56 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 09 Mar 2017 12:29:56 +0000 Subject: [Koha-bugs] [Bug 17311] koha-common service should be restarted on upgrade In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17311 Mirko Tietgen changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |ASSIGNED --- Comment #1 from Mirko Tietgen --- We should also take care of the correct order of restarting memcached and plack here in some way. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Mar 9 13:30:14 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 09 Mar 2017 12:30:14 +0000 Subject: [Koha-bugs] [Bug 18238] New: Test harness/suite/"test runner" Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18238 Bug ID: 18238 Summary: Test harness/suite/"test runner" Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Test Suite Assignee: chris at bigballofwax.co.nz Reporter: olli-antti.kivilahti at jns.fi QA Contact: gmcharlt at gmail.com There is no smart interface for running different types of tests in Koha and covering code coverage metrics from those. This bug introduces one way of running various test suites. +my $usage = < References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16758 Mirko Tietgen changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |https://bugs.koha-community | |.org/bugzilla3/show_bug.cgi | |?id=17311 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Mar 9 13:31:05 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 09 Mar 2017 12:31:05 +0000 Subject: [Koha-bugs] [Bug 17311] koha-common service should be restarted on upgrade In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17311 Mirko Tietgen changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |https://bugs.koha-community | |.org/bugzilla3/show_bug.cgi | |?id=16758 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Mar 9 13:31:29 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 09 Mar 2017 12:31:29 +0000 Subject: [Koha-bugs] [Bug 18238] Test harness/suite/"test runner" In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18238 --- Comment #1 from Olli-Antti Kivilahti --- Created attachment 60945 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=60945&action=edit KD-1738 - AnsbileTorpor - Poor man's Ansible Tower - testHarness.pl testHarness.pl for running Koha's tests in petite chunks -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Mar 9 13:31:50 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 09 Mar 2017 12:31:50 +0000 Subject: [Koha-bugs] [Bug 18238] Test harness/suite/"test runner" In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18238 Olli-Antti Kivilahti changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |In Discussion -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Mar 9 13:34:15 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 09 Mar 2017 12:34:15 +0000 Subject: [Koha-bugs] [Bug 18238] Test harness/suite/"test runner" In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18238 --- Comment #2 from Olli-Antti Kivilahti --- I am using this script to run various kinds of tests in Koha. Test execution starts from Jenkins2.0, then passes to https://github.com/kivilahtio/AnsbileTorpor which triggers a Koha build and test runs and finally is executed via Ansible scripts ks-test-harness.pl --git 5 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Mar 9 13:34:38 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 09 Mar 2017 12:34:38 +0000 Subject: [Koha-bugs] [Bug 11897] Stock Rotation for Koha In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11897 Fiona Borthwick changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |fiona.borthwick at ptfs-europe | |.com -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Mar 9 13:37:05 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 09 Mar 2017 12:37:05 +0000 Subject: [Koha-bugs] [Bug 18055] Speed up '00-strict.t' test In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18055 Olli-Antti Kivilahti changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |olli-antti.kivilahti at jns.fi --- Comment #19 from Olli-Antti Kivilahti --- Hi! Pretty good improvement. What concerns me is how well does this module detect the available CPU cores? For example on LXC all the cores are visible to the test runner. There can be resource limits, but we might get a situation where we fork 32 test runners because the LXC container is ran on a server with 32 cores. However resource limits prevent utilization of more than 4 on this LXC-container. This is not good. Maybe a better solution would be to accelerate the whole test running infrastructure. I am not seeing anything in t or $KOHA_PATH which would allow to easily run all Koha's tests, but I have been working on something like Bug 18238. Parallelizing the test runs makes sense in this bigger context, but needs multiple parallel test databases and KOHA_CONF's and is generally a big hassle and prone to all kinds of strange race condition errors. Maybe it is better to parallellize tests from infrastructure using your DevOps (TM) build pipeline and run tests on multiple Koha-intances? -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Mar 9 13:37:29 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 09 Mar 2017 12:37:29 +0000 Subject: [Koha-bugs] [Bug 18055] Speed up '00-strict.t' test In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18055 Olli-Antti Kivilahti changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |https://bugs.koha-community | |.org/bugzilla3/show_bug.cgi | |?id=18238 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Mar 9 13:37:29 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 09 Mar 2017 12:37:29 +0000 Subject: [Koha-bugs] [Bug 18238] Test harness/suite/"test runner" In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18238 Olli-Antti Kivilahti changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |https://bugs.koha-community | |.org/bugzilla3/show_bug.cgi | |?id=18055 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Mar 9 13:47:52 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 09 Mar 2017 12:47:52 +0000 Subject: [Koha-bugs] [Bug 7614] Branch transfer limit and holds In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7614 --- Comment #15 from Olli-Antti Kivilahti --- Created attachment 60946 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=60946&action=edit Bug 7614 - Fixes "Looks like you planned 61 tests but ran 62" at t/db_dependent/Holds.t -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Mar 9 14:43:03 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 09 Mar 2017 13:43:03 +0000 Subject: [Koha-bugs] [Bug 10382] collection not returning to null when removed from course reserves In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10382 Alex Arnaud changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #19611|0 |1 is obsolete| | --- Comment #15 from Alex Arnaud --- Created attachment 60947 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=60947&action=edit Bug 10382 - collection not returning to null when removed from course reserves Test Plan: 1) Create an item, do not set a collection code 2) Add the item to a course, and choose to set a collection code 3) Ensure the course is enabled, and the collection code is now visible 4) Disable the course, ensure the collection code is no longer visible -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Mar 9 14:43:11 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 09 Mar 2017 13:43:11 +0000 Subject: [Koha-bugs] [Bug 10382] collection not returning to null when removed from course reserves In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10382 --- Comment #16 from Alex Arnaud --- Created attachment 60948 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=60948&action=edit Bug 10382 - Add unit tests for course items -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Mar 9 14:45:24 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 09 Mar 2017 13:45:24 +0000 Subject: [Koha-bugs] [Bug 18230] Generate Koha::Patron::Modification verification_token in -> new In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18230 --- Comment #1 from Lari Taskula --- Created attachment 60949 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=60949&action=edit Bug 18230: Generate verification_token in Koha::Patron::Modification->new To test: 1. prove t/db_dependent/Koha/Patron/Modifications.t -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Mar 9 14:45:42 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 09 Mar 2017 13:45:42 +0000 Subject: [Koha-bugs] [Bug 18230] Generate Koha::Patron::Modification verification_token in -> new In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18230 Lari Taskula changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|gmcharlt at gmail.com |lari.taskula at jns.fi -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Mar 9 14:49:01 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 09 Mar 2017 13:49:01 +0000 Subject: [Koha-bugs] [Bug 18231] Add the missing id-column to koha.issuingrules-table for DBIC fixtures In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18231 Marc V?ron changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |veron at veron.ch --- Comment #2 from Marc V?ron --- - Is there any test plan? - The atomic update file is named "Bug-18226-Remove_mock_dbh.sql", but we are on Bug 18231, I think it should be renamed. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Thu Mar 9 14:54:06 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 09 Mar 2017 13:54:06 +0000 Subject: [Koha-bugs] [Bug 10382] collection not returning to null when removed from course reserves In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10382 Alex Arnaud changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |alex.arnaud at biblibre.com --- Comment #17 from Alex Arnaud --- (In reply to Kyle M Hall from comment #12) > If someone would be willing to write some unit tests to demonstrate the > issues I'd be more than happy to continue work on this bug. I think the > issue is triggered by removing an item from course reserve, and *not* > triggered by simply disabling the course reserves. Can someone confirm this? Hello Kyle, I have rebased your patch and provided some unit tests that reveal the problem. Unfortunately, it seems that your patch does not fix it. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Mar 9 14:58:18 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 09 Mar 2017 13:58:18 +0000 Subject: [Koha-bugs] [Bug 11361] Add a Z39.50 search page in the OPAC to let members search for records on remote Koha instances. In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11361 --- Comment #4 from Bouzid --- Created attachment 60950 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=60950&action=edit Bug 11361 - Add a Z39.50 search page in the OPAC to let members search for records on remote Koha instances This patch adds the OPACZ3950 preference which activates a "Z39.50 Search" page in the OPAC. This page can be used to let members search for biblio records on remote Koha instances. If the "Show" link is clicked in the results page, the user is then redirected to the remote Koha's OPAC to see the record's details. This feature can be useful if you have multiple libraries with their own Koha instance and you want your users to be able to search for books in your other libraries. Please note that this will only work with Koha instances. The links in the results page won't work with other normal Z39.50 servers. Sponsored-by: CCSR ( http://www.ccsr.qc.ca ) -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Mar 9 15:05:56 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 09 Mar 2017 14:05:56 +0000 Subject: [Koha-bugs] [Bug 11361] Add a Z39.50 search page in the OPAC to let members search for records on remote Koha instances. In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11361 --- Comment #5 from Bouzid --- Created attachment 60951 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=60951&action=edit Bug 11361 - Add a Z39.50 search page in the OPAC to let members search for records on remote Koha instances This patch adds the OPACZ3950 preference which activates a "Z39.50 Search" page in the OPAC. This page can be used to let members search for biblio records on remote Koha instances. If the "Show" link is clicked in the results page, the user is then redirected to the remote Koha's OPAC to see the record's details. This feature can be useful if you have multiple libraries with their own Koha instance and you want your users to be able to search for books in your other libraries. Please note that this will only work with Koha instances. The links in the results page won't work with other normal Z39.50 servers. Sponsored-by: CCSR ( http://www.ccsr.qc.ca ) -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Mar 9 15:06:35 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 09 Mar 2017 14:06:35 +0000 Subject: [Koha-bugs] [Bug 14957] Write protecting MARC fields based on source of import In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14957 --- Comment #49 from David Gustafsson --- Have discovered a lot of weirdness in how permissions are applied, not sure if this is something I have introduces or present in the original patch, but don't merge in this quite yet. Will update the patch some time in the coming days. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Mar 9 15:08:29 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 09 Mar 2017 14:08:29 +0000 Subject: [Koha-bugs] [Bug 16034] Integration with OverDrive Patron API In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16034 Mirko Tietgen changed: What |Removed |Added ---------------------------------------------------------------------------- Status|RESOLVED |REOPENED Resolution|FIXED |--- --- Comment #80 from Mirko Tietgen --- I rolled a package and installed it. $ locate WebService/ILS/OverDrive/Patron.pm /usr/share/perl5/WebService/ILS/OverDrive/Patron.pm Test fails anyway. # Failed test 'use Koha::ExternalContent::OverDrive;' # at t/00-load.t line 65. # Tried to use 'Koha::ExternalContent::OverDrive'. # Error: Can't locate WebService/ILS/OverDrive/Patron.pm in @INC (you may need to install the WebService::ILS::OverDrive::Patron module) (@INC contains: /tmp/buildd/koha-16.12+17311~git+20170309145207.123dfb1c/blib/PERL_MODULE_DIR /tmp/buildd/koha-16.12+17311~git+20170309145207.123dfb1c/blib/arch /etc/perl /usr/local/lib/x86_64-linux-gnu/perl/5.20.2 /usr/local/share/perl/5.20.2 /usr/lib/x86_64-linux-gnu/perl5/5.20 /usr/share/perl5 /usr/lib/x86_64-linux-gnu/perl/5.20 /usr/share/perl/5.20 /usr/local/lib/site_perl . /var/lib/koha/plugins /var/lib/koha/plugins) at /tmp/buildd/koha-16.12+17311~git+20170309145207.123dfb1c/blib/PERL_MODULE_DIR/Koha/ExternalContent/OverDrive.pm line 24. # BEGIN failed--compilation aborted at /tmp/buildd/koha-16.12+17311~git+20170309145207.123dfb1c/blib/PERL_MODULE_DIR/Koha/ExternalContent/OverDrive.pm line 24. # Compilation failed in require at t/00-load.t line 65. # BEGIN failed--compilation aborted at t/00-load.t line 65. Bailout called. Further testing stopped: ***** PROBLEMS LOADING FILE 'Koha::ExternalContent::OverDrive' # Tests were run but no plan was declared and done_testing() was not seen. # Looks like your test exited with 255 just after 255. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Mar 9 15:08:30 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 09 Mar 2017 14:08:30 +0000 Subject: [Koha-bugs] [Bug 17602] Integrate support for ONeclickDigital/Recorded Books API In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17602 Bug 17602 depends on bug 16034, which changed state. Bug 16034 Summary: Integration with OverDrive Patron API https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16034 What |Removed |Added ---------------------------------------------------------------------------- Status|RESOLVED |REOPENED Resolution|FIXED |--- -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Mar 9 15:08:30 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 09 Mar 2017 14:08:30 +0000 Subject: [Koha-bugs] [Bug 18160] Error when OverDriveCirculation not enabled In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18160 Bug 18160 depends on bug 16034, which changed state. Bug 16034 Summary: Integration with OverDrive Patron API https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16034 What |Removed |Added ---------------------------------------------------------------------------- Status|RESOLVED |REOPENED Resolution|FIXED |--- -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Mar 9 15:14:25 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 09 Mar 2017 14:14:25 +0000 Subject: [Koha-bugs] [Bug 18235] Elastic search - Configurable facets In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18235 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |https://bugs.koha-community | |.org/bugzilla3/show_bug.cgi | |?id=18213 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Mar 9 15:14:25 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 09 Mar 2017 14:14:25 +0000 Subject: [Koha-bugs] [Bug 18213] Add language facets to Elasticsearch In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18213 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |https://bugs.koha-community | |.org/bugzilla3/show_bug.cgi | |?id=18235 CC| |jonathan.druart at bugs.koha-c | |ommunity.org --- Comment #1 from Jonathan Druart --- Would be good to make it on top of bug 18235. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Mar 9 15:14:49 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 09 Mar 2017 14:14:49 +0000 Subject: [Koha-bugs] [Bug 11361] Add a Z39.50 search page in the OPAC to let members search for records on remote Koha instances. In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11361 Bouzid changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #23365|0 |1 is obsolete| | Attachment #60950|0 |1 is obsolete| | Attachment #60951|0 |1 is obsolete| | --- Comment #6 from Bouzid --- Created attachment 60952 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=60952&action=edit Bug 11361 - Add a Z39.50 search page in the OPAC to let members search for records on remote Koha instances This patch adds the OPACZ3950 preference which activates a "Z39.50 Search" page in the OPAC. This page can be used to let members search for biblio records on remote Koha instances. If the "Show" link is clicked in the results page, the user is then redirected to the remote Koha's OPAC to see the record's details. This feature can be useful if you have multiple libraries with their own Koha instance and you want your users to be able to search for books in your other libraries. Please note that this will only work with Koha instances. The links in the results page won't work with other normal Z39.50 servers. Sponsored-by: CCSR ( http://www.ccsr.qc.ca ) -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Mar 9 15:16:34 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 09 Mar 2017 14:16:34 +0000 Subject: [Koha-bugs] [Bug 18239] New: Add Open Document export option to items search Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18239 Bug ID: 18239 Summary: Add Open Document export option to items search Change sponsored?: --- Product: Koha Version: 3.22 Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Reports Assignee: gmcharlt at gmail.com Reporter: katrin.fischer at bsz-bw.de QA Contact: testopia at bugs.koha-community.org For libraries using Excel the CSV export often shows some problems: Umlauts/diacritics are broken, because UTF-8 is not detected automatically and the separators are not recognized with all data appearing in one line. What works really will, also with Excel, is the Open Document format that was added for exporting reports. It would be nice if this option could also be added to the items search in the staff interface. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Mar 9 15:16:40 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 09 Mar 2017 14:16:40 +0000 Subject: [Koha-bugs] [Bug 18239] Add Open Document export option to items search In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18239 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Version|3.22 |master -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Mar 9 15:18:13 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 09 Mar 2017 14:18:13 +0000 Subject: [Koha-bugs] [Bug 11361] Add a Z39.50 search page in the OPAC to let members search for records on remote Koha instances. In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11361 Bouzid changed: What |Removed |Added ---------------------------------------------------------------------------- Status|In Discussion |Needs Signoff CC| |bouzid.fergani at inlibro.com --- Comment #7 from Bouzid --- Hi all, I rebased all patches and squash all in one good patch. It apply correcly under the master. I think, its the alternative of 10486, because it not progress. Thanks. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Mar 9 15:26:08 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 09 Mar 2017 14:26:08 +0000 Subject: [Koha-bugs] [Bug 18209] Patron's card manage.pl page is not fully translatable In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18209 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Mar 9 15:26:11 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 09 Mar 2017 14:26:11 +0000 Subject: [Koha-bugs] [Bug 18209] Patron's card manage.pl page is not fully translatable In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18209 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #60936|0 |1 is obsolete| | --- Comment #6 from Jonathan Druart --- Created attachment 60953 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=60953&action=edit Bug 18209 - Patron's card manage.pl page is not fully translatable The headers of the tables displayed in patroncards/manage.tt are hardcoded in the .pl and thus cannot be translated. This simple fix reuse the translate_card_element tool already in the code to make the strings translatable. Applied patch and verified that table headers on manage.pl display the same as before. Signed-off-by: Marc V?ron Re-tested, works as expected. Signed-off-by: Marc V?ron Signed-off-by: Jonathan Druart -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Mar 9 15:26:15 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 09 Mar 2017 14:26:15 +0000 Subject: [Koha-bugs] [Bug 18209] Patron's card manage.pl page is not fully translatable In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18209 --- Comment #7 from Jonathan Druart --- Created attachment 60954 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=60954&action=edit Bug 18209: Add default, 'Actions' and fix case Signed-off-by: Jonathan Druart -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Mar 9 15:28:35 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 09 Mar 2017 14:28:35 +0000 Subject: [Koha-bugs] [Bug 18231] Add the missing id-column to koha.issuingrules-table for DBIC fixtures In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18231 Olli-Antti Kivilahti changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #60921|0 |1 is obsolete| | --- Comment #3 from Olli-Antti Kivilahti --- Created attachment 60955 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=60955&action=edit Bug 18231 - Add the missing id-column to koha.issuingrules-table for DBIC fixtures Many DBIx-stuffs depend on last_insert_id -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Mar 9 15:30:01 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 09 Mar 2017 14:30:01 +0000 Subject: [Koha-bugs] [Bug 18231] Add the missing id-column to koha.issuingrules-table for DBIC fixtures In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18231 --- Comment #4 from Olli-Antti Kivilahti --- (In reply to Marc V?ron from comment #2) > - Is there any test plan? > t/db_dependent/Reserves.t t/db_dependent/Circulation/CalcFine.t + others. All tests pass, no regression detected. > - The atomic update file is named "Bug-18226-Remove_mock_dbh.sql", but we > are on Bug 18231, I think it should be renamed. Fixed. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Mar 9 15:31:19 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 09 Mar 2017 14:31:19 +0000 Subject: [Koha-bugs] [Bug 18240] New: Per-instance SRU Explain documents Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18240 Bug ID: 18240 Summary: Per-instance SRU Explain documents Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Z39.50 / SRU / OpenSearch Servers Assignee: gmcharlt at gmail.com Reporter: magnus at libriotech.no QA Contact: testopia at bugs.koha-community.org CC: m.de.rooy at rijksmuseum.nl If/when "Bug 12836 - SRU Explain file needs to be rewritten" gets pushed, we should start to think about per-instance Explain docs. We will be able to generate Explain docs with detailed info about each site, so it makes sense to have one doc per site. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Mar 9 15:31:25 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 09 Mar 2017 14:31:25 +0000 Subject: [Koha-bugs] [Bug 12836] SRU Explain file needs to be rewritten In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12836 Magnus Enger changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |18240 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18240 [Bug 18240] Per-instance SRU Explain documents -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Mar 9 15:31:25 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 09 Mar 2017 14:31:25 +0000 Subject: [Koha-bugs] [Bug 18240] Per-instance SRU Explain documents In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18240 Magnus Enger changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on| |12836 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12836 [Bug 12836] SRU Explain file needs to be rewritten -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Mar 9 15:35:27 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 09 Mar 2017 14:35:27 +0000 Subject: [Koha-bugs] [Bug 13392] New statistics wizard for suggestions In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13392 Julian Maurice changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #51995|0 |1 is obsolete| | --- Comment #50 from Julian Maurice --- Created attachment 60956 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=60956&action=edit Bug 13392: Add suggestions.ordereddate and suggestions.orderedby Those fields are updated when suggestion status is changed to 'ORDERED' and are displayed on suggestion/suggestion.pl page Signed-off-by: Nicole Engard Patch updated: Use atomic update -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Mar 9 15:35:32 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 09 Mar 2017 14:35:32 +0000 Subject: [Koha-bugs] [Bug 13392] New statistics wizard for suggestions In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13392 Julian Maurice changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #51996|0 |1 is obsolete| | --- Comment #51 from Julian Maurice --- Created attachment 60957 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=60957&action=edit Bug 13392: New statistics assistant for suggestions New sub C4::Budgets::GetBudgetDescendantsIds (with unit tests) Signed-off-by: Nicole Engard -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Mar 9 15:35:37 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 09 Mar 2017 14:35:37 +0000 Subject: [Koha-bugs] [Bug 13392] New statistics wizard for suggestions In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13392 Julian Maurice changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #51997|0 |1 is obsolete| | --- Comment #52 from Julian Maurice --- Created attachment 60958 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=60958&action=edit Bug 13392: QA fixes 1/ Add tests descriptions 2/ Do not use Koha::I18N for suggestion statuses, and add statuses from SUGGEST_STATUS authorised values 3/ Use copyrightdate instead of publicationyear which seems to be unused 4/ Display free text filters if there is no values in corresponding authorised values list 5/ Rename 'Branch' to 'Library' and 'Reject reason' to 'Reason' Signed-off-by: Nicole Engard -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Mar 9 15:35:42 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 09 Mar 2017 14:35:42 +0000 Subject: [Koha-bugs] [Bug 13392] New statistics wizard for suggestions In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13392 Julian Maurice changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #51998|0 |1 is obsolete| | --- Comment #53 from Julian Maurice --- Created attachment 60959 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=60959&action=edit Bug 13392 - Fix QA failures: - Fix a perl warning in suggestions_stats.tt, - Replace term "Acquisitions" with "Suggestions", - Add POD for GetBudgetDescendantsIds. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Mar 9 15:35:47 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 09 Mar 2017 14:35:47 +0000 Subject: [Koha-bugs] [Bug 13392] New statistics wizard for suggestions In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13392 Julian Maurice changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #51999|0 |1 is obsolete| | --- Comment #54 from Julian Maurice --- Created attachment 60960 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=60960&action=edit Bug 13392 - Replace using of C4::Dates and C4::ItemType by Koha::DateUtils and Koha::ItemTypes -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Mar 9 15:35:51 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 09 Mar 2017 14:35:51 +0000 Subject: [Koha-bugs] [Bug 13392] New statistics wizard for suggestions In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13392 Julian Maurice changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #56110|0 |1 is obsolete| | --- Comment #55 from Julian Maurice --- Created attachment 60961 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=60961&action=edit Bug 13392: Remove use of C4::Branch and C4::Category + fix a 'ambiguous column name' error when using borrowers table -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Mar 9 15:35:56 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 09 Mar 2017 14:35:56 +0000 Subject: [Koha-bugs] [Bug 13392] New statistics wizard for suggestions In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13392 Julian Maurice changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #56889|0 |1 is obsolete| | --- Comment #56 from Julian Maurice --- Created attachment 60962 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=60962&action=edit Bug 13392 - Follow-up on terminology Standardizing a few terms - Patron sort 1/2 to match the holds statistics wizard - Patron category instead of borrower category -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Mar 9 15:36:27 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 09 Mar 2017 14:36:27 +0000 Subject: [Koha-bugs] [Bug 13392] New statistics wizard for suggestions In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13392 Julian Maurice changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |Needs Signoff --- Comment #57 from Julian Maurice --- Patches rebased on master -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Mar 9 15:37:58 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 09 Mar 2017 14:37:58 +0000 Subject: [Koha-bugs] [Bug 18234] After the last update, the program stopped reserving the literature. When I try to backup I get an error : No homebranch at /usr/share/koha/lib/C4/Reserves.pm line 2119. In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18234 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |RESOLVED CC| |jonathan.druart at bugs.koha-c | |ommunity.org Resolution|--- |INVALID --- Comment #1 from Jonathan Druart --- Please send an email on the mailing list with more details. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Thu Mar 9 15:39:45 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 09 Mar 2017 14:39:45 +0000 Subject: [Koha-bugs] [Bug 13392] New statistics wizard for suggestions In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13392 --- Comment #58 from Julian Maurice --- Katrin, sorry but I wasn't able to reproduce your problem. When I create a new order line from a suggestion, the suggestion status is always changed to ORDERED. Could you describe step by step what you do ? -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Mar 9 15:42:27 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 09 Mar 2017 14:42:27 +0000 Subject: [Koha-bugs] [Bug 13995] Proper Exception handling In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13995 Olli-Antti Kivilahti changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #42109|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Mar 9 15:43:24 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 09 Mar 2017 14:43:24 +0000 Subject: [Koha-bugs] [Bug 18185] Clears loan history In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18185 --- Comment #8 from Jonathan Druart --- Can you provide a screencast? -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Mar 9 15:46:00 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 09 Mar 2017 14:46:00 +0000 Subject: [Koha-bugs] [Bug 16034] Integration with OverDrive Patron API In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16034 --- Comment #81 from Jonathan Druart --- Patch on comment 75 has not been pushed and package building fail, please open a new bug report and fix these issues ASAP. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Mar 9 15:53:00 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 09 Mar 2017 14:53:00 +0000 Subject: [Koha-bugs] [Bug 13995] Proper Exception handling In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13995 Olli-Antti Kivilahti changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #41529|0 |1 is obsolete| | --- Comment #23 from Olli-Antti Kivilahti --- Created attachment 60963 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=60963&action=edit Bug 13995 - Proper Exception handling -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Mar 9 15:59:49 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 09 Mar 2017 14:59:49 +0000 Subject: [Koha-bugs] [Bug 18231] Add the missing id-column to koha.issuingrules-table for DBIC fixtures In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18231 Marc V?ron changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #60955|0 |1 is obsolete| | --- Comment #5 from Marc V?ron --- Created attachment 60964 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=60964&action=edit Bug 18231 - Add the missing id-column to koha.issuingrules-table for DBIC fixtures Many DBIx-stuffs depend on last_insert_id Followed test plan from comment #4, works as expected Signed-off-by: Marc V?ron -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Mar 9 16:01:18 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 09 Mar 2017 15:01:18 +0000 Subject: [Koha-bugs] [Bug 18231] Add the missing id-column to koha.issuingrules-table for DBIC fixtures In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18231 Olli-Antti Kivilahti changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off --- Comment #6 from Olli-Antti Kivilahti --- Community thanks you Marc :) -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Thu Mar 9 16:19:26 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 09 Mar 2017 15:19:26 +0000 Subject: [Koha-bugs] [Bug 18241] New: IP instead of DNS Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18241 Bug ID: 18241 Summary: IP instead of DNS Change sponsored?: --- Product: Koha Version: 16.05 Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Staff Client Assignee: koha-bugs at lists.koha-community.org Reporter: divalmeida at gmail.com QA Contact: testopia at bugs.koha-community.org CC: gmcharlt at gmail.com Hello, How do I set DNS for koha system login instead of IP::port. I've done an IP based installation and now I can't change this. I've already done what's explained in https://wiki.koha-community.org/wiki/How_to_set_up_a_domain_name_for_Koha but I can't put it to work. System login page still goes to IP::port and DNS goes to OPAC page as well as staff-client URL. Is there any conf file that I'be been missing?... Sorry for the rookieness, I'm new with koha. Thanks for any help. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Thu Mar 9 16:35:04 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 09 Mar 2017 15:35:04 +0000 Subject: [Koha-bugs] [Bug 18234] After the last update, the program stopped reserving the literature. When I try to backup I get an error : No homebranch at /usr/share/koha/lib/C4/Reserves.pm line 2119. In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18234 --- Comment #2 from sergeinik --- (In reply to Jonathan Druart from comment #1) > Please send an email on the mailing list with more details. sergeinik at tut.by -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Mar 9 16:38:29 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 09 Mar 2017 15:38:29 +0000 Subject: [Koha-bugs] [Bug 18185] Clears loan history In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18185 --- Comment #9 from Ricardo Vargas --- This is the screencast. http://autode.sk/2na3tNf -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Thu Mar 9 16:39:56 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 09 Mar 2017 15:39:56 +0000 Subject: [Koha-bugs] [Bug 12747] Add extra column in Z3950 search result In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12747 --- Comment #40 from Bouzid --- Created attachment 60965 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=60965&action=edit Bug12747 - Small fix for add this field correctly in cataloging module -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Mar 9 16:41:49 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 09 Mar 2017 15:41:49 +0000 Subject: [Koha-bugs] [Bug 12747] Add extra column in Z3950 search result In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12747 Bouzid changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |Needs Signoff CC| |bouzid.fergani at inlibro.com -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Mar 9 16:50:48 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 09 Mar 2017 15:50:48 +0000 Subject: [Koha-bugs] [Bug 7317] Add an Interlibrary Loan Module to Circulation and OPAC In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7317 Blou changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |bouzid.fergani at inlibro.com, | |eric.begin at inLibro.com, | |francois.charbonnier at inlibr | |o.com, | |philippe.blouin at inlibro.com -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Mar 9 17:59:23 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 09 Mar 2017 16:59:23 +0000 Subject: [Koha-bugs] [Bug 18185] Clears loan history In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18185 --- Comment #10 from Jonathan Druart --- I think you face the same problem as bug 18003, but for issues. To confirm it, try: 1. Issue an item for a patron, note the itemnumber of this item 2. Get the issue id of this issue: SELECT issue_id FROM issues WHERE itemnumber=ITEMNUMBER; If you do not know the item number, you can get it from the barcode with: SELECT itemnumber FROM items where barcode="BARCODE"; Then check if this issue_id already exists in the old_issues table: SELECT COUNT(*) FROM old_issues WHERE issue_id=ISSUE_ID -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Thu Mar 9 18:02:25 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 09 Mar 2017 17:02:25 +0000 Subject: [Koha-bugs] [Bug 18185] Clears loan history In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18185 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |https://bugs.koha-community | |.org/bugzilla3/show_bug.cgi | |?id=18003 -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Thu Mar 9 18:02:25 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 09 Mar 2017 17:02:25 +0000 Subject: [Koha-bugs] [Bug 18003] Should deletedborrowers.borrowernumber be a primary key? In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18003 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |https://bugs.koha-community | |.org/bugzilla3/show_bug.cgi | |?id=18185 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Mar 9 19:52:20 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 09 Mar 2017 18:52:20 +0000 Subject: [Koha-bugs] [Bug 18242] New: Remove primary key on old_issues.issue_id Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18242 Bug ID: 18242 Summary: Remove primary key on old_issues.issue_id Change sponsored?: --- Product: Koha Version: unspecified Hardware: All OS: All Status: ASSIGNED Severity: critical Priority: P5 - low Component: Architecture, internals, and plumbing Assignee: jonathan.druart at bugs.koha-community.org Reporter: jonathan.druart at bugs.koha-community.org QA Contact: testopia at bugs.koha-community.org The table old_issues has a primary key defined on the issue_id column. This issue_id comes from the issues table when an item is checked in. In some case the value of issue_id already exists in the table Basically this happens when an item is returned and mysqld is restarted: The auto increment value for issues.issue_id will be reset to MAX(issue_id)+1 (which is the value of the last entry of old_issues). See also the description of bug 18003 for more informations. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Mar 9 19:52:49 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 09 Mar 2017 18:52:49 +0000 Subject: [Koha-bugs] [Bug 18242] Remove primary key on old_issues.issue_id In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18242 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |https://bugs.koha-community | |.org/bugzilla3/show_bug.cgi | |?id=18185 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Mar 9 19:52:49 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 09 Mar 2017 18:52:49 +0000 Subject: [Koha-bugs] [Bug 18185] Clears loan history In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18185 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |https://bugs.koha-community | |.org/bugzilla3/show_bug.cgi | |?id=18242 --- Comment #11 from Jonathan Druart --- See also bug 18242. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Thu Mar 9 20:00:53 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 09 Mar 2017 19:00:53 +0000 Subject: [Koha-bugs] [Bug 18185] Clears loan history In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18185 --- Comment #12 from Jonathan Druart --- Created attachment 60966 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=60966&action=edit Bug 18185: [SOLUTION 1]DB changes - remove PK on old_issues.issue_id -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Thu Mar 9 20:00:58 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 09 Mar 2017 19:00:58 +0000 Subject: [Koha-bugs] [Bug 18185] Clears loan history In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18185 --- Comment #13 from Jonathan Druart --- Created attachment 60967 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=60967&action=edit Bug 18185: [SOLUTION 1]Schema changes -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Mar 9 20:01:04 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 09 Mar 2017 19:01:04 +0000 Subject: [Koha-bugs] [Bug 18185] Clears loan history In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18185 --- Comment #14 from Jonathan Druart --- Created attachment 60968 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=60968&action=edit Bug 18185: [SOLUTION 1]Remove primary key on old_issues.issue_id The table old_issues has a primary key defined on the issue_id column. This issue_id comes from the issues table when an item is checked in. In some case the value of issue_id already exists in the table Basically this happens when an item is returned and mysqld is restarted: The auto increment value for issues.issue_id will be reset to MAX(issue_id)+1 (which is the value of the last entry of old_issues). See also the description of bug 18003 for more informations. The easier solution seems to add a new column id as a primary key. The changes to the codebase are very small. However this will raise few problems: - We can no longer assume that accountlines.issue_id==old_issues.id (I guess it is problematic). - Code in Koha::REST::V1::_object_ownership_by_checkout_id is wrong assuming that old_issues.issuing_id is unique -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Thu Mar 9 20:17:59 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 09 Mar 2017 19:17:59 +0000 Subject: [Koha-bugs] [Bug 17776] Shibboleth Authentication is broken in plack In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17776 Nick Clemens changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |nick at bywatersolutions.com -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Mar 9 21:03:26 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 09 Mar 2017 20:03:26 +0000 Subject: [Koha-bugs] [Bug 18242] Remove primary key on old_issues.issue_id In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18242 --- Comment #1 from Jonathan Druart --- Created attachment 60969 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=60969&action=edit Bug 18242: [SOLUTION 1]DB changes - remove PK on old_issues.issue_id -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Mar 9 21:03:31 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 09 Mar 2017 20:03:31 +0000 Subject: [Koha-bugs] [Bug 18242] Remove primary key on old_issues.issue_id In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18242 --- Comment #2 from Jonathan Druart --- Created attachment 60970 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=60970&action=edit Bug 18242: [SOLUTION 1]Schema changes -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Mar 9 21:03:35 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 09 Mar 2017 20:03:35 +0000 Subject: [Koha-bugs] [Bug 18242] Remove primary key on old_issues.issue_id In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18242 --- Comment #3 from Jonathan Druart --- Created attachment 60971 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=60971&action=edit Bug 18242: [SOLUTION 1]Remove primary key on old_issues.issue_id The table old_issues has a primary key defined on the issue_id column. This issue_id comes from the issues table when an item is checked in. In some case the value of issue_id already exists in the table Basically this happens when an item is returned and mysqld is restarted: The auto increment value for issues.issue_id will be reset to MAX(issue_id)+1 (which is the value of the last entry of old_issues). See also the description of bug 18003 for more informations. The easier solution seems to add a new column id as a primary key. The changes to the codebase are very small. However this will raise few problems: - We can no longer assume that accountlines.issue_id==old_issues.id (I guess it is problematic). - Code in Koha::REST::V1::_object_ownership_by_checkout_id is wrong assuming that old_issues.issuing_id is unique -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Mar 9 21:04:16 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 09 Mar 2017 20:04:16 +0000 Subject: [Koha-bugs] [Bug 18242] Remove primary key on old_issues.issue_id In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18242 --- Comment #4 from Jonathan Druart --- Created attachment 60972 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=60972&action=edit Bug 18242: [SOLUTION 2]Add tests -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Mar 9 21:04:12 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 09 Mar 2017 20:04:12 +0000 Subject: [Koha-bugs] [Bug 18242] Remove primary key on old_issues.issue_id In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18242 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Mar 9 21:04:21 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 09 Mar 2017 20:04:21 +0000 Subject: [Koha-bugs] [Bug 18242] Remove primary key on old_issues.issue_id In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18242 --- Comment #5 from Jonathan Druart --- Created attachment 60973 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=60973&action=edit Bug 18242: [SOLUTION 2]Handle correctly move to old_issues The table old_issues has a primary key defined on the issue_id column. This issue_id comes from the issues table when an item is checked in. In some case the value of issue_id already exists in the table Basically this happens when an item is returned and mysqld is restarted: The auto increment value for issues.issue_id will be reset to MAX(issue_id)+1 (which is the value of the last entry of old_issues). See also the description of bug 18003 for more informations. In this solution the change is done at code level instead of DB structure: If old_issues.issue_id already exists before moving from the issues table, the issue_id is updated (not on cascade for accountlines.issue_id, should it?) before the move. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Mar 10 08:14:49 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 10 Mar 2017 07:14:49 +0000 Subject: [Koha-bugs] [Bug 18243] New: Bug 16034 follow-up: better handling of absence of WebService::ILS::OverDrive:: Patron at testing Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18243 Bug ID: 18243 Summary: Bug 16034 follow-up: better handling of absence of WebService::ILS::OverDrive::Patron at testing Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: OPAC Assignee: oleonard at myacpl.org Reporter: srdjan at catalyst.net.nz QA Contact: testopia at bugs.koha-community.org -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Mar 10 08:19:37 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 10 Mar 2017 07:19:37 +0000 Subject: [Koha-bugs] [Bug 18243] Bug 16034 follow-up: better handling of absence of WebService: :ILS::OverDrive::Patron at testing In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18243 Srdjan Jankovic changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Mar 10 08:19:39 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 10 Mar 2017 07:19:39 +0000 Subject: [Koha-bugs] [Bug 18243] Bug 16034 follow-up: better handling of absence of WebService: :ILS::OverDrive::Patron at testing In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18243 --- Comment #1 from Srdjan Jankovic --- Created attachment 60974 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=60974&action=edit Bug 18243: 16034 follow-up: better handling of absence of WebService::ILS::OverDrive::Patron at testing -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Mar 10 08:20:51 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 10 Mar 2017 07:20:51 +0000 Subject: [Koha-bugs] [Bug 16034] Integration with OverDrive Patron API In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16034 --- Comment #82 from Srdjan Jankovic --- https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18243 Should we close this one then? -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Mar 10 08:23:33 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 10 Mar 2017 07:23:33 +0000 Subject: [Koha-bugs] [Bug 16034] Integration with OverDrive Patron API In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16034 Srdjan Jankovic changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #60789|0 |1 is obsolete| | --- Comment #83 from Srdjan Jankovic --- Comment on attachment 60789 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=60789 Bug 16034 follow-up: better handling of absence of WebService::ILS::OverDrive::Patron at testing Attached to bug 18243 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Mar 10 08:25:32 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 10 Mar 2017 07:25:32 +0000 Subject: [Koha-bugs] [Bug 18235] Elastic search - Configurable facets In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18235 Jacek Ablewicz changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |abl at biblos.pk.edu.pl -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Mar 10 08:40:42 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 10 Mar 2017 07:40:42 +0000 Subject: [Koha-bugs] [Bug 17560] Hold fee placement at point of checkout In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17560 Marcel de Rooy changed: What |Removed |Added ---------------------------------------------------------------------------- QA Contact|testopia at bugs.koha-communit |m.de.rooy at rijksmuseum.nl |y.org | CC| |m.de.rooy at rijksmuseum.nl --- Comment #14 from Marcel de Rooy --- QA: Looking here now. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Mar 10 08:48:15 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 10 Mar 2017 07:48:15 +0000 Subject: [Koha-bugs] [Bug 18220] OPAC login appears to be linked to staff login In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18220 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |katrin.fischer at bsz-bw.de Resolution|--- |FIXED Status|NEW |RESOLVED --- Comment #1 from Katrin Fischer --- It's normal if you are running both staff and OPAC on the same 'URL' with only the ports being different. If you use different subdomains it would not happen. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Mar 10 08:50:26 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 10 Mar 2017 07:50:26 +0000 Subject: [Koha-bugs] [Bug 18223] Request for ID to be included on patron details of overdue report In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18223 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |katrin.fischer at bsz-bw.de --- Comment #1 from Katrin Fischer --- Hi Caroline, I am not sure what patron id is - can you describe this a bit more or tell us the name of the column in the borrowers table? -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Fri Mar 10 08:58:14 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 10 Mar 2017 07:58:14 +0000 Subject: [Koha-bugs] [Bug 17560] Hold fee placement at point of checkout In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17560 Marcel de Rooy changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Failed QA --- Comment #15 from Marcel de Rooy --- QA Comment Code looks good to me. Note some wording issues and one blocker in the db revision. Did not yet test the interface. not_always is kind of a vague name for an option ;) There is a charge of [% RESERVE_CHARGE %] for collecting this hold There is a charge of [% RESERVE_CHARGE %] for placing this hold Shouldn't it be better to say WHEN collecting this hold or WHEN placing this hold ?
    You have been charged for collecting this item.
    Why did they charge me? Shouldn't you mention the the term "hold fee" here too? sco-main.pl You check if a hold exists before issuing. Shouldn't you check for the borrowernumber too? BTW Why not just call GetReserveFee here instead? You do not need to check holds and account_lines anymore. And additionally you can pass the exact amount in the message. If you would still check account_lines, why not search for "Reserve Charge - $title" too? Please rename bug_XXXXX.sql. Additionally, if the pref is set to 'always', you should now change the value to any_time_is_placed. Since you remove always !! Failed QA -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Mar 10 09:04:27 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 10 Mar 2017 08:04:27 +0000 Subject: [Koha-bugs] [Bug 17755] Introduce Koha::Patron::Attribute::Type(s) In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17755 Marcel de Rooy changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Failed QA CC| |m.de.rooy at rijksmuseum.nl --- Comment #17 from Marcel de Rooy --- FAIL Koha/Object/Library/Limit.pm OK critic OK forbidden patterns FAIL git manipulation The file has been added and deleted in the same patchset OK pod SKIP spelling OK valid FAIL Koha/Object/Limit/Library.pm FAIL valid Can't locate Data/Printer.pm in @INC Debugging leftover ? -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Mar 10 09:09:08 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 10 Mar 2017 08:09:08 +0000 Subject: [Koha-bugs] [Bug 15427] Allow db connections using TLS In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15427 Marcel de Rooy changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |m.de.rooy at rijksmuseum.nl --- Comment #17 from Marcel de Rooy --- Note: tls is not found in debian/templates/koha-conf-site.xml.in -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Mar 10 09:09:54 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 10 Mar 2017 08:09:54 +0000 Subject: [Koha-bugs] [Bug 15427] Allow db connections using TLS In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15427 Marcel de Rooy changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |https://bugs.koha-community | |.org/bugzilla3/show_bug.cgi | |?id=18215 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Mar 10 09:09:54 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 10 Mar 2017 08:09:54 +0000 Subject: [Koha-bugs] [Bug 18215] Resolve warning on $tls in Database.pm In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18215 Marcel de Rooy changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |https://bugs.koha-community | |.org/bugzilla3/show_bug.cgi | |?id=15427 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Mar 10 09:10:18 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 10 Mar 2017 08:10:18 +0000 Subject: [Koha-bugs] [Bug 18215] Resolve warning on $tls in Database.pm In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18215 Marcel de Rooy changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to Master |ASSIGNED -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Mar 10 09:21:39 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 10 Mar 2017 08:21:39 +0000 Subject: [Koha-bugs] [Bug 18215] Resolve warning on $tls in Database.pm In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18215 Marcel de Rooy changed: What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Mar 10 09:21:42 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 10 Mar 2017 08:21:42 +0000 Subject: [Koha-bugs] [Bug 18215] Resolve warning on $tls in Database.pm In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18215 --- Comment #6 from Marcel de Rooy --- Created attachment 60975 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=60975&action=edit Bug 18215: Fix another tls warning Resolve warning: Use of uninitialized value in string eq at C4/Installer.pm line 79. Test plan: Add a trivial .sql file in atomicupdate (comment is sufficient). Run updatedatabase.pl Without the patch you have the warning. Apply the patch and repeat (no warning). Signed-off-by: Marcel de Rooy -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Mar 10 09:21:56 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 10 Mar 2017 08:21:56 +0000 Subject: [Koha-bugs] [Bug 18215] Resolve warning on $tls in Database.pm In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18215 Marcel de Rooy changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off CC| |m.de.rooy at rijksmuseum.nl -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Mar 10 09:22:14 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 10 Mar 2017 08:22:14 +0000 Subject: [Koha-bugs] [Bug 18215] Resolve warning on $tls in Database.pm In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18215 Marcel de Rooy changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Mar 10 09:22:38 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 10 Mar 2017 08:22:38 +0000 Subject: [Koha-bugs] [Bug 18215] Resolve warning on $tls in Database.pm In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18215 Marcel de Rooy changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #60846|Bug 18215: Resolve warning |[PUSHED] Bug 18215: Resolve description|on $tls in Database.pm |warning on $tls in | |Database.pm -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Mar 10 09:23:04 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 10 Mar 2017 08:23:04 +0000 Subject: [Koha-bugs] [Bug 18215] Resolve warning on $tls in Database.pm In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18215 --- Comment #7 from Marcel de Rooy --- Kyle: Please push the second patch. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Mar 10 09:25:23 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 10 Mar 2017 08:25:23 +0000 Subject: [Koha-bugs] [Bug 15179] Marc field 084 does not show on bibliographic record In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15179 Marcel de Rooy changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |m.de.rooy at rijksmuseum.nl Assignee|koha-bugs at lists.koha-commun |karenliang.student at wegc.sch |ity.org |ool.nz -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Mar 10 09:38:54 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 10 Mar 2017 08:38:54 +0000 Subject: [Koha-bugs] [Bug 17970] GetPreparedLetter does not warn when expected In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17970 Marcel de Rooy changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #59481|0 |1 is obsolete| | --- Comment #7 from Marcel de Rooy --- Created attachment 60976 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=60976&action=edit Bug 17970: Add tests to highlight the problem Signed-off-by: Mark Tompsett Signed-off-by: Marcel de Rooy -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Mar 10 09:38:57 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 10 Mar 2017 08:38:57 +0000 Subject: [Koha-bugs] [Bug 17970] GetPreparedLetter does not warn when expected In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17970 Marcel de Rooy changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #59482|0 |1 is obsolete| | --- Comment #8 from Marcel de Rooy --- Created attachment 60977 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=60977&action=edit Bug 17970: Fix GetPreparedLetter behavior if nothing to substitute >From C4::Letters::GetPreparedLetter: my $tables = $params{tables}; my $substitute = $params{substitute}; $tables || $substitute || $repeat or carp( "ERROR: nothing to substitute - both 'tables' and 'substitute' are empty" ), return; So if the parameter tables or substitute is passed but does not contain anything, it will not warn as expected. Test plan: 1/ Apply the patch with tests 2/ Confirm that they do not pass 3/ Apply this patch 4/ Confirm that the tests now pass Signed-off-by: Mark Tompsett Signed-off-by: Marcel de Rooy -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Mar 10 09:44:39 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 10 Mar 2017 08:44:39 +0000 Subject: [Koha-bugs] [Bug 17970] GetPreparedLetter does not warn when expected In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17970 Marcel de Rooy changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA QA Contact|testopia at bugs.koha-communit |m.de.rooy at rijksmuseum.nl |y.org | Patch complexity|--- |Small patch CC| |m.de.rooy at rijksmuseum.nl --- Comment #9 from Marcel de Rooy --- Not really sure if we need this. But no blocker. Note that you also have wantlibrarian, which triggers an action but will not be allowed on itself now. And we still replace OPACBaseURL and call _process_tt if we do not pass table/substitute/repeat.. I diagonally checked all calls of GetPreparedLetter and they all use one or more of the parameters in the condition. So no problems expected. The error message does not mention repeat (part of the condition). The POD does not tell me which parameters are mandatory. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Mar 10 10:03:59 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 10 Mar 2017 09:03:59 +0000 Subject: [Koha-bugs] [Bug 17479] REST API: Save information on owner access In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17479 Marcel de Rooy changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |m.de.rooy at rijksmuseum.nl --- Comment #5 from Marcel de Rooy --- Just a dumb [hypothetical] question, since I am not that deep into Mojolicious etc. You only set the flag; you do not clear the flag. How do you make sure that setting this owner flag is not misused/abused later on? Is it possible that it is still on thru persistence? I could imagine that you would clear this flag in the else branch of the haspermission if? -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Mar 10 10:05:37 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 10 Mar 2017 09:05:37 +0000 Subject: [Koha-bugs] [Bug 18231] Add the missing id-column to koha.issuingrules-table for DBIC fixtures In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18231 Marcel de Rooy changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |m.de.rooy at rijksmuseum.nl Assignee|koha-bugs at lists.koha-commun |olli-antti.kivilahti at jns.fi |ity.org | --- Comment #7 from Marcel de Rooy --- Olli: Did you know that we have an Assignee field ? -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Fri Mar 10 10:06:18 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 10 Mar 2017 09:06:18 +0000 Subject: [Koha-bugs] [Bug 18001] LocalHoldsPriority can cause multiple holds queue lines for same hold request In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18001 Marcel de Rooy changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|koha-bugs at lists.koha-commun |kyle at bywatersolutions.com |ity.org | CC| |m.de.rooy at rijksmuseum.nl -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Mar 10 10:16:25 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 10 Mar 2017 09:16:25 +0000 Subject: [Koha-bugs] [Bug 18022] Empty barcode causes internal server error In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18022 Marcel de Rooy changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |m.de.rooy at rijksmuseum.nl Status|Signed Off |Passed QA --- Comment #11 from Marcel de Rooy --- Can't say that terrible hacks look good, but at least we could move this patch to the queue of Katrin.. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Mar 10 10:16:38 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 10 Mar 2017 09:16:38 +0000 Subject: [Koha-bugs] [Bug 18022] Empty barcode causes internal server error In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18022 Marcel de Rooy changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to Master -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Mar 10 10:21:27 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 10 Mar 2017 09:21:27 +0000 Subject: [Koha-bugs] [Bug 18028] install_misc directory is outdated and must be removed In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18028 Marcel de Rooy changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Mar 10 10:21:30 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 10 Mar 2017 09:21:30 +0000 Subject: [Koha-bugs] [Bug 18028] install_misc directory is outdated and must be removed In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18028 Marcel de Rooy changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #59751|0 |1 is obsolete| | --- Comment #3 from Marcel de Rooy --- Created attachment 60978 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=60978&action=edit Bug 18028: Remove outdated install_misc directory This directory is no longer maintained and contain outdated information on how to install Koha. On the Internet there are tutos using them and that can create confusion to new user (yes it could be confusing as well to execute a file that does no longer exist). NOTE: last tweak was mid 2016, but before that 2015. So I agree with the deletion. Signed-off-by: Mark Tompsett Signed-off-by: Marcel de Rooy -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Mar 10 10:22:02 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 10 Mar 2017 09:22:02 +0000 Subject: [Koha-bugs] [Bug 18028] install_misc directory is outdated and must be removed In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18028 Marcel de Rooy changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |m.de.rooy at rijksmuseum.nl QA Contact|testopia at bugs.koha-communit |m.de.rooy at rijksmuseum.nl |y.org | --- Comment #4 from Marcel de Rooy --- Always in for patches that reduce the number of lines :) -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Mar 10 10:24:54 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 10 Mar 2017 09:24:54 +0000 Subject: [Koha-bugs] [Bug 17605] EDI should set currency in order record on creation In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17605 Marcel de Rooy changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |m.de.rooy at rijksmuseum.nl Status|Signed Off |Failed QA --- Comment #4 from Marcel de Rooy --- Note that we have a Koha::Object for Bookseller(s) -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Mar 10 10:25:52 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 10 Mar 2017 09:25:52 +0000 Subject: [Koha-bugs] [Bug 17605] EDI should set currency in order record on creation In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17605 Marcel de Rooy changed: What |Removed |Added ---------------------------------------------------------------------------- Patch complexity|--- |Small patch QA Contact|testopia at bugs.koha-communit |m.de.rooy at rijksmuseum.nl |y.org | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Mar 10 10:27:03 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 10 Mar 2017 09:27:03 +0000 Subject: [Koha-bugs] [Bug 8630] Add covers from AdLibris to the OPAC and Intranet In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8630 Marcel de Rooy changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Patch doesn't apply CC| |m.de.rooy at rijksmuseum.nl -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Mar 10 10:44:33 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 10 Mar 2017 09:44:33 +0000 Subject: [Koha-bugs] [Bug 10382] collection not returning to null when removed from course reserves In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10382 --- Comment #18 from Alex Arnaud --- Created attachment 60979 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=60979&action=edit Bug 10382 - Course reserves: handle empty values -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Mar 10 10:45:33 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 10 Mar 2017 09:45:33 +0000 Subject: [Koha-bugs] [Bug 10382] collection not returning to null when removed from course reserves In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10382 Alex Arnaud changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Mar 10 10:45:45 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 10 Mar 2017 09:45:45 +0000 Subject: [Koha-bugs] [Bug 17718] Allow usage of Smartform API (Czech only) In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17718 Marcel de Rooy changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |m.de.rooy at rijksmuseum.nl Status|Signed Off |Failed QA --- Comment #14 from Marcel de Rooy --- Few questions: Why not only have one preference? If the client id is empty, the pref is obviously not enabled. We already have so much preferences ;) >From a security perspective, I do not really like to include code like this: Can we do it some other way? Add it to a local lib directory, and have more control? In general: Can you convince me why we should push it in this current form? I could imagine that we could have a more general 'plugin' that operates on address fields and allows access to selected web services, or so? Anyway, thanks for your work ! Your answers or adjustments may bring this further. Changing status to reflect need for feedback. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Mar 10 10:46:15 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 10 Mar 2017 09:46:15 +0000 Subject: [Koha-bugs] [Bug 17718] Allow usage of Smartform API (Czech only) In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17718 Marcel de Rooy changed: What |Removed |Added ---------------------------------------------------------------------------- QA Contact|testopia at bugs.koha-communit |m.de.rooy at rijksmuseum.nl |y.org | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Mar 10 10:49:02 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 10 Mar 2017 09:49:02 +0000 Subject: [Koha-bugs] [Bug 17971] TT syntax for notices - Add support for plurals In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17971 Marcel de Rooy changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Patch doesn't apply CC| |m.de.rooy at rijksmuseum.nl --- Comment #5 from Marcel de Rooy --- Applying on top of 17970: Applying: Bug 17971: TT syntax for notices - Add support for plurals fatal: sha1 information is lacking or useless (C4/Letters.pm). Repository lacks necessary blobs to fall back on 3-way merge. Cannot fall back to three-way merge. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Mar 10 10:52:04 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 10 Mar 2017 09:52:04 +0000 Subject: [Koha-bugs] [Bug 13371] Add filters to the supplier list view In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13371 --- Comment #76 from Marcel de Rooy --- Jonathan or Julian: Could you try to get some more feedback on this bug in view of earlier comments (for example 71 and 72) ? Mailing list, IRC, etc. ? Without some more positive feedback, this patch gets stuck here.. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Mar 10 10:58:41 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 10 Mar 2017 09:58:41 +0000 Subject: [Koha-bugs] [Bug 17844] Move C4::Koha::get_notforloan_label_of to Koha:: AuthorisedValues In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17844 Marcel de Rooy changed: What |Removed |Added ---------------------------------------------------------------------------- QA Contact|testopia at bugs.koha-communit |m.de.rooy at rijksmuseum.nl |y.org | CC| |m.de.rooy at rijksmuseum.nl -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Mar 10 11:05:33 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 10 Mar 2017 10:05:33 +0000 Subject: [Koha-bugs] [Bug 17844] Move C4::Koha::get_notforloan_label_of to Koha:: AuthorisedValues In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17844 Marcel de Rooy changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA Patch complexity|--- |Small patch -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Mar 10 11:05:35 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 10 Mar 2017 10:05:35 +0000 Subject: [Koha-bugs] [Bug 17844] Move C4::Koha::get_notforloan_label_of to Koha:: AuthorisedValues In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17844 Marcel de Rooy changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #60012|0 |1 is obsolete| | --- Comment #8 from Marcel de Rooy --- Created attachment 60980 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=60980&action=edit Bug 17844: Remove C4::Koha::get_notforloan_label_of Signed-off-by: Josef Moravec Signed-off-by: Marcel de Rooy -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Mar 10 11:05:39 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 10 Mar 2017 10:05:39 +0000 Subject: [Koha-bugs] [Bug 17844] Move C4::Koha::get_notforloan_label_of to Koha:: AuthorisedValues In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17844 Marcel de Rooy changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #60013|0 |1 is obsolete| | --- Comment #9 from Marcel de Rooy --- Created attachment 60981 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=60981&action=edit Bug 17844: Replace C4::Koha::get_notforloan_label_of with Koha::AuthorisedValues This patch is more a bugfix than a refactoring. Indeed the C4::Koha::get_notforloan_label_of behaviors were buggy: 1/ It does not display the opac description at the OPAC, but always the staff description 2/ It does not care of the framework of the biblio, but retrieve the first row of the marc_subfield_structure mapped with items.notforloan These 2 bugs can easily be fixed using the Koha::AuthorisedValues->search_by_koha_field Steps to recreate the issues: - Create 2 authorised value categories for not for loan (NFL1 and NFL2) with the same values. Define a different description for the OPAC. - Define link 952$7 to NFL1 for the default framework and to NFL2 for the BK framework - Create 2 bibliographic records (B1 using NFL1 and B2 using NFL2) with 2 items each (1 item should have a not for loan value) - Go to the "Place a hold" view for this record. - In the item list, you should see the not for loan value => The staff description of NFL1 will always be used, even for the OPAC Test plan: - Recreate the issues without this patchset - Apply this patchset - Recreate the steps to recreate the issues => The staff description of NFL2 should be displayed for the B2 item => The opac description of NFL2 should be displayed for the B2 item at the OPAC Signed-off-by: Josef Moravec Signed-off-by: Marcel de Rooy -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Mar 10 11:08:46 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 10 Mar 2017 10:08:46 +0000 Subject: [Koha-bugs] [Bug 17847] Move C4::Koha::GetAuthvalueDropbox to Koha::AuthorisedValues In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17847 Marcel de Rooy changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |m.de.rooy at rijksmuseum.nl QA Contact|testopia at bugs.koha-communit |m.de.rooy at rijksmuseum.nl |y.org | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Mar 10 11:19:13 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 10 Mar 2017 10:19:13 +0000 Subject: [Koha-bugs] [Bug 18244] New: Patron card creator does not take in account fields with underscore ( B_address etc.) Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18244 Bug ID: 18244 Summary: Patron card creator does not take in account fields with underscore (B_address etc.) Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: normal Priority: P5 - low Component: Label/patron card printing Assignee: cnighswonger at foundations.edu Reporter: veron at veron.ch QA Contact: testopia at bugs.koha-community.org Fields with underscore like B_address do not print on patron cards. To reproduce: - Create patron card layout using fields with underscore in their name (e.g. ) - Print (export) patron card - Verify that fields without underscore are replaced by their value, but fields with underscore do not replace but show the field name -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Mar 10 11:25:35 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 10 Mar 2017 10:25:35 +0000 Subject: [Koha-bugs] [Bug 17847] Move C4::Koha::GetAuthvalueDropbox to Koha::AuthorisedValues In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17847 Marcel de Rooy changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #60019|0 |1 is obsolete| | --- Comment #5 from Marcel de Rooy --- Created attachment 60982 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=60982&action=edit Bug 17847: Replace C4::Koha::GetAuthvalueDropbox with Koha::AuthorisedValues The C4::Koha::GetAuthvalueDropbox subroutine does the same job as Koha::AuthorisedValues->search We should then replace the different calls to this subroutine to finally remove it. There were 2 calls to this subroutine: - from the AuthorisedValues TT plugin (called from av-build-dropbox.inc and members/housebound.tt) - from the acqui/ajax-getauthvaluedropbox.pl ajax script To make sure that this patchset does not introduce regressions, we will have to test that the TT plugin and the ajax script still behave as before. Test plan: 1/ Test acqui/ajax-getauthvaluedropbox.pl - Link a fund to an authorised value category - Create a new order => When you select a fund linked to AV category, the sort1 (and/or sort2, depending on what you set) should be replaced with a dropdown list populated with the authorised values 2/ Test av-build-dropbox.inc - Create some authorised values for Bsort1 - Edit a patron => The sort1 should be a dropdown list populated with the Bsort1 AV 3/ Test members/housebound.tt - Enable the housebound module (pref HouseboundModule) - On the patron detail page, click on the "Housebound" tab => The frequency dropdown list should be populated with the different HSBND_FREQ AV Signed-off-by: Josef Moravec Signed-off-by: Marcel de Rooy -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Mar 10 11:25:39 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 10 Mar 2017 10:25:39 +0000 Subject: [Koha-bugs] [Bug 17847] Move C4::Koha::GetAuthvalueDropbox to Koha::AuthorisedValues In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17847 Marcel de Rooy changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #60020|0 |1 is obsolete| | --- Comment #6 from Marcel de Rooy --- Created attachment 60983 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=60983&action=edit Bug 17847: Remove C4::Koha::GetAuthvalueDropbox Signed-off-by: Josef Moravec Signed-off-by: Marcel de Rooy -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Mar 10 11:25:59 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 10 Mar 2017 10:25:59 +0000 Subject: [Koha-bugs] [Bug 18244] Patron card creator does not take in account fields with underscore ( B_address etc.) In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18244 Marc V?ron changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|cnighswonger at foundations.ed |veron at veron.ch |u | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Mar 10 11:26:33 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 10 Mar 2017 10:26:33 +0000 Subject: [Koha-bugs] [Bug 17847] Move C4::Koha::GetAuthvalueDropbox to Koha::AuthorisedValues In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17847 Marcel de Rooy changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA Patch complexity|--- |Small patch --- Comment #7 from Marcel de Rooy --- acqui/ajax-getauthvaluedropbox.pl We should actually use a html template here and move the html stuff outside the script. Yes, it was already there, but this is/was an opportunity? Passed QA -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Mar 10 11:26:39 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 10 Mar 2017 10:26:39 +0000 Subject: [Koha-bugs] [Bug 18244] Patron card creator does not take in account fields with underscore ( B_address etc.) In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18244 --- Comment #1 from Marc V?ron --- Created attachment 60984 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=60984&action=edit Bug 18244: Patron card creator does not take in account fields with underscore (B_address etc.) Fields with underscore like B_address do not print on patron cards. To reproduce: - Create patron card layout using fields with underscore in their name (e.g. ) - Print (export) patron card - Verify that fields without underscore are replaced by their value, but fields with underscore do not replace but show the field name To test: - Apply patch - Try to reproduce and verify that fields with underscore are replace as expected -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Mar 10 11:27:42 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 10 Mar 2017 10:27:42 +0000 Subject: [Koha-bugs] [Bug 18244] Patron card creator does not take in account fields with underscore ( B_address etc.) In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18244 Marc V?ron changed: What |Removed |Added ---------------------------------------------------------------------------- Patch complexity|--- |Trivial patch Status|NEW |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Mar 10 11:39:02 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 10 Mar 2017 10:39:02 +0000 Subject: [Koha-bugs] [Bug 18058] 'borrowers-force-messaging-defaults --doit --truncate ' gives DBI error In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18058 Marcel de Rooy changed: What |Removed |Added ---------------------------------------------------------------------------- Patch complexity|--- |Small patch Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Mar 10 11:39:04 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 10 Mar 2017 10:39:04 +0000 Subject: [Koha-bugs] [Bug 18058] 'borrowers-force-messaging-defaults --doit --truncate ' gives DBI error In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18058 --- Comment #3 from Marcel de Rooy --- Created attachment 60985 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=60985&action=edit Bug 18058: Allow borrower_message_preferences to be truncated borrower_message_preferences cannot be truncated because of the foreign. DBMS fails with "Cannot truncate a table referenced in a foreign key constraint" To avoid that we should remove the FK check and truncate the other table as well. I am wondering if we really need a truncate here DELETE FROM borrower_message_preferences; should do the job, but leave it as it because of the param name. Test plan perl misc/maintenance/borrowers-force-messaging-defaults --doit --truncate Should no longer raise the error message Signed-off-by: Mark Tompsett Signed-off-by: Marcel de Rooy -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Mar 10 11:39:32 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 10 Mar 2017 10:39:32 +0000 Subject: [Koha-bugs] [Bug 18058] 'borrowers-force-messaging-defaults --doit --truncate ' gives DBI error In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18058 Marcel de Rooy changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #60479|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Mar 10 11:39:31 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 10 Mar 2017 10:39:31 +0000 Subject: [Koha-bugs] [Bug 18058] 'borrowers-force-messaging-defaults --doit --truncate ' gives DBI error In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18058 Marcel de Rooy changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |m.de.rooy at rijksmuseum.nl -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Mar 10 11:40:08 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 10 Mar 2017 10:40:08 +0000 Subject: [Koha-bugs] [Bug 18058] 'borrowers-force-messaging-defaults --doit --truncate ' gives DBI error In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18058 Marcel de Rooy changed: What |Removed |Added ---------------------------------------------------------------------------- QA Contact|testopia at bugs.koha-communit |m.de.rooy at rijksmuseum.nl |y.org | --- Comment #4 from Marcel de Rooy --- Delete instead of truncate indeed seems to be a better idea here.. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Mar 10 11:56:02 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 10 Mar 2017 10:56:02 +0000 Subject: [Koha-bugs] [Bug 18208] Add RecordProcessor filter to inject not onloan count to MARC records In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18208 Marcel de Rooy changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |m.de.rooy at rijksmuseum.nl --- Comment #3 from Marcel de Rooy --- my $items = Koha::Items->search({ biblionumber => $biblionumber }); + + while ( my $item = $items->next ) { + $not_onloan_items++ + if not $item->onloan; + } Can't you combine that in one statement? In general: Do I understand correctly that this is not an optional filter? We will always save the not onloan count to 999$x? Can you also add some explanation on this report why we definitely need it? At this point we are not using it in the codebase. But if we should do after some time, would it feel good to rely on a field in the search engine when we can generate the count in one Koha::Items call ? No blockers, just convince me.. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Mar 10 11:58:27 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 10 Mar 2017 10:58:27 +0000 Subject: [Koha-bugs] [Bug 14608] HEA : add possibility of sharing usage statistics in Administration page and Web installer In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14608 Marcel de Rooy changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Failed QA --- Comment #37 from Marcel de Rooy --- Please move the countries somewhere else :) -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Mar 10 12:05:52 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 10 Mar 2017 11:05:52 +0000 Subject: [Koha-bugs] [Bug 18000] Add --tablename option to misc/devel/ update_dbix_class_files.pl script In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18000 Marcel de Rooy changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |m.de.rooy at rijksmuseum.nl QA Contact| |m.de.rooy at rijksmuseum.nl -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Mar 10 12:08:46 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 10 Mar 2017 11:08:46 +0000 Subject: [Koha-bugs] [Bug 18000] Add --tablename option to misc/devel/ update_dbix_class_files.pl script In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18000 Marcel de Rooy changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Failed QA --- Comment #8 from Marcel de Rooy --- This does not seem to work. I tested table virtualshelves (added a column). The results between running with table only and on the whole db are different. If you run only on one table, you loose has_many and belongs_to etc. Seems quite dangerous.. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Mar 10 12:19:44 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 10 Mar 2017 11:19:44 +0000 Subject: [Koha-bugs] [Bug 17479] REST API: Save information on owner access In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17479 --- Comment #6 from Lari Taskula --- In Mojolicious, the stash, which we use for this flag, is a non-persistent storage only for the current request. So it will be cleared for the following requests and then set again. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Mar 10 12:33:03 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 10 Mar 2017 11:33:03 +0000 Subject: [Koha-bugs] [Bug 17479] REST API: Save information on owner access In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17479 --- Comment #7 from Marcel de Rooy --- (In reply to Lari Taskula from comment #6) > In Mojolicious, the stash, which we use for this flag, is a non-persistent > storage only for the current request. So it will be cleared for the > following requests and then set again. OK I suspected that. Altough clearing it in the else still seems safe.. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Mar 10 12:58:37 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 10 Mar 2017 11:58:37 +0000 Subject: [Koha-bugs] [Bug 18208] Add RecordProcessor filter to inject not onloan count to MARC records In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18208 --- Comment #4 from Tom?s Cohen Arazi --- (In reply to Marcel de Rooy from comment #3) > my $items = Koha::Items->search({ biblionumber => $biblionumber }); > + > + while ( my $item = $items->next ) { > + $not_onloan_items++ > + if not $item->onloan; > + } > Can't you combine that in one statement? > > In general: Do I understand correctly that this is not an optional filter? > We will always save the not onloan count to 999$x? > Can you also add some explanation on this report why we definitely need it? > At this point we are not using it in the codebase. But if we should do after > some time, would it feel good to rely on a field in the search engine when > we can generate the count in one Koha::Items call ? > No blockers, just convince me.. The record will always inject that. And is going to be used on indexing only. See bug 18098. When it comes to filtering search results (records with available items this time) we need the index for being able to build the filtering query. We already do that but the query is not working, and this way writing the query seems straightfowrad. Just check if the index has a value higher than 0. Period. RecordProcessor filters should be used for lots of things (specially stuff done in C4::Biblios) like embedding items... -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Mar 10 13:21:38 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 10 Mar 2017 12:21:38 +0000 Subject: [Koha-bugs] [Bug 17015] New Koha Calendar In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17015 Mehdi Hamidi changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #60902|0 |1 is obsolete| | --- Comment #57 from Mehdi Hamidi --- Created attachment 60986 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=60986&action=edit Bug 17015 - DiscreteCalendar UI, Back-End and necessary scripts -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Mar 10 13:22:29 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 10 Mar 2017 12:22:29 +0000 Subject: [Koha-bugs] [Bug 18243] Bug 16034 follow-up: better handling of absence of WebService: :ILS::OverDrive::Patron at testing In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18243 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on| |16034 CC| |jonathan.druart at bugs.koha-c | |ommunity.org Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16034 [Bug 16034] Integration with OverDrive Patron API -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Mar 10 13:22:29 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 10 Mar 2017 12:22:29 +0000 Subject: [Koha-bugs] [Bug 16034] Integration with OverDrive Patron API In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16034 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |18243 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18243 [Bug 18243] Bug 16034 follow-up: better handling of absence of WebService::ILS::OverDrive::Patron at testing -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Mar 10 13:23:08 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 10 Mar 2017 12:23:08 +0000 Subject: [Koha-bugs] [Bug 16034] Integration with OverDrive Patron API In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16034 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Status|REOPENED |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Mar 10 13:23:20 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 10 Mar 2017 12:23:20 +0000 Subject: [Koha-bugs] [Bug 16034] Integration with OverDrive Patron API In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16034 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Mar 10 13:23:29 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 10 Mar 2017 12:23:29 +0000 Subject: [Koha-bugs] [Bug 16034] Integration with OverDrive Patron API In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16034 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Mar 10 13:24:26 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 10 Mar 2017 12:24:26 +0000 Subject: [Koha-bugs] [Bug 16034] Integration with OverDrive Patron API In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16034 --- Comment #84 from Jonathan Druart --- (In reply to Srdjan Jankovic from comment #82) > https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18243 > > Should we close this one then? At least "pushed to master", not sure resolved is appropriate when there are known bugs. Did you also fix comment 80? -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Mar 10 13:24:36 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 10 Mar 2017 12:24:36 +0000 Subject: [Koha-bugs] [Bug 16034] Integration with OverDrive Patron API In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16034 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to Master -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Mar 10 13:32:04 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 10 Mar 2017 12:32:04 +0000 Subject: [Koha-bugs] [Bug 17971] TT syntax for notices - Add support for plurals In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17971 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Patch doesn't apply |Signed Off -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Mar 10 13:32:08 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 10 Mar 2017 12:32:08 +0000 Subject: [Koha-bugs] [Bug 17971] TT syntax for notices - Add support for plurals In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17971 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #59529|0 |1 is obsolete| | Attachment #59530|0 |1 is obsolete| | --- Comment #6 from Jonathan Druart --- Created attachment 60987 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=60987&action=edit Bug 17971: TT syntax for notices - Add support for plurals On of the awesome things we will be able to do with the TT syntax is the support of plurals. For instance we will be able to send a list of items, checkouts, etc. to the notice template. That way we will get rid of our custom syntax like <> or for instance. The existing code already has the playground for that but it is not used. Basically the idea is to add a "loops" key which can contain a list of object to retrieve from the DB and send to the template. For instance: loops => { overdues => [ $itemnumber_1, .., $itemnumber_N ] } will send a variable "overdues" to the template. It will contain the Koha::Checkout objects relative to the id passed. There is one quite big inconvenient to this approach so far: since we are still supporting the historical syntax, the objects can be fetch by a script, then the script will send the id to GetPreparedLetter which will refetch them. This must be improved, but I suggest to do that later. Test plan: prove t/db_dependent/Letters/TemplateToolkit.t should return green Signed-off-by: Josef Moravec -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Mar 10 13:32:22 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 10 Mar 2017 12:32:22 +0000 Subject: [Koha-bugs] [Bug 17971] TT syntax for notices - Add support for plurals In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17971 --- Comment #7 from Jonathan Druart --- Created attachment 60988 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=60988&action=edit Bug 17971: Add support for objects represented by fk For instance an issue is not fetch from its fk but using the fk itemnumber. We need to support them. Signed-off-by: Josef Moravec -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Mar 10 13:32:58 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 10 Mar 2017 12:32:58 +0000 Subject: [Koha-bugs] [Bug 16895] Allow writeoffs via SIP2 In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16895 Marcel de Rooy changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |m.de.rooy at rijksmuseum.nl --- Comment #3 from Marcel de Rooy --- Any chance to include some kind of unit testing? We have some tests for MsgType.. Can you further explain the use of the pay_type? If I follow the chain, it gets written to the accounts table with a sip prefix? But is that the only thing it does, or do I overlook any specific behavior for sip payment type? Please clarify. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Mar 10 13:47:38 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 10 Mar 2017 12:47:38 +0000 Subject: [Koha-bugs] [Bug 17605] EDI should set currency in order record on creation In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17605 --- Comment #5 from Colin Campbell --- (In reply to Marcel de Rooy from comment #4) > Note that we have a Koha::Object for Bookseller(s) By not using the Koha::Object this patch will apply to the stable banches 16.5 and 16.11 Booksellers.pm and hence the find method only present in master -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Mar 10 13:51:40 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 10 Mar 2017 12:51:40 +0000 Subject: [Koha-bugs] [Bug 14608] HEA : add possibility of sharing usage statistics in Administration page and Web installer In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14608 --- Comment #38 from Jonathan Druart --- (In reply to Marcel de Rooy from comment #37) > Please move the countries somewhere else :) I do not know what you mean, it's how it is done in admin/preferences/admin.pref I know it is not ideal to have that list in 2 places, but it will not be easy to centralise it. I would prefer to deal with that on another bug report, unless you have something easy to suggest? -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Mar 10 13:59:39 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 10 Mar 2017 12:59:39 +0000 Subject: [Koha-bugs] [Bug 17605] EDI should set currency in order record on creation In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17605 --- Comment #6 from Marcel de Rooy --- (In reply to Colin Campbell from comment #5) > (In reply to Marcel de Rooy from comment #4) > > Note that we have a Koha::Object for Bookseller(s) > > By not using the Koha::Object this patch will apply to the stable banches > 16.5 and 16.11 Booksellers.pm and hence the find method only present in > master Agreed. Sounds reasonable for the stable branches. Since the patch only deals with two lines, you could also supply two versions? -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Mar 10 14:11:53 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 10 Mar 2017 13:11:53 +0000 Subject: [Koha-bugs] [Bug 16895] Allow writeoffs via SIP2 In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16895 --- Comment #4 from Kyle M Hall --- (In reply to Marcel de Rooy from comment #3) > Any chance to include some kind of unit testing? We have some tests for > MsgType.. > Can you further explain the use of the pay_type? Yes, it is a legacy parameter that simply declares this payment was made via SIP. > If I follow the chain, it > gets written to the accounts table with a sip prefix? But is that the only > thing it does, or do I overlook any specific behavior for sip payment type? Nope, that is literally all it does, it is existing behavior that we are continuing to use. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Mar 10 14:23:21 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 10 Mar 2017 13:23:21 +0000 Subject: [Koha-bugs] [Bug 17560] Hold fee placement at point of checkout In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17560 --- Comment #16 from Jonathan Druart --- (In reply to Marcel de Rooy from comment #15) > QA Comment > Code looks good to me. Note some wording issues and one blocker in the db > revision. Did not yet test the interface. > > not_always is kind of a vague name for an option ;) > There is a charge of [% RESERVE_CHARGE %] for collecting this hold > There is a charge of [% RESERVE_CHARGE %] for placing this hold > Shouldn't it be better to say WHEN collecting this hold or WHEN placing this > hold ? >
    You have been charged for collecting this item.
    > Why did they charge me? Shouldn't you mention the the term "hold fee" here > too? Can we get a native English speaker confirm the wordings? > sco-main.pl > You check if a hold exists before issuing. Shouldn't you check for the > borrowernumber too? Indeed. > BTW Why not just call GetReserveFee here instead? You do not need to check > holds and account_lines anymore. And additionally you can pass the exact > amount in the message. The idea was to make sure the patron has been charged. From the circulation and reserves modules we are never really sure that what we want to happen will happen.... > If you would still check account_lines, why not search for "Reserve Charge - > $title" too? To avoid to depend on a string that could change, but I can add it if you think it's safer. > Please rename bug_XXXXX.sql. > Additionally, if the pref is set to 'always', you should now change the > value to any_time_is_placed. Since you remove always !! Indeed, will fix. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Mar 10 14:28:37 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 10 Mar 2017 13:28:37 +0000 Subject: [Koha-bugs] [Bug 17718] Allow usage of Smartform API (Czech only) In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17718 --- Comment #15 from Radek ?iman (R-Bit Technology, s.r.o.) --- One preference is a good idea, I will change it. I understand the security reasons about cross-site inclusion of javascripts. The problem is, this a 3rd party service we really like and we trust it, because it's widely used in our country including a leader of IT market. Not a good reason, I know. Currently they offer direct linkage only. I am not sure if they will ever allow to download the sources as a package. It is connected to their database structure and so they have a good control over compatibility issues, I think. However, I'll try to ask them for the sources. For your information, please look at http://www.smartform.cz/index.html and you will see how the service grows on the graph in the right bottom corner of the page. The only reason to ask for the current form is a growing community of this service users in the Czech Republic. Originally we had an idea similar to the Norwegian patron database and we planned this feature for our country only. On the other hand, you are right that kind of general plugin or driver would be useful, but it highly exceeds the original limits. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Mar 10 14:43:01 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 10 Mar 2017 13:43:01 +0000 Subject: [Koha-bugs] [Bug 18144] Removal of persona broke Google OAuth2 In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18144 M. Tompsett changed: What |Removed |Added ---------------------------------------------------------------------------- Summary|Removal of persona broke |Removal of persona broke |openidconnect |Google OAuth2 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Mar 10 14:49:37 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 10 Mar 2017 13:49:37 +0000 Subject: [Koha-bugs] [Bug 17755] Introduce Koha::Patron::Attribute::Type(s) In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17755 Tom?s Cohen Arazi changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #58495|0 |1 is obsolete| | Attachment #58498|0 |1 is obsolete| | --- Comment #18 from Tom?s Cohen Arazi --- Created attachment 60989 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=60989&action=edit Bug 17755: Introduce Koha::Object::Limit::Library This patch introduces a new class for extending Koha::Object using multiple inheritance. It cannot be used standalone, it needs to be used in Koha::Object implementations like this: use base qw( Koha::Object Koha::Object::Limit::Library ); Its goal is to provide a single way and place to deal with this common pattern in Koha's codebase. As it happened with Koha::Object, that needed to be tested in a real object class, this work was done on top of Koha::Patron::Attribute::Type implementation and it is fully covered by the tests that are introduced for it. Signed-off-by: Kyle M Hall -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Mar 10 14:49:47 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 10 Mar 2017 13:49:47 +0000 Subject: [Koha-bugs] [Bug 17755] Introduce Koha::Patron::Attribute::Type(s) In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17755 Tom?s Cohen Arazi changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #58496|0 |1 is obsolete| | --- Comment #19 from Tom?s Cohen Arazi --- Created attachment 60990 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=60990&action=edit Bug 17755: Unit tests This patch introduces unit tests for Koha::Object::Library::Limit. It is done this way because it needs to be instantiated to be usable. To test: - Run: $ prove t/db_dependent/Koha/Patron/Attribute/Types.t => SUCCESS: Tests pass - Sign off :-D Signed-off-by: Kyle M Hall -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Mar 10 14:49:55 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 10 Mar 2017 13:49:55 +0000 Subject: [Koha-bugs] [Bug 17755] Introduce Koha::Patron::Attribute::Type(s) In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17755 Tom?s Cohen Arazi changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #58497|0 |1 is obsolete| | --- Comment #20 from Tom?s Cohen Arazi --- Created attachment 60991 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=60991&action=edit Bug 17755: Introduce Koha::Patron::Attribute::Type(s) This patch introduces the Koha::Object-based classes for handling patron attribute types. It also adds branch limitation handling to the Koha::Patron::Attribute::Type class. It is built on top of the new Koha::Object::Library::Limit class that extends Koha::Object so it handles library limits. Signed-off-by: Kyle M Hall -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Mar 10 14:50:02 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 10 Mar 2017 13:50:02 +0000 Subject: [Koha-bugs] [Bug 17755] Introduce Koha::Patron::Attribute::Type(s) In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17755 Tom?s Cohen Arazi changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #59354|0 |1 is obsolete| | --- Comment #21 from Tom?s Cohen Arazi --- Created attachment 60992 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=60992&action=edit Bug 17755: (QA followup) Return $self when appropriate As failure situations raise exceptions that should be handled outside the object class, methods should return $self so successive calls can be chained nicely. This patch makes methods return $self and adjusts the tests to reflect this change. Make sure tests pass: - Run: $ prove t/db_dependent/Koha/Patron/Attribute/Types.t => SUCCESS: Tests return green - Sign off :-D -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Mar 10 14:50:22 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 10 Mar 2017 13:50:22 +0000 Subject: [Koha-bugs] [Bug 17755] Introduce Koha::Patron::Attribute::Type(s) In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17755 Tom?s Cohen Arazi changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |tomascohen at gmail.com Status|Failed QA |Signed Off -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Mar 10 15:02:34 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 10 Mar 2017 14:02:34 +0000 Subject: [Koha-bugs] [Bug 17560] Hold fee placement at point of checkout In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17560 --- Comment #17 from Jonathan Druart --- Created attachment 60993 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=60993&action=edit Bug 17560: Improve strenght of hold existence test This patch is a QA follow-up to fix several issues: - 1 call to GetReserveFee was wrong in ModReserveFill - Update DB entry was wrong and insufficient - Add robustness to the tests in sco-main -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Mar 10 15:05:37 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 10 Mar 2017 14:05:37 +0000 Subject: [Koha-bugs] [Bug 17560] Hold fee placement at point of checkout In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17560 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |Signed Off --- Comment #18 from Jonathan Druart --- (In reply to Marcel de Rooy from comment #15) > BTW Why not just call GetReserveFee here instead? You do not need to check > holds and account_lines anymore. And additionally you can pass the exact > amount in the message. I tried to display the amount, but since we do not handle the display of price yet, I do not think it is ready. Without the currency symbol, the number alone looks weird, and with the currency symbol the display will be wrong half of the time... > Please rename bug_XXXXX.sql. I do not think this is necessary, I will have to rewrite the original patches and reupload all of them. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Mar 10 15:19:55 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 10 Mar 2017 14:19:55 +0000 Subject: [Koha-bugs] [Bug 18144] Removal of persona broke Google OAuth2 In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18144 M. Tompsett changed: What |Removed |Added ---------------------------------------------------------------------------- Alias| |persona, removal, broke, | |openidconnect -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Mar 10 16:16:19 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 10 Mar 2017 15:16:19 +0000 Subject: [Koha-bugs] [Bug 18220] OPAC login appears to be linked to staff login In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18220 --- Comment #2 from Christopher Brannon --- Thanks for the clarification. I was hoping it was something simple. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Mar 10 16:26:35 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 10 Mar 2017 15:26:35 +0000 Subject: [Koha-bugs] [Bug 5620] Capture Mode of payment In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5620 --- Comment #15 from Bouzid --- Created attachment 60994 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=60994&action=edit bug 5620 - Capture Mode of payment, receipt number and notes in pay fines. Using sql file in atomiqueupdate using function GetKohaAuthorisedValues -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Mar 10 16:33:09 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 10 Mar 2017 15:33:09 +0000 Subject: [Koha-bugs] [Bug 17755] Introduce Koha::Patron::Attribute::Type(s) In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17755 --- Comment #22 from Tom?s Cohen Arazi --- Created attachment 60995 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=60995&action=edit Bug 17755: (followup) Override ->search to allow filtering by branchcode Signed-off-by: Tomas Cohen Arazi -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Mar 10 16:33:05 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 10 Mar 2017 15:33:05 +0000 Subject: [Koha-bugs] [Bug 17755] Introduce Koha::Patron::Attribute::Type(s) In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17755 Tom?s Cohen Arazi changed: What |Removed |Added ---------------------------------------------------------------------------- Patch complexity|--- |Small patch -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Mar 10 16:33:53 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 10 Mar 2017 15:33:53 +0000 Subject: [Koha-bugs] [Bug 5620] Capture Mode of payment In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5620 Bouzid changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #56037|0 |1 is obsolete| | Attachment #56080|0 |1 is obsolete| | Attachment #60994|0 |1 is obsolete| | --- Comment #16 from Bouzid --- Created attachment 60996 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=60996&action=edit bug 5620 - Capture Mode of payment, receipt number and notes in pay fines. - Replace all sub deleted - Using Koha::Template::Plugin::AuthorisedValues - Delete unit tests -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Mar 10 16:34:47 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 10 Mar 2017 15:34:47 +0000 Subject: [Koha-bugs] [Bug 5620] Capture Mode of payment In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5620 Bouzid changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. You are the QA Contact for the bug. From bugzilla-daemon at bugs.koha-community.org Fri Mar 10 16:36:15 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 10 Mar 2017 15:36:15 +0000 Subject: [Koha-bugs] [Bug 18211] Circulation.pl / Moremember.pl has errors in table row id In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18211 --- Comment #1 from Christopher Brannon --- Created attachment 60997 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=60997&action=edit Bug 18211: Corrected intended id's in jquery. To test: 1) Checkout items - if you can, have items checked out from previous day too, but not necessary. 2) Review source code and see that the ids on the and for cells containing "Today's checkouts" and "Previous checkouts" labels have some crazy ids with partial html tags (strong) and other unnecessary elements. 3) Apply patch. 4) Examine source code again and see a better and smaller id. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Mar 10 16:36:42 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 10 Mar 2017 15:36:42 +0000 Subject: [Koha-bugs] [Bug 18211] Circulation.pl / Moremember.pl has errors in table row id In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18211 Christopher Brannon changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Fri Mar 10 16:50:36 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 10 Mar 2017 15:50:36 +0000 Subject: [Koha-bugs] [Bug 16895] Allow writeoffs via SIP2 In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16895 --- Comment #5 from Colin Campbell --- Yes pay type is just recorded. We are finding it useful though in reconciling when cashing up units that handle rental fees. Hopefully this will be included in a future submission -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Mar 10 17:20:13 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 10 Mar 2017 16:20:13 +0000 Subject: [Koha-bugs] [Bug 11299] Add a button that automatically links authority records to a biblio record during edition. (AJAX) In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11299 Bouzid changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #56440|0 |1 is obsolete| | Attachment #56509|0 |1 is obsolete| | Attachment #58307|0 |1 is obsolete| | --- Comment #31 from Bouzid --- Created attachment 60998 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=60998&action=edit Bug 11299 - Add a button to the biblio edition page to automatically add authority links in the current biblio record via AJAX. Also adds a button to easily create missing authority records. add authority type in the form to create the missing authority. when authority was found, the 600$9 field have the authid. Testing scenario (Creating an authority record for a failed automatic link) : * In you system preferences, deactivate the "AutoCreateAuthorities" preference. * Go to the biblio record creation form to create a new biblio record. (koha/cataloguing/addbiblio.pl) * Click the "Link authorities automatically" button. A message should appear, telling the user "No authority link was changed." * Add random informations in field 600$a of the biblio record. * Click the "Link authorities automatically" button. * if matching authority was found, The message box should now show "600 - A matching authority was found in the local database". * if no matching authority was found, the message box should now show "600 - No matching authority found.". For this scenario, we want the authority match to have failed. * The 600$9 field should now be red and icons should have appeared next to it. Click on the "create authority" icon. * A popup will appear, containing a form to create the missing authority. The form should be pre-filled, a the informations in the 600$a field of the biblio should be in the 100$a field of this new authority record. * Fill in the form and click the "Save" button * The 600$9 field in the biblio record should now be back to normal and have the authid of the authority record that was just created. * Click the "Link authorities automatically" button again. The message box should now show "No authority link was changed.". -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Mar 10 17:21:57 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 10 Mar 2017 16:21:57 +0000 Subject: [Koha-bugs] [Bug 11299] Add a button that automatically links authority records to a biblio record during edition. (AJAX) In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11299 --- Comment #32 from Bouzid --- Hi all, I rebase all patches and squash all in one good patch. Thanks. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Mar 10 17:42:49 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 10 Mar 2017 16:42:49 +0000 Subject: [Koha-bugs] [Bug 11300] Add a new authority linker which searches for authority links on a Z39.50 server. In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11300 Bouzid changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #56542|0 |1 is obsolete| | Attachment #56543|0 |1 is obsolete| | --- Comment #13 from Bouzid --- Created attachment 60999 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=60999&action=edit Bug 11300 - Add a new authority linker which searches for authority links on a Z39.50 server. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Mar 10 17:44:10 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 10 Mar 2017 16:44:10 +0000 Subject: [Koha-bugs] [Bug 11300] Add a new authority linker which searches for authority links on a Z39.50 server. In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11300 --- Comment #14 from Bouzid --- Hi all, I rebase all patches and squash all in one good patch. Thanks. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Mar 10 18:45:25 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 10 Mar 2017 17:45:25 +0000 Subject: [Koha-bugs] [Bug 18144] Removal of persona broke Google OAuth2 In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18144 Marcel de Rooy changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |m.de.rooy at rijksmuseum.nl -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Mar 10 18:46:23 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 10 Mar 2017 17:46:23 +0000 Subject: [Koha-bugs] [Bug 17755] Introduce Koha::Patron::Attribute::Type(s) In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17755 Kyle M Hall changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #60992|0 |1 is obsolete| | Attachment #60995|0 |1 is obsolete| | --- Comment #23 from Kyle M Hall --- Created attachment 61000 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=61000&action=edit Bug 17755: (QA followup) Return $self when appropriate As failure situations raise exceptions that should be handled outside the object class, methods should return $self so successive calls can be chained nicely. This patch makes methods return $self and adjusts the tests to reflect this change. Make sure tests pass: - Run: $ prove t/db_dependent/Koha/Patron/Attribute/Types.t => SUCCESS: Tests return green - Sign off :-D Signed-off-by: Kyle M Hall -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Mar 10 18:46:30 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 10 Mar 2017 17:46:30 +0000 Subject: [Koha-bugs] [Bug 17755] Introduce Koha::Patron::Attribute::Type(s) In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17755 --- Comment #24 from Kyle M Hall --- Created attachment 61001 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=61001&action=edit Bug 17755: (followup) Override ->search to allow filtering by branchcode Signed-off-by: Tomas Cohen Arazi Signed-off-by: Kyle M Hall -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Mar 10 20:01:14 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 10 Mar 2017 19:01:14 +0000 Subject: [Koha-bugs] [Bug 10382] collection not returning to null when removed from course reserves In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10382 --- Comment #19 from M. Tompsett --- Comment on attachment 60979 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=60979 Bug 10382 - Course reserves: handle empty values Review of attachment 60979: --> (https://bugs.koha-community.org/bugzilla3/page.cgi?id=splinter.html&bug=10382&attachment=60979) ----------------------------------------------------------------- ::: installer/data/mysql/atomicupdate/bug_10382-changes-on-courseitems-table.sql @@ +1,4 @@ > +ALTER TABLE course_items DROP FOREIGN KEY course_items_ibfk_2; > +ALTER TABLE course_items MODIFY itype VARCHAR(20); > +ALTER TABLE course_items MODIFY ccode VARCHAR(20); > +ALTER TABLE course_items MODIFY holdingbranch VARCHAR(20); \ No newline at end of file Why drop the foreign key completely? Shouldn't the key be recreated? -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Mar 10 20:10:05 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 10 Mar 2017 19:10:05 +0000 Subject: [Koha-bugs] [Bug 16116] Change of issue publication date doesn' t reflect on the next issue generated In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16116 Bouzid changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #58265|0 |1 is obsolete| | Attachment #58266|0 |1 is obsolete| | --- Comment #6 from Bouzid --- Created attachment 61002 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=61002&action=edit Bug 16116 - Fix problem change of issue publication date doesn't reflect on the next issue generated Test plan : 1. In Cataloging > New with Z39.50, look for issn = 1536-6596 (National Geographic) into the LCC z39.60 server. Add the record. 2. Add a new subscription for National Geographic. Fill-in the form. - use the default values of the first page - for the second page : First issue publication date = 10/01/2016 Frequency = 1/month Subscription lenght = 12 issues Subscription start date = 01/01/2016 Numbering pattern = Number Begins with = 1 - Save 3. Receive the first issue. Change the status to "received". Note that the "Published on" date = 10/01/2016. This date goes to the "Date published" column in the serial collection page. 4. The second issue is generated. Edit serial to receive the issue. 5. Change the "Published on" date to 14/02/2016. Change the status to "received". Save. 6. "Date published" for the next issue generated is : 14/03/2016. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Mar 10 20:11:50 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 10 Mar 2017 19:11:50 +0000 Subject: [Koha-bugs] [Bug 16116] Change of issue publication date doesn' t reflect on the next issue generated In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16116 --- Comment #7 from Bouzid --- Hi All, I deteted patch unit test because it test a local sub. Thanks -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Mar 10 20:42:26 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 10 Mar 2017 19:42:26 +0000 Subject: [Koha-bugs] [Bug 18215] Resolve warning on $tls in Database.pm In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18215 M. Tompsett changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |mtompset at hotmail.com --- Comment #8 from M. Tompsett --- The problem is that kohastructures.sql is LACKING a TLS. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Mar 10 20:56:07 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 10 Mar 2017 19:56:07 +0000 Subject: [Koha-bugs] [Bug 18245] New: debian/templates/koha-conf-site.xml.in missing tls Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18245 Bug ID: 18245 Summary: debian/templates/koha-conf-site.xml.in missing tls Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Architecture, internals, and plumbing Assignee: gmcharlt at gmail.com Reporter: mtompset at hotmail.com QA Contact: testopia at bugs.koha-community.org As noted by Marcel in https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15427#c17 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Mar 10 20:56:40 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 10 Mar 2017 19:56:40 +0000 Subject: [Koha-bugs] [Bug 17346] Enable the check in option in Columns settings In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17346 --- Comment #2 from Christopher Brannon --- Created attachment 61003 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=61003&action=edit Bug 17346: Make checkin column hidable -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Mar 10 20:59:43 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 10 Mar 2017 19:59:43 +0000 Subject: [Koha-bugs] [Bug 18245] debian/templates/koha-conf-site.xml.in missing tls In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18245 M. Tompsett changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Mar 10 20:59:45 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 10 Mar 2017 19:59:45 +0000 Subject: [Koha-bugs] [Bug 18245] debian/templates/koha-conf-site.xml.in missing tls In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18245 --- Comment #1 from M. Tompsett --- Created attachment 61004 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=61004&action=edit Bug 18245: Add missing TLS to debian/templates/koha-conf-site.xml.in This was found as a result of testing another bug. Added missing line. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Mar 10 21:00:14 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 10 Mar 2017 20:00:14 +0000 Subject: [Koha-bugs] [Bug 18245] debian/templates/koha-conf-site.xml.in missing tls In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18245 M. Tompsett changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |https://bugs.koha-community | |.org/bugzilla3/show_bug.cgi | |?id=15427 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Mar 10 21:00:14 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 10 Mar 2017 20:00:14 +0000 Subject: [Koha-bugs] [Bug 15427] Allow db connections using TLS In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15427 M. Tompsett changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |https://bugs.koha-community | |.org/bugzilla3/show_bug.cgi | |?id=18245 --- Comment #18 from M. Tompsett --- (In reply to Marcel de Rooy from comment #17) > Note: tls is not found in debian/templates/koha-conf-site.xml.in See bug 18245. :) -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Mar 10 21:00:24 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 10 Mar 2017 20:00:24 +0000 Subject: [Koha-bugs] [Bug 17346] Enable the check in option in Columns settings In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17346 Christopher Brannon changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |cbrannon at cdalibrary.org Status|NEW |Needs Signoff --- Comment #3 from Christopher Brannon --- Hope you don't mind. I took the liberty to write the patch. To test: 1) Go to columns_settings.pl --> Circulation --> issues-table and note that you cannot change the settings for checkin. 2) Go to columns_settings.pl --> Patrons --> issues-table and note that you cannot change the settings for checkin. 3) Apply the patch. 4) Go to both tables again and note that you can now change the settings. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Mar 10 21:06:56 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 10 Mar 2017 20:06:56 +0000 Subject: [Koha-bugs] [Bug 18215] Resolve warning on $tls in Database.pm In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18215 --- Comment #9 from M. Tompsett --- Created attachment 61005 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=61005&action=edit Bug 18215: Third case which was missed. Git install old-school style a pre-tls koha Drop the DB Create the DB change branch to master Run a web install. NOTE: found with git grep "['\"]tls['\"]" -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Mar 10 21:46:33 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 10 Mar 2017 20:46:33 +0000 Subject: [Koha-bugs] [Bug 17015] New Koha Calendar In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17015 --- Comment #58 from Mehdi Hamidi --- Hello everyone, here's a link to our screencast : https://www.youtube.com/watch?v=QLxE9ToRJgE Feel free to leave us feedback! -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Fri Mar 10 22:24:08 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 10 Mar 2017 21:24:08 +0000 Subject: [Koha-bugs] [Bug 18185] Clears loan history In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18185 J Schmidt changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |jschmidt at switchinc.org --- Comment #15 from J Schmidt --- Can I ask what is the starting Koha version that's impacted by this bug? 16.05 or earlier? 16.11? thank you. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Mar 10 22:41:27 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 10 Mar 2017 21:41:27 +0000 Subject: [Koha-bugs] [Bug 18003] Should deletedborrowers.borrowernumber be a primary key? In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18003 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |https://bugs.koha-community | |.org/bugzilla3/show_bug.cgi | |?id=18242 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Mar 10 22:41:27 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 10 Mar 2017 21:41:27 +0000 Subject: [Koha-bugs] [Bug 18242] Remove primary key on old_issues.issue_id In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18242 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |https://bugs.koha-community | |.org/bugzilla3/show_bug.cgi | |?id=18003 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Mar 10 22:46:26 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 10 Mar 2017 21:46:26 +0000 Subject: [Koha-bugs] [Bug 18185] Clears loan history In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18185 --- Comment #16 from Jonathan Druart --- (In reply to J Schmidt from comment #15) > Can I ask what is the starting Koha version that's impacted by this bug? > 16.05 or earlier? 16.11? thank you. This bug impacts all Koha versions, but only in very specific cases. Basically it happens if you restart the DBMS and that the last item that has been checked out is checked in. In that case the auto increment value of the issue table become lower than the max value of old_issues.issue_id After the restart, the next issue will get an issue_id that already exists in the old_issues table. When this issue will be checked in and moved to the old_issue table, the copy of the data to the old_issues table will fail and the row will be deleted from the issues table => data are lost! -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Fri Mar 10 22:46:49 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 10 Mar 2017 21:46:49 +0000 Subject: [Koha-bugs] [Bug 18185] Clears loan history In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18185 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #60966|0 |1 is obsolete| | -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Mar 10 22:46:51 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 10 Mar 2017 21:46:51 +0000 Subject: [Koha-bugs] [Bug 18185] Clears loan history In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18185 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #60967|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Fri Mar 10 22:46:52 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 10 Mar 2017 21:46:52 +0000 Subject: [Koha-bugs] [Bug 18185] Clears loan history In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18185 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #60968|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Fri Mar 10 23:59:58 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 10 Mar 2017 22:59:58 +0000 Subject: [Koha-bugs] [Bug 18212] Move SQL code from aqplan.pl administrative script into a C4 perl module In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18212 --- Comment #1 from Alex Buckley --- Created attachment 61006 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=61006&action=edit Bug 18212 - Created a subroutine GetAuthValuesForCategory() in C4/Acqusition.pm perl module. I've removed one sql select query from aqplan.pl and rewritten it in DBIx query format in the new GetAuthValuesForCategory subroutine. aqplan.pl is successfully calling and running this DBIx query -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Mar 11 00:00:45 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 10 Mar 2017 23:00:45 +0000 Subject: [Koha-bugs] [Bug 18212] Move SQL code from aqplan.pl administrative script into a C4 perl module In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18212 --- Comment #2 from Alex Buckley --- Created attachment 61007 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=61007&action=edit Bug 18212 - Moved all sql queries out aqplan.pl into Koha::Libraries.pm, Koha::ItemType.pm, Koha::AuthorisedValue.pm files The new subroutines in the perl modules contain POD -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Mar 11 00:01:28 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 10 Mar 2017 23:01:28 +0000 Subject: [Koha-bugs] [Bug 18212] Move SQL code from aqplan.pl administrative script into a C4 perl module In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18212 --- Comment #3 from Alex Buckley --- Created attachment 61008 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=61008&action=edit Bug 18212 - Added a successful unit test for GetAuthValues() function -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Mar 11 00:01:56 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 10 Mar 2017 23:01:56 +0000 Subject: [Koha-bugs] [Bug 18212] Move SQL code from aqplan.pl administrative script into a C4 perl module In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18212 --- Comment #4 from Alex Buckley --- Created attachment 61009 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=61009&action=edit Bug 18212 - Four successfully transferred sql queries to Koha::AuthorisedValue, Koha::ItemType, Koha::Libraries from aqplan.pl administrative script All these queries have been placed inside subroutines in the perl modules outlined above, each subroutine has POD, and a successful unit test -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Mar 11 00:21:30 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 10 Mar 2017 23:21:30 +0000 Subject: [Koha-bugs] [Bug 18212] Move SQL code from aqplan.pl administrative script into a C4 perl module In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18212 Alex Buckley changed: What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |Needs Signoff --- Comment #5 from Alex Buckley --- Test plan: 1. Restart memcached: sudo service memcached restart 2. Drop and recreate the Koha instance database 3. Go through the web installer, selecting all data to be installed in step 3 4. After the web installer is finished log in with the Koha database administrator credentials 5. Create yourself a patron account 6. Set the patron account to have superlibrarian privileges 7. Log out and back in as your newly created patron 8. Navigate to the Acquisitions interface 9. Create a budget named 'testbudget' 10. Create a fund named 'testfund' 11. Navigate to the 'Administrator' interface 12. Write in the URL 'cgi-bin/koha/admin/aqplan.pl' 13. There should be no records showing 14. If you click on Planning->Plan by Months testfund will be displayed 15. Repeat step 14 but click on Planning->Plan by libraries and Planning->Plan by Itemtypes, Both of these pages should also show 'testfund' 16. In your terminal navigate from your Koha instance root directory to t/db_dependent 17. Enter koha shell: sudo koha-shell 18. Run AuthorisedValues unit tests: prove -v AuthorisedValues.t 19. The tests should run successful 20. Exit the koha shell 21. cd into the 'koha' directory from where you are 22. Enter the koha shell and run the ItemTypes.t and Libraries.t unit tests by writing in: prove -v filename.t (both of which should be successful) -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Mar 11 01:28:34 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 11 Mar 2017 00:28:34 +0000 Subject: [Koha-bugs] [Bug 18132] Confirming a hold/transfer clears checkin history In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18132 --- Comment #2 from Nick Clemens --- Ah, yes, confirming a hold doesn't trigger it seems But cancelling a transfer still triggers this issue. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Mar 11 14:01:50 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 11 Mar 2017 13:01:50 +0000 Subject: [Koha-bugs] [Bug 17785] oai.pl returns wrong URLs under Plack In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17785 Steven F. Schmieder changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |steven.schmieder at gmail.com --- Comment #8 from Steven F. Schmieder --- I am having a similar problem that does appear to have been solved by the patch. I running Debian Stretch RC2 with perl 5.24.1 and Koha 16.11.04. Everythings works fine except the oai.pl script which returns an "internal server message". As far as I can ascertain, the other scripts run fine. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Mar 11 17:03:57 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 11 Mar 2017 16:03:57 +0000 Subject: [Koha-bugs] [Bug 8603] Patron card creator - 'Barcode Type' doesn't stick in layouts In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8603 Marc V?ron changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |veron at veron.ch -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Mar 11 17:21:34 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 11 Mar 2017 16:21:34 +0000 Subject: [Koha-bugs] [Bug 8603] Patron card creator - 'Barcode Type' doesn't stick in layouts In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8603 --- Comment #1 from Marc V?ron --- Created attachment 61010 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=61010&action=edit Bug 8603: Patron card creator - 'Barcode Type' doesn't stick in layouts To reproduce: 1. Make a new layout 2. Tick "Print card number as barcode" 3. Change 'Barcode Type' to anything other than Code39 4. Save 5. Edit it again 6. Its back to Code39 To test: 1. Apply patch 2. Repeat steps above 3. Verify that 'Barcode type' is selected as expected -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Mar 11 17:22:33 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 11 Mar 2017 16:22:33 +0000 Subject: [Koha-bugs] [Bug 8603] Patron card creator - 'Barcode Type' doesn't stick in layouts In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8603 Marc V?ron changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff Patch complexity|--- |Small patch Assignee|cnighswonger at foundations.ed |veron at veron.ch |u | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Mar 11 19:15:56 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 11 Mar 2017 18:15:56 +0000 Subject: [Koha-bugs] [Bug 18246] New: Patron card creator: Unit not always displays properly in layouts Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18246 Bug ID: 18246 Summary: Patron card creator: Unit not always displays properly in layouts Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: normal Priority: P5 - low Component: Label/patron card printing Assignee: cnighswonger at foundations.edu Reporter: veron at veron.ch QA Contact: testopia at bugs.koha-community.org To reproduce: 1) Create a new layout 2) Select an unit in "Units selection" 3) Save 4) Edit layout again 5) Select other unit, e.g. 'SI Centimeter' 6) Save 7) Repeat 8) Edit again Error: Latest unit seems to stick and can no longer be changed, because in units drop down, multiple untis are marked as selected. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Mar 11 19:16:26 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 11 Mar 2017 18:16:26 +0000 Subject: [Koha-bugs] [Bug 18246] Patron card creator: Unit not always displays properly in layouts In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18246 Marc V?ron changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on| |8603 Assignee|cnighswonger at foundations.ed |veron at veron.ch |u | Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8603 [Bug 8603] Patron card creator - 'Barcode Type' doesn't stick in layouts -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Mar 11 19:16:26 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 11 Mar 2017 18:16:26 +0000 Subject: [Koha-bugs] [Bug 8603] Patron card creator - 'Barcode Type' doesn't stick in layouts In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8603 Marc V?ron changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |18246 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18246 [Bug 18246] Patron card creator: Unit not always displays properly in layouts -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Mar 11 19:19:34 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 11 Mar 2017 18:19:34 +0000 Subject: [Koha-bugs] [Bug 18246] Patron card creator: Unit not always displays properly in layouts In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18246 --- Comment #1 from Marc V?ron --- Created attachment 61011 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=61011&action=edit Bug 18246: Patron card creator: Unit not always displays properly in layouts To reproduce: 1) Create a new layout 2) Select an unit in "Units selection" 3) Save 4) Edit layout again 5) Select other unit, e.g. 'SI Centimeter' 6) Save 7) Repeat 8) Edit again Error: Latest unit seems to stick and can no longer be changed, because in units drop down, multiple untis are marked as selected. To test: 1) Apply patch 2) Repeat steps above, verify that value for units always display as expected. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Mar 11 19:33:26 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 11 Mar 2017 18:33:26 +0000 Subject: [Koha-bugs] [Bug 18246] Patron card creator: Unit not always displays properly in layouts In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18246 Marc V?ron changed: What |Removed |Added ---------------------------------------------------------------------------- Patch complexity|--- |Trivial patch Status|NEW |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Mar 11 19:53:25 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 11 Mar 2017 18:53:25 +0000 Subject: [Koha-bugs] [Bug 17346] Enable the check in option in Columns settings In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17346 Marc V?ron changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #61003|0 |1 is obsolete| | --- Comment #4 from Marc V?ron --- Created attachment 61012 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=61012&action=edit Bug 17346: Make checkin column hidable To test: 1) Go to columns_settings.pl --> Circulation --> issues-table and note that you cannot change the settings for checkin. 2) Go to columns_settings.pl --> Patrons --> issues-table and note that you cannot change the settings for checkin. 3) Apply the patch. 4) Go to both tables again and note that you can now change the settings. Followed test plan, works as expected. Signed-off-by: Marc V?ron -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Mar 11 19:55:16 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 11 Mar 2017 18:55:16 +0000 Subject: [Koha-bugs] [Bug 17346] Enable the check in option in Columns settings In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17346 Marc V?ron changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|T.Reimann95 at gmx.de |cbrannon at cdalibrary.org CC| |veron at veron.ch Status|Needs Signoff |Signed Off Patch complexity|--- |Trivial patch -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Mar 11 20:02:28 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 11 Mar 2017 19:02:28 +0000 Subject: [Koha-bugs] [Bug 14366] Units doesn't get saved usefully for patroncards In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14366 Marc V?ron changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |https://bugs.koha-community | |.org/bugzilla3/show_bug.cgi | |?id=18246 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Mar 11 20:02:28 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 11 Mar 2017 19:02:28 +0000 Subject: [Koha-bugs] [Bug 18246] Patron card creator: Unit not always displays properly in layouts In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18246 Marc V?ron changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |https://bugs.koha-community | |.org/bugzilla3/show_bug.cgi | |?id=14366 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Mar 11 20:05:07 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 11 Mar 2017 19:05:07 +0000 Subject: [Koha-bugs] [Bug 18246] Patron card creator: Unit not always displays properly in layouts In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18246 Marc V?ron changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |https://bugs.koha-community | |.org/bugzilla3/show_bug.cgi | |?id=8602 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Mar 11 20:05:07 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 11 Mar 2017 19:05:07 +0000 Subject: [Koha-bugs] [Bug 8602] Patron card creator - 'Units' don't stick in layouts In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8602 Marc V?ron changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |https://bugs.koha-community | |.org/bugzilla3/show_bug.cgi | |?id=18246 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Mar 11 20:06:09 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 11 Mar 2017 19:06:09 +0000 Subject: [Koha-bugs] [Bug 18246] Patron card creator: Units not always display properly in layouts In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18246 Marc V?ron changed: What |Removed |Added ---------------------------------------------------------------------------- Summary|Patron card creator: Unit |Patron card creator: Units |not always displays |not always display properly |properly in layouts |in layouts -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Mar 11 20:08:30 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 11 Mar 2017 19:08:30 +0000 Subject: [Koha-bugs] [Bug 5181] Add js to convert units when units are changed on label or card template form In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5181 Marc V?ron changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |veron at veron.ch -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Mar 11 20:44:22 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 11 Mar 2017 19:44:22 +0000 Subject: [Koha-bugs] [Bug 5770] email librarian when purchase suggestion made In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5770 Marc V?ron changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |veron at veron.ch -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Mar 11 20:48:08 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 11 Mar 2017 19:48:08 +0000 Subject: [Koha-bugs] [Bug 14376] Allow the librarian to choose a patron when entering a purchase suggestion In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14376 Marc V?ron changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |veron at veron.ch -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Mar 11 20:58:42 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 11 Mar 2017 19:58:42 +0000 Subject: [Koha-bugs] [Bug 14973] Suggestions - Search and warn user about existing biblio when submitting a suggestion In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14973 Marc V?ron changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |https://bugs.koha-community | |.org/bugzilla3/show_bug.cgi | |?id=6813 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Mar 11 20:58:42 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 11 Mar 2017 19:58:42 +0000 Subject: [Koha-bugs] [Bug 6813] Acquistions - duplicate search across orders, suggestions and catalog In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6813 Marc V?ron changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |https://bugs.koha-community | |.org/bugzilla3/show_bug.cgi | |?id=14973 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Mar 11 21:02:14 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 11 Mar 2017 20:02:14 +0000 Subject: [Koha-bugs] [Bug 12349] patron name on suggestions should be linked In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12349 Marc V?ron changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |veron at veron.ch -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Mar 11 21:04:38 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 11 Mar 2017 20:04:38 +0000 Subject: [Koha-bugs] [Bug 10568] way to vote for purchase suggestions In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10568 Marc V?ron changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |veron at veron.ch -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Mar 11 21:05:50 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 11 Mar 2017 20:05:50 +0000 Subject: [Koha-bugs] [Bug 9851] way to get full records for purchase suggestions In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9851 Marc V?ron changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |veron at veron.ch -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Mar 11 21:06:19 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 11 Mar 2017 20:06:19 +0000 Subject: [Koha-bugs] [Bug 9776] transfering a suggestion to an other librarian In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9776 Marc V?ron changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |veron at veron.ch -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Mar 11 21:11:18 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 11 Mar 2017 20:11:18 +0000 Subject: [Koha-bugs] [Bug 15248] Improve FindDuplicate In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15248 Marc V?ron changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |veron at veron.ch -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Mar 11 21:13:22 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 11 Mar 2017 20:13:22 +0000 Subject: [Koha-bugs] [Bug 8325] autofill tags in the opac In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8325 Marc V?ron changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |veron at veron.ch -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Mar 11 21:14:01 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 11 Mar 2017 20:14:01 +0000 Subject: [Koha-bugs] [Bug 5993] tags not searchable In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5993 Marc V?ron changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |veron at veron.ch -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Mar 11 21:15:36 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 11 Mar 2017 20:15:36 +0000 Subject: [Koha-bugs] [Bug 5535] Show the logged-in user' s unapproved tags on search results and detail pages In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5535 Marc V?ron changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |veron at veron.ch -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Mar 11 21:33:57 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 11 Mar 2017 20:33:57 +0000 Subject: [Koha-bugs] [Bug 10267] No error message when entering an invalid cardnumber In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10267 Marc V?ron changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |veron at veron.ch -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Mar 11 21:37:29 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 11 Mar 2017 20:37:29 +0000 Subject: [Koha-bugs] [Bug 11251] Be able to configure HTML Opac preferences per library In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11251 Marc V?ron changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |veron at veron.ch -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Mar 11 21:38:21 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 11 Mar 2017 20:38:21 +0000 Subject: [Koha-bugs] [Bug 9999] Reconstruct pref values via action_logs In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9999 Marc V?ron changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |veron at veron.ch -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Mar 11 21:41:15 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 11 Mar 2017 20:41:15 +0000 Subject: [Koha-bugs] [Bug 15297] Patron registration default date In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15297 Marc V?ron changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |veron at veron.ch -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Mar 11 21:41:55 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 11 Mar 2017 20:41:55 +0000 Subject: [Koha-bugs] [Bug 14615] Staff cart email doesn' t include a link back to the staff client In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14615 Marc V?ron changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |veron at veron.ch -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Mar 12 11:01:29 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 12 Mar 2017 10:01:29 +0000 Subject: [Koha-bugs] [Bug 18247] New: Remove SQL queries from branch_transfer_limit.pl administrative script Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18247 Bug ID: 18247 Summary: Remove SQL queries from branch_transfer_limit.pl administrative script Change sponsored?: --- Product: Koha Version: 17.05 Hardware: All OS: All Status: ASSIGNED Severity: enhancement Priority: P5 - low Component: Architecture, internals, and plumbing Assignee: alexbuckley at catalyst.net.nz Reporter: alexbuckley at catalyst.net.nz QA Contact: testopia at bugs.koha-community.org This bug report requires all three SQL queries to be removed from branch_transfer_limit.pl administrative script and placed into suitable perl modules in the Koha or C4 directory. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Mar 12 11:32:36 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 12 Mar 2017 10:32:36 +0000 Subject: [Koha-bugs] [Bug 17519] Item editor handles clearing dateaccessioned and replacementpricedate inconsistently In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17519 Marc V?ron changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #56984|0 |1 is obsolete| | --- Comment #2 from Marc V?ron --- Created attachment 61013 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=61013&action=edit Bug 17519: Item editor handles clearing dateaccessioned and replacementpricedate inconsistently This patch adds dateaccessioned to the hash built by Items routine _build_default_values_for_mod_marc, used in ModItemFromMarc when modifying an item. Normally, dateaccessioned will already have a value, and this change has no effect. The only exception is: when you modify an item and for some reason want to clear the dateaccessioned field, the item editor did not respond to that change. This change makes it possible to do so. This is consistent with the other date in the item editor (replacementpricedate) where you can already clear the date. Test plan: [1] Do not yet apply this patch. [2] Try to clear date acquired and replacementpricedate in the Item editor. Save and check results. You should still find the original date acquired in the saved record. [3] Apply the patch (restart Plack?), restore replacementpricedate, and repeat step 2. Both dates should be cleared. Followed test plan, date acquired can be deleted as expected. Signed-off-by: Marc V?ron -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Mar 12 11:32:52 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 12 Mar 2017 10:32:52 +0000 Subject: [Koha-bugs] [Bug 17519] Item editor handles clearing dateaccessioned and replacementpricedate inconsistently In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17519 Marc V?ron changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |veron at veron.ch Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Mar 12 11:42:28 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 12 Mar 2017 10:42:28 +0000 Subject: [Koha-bugs] [Bug 17483] Forgiving charge should apply to item's last fine. In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17483 Marc V?ron changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |veron at veron.ch -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Mar 12 13:24:14 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 12 Mar 2017 12:24:14 +0000 Subject: [Koha-bugs] [Bug 18247] Remove SQL queries from branch_transfer_limit.pl administrative script In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18247 --- Comment #1 from Alex Buckley --- Created attachment 61014 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=61014&action=edit Bug 18247 - Moved the SQL queries out of the branch_transfer_limits.pl script into the Koha::AuthorisedValue, Koha::Libraries, Koha::ItemType perl modules All the queries run successfully in the perl modules. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Mar 12 13:24:50 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 12 Mar 2017 12:24:50 +0000 Subject: [Koha-bugs] [Bug 18247] Remove SQL queries from branch_transfer_limit.pl administrative script In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18247 --- Comment #2 from Alex Buckley --- Created attachment 61015 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=61015&action=edit Bug 18247 - Added 3 successfully working unit tests for each new subroutine -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Mar 12 13:29:52 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 12 Mar 2017 12:29:52 +0000 Subject: [Koha-bugs] [Bug 18212] Move SQL code from aqplan.pl administrative script into a C4 perl module In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18212 --- Comment #6 from Alex Buckley --- Amended Test plan: 1. Apply all the patches attached to this bug report 2. Restart memcached: sudo service memcached restart 3. Drop and recreate the Koha instance database 4. Go through the web installer, selecting all data to be installed in step 3 5. After the web installer is finished log in with the Koha database administrator credentials 6. Create yourself a patron account 7. Set the patron account to have superlibrarian privileges 8. Log out and back in as your newly created patron 9. Navigate to the Acquisitions interface 10. Create a budget named 'testbudget' 11. Create a fund named 'testfund' 12. Navigate to the 'Administrator' interface 13. Write in the URL 'cgi-bin/koha/admin/aqplan.pl' 14. There should be no records showing 15. If you click on Planning->Plan by Months testfund will be displayed 16. Repeat step 14 but click on Planning->Plan by libraries and Planning->Plan by Itemtypes, Both of these pages should also show 'testfund' 17. In your terminal navigate from your Koha instance root directory to t/db_dependent 18. Enter koha shell: sudo koha-shell 19. Run AuthorisedValues unit tests: prove -v AuthorisedValues.t 20. The tests should run successful 21. Exit the koha shell 22. cd into the 'koha' directory from where you are 23. Enter the koha shell and run the ItemTypes.t and Libraries.t unit tests by writing in: prove -v filename.t (both of which should be successful) -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Mar 12 13:35:20 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 12 Mar 2017 12:35:20 +0000 Subject: [Koha-bugs] [Bug 18247] Remove SQL queries from branch_transfer_limit.pl administrative script In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18247 Alex Buckley changed: What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |Needs Signoff --- Comment #3 from Alex Buckley --- Test plan: 1. Restart memcached: sudo service memcached restart 2. Drop and recreate the Koha instance database 3. Go through the web installer, selecting all data to be installed in step 3 of the web installer 4. After the web installer is finished log in with the Koha database administrator credentials 5. Create yourself a patron account 6. Set the patron account to have superlibrarian privileges 7. Log out and back in as your newly created patron 8. Navigate to the Administrator interface and type in the url: cgi-bin/koha/admin/branch_transfer_limits.pl 9. Observe the list of default installed libraries displayed 10. Change the url to cgi-bin/koha/admin/branch_transfer_limits.pl?limitType=ccode 11. Observe the same list of libraries is displayed 12. Apply all the patches attached to this bug report 13. Repeat steps 1 through to 11 observing that all the libraries in the list are still visible with the patches applied when repeating steps 9 and 11 14. In your terminal navigate from your Koha instance root directory to t/db_dependent 15. Enter koha shell: sudo koha-shell 16. Run AuthorisedValues unit tests: prove -v AuthorisedValues.t 17. The tests should run successful 18. Exit the koha shell 19. cd into the 'Koha' directory from where you are 20. Enter the koha shell and run the ItemTypes.t and Libraries.t unit tests by writing in: prove -v filename.t (both of which should be successful) -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Mar 12 13:39:08 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 12 Mar 2017 12:39:08 +0000 Subject: [Koha-bugs] [Bug 18212] Move SQL code from aqplan.pl administrative script into Koha directory perl modules In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18212 Alex Buckley changed: What |Removed |Added ---------------------------------------------------------------------------- Summary|Move SQL code from |Move SQL code from |aqplan.pl administrative |aqplan.pl administrative |script into a C4 perl |script into Koha directory |module |perl modules -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Mar 12 21:32:09 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 12 Mar 2017 20:32:09 +0000 Subject: [Koha-bugs] [Bug 17505] REST API: Add route for messaging preferences In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17505 Mike changed: What |Removed |Added ---------------------------------------------------------------------------- QA Contact|testopia at bugs.koha-communit | |y.org | Assignee|lari.taskula at jns.fi |mail at jkozlovsky.cz CC| |black23 at gmail.com Jiri Kozlovsky changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |In Discussion --- Comment #1 from Jiri Kozlovsky --- Just to be clear about the implementation details .. For messaging preferences to work, there must be set EnhancedMessagingPreferences to Allow in order to let anyone change anything. This will ensure only staff can edit messaging preferences. For regular users to allow them editing those, EnhancedMessagingPreferencesOPAC must be also enabled. If is EnhancedMessagingPreferencesOPAC enabled, but EnhancedMessagingPreferences is not, no editing is allowed to anyone. API URL will be in this format: /api/v1/messaging_preferences/{borrowernumber} Next, I suppose, there will be GET & POST methods. No else. GET method only returns user's messaging prefs. User can view only it's own prefs, unless he has 'borrowers' rights. POST method updates user's messaging pref. User can update only it's own prefs, unless he has 'borrowers' rights. Both, GET & POST methods will send / receive JSON in this format: { item_due: { email: 0/1, digest_only: 0/1, do_not_notify: 0/1 } advance_notice: { days_in_advance: 0-30, email: 0/1, digest_only: 0/1, do_not_notify: 0/1 } hold_filled: { email: 0/1, do_not_notify: 0/1 } item_checkin: { email: 0/1, do_not_notify: 0/1 } item_checkout: { email: 0/1, do_not_notify: 0/1 } } Please someone take a look at this concept, if it is okay to implement this feature in this way. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Mar 12 21:37:22 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 12 Mar 2017 20:37:22 +0000 Subject: [Koha-bugs] [Bug 17005] REST API: add routes to list checkouts history In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17005 --- Comment #15 from Jiri Kozlovsky --- Someone please help me, I'm stuck in writing unit tests in kohadevbox. This is what I got returned from sample API partons.t: kohadev-koha at kohadevbox:/home/vagrant/kohaclone$ prove t/db_dependent/api/v1/patrons.t t/db_dependent/api/v1/patrons.t .. DBD::mysql::st execute failed: Unknown column 'overdrive_auth_token' in 'field list' [for Statement "INSERT INTO `borrowers` ( `B_address`, `B_address2`, `B_city`, `B_country`, `B_email`, `B_phone`, `B_state`, `B_streetnumber`, `B_streettype`, `B_zipcode`, `address`, `address2`, `altcontactaddress1`, `altcontactaddress2`, `altcontactaddress3`, `altcontactcountry`, `altcontactfirstname`, `altcontactphone`, `altcontactstate`, `altcontactsurname`, `altcontactzipcode`, `borrowernotes`, `branchcode`, `cardnumber`, `categorycode`, `checkprevcheckout`, `city`, `contactfirstname`, `contactname`, `contactnote`, `contacttitle`, `country`, `dateenrolled`, `dateexpiry`, `dateofbirth`, `debarred`, `debarredcomment`, `email`, `emailpro`, `fax`, `firstname`, `flags`, `gonenoaddress`, `guarantorid`, `initials`, `lastseen`, `lost`, `mobile`, `opacnote`, `othernames`, `overdrive_auth_token`, `password`, `phone`, `phonepro`, `privacy`, `privacy_guarantor_checkouts`, `relationship`, `sex`, `sms_provider_id`, `smsalertnumber`, `sort1`, `sort2`, `state`, `streetnumber`, `streettype`, `surname`, `title`, `updated_on`, `userid`, `zipcode`) VALUES ( ?, ?, ?, ?, ?, ?, ?, ?, ?, ?, ?, ?, ?, ?, ?, ?, ?, ?, ?, ?, ?, ?, ?, ?, ?, ?, ?, ?, ?, ?, ?, ?, ?, ?, ?, ?, ?, ?, ?, ?, ?, ?, ?, ?, ?, ?, ?, ?, ?, ?, ?, ?, ?, ?, ?, ?, ?, ?, ?, ?, ?, ?, ?, ?, ?, ?, ?, ?, ?, ? )" with ParamValues: 0='VjklbDmEmoWudPhpCWvz7rJAfEEmrCSjbnCf6S4v8DtGZjkCI7jaHoADwHWOGYysHLuBeMzYorwm3992o_UDF3YKUpGYgoPJ', 1='GZgOWb', 2='tSVrqQ8', 3='wk', 4='bNj', 5='BI2aSjf', 6='pTkX6zIVE', 7='BmMDX', 8='Df9lTEgMW770zsj6qMmgo90AcPmCZ2f5yxR2tHtd2W1', 9='NiPDa3Is5', 10='aMIrS', 11='o2fw2mw_gx', 12='QJ96zi10BKHjf45i7UI5qhWEwYcYH4iXBfH8pDeqlMV5xWg2eSyeXiBd0OIboV3mNVJffAKQ0u75wDpIY05H7Iqe3TIbHMUPQ5CoevT1eg87PlkSp6CxoZLKyEzRTNbZS88WKtrzDV6T3NJnn1yDEBfoQdM8zl7n9BYWS6oSacsGTXXJ1fFwiVuNN0GiiulwCC7nhzw5vCmF3eNNxVDj2LF92S22PbUi5pTEiClTLuTqa4zABSs2', 13='a9RpXJAOZTH81_8QUy0ufD0qF_dMHStD3yzzQIr9fcV4KCVRYT_GRsLp4O6iyMI2vHk2LARICmB3crQiA9HjJA4wM4LHfrKDfcUpRurK4R4sH4GS_LxvX', 14='w6f9XgdIm4fUDi1LAlxHlnv0k6bAWvnX_NA7OhYNeInF24CbCzLyOWcX0iyUWwYo1rjUOK4X5DC8zuqiWZdxLveQVOQWCTb0TwFP5bYXCvX0Y20eePvWShnkw3BVm8dnoo8pSvENIIBPsEcbj49uUtuxt_tgye45oX2vYGS75ICIWtjZB6fP8RN6e33SCtoIE4c0wiB68iG6Njs', 15='N', 16='L6xkGcRxTqabsrPIv296A_YUr_TYIn4k4U_p0ESh3iNPfxR2iAh2hVGHQLc8snQXsvjeKQ7Pca0gcp_k9DVhTPcXi3JvdErJ9UBI6SkvmYXxDI7RRI2rm2R4mOuMuf8PbcfAQdWjTbWFnCag', 17='xIn07_7bog', 18='t', 19='d25sJFVrJ6sqNW6o4jw0E76EZkC6w6zmX95Ixsa1yNqZ58zSrN63q1fqCpzTO4HDx0bGCxGXOXVpOTL9cvbaepJ6d_JjBDKUkGsJtfNd7bMlpAx0ypzNE9a3zmIQKw8_ZBeB4M0uk6RONs2t0Pe_MLGTTMP7', 20='Gm1Mgmb4dr5tTD30kXY0y', 21='F3wl', 22='Y6PWhl_UhS', 23='wkINA3tkWfTGo', 24='cR4nYYRnj', 25='ii9I', 26='xlZTwq8', 27='ThXks0vXrW', 28='jImAGNe', 29='YFQrtDRDCCQCLeYC7c_dErxY2Ol5F7InDZk3oEn41zMl2sN_AQxoNYZjqtOugdmSJzUx9HXmdutL45Js8ZUWvfelGTPvCfLdPDIZziX_hNBbVnmwHyXUIoZboIWusA7CZllwzA0TvC2zJ4gKx09v_p5Zu2_42msD0KskMdg4iFzCRl09e6IufqZvS9CJ4uRAA1x4hyUbdy', 30='Z_Fqh', 31='Oba', 32='2017-03-12', 33='2017-03-12', 34='2017-03-12', 35='2017-03-12', 36='Mwf1IB5_qAvR4Fm1Fg2JdqZ2YWofYwVcC5l4dwcnIit4fba2Yopjh5rxZh__Dqhz3yNiWRVzG0M90V2kVFZ0pNRVGpt6DqVqVuJpZrKz0PArDdo5Aept70lMR9mbRHLo6ydPMHVMJcf8NYSajFO1DtQ4JYaT_bRjtdj5Q6ftsOM2yZEME', 37='lHLdEMU', 38='szanHw_MI3q', 39='iXZmy', 40='hlQ0BFbYzW5', 41=0, 42=54, 43=1365868268, 44='uW', 45='2017-03-12 20:34:07', 46=108, 47='gUpy', 48='cfPPJnisWoT', 49='KJSvZZdrF', 50='qm8Xqtvkp', 51='CuaSVbZHRgPLRSM8o5kj', 52='RJJf2lN_m7y', 53='XgyQAVDu', 54=1483959990, 55=1, 56='DkqBG8ZnY3UdRnqDJhvuuW6nnxkFa7Ynp6le', 57='w', 58='4', 59='BpAvEd8VoHTlNcxMHobD', 60='y_7ohFg3sH2tV7LPRQHXZ2x39fdcflRNl_y9UFROZFwAg2stPmeolaYYEY8', 61='eqNIYiKKN0zqJWW_HXk3WZmTAiNjrdRFfiTRsli8X4hkhUkXxH1hcVj5gLV3dSIkX9uAp4l_pS89W63', 62='DWqrDgqkQW', 63='mKq', 64='z9apII7dgaGVu9', 65='Sqj', 66='WXReDMh', 67='2017-03-12 20:34:07', 68='zrG1UCYaWyq7Aq3eSUT8R6MW12jWL0', 69='IcdAqkr_KCQl_wJIErkLSP'] at /usr/share/perl5/DBIx/Class/Storage/DBI.pm line 1832. DBIx::Class::Storage::DBI::_execute(): DBD::mysql::st execute failed: Unknown column 'overdrive_auth_token' in 'field list' [for Statement "INSERT INTO `borrowers` ( `B_address`, `B_address2`, `B_city`, `B_country`, `B_email`, `B_phone`, `B_state`, `B_streetnumber`, `B_streettype`, `B_zipcode`, `address`, `address2`, `altcontactaddress1`, `altcontactaddress2`, `altcontactaddress3`, `altcontactcountry`, `altcontactfirstname`, `altcontactphone`, `altcontactstate`, `altcontactsurname`, `altcontactzipcode`, `borrowernotes`, `branchcode`, `cardnumber`, `categorycode`, `checkprevcheckout`, `city`, `contactfirstname`, `contactname`, `contactnote`, `contacttitle`, `country`, `dateenrolled`, `dateexpiry`, `dateofbirth`, `debarred`, `debarredcomment`, `email`, `emailpro`, `fax`, `firstname`, `flags`, `gonenoaddress`, `guarantorid`, `initials`, `lastseen`, `lost`, `mobile`, `opacnote`, `othernames`, `overdrive_auth_token`, `password`, `phone`, `phonepro`, `privacy`, `privacy_guarantor_checkouts`, `relationship`, `sex`, `sms_provider_id`, `smsalertnumber`, `sort1`, `sort2`, `state`, `streetnumber`, `streettype`, `surname`, `title`, `updated_on`, `userid`, `zipcode`) VALUES ( ?, ?, ?, ?, ?, ?, ?, ?, ?, ?, ?, ?, ?, ?, ?, ?, ?, ?, ?, ?, ?, ?, ?, ?, ?, ?, ?, ?, ?, ?, ?, ?, ?, ?, ?, ?, ?, ?, ?, ?, ?, ?, ?, ?, ?, ?, ?, ?, ?, ?, ?, ?, ?, ?, ?, ?, ?, ?, ?, ?, ?, ?, ?, ?, ?, ?, ?, ?, ?, ? )" with ParamValues: 0='VjklbDmEmoWudPhpCWvz7rJAfEEmrCSjbnCf6S4v8DtGZjkCI7jaHoADwHWOGYysHLuBeMzYorwm3992o_UDF3YKUpGYgoPJ', 1='GZgOWb', 2='tSVrqQ8', 3='wk', 4='bNj', 5='BI2aSjf', 6='pTkX6zIVE', 7='BmMDX', 8='Df9lTEgMW770zsj6qMmgo90AcPmCZ2f5yxR2tHtd2W1', 9='NiPDa3Is5', 10='aMIrS', 11='o2fw2mw_gx', 12='QJ96zi10BKHjf45i7UI5qhWEwYcYH4iXBfH8pDeqlMV5xWg2eSyeXiBd0OIboV3mNVJffAKQ0u75wDpIY05H7Iqe3TIbHMUPQ5CoevT1eg87PlkSp6CxoZLKyEzRTNbZS88WKtrzDV6T3NJnn1yDEBfoQdM8zl7n9BYWS6oSacsGTXXJ1fFwiVuNN0GiiulwCC7nhzw5vCmF3eNNxVDj2LF92S22PbUi5pTEiClTLuTqa4zABSs2', 13='a9RpXJAOZTH81_8QUy0ufD0qF_dMHStD3yzzQIr9fcV4KCVRYT_GRsLp4O6iyMI2vHk2LARICmB3crQiA9HjJA4wM4LHfrKDfcUpRurK4R4sH4GS_LxvX', 14='w6f9XgdIm4fUDi1LAlxHlnv0k6bAWvnX_NA7OhYNeInF24CbCzLyOWcX0iyUWwYo1rjUOK4X5DC8zuqiWZdxLveQVOQWCTb0TwFP5bYXCvX0Y20eePvWShnkw3BVm8dnoo8pSvENIIBPsEcbj49uUtuxt_tgye45oX2vYGS75ICIWtjZB6fP8RN6e33SCtoIE4c0wiB68iG6Njs', 15='N', 16='L6xkGcRxTqabsrPIv296A_YUr_TYIn4k4U_p0ESh3iNPfxR2iAh2hVGHQLc8snQXsvjeKQ7Pca0gcp_k9DVhTPcXi3JvdErJ9UBI6SkvmYXxDI7RRI2rm2R4mOuMuf8PbcfAQdWjTbWFnCag', 17='xIn07_7bog', 18='t', 19='d25sJFVrJ6sqNW6o4jw0E76EZkC6w6zmX95Ixsa1yNqZ58zSrN63q1fqCpzTO4HDx0bGCxGXOXVpOTL9cvbaepJ6d_JjBDKUkGsJtfNd7bMlpAx0ypzNE9a3zmIQKw8_ZBeB4M0uk6RONs2t0Pe_MLGTTMP7', 20='Gm1Mgmb4dr5tTD30kXY0y', 21='F3wl', 22='Y6PWhl_UhS', 23='wkINA3tkWfTGo', 24='cR4nYYRnj', 25='ii9I', 26='xlZTwq8', 27='ThXks0vXrW', 28='jImAGNe', 29='YFQrtDRDCCQCLeYC7c_dErxY2Ol5F7InDZk3oEn41zMl2sN_AQxoNYZjqtOugdmSJzUx9HXmdutL45Js8ZUWvfelGTPvCfLdPDIZziX_hNBbVnmwHyXUIoZboIWusA7CZllwzA0TvC2zJ4gKx09v_p5Zu2_42msD0KskMdg4iFzCRl09e6IufqZvS9CJ4uRAA1x4hyUbdy', 30='Z_Fqh', 31='Oba', 32='2017-03-12', 33='2017-03-12', 34='2017-03-12', 35='2017-03-12', 36='Mwf1IB5_qAvR4Fm1Fg2JdqZ2YWofYwVcC5l4dwcnIit4fba2Yopjh5rxZh__Dqhz3yNiWRVzG0M90V2kVFZ0pNRVGpt6DqVqVuJpZrKz0PArDdo5Aept70lMR9mbRHLo6ydPMHVMJcf8NYSajFO1DtQ4JYaT_bRjtdj5Q6ftsOM2yZEME', 37='lHLdEMU', 38='szanHw_MI3q', 39='iXZmy', 40='hlQ0BFbYzW5', 41=0, 42=54, 43=1365868268, 44='uW', 45='2017-03-12 20:34:07', 46=108, 47='gUpy', 48='cfPPJnisWoT', 49='KJSvZZdrF', 50='qm8Xqtvkp', 51='CuaSVbZHRgPLRSM8o5kj', 52='RJJf2lN_m7y', 53='XgyQAVDu', 54=1483959990, 55=1, 56='DkqBG8ZnY3UdRnqDJhvuuW6nnxkFa7Ynp6le', 57='w', 58='4', 59='BpAvEd8VoHTlNcxMHobD', 60='y_7ohFg3sH2tV7LPRQHXZ2x39fdcflRNl_y9UFROZFwAg2stPmeolaYYEY8', 61='eqNIYiKKN0zqJWW_HXk3WZmTAiNjrdRFfiTRsli8X4hkhUkXxH1hcVj5gLV3dSIkX9uAp4l_pS89W63', 62='DWqrDgqkQW', 63='mKq', 64='z9apII7dgaGVu9', 65='Sqj', 66='WXReDMh', 67='2017-03-12 20:34:07', 68='zrG1UCYaWyq7Aq3eSUT8R6MW12jWL0', 69='IcdAqkr_KCQl_wJIErkLSP'] at /usr/share/perl5/DBIx/Class/Storage/DBI.pm line 1832. at /home/vagrant/kohaclone/t/lib/TestBuilder.pm line 249 # Looks like your test exited with 255 before it could output anything. t/db_dependent/api/v1/patrons.t .. Dubious, test returned 255 (wstat 65280, 0xff00) Failed 21/21 subtests Test Summary Report ------------------- t/db_dependent/api/v1/patrons.t (Wstat: 65280 Tests: 0 Failed: 0) Non-zero exit status: 255 Parse errors: Bad plan. You planned 21 tests but ran 0. Files=1, Tests=0, 2 wallclock secs ( 0.02 usr 0.01 sys + 1.44 cusr 0.16 csys = 1.63 CPU) Result: FAIL I think it's obvious there is some problem with DB, but I have no idea what it could be about :( It's also obvious I cannot write any unit tests for this API because they would eventually fail from similar reason so I wouldn't see if they pass or no. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Mar 12 22:48:16 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 12 Mar 2017 21:48:16 +0000 Subject: [Koha-bugs] [Bug 17895] Small typo -'re-set' In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17895 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to Master |Pushed to Stable --- Comment #8 from Katrin Fischer --- This patch has been pushed to 16.11.x and will be in 16.11.05. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Mar 12 22:50:20 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 12 Mar 2017 21:50:20 +0000 Subject: [Koha-bugs] [Bug 17947] Searching my library first shows the branchcode by the search bar rather than branchname In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17947 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to Master |Pushed to Stable Severity|enhancement |normal --- Comment #11 from Katrin Fischer --- I've decided to backport this - I think showing the branch name is the correct thing, especially to users in the OPAC. This patch has been pushed to 16.11.x and will be in 16.11.05. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Mar 12 22:52:46 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 12 Mar 2017 21:52:46 +0000 Subject: [Koha-bugs] [Bug 16034] Integration with OverDrive Patron API In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16034 --- Comment #85 from Katrin Fischer --- This won't get ported back to 16.11.x as it is an enhancement. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Mar 12 22:59:01 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 12 Mar 2017 21:59:01 +0000 Subject: [Koha-bugs] [Bug 18248] New: Add missing patch from 17216 Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18248 Bug ID: 18248 Summary: Add missing patch from 17216 Change sponsored?: --- Product: Koha Version: 16.11 Hardware: All OS: All Status: NEW Severity: normal Priority: P5 - low Component: Architecture, internals, and plumbing Assignee: gmcharlt at gmail.com Reporter: katrin.fischer at bsz-bw.de QA Contact: testopia at bugs.koha-community.org Using this bug number in order to have a better release notes entry. http://git.koha-community.org/gitweb/?p=koha.git;a=commit;h=11bae489bc85a9463712c9caafd2caf7b63155d9 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Mar 12 23:00:24 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 12 Mar 2017 22:00:24 +0000 Subject: [Koha-bugs] [Bug 17216] Add a new table to store authorized value categories In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17216 --- Comment #106 from Katrin Fischer --- This changed an existing database entry - what about the installations that have already updated to 16.11.x? -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Mar 12 23:00:59 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 12 Mar 2017 22:00:59 +0000 Subject: [Koha-bugs] [Bug 17216] Add a new table to store authorized value categories In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17216 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |18248 --- Comment #107 from Katrin Fischer --- Please use bug 18248 for follow-ups! Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18248 [Bug 18248] Add missing patch from 17216 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Mar 12 23:00:59 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 12 Mar 2017 22:00:59 +0000 Subject: [Koha-bugs] [Bug 18248] Add missing patch from 17216 In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18248 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on| |17216 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17216 [Bug 17216] Add a new table to store authorized value categories -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Mar 12 23:02:30 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 12 Mar 2017 22:02:30 +0000 Subject: [Koha-bugs] [Bug 17216] Add a new table to store authorized value categories In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17216 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks|18248 | Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18248 [Bug 18248] Add missing patch from 17216 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Mar 12 23:02:30 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 12 Mar 2017 22:02:30 +0000 Subject: [Koha-bugs] [Bug 18248] Add missing patch from 17216 In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18248 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on|17216 | Status|NEW |Needs Signoff Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17216 [Bug 17216] Add a new table to store authorized value categories -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Mar 12 23:02:44 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 12 Mar 2017 22:02:44 +0000 Subject: [Koha-bugs] [Bug 18248] Add missing patch from 17216 In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18248 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Mar 12 23:02:51 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 12 Mar 2017 22:02:51 +0000 Subject: [Koha-bugs] [Bug 18248] Add missing patch from 17216 In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18248 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Mar 12 23:03:07 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 12 Mar 2017 22:03:07 +0000 Subject: [Koha-bugs] [Bug 18248] Add missing patch from 17216 In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18248 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to Stable Depends on| |17216 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17216 [Bug 17216] Add a new table to store authorized value categories -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Mar 12 23:03:07 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 12 Mar 2017 22:03:07 +0000 Subject: [Koha-bugs] [Bug 17216] Add a new table to store authorized value categories In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17216 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |18248 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18248 [Bug 18248] Add missing patch from 17216 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Mar 12 23:05:19 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 12 Mar 2017 22:05:19 +0000 Subject: [Koha-bugs] [Bug 17260] updatedatabase.pl fails on invalid entries in ENUM and BOOLEAN columns In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17260 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |katrin.fischer at bsz-bw.de --- Comment #13 from Katrin Fischer --- These patches have been pushed to 16.11.x and will be in 16.11.05. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Mar 12 23:12:48 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 12 Mar 2017 22:12:48 +0000 Subject: [Koha-bugs] [Bug 18248] Add missing patch from 17216 In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18248 --- Comment #1 from Katrin Fischer --- This patch has been pushed to 16.11.x and will be in 16.11.05. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Mar 12 23:13:09 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 12 Mar 2017 22:13:09 +0000 Subject: [Koha-bugs] [Bug 17260] updatedatabase.pl fails on invalid entries in ENUM and BOOLEAN columns In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17260 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to Master |Pushed to Stable --- Comment #14 from Katrin Fischer --- These patches have been pushed to 16.11.x and will be in 16.11.05. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Mar 12 23:26:14 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 12 Mar 2017 22:26:14 +0000 Subject: [Koha-bugs] [Bug 17941] CanBookBeRenewed is very inefficient/slow In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17941 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |katrin.fischer at bsz-bw.de --- Comment #40 from Katrin Fischer --- This seems to use some new constructs, is this safe for backporting to 16.11.x? -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Mar 12 23:27:19 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 12 Mar 2017 22:27:19 +0000 Subject: [Koha-bugs] [Bug 18160] Error when OverDriveCirculation not enabled In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18160 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |katrin.fischer at bsz-bw.de Status|Pushed to Master |RESOLVED Resolution|--- |FIXED --- Comment #15 from Katrin Fischer --- Depends on bug 16034 which is not in 16.11.x. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Mar 12 23:28:16 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 12 Mar 2017 22:28:16 +0000 Subject: [Koha-bugs] [Bug 17992] REST api: Cities controller should not use ->unblessed In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17992 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to Master |RESOLVED CC| |katrin.fischer at bsz-bw.de Resolution|--- |FIXED --- Comment #5 from Katrin Fischer --- Depends on bug 17932 which is not in 16.11.x. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Mar 12 23:32:57 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 12 Mar 2017 22:32:57 +0000 Subject: [Koha-bugs] [Bug 18087] Clarification on File type when using file of biblionumbers to export data In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18087 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to Master |Pushed to Stable CC| |katrin.fischer at bsz-bw.de --- Comment #22 from Katrin Fischer --- These patches have been pushed to 16.11.x and will be in 16.11.05. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Mar 12 23:48:39 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 12 Mar 2017 22:48:39 +0000 Subject: [Koha-bugs] [Bug 13968] Branch email hints are misleading In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13968 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to Master |Pushed to Stable --- Comment #11 from Katrin Fischer --- This patch has been pushed to 16.11.x and will be in 16.11.05. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Mar 12 23:50:43 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 12 Mar 2017 22:50:43 +0000 Subject: [Koha-bugs] [Bug 16966] Koha:: Patrons - Move GetBorrowersWithIssuesHistoryOlderThan to search_patrons_to_anonymise In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16966 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to Master |RESOLVED Resolution|--- |FIXED CC| |katrin.fischer at bsz-bw.de --- Comment #60 from Katrin Fischer --- This won't get ported back to 16.11.x as it is an enhancement. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Mar 12 23:50:44 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 12 Mar 2017 22:50:44 +0000 Subject: [Koha-bugs] [Bug 16846] Move patron related code to Koha::Patron In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16846 Bug 16846 depends on bug 16966, which changed state. Bug 16966 Summary: Koha::Patrons - Move GetBorrowersWithIssuesHistoryOlderThan to search_patrons_to_anonymise https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16966 What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to Master |RESOLVED Resolution|--- |FIXED -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Mar 12 23:50:44 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 12 Mar 2017 22:50:44 +0000 Subject: [Koha-bugs] [Bug 18169] Date like 2999 should not be used arbitrarily In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18169 Bug 18169 depends on bug 16966, which changed state. Bug 16966 Summary: Koha::Patrons - Move GetBorrowersWithIssuesHistoryOlderThan to search_patrons_to_anonymise https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16966 What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to Master |RESOLVED Resolution|--- |FIXED -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Mar 12 23:51:37 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 12 Mar 2017 22:51:37 +0000 Subject: [Koha-bugs] [Bug 17334] members-update.pl should show timestamp In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17334 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Resolution|--- |FIXED Status|Pushed to Master |RESOLVED CC| |katrin.fischer at bsz-bw.de --- Comment #17 from Katrin Fischer --- This won't get ported back to 16.11.x as it is an enhancement. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Mar 12 23:56:54 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 12 Mar 2017 22:56:54 +0000 Subject: [Koha-bugs] [Bug 17840] Add classes to internal and public notes in checkouts table In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17840 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to Master |Pushed to Stable Severity|enhancement |trivial --- Comment #14 from Katrin Fischer --- This is marked enh, but as the classes being empty before can be considered a bug and the change is very small, I have decided to push this small one. This patch has been pushed to 16.11.x and will be in 16.11.05. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Mar 12 23:57:54 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 12 Mar 2017 22:57:54 +0000 Subject: [Koha-bugs] [Bug 15545] Optionally make hold notes required when placing a hold ( via Koha::Plugin) In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15545 Bug 15545 depends on bug 18037, which changed state. Bug 18037 Summary: Hold notes template cleanup (from 15545) https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18037 What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to Master |RESOLVED Resolution|--- |FIXED -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Mar 12 23:57:53 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 12 Mar 2017 22:57:53 +0000 Subject: [Koha-bugs] [Bug 18037] Hold notes template cleanup (from 15545) In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18037 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Resolution|--- |FIXED Status|Pushed to Master |RESOLVED CC| |katrin.fischer at bsz-bw.de --- Comment #5 from Katrin Fischer --- This won't get ported back to 16.11.x as it is an enhancement. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Mar 12 23:58:32 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 12 Mar 2017 22:58:32 +0000 Subject: [Koha-bugs] [Bug 18070] Support clean removal of authority records In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18070 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to Master |RESOLVED CC| |katrin.fischer at bsz-bw.de Resolution|--- |FIXED --- Comment #33 from Katrin Fischer --- This won't get ported back to 16.11.x as it is an enhancement. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Mar 12 23:58:32 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 12 Mar 2017 22:58:32 +0000 Subject: [Koha-bugs] [Bug 9988] Leave larger authority merges to merge_authorities cronjob ( pref AuthorityMergeLimit) In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9988 Bug 9988 depends on bug 18070, which changed state. Bug 18070 Summary: Support clean removal of authority records https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18070 What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to Master |RESOLVED Resolution|--- |FIXED -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Mar 12 23:58:33 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 12 Mar 2017 22:58:33 +0000 Subject: [Koha-bugs] [Bug 17908] Authority merge omnibus In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17908 Bug 17908 depends on bug 18070, which changed state. Bug 18070 Summary: Support clean removal of authority records https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18070 What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to Master |RESOLVED Resolution|--- |FIXED -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Mar 12 23:58:35 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 12 Mar 2017 22:58:35 +0000 Subject: [Koha-bugs] [Bug 18071] Add new script update_authorities.pl In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18071 Bug 18071 depends on bug 18070, which changed state. Bug 18070 Summary: Support clean removal of authority records https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18070 What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to Master |RESOLVED Resolution|--- |FIXED -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Mar 12 23:59:18 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 12 Mar 2017 22:59:18 +0000 Subject: [Koha-bugs] [Bug 18108] Sorting by author in opac summary In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18108 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |katrin.fischer at bsz-bw.de Resolution|--- |FIXED Status|Pushed to Master |RESOLVED --- Comment #5 from Katrin Fischer --- This won't get ported back to 16.11.x as it is an enhancement. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Mar 13 00:01:04 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 12 Mar 2017 23:01:04 +0000 Subject: [Koha-bugs] [Bug 18122] Audio alerts: Add hint on where to enable sounds In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18122 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to Master |Pushed to Stable CC| |katrin.fischer at bsz-bw.de --- Comment #8 from Katrin Fischer --- Helpful string change - decided to push this although it's marked as enhancement. This patch has been pushed to 16.11.x and will be in 16.11.05. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Mar 13 00:01:38 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 12 Mar 2017 23:01:38 +0000 Subject: [Koha-bugs] [Bug 18169] Date like 2999 should not be used arbitrarily In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18169 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to Master |RESOLVED CC| |katrin.fischer at bsz-bw.de Resolution|--- |FIXED --- Comment #9 from Katrin Fischer --- This won't get ported back to 16.11.x as it is an enhancement. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Mar 13 00:02:22 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 12 Mar 2017 23:02:22 +0000 Subject: [Koha-bugs] [Bug 7663] batch add barcodes to a list In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7663 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Resolution|--- |FIXED Status|Pushed to Master |RESOLVED --- Comment #12 from Katrin Fischer --- This won't get ported back to 16.11.x as it is an enhancement. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Mar 13 00:03:04 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 12 Mar 2017 23:03:04 +0000 Subject: [Koha-bugs] [Bug 10978] redirect to basket list of a supplier after deleting a basket In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10978 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Resolution|--- |FIXED CC| |katrin.fischer at bsz-bw.de Status|Pushed to Master |RESOLVED --- Comment #11 from Katrin Fischer --- This won't get ported back to 16.11.x as it is an enhancement. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Mar 13 00:03:27 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 12 Mar 2017 23:03:27 +0000 Subject: [Koha-bugs] [Bug 14764] Add OPAC News branch selector In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14764 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to Master |Pushed to Stable --- Comment #49 from Katrin Fischer --- This won't get ported back to 16.11.x as it is an enhancement. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Mar 13 00:05:26 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 12 Mar 2017 23:05:26 +0000 Subject: [Koha-bugs] [Bug 15427] Allow db connections using TLS In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15427 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |katrin.fischer at bsz-bw.de --- Comment #19 from Katrin Fischer --- This won't get ported back to 16.11.x as it is an enhancement. Not changing status to Resolved Fixed as there is an unpushed follow-up on bug 18215. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Mar 13 00:05:50 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 12 Mar 2017 23:05:50 +0000 Subject: [Koha-bugs] [Bug 16530] Add a circ sidebar navigation menu In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16530 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to Master |RESOLVED Resolution|--- |FIXED --- Comment #19 from Katrin Fischer --- This won't get ported back to 16.11.x as it is an enhancement. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Mar 13 01:19:39 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 13 Mar 2017 00:19:39 +0000 Subject: [Koha-bugs] [Bug 16034] Integration with OverDrive Patron API In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16034 --- Comment #86 from Srdjan Jankovic --- > Did you also fix comment 80? Not sure. I was not getting it in the first place. But 18234 should address that. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Mar 13 02:44:10 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 13 Mar 2017 01:44:10 +0000 Subject: [Koha-bugs] [Bug 10662] Build OAI-PMH Harvesting Client In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10662 --- Comment #114 from David Cook --- (In reply to Eugene Espinoza from comment #113) > Hi David! Any update on this? I'm interested on this feature. Thanks! Still working on it but I hope to have something posted soon. Glad to hear you're interested! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Mar 13 04:45:03 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 13 Mar 2017 03:45:03 +0000 Subject: [Koha-bugs] [Bug 18249] New: Typo "resrerves" in en-NZ translation files Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18249 Bug ID: 18249 Summary: Typo "resrerves" in en-NZ translation files Change sponsored?: --- Product: Koha Version: unspecified Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Staff Client Assignee: koha-bugs at lists.koha-community.org Reporter: aleishaamohia at hotmail.com QA Contact: testopia at bugs.koha-community.org CC: gmcharlt at gmail.com -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Mon Mar 13 04:46:43 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 13 Mar 2017 03:46:43 +0000 Subject: [Koha-bugs] [Bug 18249] Typo "resrerves" in en-NZ translation files In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18249 Aleisha Amohia changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff Patch complexity|--- |String patch -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Mon Mar 13 04:46:46 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 13 Mar 2017 03:46:46 +0000 Subject: [Koha-bugs] [Bug 18249] Typo "resrerves" in en-NZ translation files In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18249 --- Comment #1 from Aleisha Amohia --- Created attachment 61016 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=61016&action=edit Bug 18249: Typo 'resrerves' in en-NZ translation file To test: 1) git grep "resrerves" 2) Notice typo 3) Apply patch 4) git grep "resrerves" 5) Typo should be gone Sponsored-by: Catalyst IT -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Mon Mar 13 08:40:31 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 13 Mar 2017 07:40:31 +0000 Subject: [Koha-bugs] [Bug 17519] Item editor handles clearing dateaccessioned and replacementpricedate inconsistently In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17519 --- Comment #3 from Marcel de Rooy --- (In reply to Marc V?ron from comment #2) > Signed-off-by: Marc V?ron Thanks! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Mar 13 08:51:59 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 13 Mar 2017 07:51:59 +0000 Subject: [Koha-bugs] [Bug 14608] HEA : add possibility of sharing usage statistics in Administration page and Web installer In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14608 --- Comment #39 from Marcel de Rooy --- (In reply to Jonathan Druart from comment #38) > (In reply to Marcel de Rooy from comment #37) > > Please move the countries somewhere else :) > > I do not know what you mean, it's how it is done in > admin/preferences/admin.pref > I know it is not ideal to have that list in 2 places, but it will not be > easy to centralise it. > I would prefer to deal with that on another bug report, unless you have > something easy to suggest? We could start with putting the country list of this report in a general include file. Removing the list from admin.pref yaml file is for another report. (We should probably load them from the general include and insert them into admin/preferences.pl somewhere. Yaml cannot include files..) -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Mar 13 08:53:44 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 13 Mar 2017 07:53:44 +0000 Subject: [Koha-bugs] [Bug 10662] Build OAI-PMH Harvesting Client In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10662 --- Comment #115 from Sebastian Hierl --- We are interested as well and I trust that there are many more Koha libraries who would like to update their data via OAI-PMH. Thank you, Sebastian -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Mar 13 09:30:25 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 13 Mar 2017 08:30:25 +0000 Subject: [Koha-bugs] [Bug 17005] REST API: add routes to list checkouts history In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17005 --- Comment #16 from Josef Moravec --- (In reply to Jiri Kozlovsky from comment #15) > Someone please help me, I'm stuck in writing unit tests in kohadevbox. > > t/db_dependent/api/v1/patrons.t .. DBD::mysql::st execute failed: Unknown > column 'overdrive_auth_token' in 'field list' > > I think it's obvious there is some problem with DB, but I have no idea what > it could be about :( > You are right, looks like you do need to update your database schema -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Mar 13 09:51:47 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 13 Mar 2017 08:51:47 +0000 Subject: [Koha-bugs] [Bug 17462] Pay fines not accepting ', ' for EUR currency input In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17462 Fridolin SOMERS changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |fridolin.somers at biblibre.co | |m --- Comment #1 from Fridolin SOMERS --- Duplicate of Bug 12310 ? -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Mar 13 10:00:46 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 13 Mar 2017 09:00:46 +0000 Subject: [Koha-bugs] [Bug 18249] Typo "resrerves" in en-NZ translation files In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18249 Marc V?ron changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |veron at veron.ch Resolution|--- |INVALID Status|Needs Signoff |RESOLVED --- Comment #2 from Marc V?ron --- Hi Aleisha Such typos can be fixed here: http://translate.koha-community.org/en_NZ/ (Just did it for 16.05 and 16.11) Setting to RESOLVED INVALID because it is not done in Bug tracker. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Mon Mar 13 10:28:27 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 13 Mar 2017 09:28:27 +0000 Subject: [Koha-bugs] [Bug 17560] Hold fee placement at point of checkout In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17560 Marc V?ron changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |veron at veron.ch -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Mar 13 10:39:40 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 13 Mar 2017 09:39:40 +0000 Subject: [Koha-bugs] [Bug 17005] REST API: add routes to list checkouts history In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17005 --- Comment #17 from Jiri Kozlovsky --- (In reply to Josef Moravec from comment #16) > (In reply to Jiri Kozlovsky from comment #15) > > Someone please help me, I'm stuck in writing unit tests in kohadevbox. > > > > t/db_dependent/api/v1/patrons.t .. DBD::mysql::st execute failed: Unknown > > column 'overdrive_auth_token' in 'field list' > > > > I think it's obvious there is some problem with DB, but I have no idea what > > it could be about :( > > > > You are right, looks like you do need to update your database schema I thought kohadevbox takes care of that? Btw I'm running it with this command: LOCAL_ANSIBLE=1 SYNC_REPO="/etc/koha/kohaclone" SKIP_WEBINSTALLER=1 CREATE_ADMIN_USER=1 vagrant up --provision -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Mar 13 10:47:32 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 13 Mar 2017 09:47:32 +0000 Subject: [Koha-bugs] [Bug 17005] REST API: add routes to list checkouts history In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17005 --- Comment #18 from Josef Moravec --- (In reply to Jiri Kozlovsky from comment #17) > (In reply to Josef Moravec from comment #16) > > (In reply to Jiri Kozlovsky from comment #15) > > > Someone please help me, I'm stuck in writing unit tests in kohadevbox. > > > > > > t/db_dependent/api/v1/patrons.t .. DBD::mysql::st execute failed: Unknown > > > column 'overdrive_auth_token' in 'field list' > > > > > > I think it's obvious there is some problem with DB, but I have no idea what > > > it could be about :( > > > > > > > You are right, looks like you do need to update your database schema > > I thought kohadevbox takes care of that? > > Btw I'm running it with this command: > > LOCAL_ANSIBLE=1 SYNC_REPO="/etc/koha/kohaclone" SKIP_WEBINSTALLER=1 > CREATE_ADMIN_USER=1 vagrant up --provision I don't think you'd like to run provision just for updating the database, there is quicker way: cd kohaclone sudo koha-shell kohadev installer/data/mysql/updatedatabase.pl -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Mar 13 10:54:09 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 13 Mar 2017 09:54:09 +0000 Subject: [Koha-bugs] [Bug 18243] Bug 16034 follow-up: better handling of absence of WebService: :ILS::OverDrive::Patron at testing In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18243 Nick Clemens changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #60974|0 |1 is obsolete| | --- Comment #2 from Nick Clemens --- Created attachment 61017 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=61017&action=edit Bug 18243: 16034 follow-up: better handling of absence of WebService::ILS::OverDrive::Patron at testing To test: 1 - Make sure you don't have WebService::ILS::OverDrive::Patron installed 2 - prove t/Koha_ExternalContent_OverDrive.t 3 - You should get a failure to load module and tests are skipped 4 - Apply patch 5 - prove t/Koha_ExternalContent_OverDrive.t 6 - Module is not loaded, test are skipped Fixed small typo 'cannot filnd' -> 'cannot find' Signed-off-by: Nick Clemens -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Mar 13 10:54:07 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 13 Mar 2017 09:54:07 +0000 Subject: [Koha-bugs] [Bug 18243] Bug 16034 follow-up: better handling of absence of WebService: :ILS::OverDrive::Patron at testing In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18243 Nick Clemens changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Mar 13 11:13:53 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 13 Mar 2017 10:13:53 +0000 Subject: [Koha-bugs] [Bug 10382] collection not returning to null when removed from course reserves In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10382 --- Comment #20 from Alex Arnaud --- > Why drop the foreign key completely? Shouldn't the key be recreated? With this patch, the value '' is inserted in the column course_items.holdingbranch if no change is requested. This is why i remove the foreign key. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Mar 13 11:20:47 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 13 Mar 2017 10:20:47 +0000 Subject: [Koha-bugs] [Bug 11708] Display all basketgroups on one page, and new column aqbasketgroups.closeddate In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11708 Julian Maurice changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #59301|0 |1 is obsolete| | --- Comment #163 from Julian Maurice --- Created attachment 61018 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=61018&action=edit Bug 11708: Add aqbasketgroups.closeddate Signed-off-by: juliette levast Signed-off-by: Paola Rossi Patch updated: Use atomic update -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Mar 13 11:20:52 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 13 Mar 2017 10:20:52 +0000 Subject: [Koha-bugs] [Bug 11708] Display all basketgroups on one page, and new column aqbasketgroups.closeddate In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11708 Julian Maurice changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #59302|0 |1 is obsolete| | --- Comment #164 from Julian Maurice --- Created attachment 61019 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=61019&action=edit Bug 11708: Unit tests for aqbasketgroups.closeddate Signed-off-by: juliette levast Signed-off-by: Paola Rossi -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Mar 13 11:20:58 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 13 Mar 2017 10:20:58 +0000 Subject: [Koha-bugs] [Bug 11708] Display all basketgroups on one page, and new column aqbasketgroups.closeddate In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11708 Julian Maurice changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #59303|0 |1 is obsolete| | --- Comment #165 from Julian Maurice --- Created attachment 61020 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=61020&action=edit Bug 11708: basketgroup.pl can now display basketgroups for all suppliers This happens when no booksellerid is given. This patch also adds 4 columns: - No. of ordered titles - No. of received titles - Ordered amount - Charged amount (amount of received orders) Add filters to basketgroup tables columns Show closed date in closed basketgroups tables Signed-off-by: juliette levast Signed-off-by: Paola Rossi -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Mar 13 11:21:04 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 13 Mar 2017 10:21:04 +0000 Subject: [Koha-bugs] [Bug 11708] Display all basketgroups on one page, and new column aqbasketgroups.closeddate In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11708 Julian Maurice changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #59304|0 |1 is obsolete| | --- Comment #166 from Julian Maurice --- Created attachment 61021 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=61021&action=edit Bug 11708: Remove column aqbasketgroups.closed It is redundant with aqbasketgroups.closeddate Signed-off-by: Paola Rossi Patch updated: use atomic update -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Mar 13 11:21:09 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 13 Mar 2017 10:21:09 +0000 Subject: [Koha-bugs] [Bug 11708] Display all basketgroups on one page, and new column aqbasketgroups.closeddate In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11708 Julian Maurice changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #59305|0 |1 is obsolete| | --- Comment #167 from Julian Maurice --- Created attachment 61022 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=61022&action=edit Bug 11708: Place "Basket groups" menu entry on top of the side navigation -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Mar 13 11:21:16 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 13 Mar 2017 10:21:16 +0000 Subject: [Koha-bugs] [Bug 11708] Display all basketgroups on one page, and new column aqbasketgroups.closeddate In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11708 Julian Maurice changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #59306|0 |1 is obsolete| | --- Comment #168 from Julian Maurice --- Created attachment 61023 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=61023&action=edit Bug 11708: New page for basket groups This patch moves the code responsible for displaying a list of basket groups into its own Perl script (acqui/basketgroups.pl), making the code in basketgroup.pl and basketgroup.tt a little bit easier to read. basketgroups.pl displays all basket groups in a single table (as bug 13371 for vendors) where rows are grouped by bookseller. In the process, this patch adds 4 new "Koha::Object" modules: - Koha::Bookseller(s) - Koha::Basket(s) - Koha::Basketgroup(s) - Koha::Order(s) It also adds a wrapper around the new DataTable() constructor to be able to use it with the same defaults than the previous dataTable() constructor Test plan: 0. Create a bunch of booksellers and basketgroups 1. Go back to acquisitions home page and click on "Basket groups" link on the left 2. Play with the table (sort, filter) and try every possible actions (Edit, Close and export as PDF, View, Reopen, Export as CSV) 3. Go to a specific vendor page and click on "Basket groups" tab 4. Check that only the vendor's basket groups are displayed -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Mar 13 11:21:22 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 13 Mar 2017 10:21:22 +0000 Subject: [Koha-bugs] [Bug 11708] Display all basketgroups on one page, and new column aqbasketgroups.closeddate In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11708 Julian Maurice changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #59307|0 |1 is obsolete| | --- Comment #169 from Julian Maurice --- Created attachment 61024 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=61024&action=edit Bug 11708: UT: Replace 'ok' by 'is' where appropriate -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Mar 13 11:21:27 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 13 Mar 2017 10:21:27 +0000 Subject: [Koha-bugs] [Bug 11708] Display all basketgroups on one page, and new column aqbasketgroups.closeddate In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11708 Julian Maurice changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #59308|0 |1 is obsolete| | --- Comment #170 from Julian Maurice --- Created attachment 61025 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=61025&action=edit Bug 11708: UT: Use DateTime instead of localtime+sprintf -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Mar 13 11:21:33 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 13 Mar 2017 10:21:33 +0000 Subject: [Koha-bugs] [Bug 11708] Display all basketgroups on one page, and new column aqbasketgroups.closeddate In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11708 Julian Maurice changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #59309|0 |1 is obsolete| | --- Comment #171 from Julian Maurice --- Created attachment 61026 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=61026&action=edit Bug 11708: Move acq related Koha::Objects to Koha::Acquisition namespace and fix Koha::Acquisition::Order usage everywhere -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Mar 13 11:26:27 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 13 Mar 2017 10:26:27 +0000 Subject: [Koha-bugs] [Bug 9692] Add a checkbox to display statistical fields in basket.tt In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9692 Julian Maurice changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |julian.maurice at biblibre.com Status|Needs Signoff |Patch doesn't apply -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Mar 13 11:26:30 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 13 Mar 2017 10:26:30 +0000 Subject: [Koha-bugs] [Bug 17462] Pay fines not accepting ', ' for EUR currency input In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17462 Marc V?ron changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |veron at veron.ch -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Mar 13 12:30:23 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 13 Mar 2017 11:30:23 +0000 Subject: [Koha-bugs] [Bug 17605] EDI should set currency in order record on creation In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17605 --- Comment #7 from Colin Campbell --- Created attachment 61027 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=61027&action=edit Patch against master Previous version of patch required for 16.5 or 16.11 this version wraps the dbic calls in Koha::Object::Booksellers but requires dependencies currently only im master -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Mar 13 12:31:02 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 13 Mar 2017 11:31:02 +0000 Subject: [Koha-bugs] [Bug 17605] EDI should set currency in order record on creation In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17605 --- Comment #8 from Colin Campbell --- (In reply to Marcel de Rooy from comment #6) > (In reply to Colin Campbell from comment #5) > > (In reply to Marcel de Rooy from comment #4) > > > Note that we have a Koha::Object for Bookseller(s) > > > > By not using the Koha::Object this patch will apply to the stable banches > > 16.5 and 16.11 Booksellers.pm and hence the find method only present in > > master > > Agreed. Sounds reasonable for the stable branches. > Since the patch only deals with two lines, you could also supply two > versions? Done -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Mar 13 12:43:25 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 13 Mar 2017 11:43:25 +0000 Subject: [Koha-bugs] [Bug 17605] EDI should set currency in order record on creation In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17605 --- Comment #9 from Marcel de Rooy --- They are exactly the same? -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Mar 13 12:54:31 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 13 Mar 2017 11:54:31 +0000 Subject: [Koha-bugs] [Bug 17605] EDI should set currency in order record on creation In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17605 Colin Campbell changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #61027|0 |1 is obsolete| | --- Comment #10 from Colin Campbell --- Created attachment 61028 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=61028&action=edit Patch against master oops uploaded wrong version - corrected -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Mar 13 13:03:28 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 13 Mar 2017 12:03:28 +0000 Subject: [Koha-bugs] [Bug 16034] Integration with OverDrive Patron API In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16034 --- Comment #87 from Jonathan Druart --- (In reply to Srdjan Jankovic from comment #86) > > Did you also fix comment 80? > > Not sure. I was not getting it in the first place. But 18234 should address > that. It's bug 18243 I guess. And no, it does not: % git bz apply 18243 % prove t/00-load.t # Failed test 'use Koha::ExternalContent::OverDrive;' # at t/00-load.t line 65. # Tried to use 'Koha::ExternalContent::OverDrive'. # Error: Can't locate WebService/ILS/OverDrive/Patron.pm in @INC (you may need to install the WebService::ILS::OverDrive::Patron module) (@INC contains: /home/vagrant/kohaclone /home/vagrant/qa-test-tools /etc/perl /usr/local/lib/x86_64-linux-gnu/perl/5.20.2 /usr/local/share/perl/5.20.2 /usr/lib/x86_64-linux-gnu/perl5/5.20 /usr/share/perl5 /usr/lib/x86_64-linux-gnu/perl/5.20 /usr/share/perl/5.20 /usr/local/lib/site_perl . /var/lib/koha/kohadev/plugins /var/lib/koha/kohadev/plugins) at /home/vagrant/kohaclone/Koha/ExternalContent/OverDrive.pm line 24. # BEGIN failed--compilation aborted at /home/vagrant/kohaclone/Koha/ExternalContent/OverDrive.pm line 24. # Compilation failed in require at t/00-load.t line 65. # BEGIN failed--compilation aborted at t/00-load.t line 65. Bailout called. Further testing stopped: ***** PROBLEMS LOADING FILE 'Koha::ExternalContent::OverDrive' -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Mar 13 13:11:27 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 13 Mar 2017 12:11:27 +0000 Subject: [Koha-bugs] [Bug 17605] EDI should set currency in order record on creation In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17605 Marcel de Rooy changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |Signed Off -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Mar 13 13:11:30 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 13 Mar 2017 12:11:30 +0000 Subject: [Koha-bugs] [Bug 17605] EDI should set currency in order record on creation In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17605 --- Comment #11 from Marcel de Rooy --- Created attachment 61029 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=61029&action=edit Bug 17605: [MASTER] Add currency to orders generated by quotes Sets the vendors currency in the edi generated order The currency used is agreed between vendor and library and the value in the quote is optional Edifact potentially allows the currency to be overwitten by specifying another currency in the CUX segment but we know currently of no supplier doing this Signed-off-by: Alex Buckley Signed-off-by: Marcel de Rooy -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Mar 13 13:12:39 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 13 Mar 2017 12:12:39 +0000 Subject: [Koha-bugs] [Bug 17605] EDI should set currency in order record on creation In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17605 --- Comment #12 from Marcel de Rooy --- Created attachment 61030 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=61030&action=edit Bug 17605: [STABLE] Add currency to orders generated by quotes Sets the vendors currency in the edi generated order The currency used is agreed between vendor and library and the value in the quote is optional Edifact potentially allows the currency to be overwitten by specifying another currency in the CUX segment but we know currently of no supplier doing this Signed-off-by: Alex Buckley Signed-off-by: Marcel de Rooy -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Mar 13 13:13:02 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 13 Mar 2017 12:13:02 +0000 Subject: [Koha-bugs] [Bug 17605] EDI should set currency in order record on creation In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17605 Marcel de Rooy changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #61028|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Mar 13 13:13:00 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 13 Mar 2017 12:13:00 +0000 Subject: [Koha-bugs] [Bug 17605] EDI should set currency in order record on creation In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17605 Marcel de Rooy changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #57811|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Mar 13 13:14:32 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 13 Mar 2017 12:14:32 +0000 Subject: [Koha-bugs] [Bug 17605] EDI should set currency in order record on creation In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17605 Marcel de Rooy changed: What |Removed |Added ---------------------------------------------------------------------------- Severity|enhancement |normal Status|Signed Off |Passed QA --- Comment #13 from Marcel de Rooy --- Changing enhancement to normal. Stable patch is provided for stable branches.. Looks good to me. Just noting for the record that we do not have unit tests for Koha::EDI. Should not block this twoliner.. Passed QA -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Mar 13 13:21:21 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 13 Mar 2017 12:21:21 +0000 Subject: [Koha-bugs] [Bug 14608] HEA : add possibility of sharing usage statistics in Administration page and Web installer In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14608 --- Comment #40 from Jonathan Druart --- Created attachment 61031 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=61031&action=edit Bug 14608: Move country list to an include file -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Mar 13 13:22:00 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 13 Mar 2017 12:22:00 +0000 Subject: [Koha-bugs] [Bug 14608] HEA : add possibility of sharing usage statistics in Administration page and Web installer In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14608 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |Signed Off --- Comment #41 from Jonathan Druart --- Marcel, is it what you were expecting? -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Mar 13 13:25:34 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 13 Mar 2017 12:25:34 +0000 Subject: [Koha-bugs] [Bug 14608] HEA : add possibility of sharing usage statistics in Administration page and Web installer In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14608 --- Comment #42 from Marcel de Rooy --- (In reply to Jonathan Druart from comment #41) > Marcel, is it what you were expecting? Yes, looks like it. Will continue here later this week.. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Mar 13 13:51:52 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 13 Mar 2017 12:51:52 +0000 Subject: [Koha-bugs] [Bug 16246] Return all reserves columns in ILS-DI GetRecords response In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16246 Julian Maurice changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #56829|0 |1 is obsolete| | --- Comment #8 from Julian Maurice --- Created attachment 61032 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=61032&action=edit Bug 16246: Return all reserves columns in ILS-DI GetRecords response The list of reserves fields returned in ILS-DI GetRecords response is arbitrary. Instead we should return all the fields available in reserves table -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Mar 13 13:51:55 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 13 Mar 2017 12:51:55 +0000 Subject: [Koha-bugs] [Bug 16246] Return all reserves columns in ILS-DI GetRecords response In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16246 Julian Maurice changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #56830|0 |1 is obsolete| | --- Comment #9 from Julian Maurice --- Created attachment 61033 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=61033&action=edit Bug 16246: Add tests for ILS-DI GetRecords -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Mar 13 13:52:10 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 13 Mar 2017 12:52:10 +0000 Subject: [Koha-bugs] [Bug 16246] Return all reserves columns in ILS-DI GetRecords response In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16246 --- Comment #10 from Julian Maurice --- Patches rebased on master -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Mar 13 13:53:28 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 13 Mar 2017 12:53:28 +0000 Subject: [Koha-bugs] [Bug 18250] New: koha-common should start after memcached Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18250 Bug ID: 18250 Summary: koha-common should start after memcached Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: normal Priority: P5 - low Component: Packaging Assignee: koha-bugs at lists.koha-community.org Reporter: m.de.rooy at rijksmuseum.nl QA Contact: testopia at bugs.koha-community.org CC: mirko at abunchofthings.net -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Mon Mar 13 13:53:40 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 13 Mar 2017 12:53:40 +0000 Subject: [Koha-bugs] [Bug 17311] koha-common service should be restarted on upgrade In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17311 Marcel de Rooy changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |https://bugs.koha-community | |.org/bugzilla3/show_bug.cgi | |?id=18250 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Mar 13 13:53:40 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 13 Mar 2017 12:53:40 +0000 Subject: [Koha-bugs] [Bug 18250] koha-common should start after memcached In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18250 Marcel de Rooy changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |https://bugs.koha-community | |.org/bugzilla3/show_bug.cgi | |?id=17311 -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Mar 13 14:03:57 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 13 Mar 2017 13:03:57 +0000 Subject: [Koha-bugs] [Bug 18250] koha-common should start after memcached In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18250 --- Comment #1 from Marcel de Rooy --- Created attachment 61034 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=61034&action=edit Bug 18250: Update LSB block of koha-common init script Currently koha-common may start before memcached. We should prevent that. If we add memcached to the LSB section of the koha-common init script, Debian's insserv will know about this requirement. Note: This patch is only a step in resolving the issue. Test plan: [1] Copy the updated koha-common script to /etc/init.d [2] Look for S..koha-common and S..memcached in /etc/rcX.d (say X=5) [3] Run sudo update-rc.d koha-common disable [4] Run sudo update-rc.d koha-common enable [5] Look again for S..koha-common in /etc/rcX.d (say X=5). The number for koha-common should now be higher than for memcached. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Mar 13 14:06:20 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 13 Mar 2017 13:06:20 +0000 Subject: [Koha-bugs] [Bug 17098] Validation problems with form field type "number" ( decimal separator) In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17098 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |jonathan.druart at bugs.koha-c | |ommunity.org --- Comment #5 from Jonathan Druart --- I do not recreate, on /members/maninvoice.pl?borrowernumber=5, I tried with FF ESR 45.4.0 and Chromium 55.0.2883.75. With de-DE, I do see lang=de-DE, but 12.3 and 12,3 are ok -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Mar 13 14:08:04 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 13 Mar 2017 13:08:04 +0000 Subject: [Koha-bugs] [Bug 18250] koha-common should start after memcached In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18250 --- Comment #2 from Mirko Tietgen --- Memcached is optional for Koha. What happens with this patch if it is not installed? -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Mar 13 14:17:57 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 13 Mar 2017 13:17:57 +0000 Subject: [Koha-bugs] [Bug 18250] koha-common should start after memcached In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18250 --- Comment #3 from Marcel de Rooy --- (In reply to Mirko Tietgen from comment #2) > Memcached is optional for Koha. What happens with this patch if it is not > installed? True. We need to take care of that too. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Mon Mar 13 14:18:18 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 13 Mar 2017 13:18:18 +0000 Subject: [Koha-bugs] [Bug 18250] koha-common should start after memcached In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18250 --- Comment #4 from Marcel de Rooy --- You will see this warning when disabling: insserv: warning: current start runlevel(s) (empty) of script `koha-common' overrides LSB defaults (2 3 4 5). insserv: warning: current stop runlevel(s) (0 1 2 3 4 5 6) of script `koha-common' overrides LSB defaults (0 1 6). -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Mon Mar 13 14:18:42 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 13 Mar 2017 13:18:42 +0000 Subject: [Koha-bugs] [Bug 18250] koha-common should start after memcached In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18250 --- Comment #5 from Marcel de Rooy --- Created attachment 61035 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=61035&action=edit Bug 18250: Force startup order in postinst script This is a workaround meant to correct upgrading installs. We force the order by disable/enable. Test plan: [1] When upgrading an existing install, check that the startup order after the upgrade has been corrected in /etc/rcX.d (say X=5). -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Mar 13 14:19:00 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 13 Mar 2017 13:19:00 +0000 Subject: [Koha-bugs] [Bug 18250] koha-common should start after memcached In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18250 --- Comment #6 from Marcel de Rooy --- We should check if this change is enough for a new install. When we are installing koha-common with this new LSB block, you would expect a better startup order in /etc/rc.d. When we are upgrading, we could try to force the order as is done in the second patch. Must still be tested. It is a kind of workaround. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Mar 13 14:20:59 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 13 Mar 2017 13:20:59 +0000 Subject: [Koha-bugs] [Bug 17311] koha-common service should be restarted on upgrade In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17311 Marcel de Rooy changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |m.de.rooy at rijksmuseum.nl --- Comment #2 from Marcel de Rooy --- (In reply to Mirko Tietgen from comment #1) > We should also take care of the correct order of restarting memcached and > plack here in some way. Added the see also to bug 18250. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Mar 13 14:22:09 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 13 Mar 2017 13:22:09 +0000 Subject: [Koha-bugs] [Bug 17098] Validation problems with form field type "number" ( decimal separator) In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17098 --- Comment #6 from Jonathan Druart --- If we simply replace type="number" with type="text", we will reintroduce bug 2542. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Mar 13 14:22:52 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 13 Mar 2017 13:22:52 +0000 Subject: [Koha-bugs] [Bug 17098] Validation problems with form field type "number" ( decimal separator) In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17098 --- Comment #7 from Jonathan Druart --- (In reply to Jonathan Druart from comment #6) > If we simply replace type="number" with type="text", we will reintroduce bug > 2542. That could work using the pattern attribute indeed. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Mar 13 14:24:53 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 13 Mar 2017 13:24:53 +0000 Subject: [Koha-bugs] [Bug 18250] koha-common should start after memcached In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18250 --- Comment #7 from Marcel de Rooy --- (In reply to Marcel de Rooy from comment #3) > (In reply to Mirko Tietgen from comment #2) > > Memcached is optional for Koha. What happens with this patch if it is not > > installed? > > True. We need to take care of that too. Maybe an easy way out here is the $all-approach in insserv? (Start after anything else..) Or removing the memcached from init.d with sed when there is no memcached. Only problem there: what happens if someone installs memcached later? -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Mon Mar 13 14:29:04 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 13 Mar 2017 13:29:04 +0000 Subject: [Koha-bugs] [Bug 18250] koha-common should start after memcached In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18250 --- Comment #8 from Marcel de Rooy --- Tested a notexisting service with disable/enable: insserv: Service notexistingservice has to be enabled to start service koha-common insserv: exiting now! -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Mar 13 14:32:16 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 13 Mar 2017 13:32:16 +0000 Subject: [Koha-bugs] [Bug 7534] New OPACAllowUserToChooseBranch setting for only showing libraries allowing holds In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7534 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Failed QA --- Comment #36 from Jonathan Druart --- Lari, I think we need a check server-side to make sure a patron will not inject a library that is not in the list. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Mar 13 14:44:04 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 13 Mar 2017 13:44:04 +0000 Subject: [Koha-bugs] [Bug 18250] koha-common should start after memcached In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18250 --- Comment #9 from Marcel de Rooy --- Or should we do in postinst: if memcached_is_installed if memcached_not_yet_in_lsb_header add to init.d/koha-common disable, enable fi fi That way we would only do the reshuffle once.. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Mon Mar 13 14:45:58 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 13 Mar 2017 13:45:58 +0000 Subject: [Koha-bugs] [Bug 18250] koha-common should start after memcached In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18250 --- Comment #10 from Marcel de Rooy --- So far my proposals; this report now first needs some feedback. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Mon Mar 13 14:47:00 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 13 Mar 2017 13:47:00 +0000 Subject: [Koha-bugs] [Bug 18200] Fix a potential issue with preceding space in GetMarcUrls In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18200 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Mar 13 14:47:05 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 13 Mar 2017 13:47:05 +0000 Subject: [Koha-bugs] [Bug 18200] Fix a potential issue with preceding space in GetMarcUrls In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18200 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #60808|0 |1 is obsolete| | --- Comment #5 from Jonathan Druart --- Created attachment 61036 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=61036&action=edit Bug 18200: Fix a potential issue with preceding space in GetMarcUrls Trims the URL in order prevent prefixing a space with http:// Normally you won't have a preceding space here, but I saw it happening one day and it does not cost much to resolve it. Bonus: Adding few simple tests in t/db_dependent/Biblio.t. Test plan: [1] Run t/db_dependent/Biblio.t [2] Add a 856$u with preceding space (MARC21) [3] Check opac-detail, Online access with OPACXSLTDetailsDisplay empty. Signed-off-by: Marcel de Rooy Followed test plan, works as expected Signed-off-by: Marc V?ron Signed-off-by: Jonathan Druart -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Mar 13 14:59:24 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 13 Mar 2017 13:59:24 +0000 Subject: [Koha-bugs] [Bug 18219] "Not checked out." problem message displays twice on local use. In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18219 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Mar 13 14:59:34 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 13 Mar 2017 13:59:34 +0000 Subject: [Koha-bugs] [Bug 18219] "Not checked out." problem message displays twice on local use. In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18219 --- Comment #9 from Jonathan Druart --- Created attachment 61038 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=61038&action=edit Bug 18219: Remove extra whitespace from returns.tt Signed-off-by: Jonathan Druart -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Mar 13 14:59:29 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 13 Mar 2017 13:59:29 +0000 Subject: [Koha-bugs] [Bug 18219] "Not checked out." problem message displays twice on local use. In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18219 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #60908|0 |1 is obsolete| | Attachment #60910|0 |1 is obsolete| | --- Comment #8 from Jonathan Druart --- Created attachment 61037 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=61037&action=edit Bug 18219: Remove duplicated code in returns.tt Removed lines of code that were duplicated in bug 16530. Fixes alignment of a few lines of code surrounding duplication. Modifies returns.tt To test: 1) Check in items that are not checked out. 2) Note duplicated problem message (i.e. "Not checked out.") 3) Apply patch. 4) Repeat step 1. 5) Note the problem message is no longer duplicated. Followed test plan, works as expected. Signed-off-by: Marc V?ron Signed-off-by: Jonathan Druart -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Mar 13 14:59:43 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 13 Mar 2017 13:59:43 +0000 Subject: [Koha-bugs] [Bug 16530] Add a circ sidebar navigation menu In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16530 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |18219 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18219 [Bug 18219] "Not checked out." problem message displays twice on local use. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Mar 13 14:59:43 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 13 Mar 2017 13:59:43 +0000 Subject: [Koha-bugs] [Bug 18219] "Not checked out." problem message displays twice on local use. In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18219 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |jonathan.druart at bugs.koha-c | |ommunity.org Depends on| |16530 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16530 [Bug 16530] Add a circ sidebar navigation menu -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Mar 13 15:08:16 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 13 Mar 2017 14:08:16 +0000 Subject: [Koha-bugs] [Bug 18250] koha-common should start after memcached In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18250 --- Comment #11 from Mirko Tietgen --- To avoid workarounds, we could just make memcached mandatory. It is widely available in Debian versions. Feels like a cleaner approach to me. Any reasons not to do it? -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Mar 13 15:19:47 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 13 Mar 2017 14:19:47 +0000 Subject: [Koha-bugs] [Bug 17346] Enable the check in option in Columns settings In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17346 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Failed QA --- Comment #5 from Jonathan Druart --- I finally remember why the action columns were not modifiable. There is something wrong happening if you select checkin hidden by default and can be toggled. When you show it, the tr element "Today's checkouts" does not display correctly. Not sure how to fix that cleanly... -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Mar 13 15:27:53 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 13 Mar 2017 14:27:53 +0000 Subject: [Koha-bugs] [Bug 18243] Bug 16034 follow-up: better handling of absence of WebService: :ILS::OverDrive::Patron at testing In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18243 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Mar 13 15:27:57 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 13 Mar 2017 14:27:57 +0000 Subject: [Koha-bugs] [Bug 18243] Bug 16034 follow-up: better handling of absence of WebService: :ILS::OverDrive::Patron at testing In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18243 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #61017|0 |1 is obsolete| | --- Comment #3 from Jonathan Druart --- Created attachment 61039 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=61039&action=edit Bug 18243: 16034 follow-up: better handling of absence of WebService::ILS::OverDrive::Patron at testing To test: 1 - Make sure you don't have WebService::ILS::OverDrive::Patron installed 2 - prove t/Koha_ExternalContent_OverDrive.t 3 - You should get a failure to load module and tests are skipped 4 - Apply patch 5 - prove t/Koha_ExternalContent_OverDrive.t 6 - Module is not loaded, test are skipped Fixed small typo 'cannot filnd' -> 'cannot find' Signed-off-by: Nick Clemens Signed-off-by: Jonathan Druart -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Mar 13 15:28:22 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 13 Mar 2017 14:28:22 +0000 Subject: [Koha-bugs] [Bug 18243] Bug 16034 follow-up: better handling of absence of WebService: :ILS::OverDrive::Patron at testing In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18243 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Severity|enhancement |normal Component|OPAC |Test Suite Assignee|oleonard at myacpl.org |srdjan at catalyst.net.nz QA Contact|testopia at bugs.koha-communit |gmcharlt at gmail.com |y.org | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Mar 13 15:30:36 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 13 Mar 2017 14:30:36 +0000 Subject: [Koha-bugs] [Bug 18251] New: SCO alerts - need a trigger for successful checkouts Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18251 Bug ID: 18251 Summary: SCO alerts - need a trigger for successful checkouts Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: minor Priority: P5 - low Component: Self checkout Assignee: koha-bugs at lists.koha-community.org Reporter: nick at bywatersolutions.com QA Contact: testopia at bugs.koha-community.org Failed checkouts on the sco can be triggered by presence of alert, however, we have no feedback for a successful checkout. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Mon Mar 13 15:34:51 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 13 Mar 2017 14:34:51 +0000 Subject: [Koha-bugs] [Bug 18251] SCO alerts - need a trigger for successful checkouts In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18251 --- Comment #1 from Nick Clemens --- Created attachment 61040 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=61040&action=edit Bug 18251 - SCO alerts - need a trigger for successful checkouts This patch adds simple text and a div to allow for sounds to be configured upon successful SCO checkout To test: 1 - Enable sco module 2 - Enable AudioAlerts 3 - Define alert with Selector: .sco-alert-success Sound:http://localhost:8081/intranet-tmpl/prog/sound/opening.ogg 4 - Checkout to patron using SCO 5 - Note only feedback is a addition of item to checkouts list 6 - Apply patch 7 - Checkout ot patron via SCO 8 - You should hear the sound specified above 9 - You should also see a note: Item checked out -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Mon Mar 13 15:34:49 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 13 Mar 2017 14:34:49 +0000 Subject: [Koha-bugs] [Bug 18251] SCO alerts - need a trigger for successful checkouts In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18251 Nick Clemens changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff Patch complexity|--- |Trivial patch -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Mar 13 15:35:07 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 13 Mar 2017 14:35:07 +0000 Subject: [Koha-bugs] [Bug 18251] SCO alerts - need a trigger for successful checkouts In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18251 Nick Clemens changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|koha-bugs at lists.koha-commun |nick at bywatersolutions.com |ity.org | -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Mon Mar 13 15:35:21 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 13 Mar 2017 14:35:21 +0000 Subject: [Koha-bugs] [Bug 14150] Field issues.date_due does not display in ISSUESLIP or ISSUEQSLIP In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14150 --- Comment #7 from Christopher Brannon --- (In reply to Katrin Fischer from comment #6) > I did some more tests - this problem appears in 3.18.6, but is fixed on the > current 3.18.x branch, that will be 3.18.7. Katrin, Please confirm with master. I am in 3.22, and I see that issues.date_due is producing a date, but I do not see a time stamp. Shouldn't this value produce a timestamp for hourly loans, or do hourly loans have to be turned on in order for it to produce a time stamp? Christopher -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Mar 13 15:38:08 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 13 Mar 2017 14:38:08 +0000 Subject: [Koha-bugs] [Bug 17519] Item editor handles clearing dateaccessioned and replacementpricedate inconsistently In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17519 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |jonathan.druart at bugs.koha-c | |ommunity.org --- Comment #4 from Jonathan Druart --- It seems that replacement price is ok before this patch, and the patch does not affect it. Should we rename the bug report and the commit msg? -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Mar 13 15:45:56 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 13 Mar 2017 14:45:56 +0000 Subject: [Koha-bugs] [Bug 14150] Field issues.date_due does not display in ISSUESLIP or ISSUEQSLIP In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14150 --- Comment #8 from Christopher Brannon --- On further inspection, it appears that in 3.22.8, issues.date_due shows the date but not the time. In master, I see that issues.date_due includes the time as well. Can't find the bug that changed this. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Mon Mar 13 15:49:41 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 13 Mar 2017 14:49:41 +0000 Subject: [Koha-bugs] [Bug 18251] SCO alerts - need a trigger for successful checkouts In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18251 Nick Clemens changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on| |16732 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16732 [Bug 16732] Add audio alerts (custom sound notifications) to web based self checkout -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Mar 13 15:49:39 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 13 Mar 2017 14:49:39 +0000 Subject: [Koha-bugs] [Bug 17346] Enable the check in option in Columns settings In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17346 --- Comment #6 from Christopher Brannon --- (In reply to Jonathan Druart from comment #5) > I finally remember why the action columns were not modifiable. > There is something wrong happening if you select checkin hidden by default > and can be toggled. > When you show it, the tr element "Today's checkouts" does not display > correctly. > > Not sure how to fix that cleanly... I will look into it, but if I can't find a resolution, at least we can still lock the option to toggle it. That would be a reasonable compromise. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Mar 13 15:49:41 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 13 Mar 2017 14:49:41 +0000 Subject: [Koha-bugs] [Bug 16732] Add audio alerts (custom sound notifications) to web based self checkout In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16732 Nick Clemens changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |18251 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18251 [Bug 18251] SCO alerts - need a trigger for successful checkouts -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Mar 13 16:13:34 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 13 Mar 2017 15:13:34 +0000 Subject: [Koha-bugs] [Bug 18252] New: Move C4::Items code to the Koha namespace Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18252 Bug ID: 18252 Summary: Move C4::Items code to the Koha namespace Change sponsored?: --- Product: Koha Version: unspecified Hardware: All OS: All Status: ASSIGNED Severity: enhancement Priority: P5 - low Component: Architecture, internals, and plumbing Assignee: jonathan.druart at bugs.koha-community.org Reporter: jonathan.druart at bugs.koha-community.org QA Contact: testopia at bugs.koha-community.org -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Mar 13 16:13:53 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 13 Mar 2017 15:13:53 +0000 Subject: [Koha-bugs] [Bug 15449] Move stuffs to the Koha namespace In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15449 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on| |18252 --- Comment #19 from Jonathan Druart --- Bug 18252 - Move C4::Items code to the Koha namespace Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18252 [Bug 18252] Move C4::Items code to the Koha namespace -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Mar 13 16:13:53 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 13 Mar 2017 15:13:53 +0000 Subject: [Koha-bugs] [Bug 18252] Move C4::Items code to the Koha namespace In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18252 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |15449 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15449 [Bug 15449] Move stuffs to the Koha namespace -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Mar 13 16:19:04 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 13 Mar 2017 15:19:04 +0000 Subject: [Koha-bugs] [Bug 18253] New: Remove C4::Items::GetItemsByBiblioitemnumber Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18253 Bug ID: 18253 Summary: Remove C4::Items::GetItemsByBiblioitemnumber Change sponsored?: --- Product: Koha Version: unspecified Hardware: All OS: All Status: ASSIGNED Severity: enhancement Priority: P5 - low Component: Architecture, internals, and plumbing Assignee: jonathan.druart at bugs.koha-community.org Reporter: jonathan.druart at bugs.koha-community.org QA Contact: testopia at bugs.koha-community.org This subroutine does too many things, we could use existing method from the Koha namespace to achieve the same goal. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Mar 13 16:19:42 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 13 Mar 2017 15:19:42 +0000 Subject: [Koha-bugs] [Bug 18253] Remove C4::Items::GetItemsByBiblioitemnumber In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18253 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |18252 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18252 [Bug 18252] Move C4::Items code to the Koha namespace -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Mar 13 16:19:42 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 13 Mar 2017 15:19:42 +0000 Subject: [Koha-bugs] [Bug 18252] Move C4::Items code to the Koha namespace In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18252 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on| |18253 --- Comment #1 from Jonathan Druart --- Bug 18253 - Remove C4::Items::GetItemsByBiblioitemnumber Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18253 [Bug 18253] Remove C4::Items::GetItemsByBiblioitemnumber -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Mar 13 16:20:34 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 13 Mar 2017 15:20:34 +0000 Subject: [Koha-bugs] [Bug 18254] New: Remove C4::Items:: GetItemsByBiblioitemnumber call from additem.pl Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18254 Bug ID: 18254 Summary: Remove C4::Items::GetItemsByBiblioitemnumber call from additem.pl Change sponsored?: --- Product: Koha Version: unspecified Hardware: All OS: All Status: ASSIGNED Severity: enhancement Priority: P5 - low Component: Architecture, internals, and plumbing Assignee: jonathan.druart at bugs.koha-community.org Reporter: jonathan.druart at bugs.koha-community.org QA Contact: testopia at bugs.koha-community.org -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Mar 13 16:21:15 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 13 Mar 2017 15:21:15 +0000 Subject: [Koha-bugs] [Bug 18253] Remove C4::Items::GetItemsByBiblioitemnumber In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18253 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on| |18254 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18254 [Bug 18254] Remove C4::Items::GetItemsByBiblioitemnumber call from additem.pl -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Mar 13 16:21:07 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 13 Mar 2017 15:21:07 +0000 Subject: [Koha-bugs] [Bug 18253] Remove C4::Items::GetItemsByBiblioitemnumber In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18253 --- Comment #1 from Jonathan Druart --- There are only 2 calls, first on is in additem.pl Bug 18254 - Remove C4::Items::GetItemsByBiblioitemnumber call from additem.pl -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Mar 13 16:21:15 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 13 Mar 2017 15:21:15 +0000 Subject: [Koha-bugs] [Bug 18254] Remove C4::Items:: GetItemsByBiblioitemnumber call from additem.pl In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18254 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |18253 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18253 [Bug 18253] Remove C4::Items::GetItemsByBiblioitemnumber -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Mar 13 16:29:02 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 13 Mar 2017 15:29:02 +0000 Subject: [Koha-bugs] [Bug 18254] Remove C4::Items:: GetItemsByBiblioitemnumber call from additem.pl In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18254 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Mar 13 16:29:06 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 13 Mar 2017 15:29:06 +0000 Subject: [Koha-bugs] [Bug 18254] Remove C4::Items:: GetItemsByBiblioitemnumber call from additem.pl In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18254 --- Comment #1 from Jonathan Druart --- Created attachment 61041 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=61041&action=edit Bug 18254: Remove call to GetItemsByBiblioitemnumber call from additem.pl The code from additem to delete all the items of a bibliographic record is very ackward. This patch simplifies the algorithm and make the code more readable. Test plan: Remove all the items of a bibliographic records If at least 1 item is checked out you should get an error. No change with the current behavior is expected. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Mar 13 16:54:46 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 13 Mar 2017 15:54:46 +0000 Subject: [Koha-bugs] [Bug 18137] REST API: Migrate from Mojolicious::Plugin:: Swagger2 to Mojolicious::Plugin::OpenAPI In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18137 --- Comment #25 from Lari Taskula --- (In reply to Mirko Tietgen from comment #24) > I submitted Mojolicious::Plugin::OpenAPI to Debian a few days ago (1.10). > 1.13 is out by now. And both versions depend on versions of > libjson-validator-perl not yet in Debian unstable, and the tests in the > latest version are broken. Thanks for looking at this Mirko! I had a look at JSON::Validator version 0.96. There indeed seemed to be some issues with the tests in the latest version. I noticed there is a commit to json-validator in GitHub as well as some IRC discussion in #swagger @irc.perl.org suggesting that tests are broken on an older version of Test::More. Using the latest version of Test::More passes the tests. I tested an older version of Test::More (1.001014) and tests are indeed failing: $ sudo cpanm Test::More at 1.001014 --> Working on Test::More Fetching http://backpan.perl.org/authors/id/E/EX/EXODIST/Test-Simple-1.001014.tar.gz ... OK Configuring Test-Simple-1.001014 ... OK Building and testing Test-Simple-1.001014 ... OK Successfully installed Test-Simple-1.001014 (downgraded from 1.302078) 1 distribution installed $ prove t .. .. Test Summary Report ------------------- t/acceptance.t (Wstat: 0 Tests: 265 Failed: 0) TODO passed: 45-47, 49-52, 56-57 t/jv-formats.t (Wstat: 256 Tests: 28 Failed: 1) Failed test: 27 Non-zero exit status: 1 t/jv-object.t (Wstat: 256 Tests: 19 Failed: 1) Failed test: 18 Non-zero exit status: 1 t/openapi-formats.t (Wstat: 512 Tests: 24 Failed: 2) Failed tests: 12, 22 Non-zero exit status: 2 t/openapi-response.t (Wstat: 0 Tests: 7 Failed: 0) TODO passed: 1 t/openapi.t (Wstat: 0 Tests: 8 Failed: 0) TODO passed: 1 Files=44, Tests=558, 11 wallclock secs ( 0.24 usr 0.06 sys + 9.82 cusr 1.04 csys = 11.16 CPU) Result: FAIL Whereas the new version passes: $ sudo cpanm Test::More --> Working on Test::More Fetching http://www.cpan.org/authors/id/E/EX/EXODIST/Test-Simple-1.302078.tar.gz ... OK Configuring Test-Simple-1.302078 ... OK Building and testing Test-Simple-1.302078 ... OK Successfully installed Test-Simple-1.302078 (upgraded from 1.001014) 1 distribution installed $ prove t .. .. All tests successful. Test Summary Report ------------------- t/acceptance.t (Wstat: 0 Tests: 265 Failed: 0) TODO passed: 45-47, 49-52, 56-57 t/jv-object.t (Wstat: 0 Tests: 19 Failed: 0) TODO passed: 9 t/openapi-formats.t (Wstat: 0 Tests: 24 Failed: 0) TODO passed: 7, 10-11 t/openapi-response.t (Wstat: 0 Tests: 7 Failed: 0) TODO passed: 1 t/openapi.t (Wstat: 0 Tests: 8 Failed: 0) TODO passed: 1 Files=44, Tests=558, 12 wallclock secs ( 0.23 usr 0.08 sys + 10.66 cusr 1.12 csys = 12.09 CPU) Result: PASS Could this be related to the issue you were having with the tests? Anyway, as a side note to comment #18, Mojolicious::Plugin::OpenAPI 1.13 has a requirement for JSON::Validator 0.95, which is not enough for us. We need JSON::Validator 0.96 or newer. It will be a requirement in currently unreleased Mojolicious::Plugin::OpenAPI version 1.14. Should we wait for that or explicitly define requirement for JSON::Validator 0.96 in PerlDependencies.pm? What comes to Mojolicious - I've attempted to run our REST API on Mojolicious 7.26 and so far it seems ok. Tests are also passing for me. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Mar 13 17:05:00 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 13 Mar 2017 16:05:00 +0000 Subject: [Koha-bugs] [Bug 7614] Branch transfer limit and holds In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7614 Lari Taskula changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Patch doesn't apply --- Comment #16 from Lari Taskula --- (In reply to Koha Team AMU from comment #13) > I tried to test in sandbox but failed : Hi and thanks for testing! This patch set is not rebased yet on top of Bug 7534 as it is currently going through some changes in QA process. I will rebase these patches once Bug 7534 passes QA. (In reply to Olli-Antti Kivilahti from comment #14) > Created attachment 60938 [details] [review] > Bug 7614 - Fix my variable earlier declaration bug. (In reply to Olli-Antti Kivilahti from comment #15) > Created attachment 60946 [details] [review] > Bug 7614 - Fixes "Looks like you planned 61 tests but ran 62" at > t/db_dependent/Holds.t Thanks Olli-Antti! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Mar 13 17:21:18 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 13 Mar 2017 16:21:18 +0000 Subject: [Koha-bugs] [Bug 16461] Add some information (branch and barcode) in fine description for overdue In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16461 Alex Arnaud changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #52052|0 |1 is obsolete| | --- Comment #7 from Alex Arnaud --- Created attachment 61042 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=61042&action=edit Bug 16461 - Add branch and barcode in accountline table for overdues -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Mar 13 17:22:07 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 13 Mar 2017 16:22:07 +0000 Subject: [Koha-bugs] [Bug 16461] Add some information (branch and barcode) in fine description for overdue In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16461 Alex Arnaud changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |Needs Signoff QA Contact|testopia at bugs.koha-communit |alex.arnaud at biblibre.com |y.org | -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Mar 13 17:42:37 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 13 Mar 2017 16:42:37 +0000 Subject: [Koha-bugs] [Bug 18255] New: Koha::Biblio - Remove GetBiblioItemByBiblioNumber Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18255 Bug ID: 18255 Summary: Koha::Biblio - Remove GetBiblioItemByBiblioNumber Change sponsored?: --- Product: Koha Version: unspecified Hardware: All OS: All Status: ASSIGNED Severity: enhancement Priority: P5 - low Component: Architecture, internals, and plumbing Assignee: jonathan.druart at bugs.koha-community.org Reporter: jonathan.druart at bugs.koha-community.org QA Contact: testopia at bugs.koha-community.org -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Mar 13 17:43:06 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 13 Mar 2017 16:43:06 +0000 Subject: [Koha-bugs] [Bug 18255] Koha::Biblio - Remove GetBiblioItemByBiblioNumber In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18255 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |17628 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17628 [Bug 17628] Move bibliographic related code to Koha::Biblio -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Mar 13 17:43:06 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 13 Mar 2017 16:43:06 +0000 Subject: [Koha-bugs] [Bug 17628] Move bibliographic related code to Koha::Biblio In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17628 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on| |18255 --- Comment #1 from Jonathan Druart --- Bug 17629 - Koha::Biblio - Remove ModBiblioframework Bug 17631 - Koha::Biblio - Remove GetHolds Bug 18255 - Koha::Biblio - Remove GetBiblioItemByBiblioNumber Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18255 [Bug 18255] Koha::Biblio - Remove GetBiblioItemByBiblioNumber -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Mar 13 17:44:05 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 13 Mar 2017 16:44:05 +0000 Subject: [Koha-bugs] [Bug 18255] Koha::Biblio - Remove GetBiblioItemByBiblioNumber In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18255 --- Comment #1 from Jonathan Druart --- Created attachment 61043 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=61043&action=edit Bug 18255: WIP -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Mar 13 17:44:28 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 13 Mar 2017 16:44:28 +0000 Subject: [Koha-bugs] [Bug 18255] Koha::Biblio - Remove GetBiblioItemByBiblioNumber In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18255 --- Comment #2 from Jonathan Druart --- Waiting for an answer from the mailing list - http://lists.koha-community.org/pipermail/koha-devel/2017-March/043530.html -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Mar 13 18:09:18 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 13 Mar 2017 17:09:18 +0000 Subject: [Koha-bugs] [Bug 18217] SMS alert number should be grouped with other borrower contact information. In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18217 --- Comment #1 from Owen Leonard --- I don't know how easy it would be to implement, but shouldn't we instead offer an option to specify one of the existing phone numbers (primary, secondary, other) as the SMS alert number? Could this be combined with Bug 11879? -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Mar 13 18:22:33 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 13 Mar 2017 17:22:33 +0000 Subject: [Koha-bugs] [Bug 7534] New OPACAllowUserToChooseBranch setting for only showing libraries allowing holds In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7534 --- Comment #37 from Lari Taskula --- Created attachment 61044 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=61044&action=edit Bug 7534: Validate pickup location in CanBook/ItemBeReserved This patch adds $branchcode_to parameter to CanBookBeReserved and CanItemBeReserved. It represents the pickup location for the hold. To test: 1. prove t/db_dependent/Holds.t -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Mar 13 18:22:54 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 13 Mar 2017 17:22:54 +0000 Subject: [Koha-bugs] [Bug 7534] New OPACAllowUserToChooseBranch setting for only showing libraries allowing holds In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7534 --- Comment #38 from Lari Taskula --- Created attachment 61045 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=61045&action=edit Bug 7534: Check hold availability to desired pickup location in opac-reserve.pl To test: -1. Have access to your browser's developer tools in order to modify dropdown values 1. Go to cgi-bin/koha/admin/branches.pl 2. Configure one of your libraries to "Pickup location" => "No". Remember the branchcode of this library! 3. Go place a hold in OPAC 4. See the provided "Pick up location" list 5. Observe the library that you configured is not present in the list 6. You should see another library selected by default. Right click that and in Firefox/Chrome click "Inspect element" 7. You should see a list of elements 8. Double click between value (xxxx in above example) and replace the value with the branchcode you remember from step 2. 9. Place the hold 10. Observe that you are taken to cgi-bin/koha/opac-user.pl but your hold was not successful. 11. Go back to place a hold and this time do not modify any values. 12. Observe that a hold is now placed. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Mar 13 18:39:22 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 13 Mar 2017 17:39:22 +0000 Subject: [Koha-bugs] [Bug 18256] New: Koha::Biblio - Remove GetItemsCount Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18256 Bug ID: 18256 Summary: Koha::Biblio - Remove GetItemsCount Change sponsored?: --- Product: Koha Version: unspecified Hardware: All OS: All Status: ASSIGNED Severity: normal Priority: P5 - low Component: Architecture, internals, and plumbing Assignee: jonathan.druart at bugs.koha-community.org Reporter: jonathan.druart at bugs.koha-community.org QA Contact: testopia at bugs.koha-community.org -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Mar 13 18:39:47 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 13 Mar 2017 17:39:47 +0000 Subject: [Koha-bugs] [Bug 17628] Move bibliographic related code to Koha::Biblio In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17628 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on| |18256 --- Comment #2 from Jonathan Druart --- Bug 18256 - Koha::Biblio - Remove GetItemsCount Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18256 [Bug 18256] Koha::Biblio - Remove GetItemsCount -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Mar 13 18:39:47 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 13 Mar 2017 17:39:47 +0000 Subject: [Koha-bugs] [Bug 18256] Koha::Biblio - Remove GetItemsCount In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18256 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |17628 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17628 [Bug 17628] Move bibliographic related code to Koha::Biblio -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Mar 13 18:45:07 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 13 Mar 2017 17:45:07 +0000 Subject: [Koha-bugs] [Bug 18256] Koha::Biblio - Remove GetItemsCount In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18256 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Mar 13 18:45:12 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 13 Mar 2017 17:45:12 +0000 Subject: [Koha-bugs] [Bug 18256] Koha::Biblio - Remove GetItemsCount In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18256 --- Comment #1 from Jonathan Druart --- Created attachment 61048 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=61048&action=edit Bug 18256: Koha::Items - Remove GetItemsCount C4::Items::GetItemsCount can be replaced with Koha::Biblio->items->count Test plan: Create a bibliographic record with items attached Try to delete the record from a basket (acquisition module), the detail page and the batch item deletion tool. => You should not be able to delete it. Remove the items and then try again to delete the record => Now you must be able to delete it. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Mar 13 18:48:19 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 13 Mar 2017 17:48:19 +0000 Subject: [Koha-bugs] [Bug 18256] Koha::Biblio - Remove GetItemsCount In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18256 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #61048|0 |1 is obsolete| | --- Comment #2 from Jonathan Druart --- Created attachment 61049 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=61049&action=edit Bug 18256: Koha::Items - Remove GetItemsCount C4::Items::GetItemsCount can be replaced with Koha::Biblio->items->count Test plan: Create a bibliographic record with items attached Try to delete the record from a basket (acquisition module), the detail page and the batch item deletion tool. => You should not be able to delete it. Remove the items and then try again to delete the record => Now you must be able to delete it. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Mar 13 18:51:50 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 13 Mar 2017 17:51:50 +0000 Subject: [Koha-bugs] [Bug 18257] New: Column visibility button does not increase colspan properly with pre-hidden columns Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18257 Bug ID: 18257 Summary: Column visibility button does not increase colspan properly with pre-hidden columns Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: trivial Priority: P5 - low Component: Circulation Assignee: koha-bugs at lists.koha-community.org Reporter: cbrannon at cdalibrary.org QA Contact: testopia at bugs.koha-community.org CC: gmcharlt at gmail.com, kyle.m.hall at gmail.com When toggling a column that is hidden by default in circulation.pl and moremember.pl, the "Today's checkouts" and "Previous checkouts" cells do not expand correctly. To test: 1) Go to circulation.pl and checkout an item. 2) Hide a column. See that the "Today's checkouts" cell is the correct length. 3) Show the hidden column. See that the cell is still the correct length. 4) Go to columns_settings.pl --> issues-table and hide one of the columns by default. 5) Go back to circulation.pl and show that hidden column. See that the "Today's checkouts" cell is shorter than the row. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Mon Mar 13 19:18:43 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 13 Mar 2017 18:18:43 +0000 Subject: [Koha-bugs] [Bug 18217] SMS alert number should be grouped with other borrower contact information. In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18217 --- Comment #2 from Barton Chittenden --- (In reply to Owen Leonard from comment #1) > I don't know how easy it would be to implement, but shouldn't we instead > offer an option to specify one of the existing phone numbers (primary, > secondary, other) as the SMS alert number? > > Could this be combined with Bug 11879? maybe a drop down... along the lines of SMS Alert Number [ [ Use Primary ] ] [ Use Secondary ] [ Use Other ] [ Enter SMS Number | | ] ? -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Mon Mar 13 19:26:49 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 13 Mar 2017 18:26:49 +0000 Subject: [Koha-bugs] [Bug 18258] New: Add the Koha::Biblio->subscriptions method Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18258 Bug ID: 18258 Summary: Add the Koha::Biblio->subscriptions method Change sponsored?: --- Product: Koha Version: unspecified Hardware: All OS: All Status: ASSIGNED Severity: enhancement Priority: P5 - low Component: Architecture, internals, and plumbing Assignee: jonathan.druart at bugs.koha-community.org Reporter: jonathan.druart at bugs.koha-community.org QA Contact: testopia at bugs.koha-community.org -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Mar 13 19:31:42 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 13 Mar 2017 18:31:42 +0000 Subject: [Koha-bugs] [Bug 18258] Add the Koha::Biblio->subscriptions method In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18258 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Mar 13 19:31:46 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 13 Mar 2017 18:31:46 +0000 Subject: [Koha-bugs] [Bug 18258] Add the Koha::Biblio->subscriptions method In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18258 --- Comment #1 from Jonathan Druart --- Created attachment 61050 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=61050&action=edit Bug 18258: Add the Koha::Biblio->subscriptions method Test plan: prove t/db_dependent/Koha/Biblios.t should return green -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Mar 13 19:32:40 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 13 Mar 2017 18:32:40 +0000 Subject: [Koha-bugs] [Bug 18259] New: Koha::Biblio - Remove GetSubscriptionsId Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18259 Bug ID: 18259 Summary: Koha::Biblio - Remove GetSubscriptionsId Change sponsored?: --- Product: Koha Version: unspecified Hardware: All OS: All Status: ASSIGNED Severity: enhancement Priority: P5 - low Component: Architecture, internals, and plumbing Assignee: jonathan.druart at bugs.koha-community.org Reporter: jonathan.druart at bugs.koha-community.org QA Contact: testopia at bugs.koha-community.org C4::Biblio::GetSubscriptionsId can be replaced using Koha::Biblio->subscriptions -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Mar 13 19:32:56 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 13 Mar 2017 18:32:56 +0000 Subject: [Koha-bugs] [Bug 18259] Koha::Biblio - Remove GetSubscriptionsId In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18259 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |17628 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17628 [Bug 17628] Move bibliographic related code to Koha::Biblio -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Mar 13 19:32:56 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 13 Mar 2017 18:32:56 +0000 Subject: [Koha-bugs] [Bug 17628] Move bibliographic related code to Koha::Biblio In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17628 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on| |18259 --- Comment #3 from Jonathan Druart --- Bug 18259 - Koha::Biblio - Remove GetSubscriptionsId Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18259 [Bug 18259] Koha::Biblio - Remove GetSubscriptionsId -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Mar 13 19:33:13 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 13 Mar 2017 18:33:13 +0000 Subject: [Koha-bugs] [Bug 18258] Add the Koha::Biblio->subscriptions method In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18258 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |18259 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18259 [Bug 18259] Koha::Biblio - Remove GetSubscriptionsId -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Mar 13 19:33:13 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 13 Mar 2017 18:33:13 +0000 Subject: [Koha-bugs] [Bug 18259] Koha::Biblio - Remove GetSubscriptionsId In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18259 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on| |18258 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18258 [Bug 18258] Add the Koha::Biblio->subscriptions method -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Mar 13 19:37:44 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 13 Mar 2017 18:37:44 +0000 Subject: [Koha-bugs] [Bug 18256] Koha::Biblio - Remove GetItemsCount In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18256 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |18259 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18259 [Bug 18259] Koha::Biblio - Remove GetSubscriptionsId -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Mar 13 19:37:44 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 13 Mar 2017 18:37:44 +0000 Subject: [Koha-bugs] [Bug 18259] Koha::Biblio - Remove GetSubscriptionsId In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18259 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on| |18256 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18256 [Bug 18256] Koha::Biblio - Remove GetItemsCount -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Mar 13 19:46:11 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 13 Mar 2017 18:46:11 +0000 Subject: [Koha-bugs] [Bug 18259] Koha::Biblio - Remove GetSubscriptionsId In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18259 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Mar 13 19:46:16 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 13 Mar 2017 18:46:16 +0000 Subject: [Koha-bugs] [Bug 18259] Koha::Biblio - Remove GetSubscriptionsId In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18259 --- Comment #1 from Jonathan Druart --- Created attachment 61051 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=61051&action=edit Bug 18259: Koha::Biblio - Remove GetSubscriptionsId C4::Biblio::GetSubscriptionsId can be replaced using Koha::Biblio->subscriptions Test plan: Create a new order for a bibliographic record Create a new subscription on this biblio >From the basket (acquisition), confirm that you are not able to delete the order with the biblio ("Can't cancel order and delete catalog record 1 subscription(s) left") Receive the order On the parcel page, confirm that you are not able to delete the order with the biblio -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Mar 13 20:26:38 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 13 Mar 2017 19:26:38 +0000 Subject: [Koha-bugs] [Bug 17708] Renewal log seems empty In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17708 Marjorie Barry-Vila changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |marjorie.barry-vila at ccsr.qc | |.ca -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Mar 13 20:29:34 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 13 Mar 2017 19:29:34 +0000 Subject: [Koha-bugs] [Bug 18256] Koha::Biblio - Remove GetItemsCount In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18256 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #61049|0 |1 is obsolete| | --- Comment #3 from Jonathan Druart --- Created attachment 61052 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=61052&action=edit Bug 18256: Koha::Items - Remove GetItemsCount C4::Items::GetItemsCount can be replaced with Koha::Biblio->items->count Test plan: Create a bibliographic record with items attached Try to delete the record from a basket (acquisition module), the detail page and the batch item deletion tool. => You should not be able to delete it. Remove the items and then try again to delete the record => Now you must be able to delete it. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Mar 13 20:30:59 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 13 Mar 2017 19:30:59 +0000 Subject: [Koha-bugs] [Bug 18249] Typo "resrerves" in en-NZ translation files In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18249 --- Comment #3 from Aleisha Amohia --- Oh I see, thanks! -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Mon Mar 13 20:39:29 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 13 Mar 2017 19:39:29 +0000 Subject: [Koha-bugs] [Bug 18260] Koha::Biblio - Remove GetBiblio In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18260 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on| |18256 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18256 [Bug 18256] Koha::Biblio - Remove GetItemsCount -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Mar 13 20:39:22 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 13 Mar 2017 19:39:22 +0000 Subject: [Koha-bugs] [Bug 18260] New: Koha::Biblio - Remove GetBiblio Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18260 Bug ID: 18260 Summary: Koha::Biblio - Remove GetBiblio Change sponsored?: --- Product: Koha Version: unspecified Hardware: All OS: All Status: ASSIGNED Severity: enhancement Priority: P5 - low Component: Architecture, internals, and plumbing Assignee: jonathan.druart at bugs.koha-community.org Reporter: jonathan.druart at bugs.koha-community.org QA Contact: testopia at bugs.koha-community.org C4::Biblio::GetBiblio can be replaced with Koha::Biblios->find -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Mar 13 20:39:29 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 13 Mar 2017 19:39:29 +0000 Subject: [Koha-bugs] [Bug 18256] Koha::Biblio - Remove GetItemsCount In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18256 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |18260 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18260 [Bug 18260] Koha::Biblio - Remove GetBiblio -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Mar 13 20:39:50 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 13 Mar 2017 19:39:50 +0000 Subject: [Koha-bugs] [Bug 17628] Move bibliographic related code to Koha::Biblio In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17628 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on| |18260 --- Comment #4 from Jonathan Druart --- Bug 18260 - Koha::Biblio - Remove GetBiblio Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18260 [Bug 18260] Koha::Biblio - Remove GetBiblio -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Mar 13 20:39:50 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 13 Mar 2017 19:39:50 +0000 Subject: [Koha-bugs] [Bug 18260] Koha::Biblio - Remove GetBiblio In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18260 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |17628 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17628 [Bug 17628] Move bibliographic related code to Koha::Biblio -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Mar 13 20:42:29 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 13 Mar 2017 19:42:29 +0000 Subject: [Koha-bugs] [Bug 13259] Set notforloan status when adding items to a course reserve In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13259 Alexandre changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |alexandre.breton at ccsr.qc.ca --- Comment #1 from Alexandre --- I was creating a new bug when I found an old one from my work partner... I decided to put my notes here as a supplement. Alternative title: Adding alerts when loaning a record from a course reserve When the staff put a record in a course reserve (with his barcode for example), the record stay avalable for loan. It must be corrected in a second step for which not all the staff are allowed to do it. Can we add an option "not for loan" when we transfer a record in a reserve ? (It will eliminate a step and some errors possibilities as it's not the same people making the 2 steps. Also, some items may be loaned by error when they are put in a course reserve. Path : 1) Go to "Course reserves" module 2) Select a course 3) Clic on "Add reserves" 4) On "Add items : scan barcode", I use "02500141x" because I know we already have in the system (put one that you are sure to have) 5) Select the record you entered in the reserve 6) Observe that no option are creating a "not for loan" status ($7) for the record, even if they are put in a reserve, they still available Then, we must change the status "not for loan" manually in a second step (with some upper staff rights). I see some solutions for this : - Add a dropdown menu linked to autorized values from NOT_LOAN function ($7) or at least, a "not for loan" option (y/n) on the same page - A alert message in a yellow square informing the user that he is about to loan a record in the reserve (with y/n) - All records put in a reserve will automatically have the "not for loan" status (This status will then return automatically to 0 value when the record exit the reserve.) Also, one of our users said that before around v3.12, when we are doing a loan from a reserve, we receive an alert "Are you sure you want to loan this record y/n ?" (or something like this.). But now, this message doesn't appears all the time (just when $7 was modified after the first step). Thanks all, Alexandre from CCSR -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Mon Mar 13 20:53:15 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 13 Mar 2017 19:53:15 +0000 Subject: [Koha-bugs] [Bug 18260] Koha::Biblio - Remove GetBiblio In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18260 --- Comment #1 from Jonathan Druart --- Created attachment 61053 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=61053&action=edit Bug 18260: Koha::Biblio - Remove GetBiblio C4::Biblio::GetBiblio can be replaced with Koha Biblio->find Test plan: Import batch, view issue history, search for items, see the image of a bibliographic record, modify and delete records in a batch -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Mar 13 20:53:10 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 13 Mar 2017 19:53:10 +0000 Subject: [Koha-bugs] [Bug 18260] Koha::Biblio - Remove GetBiblio In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18260 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Mar 13 21:28:33 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 13 Mar 2017 20:28:33 +0000 Subject: [Koha-bugs] [Bug 18261] New: Select item type not available when staff overrides hold policy Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18261 Bug ID: 18261 Summary: Select item type not available when staff overrides hold policy Change sponsored?: --- Product: Koha Version: unspecified Hardware: All OS: All Status: NEW Severity: minor Priority: P5 - low Component: Hold requests Assignee: koha-bugs at lists.koha-community.org Reporter: andreas.hedstrom.mace at sub.su.se QA Contact: testopia at bugs.koha-community.org CC: gmcharlt at gmail.com With AllowHoldItemTypeSelection set to Allow, it is possible to select an item type to fill the hold. But when staff overrides a circulation policy, the ?Request specific item type? dropdown on the place hold page only lists ?Any item type?, even if there are several items with various item types attached to the bibliographic record. We believe this to be a bug. To reproduce: Set AllowHoldItemTypeSelection to Allow. Set AllowHoldPolicyOverride to Allow. Create/choose a circulation rule for a patron category of your choice, allow holds and set On shelf holds allowed to ?If all unavailable?. Find or create a bibliographic record with two or more items, with two or more item types. Check out one item. Place a hold using the patron category for which you specified the circulation rule above. This should result in a staff override as this behaviour should not be allowed by the circulation policy. Try to request a specific item type, and confirm that choosing an item type is not available, the only option being ?Any item type?. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Mon Mar 13 21:55:17 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 13 Mar 2017 20:55:17 +0000 Subject: [Koha-bugs] [Bug 18262] New: Koha::Biblios - Remove GetBiblioData - part 1 Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18262 Bug ID: 18262 Summary: Koha::Biblios - Remove GetBiblioData - part 1 Change sponsored?: --- Product: Koha Version: unspecified Hardware: All OS: All Status: ASSIGNED Severity: enhancement Priority: P5 - low Component: Architecture, internals, and plumbing Assignee: jonathan.druart at bugs.koha-community.org Reporter: jonathan.druart at bugs.koha-community.org QA Contact: testopia at bugs.koha-community.org -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Mar 13 21:55:56 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 13 Mar 2017 20:55:56 +0000 Subject: [Koha-bugs] [Bug 17628] Move bibliographic related code to Koha::Biblio In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17628 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on| |18262 --- Comment #5 from Jonathan Druart --- Bug 18262 - Koha::Biblios - Remove GetBiblioData - part 1 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18262 [Bug 18262] Koha::Biblios - Remove GetBiblioData - part 1 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Mar 13 21:55:56 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 13 Mar 2017 20:55:56 +0000 Subject: [Koha-bugs] [Bug 18262] Koha::Biblios - Remove GetBiblioData - part 1 In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18262 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |17628 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17628 [Bug 17628] Move bibliographic related code to Koha::Biblio -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Mar 13 22:02:05 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 13 Mar 2017 21:02:05 +0000 Subject: [Koha-bugs] [Bug 18262] Koha::Biblios - Remove GetBiblioData - part 1 In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18262 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Mar 13 22:02:11 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 13 Mar 2017 21:02:11 +0000 Subject: [Koha-bugs] [Bug 18262] Koha::Biblios - Remove GetBiblioData - part 1 In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18262 --- Comment #1 from Jonathan Druart --- Created attachment 61054 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=61054&action=edit Bug 18262: Koha::Biblio - Remove GetBiblioData - part 1 Most of the time C4::Biblio::GetBiblioData is used to retrieve the title and/or the author of a bibliographic record. This patch replaces the easy occurrences of GetBiblioData, the ones where the 2 joins are needed, but only data from biblio and biblioitems table are. Test plan: It will be hard to test everything, I'd suggest a QAer to review this patch and confirm that the difference occurrences of GetBiblioData have been correctly replaced by calling Koha::Biblios->find or $biblio->bibioitem -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Mar 14 00:30:43 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 13 Mar 2017 23:30:43 +0000 Subject: [Koha-bugs] [Bug 18243] Bug 16034 follow-up: better handling of absence of WebService: :ILS::OverDrive::Patron at testing In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18243 Srdjan Jankovic changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Mar 14 00:30:45 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 13 Mar 2017 23:30:45 +0000 Subject: [Koha-bugs] [Bug 18243] Bug 16034 follow-up: better handling of absence of WebService: :ILS::OverDrive::Patron at testing In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18243 --- Comment #4 from Srdjan Jankovic --- Created attachment 61055 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=61055&action=edit Bug 18243: 16034 follow-up: Conditionally test Koha::ExternalContent::* modules loading To test: 1 - Make sure you don't have WebService::ILS installed 2 - prove t/00-load.t 3 - You should get a failure to load module and tests are skipped 4 - Apply patch 5 - prove t/00-load.t 6 - Module is not loaded, test are skipped Optional: 7 - Install WebService::ILS 5 - prove t/00-load.t 6 - Module is loaded, test passes -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Mar 14 00:32:21 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 13 Mar 2017 23:32:21 +0000 Subject: [Koha-bugs] [Bug 18243] Bug 16034 follow-up: better handling of absence of WebService: :ILS::OverDrive::Patron at testing In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18243 --- Comment #5 from Srdjan Jankovic --- Apologies for the late submission. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Mar 14 00:34:23 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 13 Mar 2017 23:34:23 +0000 Subject: [Koha-bugs] [Bug 16034] Integration with OverDrive Patron API In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16034 --- Comment #88 from Srdjan Jankovic --- (In reply to Jonathan Druart from comment #87) > (In reply to Srdjan Jankovic from comment #86) > > > Did you also fix comment 80? > > > > Not sure. I was not getting it in the first place. But 18234 should address > > that. > > It's bug 18243 I guess. > > And no, it does not: > Omg, must have had it in my PERL5LIB. Submitted to 18243. Sorry. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Mar 14 01:36:16 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 14 Mar 2017 00:36:16 +0000 Subject: [Koha-bugs] [Bug 18242] Remove primary key on old_issues.issue_id In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18242 Chris Cormack changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #60969|0 |1 is obsolete| | Attachment #60970|0 |1 is obsolete| | Attachment #60971|0 |1 is obsolete| | Attachment #60972|0 |1 is obsolete| | --- Comment #6 from Chris Cormack --- Created attachment 61056 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=61056&action=edit Bug 18242: [SOLUTION 2]Add tests Signed-off-by: Chris Cormack -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Mar 14 01:36:42 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 14 Mar 2017 00:36:42 +0000 Subject: [Koha-bugs] [Bug 18242] Remove primary key on old_issues.issue_id In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18242 Chris Cormack changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Mar 14 01:36:45 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 14 Mar 2017 00:36:45 +0000 Subject: [Koha-bugs] [Bug 18242] Remove primary key on old_issues.issue_id In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18242 Chris Cormack changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #60973|0 |1 is obsolete| | --- Comment #7 from Chris Cormack --- Created attachment 61057 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=61057&action=edit Bug 18242: [SOLUTION 2]Handle correctly move to old_issues The table old_issues has a primary key defined on the issue_id column. This issue_id comes from the issues table when an item is checked in. In some case the value of issue_id already exists in the table Basically this happens when an item is returned and mysqld is restarted: The auto increment value for issues.issue_id will be reset to MAX(issue_id)+1 (which is the value of the last entry of old_issues). See also the description of bug 18003 for more informations. In this solution the change is done at code level instead of DB structure: If old_issues.issue_id already exists before moving from the issues table, the issue_id is updated (not on cascade for accountlines.issue_id, should it?) before the move. Signed-off-by: Chris Cormack -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Mar 14 01:41:49 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 14 Mar 2017 00:41:49 +0000 Subject: [Koha-bugs] [Bug 17346] Enable the check in option in Columns settings In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17346 Nick Clemens changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |nick at bywatersolutions.com -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Mar 14 04:10:28 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 14 Mar 2017 03:10:28 +0000 Subject: [Koha-bugs] [Bug 18238] Test harness/suite/"test runner" In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18238 Mason James changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |mtj at kohaaloha.com -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Mar 14 08:09:51 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 14 Mar 2017 07:09:51 +0000 Subject: [Koha-bugs] [Bug 18262] Koha::Biblios - Remove GetBiblioData - part 1 In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18262 Marc V?ron changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |veron at veron.ch --- Comment #2 from Marc V?ron --- Small typo found: opac/opac-addbybiblionumber.pl line 145 my $biblio = Koha::Biblios->fin( $biblionumber ); should be: my $biblio = Koha::Biblios->find( $biblionumber ); -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Mar 14 09:32:09 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 14 Mar 2017 08:32:09 +0000 Subject: [Koha-bugs] [Bug 16969] Vulnerability warning for opac/opac-memberentry.pl In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16969 Chris Cormack changed: What |Removed |Added ---------------------------------------------------------------------------- Group|Koha security | Product|Koha security |Koha Component|Koha |OPAC Assignee|chris at bigballofwax.co.nz |oleonard at myacpl.org -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Mar 14 12:13:05 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 14 Mar 2017 11:13:05 +0000 Subject: [Koha-bugs] [Bug 13259] Set notforloan status when adding items to a course reserve In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13259 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |katrin.fischer at bsz-bw.de --- Comment #2 from Katrin Fischer --- Hi Alexandre, I think a lot of libraries use a different item type while the item is in course reserves that can be set to 'not for loan' or 'for reference'. Maybe this would help? The itemtype will move back to its original value automatically on removing the item from the course. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Tue Mar 14 12:14:25 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 14 Mar 2017 11:14:25 +0000 Subject: [Koha-bugs] [Bug 14150] Field issues.date_due does not display in ISSUESLIP or ISSUEQSLIP In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14150 --- Comment #9 from Katrin Fischer --- Maybe something to check: check if the time shows if you do an hourly loan with the time not bing 23:59 - we might just not show the time in this case. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Mar 14 12:17:00 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 14 Mar 2017 11:17:00 +0000 Subject: [Koha-bugs] [Bug 14608] HEA : add possibility of sharing usage statistics in Administration page and Web installer In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14608 --- Comment #43 from Katrin Fischer --- Just a note: Translating the countries is quite a bit of work, please make sure the include file is translatable - looking at it I am not sure as there is no HTML. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Mar 14 12:22:08 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 14 Mar 2017 11:22:08 +0000 Subject: [Koha-bugs] [Bug 17098] Validation problems with form field type "number" ( decimal separator) In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17098 --- Comment #8 from Katrin Fischer --- (In reply to Jonathan Druart from comment #5) > I do not recreate, on /members/maninvoice.pl?borrowernumber=5, I tried with > FF ESR 45.4.0 and Chromium 55.0.2883.75. > With de-DE, I do see lang=de-DE, but 12.3 and 12,3 are ok Hm. That's odd. Might be some change in browser behaviour? We are using ESR at work too. Will retest. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Mar 14 13:18:31 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 14 Mar 2017 12:18:31 +0000 Subject: [Koha-bugs] [Bug 15108] OAI-PMH provider improvements In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15108 Olli-Antti Kivilahti changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |Signed Off -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Mar 14 13:32:15 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 14 Mar 2017 12:32:15 +0000 Subject: [Koha-bugs] [Bug 6473] Test bug for Git-bz In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6473 sandboxes at biblibre.com changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #49083|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Mar 14 13:32:24 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 14 Mar 2017 12:32:24 +0000 Subject: [Koha-bugs] [Bug 6473] Test bug for Git-bz In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6473 sandboxes at biblibre.com changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #56974|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Mar 14 13:48:24 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 14 Mar 2017 12:48:24 +0000 Subject: [Koha-bugs] [Bug 17519] Item editor handles clearing dateaccessioned and replacementpricedate inconsistently In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17519 --- Comment #5 from Marcel de Rooy --- (In reply to Jonathan Druart from comment #4) > It seems that replacement price is ok before this patch, and the patch does > not affect it. Should we rename the bug report and the commit msg? No problem. What would you suggest? The inconsistency is in the comparison between how both fields behave. So maybe: Handle clearing dateaccessioned just like replacementpricedate? Or just Fix clearing dateaccessioned? -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Mar 14 13:49:26 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 14 Mar 2017 12:49:26 +0000 Subject: [Koha-bugs] [Bug 18262] Koha::Biblios - Remove GetBiblioData - part 1 In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18262 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #61054|0 |1 is obsolete| | --- Comment #3 from Jonathan Druart --- Created attachment 61058 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=61058&action=edit Bug 18262: Koha::Biblio - Remove GetBiblioData - part 1 Most of the time C4::Biblio::GetBiblioData is used to retrieve the title and/or the author of a bibliographic record. This patch replaces the easy occurrences of GetBiblioData, the ones where the 2 joins are needed, but only data from biblio and biblioitems table are. Test plan: It will be hard to test everything, I'd suggest a QAer to review this patch and confirm that the difference occurrences of GetBiblioData have been correctly replaced by calling Koha::Biblios->find or $biblio->bibioitem -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Mar 14 13:51:04 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 14 Mar 2017 12:51:04 +0000 Subject: [Koha-bugs] [Bug 6473] Test bug for Git-bz In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6473 Julian Maurice changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |julian.maurice at biblibre.com Attachment #56974|1 |0 is obsolete| | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Mar 14 13:52:49 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 14 Mar 2017 12:52:49 +0000 Subject: [Koha-bugs] [Bug 6473] Test bug for Git-bz In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6473 sandboxes at biblibre.com changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #56974|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Mar 14 13:53:01 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 14 Mar 2017 12:53:01 +0000 Subject: [Koha-bugs] [Bug 6473] Test bug for Git-bz In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6473 --- Comment #186 from sandboxes at biblibre.com --- Created attachment 61059 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=61059&action=edit Bug 6473: just a test https://bugs.koha-community.org/show_bug.cgi?id=6473 Signed-off-by: Julian Maurice Signed-off-by: Julian Maurice -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Mar 14 14:00:17 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 14 Mar 2017 13:00:17 +0000 Subject: [Koha-bugs] [Bug 7143] Bug for tracking changes to the about page In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7143 Kyle M Hall changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #60448|0 |1 is obsolete| | --- Comment #358 from Kyle M Hall --- Comment on attachment 60448 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=60448 Bug 7143: Replace Santallan by Santellan Pushed to master for 17.05! -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Tue Mar 14 14:00:33 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 14 Mar 2017 13:00:33 +0000 Subject: [Koha-bugs] [Bug 7143] Bug for tracking changes to the about page In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7143 Kyle M Hall changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |ASSIGNED -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Mar 14 14:03:43 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 14 Mar 2017 13:03:43 +0000 Subject: [Koha-bugs] [Bug 6473] Test bug for Git-bz In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6473 --- Comment #187 from sandboxes at biblibre.com --- Patch tested with a sandbox, by Julian Maurice -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Mar 14 14:04:15 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 14 Mar 2017 13:04:15 +0000 Subject: [Koha-bugs] [Bug 14365] SQL Reports Last Edit Date column In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14365 Kyle M Hall changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Mar 14 14:04:25 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 14 Mar 2017 13:04:25 +0000 Subject: [Koha-bugs] [Bug 14365] SQL Reports Last Edit Date column In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14365 --- Comment #7 from Kyle M Hall --- Created attachment 61061 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=61061&action=edit [SIGNED-OFF] Bug 14365 - SQL Reports Last Edit Date column - Show in interface Test Plan: 1) Apply these patches 2) Modify a saved sql report 3) Note the "Last modified" column is updated 4) Run the report 5) Note the "Last run" column is updated Signed-off-by: Cab Vinton Signed-off-by: Kyle M Hall -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Mar 14 14:04:18 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 14 Mar 2017 13:04:18 +0000 Subject: [Koha-bugs] [Bug 14365] SQL Reports Last Edit Date column In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14365 Kyle M Hall changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #59988|0 |1 is obsolete| | Attachment #59989|0 |1 is obsolete| | Attachment #60752|0 |1 is obsolete| | --- Comment #6 from Kyle M Hall --- Created attachment 61060 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=61060&action=edit [SIGNED-OFF] Bug 14365 - Populate never used saved_sql column last_run when execute_query is called Signed-off-by: Cab Vinton Signed-off-by: Kyle M Hall -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Mar 14 14:04:28 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 14 Mar 2017 13:04:28 +0000 Subject: [Koha-bugs] [Bug 14365] SQL Reports Last Edit Date column In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14365 --- Comment #8 from Kyle M Hall --- Created attachment 61062 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=61062&action=edit [SIGNED-OFF] Bug 14365 - Change 'Last modified' to 'Last edit' for terseness Signed-off-by: Cab Vinton Signed-off-by: Kyle M Hall -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Mar 14 14:07:53 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 14 Mar 2017 13:07:53 +0000 Subject: [Koha-bugs] [Bug 6473] Test bug for Git-bz In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6473 Julian Maurice changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Mar 14 14:08:46 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 14 Mar 2017 13:08:46 +0000 Subject: [Koha-bugs] [Bug 6473] Test bug for Git-bz In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6473 sandboxes at biblibre.com changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off --- Comment #188 from sandboxes at biblibre.com --- Patch tested with a sandbox, by Julian Maurice -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Mar 14 14:13:18 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 14 Mar 2017 13:13:18 +0000 Subject: [Koha-bugs] [Bug 18263] New: Make use of syspref 'CurrencyFormat' for Account and Pay fines tables Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18263 Bug ID: 18263 Summary: Make use of syspref 'CurrencyFormat' for Account and Pay fines tables Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: trivial Priority: P5 - low Component: Patrons Assignee: koha-bugs at lists.koha-community.org Reporter: veron at veron.ch QA Contact: testopia at bugs.koha-community.org CC: gmcharlt at gmail.com, kyle.m.hall at gmail.com On Home > Patrons > Accounts for... and Home > Patrons > Pay fines for..., make the amounts display as defined in syspref 'CurrencyFormat' -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Tue Mar 14 14:13:50 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 14 Mar 2017 13:13:50 +0000 Subject: [Koha-bugs] [Bug 18263] Make use of syspref 'CurrencyFormat' for Account and Pay fines tables In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18263 Marc V?ron changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|koha-bugs at lists.koha-commun |veron at veron.ch |ity.org | -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Mar 14 14:16:06 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 14 Mar 2017 13:16:06 +0000 Subject: [Koha-bugs] [Bug 18243] Bug 16034 follow-up: better handling of absence of WebService: :ILS::OverDrive::Patron at testing In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18243 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Mar 14 14:16:10 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 14 Mar 2017 13:16:10 +0000 Subject: [Koha-bugs] [Bug 18243] Bug 16034 follow-up: better handling of absence of WebService: :ILS::OverDrive::Patron at testing In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18243 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #61039|0 |1 is obsolete| | Attachment #61055|0 |1 is obsolete| | --- Comment #6 from Jonathan Druart --- Created attachment 61063 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=61063&action=edit Bug 18243: 16034 follow-up: better handling of absence of WebService::ILS::OverDrive::Patron at testing To test: 1 - Make sure you don't have WebService::ILS::OverDrive::Patron installed 2 - prove t/Koha_ExternalContent_OverDrive.t 3 - You should get a failure to load module and tests are skipped 4 - Apply patch 5 - prove t/Koha_ExternalContent_OverDrive.t 6 - Module is not loaded, test are skipped Fixed small typo 'cannot filnd' -> 'cannot find' Signed-off-by: Nick Clemens Signed-off-by: Jonathan Druart Signed-off-by: Jonathan Druart -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Mar 14 14:16:15 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 14 Mar 2017 13:16:15 +0000 Subject: [Koha-bugs] [Bug 18243] Bug 16034 follow-up: better handling of absence of WebService: :ILS::OverDrive::Patron at testing In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18243 --- Comment #7 from Jonathan Druart --- Created attachment 61064 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=61064&action=edit Bug 18243: 16034 follow-up: Conditionally test Koha::ExternalContent::* modules loading To test: 1 - Make sure you don't have WebService::ILS installed 2 - prove t/00-load.t 3 - You should get a failure to load module and tests are skipped 4 - Apply patch 5 - prove t/00-load.t 6 - Module is not loaded, test are skipped Optional: 7 - Install WebService::ILS 5 - prove t/00-load.t 6 - Module is loaded, test passes Signed-off-by: Jonathan Druart -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Mar 14 14:16:35 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 14 Mar 2017 13:16:35 +0000 Subject: [Koha-bugs] [Bug 18243] Bug 16034 follow-up: better handling of absence of WebService: :ILS::OverDrive::Patron at testing In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18243 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA --- Comment #8 from Jonathan Druart --- Ok thanks, skipping QA. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Mar 14 14:16:43 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 14 Mar 2017 13:16:43 +0000 Subject: [Koha-bugs] [Bug 18243] Bug 16034 follow-up: better handling of absence of WebService: :ILS::OverDrive::Patron at testing In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18243 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- QA Contact|gmcharlt at gmail.com |jonathan.druart at bugs.koha-c | |ommunity.org -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Mar 14 14:21:59 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 14 Mar 2017 13:21:59 +0000 Subject: [Koha-bugs] [Bug 14608] HEA : add possibility of sharing usage statistics in Administration page and Web installer In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14608 --- Comment #44 from Jonathan Druart --- (In reply to Katrin Fischer from comment #43) > Just a note: Translating the countries is quite a bit of work, please make > sure the include file is translatable - looking at it I am not sure as there > is no HTML. I thought they were already not translatable on the prefs page, because they are translated in the DB and how we handle all of that is completely buggy. But actually they are translated... I really would prefer to deal with that on another bug report, and find a way to use the same file from the pref and admin pages. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Mar 14 14:25:23 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 14 Mar 2017 13:25:23 +0000 Subject: [Koha-bugs] [Bug 14957] Write protecting MARC fields based on source of import In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14957 David Gustafsson changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #60825|0 |1 is obsolete| | --- Comment #50 from David Gustafsson --- Created attachment 61065 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=61065&action=edit Bug 14957 - Rule based permission for MARC fields Add a rule based permission system for MARC field modifications. Test plan: 1. Apply this patch 2. Run updatedatabase.pl 3. Log in to staff client 4. Enable new syspref MARCPermissions 5. You should see a new link "MARC field permissions" in the "Catalog" section under "Koha administrtion". 6. Go to the "MARC field permissions" page 7. Next to the page heading ("Manage MARC field permissions") there is a button with a question mark, click this for more information about the rule system. 8. Add desired rules to the rule table, press the +-button to add. 9. Clicking the pen-icon (edit) should allow you to edit corresponding rule. 10. Clicking the x-icon should remove corresponding rule after confirmation. 11. Selecting one or more rules followed by clicking the trash-icon should remove all selected rules after confirmation. 12. To test your rules, import or in other way modify a record. 13. Check that the record was modified as defined by your rules. Sponsored-by: Halland County Library -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Mar 14 14:26:14 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 14 Mar 2017 13:26:14 +0000 Subject: [Koha-bugs] [Bug 17519] Item editor handles clearing dateaccessioned and replacementpricedate inconsistently In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17519 --- Comment #6 from Jonathan Druart --- Marcel, sorry but I do not understand your answer. I am just saying that replacementpricedate is working correctly without your patch, so we should remove it from the bug title and commit message. Do you agree? -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Mar 14 14:28:17 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 14 Mar 2017 13:28:17 +0000 Subject: [Koha-bugs] [Bug 6473] Test bug for Git-bz In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6473 Julian Maurice changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Mar 14 14:31:16 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 14 Mar 2017 13:31:16 +0000 Subject: [Koha-bugs] [Bug 17941] CanBookBeRenewed is very inefficient/slow In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17941 --- Comment #41 from Jonathan Druart --- (In reply to Katrin Fischer from comment #40) > This seems to use some new constructs, is this safe for backporting to > 16.11.x? That would need to be tested, I only tested against master. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Mar 14 14:32:02 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 14 Mar 2017 13:32:02 +0000 Subject: [Koha-bugs] [Bug 14957] Write protecting MARC fields based on source of import In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14957 --- Comment #51 from David Gustafsson --- Made some small adjustments: - Removed $options-{filter} arguments from ModBiblioMarc in AddBiblio since ApplyMarcPermissions is never run on adding new biblios anyways (since no caller uses it, and marc-xml for current biblionumber will always be empty on save and ApplyMarcPermissions will bail out anyway), and to provide that arguments makes things even more confusing. - Added source => 'batchimport' for staged import batches. So now ApplyMarcPermissions runs also on staged imports. One thing I did not realize before is that marc permissions are never enforced adding new biblios, this is also the case for staged imports. Only if a match is found permissions will be applied. It would probably be more appropriate to call the current system "Marc merge rules" or something like that, since it is really a framework for defining what happens when two marc records are to be merged (and not "permissions" in the strict sense of the word). -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Mar 14 14:33:23 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 14 Mar 2017 13:33:23 +0000 Subject: [Koha-bugs] [Bug 16327] Running build_oai_sets.pl with embed items option should consider every item in a biblio In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16327 --- Comment #1 from Pedro Amorim --- The solution is shared in the following community entry: https://lists.katipo.co.nz/public/koha/2016-April/045257.html -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Mar 14 14:34:02 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 14 Mar 2017 13:34:02 +0000 Subject: [Koha-bugs] [Bug 18263] Make use of syspref 'CurrencyFormat' for Account and Pay fines tables In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18263 --- Comment #1 from Marc V?ron --- Created attachment 61066 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=61066&action=edit Bug 18263: Make use of syspref 'CurrencyFormat' for Account and Pay fines tables On Home > Patrons > Accounts for... and Home > Patrons > Pay fines for..., make the amounts display as defined in syspref 'CurrencyFormat' To test: - Apply patch - Give a patron a high fine or credit (e.g. 12345.67) - Got to pages Home > Patrons > Accounts for... and Home > Patrons > Pay fines - Verify that amounts display following syspref 'CurrencyFormat' (e.g. 12'345.67 for syspref set to 360'000.00 (CH) -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Mar 14 14:53:57 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 14 Mar 2017 13:53:57 +0000 Subject: [Koha-bugs] [Bug 18263] Make use of syspref 'CurrencyFormat' for Account and Pay fines tables In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18263 Marc V?ron changed: What |Removed |Added ---------------------------------------------------------------------------- Patch complexity|--- |Trivial patch Status|NEW |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Mar 14 14:55:36 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 14 Mar 2017 13:55:36 +0000 Subject: [Koha-bugs] [Bug 17519] Item editor handles clearing dateaccessioned and replacementpricedate inconsistently In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17519 --- Comment #7 from Marcel de Rooy --- (In reply to Jonathan Druart from comment #6) > Marcel, sorry but I do not understand your answer. > I am just saying that replacementpricedate is working correctly without your > patch, so we should remove it from the bug title and commit message. > Do you agree? Yes, no problem. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Mar 14 14:58:32 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 14 Mar 2017 13:58:32 +0000 Subject: [Koha-bugs] [Bug 15406] Very SLOW OAI server performance In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15406 Olli-Antti Kivilahti changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |olli-antti.kivilahti at jns.fi --- Comment #6 from Olli-Antti Kivilahti --- Then please go sign it off! -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Mar 14 15:18:48 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 14 Mar 2017 14:18:48 +0000 Subject: [Koha-bugs] [Bug 18186] Amounts with decimal comma instead of decimal dot breaking payments In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18186 Marc V?ron changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |veron at veron.ch -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Mar 14 15:19:41 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 14 Mar 2017 14:19:41 +0000 Subject: [Koha-bugs] [Bug 18264] New: Course reserves - use itemnumber for editing existing reserve items Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18264 Bug ID: 18264 Summary: Course reserves - use itemnumber for editing existing reserve items Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: normal Priority: P5 - low Component: Course reserves Assignee: koha-bugs at lists.koha-community.org Reporter: nick at bywatersolutions.com QA Contact: testopia at bugs.koha-community.org Some libraries have found that when using course reserves an item will have the barcode removed. If this happens the edit links break. We should use the itemnumber for links. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Tue Mar 14 15:21:41 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 14 Mar 2017 14:21:41 +0000 Subject: [Koha-bugs] [Bug 18264] Course reserves - use itemnumber for editing existing reserve items In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18264 Nick Clemens changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff Patch complexity|--- |Trivial patch -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Tue Mar 14 15:21:44 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 14 Mar 2017 14:21:44 +0000 Subject: [Koha-bugs] [Bug 18264] Course reserves - use itemnumber for editing existing reserve items In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18264 --- Comment #1 from Nick Clemens --- Created attachment 61067 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=61067&action=edit Bug 18264 - Course reserves - use itemnumber for editing existing reserve items This patch alters the crouse reserves module to use itemnumber as the lookup method for existing reserves as opposed to barcode To test: 1 - Apply patch 2 - Add some items to a course reserves - all should work as expected 3 - Delete the barcode for an item on reserve 4 - Note the edit link still resolves to the correct item -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Mar 14 15:22:00 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 14 Mar 2017 14:22:00 +0000 Subject: [Koha-bugs] [Bug 18264] Course reserves - use itemnumber for editing existing reserve items In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18264 Nick Clemens changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|koha-bugs at lists.koha-commun |nick at bywatersolutions.com |ity.org | -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Tue Mar 14 15:26:04 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 14 Mar 2017 14:26:04 +0000 Subject: [Koha-bugs] [Bug 7143] Bug for tracking changes to the about page In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7143 Tom?s Cohen Arazi changed: What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Tue Mar 14 15:26:19 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 14 Mar 2017 14:26:19 +0000 Subject: [Koha-bugs] [Bug 7143] Bug for tracking changes to the about page In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7143 --- Comment #359 from Tom?s Cohen Arazi --- Created attachment 61068 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=61068&action=edit Bug 7143: Add Patricio Marrone to history.txt Signed-off-by: Tomas Cohen Arazi -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Mar 14 15:28:12 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 14 Mar 2017 14:28:12 +0000 Subject: [Koha-bugs] [Bug 18265] New: Followup to Buuug 17196. deletedbiblio_metadata is not used. biblioitemnumber was forgot. Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18265 Bug ID: 18265 Summary: Followup to Buuug 17196. deletedbiblio_metadata is not used. biblioitemnumber was forgot. Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Cataloging Assignee: gmcharlt at gmail.com Reporter: olli-antti.kivilahti at jns.fi QA Contact: testopia at bugs.koha-community.org CC: m.de.rooy at rijksmuseum.nl Exhibit 1: The MARCXML is lost when the biblio is deleted because the values in biblio_metadata-table from biblioitems-table are never moved to deletedbiblio_metadata-table. Previously the marcxml was preserved in the oldbiblioitems-table This is a challenge for gathering statistics For example item has been ordered, received, and removed from collection during the statistics period Information in marcxml is needed to accurately categorize the item Exhibit 2: [15:22:38] also. In Koha there once was a great idea that one biblio-entry can have multiple biblioitems [15:22:45] and the marcxml was tied to the biblioitems-table [15:23:11] this is a nice idea, but nobdy really cared for it and now biblionumber and biblioitemnumber are used interchangeably [15:23:22] except when they get out of sync during a data migration [15:23:41] then things start to work really interestingly [15:23:47] but the point is [15:23:57] biblio_metadata has a biblionumber-column [15:24:15] shouldn't it have a biblioitemnumber-column, just for old time's sake? In the biblioitems-table we had marcxml. primary keyed with biblioitemnumber. Now the marcxml is moved to biblio_metadata and the foreign key reference was simplified to biblionumber. This makes the existing FRBR-bug worse. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Mar 14 15:34:09 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 14 Mar 2017 14:34:09 +0000 Subject: [Koha-bugs] [Bug 6473] Test bug for Git-bz In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6473 Paul Poulain changed: What |Removed |Added ---------------------------------------------------------------------------- CC|paul.poulain at biblibre.com, | |sandboxes at biblibre.com | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Mar 14 15:37:59 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 14 Mar 2017 14:37:59 +0000 Subject: [Koha-bugs] [Bug 17196] Move marcxml out of the biblioitems table In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17196 Olli-Antti Kivilahti changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |olli-antti.kivilahti at jns.fi --- Comment #134 from Olli-Antti Kivilahti --- I don't want to beat a dead horse, but can't resist: > There are several goals to do it: > - Performance > As Paul Poulain wrote, a simple query like > SELECT publicationyear, count(publicationyear) FROM biblioitems GROUP BY > publicationyear; > takes more than 10min on a DB with more than 1M bibliographic records > but only 3sec (!) on the same DB without the biblioitems.marcxml field All our test environments: MariaDB [koha]> SELECT COUNT(*) FROM biblioitems; +----------+ | COUNT(*) | +----------+ | 1424537 | +----------+ 1 row in set (0.34 sec) On Ubuntu14.04 MariaDB using a normal 10k HDD with Intel Xeon 3GHz: innodb_buffer_pool_size = 128MB MariaDB [koha]> SELECT publicationyear, count(publicationyear) FROM biblioitems GROUP BY publicationyear; +-----------------+------------------------+ | publicationyear | count(publicationyear) | +-----------------+------------------------+ | NULL | 0 | +-----------------+------------------------+ 1 row in set (39.64 sec) The search is arguably slow. I wonder how the performance inspiration server (10 min search time) is configured? On Ubuntu14.04 MariaDB using RAID-1 SSD with Intel Xeon 3GHz 32GB RAM innodb_buffer_pool_size = 24G (Percona autoconfigurer) MariaDB [koha]> SELECT publicationyear, count(publicationyear) FROM biblioitems GROUP BY publicationyear; +-----------------+------------------------+ | publicationyear | count(publicationyear) | +-----------------+------------------------+ | NULL | 0 | +-----------------+------------------------+ 1 row in set (5.56 sec) RAM and SSDs are really cheap nowadays. See also Bug 18265 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Mar 14 15:38:27 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 14 Mar 2017 14:38:27 +0000 Subject: [Koha-bugs] [Bug 17196] Move marcxml out of the biblioitems table In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17196 Olli-Antti Kivilahti changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |18265 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18265 [Bug 18265] Followup to Buuug 17196. deletedbiblio_metadata is not used. biblioitemnumber was forgot. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Mar 14 15:38:27 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 14 Mar 2017 14:38:27 +0000 Subject: [Koha-bugs] [Bug 18265] Followup to Buuug 17196. deletedbiblio_metadata is not used. biblioitemnumber was forgot. In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18265 Olli-Antti Kivilahti changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on| |17196 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17196 [Bug 17196] Move marcxml out of the biblioitems table -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Mar 14 15:43:06 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 14 Mar 2017 14:43:06 +0000 Subject: [Koha-bugs] [Bug 18266] New: Internal Server Error when paying fine for lost item Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18266 Bug ID: 18266 Summary: Internal Server Error when paying fine for lost item Change sponsored?: --- Product: Koha Version: unspecified Hardware: All OS: All Status: NEW Severity: normal Priority: P5 - low Component: Circulation Assignee: koha-bugs at lists.koha-community.org Reporter: veron at veron.ch QA Contact: testopia at bugs.koha-community.org CC: gmcharlt at gmail.com, kyle.m.hall at gmail.com To reproduce: - Create a Manual invoice for a patron, select Type: Lost Item - Do not fill in Barcode, Description - Give the invoice an amount that is easy to identify - Go to tab "Pay fines" - Identify row of new fine, click "Pay" - On the following page, click "Confirm" Result: "Internal Server Error" plack error log says: Can't call method "last_returned_by" on an undefined value at /home/marc/koha/C4/Circulation.pm line 2188. - Repeat steps above, insert a valid Barcode of an item that is lost. Same result. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Mar 14 15:46:45 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 14 Mar 2017 14:46:45 +0000 Subject: [Koha-bugs] [Bug 17462] Pay fines not accepting ', ' for EUR currency input In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17462 Marc V?ron changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |https://bugs.koha-community | |.org/bugzilla3/show_bug.cgi | |?id=18186 -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Mar 14 15:46:45 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 14 Mar 2017 14:46:45 +0000 Subject: [Koha-bugs] [Bug 18186] Amounts with decimal comma instead of decimal dot breaking payments In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18186 Marc V?ron changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |https://bugs.koha-community | |.org/bugzilla3/show_bug.cgi | |?id=17462 -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Mar 14 16:06:13 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 14 Mar 2017 15:06:13 +0000 Subject: [Koha-bugs] [Bug 6473] Test bug for Git-bz In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6473 sandboxes at biblibre.com changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off CC| |sandboxes at biblibre.com --- Comment #189 from sandboxes at biblibre.com --- Patch tested with a sandbox, by Julian Maurice -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Mar 14 16:06:43 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 14 Mar 2017 15:06:43 +0000 Subject: [Koha-bugs] [Bug 6473] Test bug for Git-bz In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6473 --- Comment #190 from sandboxes at biblibre.com --- Created attachment 61069 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=61069&action=edit Bug 6473: just a test https://bugs.koha-community.org/show_bug.cgi?id=6473 Signed-off-by: Julian Maurice Signed-off-by: Julian Maurice Signed-off-by: Julian Maurice -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Mar 14 16:06:33 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 14 Mar 2017 15:06:33 +0000 Subject: [Koha-bugs] [Bug 6473] Test bug for Git-bz In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6473 sandboxes at biblibre.com changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #61059|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Mar 14 16:11:51 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 14 Mar 2017 15:11:51 +0000 Subject: [Koha-bugs] [Bug 17196] Move marcxml out of the biblioitems table In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17196 --- Comment #135 from Jonathan Druart --- (In reply to Olli-Antti Kivilahti from comment #134) > I don't want to beat a dead horse, but can't resist: Try to be around when we ask for feedbacks and tests, *before* things are pushed. I am sure it would be more useful for everybody. I cannot count how many times I have asked for help on this one. > The search is arguably slow. > I wonder how the performance inspiration server (10 min search time) is > configured? "This is a test DB, not optimized, but we were surprised by the results." http://lists.koha-community.org/pipermail/koha-devel/2016-July/042821.html -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Mar 14 16:14:50 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 14 Mar 2017 15:14:50 +0000 Subject: [Koha-bugs] [Bug 18266] Internal Server Error when paying fine for lost item In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18266 Marc V?ron changed: What |Removed |Added ---------------------------------------------------------------------------- Version|unspecified |master --- Comment #1 from Marc V?ron --- Following finding: sub pay in Koha/Account.pm line 106 triggers C4::Circulation::ReturnLostItem ( $self->{patron_id}, $fine->itemnumber ); $fine->itemnumber is not defined. But should payment for a lost item mark the item as returned? Payment for an item that is lost does not necessarily mean that the item is already replaced or will be replaced at all. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Tue Mar 14 16:17:30 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 14 Mar 2017 15:17:30 +0000 Subject: [Koha-bugs] [Bug 18242] Remove primary key on old_issues.issue_id In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18242 Tom?s Cohen Arazi changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |tomascohen at gmail.com Version|unspecified |master -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Mar 14 16:18:32 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 14 Mar 2017 15:18:32 +0000 Subject: [Koha-bugs] [Bug 15336] Script for merging vendors In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15336 Alex Arnaud changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #45530|0 |1 is obsolete| | Attachment #45607|0 |1 is obsolete| | Attachment #45777|0 |1 is obsolete| | Attachment #49313|0 |1 is obsolete| | --- Comment #19 from Alex Arnaud --- Created attachment 61070 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=61070&action=edit Bug 15336 - New command-line script: merge_bookseller.pl Test plan (i.e. merge bookseller n? 3 into the n? 6): run perl misc/migration_tools/merge_booksellers.pl -f 3 -t 6 -v -c Check that basketgroups, baskets, contacts, contracts and invoices had moved into bookseller 6. Check that bookseller n? 3 has been deleted. Remove -c (confirm) parameter to run in test mode only. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Mar 14 16:19:34 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 14 Mar 2017 15:19:34 +0000 Subject: [Koha-bugs] [Bug 15336] Script for merging vendors In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15336 Alex Arnaud changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Mar 14 16:25:20 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 14 Mar 2017 15:25:20 +0000 Subject: [Koha-bugs] [Bug 14608] HEA : add possibility of sharing usage statistics in Administration page and Web installer In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14608 --- Comment #45 from Katrin Fischer --- They are translated via the yaml file - the memory of translating them is still fresh. Having only one list would be preferable of course. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Mar 14 16:26:10 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 14 Mar 2017 15:26:10 +0000 Subject: [Koha-bugs] [Bug 15336] Script for merging vendors In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15336 Alex Arnaud changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #61070|0 |1 is obsolete| | --- Comment #20 from Alex Arnaud --- Created attachment 61071 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=61071&action=edit Bug 15336 - New command-line script: merge_bookseller.pl Test plan (i.e. merge bookseller n? 3 into the n? 6): run perl misc/migration_tools/merge_booksellers.pl -f 3 -t 6 -v -c Check that basketgroups, baskets, contacts, contracts and invoices had moved into bookseller 6. Check that bookseller n? 3 has been deleted. Remove -c (confirm) parameter to run in test mode only. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Mar 14 16:29:46 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 14 Mar 2017 15:29:46 +0000 Subject: [Koha-bugs] [Bug 17519] Item editor handles clearing dateaccessioned and replacementpricedate inconsistently In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17519 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |katrin.fischer at bsz-bw.de --- Comment #8 from Katrin Fischer --- Will this effect the automatic setting of dateaccessioned on leaving it empty when saving? We rely on this behaviour at the moment. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Mar 14 16:33:23 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 14 Mar 2017 15:33:23 +0000 Subject: [Koha-bugs] [Bug 17519] Item editor handles clearing dateaccessioned and replacementpricedate inconsistently In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17519 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |In Discussion -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Mar 14 16:37:14 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 14 Mar 2017 15:37:14 +0000 Subject: [Koha-bugs] [Bug 17519] Item editor handles clearing dateaccessioned and replacementpricedate inconsistently In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17519 --- Comment #9 from Marcel de Rooy --- (In reply to Katrin Fischer from comment #8) > Will this effect the automatic setting of dateaccessioned on leaving it > empty when saving? We rely on this behaviour at the moment. Please explain what you mean. Where do you rely on exactly? -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Mar 14 16:40:49 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 14 Mar 2017 15:40:49 +0000 Subject: [Koha-bugs] [Bug 18265] Followup to Bug 17196. deletedbiblio_metadata is not used. biblioitemnumber was forgotten In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18265 Owen Leonard changed: What |Removed |Added ---------------------------------------------------------------------------- Summary|Followup to Buuug 17196. |Followup to Bug 17196. |deletedbiblio_metadata is |deletedbiblio_metadata is |not used. biblioitemnumber |not used. biblioitemnumber |was forgot. |was forgotten -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Mar 14 16:48:07 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 14 Mar 2017 15:48:07 +0000 Subject: [Koha-bugs] [Bug 17519] Item editor handles clearing dateaccessioned and replacementpricedate inconsistently In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17519 --- Comment #10 from Katrin Fischer --- We have trained libraries that they don't have to fill out the field because Koha does it in the background automatically. I was wondering, because this patch talks about clearing the field. At the moment it's simply not possible to have an item without a dateaccessioned which is often used as creation data in various reports. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Mar 14 16:52:49 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 14 Mar 2017 15:52:49 +0000 Subject: [Koha-bugs] [Bug 14608] HEA : add possibility of sharing usage statistics in Administration page and Web installer In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14608 --- Comment #46 from Marc V?ron --- Just wondering: - What value will be sent to the HEA database? - The translated one? - Does it depend on what language is choosen at the moment you set the value for UsageStatsCountry? - Deutschland or Germany? -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Mar 14 17:01:28 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 14 Mar 2017 16:01:28 +0000 Subject: [Koha-bugs] [Bug 17519] Item editor handles clearing dateaccessioned and replacementpricedate inconsistently In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17519 --- Comment #11 from Marcel de Rooy --- (In reply to Katrin Fischer from comment #10) > We have trained libraries that they don't have to fill out the field because > Koha does it in the background automatically. I was wondering, because this > patch talks about clearing the field. At the moment it's simply not possible > to have an item without a dateaccessioned which is often used as creation > data in various reports. No, this does not affect adding an item with an empty date. The sub _set_defaults_for_add will default dateaccessioned to today. The change is in ModItemFromMarc. If the user cleared the date when modifying an item, this change was not picked up. Now it is possible just as it already was for replacementpricedate. Note that we are still not 100% consistent imo. Only a little bit more ;) If we want a default in dateaccessioned, we should better take care of that in the interface rather than doing it invisibly in a set_defaults sub. Why should a user understand that we fill dateaccessioned but we do not fill replacementpricedate? But that is a topic for another report.. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Mar 14 17:02:53 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 14 Mar 2017 16:02:53 +0000 Subject: [Koha-bugs] [Bug 14608] HEA : add possibility of sharing usage statistics in Administration page and Web installer In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14608 --- Comment #47 from Jonathan Druart --- (In reply to Marc V?ron from comment #46) > Just wondering: > - What value will be sent to the HEA database? The non-translated ones. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Mar 14 17:08:04 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 14 Mar 2017 16:08:04 +0000 Subject: [Koha-bugs] [Bug 17519] Item editor handles clearing dateaccessioned and replacementpricedate inconsistently In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17519 --- Comment #12 from Katrin Fischer --- Ok, so when adding an item the behaviour will be the same. But it will be possible to empty out the date on changing an item, correct? I am not sure how replacementpricedate was intended to work. I have heard somewhere that it was used to decrease the replacement price over time as the item aged, but not entirely sure. I am not sure we have any functionality tied to it at the moment in Koha itself. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Mar 14 17:10:36 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 14 Mar 2017 16:10:36 +0000 Subject: [Koha-bugs] [Bug 18206] REST API: Default exception handling In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18206 --- Comment #1 from Lari Taskula --- Created attachment 61072 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=61072&action=edit Bug 18206: Default exception handling for REST API Many of our operations in REST API controllers now use try-catch blocks to catch exceptions and handle them appropriately. This is great, but we should introduce a centralized way of handling default HTTP 500 errors. Currently they are checked over and over again in each operation. As an example this same lovely poem, in many cases, is currently replicated for each operation: sub list { ... try { blabla } catch { # This should stay here, custom error handling for this particular operation if ($_->isa('Koha::Exceptions::Patron::Something')) { return $c->render(status => 400, openapi => { error => $_->error }); } # But the checks below can be centralized! elsif ($_->isa('DBIx::Class::Exception')) { return $c->render(status => 500, openapi => { error => $_->{msg} }); } elsif ($_->isa('Koha::Exceptions::Exception')) { return $c->render(status => 500, openapi => { error => $_->error }); } else { return $c->render(status => 500, openapi => { error => "Something went wrong, check the logs." }); } }; } Instead, my proposal for a more centralized solution is to use a before_render hook to catch all of the default exceptions before rendering that are expected to return a 500, logging the error and displaying an appropriate error message in response body. After this patch, the above example would then look like this: sub list { ... try { blabla } catch { # This should stay here, custom error handling for this particular operation if ($_->isa('Koha::Exceptions::Patron::Something')) { return $c->render(status => 400, openapi => { error => $_->error }); } # Simply rethrow the exception with the help of below function - it will then # be handled in before_render hook Koha::Exceptions::rethrow_exception($_); }; } What does this patch actually do? After this patch, in case of an exception, we will normally visit the catch-block. If none of the specified Koha::Exceptions match the thrown $_, we will now rethrow the exception. This does not crash the whole app, but forwards the exception eventually into our before_render hook at Koha::REST::V1::handle_default_exceptions. There, we are able to customize our way of handling these exceptions. In this patch I have added an error logging there. We should also discuss whether we want to display a detailed error message, or simply "Something went wrong, check the logs." for all of the default exceptions. Perhaps this could be controlled by some sort of configuration for development/production (e.g. MOJO_MODE) ? To test: 1. prove t/db_dependent/api 2. prove t/Koha/Exceptions.t -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Mar 14 17:10:54 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 14 Mar 2017 16:10:54 +0000 Subject: [Koha-bugs] [Bug 18205] REST interface to Koha::Logger In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18205 Lari Taskula changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |18206 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18206 [Bug 18206] REST API: Default exception handling -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Mar 14 17:10:54 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 14 Mar 2017 16:10:54 +0000 Subject: [Koha-bugs] [Bug 18206] REST API: Default exception handling In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18206 Lari Taskula changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on| |18205 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18205 [Bug 18205] REST interface to Koha::Logger -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Mar 14 17:11:09 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 14 Mar 2017 16:11:09 +0000 Subject: [Koha-bugs] [Bug 14764] Add OPAC News branch selector In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14764 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Text to go in the|This patch insert a new sys |This patch inserts a new release notes|pref: |system preference: |"OpacNewsLibrarySelect". |"OpacNewsLibrarySelect". |When it is active you can |When it is active you can |select the news that you |select to see the news of |see in the |any library on the OPAC |main opac page. |start page. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Mar 14 17:22:46 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 14 Mar 2017 16:22:46 +0000 Subject: [Koha-bugs] [Bug 18206] REST API: Default exception handling In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18206 Lari Taskula changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Mar 14 17:22:49 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 14 Mar 2017 16:22:49 +0000 Subject: [Koha-bugs] [Bug 18206] REST API: Default exception handling In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18206 --- Comment #2 from Lari Taskula --- Created attachment 61073 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=61073&action=edit Bug 18206: Use this feature for cities To test: 1. prove t/db_dependent/api/v1/cities.t -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Mar 14 17:28:28 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 14 Mar 2017 16:28:28 +0000 Subject: [Koha-bugs] [Bug 18135] Can submit batch deletion for authorities without selecting any In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18135 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Severity|enhancement |trivial CC| |katrin.fischer at bsz-bw.de Status|Pushed to Master |Pushed to Stable --- Comment #6 from Katrin Fischer --- 'Upping' this to be a bug fix as this fixes the former inconsistent behaviour. This patch has been pushed to 16.11.x and will be in 16.11.05. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Mar 14 17:31:39 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 14 Mar 2017 16:31:39 +0000 Subject: [Koha-bugs] [Bug 18215] Resolve warning on $tls in Database.pm In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18215 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |RESOLVED Resolution|--- |FIXED CC| |katrin.fischer at bsz-bw.de --- Comment #10 from Katrin Fischer --- Depends on enh bug 15427 that is not in 16.11.x. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Mar 14 17:33:07 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 14 Mar 2017 16:33:07 +0000 Subject: [Koha-bugs] [Bug 7143] Bug for tracking changes to the about page In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7143 --- Comment #360 from Katrin Fischer --- Pushed the last fix for Santellan to 16.11.x. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Tue Mar 14 17:34:39 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 14 Mar 2017 16:34:39 +0000 Subject: [Koha-bugs] [Bug 16202] Rental fees can be generated for fractions of a penny/cent In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16202 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Severity|enhancement |minor Status|Pushed to Master |Pushed to Stable CC| |katrin.fischer at bsz-bw.de --- Comment #19 from Katrin Fischer --- Considering this a bug fix. This patch has been pushed to 16.11.x and will be in 16.11.05. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Mar 14 17:35:56 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 14 Mar 2017 16:35:56 +0000 Subject: [Koha-bugs] [Bug 18267] New: Update price and tax fields in EDI to reflect DB changes Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18267 Bug ID: 18267 Summary: Update price and tax fields in EDI to reflect DB changes Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Acquisitions Assignee: koha-bugs at lists.koha-community.org Reporter: colin.campbell at ptfs-europe.com QA Contact: testopia at bugs.koha-community.org The aqorders price and tax fields were renamed/ added to in bug 13321 but the changes were not propagated to EDI.pm which is still creating orders with the prices in the old fields. Update the fields used and check the correct Edifact elements are being assigned -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Mar 14 17:38:32 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 14 Mar 2017 16:38:32 +0000 Subject: [Koha-bugs] [Bug 17941] CanBookBeRenewed is very inefficient/slow In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17941 --- Comment #42 from Katrin Fischer --- I will watch this a bit longer and consider pushing it to the next 16.11.x release. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Mar 14 17:40:07 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 14 Mar 2017 16:40:07 +0000 Subject: [Koha-bugs] [Bug 16344] Add a circ rule to limit the auto renewals given a specific date In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16344 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #57735|0 |1 is obsolete| | Attachment #57736|0 |1 is obsolete| | Attachment #57737|0 |1 is obsolete| | --- Comment #32 from Jonathan Druart --- Created attachment 61074 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=61074&action=edit Bug 16344: Add a circ rule to limit the auto renewals given a specific This patch adds a new circulation rule (no_auto_renewal_after_hard_limit) to block/allow auto renewals after a given date. The idea is to stop renewals at a given date. That way the library will have time to send overdues and get the books back before the students do on holiday. Test plan: 0/ Execute the update DB entry 1/ Define a rule with no_auto_renewal_after_hard_limit set to tomorrow 2/ Modify the issues.issuedate, to simulate a checkout in the past: UPDATE issues SET issuedate = "yyyy-mm-dd hh:mm:ss" WHERE itemnumber = YOUR_ITEMNUMBER; with issuedate = 2 days before for instance 3/ Execute the automatic renewals cronjob script (misc/cronjobs/automatic_renewals.pl) Confirm that the issue has been renewed 4/ Modify the no_auto_renewal_after_hard_limit and set it to yesterday 5/ Execute the automatic renewals cronjob script (misc/cronjobs/automatic_renewals.pl) Confirm that the issue has not been renewed -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Mar 14 17:40:15 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 14 Mar 2017 16:40:15 +0000 Subject: [Koha-bugs] [Bug 16344] Add a circ rule to limit the auto renewals given a specific date In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16344 --- Comment #33 from Jonathan Druart --- Created attachment 61075 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=61075&action=edit Bug 16344: Fix alignment between top and bottom columns -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Mar 14 17:40:30 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 14 Mar 2017 16:40:30 +0000 Subject: [Koha-bugs] [Bug 16344] Add a circ rule to limit the auto renewals given a specific date In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16344 --- Comment #34 from Jonathan Druart --- Created attachment 61076 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=61076&action=edit Bug 16344: [DO NOT PUSH] Schema changes -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Mar 14 17:41:04 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 14 Mar 2017 16:41:04 +0000 Subject: [Koha-bugs] [Bug 15582] Ability to block auto renewals if the OPACFineNoRenewals amount is reached In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15582 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #57738|0 |1 is obsolete| | Attachment #57739|0 |1 is obsolete| | Attachment #57740|0 |1 is obsolete| | --- Comment #29 from Jonathan Druart --- Created attachment 61077 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=61077&action=edit Bug 15582: DB changes - add new pref OPACFineNoRenewalsBlockAutoRenew Sponsored-by: University of the Arts London -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Mar 14 17:41:11 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 14 Mar 2017 16:41:11 +0000 Subject: [Koha-bugs] [Bug 15582] Ability to block auto renewals if the OPACFineNoRenewals amount is reached In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15582 --- Comment #30 from Jonathan Druart --- Created attachment 61078 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=61078&action=edit Bug 15582: Ability to block auto renewals if OPACFineNoRenewals is reached If a patron owes more than the OPACFineNoRenewals value, the issue won't be auto renewed anymore (driven by the new pref OPACFineNoRenewalsBlockAutoRenew). Test plan: Note: You will have to manually change data in your DB, make sure you have access to the sql cli. 1/ Set the OPACFineNoRenewals to 5 (for instance) 2/ Set OPACFineNoRenewalsBlockAutoRenew to block 3/ Check an item out to a patron and mark is as an auto renewal 4/ Make sure the patron does not have any fees or charges. 5/ Execute the automatic renewals cronjob script (misc/cronjobs/automatic_renewals.pl) Confirm that the issue has been renewed 6/ Create an invoice for this patron with a amount > OPACFineNoRenewals (6 for instance) 7/ Execute the automatic renewals cronjob script (misc/cronjobs/automatic_renewals.pl) Confirm that the issue has not been renewed. 8/ Set OPACFineNoRenewalsBlockAutoRenew to allow 9/ Execute the automatic renewals cronjob script (misc/cronjobs/automatic_renewals.pl) Confirm that the issue has been renewed Sponsored-by: University of the Arts London -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Mar 14 17:41:21 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 14 Mar 2017 16:41:21 +0000 Subject: [Koha-bugs] [Bug 15582] Ability to block auto renewals if the OPACFineNoRenewals amount is reached In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15582 --- Comment #31 from Jonathan Druart --- Created attachment 61079 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=61079&action=edit Bug 15582: Fix grammar in syspref description -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Mar 14 17:42:05 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 14 Mar 2017 16:42:05 +0000 Subject: [Koha-bugs] [Bug 15705] Notify the user on auto renewing In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15705 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #57741|0 |1 is obsolete| | Attachment #57742|0 |1 is obsolete| | Attachment #57743|0 |1 is obsolete| | Attachment #57744|0 |1 is obsolete| | Attachment #57745|0 |1 is obsolete| | Attachment #57746|0 |1 is obsolete| | Attachment #57747|0 |1 is obsolete| | --- Comment #39 from Jonathan Druart --- Created attachment 61080 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=61080&action=edit Bug 15705: Notify the user on auto renewing When an issue is auto renewed, a notice will be sent to the patron. The notice will tell if the renewed has been successfully done. Note that this patch is not ready to be pushed yet, as it has some defects: - 1 notice per issue - no way to disable the notice generation - no way to specify patron categories to enable/disable the notifications Test plan: Use the automatic_renewals.pl script to auto renew issues. If the auto renew has failed or succeeded, a notice will be generated in the message_queue table. If the error is "too_soon" or is the same as the previous error, the notice won't be generated (we do not want to spam the patron). -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Mar 14 17:42:11 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 14 Mar 2017 16:42:11 +0000 Subject: [Koha-bugs] [Bug 15705] Notify the user on auto renewing In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15705 --- Comment #40 from Jonathan Druart --- Created attachment 61081 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=61081&action=edit Bug 15705: DB Changes - Add [old_]issues.auto_renew_error and the AUTO_RENEWALS notice -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Mar 14 17:42:17 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 14 Mar 2017 16:42:17 +0000 Subject: [Koha-bugs] [Bug 15705] Notify the user on auto renewing In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15705 --- Comment #41 from Jonathan Druart --- Created attachment 61082 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=61082&action=edit Bug 15705: Add is_tt param to the new letter -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Mar 14 17:42:22 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 14 Mar 2017 16:42:22 +0000 Subject: [Koha-bugs] [Bug 15705] Notify the user on auto renewing In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15705 --- Comment #42 from Jonathan Druart --- Created attachment 61083 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=61083&action=edit Bug 15705: [DO NOT PUSH] DBIC Schema -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Mar 14 17:42:27 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 14 Mar 2017 16:42:27 +0000 Subject: [Koha-bugs] [Bug 15705] Notify the user on auto renewing In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15705 --- Comment #43 from Jonathan Druart --- Created attachment 61084 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=61084&action=edit Bug 15705: Increasing size of auto_renew_error to 32 auto_too_much_oweing is bigger than 16, so we need more! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Mar 14 17:42:38 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 14 Mar 2017 16:42:38 +0000 Subject: [Koha-bugs] [Bug 15705] Notify the user on auto renewing In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15705 --- Comment #45 from Jonathan Druart --- Created attachment 61086 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=61086&action=edit Bug 15705: Add specific warning messages for auto_too_much_oweing -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Mar 14 17:42:32 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 14 Mar 2017 16:42:32 +0000 Subject: [Koha-bugs] [Bug 15705] Notify the user on auto renewing In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15705 --- Comment #44 from Jonathan Druart --- Created attachment 61085 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=61085&action=edit Bug 15705: DO NOT PUSH DBIC Changes -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Mar 14 17:43:34 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 14 Mar 2017 16:43:34 +0000 Subject: [Koha-bugs] [Bug 18206] REST API: Default exception handling In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18206 Lari Taskula changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #61072|0 |1 is obsolete| | --- Comment #3 from Lari Taskula --- Created attachment 61087 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=61087&action=edit Bug 18206: Default exception handling for REST API Many of our operations in REST API controllers now use try-catch blocks to catch exceptions and handle them appropriately. This is great, but we should introduce a centralized way of handling default HTTP 500 errors. Currently they are checked over and over again in each operation. As an example this same lovely poem, in many cases, is currently replicated for each operation: sub list { ... try { blabla } catch { # This should stay here, custom error handling for this particular operation if ($_->isa('Koha::Exceptions::Patron::Something')) { return $c->render(status => 400, openapi => { error => $_->error }); } # But the checks below can be centralized! elsif ($_->isa('DBIx::Class::Exception')) { return $c->render(status => 500, openapi => { error => $_->{msg} }); } elsif ($_->isa('Koha::Exceptions::Exception')) { return $c->render(status => 500, openapi => { error => $_->error }); } else { return $c->render(status => 500, openapi => { error => "Something went wrong, check the logs." }); } }; } Instead, my proposal for a more centralized solution is to use a before_render hook to catch all of the default exceptions before rendering that are expected to return a 500, logging the error and displaying an appropriate error message in response body. After this patch, the above example would then look like this: sub list { ... try { blabla } catch { # This should stay here, custom error handling for this particular operation if ($_->isa('Koha::Exceptions::Patron::Something')) { return $c->render(status => 400, openapi => { error => $_->error }); } # Simply rethrow the exception with the help of below function - it will then # be handled in before_render hook Koha::Exceptions::rethrow_exception($_); }; } What does this patch actually do? After this patch, in case of an exception, we will normally visit the catch-block. If none of the specified Koha::Exceptions match the thrown $_, we will now rethrow the exception. This does not crash the whole app, but forwards the exception eventually into our before_render hook at Koha::REST::V1::handle_default_exceptions. There, we are able to customize our way of handling these exceptions. In this patch I have added an error logging there. We should also discuss whether we want to display a detailed error message, or simply "Something went wrong, check the logs." for all of the default exceptions. Perhaps this could be controlled by some sort of configuration for development/production (e.g. MOJO_MODE) ? To test: 1. prove t/db_dependent/api 2. prove t/Koha/Exceptions.t -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Mar 14 17:43:46 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 14 Mar 2017 16:43:46 +0000 Subject: [Koha-bugs] [Bug 18206] REST API: Default exception handling In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18206 Lari Taskula changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #61073|0 |1 is obsolete| | --- Comment #4 from Lari Taskula --- Created attachment 61088 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=61088&action=edit Bug 18206: Use this feature for cities To test: 1. prove t/db_dependent/api/v1/cities.t -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Mar 14 17:50:54 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 14 Mar 2017 16:50:54 +0000 Subject: [Koha-bugs] [Bug 9031] Overdue items crossing DST boundary throw invalid local time exception In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9031 Nick Clemens changed: What |Removed |Added ---------------------------------------------------------------------------- Status|In Discussion |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Tue Mar 14 17:50:56 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 14 Mar 2017 16:50:56 +0000 Subject: [Koha-bugs] [Bug 9031] Overdue items crossing DST boundary throw invalid local time exception In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9031 Nick Clemens changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #13795|0 |1 is obsolete| | --- Comment #9 from Nick Clemens --- Created attachment 61089 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=61089&action=edit Bug 9031 - Overdue items crossing DST boundary throw invalid local time exception To test: 1 - Set TZ to America/New York 2 - Checkout item and set due date to '2016-03-09 02:29:00" 3 - Make sure fines are set for the item type, fine mode production, calculate fines on return 4 - Check in item - invalid date time warning in logs 5 - Apply patch 6 - Check in item - no error 7 - prove t/Calendar.t -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Tue Mar 14 17:51:52 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 14 Mar 2017 16:51:52 +0000 Subject: [Koha-bugs] [Bug 9031] Overdue items crossing DST boundary throw invalid local time exception In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9031 Nick Clemens changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |nick at bywatersolutions.com --- Comment #10 from Nick Clemens --- One test is failing on master currently for me (13 - Exception holiday is not a closed day test) This patch doesn't affect that -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Tue Mar 14 17:56:33 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 14 Mar 2017 16:56:33 +0000 Subject: [Koha-bugs] [Bug 17196] Move marcxml out of the biblioitems table In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17196 --- Comment #136 from Olli-Antti Kivilahti --- Just noticed while doing DB changes, that biblio_metadata is linked to the biblio table instead of the biblioitems-table! This will be fixed in the followup. >Try to be around when we ask for feedbacks and tests, *before* things are pushed. >I am sure it would be more useful for everybody. >I cannot count how many times I have asked for help on this one. Unfortunately that is not possible at the moment. I can only bark later. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Mar 14 17:58:22 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 14 Mar 2017 16:58:22 +0000 Subject: [Koha-bugs] [Bug 18265] Followup to Bug 17196. deletedbiblio_metadata is not used. biblioitemnumber was forgotten In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18265 --- Comment #1 from Olli-Antti Kivilahti --- Exhibit 3: Just noticed while doing DB changes, that biblio_metadata is linked to the biblio table instead of the biblioitems-table! No FRBR there. Is being fixed. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Mar 14 18:00:34 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 14 Mar 2017 17:00:34 +0000 Subject: [Koha-bugs] [Bug 18265] Followup to Bug 17196. deletedbiblio_metadata is not used. biblioitemnumber was forgotten In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18265 --- Comment #2 from Olli-Antti Kivilahti --- Created attachment 61090 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=61090&action=edit Bug 18265 - Followup to Buuug 17196. deletedbiblio_metadata is not used. biblioitemnumber was forgot. perl misc/devel/update_dbix_class_files.pl perl t/db_dependent/Biblio_crud.t perl t/db_dependent/Holds/HoldFulfillmentPolicy.t + other tests from Buug 17196 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Mar 14 18:01:14 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 14 Mar 2017 17:01:14 +0000 Subject: [Koha-bugs] [Bug 18265] Followup to Bug 17196. deletedbiblio_metadata is not used. biblioitemnumber was forgotten In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18265 --- Comment #3 from Olli-Antti Kivilahti --- WIP. Will fix tests tomorrow. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Mar 14 18:01:24 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 14 Mar 2017 17:01:24 +0000 Subject: [Koha-bugs] [Bug 18265] Followup to Bug 17196. deletedbiblio_metadata is not used. biblioitemnumber was forgotten In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18265 Olli-Antti Kivilahti changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|gmcharlt at gmail.com |olli-antti.kivilahti at jns.fi -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Mar 14 18:25:15 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 14 Mar 2017 17:25:15 +0000 Subject: [Koha-bugs] [Bug 18215] Resolve warning on $tls in Database.pm In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18215 Marcel de Rooy changed: What |Removed |Added ---------------------------------------------------------------------------- Resolution|FIXED |--- Status|RESOLVED |REOPENED --- Comment #11 from Marcel de Rooy --- Katrin: This was Passed QA. So you should not close it. Just wait until all patches have been pushed and the status has been changed. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Mar 14 18:25:32 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 14 Mar 2017 17:25:32 +0000 Subject: [Koha-bugs] [Bug 18215] Resolve warning on $tls in Database.pm In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18215 Marcel de Rooy changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Mar 14 18:25:25 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 14 Mar 2017 17:25:25 +0000 Subject: [Koha-bugs] [Bug 18215] Resolve warning on $tls in Database.pm In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18215 Marcel de Rooy changed: What |Removed |Added ---------------------------------------------------------------------------- Status|REOPENED |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Mar 14 18:25:39 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 14 Mar 2017 17:25:39 +0000 Subject: [Koha-bugs] [Bug 18215] Resolve warning on $tls in Database.pm In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18215 Marcel de Rooy changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Mar 14 21:17:38 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 14 Mar 2017 20:17:38 +0000 Subject: [Koha-bugs] [Bug 18257] Column visibility button does not increase colspan properly with pre-hidden columns In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18257 --- Comment #1 from Christopher Brannon --- I'm looking at the possibility of changing the nature of the tables a touch. Right now, the tables completely remove the columns. I am looking to see if they can just be hidden. The problem is that when the columns are hidden by default, the Column Visibility feature does not know how many columns are hidden by default. I have a desire to retain the columns hidden, so I can use the information in those cells for another feature I have in the works. This is open for discussion. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Tue Mar 14 21:31:02 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 14 Mar 2017 20:31:02 +0000 Subject: [Koha-bugs] [Bug 18268] New: Notices no longer sent; resending when Patron Messaging Preference changed Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18268 Bug ID: 18268 Summary: Notices no longer sent; resending when Patron Messaging Preference changed Change sponsored?: --- Product: Koha Version: 3.22 Hardware: All OS: All Status: NEW Severity: minor Priority: P5 - low Component: Notices Assignee: koha-bugs at lists.koha-community.org Reporter: cgdavis at uintah.utah.gov QA Contact: testopia at bugs.koha-community.org A patron?s Koha account had a address within its primary email address field and all patron messaging preferences were enabled (including the ?Digests only? preferences), and yet, after a time, Koha failed to send notices to the patron?s email address. It was confirmed when checking the ?Notices sent for [patron name] ([patron barcode])? tab on the patron?s account that Koha stopped sending notices to the patron?s email address. The email addresses of another patron account with the same patron messaging preference within this Koha system received notices from Koha. Koha began re-sending notices to the patron email address when the ?Item checkout? patron messaging preference was disabled and then re-enabled. This is on Koha 3.22.08 -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Tue Mar 14 22:07:42 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 14 Mar 2017 21:07:42 +0000 Subject: [Koha-bugs] [Bug 18101] "Internal server error" when accessing audio alerts In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18101 Marc V?ron changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |veron at veron.ch --- Comment #5 from Marc V?ron --- Works fine for me on current master. No error. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Mar 14 22:15:15 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 14 Mar 2017 21:15:15 +0000 Subject: [Koha-bugs] [Bug 18269] New: Move field mappings related code to Koha::FieldMapping[s] Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18269 Bug ID: 18269 Summary: Move field mappings related code to Koha::FieldMapping[s] Change sponsored?: --- Product: Koha Version: unspecified Hardware: All OS: All Status: ASSIGNED Severity: enhancement Priority: P5 - low Component: Architecture, internals, and plumbing Assignee: jonathan.druart at bugs.koha-community.org Reporter: jonathan.druart at bugs.koha-community.org QA Contact: testopia at bugs.koha-community.org There are 3 subroutines in C4::Biblio that only do CRUD operations. They can be replaced with a new package Koha::FieldMapping[s] -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Mar 14 22:15:32 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 14 Mar 2017 21:15:32 +0000 Subject: [Koha-bugs] [Bug 15449] Move stuffs to the Koha namespace In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15449 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on| |18269 --- Comment #20 from Jonathan Druart --- Bug 18269 - Move field mappings related code to Koha::FieldMapping[s] Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18269 [Bug 18269] Move field mappings related code to Koha::FieldMapping[s] -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Mar 14 22:15:32 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 14 Mar 2017 21:15:32 +0000 Subject: [Koha-bugs] [Bug 18269] Move field mappings related code to Koha::FieldMapping[s] In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18269 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |15449 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15449 [Bug 15449] Move stuffs to the Koha namespace -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Mar 14 22:15:54 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 14 Mar 2017 21:15:54 +0000 Subject: [Koha-bugs] [Bug 17628] Move bibliographic related code to Koha::Biblio In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17628 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |https://bugs.koha-community | |.org/bugzilla3/show_bug.cgi | |?id=18269 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Mar 14 22:15:54 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 14 Mar 2017 21:15:54 +0000 Subject: [Koha-bugs] [Bug 18269] Move field mappings related code to Koha::FieldMapping[s] In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18269 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |https://bugs.koha-community | |.org/bugzilla3/show_bug.cgi | |?id=17628 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Mar 14 22:21:22 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 14 Mar 2017 21:21:22 +0000 Subject: [Koha-bugs] [Bug 18269] Move field mappings related code to Koha::FieldMapping[s] In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18269 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Mar 14 22:21:25 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 14 Mar 2017 21:21:25 +0000 Subject: [Koha-bugs] [Bug 18269] Move field mappings related code to Koha::FieldMapping[s] In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18269 --- Comment #1 from Jonathan Druart --- Created attachment 61091 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=61091&action=edit Bug 18269: Add Koha::FieldMapping[s] packages -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Mar 14 22:21:29 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 14 Mar 2017 21:21:29 +0000 Subject: [Koha-bugs] [Bug 18269] Move field mappings related code to Koha::FieldMapping[s] In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18269 --- Comment #2 from Jonathan Druart --- Created attachment 61092 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=61092&action=edit Bug 18269: Move field mappings related code to Koha::FieldMapping[s] The 3 subroutines GetFieldMapping, SetFieldMapping and DeleteFieldMapping from the C4::Biblio module were only used from the field mappings admin page. They can easily replaced with new packages Koha::FieldMappings based on Koha::Object[s] Test plan: Add and delete field mappings (admin/fieldmapping.pl, Home ? Administration ? Keyword to MARC mapping). Add an existing mapping > Nothing should be added Note that this page has not been rewritten and you will not get any feedbacks, but it's not the goal of this page to improve it. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Mar 15 00:27:25 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 14 Mar 2017 23:27:25 +0000 Subject: [Koha-bugs] [Bug 10662] Build OAI-PMH Harvesting Client In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10662 --- Comment #116 from David Cook --- (In reply to Sebastian Hierl from comment #115) > We are interested as well and I trust that there are many more Koha > libraries who would like to update their data via OAI-PMH. Thank you, > Sebastian Glad to hear it! I hope the end result works well for everyone! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Mar 15 01:31:53 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 15 Mar 2017 00:31:53 +0000 Subject: [Koha-bugs] [Bug 6473] Test bug for Git-bz In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6473 Mason James changed: What |Removed |Added ---------------------------------------------------------------------------- CC|mtj at kohaaloha.com | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Mar 15 10:35:05 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 15 Mar 2017 09:35:05 +0000 Subject: [Koha-bugs] [Bug 18269] Move field mappings related code to Koha::FieldMapping[s] In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18269 Marc V?ron changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #61091|0 |1 is obsolete| | --- Comment #3 from Marc V?ron --- Created attachment 61093 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=61093&action=edit Bug 18269: Add Koha::FieldMapping[s] packages Tested both patches together, works as expected. Signed-off-by: Marc V?ron -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Mar 15 10:36:20 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 15 Mar 2017 09:36:20 +0000 Subject: [Koha-bugs] [Bug 18269] Move field mappings related code to Koha::FieldMapping[s] In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18269 Marc V?ron changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #61092|0 |1 is obsolete| | --- Comment #4 from Marc V?ron --- Created attachment 61094 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=61094&action=edit Bug 18269: Move field mappings related code to Koha::FieldMapping[s] The 3 subroutines GetFieldMapping, SetFieldMapping and DeleteFieldMapping from the C4::Biblio module were only used from the field mappings admin page. They can easily replaced with new packages Koha::FieldMappings based on Koha::Object[s] Test plan: Add and delete field mappings (admin/fieldmapping.pl, Home ? Administration ? Keyword to MARC mapping). Add an existing mapping > Nothing should be added Note that this page has not been rewritten and you will not get any feedbacks, but it's not the goal of this page to improve it. Followed test plan, works as expected. Signed-off-by: Marc V?ron -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Mar 15 10:36:41 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 15 Mar 2017 09:36:41 +0000 Subject: [Koha-bugs] [Bug 18269] Move field mappings related code to Koha::FieldMapping[s] In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18269 Marc V?ron changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |veron at veron.ch Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Mar 15 11:13:44 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 15 Mar 2017 10:13:44 +0000 Subject: [Koha-bugs] [Bug 18264] Course reserves - use itemnumber for editing existing reserve items In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18264 Marc V?ron changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #61067|0 |1 is obsolete| | --- Comment #2 from Marc V?ron --- Created attachment 61095 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=61095&action=edit Bug 18264 - Course reserves - use itemnumber for editing existing reserve items This patch alters the crouse reserves module to use itemnumber as the lookup method for existing reserves as opposed to barcode To test: 1 - Apply patch 2 - Add some items to a course reserves - all should work as expected 3 - Delete the barcode for an item on reserve 4 - Note the edit link still resolves to the correct item Followed test plan, works as expected. Signed-off-by: Marc V?ron -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Mar 15 11:14:01 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 15 Mar 2017 10:14:01 +0000 Subject: [Koha-bugs] [Bug 18264] Course reserves - use itemnumber for editing existing reserve items In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18264 Marc V?ron changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |veron at veron.ch Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Mar 15 11:17:04 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 15 Mar 2017 10:17:04 +0000 Subject: [Koha-bugs] [Bug 18215] Resolve warning on $tls in Database.pm In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18215 --- Comment #12 from Katrin Fischer --- Sorry, missed that you weren't finished here when looking over this. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Mar 15 11:31:01 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 15 Mar 2017 10:31:01 +0000 Subject: [Koha-bugs] [Bug 18265] Followup to Bug 17196. deletedbiblio_metadata is not used. biblioitemnumber was forgotten In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18265 --- Comment #4 from Olli-Antti Kivilahti --- Created attachment 61096 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=61096&action=edit Bug 18265 - Followup to Buuug 17196. deletedbiblio_metadata is not used. biblioitemnumber was forgot. FK to wrong table. Exhibit 1: The MARCXML is lost when the biblio is deleted because the values in biblio_metadata-table from biblioitems-table are never moved to deletedbiblio_metadata-table. Previously the marcxml was preserved in the oldbiblioitems-table This is a challenge for gathering statistics For example item has been ordered, received, and removed from collection during the statistics period Information in marcxml is needed to accurately categorize the item Exhibit 2: [15:22:38] also. In Koha there once was a great idea that one biblio-entry can have multiple biblioitems [15:22:45] and the marcxml was tied to the biblioitems-table [15:23:11] this is a nice idea, but nobdy really cared for it and now biblionumber and biblioitemnumber are used interchangeably [15:23:22] except when they get out of sync during a data migration [15:23:41] then things start to work really interestingly [15:23:47] but the point is [15:23:57] biblio_metadata has a biblionumber-column [15:24:15] shouldn't it have a biblioitemnumber-column, just for old time's sake? In the biblioitems-table we had marcxml. primary keyed with biblioitemnumber. Now the marcxml is moved to biblio_metadata and the foreign key reference was simplified to biblionumber. This makes the existing FRBR-bug worse. Exhibit 3: Just noticed while doing DB changes, that biblio_metadata is linked to the biblio table instead of the biblioitems-table! No FRBR there. Is being fixed. REPLICATE ISSUE: Create biblio Delete biblio Where is deletedbiblio_metadata-row? TEST PLAN: perl misc/devel/update_dbix_class_files.pl perl t/db_dependent/Biblio_crud.t perl t/db_dependent/Holds/HoldFulfillmentPolicy.t + other tests from Buug 17196 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Mar 15 11:31:32 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 15 Mar 2017 10:31:32 +0000 Subject: [Koha-bugs] [Bug 18265] Followup to Bug 17196. deletedbiblio_metadata is not used. biblioitemnumber was forgotten In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18265 Olli-Antti Kivilahti changed: What |Removed |Added ---------------------------------------------------------------------------- Severity|enhancement |critical Status|NEW |Needs Signoff Priority|P5 - low |P2 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Mar 15 11:32:10 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 15 Mar 2017 10:32:10 +0000 Subject: [Koha-bugs] [Bug 18265] Followup to Bug 17196. deletedbiblio_metadata is not used. biblioitemnumber was forgotten In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18265 Olli-Antti Kivilahti changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |jonathan.druart at bugs.koha-c | |ommunity.org -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Mar 15 11:34:48 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 15 Mar 2017 10:34:48 +0000 Subject: [Koha-bugs] [Bug 17196] Move marcxml out of the biblioitems table In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17196 --- Comment #137 from Olli-Antti Kivilahti --- Followup Bug 18265 is ready to be SO'd. Regardless of the bugs found, I think this change is welcome. I hope we get the fixes in asap. http://quoteinvestigator.com/2014/12/16/no-mistakes/ -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Mar 15 11:39:22 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 15 Mar 2017 10:39:22 +0000 Subject: [Koha-bugs] [Bug 18265] Followup to Bug 17196. deletedbiblio_metadata is not used. biblioitemnumber was forgotten In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18265 Olli-Antti Kivilahti changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #61096|0 |1 is obsolete| | --- Comment #5 from Olli-Antti Kivilahti --- Created attachment 61097 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=61097&action=edit Bug 18265 - Followup to Buuug 17196. deletedbiblio_metadata is not used. biblioitemnumber was forgot. FK to wrong table. Exhibit 1: The MARCXML is lost when the biblio is deleted because the values in biblio_metadata-table from biblioitems-table are never moved to deletedbiblio_metadata-table. Previously the marcxml was preserved in the oldbiblioitems-table This is a challenge for gathering statistics For example item has been ordered, received, and removed from collection during the statistics period Information in marcxml is needed to accurately categorize the item Exhibit 2: [15:22:38] also. In Koha there once was a great idea that one biblio-entry can have multiple biblioitems [15:22:45] and the marcxml was tied to the biblioitems-table [15:23:11] this is a nice idea, but nobdy really cared for it and now biblionumber and biblioitemnumber are used interchangeably [15:23:22] except when they get out of sync during a data migration [15:23:41] then things start to work really interestingly [15:23:47] but the point is [15:23:57] biblio_metadata has a biblionumber-column [15:24:15] shouldn't it have a biblioitemnumber-column, just for old time's sake? In the biblioitems-table we had marcxml. primary keyed with biblioitemnumber. Now the marcxml is moved to biblio_metadata and the foreign key reference was simplified to biblionumber. This makes the existing FRBR-bug worse. Exhibit 3: Just noticed while doing DB changes, that biblio_metadata is linked to the biblio table instead of the biblioitems-table! No FRBR there. Is being fixed. REPLICATE ISSUE: Create biblio Delete biblio Where is deletedbiblio_metadata-row? TEST PLAN: perl misc/devel/update_dbix_class_files.pl perl t/db_dependent/Biblio_crud.t perl t/db_dependent/Holds/HoldFulfillmentPolicy.t + other tests from Buug 17196 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Mar 15 11:45:02 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 15 Mar 2017 10:45:02 +0000 Subject: [Koha-bugs] [Bug 17366] create patron list, software error In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17366 Jon Knight changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |J.P.Knight at lboro.ac.uk --- Comment #4 from Jon Knight --- I've just had the same thing happen on a fresh install of Koha. The logs show: [Wed Mar 15 10:29:35 2017] [error] [client p.q.r.s] [Wed Mar 15 10:29:35 2017] add-modify.pl: No owner passed in or defined! at /usr/share/koha/intranet/cgi-bin/patron_lists/add-modify.pl line 54., referer: http://koha-dev.lboro.ac.uk:8080/cgi-bin/koha/patron_lists/add-modify.pl [Wed Mar 15 10:29:35 2017] [error] [client p.q.r.s] [Wed Mar 15 10:29:35 2017] add-modify.pl: Can't call method "patron_list_id" on an undefined value at /usr/share/koha/intranet/cgi-bin/patron_lists/add-modify.pl line 55., referer: http://koha-dev.lboro.ac.uk:8080/cgi-bin/koha/patron_lists/add-modify.pl where p.q.r.s is my machine's IPv4 address. However I've "solved" the problem - I was playing about as the Koha database admin setting the system up when I hit the error. When I switched to use my own (superlibrarian) staff account, the error went away. So this may be the case for other users and I thought it was a good idea to note it here. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Mar 15 12:07:07 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 15 Mar 2017 11:07:07 +0000 Subject: [Koha-bugs] [Bug 18265] Followup to Bug 17196. deletedbiblio_metadata is not used. biblioitemnumber was forgotten In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18265 Olli-Antti Kivilahti changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #61097|0 |1 is obsolete| | --- Comment #6 from Olli-Antti Kivilahti --- Created attachment 61098 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=61098&action=edit Bug 18265 - Followup to Buuug 17196. deletedbiblio_metadata is not used. biblioitemnumber was forgot. FK to wrong table. Exhibit 1: The MARCXML is lost when the biblio is deleted because the values in biblio_metadata-table from biblioitems-table are never moved to deletedbiblio_metadata-table. Previously the marcxml was preserved in the oldbiblioitems-table This is a challenge for gathering statistics For example item has been ordered, received, and removed from collection during the statistics period Information in marcxml is needed to accurately categorize the item Exhibit 2: [15:22:38] also. In Koha there once was a great idea that one biblio-entry can have multiple biblioitems [15:22:45] and the marcxml was tied to the biblioitems-table [15:23:11] this is a nice idea, but nobdy really cared for it and now biblionumber and biblioitemnumber are used interchangeably [15:23:22] except when they get out of sync during a data migration [15:23:41] then things start to work really interestingly [15:23:47] but the point is [15:23:57] biblio_metadata has a biblionumber-column [15:24:15] shouldn't it have a biblioitemnumber-column, just for old time's sake? In the biblioitems-table we had marcxml. primary keyed with biblioitemnumber. Now the marcxml is moved to biblio_metadata and the foreign key reference was simplified to biblionumber. This makes the existing FRBR-bug worse. Exhibit 3: Just noticed while doing DB changes, that biblio_metadata is linked to the biblio table instead of the biblioitems-table! No FRBR there. Is being fixed. REPLICATE ISSUE: Create biblio Delete biblio Where is deletedbiblio_metadata-row? TEST PLAN: perl misc/devel/update_dbix_class_files.pl perl t/db_dependent/Biblio_crud.t perl t/db_dependent/Holds/HoldFulfillmentPolicy.t + other tests from Buug 17196 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Mar 15 12:11:17 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 15 Mar 2017 11:11:17 +0000 Subject: [Koha-bugs] [Bug 18111] Import default framework is broken In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18111 --- Comment #17 from Julian Maurice --- Created attachment 61099 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=61099&action=edit Bug 18111: Follow-up for 3.22.x Replace [% frameworkcode %] by 'default' wherever needed -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Mar 15 12:11:57 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 15 Mar 2017 11:11:57 +0000 Subject: [Koha-bugs] [Bug 18111] Import default framework is broken In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18111 Julian Maurice changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |julian.maurice at biblibre.com --- Comment #18 from Julian Maurice --- Pushed to 3.22.x, will be in 3.22.18 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Mar 15 12:13:15 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 15 Mar 2017 11:13:15 +0000 Subject: [Koha-bugs] [Bug 15336] Script for merging vendors In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15336 --- Comment #21 from Marc V?ron --- - Script works fine - t/db_dependent/Bookseller.t passes OK - t/Bookseller.t fails with: t/Bookseller.t .. 1/14 Can't use string ("Koha::Acquisition::Bookseller") as a HASH ref while "strict refs" in use at (...)/Koha/Object.pm line 275. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Mar 15 12:14:24 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 15 Mar 2017 11:14:24 +0000 Subject: [Koha-bugs] [Bug 17865] If a subscription has no history end date, it shows as expired today in OPAC In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17865 Julian Maurice changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |julian.maurice at biblibre.com --- Comment #22 from Julian Maurice --- Pushed to 3.22.x, will be in 3.22.18 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Mar 15 12:16:11 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 15 Mar 2017 11:16:11 +0000 Subject: [Koha-bugs] [Bug 17852] Multiple URLs (856) in list email are broken In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17852 Julian Maurice changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |julian.maurice at biblibre.com --- Comment #12 from Julian Maurice --- Pushed to 3.22.x, will be in 3.22.18 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Mar 15 12:23:45 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 15 Mar 2017 11:23:45 +0000 Subject: [Koha-bugs] [Bug 17895] Small typo -'re-set' In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17895 Julian Maurice changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |julian.maurice at biblibre.com --- Comment #9 from Julian Maurice --- Pushed to 3.22.x, will be in 3.22.18 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Mar 15 12:28:39 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 15 Mar 2017 11:28:39 +0000 Subject: [Koha-bugs] [Bug 17947] Searching my library first shows the branchcode by the search bar rather than branchname In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17947 Julian Maurice changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |julian.maurice at biblibre.com --- Comment #12 from Julian Maurice --- Pushed to 3.22.x, will be in 3.22.18 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Mar 15 12:36:16 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 15 Mar 2017 11:36:16 +0000 Subject: [Koha-bugs] [Bug 16202] Rental fees can be generated for fractions of a penny/cent In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16202 Julian Maurice changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |julian.maurice at biblibre.com --- Comment #20 from Julian Maurice --- Pushed to 3.22.x, will be in 3.22.18 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Mar 15 12:46:00 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 15 Mar 2017 11:46:00 +0000 Subject: [Koha-bugs] [Bug 18265] Followup to Bug 17196. deletedbiblio_metadata is not used. biblioitemnumber was forgotten In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18265 --- Comment #7 from Jonathan Druart --- (In reply to Olli-Antti Kivilahti from comment #1) > Exhibit 3: > > Just noticed while doing DB changes, that biblio_metadata is linked to the > biblio table instead of the biblioitems-table! I think we should keep the link to biblio, both table should be merged. You are going too far with this patch, we need a quick patch to fix the data lost when deleting a bibliographic record, then we can discuss other points on another bug report. Would you agree with that? -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Mar 15 13:02:44 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 15 Mar 2017 12:02:44 +0000 Subject: [Koha-bugs] [Bug 17519] Item editor handles clearing dateaccessioned and replacementpricedate inconsistently In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17519 --- Comment #13 from Marcel de Rooy --- (In reply to Katrin Fischer from comment #12) > Ok, so when adding an item the behaviour will be the same. > But it will be possible to empty out the date on changing an item, correct? Correct. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Mar 15 13:05:33 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 15 Mar 2017 12:05:33 +0000 Subject: [Koha-bugs] [Bug 17825] Remove C4::Members::AttributeTypes::AttributeTypeExists In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17825 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |jonathan.druart at bugs.koha-c | |ommunity.org QA Contact|testopia at bugs.koha-communit |jonathan.druart at bugs.koha-c |y.org |ommunity.org --- Comment #5 from Jonathan Druart --- Waiting for bug 13757 to QA it. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Mar 15 13:05:48 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 15 Mar 2017 12:05:48 +0000 Subject: [Koha-bugs] [Bug 17792] Introduce Koha::Patron::Attribute(s) In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17792 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- QA Contact|testopia at bugs.koha-communit |jonathan.druart at bugs.koha-c |y.org |ommunity.org CC| |jonathan.druart at bugs.koha-c | |ommunity.org --- Comment #18 from Jonathan Druart --- Waiting for bug 13757 to QA it. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Mar 15 13:07:57 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 15 Mar 2017 12:07:57 +0000 Subject: [Koha-bugs] [Bug 6473] Test bug for Git-bz In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6473 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |ASSIGNED -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Mar 15 13:14:01 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 15 Mar 2017 12:14:01 +0000 Subject: [Koha-bugs] [Bug 18231] Add the missing id-column to koha.issuingrules-table for DBIC fixtures In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18231 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |jonathan.druart at bugs.koha-c | |ommunity.org Status|Signed Off |Failed QA --- Comment #8 from Jonathan Druart --- unique key is not named the same. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Mar 15 13:18:39 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 15 Mar 2017 12:18:39 +0000 Subject: [Koha-bugs] [Bug 18264] Course reserves - use itemnumber for editing existing reserve items In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18264 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |jonathan.druart at bugs.koha-c | |ommunity.org --- Comment #3 from Jonathan Druart --- I do not understand the goal of this patch, why do barcodes are removed? -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Mar 15 13:29:57 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 15 Mar 2017 12:29:57 +0000 Subject: [Koha-bugs] [Bug 18270] New: No need to fetch the MARC record when deleting an item Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18270 Bug ID: 18270 Summary: No need to fetch the MARC record when deleting an item Change sponsored?: --- Product: Koha Version: unspecified Hardware: All OS: All Status: ASSIGNED Severity: minor Priority: P5 - low Component: Architecture, internals, and plumbing Assignee: jonathan.druart at bugs.koha-community.org Reporter: jonathan.druart at bugs.koha-community.org QA Contact: testopia at bugs.koha-community.org >From C4::Items::DelItem 683 # get the MARC record 684 my $record = GetMarcBiblio($biblionumber); 685 ModZebra( $biblionumber, "specialUpdate", "biblioserver" ); 686 687 #search item field code 688 logaction("CATALOGUING", "DELETE", $itemnumber, "item") if C4::Context->preference("CataloguingLog"); 689 return $deleted; 690 } The GetMarcBiblio call is not needed. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Mar 15 13:32:16 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 15 Mar 2017 12:32:16 +0000 Subject: [Koha-bugs] [Bug 18270] No need to fetch the MARC record when deleting an item In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18270 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Mar 15 13:32:19 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 15 Mar 2017 12:32:19 +0000 Subject: [Koha-bugs] [Bug 18270] No need to fetch the MARC record when deleting an item In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18270 --- Comment #1 from Jonathan Druart --- Created attachment 61100 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=61100&action=edit Bug 18270: Do not fetch the MARC record when deleting an item $record is never used later, the call is superfluous. Test plan: Quick glance at the code should be enough -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Mar 15 14:05:19 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 15 Mar 2017 13:05:19 +0000 Subject: [Koha-bugs] [Bug 18265] Followup to Bug 17196. deletedbiblio_metadata is not used. biblioitemnumber was forgotten In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18265 Olli-Antti Kivilahti changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #61098|0 |1 is obsolete| | --- Comment #8 from Olli-Antti Kivilahti --- Created attachment 61101 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=61101&action=edit Bug 18265 - Followup to Buuug 17196. deletedbiblio_metadata is not used. biblioitemnumber was forgot. FK to wrong table. Exhibit 1: The MARCXML is lost when the biblio is deleted because the values in biblio_metadata-table from biblioitems-table are never moved to deletedbiblio_metadata-table. Previously the marcxml was preserved in the oldbiblioitems-table This is a challenge for gathering statistics For example item has been ordered, received, and removed from collection during the statistics period Information in marcxml is needed to accurately categorize the item Exhibit 2: [15:22:38] also. In Koha there once was a great idea that one biblio-entry can have multiple biblioitems [15:22:45] and the marcxml was tied to the biblioitems-table [15:23:11] this is a nice idea, but nobdy really cared for it and now biblionumber and biblioitemnumber are used interchangeably [15:23:22] except when they get out of sync during a data migration [15:23:41] then things start to work really interestingly [15:23:47] but the point is [15:23:57] biblio_metadata has a biblionumber-column [15:24:15] shouldn't it have a biblioitemnumber-column, just for old time's sake? In the biblioitems-table we had marcxml. primary keyed with biblioitemnumber. Now the marcxml is moved to biblio_metadata and the foreign key reference was simplified to biblionumber. This makes the existing FRBR-bug worse. Exhibit 3: Just noticed while doing DB changes, that biblio_metadata is linked to the biblio table instead of the biblioitems-table! No FRBR there. Is being fixed. REPLICATE ISSUE: Create biblio Delete biblio Where is deletedbiblio_metadata-row? TEST PLAN: perl misc/devel/update_dbix_class_files.pl perl t/db_dependent/Biblio_crud.t perl t/db_dependent/Holds/HoldFulfillmentPolicy.t + other tests from Buug 17196 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Mar 15 14:08:49 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 15 Mar 2017 13:08:49 +0000 Subject: [Koha-bugs] [Bug 18231] Add the missing id-column to koha.issuingrules-table for DBIC fixtures In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18231 --- Comment #9 from Olli-Antti Kivilahti --- (In reply to Jonathan Druart from comment #8) > unique key is not named the same. Prior to this patch there was no UNIQUE KEY? If you mean the index naming convention doesn't follow a established pattern, maybe it is easiest just let the DB-engine name the index? -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Mar 15 14:09:08 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 15 Mar 2017 13:09:08 +0000 Subject: [Koha-bugs] [Bug 18231] Add the missing id-column to koha.issuingrules-table for DBIC fixtures In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18231 --- Comment #10 from Olli-Antti Kivilahti --- (In reply to Marcel de Rooy from comment #7) > Olli: Did you know that we have an Assignee field ? Now I know :) -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Mar 15 14:14:48 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 15 Mar 2017 13:14:48 +0000 Subject: [Koha-bugs] [Bug 18265] Followup to Bug 17196. deletedbiblio_metadata is not used. biblioitemnumber was forgotten In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18265 --- Comment #9 from Olli-Antti Kivilahti --- (In reply to Jonathan Druart from comment #7) > (In reply to Olli-Antti Kivilahti from comment #1) > > Exhibit 3: > > > > Just noticed while doing DB changes, that biblio_metadata is linked to the > > biblio table instead of the biblioitems-table! > > I think we should keep the link to biblio, both table should be merged. > Do you mean that biblio- and biblioitems-tables should be merged? Then those need to be separated again when we are moving to FRBR. This is one fundamentally good architectural design decision in Koha. Don't break it. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Mar 15 14:19:03 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 15 Mar 2017 13:19:03 +0000 Subject: [Koha-bugs] [Bug 18265] Followup to Bug 17196. deletedbiblio_metadata is not used. biblioitemnumber was forgotten In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18265 --- Comment #10 from Marcel de Rooy --- (In reply to Olli-Antti Kivilahti from comment #9) > Do you mean that biblio- and biblioitems-tables should be merged? > > Then those need to be separated again when we are moving to FRBR. > > This is one fundamentally good architectural design decision in Koha. Don't > break it. A design decision that has not been implemented, might not be a good one after all.. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Mar 15 14:19:12 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 15 Mar 2017 13:19:12 +0000 Subject: [Koha-bugs] [Bug 18231] Add the missing id-column to koha.issuingrules-table for DBIC fixtures In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18231 Olli-Antti Kivilahti changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #60964|0 |1 is obsolete| | --- Comment #11 from Olli-Antti Kivilahti --- Created attachment 61102 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=61102&action=edit Bug 18231 - Add the missing id-column to koha.issuingrules-table for DBIC fixtures Many DBIx-stuffs depend on last_insert_id Followed test plan from comment #4, works as expected Signed-off-by: Marc V?ron -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Mar 15 14:20:04 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 15 Mar 2017 13:20:04 +0000 Subject: [Koha-bugs] [Bug 18231] Add the missing id-column to koha.issuingrules-table for DBIC fixtures In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18231 Olli-Antti Kivilahti changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |Signed Off --- Comment #12 from Olli-Antti Kivilahti --- (In reply to Jonathan Druart from comment #8) > unique key is not named the same. I think you meant the issue where both the PRIMARY KEY and the UNIQUE CONSTRAINT had the same index name? That is now fixed. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Mar 15 14:25:43 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 15 Mar 2017 13:25:43 +0000 Subject: [Koha-bugs] [Bug 18264] Course reserves - use itemnumber for editing existing reserve items In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18264 --- Comment #4 from Nick Clemens --- (In reply to Jonathan Druart from comment #3) > I do not understand the goal of this patch, why do barcodes are removed? Some workflows at libraries cause this, I think electronic items or copies may only be assigned temporary barcodes and deleted when the items are not in use - in these cases things can no longer be edited in the reserves. While having barcodes is expected for adding items to course reserves currently I think this change opens up more possibilities and doesn't hurt anything and solves a potential issue. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Mar 15 14:39:38 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 15 Mar 2017 13:39:38 +0000 Subject: [Koha-bugs] [Bug 18265] Followup to Bug 17196. deletedbiblio_metadata is not used. biblioitemnumber was forgotten In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18265 --- Comment #11 from Jonathan Druart --- (In reply to Jonathan Druart from comment #7) > You are going too far with this patch, we need a quick patch to fix the data > lost when deleting a bibliographic record, then we can discuss other points > on another bug report. Would you agree with that? What about this important part? -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Mar 15 15:42:04 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 15 Mar 2017 14:42:04 +0000 Subject: [Koha-bugs] [Bug 18271] New: UpdateFine should be passed a hash - missing patch from bug 14390 Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18271 Bug ID: 18271 Summary: UpdateFine should be passed a hash - missing patch from bug 14390 Change sponsored?: --- Product: Koha Version: 3.22 Hardware: All OS: All Status: NEW Severity: critical Priority: P5 - low Component: Circulation Assignee: koha-bugs at lists.koha-community.org Reporter: nick at bywatersolutions.com QA Contact: testopia at bugs.koha-community.org CC: gmcharlt at gmail.com, kyle.m.hall at gmail.com It looks like a patch was missed when bug 14390 was added to 3.22: https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=54824&action=diff Without this the calls to C4::Overdues::UpdateFine will fail -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Mar 15 16:01:39 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 15 Mar 2017 15:01:39 +0000 Subject: [Koha-bugs] [Bug 18272] New: Date substitution does'nt work in cataloguing/additem Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18272 Bug ID: 18272 Summary: Date substitution does'nt work in cataloguing/additem Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: major Priority: P5 - low Component: Cataloging Assignee: gmcharlt at gmail.com Reporter: alex.arnaud at biblibre.com QA Contact: testopia at bugs.koha-community.org CC: m.de.rooy at rijksmuseum.nl To reproduce: I.e configure an item field for a framework of your choice: - default value: type "<>-<>-<
    >", - Visibility: check "Editor", Edit an item of a biblio with this frameworkcode. In the field you have configured, you should see "2017-<>-15" (for today). -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Mar 15 16:03:01 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 15 Mar 2017 15:03:01 +0000 Subject: [Koha-bugs] [Bug 18266] Internal Server Error when paying fine for lost item In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18266 --- Comment #2 from Marc V?ron --- (In reply to Marc V?ron from comment #1) > Following finding: > But should payment for a lost item mark the item as returned? > > Payment for an item that is lost does not necessarily mean that the item is > already replaced or will be replaced at all. Please ignore this comment - of course the item should be marked as returned. I think - it should not be possible to create a manual invoice for a lost item or alternatively the barcode should be verified and the item should be set to LOST (not in the scope of this bug) - paying a fine for a lost item without having a barcode should not result in an internal server error (scope of this bug) -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Wed Mar 15 16:06:11 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 15 Mar 2017 15:06:11 +0000 Subject: [Koha-bugs] [Bug 18272] Date substitution does'nt work in cataloguing/additem In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18272 --- Comment #1 from Alex Arnaud --- Sorry, already fixed with Bug 17922 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Mar 15 16:06:30 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 15 Mar 2017 15:06:30 +0000 Subject: [Koha-bugs] [Bug 18272] Date substitution does'nt work in cataloguing/additem In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18272 Alex Arnaud changed: What |Removed |Added ---------------------------------------------------------------------------- Resolution|--- |DUPLICATE Status|NEW |RESOLVED --- Comment #2 from Alex Arnaud --- *** This bug has been marked as a duplicate of bug 17922 *** -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Mar 15 16:06:30 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 15 Mar 2017 15:06:30 +0000 Subject: [Koha-bugs] [Bug 17922] Default value substitution for month and day should be fixed length In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17922 Alex Arnaud changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |alex.arnaud at biblibre.com --- Comment #11 from Alex Arnaud --- *** Bug 18272 has been marked as a duplicate of this bug. *** -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Mar 15 16:21:55 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 15 Mar 2017 15:21:55 +0000 Subject: [Koha-bugs] [Bug 18270] No need to fetch the MARC record when deleting an item In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18270 Marc V?ron changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #61100|0 |1 is obsolete| | --- Comment #2 from Marc V?ron --- Created attachment 61103 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=61103&action=edit Bug 18270: Do not fetch the MARC record when deleting an item $record is never used later, the call is superfluous. Test plan: Quick glance at the code should be enough Signed-off-by: Marc V?ron -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Mar 15 16:22:19 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 15 Mar 2017 15:22:19 +0000 Subject: [Koha-bugs] [Bug 18270] No need to fetch the MARC record when deleting an item In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18270 Marc V?ron changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off CC| |veron at veron.ch -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Mar 15 16:23:42 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 15 Mar 2017 15:23:42 +0000 Subject: [Koha-bugs] [Bug 18271] UpdateFine should be passed a hash - missing patch from bug 14390 In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18271 Nick Clemens changed: What |Removed |Added ---------------------------------------------------------------------------- Resolution|--- |INVALID Status|NEW |RESOLVED --- Comment #1 from Nick Clemens --- My mistake - was a problem on a local branch only -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Wed Mar 15 16:30:40 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 15 Mar 2017 15:30:40 +0000 Subject: [Koha-bugs] [Bug 18273] New: Bulkmarcimport inserts authority duplicates Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18273 Bug ID: 18273 Summary: Bulkmarcimport inserts authority duplicates Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Command-line Utilities Assignee: gmcharlt at gmail.com Reporter: matthias.meusburger at biblibre.com QA Contact: testopia at bugs.koha-community.org CC: robin at catalyst.net.nz When importing authorities through bulkmarcimport with the -match option, there are 3 possibilities: 1) An existing authority has been found in koha according to the -match criteria. The authority is replaced if needed (005 are checked first). This is ok. 2) No authority is found in koha according to the -match criteria. The authority is inserted. This is also ok. 3) Multiple authorities have been found in koha according to the -match criteria. The authority is inserted. => Is this the expected behavior? As the -match criteria is used for deduping, the existing authorities are very likely to be already existing duplicates. Do we really want to add another one? My feeling is that in this case, the authority should NOT be inserted. Can I have your opinion on this? -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Mar 15 17:04:20 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 15 Mar 2017 16:04:20 +0000 Subject: [Koha-bugs] [Bug 15336] Script for merging vendors In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15336 --- Comment #22 from Alex Arnaud --- Created attachment 61104 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=61104&action=edit Bug 15336 - Fix unit tests (t/Bookseller.t) -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Mar 15 17:09:23 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 15 Mar 2017 16:09:23 +0000 Subject: [Koha-bugs] [Bug 15336] Script for merging vendors In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15336 Alex Arnaud changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #61104|0 |1 is obsolete| | --- Comment #23 from Alex Arnaud --- Created attachment 61105 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=61105&action=edit Bug 15336 - Fix unit tests (t/Bookseller.t) -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Mar 15 17:10:46 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 15 Mar 2017 16:10:46 +0000 Subject: [Koha-bugs] [Bug 8010] Search history can be added to the wrong patron In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8010 --- Comment #9 from Marc V?ron --- Small typo in the sql files: ....get the last seaches.... -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Mar 15 17:12:04 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 15 Mar 2017 16:12:04 +0000 Subject: [Koha-bugs] [Bug 18273] Bulkmarcimport inserts authority duplicates In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18273 --- Comment #1 from Matthias Meusburger --- Created attachment 61106 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=61106&action=edit Bug 18273: Do not insert authority if there already are duplicates in koha -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Mar 15 17:24:25 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 15 Mar 2017 16:24:25 +0000 Subject: [Koha-bugs] [Bug 8010] Search history can be added to the wrong patron In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8010 --- Comment #10 from Marc V?ron --- I think there is a small error with the logic: If I set LoadSearchHistoryToTheFirstLoggedUserto Load, it does not load, if I set it to Don't load, it loads. BTW: Testplan refers to addSearchHistoryToTheFirstLoggedUser, not LoadSearchHistoryToTheFirstLoggedUserto -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Mar 15 17:27:07 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 15 Mar 2017 16:27:07 +0000 Subject: [Koha-bugs] [Bug 18274] New: C4::Items - Remove GetItemStatus Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18274 Bug ID: 18274 Summary: C4::Items - Remove GetItemStatus Change sponsored?: --- Product: Koha Version: unspecified Hardware: All OS: All Status: ASSIGNED Severity: enhancement Priority: P5 - low Component: Architecture, internals, and plumbing Assignee: jonathan.druart at bugs.koha-community.org Reporter: jonathan.druart at bugs.koha-community.org QA Contact: testopia at bugs.koha-community.org Depends on: 13423 This subroutine is no longer in used. It was previously call from serials/serials-recieve.pl, which was not used and has been removed by commit 65b7ad030cd5cd0e3148fbbd1496d31b5cf149f7 Bug 13423: Remove unused serials-recieve Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13423 [Bug 13423] Unused code in serials-edit.tt and serials-recieve.tt -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Mar 15 17:27:07 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 15 Mar 2017 16:27:07 +0000 Subject: [Koha-bugs] [Bug 13423] Unused code in serials-edit.tt and serials-recieve.tt In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13423 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |18274 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18274 [Bug 18274] C4::Items - Remove GetItemStatus -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Mar 15 17:27:29 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 15 Mar 2017 16:27:29 +0000 Subject: [Koha-bugs] [Bug 18252] Move C4::Items code to the Koha namespace In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18252 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on| |18274 --- Comment #2 from Jonathan Druart --- Bug 18274 - C4::Items - Remove GetItemStatus Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18274 [Bug 18274] C4::Items - Remove GetItemStatus -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Mar 15 17:27:29 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 15 Mar 2017 16:27:29 +0000 Subject: [Koha-bugs] [Bug 18274] C4::Items - Remove GetItemStatus In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18274 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |18252 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18252 [Bug 18252] Move C4::Items code to the Koha namespace -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Mar 15 17:29:27 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 15 Mar 2017 16:29:27 +0000 Subject: [Koha-bugs] [Bug 18274] C4::Items - Remove GetItemStatus In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18274 --- Comment #1 from Jonathan Druart --- Created attachment 61107 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=61107&action=edit Bug 18274: C4::Items - Remove GetItemStatus This subroutine is no longer in used. It was previously call from serials/serials-recieve.pl, which was not used and has been removed by commit 65b7ad030cd5cd0e3148fbbd1496d31b5cf149f7 Bug 13423: Remove unused serials-recieve Test plan: git grep GetItemStatus should not return any used calls (only 1 occurrence in release notes) -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Mar 15 17:29:23 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 15 Mar 2017 16:29:23 +0000 Subject: [Koha-bugs] [Bug 18274] C4::Items - Remove GetItemStatus In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18274 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Mar 15 17:30:01 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 15 Mar 2017 16:30:01 +0000 Subject: [Koha-bugs] [Bug 15336] Script for merging vendors In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15336 Marc V?ron changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #61071|0 |1 is obsolete| | --- Comment #24 from Marc V?ron --- Created attachment 61108 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=61108&action=edit Bug 15336 - New command-line script: merge_bookseller.pl Test plan (i.e. merge bookseller n? 3 into the n? 6): run perl misc/migration_tools/merge_booksellers.pl -f 3 -t 6 -v -c Check that basketgroups, baskets, contacts, contracts and invoices had moved into bookseller 6. Check that bookseller n? 3 has been deleted. Remove -c (confirm) parameter to run in test mode only. Signed-off-by: Marc V?ron -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Mar 15 17:30:54 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 15 Mar 2017 16:30:54 +0000 Subject: [Koha-bugs] [Bug 15336] Script for merging vendors In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15336 Marc V?ron changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #61105|0 |1 is obsolete| | --- Comment #25 from Marc V?ron --- Created attachment 61109 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=61109&action=edit Bug 15336 - Fix unit tests (t/Bookseller.t) Signed-off-by: Marc V?ron -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Mar 15 17:31:17 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 15 Mar 2017 16:31:17 +0000 Subject: [Koha-bugs] [Bug 15336] Script for merging vendors In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15336 Marc V?ron changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Mar 15 17:41:23 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 15 Mar 2017 16:41:23 +0000 Subject: [Koha-bugs] [Bug 18256] Koha::Biblio - Remove GetItemsCount In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18256 Marc V?ron changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |veron at veron.ch --- Comment #4 from Marc V?ron --- Wanted to test but can not apply: sha1 information is lacking or useless(C4/Acquisition.pm) Missing dependency? -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Mar 15 17:52:23 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 15 Mar 2017 16:52:23 +0000 Subject: [Koha-bugs] [Bug 18204] Authority searches are not saved in Search history In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18204 Marc V?ron changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Patch doesn't apply CC| |veron at veron.ch --- Comment #2 from Marc V?ron --- Problem recreated. However, I can not apply the patch: git bz apply 18204 Result: Traceback (most recent call last): File "/usr/local/bin/git-bz", line 2630, in do_apply(*args) File "/usr/local/bin/git-bz", line 1755, in do_apply users = bug.server.get_xmlrpc_proxy().User.get({ 'names': [patch.attacher] })['users'] File "/usr/lib/python2.7/xmlrpclib.py", line 1233, in __call__ return self.__send(self.__name, args) File "/usr/lib/python2.7/xmlrpclib.py", line 1591, in __request verbose=self.__verbose File "/usr/lib/python2.7/xmlrpclib.py", line 1273, in request return self.single_request(host, handler, request_body, verbose) File "/usr/lib/python2.7/xmlrpclib.py", line 1321, in single_request response.msg, xmlrpclib.ProtocolError: -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Mar 15 18:36:37 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 15 Mar 2017 17:36:37 +0000 Subject: [Koha-bugs] [Bug 11077] Correct silent warnings in C4/Auth.pm In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11077 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |18275 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Mar 15 19:03:27 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 15 Mar 2017 18:03:27 +0000 Subject: [Koha-bugs] [Bug 18094] Patron search filters are broken by searchable attributes In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18094 Marc V?ron changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #60212|0 |1 is obsolete| | --- Comment #3 from Marc V?ron --- Created attachment 61111 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=61111&action=edit Bug 18094: Add tests to highlight the problem Signed-off-by: Marc V?ron -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Mar 15 19:04:25 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 15 Mar 2017 18:04:25 +0000 Subject: [Koha-bugs] [Bug 18094] Patron search filters are broken by searchable attributes In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18094 Marc V?ron changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #60213|0 |1 is obsolete| | --- Comment #4 from Marc V?ron --- Created attachment 61112 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=61112&action=edit Bug 18094: Only search in searchable patron attributes if searching in standard fields Test plan: - Add a new patron attrbute and mark it searchable - Populate a new patron with 'potato' in that field - Add/edit another patron to have email potato at invalidemail.com' - Perform a patron search with query 'potato' (in standard fields) => Both patrons are returned - Perform a patron search with filters 'Email' and query 'potato' => Only 1 patron is returned and you are redirected to the patron detail page. Followed test plan, works as expected. Signed-off-by: Marc V?ron -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Mar 15 19:04:44 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 15 Mar 2017 18:04:44 +0000 Subject: [Koha-bugs] [Bug 18094] Patron search filters are broken by searchable attributes In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18094 Marc V?ron changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off CC| |veron at veron.ch -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Mar 15 19:22:07 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 15 Mar 2017 18:22:07 +0000 Subject: [Koha-bugs] [Bug 17995] HOLDPLACED notice should have access to the reserves table In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17995 --- Comment #2 from Marc V?ron --- Created attachment 61115 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=61115&action=edit Bug 17995 - HOLDPLACED notice should have access to the reserves table To test: 1 - Add reserves.reservenotes to HOLDPLACED message 2 - Enable emailLibrarianWhenHoldIsPlaced OpacHoldNotes sysprefs 3 - Place a hold via OPAC with a note 4 - view the messagequeue and note the reservenotes is blank 5 - Apply patch 6 - Place a hold with a note 7 - view the messagequeue and note the reservenotes is populated Followed test plan, works as expected. Signed-off-by: Marc V?ron -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Mar 15 19:22:29 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 15 Mar 2017 18:22:29 +0000 Subject: [Koha-bugs] [Bug 17995] HOLDPLACED notice should have access to the reserves table In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17995 Marc V?ron changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off CC| |veron at veron.ch -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Mar 15 19:30:46 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 15 Mar 2017 18:30:46 +0000 Subject: [Koha-bugs] [Bug 18274] C4::Items - Remove GetItemStatus In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18274 Marc V?ron changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #61107|0 |1 is obsolete| | --- Comment #2 from Marc V?ron --- Created attachment 61116 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=61116&action=edit Bug 18274: C4::Items - Remove GetItemStatus This subroutine is no longer in used. It was previously call from serials/serials-recieve.pl, which was not used and has been removed by commit 65b7ad030cd5cd0e3148fbbd1496d31b5cf149f7 Bug 13423: Remove unused serials-recieve Test plan: git grep GetItemStatus should not return any used calls (only 1 occurrence in release notes) Signed-off-by: Marc V?ron -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Mar 15 19:31:08 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 15 Mar 2017 18:31:08 +0000 Subject: [Koha-bugs] [Bug 18274] C4::Items - Remove GetItemStatus In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18274 Marc V?ron changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |veron at veron.ch Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Mar 15 19:37:11 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 15 Mar 2017 18:37:11 +0000 Subject: [Koha-bugs] [Bug 17886] Don' t show option to add to existing list if there are no lists In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17886 Marc V?ron changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #59381|0 |1 is obsolete| | --- Comment #9 from Marc V?ron --- Created attachment 61117 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=61117&action=edit Bug 17886: Forgot to count the lists shared to patron The private_shelves_shared_with_me structure is defined, but has 0 entries. The missing .count is the issue. TEST PLAN --------- 1) Make sure no lists exist at all. 2) Make there is at least one findable biblio record entered 3) Find that biblio record in the OPAC 4) Click 'Save to your lists' -- Notice that the whole save to list section is there. 5) apply this patch 6) Click 'Cancel' 7) Click 'Save to your lists' -- Notice you can only add now, which makes sense. 8) run koha qa test tools. Followed test plan, works as expected. Signed-off-by: Marc V?ron -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Mar 15 19:38:18 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 15 Mar 2017 18:38:18 +0000 Subject: [Koha-bugs] [Bug 17886] Don' t show option to add to existing list if there are no lists In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17886 Marc V?ron changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off CC| |veron at veron.ch -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Mar 15 19:59:19 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 15 Mar 2017 18:59:19 +0000 Subject: [Koha-bugs] [Bug 18256] Koha::Biblio - Remove GetItemsCount In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18256 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #61052|0 |1 is obsolete| | --- Comment #5 from Jonathan Druart --- Created attachment 61119 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=61119&action=edit Bug 18256: Koha::Items - Remove GetItemsCount C4::Items::GetItemsCount can be replaced with Koha::Biblio->items->count Test plan: Create a bibliographic record with items attached Try to delete the record from a basket (acquisition module), the detail page and the batch item deletion tool. => You should not be able to delete it. Remove the items and then try again to delete the record => Now you must be able to delete it. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Mar 15 19:59:44 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 15 Mar 2017 18:59:44 +0000 Subject: [Koha-bugs] [Bug 18256] Koha::Biblio - Remove GetItemsCount In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18256 --- Comment #6 from Jonathan Druart --- (In reply to Marc V?ron from comment #4) > Wanted to test but can not apply: sha1 information is lacking or > useless(C4/Acquisition.pm) > Missing dependency? Looks ok for me, reattached it. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Mar 15 20:06:32 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 15 Mar 2017 19:06:32 +0000 Subject: [Koha-bugs] [Bug 8010] Search history can be added to the wrong patron In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8010 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Failed QA --- Comment #11 from Jonathan Druart --- And tests must be added to t/db_dependent/Search/History.t, in a new subtest. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Mar 15 20:08:23 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 15 Mar 2017 19:08:23 +0000 Subject: [Koha-bugs] [Bug 18276] New: Koha::Biblio - Remove GetBiblioFromItemNumber Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18276 Bug ID: 18276 Summary: Koha::Biblio - Remove GetBiblioFromItemNumber Change sponsored?: --- Product: Koha Version: unspecified Hardware: All OS: All Status: ASSIGNED Severity: enhancement Priority: P5 - low Component: Architecture, internals, and plumbing Assignee: jonathan.druart at bugs.koha-community.org Reporter: jonathan.druart at bugs.koha-community.org QA Contact: testopia at bugs.koha-community.org -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Mar 15 20:08:46 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 15 Mar 2017 19:08:46 +0000 Subject: [Koha-bugs] [Bug 18277] New: Koha::Biblio - Remove GetBiblionumberFromItemnumber Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18277 Bug ID: 18277 Summary: Koha::Biblio - Remove GetBiblionumberFromItemnumber Change sponsored?: --- Product: Koha Version: unspecified Hardware: All OS: All Status: ASSIGNED Severity: enhancement Priority: P5 - low Component: Architecture, internals, and plumbing Assignee: jonathan.druart at bugs.koha-community.org Reporter: jonathan.druart at bugs.koha-community.org QA Contact: testopia at bugs.koha-community.org -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Mar 15 20:09:14 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 15 Mar 2017 19:09:14 +0000 Subject: [Koha-bugs] [Bug 17628] Move bibliographic related code to Koha::Biblio In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17628 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on| |18276, 18277 --- Comment #6 from Jonathan Druart --- Bug 18276 - Koha::Biblio - Remove GetBiblioFromItemNumber Bug 18277 - Koha::Biblio - Remove GetBiblionumberFromItemnumber Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18276 [Bug 18276] Koha::Biblio - Remove GetBiblioFromItemNumber https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18277 [Bug 18277] Koha::Biblio - Remove GetBiblionumberFromItemnumber -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Mar 15 20:09:14 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 15 Mar 2017 19:09:14 +0000 Subject: [Koha-bugs] [Bug 18276] Koha::Biblio - Remove GetBiblioFromItemNumber In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18276 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |17628 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17628 [Bug 17628] Move bibliographic related code to Koha::Biblio -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Mar 15 20:09:14 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 15 Mar 2017 19:09:14 +0000 Subject: [Koha-bugs] [Bug 18277] Koha::Biblio - Remove GetBiblionumberFromItemnumber In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18277 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |17628 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17628 [Bug 17628] Move bibliographic related code to Koha::Biblio -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Mar 15 20:23:39 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 15 Mar 2017 19:23:39 +0000 Subject: [Koha-bugs] [Bug 18256] Koha::Biblio - Remove GetItemsCount In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18256 Marc V?ron changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #61119|0 |1 is obsolete| | --- Comment #7 from Marc V?ron --- Created attachment 61120 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=61120&action=edit Bug 18256: Koha::Items - Remove GetItemsCount C4::Items::GetItemsCount can be replaced with Koha::Biblio->items->count Test plan: Create a bibliographic record with items attached Try to delete the record from a basket (acquisition module), the detail page and the batch item deletion tool. => You should not be able to delete it. Remove the items and then try again to delete the record => Now you must be able to delete it. Followed test plan, works as expected. Signed-off-by: Marc V?ron -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Mar 15 20:23:51 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 15 Mar 2017 19:23:51 +0000 Subject: [Koha-bugs] [Bug 18256] Koha::Biblio - Remove GetItemsCount In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18256 Marc V?ron changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Mar 15 20:28:25 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 15 Mar 2017 19:28:25 +0000 Subject: [Koha-bugs] [Bug 18258] Add the Koha::Biblio->subscriptions method In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18258 Marc V?ron changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #61050|0 |1 is obsolete| | --- Comment #2 from Marc V?ron --- Created attachment 61121 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=61121&action=edit Bug 18258: Add the Koha::Biblio->subscriptions method Test plan: prove t/db_dependent/Koha/Biblios.t should return green Signed-off-by: Marc V?ron -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Mar 15 20:28:36 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 15 Mar 2017 19:28:36 +0000 Subject: [Koha-bugs] [Bug 18258] Add the Koha::Biblio->subscriptions method In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18258 Marc V?ron changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |veron at veron.ch Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Mar 15 20:48:47 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 15 Mar 2017 19:48:47 +0000 Subject: [Koha-bugs] [Bug 18242] Remove primary key on old_issues.issue_id In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18242 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |freddyguerr at gmail.com --- Comment #8 from Jonathan Druart --- *** Bug 18185 has been marked as a duplicate of this bug. *** -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Mar 15 20:48:47 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 15 Mar 2017 19:48:47 +0000 Subject: [Koha-bugs] [Bug 18185] Clears loan history In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18185 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Resolution|--- |DUPLICATE Status|NEW |RESOLVED --- Comment #17 from Jonathan Druart --- Marked as a duplicate of bug 18242, please reopen if it does not fix your issue. *** This bug has been marked as a duplicate of bug 18242 *** -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Mar 15 20:49:15 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 15 Mar 2017 19:49:15 +0000 Subject: [Koha-bugs] [Bug 18185] Clears loan history In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18185 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Version|16.11 |unspecified -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Wed Mar 15 20:52:25 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 15 Mar 2017 19:52:25 +0000 Subject: [Koha-bugs] [Bug 18276] Koha::Biblio - Remove GetBiblioFromItemNumber In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18276 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Mar 15 20:52:29 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 15 Mar 2017 19:52:29 +0000 Subject: [Koha-bugs] [Bug 18276] Koha::Biblio - Remove GetBiblioFromItemNumber In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18276 --- Comment #1 from Jonathan Druart --- Created attachment 61122 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=61122&action=edit Bug 18276: Remove GetBiblioFromItemNumber - Course reserves Values from the items, biblio and biblioitems tables are used in the template, so we need to pass all of them to the template, but separately. That way we easily see which field from which table we are displaying. Test plan: Create a course reserve and add items. Correct information must be displayed on the detail page of the course reserve, on staff and OPAC interface. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Mar 15 20:52:36 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 15 Mar 2017 19:52:36 +0000 Subject: [Koha-bugs] [Bug 18276] Koha::Biblio - Remove GetBiblioFromItemNumber In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18276 --- Comment #2 from Jonathan Druart --- Created attachment 61123 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=61123&action=edit Bug 18276: Remove GetBiblioFromItemNumber - ILSDI Test plan: Hit /cgi-bin/koha/ilsdi.pl?service=GetPatronInfo&patron_id=51&show_holds=1 The results should be the same before and after this patch -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Mar 15 20:52:45 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 15 Mar 2017 19:52:45 +0000 Subject: [Koha-bugs] [Bug 18276] Koha::Biblio - Remove GetBiblioFromItemNumber In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18276 --- Comment #4 from Jonathan Druart --- Created attachment 61125 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=61125&action=edit Bug 18276: Remove GetBiblioFromItemNumber - Easy ones The subroutine C4::Biblio::GetBiblioFromItemNumber was wrong for several reasons: - badly named, we can get biblio info from a barcode - SELECT * from items, biblio and biblioitems makes things hard to follow and debug, we never know where do come from the value we display - sometimes called only for trivial information such as biblionumber, author or title This patchset suggests to replace it with calls to: - Koha::Items->find for item's info - $item->biblio for biblio's info - $item->biblio->biblioitem for biblioitem's info Test plan: Item's info should correctly be displayed on the following pages: - circulation history - transfer book - checkin - waiting holds QA will check the other changes reading the code, it's trivial -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Mar 15 20:52:40 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 15 Mar 2017 19:52:40 +0000 Subject: [Koha-bugs] [Bug 18276] Koha::Biblio - Remove GetBiblioFromItemNumber In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18276 --- Comment #3 from Jonathan Druart --- Created attachment 61124 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=61124&action=edit Bug 18276: Remove GetBiblioFromItemNumber - circulation pages Test plan: 1. Checkout items in a batch The information displayed should be ok (title, subtitles, author, itemnotes, barcode) 2. Checkout an item using the standard checkout page You should correctly see the information of the item that has been checked out (title and author) -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Mar 15 20:52:52 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 15 Mar 2017 19:52:52 +0000 Subject: [Koha-bugs] [Bug 18276] Koha::Biblio - Remove GetBiblioFromItemNumber In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18276 --- Comment #5 from Jonathan Druart --- Created attachment 61126 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=61126&action=edit Bug 18276: Remove the C4::Biblio::GetBiblioFromItemNumber subroutine -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Mar 15 20:53:25 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 15 Mar 2017 19:53:25 +0000 Subject: [Koha-bugs] [Bug 18277] Koha::Biblio - Remove GetBiblionumberFromItemnumber In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18277 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Mar 15 20:53:31 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 15 Mar 2017 19:53:31 +0000 Subject: [Koha-bugs] [Bug 18277] Koha::Biblio - Remove GetBiblionumberFromItemnumber In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18277 --- Comment #1 from Jonathan Druart --- Created attachment 61127 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=61127&action=edit Bug 18277: Remove GetBiblionumberFromItemnumber - Easy ones To retrieve a biblionumber from an itemnumber, we can use: Koha::Item->biblio->biblionumber This is only what this patchset does. Doing that we will be able to get rid of the C4::Biblio::GetBiblionumberFromItemnumber subroutine. Test plan: - Acquisition module: cancel a receipt - Export a record to CSV - Modify items in a batch Item's info should be correct Other changes with be checked by QA team, by reading the code. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Mar 15 20:53:46 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 15 Mar 2017 19:53:46 +0000 Subject: [Koha-bugs] [Bug 18277] Koha::Biblio - Remove GetBiblionumberFromItemnumber In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18277 --- Comment #3 from Jonathan Druart --- Created attachment 61129 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=61129&action=edit Bug 18277: Remove GetBiblionumberFromItemnumber - create_analytical_rel.pl I have no idea how to test this patch, see bug 5528, or simply read the code. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Mar 15 20:53:37 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 15 Mar 2017 19:53:37 +0000 Subject: [Koha-bugs] [Bug 18277] Koha::Biblio - Remove GetBiblionumberFromItemnumber In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18277 --- Comment #2 from Jonathan Druart --- Created attachment 61128 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=61128&action=edit Bug 18277: Remove GetBiblionumberFromItemnumber - linkitem Test plan: Enable EasyAnalyticalRecords and link an item to another one (Edit > link to host item) -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Mar 15 20:53:52 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 15 Mar 2017 19:53:52 +0000 Subject: [Koha-bugs] [Bug 18277] Koha::Biblio - Remove GetBiblionumberFromItemnumber In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18277 --- Comment #4 from Jonathan Druart --- Created attachment 61130 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=61130&action=edit Bug 18277: Remove the C4::Biblio::GetBiblionumberFromItemnumber -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Mar 15 20:54:28 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 15 Mar 2017 19:54:28 +0000 Subject: [Koha-bugs] [Bug 18277] Koha::Biblio - Remove GetBiblionumberFromItemnumber In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18277 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on| |18276 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18276 [Bug 18276] Koha::Biblio - Remove GetBiblioFromItemNumber -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Mar 15 20:54:28 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 15 Mar 2017 19:54:28 +0000 Subject: [Koha-bugs] [Bug 18276] Koha::Biblio - Remove GetBiblioFromItemNumber In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18276 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |18277 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18277 [Bug 18277] Koha::Biblio - Remove GetBiblionumberFromItemnumber -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Mar 15 21:13:02 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 15 Mar 2017 20:13:02 +0000 Subject: [Koha-bugs] [Bug 18274] C4::Items - Remove GetItemStatus In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18274 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |https://bugs.koha-community | |.org/bugzilla3/show_bug.cgi | |?id=18278 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Mar 15 21:13:02 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 15 Mar 2017 20:13:02 +0000 Subject: [Koha-bugs] [Bug 18278] New: C4::Items - Remove GetItemLocation Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18278 Bug ID: 18278 Summary: C4::Items - Remove GetItemLocation Change sponsored?: --- Product: Koha Version: unspecified Hardware: All OS: All Status: ASSIGNED Severity: enhancement Priority: P5 - low Component: Architecture, internals, and plumbing Assignee: jonathan.druart at bugs.koha-community.org Reporter: jonathan.druart at bugs.koha-community.org QA Contact: testopia at bugs.koha-community.org Same as bug 18274, but for GetItemLocation This subroutine is no longer in used. It was previously call from serials/serials-recieve.pl, which was not used and has been removed by commit 65b7ad030cd5cd0e3148fbbd1496d31b5cf149f7 Bug 13423: Remove unused serials-recieve -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Mar 15 21:13:23 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 15 Mar 2017 20:13:23 +0000 Subject: [Koha-bugs] [Bug 18252] Move C4::Items code to the Koha namespace In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18252 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on| |18278 --- Comment #3 from Jonathan Druart --- Bug 18278 - C4::Items - Remove GetItemLocation Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18278 [Bug 18278] C4::Items - Remove GetItemLocation -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Mar 15 21:13:23 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 15 Mar 2017 20:13:23 +0000 Subject: [Koha-bugs] [Bug 18278] C4::Items - Remove GetItemLocation In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18278 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |18252 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18252 [Bug 18252] Move C4::Items code to the Koha namespace -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Mar 15 21:14:27 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 15 Mar 2017 20:14:27 +0000 Subject: [Koha-bugs] [Bug 18274] C4::Items - Remove GetItemStatus In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18274 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |18278 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18278 [Bug 18278] C4::Items - Remove GetItemLocation -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Mar 15 21:14:27 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 15 Mar 2017 20:14:27 +0000 Subject: [Koha-bugs] [Bug 18278] C4::Items - Remove GetItemLocation In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18278 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on| |18274 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18274 [Bug 18274] C4::Items - Remove GetItemStatus -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Mar 15 21:15:45 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 15 Mar 2017 20:15:45 +0000 Subject: [Koha-bugs] [Bug 18278] C4::Items - Remove GetItemLocation In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18278 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Mar 15 21:15:49 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 15 Mar 2017 20:15:49 +0000 Subject: [Koha-bugs] [Bug 18278] C4::Items - Remove GetItemLocation In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18278 --- Comment #1 from Jonathan Druart --- Created attachment 61131 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=61131&action=edit Bug 18278: C4::Items - Remove GetItemLocation This subroutine is no longer in used. It was previously call from serials/serials-recieve.pl, which was not used and has been removed by commit 65b7ad030cd5cd0e3148fbbd1496d31b5cf149f7 Bug 13423: Remove unused serials-recieve Test plan: git grep GetItemLocation -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Mar 15 21:29:52 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 15 Mar 2017 20:29:52 +0000 Subject: [Koha-bugs] [Bug 13757] Make patron attributes editable in the opac if set to ' editable in OPAC' In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13757 Nick Clemens changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Mar 15 21:29:56 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 15 Mar 2017 20:29:56 +0000 Subject: [Koha-bugs] [Bug 13757] Make patron attributes editable in the opac if set to ' editable in OPAC' In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13757 Nick Clemens changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #58706|0 |1 is obsolete| | Attachment #58707|0 |1 is obsolete| | Attachment #58708|0 |1 is obsolete| | Attachment #58709|0 |1 is obsolete| | Attachment #58710|0 |1 is obsolete| | Attachment #58711|0 |1 is obsolete| | Attachment #58712|0 |1 is obsolete| | Attachment #58713|0 |1 is obsolete| | Attachment #58714|0 |1 is obsolete| | Attachment #58715|0 |1 is obsolete| | Attachment #59376|0 |1 is obsolete| | Attachment #59737|0 |1 is obsolete| | Attachment #59738|0 |1 is obsolete| | Attachment #59739|0 |1 is obsolete| | Attachment #59896|0 |1 is obsolete| | Attachment #59897|0 |1 is obsolete| | Attachment #59898|0 |1 is obsolete| | Attachment #60359|0 |1 is obsolete| | Attachment #60360|0 |1 is obsolete| | --- Comment #84 from Nick Clemens --- Created attachment 61132 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=61132&action=edit Bug 13757: Add the option to set patron attributes editable in the OPAC Note: this is a squashed version of the original patchset, because it was needed This patch adds an opac_editable property of borrower attribute types that can be set in the interface. I'm removing work on OPAC and will refactor it, keeping the author attribution. Test plan: 1. Repeat the following with a new and existing borrower attribute type: 2. Verify that "Editable in OPAC" can only be checked if "Display in OPAC" is checked. 3. Verify that this new property is correctly saved. Signed-off-by: Aleisha Signed-off-by: Tomas Cohen Arazi Signed-off-by: Nick Clemens -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Mar 15 21:30:04 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 15 Mar 2017 20:30:04 +0000 Subject: [Koha-bugs] [Bug 13757] Make patron attributes editable in the opac if set to ' editable in OPAC' In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13757 --- Comment #85 from Nick Clemens --- Created attachment 61133 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=61133&action=edit Bug 13757: DB update Signed-off-by: Tomas Cohen Arazi Signed-off-by: Nick Clemens -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Mar 15 21:30:11 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 15 Mar 2017 20:30:11 +0000 Subject: [Koha-bugs] [Bug 13757] Make patron attributes editable in the opac if set to ' editable in OPAC' In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13757 --- Comment #86 from Nick Clemens --- Created attachment 61134 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=61134&action=edit Bug 13757: OPAC changes Signed-off-by: Tomas Cohen Arazi Signed-off-by: Nick Clemens -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Mar 15 21:30:18 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 15 Mar 2017 20:30:18 +0000 Subject: [Koha-bugs] [Bug 13757] Make patron attributes editable in the opac if set to ' editable in OPAC' In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13757 --- Comment #87 from Nick Clemens --- Created attachment 61135 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=61135&action=edit Bug 13757: DBIC update Signed-off-by: Tomas Cohen Arazi Signed-off-by: Nick Clemens -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Mar 15 21:30:25 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 15 Mar 2017 20:30:25 +0000 Subject: [Koha-bugs] [Bug 13757] Make patron attributes editable in the opac if set to ' editable in OPAC' In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13757 --- Comment #88 from Nick Clemens --- Created attachment 61136 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=61136&action=edit Bug 13757: Add extended attributes to the patron modification Signed-off-by: Tomas Cohen Arazi Signed-off-by: Nick Clemens -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Mar 15 21:30:32 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 15 Mar 2017 20:30:32 +0000 Subject: [Koha-bugs] [Bug 13757] Make patron attributes editable in the opac if set to ' editable in OPAC' In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13757 --- Comment #89 from Nick Clemens --- Created attachment 61137 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=61137&action=edit Bug 13757: (followup) Remove warnings Signed-off-by: Tomas Cohen Arazi Signed-off-by: Nick Clemens -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Mar 15 21:30:39 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 15 Mar 2017 20:30:39 +0000 Subject: [Koha-bugs] [Bug 13757] Make patron attributes editable in the opac if set to ' editable in OPAC' In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13757 --- Comment #90 from Nick Clemens --- Created attachment 61138 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=61138&action=edit Bug 13757: (followup) Staff interface changes This patch adds proper extended attributes display and handling on the patron modifications moderation page (members-update.pl). It also adds changes checking to the opac-memberentry.pl page so it only saves a modification request if there are changes (it only checked regular fields and not the extended ones). Signed-off-by: Tomas Cohen Arazi Signed-off-by: Nick Clemens -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Mar 15 21:30:47 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 15 Mar 2017 20:30:47 +0000 Subject: [Koha-bugs] [Bug 13757] Make patron attributes editable in the opac if set to ' editable in OPAC' In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13757 --- Comment #91 from Nick Clemens --- Created attachment 61139 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=61139&action=edit Bug 13757: (followup) Only touch opac_editable attributes As reported by Owen, the members-update.pl was showing every attributes the patron has (display issue) instead of showing only those affected by the changes. This patch fixes this by filtering the patron's attributes by opac editability. It also fixes Koha::Patron::Modification->approve so it only clears the attributes with the updating 'code' and leaves the others untouched. As its been coded so far (until someone refactors it all) the Koha::Patron::Modification object needs to contain all the attributes for a specific code. And it comes from parsing the UI's input. Tests for Koha::Patron::Modification->approve to come. Signed-off-by: Tomas Cohen Arazi Signed-off-by: Nick Clemens -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Mar 15 21:30:53 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 15 Mar 2017 20:30:53 +0000 Subject: [Koha-bugs] [Bug 13757] Make patron attributes editable in the opac if set to ' editable in OPAC' In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13757 --- Comment #92 from Nick Clemens --- Created attachment 61140 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=61140&action=edit Bug 13757: (followup) Regression tests for ->approve changes Signed-off-by: Tomas Cohen Arazi Signed-off-by: Nick Clemens -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Mar 15 21:30:59 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 15 Mar 2017 20:30:59 +0000 Subject: [Koha-bugs] [Bug 13757] Make patron attributes editable in the opac if set to ' editable in OPAC' In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13757 --- Comment #93 from Nick Clemens --- Created attachment 61141 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=61141&action=edit Bug 13757: (followup) Fix authorized value display when opac_display & not opac_editable Signed-off-by: Tomas Cohen Arazi Signed-off-by: Nick Clemens -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Mar 15 21:31:05 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 15 Mar 2017 20:31:05 +0000 Subject: [Koha-bugs] [Bug 13757] Make patron attributes editable in the opac if set to ' editable in OPAC' In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13757 --- Comment #94 from Nick Clemens --- Created attachment 61142 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=61142&action=edit Bug 13757: (QA followup) Check DB structure before altering table Signed-off-by: Tomas Cohen Arazi Signed-off-by: Nick Clemens -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Mar 15 21:31:11 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 15 Mar 2017 20:31:11 +0000 Subject: [Koha-bugs] [Bug 13757] Make patron attributes editable in the opac if set to ' editable in OPAC' In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13757 --- Comment #95 from Nick Clemens --- Created attachment 61143 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=61143&action=edit Bug 13757: (regression tests) Empty attributes should delete existing This patch introduces tests for the required functionality. To test: - Run: $ prove t/db_dependent/Koha/Patron/Modifications.t => FAIL: The current code doesn't work like that Signed-off-by: Tomas Cohen Arazi https://bugs.koha-community.org/show_bug.cgi?id=13737 Signed-off-by: Nick Clemens -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Mar 15 21:31:18 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 15 Mar 2017 20:31:18 +0000 Subject: [Koha-bugs] [Bug 13757] Make patron attributes editable in the opac if set to ' editable in OPAC' In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13757 --- Comment #96 from Nick Clemens --- Created attachment 61144 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=61144&action=edit Bug 13757: Make Koha::Patron::Modification->store del empty attrs This patch makes Koha::Patron::Modification->store delete the passed attributes that contain empty values. This is the way it currently works, as all opac-editable attributes are presented to the end-user and they are allowed to delete them, and the best way I found to represent the deletion on the modification request is by setting it to the empty string. I chose this way because it is how the staff interface handles it, so it is consistent. To test: - Apply this patch - Run: $ prove t/db_dependent/Koha/Patron/Modifications.t => SUCCESS: This time tests pass! - Verify comment #70 on the bug is fixed now - Sign off :-D Signed-off-by: Tomas Cohen Arazi https://bugs.koha-community.org/show_bug.cgi?id=13737 Signed-off-by: Nick Clemens -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Mar 15 21:31:24 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 15 Mar 2017 20:31:24 +0000 Subject: [Koha-bugs] [Bug 13757] Make patron attributes editable in the opac if set to ' editable in OPAC' In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13757 --- Comment #97 from Nick Clemens --- Created attachment 61145 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=61145&action=edit Bug 13757: (QA followup) Make opac-memberentry.pl handle attrs deletion The original code on this bug skipped empty-valued attributes. But emptying attributes is the only way to tell the controller script that the user wants to delete them. This patch makes opac-memberentry.pl check the existence of attributes sharing the code of the empty for the given patron, and it stores the deletion on the Koha::Patron::Modification as needed. Otherwise deletions got skipped. To test: - Verify setting/deleting attributes that are opac-editable and verify the results are sound. https://bugs.koha-community.org/show_bug.cgi?id=13737 Signed-off-by: Nick Clemens -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Mar 15 21:31:38 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 15 Mar 2017 20:31:38 +0000 Subject: [Koha-bugs] [Bug 13757] Make patron attributes editable in the opac if set to ' editable in OPAC' In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13757 --- Comment #98 from Nick Clemens --- Created attachment 61146 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=61146&action=edit Bug 13757: (QA followup) Fix non-editable attrs on failed save When a field is not editable but displayable in the OPAC, and you submit an incomplete/wrong update, those attributes are displayed as empty. This patch fixes that. Signed-off-by: Tomas Cohen Arazi Signed-off-by: Nick Clemens -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Mar 15 21:31:44 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 15 Mar 2017 20:31:44 +0000 Subject: [Koha-bugs] [Bug 13757] Make patron attributes editable in the opac if set to ' editable in OPAC' In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13757 --- Comment #99 from Nick Clemens --- Created attachment 61147 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=61147&action=edit Bug 13757: Make K::P::Modifications->pending return K::P::Attribute This patch makes Koha::Patron::Modifications->pending return Koha::Patron:Attribute objects. They are not stored on the DB but only live in memory on runtime. members-update.pl is the only place this is used, and this way we have all we need for better rendering the UI. Tests are added for the changed API. Signed-off-by: Nick Clemens -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Mar 15 21:31:52 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 15 Mar 2017 20:31:52 +0000 Subject: [Koha-bugs] [Bug 13757] Make patron attributes editable in the opac if set to ' editable in OPAC' In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13757 --- Comment #100 from Nick Clemens --- Created attachment 61148 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=61148&action=edit Bug 13757: Better display for attr changes in members-update.pl This patch changes the way changed attributes are displayed for the staff user to make the decision to approve (or not) the changes. Regards Signed-off-by: Nick Clemens -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Mar 15 21:31:58 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 15 Mar 2017 20:31:58 +0000 Subject: [Koha-bugs] [Bug 13757] Make patron attributes editable in the opac if set to ' editable in OPAC' In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13757 --- Comment #101 from Nick Clemens --- Created attachment 61149 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=61149&action=edit Bug 13757: (regression test) Attribute with value 0 should be stored Signed-off-by: Tomas Cohen Arazi Signed-off-by: Nick Clemens -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Mar 15 21:32:05 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 15 Mar 2017 20:32:05 +0000 Subject: [Koha-bugs] [Bug 13757] Make patron attributes editable in the opac if set to ' editable in OPAC' In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13757 --- Comment #102 from Nick Clemens --- Created attachment 61150 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=61150&action=edit Bug 13757: Attribute with value 0 should be stored Signed-off-by: Tomas Cohen Arazi Signed-off-by: Nick Clemens -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Mar 15 21:33:05 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 15 Mar 2017 20:33:05 +0000 Subject: [Koha-bugs] [Bug 18278] C4::Items - Remove GetItemLocation In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18278 Marc V?ron changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |veron at veron.ch --- Comment #2 from Marc V?ron --- git grep GetItemLocation Result: GetItemLocation in C4/Items.pm (line 70) -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Mar 15 21:48:42 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 15 Mar 2017 20:48:42 +0000 Subject: [Koha-bugs] [Bug 18278] C4::Items - Remove GetItemLocation In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18278 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #61131|0 |1 is obsolete| | --- Comment #3 from Jonathan Druart --- Created attachment 61151 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=61151&action=edit Bug 18278: C4::Items - Remove GetItemLocation This subroutine is no longer in used. It was previously call from serials/serials-recieve.pl, which was not used and has been removed by commit 65b7ad030cd5cd0e3148fbbd1496d31b5cf149f7 Bug 13423: Remove unused serials-recieve Test plan: git grep GetItemLocation -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Mar 15 22:03:36 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 15 Mar 2017 21:03:36 +0000 Subject: [Koha-bugs] [Bug 14004] Add ability to temporarily disable intranetuserjs / opacuserjs In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14004 --- Comment #1 from Barton Chittenden --- Actually, it would be even nicer if this could be handled via an option in the URL, eg. .../cgi-bin/koha/catalogue/itemsearch.pl?disbable_intranetuserjs=true -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Wed Mar 15 22:22:26 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 15 Mar 2017 21:22:26 +0000 Subject: [Koha-bugs] [Bug 18279] New: C4::Items - Remove GetLostItems Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18279 Bug ID: 18279 Summary: C4::Items - Remove GetLostItems Change sponsored?: --- Product: Koha Version: unspecified Hardware: All OS: All Status: ASSIGNED Severity: enhancement Priority: P5 - low Component: Architecture, internals, and plumbing Assignee: jonathan.druart at bugs.koha-community.org Reporter: jonathan.druart at bugs.koha-community.org QA Contact: testopia at bugs.koha-community.org -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Mar 15 22:22:44 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 15 Mar 2017 21:22:44 +0000 Subject: [Koha-bugs] [Bug 18279] C4::Items - Remove GetLostItems In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18279 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |18252 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18252 [Bug 18252] Move C4::Items code to the Koha namespace -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Mar 15 22:22:44 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 15 Mar 2017 21:22:44 +0000 Subject: [Koha-bugs] [Bug 18252] Move C4::Items code to the Koha namespace In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18252 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on| |18279 --- Comment #4 from Jonathan Druart --- Bug 18279 - C4::Items - Remove GetLostItems Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18279 [Bug 18279] C4::Items - Remove GetLostItems -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Mar 15 22:30:38 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 15 Mar 2017 21:30:38 +0000 Subject: [Koha-bugs] [Bug 18279] C4::Items - Remove GetLostItems In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18279 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Mar 15 22:30:43 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 15 Mar 2017 21:30:43 +0000 Subject: [Koha-bugs] [Bug 18279] C4::Items - Remove GetLostItems In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18279 --- Comment #1 from Jonathan Druart --- Created attachment 61152 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=61152&action=edit Bug 18279: Remove C4::Items::GetLostItems The JOIN done by this subroutine are not always useful (depending on item-level_itypes). They also search with LIKE when it is not needed. Since we have now Koha::Items, we can replace this subroutine with a call to Koha::Items->search with the correct parameters. A change in previous behaviours can happen: If a items.itemlost contains a value that is not defined as a LOST authorised value, the item will not be displayed. I think it's the expected behaviour, even if it should not happen in correctly configured installations. Test plan: To test with item-level_itypes set to item and biblio: List the lost items you have on your system, using the different filters available. The result table should contain the correct item's info. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Mar 15 22:55:19 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 15 Mar 2017 21:55:19 +0000 Subject: [Koha-bugs] [Bug 18278] C4::Items - Remove GetItemLocation In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18278 Marc V?ron changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #61151|0 |1 is obsolete| | --- Comment #4 from Marc V?ron --- Created attachment 61153 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=61153&action=edit Bug 18278: C4::Items - Remove GetItemLocation This subroutine is no longer in used. It was previously call from serials/serials-recieve.pl, which was not used and has been removed by commit 65b7ad030cd5cd0e3148fbbd1496d31b5cf149f7 Bug 13423: Remove unused serials-recieve Test plan: git grep GetItemLocation Signed-off-by: Marc V?ron -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Mar 15 22:55:31 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 15 Mar 2017 21:55:31 +0000 Subject: [Koha-bugs] [Bug 18278] C4::Items - Remove GetItemLocation In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18278 Marc V?ron changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Mar 15 22:59:53 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 15 Mar 2017 21:59:53 +0000 Subject: [Koha-bugs] [Bug 18093] Add the Koha::Objects->get_column method In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18093 --- Comment #6 from Jonathan Druart --- Created attachment 61154 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=61154&action=edit Bug 18093: Koha::Objects->get_column should not return a DBIC object -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Mar 15 23:00:40 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 15 Mar 2017 22:00:40 +0000 Subject: [Koha-bugs] [Bug 18093] Add the Koha::Objects->get_column method In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18093 --- Comment #7 from Jonathan Druart --- (In reply to Marcel de Rooy from comment #5) > (In reply to Jonathan Druart from comment #4) > > I wanted to add a follow-up for something but finally did not need it. > > It is not important for now, but we may need it later. > > How would you use it? I would have used it how I did in the test. > Koha Objects more-or-less encapsulate DBIx, but here you do not. > Would returning an array of values be enough? Do you think it's better with this second patch? -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Mar 15 23:26:19 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 15 Mar 2017 22:26:19 +0000 Subject: [Koha-bugs] [Bug 5528] Analytical records support In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5528 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |jonathan.druart at bugs.koha-c | |ommunity.org --- Comment #20 from Jonathan Druart --- A bit late but, 'hostitemsflag' is passed several times to the templates, but never used. Is there something missing or this flag is useless? -- You are receiving this mail because: You are watching all bug changes. You are the QA Contact for the bug. From bugzilla-daemon at bugs.koha-community.org Wed Mar 15 23:48:58 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 15 Mar 2017 22:48:58 +0000 Subject: [Koha-bugs] [Bug 18280] New: Item barcodes should be locked when record is created Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18280 Bug ID: 18280 Summary: Item barcodes should be locked when record is created Change sponsored?: --- Product: Koha Version: 16.05 Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Cataloging Assignee: gmcharlt at gmail.com Reporter: david.roberts at ptfs-europe.com QA Contact: testopia at bugs.koha-community.org CC: m.de.rooy at rijksmuseum.nl When several cataloguers are cataloguing simultaneously and the autoBarcode system preference is set to generate the barcodes in 1, 2, 3 form, it is possible that the same item barcode will be assigned to two different items at the same time which prevents the record from being saved. Koha should lock the barcode in some way once it has been allocated, even if the item record is not yet saved. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Mar 16 06:44:06 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 16 Mar 2017 05:44:06 +0000 Subject: [Koha-bugs] [Bug 18281] New: Unable to import dump after upgrade to 16.11 Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18281 Bug ID: 18281 Summary: Unable to import dump after upgrade to 16.11 Change sponsored?: --- Product: Koha Version: 16.11 Hardware: All OS: All Status: NEW Severity: normal Priority: P5 - low Component: Installation and upgrade (web-based installer) Assignee: koha-bugs at lists.koha-community.org Reporter: tejoskumar at gmail.com QA Contact: testopia at bugs.koha-community.org CC: gmcharlt at gmail.com Iam receiving the below error, after upgrading from 3.22.6 to 16.11.4. Upgrading was successful and it was working fine. I exported the backup dump from 3.22.6 and imported the data to 16.11.4. Import data was not successful. Also the below error I got when I tried to login to the koha login page(Both staff and opac) - Software error: DBIx::Class::Storage::DBI::_dbh_execute(): Unknown column 'me.sms_provider_id' in 'field list' at /usr/share/koha/lib/Koha/Objects.pm line 83 For help, please send mail to the webmaster ([no address given]), giving this error message and the time and date of the error. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Thu Mar 16 08:38:51 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 16 Mar 2017 07:38:51 +0000 Subject: [Koha-bugs] [Bug 18093] Add the Koha::Objects->get_column method In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18093 Marcel de Rooy changed: What |Removed |Added ---------------------------------------------------------------------------- QA Contact|testopia at bugs.koha-communit |m.de.rooy at rijksmuseum.nl |y.org | Patch complexity|--- |Small patch -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Mar 16 08:39:13 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 16 Mar 2017 07:39:13 +0000 Subject: [Koha-bugs] [Bug 18093] Add the Koha::Objects->get_column method In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18093 Marcel de Rooy changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #60115|0 |1 is obsolete| | --- Comment #8 from Marcel de Rooy --- Created attachment 61155 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=61155&action=edit Bug 18093: Add Koha::Objects->get_column Test plan: prove t/db_dependent/Koha/Objects.t Should return green Followed test plan, result as expected Signed-off-by: Marc V?ron Signed-off-by: Marcel de Rooy -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Mar 16 08:39:18 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 16 Mar 2017 07:39:18 +0000 Subject: [Koha-bugs] [Bug 18093] Add the Koha::Objects->get_column method In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18093 Marcel de Rooy changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #61154|0 |1 is obsolete| | --- Comment #9 from Marcel de Rooy --- Created attachment 61156 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=61156&action=edit Bug 18093: Koha::Objects->get_column should not return a DBIC object Signed-off-by: Marcel de Rooy -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Mar 16 08:39:29 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 16 Mar 2017 07:39:29 +0000 Subject: [Koha-bugs] [Bug 18093] Add the Koha::Objects->get_column method In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18093 Marcel de Rooy changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Mar 16 08:44:07 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 16 Mar 2017 07:44:07 +0000 Subject: [Koha-bugs] [Bug 7143] Bug for tracking changes to the about page In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7143 Marcel de Rooy changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Thu Mar 16 08:44:13 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 16 Mar 2017 07:44:13 +0000 Subject: [Koha-bugs] [Bug 7143] Bug for tracking changes to the about page In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7143 Marcel de Rooy changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #61068|0 |1 is obsolete| | --- Comment #361 from Marcel de Rooy --- Created attachment 61157 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=61157&action=edit Bug 7143: Add Patricio Marrone to history.txt Signed-off-by: Tomas Cohen Arazi Signed-off-by: Marcel de Rooy -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Thu Mar 16 08:45:19 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 16 Mar 2017 07:45:19 +0000 Subject: [Koha-bugs] [Bug 7143] Bug for tracking changes to the about page In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7143 Marcel de Rooy changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA --- Comment #362 from Marcel de Rooy --- Taking the liberty to promote this trivial patch to PQA directly. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Thu Mar 16 08:49:22 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 16 Mar 2017 07:49:22 +0000 Subject: [Koha-bugs] [Bug 18265] Followup to Bug 17196. deletedbiblio_metadata is not used. biblioitemnumber was forgotten In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18265 Olli-Antti Kivilahti changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #61090|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Mar 16 09:01:30 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 16 Mar 2017 08:01:30 +0000 Subject: [Koha-bugs] [Bug 18265] Followup to Bug 17196. deletedbiblio_metadata is not used. biblioitemnumber was forgotten In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18265 --- Comment #12 from Olli-Antti Kivilahti --- (In reply to Jonathan Druart from comment #11) > (In reply to Jonathan Druart from comment #7) > > You are going too far with this patch, we need a quick patch to fix the data > > lost when deleting a bibliographic record, I have to disagree. You need properly implemented features, not small steps and quick fixes. > > then we can discuss other points > > on another bug report. Would you agree with that? > > What about this important part? I have already spent a significant amount of time (8h+) on this bug. This preserves existing data structure functionally as it was intended. Also there is no mention on Bug 17196 about the intent of merging biblio and biblioitems. There is a mention about Koha::MetadataRecord but there is no reason that would require the supposed merge. I have no interest atm for any discussion about this bug ticket. You are free to continue doing whatever you please. However I recommend you salvage the test case attached. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Mar 16 09:41:35 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 16 Mar 2017 08:41:35 +0000 Subject: [Koha-bugs] [Bug 18279] C4::Items - Remove GetLostItems In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18279 Marc V?ron changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Patch doesn't apply CC| |veron at veron.ch --- Comment #2 from Marc V?ron --- DOes not apply: Merge conflict in C4/Items.pm -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Mar 16 09:58:21 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 16 Mar 2017 08:58:21 +0000 Subject: [Koha-bugs] [Bug 15219] Server-side processing and pagination on checkouts tables In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15219 Julian Maurice changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #60071|0 |1 is obsolete| | --- Comment #15 from Julian Maurice --- Created attachment 61158 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=61158&action=edit Bug 15219: Server-side processing and pagination on checkouts tables Some libraries have patrons with more than 1000 checkouts. Loading all of them at once can be very long, and sometimes can cause timeout errors. This patch prevent that by enabling server-side processing and pagination on checkouts tables. This affects patron's checkouts and patron's relatives' checkouts tables on pages circ/circulation.pl and members/moremember.pl. As server-side processing can be useless and cumbersome with small sets of data, a new system preference is introduced to control this behaviour (server-side processing is disabled by default). Additionally, this patch: - adds a switch to turn off and on row grouping (today's checkouts vs previous checkouts) (on by default) - adds "column settings" for relatives' checkouts tables - factorize some code that was duplicated across the two DataTables configurations (mDataProp) Test plan: 1. Find (or create) a patron that have at least 10 checkouts and where the relatives checkouts table contain at least 10 checkouts. 2. Go to the patron's detail page and check everything works fine in both tables (sorting, pagination, the data itself, ...) 3. Do the same on circulation page (circulation.pl) 4. Enable system preference ServerSideCheckoutsTable 5. Repeat steps 2 and 3 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Mar 16 09:58:26 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 16 Mar 2017 08:58:26 +0000 Subject: [Koha-bugs] [Bug 15219] Server-side processing and pagination on checkouts tables In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15219 Julian Maurice changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #60642|0 |1 is obsolete| | --- Comment #16 from Julian Maurice --- Created attachment 61159 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=61159&action=edit Bug 15219: Fix date sorting when server-side processing is disabled Use DataTables 'columns' option instead of 'aoColumns' This allow more control on what data is used for display, sorting, filtering, ... A large part of this patch is about rewording things to better match the DataTables documentation. The real change is that "mRender": renderingFunc becomes "render": { "display": renderingFunc } So the return value of renderingFunc is now only used for display (not for filtering, sorting, ...) -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Mar 16 10:05:36 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 16 Mar 2017 09:05:36 +0000 Subject: [Koha-bugs] [Bug 18276] Koha::Biblio - Remove GetBiblioFromItemNumber In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18276 Marc V?ron changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |veron at veron.ch --- Comment #6 from Marc V?ron --- While testing first patch I get an Internal Server Error. Plack error log says: Template process failed: undef error - The method ccode is not covered by tests! at (...)/C4/Templates.pm line 121. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Mar 16 10:06:39 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 16 Mar 2017 09:06:39 +0000 Subject: [Koha-bugs] [Bug 15235] Add column filters to checkouts table In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15235 Julian Maurice changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #60079|0 |1 is obsolete| | --- Comment #4 from Julian Maurice --- Created attachment 61160 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=61160&action=edit Bug 15235: Add column filters to checkouts table This adds a switch that allow to enable/disable column filters on checkouts table (disabled by default) Depends on bug 15219 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Mar 16 11:10:29 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 16 Mar 2017 10:10:29 +0000 Subject: [Koha-bugs] [Bug 15707] Add ability to define hierarchical groups of libraries In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15707 --- Comment #168 from Kyle M Hall --- (In reply to Jonathan Druart from comment #167) > (In reply to Kyle M Hall from comment #166) > > > - If Search groups contain several levels of subgroups, only the first one > > > will be used. Not sure it's the expected behaviour. > > > > > > Example: > > > __SEARCH_GROUP__ > > > Group 1 > > > Library 1 > > > Subgroup > > > Library 2 > > > > > > Search on "Group 1" will search in library 1. > > > > That is expected behavior and will be documented in the manual. There is no > > additional utility for this particular feature to sub-groups. > > If L1 is in a subgroup that is in a group, L1 is not considered part of the > group? > This behaviour sounds very weird. > Why did you choose this behaviour? For efficiency. If you think it makes more sense to have all libraries in all subgroups selected as well I'd be happy to change it. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Mar 16 11:16:23 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 16 Mar 2017 10:16:23 +0000 Subject: [Koha-bugs] [Bug 18265] Followup to Bug 17196. deletedbiblio_metadata is not used. biblioitemnumber was forgotten In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18265 --- Comment #13 from Olli-Antti Kivilahti --- (In reply to Marcel de Rooy from comment #10) > (In reply to Olli-Antti Kivilahti from comment #9) > > Do you mean that biblio- and biblioitems-tables should be merged? > > > > Then those need to be separated again when we are moving to FRBR. > > > > This is one fundamentally good architectural design decision in Koha. Don't > > break it. > > A design decision that has not been implemented, might not be a good one > after all.. The issues with (MA)chine (R)eadable (C)ard catalogues are aknowledged for decades. Probably even then when the format was being discussed. Now the official formats for implementing FRBR (RDA -> Bibframe) are at the door and we (Finland) are already migrating to RDA this year. Actually I think we officially did and new records are only available in RDA as we speak. Looking forward to Bibframe in the near future. Structuring the DB to model the separation of work from manifestation is fundamentally important to achieve moving Koha to the future. Removing this distinction will turn us back 30 years. I have already suffered from the awkwardness caused by this divide (biblio-biblioitems) for many years with Koha, but the problem is not with DB but the internal API. Better stick to it now, since it is the foothold for pushing us forward. Naturally the current implementation is not good enough, but it is better than nothing. Otherwise we need to reinvent this wheel. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Mar 16 12:37:38 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 16 Mar 2017 11:37:38 +0000 Subject: [Koha-bugs] [Bug 15140] Add MARC21 776 to OPAC and staff display In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15140 Marcel de Rooy changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|gmcharlt at gmail.com |m.de.rooy at rijksmuseum.nl CC| |m.de.rooy at rijksmuseum.nl Status|NEW |ASSIGNED -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Mar 16 12:43:27 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 16 Mar 2017 11:43:27 +0000 Subject: [Koha-bugs] [Bug 15140] Add MARC21 776 to OPAC and staff display In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15140 --- Comment #2 from Marcel de Rooy --- Created attachment 61161 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=61161&action=edit Bug 15140: [3.22] Add MARC21 776 to OPAC and staff display Adds code to opac and staff detail XSLT in order to show 776$t and a link based on 776$w (record control number). $w should be in the form: (MARCOrgCode)Record-number For instance: (NL-AmRIJ)12345 Note: You should have enabled default opac/intranet XSLT view. Test plan: [1] Add two 776s (one with $t and $w and one with $t only) [2] Verify that you see "Additional physical formats" on opac-detail. Does the link for $w work? [3] Check intranet detail too. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Mar 16 12:48:22 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 16 Mar 2017 11:48:22 +0000 Subject: [Koha-bugs] [Bug 15140] Add MARC21 776 to OPAC and staff display In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15140 Marcel de Rooy changed: What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Mar 16 12:48:25 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 16 Mar 2017 11:48:25 +0000 Subject: [Koha-bugs] [Bug 15140] Add MARC21 776 to OPAC and staff display In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15140 Marcel de Rooy changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #61161|0 |1 is obsolete| | --- Comment #3 from Marcel de Rooy --- Created attachment 61162 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=61162&action=edit Bug 15140: Add MARC21 776 to OPAC and staff display Adds code to opac and staff detail XSLT in order to show 776$t and a link based on 776$w (record control number). $w should be in the form: (MARCOrgCode)Record-number For instance: (NL-AmRIJ)12345 Note: You should have enabled default opac/intranet XSLT view. Test plan: [1] Add two 776s (one with $t and $w and one with $t only) [2] Verify that you see "Additional physical formats" on opac-detail. Does the link for $w work? [3] Check intranet detail too. Signed-off-by: Marcel de Rooy -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Mar 16 12:49:31 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 16 Mar 2017 11:49:31 +0000 Subject: [Koha-bugs] [Bug 15140] Add MARC21 776 to OPAC and staff display In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15140 Marcel de Rooy changed: What |Removed |Added ---------------------------------------------------------------------------- Patch complexity|--- |Small patch -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Mar 16 12:58:12 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 16 Mar 2017 11:58:12 +0000 Subject: [Koha-bugs] [Bug 18137] REST API: Migrate from Mojolicious::Plugin:: Swagger2 to Mojolicious::Plugin::OpenAPI In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18137 --- Comment #26 from Lari Taskula --- Created attachment 61163 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=61163&action=edit Bug 18137: (follow-up) operationId must be unique operationId has the following documentation: "Unique string used to identify the operation. The id MUST be unique among all operations described in the API." This patch modifies operationIds to be unique accross our API operations. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Mar 16 13:09:42 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 16 Mar 2017 12:09:42 +0000 Subject: [Koha-bugs] [Bug 18205] REST interface to Koha::Logger In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18205 Lari Taskula changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Mar 16 13:22:05 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 16 Mar 2017 12:22:05 +0000 Subject: [Koha-bugs] [Bug 18137] REST API: Migrate from Mojolicious::Plugin:: Swagger2 to Mojolicious::Plugin::OpenAPI In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18137 Lari Taskula changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |16497 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16497 [Bug 16497] REST API: add routes to list libraries -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Mar 16 13:22:10 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 16 Mar 2017 12:22:10 +0000 Subject: [Koha-bugs] [Bug 16497] REST API: add routes to list libraries In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16497 Lari Taskula changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #60801|0 |1 is obsolete| | --- Comment #15 from Lari Taskula --- Created attachment 61164 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=61164&action=edit Bug 16497: [REST] Add /api/v1/libraries CRUD for libraries via REST API. GET /api/v1/libraries - List all libraries GET /api/v1/libraries/{branchcode} - Get one Library POST /api/v1/libraries - Add new Library DELETE /api/v1/libraries/{branchcode} - Delete Library Test plan: - apply patch - run tests: t/db_dependent/api/v1/libraries.t - test API with some API tool or simple curl e.g.: curl http://host:port/api/v1/libraries curl http://host:port/api/v1/libraries/cpl -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Mar 16 13:22:05 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 16 Mar 2017 12:22:05 +0000 Subject: [Koha-bugs] [Bug 16497] REST API: add routes to list libraries In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16497 Lari Taskula changed: What |Removed |Added ---------------------------------------------------------------------------- Status|In Discussion |Needs Signoff Depends on| |18137 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18137 [Bug 18137] REST API: Migrate from Mojolicious::Plugin::Swagger2 to Mojolicious::Plugin::OpenAPI -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Mar 16 13:22:27 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 16 Mar 2017 12:22:27 +0000 Subject: [Koha-bugs] [Bug 16497] REST API: add routes to list libraries In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16497 Lari Taskula changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #60802|0 |1 is obsolete| | --- Comment #16 from Lari Taskula --- Created attachment 61165 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=61165&action=edit Bug 16497: Sort definitions.json Before this file grows, we should sort it alphabetically. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Thu Mar 16 13:25:58 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 16 Mar 2017 12:25:58 +0000 Subject: [Koha-bugs] [Bug 18137] REST API: Migrate from Mojolicious::Plugin:: Swagger2 to Mojolicious::Plugin::OpenAPI In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18137 --- Comment #27 from Lari Taskula --- Created attachment 61166 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=61166&action=edit Bug 18137: (follow-up) Sort definitions.json Before this file grows, we should sort it alphabetically. To test: 1. prove t/db_dependent/api/v1 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Mar 16 13:26:11 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 16 Mar 2017 12:26:11 +0000 Subject: [Koha-bugs] [Bug 16497] REST API: add routes to list libraries In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16497 Lari Taskula changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #61165|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Thu Mar 16 13:34:52 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 16 Mar 2017 12:34:52 +0000 Subject: [Koha-bugs] [Bug 18282] New: OpenAPI operationId must be unique Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18282 Bug ID: 18282 Summary: OpenAPI operationId must be unique Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Web services Assignee: koha-bugs at lists.koha-community.org Reporter: lari.taskula at jns.fi QA Contact: testopia at bugs.koha-community.org operationId has the following documentation: "Unique string used to identify the operation. The id MUST be unique among all operations described in the API." -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Mar 16 13:37:54 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 16 Mar 2017 12:37:54 +0000 Subject: [Koha-bugs] [Bug 18282] OpenAPI operationId must be unique In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18282 --- Comment #1 from Lari Taskula --- Created attachment 61169 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=61169&action=edit Bug 18282: operationId must be unique operationId has the following documentation: "Unique string used to identify the operation. The id MUST be unique among all operations described in the API." This patch modifies operationIds to be unique accross our API operations. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Thu Mar 16 13:37:51 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 16 Mar 2017 12:37:51 +0000 Subject: [Koha-bugs] [Bug 18282] OpenAPI operationId must be unique In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18282 Lari Taskula changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Thu Mar 16 13:42:12 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 16 Mar 2017 12:42:12 +0000 Subject: [Koha-bugs] [Bug 18282] OpenAPI operationId must be unique In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18282 Lari Taskula changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |tomascohen at gmail.com Depends on| |18137 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18137 [Bug 18137] REST API: Migrate from Mojolicious::Plugin::Swagger2 to Mojolicious::Plugin::OpenAPI -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Thu Mar 16 13:42:12 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 16 Mar 2017 12:42:12 +0000 Subject: [Koha-bugs] [Bug 18137] REST API: Migrate from Mojolicious::Plugin:: Swagger2 to Mojolicious::Plugin::OpenAPI In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18137 Lari Taskula changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |18282 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18282 [Bug 18282] OpenAPI operationId must be unique -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Mar 16 13:42:44 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 16 Mar 2017 12:42:44 +0000 Subject: [Koha-bugs] [Bug 18137] REST API: Migrate from Mojolicious::Plugin:: Swagger2 to Mojolicious::Plugin::OpenAPI In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18137 Lari Taskula changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #61163|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Mar 16 13:52:09 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 16 Mar 2017 12:52:09 +0000 Subject: [Koha-bugs] [Bug 18282] OpenAPI operationId must be unique In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18282 --- Comment #2 from Tom?s Cohen Arazi --- Lari, shouldn't this patch also change the controller class function names? - sub list { + sub list_cities { - sub add { + sub add_city { - sub update { + sub update_city { - sub delete { + sub delete_city { -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Mar 16 13:52:15 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 16 Mar 2017 12:52:15 +0000 Subject: [Koha-bugs] [Bug 18282] OpenAPI operationId must be unique In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18282 Tom?s Cohen Arazi changed: What |Removed |Added ---------------------------------------------------------------------------- QA Contact|testopia at bugs.koha-communit |tomascohen at gmail.com |y.org | -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Thu Mar 16 13:53:07 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 16 Mar 2017 12:53:07 +0000 Subject: [Koha-bugs] [Bug 18206] REST API: Default exception handling In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18206 Lari Taskula changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |tomascohen at gmail.com -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Mar 16 13:58:35 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 16 Mar 2017 12:58:35 +0000 Subject: [Koha-bugs] [Bug 18282] OpenAPI operationId must be unique In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18282 --- Comment #3 from Lari Taskula --- (In reply to Tom?s Cohen Arazi from comment #2) > Lari, shouldn't this patch also change the controller class function names? > > - sub list { > + sub list_cities { > - sub add { > + sub add_city { > - sub update { > + sub update_city { > - sub delete { > + sub delete_city { With Swagger2 plugin yes, but I set this as dependent on Mojolicious::Plugin::OpenAPI, which is using "x-mojo-to" for pointing to the controller class operation. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Thu Mar 16 14:02:01 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 16 Mar 2017 13:02:01 +0000 Subject: [Koha-bugs] [Bug 18282] OpenAPI operationId must be unique In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18282 --- Comment #4 from Lari Taskula --- (In reply to Lari Taskula from comment #3) > (In reply to Tom?s Cohen Arazi from comment #2) > > Lari, shouldn't this patch also change the controller class function names? > > > > - sub list { > > + sub list_cities { > > - sub add { > > + sub add_city { > > - sub update { > > + sub update_city { > > - sub delete { > > + sub delete_city { > > With Swagger2 plugin yes, but I set this as dependent on > Mojolicious::Plugin::OpenAPI, which is using "x-mojo-to" for pointing to the > controller class operation. In fact not either with Swagger2. As you can see from patrons controller. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Thu Mar 16 14:04:24 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 16 Mar 2017 13:04:24 +0000 Subject: [Koha-bugs] [Bug 18282] OpenAPI operationId must be unique In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18282 --- Comment #5 from Tom?s Cohen Arazi --- (In reply to Lari Taskula from comment #4) > (In reply to Lari Taskula from comment #3) > > (In reply to Tom?s Cohen Arazi from comment #2) > > > Lari, shouldn't this patch also change the controller class function names? > > > > > > - sub list { > > > + sub list_cities { > > > - sub add { > > > + sub add_city { > > > - sub update { > > > + sub update_city { > > > - sub delete { > > > + sub delete_city { > > > > With Swagger2 plugin yes, but I set this as dependent on > > Mojolicious::Plugin::OpenAPI, which is using "x-mojo-to" for pointing to the > > controller class operation. > > In fact not either with Swagger2. As you can see from patrons controller. I tend to prefer avoiding black magic as much as possible to avoid unexpected behaviours. That's why I prefer to explicitly put the most similar to the function name. But keep moving and see how bad/good it looks. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Mar 16 14:04:23 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 16 Mar 2017 13:04:23 +0000 Subject: [Koha-bugs] [Bug 18206] REST API: Default exception handling In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18206 Lari Taskula changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #61087|0 |1 is obsolete| | --- Comment #5 from Lari Taskula --- Created attachment 61170 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=61170&action=edit Bug 18206: Default exception handling for REST API Many of our operations in REST API controllers now use try-catch blocks to catch exceptions and handle them appropriately. This is great, but we should introduce a centralized way of handling default HTTP 500 errors. Currently they are checked over and over again in each operation. As an example this same lovely poem, in many cases, is currently replicated for each operation: sub list { ... try { blabla } catch { # This should stay here, custom error handling for this particular operation if ($_->isa('Koha::Exceptions::Patron::Something')) { return $c->render(status => 400, openapi => { error => $_->error }); } # But the checks below can be centralized! elsif ($_->isa('DBIx::Class::Exception')) { return $c->render(status => 500, openapi => { error => $_->{msg} }); } elsif ($_->isa('Koha::Exceptions::Exception')) { return $c->render(status => 500, openapi => { error => $_->error }); } else { return $c->render(status => 500, openapi => { error => "Something went wrong, check the logs." }); } }; } Instead, my proposal for a more centralized solution is to use a before_render hook to catch all of the default exceptions before rendering that are expected to return a 500, logging the error and displaying an appropriate error message in response body. After this patch, the above example would then look like this: sub list { ... try { blabla } catch { # This should stay here, custom error handling for this particular operation if ($_->isa('Koha::Exceptions::Patron::Something')) { return $c->render(status => 400, openapi => { error => $_->error }); } # Simply rethrow the exception with the help of below function - it will then # be handled in before_render hook Koha::Exceptions::rethrow_exception($_); }; } What does this patch actually do? After this patch, in case of an exception, we will normally visit the catch-block. If none of the specified Koha::Exceptions match the thrown $_, we will now rethrow the exception. This does not crash the whole app, but forwards the exception eventually into our before_render hook at Koha::REST::V1::handle_default_exceptions. There, we are able to customize our way of handling these exceptions. In this patch I have added an error logging there. We should also discuss whether we want to display a detailed error message, or simply "Something went wrong, check the logs." for all of the default exceptions. Perhaps this could be controlled by some sort of configuration for development/production (e.g. MOJO_MODE) ? To test: 1. prove t/db_dependent/api 2. prove t/Koha/Exceptions.t -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Mar 16 14:04:50 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 16 Mar 2017 13:04:50 +0000 Subject: [Koha-bugs] [Bug 18206] REST API: Default exception handling In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18206 Lari Taskula changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #61088|0 |1 is obsolete| | --- Comment #6 from Lari Taskula --- Created attachment 61171 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=61171&action=edit Bug 18206: Use this feature for cities To test: 1. prove t/db_dependent/api/v1/cities.t -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Mar 16 15:28:42 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 16 Mar 2017 14:28:42 +0000 Subject: [Koha-bugs] [Bug 18078] Updating buttons for z39.50 Authority search In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18078 Marc V?ron changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #60002|0 |1 is obsolete| | --- Comment #2 from Marc V?ron --- Created attachment 61172 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=61172&action=edit Bug 18078: Updating buttons for z39.50 Authority search 1) Go to Home > Authorities -> New from Z39.50 2) Notice how Search button is strangely off page (have to scroll down to see it) 3) Do a search, noticing the ugly buttons from Comment 1 4) Apply patch and go back to a new search 5) Do a search again, notice no longer need to scroll to get to Search button and new, nicer buttons 6) Confirm they still work as expected Sponsored-by: Catalyst IT Testplan changed to test with Authorities. Z39.50 search for authorities displays and Works as expected. Signed-off-by: Marc V?ron -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Mar 16 15:28:57 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 16 Mar 2017 14:28:57 +0000 Subject: [Koha-bugs] [Bug 18078] Updating buttons for z39.50 Authority search In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18078 Marc V?ron changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |veron at veron.ch Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Mar 16 15:31:18 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 16 Mar 2017 14:31:18 +0000 Subject: [Koha-bugs] [Bug 18008] Use templates for generating pagination in intranet In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18008 Marc V?ron changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |veron at veron.ch -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Mar 16 15:40:48 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 16 Mar 2017 14:40:48 +0000 Subject: [Koha-bugs] [Bug 16187] Add a script to cancel unfilled holds after a specified number of days In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16187 Nick Clemens changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |Signed Off -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Mar 16 15:40:52 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 16 Mar 2017 14:40:52 +0000 Subject: [Koha-bugs] [Bug 16187] Add a script to cancel unfilled holds after a specified number of days In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16187 --- Comment #8 from Nick Clemens --- Created attachment 61173 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=61173&action=edit Bug 16187 - (QA followup) Tidy, add confirm, minor changes -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Mar 16 15:44:29 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 16 Mar 2017 14:44:29 +0000 Subject: [Koha-bugs] [Bug 16187] Add a script to cancel unfilled holds after a specified number of days In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16187 --- Comment #9 from Nick Clemens --- (In reply to Liz Rea from comment #6) > I feel like this needs some safeguards. > > Cheers, > Liz I added a 'confirm' option so this can be run to see what would be deleted before going through with the deletion, is there another specific feedback you would like to see? -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Mar 16 15:45:12 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 16 Mar 2017 14:45:12 +0000 Subject: [Koha-bugs] [Bug 16187] Add a script to cancel unfilled holds after a specified number of days In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16187 --- Comment #10 from Nick Clemens --- (In reply to Jonathan Druart from comment #7) > Nick, do you have any good reasons to use DateTime instead of dt_from_string > to get today's date? Nope, was a copy paste job > Note that you could have use > Koha::Libraries->search->get_column('branchcode') to get an iterator on the > branchcodes. Advice taken > Please resubmit tidying the whole file. Done. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Mar 16 16:34:04 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 16 Mar 2017 15:34:04 +0000 Subject: [Koha-bugs] [Bug 18283] New: Display improvements on report results - hide code and change wording Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18283 Bug ID: 18283 Summary: Display improvements on report results - hide code and change wording Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Reports Assignee: gmcharlt at gmail.com Reporter: nick at bywatersolutions.com QA Contact: testopia at bugs.koha-community.org -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Mar 16 16:34:35 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 16 Mar 2017 15:34:35 +0000 Subject: [Koha-bugs] [Bug 18283] Display improvements on report results - hide code and change wording In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18283 Nick Clemens changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|gmcharlt at gmail.com |nick at bywatersolutions.com -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Mar 16 16:37:14 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 16 Mar 2017 15:37:14 +0000 Subject: [Koha-bugs] [Bug 17479] REST API: Save information on owner access In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17479 Lari Taskula changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #57286|0 |1 is obsolete| | --- Comment #8 from Lari Taskula --- Created attachment 61174 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=61174&action=edit Bug 17479: Store information on owner access into $c->stash There are two ways of accessing a resource via REST API; either: - you have the required permission - you do not have the permission but you are owner of the object, e.g. you want to GET your own patron information In many cases we want to perform additional operations if the user is accessing his own object. Usually this additional operation is checking a system preference. Example: Patron wants to update his own patron information via REST API. We have to check OPACPatronDetails system preference for this. If it is on, we should forward the changes for approval from a librarian. Currently, in controller, we can check this opac-like access by checking that the user does not have permissions and that the patron he is accessing is himself. This would require another haspermission() call. Instead, we could set a flag into $c->stash in Koha/REST/V1.pm in the case of ownership access. After this, in controller, we only need to check $c->stash for this flag. To test: 1. Apply patch 2. Run t/db_dependent/api/v1/ownerflag.t 3. Observe it pass -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Mar 16 16:37:10 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 16 Mar 2017 15:37:10 +0000 Subject: [Koha-bugs] [Bug 17479] REST API: Save information on owner access In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17479 Lari Taskula changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Mar 16 16:37:41 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 16 Mar 2017 15:37:41 +0000 Subject: [Koha-bugs] [Bug 17479] REST API: Save information on owner access In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17479 Lari Taskula changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on| |18137 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18137 [Bug 18137] REST API: Migrate from Mojolicious::Plugin::Swagger2 to Mojolicious::Plugin::OpenAPI -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Mar 16 16:37:41 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 16 Mar 2017 15:37:41 +0000 Subject: [Koha-bugs] [Bug 18137] REST API: Migrate from Mojolicious::Plugin:: Swagger2 to Mojolicious::Plugin::OpenAPI In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18137 Lari Taskula changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |17479 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17479 [Bug 17479] REST API: Save information on owner access -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Mar 16 16:39:10 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 16 Mar 2017 15:39:10 +0000 Subject: [Koha-bugs] [Bug 17479] REST API: Save information on owner access In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17479 --- Comment #9 from Lari Taskula --- Rebased on top of Bug 18137. To test, first apply Bug 18137, then this one, and run tests. Removed sign-offs as the test file was heavily rewritten. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Mar 16 16:39:13 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 16 Mar 2017 15:39:13 +0000 Subject: [Koha-bugs] [Bug 18283] Display improvements on report results - hide code and change wording In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18283 --- Comment #1 from Nick Clemens --- Created attachment 61175 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=61175&action=edit Bug 18283 - Display improvements on report results - hide code and change wording This patch makes small display improvements to the report results page. -Add toggle link for SQL code -Change results count wording -Add 'Notes:' label report notes To test: 1 - Apply patch 2 - Run some reports 3 - Check that results page makes sense 4 - Hide and display code and ensure toggle works -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Mar 16 17:32:37 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 16 Mar 2017 16:32:37 +0000 Subject: [Koha-bugs] [Bug 18279] C4::Items - Remove GetLostItems In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18279 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on| |18278 Status|Patch doesn't apply |Needs Signoff --- Comment #3 from Jonathan Druart --- Forgot to add the dependency, sorry. Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18278 [Bug 18278] C4::Items - Remove GetItemLocation -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Mar 16 17:32:37 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 16 Mar 2017 16:32:37 +0000 Subject: [Koha-bugs] [Bug 18278] C4::Items - Remove GetItemLocation In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18278 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |18279 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18279 [Bug 18279] C4::Items - Remove GetLostItems -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Mar 16 17:38:48 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 16 Mar 2017 16:38:48 +0000 Subject: [Koha-bugs] [Bug 18137] REST API: Migrate from Mojolicious::Plugin:: Swagger2 to Mojolicious::Plugin::OpenAPI In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18137 Lari Taskula changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |16825 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16825 [Bug 16825] REST API: Add API route for getting an item -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Mar 16 17:38:48 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 16 Mar 2017 16:38:48 +0000 Subject: [Koha-bugs] [Bug 16825] REST API: Add API route for getting an item In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16825 Lari Taskula changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Needs Signoff Depends on|15126 |18137 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15126 [Bug 15126] REST?API: Use newer version of Swagger2 https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18137 [Bug 18137] REST API: Migrate from Mojolicious::Plugin::Swagger2 to Mojolicious::Plugin::OpenAPI -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Mar 16 17:38:48 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 16 Mar 2017 16:38:48 +0000 Subject: [Koha-bugs] [Bug 15126]=?UTF-8?Q?=20REST=C2=A0API?=: Use newer version of Swagger2 In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15126 Lari Taskula changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks|16825 | Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16825 [Bug 16825] REST API: Add API route for getting an item -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Mar 16 17:38:52 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 16 Mar 2017 16:38:52 +0000 Subject: [Koha-bugs] [Bug 16825] REST API: Add API route for getting an item In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16825 Lari Taskula changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #56290|0 |1 is obsolete| | --- Comment #28 from Lari Taskula --- Created attachment 61176 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=61176&action=edit Bug 16825: Add API route for getting an item GET /api/v1/items/{itemnumber} Gets one Item This patch adds route to get one item from koha.items table. This table has a column "itemnotes_nonpublic", which should not be returned if the user has no catalogue permission. The OpacHiddenItems syspref restriction is considered for users who are not staff. They see "Item Not Found" when trying to view item hidden from OPAC. Only staff can see those items. To test: 1. Apply patch 2. Open a browser tab on Koha staff and log in (to create CGISESSID cookie). 3. Send GET request to http://yourlibrary/api/v1/items/YYY where YYY is an existing itemnumber. 4. Make sure the returned data is correct. 5. Run unit tests in t/db_dependent/api/v1/items.t -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Mar 16 17:40:16 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 16 Mar 2017 16:40:16 +0000 Subject: [Koha-bugs] [Bug 16825] REST API: Add API route for getting an item In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16825 Lari Taskula changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #56292|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Mar 16 17:40:31 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 16 Mar 2017 16:40:31 +0000 Subject: [Koha-bugs] [Bug 16825] REST API: Add API route for getting an item In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16825 Lari Taskula changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #56293|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Mar 16 17:41:12 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 16 Mar 2017 16:41:12 +0000 Subject: [Koha-bugs] [Bug 16825] REST API: Add API route for getting an item In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16825 --- Comment #29 from Lari Taskula --- Rewritten, now Mojolicious::Plugin::OpenAPI compatible. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Mar 16 17:49:06 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 16 Mar 2017 16:49:06 +0000 Subject: [Koha-bugs] [Bug 18276] Koha::Biblio - Remove GetBiblioFromItemNumber In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18276 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #61122|0 |1 is obsolete| | Attachment #61123|0 |1 is obsolete| | Attachment #61124|0 |1 is obsolete| | Attachment #61125|0 |1 is obsolete| | Attachment #61126|0 |1 is obsolete| | --- Comment #7 from Jonathan Druart --- Created attachment 61177 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=61177&action=edit Bug 18276: Remove GetBiblioFromItemNumber - Course reserves Values from the items, biblio and biblioitems tables are used in the template, so we need to pass all of them to the template, but separately. That way we easily see which field from which table we are displaying. Test plan: Create a course reserve and add items. Correct information must be displayed on the detail page of the course reserve, on staff and OPAC interface. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Mar 16 17:49:20 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 16 Mar 2017 16:49:20 +0000 Subject: [Koha-bugs] [Bug 18276] Koha::Biblio - Remove GetBiblioFromItemNumber In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18276 --- Comment #8 from Jonathan Druart --- Created attachment 61178 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=61178&action=edit Bug 18276: Remove GetBiblioFromItemNumber - ILSDI Test plan: Hit /cgi-bin/koha/ilsdi.pl?service=GetPatronInfo&patron_id=51&show_holds=1 The results should be the same before and after this patch -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Mar 16 17:49:39 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 16 Mar 2017 16:49:39 +0000 Subject: [Koha-bugs] [Bug 18276] Koha::Biblio - Remove GetBiblioFromItemNumber In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18276 --- Comment #9 from Jonathan Druart --- Created attachment 61179 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=61179&action=edit Bug 18276: Remove GetBiblioFromItemNumber - circulation pages Test plan: 1. Checkout items in a batch The information displayed should be ok (title, subtitles, author, itemnotes, barcode) 2. Checkout an item using the standard checkout page You should correctly see the information of the item that has been checked out (title and author) -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Mar 16 17:49:56 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 16 Mar 2017 16:49:56 +0000 Subject: [Koha-bugs] [Bug 18276] Koha::Biblio - Remove GetBiblioFromItemNumber In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18276 --- Comment #10 from Jonathan Druart --- Created attachment 61180 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=61180&action=edit Bug 18276: Remove GetBiblioFromItemNumber - Easy ones The subroutine C4::Biblio::GetBiblioFromItemNumber was wrong for several reasons: - badly named, we can get biblio info from a barcode - SELECT * from items, biblio and biblioitems makes things hard to follow and debug, we never know where do come from the value we display - sometimes called only for trivial information such as biblionumber, author or title This patchset suggests to replace it with calls to: - Koha::Items->find for item's info - $item->biblio for biblio's info - $item->biblio->biblioitem for biblioitem's info Test plan: Item's info should correctly be displayed on the following pages: - circulation history - transfer book - checkin - waiting holds QA will check the other changes reading the code, it's trivial -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Mar 16 17:50:17 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 16 Mar 2017 16:50:17 +0000 Subject: [Koha-bugs] [Bug 18276] Koha::Biblio - Remove GetBiblioFromItemNumber In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18276 --- Comment #11 from Jonathan Druart --- Created attachment 61181 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=61181&action=edit Bug 18276: Remove the C4::Biblio::GetBiblioFromItemNumber subroutine -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Mar 16 17:55:08 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 16 Mar 2017 16:55:08 +0000 Subject: [Koha-bugs] [Bug 15707] Add ability to define hierarchical groups of libraries In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15707 --- Comment #169 from Jonathan Druart --- (In reply to Kyle M Hall from comment #168) > For efficiency. If you think it makes more sense to have all libraries in > all subgroups selected as well I'd be happy to change it. To me it does not make sense not to go all over the whole tree, I think it would be good to get other opinions. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Mar 16 18:03:22 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 16 Mar 2017 17:03:22 +0000 Subject: [Koha-bugs] [Bug 16825] REST API: Add API route for getting an item In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16825 --- Comment #30 from Lari Taskula --- (In reply to Lari Taskula from comment #29) > Rewritten, now Mojolicious::Plugin::OpenAPI compatible. Forgot to include this in the previous comment - Additional note for testers: requires JSON::Validator version 0.96, otherwise tests fail for the following reason: GET /api/v1/items/340856 [{"message":"Does not match date-time format.","path":"\/timestamp"},{"message":"anyOf failed: Does not match date-time format.","path":"\/itemlost_on"},{"message":"anyOf failed: Does not match date-time format.","path":"\/withdrawn_on"}]. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Mar 16 18:06:22 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 16 Mar 2017 17:06:22 +0000 Subject: [Koha-bugs] [Bug 18265] Followup to Bug 17196. deletedbiblio_metadata is not used. biblioitemnumber was forgotten In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18265 --- Comment #14 from Jonathan Druart --- (In reply to Olli-Antti Kivilahti from comment #12) > (In reply to Jonathan Druart from comment #11) > > (In reply to Jonathan Druart from comment #7) > > > You are going too far with this patch, we need a quick patch to fix the data > > > lost when deleting a bibliographic record, > > I have to disagree. You need properly implemented features, not small steps > and quick fixes. Yes and that is something you did not understand yet, but I am sure you will at some point. That is exactly why you do not manage to get your patches pushed. Small steps are the way to go if you want your changes to be integrated. On this bug report you are addressing to many different points, you are just slowing down its move. I will take care of the moveto deletedbiblio_metadata. Thanks for the try! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Mar 16 18:29:32 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 16 Mar 2017 17:29:32 +0000 Subject: [Koha-bugs] [Bug 18120] REST API: CRUD endpoint for vendors In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18120 Tom?s Cohen Arazi changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #60851|0 |1 is obsolete| | --- Comment #3 from Tom?s Cohen Arazi --- Created attachment 61182 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=61182&action=edit Bug 18120: REST api | /acquisitions/vendors unit tests This patch introduces unit tests that need to be passed by an /acquisitions/vendors/ REST endpoint. To test: - Apply the patch - Run: $ sudo koha-shell kohadev k$ prove t/db_dependent/api/v1/acquisitions_vendors.t => FAIL: The endpoint is not present, should fail. Sponsored-by: ByWater Solutions -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Mar 16 18:29:38 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 16 Mar 2017 17:29:38 +0000 Subject: [Koha-bugs] [Bug 18120] REST API: CRUD endpoint for vendors In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18120 Tom?s Cohen Arazi changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #60852|0 |1 is obsolete| | --- Comment #4 from Tom?s Cohen Arazi --- Created attachment 61183 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=61183&action=edit Bug 18120: REST api | Add a 'vendors' endpoint This patch introduces an /acquisitions/vendors endpoint. To test: - Apply the patch - Run: $ sudo koha-shell kohadev k$ prove t/db_dependent/api/v1/acquisitions_vendors.t => SUCCESS: Tests pass - Sign off :-D Sponsored-by: ByWater Solutions -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Mar 16 19:22:38 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 16 Mar 2017 18:22:38 +0000 Subject: [Koha-bugs] [Bug 18284] New: Biblio metadata are not moved to the deleted table when a biblio is deleted Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18284 Bug ID: 18284 Summary: Biblio metadata are not moved to the deleted table when a biblio is deleted Change sponsored?: --- Product: Koha Version: unspecified Hardware: All OS: All Status: ASSIGNED Severity: blocker Priority: P5 - low Component: Architecture, internals, and plumbing Assignee: jonathan.druart at bugs.koha-community.org Reporter: jonathan.druart at bugs.koha-community.org QA Contact: testopia at bugs.koha-community.org There is a deletedbiblio_metadata table but it is not populated when a biblio is deleted. Since we have a ON DELETE constraint on biblio_metadata.biblionumber, the row is deleted when the biblio entry is deleted => data lost! We absolutely need this one before the next release. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Mar 16 19:24:21 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 16 Mar 2017 18:24:21 +0000 Subject: [Koha-bugs] [Bug 17196] Move marcxml out of the biblioitems table In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17196 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |18284 --- Comment #138 from Jonathan Druart --- (In reply to Olli-Antti Kivilahti from comment #137) > Followup Bug 18265 is ready to be SO'd. I have opened and submitted a patch on bug 18284 to deal with the move of the biblio metadata and the data lost. Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18284 [Bug 18284] Biblio metadata are not moved to the deleted table when a biblio is deleted -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Mar 16 19:24:21 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 16 Mar 2017 18:24:21 +0000 Subject: [Koha-bugs] [Bug 18284] Biblio metadata are not moved to the deleted table when a biblio is deleted In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18284 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on| |17196 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17196 [Bug 17196] Move marcxml out of the biblioitems table -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Mar 16 19:27:08 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 16 Mar 2017 18:27:08 +0000 Subject: [Koha-bugs] [Bug 18284] Biblio metadata are not moved to the deleted table when a biblio is deleted In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18284 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Mar 16 19:27:12 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 16 Mar 2017 18:27:12 +0000 Subject: [Koha-bugs] [Bug 18284] Biblio metadata are not moved to the deleted table when a biblio is deleted In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18284 --- Comment #1 from Jonathan Druart --- Created attachment 61184 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=61184&action=edit Bug 18284: (bug 17196 follow-up) Move biblio metadata when a biblio is deleted There is a deletedbiblio_metadata table but it is not populated when a biblio is deleted. Since we have a ON DELETE constraint on biblio_metadata.biblionumber, the row is deleted when the biblio entry is deleted => data lost! Test plan: - Create a biblio - Delete it => Without this patch the deletedbiblio_metadata table is not populated with the biblio_metadata row related to the biblio => With this patch applied you should see that the row has been moved. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Mar 16 20:01:37 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 16 Mar 2017 19:01:37 +0000 Subject: [Koha-bugs] [Bug 18285] New: Koha::Database schema cache accessors Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18285 Bug ID: 18285 Summary: Koha::Database schema cache accessors Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Architecture, internals, and plumbing Assignee: gmcharlt at gmail.com Reporter: olli-antti.kivilahti at jns.fi QA Contact: testopia at bugs.koha-community.org Safe way of getting and flushing the $database->{schema} -cache. This is needed by Test::DBIx::Class to overcome pre-initialization connection caching from C4::Context and others. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Mar 16 20:01:35 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 16 Mar 2017 19:01:35 +0000 Subject: [Koha-bugs] [Bug 18283] Display improvements on report results - hide code and change wording In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18283 Christopher Brannon changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |cbrannon at cdalibrary.org --- Comment #2 from Christopher Brannon --- Works great. I would change it to a button and put it with the rest of the buttons at the top of the report. My 2 cents. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Mar 16 20:07:07 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 16 Mar 2017 19:07:07 +0000 Subject: [Koha-bugs] [Bug 18286] New: Test::DBIx::Class connection/ schema is shadowed by a cached connection/schema Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18286 Bug ID: 18286 Summary: Test::DBIx::Class connection/schema is shadowed by a cached connection/schema Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Test Suite Assignee: chris at bigballofwax.co.nz Reporter: olli-antti.kivilahti at jns.fi QA Contact: gmcharlt at gmail.com If Koha::Database->schema gets called before use Test::DBIx::Class The DB connection from $KOHA_CONF is cached. This happens most of the time because when C4::Context and friends are loaded (in compile-time?), they already access the DB. After Test::DBIx::Class is instantiated and hooks put in place to overload Koha::Schema connection, those hooks are never called due to getting the old connection from cache. This feature introduces a test case to replicate the behaviour and shows how flushing the connection cache solves the problem. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Mar 16 20:07:32 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 16 Mar 2017 19:07:32 +0000 Subject: [Koha-bugs] [Bug 18285] Koha::Database schema cache accessors In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18285 --- Comment #1 from Olli-Antti Kivilahti --- Created attachment 61185 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=61185&action=edit Bug 18285 - Koha::Database schema cache accessors Safe way of getting and flushing the $database->{schema} -cache. This is needed by Test::DBIx::Class to overcome pre-initialization connection caching from C4::Context and others. See Buug 18286 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Mar 16 20:09:16 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 16 Mar 2017 19:09:16 +0000 Subject: [Koha-bugs] [Bug 18286] Test::DBIx::Class connection/ schema is shadowed by a cached connection/schema In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18286 --- Comment #1 from Olli-Antti Kivilahti --- Created attachment 61186 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=61186&action=edit Bug 18286 - Test::DBIx::Class connection/schema is shadowed by a cached connection/schema If Koha::Database->schema gets called before use Test::DBIx::Class The DB connection from $KOHA_CONF is cached. This happens most of the time because when C4::Context and friends are loaded (in compile-time?), they already access the DB. After Test::DBIx::Class is instantiated and hooks put in place to overload Koha::Schema connection, those hooks are never called due to getting the old connection from cache. This feature introduces a test case to replicate the behaviour and shows how flushing the connection cache solves the problem. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Mar 16 20:09:45 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 16 Mar 2017 19:09:45 +0000 Subject: [Koha-bugs] [Bug 18286] Test::DBIx::Class connection/ schema is shadowed by a cached connection/schema In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18286 Olli-Antti Kivilahti changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on| |18285 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18285 [Bug 18285] Koha::Database schema cache accessors -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Mar 16 20:09:45 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 16 Mar 2017 19:09:45 +0000 Subject: [Koha-bugs] [Bug 18285] Koha::Database schema cache accessors In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18285 Olli-Antti Kivilahti changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |18286 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18286 [Bug 18286] Test::DBIx::Class connection/schema is shadowed by a cached connection/schema -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Mar 16 20:09:59 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 16 Mar 2017 19:09:59 +0000 Subject: [Koha-bugs] [Bug 18285] Koha::Database schema cache accessors In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18285 Olli-Antti Kivilahti changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Mar 16 20:10:04 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 16 Mar 2017 19:10:04 +0000 Subject: [Koha-bugs] [Bug 18286] Test::DBIx::Class connection/ schema is shadowed by a cached connection/schema In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18286 Olli-Antti Kivilahti changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Mar 16 20:10:22 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 16 Mar 2017 19:10:22 +0000 Subject: [Koha-bugs] [Bug 18286] Test::DBIx::Class connection/ schema is shadowed by a cached connection/schema In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18286 Olli-Antti Kivilahti changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|chris at bigballofwax.co.nz |olli-antti.kivilahti at jns.fi -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Mar 16 20:10:29 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 16 Mar 2017 19:10:29 +0000 Subject: [Koha-bugs] [Bug 18285] Koha::Database schema cache accessors In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18285 Olli-Antti Kivilahti changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|gmcharlt at gmail.com |olli-antti.kivilahti at jns.fi -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Mar 16 20:11:03 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 16 Mar 2017 19:11:03 +0000 Subject: [Koha-bugs] [Bug 18286] Test::DBIx::Class connection/ schema is shadowed by a cached connection/schema In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18286 --- Comment #2 from Olli-Antti Kivilahti --- Prior to this patch, for example t/Koha.t fails due to this caching issue. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Mar 16 20:15:39 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 16 Mar 2017 19:15:39 +0000 Subject: [Koha-bugs] [Bug 18226] Remove "use Test::DBIx::Class" instantiations' dangerous code duplication In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18226 Olli-Antti Kivilahti changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on| |18285, 18286 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18285 [Bug 18285] Koha::Database schema cache accessors https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18286 [Bug 18286] Test::DBIx::Class connection/schema is shadowed by a cached connection/schema -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Mar 16 20:15:39 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 16 Mar 2017 19:15:39 +0000 Subject: [Koha-bugs] [Bug 18285] Koha::Database schema cache accessors In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18285 Olli-Antti Kivilahti changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |18226 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18226 [Bug 18226] Remove "use Test::DBIx::Class" instantiations' dangerous code duplication -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Mar 16 20:15:39 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 16 Mar 2017 19:15:39 +0000 Subject: [Koha-bugs] [Bug 18286] Test::DBIx::Class connection/ schema is shadowed by a cached connection/schema In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18286 Olli-Antti Kivilahti changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |18226 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18226 [Bug 18226] Remove "use Test::DBIx::Class" instantiations' dangerous code duplication -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Mar 16 20:19:25 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 16 Mar 2017 19:19:25 +0000 Subject: [Koha-bugs] [Bug 18287] New: Fix t/Koha.t having a Test::DBIx::Class cache issue Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18287 Bug ID: 18287 Summary: Fix t/Koha.t having a Test::DBIx::Class cache issue Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Test Suite Assignee: chris at bigballofwax.co.nz Reporter: olli-antti.kivilahti at jns.fi QA Contact: gmcharlt at gmail.com REPLICATE ISSUE: perl t/Koha.t -> fails AFTER THIS PATCH AND DEPENDENCIES: perl t/Koha.t -> OK -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Mar 16 20:19:47 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 16 Mar 2017 19:19:47 +0000 Subject: [Koha-bugs] [Bug 18287] Fix t/Koha.t having a Test::DBIx::Class cache issue In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18287 Olli-Antti Kivilahti changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on| |18226 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18226 [Bug 18226] Remove "use Test::DBIx::Class" instantiations' dangerous code duplication -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Mar 16 20:19:47 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 16 Mar 2017 19:19:47 +0000 Subject: [Koha-bugs] [Bug 18226] Remove "use Test::DBIx::Class" instantiations' dangerous code duplication In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18226 Olli-Antti Kivilahti changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |18287 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18287 [Bug 18287] Fix t/Koha.t having a Test::DBIx::Class cache issue -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Mar 16 20:20:00 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 16 Mar 2017 19:20:00 +0000 Subject: [Koha-bugs] [Bug 18287] Fix t/Koha.t having a Test::DBIx::Class cache issue In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18287 Olli-Antti Kivilahti changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|chris at bigballofwax.co.nz |olli-antti.kivilahti at jns.fi -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Mar 16 20:20:19 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 16 Mar 2017 19:20:19 +0000 Subject: [Koha-bugs] [Bug 18287] Fix t/Koha.t having a Test::DBIx::Class cache issue In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18287 --- Comment #1 from Olli-Antti Kivilahti --- Created attachment 61187 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=61187&action=edit Bug 18287 - Fix t/Koha.t having a Test::DBIx::Class cache issue REPLICATE ISSUE: perl t/Koha.t -> fails AFTER THIS PATCH AND DEPENDENCIES: perl t/Koha.t -> OK -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Mar 16 20:20:36 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 16 Mar 2017 19:20:36 +0000 Subject: [Koha-bugs] [Bug 18287] Fix t/Koha.t having a Test::DBIx::Class cache issue In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18287 Olli-Antti Kivilahti changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Mar 16 20:25:39 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 16 Mar 2017 19:25:39 +0000 Subject: [Koha-bugs] [Bug 18288] New: Fix t/SocialData.t having a Test::DBIx::Class cache issue Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18288 Bug ID: 18288 Summary: Fix t/SocialData.t having a Test::DBIx::Class cache issue Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Test Suite Assignee: chris at bigballofwax.co.nz Reporter: olli-antti.kivilahti at jns.fi QA Contact: gmcharlt at gmail.com REPLICATE ISSUE: perl t/SocialData.t -> fails AFTER THIS PATCH AND DEPENDENCIES: perl t/SocialData.t -> OK -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Mar 16 20:26:03 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 16 Mar 2017 19:26:03 +0000 Subject: [Koha-bugs] [Bug 18288] Fix t/SocialData.t having a Test::DBIx::Class cache issue In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18288 Olli-Antti Kivilahti changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |https://bugs.koha-community | |.org/bugzilla3/show_bug.cgi | |?id=18287 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Mar 16 20:26:03 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 16 Mar 2017 19:26:03 +0000 Subject: [Koha-bugs] [Bug 18287] Fix t/Koha.t having a Test::DBIx::Class cache issue In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18287 Olli-Antti Kivilahti changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |https://bugs.koha-community | |.org/bugzilla3/show_bug.cgi | |?id=18288 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Mar 16 20:26:22 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 16 Mar 2017 19:26:22 +0000 Subject: [Koha-bugs] [Bug 18288] Fix t/SocialData.t having a Test::DBIx::Class cache issue In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18288 Olli-Antti Kivilahti changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on| |18226 Assignee|chris at bigballofwax.co.nz |olli-antti.kivilahti at jns.fi Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18226 [Bug 18226] Remove "use Test::DBIx::Class" instantiations' dangerous code duplication -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Mar 16 20:26:22 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 16 Mar 2017 19:26:22 +0000 Subject: [Koha-bugs] [Bug 18226] Remove "use Test::DBIx::Class" instantiations' dangerous code duplication In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18226 Olli-Antti Kivilahti changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |18288 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18288 [Bug 18288] Fix t/SocialData.t having a Test::DBIx::Class cache issue -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Mar 16 20:27:03 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 16 Mar 2017 19:27:03 +0000 Subject: [Koha-bugs] [Bug 18288] Fix t/SocialData.t having a Test::DBIx::Class cache issue In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18288 --- Comment #1 from Olli-Antti Kivilahti --- Created attachment 61188 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=61188&action=edit Bug 18288 - Fix t/SocialData.t having a Test::DBIx::Class cache issue REPLICATE ISSUE: perl t/SocialData.t -> fails AFTER THIS PATCH AND DEPENDENCIES: perl t/SocialData.t -> OK -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Mar 16 20:27:13 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 16 Mar 2017 19:27:13 +0000 Subject: [Koha-bugs] [Bug 18288] Fix t/SocialData.t having a Test::DBIx::Class cache issue In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18288 Olli-Antti Kivilahti changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Mar 16 20:27:42 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 16 Mar 2017 19:27:42 +0000 Subject: [Koha-bugs] [Bug 18079] Cleanup of holds to pull page In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18079 --- Comment #11 from Marc V?ron --- Created attachment 61189 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=61189&action=edit Bug 18279: Remove C4::Items::GetLostItems The JOIN done by this subroutine are not always useful (depending on item-level_itypes). They also search with LIKE when it is not needed. Since we have now Koha::Items, we can replace this subroutine with a call to Koha::Items->search with the correct parameters. A change in previous behaviours can happen: If a items.itemlost contains a value that is not defined as a LOST authorised value, the item will not be displayed. I think it's the expected behaviour, even if it should not happen in correctly configured installations. Test plan: To test with item-level_itypes set to item and biblio: List the lost items you have on your system, using the different filters available. The result table should contain the correct item's info. Followed test plan, works as expected. Signed-off-by: Marc V?ron -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Mar 16 20:28:55 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 16 Mar 2017 19:28:55 +0000 Subject: [Koha-bugs] [Bug 18289] New: Fix t/Prices.t having a Test::DBIx::Class cache issue Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18289 Bug ID: 18289 Summary: Fix t/Prices.t having a Test::DBIx::Class cache issue Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Test Suite Assignee: chris at bigballofwax.co.nz Reporter: olli-antti.kivilahti at jns.fi QA Contact: gmcharlt at gmail.com REPLICATE ISSUE: perl t/Prices.t -> fails AFTER THIS PATCH AND DEPENDENCIES: perl t/Prices.t -> OK -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Mar 16 20:29:17 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 16 Mar 2017 19:29:17 +0000 Subject: [Koha-bugs] [Bug 18289] Fix t/Prices.t having a Test::DBIx::Class cache issue In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18289 Olli-Antti Kivilahti changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |https://bugs.koha-community | |.org/bugzilla3/show_bug.cgi | |?id=18288, | |https://bugs.koha-community | |.org/bugzilla3/show_bug.cgi | |?id=18287 Status|NEW |Needs Signoff Depends on| |18266 Assignee|chris at bigballofwax.co.nz |olli-antti.kivilahti at jns.fi Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18266 [Bug 18266] Internal Server Error when paying fine for lost item -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Mar 16 20:29:17 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 16 Mar 2017 19:29:17 +0000 Subject: [Koha-bugs] [Bug 18288] Fix t/SocialData.t having a Test::DBIx::Class cache issue In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18288 Olli-Antti Kivilahti changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |https://bugs.koha-community | |.org/bugzilla3/show_bug.cgi | |?id=18289 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Mar 16 20:29:17 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 16 Mar 2017 19:29:17 +0000 Subject: [Koha-bugs] [Bug 18287] Fix t/Koha.t having a Test::DBIx::Class cache issue In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18287 Olli-Antti Kivilahti changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |https://bugs.koha-community | |.org/bugzilla3/show_bug.cgi | |?id=18289 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Mar 16 20:29:25 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 16 Mar 2017 19:29:25 +0000 Subject: [Koha-bugs] [Bug 18079] Cleanup of holds to pull page In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18079 Marc V?ron changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |veron at veron.ch Attachment #61189|0 |1 is obsolete| | --- Comment #12 from Marc V?ron --- Comment on attachment 61189 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=61189 Bug 18279: Remove C4::Items::GetLostItems Mistaked with Bug number, sorry for the noise. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Mar 16 20:29:17 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 16 Mar 2017 19:29:17 +0000 Subject: [Koha-bugs] [Bug 18266] Internal Server Error when paying fine for lost item In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18266 Olli-Antti Kivilahti changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |18289 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18289 [Bug 18289] Fix t/Prices.t having a Test::DBIx::Class cache issue -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Thu Mar 16 20:29:53 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 16 Mar 2017 19:29:53 +0000 Subject: [Koha-bugs] [Bug 18289] Fix t/Prices.t having a Test::DBIx::Class cache issue In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18289 --- Comment #1 from Olli-Antti Kivilahti --- Created attachment 61190 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=61190&action=edit Bug 18289 - Fix t/Prices.t having a Test::DBIx::Class cache issue REPLICATE ISSUE: perl t/Prices.t -> fails AFTER THIS PATCH AND DEPENDENCIES: perl t/Prices.t -> OK -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Mar 16 20:30:08 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 16 Mar 2017 19:30:08 +0000 Subject: [Koha-bugs] [Bug 18279] C4::Items - Remove GetLostItems In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18279 Marc V?ron changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #61152|0 |1 is obsolete| | --- Comment #4 from Marc V?ron --- Created attachment 61191 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=61191&action=edit Bug 18279: Remove C4::Items::GetLostItems The JOIN done by this subroutine are not always useful (depending on item-level_itypes). They also search with LIKE when it is not needed. Since we have now Koha::Items, we can replace this subroutine with a call to Koha::Items->search with the correct parameters. A change in previous behaviours can happen: If a items.itemlost contains a value that is not defined as a LOST authorised value, the item will not be displayed. I think it's the expected behaviour, even if it should not happen in correctly configured installations. Test plan: To test with item-level_itypes set to item and biblio: List the lost items you have on your system, using the different filters available. The result table should contain the correct item's info. Followed test plan, works as expected. Signed-off-by: Marc V?ron https://bugs.koha-community.org/show_bug.cgi?id=18079 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Mar 16 20:30:28 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 16 Mar 2017 19:30:28 +0000 Subject: [Koha-bugs] [Bug 18279] C4::Items - Remove GetLostItems In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18279 Marc V?ron changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Mar 16 20:30:55 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 16 Mar 2017 19:30:55 +0000 Subject: [Koha-bugs] [Bug 18226] Remove "use Test::DBIx::Class" instantiations' dangerous code duplication In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18226 --- Comment #6 from Olli-Antti Kivilahti --- See the blocked list of Bugs for more individual test fixes. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Mar 16 20:31:27 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 16 Mar 2017 19:31:27 +0000 Subject: [Koha-bugs] [Bug 13757] Make patron attributes editable in the opac if set to ' editable in OPAC' In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13757 --- Comment #103 from Jonathan Druart --- Just small things: 1. I think we should not display the attributes at the opac if they are empty and not editable (it's especially weird for self registration) 2. [% IF !pm.extended_attributes and pm.size > 3 or pm.extended_attributes and pm.size > 4 %] I am sure you can make it more readable :D 3. Typo 'FilterUnchagedAttributes' Please fix ASAP and I PQA it! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Mar 16 20:59:25 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 16 Mar 2017 19:59:25 +0000 Subject: [Koha-bugs] [Bug 18226] Remove "use Test::DBIx::Class" instantiations' dangerous code duplication In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18226 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |jonathan.druart at bugs.koha-c | |ommunity.org --- Comment #7 from Jonathan Druart --- % git log --oneline 619aa5f Bug 18226 - Remove "use Test::DBIx::Class" instantiations' dangerous code duplication. Replace mock_dbh 2 5fb9461 Bug 18226 - Remove "use Test::DBIx::Class" instantiations' dangerous code duplication. Replace mock_dbh 1 5875738 Bug 18286 - Test::DBIx::Class connection/schema is shadowed by a cached connection/schema 8814c10 Bug 18285 - Koha::Database schema cache accessors Last patch from this bug does not apply: t/Members/cardnumber.t .. # Can't initialize a schema with the given configuration # Returned Error: `' is not a module name # configuration: { # 'fixture_sets' => {} # } % pmvers Test::DBIx::Class 0.52 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Mar 16 21:00:13 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 16 Mar 2017 20:00:13 +0000 Subject: [Koha-bugs] [Bug 18226] Remove "use Test::DBIx::Class" instantiations' dangerous code duplication In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18226 --- Comment #8 from Jonathan Druart --- % git log --oneline 619aa5f Bug 18226 - Remove "use Test::DBIx::Class" instantiations' dangerous code duplication. Replace mock_dbh 2 5fb9461 Bug 18226 - Remove "use Test::DBIx::Class" instantiations' dangerous code duplication. Replace mock_dbh 1 5875738 Bug 18286 - Test::DBIx::Class connection/schema is shadowed by a cached connection/schema 8814c10 Bug 18285 - Koha::Database schema cache accessors Last patch from this bug does not apply! % prove t/Members/cardnumber. t/Members/cardnumber.t .. # Can't initialize a schema with the given configuration # Returned Error: `' is not a module name # configuration: { # 'fixture_sets' => {} # } ... % pmvers Test::DBIx::Class 0.52 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Mar 16 21:33:57 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 16 Mar 2017 20:33:57 +0000 Subject: [Koha-bugs] [Bug 18283] Display improvements on report results - hide code and change wording In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18283 Nick Clemens changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #61175|0 |1 is obsolete| | --- Comment #3 from Nick Clemens --- Created attachment 61192 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=61192&action=edit Bug 18283 - Display improvements on report results - hide code and change wording This patch makes small display improvements to the report results page. -Add toggle link for SQL code -Change results count wording -Add 'Notes:' label report notes To test: 1 - Apply patch 2 - Run some reports 3 - Check that results page makes sense 4 - Hide and display code and ensure toggle works -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Mar 16 21:33:55 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 16 Mar 2017 20:33:55 +0000 Subject: [Koha-bugs] [Bug 18283] Display improvements on report results - hide code and change wording In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18283 Nick Clemens changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Mar 16 21:54:53 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 16 Mar 2017 20:54:53 +0000 Subject: [Koha-bugs] [Bug 18284] Biblio metadata are not moved to the deleted table when a biblio is deleted In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18284 Marc V?ron changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #61184|0 |1 is obsolete| | --- Comment #2 from Marc V?ron --- Created attachment 61193 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=61193&action=edit Bug 18284: (bug 17196 follow-up) Move biblio metadata when a biblio is deleted There is a deletedbiblio_metadata table but it is not populated when a biblio is deleted. Since we have a ON DELETE constraint on biblio_metadata.biblionumber, the row is deleted when the biblio entry is deleted => data lost! Test plan: - Create a biblio - Delete it => Without this patch the deletedbiblio_metadata table is not populated with the biblio_metadata row related to the biblio => With this patch applied you should see that the row has been moved. Followed test plan, behaves as expected Signed-off-by: Marc V?ron -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Mar 16 21:55:10 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 16 Mar 2017 20:55:10 +0000 Subject: [Koha-bugs] [Bug 18284] Biblio metadata are not moved to the deleted table when a biblio is deleted In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18284 Marc V?ron changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off CC| |veron at veron.ch -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Mar 16 22:02:08 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 16 Mar 2017 21:02:08 +0000 Subject: [Koha-bugs] [Bug 18280] Item barcodes should be locked when record is created In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18280 Marc V?ron changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |veron at veron.ch See Also| |https://bugs.koha-community | |.org/bugzilla3/show_bug.cgi | |?id=8425 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Mar 16 22:02:08 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 16 Mar 2017 21:02:08 +0000 Subject: [Koha-bugs] [Bug 8425] Autobarcode generates duplicate barcodes with AcqCreateItems = on order In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8425 Marc V?ron changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |https://bugs.koha-community | |.org/bugzilla3/show_bug.cgi | |?id=18280 -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Mar 16 22:03:58 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 16 Mar 2017 21:03:58 +0000 Subject: [Koha-bugs] [Bug 15249] barcode duplicate warning missing during adding multiple copy In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15249 Marc V?ron changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |https://bugs.koha-community | |.org/bugzilla3/show_bug.cgi | |?id=18280 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Mar 16 22:03:58 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 16 Mar 2017 21:03:58 +0000 Subject: [Koha-bugs] [Bug 18280] Item barcodes should be locked when record is created In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18280 Marc V?ron changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |https://bugs.koha-community | |.org/bugzilla3/show_bug.cgi | |?id=15249 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Mar 16 22:04:57 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 16 Mar 2017 21:04:57 +0000 Subject: [Koha-bugs] [Bug 8857] Add and duplicate functionality inconsistent w/autobarcode In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8857 Marc V?ron changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |veron at veron.ch -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Mar 16 22:19:44 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 16 Mar 2017 21:19:44 +0000 Subject: [Koha-bugs] [Bug 18283] Display improvements on report results - hide code and change wording In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18283 Marc V?ron changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |veron at veron.ch --- Comment #4 from Marc V?ron --- I can not toggle code display. It seems that something went lost from previous patch: Show sql code -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Mar 16 22:54:53 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 16 Mar 2017 21:54:53 +0000 Subject: [Koha-bugs] [Bug 4175] duplicate items does not obey autoBarcode sys pref In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=4175 Candice Hope changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |https://bugs.koha-community | |.org/bugzilla3/show_bug.cgi | |?id=8857 -- You are receiving this mail because: You are watching all bug changes. You are the QA Contact for the bug. From bugzilla-daemon at bugs.koha-community.org Thu Mar 16 22:54:53 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 16 Mar 2017 21:54:53 +0000 Subject: [Koha-bugs] [Bug 8857] Add and duplicate functionality inconsistent w/autobarcode In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8857 Candice Hope changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |https://bugs.koha-community | |.org/bugzilla3/show_bug.cgi | |?id=4175 CC| |candiceh at payson.org -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Mar 17 00:00:56 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 16 Mar 2017 23:00:56 +0000 Subject: [Koha-bugs] [Bug 17895] Small typo -'re-set' In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17895 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Severity|enhancement |trivial -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Mar 17 02:47:15 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 17 Mar 2017 01:47:15 +0000 Subject: [Koha-bugs] [Bug 14224] patron notes about item shown at check in In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14224 Lisette changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |lisetteslatah at gmail.com -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Mar 17 02:52:03 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 17 Mar 2017 01:52:03 +0000 Subject: [Koha-bugs] [Bug 16276] When automatically deleting expired borrowers, make sure they didn't log in recently In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16276 Lisette changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |lisetteslatah at gmail.com -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Mar 17 06:34:29 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 17 Mar 2017 05:34:29 +0000 Subject: [Koha-bugs] [Bug 13205] Last/First page options for result list paging In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13205 dilan at calyx.net.au changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #60300|0 |1 is obsolete| | --- Comment #5 from dilan at calyx.net.au --- Created attachment 61194 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=61194&action=edit Bug 13205: Last/first page options for result list paging for OPAC Same fix but on OPAC side. Same test plan Sponsored-by: Catalyst IT Signed-off-by: Dilan Johnpulle Signed-off-by: Your Full Name -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Mar 17 06:38:31 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 17 Mar 2017 05:38:31 +0000 Subject: [Koha-bugs] [Bug 13205] Last/First page options for result list paging In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13205 --- Comment #6 from dilan at calyx.net.au --- Comment on attachment 61194 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=61194 Bug 13205: Last/first page options for result list paging for OPAC >From bd80eca290f389e8e12d63dd220ec639763adcbb Mon Sep 17 00:00:00 2001 >From: Aleisha Amohia >Date: Thu, 16 Feb 2017 02:28:13 +0000 >Subject: [PATCH] Bug 13205: Last/first page options for result list paging for > OPAC > >Same fix but on OPAC side. Same test plan > >Sponsored-by: Catalyst IT > >Signed-off-by: Dilan Johnpulle > >--- > .../bootstrap/en/includes/page-numbers.inc | 26 ++++++++++++---------- > opac/opac-search.pl | 2 ++ > 2 files changed, 16 insertions(+), 12 deletions(-) > >diff --git a/koha-tmpl/opac-tmpl/bootstrap/en/includes/page-numbers.inc b/koha-tmpl/opac-tmpl/bootstrap/en/includes/page-numbers.inc >index f18c9ce..63e083e 100644 >--- a/koha-tmpl/opac-tmpl/bootstrap/en/includes/page-numbers.inc >+++ b/koha-tmpl/opac-tmpl/bootstrap/en/includes/page-numbers.inc >@@ -1,19 +1,21 @@ > [% IF ( PAGE_NUMBERS ) %] > > [% END %] >diff --git a/opac/opac-search.pl b/opac/opac-search.pl >index a84e9d3..130aad3 100755 >--- a/opac/opac-search.pl >+++ b/opac/opac-search.pl >@@ -837,6 +837,7 @@ for (my $i=0;$i<@servers;$i++) { > my @page_numbers; > # total number of pages there will be > my $pages = ceil($hits / $results_per_page); >+ my $last_page = ($pages * $results_per_page) - $results_per_page; > # default page number > my $current_page_number = 1; > if ($offset) { >@@ -887,6 +888,7 @@ for (my $i=0;$i<@servers;$i++) { > > } > $template->param( PAGE_NUMBERS => \@page_numbers, >+ last_page => $last_page, > previous_page_offset => $previous_page_offset) unless $pages < 2; > $template->param(next_page_offset => $next_page_offset) unless $pages eq $current_page_number; > } >-- >2.1.4 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Mar 17 06:40:17 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 17 Mar 2017 05:40:17 +0000 Subject: [Koha-bugs] [Bug 13205] Last/First page options for result list paging In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13205 --- Comment #7 from dilan at calyx.net.au --- Comment on attachment 61194 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=61194 Bug 13205: Last/first page options for result list paging for OPAC >From bd80eca290f389e8e12d63dd220ec639763adcbb Mon Sep 17 00:00:00 2001 >From: Aleisha Amohia >Date: Thu, 16 Feb 2017 02:28:13 +0000 >Subject: [PATCH] Bug 13205: Last/first page options for result list paging for > OPAC > >Same fix but on OPAC side. Same test plan > >Sponsored-by: Catalyst IT > >Signed-off-by: Dilan Johnpulle > >--- > .../bootstrap/en/includes/page-numbers.inc | 26 ++++++++++++---------- > opac/opac-search.pl | 2 ++ > 2 files changed, 16 insertions(+), 12 deletions(-) > >diff --git a/koha-tmpl/opac-tmpl/bootstrap/en/includes/page-numbers.inc b/koha-tmpl/opac-tmpl/bootstrap/en/includes/page-numbers.inc >index f18c9ce..63e083e 100644 >--- a/koha-tmpl/opac-tmpl/bootstrap/en/includes/page-numbers.inc >+++ b/koha-tmpl/opac-tmpl/bootstrap/en/includes/page-numbers.inc >@@ -1,19 +1,21 @@ > [% IF ( PAGE_NUMBERS ) %] > > [% END %] >diff --git a/opac/opac-search.pl b/opac/opac-search.pl >index a84e9d3..130aad3 100755 >--- a/opac/opac-search.pl >+++ b/opac/opac-search.pl >@@ -837,6 +837,7 @@ for (my $i=0;$i<@servers;$i++) { > my @page_numbers; > # total number of pages there will be > my $pages = ceil($hits / $results_per_page); >+ my $last_page = ($pages * $results_per_page) - $results_per_page; > # default page number > my $current_page_number = 1; > if ($offset) { >@@ -887,6 +888,7 @@ for (my $i=0;$i<@servers;$i++) { > > } > $template->param( PAGE_NUMBERS => \@page_numbers, >+ last_page => $last_page, > previous_page_offset => $previous_page_offset) unless $pages < 2; > $template->param(next_page_offset => $next_page_offset) unless $pages eq $current_page_number; > } >-- >2.1.4 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Mar 17 06:46:41 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 17 Mar 2017 05:46:41 +0000 Subject: [Koha-bugs] [Bug 13205] Last/First page options for result list paging In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13205 dilan at calyx.net.au changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |dilan at calyx.net.au Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Mar 17 07:20:13 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 17 Mar 2017 06:20:13 +0000 Subject: [Koha-bugs] [Bug 18290] New: Fix t/db_dependent/Koha/Object.t, Mojo::JSON:: Bool is a JSON::PP::Boolean :) Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18290 Bug ID: 18290 Summary: Fix t/db_dependent/Koha/Object.t, Mojo::JSON::Bool is a JSON::PP::Boolean :) Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Architecture, internals, and plumbing Assignee: gmcharlt at gmail.com Reporter: olli-antti.kivilahti at jns.fi QA Contact: testopia at bugs.koha-community.org -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Mar 17 07:21:24 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 17 Mar 2017 06:21:24 +0000 Subject: [Koha-bugs] [Bug 17932] Koha::Object should provide a TO_JSON method In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17932 Olli-Antti Kivilahti changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |olli-antti.kivilahti at jns.fi Blocks| |18290 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18290 [Bug 18290] Fix t/db_dependent/Koha/Object.t, Mojo::JSON::Bool is a JSON::PP::Boolean :) -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Mar 17 07:21:24 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 17 Mar 2017 06:21:24 +0000 Subject: [Koha-bugs] [Bug 18290] Fix t/db_dependent/Koha/Object.t, Mojo::JSON::Bool is a JSON:: PP::Boolean :) In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18290 Olli-Antti Kivilahti changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on| |17932 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17932 [Bug 17932] Koha::Object should provide a TO_JSON method -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Mar 17 07:22:06 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 17 Mar 2017 06:22:06 +0000 Subject: [Koha-bugs] [Bug 17932] Koha::Object should provide a TO_JSON method In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17932 --- Comment #27 from Olli-Antti Kivilahti --- Followup Bug 18290 fixes tests to cover a change in Mojolicious -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Mar 17 07:22:18 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 17 Mar 2017 06:22:18 +0000 Subject: [Koha-bugs] [Bug 18290] Fix t/db_dependent/Koha/Object.t, Mojo::JSON::Bool is a JSON:: PP::Boolean :) In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18290 Olli-Antti Kivilahti changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|gmcharlt at gmail.com |olli-antti.kivilahti at jns.fi Status|NEW |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Mar 17 07:23:01 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 17 Mar 2017 06:23:01 +0000 Subject: [Koha-bugs] [Bug 18290] Fix t/db_dependent/Koha/Object.t, Mojo::JSON::Bool is a JSON:: PP::Boolean :) In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18290 --- Comment #1 from Olli-Antti Kivilahti --- Created attachment 61195 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=61195&action=edit Bug 18290 - Fix t/db_dependent/Koha/Object.t, Mojo::JSON::Bool is a JSON::PP::Boolean :) Mojolicious no longer returns Mojo::JSON::Bool-objects but JSON::PP instead. Which might be pretty smart. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Mar 17 07:23:33 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 17 Mar 2017 06:23:33 +0000 Subject: [Koha-bugs] [Bug 18290] Fix t/db_dependent/Koha/Object.t, Mojo::JSON::Bool is a JSON:: PP::Boolean :) In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18290 --- Comment #2 from Olli-Antti Kivilahti --- The Mojolicious team tends to do a lot of smart things. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Mar 17 08:01:08 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 17 Mar 2017 07:01:08 +0000 Subject: [Koha-bugs] [Bug 18291] New: Remove SQL from preferences.pl administrative script Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18291 Bug ID: 18291 Summary: Remove SQL from preferences.pl administrative script Change sponsored?: --- Product: Koha Version: 17.05 Hardware: All OS: All Status: ASSIGNED Severity: enhancement Priority: P5 - low Component: Architecture, internals, and plumbing Assignee: alexbuckley at catalyst.net.nz Reporter: alexbuckley at catalyst.net.nz QA Contact: testopia at bugs.koha-community.org This bug report requires the removal of SQL code from the preferences.pl administrative script into a separate perl module. It also requires the creation of unit tests and POD for the new subroutines in the perl modules. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Mar 17 08:02:35 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 17 Mar 2017 07:02:35 +0000 Subject: [Koha-bugs] [Bug 18292] New: t/db_dependent/Circulation.t Dubious, test returned 1 even if test ok Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18292 Bug ID: 18292 Summary: t/db_dependent/Circulation.t Dubious, test returned 1 even if test ok Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Circulation Assignee: koha-bugs at lists.koha-community.org Reporter: olli-antti.kivilahti at jns.fi QA Contact: testopia at bugs.koha-community.org CC: gmcharlt at gmail.com, kyle.m.hall at gmail.com -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Mar 17 08:03:00 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 17 Mar 2017 07:03:00 +0000 Subject: [Koha-bugs] [Bug 18292] t/db_dependent/Circulation.t Dubious, test returned 1 even if test ok In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18292 Olli-Antti Kivilahti changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff Depends on| |12596 Assignee|koha-bugs at lists.koha-commun |olli-antti.kivilahti at jns.fi |ity.org | Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12596 [Bug 12596] Backdating returns with SpecifiyReturnDate causes fines for items not overdue! -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Mar 17 08:03:00 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 17 Mar 2017 07:03:00 +0000 Subject: [Koha-bugs] [Bug 12596] Backdating returns with SpecifiyReturnDate causes fines for items not overdue! In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12596 Olli-Antti Kivilahti changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |18292 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18292 [Bug 18292] t/db_dependent/Circulation.t Dubious, test returned 1 even if test ok -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Mar 17 08:03:04 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 17 Mar 2017 07:03:04 +0000 Subject: [Koha-bugs] [Bug 18284] Biblio metadata are not moved to the deleted table when a biblio is deleted In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18284 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |martin.renvoize at ptfs-europe | |.com --- Comment #3 from Martin Renvoize --- I wish we flagged deleted rather than had deleted_* tables.. this sort of thing would be far less fraught with dangers that way. I would also do this at the DBIC level personally.. with a monkeypatch of the standard delete call. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Mar 17 08:05:12 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 17 Mar 2017 07:05:12 +0000 Subject: [Koha-bugs] [Bug 18292] t/db_dependent/Circulation.t doesn't need to return 1; In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18292 Olli-Antti Kivilahti changed: What |Removed |Added ---------------------------------------------------------------------------- Summary|t/db_dependent/Circulation. |t/db_dependent/Circulation. |t Dubious, test returned 1 |t doesn't need to return 1; |even if test ok | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Mar 17 08:06:08 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 17 Mar 2017 07:06:08 +0000 Subject: [Koha-bugs] [Bug 18292] t/db_dependent/Circulation.t doesn't need to return 1; In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18292 --- Comment #1 from Olli-Antti Kivilahti --- Created attachment 61196 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=61196&action=edit Bug 18292 - t/db_dependent/Circulation.t doesn't need to return 1; -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Mar 17 08:06:57 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 17 Mar 2017 07:06:57 +0000 Subject: [Koha-bugs] [Bug 18292] t/db_dependent/Circulation.t doesn't need to return 1; In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18292 --- Comment #2 from Olli-Antti Kivilahti --- Initially thought the test fails because of this when ran via prove, but it was maybe something leaking between test cases. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Mar 17 08:10:24 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 17 Mar 2017 07:10:24 +0000 Subject: [Koha-bugs] [Bug 18284] Biblio metadata are not moved to the deleted table when a biblio is deleted In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18284 --- Comment #4 from Martin Renvoize --- Comment on attachment 61193 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=61193 Bug 18284: (bug 17196 follow-up) Move biblio metadata when a biblio is deleted Review of attachment 61193: --> (https://bugs.koha-community.org/bugzilla3/page.cgi?id=splinter.html&bug=18284&attachment=61193) ----------------------------------------------------------------- New FIXME..? ::: C4/Biblio.pm @@ +3361,4 @@ > my $sth = $dbh->prepare("SELECT * FROM biblio WHERE biblionumber=?"); > $sth->execute($biblionumber); > > + # FIXME There is a transaction in _koha_delete_biblio_metadata Why add the FIXME rather than adding the code to actually solve the problem? Nested transactions work well in DBIC whenever I've used them -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Mar 17 08:13:33 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 17 Mar 2017 07:13:33 +0000 Subject: [Koha-bugs] [Bug 18284] Biblio metadata are not moved to the deleted table when a biblio is deleted In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18284 --- Comment #5 from Martin Renvoize --- OK, I can see why it's not at the DBIC level.. C4 module not Koha.. my bad. :( -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Mar 17 08:13:46 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 17 Mar 2017 07:13:46 +0000 Subject: [Koha-bugs] [Bug 16757] Add ability to pay fee by id for SIP2 In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16757 Marcel de Rooy changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |m.de.rooy at rijksmuseum.nl Status|Signed Off |Patch doesn't apply -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Mar 17 08:14:33 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 17 Mar 2017 07:14:33 +0000 Subject: [Koha-bugs] [Bug 16895] Allow writeoffs via SIP2 In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16895 Marcel de Rooy changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |BLOCKED --- Comment #6 from Marcel de Rooy --- Depends on a PNA -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Mar 17 08:15:20 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 17 Mar 2017 07:15:20 +0000 Subject: [Koha-bugs] [Bug 16899] Add ability to disallow overpayments via SIP In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16899 Marcel de Rooy changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |m.de.rooy at rijksmuseum.nl Status|Signed Off |BLOCKED --- Comment #5 from Marcel de Rooy --- Also depends on a PNA -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Mar 17 08:33:50 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 17 Mar 2017 07:33:50 +0000 Subject: [Koha-bugs] [Bug 17005] REST API: add routes to list checkouts history In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17005 --- Comment #19 from Olli-Antti Kivilahti --- Created attachment 61197 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=61197&action=edit Bug 17005 - REST API: add routes to list checkouts history - Followup1. Fix date_due timeformat in tests. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Mar 17 08:45:04 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 17 Mar 2017 07:45:04 +0000 Subject: [Koha-bugs] [Bug 18293] New: REST API tests. fix dateformat change regression in tests Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18293 Bug ID: 18293 Summary: REST API tests. fix dateformat change regression in tests Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Web services Assignee: koha-bugs at lists.koha-community.org Reporter: olli-antti.kivilahti at jns.fi QA Contact: testopia at bugs.koha-community.org -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Mar 17 08:47:32 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 17 Mar 2017 07:47:32 +0000 Subject: [Koha-bugs] [Bug 18293] REST API tests. fix dateformat change regression in tests In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18293 --- Comment #1 from Olli-Antti Kivilahti --- Created attachment 61198 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=61198&action=edit Bug 18293 - REST API tests. fix dateformat change regression in tests # got: '2017-03-27T00:00:00+03:00' # expected: '2017-03-27 00:00:00' Lax ISO8601 is not hip anymore. Now we roll wid dem big boyz! P.S. All datetimes in REST TESTS need fixing. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Mar 17 08:47:53 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 17 Mar 2017 07:47:53 +0000 Subject: [Koha-bugs] [Bug 18293] REST API tests. fix dateformat change regression in tests In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18293 Olli-Antti Kivilahti changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|koha-bugs at lists.koha-commun |lari.taskula at jns.fi |ity.org | -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Mar 17 09:01:16 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 17 Mar 2017 08:01:16 +0000 Subject: [Koha-bugs] [Bug 18265] Followup to Bug 17196. deletedbiblio_metadata is not used. biblioitemnumber was forgotten In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18265 --- Comment #15 from Olli-Antti Kivilahti --- Created attachment 61199 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=61199&action=edit Bug 18265 - Followup to Buuug 17196. Fix t/db_dependent/Exporter/Record.t -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Mar 17 09:03:12 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 17 Mar 2017 08:03:12 +0000 Subject: [Koha-bugs] [Bug 7029] searching : fuzzy et steming In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7029 --- Comment #8 from Fridolin SOMERS --- You have the syspref IncludeSeeFormInSearches on, it may impact the search results on worlds not visible in the biblio record. -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Mar 17 09:07:11 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 17 Mar 2017 08:07:11 +0000 Subject: [Koha-bugs] [Bug 18284] Biblio metadata are not moved to the deleted table when a biblio is deleted In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18284 Olli-Antti Kivilahti changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |olli-antti.kivilahti at jns.fi --- Comment #6 from Olli-Antti Kivilahti --- (In reply to Martin Renvoize from comment #3) > I wish we flagged deleted rather than had deleted_* tables.. this sort of > thing would be far less fraught with dangers that way. > > I would also do this at the DBIC level personally.. with a monkeypatch of > the standard delete call. I kinda agree. Having two separate tables makes doing reports very very awkward. But I guess there would be a performance penalty of having 5 years of history in the biblioitems-table eh? After over two and a half years of service, our DB has 153569 deletedbiblio- and 1422962 biblio-rows. deletebiblio has no effect performance-wise. Martin I am 100% with you on this topic. Martin. Take a look at Bug 18265 and comment on what these cultural Marxists are about to do. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Mar 17 09:07:20 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 17 Mar 2017 08:07:20 +0000 Subject: [Koha-bugs] [Bug 18265] Followup to Bug 17196. deletedbiblio_metadata is not used. biblioitemnumber was forgotten In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18265 Olli-Antti Kivilahti changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |https://bugs.koha-community | |.org/bugzilla3/show_bug.cgi | |?id=18284 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Mar 17 09:07:20 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 17 Mar 2017 08:07:20 +0000 Subject: [Koha-bugs] [Bug 18284] Biblio metadata are not moved to the deleted table when a biblio is deleted In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18284 Olli-Antti Kivilahti changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |https://bugs.koha-community | |.org/bugzilla3/show_bug.cgi | |?id=18265 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Mar 17 09:12:58 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 17 Mar 2017 08:12:58 +0000 Subject: [Koha-bugs] [Bug 18292] t/db_dependent/Circulation.t doesn't need to return 1; In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18292 Marc V?ron changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |veron at veron.ch --- Comment #3 from Marc V?ron --- What about the tons of *.t files with 1; as last line? git grep '^1;' -- *.t -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Mar 17 09:15:11 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 17 Mar 2017 08:15:11 +0000 Subject: [Koha-bugs] [Bug 18292] t/db_dependent/Circulation.t doesn't need to return 1; In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18292 --- Comment #4 from Olli-Antti Kivilahti --- (In reply to Marc V?ron from comment #3) > What about the tons of *.t files with 1; as last line? > > git grep '^1;' -- *.t This patch is just cosmetic and seems to have no impact on test results. If I had a delete button for this issue I would delete this. But as I don't, it is better to make some use of this ticket. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Mar 17 10:00:37 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 17 Mar 2017 09:00:37 +0000 Subject: [Koha-bugs] [Bug 12021] SIP2 checkin should alert on transfer and use CT for return branch In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12021 --- Comment #11 from Marcel de Rooy --- Still applies. Saw the CV04 but not the CT (protocol issue). A branch transfer was created for checkin at another location. Will come back here later. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Mar 17 10:01:15 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 17 Mar 2017 09:01:15 +0000 Subject: [Koha-bugs] [Bug 12021] SIP2 checkin should alert on transfer and use CT for return branch In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12021 --- Comment #12 from Marcel de Rooy --- Created attachment 61200 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=61200&action=edit Bug 12021 - SIP2 checkin should alert on transfer and use CT for return branch This small patch corrects the SIP2 checkin response if branch transfer is needed. It depends on bug 7981 and also removes an obsolete alert check in SIP2. Test plan: - apply bug 7981 - make sure syspref AutomaticItemReturn is false - check 'Return policy' in 'Default checkout, hold and return policy' - make a SIP2 checkout and checkin from a branch different than item's home branch. - verify that SIP2 response gives alert CV04 (=send to different branch) - also verify that response field CT gives correct branch according to 'Return policy' Signed-off-by: Kyle M Hall -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Mar 17 10:01:34 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 17 Mar 2017 09:01:34 +0000 Subject: [Koha-bugs] [Bug 12021] SIP2 checkin should alert on transfer and use CT for return branch In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12021 Marcel de Rooy changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #27488|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Mar 17 10:02:31 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 17 Mar 2017 09:02:31 +0000 Subject: [Koha-bugs] [Bug 12021] SIP2 checkin should alert on transfer and use CT for return branch In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12021 --- Comment #13 from Marcel de Rooy --- Trivial rebase iirc -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Mar 17 10:18:14 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 17 Mar 2017 09:18:14 +0000 Subject: [Koha-bugs] [Bug 16758] Caching issues in scripts running in daemon mode In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16758 Marc V?ron changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |veron at veron.ch -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Mar 17 10:27:30 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 17 Mar 2017 09:27:30 +0000 Subject: [Koha-bugs] [Bug 16258] Add a preference to turn EDIFACT off In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16258 Marc V?ron changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |Patch doesn't apply --- Comment #12 from Marc V?ron --- Patch no longer applies. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Mar 17 10:29:07 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 17 Mar 2017 09:29:07 +0000 Subject: [Koha-bugs] [Bug 14608] HEA : add possibility of sharing usage statistics in Administration page and Web installer In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14608 Marcel de Rooy changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #59949|0 |1 is obsolete| | --- Comment #48 from Marcel de Rooy --- Created attachment 61201 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=61201&action=edit Bug 14608: Add a page to configure shared statistics This patch set adds: - a reference to Hea at the end of the installation process - a link to the new page from the admin home page - a new page to easily configure shared statistics Signed-off-by: Mark Tompsett Signed-off-by: Chris Cormack Signed-off-by: Marcel de Rooy -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Mar 17 10:29:12 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 17 Mar 2017 09:29:12 +0000 Subject: [Koha-bugs] [Bug 14608] HEA : add possibility of sharing usage statistics in Administration page and Web installer In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14608 Marcel de Rooy changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #59950|0 |1 is obsolete| | --- Comment #49 from Marcel de Rooy --- Created attachment 61202 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=61202&action=edit Bug 14608: Add a link from the admin home page Signed-off-by: Mark Tompsett Signed-off-by: Chris Cormack Signed-off-by: Marcel de Rooy -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Mar 17 10:29:16 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 17 Mar 2017 09:29:16 +0000 Subject: [Koha-bugs] [Bug 14608] HEA : add possibility of sharing usage statistics in Administration page and Web installer In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14608 Marcel de Rooy changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #59951|0 |1 is obsolete| | --- Comment #50 from Marcel de Rooy --- Created attachment 61203 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=61203&action=edit Bug 14608: Add a reference to Hea at the end of the installer process Signed-off-by: Mark Tompsett Signed-off-by: Chris Cormack Signed-off-by: Marcel de Rooy -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Mar 17 10:29:21 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 17 Mar 2017 09:29:21 +0000 Subject: [Koha-bugs] [Bug 14608] HEA : add possibility of sharing usage statistics in Administration page and Web installer In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14608 Marcel de Rooy changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #59952|0 |1 is obsolete| | --- Comment #51 from Marcel de Rooy --- Created attachment 61204 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=61204&action=edit Bug 14608: Follow up on labels and search box This addresses concerns raised in comment #26 and comment #27. Signed-off-by: Chris Cormack Signed-off-by: Marcel de Rooy -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Mar 17 10:29:25 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 17 Mar 2017 09:29:25 +0000 Subject: [Koha-bugs] [Bug 14608] HEA : add possibility of sharing usage statistics in Administration page and Web installer In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14608 Marcel de Rooy changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #61031|0 |1 is obsolete| | --- Comment #52 from Marcel de Rooy --- Created attachment 61205 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=61205&action=edit Bug 14608: Move country list to an include file Signed-off-by: Marcel de Rooy -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Mar 17 10:33:55 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 17 Mar 2017 09:33:55 +0000 Subject: [Koha-bugs] [Bug 14608] HEA : add possibility of sharing usage statistics in Administration page and Web installer In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14608 Marcel de Rooy changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA QA Contact|testopia at bugs.koha-communit |m.de.rooy at rijksmuseum.nl |y.org | Patch complexity|Medium patch |Small patch --- Comment #53 from Marcel de Rooy --- Looks good to me. Note that I expected more from this patch set than it actually does. It just seems to be another form for setting the HEA prefs. As mentioned on the report, you will deal with translating the country list on a new report. Looking forward to that. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Mar 17 10:47:25 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 17 Mar 2017 09:47:25 +0000 Subject: [Koha-bugs] [Bug 18284] Biblio metadata are not moved to the deleted table when a biblio is deleted In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18284 Marcel de Rooy changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |m.de.rooy at rijksmuseum.nl --- Comment #7 from Marcel de Rooy --- (In reply to Olli-Antti Kivilahti from comment #6) > comment on what these cultural Marxists are about to do. Hmm Quote: "about 99.9% of the time "Cultural Marxism" is a snarl word used to attack anyone with progressive tendencies" Link with Nazi Germany? imo we could do without such terms? -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Mar 17 10:56:46 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 17 Mar 2017 09:56:46 +0000 Subject: [Koha-bugs] [Bug 16939] Making all 'add to basket' actions buttons In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16939 --- Comment #16 from Marc V?ron --- Created attachment 61206 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=61206&action=edit Strange artifact when ordering from external source Testing 11) 'Order' should now show as a button with appropriate icons. MARC and Card preview have been moved into a dropdown menu - confirm this works as expected. Links have not been changed when clicking on a row Result Clicking on adropdown menu shows a strange artifact. Tested with Firefox 52.0 (32-Bit) Win Other points are OK -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Mar 17 11:05:06 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 17 Mar 2017 10:05:06 +0000 Subject: [Koha-bugs] [Bug 18283] Display improvements on report results - hide code and change wording In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18283 Nick Clemens changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #61192|0 |1 is obsolete| | --- Comment #5 from Nick Clemens --- Created attachment 61207 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=61207&action=edit Bug 18283 - Display improvements on report results - hide code and change wording This patch makes small display improvements to the report results page. -Add toggle link for SQL code -Change results count wording -Add 'Notes:' label report notes To test: 1 - Apply patch 2 - Run some reports 3 - Check that results page makes sense 4 - Hide and display code and ensure toggle works -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Mar 17 11:06:53 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 17 Mar 2017 10:06:53 +0000 Subject: [Koha-bugs] [Bug 18284] Biblio metadata are not moved to the deleted table when a biblio is deleted In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18284 Marcel de Rooy changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #61193|0 |1 is obsolete| | --- Comment #8 from Marcel de Rooy --- Created attachment 61208 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=61208&action=edit Bug 18284: (bug 17196 follow-up) Move biblio metadata when a biblio is deleted There is a deletedbiblio_metadata table but it is not populated when a biblio is deleted. Since we have a ON DELETE constraint on biblio_metadata.biblionumber, the row is deleted when the biblio entry is deleted => data lost! Test plan: - Create a biblio - Delete it => Without this patch the deletedbiblio_metadata table is not populated with the biblio_metadata row related to the biblio => With this patch applied you should see that the row has been moved. Followed test plan, behaves as expected Signed-off-by: Marc V?ron Signed-off-by: Marcel de Rooy -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Mar 17 11:07:22 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 17 Mar 2017 10:07:22 +0000 Subject: [Koha-bugs] [Bug 18284] Biblio metadata are not moved to the deleted table when a biblio is deleted In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18284 Marcel de Rooy changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Mar 17 11:07:25 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 17 Mar 2017 10:07:25 +0000 Subject: [Koha-bugs] [Bug 18284] Biblio metadata are not moved to the deleted table when a biblio is deleted In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18284 --- Comment #9 from Marcel de Rooy --- Created attachment 61209 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=61209&action=edit Bug 18284: [QA Follow-up] Add test descriptions Signed-off-by: Marcel de Rooy -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Mar 17 11:09:39 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 17 Mar 2017 10:09:39 +0000 Subject: [Koha-bugs] [Bug 18284] Biblio metadata are not moved to the deleted table when a biblio is deleted In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18284 --- Comment #10 from Marcel de Rooy --- (In reply to Martin Renvoize from comment #4) > Why add the FIXME rather than adding the code to actually solve the problem? Passed QA since we need the deleted xml. But I agree that the FIXME and the transaction stuff needs further attention. The result of the new txn_do call is not even checked. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Mar 17 11:11:06 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 17 Mar 2017 10:11:06 +0000 Subject: [Koha-bugs] [Bug 18284] Biblio metadata are not moved to the deleted table when a biblio is deleted In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18284 Marcel de Rooy changed: What |Removed |Added ---------------------------------------------------------------------------- Patch complexity|--- |Small patch QA Contact|testopia at bugs.koha-communit |m.de.rooy at rijksmuseum.nl |y.org | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Mar 17 11:51:19 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 17 Mar 2017 10:51:19 +0000 Subject: [Koha-bugs] [Bug 13345] Choose the format when sending a basket/list by email In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13345 Marcel de Rooy changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #56499|0 |1 is obsolete| | --- Comment #17 from Marcel de Rooy --- Created attachment 61210 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=61210&action=edit Bug 13345: Allow patrons to choose format on sending basket/list by email It is already possible to download a basket(cart) or a list using different format. But by email, only iso2709 is possible. This patch adds the ability to select a format for the file attached to the email when sending the basket/list content. Test plan: 1/ At the OPAC, add some records to your basket and send it by email using different formats (RIS, BibTeX, MARC and the CSV profiles defined). 2/ At the OPAC, add some records to a list and send it by email using the different formats. 3/ Redo step 1 at the intranet 4/ Redo step 2 at the intranet Not that subtitles are not displayed in all these cases. Note for QA: This patch refactors 3 main things: 1/ Template side: the dropdown list to select the format is now in an include file (indeed, this list is used in 4 templates, this will make easier further changes). The include files are named 'download-export-available-formats.inc', feel free to suggest something better. The are used in: [opac-]sendbasket.tt, [opac-]sendshelf.tt, [opac-]downloadbasket.tt and [opac-]downloadshelf.tt. 2/ Build records data and the records file This job was done in 4 scripts: - opac/opac-sendbasket.pl - opac/opac-sendshelf.pl - basket/sendbasket.pl - virtualshelves/sendshelf.pl Now it's done in C4::Biblio::BuildBiblioDataForExport and tests are provided in t/db_dependent/Biblio/BuildBiblioDataForExport.t Not that a similar job is done in [opac-]downloadcart.pl and [opac-]downloadshelf.pl 3/ Build the subject and body of the email sent Same as before, the job was done at the same places. Now it's done in Koha::Email->fill_body_for_sending (feel free to suggestion a better name) and tests are provided in t/Koha_Email.t Sponsored-by: Mines Paristech Signed-off-by: Nicole C. Engard -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Mar 17 11:53:10 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 17 Mar 2017 10:53:10 +0000 Subject: [Koha-bugs] [Bug 13345] Choose the format when sending a basket/list by email In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13345 --- Comment #18 from Marcel de Rooy --- # Subtest: iso2709 1..7 ok 1 - BuildBiblioDataForExport should return a correct records file in iso2709 ok 2 ok 3 - 499 and 462 ok 4 ok 5 - 1 item ok 6 - 0 author ok 7 - bibionumber is correct Please add test descriptions -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Mar 17 11:53:40 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 17 Mar 2017 10:53:40 +0000 Subject: [Koha-bugs] [Bug 13345] Choose the format when sending a basket/list by email In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13345 --- Comment #19 from Marcel de Rooy --- # Subtest: ris 1..1 Use of uninitialized value in numeric ne (!=) at /usr/share/koha/masterclone/C4/Ris.pm line 834. Use of uninitialized value in numeric ne (!=) at /usr/share/koha/masterclone/C4/Ris.pm line 834. not ok 1 # Failed test at t/db_dependent/Biblio/BuildBiblioDataForExport.t line 68. # got: 'TY - BOOK # AU - Knuth,Donald Ervin # TI - The art of computer programming # KW - Computer programming # KW - Computer algorithms # ER - # ' # expected: 'TY - BOOK # AU - Knuth, Donald Ervin # TI - The art of computer programming # KW - Computer programming # KW - Computer algorithms # ER - # ' # Looks like you failed 1 test of 1. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Mar 17 11:54:41 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 17 Mar 2017 10:54:41 +0000 Subject: [Koha-bugs] [Bug 13345] Choose the format when sending a basket/list by email In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13345 --- Comment #20 from Marcel de Rooy --- # Subtest: bibtex 1..1 not ok 1 # Failed test at t/db_dependent/Biblio/BuildBiblioDataForExport.t line 77. # got: '@book{1945, # author = {Knuth, Donald Ervin}, # title = {The art of computer programming} # } # ' # expected: '@book{1945, # author = {Knuth, Donald Ervin}, # title = {The art of computer programming} # } # ' # Looks like you failed 1 test of 1. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Mar 17 12:00:29 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 17 Mar 2017 11:00:29 +0000 Subject: [Koha-bugs] [Bug 13345] Choose the format when sending a basket/list by email In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13345 Marcel de Rooy changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Failed QA --- Comment #21 from Marcel de Rooy --- Can't locate object method "biblionumber" via package "41" (perhaps you forgot to load "41"?) at /usr/share/koha/masterclone/virtualshelves/sendshelf.pl line 76 Both opac-sendshelf and virtualshelves/sendshelf.pl contain this statement: my $biblionumber = $content->biblionumber->biblionumber; Is not correct. Also please add your signoff to the original patch. And/or add follow-ups. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Mar 17 12:21:49 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 17 Mar 2017 11:21:49 +0000 Subject: [Koha-bugs] [Bug 17233] Add 008 value builder plugin for MARC21 classifications In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17233 Marcel de Rooy changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Failed QA --- Comment #4 from Marcel de Rooy --- Question: I am not familiar with MARC21 classification records. But I understand that they are not the same as authority records. Are we introducing here some workaround to use authorities as classifications? Strictly speaking, improper use? Since this only is a plugin, we do no harm here. But what would be the next step? How are you using this? What is the future for classifications in Koha? Changing status to reflect need for feedback. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Mar 17 12:22:33 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 17 Mar 2017 11:22:33 +0000 Subject: [Koha-bugs] [Bug 17233] Add 008 value builder plugin for MARC21 classifications In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17233 Marcel de Rooy changed: What |Removed |Added ---------------------------------------------------------------------------- QA Contact|testopia at bugs.koha-communit |m.de.rooy at rijksmuseum.nl |y.org | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Mar 17 12:26:01 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 17 Mar 2017 11:26:01 +0000 Subject: [Koha-bugs] [Bug 17233] Add 008 value builder plugin for MARC21 classifications In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17233 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |katrin.fischer at bsz-bw.de --- Comment #5 from Katrin Fischer --- Not sure if this is true in general, but we get classification records from our union catalog in the same file as the other authority records. We currently don't import them, but last time I investigated it looked like we'd just need a framework and some additional mappings for the main heading (hardcoded in some places) to make it work. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Mar 17 12:28:02 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 17 Mar 2017 11:28:02 +0000 Subject: [Koha-bugs] [Bug 18251] SCO alerts - need a trigger for successful checkouts In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18251 Marc V?ron changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |veron at veron.ch See Also| |https://bugs.koha-community | |.org/bugzilla3/show_bug.cgi | |?id=16732 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Mar 17 12:28:02 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 17 Mar 2017 11:28:02 +0000 Subject: [Koha-bugs] [Bug 16732] Add audio alerts (custom sound notifications) to web based self checkout In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16732 Marc V?ron changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |https://bugs.koha-community | |.org/bugzilla3/show_bug.cgi | |?id=18251 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Mar 17 12:31:28 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 17 Mar 2017 11:31:28 +0000 Subject: [Koha-bugs] [Bug 18251] SCO alerts - need a trigger for successful checkouts In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18251 Marc V?ron changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #61040|0 |1 is obsolete| | --- Comment #2 from Marc V?ron --- Created attachment 61211 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=61211&action=edit Bug 18251 - SCO alerts - need a trigger for successful checkouts This patch adds simple text and a div to allow for sounds to be configured upon successful SCO checkout To test: 1 - Enable sco module 2 - Enable AudioAlerts 3 - Define alert with Selector: .sco-alert-success Sound:http://localhost:8081/intranet-tmpl/prog/sound/opening.ogg 4 - Checkout to patron using SCO 5 - Note only feedback is a addition of item to checkouts list 6 - Apply patch 7 - Checkout ot patron via SCO 8 - You should hear the sound specified above 9 - You should also see a note: Item checked out Followed test plan, works as expected. (Works with external sound only, see Bug 16732) Signed-off-by: Marc V?ron -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Mar 17 12:31:52 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 17 Mar 2017 11:31:52 +0000 Subject: [Koha-bugs] [Bug 18251] SCO alerts - need a trigger for successful checkouts In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18251 Marc V?ron changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Mar 17 13:18:29 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 17 Mar 2017 12:18:29 +0000 Subject: [Koha-bugs] [Bug 17519] Item editor handles clearing dateaccessioned and replacementpricedate inconsistently In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17519 Marcel de Rooy changed: What |Removed |Added ---------------------------------------------------------------------------- Status|In Discussion |Signed Off --- Comment #14 from Marcel de Rooy --- The discussion seems to be finished ;) -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Mar 17 13:26:08 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 17 Mar 2017 12:26:08 +0000 Subject: [Koha-bugs] [Bug 18284] Biblio metadata are not moved to the deleted table when a biblio is deleted In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18284 --- Comment #11 from Jonathan Druart --- (In reply to Martin Renvoize from comment #3) > I wish we flagged deleted rather than had deleted_* tables.. this sort of > thing would be far less fraught with dangers that way. I am just following the existing pattern, used twice already. Moreover the table already exists and we want to keep FK. Without 2 differents we could not keep the FK. > I would also do this at the DBIC level personally.. with a monkeypatch of > the standard delete call. With a critical or blocker I always try to provide as small fix as possible to avoid any integration problems. Without using DBIx::Class I avoid creating 2 new packages + provide tests (~100 lines minimum). (In reply to Martin Renvoize from comment #4) > Comment on attachment 61193 [details] [review] > New FIXME..? Yes? What's wrong with FIXME? I provide code that is not good, I highlight it in the codebase. > ::: C4/Biblio.pm > @@ +3361,4 @@ > > my $sth = $dbh->prepare("SELECT * FROM biblio WHERE biblionumber=?"); > > $sth->execute($biblionumber); > > > > + # FIXME There is a transaction in _koha_delete_biblio_metadata > > Why add the FIXME rather than adding the code to actually solve the problem? > > Nested transactions work well in DBIC whenever I've used them Yes of course, I use them in these tests and they pass. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Mar 17 13:37:19 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 17 Mar 2017 12:37:19 +0000 Subject: [Koha-bugs] [Bug 18284] Biblio metadata are not moved to the deleted table when a biblio is deleted In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18284 --- Comment #12 from Martin Renvoize --- I'm happy with this.. just thought the FIXME worth pointing out. I'm hoping there's an intention to go back and fix the fixme 'tis all ;) Is there a broader discussion anywhere regarding delete_* tables.. that was more a throw away comment to be honest. I was tempted to pass qa on it myself but hadn't yet fully tested it. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Mar 17 13:40:30 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 17 Mar 2017 12:40:30 +0000 Subject: [Koha-bugs] [Bug 7728] Fixing subscription endddate inconsistency: should be empty when the subscription is running In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7728 Marcel de Rooy changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Mar 17 13:40:33 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 17 Mar 2017 12:40:33 +0000 Subject: [Koha-bugs] [Bug 18284] Biblio metadata are not moved to the deleted table when a biblio is deleted In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18284 --- Comment #13 from Jonathan Druart --- (In reply to Martin Renvoize from comment #12) > I'm happy with this.. just thought the FIXME worth pointing out. I'm hoping > there's an intention to go back and fix the fixme 'tis all ;) > > Is there a broader discussion anywhere regarding delete_* tables.. that was > more a throw away comment to be honest. I was tempted to pass qa on it > myself but hadn't yet fully tested it. Yes, and especially the last 2 months as we faced critical issues, like bug 18242 for instance, or bug 18003. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Mar 17 13:40:34 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 17 Mar 2017 12:40:34 +0000 Subject: [Koha-bugs] [Bug 7728] Fixing subscription endddate inconsistency: should be empty when the subscription is running In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7728 Marcel de Rooy changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #58813|0 |1 is obsolete| | Attachment #58814|0 |1 is obsolete| | Attachment #58815|0 |1 is obsolete| | --- Comment #17 from Marcel de Rooy --- Created attachment 61212 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=61212&action=edit Bug 7728: Fix subs history end date consistency Without this patch, there is an inconsistency in subscriptions: * a new subscription has no history end date set (as expected) * if you renew it, a date is set. This patch removes the setting of the history end date during renewal Test plan: * create a subscription, go to subscription-detail.pl page, tab "Summary". No History end date is set * renew the subscription => a date has been set * apply the patch * create another subscription * renew it => no history end date has been set * sign-off Signed-off-by: beroud Signed-off-by: Marcel de Rooy -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Mar 17 13:40:40 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 17 Mar 2017 12:40:40 +0000 Subject: [Koha-bugs] [Bug 7728] Fixing subscription endddate inconsistency: should be empty when the subscription is running In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7728 --- Comment #18 from Marcel de Rooy --- Created attachment 61213 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=61213&action=edit Bug 7728: Adding unit test ReNewSubscription.t Test plan: * run without the patch, the test will fail * run with the patch, the test will pass Signed-off-by: Marcel de Rooy -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Mar 17 13:40:45 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 17 Mar 2017 12:40:45 +0000 Subject: [Koha-bugs] [Bug 7728] Fixing subscription endddate inconsistency: should be empty when the subscription is running In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7728 --- Comment #19 from Marcel de Rooy --- Created attachment 61214 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=61214&action=edit Bug 7728: QA fixes - Remove useless comments - Use Koha::Objects::find instead of Koha::Objects::search Signed-off-by: Marcel de Rooy -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Mar 17 13:40:49 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 17 Mar 2017 12:40:49 +0000 Subject: [Koha-bugs] [Bug 7728] Fixing subscription endddate inconsistency: should be empty when the subscription is running In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7728 --- Comment #20 from Marcel de Rooy --- Created attachment 61215 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=61215&action=edit Bug 7728: [QA Follow-up] Fix POD whitespace Resolves complaints from qa tools. Signed-off-by: Marcel de Rooy -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Mar 17 13:41:14 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 17 Mar 2017 12:41:14 +0000 Subject: [Koha-bugs] [Bug 7728] Fixing subscription endddate inconsistency: should be empty when the subscription is running In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7728 Marcel de Rooy changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |m.de.rooy at rijksmuseum.nl --- Comment #21 from Marcel de Rooy --- Two patches from Paul again; come, write a few more :) -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Mar 17 13:42:35 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 17 Mar 2017 12:42:35 +0000 Subject: [Koha-bugs] [Bug 14608] HEA : add possibility of sharing usage statistics in Administration page and Web installer In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14608 --- Comment #54 from Jonathan Druart --- (In reply to Marcel de Rooy from comment #53) > Looks good to me. Note that I expected more from this patch set than it > actually does. It just seems to be another form for setting the HEA prefs. What would you expect more? Seen bug 18066? -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Mar 17 13:43:40 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 17 Mar 2017 12:43:40 +0000 Subject: [Koha-bugs] [Bug 7728] Fixing subscription endddate inconsistency: should be empty when the subscription is running In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7728 Marcel de Rooy changed: What |Removed |Added ---------------------------------------------------------------------------- QA Contact| |m.de.rooy at rijksmuseum.nl Patch complexity|--- |Small patch -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Mar 17 13:46:02 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 17 Mar 2017 12:46:02 +0000 Subject: [Koha-bugs] [Bug 14608] HEA : add possibility of sharing usage statistics in Administration page and Web installer In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14608 --- Comment #55 from Marcel de Rooy --- (In reply to Jonathan Druart from comment #54) > (In reply to Marcel de Rooy from comment #53) > > Looks good to me. Note that I expected more from this patch set than it > > actually does. It just seems to be another form for setting the HEA prefs. > > What would you expect more? Seen bug 18066? Only the title :) -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Mar 17 13:53:02 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 17 Mar 2017 12:53:02 +0000 Subject: [Koha-bugs] [Bug 17233] Add 008 value builder plugin for MARC21 classifications In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17233 --- Comment #6 from Jacek Ablewicz --- As far as I know, for all practical purposes, classification records (or "classification authority records" in other nomenclature) are authority records, just slightly different kind than "ordinary" authority records. LoC classification records are generally speaking, numeric classification records (of different types: UDC, Dewey, and so on) controlled by an authority. In MARC21 biblio records, classification numbers are typically in 08X fields, and in the authority record, corresponding classification number is (usually ?) in the heading field with 153 tag. But, as Katrin said, for such "classification authority records" to be fully functional in Koha, apart from user-configurable stuff like frameworks, zebra indexes etc., you need to make some changes (additions) in the code too: - C4/Heading/MARC21.pm - C4/AuthoritiesMarc.pm because tag numbers and subfields for a given authority types are hard coded in there. For example (we are using UDC numerical classification in here), we needed to add definitions for 080 and 153 tags in aforementioned files, because they were not supported by default. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Mar 17 13:58:03 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 17 Mar 2017 12:58:03 +0000 Subject: [Koha-bugs] [Bug 18294] New: Keyword searches surrounded by double quotes fail on staff client and OPAC Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18294 Bug ID: 18294 Summary: Keyword searches surrounded by double quotes fail on staff client and OPAC Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Searching Assignee: gmcharlt at gmail.com Reporter: barton at bywatersolutions.com QA Contact: testopia at bugs.koha-community.org To replicate: A keyword search for juggling for the complete klutz or a single quoted version of the same: 'juggling for the complete klutz' on https://demo.bywatersolutions.com returns the following result: https://demo.bywatersolutions.com/cgi-bin/koha/opac-detail.pl?biblionumber=36263 The same search, surrounded by double quotes returns no hits: "juggling for the complete klutz" https://demo.bywatersolutions.com/cgi-bin/koha/opac-search.pl?q=%22juggling+for+the+complete+klutz%22&branch_group_limit= ... RESULTS OF SEARCH FOR 'KW,WRDL: "JUGGLING FOR THE COMPLETE KLUTZ"' No results found! No results found for that in ByWater Library System catalog. ? Sorry we didn't find what you were looking for [Replicated under 16.11.04.001] -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Mar 17 14:00:49 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 17 Mar 2017 13:00:49 +0000 Subject: [Koha-bugs] [Bug 18294] Keyword searches surrounded by double quotes fail on staff client and OPAC In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18294 Barton Chittenden changed: What |Removed |Added ---------------------------------------------------------------------------- Severity|enhancement |normal -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Mar 17 14:10:29 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 17 Mar 2017 13:10:29 +0000 Subject: [Koha-bugs] [Bug 13205] Last/First page options for result list paging In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13205 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Failed QA CC| |jonathan.druart at bugs.koha-c | |ommunity.org --- Comment #8 from Jonathan Druart --- Hi Aleisha, It's a bit more complicated, we do not want to see First and Last when they are not needed (for instance if you are on the first or last page). I would have written my $last_page = ($pages * $results_per_page) - $results_per_page; that way: my $last_page = $pages * ( $results_per_page - 1 ); Sounds more readable. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Mar 17 14:19:54 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 17 Mar 2017 13:19:54 +0000 Subject: [Koha-bugs] [Bug 18078] Updating buttons for z39.50 Authority search In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18078 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |jonathan.druart at bugs.koha-c | |ommunity.org, | |oleonard at myacpl.org --- Comment #3 from Jonathan Druart --- I discussed with Owen about the use of btn-primary and I think the conclusion was not to use as it is, but customise our own. I do not find the bug report where it has been discussed, so ccing Owen to refresh my mind. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Mar 17 14:40:43 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 17 Mar 2017 13:40:43 +0000 Subject: [Koha-bugs] [Bug 15541] Prevent normalization during matching/import process In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15541 Marcel de Rooy changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Mar 17 14:40:46 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 17 Mar 2017 13:40:46 +0000 Subject: [Koha-bugs] [Bug 15541] Prevent normalization during matching/import process In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15541 Marcel de Rooy changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #59295|0 |1 is obsolete| | --- Comment #36 from Marcel de Rooy --- Created attachment 61216 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=61216&action=edit Bug 15541 - Prevent normalization during matching/import process This patch allows you to use the "qualifier,qualifier" syntax in the Record Matching Rules "Search Index" when using the QueryParser. While QueryParser doesn't support this syntax, it will now fallback correctly to non-QueryParser functionality. Without the patch, your search will just fail silently. This patch also adds a "skip_normalize" option to C4::Search::SimpleSearch(), and uses the option during C4::Matcher::get_matches. This prevents the s/:/=/g and s/=/:/g normalization. This normalization is heavy-handed, and while it is necessary sometimes to generate a valid CCL query or QueryParser query, C4::Matcher::get_matches() already produces a valid CCL query, so we don't need to do this normalization. Additionally, this normalization causes problems when you use a Zebra register which isn't normalized: namely the "u" register. Strings are stored "as is", so http://localhost/koha/resource/1 is stored as is during indexing. When you search, you need to pass the exact same thing through the query to get a match. Using http=//localhost/koha/resource/1 in your query will yield zero results. _TEST PLAN_ 0) Apply patch 1) Create a Record Matching Rule in Koha with the following details: Matching rule code: TEST Description: Test Match threshold: 100 Record type: Bibliographic Match point 1: Search index: id-other,st-urx Score: 100 Tag: 024 Subfields: a Normalization rule: None 2) Create a record in Koha with an indexable URI 2a) Default framework 2b) 024 $a http://koha-community.org/test $2 uri 2c) 040 $c test 2d) 245 $a This is a test record 2e) 942 $c Books 2f) Save (save again if cautioned about missing fields as these should autofill) 3) Do a full re-index of Zebra 4) Download your record from Koha as a .mrc file (ie isomarc, binary marc, etc) 5) Go to "Stage MARC records for import" 5a) Upload your .marc file. 5b) Change your "Record matching rule" to "Test" 5c) Click Stage for import 9) It should say "1 records with at least one match in catalog per matching rule "Test". NOTE: For completeness, you can go through this process on a clean master branch, and note that it will say '0 records with at least one match in catalog per matching rule "TEST"' Signed-off-by: Alex Buckley Signed-off-by: Marcel de Rooy -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Mar 17 14:41:13 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 17 Mar 2017 13:41:13 +0000 Subject: [Koha-bugs] [Bug 15541] Prevent normalization during matching/import process In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15541 --- Comment #37 from Marcel de Rooy --- QA Comment: Looks good to me. Finally :) %options: Putting a hash in the parameter list may be tricky of course. We always like to have unit tests. But unfortunately we have no tests for get_matches.. Passed QA -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Mar 17 14:42:49 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 17 Mar 2017 13:42:49 +0000 Subject: [Koha-bugs] [Bug 18251] SCO alerts - need a trigger for successful checkouts In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18251 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |jonathan.druart at bugs.koha-c | |ommunity.org --- Comment #3 from Jonathan Druart --- Should not it be an id instead of a class? -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Mar 17 14:42:54 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 17 Mar 2017 13:42:54 +0000 Subject: [Koha-bugs] [Bug 17519] Item editor handles clearing dateaccessioned and replacementpricedate inconsistently In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17519 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |In Discussion --- Comment #15 from Katrin Fischer --- Actually no - I just didn't have the time to write another answer. I think this patch makes the behaviour inconsistent. If you can empty out on editing, but not on adding the item - that will look like a bug. The behaviour right now is consistent as the field is forced to be mandatory and as I said, we rely on this in some contexts - for example in context of inventory books. Maybe we should discuss use cases first? Things that come to my mind: - new books list - inventory book (electronical, sometimes printed out) - sorting by accession date in the OPAC - weeding reports/workflows -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Mar 17 14:45:33 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 17 Mar 2017 13:45:33 +0000 Subject: [Koha-bugs] [Bug 18251] SCO alerts - need a trigger for successful checkouts In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18251 --- Comment #4 from Jonathan Druart --- And maybe the message should be in a box, to make it more visible. At the moment it is quite hidden. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Mar 17 14:45:51 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 17 Mar 2017 13:45:51 +0000 Subject: [Koha-bugs] [Bug 18078] Updating buttons for z39.50 Authority search In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18078 --- Comment #4 from Marc V?ron --- (In reply to Jonathan Druart from comment #3) > I discussed with Owen about the use of btn-primary and I think the > conclusion was not to use as it is, but customise our own. > I do not find the bug report where it has been discussed, so ccing Owen to > refresh my mind. Maybe Bug 18042 ? -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Mar 17 14:47:07 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 17 Mar 2017 13:47:07 +0000 Subject: [Koha-bugs] [Bug 17519] Item editor handles clearing dateaccessioned and replacementpricedate inconsistently In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17519 Marcel de Rooy changed: What |Removed |Added ---------------------------------------------------------------------------- Status|In Discussion |RESOLVED Resolution|--- |WONTFIX --- Comment #16 from Marcel de Rooy --- (In reply to Katrin Fischer from comment #15) > Actually no - I just didn't have the time to write another answer. > > I think this patch makes the behaviour inconsistent. If you can empty out on > editing, but not on adding the item - that will look like a bug. > > The behaviour right now is consistent as the field is forced to be mandatory > and as I said, we rely on this in some contexts - for example in context of > inventory books. > > Maybe we should discuss use cases first? > > Things that come to my mind: > - new books list > - inventory book (electronical, sometimes printed out) > - sorting by accession date in the OPAC > - weeding reports/workflows OK. The current behavior is not really consistent (if you compare with the other date). But in view of its low importance, I would rather close this report now if it disturbs other users too much.. No problem! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Mar 17 14:47:16 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 17 Mar 2017 13:47:16 +0000 Subject: [Koha-bugs] [Bug 17519] Item editor handles clearing dateaccessioned and replacementpricedate inconsistently In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17519 Marcel de Rooy changed: What |Removed |Added ---------------------------------------------------------------------------- Status|RESOLVED |CLOSED -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Mar 17 14:56:00 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 17 Mar 2017 13:56:00 +0000 Subject: [Koha-bugs] [Bug 18251] SCO alerts - need a trigger for successful checkouts In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18251 --- Comment #5 from Marc V?ron --- (In reply to Jonathan Druart from comment #3) > Should not it be an id instead of a class? The alerts were introduced with Bug 11431, the triggers are in a class, e.g. https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=44395&action=diff#a/koha-tmpl/intranet-tmpl/prog/en/modules/circ/circulation.tt_sec1
    -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Mar 17 14:56:47 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 17 Mar 2017 13:56:47 +0000 Subject: [Koha-bugs] [Bug 18251] SCO alerts - need a trigger for successful checkouts In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18251 Marc V?ron changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |https://bugs.koha-community | |.org/bugzilla3/show_bug.cgi | |?id=11431 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Mar 17 14:56:47 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 17 Mar 2017 13:56:47 +0000 Subject: [Koha-bugs] [Bug 11431] Custom notification sounds In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11431 Marc V?ron changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |https://bugs.koha-community | |.org/bugzilla3/show_bug.cgi | |?id=18251 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Mar 17 14:58:04 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 17 Mar 2017 13:58:04 +0000 Subject: [Koha-bugs] [Bug 18294] Keyword searches surrounded by double quotes fail on staff client and OPAC In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18294 --- Comment #1 from Barton Chittenden --- Note that this issue is separate from the URL encoding issues in Bug 13301. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Mar 17 15:05:39 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 17 Mar 2017 14:05:39 +0000 Subject: [Koha-bugs] [Bug 18078] Updating buttons for z39.50 Authority search In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18078 --- Comment #5 from Jonathan Druart --- Yes certainly, thanks! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Mar 17 15:18:08 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 17 Mar 2017 14:18:08 +0000 Subject: [Koha-bugs] [Bug 18264] Course reserves - use itemnumber for editing existing reserve items In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18264 --- Comment #5 from Jonathan Druart --- Comment on attachment 61095 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=61095 Bug 18264 - Course reserves - use itemnumber for editing existing reserve items Review of attachment 61095: --> (https://bugs.koha-community.org/bugzilla3/page.cgi?id=splinter.html&bug=18264&attachment=61095) ----------------------------------------------------------------- ::: course_reserves/add_items.pl @@ +39,2 @@ > > +my $item = GetBiblioFromItemNumber( $itemnumber, $barcode ); This is wrong, this subroutine uses only one parameter (also see bug 18276). @@ +50,4 @@ > flagsrequired => { coursereserves => 'add_reserves' }, > } > ); > +my $inumber = $itemnumber ? " (itemnumber:$itemnumber)" : ""; hum? ? @@ +51,5 @@ > } > ); > +my $inumber = $itemnumber ? " (itemnumber:$itemnumber)" : ""; > +$template->param( ERROR_BARCODE_NOT_FOUND => $barcode . $inumber ) > + unless ( $barcode && !$itemnumber && $item && $action eq 'lookup' ); How do we reach that? -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Mar 17 15:18:17 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 17 Mar 2017 14:18:17 +0000 Subject: [Koha-bugs] [Bug 18264] Course reserves - use itemnumber for editing existing reserve items In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18264 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Failed QA -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Mar 17 15:21:52 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 17 Mar 2017 14:21:52 +0000 Subject: [Koha-bugs] [Bug 17995] HOLDPLACED notice should have access to the reserves table In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17995 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |jonathan.druart at bugs.koha-c | |ommunity.org Attachment #59559|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Mar 17 15:28:33 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 17 Mar 2017 14:28:33 +0000 Subject: [Koha-bugs] [Bug 17995] HOLDPLACED notice should have access to the reserves table In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17995 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Mar 17 15:28:38 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 17 Mar 2017 14:28:38 +0000 Subject: [Koha-bugs] [Bug 17995] HOLDPLACED notice should have access to the reserves table In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17995 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #61115|0 |1 is obsolete| | --- Comment #3 from Jonathan Druart --- Created attachment 61217 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=61217&action=edit Bug 17995 - HOLDPLACED notice should have access to the reserves table To test: 1 - Add reserves.reservenotes to HOLDPLACED message 2 - Enable emailLibrarianWhenHoldIsPlaced OpacHoldNotes sysprefs 3 - Place a hold via OPAC with a note 4 - view the messagequeue and note the reservenotes is blank 5 - Apply patch 6 - Place a hold with a note 7 - view the messagequeue and note the reservenotes is populated Followed test plan, works as expected. Signed-off-by: Marc V?ron Signed-off-by: Jonathan Druart -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Mar 17 15:29:39 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 17 Mar 2017 14:29:39 +0000 Subject: [Koha-bugs] [Bug 14544] Move the list related code to Koha::Virtualshelves In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14544 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |17886 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17886 [Bug 17886] Don't show option to add to existing list if there are no lists -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Mar 17 15:29:39 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 17 Mar 2017 14:29:39 +0000 Subject: [Koha-bugs] [Bug 17886] Don' t show option to add to existing list if there are no lists In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17886 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on| |14544 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14544 [Bug 14544] Move the list related code to Koha::Virtualshelves -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Mar 17 15:36:12 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 17 Mar 2017 14:36:12 +0000 Subject: [Koha-bugs] [Bug 17886] Don' t show option to add to existing list if there are no lists In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17886 --- Comment #10 from Jonathan Druart --- I am lost here... First patch fixed the staff interface only, now the patch fixes the opac interface only... Can we have both please? -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Mar 17 15:36:21 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 17 Mar 2017 14:36:21 +0000 Subject: [Koha-bugs] [Bug 17886] Don' t show option to add to existing list if there are no lists In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17886 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Failed QA -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Mar 17 16:00:45 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 17 Mar 2017 15:00:45 +0000 Subject: [Koha-bugs] [Bug 18231] Add the missing id-column to koha.issuingrules-table for DBIC fixtures In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18231 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Mar 17 16:00:50 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 17 Mar 2017 15:00:50 +0000 Subject: [Koha-bugs] [Bug 18231] Add the missing id-column to koha.issuingrules-table for DBIC fixtures In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18231 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #61102|0 |1 is obsolete| | --- Comment #13 from Jonathan Druart --- Created attachment 61218 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=61218&action=edit Bug 18231 - Add the missing id-column to koha.issuingrules-table for DBIC fixtures Many DBIx-stuffs depend on last_insert_id Followed test plan from comment #4, works as expected Signed-off-by: Marc V?ron -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Mar 17 16:00:57 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 17 Mar 2017 15:00:57 +0000 Subject: [Koha-bugs] [Bug 18231] Add the missing id-column to koha.issuingrules-table for DBIC fixtures In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18231 --- Comment #14 from Jonathan Druart --- Created attachment 61219 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=61219&action=edit Bug 18231: Make sure we will not add the column twice -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Mar 17 16:02:06 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 17 Mar 2017 15:02:06 +0000 Subject: [Koha-bugs] [Bug 18231] Add the missing id-column to koha.issuingrules-table for DBIC fixtures In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18231 --- Comment #15 from Jonathan Druart --- Olli, you are not supposed to modify a patch once it has been signed off. Take a look at the second patch to know how to process for DB updates adding/modifying columns. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Mar 17 16:17:54 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 17 Mar 2017 15:17:54 +0000 Subject: [Koha-bugs] [Bug 14365] SQL Reports Last Edit Date column In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14365 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA CC| |jonathan.druart at bugs.koha-c | |ommunity.org --- Comment #9 from Jonathan Druart --- Not blocker but it would have been good to update the prototype of the subroutine to pass a hashref instead of the list of undef... This new parameter is a bit awkward: if the id is passed, a DB field is updated. Not elegant but given the quality of the existing code it's hard to provide something better... Passing QA -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Mar 17 16:19:28 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 17 Mar 2017 15:19:28 +0000 Subject: [Koha-bugs] [Bug 14365] SQL Reports Last Edit Date column In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14365 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #61060|0 |1 is obsolete| | Attachment #61061|0 |1 is obsolete| | Attachment #61062|0 |1 is obsolete| | --- Comment #10 from Jonathan Druart --- Created attachment 61220 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=61220&action=edit Bug 14365 - Populate never used saved_sql column last_run when execute_query is called Signed-off-by: Cab Vinton Signed-off-by: Kyle M Hall Signed-off-by: Jonathan Druart -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Mar 17 16:19:38 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 17 Mar 2017 15:19:38 +0000 Subject: [Koha-bugs] [Bug 14365] SQL Reports Last Edit Date column In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14365 --- Comment #12 from Jonathan Druart --- Created attachment 61222 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=61222&action=edit Bug 14365 - Change 'Last modified' to 'Last edit' for terseness Signed-off-by: Cab Vinton Signed-off-by: Kyle M Hall Signed-off-by: Jonathan Druart -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Mar 17 16:19:33 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 17 Mar 2017 15:19:33 +0000 Subject: [Koha-bugs] [Bug 14365] SQL Reports Last Edit Date column In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14365 --- Comment #11 from Jonathan Druart --- Created attachment 61221 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=61221&action=edit Bug 14365 - SQL Reports Last Edit Date column - Show in interface Test Plan: 1) Apply these patches 2) Modify a saved sql report 3) Note the "Last modified" column is updated 4) Run the report 5) Note the "Last run" column is updated Signed-off-by: Cab Vinton Signed-off-by: Kyle M Hall Signed-off-by: Jonathan Druart -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Mar 17 16:21:16 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 17 Mar 2017 15:21:16 +0000 Subject: [Koha-bugs] [Bug 5938] Maximum number of issues across a family group In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5938 Lennon changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |lmmazonde at gmail.com --- Comment #2 from Lennon --- Hi, has there been anywork done on this feature? It would certainly be useful to be able to limit the total number of checkouts for a particular family group. Does it require a cosponsor or developers? -- You are receiving this mail because: You are watching all bug changes. You are the QA Contact for the bug. From bugzilla-daemon at bugs.koha-community.org Fri Mar 17 16:33:58 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 17 Mar 2017 15:33:58 +0000 Subject: [Koha-bugs] [Bug 13345] Choose the format when sending a basket/list by email In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13345 --- Comment #22 from Jonathan Druart --- (In reply to Marcel de Rooy from comment #21) > Can't locate object method "biblionumber" via package "41" (perhaps you > forgot to load "41"?) at > /usr/share/koha/masterclone/virtualshelves/sendshelf.pl line 76 > > Both opac-sendshelf and virtualshelves/sendshelf.pl contain this statement: > my $biblionumber = $content->biblionumber->biblionumber; > Is not correct. Because of bug 17094. About the test failures, I guess we will adjust the tests as it is certainly not this patch that make them fail, but it looks like a Koha regression then. I am pretty sure the tests passed when I wrote them. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Mar 17 17:15:59 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 17 Mar 2017 16:15:59 +0000 Subject: [Koha-bugs] [Bug 8010] Search history can be added to the wrong patron In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8010 --- Comment #12 from Baptiste --- Created attachment 61223 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=61223&action=edit BUG 8010: Correct a few syntax errors, and moved tests - Tests are now in t/db_dependent/Search/History.t - There were 2 differents sysprefs in sysprefs.sql and in atomicupdate => fixed -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Mar 17 17:16:49 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 17 Mar 2017 16:16:49 +0000 Subject: [Koha-bugs] [Bug 8010] Search history can be added to the wrong patron In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8010 Baptiste changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Mar 17 17:19:20 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 17 Mar 2017 16:19:20 +0000 Subject: [Koha-bugs] [Bug 18093] Add the Koha::Objects->get_column method In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18093 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on| |18295 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18295 [Bug 18295] Koha::Biblio - Remove get_itemnumbers_of -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Mar 17 17:19:20 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 17 Mar 2017 16:19:20 +0000 Subject: [Koha-bugs] [Bug 18295] New: Koha::Biblio - Remove get_itemnumbers_of Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18295 Bug ID: 18295 Summary: Koha::Biblio - Remove get_itemnumbers_of Change sponsored?: --- Product: Koha Version: unspecified Hardware: All OS: All Status: ASSIGNED Severity: enhancement Priority: P5 - low Component: Architecture, internals, and plumbing Assignee: jonathan.druart at bugs.koha-community.org Reporter: jonathan.druart at bugs.koha-community.org QA Contact: testopia at bugs.koha-community.org Blocks: 18093, 18279 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18093 [Bug 18093] Add the Koha::Objects->get_column method https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18279 [Bug 18279] C4::Items - Remove GetLostItems -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Mar 17 17:19:20 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 17 Mar 2017 16:19:20 +0000 Subject: [Koha-bugs] [Bug 18279] C4::Items - Remove GetLostItems In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18279 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on| |18295 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18295 [Bug 18295] Koha::Biblio - Remove get_itemnumbers_of -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Mar 17 17:20:10 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 17 Mar 2017 16:20:10 +0000 Subject: [Koha-bugs] [Bug 18295] Koha::Biblio - Remove get_itemnumbers_of In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18295 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |18296 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18296 [Bug 18296] Koha::Biblio - Remove GetItemInfosOf -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Mar 17 17:20:10 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 17 Mar 2017 16:20:10 +0000 Subject: [Koha-bugs] [Bug 18296] New: Koha::Biblio - Remove GetItemInfosOf Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18296 Bug ID: 18296 Summary: Koha::Biblio - Remove GetItemInfosOf Change sponsored?: --- Product: Koha Version: unspecified Hardware: All OS: All Status: ASSIGNED Severity: enhancement Priority: P5 - low Component: Architecture, internals, and plumbing Assignee: jonathan.druart at bugs.koha-community.org Reporter: jonathan.druart at bugs.koha-community.org QA Contact: testopia at bugs.koha-community.org Depends on: 18295 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18295 [Bug 18295] Koha::Biblio - Remove get_itemnumbers_of -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Mar 17 17:21:49 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 17 Mar 2017 16:21:49 +0000 Subject: [Koha-bugs] [Bug 18296] C4::Items - Remove GetItemInfosOf In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18296 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Summary|Koha::Biblio - Remove |C4::Items - Remove |GetItemInfosOf |GetItemInfosOf -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Mar 17 17:22:04 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 17 Mar 2017 16:22:04 +0000 Subject: [Koha-bugs] [Bug 18295] C4::Items - Remove get_itemnumbers_of In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18295 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Summary|Koha::Biblio - Remove |C4::Items - Remove |get_itemnumbers_of |get_itemnumbers_of -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Mar 17 17:22:58 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 17 Mar 2017 16:22:58 +0000 Subject: [Koha-bugs] [Bug 18125] Edit button can duplicate some circulation rule In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18125 --- Comment #6 from Baptiste --- Hi ! You mean gray out the field or the menus ? Because graying out the scrollable menus is the expected behavior of this patch.. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Mar 17 17:24:00 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 17 Mar 2017 16:24:00 +0000 Subject: [Koha-bugs] [Bug 12021] SIP2 checkin should alert on transfer and use CT for return branch In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12021 Marcel de Rooy changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Failed QA --- Comment #14 from Marcel de Rooy --- Please look at this: if ($messages->{NeedsTransfer}) { $self->{item}->destination_loc($messages->{NeedsTransfer}); $self->alert_type('04'); # send to other branch } if ($messages->{WasTransfered}) { # set into transit so tell unit $self->destination_loc($iteminformation->{homebranch}); $self->alert_type('04'); # send to other branch } You changed NeedsTransfer, but you did not touch WasTransfered here. That is the reason why I saw the CV04 without CT. Please change and set back to Needs Signoff. A fresh signoff would not be bad. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Mar 17 17:45:46 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 17 Mar 2017 16:45:46 +0000 Subject: [Koha-bugs] [Bug 18297] New: Clicking on Stage MARC records for import launches koha installer Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18297 Bug ID: 18297 Summary: Clicking on Stage MARC records for import launches koha installer Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: critical Priority: P5 - low Component: Tools Assignee: gmcharlt at gmail.com Reporter: cbrannon at cdalibrary.org QA Contact: testopia at bugs.koha-community.org In master, when you click on the "Stage MARC records for import" under tools, you get thrown into the Koha installer. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Mar 17 17:57:31 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 17 Mar 2017 16:57:31 -0000 Subject: [Koha-bugs] [Bug 17314] REST API: Add API route to create, list and delete a purchase suggestion In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17314 Mike changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Mar 17 17:59:22 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 17 Mar 2017 16:59:22 +0000 Subject: [Koha-bugs] [Bug 8010] Search history can be added to the wrong patron In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8010 --- Comment #13 from Marc V?ron --- applied both paches, then git grep FirstLoggedUser Result: both variants of LoadSearchHistoryToTheFirstLoggedUser rsp. addSearchHistoryToTheFirstLoggedUser -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Mar 17 18:05:27 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 17 Mar 2017 17:05:27 +0000 Subject: [Koha-bugs] [Bug 18283] Display improvements on report results - hide code and change wording In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18283 Christopher Brannon changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Failed QA --- Comment #6 from Christopher Brannon --- Works great. Just need to add space between buttons. The picky part of me wants you to place the button between the New report and Edit buttons. Makes more sense to be there. But the space is a must. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Mar 17 18:07:29 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 17 Mar 2017 17:07:29 +0000 Subject: [Koha-bugs] [Bug 17479] REST API: Save information on owner access In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17479 --- Comment #10 from Jiri Kozlovsky --- Lari, what do you think about storing owned object also? I think sparing one DB request for each owner / guarantor request is a good step forward. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Mar 17 18:13:03 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 17 Mar 2017 17:13:03 +0000 Subject: [Koha-bugs] [Bug 17479] REST API: Save information on owner access In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17479 --- Comment #11 from Lari Taskula --- (In reply to Jiri Kozlovsky from comment #10) > Lari, what do you think about storing owned object also? > > I think sparing one DB request for each owner / guarantor request is a good > step forward. True. I don't see why we should not also stash the owned object. Feel free to provide a follow-up :) -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Mar 17 18:14:33 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 17 Mar 2017 17:14:33 +0000 Subject: [Koha-bugs] [Bug 18297] Clicking on Stage MARC records for import launches koha installer In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18297 --- Comment #1 from Christopher Brannon --- Per Katrin, this seems to have corrected the issue: On kohadevbox: sudo koha-shell kohadev perl installer/data/mysql/updatedatabase.pl exit restart_all Not sure what caused this issue, but this corrects it. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Mar 17 18:25:39 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 17 Mar 2017 17:25:39 +0000 Subject: [Koha-bugs] [Bug 18296] C4::Items - Remove GetItemInfosOf In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18296 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Mar 17 18:25:42 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 17 Mar 2017 17:25:42 +0000 Subject: [Koha-bugs] [Bug 18296] C4::Items - Remove GetItemInfosOf In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18296 --- Comment #1 from Jonathan Druart --- Created attachment 61224 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=61224&action=edit Bug 18295: C4::Items - get_itemnumbers_of The code from scripts and subroutines using this subroutine was not very elegant. Most of the time the code was unnecessarily complex. This patch removes this subroutine and adapt the code to use Koha::Items instead. 1. C4::Items::get_hostitemnumbers_of I did not understand why the code was so complicated, it seems that we only want to know if a given item has a given biblionumber 2. cataloguing/merge.pl We want to retrieve the itemnumber for a given biblio. We could also have done that with: Koha::Biblios->find( $biblionumber )->items; 3. labels/label-item-search.pl We want to loop over the items for a given biblio, no need to use get_itemnumbers_of and GetItemInfosOf. We just need to use: Koha::Items->search({ biblionumber => $biblionumber }) 4. reserve/request.pl We want to retrieve the itemnumbers of the biblio's items We could also have done that with: Koha::Biblios->find( $biblionumber )->items->get_column('itemnumber'); Test plan: 1.You need to create analytical record relationships ( EasyAnalyticalRecords needs to be set). Link an item to a biblio using the 'Edit > Link to host item' menu from the biblio detail page. >From the staff interface place a hold on the biblio. You should see the items from the biblio and the one you just linked 2. Merge two bibliographic records (with items), the resulting record should contain items from both original records 3. Create a new label batch, edit it. Add items to this batch ('Add items' button). Fill the input with a barcode. You should see all the items of a biblio. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Mar 17 18:26:59 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 17 Mar 2017 17:26:59 +0000 Subject: [Koha-bugs] [Bug 18295] C4::Items - Remove get_itemnumbers_of In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18295 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Mar 17 18:27:03 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 17 Mar 2017 17:27:03 +0000 Subject: [Koha-bugs] [Bug 18295] C4::Items - Remove get_itemnumbers_of In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18295 --- Comment #1 from Jonathan Druart --- Created attachment 61225 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=61225&action=edit Bug 18295: C4::Items - get_itemnumbers_of The code from scripts and subroutines using this subroutine was not very elegant. Most of the time the code was unnecessarily complex. This patch removes this subroutine and adapt the code to use Koha::Items instead. 1. C4::Items::get_hostitemnumbers_of I did not understand why the code was so complicated, it seems that we only want to know if a given item has a given biblionumber 2. cataloguing/merge.pl We want to retrieve the itemnumber for a given biblio. We could also have done that with: Koha::Biblios->find( $biblionumber )->items; 3. labels/label-item-search.pl We want to loop over the items for a given biblio, no need to use get_itemnumbers_of and GetItemInfosOf. We just need to use: Koha::Items->search({ biblionumber => $biblionumber }) 4. reserve/request.pl We want to retrieve the itemnumbers of the biblio's items We could also have done that with: Koha::Biblios->find( $biblionumber )->items->get_column('itemnumber'); Test plan: 1.You need to create analytical record relationships ( EasyAnalyticalRecords needs to be set). Link an item to a biblio using the 'Edit > Link to host item' menu from the biblio detail page. >From the staff interface place a hold on the biblio. You should see the items from the biblio and the one you just linked 2. Merge two bibliographic records (with items), the resulting record should contain items from both original records 3. Create a new label batch, edit it. Add items to this batch ('Add items' button). Fill the input with a barcode. You should see all the items of a biblio. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Mar 17 18:28:23 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 17 Mar 2017 17:28:23 +0000 Subject: [Koha-bugs] [Bug 18296] C4::Items - Remove GetItemInfosOf In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18296 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #61224|0 |1 is obsolete| | --- Comment #2 from Jonathan Druart --- Created attachment 61226 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=61226&action=edit Bug 18296: C4::Items - Remove GetItemInfosOf At this point this subroutine is only used once, from reserve/request.pl. Since we already have the items, it's easy to populate the different hashes as the rest of the code is expecting it. Test plan: You need to create analytical record relationships ( EasyAnalyticalRecords needs to be set). Link an item to a biblio using the 'Edit > Link to host item' menu from the biblio detail page. >From the staff interface place a hold on the biblio. You should see the items from the biblio and the one you just linked -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Mar 17 18:57:08 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 17 Mar 2017 17:57:08 +0000 Subject: [Koha-bugs] [Bug 18295] C4::Items - Remove get_itemnumbers_of In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18295 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |18252 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18252 [Bug 18252] Move C4::Items code to the Koha namespace -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Mar 17 18:57:08 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 17 Mar 2017 17:57:08 +0000 Subject: [Koha-bugs] [Bug 18252] Move C4::Items code to the Koha namespace In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18252 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on| |18295, 18296 --- Comment #5 from Jonathan Druart --- Bug 18295 - C4::Items - Remove get_itemnumbers_of Bug 18296 - C4::Items - Remove GetItemInfosOf Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18295 [Bug 18295] C4::Items - Remove get_itemnumbers_of https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18296 [Bug 18296] C4::Items - Remove GetItemInfosOf -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Mar 17 18:57:08 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 17 Mar 2017 17:57:08 +0000 Subject: [Koha-bugs] [Bug 18296] C4::Items - Remove GetItemInfosOf In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18296 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |18252 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18252 [Bug 18252] Move C4::Items code to the Koha namespace -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Mar 17 19:32:41 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 17 Mar 2017 18:32:41 +0000 Subject: [Koha-bugs] [Bug 13664] Add password strength plugin In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13664 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |https://bugs.koha-community | |.org/bugzilla3/show_bug.cgi | |?id=18298 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Mar 17 19:32:41 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 17 Mar 2017 18:32:41 +0000 Subject: [Koha-bugs] [Bug 18298] New: Enforce password complexity Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18298 Bug ID: 18298 Summary: Enforce password complexity Change sponsored?: --- Product: Koha Version: unspecified Hardware: All OS: All Status: ASSIGNED Severity: enhancement Priority: P5 - low Component: Patrons Assignee: jonathan.druart at bugs.koha-community.org Reporter: jonathan.druart at bugs.koha-community.org QA Contact: testopia at bugs.koha-community.org CC: gmcharlt at gmail.com, kyle.m.hall at gmail.com Some libraries would want to add the option to Koha to enforce a strong password policy. That policy would mean that passwords should include both upper and lower case characters one or more numbers. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Mar 17 19:51:07 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 17 Mar 2017 18:51:07 +0000 Subject: [Koha-bugs] [Bug 18298] Enforce password complexity In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18298 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Mar 17 19:51:12 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 17 Mar 2017 18:51:12 +0000 Subject: [Koha-bugs] [Bug 18298] Enforce password complexity In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18298 --- Comment #1 from Jonathan Druart --- Created attachment 61227 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=61227&action=edit Bug 18298: Enforce password complexity This patchset prevents users to enter too leak password, controlled by a new syspref RequireStrongPassword. If set the staff and patrons will have to enter a strong password. The strongness cannot be modified, it has been arbitrarily set (by the author of this enhancement) to at least 1 lowercase, 1 uppercase and 1 digit. This can be inforce by increasing the value of the existing minPasswordLength pref. I decided to turn this feature on, it cannot hurt! For existing installs it will have to be turned on manually. Writing these patches I found a lot of inconsistencies all around the password checks and decided to refactor everything to make things consistent and more robust. Now the password validity is check at only one place (subroutine covered by tests). Test plan: We have several places where a password can be change/created: a. Editing a patron (members/memberentry.pl) b. Changing the password of a patron (members/member-password.pl) c. Changing your own password at the opac (opac/opac-passwd.pl). OpacPasswordChange needs to be set d. Reseting your own password at the opac (opac/opac-password-recovery.pl). OpacResetPassword needs to be set, see "Forgot your password?" link when you are not logged in e. Self registration feature, PatronSelfRegistration needs to be set. You will also need to add 'password' to PatronSelfRegistrationBorrowerMandatoryField. Note that '****' is considered by Koha internally that the password is not changed (existing behavior). To fully test this patch you will need to test the different combinations of RequireStrongPassword and minPasswordLength. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Mar 17 19:51:20 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 17 Mar 2017 18:51:20 +0000 Subject: [Koha-bugs] [Bug 18298] Enforce password complexity In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18298 --- Comment #2 from Jonathan Druart --- Created attachment 61228 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=61228&action=edit Bug 18298: Use the validate jQuery plugin To validate password fields we need to use the validate jQuery plugin. To make things reusable this patch adds a new include file 'password_check.inc' at the intranet and opac sides, it creates 3 new validation methods: - password_strong => make sure the passwords are strong enough according to the values of the RequireStrongPassword and minPasswordLength prefs - password_no_spaces => prevent passwords to be entered with leading or trailing spaces - password_match => make sure both password fields match -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Mar 17 19:51:26 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 17 Mar 2017 18:51:26 +0000 Subject: [Koha-bugs] [Bug 18298] Enforce password complexity In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18298 --- Comment #3 from Jonathan Druart --- Created attachment 61229 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=61229&action=edit Bug 18298: Move password generation to template side This patch removes a really ugly way to generate a password: the whole template was sent and parsed to retrieve the "#defaultnewpassfield" node. To avoid the password to be sent plain text it is certainly better to generate it client-side. The same kind of passwords will be generated: 0-9a-zA-Z The while loop prevents to get an invalid generated password. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Mar 17 19:51:32 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 17 Mar 2017 18:51:32 +0000 Subject: [Koha-bugs] [Bug 18298] Enforce password complexity In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18298 --- Comment #4 from Jonathan Druart --- Created attachment 61230 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=61230&action=edit Bug 18298: minPaswordLength should not be < 3 Indeed if RequireStrongPassword is set we need at least 3 characters to match 1 upper, 1 lower and 1 digit. We could make things more complicated to allow minPasswordLength < 3 but, really, 3 is already too low... -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Mar 17 19:51:37 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 17 Mar 2017 18:51:37 +0000 Subject: [Koha-bugs] [Bug 18298] Enforce password complexity In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18298 --- Comment #5 from Jonathan Druart --- Created attachment 61231 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=61231&action=edit Bug 18298: minPasswordLength should not be used as the default password length The length of the passwords generated for a patron should not be as long as the value of minPasswordLength. It is the minimum required size of a password, not the maximum! So let's fix it to 8 if the minPasswordLength if < 8, that sounds reasonable and less risky for patrons. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Mar 17 19:51:43 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 17 Mar 2017 18:51:43 +0000 Subject: [Koha-bugs] [Bug 18298] Enforce password complexity In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18298 --- Comment #6 from Jonathan Druart --- Created attachment 61232 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=61232&action=edit Bug 18298: Add server-side checks and refactor stuffs Now that we have a check client-side, nothing prevents us from a smart guy to bypass it and force an invalid password. This patch adds two new subroutines to Koha::AuthUtils to check the validity of passwords and generate a password server-side. It is used only once (self-registration) but could be useful later. Moreover the 3 different cases of password rejection (too leak, too short, contains leading or trailing whitespaces) were not tested everywhere. Now they are! This patch makes things consistent everywhere and clean up some code. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Mar 17 20:10:58 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 17 Mar 2017 19:10:58 +0000 Subject: [Koha-bugs] [Bug 18298] Enforce password complexity In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18298 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Change sponsored?|--- |Sponsored -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Mar 17 22:05:21 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 17 Mar 2017 21:05:21 +0000 Subject: [Koha-bugs] [Bug 14872] Reminder to update SMSnumber when primary phone is updated In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14872 Indranil Das Gupta changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |https://bugs.koha-community | |.org/bugzilla3/show_bug.cgi | |?id=18217 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Mar 17 22:05:21 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 17 Mar 2017 21:05:21 +0000 Subject: [Koha-bugs] [Bug 18217] SMS alert number should be grouped with other borrower contact information. In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18217 Indranil Das Gupta changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |https://bugs.koha-community | |.org/bugzilla3/show_bug.cgi | |?id=14872 CC| |indradg at l2c2.co.in -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Fri Mar 17 22:05:56 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 17 Mar 2017 21:05:56 +0000 Subject: [Koha-bugs] [Bug 11879] Add a new borrower field : main contact method. In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11879 Indranil Das Gupta changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |indradg at l2c2.co.in See Also| |https://bugs.koha-community | |.org/bugzilla3/show_bug.cgi | |?id=14872 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Mar 17 22:05:56 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 17 Mar 2017 21:05:56 +0000 Subject: [Koha-bugs] [Bug 14872] Reminder to update SMSnumber when primary phone is updated In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14872 Indranil Das Gupta changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |https://bugs.koha-community | |.org/bugzilla3/show_bug.cgi | |?id=11879 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Mar 17 22:08:13 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 17 Mar 2017 21:08:13 +0000 Subject: [Koha-bugs] [Bug 11373] Add a "cash register" feature to the fine payment form. In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11373 sandboxes at biblibre.com changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off --- Comment #20 from sandboxes at biblibre.com --- Patch tested with a sandbox, by Candice Hope -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Mar 17 22:08:31 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 17 Mar 2017 21:08:31 +0000 Subject: [Koha-bugs] [Bug 11373] Add a "cash register" feature to the fine payment form. In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11373 sandboxes at biblibre.com changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #60528|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Mar 17 22:08:38 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 17 Mar 2017 21:08:38 +0000 Subject: [Koha-bugs] [Bug 11373] Add a "cash register" feature to the fine payment form. In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11373 sandboxes at biblibre.com changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #60529|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Mar 17 22:08:46 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 17 Mar 2017 21:08:46 +0000 Subject: [Koha-bugs] [Bug 11373] Add a "cash register" feature to the fine payment form. In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11373 --- Comment #21 from sandboxes at biblibre.com --- Created attachment 61233 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=61233&action=edit Bug 11373: Add a "cash register" feature to the fine payment form. If the amount received is greater than the amount to pay, a message is shown to tell the employee how much money to give back. Signed-off-by: Joel Aloi Signed-off-by: Candice Hope -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Mar 17 22:08:51 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 17 Mar 2017 21:08:51 +0000 Subject: [Koha-bugs] [Bug 11373] Add a "cash register" feature to the fine payment form. In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11373 --- Comment #22 from sandboxes at biblibre.com --- Created attachment 61234 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=61234&action=edit Bug 11373 - Fixed: 'Change to give back' not displaying. I tested the last patch and found that the case 'amount oustanding == amount paid' was not handled in paycollect.p . The confirmation box should now appear when those values are equal and the amount collected is higher than the amount paid. I have found another problem while testing. When paying all fines or selected fines, the 'The amount collected is greater than the total amount paid.' message would appear even when the entered data was correct. Both issues were adressed in this patch. modified: koha-tmpl/intranet-tmpl/prog/en/modules/members/paycollect.tt modified: members/paycollect.pl Signed-off-by: Candice Hope -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Mar 18 02:10:52 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 18 Mar 2017 01:10:52 +0000 Subject: [Koha-bugs] [Bug 18291] Remove SQL from preferences.pl administrative script In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18291 --- Comment #1 from Alex Buckley --- Created attachment 61235 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=61235&action=edit Bug 18291 - Removed the SQL query out of admin/preferences.pl Placed a subroutine into Context.pm which in turn calls Koha::Config::SysPref.pm where the SQL query has been re-written as a DBIx query -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Mar 18 02:11:25 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 18 Mar 2017 01:11:25 +0000 Subject: [Koha-bugs] [Bug 18291] Remove SQL from preferences.pl administrative script In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18291 --- Comment #2 from Alex Buckley --- Created attachment 61236 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=61236&action=edit Bug 18291 - Fixed intranet-error log error, by changing back to using SQL query. Removed select_systempreferences subroutine from C4::Context.pm The subroutine in Koha::Config::SysPref.pm includes a successful unit test and POD -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Mar 18 02:24:34 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 18 Mar 2017 01:24:34 +0000 Subject: [Koha-bugs] [Bug 18291] Remove SQL from preferences.pl administrative script In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18291 Alex Buckley changed: What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |Needs Signoff --- Comment #3 from Alex Buckley --- Test Plan: 1. Restart memcached: sudo service memcached restart 2. Drop and recreate the Koha instance database 3. Go through the web installer, selecting all data to be installed in step 3 4. After the web installer is finished log in with the Koha database administrator credentials 5. Create yourself a patron account 6. Set the patron account to have superlibrarian privileges 7. Log out and back in as your newly created patron 8. Navigate to the Administration area 9. Write in the URL: cgi-bin/koha/admin/preferences.pl 10. Notice a table of system preferences and associated values 11. Apply all patches associated with this bug report 12. Repeat steps 1,2,3,4,5,6,7,8,9 13. Again notice the systempreference table is full of preferences and their values is displayed 14. In your terminal navigate from your Koha instance root directory to t/db_dependent 15. Enter koha shell: sudo koha-shell 16. Run sysprefs.t unit test: prove -v sysprefs.t 17. The tests should run successful 18. Exit the koha shell 19. Navigate back to your Koha instance root directory 20. View admin/preferences.pl script and observe it contains no SQL queries 21. Navigate back to your Koha instance root directory 22. View Koha/Config/SysPref.pm and notice that the select_systempreferences subroutine (the subroutine preferences.pl now calls to run the SQL query) contains POD -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Mar 18 02:31:17 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 18 Mar 2017 01:31:17 +0000 Subject: [Koha-bugs] [Bug 18299] New: Removal of SQL queries from admin/ env_tz_test.pl script into a perl module Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18299 Bug ID: 18299 Summary: Removal of SQL queries from admin/env_tz_test.pl script into a perl module Change sponsored?: --- Product: Koha Version: 17.05 Hardware: All OS: All Status: ASSIGNED Severity: enhancement Priority: P5 - low Component: Architecture, internals, and plumbing Assignee: alexbuckley at catalyst.net.nz Reporter: alexbuckley at catalyst.net.nz QA Contact: testopia at bugs.koha-community.org This bug report requires the removal of SQL queries out of the admin/env_tz_test.pl script into perl module(s) in the Koha or C4 directory. It also requires POD and unit tests for the new subroutines in the perl module(s). -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Mar 18 09:42:07 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 18 Mar 2017 08:42:07 +0000 Subject: [Koha-bugs] [Bug 17519] Item editor handles clearing dateaccessioned and replacementpricedate inconsistently In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17519 --- Comment #17 from Katrin Fischer --- Sorry Marcel, didn't want to upset you - it just felt not 'quite right' yet to me. Maybe having a separate 'created_on' column on items would be a good idea long term. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Mar 18 19:28:38 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 18 Mar 2017 18:28:38 +0000 Subject: [Koha-bugs] [Bug 16939] Making all 'add to basket' actions buttons In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16939 Owen Leonard changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Failed QA --- Comment #17 from Owen Leonard --- Please update the classes on the action buttons. Now that we have Bootstrap 3 the button classes should be "btn btn-default btn-xs" https://wiki.koha-community.org/wiki/Interface_patterns#Action_buttons_in_tables -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Mar 18 20:34:55 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 18 Mar 2017 19:34:55 +0000 Subject: [Koha-bugs] [Bug 18298] Enforce password complexity In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18298 Marc V?ron changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |veron at veron.ch --- Comment #7 from Marc V?ron --- Created attachment 61237 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=61237&action=edit Screenshots of passwort hints on OPAC self registration Tested following plan in comment #1, works great. One small thing: Hints for wrong password do not display properly on OPAC self registration, see screenshots. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Mar 18 21:13:09 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 18 Mar 2017 20:13:09 +0000 Subject: [Koha-bugs] [Bug 18298] Enforce password complexity In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18298 Marcel de Rooy changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |m.de.rooy at rijksmuseum.nl -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Mar 18 22:11:06 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 18 Mar 2017 21:11:06 +0000 Subject: [Koha-bugs] [Bug 18299] Removal of SQL queries from admin/ env_tz_test.pl script into a perl module In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18299 --- Comment #1 from Alex Buckley --- Created attachment 61238 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=61238&action=edit Bug 18299 - Moved the SQL queries from admin/env_tz_test.pl into the C4/Context.pm in two new subroutines. Both new subroutines have a successful subtest in the t/db_dependent/Context.t unit test in addition to POD. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Mar 18 22:33:01 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 18 Mar 2017 21:33:01 +0000 Subject: [Koha-bugs] [Bug 18299] Removal of SQL queries from admin/ env_tz_test.pl script into a perl module In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18299 Alex Buckley changed: What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |Needs Signoff --- Comment #2 from Alex Buckley --- Test Plan: 1. Restart memcached: sudo service memcached restart 2. Drop and recreate the Koha instance database 3. Go through the web installer, selecting all data to be installed in step 3 4. After the web installer is finished log in with the Koha database administrator credentials 5. Create yourself a patron account 6. Set the patron account to have superlibrarian privileges 7. Log out and back in as your newly created patron 8. Navigate to the Administration area 9. Write in the URL: cgi-bin/koha/admin/env_tz_test.pl 10. Notice a page titled with "Dumping ENV". Scroll down and observe the current time printed below the "Checking different TIME elements in the system" title 11. Apply all patches associated with this bug report 12. Repeat steps 1,2,3,4,5,6,7,8,9 13. Again notice the current time is displayed below the "Checking different TIME elements in the system" title 14. In your terminal navigate from your Koha instance root directory to t/db_dependent 15. Enter koha shell: sudo koha-shell 16. Run Context.t unit test: prove -v Context.t 17. The tests should run successful 18. Exit the koha shell 19. Navigate back to your Koha instance root directory 20. View admin/env_tz_test.pl script and observe it contains no SQL queries 21. Navigate back to your Koha instance root directory 22. View C4/Context.pm and notice that the get_env_variables and get_current_time subroutines (the subroutines called by env_tz_test.pl to run the SQL queries) contain POD -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Mar 19 16:50:00 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 19 Mar 2017 15:50:00 +0000 Subject: [Koha-bugs] [Bug 18300] New: Delete missing upload records Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18300 Bug ID: 18300 Summary: Delete missing upload records Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Architecture, internals, and plumbing Assignee: gmcharlt at gmail.com Reporter: m.de.rooy at rijksmuseum.nl QA Contact: testopia at bugs.koha-community.org On top of bug 17669 (deleting temporary files), we should be able to remove records too for missing upload files. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Mar 19 16:50:14 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 19 Mar 2017 15:50:14 +0000 Subject: [Koha-bugs] [Bug 18300] Delete missing upload records In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18300 Marcel de Rooy changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|gmcharlt at gmail.com |m.de.rooy at rijksmuseum.nl Status|NEW |ASSIGNED -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Mar 19 17:29:25 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 19 Mar 2017 16:29:25 +0000 Subject: [Koha-bugs] [Bug 12962] easier to see circ rule edits In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12962 Marc V?ron changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |veron at veron.ch -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Mar 19 17:31:13 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 19 Mar 2017 16:31:13 +0000 Subject: [Koha-bugs] [Bug 18125] Edit button can duplicate some circulation rule In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18125 Marc V?ron changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |veron at veron.ch -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Mar 19 17:41:06 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 19 Mar 2017 16:41:06 +0000 Subject: [Koha-bugs] [Bug 18301] New: export_records.pl from the tools menu fails with the message Internal Server Error Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18301 Bug ID: 18301 Summary: export_records.pl from the tools menu fails with the message Internal Server Error Change sponsored?: --- Product: Koha Version: 16.11 Hardware: All OS: Linux Status: NEW Severity: normal Priority: P5 - low Component: Tools Assignee: gmcharlt at gmail.com Reporter: steven.schmieder at gmail.com QA Contact: testopia at bugs.koha-community.org After applying the latest update 16.11.05.000 on three servers, one running Debian 8.7 (Jessie), the second with Debian 9 RC2 (Stretch), and the third with Ubuntu 14.04, trying to export bibliographic records from the tools menu fails with an Internal Server Error on the Debian hosts. The Ubuntu hosts returns: Software error: Can't use an undefined value as a HASH reference at /usr/share/koha/intranet/cgi-bin/tools/export.pl line 75 For help, please send mail, etc. Steven F. Schmieder -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Mar 19 22:37:13 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 19 Mar 2017 21:37:13 +0000 Subject: [Koha-bugs] [Bug 18281] Unable to import dump after upgrade to 16.11 In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18281 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |RESOLVED CC| |katrin.fischer at bsz-bw.de Resolution|--- |INVALID --- Comment #1 from Katrin Fischer --- Hi Suresh, please move your question to the mailing list - many more people are reading there that will be able to help you with this type of question. https://koha-community.org/support/community-support/ -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Mar 19 22:40:03 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 19 Mar 2017 21:40:03 +0000 Subject: [Koha-bugs] [Bug 18273] Bulkmarcimport inserts authority duplicates In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18273 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |katrin.fischer at bsz-bw.de --- Comment #2 from Katrin Fischer --- The bibliographic import overlays the one with the lower (or higher?) biblionumber. Not sure if we should make it consistent. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Mar 19 22:43:44 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 19 Mar 2017 21:43:44 +0000 Subject: [Koha-bugs] [Bug 18241] IP instead of DNS In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18241 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Resolution|--- |INVALID Status|NEW |RESOLVED CC| |katrin.fischer at bsz-bw.de --- Comment #1 from Katrin Fischer --- Hi Diva, pleas ask your question on the mailing list where a lot more people will be reading it and be able to help you: https://koha-community.org/support/community-support/ As this is not a bug or a feature wish, I am closing this INVALID. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Mar 20 08:06:26 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 20 Mar 2017 07:06:26 +0000 Subject: [Koha-bugs] [Bug 18298] Enforce password complexity In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18298 Josef Moravec changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |josef.moravec at gmail.com -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Mar 20 08:49:46 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 20 Mar 2017 07:49:46 +0000 Subject: [Koha-bugs] [Bug 17669] Add purging temporary uploads to cleanup_database In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17669 Marcel de Rooy changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |ASSIGNED -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Mar 20 08:53:35 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 20 Mar 2017 07:53:35 +0000 Subject: [Koha-bugs] [Bug 17669] Add purging temporary uploads to cleanup_database In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17669 --- Comment #11 from Marcel de Rooy --- Created attachment 61240 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=61240&action=edit Bug 17669: Small change to sub delete Instead of looping through _resultset here and wrapping the results, we should use a Koha::Objects instance. Since the method may be called as a class method, we create an instance if needed. Test plan: Run t/db_dependent/Upload.t Signed-off-by: Marcel de Rooy -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Mar 20 08:53:39 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 20 Mar 2017 07:53:39 +0000 Subject: [Koha-bugs] [Bug 17669] Add purging temporary uploads to cleanup_database In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17669 Marcel de Rooy changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #58810|0 |1 is obsolete| | --- Comment #12 from Marcel de Rooy --- Created attachment 61241 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=61241&action=edit Bug 17669: Add delete_temporary method with unit tests Test plan: Run t/db_dependent/Upload.t Signed-off-by: Marcel de Rooy -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Mar 20 08:53:31 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 20 Mar 2017 07:53:31 +0000 Subject: [Koha-bugs] [Bug 17669] Add purging temporary uploads to cleanup_database In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17669 Marcel de Rooy changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #58176|0 |1 is obsolete| | --- Comment #10 from Marcel de Rooy --- Created attachment 61239 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=61239&action=edit Bug 17669: Introduce new preference for purging temp uploads The new preference is: Upload_PurgeTemporaryFiles_Days. It controls if the cron job will delete temporary uploaded files and if so, how many days should have passed before doing so. Since the default value is empty, it will not start deleting these uploads until you change the pref. No behavior change. But the dbrev will print a message if you already have temporary uploads. Test plan: [1] Check Administration, Preferences, Tools for the new pref. [2] Run the db rev. If you have temporary uploads, check the reported count. [3] Bonus: Run sysprefs.sql in a safe environment. Signed-off-by: Marcel de Rooy -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Mar 20 08:53:43 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 20 Mar 2017 07:53:43 +0000 Subject: [Koha-bugs] [Bug 17669] Add purging temporary uploads to cleanup_database In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17669 Marcel de Rooy changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #58811|0 |1 is obsolete| | --- Comment #13 from Marcel de Rooy --- Created attachment 61242 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=61242&action=edit Bug 17669: Incorporate the changes in cleanup_database Two command line options are added: [1] -temp-uploads to indicate that you want to purge these uploads, [2] -temp-uploads-override DAYS to (optionally) tell that you want to override the corresponding pref value. Test plan: [1] Check the modified usage statement. [2] If needed, backup your temporary uploads :) In case you do not have one, add a temporary one with Tools/Upload. Note: Do not choose an upload category. [3] Set pref to 0, and run cleanup_database with only --temp-uploads. No files should be deleted. [4] Check number of "old" temp uploads. Set pref to nonzero value. Verify that the oldest are gone (depending on the value chosen). [5] Set pref to 0 again. If all uploads are gone now, add a new one with Tools/Upload. Run cleanup_database with --temp-uploads --temp-uploads-override -1 All temporary files are gone. Signed-off-by: Marcel de Rooy -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Mar 20 08:53:46 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 20 Mar 2017 07:53:46 +0000 Subject: [Koha-bugs] [Bug 17669] Add purging temporary uploads to cleanup_database In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17669 Marcel de Rooy changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #58812|0 |1 is obsolete| | --- Comment #14 from Marcel de Rooy --- Created attachment 61243 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=61243&action=edit Bug 17669: Add new switch to crontab example and debian daily cron file The new switch for deleting temporary uploads in cleanup_database can be added to cron. Note: Since the option --temp-uploads does only purge temporary uploads when triggered by the preference Upload_PurgeTemporaryFiles_Days, it can be safely added here. Test plan: There is actually nothing to test here if you followed the preceding test plans. Just verify that the switch is inserted ocrrectly. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Mar 20 08:58:32 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 20 Mar 2017 07:58:32 +0000 Subject: [Koha-bugs] [Bug 17669] Add purging temporary uploads to cleanup_database In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17669 Marcel de Rooy changed: What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |Needs Signoff --- Comment #15 from Marcel de Rooy --- Added the second patch. Ready to go again! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Mar 20 08:59:00 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 20 Mar 2017 07:59:00 +0000 Subject: [Koha-bugs] [Bug 18300] Delete missing upload records In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18300 Marcel de Rooy changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on| |17669 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17669 [Bug 17669] Add purging temporary uploads to cleanup_database -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Mar 20 08:59:00 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 20 Mar 2017 07:59:00 +0000 Subject: [Koha-bugs] [Bug 17669] Add purging temporary uploads to cleanup_database In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17669 Marcel de Rooy changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |18300 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18300 [Bug 18300] Delete missing upload records -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Mar 20 09:09:42 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 20 Mar 2017 08:09:42 +0000 Subject: [Koha-bugs] [Bug 15565] Place multiple holds at once for the same record In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15565 Alex Arnaud changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #56520|0 |1 is obsolete| | --- Comment #38 from Alex Arnaud --- Created attachment 61244 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=61244&action=edit Bz 15565 - Place multiple holds at once for the same record on staff and OPAC. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Mar 20 09:09:52 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 20 Mar 2017 08:09:52 +0000 Subject: [Koha-bugs] [Bug 15565] Place multiple holds at once for the same record In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15565 Alex Arnaud changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #56521|0 |1 is obsolete| | --- Comment #39 from Alex Arnaud --- Created attachment 61245 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=61245&action=edit Bz 15565 - CSS changes -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Mar 20 09:10:05 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 20 Mar 2017 08:10:05 +0000 Subject: [Koha-bugs] [Bug 15565] Place multiple holds at once for the same record In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15565 Alex Arnaud changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #56522|0 |1 is obsolete| | --- Comment #40 from Alex Arnaud --- Created attachment 61246 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=61246&action=edit Bug 15565: Use item's biblionumber only on item-level request -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Mar 20 09:10:16 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 20 Mar 2017 08:10:16 +0000 Subject: [Koha-bugs] [Bug 15565] Place multiple holds at once for the same record In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15565 Alex Arnaud changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #56523|0 |1 is obsolete| | --- Comment #41 from Alex Arnaud --- Created attachment 61247 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=61247&action=edit Bug 15565: Set 'found' parameter correctly when ReservesNeedReturns is off Signed-off-by: Danielle Elder -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Mar 20 09:10:30 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 20 Mar 2017 08:10:30 +0000 Subject: [Koha-bugs] [Bug 15565] Place multiple holds at once for the same record In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15565 Alex Arnaud changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #56524|0 |1 is obsolete| | --- Comment #42 from Alex Arnaud --- Created attachment 61248 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=61248&action=edit Bug 15565: Alert librarian that maximum holds per record is reached Signed-off-by: Dani Elder Signed-off-by: Danielle Elder -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Mar 20 09:12:48 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 20 Mar 2017 08:12:48 +0000 Subject: [Koha-bugs] [Bug 15565] Place multiple holds at once for the same record In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15565 Alex Arnaud changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Patch doesn't apply |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Mar 20 09:14:24 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 20 Mar 2017 08:14:24 +0000 Subject: [Koha-bugs] [Bug 18283] Display improvements on report results - hide code and change wording In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18283 Nick Clemens changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Mar 20 09:14:27 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 20 Mar 2017 08:14:27 +0000 Subject: [Koha-bugs] [Bug 18283] Display improvements on report results - hide code and change wording In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18283 Nick Clemens changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #61207|0 |1 is obsolete| | --- Comment #7 from Nick Clemens --- Created attachment 61249 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=61249&action=edit Bug 18283 - Display improvements on report results - hide code and change wording This patch makes small display improvements to the report results page. -Add toggle link for SQL code -Change results count wording -Add 'Notes:' label report notes To test: 1 - Apply patch 2 - Run some reports 3 - Check that results page makes sense 4 - Hide and display code and ensure toggle works -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Mar 20 09:39:53 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 20 Mar 2017 08:39:53 +0000 Subject: [Koha-bugs] [Bug 18300] Delete missing upload records In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18300 Marcel de Rooy changed: What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |Needs Signoff Patch complexity|--- |Small patch -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Mar 20 09:39:56 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 20 Mar 2017 08:39:56 +0000 Subject: [Koha-bugs] [Bug 18300] Delete missing upload records In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18300 --- Comment #1 from Marcel de Rooy --- Created attachment 61250 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=61250&action=edit Bug 18300: Delete missing upload records If you deleted files from the upload directories manually, or you rebooted with files in the temporary upload folder, or for some other reason have records without a file, you may want to cleanup your records in the uploaded_files table. This patch adds the method delete_missing to Koha::UploadedFiles. It also supports a keep_record parameter to do a dry run (count the missing files first). Also, we add an option --uploads-missing to cleanup_database. If you add the flag 1 after this option, you will delete missing files. If you add the flag 0 or only use the option, you will count missing files. A subtest is added to Upload.t for delete_missing tests. Test plan: [1] Run t/db_dependent/Upload.t [2] Upload a file and delete the file manually. [3] Run cleanup_database.pl --uploads-missing It should report at least one missing file now. Check that the record has not been deleted. [4] Run cleanup_database.pl --uploads-missing 1 It should report that it removed at least one file. Check that the record is gone. Signed-off-by: Marcel de Rooy -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Mar 20 09:39:58 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 20 Mar 2017 08:39:58 +0000 Subject: [Koha-bugs] [Bug 8010] Search history can be added to the wrong patron In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8010 --- Comment #14 from Baptiste --- Created attachment 61251 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=61251&action=edit BUG 8010: Removed Auth2.t -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Mar 20 09:53:14 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 20 Mar 2017 08:53:14 +0000 Subject: [Koha-bugs] [Bug 17624] Add Staff Collection status for items in C4::XSLT In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17624 Marcel de Rooy changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |BLOCKED --- Comment #14 from Marcel de Rooy --- Blocking this patch until a marvel(l)ous idea comes up.. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Mar 20 09:56:16 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 20 Mar 2017 08:56:16 +0000 Subject: [Koha-bugs] [Bug 18273] Bulkmarcimport inserts authority duplicates In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18273 --- Comment #3 from Matthias Meusburger --- Are you sure about that Katrin? >From what I've seen, the behaviour is the same for biblios: if multiple matching biblios have been found, a new biblio is inserted. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Mar 20 10:00:05 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 20 Mar 2017 09:00:05 +0000 Subject: [Koha-bugs] [Bug 18273] Bulkmarcimport inserts authority duplicates In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18273 --- Comment #4 from Katrin Fischer --- Hm, I was pretty sure, but was thinking of the staged marc tool. Didn't realize then it will probably be different for bulkmarcimport. Makes sense then. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Mar 20 10:42:14 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 20 Mar 2017 09:42:14 +0000 Subject: [Koha-bugs] [Bug 18302] New: Release team 17.05 Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18302 Bug ID: 18302 Summary: Release team 17.05 Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: About Assignee: nengard at gmail.com Reporter: m.de.rooy at rijksmuseum.nl QA Contact: testopia at bugs.koha-community.org -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Mar 20 10:42:51 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 20 Mar 2017 09:42:51 +0000 Subject: [Koha-bugs] [Bug 18303] New: Release team omnibus Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18303 Bug ID: 18303 Summary: Release team omnibus Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: About Assignee: nengard at gmail.com Reporter: m.de.rooy at rijksmuseum.nl QA Contact: testopia at bugs.koha-community.org -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Mar 20 10:43:37 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 20 Mar 2017 09:43:37 +0000 Subject: [Koha-bugs] [Bug 18302] Release team 17.05 In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18302 --- Comment #1 from Marcel de Rooy --- Created attachment 61252 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=61252&action=edit Bug 18302: Release team 17.05 Changes to about.tt in sections release team and development team. Notes: [1] We do not have a QA manager in 17.05 any more. [2] Martin Renvoize has been added to the QA team of 16.11 after the election; this was not adjusted in about, but has been added in the Development team section now. Test plan: Compare about:Koha team with roles for 17.05 page on the wiki. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Mar 20 10:43:34 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 20 Mar 2017 09:43:34 +0000 Subject: [Koha-bugs] [Bug 18302] Release team 17.05 In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18302 Marcel de Rooy changed: What |Removed |Added ---------------------------------------------------------------------------- Patch complexity|--- |String patch Status|NEW |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Mar 20 10:43:53 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 20 Mar 2017 09:43:53 +0000 Subject: [Koha-bugs] [Bug 18302] Release team 17.05 In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18302 Marcel de Rooy changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|nengard at gmail.com |m.de.rooy at rijksmuseum.nl -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Mar 20 10:45:23 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 20 Mar 2017 09:45:23 +0000 Subject: [Koha-bugs] [Bug 18283] Display improvements on report results - hide code and change wording In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18283 Marc V?ron changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #61249|0 |1 is obsolete| | --- Comment #8 from Marc V?ron --- Created attachment 61253 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=61253&action=edit Bug 18283 - Display improvements on report results - hide code and change wording This patch makes small display improvements to the report results page. -Add toggle link for SQL code -Change results count wording -Add 'Notes:' label report notes To test: 1 - Apply patch 2 - Run some reports 3 - Check that results page makes sense 4 - Hide and display code and ensure toggle works Followed test plan, works as expected. Signed-off-by: Marc V?ron -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Mar 20 10:45:50 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 20 Mar 2017 09:45:50 +0000 Subject: [Koha-bugs] [Bug 18302] Release team 17.05 In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18302 Marcel de Rooy changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |18303 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18303 [Bug 18303] Release team omnibus -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Mar 20 10:45:50 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 20 Mar 2017 09:45:50 +0000 Subject: [Koha-bugs] [Bug 18303] Release team omnibus In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18303 Marcel de Rooy changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on| |18302 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18302 [Bug 18302] Release team 17.05 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Mar 20 10:45:55 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 20 Mar 2017 09:45:55 +0000 Subject: [Koha-bugs] [Bug 18283] Display improvements on report results - hide code and change wording In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18283 Marc V?ron changed: What |Removed |Added ---------------------------------------------------------------------------- Patch complexity|--- |Small patch Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Mar 20 10:47:24 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 20 Mar 2017 09:47:24 +0000 Subject: [Koha-bugs] [Bug 18303] Release team omnibus In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18303 Marcel de Rooy changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|nengard at gmail.com |m.de.rooy at rijksmuseum.nl Status|NEW |ASSIGNED -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Mar 20 10:48:49 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 20 Mar 2017 09:48:49 +0000 Subject: [Koha-bugs] [Bug 7143] Bug for tracking changes to the about page In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7143 Marcel de Rooy changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |https://bugs.koha-community | |.org/bugzilla3/show_bug.cgi | |?id=18303 --- Comment #363 from Marcel de Rooy --- Added bug 18303 for release team omnibus. And 18302 contains the 17.05 release team. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Mar 20 10:48:49 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 20 Mar 2017 09:48:49 +0000 Subject: [Koha-bugs] [Bug 18303] Release team omnibus In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18303 Marcel de Rooy changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |https://bugs.koha-community | |.org/bugzilla3/show_bug.cgi | |?id=7143 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Mar 20 10:57:20 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 20 Mar 2017 09:57:20 +0000 Subject: [Koha-bugs] [Bug 17708] Renewal log seems empty In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17708 jmbroust changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |jean-manuel.broust at univ-lyo | |n2.fr Status|Needs Signoff |Patch doesn't apply --- Comment #17 from jmbroust --- The sandbox you've requested is not ready. Some problems occurred applying patches from bug 17708:

    Something went wrong !

    Applying: BUG 17708: Added a logaction function in Addrenewal in order to send renew logs Using index info to reconstruct a base tree... M C4/Circulation.pm M installer/data/mysql/sysprefs.sql M t/db_dependent/Circulation.t Falling back to patching base and 3-way merge... Auto-merging t/db_dependent/Circulation.t CONFLICT (content): Merge conflict in t/db_dependent/Circulation.t Auto-merging installer/data/mysql/sysprefs.sql Auto-merging C4/Circulation.pm Patch failed at 0001 BUG 17708: Added a logaction function in Addrenewal in order to send renew logs The copy of the patch that failed is found in: .git/rebase-apply/patch When you have resolved this problem run git bz apply --continue. If you would prefer to skip this patch, instead run git bz apply --skip. To restore the original branch and stop patching run git bz apply --abort. error: Failed to merge in the changes. Bug 17708 - Renewal log seems empty 60641 - BUG 17708: Added a logaction function in Addrenewal in order to send renew logs Apply? [(y)es, (n)o, (i)nteractive] Patch left in tmpBUG-17708-Added-a-logaction-function-in-Addrenewal-dBVGdR.patch . -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Mar 20 10:59:52 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 20 Mar 2017 09:59:52 +0000 Subject: [Koha-bugs] [Bug 18242] Remove primary key on old_issues.issue_id In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18242 Nick Clemens changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Mar 20 10:59:55 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 20 Mar 2017 09:59:55 +0000 Subject: [Koha-bugs] [Bug 18242] Remove primary key on old_issues.issue_id In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18242 Nick Clemens changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #61056|0 |1 is obsolete| | --- Comment #9 from Nick Clemens --- Created attachment 61254 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=61254&action=edit Bug 18242: [SOLUTION 2]Add tests Signed-off-by: Chris Cormack Signed-off-by: Nick Clemens -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Mar 20 11:00:01 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 20 Mar 2017 10:00:01 +0000 Subject: [Koha-bugs] [Bug 18242] Remove primary key on old_issues.issue_id In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18242 Nick Clemens changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #61057|0 |1 is obsolete| | --- Comment #10 from Nick Clemens --- Created attachment 61255 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=61255&action=edit Bug 18242: [SOLUTION 2]Handle correctly move to old_issues The table old_issues has a primary key defined on the issue_id column. This issue_id comes from the issues table when an item is checked in. In some case the value of issue_id already exists in the table Basically this happens when an item is returned and mysqld is restarted: The auto increment value for issues.issue_id will be reset to MAX(issue_id)+1 (which is the value of the last entry of old_issues). See also the description of bug 18003 for more informations. In this solution the change is done at code level instead of DB structure: If old_issues.issue_id already exists before moving from the issues table, the issue_id is updated (not on cascade for accountlines.issue_id, should it?) before the move. Signed-off-by: Chris Cormack Signed-off-by: Nick Clemens -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Mar 20 11:01:24 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 20 Mar 2017 10:01:24 +0000 Subject: [Koha-bugs] [Bug 18242] Remove primary key on old_issues.issue_id In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18242 Nick Clemens changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |nick at bywatersolutions.com --- Comment #11 from Nick Clemens --- This works in all testing I tried, it does seem that if things get out of sync the ids will be updated for most returns and never get back into sync, however, I can't think of any reason issue_id needs to be static so seems fine -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Mar 20 11:07:33 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 20 Mar 2017 10:07:33 +0000 Subject: [Koha-bugs] [Bug 8548] Add callnumber sort option to overdue report In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8548 Nick Clemens changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |nick at bywatersolutions.com --- Comment #9 from Nick Clemens --- I think you are right Jonathan, once the results are exported the end user can sort in whichever program they use. These patches are a nice improvement on the overdues screen -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Mar 20 11:10:56 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 20 Mar 2017 10:10:56 +0000 Subject: [Koha-bugs] [Bug 8010] Search history can be added to the wrong patron In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8010 Marc V?ron changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #60187|0 |1 is obsolete| | --- Comment #15 from Marc V?ron --- Created attachment 61256 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=61256&action=edit Added a new syspref to Load history to the next user Added a syspref LoadHistory addSearchHistoryToTheFirstLoggedUser to select if you want the system to add the history of searches performed without session when you log in as registered user. TEST PLAN 1 - Search in the catalogue, check you are not logged 2 - Log in : your last history should appear 4 - Log out 5 - Apply the patch 6 - Repeat 1 and 2 7 - Desactivate the syspref addSearchHistoryToTheFirstLoggedUser 8 - Repeat 1 and 2 : your last history shouldn't appear The Unit test doesn't rollback but delete the added lines : the function get_template_and_user allway sets the autocommit to 1. https://bugs.koha-community.org/show_bug.cgi?id=8010 Tested 3 patches together, works as expected. Signed-off-by: Marc V?ron -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Mar 20 11:11:50 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 20 Mar 2017 10:11:50 +0000 Subject: [Koha-bugs] [Bug 8010] Search history can be added to the wrong patron In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8010 Marc V?ron changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #61223|0 |1 is obsolete| | --- Comment #16 from Marc V?ron --- Created attachment 61257 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=61257&action=edit BUG 8010: Correct a few syntax errors, and moved tests - Tests are now in t/db_dependent/Search/History.t - There were 2 differents sysprefs in sysprefs.sql and in atomicupdate => fixed Signed-off-by: Marc V?ron -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Mar 20 11:13:24 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 20 Mar 2017 10:13:24 +0000 Subject: [Koha-bugs] [Bug 8010] Search history can be added to the wrong patron In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8010 Marc V?ron changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #61251|0 |1 is obsolete| | --- Comment #17 from Marc V?ron --- Created attachment 61258 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=61258&action=edit BUG 8010: Removed Auth2.t Signed-off-by: Marc V?ron -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Mar 20 11:14:39 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 20 Mar 2017 10:14:39 +0000 Subject: [Koha-bugs] [Bug 8010] Search history can be added to the wrong patron In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8010 Marc V?ron changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Mar 20 11:19:27 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 20 Mar 2017 10:19:27 +0000 Subject: [Koha-bugs] [Bug 18018] WWW:CSRF is missing in PerlDependencies.pm In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18018 Mirko Tietgen changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to Master |Pushed to Stable -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Mar 20 11:34:02 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 20 Mar 2017 10:34:02 +0000 Subject: [Koha-bugs] [Bug 11879] Add a new borrower field : main contact method. In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11879 Jesse Maseto changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |jesse at bywatersolutions.com Status|Needs Signoff |Patch doesn't apply --- Comment #85 from Jesse Maseto --- This patch does not apply. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Mar 20 11:35:18 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 20 Mar 2017 10:35:18 +0000 Subject: [Koha-bugs] [Bug 18301] export_records.pl from the tools menu fails with the message Internal Server Error In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18301 Marc V?ron changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |veron at veron.ch --- Comment #1 from Marc V?ron --- Confirmed on current master. To reproduce: - Go to Home > Tools > Export data - Choose tab 'Export bibliographic records' or 'Export authority records' - Click 'Export (...)' Result for both: 'Internal server error' Plack error log says: Can't use an undefined value as a HASH reference at /usr/share/koha/intranet/cgi-bin/tools/export.pl line 75 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Mar 20 11:42:19 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 20 Mar 2017 10:42:19 +0000 Subject: [Koha-bugs] [Bug 18256] Koha::Biblio - Remove GetItemsCount In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18256 Nick Clemens changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #61120|0 |1 is obsolete| | --- Comment #8 from Nick Clemens --- Created attachment 61259 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=61259&action=edit Bug 18256: Koha::Items - Remove GetItemsCount C4::Items::GetItemsCount can be replaced with Koha::Biblio->items->count Test plan: Create a bibliographic record with items attached Try to delete the record from a basket (acquisition module), the detail page and the batch item deletion tool. => You should not be able to delete it. Remove the items and then try again to delete the record => Now you must be able to delete it. Followed test plan, works as expected. Signed-off-by: Marc V?ron Signed-off-by: Nick Clemens -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Mar 20 11:42:16 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 20 Mar 2017 10:42:16 +0000 Subject: [Koha-bugs] [Bug 18256] Koha::Biblio - Remove GetItemsCount In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18256 Nick Clemens changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Mar 20 11:43:01 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 20 Mar 2017 10:43:01 +0000 Subject: [Koha-bugs] [Bug 17233] Add 008 value builder plugin for MARC21 classifications In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17233 Marcel de Rooy changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #58716|0 |1 is obsolete| | --- Comment #7 from Marcel de Rooy --- Created attachment 61260 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=61260&action=edit Bug 17233 - Add 008 value builder plugin for MARC21 classifications This patch adds 008 cataloguing value builder for MARC21 classifications records (LCC, DDC/Dewey, UDC and so on). For most practical purposes, MARC21 classification records () are quite similar to regular MARC21 authority records, so handling them in Koha is (almost) achievable by means of the built-in 'regular' MARC21 authority records related functionalities, but there are some notable differences - in particular, 008 field length and format is not the same. To test: 1) apply patch 2) link the new plugin (marc21_field_008_classifications.pl) to the 008 field in the existing (or cloned, ..) authority framework of your choice 3) try to add, edit, re-edit 008 field using this "authority" framework, ensure that the new plugin behaves as it should according to the Library of Congress specifications for MARC21 classification records 008 field format (). Signed-off-by: Mark Tompsett Signed-off-by: Marcel de Rooy -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Mar 20 11:42:58 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 20 Mar 2017 10:42:58 +0000 Subject: [Koha-bugs] [Bug 17233] Add 008 value builder plugin for MARC21 classifications In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17233 Marcel de Rooy changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |Signed Off -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Mar 20 11:44:03 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 20 Mar 2017 10:44:03 +0000 Subject: [Koha-bugs] [Bug 17233] Add 008 value builder plugin for MARC21 classifications In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17233 --- Comment #8 from Marcel de Rooy --- (In reply to Jacek Ablewicz from comment #6) > But, as Katrin said, for such "classification authority records" to be fully > functional in Koha, apart from user-configurable stuff like frameworks, > zebra indexes etc., you need to make some changes (additions) in the code > too: > > - C4/Heading/MARC21.pm > - C4/AuthoritiesMarc.pm > > because tag numbers and subfields for a given authority types are hard coded > in there. For example (we are using UDC numerical classification in here), > we needed to add definitions for 080 and 153 tags in aforementioned files, > because they were not supported by default. Would these adjustments be interesting too for the community? -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Mar 20 11:45:17 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 20 Mar 2017 10:45:17 +0000 Subject: [Koha-bugs] [Bug 17233] Add 008 value builder plugin for MARC21 classifications In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17233 Marcel de Rooy changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA --- Comment #9 from Marcel de Rooy --- Passing QA on this patch with reference to the discussion above. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Mar 20 11:48:00 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 20 Mar 2017 10:48:00 +0000 Subject: [Koha-bugs] [Bug 9988] Leave larger authority merges to merge_authorities cronjob ( pref AuthorityMergeLimit) In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9988 --- Comment #39 from Jacek Ablewicz --- For "real" merge usage case (merging two different authority records), if the merge gets postponed, when merge() is called later by the cron job, authority record with $mergefrom ID is no longer there (it got deleted from the database by authorities/merge.pl script ?). This search in postponed merge() call my $authfrom = Koha::Authorities->find($mergefrom); will fail, and $authtypefrom | $auth_tag_to_report_from | @record_from would be empty. I.e.: old authority record heading, stored in the merge requests table will never be used. (but there is a strong possibility I'm very much mistaken about that, authorities-related code got changed quite a lot lately). -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Mar 20 11:49:52 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 20 Mar 2017 10:49:52 +0000 Subject: [Koha-bugs] [Bug 18246] Patron card creator: Units not always display properly in layouts In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18246 Jesse Maseto changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #61011|0 |1 is obsolete| | --- Comment #2 from Jesse Maseto --- Created attachment 61261 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=61261&action=edit Bug 18246: Patron card creator: Unit not always displays properly in layouts To reproduce: 1) Create a new layout 2) Select an unit in "Units selection" 3) Save 4) Edit layout again 5) Select other unit, e.g. 'SI Centimeter' 6) Save 7) Repeat 8) Edit again Error: Latest unit seems to stick and can no longer be changed, because in units drop down, multiple untis are marked as selected. To test: 1) Apply patch 2) Repeat steps above, verify that value for units always display as expected. Signed-off-by: Jesse Maseto -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Mar 20 11:49:47 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 20 Mar 2017 10:49:47 +0000 Subject: [Koha-bugs] [Bug 18246] Patron card creator: Units not always display properly in layouts In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18246 Jesse Maseto changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Mar 20 11:52:08 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 20 Mar 2017 10:52:08 +0000 Subject: [Koha-bugs] [Bug 18251] SCO alerts - need a trigger for successful checkouts In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18251 --- Comment #6 from Nick Clemens --- Created attachment 61262 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=61262&action=edit Bug 18251 (QA Followup) Add alert box to checkout message -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Mar 20 11:53:10 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 20 Mar 2017 10:53:10 +0000 Subject: [Koha-bugs] [Bug 9988] Leave larger authority merges to merge_authorities cronjob ( pref AuthorityMergeLimit) In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9988 --- Comment #40 from Marcel de Rooy --- (In reply to Jacek Ablewicz from comment #39) > For "real" merge usage case (merging two different authority records), if > the merge gets postponed, when merge() is called later by the cron job, > authority record with $mergefrom ID is no longer there (it got deleted from > the database by authorities/merge.pl script ?). This search in postponed > merge() call > > my $authfrom = Koha::Authorities->find($mergefrom); > > will fail, and $authtypefrom | $auth_tag_to_report_from | @record_from would > be empty. I.e.: old authority record heading, stored in the merge requests > table will never be used. > > (but there is a strong possibility I'm very much mistaken about that, > authorities-related code got changed quite a lot lately). The code is designed to overcome this situation. There are tests simulating it too. Take a look :) -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Mar 20 11:54:58 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 20 Mar 2017 10:54:58 +0000 Subject: [Koha-bugs] [Bug 9988] Leave larger authority merges to merge_authorities cronjob ( pref AuthorityMergeLimit) In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9988 --- Comment #41 from Marcel de Rooy --- Especially the "Few subtle changes" patch makes a few additional refinements in this regard. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Mar 20 12:03:01 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 20 Mar 2017 11:03:01 +0000 Subject: [Koha-bugs] [Bug 12063] Change date calculation for reserve expiration to skip all holidays In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12063 --- Comment #39 from Alex Arnaud --- (In reply to Andreas Hedstr?m Mace from comment #37) > Tested and everything works as intended, except that it is not possible to > cancel holds with the cronjob in > misc/cronjobs/holds/cancel_expired_holds.pl, and thus not possible to set a > cancelation fee. > > However, with the ExpireReservesOnHolidays syspref set to allow, and without > ExcludeHolidaysFromMaxPickUpDelay (set to don?t allow), the hold is > cancelled and sets the fee. > > I don't think this is the desired behaviour (one might want to exclude > holidays but still apply a fee for those who doesn?t pick up a reserved > book), so I'm setting this to patch doesn't apply. > > If someone disagrees, feel free to change the status. Hello Andreas, I didn't managed to reproduce this issue. I have an expired hold. ExpireReservesOnHolidays is set to "don't allow". ExcludeHolidaysFromMaxPickUpDelay is set to "allow", i'm not on a holiday period and ExpireReservesMaxPickUpDelayCharge is set to 11. Launch misc/cronjobs/holds/cancel_expired_holds.pl: 1) hold is canceled, 2) related borrower is charged -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Mar 20 12:07:10 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 20 Mar 2017 11:07:10 +0000 Subject: [Koha-bugs] [Bug 18134] Batch authority record modification Preview MARC button needs updating In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18134 sandboxes at biblibre.com changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off CC| |sandboxes at biblibre.com --- Comment #2 from sandboxes at biblibre.com --- Patch tested with a sandbox, by JMBroust -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Mar 20 12:07:22 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 20 Mar 2017 11:07:22 +0000 Subject: [Koha-bugs] [Bug 18134] Batch authority record modification Preview MARC button needs updating In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18134 sandboxes at biblibre.com changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #60369|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Mar 20 12:07:29 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 20 Mar 2017 11:07:29 +0000 Subject: [Koha-bugs] [Bug 18134] Batch authority record modification Preview MARC button needs updating In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18134 --- Comment #3 from sandboxes at biblibre.com --- Created attachment 61263 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=61263&action=edit Bug 18134: Updating Preview MARC button in Batch Authority Record Mod This patch ensures the Preview MARC button when batch modifying authority records looks like the Preview MARC button when batch modifying biblio records. To test: 1) Go to Tools -> Batch record modification 2) Leave record type as Biblio, Put in a biblionumber, select a template and click Continue 3) Notice the 'Show MARC' button 4) Click Cancel and change record type to Authority. Put in auth id, select template, click Continue 5) Notice ugly 'Preview MARC' link 6) Apply patch and refresh page 7) There should now be a nice 'Show MARC' button like there is for biblio mod. Confirm it still works as expected. Sponsored-by: Catalyst IT Signed-off-by: JMBroust -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Mar 20 12:11:04 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 20 Mar 2017 11:11:04 +0000 Subject: [Koha-bugs] [Bug 12026] Shibboleth auto-provisioning In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12026 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |Signed Off --- Comment #29 from Martin Renvoize --- Perfect Mirko, thanks for cleaning up the rebase. Setting back to SO. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Mar 20 12:12:17 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 20 Mar 2017 11:12:17 +0000 Subject: [Koha-bugs] [Bug 12026] Shibboleth auto-provisioning In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12026 --- Comment #30 from Martin Renvoize --- Just to clarify.. seems I've even been running Mirko's follow-up in production here on a couple of systems since they were done.. sorry for not having signed them off.. must have slipped through the net :( -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Mar 20 12:14:49 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 20 Mar 2017 11:14:49 +0000 Subject: [Koha-bugs] [Bug 8612] CSV export profile to have custom fields in export csv basket In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8612 Josef Moravec changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #60480|0 |1 is obsolete| | --- Comment #71 from Josef Moravec --- Created attachment 61264 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=61264&action=edit Bug 8612: Use CSV profile for exporting basket This patch allows the user to use a CSV export profile to create the fields to export the basket as CSV in a basket page. Test plan: 1) Apply the patch 2) Go to Tools ? CSV export profiles and create a profile of type "SQL for basket export in acquisition" example: biblionumber=biblio.biblionumber|auteur=biblio.author|titre=biblio.title|date=biblioitems.copyrightdate|editeur=biblioitems.publishercode|isbn=biblioitems.isbn|quantite=aqorders.quantity|prix=aqorders.rrp|panier=aqorders.basketno 3) In acquisition module, create a new basket and add an order to the basket 4) On basket detail page, there should be the split button labelled "Export to CSV" 5) Try to use the button and export CSV with your CSV profile you defined in step 2 6) Validate the CSV file. 7) Repeat 4-6 with a closed basket. a) close the basket b) View the basket c) validate that there is an export button d) test it with an export 8) prove t/db_dependent/Acquisition/GetBasketAsCSV.t t/db_dependent/Koha/CsvProfiles.t Initial work: Sponsored by: CCSR Signed-off-by: Josef Moravec Signed-off-by: mehdi -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Mar 20 12:14:59 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 20 Mar 2017 11:14:59 +0000 Subject: [Koha-bugs] [Bug 8612] CSV export profile to have custom fields in export csv basket In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8612 --- Comment #72 from Josef Moravec --- Created attachment 61265 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=61265&action=edit Bug 8612: QA-followup - Fix test -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Mar 20 12:15:06 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 20 Mar 2017 11:15:06 +0000 Subject: [Koha-bugs] [Bug 8612] CSV export profile to have custom fields in export csv basket In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8612 --- Comment #73 from Josef Moravec --- Created attachment 61266 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=61266&action=edit Bug 8612: QA followup - make usage and type different columns in db -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Mar 20 12:15:12 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 20 Mar 2017 11:15:12 +0000 Subject: [Koha-bugs] [Bug 8612] CSV export profile to have custom fields in export csv basket In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8612 --- Comment #74 from Josef Moravec --- Created attachment 61267 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=61267&action=edit Bug 8612: QA followup - update dbix schema -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Mar 20 12:15:48 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 20 Mar 2017 11:15:48 +0000 Subject: [Koha-bugs] [Bug 12026] Shibboleth auto-provisioning In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12026 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #57563|0 |1 is obsolete| | --- Comment #31 from Martin Renvoize --- Created attachment 61268 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=61268&action=edit BUG 12026: Adds auto-provisioning to shibboleth - Adds the option to map shibboleth attributes to koha user columns and allows mapping to auto create non-existant users Signed-off-by: Mirko Tietgen Signed-off-by: Martin Renvoize -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Mar 20 12:15:55 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 20 Mar 2017 11:15:55 +0000 Subject: [Koha-bugs] [Bug 12026] Shibboleth auto-provisioning In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12026 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #57564|0 |1 is obsolete| | --- Comment #32 from Martin Renvoize --- Created attachment 61269 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=61269&action=edit BUG 12026, Follow up: Added Documentation BUG 12026, Follow up: Updated to work with match point selection - The base bug that this patch enhances has added the ability to choose your match point in the configuration file. This patch adds code to take that change into account. Signed-off-by: Mirko Tietgen Signed-off-by: Martin Renvoize -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Mar 20 12:16:09 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 20 Mar 2017 11:16:09 +0000 Subject: [Koha-bugs] [Bug 12026] Shibboleth auto-provisioning In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12026 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #57566|0 |1 is obsolete| | --- Comment #34 from Martin Renvoize --- Created attachment 61271 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=61271&action=edit Bug 12026 Fix small errors When running tests I got two errors. Do these changes make sense? Signed-off-by: Martin Renvoize -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Mar 20 12:16:02 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 20 Mar 2017 11:16:02 +0000 Subject: [Koha-bugs] [Bug 12026] Shibboleth auto-provisioning In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12026 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #57565|0 |1 is obsolete| | --- Comment #33 from Martin Renvoize --- Created attachment 61270 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=61270&action=edit BUG 12026: Followup Rebasing Signed-off-by: Mirko Tietgen Signed-off-by: Martin Renvoize -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Mar 20 12:17:00 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 20 Mar 2017 11:17:00 +0000 Subject: [Koha-bugs] [Bug 12026] Shibboleth auto-provisioning In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12026 --- Comment #35 from Martin Renvoize --- Added signoff line to signify that I've checked the rebase and followup added by Mirko :) -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Mar 20 12:21:00 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 20 Mar 2017 11:21:00 +0000 Subject: [Koha-bugs] [Bug 8612] CSV export profile to have custom fields in export csv basket In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8612 Josef Moravec changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |Signed Off --- Comment #75 from Josef Moravec --- (In reply to Marcel de Rooy from comment #70) > (In reply to Jonathan Druart from comment #69) > > I have the feeling that there is a design issue. I'd have let the type="sql" > > but add another DB field ('usage' or similar) to identify how the profile > > can be used. > > I agree with Jonathan. > Although I acknowledge that this patch already has quite a history already. > > Export format is the name of the table for the CSV profiles (this is already > confusing btw). Actually, csv profiles would be a better name. > The column type should be either marc or sql: we refer to marc fields or > database columns. > But yes, we need an additional column where to use which profile. Probably > we can start here with the simple list we have now. Could be expanded later.. > > About t/db_dependent/Acquisition/GetBasketAsCSV.t: > Remove the dbh statements. You do not need them. You use schema txn.. > You pass a new CGI object in your test. You probably can; just wondering if > you should mock C4::Languages::getlanguage and not use CGI here. > Typo defautl So, I rebased the patch on top of current master and added some followups. Changes made - - revert the changes in csv profile types so there are again only two - marc and sql - added new db column used_for, which should say where the profile could be used - fix typo and remove dbh from test GetBasketAsCSV.t How do you think the mocked getlanguage could be used? The soubroutine GetBasketAsCSV does need the CGI object as a param... -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Mar 20 12:24:00 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 20 Mar 2017 11:24:00 +0000 Subject: [Koha-bugs] [Bug 18264] Course reserves - use itemnumber for editing existing reserve items In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18264 Nick Clemens changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |Signed Off -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Mar 20 12:24:03 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 20 Mar 2017 11:24:03 +0000 Subject: [Koha-bugs] [Bug 18264] Course reserves - use itemnumber for editing existing reserve items In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18264 --- Comment #6 from Nick Clemens --- Created attachment 61272 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=61272&action=edit Bug 18264 - (QA Followup) Remove use of GetBiblioFromItemNumber Replace with (blank) -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Mar 20 12:26:33 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 20 Mar 2017 11:26:33 +0000 Subject: [Koha-bugs] [Bug 18264] Course reserves - use itemnumber for editing existing reserve items In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18264 --- Comment #7 from Nick Clemens --- (In reply to Jonathan Druart from comment #5) > > +my $item = GetBiblioFromItemNumber( $itemnumber, $barcode ); > This is wrong, this subroutine uses only one parameter (also see bug 18276). Removed > hum? ? In case of itemnumber lookup (no barcode) we display '(blank)' for barcode and itemnumber after > How do we reach that? As above case - it shouldn't happen, but makes for a nice error if someone messes up the link example with bad itemnumber: http://localhost:8081/cgi-bin/koha/course_reserves/add_items.pl?course_id=11&itemnumber=123456789123456798&action=lookup&return=11 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Mar 20 12:28:09 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 20 Mar 2017 11:28:09 +0000 Subject: [Koha-bugs] [Bug 18243] Bug 16034 follow-up: better handling of absence of WebService: :ILS::OverDrive::Patron at testing In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18243 Mirko Tietgen changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |mirko at abunchofthings.net --- Comment #9 from Mirko Tietgen --- Fixes the problem for the nightly builds too, please push. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Mar 20 12:38:13 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 20 Mar 2017 11:38:13 +0000 Subject: [Koha-bugs] [Bug 7534] New OPACAllowUserToChooseBranch setting for only showing libraries allowing holds In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7534 sandboxes at biblibre.com changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off CC| |sandboxes at biblibre.com --- Comment #42 from sandboxes at biblibre.com --- Patch tested with a sandbox, by Koha Team AMU -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Mar 20 12:38:51 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 20 Mar 2017 11:38:51 +0000 Subject: [Koha-bugs] [Bug 7534] New OPACAllowUserToChooseBranch setting for only showing libraries allowing holds In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7534 sandboxes at biblibre.com changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #60878|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Mar 20 12:38:57 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 20 Mar 2017 11:38:57 +0000 Subject: [Koha-bugs] [Bug 7534] New OPACAllowUserToChooseBranch setting for only showing libraries allowing holds In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7534 sandboxes at biblibre.com changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #60879|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Mar 20 12:39:02 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 20 Mar 2017 11:39:02 +0000 Subject: [Koha-bugs] [Bug 7534] New OPACAllowUserToChooseBranch setting for only showing libraries allowing holds In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7534 sandboxes at biblibre.com changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #60880|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Mar 20 12:39:09 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 20 Mar 2017 11:39:09 +0000 Subject: [Koha-bugs] [Bug 7534] New OPACAllowUserToChooseBranch setting for only showing libraries allowing holds In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7534 sandboxes at biblibre.com changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #60881|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Mar 20 12:39:15 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 20 Mar 2017 11:39:15 +0000 Subject: [Koha-bugs] [Bug 7534] New OPACAllowUserToChooseBranch setting for only showing libraries allowing holds In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7534 sandboxes at biblibre.com changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #60882|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Mar 20 12:39:21 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 20 Mar 2017 11:39:21 +0000 Subject: [Koha-bugs] [Bug 7534] New OPACAllowUserToChooseBranch setting for only showing libraries allowing holds In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7534 sandboxes at biblibre.com changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #60883|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Mar 20 12:39:27 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 20 Mar 2017 11:39:27 +0000 Subject: [Koha-bugs] [Bug 7534] New OPACAllowUserToChooseBranch setting for only showing libraries allowing holds In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7534 sandboxes at biblibre.com changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #61046|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Mar 20 12:39:32 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 20 Mar 2017 11:39:32 +0000 Subject: [Koha-bugs] [Bug 7534] New OPACAllowUserToChooseBranch setting for only showing libraries allowing holds In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7534 sandboxes at biblibre.com changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #61047|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Mar 20 12:39:40 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 20 Mar 2017 11:39:40 +0000 Subject: [Koha-bugs] [Bug 7534] New OPACAllowUserToChooseBranch setting for only showing libraries allowing holds In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7534 --- Comment #43 from sandboxes at biblibre.com --- Created attachment 61273 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=61273&action=edit Bug 7534: Add new column "pickup_location" to branches This patch adds a new column "pickup_location" for each library. This value defines whether a library can be used as a pickup location or not. For extended configurability, this flag could perhaps be considered as a part of issuing rules, but as of now, this patch only offers a simple flag into each library. This method also allows easy way for REST API to determine valid pickup locations by querying the /libraries endpoint. To test: 1. perl installer/data/mysql/updatedatabase.pl 2. Observe DEV atomic update: bug_7534.perl Upgrade to XXX done (Bug 7534 - Let libraries have configuration for pickup locations) https://bugs.koha-community.org/show_bug.cgi?id=7354 Signed-off-by: Koha Team AMU -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Mar 20 12:39:44 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 20 Mar 2017 11:39:44 +0000 Subject: [Koha-bugs] [Bug 7534] New OPACAllowUserToChooseBranch setting for only showing libraries allowing holds In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7534 --- Comment #44 from sandboxes at biblibre.com --- Created attachment 61274 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=61274&action=edit Bug 7534: Use search parameters for Koha::Template::Plugin::Branches->all This lets us query libraries with additional search parameters and is useful for this particular Bug by allowing us to select pickup locations. Unit tests included. To test: 1. prove t/db_dependent/Template/Plugin/Branches.t Signed-off-by: Koha Team AMU -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Mar 20 12:39:48 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 20 Mar 2017 11:39:48 +0000 Subject: [Koha-bugs] [Bug 7534] New OPACAllowUserToChooseBranch setting for only showing libraries allowing holds In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7534 --- Comment #45 from sandboxes at biblibre.com --- Created attachment 61275 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=61275&action=edit Bug 7534: Add configuration to admin/branches.pl This patch adds a configuration option for pickup locations. To test: 1. Apply patch 2. Go to cgi-bin/koha/admin/branches.pl 3. Observe there is a new column "Pickup location" 4. Click "Edit" for any library 5. Scroll to bottom of the page and select "No" 6. Click "Submit" 7. Observe your library in Libraries-table, notice the value of "Pickup location" has changed to "No" Signed-off-by: Koha Team AMU -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Mar 20 12:39:51 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 20 Mar 2017 11:39:51 +0000 Subject: [Koha-bugs] [Bug 7534] New OPACAllowUserToChooseBranch setting for only showing libraries allowing holds In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7534 --- Comment #46 from sandboxes at biblibre.com --- Created attachment 61276 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=61276&action=edit Bug 7534: Display pickup locations instead of all libraries in request.pl This patch sets request.tt to use the list of pickup libraries instead of every library in the system. To test: 1. Go to cgi-bin/koha/admin/branches.pl 2. Configure one of your libraries to "Pickup location" => "No" 3. Go place a hold in intranet 4. See the provided "Pickup at" list 5. Observe the library that you configured is not present in the list 6. Place the hold 7. See list of existing holds on that biblio 8. See "Pickup library" column and observe your configured library is not included in the list Signed-off-by: Koha Team AMU -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Mar 20 12:39:55 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 20 Mar 2017 11:39:55 +0000 Subject: [Koha-bugs] [Bug 7534] New OPACAllowUserToChooseBranch setting for only showing libraries allowing holds In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7534 --- Comment #47 from sandboxes at biblibre.com --- Created attachment 61277 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=61277&action=edit Bug 7534: Display pickup locations instead of all libraries in opac-reserve.pl This patch sets opac-reserve.tt to use the list of pickup libraries instead of every library in the system. To test: 1. Go to cgi-bin/koha/admin/branches.pl 2. Configure one of your libraries to "Pickup location" => "No" 3. Go to OPAC and place a hold 4. See the provided Pickup location list 5. Observe the library that you configured is not present in the list Signed-off-by: Koha Team AMU -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Mar 20 12:39:58 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 20 Mar 2017 11:39:58 +0000 Subject: [Koha-bugs] [Bug 7534] New OPACAllowUserToChooseBranch setting for only showing libraries allowing holds In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7534 --- Comment #48 from sandboxes at biblibre.com --- Created attachment 61278 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=61278&action=edit Bug 7534: (QA-follow-up) Default pickup location to Yes when adding a new library To test: 1. Apply the patches before this one 2. Go to /cgi-bin/koha/admin/branches.pl 3. Press New library button 4. Scroll down the page and observe Pickup location defaults to No 5. Apply this patch 6. Go to /cgi-bin/koha/admin/branches.pl 7. Press New library button 8. Scroll down the page and observe Pickup location now defaults to Yes Signed-off-by: Koha Team AMU -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Mar 20 12:40:02 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 20 Mar 2017 11:40:02 +0000 Subject: [Koha-bugs] [Bug 7534] New OPACAllowUserToChooseBranch setting for only showing libraries allowing holds In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7534 --- Comment #49 from sandboxes at biblibre.com --- Created attachment 61279 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=61279&action=edit Bug 7534: Validate pickup location in CanBook/ItemBeReserved This patch adds $branchcode_to parameter to CanBookBeReserved and CanItemBeReserved. It represents the pickup location for the hold. To test: 1. prove t/db_dependent/Holds.t Signed-off-by: Koha Team AMU -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Mar 20 12:40:06 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 20 Mar 2017 11:40:06 +0000 Subject: [Koha-bugs] [Bug 7534] New OPACAllowUserToChooseBranch setting for only showing libraries allowing holds In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7534 --- Comment #50 from sandboxes at biblibre.com --- Created attachment 61280 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=61280&action=edit Bug 7534: Check hold availability to desired pickup location in opac-reserve.pl To test: -1. Have access to your browser's developer tools in order to modify