[Koha-bugs] [Bug 18182] TestBuilder should be able to return Koha::Object objects

[bugzilla-daemon at bugs.koha-community.org]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18182

--- Comment #3 from Marcel de Rooy <m.de.rooy at rijksmuseum.nl> ---
Great, Tomas.

Few remarks:
I would rather remove the id column. We c/should take care of that in the code.
Like:
my @pk = $schema->source('Borrower')->primary_columns;
Note that we theoretically can have multiple columns. (We don't have such Koha
objects, but iirc we have one or two tables like that.)

Similarly, it would be more consistent and less confusing to use the singular
form. We do so in build; I would expect the same for build_object.
Additionally, you return just one singular object.

-- 
You are receiving this mail because:
You are watching all bug changes.