[Koha-bugs] [Bug 18150] CanItemBeReserved doesn't work with ( IndependentBranches AND ! canreservefromotherbranches)

[bugzilla-daemon at bugs.koha-community.org]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18150

Jonathan Druart <jonathan.druart at bugs.koha-community.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #60542|0                           |1
        is obsolete|                            |
  Attachment #60854|0                           |1
        is obsolete|                            |

--- Comment #5 from Jonathan Druart <jonathan.druart at bugs.koha-community.org> ---
Created attachment 60901
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=60901&action=edit
Bug 18150 - CanItemBeReserved doesn't work with (IndependentBranches AND !
canreservefromotherbranches)

The variable $item used to be a hash, but at the end of the function,
it's a Koha object. As $item->{homebranch} doesn't yield anything and
should be $item->homebranch. It prevents people using different
branches without holds between branches from placing a hold on an item
they should be able to place hold on.

Test plan:

1. Before patch

  a. with IndependantBranches off
  b. try to place hold on an item you should be able to place hold on
  c. it should work
  d. put IndependantBranches on and canreservefromotherbranches off
  e. shouldn't work

2. after patches redo steps from (1) and everything should be working
fine.

Signed-off-by: Christopher Brannon <cbrannon at cdalibrary.org>

Signed-off-by: Jonathan Druart <jonathan.druart at bugs.koha-community.org>
Note: Item is fetched twice, it's not necessary. But out of the scope of
this patch.

-- 
You are receiving this mail because:
You are watching all bug changes.