[Koha-bugs] [Bug 17560] Hold fee placement at point of checkout

[bugzilla-daemon at bugs.koha-community.org]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17560

Marcel de Rooy <m.de.rooy at rijksmuseum.nl> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Signed Off                  |Failed QA

--- Comment #15 from Marcel de Rooy <m.de.rooy at rijksmuseum.nl> ---
QA Comment
Code looks good to me. Note some wording issues and one blocker in the db
revision. Did not yet test the interface.

not_always is kind of a vague name for an option ;)
There is a charge of [% RESERVE_CHARGE %] for collecting this hold
There is a charge of [% RESERVE_CHARGE %] for placing this hold
Shouldn't it be better to say WHEN collecting this hold or WHEN placing this
hold ?
<div class="alert">You have been charged for collecting this item.</div>
Why did they charge me? Shouldn't you mention the the term "hold fee" here too?

sco-main.pl
You check if a hold exists before issuing. Shouldn't you check for the
borrowernumber too?
BTW Why not just call GetReserveFee here instead? You do not need to check
holds and account_lines anymore. And additionally you can pass the exact amount
in the message.
If you would still check account_lines, why not search for "Reserve Charge -
$title" too? 

Please rename bug_XXXXX.sql.
Additionally, if the pref is set to 'always', you should now change the value
to any_time_is_placed. Since you remove always !!

Failed QA

-- 
You are receiving this mail because:
You are watching all bug changes.