[Koha-bugs] [Bug 17718] Allow usage of Smartform API (Czech only)

bugzilla-daemon at bugs.koha-community.org bugzilla-daemon at bugs.koha-community.org
Fri Mar 10 10:45:45 CET 2017


https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17718

Marcel de Rooy <m.de.rooy at rijksmuseum.nl> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |m.de.rooy at rijksmuseum.nl
             Status|Signed Off                  |Failed QA

--- Comment #14 from Marcel de Rooy <m.de.rooy at rijksmuseum.nl> ---
Few questions:
Why not only have one preference? If the client id is empty, the pref is
obviously not enabled. We already have so much preferences ;)

>From a security perspective, I do not really like to include code like this:
<script type="text/javascript"
src="http://smartform.cz/api/v1/smartform.js"></script>
Can we do it some other way? Add it to a local lib directory, and have more
control?

In general: Can you convince me why we should push it in this current form? I
could imagine that we could have a more general 'plugin' that operates on
address fields and allows access to selected web services, or so?

Anyway, thanks for your work ! Your answers or adjustments may bring this
further.

Changing status to reflect need for feedback.

-- 
You are receiving this mail because:
You are watching all bug changes.


More information about the Koha-bugs mailing list