[Koha-bugs] [Bug 18208] Add RecordProcessor filter to inject not onloan count to MARC records

[bugzilla-daemon at bugs.koha-community.org]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18208

--- Comment #4 from Tomás Cohen Arazi <tomascohen at gmail.com> ---
(In reply to Marcel de Rooy from comment #3)
> my $items = Koha::Items->search({ biblionumber => $biblionumber });
> +
> +    while ( my $item = $items->next ) {
> +        $not_onloan_items++
> +            if not $item->onloan;
> +    }
> Can't you combine that in one statement?
> 
> In general: Do I understand correctly that this is not an optional filter?
> We will always save the not onloan count to 999$x?
> Can you also add some explanation on this report why we definitely need it?
> At this point we are not using it in the codebase. But if we should do after
> some time, would it feel good to rely on a field in the search engine when
> we can generate the count in one Koha::Items call ?
> No blockers, just convince me..

The record will always inject that. And is going to be used on indexing only.
See bug 18098.

When it comes to filtering search results (records with available items this
time) we need the index for being able to build the filtering query. We already
do that but the query is not working, and this way writing the query seems
straightfowrad. Just check if the index has a value higher than 0. Period.

RecordProcessor filters should be used for lots of things (specially stuff done
in C4::Biblios) like embedding items...

-- 
You are receiving this mail because:
You are watching all bug changes.