[Koha-bugs] [Bug 17560] Hold fee placement at point of checkout

[bugzilla-daemon at bugs.koha-community.org]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17560

--- Comment #16 from Jonathan Druart <jonathan.druart at bugs.koha-community.org> ---
(In reply to Marcel de Rooy from comment #15)
> QA Comment
> Code looks good to me. Note some wording issues and one blocker in the db
> revision. Did not yet test the interface.
> 
> not_always is kind of a vague name for an option ;)
> There is a charge of [% RESERVE_CHARGE %] for collecting this hold
> There is a charge of [% RESERVE_CHARGE %] for placing this hold
> Shouldn't it be better to say WHEN collecting this hold or WHEN placing this
> hold ?
> <div class="alert">You have been charged for collecting this item.</div>
> Why did they charge me? Shouldn't you mention the the term "hold fee" here
> too?


Can we get a native English speaker confirm the wordings?


> sco-main.pl
> You check if a hold exists before issuing. Shouldn't you check for the
> borrowernumber too?

Indeed.

> BTW Why not just call GetReserveFee here instead? You do not need to check
> holds and account_lines anymore. And additionally you can pass the exact
> amount in the message.

The idea was to make sure the patron has been charged. From the circulation and
reserves modules we are never really sure that what we want to happen will
happen....

> If you would still check account_lines, why not search for "Reserve Charge -
> $title" too? 

To avoid to depend on a string that could change, but I can add it if you think
it's safer.

> Please rename bug_XXXXX.sql.
> Additionally, if the pref is set to 'always', you should now change the
> value to any_time_is_placed. Since you remove always !!

Indeed, will fix.

-- 
You are receiving this mail because:
You are watching all bug changes.