[Koha-bugs] [Bug 13757] Make patron attributes editable in the opac if set to ' editable in OPAC'

bugzilla-daemon at bugs.koha-community.org bugzilla-daemon at bugs.koha-community.org
Wed Mar 15 21:30:47 CET 2017


https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13757

--- Comment #91 from Nick Clemens <nick at bywatersolutions.com> ---
Created attachment 61139
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=61139&action=edit
Bug 13757: (followup) Only touch opac_editable attributes

As reported by Owen, the members-update.pl was showing every attributes
the patron has (display issue) instead of showing only those affected by
the changes.

This patch fixes this by filtering the patron's attributes by opac
editability.

It also fixes Koha::Patron::Modification->approve so it only clears the
attributes with the updating 'code' and leaves the others untouched.
As its been coded so far (until someone refactors it all) the
Koha::Patron::Modification object needs to contain all the attributes
for a specific code. And it comes from parsing the UI's input.

Tests for Koha::Patron::Modification->approve to come.

Signed-off-by: Tomas Cohen Arazi <tomascohen at theke.io>

Signed-off-by: Nick Clemens <nick at bywatersolutions.com>

-- 
You are receiving this mail because:
You are watching all bug changes.


More information about the Koha-bugs mailing list