[Koha-bugs] [Bug 18282] OpenAPI operationId must be unique

[bugzilla-daemon at bugs.koha-community.org]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18282

--- Comment #5 from Tomás Cohen Arazi <tomascohen at gmail.com> ---
(In reply to Lari Taskula from comment #4)
> (In reply to Lari Taskula from comment #3)
> > (In reply to Tomás Cohen Arazi from comment #2)
> > > Lari, shouldn't this patch also change the controller class function names?
> > > 
> > > - sub list {
> > > + sub list_cities {
> > > - sub add {
> > > + sub add_city {
> > > - sub update {
> > > + sub update_city {
> > > - sub delete {
> > > + sub delete_city {
> > 
> > With Swagger2 plugin yes, but I set this as dependent on
> > Mojolicious::Plugin::OpenAPI, which is using "x-mojo-to" for pointing to the
> > controller class operation.
> 
> In fact not either with Swagger2. As you can see from patrons controller.

I tend to prefer avoiding black magic as much as possible to avoid unexpected
behaviours. That's why I prefer to explicitly put the most similar to the
function name. But keep moving and see how bad/good it looks.

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.