[Koha-bugs] [Bug 18279] C4::Items - Remove GetLostItems

bugzilla-daemon at bugs.koha-community.org bugzilla-daemon at bugs.koha-community.org
Thu Mar 16 20:30:08 CET 2017


https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18279

Marc Véron <veron at veron.ch> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #61152|0                           |1
        is obsolete|                            |

--- Comment #4 from Marc Véron <veron at veron.ch> ---
Created attachment 61191
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=61191&action=edit
Bug 18279: Remove C4::Items::GetLostItems

The JOIN done by this subroutine are not always useful (depending on
item-level_itypes). They also search with LIKE when it is not needed.

Since we have now Koha::Items, we can replace this subroutine with a
call to Koha::Items->search with the correct parameters.

A change in previous behaviours can happen: If a items.itemlost contains
a value that is not defined as a LOST authorised value, the item will
not be displayed. I think it's the expected behaviour, even if it should
not happen in correctly configured installations.

Test plan:
To test with item-level_itypes set to item and biblio:
List the lost items you have on your system, using the different
filters available.
The result table should contain the correct item's info.

Followed test plan, works as expected.
Signed-off-by: Marc Véron <veron at veron.ch>

https://bugs.koha-community.org/show_bug.cgi?id=18079

-- 
You are receiving this mail because:
You are watching all bug changes.


More information about the Koha-bugs mailing list