[Koha-bugs] [Bug 13345] Choose the format when sending a basket/list by email

[bugzilla-daemon at bugs.koha-community.org]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13345

Marcel de Rooy <m.de.rooy at rijksmuseum.nl> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #56499|0                           |1
        is obsolete|                            |

--- Comment #17 from Marcel de Rooy <m.de.rooy at rijksmuseum.nl> ---
Created attachment 61210
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=61210&action=edit
Bug 13345: Allow patrons to choose format on sending basket/list by email

It is already possible to download a basket(cart) or a list using
different format.
But by email, only iso2709 is possible.

This patch adds the ability to select a format for the file attached to
the email when sending the basket/list content.

Test plan:
1/ At the OPAC, add some records to your basket and send it by email
using different formats (RIS, BibTeX, MARC and the CSV profiles defined).
2/ At the OPAC, add some records to a list and send it by email using
the different formats.
3/ Redo step 1 at the intranet
4/ Redo step 2 at the intranet

Not that subtitles are not displayed in all these cases.

Note for QA: This patch refactors 3 main things:
1/ Template side: the dropdown list to select the format is now in an
include file (indeed, this list is used in 4 templates, this will make
easier further changes).
The include files are named 'download-export-available-formats.inc',
feel free to suggest something better.
The are used in:
[opac-]sendbasket.tt, [opac-]sendshelf.tt, [opac-]downloadbasket.tt and
[opac-]downloadshelf.tt.

2/ Build records data and the records file
This job was done in 4 scripts:
 - opac/opac-sendbasket.pl
 - opac/opac-sendshelf.pl
 - basket/sendbasket.pl
 - virtualshelves/sendshelf.pl
Now it's done in C4::Biblio::BuildBiblioDataForExport and tests are
provided in t/db_dependent/Biblio/BuildBiblioDataForExport.t
Not that a similar job is done in [opac-]downloadcart.pl and
[opac-]downloadshelf.pl

3/ Build the subject and body of the email sent
Same as before, the job was done at the same places.
Now it's done in Koha::Email->fill_body_for_sending (feel free to
suggestion a better name) and tests are provided in t/Koha_Email.t

Sponsored-by: Mines Paristech
Signed-off-by: Nicole C. Engard <nengard at bywatersolutions.com>

-- 
You are receiving this mail because:
You are watching all bug changes.