[Koha-bugs] [Bug 18264] Course reserves - use itemnumber for editing existing reserve items

[bugzilla-daemon at bugs.koha-community.org]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18264

--- Comment #5 from Jonathan Druart <jonathan.druart at bugs.koha-community.org> ---
Comment on attachment 61095
  --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=61095
Bug 18264 - Course reserves - use itemnumber for editing existing reserve items

Review of attachment 61095:
 --> (https://bugs.koha-community.org/bugzilla3/page.cgi?id=splinter.html&bug=18264&attachment=61095)
-----------------------------------------------------------------

::: course_reserves/add_items.pl
@@ +39,2 @@
>  
> +my $item = GetBiblioFromItemNumber( $itemnumber, $barcode );

This is wrong, this subroutine uses only one parameter (also see bug 18276).

@@ +50,4 @@
>          flagsrequired   => { coursereserves => 'add_reserves' },
>      }
>  );
> +my $inumber = $itemnumber ? "<blank> (itemnumber:$itemnumber)" : "";

hum? <blank>?

@@ +51,5 @@
>      }
>  );
> +my $inumber = $itemnumber ? "<blank> (itemnumber:$itemnumber)" : "";
> +$template->param( ERROR_BARCODE_NOT_FOUND => $barcode . $inumber )
> +  unless ( $barcode && !$itemnumber && $item && $action eq 'lookup' );

How do we reach that?

-- 
You are receiving this mail because:
You are watching all bug changes.