[Koha-bugs] [Bug 18291] Remove SQL from preferences.pl administrative script

[bugzilla-daemon at bugs.koha-community.org]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18291

Alex Buckley <alexbuckley at catalyst.net.nz> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|ASSIGNED                    |Needs Signoff

--- Comment #3 from Alex Buckley <alexbuckley at catalyst.net.nz> ---
Test Plan:

1. Restart memcached: sudo service memcached restart

2. Drop and recreate the Koha instance database

3. Go through the web installer, selecting all data to be installed in step 3

4. After the web installer is finished log in with the Koha database 
administrator credentials

5. Create yourself a patron account 

6. Set the patron account to have superlibrarian privileges 

7. Log out and back in as your newly created patron

8. Navigate to the Administration area

9. Write in the URL: cgi-bin/koha/admin/preferences.pl

10. Notice a table of system preferences and associated values

11. Apply all patches associated with this bug report 

12. Repeat steps 1,2,3,4,5,6,7,8,9

13. Again notice the systempreference table is full of preferences and their
values is displayed

14. In your terminal navigate from your Koha instance root directory to
t/db_dependent

15. Enter koha shell: sudo koha-shell <instancename>

16. Run sysprefs.t unit test: prove -v sysprefs.t

17. The tests should run successful

18. Exit the koha shell

19. Navigate back to your Koha instance root directory

20. View admin/preferences.pl script and observe it contains no SQL queries

21. Navigate back to your Koha instance root directory

22. View Koha/Config/SysPref.pm and notice that the select_systempreferences
subroutine (the subroutine preferences.pl now calls to run the SQL query)
contains POD

-- 
You are receiving this mail because:
You are watching all bug changes.