[Koha-bugs] [Bug 12063] Change date calculation for reserve expiration to skip all holidays

bugzilla-daemon at bugs.koha-community.org bugzilla-daemon at bugs.koha-community.org
Tue Mar 21 17:01:09 CET 2017


https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12063

Marcel de Rooy <m.de.rooy at rijksmuseum.nl> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Signed Off                  |Failed QA

--- Comment #45 from Marcel de Rooy <m.de.rooy at rijksmuseum.nl> ---
Prelimary results (QA can be an iterative process):

perl t/db_dependent/Holds/CancelReserves.t
1..5
ok 1 - use C4::Reserves;
ok 2 - Reserve 1 should not be canceled.
ok 3 - Reserve 2 should be canceled.
Can't locate object method "get_instance" via package "Koha::Cache" at
t/db_dependent/Holds/CancelReserves.t line 81.
# Looks like your test exited with 255 just after 3.

perl t/db_dependent/Holds/WaitingReserves.t
1..11
ok 1 - use C4::Reserves;
ok 2 - Waiting date should be set to today
ok 3 - Expiration date should be set to today + 6
ok 4 - Reserve status is now "waiting"
ok 5 - Priority should be 0
ok 6 - Item number should be set correctly
ok 7 - 2nd reserve - Reserve status is now "To transfer"
ok 8 - 2nd reserve - Priority should be 0
ok 9 - 2nd reserve - Item number should be set correctly
not ok 10 - Expiration date should be set to today + 7
#   Failed test 'Expiration date should be set to today + 7'
#   at t/db_dependent/Holds/WaitingReserves.t line 218.
#          got: '2017-03-27'
#     expected: '2017-03-29'
ok 11 - Requested expiration date should be kept
# Looks like you failed 1 test of 11.

-- 
You are receiving this mail because:
You are watching all bug changes.


More information about the Koha-bugs mailing list