[Koha-bugs] [Bug 17257] Cannot create a patron under MySQL 5.7

[bugzilla-daemon at bugs.koha-community.org]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17257

--- Comment #6 from Jonathan Druart <jonathan.druart at bugs.koha-community.org> ---
(In reply to Srdjan Jankovic from comment #5)
> (In reply to Jonathan Druart from comment #4)
> > (In reply to Srdjan Jankovic from comment #3)
> > > I don't have mysql (running mariadb), and wondering how come DBIx::Class did
> > > not solve it?
> > 
> > If the key exists, the default value defined at DB level is not used.
> 
> Ah I see. Then maybe
> 
> delete $data{'dateofbirth'} if exists($data{'dateofbirth') &&
> !$data{'dateofbirth'};
> 
> would make intention clearer.

I just mimic what existed before.

> > I do not understand, we are not using Koha::Patron here.
> 
> A couple of lines later:
> 
> my $patron = Koha::Patron->new( $new_member )->store;
> 
> Considering the line number mismatch, I'd say base for this patch is lagging
> a bit.

As I said, I just mimic what existed before.
The plan is to move C4::Members::AddMember to Koha::Patron, of course. But that
patch is just supposed to be a bugfix.

-- 
You are receiving this mail because:
You are watching all bug changes.