[Koha-bugs] [Bug 12063] Change date calculation for reserve expiration to skip all holidays

bugzilla-daemon at bugs.koha-community.org bugzilla-daemon at bugs.koha-community.org
Thu Mar 23 15:45:58 CET 2017


https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12063

--- Comment #54 from Marcel de Rooy <m.de.rooy at rijksmuseum.nl> ---
Also please look here in circ/waitingreserves.pl
    ( $waiting_year, $waiting_month, $waiting_day ) =
      Add_Delta_Days( $waiting_year, $waiting_month, $waiting_day,
        $max_pickup_delay);
    my $calcDate = Date_to_Days( $waiting_year, $waiting_month, $waiting_day );
This date is compared with today and holds may be cancelled. We should use the
new expirationdate here too. 
An interesting aspect is this one too in the same script: 
$max_pickup_delay-- if C4::Context->preference('ExpireReservesMaxPickUpDelay');
This is kind of strange btw. You should either use the delay or not use it.

-- 
You are receiving this mail because:
You are watching all bug changes.


More information about the Koha-bugs mailing list