[Koha-bugs] [Bug 12063] Change date calculation for reserve expiration to skip all holidays

bugzilla-daemon at bugs.koha-community.org bugzilla-daemon at bugs.koha-community.org
Thu Mar 30 12:05:06 CEST 2017


https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12063

Alex Arnaud <alex.arnaud at biblibre.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Failed QA                   |Signed Off

--- Comment #59 from Alex Arnaud <alex.arnaud at biblibre.com> ---
Patch above fix Marcel's QA comments. Also, i added some minor changes:

in the sub Koha::Hold::set_waiting:
 => Remove the test "if (
C4::Context->preference("ExpireReservesMaxPickUpDelay") )".
I think we want to calculate the expiration date even if
ExpireReservesMaxPickUpDelay is set to dont't allow

in C4::Reserves::CancelExpiredReserves:
return if ExpireReservesMaxPickUpDelay is set to don't allow. Do nothing

turn this BZ back to Signed off status. Tell me if the changes make i should
pass it to Needs Signoff again.

-- 
You are receiving this mail because:
You are watching all bug changes.


More information about the Koha-bugs mailing list