[Koha-bugs] [Bug 17560] Hold fee placement at point of checkout

[bugzilla-daemon at bugs.koha-community.org]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17560

--- Comment #46 from Marcel de Rooy <m.de.rooy at rijksmuseum.nl> ---
I obsoleted the last patch. It is not really what I had in mind.
I found out what my problem was in the charges display:
HoldsInNoissuesCharge = Dont include
RentalsInNoissuesCharge = Include
If you set HoldsInNoissuesCharge to include, you will have the same display as
a rental fee. But what would be the side effects?

I am not sure if the current code really works fine if you would e.g. combine a
hold fee with a rental fee (playing with noissuescharge too). But we are
leaving the scope of this bug here.

In the issuing process CanBookBeIssued is called, it does not care about the
hold fee charged later. And in this case it should not block the issue here for
a hold fee only.

What may happen is this: I set rental to 6, hold fee to 7 and noissuecharge to
5 (a weird combination), Koha still allows me to checkout the book, charges me
13 AND says Cannot check out ! This is definitely a bug but not from this
report.

In conclusion: Since Koha does not handle these charges correctly here, I would
not enforce point 1 from comment 40. Since we move point 2 to another report,
point 3 makes no sense yet..

Before passing QA: Do you still have any feedback to these last findings?

-- 
You are receiving this mail because:
You are watching all bug changes.