[Koha-bugs] [Bug 15438] Checking out an on-hold item sends holder' s borrowernumber in AF (screen message) field.

[bugzilla-daemon at bugs.koha-community.org]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15438

Colin Campbell <colin.campbell at ptfs-europe.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Failed QA                   |Needs Signoff

--- Comment #19 from Colin Campbell <colin.campbell at ptfs-europe.com> ---
Have done some testing on the patch and while inelegant - it does suppress the
random data elements. This bit of debug shows the nature of the problem:

The debug statements were in the wrapper the patch adds It outputs the keys
found in the issuingimposible and needsconfirmation hashes (2 indicates
needsconfirmation) and the keys "Remaining" in those hashs after sanitization


Mar 30 15:38:49 zazou koha_sip[28864]: Key 2:RESERVED
Mar 30 15:38:49 zazou koha_sip[28864]: Key 2:resfirstname
Mar 30 15:38:49 zazou koha_sip[28864]: Key 2:resreservedate
Mar 30 15:38:49 zazou koha_sip[28864]: Key 2:resbranchcode
Mar 30 15:38:49 zazou koha_sip[28864]: Key 2:ressurname
Mar 30 15:38:49 zazou koha_sip[28864]: Key 2:resborrowernumber
Mar 30 15:38:49 zazou koha_sip[28864]: Key 2:rescardnumber
Mar 30 15:38:49 zazou koha_sip[28864]: Remaining I:
Mar 30 15:38:49 zazou koha_sip[28864]: Remaining C:RESERVED

TBH reading the code of CanBookBeIssued is a bit dispiriting parameters have
been tacked on that are used in one place and its logic is full of special (and
not so special) cases. I'm sure it could be made clearer and more efficient as 
befits such a central routine. I'm taking the liberty of reseting the status to
Needs Signoff as some people are getting burned by this (some sites dont suffer
because their syspreferences avoid setting of fields like the above). 
If testing remember to stop and restart the sipsever you are testing against
after code changes as the sip server runs persistently unlike cgi processes

-- 
You are receiving this mail because:
You are watching all bug changes.