From bugzilla-daemon at bugs.koha-community.org Mon May 1 01:54:26 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 30 Apr 2017 23:54:26 +0000 Subject: [Koha-bugs] [Bug 16034] Integration with OverDrive Patron API In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16034 Chris Cormack changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |chris at bigballofwax.co.nz Blocks| |18172 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18172 [Bug 18172] Logged in user page shows internal server error if OverDriveCirculation is disabled -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon May 1 01:54:26 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 30 Apr 2017 23:54:26 +0000 Subject: [Koha-bugs] [Bug 18172] Logged in user page shows internal server error if OverDriveCirculation is disabled In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18172 Chris Cormack changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on| |16034 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16034 [Bug 16034] Integration with OverDrive Patron API -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon May 1 01:59:04 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 30 Apr 2017 23:59:04 +0000 Subject: [Koha-bugs] [Bug 18514] New: Allow library to search their Koha and Overdrive collections using ElasticSearch Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18514 Bug ID: 18514 Summary: Allow library to search their Koha and Overdrive collections using ElasticSearch Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: OPAC Assignee: oleonard at myacpl.org Reporter: chris at bigballofwax.co.nz QA Contact: testopia at bugs.koha-community.org Building on the Elasticsearch and Overdrive work, this feature will allow users to run a cronjob to populate their elastic index with collection information from Overdrive. This makes both local Koha records, and Overdrive ones searchable. This bug will add the code to fetch and index the records, and to search and display them in the OPAC Subsequent bugs will add the detail display to the staff side -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon May 1 01:59:56 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 30 Apr 2017 23:59:56 +0000 Subject: [Koha-bugs] [Bug 18514] Allow library to search their Koha and Overdrive collections using ElasticSearch In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18514 Chris Cormack changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on| |16034 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16034 [Bug 16034] Integration with OverDrive Patron API -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon May 1 01:59:56 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 30 Apr 2017 23:59:56 +0000 Subject: [Koha-bugs] [Bug 16034] Integration with OverDrive Patron API In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16034 Chris Cormack changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |18514 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18514 [Bug 18514] Allow library to search their Koha and Overdrive collections using ElasticSearch -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon May 1 02:05:45 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 01 May 2017 00:05:45 +0000 Subject: [Koha-bugs] [Bug 18483] Customised help: Enhance staff client with news based, easily editable help system In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18483 --- Comment #16 from M. Tompsett --- Comment on attachment 62901 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=62901 Bug 18483 - Customised help: Enhance staff client with news based, easily editable help system Review of attachment 62901: --> (https://bugs.koha-community.org/bugzilla3/page.cgi?id=splinter.html&bug=18483&attachment=62901) ----------------------------------------------------------------- ::: koha-tmpl/intranet-tmpl/prog/en/includes/header.inc @@ +98,4 @@ > > > > + [% IF Koha.Preference('HelpSystem').match('filebased|newsbased') %] Is there ever going to be a HelpSystem which does not need the Help link? Is this really necessary? -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon May 1 02:13:30 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 01 May 2017 00:13:30 +0000 Subject: [Koha-bugs] [Bug 12027] Shibboleth authentication for staff client In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12027 M. Tompsett changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |mtompset at hotmail.com --- Comment #23 from M. Tompsett --- (In reply to Martin Renvoize from comment #13) > https://wiki.koha-community.org/wiki/Shibboleth_Configuration Sweet, tangentially, do we have attempts at other authentication methods? Also, we should also have a bug for changing the StaffBaseURL to include the protocol. After all, shibboleth requires https, does it not? -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon May 1 02:17:53 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 01 May 2017 00:17:53 +0000 Subject: [Koha-bugs] [Bug 18514] Allow library to search their Koha and Overdrive collections using ElasticSearch In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18514 --- Comment #1 from Chris Cormack --- Created attachment 62902 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=62902&action=edit Bug 18514 : Script to fetch records from Overdrive To Test: You must be running Elasticsearch with Koha 1/ Fill in the Overdrive system preferences 2/ run this script 3/ Records should be in ElasticSearch -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon May 1 02:18:17 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 01 May 2017 00:18:17 +0000 Subject: [Koha-bugs] [Bug 18514] Allow library to search their Koha and Overdrive collections using ElasticSearch In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18514 --- Comment #2 from Chris Cormack --- Created attachment 62903 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=62903&action=edit Bug 18514 : Adding search capabilities for Overdrive results in Koha To test 1/ Apply the first patch and run the script in it 2/ Search, notice no Overdrive results showing 3/ Search again, now you should get results in the OPAC results page -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon May 1 02:18:36 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 01 May 2017 00:18:36 +0000 Subject: [Koha-bugs] [Bug 18514] Allow library to search their Koha and Overdrive collections using ElasticSearch In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18514 --- Comment #3 from Chris Cormack --- Created attachment 62904 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=62904&action=edit Bug 18514 Fix link on results page, and show overdrive data on detail page To test 1/ Apply the first 2 patches, and run the fetcher script (in patch one) 2/ Search, notice the overdrive results result in a 404 if you click on them 3/ Apply this patch 4/ Search again 5/ Click on a result, you should now be at a detail page -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon May 1 06:22:03 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 01 May 2017 04:22:03 +0000 Subject: [Koha-bugs] [Bug 18515] New: Use news based help system for OPAC Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18515 Bug ID: 18515 Summary: Use news based help system for OPAC Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: OPAC Assignee: oleonard at myacpl.org Reporter: veron at veron.ch QA Contact: testopia at bugs.koha-community.org Implement the news based, easily editable help system for OPAC as well, based on Bug 18483. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon May 1 06:22:26 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 01 May 2017 04:22:26 +0000 Subject: [Koha-bugs] [Bug 18483] Customised help: Enhance staff client with news based, easily editable help system In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18483 Marc V?ron changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |18515 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18515 [Bug 18515] Use news based help system for OPAC -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon May 1 06:22:26 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 01 May 2017 04:22:26 +0000 Subject: [Koha-bugs] [Bug 18515] Use news based help system for OPAC In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18515 Marc V?ron changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on| |18483 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18483 [Bug 18483] Customised help: Enhance staff client with news based, easily editable help system -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon May 1 06:25:44 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 01 May 2017 04:25:44 +0000 Subject: [Koha-bugs] [Bug 18483] Customised help: Enhance staff client with news based, easily editable help system In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18483 --- Comment #17 from Marc V?ron --- (In reply to M. Tompsett from comment #16) > Comment on attachment 62901 [details] [review] > Bug 18483 - Customised help: Enhance staff client with news based, easily > editable help system > > Review of attachment 62901 [details] [review]: > ----------------------------------------------------------------- > > ::: koha-tmpl/intranet-tmpl/prog/en/includes/header.inc > @@ +98,4 @@ > > > > > > > > + [% IF Koha.Preference('HelpSystem').match('filebased|newsbased') %] > > Is there ever going to be a HelpSystem which does not need the Help link? Is > this really necessary? I implemented this because the help system can totally be turned off (nothing selected in system preference 'HelpSystem'). And 'yes' to the question, or better 'yes, but not yet': - I'm thinking about expanding the news based help to the OPAC as well, see Bug 18515 - Use news based help system for OPAC, and I do not want it to trigger the link on staff client. - I can imagine a help system that for example displays a small help text directly on the screen -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon May 1 06:33:05 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 01 May 2017 04:33:05 +0000 Subject: [Koha-bugs] [Bug 6422] help files for the OPAC In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6422 Marc V?ron changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |https://bugs.koha-community | |.org/bugzilla3/show_bug.cgi | |?id=18515 -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon May 1 06:33:05 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 01 May 2017 04:33:05 +0000 Subject: [Koha-bugs] [Bug 18515] Use news based help system for OPAC In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18515 Marc V?ron changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |https://bugs.koha-community | |.org/bugzilla3/show_bug.cgi | |?id=6422 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon May 1 06:52:23 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 01 May 2017 04:52:23 +0000 Subject: [Koha-bugs] [Bug 18516] New: Add possibility to import text from file based help system as news based help system item Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18516 Bug ID: 18516 Summary: Add possibility to import text from file based help system as news based help system item Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Staff Client Assignee: koha-bugs at lists.koha-community.org Reporter: veron at veron.ch QA Contact: testopia at bugs.koha-community.org CC: gmcharlt at gmail.com Bug 18483 introduces a news based help system. When displaying help from a page, it would be nice to have a button to create a news based entry from the file based help text. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Mon May 1 06:52:48 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 01 May 2017 04:52:48 +0000 Subject: [Koha-bugs] [Bug 18483] Customised help: Enhance staff client with news based, easily editable help system In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18483 Marc V?ron changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |18516 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18516 [Bug 18516] Add possibility to import text from file based help system as news based help system item -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon May 1 06:52:48 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 01 May 2017 04:52:48 +0000 Subject: [Koha-bugs] [Bug 18516] Add possibility to import text from file based help system as news based help system item In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18516 Marc V?ron changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on| |18483 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18483 [Bug 18483] Customised help: Enhance staff client with news based, easily editable help system -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon May 1 08:37:34 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 01 May 2017 06:37:34 +0000 Subject: [Koha-bugs] [Bug 17600] Standardize the EXPORT In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17600 --- Comment #33 from Marcel de Rooy --- (In reply to Martin Renvoize from comment #32) > So, this is a PQA from me.. Did Marcel also add his PQA.. if so we should do > one last rebase and push the bugger ;) Did you add a signoff line? I still have a look this week. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon May 1 11:43:33 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 01 May 2017 09:43:33 +0000 Subject: [Koha-bugs] [Bug 6979] LDAP authentication fails during password comparison In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6979 Marcel de Rooy changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |m.de.rooy at rijksmuseum.nl --- Comment #46 from Marcel de Rooy --- commit 8c3fc47338fed6c35ea21a6524d6c1a109861ebf Author: = <=> Date: Wed Oct 5 16:47:21 2011 -0400 >From IRC: rangi: can we fix the author lines on commits like that please? I agree that we should not push patches like that. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon May 1 11:48:47 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 01 May 2017 09:48:47 +0000 Subject: [Koha-bugs] [Bug 18291] Remove SQL from preferences.pl administrative script In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18291 Alex Buckley changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #62517|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon May 1 11:49:24 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 01 May 2017 09:49:24 +0000 Subject: [Koha-bugs] [Bug 18291] Remove SQL from preferences.pl administrative script In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18291 Alex Buckley changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #62518|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon May 1 11:50:24 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 01 May 2017 09:50:24 +0000 Subject: [Koha-bugs] [Bug 18291] Remove SQL from preferences.pl administrative script In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18291 --- Comment #7 from Alex Buckley --- Created attachment 62905 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=62905&action=edit Bug 18291 - Implemented call to C4::Context->preference($name) in admin/preferences.pl which uses cached preference values -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon May 1 11:52:19 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 01 May 2017 09:52:19 +0000 Subject: [Koha-bugs] [Bug 18291] Remove SQL from preferences.pl administrative script In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18291 Alex Buckley changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #62905|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon May 1 11:52:55 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 01 May 2017 09:52:55 +0000 Subject: [Koha-bugs] [Bug 18291] Remove SQL from preferences.pl administrative script In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18291 --- Comment #8 from Alex Buckley --- Created attachment 62906 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=62906&action=edit Bug 18291 - Implemented call to C4::Context->preference($name) in admin/preferences.pl which uses cached preference values -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon May 1 12:14:51 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 01 May 2017 10:14:51 +0000 Subject: [Koha-bugs] [Bug 18502] koha-shell broken on dev installs In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18502 Marcel de Rooy changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon May 1 12:14:54 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 01 May 2017 10:14:54 +0000 Subject: [Koha-bugs] [Bug 18502] koha-shell broken on dev installs In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18502 Marcel de Rooy changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #62792|0 |1 is obsolete| | --- Comment #3 from Marcel de Rooy --- Created attachment 62907 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=62907&action=edit Bug 18502: Make koha-shell set the right PERL5LIB on dev installs Bug 16749 introduced a nice way to have flexible paths. During the discussion on how to do it, we moved from having it contain the path to the git dir to just a boolean. The 'koha-shell' script didn't get attention it seems, and it is broken on dev installs. This was hidden by the fact that many of us run dev installs on kohadevbox, which sets a .bashrc file for de instance's user, containing the right path when opening the new shell. This patch changes the logic so on a dev install, intranetdir is picked as the right path. This is how it is handled in koha-functions.sh To test: - On kohadevbox, run: $ sudo koha-shell kohadev -c "perl misc4dev/populate_db.pl" => FAIL: C4/Installer.pm not found on PERL5LIB error. - Apply this patch - Replace /usr/bin/koha-shell with debian/scripts/koha-shell $ sudo cp kohaclone/debian/scripts/koha-shell /usr/bin/koha-shell - Run: $ sudo koha-shell kohadev -c "perl misc4dev/populate_db.pl" => SUCCESS: No warning about missing libs is raised. - Sign off :-D Signed-off-by: Tomas Cohen Arazi Signed-off-by: Marcel de Rooy -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon May 1 12:17:14 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 01 May 2017 10:17:14 +0000 Subject: [Koha-bugs] [Bug 18291] Remove SQL from preferences.pl administrative script In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18291 Alex Buckley changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |Needs Signoff --- Comment #9 from Alex Buckley --- Hi Jonathan I think see what you mean about the use of Koha::Context->SysPref and Koha::Context->SysPref. I have chosen to use the C4::Context::preference() call rather than the call to the Koha::Config::Sysprefs->find( $variable ) as both present a one line patch and the use of retrieving cached values seems better from a performance point of view. In addition to this call I have had to change $row->{''}; to $piece->{''}; in several places to allow preferences.pl to run successfully. Could you please test my patch and let me know if I have fixed the issues that previously existed? Cheers Alex -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon May 1 12:59:40 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 01 May 2017 10:59:40 +0000 Subject: [Koha-bugs] [Bug 16733] More flexible paths in debian scripts (for dev installs) In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16733 --- Comment #42 from Katrin Fischer --- Waiting for bug 18502 to reconsider backporting (visible when checking the graph) -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon May 1 13:07:20 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 01 May 2017 11:07:20 +0000 Subject: [Koha-bugs] [Bug 15140] Add MARC21 776 to OPAC and staff display In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15140 Marcel de Rooy changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon May 1 13:07:23 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 01 May 2017 11:07:23 +0000 Subject: [Koha-bugs] [Bug 15140] Add MARC21 776 to OPAC and staff display In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15140 --- Comment #13 from Marcel de Rooy --- Created attachment 62908 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=62908&action=edit Bug 15140: Display $i when ind2==8 See MARC specification. Note that we have a preceding text before all 776s too. Test plan: [1] Set field 776 ind2 to 8. And add text in $i. [2] Look for this text on OPAC detail and staff detail. Signed-off-by: Marcel de Rooy -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon May 1 13:07:56 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 01 May 2017 11:07:56 +0000 Subject: [Koha-bugs] [Bug 15140] Add MARC21 776 to OPAC and staff display In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15140 --- Comment #14 from Marcel de Rooy --- (In reply to Felix Hemme from comment #12) > Hi Marcel, > linking works fine now. But I think the value from subfield $i (relationship > information) should be displayed if second indicator = 8. Like in field 775 > (other edition entry). I changed the status to "Failed QA". Please change it > again if that was not correct. Thanks for testing, Felix. I have tried to implement your suggestion in the second patch. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon May 1 13:10:22 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 01 May 2017 11:10:22 +0000 Subject: [Koha-bugs] [Bug 14399] Fix inventory.pl part two (following 12913) In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14399 --- Comment #24 from Marcel de Rooy --- (In reply to Josef Moravec from comment #23) > Signed-off-by: Josef Moravec Thanks for testing, Josef. In the meantime we are using these changes in production on 3.22 already. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon May 1 13:12:03 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 01 May 2017 11:12:03 +0000 Subject: [Koha-bugs] [Bug 18361] Koha::Objects->find should accept composite primary keys In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18361 Marcel de Rooy changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #62396|0 |1 is obsolete| | --- Comment #15 from Marcel de Rooy --- Created attachment 62910 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=62910&action=edit Bug 18361: Additional tests for Koha::Objects->find Adding a subtest find in t/db_dependent/Koha/Objects.t. Test plan: Run t/db_dependent/Koha/Objects.t Signed-off-by: Marcel de Rooy Signed-off-by: Tomas Cohen Arazi -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon May 1 13:11:58 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 01 May 2017 11:11:58 +0000 Subject: [Koha-bugs] [Bug 18361] Koha::Objects->find should accept composite primary keys In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18361 Marcel de Rooy changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #62395|0 |1 is obsolete| | --- Comment #14 from Marcel de Rooy --- Created attachment 62909 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=62909&action=edit Bug 18361: Koha::Objects->find should accept composite primary keys Changes the $id parameter to an array. (IssuingRule has three keys.) The build_object method in TestBuilder.pm has been adjusted to pass multiple primary key values to find. Also adjusted the POD section to show more clearly that we accept the same parameters as DBIx ResultSet does. Test plan: Run t/db_dependent/Koha/Object.t Run t/db_dependent/Koha/Objects.t Run t/db_dependent/TestBuilder.t Signed-off-by: Marcel de Rooy Signed-off-by: Tomas Cohen Arazi -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon May 1 13:12:07 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 01 May 2017 11:12:07 +0000 Subject: [Koha-bugs] [Bug 18361] Koha::Objects->find should accept composite primary keys In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18361 Marcel de Rooy changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #62397|0 |1 is obsolete| | --- Comment #16 from Marcel de Rooy --- Created attachment 62911 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=62911&action=edit Bug 18361: (QA followup) Add tests for the no params case This patch adds a test for the trivial case in which no param is passed and the ->find method returns undef. For completeness purposes. Signed-off-by: Tomas Cohen Arazi -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon May 1 13:12:44 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 01 May 2017 11:12:44 +0000 Subject: [Koha-bugs] [Bug 18361] Koha::Objects->find should accept composite primary keys In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18361 Marcel de Rooy changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Patch doesn't apply |Signed Off --- Comment #17 from Marcel de Rooy --- Jonathan: Please try again. I actually did not change anything. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon May 1 13:17:26 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 01 May 2017 11:17:26 +0000 Subject: [Koha-bugs] [Bug 18299] Removal of SQL queries from admin/ env_tz_test.pl script into a perl module In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18299 --- Comment #9 from Marcel de Rooy --- (In reply to Jonathan Druart from comment #8) > I was not aware of this script and I think it does not make sense to have it. > I'd prefer to remove it than adding more code to the codebase to maintain it. > > Opinions? No strong opinion. But yes, we could do without this script. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon May 1 14:23:52 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 01 May 2017 12:23:52 +0000 Subject: [Koha-bugs] [Bug 11375] Improve patrons permissions display In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11375 --- Comment #6 from Katrin Fischer --- I like it! Only thing maybe is that I like the top level permission clickable, as that seems a bit faster than the 'show details' link when you have to enter a lot of accounts as we usually do. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Mon May 1 14:29:20 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 01 May 2017 12:29:20 +0000 Subject: [Koha-bugs] [Bug 7550] Self checkout: limit display of patron image to logged-in patron In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7550 Marcel de Rooy changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #62441|0 |1 is obsolete| | --- Comment #27 from Marcel de Rooy --- Created attachment 62912 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=62912&action=edit Bug 7550: SCO - Restrict access of patron's image With this patch if SelfCheckoutByLogin is set to 'username and password', only the logged in user will be able to see the image linked to his/her logged in account. If set to "barcode" we generate a token but it can be easily generated. You should add a warning in the about page if SelfCheckoutByLogin="barcode" and ShowPatronImageInWebBasedSelfCheck="Show". How I tested: - Go to SCO - Log - Enable self checkout, go to [Your Server]//cgi-bin/koha/sco/sco-main.pl - Log in with a user 'A' who has a patron image - Copy the address of the patron image into an other browser window - Change the borrowernumber to on of an other user 'B' having a patron image - Verify that the patron image is NOT displayed Signed-off-by: Marc V?ron Signed-off-by: Marcel de Rooy -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon May 1 14:29:25 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 01 May 2017 12:29:25 +0000 Subject: [Koha-bugs] [Bug 7550] Self checkout: limit display of patron image to logged-in patron In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7550 --- Comment #28 from Marcel de Rooy --- Created attachment 62913 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=62913&action=edit Bug 7550: [QA Follow-up] Resolve param warning from sco-patron-image Resolve this warning: CGI::param called in list context from package C4::Service line 212, this can lead to vulnerabilities. See the warning in "Fetching the value or values of a single named parameter" at /usr/share/perl5/CGI.pm line 436. It comes from the require_params call in sco-patron-image.pl. Git grepping on require_params tells me this: members/default_messageprefs.pl:my ($categorycode) = C4::Service->require_params('categorycode'); opac/sco/sco-patron-image.pl:my ($borrowernumber) = C4::Service->require_params('borrowernumber'); opac/sco/sco-patron-image.pl:my ($csrf_token) = C4::Service->require_params('csrf_token'); svc/cataloguing/metasearch:my ( $query_string, $servers ) = C4::Service->require_params( 'q', 'servers' ); The only candidate for multi_param seems to be 'servers', but as we can see this variable is a scalar. Additional servers returned by require_params are lost. This should be solved on its own report. So, we can safely add scalar to the params call, resolve the warning and keep the same behavior. Signed-off-by: Marcel de Rooy -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon May 1 14:29:39 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 01 May 2017 12:29:39 +0000 Subject: [Koha-bugs] [Bug 7550] Self checkout: limit display of patron image to logged-in patron In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7550 Marcel de Rooy changed: What |Removed |Added ---------------------------------------------------------------------------- QA Contact| |m.de.rooy at rijksmuseum.nl Patch complexity|Trivial patch |Small patch -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon May 1 14:29:52 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 01 May 2017 12:29:52 +0000 Subject: [Koha-bugs] [Bug 7550] Self checkout: limit display of patron image to logged-in patron In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7550 Marcel de Rooy changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #62400|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon May 1 14:30:14 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 01 May 2017 12:30:14 +0000 Subject: [Koha-bugs] [Bug 7550] Self checkout: limit display of patron image to logged-in patron In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7550 Marcel de Rooy changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon May 1 14:32:09 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 01 May 2017 12:32:09 +0000 Subject: [Koha-bugs] [Bug 17190] Mark REST API dependencies as mandatory in PerlDependencies.pm In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17190 --- Comment #4 from Katrin Fischer --- Thx Alex and Marc! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon May 1 14:34:55 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 01 May 2017 12:34:55 +0000 Subject: [Koha-bugs] [Bug 15582] Ability to block auto renewals if the OPACFineNoRenewals amount is reached In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15582 Nick Clemens changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Failed QA --- Comment #39 from Nick Clemens --- The feature works as expected but I think that we need feedback on opac and staff pages to indicate whether the auto-renewal will succeed/fail -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon May 1 14:43:02 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 01 May 2017 12:43:02 +0000 Subject: [Koha-bugs] [Bug 15582] Ability to block auto renewals if the OPACFineNoRenewals amount is reached In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15582 --- Comment #40 from Nick Clemens --- (In reply to Nick Clemens from comment #39) > The feature works as expected but I think that we need feedback on opac and > staff pages to indicate whether the auto-renewal will succeed/fail Ah, nvm, implemented in bug 15705 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon May 1 14:44:53 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 01 May 2017 12:44:53 +0000 Subject: [Koha-bugs] [Bug 15582] Ability to block auto renewals if the OPACFineNoRenewals amount is reached In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15582 Nick Clemens changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |Passed QA -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon May 1 14:44:57 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 01 May 2017 12:44:57 +0000 Subject: [Koha-bugs] [Bug 15582] Ability to block auto renewals if the OPACFineNoRenewals amount is reached In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15582 Nick Clemens changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #62881|0 |1 is obsolete| | Attachment #62882|0 |1 is obsolete| | Attachment #62883|0 |1 is obsolete| | --- Comment #41 from Nick Clemens --- Created attachment 62914 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=62914&action=edit Bug 15582: DB changes - add new pref OPACFineNoRenewalsBlockAutoRenew Sponsored-by: University of the Arts London Signed-off-by: Jonathan Field Signed-off-by: Janet McGowan Signed-off-by: Nick Clemens -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon May 1 14:45:00 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 01 May 2017 12:45:00 +0000 Subject: [Koha-bugs] [Bug 15582] Ability to block auto renewals if the OPACFineNoRenewals amount is reached In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15582 --- Comment #42 from Nick Clemens --- Created attachment 62915 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=62915&action=edit Bug 15582: Ability to block auto renewals if OPACFineNoRenewals is reached If a patron owes more than the OPACFineNoRenewals value, the issue won't be auto renewed anymore (driven by the new pref OPACFineNoRenewalsBlockAutoRenew). Test plan: Note: You will have to manually change data in your DB, make sure you have access to the sql cli. 1/ Set the OPACFineNoRenewals to 5 (for instance) 2/ Set OPACFineNoRenewalsBlockAutoRenew to block 3/ Check an item out to a patron and mark is as an auto renewal 4/ Make sure the patron does not have any fees or charges. 5/ Execute the automatic renewals cronjob script (misc/cronjobs/automatic_renewals.pl) Confirm that the issue has been renewed 6/ Create an invoice for this patron with a amount > OPACFineNoRenewals (6 for instance) 7/ Execute the automatic renewals cronjob script (misc/cronjobs/automatic_renewals.pl) Confirm that the issue has not been renewed. 8/ Set OPACFineNoRenewalsBlockAutoRenew to allow 9/ Execute the automatic renewals cronjob script (misc/cronjobs/automatic_renewals.pl) Confirm that the issue has been renewed Sponsored-by: University of the Arts London Signed-off-by: Jonathan Field Signed-off-by: Janet McGowan Signed-off-by: Nick Clemens -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon May 1 14:45:05 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 01 May 2017 12:45:05 +0000 Subject: [Koha-bugs] [Bug 15582] Ability to block auto renewals if the OPACFineNoRenewals amount is reached In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15582 --- Comment #43 from Nick Clemens --- Created attachment 62916 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=62916&action=edit Bug 15582: Fix grammar in syspref description Signed-off-by: Jonathan Field Signed-off-by: Janet McGowan Signed-off-by: Nick Clemens -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon May 1 14:50:10 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 01 May 2017 12:50:10 +0000 Subject: [Koha-bugs] [Bug 18444] Add TalkingTechItivaPhoneNotification to sysprefs.sql In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18444 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon May 1 14:50:13 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 01 May 2017 12:50:13 +0000 Subject: [Koha-bugs] [Bug 18444] Add TalkingTechItivaPhoneNotification to sysprefs.sql In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18444 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #62273|0 |1 is obsolete| | --- Comment #3 from Katrin Fischer --- Created attachment 62917 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=62917&action=edit Bug 18444: Add TalkingTechItivaPhoneNotification to sysprefs.sql Signed-off-by: Katrin Fischer -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon May 1 14:51:24 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 01 May 2017 12:51:24 +0000 Subject: [Koha-bugs] [Bug 18494] Fix Letters.t (follow-up of 15702) In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18494 Marcel de Rooy changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Failed QA CC| |m.de.rooy at rijksmuseum.nl --- Comment #8 from Marcel de Rooy --- (In reply to Lari Taskula from comment #2) > Now that I'm looking at this closer, I don't yet understand why it > originally fails. If $patron_category is passed as a hashref to ->find, I'm > thinking it should still work... I tested it on another container running > with slightly different version and I don't experience this failure. Passing categorycode as a hashref seems to be wrong. Why are we fixing this error in the wrong place ? Please convince me before passing qa on this one. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon May 1 14:55:29 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 01 May 2017 12:55:29 +0000 Subject: [Koha-bugs] [Bug 18444] Add TalkingTechItivaPhoneNotification to sysprefs.sql In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18444 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |katrin.fischer at bsz-bw.de --- Comment #4 from Katrin Fischer --- I wonder if we should also have an atomicupdate checking if the preference already exists and adding it if not. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon May 1 14:57:07 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 01 May 2017 12:57:07 +0000 Subject: [Koha-bugs] [Bug 18494] Fix Letters.t (follow-up of 15702) In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18494 Marcel de Rooy changed: What |Removed |Added ---------------------------------------------------------------------------- Patch complexity|--- |Small patch Assignee|chris at bigballofwax.co.nz |lari.taskula at jns.fi QA Contact|gmcharlt at gmail.com |m.de.rooy at rijksmuseum.nl -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon May 1 14:57:27 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 01 May 2017 12:57:27 +0000 Subject: [Koha-bugs] [Bug 15705] Notify the user on auto renewing In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15705 Nick Clemens changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |nick at bywatersolutions.com Status|Signed Off |Patch doesn't apply -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon May 1 15:02:05 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 01 May 2017 13:02:05 +0000 Subject: [Koha-bugs] [Bug 18446] Test to ensure a system preference in .pref file also exists in sysprefs.sql In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18446 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |katrin.fischer at bsz-bw.de Status|Needs Signoff |Failed QA --- Comment #5 from Katrin Fischer --- I think before this can go in, we need 2 things: - Exclude marcflavour as it is added and set by the web installer - Write a patch to add the missing preferences to syspref.sql and maybe also have an atomicupdate checking for their existence and adding when needed to get to a clean state. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon May 1 15:07:09 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 01 May 2017 13:07:09 +0000 Subject: [Koha-bugs] [Bug 18447] Datepicker only shows -10/+10 years for date of birth In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18447 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |katrin.fischer at bsz-bw.de --- Comment #12 from Katrin Fischer --- Having more than 10 years past globally makes sense to me, but 100 seems a bit much. I am thinking of date pickers in acq/serials for example. Maybe: Global: -20, +19 Date of birth. -100, +0 But not opposed to a general change of -100, +10 either. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon May 1 15:08:46 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 01 May 2017 13:08:46 +0000 Subject: [Koha-bugs] [Bug 18517] New: Update German web installer sample files for 17.05 Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18517 Bug ID: 18517 Summary: Update German web installer sample files for 17.05 Change sponsored?: --- Product: Koha Version: 16.11 Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Installation and upgrade (web-based installer) Assignee: koha-bugs at lists.koha-community.org Reporter: katrin.fischer at bsz-bw.de QA Contact: testopia at bugs.koha-community.org CC: gmcharlt at gmail.com Same procedure as every new release - update translated installer files to have all the new translations and check for missing things. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Mon May 1 15:20:38 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 01 May 2017 13:20:38 +0000 Subject: [Koha-bugs] [Bug 18516] Add possibility to import text from file based help system as news based help system item In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18516 --- Comment #1 from Marc V?ron --- Created attachment 62918 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=62918&action=edit Bug 18516 - Add possibility to import text from file based help system as news based help system item Adds additional button to help page to import text from file based help to a new news based help item. First draft - proof of concept. Not yet ready to sign-off. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon May 1 15:24:44 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 01 May 2017 13:24:44 +0000 Subject: [Koha-bugs] [Bug 18458] Merging authority record incorrectly orders subfields In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18458 --- Comment #2 from Marcel de Rooy --- (In reply to Nick Clemens from comment #0) > When merging two authorities and updating the linked biblios > MARC::Field->new() is called with the tagnumber, indicators, and the new > subfield $9 > > This causes this subfield to be the first in the field as a whole and is > inconsistent with usualy ordering The old merge routine did actually do the same. Also note that we normally have the $9 before the a..z subfields in the editor. This does not mean that we should do it differently of course. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon May 1 15:40:05 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 01 May 2017 13:40:05 +0000 Subject: [Koha-bugs] [Bug 18505] OPAC Search History page does not respect OpacPublic syspref In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18505 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |katrin.fischer at bsz-bw.de --- Comment #2 from Katrin Fischer --- Good catch! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon May 1 15:44:21 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 01 May 2017 13:44:21 +0000 Subject: [Koha-bugs] [Bug 18505] OPAC Search History page does not respect OpacPublic syspref In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18505 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off Patch complexity|--- |Trivial patch -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon May 1 15:44:24 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 01 May 2017 13:44:24 +0000 Subject: [Koha-bugs] [Bug 18505] OPAC Search History page does not respect OpacPublic syspref In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18505 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #62809|0 |1 is obsolete| | --- Comment #3 from Katrin Fischer --- Created attachment 62919 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=62919&action=edit [SIGNED OFF]] BUG 18505: opac-search-history does not respect opacPublic The opac-search-history page was available regardless of the opacPublic setting, this patch corrects that. Test plan, set opacPublic to 'No', test whether opac-search-history page is available when not logged in, note that it is. Apply patch, test whether opac-search-history is still available when not logged in, note that you should be redirected to the login page. Signed-off-by: Katrin Fischer -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon May 1 16:20:54 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 01 May 2017 14:20:54 +0000 Subject: [Koha-bugs] [Bug 2093] Add OPAC dashboard for logged-in users In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=2093 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |oleonard at myacpl.org --- Comment #4 from Katrin Fischer --- Hi Aleisha, I have tested this a bit and only some small comments: - Welcome, always displays, even if there is no other information to be displayed below. I think I'd either not display it, if there is no more information to show or show the other entries with 0/no - 5.00 due = To make it a little easier to translate, I suggest to change it a bit, maybe 5.00 due in fines and charges (if that is English...). Single small words with multiple meanings are often hard to translate right. Making it more specific would help. Adding Owen for ideas on the styling! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon May 1 16:36:50 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 01 May 2017 14:36:50 +0000 Subject: [Koha-bugs] [Bug 2454] Don't show credits on Pay Fines Tab In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=2454 --- Comment #7 from Katrin Fischer --- I have to say that the credits system is kind of a mystery to me, as it seems... broken? But the display is better with these patches. Just a little concerned about those lines: + [% ELSE %] + Credit + [% END %] Why not check for accounttype = 'C' instead? -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon May 1 16:39:39 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 01 May 2017 14:39:39 +0000 Subject: [Koha-bugs] [Bug 18518] New: The staff interface "blink" for different actions after upgrading to Firefox 53 Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18518 Bug ID: 18518 Summary: The staff interface "blink" for different actions after upgrading to Firefox 53 Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Browser compatibility Assignee: oleonard at myacpl.org Reporter: francois.charbonnier at inlibro.com QA Contact: testopia at bugs.koha-community.org After upgrading to firefox 53 (ubuntu 14.04) I noticed the interface "blinks" when I check out an item (on Koha 16.05) I tried this with firefox 52, the interface stays still. Marc Veron reproduced the issue on the current master : - On the staff client main page, click on 'Patrons' - While loading the page, I see very shortly a yellow message "Add patrons to" (I took a video and stepped through it to be able to read the text). - Then the page refreshes and displays as expected. - I get the same when I am on the page Home > Patrons and click 'Search'. I get it with Firefox 53.0 (Windows) I do not get it with Firefox ESR 45.3.0 (Debian) Marc suggests the message "Add patrons to" should not be triggered. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon May 1 16:41:19 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 01 May 2017 14:41:19 +0000 Subject: [Koha-bugs] [Bug 18518] The staff interface "blink" for different actions after upgrading to Firefox 53 In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18518 Francois Charbonnier changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |philippe.blouin at inlibro.com -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon May 1 16:47:06 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 01 May 2017 14:47:06 +0000 Subject: [Koha-bugs] [Bug 3137] Add sys pref to collapse areas of the patron add by default In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=3137 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |katrin.fischer at bsz-bw.de --- Comment #4 from Katrin Fischer --- I have tested this quickly, but there is a display problem, where not all sections reappear. What I have done: - In the system preference, select all and save - In the patron add form, display all using the link - Notice some areas don't disappear/blue blocks are shown (see screenshot attached) I really like the idea of simplyfing the form a bit, but I would like to suggest to make use of the initial idea of collapsing/uncollapsing sections. Following scenario: I have a minimal patron add form with say, the second and third address hidden by default. While entering the data, I notice that I have to enter a second address. With this patch, I have to scroll back up, unlock all the hidden fields, scroll down and find the right ones. I think it would be nicer if the interface would always show the section headings (collapsing some according to the system preference) and then allow me to click on the heading to uncollapse/unfold the fields. That way I could keep entering data without the scrolling action. I hope that makes sense! -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon May 1 16:48:21 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 01 May 2017 14:48:21 +0000 Subject: [Koha-bugs] [Bug 3137] Add sys pref to collapse areas of the patron add by default In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=3137 --- Comment #5 from Katrin Fischer --- Created attachment 62920 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=62920&action=edit display problem when unhiding all -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon May 1 16:49:17 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 01 May 2017 14:49:17 +0000 Subject: [Koha-bugs] [Bug 3137] Add sys pref to collapse areas of the patron add by default In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=3137 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Failed QA -- You are receiving this mail because: You are watching all bug changes. You are the QA Contact for the bug. From bugzilla-daemon at bugs.koha-community.org Mon May 1 17:00:37 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 01 May 2017 15:00:37 +0000 Subject: [Koha-bugs] [Bug 3311] Statistical reports should error if row and column aren' t selected In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=3311 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |In Discussion --- Comment #47 from Katrin Fischer --- While testing this I noticed that the Acquisitions and Holds statistics have column and row preselected - could this be a more elegant way of solving this problem? What I don't like about this patch is the changes to the pull downs. Instead of empty for 'non-filtered' it shows a text now. Quickly scanning the form, this makes it much harder to see, what was actually filtered on (lots of text). This is not part of the problem description and should be dealt with and discussed separately. - + Sorry, not signing off. Not sure which status to set - in Discussion? -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon May 1 17:12:58 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 01 May 2017 15:12:58 +0000 Subject: [Koha-bugs] [Bug 4460] Amazon' s AssociateID tag not used in links so referred revenue lost In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=4460 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Patch complexity|--- |Trivial patch Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. You are the QA Contact for the bug. From bugzilla-daemon at bugs.koha-community.org Mon May 1 17:13:02 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 01 May 2017 15:13:02 +0000 Subject: [Koha-bugs] [Bug 4460] Amazon' s AssociateID tag not used in links so referred revenue lost In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=4460 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #57688|0 |1 is obsolete| | --- Comment #34 from Katrin Fischer --- Created attachment 62921 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=62921&action=edit [SIGNED OFF] Bug 4460: Amazon's AssociateID tag not used in links so referred revenue lost Reworking based on output of: git grep "gp\/reader" Additionally, some changes might be in order though gp/reader works. https://affiliate-program.amazon.com/help/topic/t64/a1 suggests using dp A dp was discovered, so that part of the URL was left unchanged. The "/ref..." part was changed to just an Amazon tag ("?tag={AAT}") if defined. TEST PLAN --------- 1) Added: "100 years of Canadian foreign policy / edited by Robert Bothwell and Jean Daudelin." 2) Added a second book with the word foreign in the title. 3) Waited for reindex 4) Checked out the Canadian foreign policy book. 5) Applied patch 6) Made sure that: - AmazonAssocTag was set to TEST (easy to notice) - AmazonCoverImages was set to 'Show' - OPACAmazonCoverImages was set to 'Show' 7) Searched intranet for 'foreign' to find the detail page -- hovering over picture shows URL with ?tag=TEST in it. 8) Went to the OPAC Detail page 9) Toggling OPACURLOpenInNewWindow, confirmed that URL for the picture contained ?tag=TEST in it. 10) Logged into the OPAC 11) Confirmed the URL in the checked out list on your summary page contained ?tag=TEST in it. 12) Confirmed the URL in the checked out list on your reading history page contained ?tag=TEST in it. 13) Confirmed links worked (went to expected page) 14) run koha qa test tools Followed test plan. Works as expected. Signed-off-by: Marc V?ron Signed-off-by: Marc V?ron Signed-off-by: Katrin Fischer -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon May 1 17:16:29 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 01 May 2017 15:16:29 +0000 Subject: [Koha-bugs] [Bug 4460] Amazon' s AssociateID tag not used in links so referred revenue lost In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=4460 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #62921|0 |1 is obsolete| | --- Comment #35 from Katrin Fischer --- Created attachment 62922 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=62922&action=edit [SIGNED OFF] Bug 4460: Amazon's AssociateID tag not used in links so referred revenue lost Reworking based on output of: git grep "gp\/reader" Additionally, some changes might be in order though gp/reader works. https://affiliate-program.amazon.com/help/topic/t64/a1 suggests using dp A dp was discovered, so that part of the URL was left unchanged. The "/ref..." part was changed to just an Amazon tag ("?tag={AAT}") if defined. TEST PLAN --------- 1) Added: "100 years of Canadian foreign policy / edited by Robert Bothwell and Jean Daudelin." 2) Added a second book with the word foreign in the title. 3) Waited for reindex 4) Checked out the Canadian foreign policy book. 5) Applied patch 6) Made sure that: - AmazonAssocTag was set to TEST (easy to notice) - AmazonCoverImages was set to 'Show' - OPACAmazonCoverImages was set to 'Show' 7) Searched intranet for 'foreign' to find the detail page -- hovering over picture shows URL with ?tag=TEST in it. 8) Went to the OPAC Detail page 9) Toggling OPACURLOpenInNewWindow, confirmed that URL for the picture contained ?tag=TEST in it. 10) Logged into the OPAC 11) Confirmed the URL in the checked out list on your summary page contained ?tag=TEST in it. 12) Confirmed the URL in the checked out list on your reading history page contained ?tag=TEST in it. 13) Confirmed links worked (went to expected page) 14) run koha qa test tools Followed test plan. Works as expected. Signed-off-by: Marc V?ron Signed-off-by: Marc V?ron Signed-off-by: Katrin Fischer -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon May 1 17:16:59 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 01 May 2017 15:16:59 +0000 Subject: [Koha-bugs] [Bug 4460] Amazon' s AssociateID tag not used in links so referred revenue lost In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=4460 --- Comment #36 from Katrin Fischer --- (In reply to Marc V?ron from comment #33) > Created attachment 60127 [details] > Error message on Amazon > > I tested some weeks ago and now again, the link to Amazon leads to an error > message (see screenshot). > Tested from Intranet detail page with "100 years of Canadian foreign policy > / edited by Robert Bothwell and Jean Daudelin." > Link to Amazon is: > https://www.amazon.com/gp/reader/0773534342?tag=TEST#reader-link Hm, I see the same problem without this patch as well - I think Amazon might have changed something. To me this appears to happen, when we have #reader-link attached and there is no 'reader link' (preview feature) available for the article on Amazon. Something else I noticed is that we open the Amazon page in the same tab, for external sources, it's better to always open in a new tab. Should we take those 2 issues to a new bug? I've signed off on those patches for fixing the problem with the AssociateID. -- You are receiving this mail because: You are watching all bug changes. You are the QA Contact for the bug. From bugzilla-daemon at bugs.koha-community.org Mon May 1 17:24:23 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 01 May 2017 15:24:23 +0000 Subject: [Koha-bugs] [Bug 18505] OPAC Search History page does not respect OpacPublic syspref In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18505 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #62919|0 |1 is obsolete| | --- Comment #4 from Katrin Fischer --- Created attachment 62923 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=62923&action=edit [SIGNED OFF] BUG 18505: opac-search-history does not respect opacPublic The opac-search-history page was available regardless of the opacPublic setting, this patch corrects that. Test plan, set opacPublic to 'No', test whether opac-search-history page is available when not logged in, note that it is. Apply patch, test whether opac-search-history is still available when not logged in, note that you should be redirected to the login page. Signed-off-by: Katrin Fischer -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon May 1 17:25:09 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 01 May 2017 15:25:09 +0000 Subject: [Koha-bugs] [Bug 18505] OPAC Search History page does not respect OpacPublic syspref In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18505 --- Comment #5 from Katrin Fischer --- Fixed my sign-off line. Martin, do you want to fix authorship too? From: PTFS Admin -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon May 1 17:29:42 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 01 May 2017 15:29:42 +0000 Subject: [Koha-bugs] [Bug 3311] Statistical reports should error if row and column aren' t selected In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=3311 --- Comment #48 from M. Tompsett --- (In reply to Katrin Fischer from comment #47) > While testing this I noticed that the Acquisitions and Holds statistics have > column and row preselected - could this be a more elegant way of solving > this problem? It is a "less is more" type solution. Though, someone would need to specify what row and columns are picked by default. And since the original report says, "When running Statistical Reports, interface does not clearly specify that both a column and a row must be selected. User is able to generate a report with selection of just row. Koha should either error out, or add instructions on-screen indicating both column and row are required." It says nothing of defaults, hence this solution. > What I don't like about this patch is the changes to the pull downs. Instead > of empty for 'non-filtered' it shows a text now. Quickly scanning the form, > this makes it much harder to see, what was actually filtered on (lots of > text). This is not part of the problem description and should be dealt with > and discussed separately. True, I creeped the scope to include fixing the HTML. The HTML as it is triggered validation errors. Owen had suggested his preference would be some text describing what the actual blank value means. I can provide another patch to reset those parts. > Sorry, not signing off. Not sure which status to set - in Discussion? I suppose. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon May 1 17:34:04 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 01 May 2017 15:34:04 +0000 Subject: [Koha-bugs] [Bug 4461] Context-sensitive report a problem screen In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=4461 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |katrin.fischer at bsz-bw.de Status|Needs Signoff |Patch doesn't apply --- Comment #7 from Katrin Fischer --- Hi Aleisha, this doesn't apply. It is recommended to have the changes to the Schema in a separate patch, because it's likely to conflict a lot. This way one can opt to not apply the patch and run the schema update locally when testing or pushing and you don't have to rebase as often. https://wiki.koha-community.org/wiki/Database_updates#Changes_with_DBIx::Class -- You are receiving this mail because: You are watching all bug changes. You are the QA Contact for the bug. From bugzilla-daemon at bugs.koha-community.org Mon May 1 17:34:59 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 01 May 2017 15:34:59 +0000 Subject: [Koha-bugs] [Bug 4461] Context-sensitive report a problem screen In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=4461 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Patch doesn't apply |Needs Signoff --- Comment #8 from Katrin Fischer --- Ok... partially talking nonsense. It DOES currently apply! -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon May 1 17:53:41 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 01 May 2017 15:53:41 +0000 Subject: [Koha-bugs] [Bug 18516] Add possibility to import text from file based help system as news based help system item In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18516 Marc V?ron changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #62918|0 |1 is obsolete| | --- Comment #2 from Marc V?ron --- Created attachment 62924 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=62924&action=edit Bug 18516 - Add possibility to import text from file based help system as news based help system item Adds additional button to help page to import text from file based help to a new news based help item. First draft - proof of concept. Amended to filter out template directives and correct help links from text that will be used. Not yet ready to sign-off. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Mon May 1 17:54:43 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 01 May 2017 15:54:43 +0000 Subject: [Koha-bugs] [Bug 12027] Shibboleth authentication for staff client In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12027 --- Comment #24 from Martin Renvoize --- (In reply to M. Tompsett from comment #23) > (In reply to Martin Renvoize from comment #13) > > https://wiki.koha-community.org/wiki/Shibboleth_Configuration > > Sweet, tangentially, do we have attempts at other authentication methods? > Also, we should also have a bug for changing the StaffBaseURL to include the > protocol. After all, shibboleth requires https, does it not? This patch does allow fallback logins as per OPAC shibboleth, although due to the nature of shibboleth the same caveats apply (i.e. once you've clicked the 'login via shibboleth' link and been redirected to the IdP, if you fail to login you won't get redirected back to the koha client, so you'll have to navigate back yourself to use a fallback method. This is protocol specific and at the IdP end, there's no way to fix this at the koha side) Bug 18506 allows for a 'Shibboleth Only' mode should you wish to use shibboleth in that way. Hmm, I must admit I'd lost track fo the StaffBaseURL preference and whether it allowed specifying a protocol or not now; I best check up on that one. Cheers -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon May 1 17:54:55 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 01 May 2017 15:54:55 +0000 Subject: [Koha-bugs] [Bug 4461] Context-sensitive report a problem screen In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=4461 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Failed QA --- Comment #9 from Katrin Fischer --- Really like the feature! Maybe we should add something like this to staff too? Possible problems: - Instead of tabs have a simple pull down to switch the recipient. At the moment, if you have typed up your message and then change your mind about whom to send it to, you have to start over as the text won't carry over from one tab to the other. - When submitting a problem report to the aministrator and there is no branch email supplied, the 'success' message and the 'error' message will both show at the same time after submitting. This might be confusing to the patron. Maybe we could avoid that by showing the 'error' next to the submit button or if we didn't have the tabs, not show the option to email the library at all, when there is no email address set for the branch? - There are some constraints with email sending if you are hosted and using the provider's mail server. So a while ago we have added branchreplyto (branches) and ReplyToDefault (system preference). It would be cool if you could check those first and email there if they are set and then fall back to branchemal and KohaAdminEmailAddress (like it's done for overdues etc.) - If you are not logged in when clicking on 'report a bug' the problem will be reported against the opac-reportproblem page. Questions: - I know that the feature can be hidden using the id (thx!), but maybe this should also be a preference? - How will the table in the database be maintained? Is there a way to empty it or plans to make it accessible from the GUI? -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon May 1 18:01:55 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 01 May 2017 16:01:55 +0000 Subject: [Koha-bugs] [Bug 18505] OPAC Search History page does not respect OpacPublic syspref In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18505 --- Comment #6 from Martin Renvoize --- Oh, good catch on the Authorship line.. I must have done the original work on a different server to normal. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon May 1 18:03:21 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 01 May 2017 16:03:21 +0000 Subject: [Koha-bugs] [Bug 18505] OPAC Search History page does not respect OpacPublic syspref In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18505 --- Comment #7 from Martin Renvoize --- Created attachment 62925 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=62925&action=edit BUG 18505: opac-search-history does not respect opacPublic The opac-search-history page was available regardless of the opacPublic setting, this patch corrects that. Test plan, set opacPublic to 'No', test whether opac-search-history page is available when not logged in, note that it is. Apply patch, test whether opac-search-history is still available when not logged in, note that you should be redirected to the login page. Signed-off-by: Katrin Fischer -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon May 1 18:03:52 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 01 May 2017 16:03:52 +0000 Subject: [Koha-bugs] [Bug 18505] OPAC Search History page does not respect OpacPublic syspref In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18505 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #62923|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon May 1 18:04:08 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 01 May 2017 16:04:08 +0000 Subject: [Koha-bugs] [Bug 18505] OPAC Search History page does not respect OpacPublic syspref In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18505 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #62925|BUG 18505: |[SIGNED OFF] BUG 18505: description|opac-search-history does |opac-search-history does |not respect opacPublic |not respect opacPublic -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon May 1 18:05:55 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 01 May 2017 16:05:55 +0000 Subject: [Koha-bugs] [Bug 5620] Capture Mode of payment In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5620 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |katrin.fischer at bsz-bw.de Status|Needs Signoff |In Discussion --- Comment #17 from Katrin Fischer --- Hi all, some thoughts while looking at this. At the moment we already have a way to display the mode of payment when the fine is paid via SIP. In this case different accounttype values are used: >From pay.tt: [% SWITCH line.accounttype %] [% CASE 'Pay' %]Payment, thanks [% CASE 'Pay00' %]Payment, thanks (cash via SIP2) [% CASE 'Pay01' %]Payment, thanks (VISA via SIP2) [% CASE 'Pay02' %]Payment, thanks (credit card via SIP2) ... I think we should try and not have 2 separate ways of doing this depending on payment at the desk or at the self check as this will lead to more confusion and also make it harder to wrote reports etc. We could also discuss if this should be an authorised value or not. The advantage is, that the library can change it. The disadvantage is that the disadvantage is, that we can only display the values in one langauge at the moment. With the accounttype approach, we'd have to agree on a set of payment methods, but those would be translatable. I am changing this to 'in Discussion'. Please note that this does also currently not apply. -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon May 1 18:06:17 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 01 May 2017 16:06:17 +0000 Subject: [Koha-bugs] [Bug 6473] Test bug for Git-bz In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6473 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Patch doesn't apply -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon May 1 18:13:20 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 01 May 2017 16:13:20 +0000 Subject: [Koha-bugs] [Bug 18505] OPAC Search History page does not respect OpacPublic syspref In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18505 --- Comment #8 from Katrin Fischer --- Only noticed because of my own mistake (typo in my git alias) :) -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon May 1 18:28:27 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 01 May 2017 16:28:27 +0000 Subject: [Koha-bugs] [Bug 18518] The staff interface "blink" for different actions after upgrading to Firefox 53 In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18518 Marc V?ron changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |veron at veron.ch --- Comment #1 from Marc V?ron --- Update: I could reproduce with Firefox ESR 45.3.0 (Debian) as well by slowing it down (turned on syspref DumpTemplateVarsIntranet, it consumes quite a lot of time). I think the problem is related to document.ready It contains hide() functions at several places. Maybe they could be rearranged (moved up to the top) where applicable. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon May 1 18:39:58 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 01 May 2017 16:39:58 +0000 Subject: [Koha-bugs] [Bug 18509] Minor performance improvement for overdue_notices.pl In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18509 Barton Chittenden changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |barton at bywatersolutions.com --- Comment #1 from Barton Chittenden --- This is fixed in bug 17952 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon May 1 18:44:47 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 01 May 2017 16:44:47 +0000 Subject: [Koha-bugs] [Bug 18494] Fix Letters.t (follow-up of 15702) In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18494 --- Comment #9 from M. Tompsett --- (In reply to Lari Taskula from comment #2) > Now that I'm looking at this closer, I don't yet understand why it > originally fails. If $patron_category is passed as a hashref to ->find, I'm > thinking it should still work... I tested it on another container running > with slightly different version and I don't experience this failure. Because the builder returns a hash code, when the patron_category is supposed to be a scalar. The solution in comment #0 is correct. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon May 1 18:46:05 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 01 May 2017 16:46:05 +0000 Subject: [Koha-bugs] [Bug 18494] Fix Letters.t (follow-up of 15702) In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18494 --- Comment #10 from M. Tompsett --- (In reply to Lari Taskula from comment #2) > I don't yet understand why it originally fails. Also, there was a double comma. Wrong number of commas do weird things! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon May 1 18:48:11 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 01 May 2017 16:48:11 +0000 Subject: [Koha-bugs] [Bug 18494] Fix Letters.t (follow-up of 15702) In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18494 M. Tompsett changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon May 1 18:48:14 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 01 May 2017 16:48:14 +0000 Subject: [Koha-bugs] [Bug 18494] Fix Letters.t (follow-up of 15702) In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18494 --- Comment #11 from M. Tompsett --- Created attachment 62926 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=62926&action=edit Bug 18494: Pass a code, not hash & Fix double commas TEST PLAN --------- 1) prove -v t/db_dependent/Letters.t -- fails at test 5 or so. 2) apply patch 3) run step 1 -- success 4) run koha qa test tools -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon May 1 18:49:39 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 01 May 2017 16:49:39 +0000 Subject: [Koha-bugs] [Bug 18494] Fix Letters.t (follow-up of 15702) In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18494 --- Comment #12 from M. Tompsett --- DO NOT APPLY BOTH! The second one is my counter-patch. If that is acceptable. obsolete the first and sign off the second. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon May 1 18:56:08 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 01 May 2017 16:56:08 +0000 Subject: [Koha-bugs] [Bug 18519] New: Add ability to skip irrelevant dates in Koha::Calendar Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18519 Bug ID: 18519 Summary: Add ability to skip irrelevant dates in Koha::Calendar Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Architecture, internals, and plumbing Assignee: gmcharlt at gmail.com Reporter: barton at bywatersolutions.com QA Contact: testopia at bugs.koha-community.org We've seen occurrences of fines.pl and overdue_notices.pl slowing down when there are a large number of (usually old) entries in special_holidays table. Apparently, we're checking each candidate day against the whole fines calendar -- this is unnecessary, as both fines and overdue notices are are bounded; we only need to check the calendar enteries between the current day and the relevant letter delay (for overdue notices) or between the day the item went overdue and the current day (for fines). If we could pass in a start and end date, we could eliminate this overhead. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon May 1 19:01:56 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 01 May 2017 17:01:56 +0000 Subject: [Koha-bugs] [Bug 18520] New: special_holidays should be unique by date and branch code Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18520 Bug ID: 18520 Summary: special_holidays should be unique by date and branch code Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Holidays Assignee: koha-bugs at lists.koha-community.org Reporter: barton at bywatersolutions.com QA Contact: testopia at bugs.koha-community.org I just found a library that had up to 7 entries in the special_holidays table for a given combination of branchcode and year, month, day. This doesn't make sense, it's not fixable in the UI, and it can cause performance issues, because all values will be checked. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Mon May 1 19:39:49 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 01 May 2017 17:39:49 +0000 Subject: [Koha-bugs] [Bug 18518] The staff interface "blink" for different actions after upgrading to Firefox 53 In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18518 --- Comment #2 from Marc V?ron --- OK, there are several elements hiding / unhiding, one of them is the patron lists dialog. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon May 1 19:41:27 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 01 May 2017 17:41:27 +0000 Subject: [Koha-bugs] [Bug 18518] The staff interface "blink" for different actions after upgrading to Firefox 53 In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18518 --- Comment #3 from Marc V?ron --- Created attachment 62927 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=62927&action=edit Bug 18518: Hide patron list dialog by default This patch hides the patron list dialog by default to prevent it to display shortly when koha/members/member.pl is called. There are more reasons for the blinking of the page, but at least the yellow patron list dialog does no longer display without having to. To test: - Slow down system by enabling syspref DumpTemplateVarsIntranet - Try to reproduce issue, see a yellow dialog come up for a very short time when member.pl is displayed (e.g. with a search) - Apply patch - Go to patron page - Try to reproduce. Page still blinks, but the dialog as one of the elements that produce bilnking does no longer show up - Verify that patron list functionality works as before (Select some patrons and add them to a patron list). -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon May 1 19:48:53 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 01 May 2017 17:48:53 +0000 Subject: [Koha-bugs] [Bug 18518] The staff interface "blink" for different actions after upgrading to Firefox 53 In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18518 --- Comment #4 from Marc V?ron --- The second reason for the blinking is that the form for the search filters shortly displays and then hides again. It moves the whole page down and up again. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon May 1 20:27:57 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 01 May 2017 18:27:57 +0000 Subject: [Koha-bugs] [Bug 12262] Searching patrons by extended attribute should be a search field In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12262 Marjorie Barry-Vila changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |marjorie.barry-vila at ccsr.qc | |.ca -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon May 1 20:31:25 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 01 May 2017 18:31:25 +0000 Subject: [Koha-bugs] [Bug 17952] Lost items not skipped by overdue_notices.pl In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17952 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |martin.renvoize at ptfs-europe | |.com --- Comment #4 from Martin Renvoize --- *** Bug 18509 has been marked as a duplicate of this bug. *** -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon May 1 20:31:25 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 01 May 2017 18:31:25 +0000 Subject: [Koha-bugs] [Bug 18509] Minor performance improvement for overdue_notices.pl In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18509 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- Resolution|--- |DUPLICATE Status|NEW |RESOLVED --- Comment #2 from Martin Renvoize --- Oh, nice spot, thanks for pointing that out.. means I won't have to extract it from our local branch :) Will mark resolved duplicate and take a look at the other bug. *** This bug has been marked as a duplicate of bug 17952 *** -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon May 1 20:32:27 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 01 May 2017 18:32:27 +0000 Subject: [Koha-bugs] [Bug 17952] Lost items not skipped by overdue_notices.pl In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17952 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- QA Contact|testopia at bugs.koha-communit |martin.renvoize at ptfs-europe |y.org |.com -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon May 1 20:34:14 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 01 May 2017 18:34:14 +0000 Subject: [Koha-bugs] [Bug 17952] Lost items not skipped by overdue_notices.pl In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17952 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #59551|0 |1 is obsolete| | --- Comment #5 from Martin Renvoize --- Created attachment 62928 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=62928&action=edit Bug 17952 - Lost items not skipped by overdue_notices.pl If a library does not use --mark-returned when running longoverdue.pl, all those lost item checkouts are selected by overdue_notices.pl. This causes much unnecessary overhead. In addition Koha::Calendar is instantiated many times for each branchcode which is not necessary. Test Plan: 1) Run overdue_notices.pl, note output 2) Apply this patch 3) Run overdue_notices.pl again, note output is the same Signed-off-by: Kyle M Hall Signed-off-by: Jane Leven Signed-off-by: Martin Renvoize -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon May 1 20:34:51 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 01 May 2017 18:34:51 +0000 Subject: [Koha-bugs] [Bug 17952] Lost items not skipped by overdue_notices.pl In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17952 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |NEW -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon May 1 20:34:59 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 01 May 2017 18:34:59 +0000 Subject: [Koha-bugs] [Bug 17952] Lost items not skipped by overdue_notices.pl In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17952 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon May 1 20:35:07 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 01 May 2017 18:35:07 +0000 Subject: [Koha-bugs] [Bug 17952] Lost items not skipped by overdue_notices.pl In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17952 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon May 1 20:37:29 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 01 May 2017 18:37:29 +0000 Subject: [Koha-bugs] [Bug 17952] Lost items not skipped by overdue_notices.pl In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17952 --- Comment #6 from Martin Renvoize --- OK, So in an ideal world I'd like to have seen these as separate bugs, but as it's still a fairly trivial change and the Koha::Calendar instantiation bug is fixed in the exact same way as I was intending on bug 18509 then I'm happy to sign off as a whole. Tested, but not definitively benchmarked to prove the improvement. It 'feels' more performant on the tests I ran. Signed off -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon May 1 20:37:39 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 01 May 2017 18:37:39 +0000 Subject: [Koha-bugs] [Bug 17952] Lost items not skipped by overdue_notices.pl In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17952 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- QA Contact|martin.renvoize at ptfs-europe |testopia at bugs.koha-communit |.com |y.org -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon May 1 21:23:21 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 01 May 2017 19:23:21 +0000 Subject: [Koha-bugs] [Bug 18521] New: Renew and search hotkeys are swapped on returns page. Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18521 Bug ID: 18521 Summary: Renew and search hotkeys are swapped on returns page. Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: trivial Priority: P5 - low Component: Staff Client Assignee: koha-bugs at lists.koha-community.org Reporter: tmcmahon at wlpl.org QA Contact: testopia at bugs.koha-community.org CC: gmcharlt at gmail.com The hotkeys for the tabs on the staff interface returns page (/cgi-bin/koha/circ/returns.pl) are not working correctly. Alt-W selects the tab labeled 'Search the catalog' and should select 'Renew'. Alt-Q selects the tab labeled 'Renew' and should select 'Search the catalog'. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon May 1 21:40:12 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 01 May 2017 19:40:12 +0000 Subject: [Koha-bugs] [Bug 18521] Renew and search hotkeys are swapped on returns page. In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18521 Nick Clemens changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |nick at bywatersolutions.com -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon May 1 21:41:06 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 01 May 2017 19:41:06 +0000 Subject: [Koha-bugs] [Bug 18518] The staff interface "blink" for different actions after upgrading to Firefox 53 In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18518 --- Comment #5 from Marc V?ron --- It seems that the mechanism in following file is broken: koha-tmpl/intranet-tmpl/prog/en/includes/patron-search.inc To visualise, add a delay to all functions toggle(), e.g. toggle 500 You will see that the page first displays with the filter fields set to visible, and then they are turned off by the toggle function. I can not find out how to fix. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon May 1 21:51:40 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 01 May 2017 19:51:40 +0000 Subject: [Koha-bugs] [Bug 6758] Capture membership renewal date for reporting purposes In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6758 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #62698|0 |1 is obsolete| | Attachment #62699|0 |1 is obsolete| | --- Comment #8 from Katrin Fischer --- Created attachment 62929 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=62929&action=edit [SIGNED OFF] Bug 6758 - Add new patron column for date of renewal Test Plan: 1) Apply this patch 2) Run updatedatabase 3) Create a new patron 4) Note the new column date_renewed is NULL 5) Renew the patron 6) Note the date in the column date_renewed is today's date Signed-off-by: Katrin Fischer -- You are receiving this mail because: You are watching all bug changes. You are the QA Contact for the bug. From bugzilla-daemon at bugs.koha-community.org Mon May 1 21:51:36 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 01 May 2017 19:51:36 +0000 Subject: [Koha-bugs] [Bug 6758] Capture membership renewal date for reporting purposes In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6758 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off Patch complexity|--- |Trivial patch -- You are receiving this mail because: You are watching all bug changes. You are the QA Contact for the bug. From bugzilla-daemon at bugs.koha-community.org Mon May 1 21:53:10 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 01 May 2017 19:53:10 +0000 Subject: [Koha-bugs] [Bug 6758] Capture membership renewal date for reporting purposes In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6758 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Patch complexity|Trivial patch |Medium patch --- Comment #9 from Katrin Fischer --- Obsoleted patch with the Schema change as it no longer applied. Tested by regenerating the Schema files locally. -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon May 1 21:55:55 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 01 May 2017 19:55:55 +0000 Subject: [Koha-bugs] [Bug 7419] Add authority deduplication script In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7419 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |katrin.fischer at bsz-bw.de Status|Needs Signoff |Failed QA --- Comment #61 from Katrin Fischer --- Patches apply, but there is are some problems noted by the qa script: FAIL misc/migration_tools/dedup_records.pl OK critic FAIL forbidden patterns forbidden pattern: merge marker (=======) (line 419) OK git manipulation OK pod OK spelling FAIL valid when is experimental -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon May 1 22:00:06 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 01 May 2017 20:00:06 +0000 Subject: [Koha-bugs] [Bug 7556] Use "preventDoubleFormSubmit()" more in the OPAC and Intranet to prevent duplicate data In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7556 --- Comment #7 from Katrin Fischer --- I am a bit confused by the changes to history.txt in this patch set, can someone explain? -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon May 1 22:00:40 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 01 May 2017 20:00:40 +0000 Subject: [Koha-bugs] [Bug 7556] Use "preventDoubleFormSubmit()" more in the OPAC and Intranet to prevent duplicate data In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7556 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Patch doesn't apply --- Comment #8 from Katrin Fischer --- I am a bit confused by the changes to history.txt in this patch set, can someone explain? -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon May 1 22:19:19 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 01 May 2017 20:19:19 +0000 Subject: [Koha-bugs] [Bug 7611] Show the NOT_LOAN authorised values for item status in XSLT OPAC search results. In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7611 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |katrin.fischer at bsz-bw.de --- Comment #10 from Katrin Fischer --- Created attachment 62930 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=62930&action=edit Screenshot Tested with a record with 5 items: - no status set, normal itemtype - no status set, itemtype is marked as not for loan - damaged: damaged - not for loan: staff collection - not for loan: on order - As soon as I added the item with the not for loan itemtype an additional blank line appeared between the available and unavailable items - Before the patch the items were counted as 'available' in green, after the patch the not for loan items are counted as 'unavailable' in red. I think this is a somewhat unexpected change. As I see it we define availability as 'accessible', but not necessarily as 'for loan'. I think this change needs to be discussed. - Showing the authorised value description means that this will no longer be translatable. For libraries offering the OPAC in multiple languages this might be a problem (we really need to make authorised values multi-lang as the itemtypes). Marking failed for the additional blank line. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon May 1 22:21:32 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 01 May 2017 20:21:32 +0000 Subject: [Koha-bugs] [Bug 18521] Renew and search hotkeys are swapped on returns page. In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18521 Marc V?ron changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |veron at veron.ch --- Comment #1 from Marc V?ron --- Confirmed. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon May 1 22:21:56 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 01 May 2017 20:21:56 +0000 Subject: [Koha-bugs] [Bug 7611] Show the NOT_LOAN authorised values for item status in XSLT OPAC search results. In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7611 --- Comment #11 from Katrin Fischer --- Created attachment 62931 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=62931&action=edit Screenshot of current display Current display for comparison (note: my items didn't have callnumbers) -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon May 1 22:22:47 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 01 May 2017 20:22:47 +0000 Subject: [Koha-bugs] [Bug 7611] Show the NOT_LOAN authorised values for item status in XSLT OPAC search results. In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7611 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Failed QA -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon May 1 22:41:02 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 01 May 2017 20:41:02 +0000 Subject: [Koha-bugs] [Bug 7960] choice to not show the text labels for item types In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7960 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #62344|0 |1 is obsolete| | Attachment #62807|0 |1 is obsolete| | --- Comment #4 from Katrin Fischer --- Created attachment 62932 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=62932&action=edit [SIGNED OFF] Bug 7960: Add syspref to hide/show item type text labels in catalog To test: 1) Apply patch and update database 2) Go to Admin -> Sysprefs -> Find system preference 'ItemTypeText' 3) Should have default value 'Show'. Change to 'Don't show'. 4) Make sure 'noItemTypeImages' is enabled. 5) Search for a record in catalog on staff client. Go to detail page. 6) Confirm the text label for the item type is hidden, but the item type image still shows. 7) Search for a record in catalog on OPAC. Go to detail page. 8) Confirm the text label for the item type is hidden, but the item type image still shows. 9) Go back to sysprefs and set 'ItemTypeText' to 'Show'. 10) Confirm text labels now show on detail pages. Sponsored-by: Catalyst IT Signed-off-by: Katrin Fischer -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon May 1 22:40:58 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 01 May 2017 20:40:58 +0000 Subject: [Koha-bugs] [Bug 7960] choice to not show the text labels for item types In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7960 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon May 1 22:41:51 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 01 May 2017 20:41:51 +0000 Subject: [Koha-bugs] [Bug 7960] choice to not show the text labels for item types In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7960 --- Comment #5 from Katrin Fischer --- Created attachment 62933 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=62933&action=edit [SIGNED OFF] Bug 7960: [FOLLOW-UP] Adding to places missed in first patch This patch adds the use of the syspref to: = STAFF CLIENT = - catalogue/advsearch.tt - catalogue/detail.tt - catalogue/results.tt - reserve/request.tt - virtualshelves/shelves.tt = OPAC = - opac-advsearch.tt - opac-detail.tt - opac-readingrecord.tt - opac-reserve.tt - opac-results-grouped.tt - opac-shelves.tt - opac-user.tt Sponsored-by: Catalyst IT Signed-off-by: Katrin Fischer -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon May 1 22:43:24 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 01 May 2017 20:43:24 +0000 Subject: [Koha-bugs] [Bug 7960] choice to not show the text labels for item types In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7960 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |katrin.fischer at bsz-bw.de --- Comment #6 from Katrin Fischer --- Nice one to test! 2 notes: - In order to see some of the changes you need to set item-level_itypes to 'biblio record'. - In the OPAC the 'most popular' page currently displays the biblio level itemtype description. A later patch could make it show the icon and add support for the system preferences. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon May 1 23:11:22 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 01 May 2017 21:11:22 +0000 Subject: [Koha-bugs] [Bug 8000] Test mode for notices In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8000 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |In Discussion --- Comment #119 from Katrin Fischer --- (In reply to Katrin Fischer from comment #107) > Looking at this I am wondering if it wouldn't be better to implement the > fallback to the central email address in Koha/Email.pm. It also takes care > of other fallbacks like the reply-to addresses. > It could avoid changes in some of the files and put things in a central spot. I am still confused about having so much duplicated code if we could just override the To => $params->{to} in Koha::Email? What am I missing? Can you please explain why this other approach was taken? -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon May 1 23:18:02 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 01 May 2017 21:18:02 +0000 Subject: [Koha-bugs] [Bug 8628] Add digital signs to the OPAC In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8628 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Failed QA CC| |katrin.fischer at bsz-bw.de --- Comment #12 from Katrin Fischer --- The QA scripts are pointing out some issues with these patches: FAIL installer/data/mysql/atomicupdate/bug_8628-digital-signs-sysprefs.sql OK git manipulation FAIL semicolon simicolon found instead of comma at line 1 simicolon found instead of comma at line 3 simicolon found instead of comma at line 2 OK sysprefs_order FAIL installer/data/mysql/kohastructure.sql FAIL charset_collate The table sign_streams does not have the current charset collate (see bug 11944) The table signs_to_streams does not have the current charset collate (see bug 11944) The table signs does not have the current charset collate (see bug 11944) OK git manipulation OK installer/data/mysql/sysprefs.sql OK git manipulation OK semicolon OK sysprefs_order OK koha-tmpl/intranet-tmpl/prog/en/includes/tools-menu.inc OK forbidden patterns OK git manipulation OK spelling OK tt_valid OK valid_template FAIL koha-tmpl/intranet-tmpl/prog/en/modules/tools/signs.tt FAIL forbidden patterns forbidden pattern: Contains old bootstrap style for buttons (see bug 16239) (line 407) forbidden pattern: Contains old bootstrap style for buttons (see bug 16239) (line 441) forbidden pattern: Contains old bootstrap style for buttons (see bug 16239) (line 227) forbidden pattern: Contains old bootstrap style for buttons (see bug 16239) (line 86) forbidden pattern: Contains old bootstrap style for buttons (see bug 16239) (line 87) forbidden pattern: Contains old bootstrap style for buttons (see bug 16239) (line 226) forbidden pattern: Contains old bootstrap style for buttons (see bug 16239) (line 442) OK git manipulation OK spelling OK tt_valid OK valid_template OK koha-tmpl/intranet-tmpl/prog/en/modules/tools/tools-home.tt OK forbidden patterns OK git manipulation OK spelling OK tt_valid OK valid_template FAIL koha-tmpl/opac-tmpl/bootstrap/en/modules/opac-signs.tt FAIL forbidden patterns forbidden pattern: simple-quote string (line 468) forbidden pattern: opac-tmpl should certainly replaced with [% interface %] (line 561) forbidden pattern: opac-tmpl should certainly replaced with [% interface %] (line 67) forbidden pattern: simple-quote string (line 464) forbidden pattern: simple-quote string (line 448) forbidden pattern: simple-quote string (line 450) forbidden pattern: simple-quote string (line 465) forbidden pattern: opac-tmpl should certainly replaced with [% interface %] (line 462) forbidden pattern: opac-tmpl should certainly replaced with [% interface %] (line 70) forbidden pattern: simple-quote string (line 478) forbidden pattern: opac-tmpl should certainly replaced with [% interface %] (line 69) OK git manipulation FAIL spelling initilize ==> initialize OK tt_valid OK valid_template FAIL opac/opac-signs.pl OK critic FAIL forbidden patterns forbidden pattern: Koha is now under the GPLv3 license (line 9) OK git manipulation OK pod OK spelling OK valid FAIL tools/signs.pl OK critic FAIL forbidden patterns forbidden pattern: Koha is now under the GPLv3 license (line 9) OK git manipulation OK pod OK spelling OK valid -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon May 1 23:37:57 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 01 May 2017 21:37:57 +0000 Subject: [Koha-bugs] [Bug 8628] Add digital signs to the OPAC In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8628 --- Comment #13 from Katrin Fischer --- Took a quick look at the code of the patches too: 1) There is an atomicupdate for adding a new permission edit_digital_signs, but no corresponding change to koha-tmpl/intranet-tmpl/prog/en/includes/permissions.inc 2) Maybe a merge issue, but sysprefs.sql removes 2 existing system preferences and doesn't add the new ones? 3) There is a comment about YUI - maybe that can just be thrown out? + // prepare DOM for YUI Toolbar 4) the borrow permission is used in opac-signs.pl but has since been removed. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon May 1 23:54:15 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 01 May 2017 21:54:15 +0000 Subject: [Koha-bugs] [Bug 14697] Extend and enhance "Claims returned" lost status In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14697 Benjamin Daeuber changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |bdaeuber at cityoffargo.com --- Comment #5 from Benjamin Daeuber --- (In reply to Christopher Brannon from comment #2) > How are fines/fees taken into account with this action? Will associated > fines be removed if claimed returned? Or will they be removed if marked as > found? Will there be a preference for this? I think this covers your first questions: >Add system preference to ask ?charge?, ?don?t charge?, or ?ask for confirmation? when marking an item claimed returned As to your second, I think we ought to treat it like we do lost items via the system preference RefundLostItemFeeOnReturn Perhaps a system pref: RefundClaimReturnonLocate? -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue May 2 00:04:41 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 01 May 2017 22:04:41 +0000 Subject: [Koha-bugs] [Bug 8000] Test mode for notices In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8000 Barton Chittenden changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |barton at bywatersolutions.com --- Comment #120 from Barton Chittenden --- The other place that this feature is likely to be used is in large libraries which keep a test server in place... these libraries tend to be *very* sensitive to sending out large numbers of emails to patrons. As such, I think that it should be possible to override the syspref using a line in koha-conf.xml, so that libraries can load their production database into a test server, without having to manually re-set the syspref to make them safe. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue May 2 00:10:12 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 01 May 2017 22:10:12 +0000 Subject: [Koha-bugs] [Bug 8643] Add important constraint to marc subfields In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8643 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Failed QA --- Comment #30 from Katrin Fischer --- Tested this a bit and it appears to work ok. Some things found: 1) Doesn't work on item fields, would be nice to see it implemented there as well. Maybe for now we could add a hint to the setting to avoid confusion -"Currently not implemented for items"? 2) I marked 001 as important but it didn't trigger the message. I had to mark the subfield @ important to make it work. Would be nice if this could be fixed. 3) It would be nice to have some visual hint on the important fields and subfields, atm it seems only visible when saving a record. 4) At the moment it will first tell you about the mandatory missing and then after fixing those about the important ones. It would be nicer if the checks were done altogether, to avoid the repeated action. Marking failed QA for 1) and 2), but hopefully those should not be hard to fix! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue May 2 00:11:26 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 01 May 2017 22:11:26 +0000 Subject: [Koha-bugs] [Bug 8000] Test mode for notices In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8000 --- Comment #121 from Katrin Fischer --- Hm, you could already do that with Apache I think? -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue May 2 00:12:50 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 01 May 2017 22:12:50 +0000 Subject: [Koha-bugs] [Bug 9031] Overdue items crossing DST boundary throw invalid local time exception In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9031 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|koha-bugs at lists.koha-commun |nick at bywatersolutions.com |ity.org | CC| |katrin.fischer at bsz-bw.de -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue May 2 00:20:54 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 01 May 2017 22:20:54 +0000 Subject: [Koha-bugs] [Bug 10267] No error message when entering an invalid cardnumber In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10267 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue May 2 00:20:56 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 01 May 2017 22:20:56 +0000 Subject: [Koha-bugs] [Bug 14697] Extend and enhance "Claims returned" lost status In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14697 --- Comment #6 from Christopher Brannon --- (In reply to Benjamin Daeuber from comment #5) > (In reply to Christopher Brannon from comment #2) > > How are fines/fees taken into account with this action? Will associated > > fines be removed if claimed returned? Or will they be removed if marked as > > found? Will there be a preference for this? > > I think this covers your first questions: > > >Add system preference to ask ?charge?, ?don?t charge?, or ?ask for confirmation? when marking an item claimed returned This is good. Since we have started making the refund library specific, would you consider preferences under each library? > As to your second, I think we ought to treat it like we do lost items via > the system preference RefundLostItemFeeOnReturn > > Perhaps a system pref: RefundClaimReturnonLocate? As mentioned in my response above, this functionality was moved to the library configuration as individual preferences for each library. I would say it needs to be there. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue May 2 00:20:58 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 01 May 2017 22:20:58 +0000 Subject: [Koha-bugs] [Bug 10267] No error message when entering an invalid cardnumber In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10267 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #62806|0 |1 is obsolete| | --- Comment #13 from Katrin Fischer --- Created attachment 62934 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=62934&action=edit [SIGNED OFF] Bug 10267: Show error message if user tries to enter too many characters for cardnumber This patch displays a message if the user tries to enter more than the max number of characters for a cardnumber. To test: 1) Apply patch and go to Patrons -> New patron 2) Scroll down to Card number 3) Put in any characters. Notice that when you have entered the max number of characters, you are unable to type any more. 4) Click out of the text field (so it loses focus), the error message will show up. 5) if you backspace some characters and click out of the text field again, the message should disappear Sponsored-by: Catalyst IT Followed test plan, works as expected Signed-off-by: Marc V?ron Signed-off-by: Katrin Fischer -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue May 2 00:22:52 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 01 May 2017 22:22:52 +0000 Subject: [Koha-bugs] [Bug 10744] ExpireReservesMaxPickUpDelay works with hold(s) over report In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10744 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |katrin.fischer at bsz-bw.de Status|Needs Signoff |Patch doesn't apply --- Comment #5 from Katrin Fischer --- Applying: Bug 10744 - ExpireReservesMaxPickUpDelay works with hold(s) over report fatal: sha1 information is lacking or useless (C4/Reserves.pm). error: could not build fake ancestor -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue May 2 00:30:54 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 01 May 2017 22:30:54 +0000 Subject: [Koha-bugs] [Bug 15894] Unify all account fine payment functions In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15894 Edie Discher changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |edischer at cityoffargo.com -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue May 2 01:08:45 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 01 May 2017 23:08:45 +0000 Subject: [Koha-bugs] [Bug 11122] Fix display of publication year/ copyrightdate and publishercode on various pages in acquisitions In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11122 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Summary|publisher code and |Fix display of publication |publication year not |year/copyrightdate and |fetched in acq orders |publishercode on various | |pages in acquisitions -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue May 2 01:15:53 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 01 May 2017 23:15:53 +0000 Subject: [Koha-bugs] [Bug 11122] Fix display of publication year/ copyrightdate and publishercode on various pages in acquisitions In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11122 --- Comment #31 from Katrin Fischer --- Created attachment 62935 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=62935&action=edit [SIGNED OFF] Bug 11122 - publisher code and publication year not fetched in acq orders In acquisition, several templates try to display publisher code and publication year : invoice.tt, parcel.tt, transferorder.tt. Thoses pages use C4::Acquisition methods GetPendingOrders or GetInvoiceDetails. The bug is that in the SQL query of those methods, biblioitems.publishercode and biblioitems.publicationyear. In uncertainprice.pl those datas are fetch using GetBiblioData. It whould be better to fetch them in GetPendingOrders and GetInvoiceDetails. This patch changes SQL queries to fetch wanted datas : aqorders.*,biblio.title,biblio.author,biblioitems.isbn,biblioitems.publishercode,biblioitems.publicationyear. GetInvoiceDetails also needs : biblio.seriestitle,biblioitems.volume. This patch also unifies the way biblio datas are displayed : [title] by [author] – [isbn] Publisher: [publishercode], [publicationyear] Test plan : - Choose a biblio record containing a data in : biblio.title, biblio.author, biblioitems.isbn, biblioitems.publishercode, biblioitems.publicationyear, biblio.seriestitle, biblioitems.volume. - Create an order using this biblio. - Look at this order in pages : parcel.pl, transferorder.pl, uncertainprice.pl => You see publisher code and publication year - Look at this order in page : invoice.pl => You see publisher code, publication year, series title and volume Signed-off-by: Katrin Fischer -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue May 2 01:15:57 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 01 May 2017 23:15:57 +0000 Subject: [Koha-bugs] [Bug 11122] Fix display of publication year/ copyrightdate and publishercode on various pages in acquisitions In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11122 --- Comment #32 from Katrin Fischer --- Created attachment 62936 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=62936&action=edit [SIGNED OFF] Bug 11122: Address MARC21 vs. UNIMARC issue In comment #6 and comment #17, Katrin pointed out the discrepancy between UNIMARC (using publisheryear) vs. Other MARC installations (using copyrightdate). This was dealt with in invoice.tt already. This patch does similar logic for the other 3 template files. Signed-off-by: Katrin Fischer -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue May 2 01:16:02 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 01 May 2017 23:16:02 +0000 Subject: [Koha-bugs] [Bug 11122] Fix display of publication year/ copyrightdate and publishercode on various pages in acquisitions In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11122 --- Comment #33 from Katrin Fischer --- Created attachment 62937 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=62937&action=edit Bug 11122: Follow up - Fix some display issues and typos This patch fixes the display of copyrightdate for MARC21 installations. As MARC21 already requires you to add punctuation in cataloguing, there is usually no need for punctutation in the templates. Also fixes a template variable name typo and the basket summary page. To test (all 3 patches): - Add several order lines to an order, one should be uncertain - Verify that the publisher and publication year are displayed - Check the uncertain price page - Verify that the publisher code and publication year are displayed - Fix uncertain price and close your order - Basket summary: Verify... (you know what) - Cancel one of your orders - Verify... for cancelled orders - Receive shipment - Verify... for unreceived orders - Receive order - Verify ... for received orders - Finish receiving - Verify ... on the invoice summary page -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue May 2 01:17:03 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 01 May 2017 23:17:03 +0000 Subject: [Koha-bugs] [Bug 11122] Fix display of publication year/ copyrightdate and publishercode on various pages in acquisitions In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11122 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #44710|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue May 2 01:17:06 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 01 May 2017 23:17:06 +0000 Subject: [Koha-bugs] [Bug 11122] Fix display of publication year/ copyrightdate and publishercode on various pages in acquisitions In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11122 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #44711|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue May 2 01:18:54 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 01 May 2017 23:18:54 +0000 Subject: [Koha-bugs] [Bug 11122] Fix display of publication year/ copyrightdate and publishercode on various pages in acquisitions In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11122 --- Comment #34 from Katrin Fischer --- Leaving this as 'needs signoff' because of my follow-up patch. I've written up a test plan on the last patch. I am unclear about the code for transferring orders. I have tested from the basket summary and from the order receive pages, but there is never any order information displayed. Eyeballing the code it looks ok. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue May 2 01:20:11 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 01 May 2017 23:20:11 +0000 Subject: [Koha-bugs] [Bug 12283] Set autocomplete=off for patron search input In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12283 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|koha-bugs at lists.koha-commun |pasi.kallinen at pttk.fi |ity.org | CC| |katrin.fischer at bsz-bw.de -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue May 2 01:29:42 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 01 May 2017 23:29:42 +0000 Subject: [Koha-bugs] [Bug 11297] Add support for custom PQF attributes for Z39.50 server searches In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11297 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue May 2 01:29:47 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 01 May 2017 23:29:47 +0000 Subject: [Koha-bugs] [Bug 11297] Add support for custom PQF attributes for Z39.50 server searches In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11297 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #50420|0 |1 is obsolete| | Attachment #59448|0 |1 is obsolete| | --- Comment #43 from Katrin Fischer --- Created attachment 62938 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=62938&action=edit [SIGNED OFF] Bug 11297 - Add support for custom PQF attributes for Z39.50 server searches. Adds the "Attributes" field to z3950 servers. The feature here is not quite de same. In the old patches, the attributes were applied to individual query parts if the part already contains "@attr" and the additionnal attribute is not already in the query part. Here, the content of the new field is prepended to all PQF queries sent to the server. This new way of doing is simpler and works for the sponsor. Test plan: I) Apply the patch II) Run updatedatabase.pl 1) Add a new z3950 server with the following parameters: Hostname : catalogue.banq.qc.ca Port : 210 Database : IRIS Syntax : Marc21 2) Perform a z3950 search on that server. Keyword (Any) : egypt 2.1) Nothing Found. 3) Add attributes on the server administration page @attr 4=1 4) Perform the same z3950 search 4.1) A lot of results modified: C4/Breeding.pm modified: Koha/Schema/Result/Z3950server.pm modified: admin/z3950servers.pl new file: installer/data/mysql/atomicupdate/Bug11297_z3950servers_attributes.sql modified: installer/data/mysql/kohastructure.sql modified: koha-tmpl/intranet-tmpl/prog/en/modules/admin/z3950servers.tt Followed test plan, works as expected. Signed-off-by: Marc V?ron New sign-off, works as expected. Signed-off-by: Marc V?ron Signed-off-by: Katrin Fischer -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue May 2 01:30:09 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 01 May 2017 23:30:09 +0000 Subject: [Koha-bugs] [Bug 11297] Add support for custom PQF attributes for Z39.50 server searches In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11297 --- Comment #44 from Katrin Fischer --- Created attachment 62939 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=62939&action=edit [SIGNED OFF] Bug 11297: QA follow-up - Some fixes - Makes Attributes only show up when adding a new Z39.50 server, not for SRU - Fixes typo in db documentation - Fixes sorting of table columns Signed-off-by: Katrin Fischer -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue May 2 01:30:44 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 01 May 2017 23:30:44 +0000 Subject: [Koha-bugs] [Bug 11297] Add support for custom PQF attributes for Z39.50 server searches In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11297 --- Comment #45 from Katrin Fischer --- Leaving final decisions about unit tests to QA team. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue May 2 01:50:32 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 01 May 2017 23:50:32 +0000 Subject: [Koha-bugs] [Bug 11299] Add a button that automatically links authority records to a biblio record during edition. (AJAX) In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11299 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Failed QA CC| |katrin.fischer at bsz-bw.de --- Comment #33 from Katrin Fischer --- Hi Bouzid, I've tested the linking from the normal cataloguing editor and I really love it. So, some first feedback: There are 2 complaints from the QA script: FAIL koha-tmpl/intranet-tmpl/prog/en/modules/cataloguing/addbiblio.tt FAIL forbidden patterns forbidden pattern: Contains old bootstrap style for buttons (see bug 16239) (line 710) FAIL authorities/authorities.pl FAIL spelling autority ==> authority Testing: When a match was found, it works nicely. Problems appear, when a new authority is to be added. - When I click on the plugin, instead of the normal search form, the add authority form opens, but the window is too small for the big form with the normal header on top, the navigation on top is 'messy' in the small screen. - It opened the wrong framework. I had 655 - so it should open Genre/Form, but instead it was Personal name. Maybe it would be worth to split this big patch. For now, have the automatic linking from cataloguing and leave the authority plugin untouched and deal with that later on? But maybe it's an easy fix. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue May 2 01:51:33 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 01 May 2017 23:51:33 +0000 Subject: [Koha-bugs] [Bug 11300] Add a new authority linker which searches for authority links on a Z39.50 server. In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11300 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |BLOCKED --- Comment #15 from Katrin Fischer --- Blocked by failed 11299 for now - hope we can get this moving soon! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue May 2 01:53:33 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 01 May 2017 23:53:33 +0000 Subject: [Koha-bugs] [Bug 11317] Add a way to access files from the intranet In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11317 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Patch doesn't apply Summary|Add a way to access files |Add a way to access files |from the intranet. |from the intranet --- Comment #69 from Katrin Fischer --- Sorry, this does no longer apply: Apply? [(y)es, (n)o, (i)nteractive] y Applying: Bug 11317: Adds a page to access log files on the server from the intranet. Auto packing the repository in background for optimum performance. See "git help gc" for manual housekeeping. Applying: Bug 11317: Follow up - Update ID to allow for permalinking Auto packing the repository in background for optimum performance. See "git help gc" for manual housekeeping. Applying: Bug 11317 - Rename config to 'accessdir' and fix qa Applying: Bug 11317 - Allows for multiple directories to be accessible Applying: Bug 11317 - Move file access under Tools and add specific permission fatal: sha1 information is lacking or useless (koha-tmpl/intranet-tmpl/prog/en/modules/tools/tools-home.tt). Repository lacks necessary blobs to fall back on 3-way merge. Cannot fall back to three-way merge. Patch failed at 0001 Bug 11317 - Move file access under Tools and add specific permission The copy of the patch that failed is found in: /home/vagrant/kohaclone/.git/rebase-apply/patch When you have resolved this problem run "git bz apply --continue". If you would prefer to skip this patch, instead run "git bz apply --skip". To restore the original branch and stop patching run "git bz apply --abort". Patch left in /tmp/Bug-11317---Move-file-access-under-Tools-and-add-s-D7DJsU.patch -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue May 2 02:00:42 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 02 May 2017 00:00:42 +0000 Subject: [Koha-bugs] [Bug 13952] Import and export of authority types In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13952 --- Comment #29 from M. Tompsett --- Comment on attachment 59831 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=59831 Bug 13952: Import and export authority types Review of attachment 59831: --> (https://bugs.koha-community.org/bugzilla3/page.cgi?id=splinter.html&bug=13952&attachment=59831) ----------------------------------------------------------------- Just eyeballed this. ::: admin/import_export_authtype.pl @@ +18,5 @@ > +# along with Koha; if not, see . > + > + > +use strict; > +use warnings; The recommendation is use Modern::Perl; for the equivalent of these. @@ +26,5 @@ > +use C4::Auth qw/check_cookie_auth/; > +use C4::ImportExportFramework; > + > +my %cookies = CGI::Cookie->fetch(); > +my $authenticated = 0; The variable seems extraneous. Optimized, you could $auth_status //= q{}; and unless ($auth_status eq 'ok'). -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue May 2 03:40:01 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 02 May 2017 01:40:01 +0000 Subject: [Koha-bugs] [Bug 8000] Test mode for notices In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8000 --- Comment #122 from Barton Chittenden --- (In reply to Katrin Fischer from comment #121) > Hm, you could already do that with Apache I think? I thought of that, but Tomas pointed out that overdue_notices.pl doesn't run via apache... -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue May 2 05:48:32 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 02 May 2017 03:48:32 +0000 Subject: [Koha-bugs] [Bug 17925] Disable debugging in reports/bor_issues_top.pl In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17925 Marc V?ron changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |veron at veron.ch --- Comment #4 from Marc V?ron --- Something weird while testing, not related to this bug but I write it down for the records: The column 'Patron' contains values like surname,[tab]first name e.g. Meier, Hans That will break any csv import using tab or , as separator -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue May 2 08:23:16 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 02 May 2017 06:23:16 +0000 Subject: [Koha-bugs] [Bug 11361] Add a Z39.50 search page in the OPAC to let members search for records on remote Koha instances. In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11361 --- Comment #8 from Katrin Fischer --- Comment on attachment 60952 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=60952 Bug 11361 - Add a Z39.50 search page in the OPAC to let members search for records on remote Koha instances Review of attachment 60952: --> (https://bugs.koha-community.org/bugzilla3/page.cgi?id=splinter.html&bug=11361&attachment=60952) ----------------------------------------------------------------- Hi Blou, did a first code review. Additionally to the comments I made I noticed that the changes to kohastructure.sql are misssing for the column. ::: C4/Auth.pm @@ +523,4 @@ > OPACURLOpenInNewWindow => "" . C4::Context->preference("OPACURLOpenInNewWindow"), > OPACUserCSS => "" . C4::Context->preference("OPACUserCSS"), > OpacAuthorities => C4::Context->preference("OpacAuthorities"), > + OpacZ3950 => C4::Context->preference("OpacZ3950"), It's better to use the newer TT plugin method to check system preferences. I think this is done below, so this can possibly be reoved. ::: admin/z3950servers.pl @@ +66,4 @@ > $id = 0; > } elsif ( $op eq 'add_validated' ) { > my @fields=qw/host port db userid password rank syntax encoding timeout > + recordtype checked servername servertype sru_options sru_fields attributes opac attributes is added by another patch on bug 11297, so should be marked as a dependency or removed here. ::: installer/data/mysql/sysprefs.sql @@ +569,5 @@ > ('XSLTListsDisplay','default','','Enable XSLT stylesheet control over lists pages display on intranet','Free'), > ('XSLTResultsDisplay','default','','Enable XSL stylesheet control over results page display on intranet','Free'), > ('z3950AuthorAuthFields','701,702,700',NULL,'Define the MARC biblio fields for Personal Name Authorities to fill biblio.author','free'), > +('z3950NormalizeAuthor','0','','If ON, Personal Name Authorities will replace authors in biblio.author','YesNo'), > +('OPACZ3950','0','','Allow patrons to search for bibliographic records in other libraries via Z39.50.','YesNo') The list in sysprefs.sql should be sorted alphabetically to minimize conflicts. ::: installer/data/mysql/updatedatabase.pl @@ +13959,4 @@ > print "Upgrade to $DBversion done (Bug 16530 - Add a circ sidebar navigation menu)\n"; > } > > +$DBversion = "XXX"; This should be an atomicupdate in a separate file now instead of an entry in updatedatabase. @@ +13960,5 @@ > } > > +$DBversion = "XXX"; > +if( CheckVersion( $DBversion ) ) { > + $dbh->do("ALTER TABLE z3950servers ADD COLUMN opac TINYINT(1);"); Please specify where the new column should be added using AFTER/BEFORE column. @@ +13962,5 @@ > +$DBversion = "XXX"; > +if( CheckVersion( $DBversion ) ) { > + $dbh->do("ALTER TABLE z3950servers ADD COLUMN opac TINYINT(1);"); > + $dbh->do("INSERT IGNORE INTO systempreferences (variable,value,options,explanation,type) VALUES('OPACZ3950','0','','Allow patrons to search for bibliographic records in other libraries via Z39.50.','YesNo')"); > + print "Add opac column to z3950servers table.\nAdd OPACZ3950 preference.\n"; I am not sure if the \n work nicely in the HTML output of the web installer, maybe remove them. ::: koha-tmpl/intranet-tmpl/prog/en/modules/admin/z3950servers.tt @@ +235,4 @@ > You searched for [% searchfield %] > [% END %] > > + Attributes are from bug 11297 - see above. ::: koha-tmpl/opac-tmpl/bootstrap/en/includes/masthead.inc @@ +273,4 @@ > [% IF ( Koha.Preference( 'UseCourseReserves' ) == 1 ) %]
  • Course reserves
    • [% END %] > [% IF Koha.Preference( 'OpacBrowser' ) == 1 %]
  • Browse by hierarchy
    • [% END %] > [% IF Koha.Preference( 'OpacAuthorities' ) == 1 %]
  • Authority search
    • [% END %] > + [% IF Koha.Preference( 'OpacZ3950' ) %]
  • Z39.50 Search
    • [% END %] Not sure patrons will know what Z39.50 means, maybe we could find another label - "search other catalogs" maybe? ::: koha-tmpl/opac-tmpl/bootstrap/en/modules/opac-z3950-search.tt @@ +52,5 @@ > + { label => "Keyword (any)", prop => 'srchany' }, > + { label => "LC call number", prop => 'lccall' }, > + { label => "Control no.", prop => 'controlnumber' }, > + { label => "Dewey", prop => 'dewey' }, > + { label => "Standard ID", prop => 'stdid' } Not sure if this syntax is translatable - needs testing. @@ +64,5 @@ > + > + > + > +
    > +

    Search Parameters

    Should be: Search parameters (only first word capitalized in Koha) @@ +180,5 @@ > +
    > +
    > +
    > + [% IF ( show_prevbutton ) %] > + see above (Previous page) @@ +184,5 @@ > + > + [% END %] > + Page [% current_page %] / [% total_pages %] > + [% IF ( show_nextbutton ) %] > + see above (Next page) ::: opac/opac-z3950-search.pl @@ +18,5 @@ > +# with Koha; if not, write to the Free Software Foundation, Inc., > +# 51 Franklin Street, Fifth Floor, Boston, MA 02110-1301 USA. > + > +use strict; > +use warnings; Should be: use Modern::Perl @@ +51,5 @@ > +my ( $template, $loggedinuser, $cookie ) = get_template_and_user({ > + template_name => "opac-z3950-search.tt", > + query => $input, > + type => "opac", > + authnotrequired => 1, All pages should require auth if OpacPublic is set to Disable: authnotrequired => ( C4::Context->preference("OpacPublic") ? 1 : 0 ), -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue May 2 08:23:37 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 02 May 2017 06:23:37 +0000 Subject: [Koha-bugs] [Bug 11361] Add a Z39.50 search page in the OPAC to let members search for records on remote Koha instances. In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11361 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Failed QA -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue May 2 08:30:37 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 02 May 2017 06:30:37 +0000 Subject: [Koha-bugs] [Bug 11897] Stock Rotation for Koha In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11897 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |katrin.fischer at bsz-bw.de Severity|enhancement |new feature -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue May 2 09:50:14 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 02 May 2017 07:50:14 +0000 Subject: [Koha-bugs] [Bug 8000] Test mode for notices In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8000 --- Comment #123 from Katrin Fischer --- It's a valid point then, but not sure we should make it part of this bug - maybe better to get foundations in and then add to it? -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue May 2 10:21:49 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 02 May 2017 08:21:49 +0000 Subject: [Koha-bugs] [Bug 7317] Add an Interlibrary Loan Module to Circulation and OPAC In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7317 --- Comment #27 from Alex Sassmannshausen --- (In reply to Magnus Enger from comment #24) > I think I foud a problem in Koha/Illrequest.pm, about line 646. In this > block of code: > > # Almost there, but category code didn't quite work. > my ( $branch_limit, $brw_limit ) > = ( $branch_rules->{count}, $brw_rules->{count} ); > my ( $branch_count, $brw_count ) = ( > $self->_limit_counter( > $branch_rules->{method}, { branch_id => $branchcode } > ), > $self->_limit_counter( > $brw_rules->{method}, { borrower_id => $patron->borrowernumber } > ), > ); > > branch_id should be branchcode, and borrower_id should be borrowernumber, I > think? You are absolutely right! I have committed a fix in my dev branch and hope to push the new additions later today. Alex -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue May 2 11:25:05 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 02 May 2017 09:25:05 +0000 Subject: [Koha-bugs] [Bug 17554] Move GetBorrowersWithEmail to Koha::Patron In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17554 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |martin.renvoize at ptfs-europe | |.com Status|Needs Signoff |Patch doesn't apply -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue May 2 11:25:32 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 02 May 2017 09:25:32 +0000 Subject: [Koha-bugs] [Bug 17554] Move GetBorrowersWithEmail to Koha::Patron In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17554 --- Comment #6 from Martin Renvoize --- Looks like a solid change to me, but I can't get it to apply :( -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue May 2 11:36:06 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 02 May 2017 09:36:06 +0000 Subject: [Koha-bugs] [Bug 17600] Standardize the EXPORT In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17600 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #62209|0 |1 is obsolete| | --- Comment #34 from Martin Renvoize --- Created attachment 62940 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=62940&action=edit Bug 17600: Standardize our EXPORT_OK On bug 17591 we discovered that there was something weird going on with the way we export and use subroutines/modules. This patch tries to standardize our EXPORT to use EXPORT_OK only. That way we will need to explicitely define the subroutine we want to use from a module. There are still a lot of things to do, it would be good to write a script to do what's need to be done. Signed-off-by: Martin Renvoize -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue May 2 11:36:10 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 02 May 2017 09:36:10 +0000 Subject: [Koha-bugs] [Bug 17600] Standardize the EXPORT In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17600 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #62210|0 |1 is obsolete| | --- Comment #35 from Martin Renvoize --- Created attachment 62941 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=62941&action=edit Bug 17600: Remove useless extra spaces Signed-off-by: Martin Renvoize -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue May 2 11:36:13 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 02 May 2017 09:36:13 +0000 Subject: [Koha-bugs] [Bug 17600] Standardize the EXPORT In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17600 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #62211|0 |1 is obsolete| | --- Comment #36 from Martin Renvoize --- Created attachment 62942 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=62942&action=edit Bug 17600: continue replace of EXPORT with EXPORT_OK Signed-off-by: Martin Renvoize -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue May 2 11:36:17 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 02 May 2017 09:36:17 +0000 Subject: [Koha-bugs] [Bug 17600] Standardize the EXPORT In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17600 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #62212|0 |1 is obsolete| | --- Comment #37 from Martin Renvoize --- Created attachment 62943 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=62943&action=edit Bug 17600: Explicitly export the subroutines used This patch is generated using the export.pl script Signed-off-by: Martin Renvoize -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue May 2 11:36:40 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 02 May 2017 09:36:40 +0000 Subject: [Koha-bugs] [Bug 17600] Standardize the EXPORT In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17600 --- Comment #38 from Martin Renvoize --- I have now ;) -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue May 2 11:39:15 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 02 May 2017 09:39:15 +0000 Subject: [Koha-bugs] [Bug 16696] Rename "Publisher" to "Published" on detail and result lists In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16696 Nick Clemens changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |nick at bywatersolutions.com --- Comment #4 from Nick Clemens --- "Publication details" or maybe break the field into 3 and label each? -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue May 2 11:46:02 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 02 May 2017 09:46:02 +0000 Subject: [Koha-bugs] [Bug 18436] Add home library to the SIP2 patron info response 64 In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18436 Nick Clemens changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |In Discussion CC| |nick at bywatersolutions.com --- Comment #4 from Nick Clemens --- Why not use the existing functionality to send patron's homebranch in the AF field? send_patron_home_library_in_af="1" -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue May 2 11:55:07 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 02 May 2017 09:55:07 +0000 Subject: [Koha-bugs] [Bug 11897] Stock Rotation for Koha In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11897 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- QA Contact|alex.sassmannshausen at ptfs-e |testopia at bugs.koha-communit |urope.com |y.org -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue May 2 11:59:03 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 02 May 2017 09:59:03 +0000 Subject: [Koha-bugs] [Bug 18405] Self checkout: Fix broken silent printing In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18405 Nick Clemens changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue May 2 11:59:06 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 02 May 2017 09:59:06 +0000 Subject: [Koha-bugs] [Bug 18405] Self checkout: Fix broken silent printing In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18405 Nick Clemens changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #62187|0 |1 is obsolete| | --- Comment #3 from Nick Clemens --- Created attachment 62944 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=62944&action=edit Bug 18405: Self checkout: Fix broken silent printing Fix broken 'silent printing' (without printer dialog) in self checkout. To reproduce: Set up silent printing to slip printers as described in: https://wiki.koha-community.org/wiki/Setting_up_slip_printer_to_print_silently Verify that it works for check-outs in staff client. Verify that it does not work in Self checkout. To test: Apply patch Verify that silent printing works on SCO Signed-off-by: Alex Buckley Signed-off-by: Nick Clemens -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue May 2 12:02:56 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 02 May 2017 10:02:56 +0000 Subject: [Koha-bugs] [Bug 18505] OPAC Search History page does not respect OpacPublic syspref In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18505 Nick Clemens changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue May 2 12:02:59 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 02 May 2017 10:02:59 +0000 Subject: [Koha-bugs] [Bug 18505] OPAC Search History page does not respect OpacPublic syspref In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18505 Nick Clemens changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #62925|0 |1 is obsolete| | --- Comment #9 from Nick Clemens --- Created attachment 62945 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=62945&action=edit BUG 18505: opac-search-history does not respect opacPublic The opac-search-history page was available regardless of the opacPublic setting, this patch corrects that. Test plan, set opacPublic to 'No', test whether opac-search-history page is available when not logged in, note that it is. Apply patch, test whether opac-search-history is still available when not logged in, note that you should be redirected to the login page. Signed-off-by: Katrin Fischer Signed-off-by: Nick Clemens -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue May 2 12:05:56 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 02 May 2017 10:05:56 +0000 Subject: [Koha-bugs] [Bug 18344] Allow overdue fines cap at replacement price, and cap by amount to work together In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18344 Nick Clemens changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |nick at bywatersolutions.com Assignee|koha-bugs at lists.koha-commun |kyle at bywatersolutions.com |ity.org | -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Tue May 2 12:08:17 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 02 May 2017 10:08:17 +0000 Subject: [Koha-bugs] [Bug 17190] Mark REST API dependencies as mandatory in PerlDependencies.pm In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17190 Nick Clemens changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue May 2 12:08:20 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 02 May 2017 10:08:20 +0000 Subject: [Koha-bugs] [Bug 17190] Mark REST API dependencies as mandatory in PerlDependencies.pm In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17190 Nick Clemens changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #61772|0 |1 is obsolete| | --- Comment #5 from Nick Clemens --- Created attachment 62946 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=62946&action=edit Bug 17190 - Marked REST API as mandatory (require = 1) in PerlDependencies.pm For testing I went in Staff client to Home > About Koha > tab Perl modules and verified that both Mojolicious (6.0) and Swagger2 (0.59) are marked as mandatory. Signed-off-by: Marc V?ron Signed-off-by: Nick Clemens -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue May 2 12:14:49 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 02 May 2017 10:14:49 +0000 Subject: [Koha-bugs] [Bug 12446] Enable an adult to have a guarantor In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12446 Josef Moravec changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Failed QA CC| |josef.moravec at gmail.com --- Comment #46 from Josef Moravec --- QA test tool complains: FAIL C4/Members/Attributes.pm FAIL pod in file C4/Members/Attributes.pm Apparent command =cut not preceded by blank line *** ERROR: FAIL C4/Utils/DataTables/Members.pm FAIL forbidden patterns forbidden pattern: tab char (line 58) forbidden pattern: tab char (line 59) FAIL valid Can't continue after import errors "GetMemberIssuesAndFines" is not exported by the C4::Members module FAIL koha-tmpl/intranet-tmpl/prog/en/modules/members/tables/guarantor_search.tt FAIL forbidden patterns forbidden pattern: Contains old bootstrap style for buttons (see bug 16239) (line 20) FAIL members/moremember.pl FAIL forbidden patterns forbidden pattern: tab char (line 221) also the patch does not apply cleanly -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue May 2 12:26:35 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 02 May 2017 10:26:35 +0000 Subject: [Koha-bugs] [Bug 18350] Moving call number in subscriptions tab in OPAC biblio detail In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18350 Nick Clemens changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #61728|0 |1 is obsolete| | --- Comment #3 from Nick Clemens --- Created attachment 62947 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=62947&action=edit Bug 18350: Moving call number in subscriptions tab in OPAC biblio detail This patches moves the call number up to be under the library name, so it is equivalent to the staff client To test: 1) Go to the detail page of a biblio with subscriptions in the staff client 2) Notice callnumber sits under the library name 3) Go to the detail page of the same biblio in OPAC 4) Notice callnumber is not in the same order 5) Apply patch, refresh page 6) Notice callnumber is now in same order Sponsored-by: Catalyst IT Followed test plan, works as expected. Signed-off-by: Marc V?ron Signed-off-by: Nick Clemens -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue May 2 12:26:39 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 02 May 2017 10:26:39 +0000 Subject: [Koha-bugs] [Bug 18350] Moving call number in subscriptions tab in OPAC biblio detail In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18350 --- Comment #4 from Nick Clemens --- Created attachment 62948 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=62948&action=edit Bug 18350 (QA Followup) Add classes to elements Provide classes for easy access in case library wishes to make further chnages -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue May 2 12:26:32 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 02 May 2017 10:26:32 +0000 Subject: [Koha-bugs] [Bug 18350] Moving call number in subscriptions tab in OPAC biblio detail In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18350 Nick Clemens changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue May 2 12:31:57 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 02 May 2017 10:31:57 +0000 Subject: [Koha-bugs] [Bug 18035] Front-end changes to serials -> Numbering patterns In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18035 Nick Clemens changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue May 2 12:32:01 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 02 May 2017 10:32:01 +0000 Subject: [Koha-bugs] [Bug 18035] Front-end changes to serials -> Numbering patterns In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18035 Nick Clemens changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #61731|0 |1 is obsolete| | --- Comment #9 from Nick Clemens --- Created attachment 62949 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=62949&action=edit Bug 18035: Front-end changes to serials -> numbering patterns This patch: 1) Uses datatables functionality on numbering patterns table 2) Shows breadcrumbs when using the form to add or modify numbering patterns 3) Updates the Save, Reset, and Test Pattern buttons in the form to be bootstrap 3 buttons To test: 1) Confirm that datatable sorting works on all columns EXCEPT Actions column 2) Click 'New numbering pattern' 3) Confirm breadcrumbs reads 'New numbering pattern' 4) Go back to numbering patterns and Edit an existing one 5) Confirm breadcrumbs reads 'Modifying number pattern '' 6) Confirm Save, Reset and Test pattern buttons now show as bootstrap3 buttons 7) Confirm all buttons work as expected Sponsored-by: Catalyst IT Followed test plan works as expected. Signed-off-by: Marc V?ron Signed-off-by: Nick Clemens -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue May 2 12:41:22 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 02 May 2017 10:41:22 +0000 Subject: [Koha-bugs] [Bug 16284] Borrower Previously Checked Out: Serials In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16284 --- Comment #1 from Josef Moravec --- See https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6906#c33 -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Tue May 2 12:49:58 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 02 May 2017 10:49:58 +0000 Subject: [Koha-bugs] [Bug 18267] Update price and tax fields in EDI to reflect DB changes In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18267 Barry Cannon changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off CC| |bc at interleaf.ie --- Comment #7 from Barry Cannon --- Applied to customer instance and confirmed working. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue May 2 12:53:15 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 02 May 2017 10:53:15 +0000 Subject: [Koha-bugs] [Bug 18472] Add system preferences to manage online help system In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18472 Josef Moravec changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue May 2 12:53:20 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 02 May 2017 10:53:20 +0000 Subject: [Koha-bugs] [Bug 18472] Add system preferences to manage online help system In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18472 Josef Moravec changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #62897|0 |1 is obsolete| | --- Comment #16 from Josef Moravec --- Created attachment 62950 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=62950&action=edit [SIGNED-OFF] Bug 18472: Add system preferences to manage online help system This patch introduces two new system preferences in section 'Administration' - 'HelpSystem' to select / disable the help system to use. It is designed to allow future expansions (alternative / complementing help system), thats why it is a 'Multiple choice' with one choice - 'EnableEditingFilebasedHelp' is used to toggle on/off the 'Edit' field that appears at the bottom of the durrent help pages. To test: - In staff client, open help on some pages, including help on main page - They have a button 'Edit help'. On main page help, you see a text about 'Can I edit the online help?' - Apply patch, restart memcached and plack - Update database - In staff client, go to Administration > System preferences > Administration - Locate section 'Help system', do not yet schange settings - Verify that the help pages you visited look the same as before - Change syspref 'EnableEditingFilebasedHelp' to 'No' - Visit the help pages again, verify that 'Edit help' button no longer appears. - Set the system preference 'HelpSystem' to none (deselect 'File based (staff client) - Reload any page and verify that the 'Help' link in the page header does no longer display - In syspref 'HelpSystem', check 'File based (staff client)' - Reload any page, verify that the 'Help' link is displayed (Amended to correct wrong line in sysprefs.sql 201-04-29 mv) Signed-off-by: Josef Moravec -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue May 2 13:27:22 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 02 May 2017 11:27:22 +0000 Subject: [Koha-bugs] [Bug 18522] New: User Panel filtered books not showing Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18522 Bug ID: 18522 Summary: User Panel filtered books not showing Change sponsored?: --- Product: Koha Version: 3.22 Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: bugs.koha-community.org Assignee: koha-bugs at lists.koha-community.org Reporter: lkirakosyan at polytechnic.am QA Contact: testopia at bugs.koha-community.org Created attachment 62951 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=62951&action=edit Error screenshot When logging through admin panel, uploaded books are shown. But when logging through the user account books are not showing up and search is not working. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Tue May 2 13:37:54 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 02 May 2017 11:37:54 +0000 Subject: [Koha-bugs] [Bug 18483] Customised help: Enhance staff client with news based, easily editable help system In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18483 Josef Moravec changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue May 2 13:37:58 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 02 May 2017 11:37:58 +0000 Subject: [Koha-bugs] [Bug 18483] Customised help: Enhance staff client with news based, easily editable help system In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18483 Josef Moravec changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #62901|0 |1 is obsolete| | --- Comment #18 from Josef Moravec --- Created attachment 62952 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=62952&action=edit [SIGNED-OFF] Bug 18483 - Customised help: Enhance staff client with news based, easily editable help system Koha's staff client has a file based help system with an edit function for customising. However, the edited files have to be saved and restored with each release. Otherwise they are overwritten. As an enhancement or alternative, the existing news system is used to implement a complementing help system. Similar to the news, the text can be created for all branches or for individual branches. Help is context sensitive (based on the existing help system), and it can be created / edited directly from the help page (based on a user permission). Du to the need of this user permissen, a user permission for editing news is implemented as well. Display can be managed with a system preference (Bug 18472: Add system preference to manage online help system). Preferences default to legacy (fiele based) help. To test: - Apply patch on top of Bug 18472, restart memcached and plack - Update database (Alternative: fresh install) - Log in as superlibrarian (later we test the permisisons) - Verify that news behave as before - Verify that legacy help works as before - Locate system preferences 'EnableEditingFilebasedHelp' and 'Help system' - For our tests, set 'EnableEditingFilebasedHelp' to 'No' - In 'HelpSystem', uncheck 'File based' (none selected) - Refresh any page and verify that 'Help' Link in the main menu has vanished - Check both 'File based' and 'News based' - Verify that 'Help appears again in top menu - Click 'Help' for any page, verify that, above the 'classic' filebased help, you see a title 'Help for (library name) and two buttons 'Add help for this page' and 'Add help for all pages' - Close the help page - Go back to system preferences, select 'News based' only for 'HelpSystem' - Open Help again for any page - Verify that the text from file based help no longer displays, you should have a title and buttons only at the moment. - Click 'Add help for this page'. You are taken to the form you already know from editing 'News' - Click 'Cancel'. You should be taken back to the help page as before - Again click 'Add help for this page' and add an easyly identifiable title and some text, like you would do with news. - Leave the new field 'Help key' unchanged. - Submit. You should be taken back to the help you just created should appear - Close help page and open it again to verify that the text persists (for this page) - Go to an other page and verify that the help you added for the first page does not appear. - Add a help entry using the button 'Add help for all pages' - Go back to the first page you entered help for and verify, that it displays it's own help text and the text for all pages - Edit one of the texts, verify that it saves correctly - Add some more entries and verify that they appear as expected - Go to More > Tools (in an other tab) - Verify that the menu entry for News appears/disappears and changes text depending on the settings of system preference 'HelpSystem' - Open 'News' rsp. 'Help', verify that entries appear depending on the settings of syspref 'HelpSystem' - Verify that the filter for 'Display location' works - Verify that in the 'Location' column a hint about the page appears the entry was created for - Edit a staff help entry, verify that submit or close takes you back to the list - Bonus test: Edit a staff help entry, change the key to 'all', verify that the entry now appears for all pages. Change the key to 'help/admin/preferences' and verify that it appears now for the preferences page - Create a staff user with following permisisons only: catalogue (for login), edit_help and edit_news - Test visibility of news / help editing functionality depending on the edit_ permissions - Run QA tools Signed-off-by: Josef Moravec -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue May 2 13:47:34 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 02 May 2017 11:47:34 +0000 Subject: [Koha-bugs] [Bug 2454] Don't show credits on Pay Fines Tab In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=2454 Alex Buckley changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #62194|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes. You are the QA Contact for the bug. From bugzilla-daemon at bugs.koha-community.org Tue May 2 13:48:51 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 02 May 2017 11:48:51 +0000 Subject: [Koha-bugs] [Bug 2454] Don't show credits on Pay Fines Tab In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=2454 --- Comment #8 from Alex Buckley --- Created attachment 62953 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=62953&action=edit Bug 2454 - Amended patch: Removed the display of accountype, Notify ID, Level values for manual credit in pay.tt and replaced the description with string "Credit" These specific values have been removed because this bug report requires the manual credit to no longer be shown on the 'Pay fines' tab. In response to comment 4 (thankyou for noticing that Felix) I have redone this patch so users can now successfully pay or write off manual credits because the manual credit values although not being displayed are still being submitted to pay.pl. Test plan: 1. From the Koha staff interface go the Patron area and select a patron page 2. Create a fine of $10 for the patron by clicking on the 'Fines' tab and creating a fine in the 'Create manual invoice' tab 3. Create a credit of $5 for the patron in the 'Create manual credit' page 4. Then go to the 'Pay fines' tab and notice there is a row for both the fine and credit both with values in the account type, Notify ID, and level boxes of the table 5. Select "write off all" and 'OK' in the confirmation box 6. Youre redirected to Account tab, return to 'pay fines' tab and notice no fines or credits are displayed 7. Repeat steps 2, 3, 4 and then click "Pay amount", confirm it, then navigate back to the 'Pay fines' tab and notice although the fine and credit are displayed the 'total due' value is 0.00 8. Apply the patch attached to this bug report 9. Repeat steps 2, and 3. 10. Navigate to 'Pay fines' tab and notice the fine has values in account type, Notify ID, and level and the credit does not. Additionally credit has the description value of 'Credit' 11. Repeat steps 5 and 6 and as with before this patch was applied notice the 'Pay fines' tab does not show any fines or credits 12. Repeat step 7 and again notice the 'Total due' value is 0.00 -- You are receiving this mail because: You are watching all bug changes. You are the QA Contact for the bug. From bugzilla-daemon at bugs.koha-community.org Tue May 2 14:10:25 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 02 May 2017 12:10:25 +0000 Subject: [Koha-bugs] [Bug 18494] Fix Letters.t (follow-up of 15702) In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18494 Marcel de Rooy changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue May 2 14:10:28 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 02 May 2017 12:10:28 +0000 Subject: [Koha-bugs] [Bug 18494] Fix Letters.t (follow-up of 15702) In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18494 Marcel de Rooy changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #62749|0 |1 is obsolete| | Attachment #62926|0 |1 is obsolete| | --- Comment #13 from Marcel de Rooy --- Created attachment 62954 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=62954&action=edit Bug 18494: Pass a code, not hash & Fix double commas TEST PLAN --------- 1) prove -v t/db_dependent/Letters.t -- fails at test 5 or so. 2) apply patch 3) run step 1 -- success 4) run koha qa test tools Signed-off-by: Marcel de Rooy -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue May 2 14:11:29 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 02 May 2017 12:11:29 +0000 Subject: [Koha-bugs] [Bug 18494] Fix Letters.t (follow-up of 15702) In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18494 Marcel de Rooy changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA --- Comment #14 from Marcel de Rooy --- (In reply to M. Tompsett from comment #12) > If that is acceptable. obsolete the first and sign off the second. Counter patch is a trivial one. Passing QA immediately. First patch obsoleted. If there is a need for it, please open a new report. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue May 2 14:11:50 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 02 May 2017 12:11:50 +0000 Subject: [Koha-bugs] [Bug 18494] Fix Letters.t (follow-up of 15702) In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18494 Marcel de Rooy changed: What |Removed |Added ---------------------------------------------------------------------------- Severity|enhancement |trivial Version|unspecified |master -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue May 2 14:12:31 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 02 May 2017 12:12:31 +0000 Subject: [Koha-bugs] [Bug 18494] Fix Letters.t (follow-up of 15702) In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18494 Marcel de Rooy changed: What |Removed |Added ---------------------------------------------------------------------------- Severity|trivial |enhancement -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue May 2 14:15:39 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 02 May 2017 12:15:39 +0000 Subject: [Koha-bugs] [Bug 18438] Check in: Modal about holds hides important check in messages In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18438 --- Comment #12 from Alex Buckley --- Created attachment 62955 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=62955&action=edit Bug 18438 - Added focus on the checkin barcode input box after modal box is dismissed -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue May 2 14:17:04 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 02 May 2017 12:17:04 +0000 Subject: [Koha-bugs] [Bug 17600] Standardize the EXPORT In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17600 --- Comment #39 from Marcel de Rooy --- (In reply to Martin Renvoize from comment #38) > I have now ;) Great, Martin. Thanks. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue May 2 14:23:16 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 02 May 2017 12:23:16 +0000 Subject: [Koha-bugs] [Bug 17600] Standardize the EXPORT In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17600 Marcel de Rooy changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Patch doesn't apply --- Comment #40 from Marcel de Rooy --- Applying: Bug 17600: Rerun the script to update use statements fatal: sha1 information is lacking or useless (C4/Auth_with_shibboleth.pm). Repository lacks necessary blobs to fall back on 3-way merge. Cannot fall back to three-way merge. Patch failed at 0001 Bug 17600: Rerun the script to update use statements Somehow I have the feeling that we are running more frequently against these errors. Something to do with different git versions ? I am using git version 2.1.4 on Jessie. (Should be the default version?) -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue May 2 14:52:31 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 02 May 2017 12:52:31 +0000 Subject: [Koha-bugs] [Bug 17292] Use of DBIx in updatedatabase.pl broke upgrade (from bug 12375 ) In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17292 Ian Palko changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |library at stas.org --- Comment #16 from Ian Palko --- (In reply to Jonathan Druart from comment #15) > (In reply to Fr?d?ric Demians from comment #12) > > Created attachment 56734 [details] [review] [review] > > Bug 17292 Follow-up, fix typos > > > > - wrong assignation > > - reference to 'serials' table rather than 'serial' > > > > Signed-off-by: Fr?d?ric Demians > > We need that one for the 16.11 package as well. I'll confirm that the 16.11 packages still fail as of today when moving an old database (3.22) to 16.11. Upgrade to oldstable (16.05) then to stable (16.11) succeeded without issue. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue May 2 15:05:50 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 02 May 2017 13:05:50 +0000 Subject: [Koha-bugs] [Bug 17554] Move GetBorrowersWithEmail to Koha::Patron In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17554 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Patch doesn't apply |Signed Off -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue May 2 15:05:56 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 02 May 2017 13:05:56 +0000 Subject: [Koha-bugs] [Bug 17554] Move GetBorrowersWithEmail to Koha::Patron In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17554 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #58486|0 |1 is obsolete| | --- Comment #7 from Jonathan Druart --- Created attachment 62956 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=62956&action=edit Bug 17554: Koha::Patrons - Remove GetBorrowersWithEmail C4::Members::GetBorrowersWithEmail can be easily replaced with Koha::Patrons->search({ email => $email }); Test plan: Confirm that you are still able to use PKI authentication -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue May 2 15:33:30 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 02 May 2017 13:33:30 +0000 Subject: [Koha-bugs] [Bug 15705] Notify the user on auto renewing In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15705 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Patch doesn't apply |Signed Off --- Comment #59 from Jonathan Druart --- Nick, the conflicts are on the DBIC schema file. Skip these 2 patches and regenerate the schema please. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue May 2 15:41:32 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 02 May 2017 13:41:32 +0000 Subject: [Koha-bugs] [Bug 18286] Test::DBIx::Class connection/ schema is shadowed by a cached connection/schema In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18286 Marcel de Rooy changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |m.de.rooy at rijksmuseum.nl --- Comment #4 from Marcel de Rooy --- Do we need a t/etc/schema file here? -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue May 2 16:06:29 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 02 May 2017 14:06:29 +0000 Subject: [Koha-bugs] [Bug 18502] koha-shell broken on dev installs In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18502 Nick Clemens changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue May 2 16:06:32 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 02 May 2017 14:06:32 +0000 Subject: [Koha-bugs] [Bug 18502] koha-shell broken on dev installs In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18502 Nick Clemens changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #62907|0 |1 is obsolete| | --- Comment #4 from Nick Clemens --- Created attachment 62957 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=62957&action=edit Bug 18502: Make koha-shell set the right PERL5LIB on dev installs Bug 16749 introduced a nice way to have flexible paths. During the discussion on how to do it, we moved from having it contain the path to the git dir to just a boolean. The 'koha-shell' script didn't get attention it seems, and it is broken on dev installs. This was hidden by the fact that many of us run dev installs on kohadevbox, which sets a .bashrc file for de instance's user, containing the right path when opening the new shell. This patch changes the logic so on a dev install, intranetdir is picked as the right path. This is how it is handled in koha-functions.sh To test: - On kohadevbox, run: $ sudo koha-shell kohadev -c "perl misc4dev/populate_db.pl" => FAIL: C4/Installer.pm not found on PERL5LIB error. - Apply this patch - Replace /usr/bin/koha-shell with debian/scripts/koha-shell $ sudo cp kohaclone/debian/scripts/koha-shell /usr/bin/koha-shell - Run: $ sudo koha-shell kohadev -c "perl misc4dev/populate_db.pl" => SUCCESS: No warning about missing libs is raised. - Sign off :-D Signed-off-by: Tomas Cohen Arazi Signed-off-by: Marcel de Rooy Signed-off-by: Nick Clemens -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue May 2 16:15:37 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 02 May 2017 14:15:37 +0000 Subject: [Koha-bugs] [Bug 18518] The staff interface "blink" for different actions after upgrading to Firefox 53 In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18518 --- Comment #6 from Blou --- So the Koha code is not optimal. But why does is suddenly show up in the new Firefox ? It's just slower? We'll be happy to signoff if you find a solution, Marc. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue May 2 16:16:12 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 02 May 2017 14:16:12 +0000 Subject: [Koha-bugs] [Bug 18523] New: Filter Circulation lists on home library Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18523 Bug ID: 18523 Summary: Filter Circulation lists on home library Change sponsored?: --- Product: Koha Version: 16.11 Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Circulation Assignee: koha-bugs at lists.koha-community.org Reporter: severine.queune at bulac.fr QA Contact: testopia at bugs.koha-community.org CC: gmcharlt at gmail.com, kyle.m.hall at gmail.com When using IndependentBranches, items of other sites should not be seen in this Circulation lists for staff users (except for superlibrairians) : - Holds awaiting pickup - Pending on-site checkouts -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Tue May 2 16:24:51 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 02 May 2017 14:24:51 +0000 Subject: [Koha-bugs] [Bug 18226] Remove "use Test::DBIx::Class" instantiations' dangerous code duplication In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18226 Marcel de Rooy changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |m.de.rooy at rijksmuseum.nl --- Comment #10 from Marcel de Rooy --- Applying: Bug 18226 - Remove "use Test::DBIx::Class" instantiations' dangerous code duplication fatal: sha1 information is lacking or useless (t/Calendar.t). -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue May 2 16:38:23 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 02 May 2017 14:38:23 +0000 Subject: [Koha-bugs] [Bug 17600] Standardize the EXPORT In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17600 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #62213|0 |1 is obsolete| | --- Comment #41 from Jonathan Druart --- Created attachment 62958 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=62958&action=edit Bug 17600: Rerun the script to update use statements -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue May 2 16:38:28 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 02 May 2017 14:38:28 +0000 Subject: [Koha-bugs] [Bug 17600] Standardize the EXPORT In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17600 --- Comment #42 from Jonathan Druart --- Created attachment 62959 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=62959&action=edit Bug 17600: re-Rerun the script to update use statements -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue May 2 16:39:06 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 02 May 2017 14:39:06 +0000 Subject: [Koha-bugs] [Bug 17600] Standardize the EXPORT In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17600 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Patch doesn't apply |Signed Off --- Comment #43 from Jonathan Druart --- (In reply to Marcel de Rooy from comment #40) > Applying: Bug 17600: Rerun the script to update use statements > fatal: sha1 information is lacking or useless (C4/Auth_with_shibboleth.pm). > Repository lacks necessary blobs to fall back on 3-way merge. > Cannot fall back to three-way merge. > Patch failed at 0001 Bug 17600: Rerun the script to update use statements > > Somehow I have the feeling that we are running more frequently against these > errors. Something to do with different git versions ? > I am using git version 2.1.4 on Jessie. (Should be the default version?) One patch was not in the correct order. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue May 2 16:39:37 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 02 May 2017 14:39:37 +0000 Subject: [Koha-bugs] [Bug 18518] The staff interface "blink" for different actions after upgrading to Firefox 53 In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18518 Marc V?ron changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff --- Comment #7 from Marc V?ron --- (In reply to Blou from comment #6) > So the Koha code is not optimal. But why does is suddenly show up in the > new Firefox ? It's just slower? > > We'll be happy to signoff if you find a solution, Marc. Hi Blou The patch removes one of the issues (the yellow dialog shortly shining up). For the other issue (comment #5) I did not find out how to fix. Maybe it is a good idea you reach out to ICR. Marc -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue May 2 16:41:27 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 02 May 2017 14:41:27 +0000 Subject: [Koha-bugs] [Bug 18226] Remove "use Test::DBIx::Class" instantiations' dangerous code duplication In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18226 Marcel de Rooy changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Patch doesn't apply |Signed Off -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue May 2 16:41:30 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 02 May 2017 14:41:30 +0000 Subject: [Koha-bugs] [Bug 18226] Remove "use Test::DBIx::Class" instantiations' dangerous code duplication In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18226 Marcel de Rooy changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #60886|0 |1 is obsolete| | Attachment #60920|0 |1 is obsolete| | Attachment #60923|0 |1 is obsolete| | --- Comment #11 from Marcel de Rooy --- Created attachment 62960 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=62960&action=edit Bug 18226 - Remove "use Test::DBIx::Class" instantiations' dangerous code duplication. Replace mock_dbh 1 t/00-load.t already checks if all of the perl modules can be compiled. The tests deleted in this commit do a duplicate test with t/00-load.t Hence they have become unnecessary. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue May 2 16:41:37 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 02 May 2017 14:41:37 +0000 Subject: [Koha-bugs] [Bug 18226] Remove "use Test::DBIx::Class" instantiations' dangerous code duplication In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18226 --- Comment #12 from Marcel de Rooy --- Created attachment 62961 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=62961&action=edit Bug 18226 - Remove "use Test::DBIx::Class" instantiations' dangerous code duplication. Replace mock_dbh 2 Couldn't make the tests pass using Test::DBIx::Class, so reverted to the "usual way" since these tests are in db_dependent anyway. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue May 2 16:41:41 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 02 May 2017 14:41:41 +0000 Subject: [Koha-bugs] [Bug 18226] Remove "use Test::DBIx::Class" instantiations' dangerous code duplication In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18226 --- Comment #13 from Marcel de Rooy --- Created attachment 62962 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=62962&action=edit Bug 18226 - Remove "use Test::DBIx::Class" instantiations' dangerous code duplication Is 'instantiations' even a word? Use a Test::DBIx::Class defaults instead. Save your keyboard and prevent horrible bugs from emerging from rampant code duplication. This change doesn't seem to have any impact on the speed of executing those tests. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue May 2 16:42:28 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 02 May 2017 14:42:28 +0000 Subject: [Koha-bugs] [Bug 18286] Test::DBIx::Class connection/ schema is shadowed by a cached connection/schema In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18286 Marcel de Rooy changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #61186|0 |1 is obsolete| | --- Comment #5 from Marcel de Rooy --- Created attachment 62963 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=62963&action=edit Bug 18286: Test::DBIx::Class connection/schema is shadowed by a cached connection/schema If Koha::Database->schema gets called before use Test::DBIx::Class The DB connection from $KOHA_CONF is cached. This happens most of the time because when C4::Context and friends are loaded (in compile-time?), they already access the DB. After Test::DBIx::Class is instantiated and hooks put in place to overload Koha::Schema connection, those hooks are never called due to getting the old connection from cache. This feature introduces a test case to replicate the behaviour and shows how flushing the connection cache solves the problem. Signed-off-by: Marcel de Rooy -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue May 2 16:42:35 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 02 May 2017 14:42:35 +0000 Subject: [Koha-bugs] [Bug 18286] Test::DBIx::Class connection/ schema is shadowed by a cached connection/schema In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18286 --- Comment #6 from Marcel de Rooy --- Created attachment 62964 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=62964&action=edit Bug 18286: [Follow-up] Add t/etc/schema.pl We need this file here already. Copied from bug 18226 and adjusted in order to keep qa tools quiet. Test plan: Run t/db_dependent/01-test_dbic.t again. Signed-off-by: Marcel de Rooy -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue May 2 16:42:41 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 02 May 2017 14:42:41 +0000 Subject: [Koha-bugs] [Bug 18286] Test::DBIx::Class connection/ schema is shadowed by a cached connection/schema In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18286 --- Comment #7 from Marcel de Rooy --- Created attachment 62965 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=62965&action=edit Bug 18286: [QA Follow-up] Fix some warnings from qa tools [1] Resolve warning on variable assignment before use strict. [2] Remove unused $schema variable. [3] Remove eval expression construction. Signed-off-by: Marcel de Rooy -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue May 2 16:42:23 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 02 May 2017 14:42:23 +0000 Subject: [Koha-bugs] [Bug 18286] Test::DBIx::Class connection/ schema is shadowed by a cached connection/schema In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18286 Marcel de Rooy changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |Signed Off -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue May 2 16:42:45 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 02 May 2017 14:42:45 +0000 Subject: [Koha-bugs] [Bug 18286] Test::DBIx::Class connection/ schema is shadowed by a cached connection/schema In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18286 --- Comment #8 from Marcel de Rooy --- Created attachment 62966 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=62966&action=edit Bug 18286: [Follow-up] Remove assumption on branch count A test in db_dependent should not make assumptions on the number of branches in the database. If you need one, create one. Removing the assumption of a non-zero count. Removing the library count statement outside the subtest. Replacing C4::Context by Koha::Database. Signed-off-by: Marcel de Rooy -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue May 2 16:43:14 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 02 May 2017 14:43:14 +0000 Subject: [Koha-bugs] [Bug 18285] Koha::Database schema cache accessors In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18285 Marcel de Rooy changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue May 2 16:43:17 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 02 May 2017 14:43:17 +0000 Subject: [Koha-bugs] [Bug 18285] Koha::Database schema cache accessors In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18285 Marcel de Rooy changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #61185|0 |1 is obsolete| | --- Comment #3 from Marcel de Rooy --- Created attachment 62967 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=62967&action=edit Bug 18285: Koha::Database schema cache accessors Safe way of getting and flushing the $database->{schema} -cache. This is needed by Test::DBIx::Class to overcome pre-initialization connection caching from C4::Context and others. See Bug 18286. Signed-off-by: Marcel de Rooy -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue May 2 16:44:11 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 02 May 2017 14:44:11 +0000 Subject: [Koha-bugs] [Bug 18226] Remove "use Test::DBIx::Class" instantiations' dangerous code duplication In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18226 Marcel de Rooy changed: What |Removed |Added ---------------------------------------------------------------------------- Patch complexity|--- |Small patch Assignee|gmcharlt at gmail.com |olli-antti.kivilahti at jns.fi -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue May 2 16:44:58 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 02 May 2017 14:44:58 +0000 Subject: [Koha-bugs] [Bug 18226] Remove "use Test::DBIx::Class" instantiations' dangerous code duplication In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18226 Marcel de Rooy changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #62960|0 |1 is obsolete| | --- Comment #14 from Marcel de Rooy --- Created attachment 62968 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=62968&action=edit Bug 18226 - Remove "use Test::DBIx::Class" instantiations' dangerous code duplication. Replace mock_dbh 1 t/00-load.t already checks if all of the perl modules can be compiled. The tests deleted in this commit do a duplicate test with t/00-load.t Hence they have become unnecessary. Signed-off-by: Marcel de Rooy -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue May 2 16:45:03 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 02 May 2017 14:45:03 +0000 Subject: [Koha-bugs] [Bug 18226] Remove "use Test::DBIx::Class" instantiations' dangerous code duplication In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18226 Marcel de Rooy changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #62961|0 |1 is obsolete| | --- Comment #15 from Marcel de Rooy --- Created attachment 62969 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=62969&action=edit Bug 18226 - Remove "use Test::DBIx::Class" instantiations' dangerous code duplication. Replace mock_dbh 2 Couldn't make the tests pass using Test::DBIx::Class, so reverted to the "usual way" since these tests are in db_dependent anyway. Signed-off-by: Marcel de Rooy -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue May 2 16:45:07 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 02 May 2017 14:45:07 +0000 Subject: [Koha-bugs] [Bug 18226] Remove "use Test::DBIx::Class" instantiations' dangerous code duplication In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18226 Marcel de Rooy changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #62962|0 |1 is obsolete| | --- Comment #16 from Marcel de Rooy --- Created attachment 62970 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=62970&action=edit Bug 18226 - Remove "use Test::DBIx::Class" instantiations' dangerous code duplication Is 'instantiations' even a word? Use a Test::DBIx::Class defaults instead. Save your keyboard and prevent horrible bugs from emerging from rampant code duplication. This change doesn't seem to have any impact on the speed of executing those tests. Signed-off-by: Marcel de Rooy -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue May 2 16:46:33 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 02 May 2017 14:46:33 +0000 Subject: [Koha-bugs] [Bug 18226] Remove "use Test::DBIx::Class" instantiations' dangerous code duplication In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18226 --- Comment #17 from Marcel de Rooy --- Moved the t/etc/schema to an earlier report. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue May 2 16:48:48 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 02 May 2017 14:48:48 +0000 Subject: [Koha-bugs] [Bug 18286] Test::DBIx::Class connection/ schema is shadowed by a cached connection/schema In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18286 Marcel de Rooy changed: What |Removed |Added ---------------------------------------------------------------------------- Patch complexity|--- |Small patch -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue May 2 16:49:32 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 02 May 2017 14:49:32 +0000 Subject: [Koha-bugs] [Bug 18285] Koha::Database schema cache accessors In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18285 Marcel de Rooy changed: What |Removed |Added ---------------------------------------------------------------------------- Patch complexity|--- |Small patch CC| |m.de.rooy at rijksmuseum.nl -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue May 2 16:53:21 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 02 May 2017 14:53:21 +0000 Subject: [Koha-bugs] [Bug 18298] Enforce password complexity In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18298 Alex Sassmannshausen changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |alex.sassmannshausen at ptfs-e | |urope.com --- Comment #31 from Alex Sassmannshausen --- (In reply to Jonathan Druart from comment #30) > (In reply to Martin Renvoize from comment #29) > > > Maybe we could just have different strength settings? Instead of > > > "RequireStrongPassword" we could name this PasswordStrength and then have > > > the current and alphanumeric+digits as first two options. > > > > Are you ok to provide this last followup Jonathan? > > To me it's outside the scope of this bug report. I consider this as an > improvement of this new feature. Hi Jonathan, I was hoping to sign this off once more to confirm it is ready for inclusion, but it doesn't currently apply. Best wishes, Alex -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue May 2 16:57:04 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 02 May 2017 14:57:04 +0000 Subject: [Koha-bugs] [Bug 17600] Standardize the EXPORT In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17600 --- Comment #44 from Marcel de Rooy --- (In reply to Jonathan Druart from comment #43) > (In reply to Marcel de Rooy from comment #40) > > Applying: Bug 17600: Rerun the script to update use statements > > fatal: sha1 information is lacking or useless (C4/Auth_with_shibboleth.pm). > > Repository lacks necessary blobs to fall back on 3-way merge. > > Cannot fall back to three-way merge. > > Patch failed at 0001 Bug 17600: Rerun the script to update use statements > > > > Somehow I have the feeling that we are running more frequently against these > > errors. Something to do with different git versions ? > > I am using git version 2.1.4 on Jessie. (Should be the default version?) > > One patch was not in the correct order. OK. It does apply now. Trying to have a look tomorrow. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue May 2 17:02:11 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 02 May 2017 15:02:11 +0000 Subject: [Koha-bugs] [Bug 15705] Notify the user on auto renewing In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15705 Nick Clemens changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Failed QA --- Comment #60 from Nick Clemens --- I really like this enhancement and want to see it get in, failing for reasons noted by Jonathan - 1 notice per issue **I think this could be later enhancement - is nice but not critical - no way to disable the notice generation - no way to specify patron categories to enable/disable the notifications **This could be covered by adding the option to patron messaging preferences, combination of preference 'RenewalSendNotice' and checkout notice options are similar so not sure what the most clear path is, could be script parameters too? Renewal success/failure messages in opac/staff client should be split onto a new bug -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue May 2 17:05:26 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 02 May 2017 15:05:26 +0000 Subject: [Koha-bugs] [Bug 11317] Add a way to access files from the intranet In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11317 Blou changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #58225|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue May 2 17:05:41 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 02 May 2017 15:05:41 +0000 Subject: [Koha-bugs] [Bug 11317] Add a way to access files from the intranet In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11317 Blou changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #58226|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue May 2 17:06:53 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 02 May 2017 15:06:53 +0000 Subject: [Koha-bugs] [Bug 11317] Add a way to access files from the intranet In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11317 Blou changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #58220|0 |1 is obsolete| | --- Comment #70 from Blou --- Created attachment 62971 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=62971&action=edit Bug 11317: Adds a page to access log files on the server from the intranet. The directory used is defined by the "publiclogdir" preference in koha-conf.xml. Test case : Preparation : * Add the "publiclogdir" preference to your "koha-conf.xml" file. This * preference should be in the "config" section. For this test cas, we * will use the "/tmp/koha-public" directory : ... /tmp/koha-public ... * Create the log directory on your server. Make sure this directory * is readable by your web server : $ mkdir /tmp/koha-public * Add a test file in the log directory : $ cd /tmp/koha-public $ echo "Hello world!" > test.txt Test : * Go in the "Reports" section in the intranet and select "Report/log * files" * The "test.txt" should appear in the files list. * Click on the "test.txt" file, a download dialog should appear. * Download the file and verify its content. It should contain the * text "Hello world!". Sponsored by : CCSR Signed-off-by: Jonathan Druart Signed-off-by: Bernardo Gonzalez Kriegel Signed-off-by: Nick Clemens -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue May 2 17:06:58 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 02 May 2017 15:06:58 +0000 Subject: [Koha-bugs] [Bug 11317] Add a way to access files from the intranet In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11317 Blou changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #58221|0 |1 is obsolete| | --- Comment #71 from Blou --- Created attachment 62972 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=62972&action=edit Bug 11317: Follow up - Update ID to allow for permalinking This follow up modifies the id parameter to use a digest of the filename to enable permalinking to files even if the array order changes due to new files being created. Signed-off-by: Jonathan Druart Signed-off-by: Bernardo Gonzalez Kriegel Signed-off-by: Nick Clemens -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue May 2 17:07:03 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 02 May 2017 15:07:03 +0000 Subject: [Koha-bugs] [Bug 11317] Add a way to access files from the intranet In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11317 Blou changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #58222|0 |1 is obsolete| | --- Comment #72 from Blou --- Created attachment 62973 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=62973&action=edit Bug 11317 - Rename config to 'accessdir' and fix qa Also translate date with datetime format preference and move to Tools. Signed-off-by: Nick Clemens -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue May 2 17:07:08 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 02 May 2017 15:07:08 +0000 Subject: [Koha-bugs] [Bug 11317] Add a way to access files from the intranet In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11317 Blou changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #58223|0 |1 is obsolete| | --- Comment #73 from Blou --- Created attachment 62974 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=62974&action=edit Bug 11317 - Allows for multiple directories to be accessible It is now possible to add as many SOMEDIR as needed to the config file. Signed-off-by: Nick Clemens -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue May 2 17:07:12 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 02 May 2017 15:07:12 +0000 Subject: [Koha-bugs] [Bug 11317] Add a way to access files from the intranet In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11317 Blou changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #58224|0 |1 is obsolete| | --- Comment #74 from Blou --- Created attachment 62975 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=62975&action=edit Bug 11317 - Move file access under Tools and add specific permission - Moves the .pl and .tt under tools/ instead of reports/ and adds tools/access_files permission. - Remove datatables-strings.inc from .tt - Allow sorting on date column in file access tool. For some reason, the table was blocking sorting based on timestamp, even though most users would probably want that since the feature is used primarily to access generated (daily) reports i and finding the last ones is very important. Testing -1) Having done requirements of previous patches, like adding 'accessdir' to koha-conf... 0) apply patch, update database to add permission option. 1) Login as NON-superadmin. Go under tools, see no Report/Log under the third column 2) Go to add tools/access_file permission to user 3) See new entry under tools third column. 4) validate link is ok. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue May 2 17:13:49 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 02 May 2017 15:13:49 +0000 Subject: [Koha-bugs] [Bug 11317] Add a way to access files from the intranet In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11317 Blou changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Patch doesn't apply |Signed Off --- Comment #75 from Blou --- Rebased the (evil Sha1!!) patch . Squashed the unsigned patches (last three). Ready for take off. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue May 2 17:17:20 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 02 May 2017 15:17:20 +0000 Subject: [Koha-bugs] [Bug 18298] Enforce password complexity In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18298 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #61331|0 |1 is obsolete| | Attachment #61332|0 |1 is obsolete| | Attachment #61333|0 |1 is obsolete| | Attachment #61334|0 |1 is obsolete| | Attachment #61335|0 |1 is obsolete| | Attachment #61336|0 |1 is obsolete| | --- Comment #32 from Jonathan Druart --- Created attachment 62976 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=62976&action=edit Bug 18298: Enforce password complexity This patchset prevents users to enter too leak password, controlled by a new syspref RequireStrongPassword. If set the staff and patrons will have to enter a strong password. The strongness cannot be modified, it has been arbitrarily set (by the author of this enhancement) to at least 1 lowercase, 1 uppercase and 1 digit. This can be inforce by increasing the value of the existing minPasswordLength pref. I decided to turn this feature on, it cannot hurt! For existing installs it will have to be turned on manually. Writing these patches I found a lot of inconsistencies all around the password checks and decided to refactor everything to make things consistent and more robust. Now the password validity is check at only one place (subroutine covered by tests). Test plan: We have several places where a password can be change/created: a. Editing a patron (members/memberentry.pl) b. Changing the password of a patron (members/member-password.pl) c. Changing your own password at the opac (opac/opac-passwd.pl). OpacPasswordChange needs to be set d. Reseting your own password at the opac (opac/opac-password-recovery.pl). OpacResetPassword needs to be set, see "Forgot your password?" link when you are not logged in e. Self registration feature, PatronSelfRegistration needs to be set. You will also need to add 'password' to PatronSelfRegistrationBorrowerMandatoryField. Note that '****' is considered by Koha internally that the password is not changed (existing behavior). To fully test this patch you will need to test the different combinations of RequireStrongPassword and minPasswordLength. Signed-off-by: Marc V?ron -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue May 2 17:17:31 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 02 May 2017 15:17:31 +0000 Subject: [Koha-bugs] [Bug 18298] Enforce password complexity In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18298 --- Comment #34 from Jonathan Druart --- Created attachment 62978 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=62978&action=edit Bug 18298: Move password generation to template side This patch removes a really ugly way to generate a password: the whole template was sent and parsed to retrieve the "#defaultnewpassfield" node. To avoid the password to be sent plain text it is certainly better to generate it client-side. The same kind of passwords will be generated: 0-9a-zA-Z The while loop prevents to get an invalid generated password. Signed-off-by: Marc V?ron -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue May 2 17:17:35 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 02 May 2017 15:17:35 +0000 Subject: [Koha-bugs] [Bug 18298] Enforce password complexity In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18298 --- Comment #35 from Jonathan Druart --- Created attachment 62979 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=62979&action=edit Bug 18298: minPaswordLength should not be < 3 Indeed if RequireStrongPassword is set we need at least 3 characters to match 1 upper, 1 lower and 1 digit. We could make things more complicated to allow minPasswordLength < 3 but, really, 3 is already too low... Signed-off-by: Marc V?ron -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue May 2 17:17:26 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 02 May 2017 15:17:26 +0000 Subject: [Koha-bugs] [Bug 18298] Enforce password complexity In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18298 --- Comment #33 from Jonathan Druart --- Created attachment 62977 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=62977&action=edit Bug 18298: Use the validate jQuery plugin To validate password fields we need to use the validate jQuery plugin. To make things reusable this patch adds a new include file 'password_check.inc' at the intranet and opac sides, it creates 3 new validation methods: - password_strong => make sure the passwords are strong enough according to the values of the RequireStrongPassword and minPasswordLength prefs - password_no_spaces => prevent passwords to be entered with leading or trailing spaces - password_match => make sure both password fields match Signed-off-by: Marc V?ron -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue May 2 17:17:40 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 02 May 2017 15:17:40 +0000 Subject: [Koha-bugs] [Bug 18298] Enforce password complexity In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18298 --- Comment #36 from Jonathan Druart --- Created attachment 62980 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=62980&action=edit Bug 18298: minPasswordLength should not be used as the default password length The length of the passwords generated for a patron should not be as long as the value of minPasswordLength. It is the minimum required size of a password, not the maximum! So let's fix it to 8 if the minPasswordLength if < 8, that sounds reasonable and less risky for patrons. Signed-off-by: Marc V?ron -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue May 2 17:17:45 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 02 May 2017 15:17:45 +0000 Subject: [Koha-bugs] [Bug 18298] Enforce password complexity In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18298 --- Comment #37 from Jonathan Druart --- Created attachment 62981 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=62981&action=edit Bug 18298: Add server-side checks and refactor stuffs Now that we have a check client-side, nothing prevents us from a smart guy to bypass it and force an invalid password. This patch adds two new subroutines to Koha::AuthUtils to check the validity of passwords and generate a password server-side. It is used only once (self-registration) but could be useful later. Moreover the 3 different cases of password rejection (too leak, too short, contains leading or trailing whitespaces) were not tested everywhere. Now they are! This patch makes things consistent everywhere and clean up some code. Signed-off-by: Marc V?ron -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue May 2 17:39:10 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 02 May 2017 15:39:10 +0000 Subject: [Koha-bugs] [Bug 18291] Remove SQL from preferences.pl administrative script In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18291 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |In Discussion CC| |m.de.rooy at rijksmuseum.nl, | |martin.renvoize at ptfs-europe | |.com, | |nick at bywatersolutions.com, | |tomascohen at gmail.com --- Comment #10 from Jonathan Druart --- Hi Alex, I thought a bit more about this. (In reply to Jonathan Druart from comment #6) > I do not see a valid reason not to fetch the in cache values here, so a 1 > line patch should do the trick ;) Actually there is one, if the cache is not correctly set, for whatever reason, we would like to display the DB value. I do not think it is wrong to have a SELECT statement here. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue May 2 18:06:03 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 02 May 2017 16:06:03 +0000 Subject: [Koha-bugs] [Bug 18494] Fix Letters.t (follow-up of 15702) In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18494 --- Comment #15 from M. Tompsett --- Just noticed that my patch is identical to Lari's first obsoleted patch. Feel free to change author to Lari instead. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue May 2 18:06:50 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 02 May 2017 16:06:50 +0000 Subject: [Koha-bugs] [Bug 18152] UNIMARC bib records imported with invalid 'a' char in label pos.9 In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18152 --- Comment #11 from Jonathan Druart --- Additional questions: 1. MARC::Record does not handle UNIMARC records correctly, so we should never call ->encoding('utf-8') from Koha, but SetMarcUnicodeFlag instead, right? 2. Sounds like the code in SetMarcUnicodeFlag should then be: If MARC21 or NORMARC: $marc_record->encoding('utf-8') else # unimarc do our stuffs 3. Please fix author's name of the patch -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue May 2 18:10:53 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 02 May 2017 16:10:53 +0000 Subject: [Koha-bugs] [Bug 2093] Add OPAC dashboard for logged-in users In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=2093 --- Comment #5 from Owen Leonard --- Created attachment 62982 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=62982&action=edit Bug 2093 [Follow-up] Add OPAC dashboard for logged-in users This patch adds some additional markup for applying styles to and the corresponding CSS. Also modified: Links to opac-user.pl should now open the correct tab. To test, apply the patch and compile the modified LESS file. Clear your browser cache if necessary. Follow the original test plan and confirm that the revised links work correctly. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue May 2 18:10:58 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 02 May 2017 16:10:58 +0000 Subject: [Koha-bugs] [Bug 2093] Add OPAC dashboard for logged-in users In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=2093 --- Comment #6 from Owen Leonard --- Created attachment 62983 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=62983&action=edit Bug 2093 [Compiled CSS] Add OPAC dashboard for logged-in users This patch contains the CSS file compiled from LESS. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue May 2 18:13:24 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 02 May 2017 16:13:24 +0000 Subject: [Koha-bugs] [Bug 2093] Add OPAC dashboard for logged-in users In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=2093 --- Comment #7 from Owen Leonard --- I hope the style patches are agreeable. I think cait is correct in both her comments above. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue May 2 18:16:58 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 02 May 2017 16:16:58 +0000 Subject: [Koha-bugs] [Bug 5456] Create a link to opac-ics.pl In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5456 John Andrews changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |jandrews at washoecounty.us --- Comment #13 from John Andrews --- There's a problem with the lack of end time -- when importing this into my outlook calendar, because there's no end time, outlook automatically creates an hour long event. Which means that the due date reminder shows up both on the due date, and on the day AFTER the due date. In our case, the time due is 11:59 pm, so the appointment gets created in outlook as from 11:59 pm on the due date until 12:59 am on the next day. Is there a way to force the appointment to start and end at the same time? -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue May 2 18:26:12 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 02 May 2017 16:26:12 +0000 Subject: [Koha-bugs] [Bug 18512] GetAuthorisedValues.GetByCode Template plguin should return code ( not empty string) if value not found In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18512 --- Comment #4 from Jonathan Druart --- Hard to say... Indeed, bug 16908 modified the behaviour, but with this patch you are going to modify the behaviour for all other AuthorisedValues.GetByCode calls. Bug 16908 did not modify the behaviour of GetByCode. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue May 2 18:28:11 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 02 May 2017 16:28:11 +0000 Subject: [Koha-bugs] [Bug 18512] GetAuthorisedValues.GetByCode Template plugin should return code ( not empty string) if value not found In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18512 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Summary|GetAuthorisedValues.GetByCo |GetAuthorisedValues.GetByCo |de Template plguin should |de Template plugin should |return code (not empty |return code (not empty |string) if value not found |string) if value not found -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue May 2 18:30:29 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 02 May 2017 16:30:29 +0000 Subject: [Koha-bugs] [Bug 16758] Caching issues in scripts running in daemon mode In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16758 --- Comment #13 from Jonathan Druart --- (In reply to Jonathan Druart from comment #12) > Why do you get the "syspref" cache instance? > I guess there is no reason, I'd suggest to remove it and retrieve the > default one. Jacek, It would be great to have this one into 17.05, can you answer please? -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue May 2 18:43:53 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 02 May 2017 16:43:53 +0000 Subject: [Koha-bugs] [Bug 18523] Filter Holds awaiting pickup/ Pending on-site checkouts correctly for IndependentBranches In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18523 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |katrin.fischer at bsz-bw.de Summary|Filter Circulation lists on |Filter Holds awaiting |home library |pickup/Pending on-site | |checkouts correctly for | |IndependentBranches -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue May 2 18:56:29 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 02 May 2017 16:56:29 +0000 Subject: [Koha-bugs] [Bug 18436] Add home library to the SIP2 patron info response 64 In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18436 --- Comment #5 from Colin Campbell --- (In reply to Nick Clemens from comment #4) > Why not use the existing functionality to send patron's homebranch in the AF > field? > > send_patron_home_library_in_af="1" AF is a screen message. I'm assuming that the point of this feature is to supply the information to be used by the sip unit and that will expect it in a specific field. In practice suppliers are unlikely to even attempt to parse such data out of AF. I'd still be interested to know which machine supplier is requiring AQ (I was asking about SIP devices not LMSs above), if we dont have one then AF would be the logical place if we want to display this info. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue May 2 19:05:15 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 02 May 2017 17:05:15 +0000 Subject: [Koha-bugs] [Bug 18287] Fix t/Koha.t having a Test::DBIx::Class cache issue In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18287 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |jonathan.druart at bugs.koha-c | |ommunity.org --- Comment #2 from Jonathan Druart --- It does not fail for me against master. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue May 2 19:15:03 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 02 May 2017 17:15:03 +0000 Subject: [Koha-bugs] [Bug 18426] Subscriptions batch editing In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18426 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Failed QA CC| |jonathan.druart at bugs.koha-c | |ommunity.org --- Comment #4 from Jonathan Druart --- Please move Koha::Subscription->biblio to its own bug report and provide tests. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue May 2 19:20:57 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 02 May 2017 17:20:57 +0000 Subject: [Koha-bugs] [Bug 18512] GetAuthorisedValues.GetByCode Template plugin should return code ( not empty string) if value not found In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18512 --- Comment #5 from Nick Clemens --- I did a git grep on 'GetByCode' - I didn't see anything that would break on the code - it will just add to the display for anything unmapped so helps root out old data and cruft that has been hidden -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue May 2 19:31:05 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 02 May 2017 17:31:05 +0000 Subject: [Koha-bugs] [Bug 17952] Lost items not skipped by overdue_notices.pl In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17952 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue May 2 19:31:16 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 02 May 2017 17:31:16 +0000 Subject: [Koha-bugs] [Bug 17952] Lost items not skipped by overdue_notices.pl In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17952 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #62928|0 |1 is obsolete| | --- Comment #7 from Jonathan Druart --- Created attachment 62984 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=62984&action=edit Bug 17952 - Lost items not skipped by overdue_notices.pl If a library does not use --mark-returned when running longoverdue.pl, all those lost item checkouts are selected by overdue_notices.pl. This causes much unnecessary overhead. In addition Koha::Calendar is instantiated many times for each branchcode which is not necessary. Test Plan: 1) Run overdue_notices.pl, note output 2) Apply this patch 3) Run overdue_notices.pl again, note output is the same Signed-off-by: Kyle M Hall Signed-off-by: Jane Leven Signed-off-by: Martin Renvoize Signed-off-by: Jonathan Druart -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue May 2 19:32:40 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 02 May 2017 17:32:40 +0000 Subject: [Koha-bugs] [Bug 17952] Lost items not skipped by overdue_notices.pl In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17952 --- Comment #8 from Jonathan Druart --- (In reply to Jonathan Druart from comment #3) > Kyle, could you move the "$calendar" fix to its own bug? > That sounds like a major bug as well. I do not understand my own comment. It does not sound a major bug, just a speed improvement. It would have been good to have it on its own bug anyway :) -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue May 2 20:11:13 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 02 May 2017 18:11:13 +0000 Subject: [Koha-bugs] [Bug 2454] Don't show credits on Pay Fines Tab In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=2454 --- Comment #9 from Katrin Fischer --- Hi Alex, sorry, looking at this with fresher eyes today maybe. Why remove the account type column from the display? I suggest keeping it. Notify id and level are no longer in use - I am in favor of removing them as you did. -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue May 2 20:16:13 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 02 May 2017 18:16:13 +0000 Subject: [Koha-bugs] [Bug 2093] Add OPAC dashboard for logged-in users In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=2093 --- Comment #8 from Katrin Fischer --- Thx Owen, I think it looks pretty good that way! Aleihsa, could you take a look at my comment#4? Ready to sign once those are resolved! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue May 2 20:23:41 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 02 May 2017 18:23:41 +0000 Subject: [Koha-bugs] [Bug 11897] Stock Rotation for Koha In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11897 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Patch doesn't apply --- Comment #79 from Katrin Fischer --- Sorry, don't want to break something - tried to resolve the conflicts, but better leaving it up to the author. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue May 2 20:31:25 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 02 May 2017 18:31:25 +0000 Subject: [Koha-bugs] [Bug 12145] Lock for Move up buttons with Marc tag In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12145 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |katrin.fischer at bsz-bw.de --- Comment #2 from Katrin Fischer --- When "Show tags" is off, toggling "Lock subfield positions" doesn't have any effect. Could you please check? -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue May 2 20:31:36 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 02 May 2017 18:31:36 +0000 Subject: [Koha-bugs] [Bug 12145] Lock for Move up buttons with Marc tag In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12145 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Failed QA -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue May 2 20:33:34 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 02 May 2017 18:33:34 +0000 Subject: [Koha-bugs] [Bug 12283] Set autocomplete=off for patron search input In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12283 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Patch doesn't apply --- Comment #2 from Katrin Fischer --- git bz apply 12283 Bug 12283 - Set autocomplete=off for patron search input 61374 - Bug 12283: Disable autocomplete for patron search inputs Apply? [(y)es, (n)o, (i)nteractive] y Applying: Bug 12283: Disable autocomplete for patron search inputs fatal: sha1 information is lacking or useless (koha-tmpl/intranet-tmpl/prog/en/includes/patron-search.inc). error: could not build fake ancestor Patch failed at 0001 Bug 12283: Disable autocomplete for patron search inputs The copy of the patch that failed is found in: .git/rebase-apply/patch When you have resolved this problem run "git bz apply --continue". If you would prefer to skip this patch, instead run "git bz apply --skip". To restore the original branch and stop patching run "git bz apply --abort". Patch left in /tmp/Bug-12283-Disable-autocomplete-for-patron-search-i-rhFF_M.patch -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue May 2 20:35:13 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 02 May 2017 18:35:13 +0000 Subject: [Koha-bugs] [Bug 11317] Add a way to access files from the intranet In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11317 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue May 2 20:36:17 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 02 May 2017 18:36:17 +0000 Subject: [Koha-bugs] [Bug 12365] Notes for rules In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12365 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |katrin.fischer at bsz-bw.de Status|Needs Signoff |Patch doesn't apply --- Comment #4 from Katrin Fischer --- 61865 - Bug 12365: Adding a note column to circ rules Apply? [(y)es, (n)o, (i)nteractive] y Applying: Bug 12365: Adding a note column to circ rules Using index info to reconstruct a base tree... M Koha/Schema/Result/Issuingrule.pm M admin/smart-rules.pl M installer/data/mysql/kohastructure.sql M koha-tmpl/intranet-tmpl/prog/en/modules/admin/smart-rules.tt Falling back to patching base and 3-way merge... Auto-merging koha-tmpl/intranet-tmpl/prog/en/modules/admin/smart-rules.tt Auto-merging installer/data/mysql/kohastructure.sql Auto-merging admin/smart-rules.pl Auto-merging Koha/Schema/Result/Issuingrule.pm CONFLICT (content): Merge conflict in Koha/Schema/Result/Issuingrule.pm error: Failed to merge in the changes. Patch failed at 0001 Bug 12365: Adding a note column to circ rules The copy of the patch that failed is found in: .git/rebase-apply/patch When you have resolved this problem run "git bz apply --continue". If you would prefer to skip this patch, instead run "git bz apply --skip". To restore the original branch and stop patching run "git bz apply --abort". Patch left in /tmp/Bug-12365-Adding-a-note-column-to-circ-rules-pR_pTz.patch -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue May 2 20:37:08 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 02 May 2017 18:37:08 +0000 Subject: [Koha-bugs] [Bug 12388] IssueSlip output should be sorted by date_due, not timestamp In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12388 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|koha-bugs at lists.koha-commun |lari.taskula at jns.fi |ity.org | CC| |katrin.fischer at bsz-bw.de -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue May 2 20:39:25 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 02 May 2017 18:39:25 +0000 Subject: [Koha-bugs] [Bug 18522] User Panel filtered books not showing In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18522 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |RESOLVED CC| |katrin.fischer at bsz-bw.de Resolution|--- |FIXED --- Comment #1 from Katrin Fischer --- Hi Levon, this is more likely a configuration issue then a bug - please ask about your problem on the mailing lists or in the IRC chat instead! -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue May 2 20:39:35 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 02 May 2017 18:39:35 +0000 Subject: [Koha-bugs] [Bug 18522] User Panel filtered books not showing In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18522 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Resolution|FIXED |INVALID -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue May 2 20:45:12 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 02 May 2017 18:45:12 +0000 Subject: [Koha-bugs] [Bug 12388] IssueSlip output should be sorted by date_due, not timestamp In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12388 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Failed QA --- Comment #5 from Katrin Fischer --- The QA scripts are not happy about this patch: FAIL C4/Members.pm OK critic OK forbidden patterns OK git manipulation OK pod OK spelling FAIL valid Useless use of numeric comparison (<=>) in void context Useless use of private variable in void context -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue May 2 21:08:17 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 02 May 2017 19:08:17 +0000 Subject: [Koha-bugs] [Bug 14610] Add ability to place article requests in Koha In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14610 --- Comment #266 from Katrin Fischer --- Be careful, just created release notes for 17.05 for a test and this is listed as new features (follow up pushed after release of 16.11 with this bug number...) -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue May 2 21:10:52 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 02 May 2017 19:10:52 +0000 Subject: [Koha-bugs] [Bug 14537] Rename system preference 'OverdueNoticeBcc' to 'NoticeBcc' In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14537 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Summary|The system preference |Rename system preference |'OverdueNoticeBcc' is |'OverdueNoticeBcc' to |mis-named. |'NoticeBcc' -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue May 2 21:11:38 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 02 May 2017 19:11:38 +0000 Subject: [Koha-bugs] [Bug 15906] Remove use of makepayment in paycollect.pl In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15906 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Summary|[ONLY PUSH TOGETHER WITH |Remove use of makepayment |15896] Remove use of |in paycollect.pl |makepayment in | |paycollect.pl | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue May 2 21:14:38 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 02 May 2017 19:14:38 +0000 Subject: [Koha-bugs] [Bug 17855] New onboarding tool feature to guide users through setting up Koha, and minor web installer UI improvements In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17855 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Severity|enhancement |new feature --- Comment #233 from Katrin Fischer --- This is a new idea - I suggest marking it as 'new' instead of 'enhancement' -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue May 2 21:36:06 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 02 May 2017 19:36:06 +0000 Subject: [Koha-bugs] [Bug 15408] Timestamp on funds not updated when you duplicate a budget In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15408 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |katrin.fischer at bsz-bw.de Summary|Timestamp not updated when |Timestamp on funds not |you duplicate a budget |updated when you duplicate | |a budget -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue May 2 21:36:40 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 02 May 2017 19:36:40 +0000 Subject: [Koha-bugs] [Bug 15408] Timestamp on funds not updated when you duplicate a budget In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15408 --- Comment #12 from Katrin Fischer --- Created attachment 62985 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=62985&action=edit [SIGNED OFF] Bug 15408 : deleted the timestamp so that the database gives a new one To duplicate the budget, the function CloneBudgetHierarchy create a new budget from the old without the parameter timestamp, so that the database generates a new one. Signed-off-by: Katrin Fischer -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue May 2 21:36:44 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 02 May 2017 19:36:44 +0000 Subject: [Koha-bugs] [Bug 15408] Timestamp on funds not updated when you duplicate a budget In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15408 --- Comment #13 from Katrin Fischer --- Created attachment 62986 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=62986&action=edit [SIGNED OFF] Added unit tests to patch https://bugs.koha-community.org/show_bug.cgi?id=15408 Signed-off-by: Katrin Fischer -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue May 2 21:36:47 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 02 May 2017 19:36:47 +0000 Subject: [Koha-bugs] [Bug 15408] Timestamp on funds not updated when you duplicate a budget In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15408 --- Comment #14 from Katrin Fischer --- Created attachment 62987 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=62987&action=edit [SIGNED OFF] Modified to run properly the QA tests https://bugs.koha-community.org/show_bug.cgi?id=15408 Signed-off-by: Katrin Fischer -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue May 2 21:37:22 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 02 May 2017 19:37:22 +0000 Subject: [Koha-bugs] [Bug 15408] Timestamp on funds not updated when you duplicate a budget In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15408 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off Patch complexity|--- |Small patch -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue May 2 21:37:25 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 02 May 2017 19:37:25 +0000 Subject: [Koha-bugs] [Bug 15408] Timestamp on funds not updated when you duplicate a budget In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15408 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #60337|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue May 2 21:37:31 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 02 May 2017 19:37:31 +0000 Subject: [Koha-bugs] [Bug 15408] Timestamp on funds not updated when you duplicate a budget In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15408 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #60339|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue May 2 21:37:28 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 02 May 2017 19:37:28 +0000 Subject: [Koha-bugs] [Bug 15408] Timestamp on funds not updated when you duplicate a budget In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15408 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #60338|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue May 2 22:15:23 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 02 May 2017 20:15:23 +0000 Subject: [Koha-bugs] [Bug 18524] New: Disable barcode field and submit button when a transfer is found Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18524 Bug ID: 18524 Summary: Disable barcode field and submit button when a transfer is found Change sponsored?: --- Product: Koha Version: 16.11 Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Circulation Assignee: koha-bugs at lists.koha-community.org Reporter: jzairo at bywatersolutions.com QA Contact: testopia at bugs.koha-community.org CC: gmcharlt at gmail.com, kyle.m.hall at gmail.com Similar to the actions taken on Bug 11360, when scanning in returns, it can be easy to miss a transfer message due to the fact that the barcode and submit are still active and the barcode field is focused on. When a librarian is quickly scanning in returns, it is easy to scan another item and pass over the form to accept the transfer, which is equivalent to clicking the "ignore" button. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Tue May 2 22:28:31 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 02 May 2017 20:28:31 +0000 Subject: [Koha-bugs] [Bug 18512] GetAuthorisedValues.GetByCode Template plugin should return code ( not empty string) if value not found In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18512 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue May 2 22:28:40 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 02 May 2017 20:28:40 +0000 Subject: [Koha-bugs] [Bug 18512] GetAuthorisedValues.GetByCode Template plugin should return code ( not empty string) if value not found In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18512 --- Comment #7 from Jonathan Druart --- Created attachment 62989 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=62989&action=edit Bug 18512: Add tests Signed-off-by: Jonathan Druart -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue May 2 22:28:36 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 02 May 2017 20:28:36 +0000 Subject: [Koha-bugs] [Bug 18512] GetAuthorisedValues.GetByCode Template plugin should return code ( not empty string) if value not found In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18512 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #62893|0 |1 is obsolete| | --- Comment #6 from Jonathan Druart --- Created attachment 62988 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=62988&action=edit Bug 18512 - GetAuthorisedValues.GetByCode Template plguin should return code (not empty string) if value not found To test: 1 - Create or edit a borrower with info in Sort1 and Sort2 field, not mapped to authorized values 2 - Note this info does not display on moremember.tt 3 - Apply patch 4 - Note value is passed through Signed-off-by: Mark Tompsett Signed-off-by: Jonathan Druart -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue May 2 22:44:06 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 02 May 2017 20:44:06 +0000 Subject: [Koha-bugs] [Bug 18291] Remove SQL from preferences.pl administrative script In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18291 --- Comment #11 from Alex Buckley --- Hi Jonathan >Actually there is one, if the cache is not correctly set, for whatever reason, >we would like to display the DB value. >I do not think it is wrong to have a SELECT statement here. So regarding the other sql removal patches I have been working on such as bug 17944, 18247, 18291, 18299 do you think that they are not needed because replacing sql queries with the use of cache values will be problematic if the cache values are not set correctly? -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue May 2 22:54:21 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 02 May 2017 20:54:21 +0000 Subject: [Koha-bugs] [Bug 18503] Confusing hold and transfer dialog In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18503 --- Comment #1 from Christopher Brannon --- Created attachment 62990 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=62990&action=edit Bug 18503: Fixes confusing dialog and other minor This corrects the returns2 dialog logic, and cleans up a few pieces of code. Patch also updates some buttons and fixes check in layout. To Test: 1) Check out an item. 2) Check item in. Note old buttons (Submit next to barcode, Clear). Note message next to calendar is wrapping to next line. Note Clear button is next to the check box rather than next to the calendar. 3) Check in item at a different branch both with AllowReturnToBranch in all four settings and with AutomaticItemReturn set to Do and Don't. Note old style buttons on all dialogs. 4) Place a hold on an item for pickup at another library. 5) Trigger the hold and confirm. 6) Check in item at another library (not the pickup location). 7) Note the confusing transfer/hold buttons and message. 8) Apply patch 9) Repeat steps 1-8. Note changes to the items pointed out in those steps. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue May 2 22:55:16 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 02 May 2017 20:55:16 +0000 Subject: [Koha-bugs] [Bug 2454] Don't show credits on Pay Fines Tab In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=2454 Alex Buckley changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #62953|0 |1 is obsolete| | -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue May 2 22:55:42 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 02 May 2017 20:55:42 +0000 Subject: [Koha-bugs] [Bug 18503] Confusing hold and transfer dialog In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18503 Christopher Brannon changed: What |Removed |Added ---------------------------------------------------------------------------- Severity|enhancement |normal Status|NEW |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue May 2 22:56:45 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 02 May 2017 20:56:45 +0000 Subject: [Koha-bugs] [Bug 2454] Don't show credits on Pay Fines Tab In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=2454 --- Comment #10 from Alex Buckley --- Created attachment 62991 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=62991&action=edit Bug 2454 - Amended patch: Removed the display of accountype, Notify ID, Level values for manual credit in pay.tt and replaced the description with string "Credit" Reimplemented accounttype column but kept the notifyid a nd level columns These specific values have been removed because this bug report requires the manual credit to no longer be shown on the 'Pay fines' tab. In response to comment 4 (thankyou for noticing that Felix) I have redone this patch so users can now successfully pay or write off manual credits because the manual credit values although not being displayed are still being submitted to pay.pl. Test plan: 1. From the Koha staff interface go the Patron area and select a patron page 2. Create a fine of $10 for the patron by clicking on the 'Fines' tab and creating a fine in the 'Create manual invoice' tab 3. Create a credit of $5 for the patron in the 'Create manual credit' page 4. Then go to the 'Pay fines' tab and notice there is a row for both the fine and credit both with values in the account type, Notify ID, and level boxes of the table 5. Select "write off all" and 'OK' in the confirmation box 6. Youre redirected to Account tab, return to 'pay fines' tab and notice no fines or credits are displayed 7. Repeat steps 2, 3, 4 and then click "Pay amount", confirm it, then navigate back to the 'Pay fines' tab and notice although the fine and credit are displayed the 'total due' value is 0.00 8. Apply the patch attached to this bug report 9. Repeat steps 2, and 3. 10. Navigate to 'Pay fines' tab and notice the fine has values in account type, Notify ID, and level and the credit does not. Additionally credit has the description value of 'Credit' 11. Repeat steps 5 and 6 and as with before this patch was applied notice the 'Pay fines' tab does not show any fines or credits 12. Repeat step 7 and again notice the 'Total due' value is 0.00 Bug 2454 - Reimplemented accounttype column but kept the notifyid and level columns -- You are receiving this mail because: You are watching all bug changes. You are the QA Contact for the bug. From bugzilla-daemon at bugs.koha-community.org Tue May 2 22:57:42 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 02 May 2017 20:57:42 +0000 Subject: [Koha-bugs] [Bug 18503] Confusing hold and transfer dialog In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18503 Christopher Brannon changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on| |18490 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18490 [Bug 18490] Transfer message confusing, cancel button missing -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue May 2 22:57:42 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 02 May 2017 20:57:42 +0000 Subject: [Koha-bugs] [Bug 18490] Transfer message confusing, cancel button missing In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18490 Christopher Brannon changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |18503 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18503 [Bug 18503] Confusing hold and transfer dialog -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue May 2 23:19:55 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 02 May 2017 21:19:55 +0000 Subject: [Koha-bugs] [Bug 2454] Don't show credits on Pay Fines Tab In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=2454 Alex Buckley changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #61765|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes. You are the QA Contact for the bug. From bugzilla-daemon at bugs.koha-community.org Tue May 2 23:22:32 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 02 May 2017 21:22:32 +0000 Subject: [Koha-bugs] [Bug 12601] aqorders.budget_id should be a foreign key In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12601 --- Comment #16 from Katrin Fischer --- Created attachment 62992 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=62992&action=edit [SIGNED OFF] Bug 12691: Use Koha.Preference in Self-Checkout For calls to SCOUserJS, SCOUserCSS, OPACUserCSS, AllowSelfCheckReturns, OpacFavicon, ShowPatronImageInWebBasedSelfCheck, SelfCheckoutByLogin Sponsored-by: Catalyst IT Signed-off-by: Katrin Fischer -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue May 2 23:23:18 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 02 May 2017 21:23:18 +0000 Subject: [Koha-bugs] [Bug 12601] aqorders.budget_id should be a foreign key In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12601 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #62992|0 |1 is obsolete| | --- Comment #17 from Katrin Fischer --- Comment on attachment 62992 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=62992 [SIGNED OFF] Bug 12691: Use Koha.Preference in Self-Checkout wrong bug number! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue May 2 23:23:36 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 02 May 2017 21:23:36 +0000 Subject: [Koha-bugs] [Bug 12691] Use Koha.Preference for calls to SCOUserJS, SCOUserCSS, OPACUserCSS, opacuserjs, etc in Self-Checkout In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12691 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue May 2 23:23:39 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 02 May 2017 21:23:39 +0000 Subject: [Koha-bugs] [Bug 12691] Use Koha.Preference for calls to SCOUserJS, SCOUserCSS, OPACUserCSS, opacuserjs, etc in Self-Checkout In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12691 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #59961|0 |1 is obsolete| | --- Comment #5 from Katrin Fischer --- Created attachment 62993 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=62993&action=edit [SIGNED OFF] Bug 12691: Use Koha.Preference in Self-Checkout For calls to SCOUserJS, SCOUserCSS, OPACUserCSS, AllowSelfCheckReturns, OpacFavicon, ShowPatronImageInWebBasedSelfCheck, SelfCheckoutByLogin Sponsored-by: Catalyst IT Signed-off-by: Katrin Fischer https://bugs.koha-community.org/show_bug.cgi?id=12601 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue May 2 23:24:10 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 02 May 2017 21:24:10 +0000 Subject: [Koha-bugs] [Bug 17942] Update style of the web installer with Bootstrap 3 In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17942 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Failed QA --- Comment #43 from Jonathan Druart --- 1/ #login_error is not styled, is it expected? 2/ We talked about the default style of btn-primary, should not we apply it a custom style? 3/ "Select no mandatory data", "Select all mandatory data" and others will not be translatable. I think it would be better to list all of them in the template. Note that we should only use "mandatory" and "optional" should be allowed to simplify the structure of our installer files. 4/ TODO later, the JS checks for password should use password_check.inc from bug 18298 (not pushed yet). 5/ Not blocker - "Enrolment period: " block is not really nice ;) 6/ "Enrolment Period" > "Until date" Date is like "MM/DD/YYYY", but hint says "(YYYY-MM-DD)" 7/ There are too many checks defined in onboarding.js, please double... check! (cardnumber_check for instance) -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue May 2 23:26:28 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 02 May 2017 21:26:28 +0000 Subject: [Koha-bugs] [Bug 2454] Don't show credits on Pay Fines Tab In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=2454 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue May 2 23:26:32 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 02 May 2017 21:26:32 +0000 Subject: [Koha-bugs] [Bug 2454] Don't show credits on Pay Fines Tab In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=2454 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #62991|0 |1 is obsolete| | --- Comment #11 from Katrin Fischer --- Created attachment 62994 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=62994&action=edit [SIGNED OFF] Bug 2454 - Amended patch: Removed the display of accountype, Notify ID, Level values for manual credit in pay.tt and replaced the description with string "Credit" Reimplemented accounttype column but kept the notifyid a nd level columns These specific values have been removed because this bug report requires the manual credit to no longer be shown on the 'Pay fines' tab. In response to comment 4 (thankyou for noticing that Felix) I have redone this patch so users can now successfully pay or write off manual credits because the manual credit values although not being displayed are still being submitted to pay.pl. Test plan: 1. From the Koha staff interface go the Patron area and select a patron page 2. Create a fine of $10 for the patron by clicking on the 'Fines' tab and creating a fine in the 'Create manual invoice' tab 3. Create a credit of $5 for the patron in the 'Create manual credit' page 4. Then go to the 'Pay fines' tab and notice there is a row for both the fine and credit both with values in the account type, Notify ID, and level boxes of the table 5. Select "write off all" and 'OK' in the confirmation box 6. Youre redirected to Account tab, return to 'pay fines' tab and notice no fines or credits are displayed 7. Repeat steps 2, 3, 4 and then click "Pay amount", confirm it, then navigate back to the 'Pay fines' tab and notice although the fine and credit are displayed the 'total due' value is 0.00 8. Apply the patch attached to this bug report 9. Repeat steps 2, and 3. 10. Navigate to 'Pay fines' tab and notice the fine has values in account type, Notify ID, and level and the credit does not. Additionally credit has the description value of 'Credit' 11. Repeat steps 5 and 6 and as with before this patch was applied notice the 'Pay fines' tab does not show any fines or credits 12. Repeat step 7 and again notice the 'Total due' value is 0.00 Bug 2454 - Reimplemented accounttype column but kept the notifyid and level columns Signed-off-by: Katrin Fischer -- You are receiving this mail because: You are watching all bug changes. You are the QA Contact for the bug. From bugzilla-daemon at bugs.koha-community.org Tue May 2 23:27:34 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 02 May 2017 21:27:34 +0000 Subject: [Koha-bugs] [Bug 2454] Improve display of credits on pay fines tab In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=2454 Alex Buckley changed: What |Removed |Added ---------------------------------------------------------------------------- Summary|Don't show credits on Pay |Improve display of credits |Fines Tab |on pay fines tab -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue May 2 23:33:27 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 02 May 2017 21:33:27 +0000 Subject: [Koha-bugs] [Bug 18503] Confusing hold and transfer dialog In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18503 Alex Buckley changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |alexbuckley at catalyst.net.nz Status|Needs Signoff |In Discussion --- Comment #2 from Alex Buckley --- Hi Christopher When I apply this patch on a up to date clean branch I get the following error: Applying: Bug 18503: Fixes confusing dialog and other minor fatal: sha1 information is lacking or useless (koha-tmpl/intranet-tmpl/prog/en/modules/circ/returns.tt). Repository lacks necessary blobs to fall back on 3-way merge. Cannot fall back to three-way merge. Patch failed at 0001 Bug 18503: Fixes confusing dialog and other minor The copy of the patch that failed is found in: /home/vagrant/kohaclone/.git/rebase-apply/patch When you have resolved this problem run "git bz apply --continue". If you would prefer to skip this patch, instead run "git bz apply --skip". To restore the original branch and stop patching run "git bz apply --abort". Patch left in /tmp/Bug-18503-Fixes-confusing-dialog-and-other-minor-JMU2nv.patch -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue May 2 23:34:06 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 02 May 2017 21:34:06 +0000 Subject: [Koha-bugs] [Bug 18501] Automatic refunds need protection from failure In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18501 Alex Buckley changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |alexbuckley at catalyst.net.nz Status|NEW |ASSIGNED Assignee|koha-bugs at lists.koha-commun |alexbuckley at catalyst.net.nz |ity.org | -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Tue May 2 23:35:29 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 02 May 2017 21:35:29 +0000 Subject: [Koha-bugs] [Bug 18291] Remove SQL from preferences.pl administrative script In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18291 --- Comment #12 from Jonathan Druart --- Nope. Not everything is cached, but sysprefs are. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue May 2 23:36:52 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 02 May 2017 21:36:52 +0000 Subject: [Koha-bugs] [Bug 18503] Confusing hold and transfer dialog In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18503 --- Comment #3 from Christopher Brannon --- Did you apply the(In reply to Alex Buckley from comment #2) > Hi Christopher > > When I apply this patch on a up to date clean branch I get the following > error: > > Applying: Bug 18503: Fixes confusing dialog and other minor > fatal: sha1 information is lacking or useless > (koha-tmpl/intranet-tmpl/prog/en/modules/circ/returns.tt). > Repository lacks necessary blobs to fall back on 3-way merge. > Cannot fall back to three-way merge. > Patch failed at 0001 Bug 18503: Fixes confusing dialog and other minor > The copy of the patch that failed is found in: > /home/vagrant/kohaclone/.git/rebase-apply/patch > When you have resolved this problem run "git bz apply --continue". > If you would prefer to skip this patch, instead run "git bz apply --skip". > To restore the original branch and stop patching run "git bz apply --abort". > Patch left in > /tmp/Bug-18503-Fixes-confusing-dialog-and-other-minor-JMU2nv.patch Did you apply patch 18490? This patch depends on it. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue May 2 23:37:18 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 02 May 2017 21:37:18 +0000 Subject: [Koha-bugs] [Bug 17600] Standardize the EXPORT In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17600 --- Comment #45 from Jonathan Druart --- Note that I do not support an inclusion of this patch in 17.05 (too many side-effects possible), but should be pushed at the beginning of the next cycle. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue May 2 23:38:17 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 02 May 2017 21:38:17 +0000 Subject: [Koha-bugs] [Bug 18291] Remove SQL from preferences.pl administrative script In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18291 --- Comment #13 from Alex Buckley --- Ah ok so this this patch isn't necessary but I can use a similar approach to how you suggested to solve this bug with the other sql removal bug patches? -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue May 2 23:47:22 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 02 May 2017 21:47:22 +0000 Subject: [Koha-bugs] [Bug 18525] New: Can't create order line from accepted suggestion Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18525 Bug ID: 18525 Summary: Can't create order line from accepted suggestion Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: major Priority: P5 - low Component: Acquisitions Assignee: koha-bugs at lists.koha-community.org Reporter: katrin.fischer at bsz-bw.de QA Contact: testopia at bugs.koha-community.org When I try to create an order line from an accepted suggestion, I get an error: Template process failed: undef error - The method selected is not covered by tests! at /home/vagrant/kohaclone/C4/Templates.pm line 121. Can someone confirm? -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Tue May 2 23:48:52 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 02 May 2017 21:48:52 +0000 Subject: [Koha-bugs] [Bug 13392] New statistics wizard for suggestions In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13392 --- Comment #59 from Katrin Fischer --- I've tried testing this by applying the patches, running the database update, regenerating the Schema. Every time I try to order from my accepted suggestion, an internal server error is shown (running under Plack with kohadevbox). Without Plack the error shown is: Template process failed: undef error - The method selected is not covered by tests! at /home/vagrant/kohaclone/C4/Templates.pm line 121. This prevents me from testing the problem I had earlier :( Filed bug 18525 as I also see this without the patches. But would be good if someone could confirm. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue May 2 23:52:36 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 02 May 2017 21:52:36 +0000 Subject: [Koha-bugs] [Bug 16486] Display the TIME a fine was collected/written off In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16486 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue May 2 23:52:40 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 02 May 2017 21:52:40 +0000 Subject: [Koha-bugs] [Bug 16486] Display the TIME a fine was collected/written off In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16486 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #62703|0 |1 is obsolete| | --- Comment #5 from Katrin Fischer --- Created attachment 62995 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=62995&action=edit [SIGNED OFF] Bug 16486: Display the timestamp for account payments/writeoffs To test: 1) Apply patch 2) Go to the patron account page, Fines tab 3) Click Account tab 4) Confirm timestamp shows next to payments and writeoffs 5) Go to Admin -> TimeFormat syspref, change the format 6) Refresh the fines page, confirm time format changes Sponsored-by: Catalyst IT Signed-off-by: Katrin Fischer -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue May 2 23:58:27 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 02 May 2017 21:58:27 +0000 Subject: [Koha-bugs] [Bug 17944] Remove the sql code from itemtypes.pl administrative perl script In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17944 --- Comment #39 from Jonathan Druart --- Alex, Please squash all the patches and resubmit, for readability ;) For the check, I think the best would be to override Koha::Object->delete from Koha::ItemType->delete (`git grep 'sub delete' Koha` for examples), and raise an exception if the item type cannot be deleted. You will need to surround the ->delete call with an eval in the pl script. Let me known if you have any questions about this suggestion. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue May 2 23:59:43 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 02 May 2017 21:59:43 +0000 Subject: [Koha-bugs] [Bug 18503] Confusing hold and transfer dialog In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18503 --- Comment #4 from Alex Buckley --- Yup I applied bug 18490 first -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed May 3 00:01:09 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 02 May 2017 22:01:09 +0000 Subject: [Koha-bugs] [Bug 18247] Remove SQL queries from branch_transfer_limit.pl administrative script In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18247 --- Comment #9 from Jonathan Druart --- The Get* method you added with this patch can be replaced with Koha::YourObjects->find, or ->search No need to add new methods. For instance GetBranchCodes can be replaced with my @branchcodes = Koha::Libraries->search->get_column('branchcode'); -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed May 3 00:01:27 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 02 May 2017 22:01:27 +0000 Subject: [Koha-bugs] [Bug 18286] Test::DBIx::Class connection/ schema is shadowed by a cached connection/schema In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18286 Mason James changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |mtj at kohaaloha.com -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed May 3 00:02:05 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 02 May 2017 22:02:05 +0000 Subject: [Koha-bugs] [Bug 18285] Koha::Database schema cache accessors In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18285 Mason James changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |mtj at kohaaloha.com -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed May 3 00:03:02 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 02 May 2017 22:03:02 +0000 Subject: [Koha-bugs] [Bug 18299] Removal of admin/env_tz_test.pl script In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18299 Alex Buckley changed: What |Removed |Added ---------------------------------------------------------------------------- Summary|Removal of SQL queries from |Removal of |admin/env_tz_test.pl script |admin/env_tz_test.pl script |into a perl module | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed May 3 00:03:29 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 02 May 2017 22:03:29 +0000 Subject: [Koha-bugs] [Bug 18299] Removal of admin/env_tz_test.pl script In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18299 Alex Buckley changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #62515|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed May 3 00:03:47 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 02 May 2017 22:03:47 +0000 Subject: [Koha-bugs] [Bug 18299] Removal of admin/env_tz_test.pl script In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18299 Alex Buckley changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #62516|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed May 3 00:06:39 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 02 May 2017 22:06:39 +0000 Subject: [Koha-bugs] [Bug 18299] Removal of admin/env_tz_test.pl script In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18299 --- Comment #10 from Alex Buckley --- Created attachment 62996 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=62996&action=edit Bug 18299 - Removed unused env_tz_test.pl based on user testing feedback -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed May 3 00:06:59 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 02 May 2017 22:06:59 +0000 Subject: [Koha-bugs] [Bug 18299] Removal of admin/env_tz_test.pl script In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18299 Alex Buckley changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed May 3 00:10:55 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 02 May 2017 22:10:55 +0000 Subject: [Koha-bugs] [Bug 18525] Can't create order line from accepted suggestion In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18525 --- Comment #1 from Katrin Fischer --- The problem appears, when item-level_itypes = biblio. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Wed May 3 00:15:41 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 02 May 2017 22:15:41 +0000 Subject: [Koha-bugs] [Bug 18525] Can't create order line from accepted suggestion In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18525 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Wed May 3 00:15:45 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 02 May 2017 22:15:45 +0000 Subject: [Koha-bugs] [Bug 18525] Can't create order line from accepted suggestion In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18525 --- Comment #2 from Jonathan Druart --- Created attachment 62997 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=62997&action=edit Bug 18525: (bug 14828 follow-up) FIX ordering from suggestion when item-level_itypes = biblio When ordering from a suggestion with item-level_itypes = biblio the app crashes with Template process failed: undef error - The method selected is not covered by tests! at /home/vagrant/kohaclone/C4/Templates.pm line 121. C4::ItemTypes->all did not set a selected flag. The item type is only display when ordering (and not modifying an order). The flag is never set, the test can be removed. Test plan: Confirm that the error is gone -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Wed May 3 00:16:09 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 02 May 2017 22:16:09 +0000 Subject: [Koha-bugs] [Bug 18525] Can't create order line from accepted suggestion In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18525 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|koha-bugs at lists.koha-commun |jonathan.druart at bugs.koha-c |ity.org |ommunity.org CC| |jonathan.druart at bugs.koha-c | |ommunity.org -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed May 3 00:18:37 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 02 May 2017 22:18:37 +0000 Subject: [Koha-bugs] [Bug 12732] Sort late orders by basket creation or closing date In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12732 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Failed QA --- Comment #18 from Katrin Fischer --- The patches apply right now, but 3 things: 1) there are still no unit tests for the changes to the core routine 2) if we decide to have a system preference for this kind of behaviour, I'd suggest to rename it from AcqLateOrderUseCreationDate to AcqLaterOderDefaultSort which be more descriptive. 3) The SQL in sysprefs.sql is wrong: FAIL installer/data/mysql/sysprefs.sql OK git manipulation FAIL semicolon simicolon found instead of comma at line 6 OK sysprefs_order I agree with previous commenters that it doesn't seem quite right to switch the dates in the column like this. I'd like it if both were shown and the sorting handled by JavaScript. I think it would add valuable information and allow for more flexibility. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed May 3 00:18:41 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 02 May 2017 22:18:41 +0000 Subject: [Koha-bugs] [Bug 18291] Remove SQL from preferences.pl administrative script In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18291 --- Comment #14 from Jonathan Druart --- (In reply to Alex Buckley from comment #13) > Ah ok so this this patch isn't necessary but I can use a similar approach to > how you suggested to solve this bug with the other sql removal bug patches? Exactly :) -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed May 3 00:19:18 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 02 May 2017 22:19:18 +0000 Subject: [Koha-bugs] [Bug 18291] Remove SQL from preferences.pl administrative script In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18291 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Status|In Discussion |RESOLVED Resolution|--- |INVALID -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed May 3 00:25:04 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 02 May 2017 22:25:04 +0000 Subject: [Koha-bugs] [Bug 18525] Can't create order line from accepted suggestion In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18525 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Patch complexity|--- |Small patch Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed May 3 00:25:07 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 02 May 2017 22:25:07 +0000 Subject: [Koha-bugs] [Bug 18525] Can't create order line from accepted suggestion In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18525 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #62997|0 |1 is obsolete| | --- Comment #3 from Katrin Fischer --- Created attachment 62998 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=62998&action=edit [SIGNED OFF] Bug 18525: (bug 14828 follow-up) FIX ordering from suggestion when item-level_itypes = biblio When ordering from a suggestion with item-level_itypes = biblio the app crashes with Template process failed: undef error - The method selected is not covered by tests! at /home/vagrant/kohaclone/C4/Templates.pm line 121. C4::ItemTypes->all did not set a selected flag. The item type is only display when ordering (and not modifying an order). The flag is never set, the test can be removed. Test plan: Confirm that the error is gone Signed-off-by: Katrin Fischer -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed May 3 00:25:16 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 02 May 2017 22:25:16 +0000 Subject: [Koha-bugs] [Bug 7550] Self checkout: limit display of patron image to logged-in patron In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7550 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |12691 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12691 [Bug 12691] Use Koha.Preference for calls to SCOUserJS, SCOUserCSS, OPACUserCSS, opacuserjs, etc in Self-Checkout -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed May 3 00:25:16 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 02 May 2017 22:25:16 +0000 Subject: [Koha-bugs] [Bug 12691] Use Koha.Preference for calls to SCOUserJS, SCOUserCSS, OPACUserCSS, opacuserjs, etc in Self-Checkout In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12691 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Patch doesn't apply CC| |jonathan.druart at bugs.koha-c | |ommunity.org Depends on| |7550 --- Comment #6 from Jonathan Druart --- This patch will not apply on top of bug 7550 (Passed QA), please rebase it on top. Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7550 [Bug 7550] Self checkout: limit display of patron image to logged-in patron -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed May 3 00:42:17 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 02 May 2017 22:42:17 +0000 Subject: [Koha-bugs] [Bug 18355] Permanent location should show with cart location In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18355 Christopher Brannon changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed May 3 00:42:19 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 02 May 2017 22:42:19 +0000 Subject: [Koha-bugs] [Bug 18355] Permanent location should show with cart location In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18355 Christopher Brannon changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #61984|0 |1 is obsolete| | --- Comment #9 from Christopher Brannon --- Created attachment 62999 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=62999&action=edit Bug 18355: Modifies location on detail pages. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed May 3 00:43:06 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 02 May 2017 22:43:06 +0000 Subject: [Koha-bugs] [Bug 18233] t/db_dependent/00-strict.t has non-existant resetversion.pl In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18233 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Patch complexity|--- |Trivial patch Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed May 3 00:43:10 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 02 May 2017 22:43:10 +0000 Subject: [Koha-bugs] [Bug 18233] t/db_dependent/00-strict.t has non-existant resetversion.pl In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18233 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #60924|0 |1 is obsolete| | --- Comment #2 from Katrin Fischer --- Created attachment 63000 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=63000&action=edit [SIGNED OFF] Bug 18233 - t/db_dependent/00-strict.t has non-existant resetversion.pl Removes a warning. Signed-off-by: Katrin Fischer -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed May 3 00:45:33 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 02 May 2017 22:45:33 +0000 Subject: [Koha-bugs] [Bug 18355] Permanent location should show with cart location In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18355 --- Comment #10 from Christopher Brannon --- (In reply to Nick Clemens from comment #8) > I like the idea, two strange display issues: > > 1 - Items with no location before cart display as "CART (Book Cart)", I > would expect just to see "Book cart" > 2 - Items with a shelving location not tied to an authorized value also > display as "CART (Book Cart)" I would expect to see "Book Cart (value)" Good catch. It is fixed. Didn't have the same issue on the OPAC. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed May 3 00:47:02 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 02 May 2017 22:47:02 +0000 Subject: [Koha-bugs] [Bug 18299] Removal of admin/env_tz_test.pl script In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18299 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Patch complexity|--- |Trivial patch Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed May 3 00:47:06 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 02 May 2017 22:47:06 +0000 Subject: [Koha-bugs] [Bug 18299] Removal of admin/env_tz_test.pl script In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18299 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #62996|0 |1 is obsolete| | --- Comment #11 from Katrin Fischer --- Created attachment 63001 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=63001&action=edit [SIGNED OFF] Bug 18299 - Removed unused env_tz_test.pl based on user testing feedback Signed-off-by: Katrin Fischer -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed May 3 03:08:59 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 03 May 2017 01:08:59 +0000 Subject: [Koha-bugs] [Bug 17110] Lower CSRF expiry in Koha::Token In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17110 --- Comment #15 from Mason James --- (In reply to Kyle M Hall from comment #14) > Pushed to master for 16.11, thanks Marcel! Pushed to 16.05.x, for 16.05.12 release (required for BZ-17096) -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed May 3 03:09:42 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 03 May 2017 01:09:42 +0000 Subject: [Koha-bugs] [Bug 18305] jquery.fixFloat.js breaks advanced MARC editor for some browsers In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18305 Mason James changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |mtj at kohaaloha.com --- Comment #10 from Mason James --- Pushed to 16.05.x, for 16.05.12 release -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed May 3 03:30:16 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 03 May 2017 01:30:16 +0000 Subject: [Koha-bugs] [Bug 18526] New: Test t/Token.t fails on master Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18526 Bug ID: 18526 Summary: Test t/Token.t fails on master Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: normal Priority: P5 - low Component: Test Suite Assignee: chris at bigballofwax.co.nz Reporter: mtj at kohaaloha.com QA Contact: gmcharlt at gmail.com this seems to fail on 16.11.x and 16.05.x too can anyone else verify this please -------------------- $ prove t/Token.t 1..10 ok 1 - Generate without parameters ok 2 - Token :|%}VN^o\GFJ~fz~U.L7 has 20 chars Use of uninitialized value $csrftoken in concatenation (.) or string at t/Token.t line 38. ok 3 - Token should not be empty ok 4 - Check without any parameters not ok 5 - CSRF token verified # Failed test 'CSRF token verified' # at t/Token.t line 44. # got: undef # expected: '1' ok 6 - This token is no CSRF token not ok 7 - CSRF token still valid within one second # Failed test 'CSRF token still valid within one second' # at t/Token.t line 56. # got: undef # expected: '1' ok 8 - CSRF token expired after one second # Subtest: Same id (cookie CGISESSID) with an other logged in user 1..2 not ok 1 - CSRF token verified # Failed test 'CSRF token verified' # at t/Token.t line 69. # got: undef # expected: '1' not ok 2 - CSRF token is not verified if another logged in user is using the same id # Failed test 'CSRF token is not verified if another logged in user is using the same id' # at t/Token.t line 74. # got: undef # expected: '' # Looks like you failed 2 tests of 2. not ok 9 - Same id (cookie CGISESSID) with an other logged in user # Failed test 'Same id (cookie CGISESSID) with an other logged in user' # at t/Token.t line 75. # Subtest: Same logged in user with another session (cookie CGISESSID) 1..2 not ok 1 - CSRF token verified # Failed test 'CSRF token verified' # at t/Token.t line 84. # got: undef # expected: '1' not ok 2 - CSRF token is not verified if another session is used # Failed test 'CSRF token is not verified if another session is used' # at t/Token.t line 90. # got: undef # expected: '' # Looks like you failed 2 tests of 2. not ok 10 - Same logged in user with another session (cookie CGISESSID) # Failed test 'Same logged in user with another session (cookie CGISESSID)' # at t/Token.t line 91. # Looks like you failed 4 tests of 10. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed May 3 03:42:52 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 03 May 2017 01:42:52 +0000 Subject: [Koha-bugs] [Bug 8603] Patron card creator - 'Barcode Type' doesn't stick in layouts In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8603 Mason James changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |mtj at kohaaloha.com --- Comment #11 from Mason James --- Pushed to 16.05.x, for 16.05.12 release -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed May 3 04:26:39 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 03 May 2017 02:26:39 +0000 Subject: [Koha-bugs] [Bug 17109] sendbasket: Remove second authentication, add CSRF token In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17109 --- Comment #15 from Mason James --- Pushed to 16.05.x, for 16.05.12 release -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed May 3 04:52:59 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 03 May 2017 02:52:59 +0000 Subject: [Koha-bugs] [Bug 17830] CSRF token is not generated correctly (bis) In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17830 --- Comment #8 from Mason James --- patchset applied via BZ-18124 for 16.05.x, for 16.05.12 release -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed May 3 04:53:44 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 03 May 2017 02:53:44 +0000 Subject: [Koha-bugs] [Bug 17830] CSRF token is not generated correctly (bis) In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17830 Mason James changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |https://bugs.koha-community | |.org/bugzilla3/show_bug.cgi | |?id=18124 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed May 3 05:42:51 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 03 May 2017 03:42:51 +0000 Subject: [Koha-bugs] [Bug 18246] Patron card creator: Units not always display properly in layouts In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18246 Mason James changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |mtj at kohaaloha.com --- Comment #7 from Mason James --- Pushed to 16.05.x, for 16.05.12 release -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed May 3 05:43:14 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 03 May 2017 03:43:14 +0000 Subject: [Koha-bugs] [Bug 18094] Patron search filters are broken by searchable attributes In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18094 Mason James changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |mtj at kohaaloha.com --- Comment #10 from Mason James --- Pushed to 16.05.x, for 16.05.12 release -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed May 3 05:43:41 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 03 May 2017 03:43:41 +0000 Subject: [Koha-bugs] [Bug 18069] koha-rebuild-zebra still calls rebuild_zebra with -x In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18069 --- Comment #6 from Mason James --- Pushed to 16.05.x, for 16.05.12 release -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed May 3 05:44:54 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 03 May 2017 03:44:54 +0000 Subject: [Koha-bugs] [Bug 18028] install_misc directory is outdated and must be removed In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18028 --- Comment #9 from Mason James --- Pushed to 16.05.x, for 16.05.12 release -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed May 3 05:45:07 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 03 May 2017 03:45:07 +0000 Subject: [Koha-bugs] [Bug 18373] `make upgrade` is broken In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18373 --- Comment #10 from Mason James --- Pushed to 16.05.x, for 16.05.12 release -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed May 3 05:46:53 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 03 May 2017 03:46:53 +0000 Subject: [Koha-bugs] [Bug 17605] EDI should set currency in order record on creation In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17605 Mason James changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |mtj at kohaaloha.com --- Comment #16 from Mason James --- Pushed to 16.05.x, for 16.05.12 release -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed May 3 05:48:45 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 03 May 2017 03:48:45 +0000 Subject: [Koha-bugs] [Bug 15854] Race condition for sending renewal/check-in notices In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15854 --- Comment #22 from Mason James --- (In reply to Julian Maurice from comment #13) > Pushed to 3.22.x, will be in 3.22.19 Pushed to 16.05.x, for 16.05.12 release -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed May 3 05:49:04 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 03 May 2017 03:49:04 +0000 Subject: [Koha-bugs] [Bug 18364] LOCK and UNLOCK are not transaction-safe In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18364 Mason James changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |mtj at kohaaloha.com --- Comment #15 from Mason James --- Pushed to 16.05.x, for 16.05.12 release -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed May 3 05:50:26 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 03 May 2017 03:50:26 +0000 Subject: [Koha-bugs] [Bug 18527] New: Add a system preference to exclude renewals from the quick slip Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18527 Bug ID: 18527 Summary: Add a system preference to exclude renewals from the quick slip Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Circulation Assignee: koha-bugs at lists.koha-community.org Reporter: liz at catalyst.net.nz QA Contact: testopia at bugs.koha-community.org CC: gmcharlt at gmail.com, kyle.m.hall at gmail.com Some libraries prefer to not show renewals on the day's circulations, printed on the quick slip. Propose to add a system preference to allow exclusion of these circulations from the quick slip. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed May 3 05:50:35 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 03 May 2017 03:50:35 +0000 Subject: [Koha-bugs] [Bug 18527] Add a system preference to exclude renewals from the quick slip In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18527 Liz Rea changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|koha-bugs at lists.koha-commun |liz at catalyst.net.nz |ity.org | -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Wed May 3 05:50:52 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 03 May 2017 03:50:52 +0000 Subject: [Koha-bugs] [Bug 18364] LOCK and UNLOCK are not transaction-safe In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18364 Mason James changed: What |Removed |Added ---------------------------------------------------------------------------- Keywords| |rel_3_22_candidate --- Comment #16 from Mason James --- i think 3.22.x needs this patch, because of BZ-15854 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed May 3 05:52:17 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 03 May 2017 03:52:17 +0000 Subject: [Koha-bugs] [Bug 18058] 'borrowers-force-messaging-defaults --doit --truncate ' gives DBI error In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18058 --- Comment #8 from Mason James --- Pushed to 16.05.x, for 16.05.12 release -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed May 3 05:52:37 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 03 May 2017 03:52:37 +0000 Subject: [Koha-bugs] [Bug 18022] Empty barcode causes internal server error In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18022 Mason James changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |mtj at kohaaloha.com --- Comment #14 from Mason James --- Pushed to 16.05.x, for 16.05.12 release -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed May 3 05:53:06 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 03 May 2017 03:53:06 +0000 Subject: [Koha-bugs] [Bug 17995] HOLDPLACED notice should have access to the reserves table In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17995 Mason James changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |mtj at kohaaloha.com --- Comment #9 from Mason James --- Pushed to 16.05.x, for 16.05.12 release -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed May 3 05:53:40 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 03 May 2017 03:53:40 +0000 Subject: [Koha-bugs] [Bug 17758] SIP checkin does not handle holds correctly In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17758 Mason James changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |mtj at kohaaloha.com --- Comment #7 from Mason James --- Pushed to 16.05.x, for 16.05.12 release -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Wed May 3 05:55:52 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 03 May 2017 03:55:52 +0000 Subject: [Koha-bugs] [Bug 12913] Fix wrong inventory results In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12913 Mason James changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |mtj at kohaaloha.com --- Comment #18 from Mason James --- Pushed to 16.05.x, for 16.05.12 release -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed May 3 05:56:24 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 03 May 2017 03:56:24 +0000 Subject: [Koha-bugs] [Bug 14535] Late orders does not show orders with price = 0 In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14535 Mason James changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |mtj at kohaaloha.com --- Comment #28 from Mason James --- Pushed to 16.05.x, for 16.05.12 release -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed May 3 05:56:33 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 03 May 2017 03:56:33 +0000 Subject: [Koha-bugs] [Bug 18244] Patron card creator does not take in account fields with underscore ( B_address etc.) In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18244 Mason James changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |mtj at kohaaloha.com --- Comment #18 from Mason James --- Pushed to 16.05.x, for 16.05.12 release -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed May 3 05:57:13 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 03 May 2017 03:57:13 +0000 Subject: [Koha-bugs] [Bug 12972] Transfer slip and transfer message (blue box) can conflict In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12972 Mason James changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |mtj at kohaaloha.com --- Comment #7 from Mason James --- Pushed to 16.05.x, for 16.05.12 release -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed May 3 05:57:21 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 03 May 2017 03:57:21 +0000 Subject: [Koha-bugs] [Bug 7728] Fixing subscription endddate inconsistency: should be empty when the subscription is running In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7728 Mason James changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |mtj at kohaaloha.com --- Comment #25 from Mason James --- Pushed to 16.05.x, for 16.05.12 release -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed May 3 05:58:11 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 03 May 2017 03:58:11 +0000 Subject: [Koha-bugs] [Bug 18209] Patron's card manage.pl page is not fully translatable In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18209 Mason James changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |mtj at kohaaloha.com --- Comment #11 from Mason James --- Pushed to 16.05.x, for 16.05.12 release -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed May 3 06:02:13 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 03 May 2017 04:02:13 +0000 Subject: [Koha-bugs] [Bug 18307] Branchname is no longer displayed in subscription tab view In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18307 Mason James changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |mtj at kohaaloha.com --- Comment #9 from Mason James --- (In reply to Katrin Fischer from comment #8) > This patch has been pushed to 16.11.x and will be in 16.11.07. Blocked by Enhancement, skipping for 16.05.x -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed May 3 06:04:13 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 03 May 2017 04:04:13 +0000 Subject: [Koha-bugs] [Bug 18307] Branchname is no longer displayed in subscription tab view In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18307 --- Comment #10 from Mason James --- (In reply to Mason James from comment #9) > (In reply to Katrin Fischer from comment #8) > > This patch has been pushed to 16.11.x and will be in 16.11.07. > > Blocked by Enhancement, skipping for 16.05.x hi Katrin, 16.11.x may need patch BZ-17946 now -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed May 3 06:05:53 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 03 May 2017 04:05:53 +0000 Subject: [Koha-bugs] [Bug 17290] Standardize on "Patron categories" when referring to patron category In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17290 Mason James changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |mtj at kohaaloha.com --- Comment #12 from Mason James --- Pushed to 16.05.x, for 16.05.12 release -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed May 3 06:07:07 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 03 May 2017 04:07:07 +0000 Subject: [Koha-bugs] [Bug 18263] Make use of syspref 'CurrencyFormat' for Account and Pay fines tables In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18263 Mason James changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |mtj at kohaaloha.com --- Comment #7 from Mason James --- Pushed to 16.05.x, for 16.05.12 release -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed May 3 06:07:18 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 03 May 2017 04:07:18 +0000 Subject: [Koha-bugs] [Bug 17945] Breadcrumbs broken on opac-serial-issues.pl In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17945 Mason James changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |mtj at kohaaloha.com --- Comment #10 from Mason James --- Pushed to 16.05.x, for 16.05.12 release -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed May 3 06:08:23 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 03 May 2017 04:08:23 +0000 Subject: [Koha-bugs] [Bug 17346] Enable the check in option in Columns settings In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17346 Mason James changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |mtj at kohaaloha.com --- Comment #14 from Mason James --- Pushed to 16.05.x, for 16.05.12 release -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed May 3 06:08:35 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 03 May 2017 04:08:35 +0000 Subject: [Koha-bugs] [Bug 18266] Internal Server Error when paying fine for lost item In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18266 --- Comment #12 from Mason James --- Pushed to 16.05.x, for 16.05.12 release -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed May 3 06:08:50 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 03 May 2017 04:08:50 +0000 Subject: [Koha-bugs] [Bug 18329] Batch record deletion broken In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18329 Mason James changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |mtj at kohaaloha.com --- Comment #10 from Mason James --- Pushed to 16.05.x, for 16.05.12 release -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed May 3 06:09:47 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 03 May 2017 04:09:47 +0000 Subject: [Koha-bugs] [Bug 17309] Renewing and HomeOrHoldingBranch syspref In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17309 Mason James changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |mtj at kohaaloha.com --- Comment #14 from Mason James --- Pushed to 16.05.x, for 16.05.12 release -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed May 3 06:26:50 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 03 May 2017 04:26:50 +0000 Subject: [Koha-bugs] [Bug 17872] Fix small error in GetBudgetHierarchy and one of its calls In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17872 Mason James changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |mtj at kohaaloha.com --- Comment #11 from Mason James --- Pushed to 16.05.x, for 16.05.12 release -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed May 3 06:27:14 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 03 May 2017 04:27:14 +0000 Subject: [Koha-bugs] [Bug 12930] Web installer does not show login errors In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12930 Mason James changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |mtj at kohaaloha.com --- Comment #17 from Mason James --- Pushed to 16.05.x, for 16.05.12 release -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed May 3 06:28:06 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 03 May 2017 04:28:06 +0000 Subject: [Koha-bugs] [Bug 17821] due date in intranet search results should use TT date plugin In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17821 Mason James changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |mtj at kohaaloha.com --- Comment #11 from Mason James --- Pushed to 16.05.x, for 16.05.12 release -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed May 3 06:32:10 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 03 May 2017 04:32:10 +0000 Subject: [Koha-bugs] [Bug 18439] Resend button for notices being hidden by CSS and never unhidden In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18439 Mason James changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |mtj at kohaaloha.com --- Comment #8 from Mason James --- Pushed to 16.05.x, for 16.05.12 release -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed May 3 06:33:48 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 03 May 2017 04:33:48 +0000 Subject: [Koha-bugs] [Bug 17814] koha-plack --stop should make sure that Plack really stop In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17814 Mason James changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |mtj at kohaaloha.com --- Comment #13 from Mason James --- Pushed to 16.05.x, for 16.05.12 release -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed May 3 06:34:05 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 03 May 2017 04:34:05 +0000 Subject: [Koha-bugs] [Bug 18372] transits are not created at check in despite user responsing Yes to the prompt In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18372 Mason James changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |mtj at kohaaloha.com --- Comment #13 from Mason James --- Pushed to 16.05.x, for 16.05.12 release -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed May 3 06:35:04 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 03 May 2017 04:35:04 +0000 Subject: [Koha-bugs] [Bug 17911] Message and timeout mismatch at the end of the install process In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17911 Mason James changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |mtj at kohaaloha.com --- Comment #6 from Mason James --- Pushed to 16.05.x, for 16.05.12 release -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed May 3 06:36:05 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 03 May 2017 04:36:05 +0000 Subject: [Koha-bugs] [Bug 18423] Add child button not always appearing - problem in template variable In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18423 Mason James changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |mtj at kohaaloha.com --- Comment #20 from Mason James --- Pushed to 16.05.x, for 16.05.12 release -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed May 3 06:39:08 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 03 May 2017 04:39:08 +0000 Subject: [Koha-bugs] [Bug 12021] SIP2 checkin should alert on transfer and use CT for return branch In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12021 Mason James changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |mtj at kohaaloha.com --- Comment #21 from Mason James --- Pushed to 16.05.x, for 16.05.12 release -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed May 3 06:40:10 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 03 May 2017 04:40:10 +0000 Subject: [Koha-bugs] [Bug 18460] Remove itemtype-related Serials.t warnings In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18460 Mason James changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |mtj at kohaaloha.com --- Comment #7 from Mason James --- Pushed to 16.05.x, for 16.05.12 release -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed May 3 06:41:18 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 03 May 2017 04:41:18 +0000 Subject: [Koha-bugs] [Bug 18335] Check in: Make patron info in hold messages obey syspref AddressFormat In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18335 Mason James changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |mtj at kohaaloha.com --- Comment #7 from Mason James --- Pushed to 16.05.x, for 16.05.12 release -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed May 3 06:41:42 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 03 May 2017 04:41:42 +0000 Subject: [Koha-bugs] [Bug 18429] Receiving an item should update the datelastseen In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18429 Mason James changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |mtj at kohaaloha.com --- Comment #10 from Mason James --- Pushed to 16.05.x, for 16.05.12 release -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed May 3 07:35:30 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 03 May 2017 05:35:30 +0000 Subject: [Koha-bugs] [Bug 18438] Check in: Modal about holds hides important check in messages In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18438 Josef Moravec changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Failed QA --- Comment #13 from Josef Moravec --- (In reply to Alex Buckley from comment #12) > Created attachment 62955 [details] [review] > Bug 18438 - Added focus on the checkin barcode input box after modal box is > dismissed Alex, you should avoid to use onclick parameter on submit button. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed May 3 08:49:52 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 03 May 2017 06:49:52 +0000 Subject: [Koha-bugs] [Bug 16486] Display the TIME a fine was collected/written off In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16486 --- Comment #6 from Theodoros Theodoropoulos --- Thank you all for your work on this request. I can verify that the provided patch works as expected! [FYI, for Koha 3.20 the patch needs one line less, because 'Hold waiting too long' is not available] Having said that, unless you print slips with the text from the description, I think it would be more generic to simply change the date column to show hours/minutes in ALL fine lines. Following Owen's suggestion, it would be something like this: -
    + What do you think? -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed May 3 09:20:42 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 03 May 2017 07:20:42 +0000 Subject: [Koha-bugs] [Bug 18438] Check in: Modal about holds hides important check in messages In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18438 Alex Buckley changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #62955|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed May 3 09:21:18 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 03 May 2017 07:21:18 +0000 Subject: [Koha-bugs] [Bug 18438] Check in: Modal about holds hides important check in messages In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18438 --- Comment #14 from Alex Buckley --- Created attachment 63002 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=63002&action=edit Bug 18438 - Amended implementation of focus on barcode input box when the modal box is closed. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed May 3 09:24:42 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 03 May 2017 07:24:42 +0000 Subject: [Koha-bugs] [Bug 18152] UNIMARC bib records imported with invalid 'a' char in label pos.9 In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18152 --- Comment #12 from stephane.delaune at biblibre.com --- Answers to the above questions : - Question 1 :? I never said "MARC::Record does not handle UNIMARC records correctly" ! MARC::Record->encoding('utf-8') add 'a' char in the 9th label'pos, it's ok in MARC21 and NORMARC but not in UNIMARC (requires than the 9th character in labels must be blank) C4::Charset::SetMarcUnicodeFlag always call MARC::Record->encoding('utf-8') but it should only do for MARC21 and NORMARC - Question 2 :? In SetMarcUnicodeFlag, if MARC21 or NORMARC already do ?substr($leader, 9, 1) = 'a'? in addition to MARC::Record->encoding('utf-8') (Which does exactly the same thing for UNIMARC MARC21 NORMARC) We had the choice between : - move the ?MARC::Record->encoding('utf-8')?'s call instead of ?substr($leader, 9, 1) = 'a'? (it's your proposition) - delete the ?MARC::Record->encoding('utf-8')?'s call and keep ?substr($leader, 9, 1) = 'a'? (chosen solution) Both are equivalent because ?MARC::Record->encoding('utf-8')? only do one thing : ?substr($leader, 9, 1) = 'a'? - Question 3 :? I do not understand the problem and I do not know how to do this -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed May 3 09:36:40 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 03 May 2017 07:36:40 +0000 Subject: [Koha-bugs] [Bug 18438] Check in: Modal about holds hides important check in messages In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18438 Alex Buckley changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed May 3 09:59:49 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 03 May 2017 07:59:49 +0000 Subject: [Koha-bugs] [Bug 18438] Check in: Modal about holds hides important check in messages In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18438 Josef Moravec changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed May 3 09:59:52 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 03 May 2017 07:59:52 +0000 Subject: [Koha-bugs] [Bug 18438] Check in: Modal about holds hides important check in messages In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18438 Josef Moravec changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #62444|0 |1 is obsolete| | Attachment #62445|0 |1 is obsolete| | Attachment #62446|0 |1 is obsolete| | Attachment #62708|0 |1 is obsolete| | Attachment #63002|0 |1 is obsolete| | --- Comment #15 from Josef Moravec --- Created attachment 63003 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=63003&action=edit [SIGNED-OFF] Bug 18438 - Implemented data-dismiss="modal" attribute on 'Confirm hold' and 'confirm' buttons so when they are cliked the modal box dissapears and any warning messages that were hidden by the box are now visible. The form is submitted via the js onclick function when the 'Comfirm holds' button is clicked because the checkin needs to be triggered by clicking this button. However when the 'Confirm' button is displayed this means that the item was not checked out when the user is trying to check it back in. In which case the check in does not need to be triggered and so in this patch the 'Confirm' button does not submt the form it simply closes the modal box to show any warning messages behind. Test plan: 1. Check out an item to one patron whilst having that item also being on hold to another patron 2. Check the item back in 3. Notice a modal box appears greying out the background with three buttons 'Confirm hold', 'Print and confirm' and 'Ignore'. Click confirm and notice that the page refreshes and no yellow warning messages are able to be displayed 4. Now that you have checked the item in. Try checking it in a second time by clicking on the Checkin tab and writing in the barcode. 5. The modal box will appear again, this time with three buttons 'Confirm', 'Print and confirm' and 'Cancel hold' 6. Click the 'Confirm' button and the page refreshes again and the yellow warning message hidden by the modal box is not properly displayed to the user 7. Apply patch 8. Try checking in the item again, and this time after clicking the 'confirm' button on the modal box notice that the yellow warning message is displayed telling the user the item was "Not checked out" 9. Drop the hold on the item and make sure it is not checked out. 10. Repeat steps 1 and 2 and notice after clicking the 'Confirm hold' button the page refreshes and the item is successfully checked back in Tested 3 patches together, followed test plan, works as expected. Signed-off-by: Marc V?ron Signed-off-by: Josef Moravec -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed May 3 09:59:59 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 03 May 2017 07:59:59 +0000 Subject: [Koha-bugs] [Bug 18438] Check in: Modal about holds hides important check in messages In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18438 --- Comment #16 from Josef Moravec --- Created attachment 63004 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=63004&action=edit [SIGNED-OFF] Bug 18438 - Removed unused js function call and if statement check for running js function Signed-off-by: Marc V?ron Signed-off-by: Josef Moravec -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed May 3 10:00:05 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 03 May 2017 08:00:05 +0000 Subject: [Koha-bugs] [Bug 18438] Check in: Modal about holds hides important check in messages In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18438 --- Comment #17 from Josef Moravec --- Created attachment 63005 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=63005&action=edit [SIGNED-OFF] Bug 18438 - Removed onclick event on 'Confirm hold' button to adhere to coding guidelines following feedback Signed-off-by: Marc V?ron Signed-off-by: Josef Moravec -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed May 3 10:00:11 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 03 May 2017 08:00:11 +0000 Subject: [Koha-bugs] [Bug 18438] Check in: Modal about holds hides important check in messages In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18438 --- Comment #18 from Josef Moravec --- Created attachment 63006 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=63006&action=edit [SIGNED-OFF] Bug 18438 - Removed the data-dismiss="modal" from all confirm buttons except where an item is waiting. This means the hold is confirmed for a item by the form submitting and page reloading in all cases except where the item is being attempted to be checked in again where it is actually waiting in the library for pickuop by user with a hold on it. The confirm button in this case does not require the page reloading because the hidden input 'cancel_reserve' value of it is 0 Same test plan as comment 1 Signed-off-by: Josef Moravec -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed May 3 10:00:17 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 03 May 2017 08:00:17 +0000 Subject: [Koha-bugs] [Bug 18438] Check in: Modal about holds hides important check in messages In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18438 --- Comment #19 from Josef Moravec --- Created attachment 63007 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=63007&action=edit [SIGNED-OFF] Bug 18438 - Amended implementation of focus on barcode input box when the modal box is closed. Signed-off-by: Josef Moravec -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed May 3 10:05:18 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 03 May 2017 08:05:18 +0000 Subject: [Koha-bugs] [Bug 5456] Create a link to opac-ics.pl In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5456 --- Comment #14 from Magnus Enger --- (In reply to John Andrews from comment #13) > There's a problem with the lack of end time -- when importing this into my > outlook calendar, because there's no end time, outlook automatically creates > an hour long event. Which means that the due date reminder shows up both on > the due date, and on the day AFTER the due date. In our case, the time due > is 11:59 pm, so the appointment gets created in outlook as from 11:59 pm on > the due date until 12:59 am on the next day. Is there a way to force the > appointment to start and end at the same time? Please report this as a new bug/issue. -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed May 3 10:48:37 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 03 May 2017 08:48:37 +0000 Subject: [Koha-bugs] [Bug 18152] UNIMARC bib records imported with invalid 'a' char in label pos.9 In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18152 --- Comment #13 from Paul Poulain --- Stephane, if you look at your patch: >From 9f6f0e05c9c44164d4c2d8f00f4bbd2afd87b847 Mon Sep 17 00:00:00 2001 From: Koha User <<<<<<< THIS IS WRONG Date: Wed, 22 Feb 2017 12:25:33 +0100 Set your name => https://wiki.koha-community.org/wiki/Version_Control_Using_Git#Set_your_name_.26_mail_address -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed May 3 11:06:44 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 03 May 2017 09:06:44 +0000 Subject: [Koha-bugs] [Bug 18152] UNIMARC bib records imported with invalid 'a' char in label pos.9 In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18152 stephane.delaune at biblibre.com changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #62246|0 |1 is obsolete| | --- Comment #14 from stephane.delaune at biblibre.com --- Created attachment 63008 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=63008&action=edit Bug 18152 : fix unimarc label in SetMarcUnicodeFlag only fix author's name of the patch -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed May 3 11:06:47 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 03 May 2017 09:06:47 +0000 Subject: [Koha-bugs] [Bug 18153] UNIMARC bib records exported with invalid 'a' char in label pos.9 In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18153 stephane.delaune at biblibre.com changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #62245|0 |1 is obsolete| | --- Comment #6 from stephane.delaune at biblibre.com --- Created attachment 63009 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=63009&action=edit Bug 18153 : fix unimarc label in export tool only fix author's name of the patch -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed May 3 11:35:20 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 03 May 2017 09:35:20 +0000 Subject: [Koha-bugs] [Bug 7317] Add an Interlibrary Loan Module to Circulation and OPAC In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7317 Magnus Enger changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Failed QA --- Comment #28 from Magnus Enger --- It also looks like there is a missing "use Koha::Illrequests;" in Koha/Illrequest.pm? When I try to use Koha::Illrequest in the Dancer-based NCIPServer I get this error: [24015] error @1.447857> [hit #5]request to POST / crashed: Can't locate object method "search" via package "Koha::Illrequests" (perhaps you forgot to load "Koha::Illrequests"?) at /path/to/kohaclone/Koha/Illrequest.pm line 684. in /usr/share/perl5/Dancer/Handler.pm l. 98 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed May 3 11:42:15 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 03 May 2017 09:42:15 +0000 Subject: [Koha-bugs] [Bug 18465] Patron card creator: Print on duplex card printer In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18465 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |katrin.fischer at bsz-bw.de --- Comment #5 from Katrin Fischer --- Hi Marc, we have some probems gettig the setup right, could you share screenshots/information about your configuration (template/layout) maybe? -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed May 3 13:15:15 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 03 May 2017 11:15:15 +0000 Subject: [Koha-bugs] [Bug 18233] t/db_dependent/00-strict.t has non-existant resetversion.pl In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18233 Marcel de Rooy changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed May 3 13:15:18 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 03 May 2017 11:15:18 +0000 Subject: [Koha-bugs] [Bug 18233] t/db_dependent/00-strict.t has non-existant resetversion.pl In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18233 Marcel de Rooy changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #63000|0 |1 is obsolete| | --- Comment #3 from Marcel de Rooy --- Created attachment 63010 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=63010&action=edit Bug 18233 - t/db_dependent/00-strict.t has non-existant resetversion.pl Removes a warning. Signed-off-by: Katrin Fischer Signed-off-by: Marcel de Rooy -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed May 3 13:17:10 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 03 May 2017 11:17:10 +0000 Subject: [Koha-bugs] [Bug 18233] t/db_dependent/00-strict.t has non-existant resetversion.pl In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18233 Marcel de Rooy changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |m.de.rooy at rijksmuseum.nl Assignee|chris at bigballofwax.co.nz |olli-antti.kivilahti at jns.fi QA Contact|gmcharlt at gmail.com |m.de.rooy at rijksmuseum.nl -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed May 3 13:18:47 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 03 May 2017 11:18:47 +0000 Subject: [Koha-bugs] [Bug 17600] Standardize the EXPORT In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17600 --- Comment #46 from Marcel de Rooy --- (In reply to Jonathan Druart from comment #45) > Note that I do not support an inclusion of this patch in 17.05 (too many > side-effects possible), but should be pushed at the beginning of the next > cycle. OK. Postponing QA in that case. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed May 3 13:55:38 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 03 May 2017 11:55:38 +0000 Subject: [Koha-bugs] [Bug 16330] REST API: add routes to add, update and delete patrons In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16330 Magnus Enger changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |magnus at libriotech.no --- Comment #42 from Magnus Enger --- What needs to happen for this bug to get moving? -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed May 3 14:44:29 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 03 May 2017 12:44:29 +0000 Subject: [Koha-bugs] [Bug 18291] Remove SQL from preferences.pl administrative script In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18291 --- Comment #15 from Marcel de Rooy --- If cache value is incorrect, we may certainly have serious problems on other places too. If we do not replace with a context call here, we could still do a Koha::Config::Syspref call? Assuming that the intention of this report is to remove SQL statements from scripts. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed May 3 14:58:45 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 03 May 2017 12:58:45 +0000 Subject: [Koha-bugs] [Bug 18465] Patron card creator: Print on duplex card printer In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18465 --- Comment #6 from Marc V?ron --- Created attachment 63011 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=63011&action=edit Screenshots with test settings for duplex card printing... -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed May 3 14:59:22 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 03 May 2017 12:59:22 +0000 Subject: [Koha-bugs] [Bug 18465] Patron card creator: Print on duplex card printer In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18465 --- Comment #7 from Marc V?ron --- Created attachment 63012 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=63012&action=edit Results duplex card printing based on test settings -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed May 3 15:03:33 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 03 May 2017 13:03:33 +0000 Subject: [Koha-bugs] [Bug 18465] Patron card creator: Print on duplex card printer In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18465 --- Comment #8 from Katrin Fischer --- Hi Marc, thx, that's very helpful! Is it ok that both layouts say Page side = Front? -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed May 3 15:06:43 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 03 May 2017 13:06:43 +0000 Subject: [Koha-bugs] [Bug 17944] Remove the sql code from itemtypes.pl administrative perl script In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17944 --- Comment #40 from Alex Buckley --- (In reply to Jonathan Druart in comment 39) Hi Jonathan I have squashed all the bugs together locally and I have implemented a delete method in ItemType.pm to override Koha::Object->delete. I have implemented a try catch so if the delete doesn't work then catch is run and Koha::Exceptions::CannotDeleteDefault->throw is run (as shown below) >116 sub delete{ >117 my ( $self ) = @_; >118 try { >119 my $deleted = $self->SUPER::delete($self); >120 logaction( 'ITEMTYPE', 'DELETE', $self->reserve_id, Dumper( >$self->unblessed) ) >121 if C4::Context->preference('ItemTypeLog'); >122 return $deleted; >123 } catch { >124 Koha::Exceptions::CannotDeleteDefault->throw('itemtype >could not be deleted'); >125 } >126 } However I am a bit confused where you would like the Koha::ItemType->delete call to be in itemtypes.pl. Correct me if I am wrong but I think it cant go in elsif ( $op eq 'delete_confirm') block because putting a caller to delete into this block means if the delete runs successfully the user has no choice to confirm (or not) the deletion. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed May 3 15:07:20 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 03 May 2017 13:07:20 +0000 Subject: [Koha-bugs] [Bug 12063] Change date calculation for reserve expiration to skip all holidays In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12063 --- Comment #68 from Marcel de Rooy --- Still working on this one now. Preliminary results: sub CancelExpiredReserves { + return unless C4::Context->preference("ExpireReservesMaxPickUpDelay"); This may have a unwanted side-effect. If we do not use the pickup delay, but still want to cancel expired reserves. It is no longer possible. (Note that patrons may have entered expiration dates too.) Not marking this as a blocker, since this is probably exceptional. Do you have an easy fix or can you open a new report for it? sub set_waiting { [...] + if ( C4::Context->preference("ExcludeHolidaysFromMaxPickUpDelay") ) { + $expirationdate = $calendar->days_forward( dt_from_string($self->waitingdate), $max_pickup_delay ); + } This may cause something weird. If you do a second checkin while the waitingdate is say yesterday, the waitingdate is set to today but the expiration date will be based upon the old waitingdate. Again probably exceptional, but still something to fix. I would opt here for basing the expiry on today, since we reset the waitingdate too. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed May 3 15:18:04 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 03 May 2017 13:18:04 +0000 Subject: [Koha-bugs] [Bug 17942] Update style of the web installer with Bootstrap 3 In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17942 Owen Leonard changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |Signed Off -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed May 3 15:18:08 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 03 May 2017 13:18:08 +0000 Subject: [Koha-bugs] [Bug 17942] Update style of the web installer with Bootstrap 3 In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17942 --- Comment #44 from Owen Leonard --- Created attachment 63013 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=63013&action=edit Bug 17942 [Follow-up] Update style of the web installer with Bootstrap 3 This patch makes changes following QA comments: - Login error messages now have a style - Select all/Select none links should now be translatable - Date format hint now correctly detects date format preference - Unused JS is removed from onboarding.js This patch also modifies the 'category_code_check' validation method to allow numbers as well as letters. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed May 3 15:21:34 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 03 May 2017 13:21:34 +0000 Subject: [Koha-bugs] [Bug 17942] Update style of the web installer with Bootstrap 3 In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17942 --- Comment #45 from Owen Leonard --- (In reply to Jonathan Druart from comment #43) > 2/ We talked about the default style of btn-primary, should not we apply it > a custom style? I think this is a good idea but at this point I think it should be addressed in a follow-up. > 3/ "Select no mandatory data", "Select all mandatory data" and others will > not be translatable. I hope it is acceptable now. > Note that we should only use "mandatory" and "optional" should be allowed to > simplify the structure of our installer files. I don't understand this comment. > 5/ Not blocker - "Enrolment period: " block is not really nice ;) I agree, but I think this will have to wait for a follow-up. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed May 3 15:25:06 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 03 May 2017 13:25:06 +0000 Subject: [Koha-bugs] [Bug 12063] Change date calculation for reserve expiration to skip all holidays In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12063 --- Comment #69 from Alex Arnaud --- (In reply to Marcel de Rooy from comment #68) > Still working on this one now. > Preliminary results: > > sub CancelExpiredReserves { > + return unless C4::Context->preference("ExpireReservesMaxPickUpDelay"); > This may have a unwanted side-effect. If we do not use the pickup delay, but > still want to cancel expired reserves. You mean: If ExpireReservesMaxPickUpDelay is set to don't allow ? If yes, this is because we don't want to cancel expired reserves right ? Or i don't understand the syspref. > > sub set_waiting { > [...] > + if ( C4::Context->preference("ExcludeHolidaysFromMaxPickUpDelay") ) { > + $expirationdate = $calendar->days_forward( > dt_from_string($self->waitingdate), $max_pickup_delay ); > + } > This may cause something weird. If you do a second Is it possible that the code of set_waiting (after tranferToDo) should be called 2 times for the same reserve ? -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed May 3 15:28:28 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 03 May 2017 13:28:28 +0000 Subject: [Koha-bugs] [Bug 12063] Change date calculation for reserve expiration to skip all holidays In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12063 --- Comment #70 from Alex Arnaud --- (In reply to Alex Arnaud from comment #69) > (In reply to Marcel de Rooy from comment #68) > > sub set_waiting { > > [...] > > + if ( C4::Context->preference("ExcludeHolidaysFromMaxPickUpDelay") ) { > > + $expirationdate = $calendar->days_forward( > > dt_from_string($self->waitingdate), $max_pickup_delay ); > > + } > > This may cause something weird. If you do a second > > Is it possible that the code of set_waiting (after tranferToDo) should be > called 2 times for the same reserve ? Anyway it doesn't hurt to pass today to days_forward. So i'll fix it -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed May 3 15:34:56 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 03 May 2017 13:34:56 +0000 Subject: [Koha-bugs] [Bug 18125] Edit button can duplicate some circulation rule In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18125 Andreas Hedstr?m Mace changed: What |Removed |Added ---------------------------------------------------------------------------- Status|In Discussion |Needs Signoff --- Comment #11 from Andreas Hedstr?m Mace --- I'm changing the status to Needs signoff, since my previous issue was browser-related. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed May 3 15:40:52 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 03 May 2017 13:40:52 +0000 Subject: [Koha-bugs] [Bug 18465] Patron card creator: Print on duplex card printer In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18465 --- Comment #9 from Marc V?ron --- (In reply to Katrin Fischer from comment #8) > Hi Marc, thx, that's very helpful! Is it ok that both layouts say Page side > = Front? Yes. This is only used for templates with multiple columns. For duplex card print we use only 1 row and 1 column, so it is not needed here. -------- Explanation for page side used with multiple columns: Workflow is to print first the front side, then turn the pages and then pront the back sides. Lets say you have a template with 3 columns and a batch with 3 patrons. The layout for the front prints the names: Name 1 | Name 2 | Name 3 And another layout for the back side prints the first names. Output should be: First name 3 | First name 2 | First name 1 ...to print 'First name 1' on the back of 'Name 1' Page side: 'Back' shuffles data to do that. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed May 3 15:42:02 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 03 May 2017 13:42:02 +0000 Subject: [Koha-bugs] [Bug 9156] itemcallnumber not pulling more than 2 subfields In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9156 Marjorie Barry-Vila changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |marjorie.barry-vila at ccsr.qc | |.ca -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed May 3 15:45:48 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 03 May 2017 13:45:48 +0000 Subject: [Koha-bugs] [Bug 12063] Change date calculation for reserve expiration to skip all holidays In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12063 --- Comment #71 from Marcel de Rooy --- (In reply to Alex Arnaud from comment #69) > (In reply to Marcel de Rooy from comment #68) > > sub CancelExpiredReserves { > > + return unless C4::Context->preference("ExpireReservesMaxPickUpDelay"); > > This may have a unwanted side-effect. If we do not use the pickup delay, but > > still want to cancel expired reserves. > > You mean: If ExpireReservesMaxPickUpDelay is set to don't allow ? If yes, > this is because we don't want to cancel expired reserves right ? Or i don't > understand the syspref. The situation I described is independent of this pref. You could use the cron job to remove expired reserves based on expiration dates entered by patrons. > > sub set_waiting { > > [...] > > + if ( C4::Context->preference("ExcludeHolidaysFromMaxPickUpDelay") ) { > > + $expirationdate = $calendar->days_forward( > > dt_from_string($self->waitingdate), $max_pickup_delay ); > > + } > > This may cause something weird. If you do a second > > Is it possible that the code of set_waiting (after tranferToDo) should be > called 2 times for the same reserve ? As mentioned, this is exceptional. But it can be easily simulated. Check this book in today and perhaps by accident tomorrow (it was still on the desk or something like that). Two separate checkins, two calls. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed May 3 16:07:10 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 03 May 2017 14:07:10 +0000 Subject: [Koha-bugs] [Bug 18526] Test t/Token.t fails on master In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18526 Marcel de Rooy changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |m.de.rooy at rijksmuseum.nl --- Comment #1 from Marcel de Rooy --- Title of this report is misleading. The test does not fail on master (at least not with me). -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed May 3 16:14:06 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 03 May 2017 14:14:06 +0000 Subject: [Koha-bugs] [Bug 18528] New: Patron card creator: switch form fields for card height and card width Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18528 Bug ID: 18528 Summary: Patron card creator: switch form fields for card height and card width Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Label/patron card printing Assignee: cnighswonger at foundations.edu Reporter: veron at veron.ch QA Contact: testopia at bugs.koha-community.org The form to create or edit a card template has a confusing sequence of fields for page and card height and width: Page width - Page height - Card height - Card width Switch Card height and Card width to make it more intuitive. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed May 3 16:14:46 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 03 May 2017 14:14:46 +0000 Subject: [Koha-bugs] [Bug 18528] Patron card creator template: switch form fields for card height and card width In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18528 Marc V?ron changed: What |Removed |Added ---------------------------------------------------------------------------- Summary|Patron card creator: switch |Patron card creator |form fields for card height |template: switch form |and card width |fields for card height and | |card width -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed May 3 16:21:22 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 03 May 2017 14:21:22 +0000 Subject: [Koha-bugs] [Bug 16899] Add ability to disallow overpayments via SIP In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16899 Marcel de Rooy changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Failed QA --- Comment #8 from Marcel de Rooy --- Global symbol "$patron" requires explicit package name at /usr/share/koha/masterclone/C4/SIP/ILS/Transaction/FeePayment.pm line 60. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed May 3 16:22:00 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 03 May 2017 14:22:00 +0000 Subject: [Koha-bugs] [Bug 18528] Patron card creator template: switch form fields for card height and card width In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18528 --- Comment #1 from Marc V?ron --- Created attachment 63014 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=63014&action=edit Confusing fields for height and width -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed May 3 16:24:39 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 03 May 2017 14:24:39 +0000 Subject: [Koha-bugs] [Bug 18094] Patron search filters are broken by searchable attributes In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18094 --- Comment #11 from Jonathan Druart --- Created attachment 63015 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=63015&action=edit [16.05.x] Bug 18094: Add tests to highlight the problem Signed-off-by: Marc V?ron Signed-off-by: Nick Clemens -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed May 3 16:24:43 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 03 May 2017 14:24:43 +0000 Subject: [Koha-bugs] [Bug 18098] Add an index with the count of not onloan items In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18098 Marcel de Rooy changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |m.de.rooy at rijksmuseum.nl --- Comment #5 from Marcel de Rooy --- QA: Looking here now -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed May 3 16:25:01 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 03 May 2017 14:25:01 +0000 Subject: [Koha-bugs] [Bug 18094] Patron search filters are broken by searchable attributes In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18094 --- Comment #12 from Jonathan Druart --- Created attachment 63016 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=63016&action=edit [16.05.x] Bug 18094: Only search in searchable patron attributes if searching in standard fields Test plan: - Add a new patron attrbute and mark it searchable - Populate a new patron with 'potato' in that field - Add/edit another patron to have email potato at invalidemail.com' - Perform a patron search with query 'potato' (in standard fields) => Both patrons are returned - Perform a patron search with filters 'Email' and query 'potato' => Only 1 patron is returned and you are redirected to the patron detail page. Followed test plan, works as expected. Signed-off-by: Marc V?ron Signed-off-by: Nick Clemens -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed May 3 16:25:02 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 03 May 2017 14:25:02 +0000 Subject: [Koha-bugs] [Bug 18098] Add an index with the count of not onloan items In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18098 Marcel de Rooy changed: What |Removed |Added ---------------------------------------------------------------------------- QA Contact|testopia at bugs.koha-communit |m.de.rooy at rijksmuseum.nl |y.org | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed May 3 16:30:43 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 03 May 2017 14:30:43 +0000 Subject: [Koha-bugs] [Bug 18465] Patron card creator: Print on duplex card printer In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18465 Marc V?ron changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |https://bugs.koha-community | |.org/bugzilla3/show_bug.cgi | |?id=18528 --- Comment #10 from Marc V?ron --- (In reply to Marc V?ron from comment #4) > Created attachment 62498 [details] [review] > Bug 18465 - Patron card creator: Print on duplex card printer > (Attention, Card with and Card height seem to have wrong labels, that will > go to a separate bug). Not wrong labels but confusing sequence. See Bug 18528 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed May 3 16:30:43 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 03 May 2017 14:30:43 +0000 Subject: [Koha-bugs] [Bug 18528] Patron card creator template: switch form fields for card height and card width In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18528 Marc V?ron changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |https://bugs.koha-community | |.org/bugzilla3/show_bug.cgi | |?id=18465 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed May 3 16:31:06 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 03 May 2017 14:31:06 +0000 Subject: [Koha-bugs] [Bug 18528] Patron card creator template: switch form fields for card height and card width In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18528 --- Comment #2 from Marc V?ron --- Created attachment 63017 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=63017&action=edit Bug 18528: Patron card creator template: switch form fields for card height and card width This patch changes the sequnce of form fields for card height and card width. To test: - Apply patch - Edit or create a patron card template - Verify that the fields display in sequence Page height - Page width -Card height - Card width -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed May 3 16:31:04 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 03 May 2017 14:31:04 +0000 Subject: [Koha-bugs] [Bug 18529] New: Template cleanup of patron clubs pages Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18529 Bug ID: 18529 Summary: Template cleanup of patron clubs pages Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: normal Priority: P5 - low Component: Templates Assignee: oleonard at myacpl.org Reporter: oleonard at myacpl.org QA Contact: testopia at bugs.koha-community.org The patron clubs pages need some cleanup: markup errors, inconsistent styling, etc. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed May 3 16:32:09 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 03 May 2017 14:32:09 +0000 Subject: [Koha-bugs] [Bug 18528] Patron card creator template: switch form fields for card height and card width In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18528 Marc V?ron changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff Patch complexity|--- |Trivial patch Assignee|cnighswonger at foundations.ed |veron at veron.ch |u | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed May 3 16:32:51 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 03 May 2017 14:32:51 +0000 Subject: [Koha-bugs] [Bug 18291] Remove SQL from preferences.pl administrative script In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18291 --- Comment #16 from Jonathan Druart --- (In reply to Marcel de Rooy from comment #15) > If cache value is incorrect, we may certainly have serious problems on other > places too. > > If we do not replace with a context call here, we could still do a > Koha::Config::Syspref call? Assuming that the intention of this report is to > remove SQL statements from scripts. Yes and no. It would make sense to call Sysprefs->find everywhere and cache values in the Koha::Config::Sysprefs module. Which is a lot of work for not much added value. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed May 3 16:34:39 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 03 May 2017 14:34:39 +0000 Subject: [Koha-bugs] [Bug 12063] Change date calculation for reserve expiration to skip all holidays In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12063 --- Comment #72 from Alex Arnaud --- (In reply to Marcel de Rooy from comment #71) > The situation I described is independent of this pref. You could use the > cron job to remove expired reserves based on expiration dates entered by > patrons. > Difficult to decide the issue. The behavior of sub CancelExpiredReserves was before: - Cancel holds with an expiration date (asked by the patron afaik), - Cancel other exipred holds only if ExpireReservesMaxPickUpDelay is set to allow So now we have all waiting reerves with an expiration date, we can't make the difference between those with expiration ask by the patron and those with expiration calculated. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed May 3 16:37:57 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 03 May 2017 14:37:57 +0000 Subject: [Koha-bugs] [Bug 18094] Patron search filters are broken by searchable attributes In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18094 --- Comment #13 from Mason James --- this patchset currently fails for me on 16.05.x $ prove t/db_dependent/Utils/Datatables_Members.t t/db_dependent/Utils/Datatables_Members.t .. 1/30 # Failed test ''Dupont' is contained in 2 surnames and a patron attribute. Patron attribute one should not be displayed if searching in specific fields (Bug 18094)' # at t/db_dependent/Utils/Datatables_Members.t line 407. # got: '2' # expected: '1' # Looks like you failed 1 test of 2. # Failed test 'ExtendedPatronAttributes' # at t/db_dependent/Utils/Datatables_Members.t line 409. # Looks like you failed 1 test of 30. t/db_dependent/Utils/Datatables_Members.t .. Dubious, test returned 1 (wstat 256, 0x100) Failed 1/30 subtests Test Summary Report ------------------- t/db_dependent/Utils/Datatables_Members.t (Wstat: 256 Tests: 30 Failed: 1) Failed test: 30 Non-zero exit status: 1 Files=1, Tests=30, 2 wallclock secs ( 0.03 usr 0.01 sys + 1.74 cusr 0.22 csys = 2.00 CPU) Result: FAIL -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed May 3 16:38:05 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 03 May 2017 14:38:05 +0000 Subject: [Koha-bugs] [Bug 12063] Change date calculation for reserve expiration to skip all holidays In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12063 --- Comment #73 from Alex Arnaud --- And note that CancelExpiredReserves is only caled by the script misc/cronjobs/holds/cancel_expired_holds.pl. Nowhere else if i'm not wrong. So if we remove the check of ExpireReservesMaxPickUpDelay from this sub, we get a kind of "force cancel reserves". -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed May 3 16:45:13 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 03 May 2017 14:45:13 +0000 Subject: [Koha-bugs] [Bug 18094] Patron search filters are broken by searchable attributes In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18094 --- Comment #14 from Jonathan Druart --- You need the 2 patches, not just the tests. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed May 3 16:54:18 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 03 May 2017 14:54:18 +0000 Subject: [Koha-bugs] [Bug 18529] Template cleanup of patron clubs pages In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18529 Owen Leonard changed: What |Removed |Added ---------------------------------------------------------------------------- Patch complexity|--- |Small patch Status|NEW |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed May 3 16:54:21 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 03 May 2017 14:54:21 +0000 Subject: [Koha-bugs] [Bug 18529] Template cleanup of patron clubs pages In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18529 --- Comment #1 from Owen Leonard --- Created attachment 63018 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=63018&action=edit Bug 18529 - Template cleanup of patron clubs pages This patch addresses template issues with the newly-added patron clubs pages. - Move Clubs tab out of second position in Circulation page tabs. - Link patron name in enrollments list to the patron record - Make page titles on some pages more specific - Correct label "for" attributes so that it matches input id - Correst style of buttons: Buttons in tables must be "btn-xs," all Bootstrap buttons must have "btn-default." - Correct "Edit" icons: Should be "fa-pencil" This patch also revises the club template editing form to make it more consistent with similar interfaces in Koha and (hopefully) make it more clear. To test, apply the patch and test adding clubs and club templates and enrolling patrons in clubs via the staff client and OPAC. Confirm that everything looks and work okay. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed May 3 16:55:23 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 03 May 2017 14:55:23 +0000 Subject: [Koha-bugs] [Bug 18529] Template cleanup of patron clubs pages In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18529 Owen Leonard changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on| |12461 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12461 [Bug 12461] Add patron clubs feature -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed May 3 16:55:23 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 03 May 2017 14:55:23 +0000 Subject: [Koha-bugs] [Bug 12461] Add patron clubs feature In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12461 Owen Leonard changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |18529 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18529 [Bug 18529] Template cleanup of patron clubs pages -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed May 3 16:57:54 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 03 May 2017 14:57:54 +0000 Subject: [Koha-bugs] [Bug 18098] Add an index with the count of not onloan items In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18098 --- Comment #6 from Marcel de Rooy --- Seems to work fine (MARC21), but we still need biblio-zebra-indexdefs.xsl for unimarc and normarc. Note that 'working fine' in my case included restarting zebra and indexer. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed May 3 16:58:01 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 03 May 2017 14:58:01 +0000 Subject: [Koha-bugs] [Bug 18530] New: Remove event attributes from patron clubs templates Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18530 Bug ID: 18530 Summary: Remove event attributes from patron clubs templates Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: normal Priority: P5 - low Component: Templates Assignee: oleonard at myacpl.org Reporter: oleonard at myacpl.org QA Contact: testopia at bugs.koha-community.org The patron clubs templates add a lot of instances of "onclick," in violation of coding guidelines. https://wiki.koha-community.org/wiki/Coding_Guidelines#JS9:_Avoid_the_use_of_event_attributes_like_.22onclick.22_to_attach_events They should be removed in favor of defining events in JavaScript instead of markup. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed May 3 16:58:02 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 03 May 2017 14:58:02 +0000 Subject: [Koha-bugs] [Bug 18098] Add an index with the count of not onloan items In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18098 Marcel de Rooy changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Failed QA -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed May 3 17:00:45 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 03 May 2017 15:00:45 +0000 Subject: [Koha-bugs] [Bug 17942] Update style of the web installer with Bootstrap 3 In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17942 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed May 3 17:00:54 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 03 May 2017 15:00:54 +0000 Subject: [Koha-bugs] [Bug 17942] Update style of the web installer with Bootstrap 3 In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17942 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #62861|0 |1 is obsolete| | Attachment #62862|0 |1 is obsolete| | Attachment #63013|0 |1 is obsolete| | --- Comment #46 from Jonathan Druart --- Created attachment 63019 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=63019&action=edit Bug 17942 - Update style of the web installer with Bootstrap 3 This patch makes style and markup changes to the web installer and new onboarding tool (Bug 17855). - Markup has been corrected, improved, and in many places reindented. - Some page titles have been made more specific. - Some JavaScript and CSS have been moved to separate files. In the onboarding tool I have removed form validation from the markup and JavaScript in many cases where the requirements were not matched elsewhere in Koha. For instance, we shouldn't limit item type descriptions to only letters because the database doesn't require such a limit. To test, apply the patch and run the web installer with an empty database. Confirm that the installation process completes correctly and that each page looks good and works correctly. Works as advertised Signed-off-by: Marc V?ron Signed-off-by: Jonathan Druart -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed May 3 17:01:02 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 03 May 2017 15:01:02 +0000 Subject: [Koha-bugs] [Bug 17942] Update style of the web installer with Bootstrap 3 In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17942 --- Comment #47 from Jonathan Druart --- Created attachment 63020 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=63020&action=edit Bug 17942 - Add anti-clickjack code to installer doc head close Signed-off-by: Marc V?ron Signed-off-by: Jonathan Druart -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed May 3 17:01:09 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 03 May 2017 15:01:09 +0000 Subject: [Koha-bugs] [Bug 17942] Update style of the web installer with Bootstrap 3 In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17942 --- Comment #48 from Jonathan Druart --- Created attachment 63021 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=63021&action=edit Bug 17942: Remove type for messages It it no longer in used by the templates. Also add the include files for step5 (if the circ rule is not inserted) Signed-off-by: Jonathan Druart -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed May 3 17:01:14 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 03 May 2017 15:01:14 +0000 Subject: [Koha-bugs] [Bug 17942] Update style of the web installer with Bootstrap 3 In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17942 --- Comment #49 from Jonathan Druart --- Created attachment 63022 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=63022&action=edit Bug 17942 [Follow-up] Update style of the web installer with Bootstrap 3 This patch makes changes following QA comments: - Login error messages now have a style - Select all/Select none links should now be translatable - Date format hint now correctly detects date format preference - Unused JS is removed from onboarding.js This patch also modifies the 'category_code_check' validation method to allow numbers as well as letters. Signed-off-by: Jonathan Druart -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed May 3 17:14:17 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 03 May 2017 15:14:17 +0000 Subject: [Koha-bugs] [Bug 10086] No way to go back to the basket on uncertain prices page In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10086 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |ASSIGNED --- Comment #5 from Jonathan Druart --- Please answer. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed May 3 17:15:29 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 03 May 2017 15:15:29 +0000 Subject: [Koha-bugs] [Bug 18008] Use templates for generating pagination in intranet In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18008 Josef Moravec changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #59769|0 |1 is obsolete| | --- Comment #4 from Josef Moravec --- Created attachment 63023 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=63023&action=edit Bug 18008: Make pagination generated in templates It generates pagination in bootstrap style (as bug 18005 also do) Modified pages: acqui/neworderbiblio.pl authorities/authorities-home.pl cataloguing/addbooks.pl cataloguing/value_builder/marc21_linking_section.pl cataloguing/value_builder/unimarc_field_210c.pl cataloguing/value_builder/unimarc_field_4XX.pl reports/guided_reports.pl reviews/reviewswaiting.pl tags/review.pl virtualshelves/shelves.pl Test plan: 0) Apply the patch 1) go through pages from the list above/use cataloguing plugins, and make the data to be big enough for pagination 2) confirm that pagination looks nice and behave correctly 3) git grep pagination_bar should return just C4/Output.pm and opac templates (I'll deal with it on another bugs) -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed May 3 17:35:56 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 03 May 2017 15:35:56 +0000 Subject: [Koha-bugs] [Bug 18530] Remove event attributes from patron clubs templates In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18530 Owen Leonard changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on| |12461 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12461 [Bug 12461] Add patron clubs feature -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed May 3 17:35:56 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 03 May 2017 15:35:56 +0000 Subject: [Koha-bugs] [Bug 12461] Add patron clubs feature In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12461 Owen Leonard changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |18530 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18530 [Bug 18530] Remove event attributes from patron clubs templates -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed May 3 17:40:06 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 03 May 2017 15:40:06 +0000 Subject: [Koha-bugs] [Bug 18529] Template cleanup of patron clubs pages In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18529 Josef Moravec changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed May 3 17:40:10 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 03 May 2017 15:40:10 +0000 Subject: [Koha-bugs] [Bug 18529] Template cleanup of patron clubs pages In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18529 Josef Moravec changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #63018|0 |1 is obsolete| | --- Comment #2 from Josef Moravec --- Created attachment 63024 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=63024&action=edit [SIGNED-OFF] Bug 18529 - Template cleanup of patron clubs pages This patch addresses template issues with the newly-added patron clubs pages. - Move Clubs tab out of second position in Circulation page tabs. - Link patron name in enrollments list to the patron record - Make page titles on some pages more specific - Correct label "for" attributes so that it matches input id - Correst style of buttons: Buttons in tables must be "btn-xs," all Bootstrap buttons must have "btn-default." - Correct "Edit" icons: Should be "fa-pencil" This patch also revises the club template editing form to make it more consistent with similar interfaces in Koha and (hopefully) make it more clear. To test, apply the patch and test adding clubs and club templates and enrolling patrons in clubs via the staff client and OPAC. Confirm that everything looks and work okay. Signed-off-by: Josef Moravec -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed May 3 17:42:18 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 03 May 2017 15:42:18 +0000 Subject: [Koha-bugs] [Bug 18531] New: REST api: Add an endpoint for use by GOBI Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18531 Bug ID: 18531 Summary: REST api: Add an endpoint for use by GOBI Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: new feature Priority: P5 - low Component: Web services Assignee: koha-bugs at lists.koha-community.org Reporter: tomascohen at gmail.com QA Contact: testopia at bugs.koha-community.org GOBI (formely YBP) is an aquisitions management system. It handles most of the acquisitions workflow, and traditionally generated MARC files to be included on the institution's library systems. Those files were usually served on an FTP server, for the institution to download and import on their ILS. GOBI implemented what they call GOBIapi, which is a simple workflow for them to directly inject that acquisitions information and resulting records through the use of webservices. In Koha, this means having an endpoint accepting GOBI order messages (in their documented XML format) and have it follow the internal Koha workflow for baskets: - Create a basket - Fill it with the record and budget information, etc - Close the basket and mark it as received. - Deal with the received MARC data. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed May 3 17:42:24 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 03 May 2017 15:42:24 +0000 Subject: [Koha-bugs] [Bug 18531] REST api: Add an endpoint for use by GOBI In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18531 Tom?s Cohen Arazi changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|koha-bugs at lists.koha-commun |tomascohen at gmail.com |ity.org | -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Wed May 3 17:42:29 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 03 May 2017 15:42:29 +0000 Subject: [Koha-bugs] [Bug 18531] REST api: Add an endpoint for use by GOBI In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18531 Tom?s Cohen Arazi changed: What |Removed |Added ---------------------------------------------------------------------------- Change sponsored?|--- |Sponsored -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed May 3 17:43:49 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 03 May 2017 15:43:49 +0000 Subject: [Koha-bugs] [Bug 16606] Checkout settings dropdown should have a preference to stay open all the time In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16606 Marjorie Barry-Vila changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |marjorie.barry-vila at ccsr.qc | |.ca -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed May 3 17:57:34 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 03 May 2017 15:57:34 +0000 Subject: [Koha-bugs] [Bug 16606] Checkout settings dropdown should have a preference to stay open all the time In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16606 --- Comment #6 from Marjorie Barry-Vila --- (In reply to Christopher Brannon from comment #0) > Not everyone is concerned with the additional space taken up with the new > Checkout settings. It would be helpful if these options could be set to > always show. > > For now I will use a jQuery to force it open, but a preference would be > preferable. No pun intended. > > Christopher Hi, Could you share your code JQuery? I did not find it on wiki. Regards, Marjorie -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed May 3 18:00:40 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 03 May 2017 16:00:40 +0000 Subject: [Koha-bugs] [Bug 18137] REST API: Migrate from Mojolicious::Plugin:: Swagger2 to Mojolicious::Plugin::OpenAPI In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18137 Josef Moravec changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed May 3 18:00:44 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 03 May 2017 16:00:44 +0000 Subject: [Koha-bugs] [Bug 18137] REST API: Migrate from Mojolicious::Plugin:: Swagger2 to Mojolicious::Plugin::OpenAPI In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18137 Josef Moravec changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #62781|0 |1 is obsolete| | Attachment #62782|0 |1 is obsolete| | Attachment #62783|0 |1 is obsolete| | Attachment #62784|0 |1 is obsolete| | Attachment #62785|0 |1 is obsolete| | Attachment #62786|0 |1 is obsolete| | Attachment #62787|0 |1 is obsolete| | Attachment #62788|0 |1 is obsolete| | Attachment #62789|0 |1 is obsolete| | Attachment #62816|0 |1 is obsolete| | --- Comment #44 from Josef Moravec --- Created attachment 63025 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=63025&action=edit [SIGNED-OFF] Bug 18137: Add useful Koha::Exceptions Signed-off-by: Olli-Antti Kivilahti Signed-off-by: Josef Moravec -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed May 3 18:00:56 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 03 May 2017 16:00:56 +0000 Subject: [Koha-bugs] [Bug 18137] REST API: Migrate from Mojolicious::Plugin:: Swagger2 to Mojolicious::Plugin::OpenAPI In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18137 --- Comment #45 from Josef Moravec --- Created attachment 63026 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=63026&action=edit [SIGNED-OFF] Bug 18137: Migrate from Swagger2 to Mojolicious::Plugin::OpenAPI This patch migrates from Swagger2 to Mojolicious::Plugin::OpenAPI as Swagger2 is no longer actively maintained. This migration involves some minor changes to our Swagger specification documents and to controllers. Each operation is migrated in following patches separately. Please see Mojolicious::Plugin::OpenAPI and its tutorial for more documentation. The patch also refactors some API authentication -related code by taking advantage of Koha::Exceptions. Authentication is now handled via Mojolicious's "under->to" functionality. The actual authentication & authorization checks are moved to Koha::REST::V1::Auth. Added a HTTP 503 response for when database update is required, instead of returning an authentication failure as before. To test: 1. prove t/db_dependent/api/v1/auth.t Signed-off-by: Olli-Antti Kivilahti Signed-off-by: Josef Moravec -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed May 3 18:01:02 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 03 May 2017 16:01:02 +0000 Subject: [Koha-bugs] [Bug 18137] REST API: Migrate from Mojolicious::Plugin:: Swagger2 to Mojolicious::Plugin::OpenAPI In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18137 --- Comment #46 from Josef Moravec --- Created attachment 63027 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=63027&action=edit [SIGNED-OFF] Bug 18137: Make /patrons Mojolicious::Plugin::OpenAPI compatible Also: - adding some missing and new response definitions into Swagger spec. - fixing failing test due to Bug 17932's change of boolean values To test: 1. prove t/db_dependent/api/v1/patrons.t Signed-off-by: Olli-Antti Kivilahti Signed-off-by: Josef Moravec -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed May 3 18:01:09 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 03 May 2017 16:01:09 +0000 Subject: [Koha-bugs] [Bug 18137] REST API: Migrate from Mojolicious::Plugin:: Swagger2 to Mojolicious::Plugin::OpenAPI In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18137 --- Comment #47 from Josef Moravec --- Created attachment 63028 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=63028&action=edit [SIGNED-OFF] Bug 18137: Make /cities Mojolicious::Plugin::OpenAPI compatible Also: - adding some missing and new response definitions into Swagger spec. To test: 1. prove t/db_dependent/api/v1/cities.t Signed-off-by: Olli-Antti Kivilahti Signed-off-by: Josef Moravec -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed May 3 18:01:14 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 03 May 2017 16:01:14 +0000 Subject: [Koha-bugs] [Bug 18137] REST API: Migrate from Mojolicious::Plugin:: Swagger2 to Mojolicious::Plugin::OpenAPI In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18137 --- Comment #48 from Josef Moravec --- Created attachment 63029 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=63029&action=edit [SIGNED-OFF] Bug 18137: Make /holds Mojolicious::Plugin::OpenAPI compatible Also - adding some missing and new response definitions into Swagger spec. - fixing failing tests due to Bug 17932's change of boolean values To test: 1. prove t/db_dependent/api/v1/holds.t Signed-off-by: Olli-Antti Kivilahti Signed-off-by: Josef Moravec -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed May 3 18:01:19 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 03 May 2017 16:01:19 +0000 Subject: [Koha-bugs] [Bug 18137] REST API: Migrate from Mojolicious::Plugin:: Swagger2 to Mojolicious::Plugin::OpenAPI In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18137 --- Comment #49 from Josef Moravec --- Created attachment 63030 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=63030&action=edit [SIGNED-OFF] Bug 18137: Remove x-mojo-around-action Mojolicious::Plugin::OpenAPI does not support x-mojo-around action. This patch removes it from our specification document. Signed-off-by: Olli-Antti Kivilahti Signed-off-by: Josef Moravec -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed May 3 18:01:25 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 03 May 2017 16:01:25 +0000 Subject: [Koha-bugs] [Bug 18137] REST API: Migrate from Mojolicious::Plugin:: Swagger2 to Mojolicious::Plugin::OpenAPI In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18137 --- Comment #50 from Josef Moravec --- Created attachment 63031 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=63031&action=edit [SIGNED-OFF] Bug 18137: (follow-up) Fix handling DBIx::Class::Exception messages - DBIx::Class::Exception should use ->{msg} Signed-off-by: Josef Moravec -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed May 3 18:01:30 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 03 May 2017 16:01:30 +0000 Subject: [Koha-bugs] [Bug 18137] REST API: Migrate from Mojolicious::Plugin:: Swagger2 to Mojolicious::Plugin::OpenAPI In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18137 --- Comment #51 from Josef Moravec --- Created attachment 63032 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=63032&action=edit [SIGNED-OFF] Bug 18137: (QA-follow-up) Fix pod fail Signed-off-by: Josef Moravec -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed May 3 18:01:36 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 03 May 2017 16:01:36 +0000 Subject: [Koha-bugs] [Bug 18137] REST API: Migrate from Mojolicious::Plugin:: Swagger2 to Mojolicious::Plugin::OpenAPI In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18137 --- Comment #52 from Josef Moravec --- Created attachment 63033 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=63033&action=edit [SIGNED-OFF] Bug 18137: (follow-up) Sort definitions.json Before this file grows, we should sort it alphabetically. To test: 1. prove t/db_dependent/api/v1 Signed-off-by: Josef Moravec -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed May 3 18:01:41 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 03 May 2017 16:01:41 +0000 Subject: [Koha-bugs] [Bug 18137] REST API: Migrate from Mojolicious::Plugin:: Swagger2 to Mojolicious::Plugin::OpenAPI In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18137 --- Comment #53 from Josef Moravec --- Created attachment 63034 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=63034&action=edit [SIGNED-OFF] Bug 18137: List Mojolicious::Plugin::OpenAPI and JSON::Validator as dependencies Signed-off-by: Olli-Antti Kivilahti Signed-off-by: Josef Moravec -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed May 3 18:10:05 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 03 May 2017 16:10:05 +0000 Subject: [Koha-bugs] [Bug 18152] UNIMARC bib records imported with invalid 'a' char in label pos.9 In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18152 --- Comment #15 from Jonathan Druart --- (In reply to stephane.delaune from comment #12) "MARC::Record does not handle UNIMARC records correctly" and "MARC::Record->encoding('utf-8') add 'a' char in the 9th label'pos, it's ok in MARC21 and NORMARC but not in UNIMARC" mean the same thing to me -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed May 3 18:10:55 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 03 May 2017 16:10:55 +0000 Subject: [Koha-bugs] [Bug 18415] Advanced Editor - Rancor - return focus to editor after successful macro In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18415 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed May 3 18:11:04 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 03 May 2017 16:11:04 +0000 Subject: [Koha-bugs] [Bug 18415] Advanced Editor - Rancor - return focus to editor after successful macro In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18415 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #62291|0 |1 is obsolete| | --- Comment #3 from Jonathan Druart --- Created attachment 63035 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=63035&action=edit Bug 18415 - Advanced Editor - Rancor - return focus to editor after successful macro After running a macro we should return focus to the editor screen so editing can continue from keyboard To test: 1 - Create a macro 007=vd cvaizq 2 - Run it and note focus is not on editor 3 - Apply patch 4 - Reload page 5 - Run macro 6 - Note focus is returned to editor Signed-off-by: Owen Leonard Signed-off-by: Jonathan Druart -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed May 3 18:12:11 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 03 May 2017 16:12:11 +0000 Subject: [Koha-bugs] [Bug 15326] Add CMS feature In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15326 Josef Moravec changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |josef.moravec at gmail.com Status|Needs Signoff |Patch doesn't apply -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed May 3 18:17:36 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 03 May 2017 16:17:36 +0000 Subject: [Koha-bugs] [Bug 18180] Sort Field 2 Blank on Patron Details Page In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18180 Jesse Maseto changed: What |Removed |Added ---------------------------------------------------------------------------- Resolution|--- |DUPLICATE Status|NEW |RESOLVED CC| |jesse at bywatersolutions.com --- Comment #1 from Jesse Maseto --- *** This bug has been marked as a duplicate of bug 18512 *** -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed May 3 18:17:36 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 03 May 2017 16:17:36 +0000 Subject: [Koha-bugs] [Bug 18512] GetAuthorisedValues.GetByCode Template plugin should return code ( not empty string) if value not found In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18512 Jesse Maseto changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |athieschafer at smac.edu --- Comment #8 from Jesse Maseto --- *** Bug 18180 has been marked as a duplicate of this bug. *** -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed May 3 18:31:27 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 03 May 2017 16:31:27 +0000 Subject: [Koha-bugs] [Bug 15705] Notify the user on auto renewing In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15705 --- Comment #62 from Jonathan Druart --- Created attachment 63037 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=63037&action=edit Bug 15705: Add --send-notices to the cronjob script -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed May 3 18:31:09 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 03 May 2017 16:31:09 +0000 Subject: [Koha-bugs] [Bug 15705] Notify the user on auto renewing In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15705 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #61498|0 |1 is obsolete| | Attachment #61500|0 |1 is obsolete| | --- Comment #61 from Jonathan Druart --- Created attachment 63036 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=63036&action=edit Bug 15705: DBIC Schema changes -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed May 3 18:35:10 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 03 May 2017 16:35:10 +0000 Subject: [Koha-bugs] [Bug 18532] New: AUTO_RENEWALS should be a patron messaging preferences Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18532 Bug ID: 18532 Summary: AUTO_RENEWALS should be a patron messaging preferences Change sponsored?: --- Product: Koha Version: unspecified Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Circulation Assignee: koha-bugs at lists.koha-community.org Reporter: jonathan.druart at bugs.koha-community.org QA Contact: testopia at bugs.koha-community.org CC: gmcharlt at gmail.com, kyle.m.hall at gmail.com Depends on: 15705 The AUTO_RENEWALS notices sent by the automatic_renewals.pl cronjob should be controlled and configurable at user level, like CHECKIN and CHECKOUT That way digest will be supported as well. Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15705 [Bug 15705] Notify the user on auto renewing -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Wed May 3 18:35:10 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 03 May 2017 16:35:10 +0000 Subject: [Koha-bugs] [Bug 15705] Notify the user on auto renewing In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15705 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |18532 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18532 [Bug 18532] AUTO_RENEWALS should be a patron messaging preferences -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed May 3 18:37:25 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 03 May 2017 16:37:25 +0000 Subject: [Koha-bugs] [Bug 15705] Notify the user on auto renewing In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15705 --- Comment #63 from Jonathan Druart --- Nick, I added a --send-notices flag to the script. I opened bug 18532, which may be sponsored soon, to tuned this option more granularly. Hope it makes sense to you to have this enhancement in as it. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed May 3 19:13:38 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 03 May 2017 17:13:38 +0000 Subject: [Koha-bugs] [Bug 17812] Return focus to barcode field after toggling on-site checkouts In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17812 Owen Leonard changed: What |Removed |Added ---------------------------------------------------------------------------- Status|In Discussion |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed May 3 19:13:41 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 03 May 2017 17:13:41 +0000 Subject: [Koha-bugs] [Bug 17812] Return focus to barcode field after toggling on-site checkouts In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17812 Owen Leonard changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #58651|0 |1 is obsolete| | --- Comment #4 from Owen Leonard --- Created attachment 63038 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=63038&action=edit Bug 17812 - Return focus to barcode field after toggling on-site checkouts This patch changes the behavior of the checkout form so that after checking boxes in the "checkout settings" panel the cursor focus is automatically moved to the barcode field. To test, apply the patch and enable OnSiteCheckouts and decreaseLoanHighHolds system preferences. - Open any patron account in circulation. - Expand the "Checkout settings" panel. - Click the label or checkbox for "Automatic renewal", "Don't decrease checkout length based on holds" and "On-site checkout" - Confirm that the focus has moved to the barcode field. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed May 3 19:29:42 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 03 May 2017 17:29:42 +0000 Subject: [Koha-bugs] [Bug 18518] The staff interface "blink" for different actions after upgrading to Firefox 53 In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18518 Philippe Audet-Fortin changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #62927|0 |1 is obsolete| | --- Comment #8 from Philippe Audet-Fortin --- Created attachment 63039 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=63039&action=edit Bug 18518: Hide patron list dialog by default This patch hides the patron list dialog by default to prevent it to display shortly when koha/members/member.pl is called. There are more reasons for the blinking of the page, but at least the yellow patron list dialog does no longer display without having to. To test: - Slow down system by enabling syspref DumpTemplateVarsIntranet - Try to reproduce issue, see a yellow dialog come up for a very short time when member.pl is displayed (e.g. with a search) - Apply patch - Go to patron page - Try to reproduce. Page still blinks, but the dialog as one of the elements that produce bilnking does no longer show up - Verify that patron list functionality works as before (Select some patrons and add them to a patron list). Signed-off-by: paudet -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed May 3 19:31:05 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 03 May 2017 17:31:05 +0000 Subject: [Koha-bugs] [Bug 15165] REST API routes to list, edit and pay borrower's accountlines In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15165 Tom?s Cohen Arazi changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |tomascohen at gmail.com --- Comment #56 from Tom?s Cohen Arazi --- Accountlines are tied to patrons. That means they might better be placed in /patrons/{patron_id}/accountlines. Is there a place in Koha where all accountlines are listed somehow that would require this kind of global endpoint? I don't see the use case for it. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed May 3 19:53:16 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 03 May 2017 17:53:16 +0000 Subject: [Koha-bugs] [Bug 18532] AUTO_RENEWALS should be a patron messaging preference In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18532 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Summary|AUTO_RENEWALS should be a |AUTO_RENEWALS should be a |patron messaging |patron messaging preference |preferences | -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Wed May 3 19:57:49 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 03 May 2017 17:57:49 +0000 Subject: [Koha-bugs] [Bug 18533] New: MARC::Record->encoding does not handle UNIMARC records Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18533 Bug ID: 18533 Summary: MARC::Record->encoding does not handle UNIMARC records Change sponsored?: --- Product: Koha Version: unspecified Hardware: All OS: All Status: NEW Severity: normal Priority: P5 - low Component: MARC Bibliographic data support Assignee: gmcharlt at gmail.com Reporter: jonathan.druart at bugs.koha-community.org QA Contact: testopia at bugs.koha-community.org Depends on: 18152 Regarding bug 18152 MARC::Record->encoding should not be called directly from our codebase. C4::Charset::SetMarcUnicodeFlag should call MARC::Record->encoding for MARC21 and NORMARC but does the UNIMARC trick for UNIMARC records. It seems that MARC::Record->encoding calls should be replaced with C4::Charset::SetMarcUnicodeFlag everywhere. Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18152 [Bug 18152] UNIMARC bib records imported with invalid 'a' char in label pos.9 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed May 3 19:57:49 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 03 May 2017 17:57:49 +0000 Subject: [Koha-bugs] [Bug 18152] UNIMARC bib records imported with invalid 'a' char in label pos.9 In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18152 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |18533 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18533 [Bug 18533] MARC::Record->encoding does not handle UNIMARC records -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed May 3 20:31:12 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 03 May 2017 18:31:12 +0000 Subject: [Koha-bugs] [Bug 18152] UNIMARC bib records imported with invalid 'a' char in label pos.9 In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18152 --- Comment #16 from Jonathan Druart --- Created attachment 63040 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=63040&action=edit Bug 18152: Add tests -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed May 3 20:31:17 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 03 May 2017 18:31:17 +0000 Subject: [Koha-bugs] [Bug 18152] UNIMARC bib records imported with invalid 'a' char in label pos.9 In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18152 --- Comment #17 from Jonathan Druart --- Created attachment 63041 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=63041&action=edit Bug 18152: Leader 9 for UNIMARC records must be blank -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed May 3 20:31:06 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 03 May 2017 18:31:06 +0000 Subject: [Koha-bugs] [Bug 18152] UNIMARC bib records imported with invalid 'a' char in label pos.9 In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18152 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed May 3 20:32:48 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 03 May 2017 18:32:48 +0000 Subject: [Koha-bugs] [Bug 18152] UNIMARC bib records imported with invalid 'a' char in label pos.9 In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18152 --- Comment #18 from Jonathan Druart --- Paul, St?phane, Regarding the description of this bug we are expecting the Leader 9 for UNIMARC records to be blank, does it make sense to set it in SetMarcUnicodeFlag? Let me know if you agree with the last patch, otherwise I will adapt the tests to make them pass without it. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed May 3 20:33:50 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 03 May 2017 18:33:50 +0000 Subject: [Koha-bugs] [Bug 18153] UNIMARC bib records exported with invalid 'a' char in label pos.9 In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18153 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |jonathan.druart at bugs.koha-c | |ommunity.org --- Comment #7 from Jonathan Druart --- Must it be done when importing as well? -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed May 3 20:35:05 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 03 May 2017 18:35:05 +0000 Subject: [Koha-bugs] [Bug 18152] UNIMARC bib records imported with invalid 'a' char in label pos.9 In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18152 --- Comment #19 from Jonathan Druart --- (In reply to Jonathan Druart from comment #18) > Regarding the description of this bug we are expecting the Leader 9 for > UNIMARC records to be blank, does it make sense to set it in > SetMarcUnicodeFlag? I do not think it makes sense actually, must be done elsewhere. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed May 3 20:39:57 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 03 May 2017 18:39:57 +0000 Subject: [Koha-bugs] [Bug 18299] Removal of admin/env_tz_test.pl script In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18299 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed May 3 20:40:01 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 03 May 2017 18:40:01 +0000 Subject: [Koha-bugs] [Bug 18299] Removal of admin/env_tz_test.pl script In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18299 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #63001|0 |1 is obsolete| | --- Comment #12 from Jonathan Druart --- Created attachment 63042 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=63042&action=edit Bug 18299 - Removed unused env_tz_test.pl based on user testing feedback Signed-off-by: Katrin Fischer Signed-off-by: Jonathan Druart -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed May 3 20:51:13 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 03 May 2017 18:51:13 +0000 Subject: [Koha-bugs] [Bug 16486] Display the TIME a fine was collected/written off In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16486 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Version|3.20 |unspecified CC| |jonathan.druart at bugs.koha-c | |ommunity.org --- Comment #7 from Jonathan Druart --- Would not it make sense to add it everywhere? % git grep ', thanks' **/*.tt|cut -d':' -f1|uniq koha-tmpl/intranet-tmpl/prog/en/modules/members/boraccount.tt koha-tmpl/intranet-tmpl/prog/en/modules/members/pay.tt koha-tmpl/intranet-tmpl/prog/en/modules/members/printfeercpt.tt koha-tmpl/intranet-tmpl/prog/en/modules/members/printinvoice.tt koha-tmpl/opac-tmpl/bootstrap/en/modules/opac-account.tt It seems that occurrences in pay.tt are not relevant, we do not display payments in this table. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed May 3 21:22:43 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 03 May 2017 19:22:43 +0000 Subject: [Koha-bugs] [Bug 18472] Add system preferences to manage online help system In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18472 --- Comment #17 from Jonathan Druart --- Could you explain why did you reuse the news system instead of creating a new fresh module? -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed May 3 21:23:41 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 03 May 2017 19:23:41 +0000 Subject: [Koha-bugs] [Bug 18534] New: When IndependentBranches is enabled the pickup location displayed incorrectly on request.pl Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18534 Bug ID: 18534 Summary: When IndependentBranches is enabled the pickup location displayed incorrectly on request.pl Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: normal Priority: P5 - low Component: Hold requests Assignee: koha-bugs at lists.koha-community.org Reporter: nick at bywatersolutions.com QA Contact: testopia at bugs.koha-community.org CC: gmcharlt at gmail.com The pickup location pulldown is populated with only the users branch when IndependentBranches is enabled - if the actual pickup location is a different library you instead see the current library To recreate: 1 - Place a hold for pickup at Midway 2 - Enable independentbranches 3 - Login to staff interface as admin without superlibrarian status from a different branch 4 - View the holds for the title you placed a hold on 5 - The hold placed in step 1 should show a dropdown with current branch as pickup location, current branch is the only in that dropdown 6 - Verify it displays correctly for superlibrarian -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed May 3 21:24:26 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 03 May 2017 19:24:26 +0000 Subject: [Koha-bugs] [Bug 18534] When IndependentBranches is enabled the pickup location displayed incorrectly on request.pl In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18534 Nick Clemens changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed May 3 21:24:29 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 03 May 2017 19:24:29 +0000 Subject: [Koha-bugs] [Bug 18534] When IndependentBranches is enabled the pickup location displayed incorrectly on request.pl In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18534 --- Comment #1 from Nick Clemens --- Created attachment 63043 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=63043&action=edit Bug 18534 - When IndependentBranches is enabled the pickup location displayed incorrectly on request.pl To recreate: 1 - Place a hold for pickup at Midway 2 - Enable independentbranches 3 - Login to staff interface as admin without superlibrarian status from a different branch 4 - View the holds for the title you placed a hold on 5 - The hold placed in step 1 should show a dropdown with current branch as pickup location, current branch is the only in that dropdown 6 - Verify it displays correctly for superlibrarian 7 - Apply patch 8 - The correct pickup location should show and not be editable 9 - Verify it is a dropdown -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed May 3 21:24:40 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 03 May 2017 19:24:40 +0000 Subject: [Koha-bugs] [Bug 18534] When IndependentBranches is enabled the pickup location displayed incorrectly on request.pl In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18534 Nick Clemens changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|koha-bugs at lists.koha-commun |nick at bywatersolutions.com |ity.org | -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Wed May 3 21:52:45 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 03 May 2017 19:52:45 +0000 Subject: [Koha-bugs] [Bug 16892] Add automatic patron registration via OAuth2 login In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16892 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |nick at bywatersolutions.com -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed May 3 22:03:06 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 03 May 2017 20:03:06 +0000 Subject: [Koha-bugs] [Bug 16892] Add automatic patron registration via OAuth2 login In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16892 --- Comment #34 from Jonathan Druart --- Can we get an updated test plan? It sounds like the Google APIs interface has changed. The last line you added to opac/svc/auth/googleopenidconnect (Koha::Patrons->find) is not necessary, $borrower is not used later. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed May 3 22:06:41 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 03 May 2017 20:06:41 +0000 Subject: [Koha-bugs] [Bug 18535] New: Clicking 'edit printer profile' in label creator causes software error Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18535 Bug ID: 18535 Summary: Clicking 'edit printer profile' in label creator causes software error Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: normal Priority: P5 - low Component: Label/patron card printing Assignee: cnighswonger at foundations.edu Reporter: barton at bywatersolutions.com QA Contact: testopia at bugs.koha-community.org To re-create. 1) Go to Tools > Label creator 2) If you don't have a printer profile defined, create one. 3) Go to manage > Printer profiles 4) Click the 'edit' button on any of the profiles. This will cause a software error; the plack error log will show Can't use string ("fields") as a HASH ref while "strict refs" in use at /usr/share/koha/lib/C4/Creators/Lib.pm line 147. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed May 3 22:22:59 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 03 May 2017 20:22:59 +0000 Subject: [Koha-bugs] [Bug 18472] Add system preferences to manage online help system In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18472 --- Comment #18 from Marc V?ron --- (In reply to Jonathan Druart from comment #17) > Could you explain why did you reuse the news system instead of creating a > new fresh module? Because the news module contains all the functionality needed, and users are used to it. I did not want to reinvent the wheel. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed May 3 22:39:03 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 03 May 2017 20:39:03 +0000 Subject: [Koha-bugs] [Bug 18472] Add system preferences to manage online help system In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18472 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |m.de.rooy at rijksmuseum.nl, | |nick at bywatersolutions.com, | |tomascohen at gmail.com --- Comment #19 from Jonathan Druart --- I personally do not think it is a good idea, I'd like to get other QAers point of view. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed May 3 22:45:43 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 03 May 2017 20:45:43 +0000 Subject: [Koha-bugs] [Bug 18535] Clicking 'edit printer profile' in label creator causes software error In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18535 Nick Clemens changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed May 3 22:45:45 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 03 May 2017 20:45:45 +0000 Subject: [Koha-bugs] [Bug 18535] Clicking 'edit printer profile' in label creator causes software error In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18535 --- Comment #1 from Nick Clemens --- Created attachment 63044 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=63044&action=edit Bug 18535 - Clicking 'edit printer profile' in label creator causes software error 1) Go to Tools > Label creator 2) If you don't have a printer profile defined, create one. 3) Go to manage > Printer profiles 4) Click the 'edit' button on any of the profiles. 5) INTERNAL SERVER ERROR! "Can't use string ("fields") as a HASH ref while "strict refs" in use at /usr/share/koha/lib/C4/Creators/Lib.pm line 147" 6) Apply patch 7) Click the 'edit' button on any of the profiles. 8) Things work as expected -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed May 3 22:49:18 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 03 May 2017 20:49:18 +0000 Subject: [Koha-bugs] [Bug 18535] Clicking 'edit printer profile' in label creator causes software error In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18535 Nick Clemens changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |nick at bywatersolutions.com Assignee|cnighswonger at foundations.ed |nick at bywatersolutions.com |u | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed May 3 22:49:38 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 03 May 2017 20:49:38 +0000 Subject: [Koha-bugs] [Bug 18535] Clicking 'edit printer profile' in label creator causes software error In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18535 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |jonathan.druart at bugs.koha-c | |ommunity.org -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed May 3 22:49:50 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 03 May 2017 20:49:50 +0000 Subject: [Koha-bugs] [Bug 8612] CSV export profile to have custom fields in export csv basket In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8612 Philippe Audet-Fortin changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |philippe.audet-fortin at inlib | |ro.com --- Comment #82 from Philippe Audet-Fortin --- Hi Marcel, I was wondering what you want to show in your first subparagraph, because it seems normal to me that it will not work if there is no table in front of the field. Koha need to know the table where the field come from. (Sorry for my english :)) -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed May 3 23:17:45 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 03 May 2017 21:17:45 +0000 Subject: [Koha-bugs] [Bug 17944] Remove the sql code from itemtypes.pl administrative perl script In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17944 Alex Buckley changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #62499|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed May 3 23:17:58 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 03 May 2017 21:17:58 +0000 Subject: [Koha-bugs] [Bug 17944] Remove the sql code from itemtypes.pl administrative perl script In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17944 Alex Buckley changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #62500|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed May 3 23:18:11 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 03 May 2017 21:18:11 +0000 Subject: [Koha-bugs] [Bug 17944] Remove the sql code from itemtypes.pl administrative perl script In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17944 Alex Buckley changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #62502|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed May 3 23:18:25 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 03 May 2017 21:18:25 +0000 Subject: [Koha-bugs] [Bug 17944] Remove the sql code from itemtypes.pl administrative perl script In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17944 Alex Buckley changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #62503|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed May 3 23:18:51 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 03 May 2017 21:18:51 +0000 Subject: [Koha-bugs] [Bug 17944] Remove the sql code from itemtypes.pl administrative perl script In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17944 Alex Buckley changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #62504|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed May 3 23:19:07 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 03 May 2017 21:19:07 +0000 Subject: [Koha-bugs] [Bug 17944] Remove the sql code from itemtypes.pl administrative perl script In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17944 Alex Buckley changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #62505|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed May 3 23:19:47 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 03 May 2017 21:19:47 +0000 Subject: [Koha-bugs] [Bug 17944] Remove the sql code from itemtypes.pl administrative perl script In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17944 --- Comment #41 from Alex Buckley --- Created attachment 63045 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=63045&action=edit Bug 17944 - Overridden Koha::Object->delete with Koha::ItemType->delete and implemented exception to be shown if the itemtype cannot be deleted. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed May 3 23:20:17 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 03 May 2017 21:20:17 +0000 Subject: [Koha-bugs] [Bug 17944] Remove the sql code from itemtypes.pl administrative perl script In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17944 Alex Buckley changed: What |Removed |Added ---------------------------------------------------------------------------- Status|BLOCKED |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu May 4 00:39:39 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 03 May 2017 22:39:39 +0000 Subject: [Koha-bugs] [Bug 16892] Add automatic patron registration via OAuth2 login In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16892 --- Comment #35 from M. Tompsett --- ARG! I really hate them constantly changing the interface. It makes it so much harder to help people set up. First you need to confirm the Google OAuth works normally: Go to https://console.developers.google.com/project Log in Click '+ Create Project' Type in a project name and click 'CREATE' -- the notification bell will highlight Select the creation notification with the project just created Click 'Go to APIs overview' Click 'Credentials' in the left panel Click the 'Create credentials' drop-down button Click 'OAuth client ID' Click 'Configure consent screen' Put it a meaningful string into the Product Name (e.g. South Pole Library Authentication) Fill in the other fields as desired (or not) Click 'Save' Click the 'Web application' radio button Change the 'AUTHORIZED JAVASCRIPT ORIGINS' to your OPACBaseURL. (http://localhost:8080) Change the 'AUTHORIZED REDIRECT URIS' to point to the new googleoauth2 script (http://localhost:8080/cgi-bin/koha/svc/auth/googleopenidconnect) Click 'Create' Copy and paste the 'Client ID' into the GoogleOAuth2ClientID system preference. Copy and paste the 'client secret' into the GoogleOAuth2ClientSecret system preference. Change the GoogleOpenIDConnect system preference to 'Use'. Click 'Save all Administration preferences' Click 'OK' to dismiss the client ID and client secret dialogue. In the OPAC, click 'Log in to your account'. -- You should get a confirmation request, if you are already logged in, OR a login screen if you are not. -- You need to have the primary email address set to one authenticated by Google in order to log in. -- OPACBaseURL system preference needs to be set as well. This confirms you have the Google Authentication set up. Make sure your google email is not associated with an account now, or you have a second account to test with that has no patron matching. Apply the patch Upgrade the database Make sure you set the three new system preferences: GoogleOpenIDConnectAutoRegister - Allow GoogleOpenIDConnectDefaultBranch - Any valid existing branchcode. GoogleOpenIDConnectDefaultCategory - Any valid existing patron category. Attempt to log in with a Google account not associated with a Koha account. -- should succeed Searching for patron in Staff client should show they are that branch and category. Run koha qa test tools. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu May 4 01:00:53 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 03 May 2017 23:00:53 +0000 Subject: [Koha-bugs] [Bug 16892] Add automatic patron registration via OAuth2 login In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16892 --- Comment #36 from M. Tompsett --- I haven't tested it, but I think the find is a way of ensuring the member has been added. A cache flush? A pause? Remove it and test with a plack-based system, before deciding to remove it. Also, before the code was added and at the end means for debugging, I could assert that $borrower would be a valid patron. Which is conceptually beautiful. :) -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu May 4 02:01:25 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 04 May 2017 00:01:25 +0000 Subject: [Koha-bugs] [Bug 8948] MARC21 field 787 doesn't display In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8948 --- Comment #11 from David Cook --- (In reply to Marc V?ron from comment #10) > Still valid? Not sure. I haven't looked in a while. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu May 4 02:05:38 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 04 May 2017 00:05:38 +0000 Subject: [Koha-bugs] [Bug 18299] Removal of admin/env_tz_test.pl script In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18299 David Cook changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |dcook at prosentient.com.au --- Comment #13 from David Cook --- (In reply to Jonathan Druart from comment #8) > I was not aware of this script and I think it does not make sense to have it. > I'd prefer to remove it than adding more code to the codebase to maintain it. > > Opinions? I was not aware of this script until recently, but I have been using it to double-check that I've set up the timezone for Koha correctly in Apache. I'm OK with removing the script overall, but could we add timezone information to the About page in the "Server information" tab? -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu May 4 08:28:33 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 04 May 2017 06:28:33 +0000 Subject: [Koha-bugs] [Bug 18465] Patron card creator: Print on duplex card printer In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18465 --- Comment #11 from Katrin Fischer --- Mine were not quite as pretty as yours - but it works really well! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu May 4 08:29:13 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 04 May 2017 06:29:13 +0000 Subject: [Koha-bugs] [Bug 18465] Patron card creator: Print on duplex card printer In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18465 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu May 4 08:29:15 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 04 May 2017 06:29:15 +0000 Subject: [Koha-bugs] [Bug 18465] Patron card creator: Print on duplex card printer In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18465 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #62498|0 |1 is obsolete| | --- Comment #12 from Katrin Fischer --- Created attachment 63046 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=63046&action=edit [SIGNED OFF] Bug 18465 - Patron card creator: Print on duplex card printer Card printers with duplex functionality need as input a PDF file where odd pages contain the front side and even pages the back side of the cards. This patch adds such functionality. To prepare test: - In Patron card creator > Templates, prepare a 1 up template (1 column / 1 row) that fits to a single card. Give it a name like 'Duplex card template' (Attention, Card with and Card height seem to have wrong labels, that will go to a separate bug). - In Patron card creator > Layouts create a layout for the front side and one for the back side. Give them names to easily remember (Card front layout, Card back layout) - Go to Patron card creator > Batches and test both layouts together with the 1 up template. Save and keepp both test files as reference. To test: - Apply patch. Restart memcached and plack. - Go to Patron card creator > Batches - Click "Export" for a batch - In the following screen, note the new field "Select a layout for the back side" with a hint what it is used for - Leave it on 'Back side layout not used', export and compare output with test ooutput from preparation. It should be the same - Select the layout you prepared for the back side. - Export - this file should contain 2 PDF pages per patron, one first with the front side, second with the back side. Signed-off-by: Katrin Fischer -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu May 4 08:34:15 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 04 May 2017 06:34:15 +0000 Subject: [Koha-bugs] [Bug 18002] Make onboarding tool include framework to be embedded in Acquisitions to help the users set up Acquisitions for the first time In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18002 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |katrin.fischer at bsz-bw.de --- Comment #30 from Katrin Fischer --- Starting to take a look at this (finally!). There are some complaints by the QA script: FAIL koha-tmpl/intranet-tmpl/prog/en/includes/onboardinginclude.inc OK forbidden patterns FAIL git manipulation The file has been added and deleted in the same patchset OK spelling OK tt_valid OK valid_template FAIL koha-tmpl/intranet-tmpl/prog/en/includes/onboardinginclude3.inc OK forbidden patterns OK git manipulation OK spelling OK tt_valid FAIL valid_template : filter not found FAIL koha-tmpl/intranet-tmpl/prog/en/modules/acqui/acqui-home.tt OK forbidden patterns OK git manipulation FAIL spelling seperate ==> separate OK tt_valid OK valid_template FAIL koha-tmpl/intranet-tmpl/prog/en/modules/admin/aqbudgetperiods.tt FAIL forbidden patterns forbidden pattern: tab char (line 337) OK git manipulation OK spelling OK tt_valid OK valid_template As there have been no sign-offs yet, sqashing the patches should usually be alright if you want to (for the remove/add complaint). -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu May 4 08:36:27 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 04 May 2017 06:36:27 +0000 Subject: [Koha-bugs] [Bug 18002] Make onboarding tool include framework to be embedded in Acquisitions to help the users set up Acquisitions for the first time In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18002 --- Comment #31 from Katrin Fischer --- Patches eyeball well on first glance otherwise! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu May 4 08:42:13 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 04 May 2017 06:42:13 +0000 Subject: [Koha-bugs] [Bug 8612] CSV export profile to have custom fields in export csv basket In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8612 --- Comment #83 from Marcel de Rooy --- (In reply to Philippe Audet-Fortin from comment #82) > Hi Marcel, I was wondering what you want to show in your first subparagraph, > because it seems normal to me that it will not work if there is no table in > front of the field. Koha need to know the table where the field come from. > (Sorry for my english :)) Hmm. Maybe a misunderstanding. Comment81 refers to some lines in the code including the comment "# Remove the table name if exists." -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu May 4 08:45:49 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 04 May 2017 06:45:49 +0000 Subject: [Koha-bugs] [Bug 18450] Renew in header bypasses hold block and renewal limits In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18450 --- Comment #6 from Josef Moravec --- Comment on attachment 62811 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=62811 Bug 18450 - Implemented check if either AllowRenewLimitOverride or AllowRenewalIfOtherItemsAvaliable were set to allow, so the user is only blocked if both of these sysprefs are set to 'Dont allow' Review of attachment 62811: --> (https://bugs.koha-community.org/bugzilla3/page.cgi?id=splinter.html&bug=18450&attachment=62811) ----------------------------------------------------------------- ::: koha-tmpl/intranet-tmpl/prog/en/modules/circ/renew.tt @@ +119,5 @@ > + > + > + > + > + [% ELSIF ((Koha.Preference('AllowRenewalLimitOverride')) && !(Koha.Preference('AllowRenewalIfOtherItemsAvai lable'))) %] wrong copy paste in AllowRenewalIfOtherItemsAvailable preference name -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu May 4 08:46:16 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 04 May 2017 06:46:16 +0000 Subject: [Koha-bugs] [Bug 18450] Renew in header bypasses hold block and renewal limits In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18450 Josef Moravec changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |josef.moravec at gmail.com -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu May 4 08:55:21 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 04 May 2017 06:55:21 +0000 Subject: [Koha-bugs] [Bug 18472] Add system preferences to manage online help system In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18472 --- Comment #20 from Marcel de Rooy --- (In reply to Jonathan Druart from comment #19) > I personally do not think it is a good idea, I'd like to get other QAers > point of view. At first glance, I would think so too. But I did not study all code changes. Marc: Could you convince the QA team why this is a good idea? What is the impact on the news module itself? -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu May 4 09:02:06 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 04 May 2017 07:02:06 +0000 Subject: [Koha-bugs] [Bug 14803] Rental and fine fees are not updating on circulation screen In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14803 Josef Moravec changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |josef.moravec at gmail.com --- Comment #26 from Josef Moravec --- Created attachment 63047 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=63047&action=edit Checking Out (In reply to Srdjan Jankovic from comment #25) > (In reply to Owen Leonard from comment #23) > > Created attachment 62294 [details] > > Screenshot showing a problem with the checkout box > > > > something weird happens when the patron's fines are past the > > noissuescharge limit. The checkout form is hidden from all users, whether > > they have permission to override or not. > > That may be an existing condition. I've made some changes to take in account > AllowFineOverride pref. But now, when I have no fines owed, I can't see the checkout form and even any current checkouts... See attached screenshot -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu May 4 09:13:18 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 04 May 2017 07:13:18 +0000 Subject: [Koha-bugs] [Bug 12063] Change date calculation for reserve expiration to skip all holidays In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12063 --- Comment #74 from Marcel de Rooy --- (In reply to Alex Arnaud from comment #72) > (In reply to Marcel de Rooy from comment #71) > > The situation I described is independent of this pref. You could use the > > cron job to remove expired reserves based on expiration dates entered by > > patrons. > > > > Difficult to decide the issue. The behavior of sub CancelExpiredReserves was > before: > - Cancel holds with an expiration date (asked by the patron afaik), > - Cancel other exipred holds only if ExpireReservesMaxPickUpDelay is set > to allow > > So now we have all waiting reerves with an expiration date, we can't make > the difference between those with expiration ask by the patron and those > with expiration calculated. True, but not in all cases. If you disabled ExpireReservesMaxPickUpDelay, all expired reserves must be 'patron-originated'. But the question is: do we still need to make a distinction? The reserve has expired for some reason, we can cancel it. We can just remove the line imo. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu May 4 09:15:45 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 04 May 2017 07:15:45 +0000 Subject: [Koha-bugs] [Bug 12063] Change date calculation for reserve expiration to skip all holidays In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12063 --- Comment #75 from Marcel de Rooy --- (In reply to Alex Arnaud from comment #73) > And note that CancelExpiredReserves is only caled by the script > misc/cronjobs/holds/cancel_expired_holds.pl. Nowhere else if i'm not wrong. > So if we remove the check of ExpireReservesMaxPickUpDelay from this sub, we > get a kind of "force cancel reserves". I do not understand. CancelExpiredReserves should just do what it says. Note that this patch would change behavior otherwise. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu May 4 09:16:43 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 04 May 2017 07:16:43 +0000 Subject: [Koha-bugs] [Bug 8612] CSV export profile to have custom fields in export csv basket In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8612 Josef Moravec changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #61264|0 |1 is obsolete| | --- Comment #84 from Josef Moravec --- Created attachment 63048 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=63048&action=edit Bug 8612: Use CSV profile for exporting basket This patch allows the user to use a CSV export profile to create the fields to export the basket as CSV in a basket page. Test plan: 1) Apply the patch 2) Go to Tools ? CSV export profiles and create a profile of type "SQL for basket export in acquisition" example: biblionumber=biblio.biblionumber|auteur=biblio.author|titre=biblio.title|date=biblioitems.copyrightdate|editeur=biblioitems.publishercode|isbn=biblioitems.isbn|quantite=aqorders.quantity|prix=aqorders.rrp|panier=aqorders.basketno 3) In acquisition module, create a new basket and add an order to the basket 4) On basket detail page, there should be the split button labelled "Export to CSV" 5) Try to use the button and export CSV with your CSV profile you defined in step 2 6) Validate the CSV file. 7) Repeat 4-6 with a closed basket. a) close the basket b) View the basket c) validate that there is an export button d) test it with an export 8) prove t/db_dependent/Acquisition/GetBasketAsCSV.t t/db_dependent/Koha/CsvProfiles.t Initial work: Sponsored by: CCSR Signed-off-by: Josef Moravec Signed-off-by: mehdi -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu May 4 09:16:50 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 04 May 2017 07:16:50 +0000 Subject: [Koha-bugs] [Bug 8612] CSV export profile to have custom fields in export csv basket In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8612 Josef Moravec changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #61265|0 |1 is obsolete| | --- Comment #85 from Josef Moravec --- Created attachment 63049 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=63049&action=edit Bug 8612: QA-followup - Fix test -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu May 4 09:16:58 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 04 May 2017 07:16:58 +0000 Subject: [Koha-bugs] [Bug 8612] CSV export profile to have custom fields in export csv basket In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8612 Josef Moravec changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #61266|0 |1 is obsolete| | --- Comment #86 from Josef Moravec --- Created attachment 63050 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=63050&action=edit Bug 8612: QA followup - make usage and type different columns in db -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu May 4 09:17:05 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 04 May 2017 07:17:05 +0000 Subject: [Koha-bugs] [Bug 8612] CSV export profile to have custom fields in export csv basket In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8612 Josef Moravec changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #61267|0 |1 is obsolete| | --- Comment #87 from Josef Moravec --- Created attachment 63051 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=63051&action=edit Bug 8612: QA followup - update dbix schema -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu May 4 09:17:12 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 04 May 2017 07:17:12 +0000 Subject: [Koha-bugs] [Bug 8612] CSV export profile to have custom fields in export csv basket In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8612 Josef Moravec changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #61405|0 |1 is obsolete| | --- Comment #88 from Josef Moravec --- Created attachment 63052 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=63052&action=edit Bug 8612 - QA followup, fix kohastructure.sql, fix typo in template -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu May 4 09:17:18 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 04 May 2017 07:17:18 +0000 Subject: [Koha-bugs] [Bug 8612] CSV export profile to have custom fields in export csv basket In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8612 Josef Moravec changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #61520|0 |1 is obsolete| | --- Comment #89 from Josef Moravec --- Created attachment 63053 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=63053&action=edit Bug 8612: [QA Follow-up] Just a cosmetic space Could not resist to add it :) Signed-off-by: Marcel de Rooy -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu May 4 09:17:40 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 04 May 2017 07:17:40 +0000 Subject: [Koha-bugs] [Bug 8612] CSV export profile to have custom fields in export csv basket In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8612 --- Comment #90 from Josef Moravec --- Just a rebase first... -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu May 4 10:00:41 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 04 May 2017 08:00:41 +0000 Subject: [Koha-bugs] [Bug 18152] UNIMARC bib records imported with invalid 'a' char in label pos.9 In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18152 --- Comment #20 from stephane.delaune at biblibre.com --- (In reply to Jonathan Druart from comment #19) > (In reply to Jonathan Druart from comment #18) > > Regarding the description of this bug we are expecting the Leader 9 for > > UNIMARC records to be blank, does it make sense to set it in > > SetMarcUnicodeFlag? > > I do not think it makes sense actually, must be done elsewhere. What does not make sense is that SetMarcUnicodeFlag adds an invalid character where it should not (which can be considered a bug). To do so elsewhere is to leave a bug in place to do corrective action elsewhere: a nonsense -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu May 4 10:02:21 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 04 May 2017 08:02:21 +0000 Subject: [Koha-bugs] [Bug 18472] Add system preferences to manage online help system In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18472 --- Comment #21 from Marc V?ron --- (In reply to Marcel de Rooy from comment #20) > (In reply to Jonathan Druart from comment #19) > > I personally do not think it is a good idea, I'd like to get other QAers > > point of view. > > At first glance, I would think so too. But I did not study all code changes. > > Marc: Could you convince the QA team why this is a good idea? What is the > impact on the news module itself? Need: - Having a user editable, page aware help system is a long outstanding need. First time I was asked for goes back to 2012. - We have libraries interested in Koha who ask for in their requirements. - Writing a brand new help module would take a lot of time. And who would fund it? User: - The news system works very well and libraries are used to use it. The help additons introduced in Bug 18483 enhances the news system to host custom help as well. - From a user standpoint it is easy to use, you can add whatever you want / need as help. All the benefits of the news system can be used. Custom help items can easyly be added / edited. - It can turned on and off (combined with the existing file based help system or 'standalone'). This Bug 18472 is the basis for turning on and off and/or add additional help systems. - There is no change in behavior of news and file based help system if turned off (however this patch allows to turn off the edit function of the existing file based help system). Impact: - In Bug 18483, I paid great attention to have a minimal impact on existing code. No changes in .pm files were needed. - There is a small database change to have a field to host the page key if a news item is used as help item. Things to come: - Since the news system works for both staff client and OPAC it will be easy to implement the editable help for OPAC as well (Bug 18515) So I kindly ask for Bug 18472 and Bug 18483 to make part of Koha. Marc -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu May 4 10:37:42 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 04 May 2017 08:37:42 +0000 Subject: [Koha-bugs] [Bug 8612] CSV export profile to have custom fields in export csv basket In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8612 --- Comment #91 from Josef Moravec --- Created attachment 63054 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=63054&action=edit Bug 8612: QA folowup - fix regular expression to do what is described in the comment -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu May 4 10:37:49 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 04 May 2017 08:37:49 +0000 Subject: [Koha-bugs] [Bug 8612] CSV export profile to have custom fields in export csv basket In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8612 --- Comment #92 from Josef Moravec --- Created attachment 63055 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=63055&action=edit Bug 8612: QA followup - make header in CSV profile definition optional -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu May 4 10:37:56 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 04 May 2017 08:37:56 +0000 Subject: [Koha-bugs] [Bug 8612] CSV export profile to have custom fields in export csv basket In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8612 --- Comment #93 from Josef Moravec --- Created attachment 63056 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=63056&action=edit Bug 8612: QA followup - expand tests Test plan: prove t/db_dependent/Acquisition/GetBasketAsCSV.t -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu May 4 10:39:30 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 04 May 2017 08:39:30 +0000 Subject: [Koha-bugs] [Bug 8612] CSV export profile to have custom fields in export csv basket In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8612 Josef Moravec changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |Signed Off --- Comment #94 from Josef Moravec --- (In reply to Marcel de Rooy from comment #81) > See two things so far: > > [1] Regex for field does not work: > $field =~ s/[^\.]*\.?//; # Remove the table name if exists. > Does not work well if there is no table in front. > Try this: > $field="title"; > print "$field\n"; > $field =~ s/[^\.]*\.?//; # Remove the table name if exists. > print "$field\n"; Fixed by first today's followup > [2] Regex for header and fieldname makes header no longer optional. > while ( $csv_profile_content =~ / > ([^=]+) # header > = > ([^\|]+) # fieldname (table.row or row) > \|? /gxms > ) { > But if I understand correctly from this feature, the header should be > optional. > === Quote > You have to define which fields you want to export, separated by pipes. > You can also use your own headers (instead of the ones from Koha) by > prefixing the field name with an header, followed by the equal sign. > === > If I remove the headers now, I will have an empty csv file. Fixed by second today's followup Third followup is adding one more test case -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu May 4 10:52:45 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 04 May 2017 08:52:45 +0000 Subject: [Koha-bugs] [Bug 18315] authentication and authorization refactoring In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18315 --- Comment #8 from Olli-Antti Kivilahti --- I am relieved to hear that. This auth work just nudged forward in our dev pipeline and Lari is working with it atm. I hope you can work together to bring together the best of both worlds. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu May 4 10:53:08 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 04 May 2017 08:53:08 +0000 Subject: [Koha-bugs] [Bug 18315] authentication and authorization refactoring In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18315 Olli-Antti Kivilahti changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |https://bugs.koha-community | |.org/bugzilla3/show_bug.cgi | |?id=7174 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu May 4 10:53:08 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 04 May 2017 08:53:08 +0000 Subject: [Koha-bugs] [Bug 7174] Authentication rewriting In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7174 Olli-Antti Kivilahti changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |https://bugs.koha-community | |.org/bugzilla3/show_bug.cgi | |?id=18315 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu May 4 10:55:39 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 04 May 2017 08:55:39 +0000 Subject: [Koha-bugs] [Bug 18536] New: Generating CSV using profile in serials late issues doesn 't work as described Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18536 Bug ID: 18536 Summary: Generating CSV using profile in serials late issues doesn't work as described Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Serials Assignee: koha-bugs at lists.koha-community.org Reporter: josef.moravec at gmail.com QA Contact: testopia at bugs.koha-community.org CC: colin.campbell at ptfs-europe.com Description on editing csv profiles says: "You can also use your own headers (instead of the ones from Koha) by prefixing the field name with an header, followed by the equal sign." So the header should be optional, but in fact it's mandatory. Also the regular expression to cut table name from beginning of db column is not right. Patch follows -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Thu May 4 10:56:49 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 04 May 2017 08:56:49 +0000 Subject: [Koha-bugs] [Bug 12063] Change date calculation for reserve expiration to skip all holidays In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12063 --- Comment #76 from Alex Arnaud --- Created attachment 63057 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=63057&action=edit Bug 12063 - Remove checking of ExpireReservesMaxPickUpDelay in CancelExpiredReserves(). Koha::Hold::set_waiting calculate expiration date from today instead of hold's waiting date. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu May 4 11:00:18 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 04 May 2017 09:00:18 +0000 Subject: [Koha-bugs] [Bug 18536] Generating CSV using profile in serials late issues doesn' t work as described In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18536 Josef Moravec changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Thu May 4 11:00:21 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 04 May 2017 09:00:21 +0000 Subject: [Koha-bugs] [Bug 18536] Generating CSV using profile in serials late issues doesn' t work as described In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18536 --- Comment #1 from Josef Moravec --- Created attachment 63058 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=63058&action=edit Bug 18536: Generating CSV using profile in serials late issues doesn't work as described Description on editing csv profiles says: "You can also use your own headers (instead of the ones from Koha) by prefixing the field name with an header, followed by the equal sign." So the header should be optional, but in fact it's mandatory. Also the regular expression to cut table name from beginning of db column is not right. Test plan: 0. Don't apply the patch 1. Make two CSV profiles for exporting late issues a) SUPPLIER=aqbooksellers.name|TITLE=subscription.title|ISSUENUMBER=serial.serialseq|LATE SINCE=serial.planneddate b) aqbooksellers.name|TITLE=subscription.title|ISSUE NUMBER=serial.serialseq|LATE SINCE=serial.planneddate 2. Export late issues, profile a) works as expected, profile b) doesn't 3. Apply the patch 4. Both profiles should work -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu May 4 11:15:38 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 04 May 2017 09:15:38 +0000 Subject: [Koha-bugs] [Bug 18418] Advanced Editor - Rancor - Add a control number widget In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18418 Josef Moravec changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |josef.moravec at gmail.com --- Comment #2 from Josef Moravec --- Could you please make buttons bootstrap styled? See https://wiki.koha-community.org/wiki/Interface_patterns#Buttons -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu May 4 11:18:09 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 04 May 2017 09:18:09 +0000 Subject: [Koha-bugs] [Bug 13466] Changing language does not work In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13466 Josef Moravec changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |RESOLVED CC| |josef.moravec at gmail.com Resolution|--- |WORKSFORME --- Comment #3 from Josef Moravec --- I don't think it still an issue. Feel free to reopen if you still encounter this problem. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu May 4 11:23:20 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 04 May 2017 09:23:20 +0000 Subject: [Koha-bugs] [Bug 18417] Advanced Editor - Rancor - add shortcuts for copyright symbols (C) (P) In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18417 Josef Moravec changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |josef.moravec at gmail.com --- Comment #2 from Josef Moravec --- I think it would be nice to have these shortcuts documented under the "Keyboard shortcuts" button in editor toolbar, what do you think? -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu May 4 11:35:17 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 04 May 2017 09:35:17 +0000 Subject: [Koha-bugs] [Bug 17288] Advanced Editor - Rancor - Helpers for 006 and 007 fields In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17288 Josef Moravec changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu May 4 11:35:21 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 04 May 2017 09:35:21 +0000 Subject: [Koha-bugs] [Bug 17288] Advanced Editor - Rancor - Helpers for 006 and 007 fields In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17288 Josef Moravec changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #55454|0 |1 is obsolete| | Attachment #55548|0 |1 is obsolete| | Attachment #55842|0 |1 is obsolete| | Attachment #55855|0 |1 is obsolete| | --- Comment #12 from Josef Moravec --- Created attachment 63059 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=63059&action=edit [SIGNED-OFF] Bug 17288 - Advanced Editor - Rancor - Helpers for 006 and 007 fields To test: Open advanced cataloging editor Experiment with 006 and 007 fields and ensure helpers function for all material types Signed-off-by: Josef Moravec -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu May 4 11:35:27 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 04 May 2017 09:35:27 +0000 Subject: [Koha-bugs] [Bug 17288] Advanced Editor - Rancor - Helpers for 006 and 007 fields In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17288 --- Comment #13 from Josef Moravec --- Created attachment 63060 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=63060&action=edit [SIGNED-OFF] Bug 17288: (follow-up) Fix marc21_field_007.xml Bad formatted data in 007 field. Fixed To test follow the previous commit. Signed-off-by: Josef Moravec -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu May 4 11:35:48 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 04 May 2017 09:35:48 +0000 Subject: [Koha-bugs] [Bug 17288] Advanced Editor - Rancor - Helpers for 006 and 007 fields In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17288 --- Comment #14 from Josef Moravec --- Created attachment 63061 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=63061&action=edit [SIGNED-OFF] Bug 17288 (QA Followup) Don't default char 5 (is undefined in some forms) Signed-off-by: Josef Moravec -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu May 4 11:35:56 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 04 May 2017 09:35:56 +0000 Subject: [Koha-bugs] [Bug 17288] Advanced Editor - Rancor - Helpers for 006 and 007 fields In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17288 --- Comment #15 from Josef Moravec --- Created attachment 63062 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=63062&action=edit [SIGNED-OFF] Bug 17288: (follow-up) Remove unneccessary Date() function Remove line: var now = new Date(); from both subfields Also fix 18 positions (00-17) for default data in 006 field Signed-off-by: Josef Moravec -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu May 4 11:38:06 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 04 May 2017 09:38:06 +0000 Subject: [Koha-bugs] [Bug 11897] Stock Rotation for Koha In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11897 Alex Sassmannshausen changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Patch doesn't apply |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu May 4 11:38:09 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 04 May 2017 09:38:09 +0000 Subject: [Koha-bugs] [Bug 11897] Stock Rotation for Koha In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11897 Alex Sassmannshausen changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #62750|0 |1 is obsolete| | Attachment #62751|0 |1 is obsolete| | Attachment #62752|0 |1 is obsolete| | Attachment #62753|0 |1 is obsolete| | Attachment #62754|0 |1 is obsolete| | Attachment #62755|0 |1 is obsolete| | Attachment #62756|0 |1 is obsolete| | Attachment #62757|0 |1 is obsolete| | Attachment #62758|0 |1 is obsolete| | Attachment #62759|0 |1 is obsolete| | Attachment #62760|0 |1 is obsolete| | Attachment #62761|0 |1 is obsolete| | Attachment #62762|0 |1 is obsolete| | Attachment #62763|0 |1 is obsolete| | Attachment #62764|0 |1 is obsolete| | Attachment #62765|0 |1 is obsolete| | Attachment #62766|0 |1 is obsolete| | Attachment #62767|0 |1 is obsolete| | --- Comment #80 from Alex Sassmannshausen --- Created attachment 63063 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=63063&action=edit Bug 11897: Add Stock Rotation atomic update schema. * installer/data/mysql/atomicupdate/stockrot_tables.sql: New file. * installer/data/mysql/kohastructure.sql (stockrotationrotas) (stockrotationstages, stockrotationitems): New tables. * installer/data/mysql/sysprefs.sql: Add Stockrotation sysprefs. * installer/data/mysql/userflags.sql: Add Stockrotaiton userflag. * installer/data/mysql/userpermissions.sql: Add Stockrotation userpermissions. * koha-tmpl/intranet-tmpl/prog/en/modules/admin/preferences/circulation.pref: Add Stockrotation menu. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu May 4 11:38:20 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 04 May 2017 09:38:20 +0000 Subject: [Koha-bugs] [Bug 11897] Stock Rotation for Koha In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11897 --- Comment #81 from Alex Sassmannshausen --- Created attachment 63064 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=63064&action=edit Bug 11897: DO NOT PUSH: Add stock rotation schema files. * Koha/Schema/Result/Branch.pm: New file. * Koha/Schema/Result/Item.pm: New file. * Koha/Schema/Result/Stockrotationitem.pm: New file. * Koha/Schema/Result/Stockrotationrota.pm: New file. * Koha/Schema/Result/Stockrotationstage.pm: New file. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu May 4 11:38:28 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 04 May 2017 09:38:28 +0000 Subject: [Koha-bugs] [Bug 11897] Stock Rotation for Koha In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11897 --- Comment #82 from Alex Sassmannshausen --- Created attachment 63065 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=63065&action=edit Bug 11897: DBIX::Class::Ordered in Stockrotationstage. * Koha/Schema/Result/Stockrotationstage.pm: Load `Ordered`, add grouping_column. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu May 4 11:38:47 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 04 May 2017 09:38:47 +0000 Subject: [Koha-bugs] [Bug 11897] Stock Rotation for Koha In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11897 --- Comment #85 from Alex Sassmannshausen --- Created attachment 63068 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=63068&action=edit Bug 11897: Add Utils library for Stockrotation module * Koha/Util/Stockrotation.pm: new file -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu May 4 11:38:41 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 04 May 2017 09:38:41 +0000 Subject: [Koha-bugs] [Bug 11897] Stock Rotation for Koha In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11897 --- Comment #84 from Alex Sassmannshausen --- Created attachment 63067 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=63067&action=edit Bug 11897: Add stockrotation cron script. * misc/cronjobs/stockrotation.pl: New file. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu May 4 11:38:35 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 04 May 2017 09:38:35 +0000 Subject: [Koha-bugs] [Bug 11897] Stock Rotation for Koha In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11897 --- Comment #83 from Alex Sassmannshausen --- Created attachment 63066 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=63066&action=edit Bug 11897: Add Koha::Objects for Stockrotation module. * Koha/Stockrotationitem.pm: New file. * Koha/Stockrotationitems.pm: New file. * Koha/Stockrotationrota.pm: New file. * Koha/Stockrotationrotas.pm: New file. * Koha/Stockrotationstage.pm: New file. * Koha/Stockrotationstages.pm: New file. * t/db_dependent/Stockrotationitems.t: New file. * t/db_dependent/Stockrotationrotas.t: New file. * t/db_dependent/Stockrotationstages.t: New file. * Koha/Item.pm (stockrotationitem, add_to_rota, biblio): New procedures. * Koha/Library.pm (stockrotationstages): New procedure. * t/db_dependent/Items.t: Add tests. * t/db_dependent/Koha/Libraries.t: Add tests. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu May 4 11:38:53 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 04 May 2017 09:38:53 +0000 Subject: [Koha-bugs] [Bug 11897] Stock Rotation for Koha In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11897 --- Comment #86 from Alex Sassmannshausen --- Created attachment 63069 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=63069&action=edit Bug 11897: REST API - add path defs, controller & tests * Koha/REST/V1/Stage.pm: New file * api/v1/swagger/paths.json: Add route for stage manipulation * api/v1/swagger/paths/rotas.json: New file * t/db_dependent/api/v1/stockrotationstage.t: New file -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu May 4 11:38:58 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 04 May 2017 09:38:58 +0000 Subject: [Koha-bugs] [Bug 11897] Stock Rotation for Koha In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11897 --- Comment #87 from Alex Sassmannshausen --- Created attachment 63070 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=63070&action=edit Bug 11897: Add JS to provide rota stage manipulation * koha-tmpl/intranet-tmpl/prog/js/pages/stockrotation.js: new file -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu May 4 11:39:04 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 04 May 2017 09:39:04 +0000 Subject: [Koha-bugs] [Bug 11897] Stock Rotation for Koha In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11897 --- Comment #88 from Alex Sassmannshausen --- Created attachment 63071 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=63071&action=edit Bug 11897: Add Stockrotation CSS rules * koha-tmpl/intranet-tmpl/prog/css/staff-global.css: New rules -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu May 4 11:39:09 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 04 May 2017 09:39:09 +0000 Subject: [Koha-bugs] [Bug 11897] Stock Rotation for Koha In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11897 --- Comment #89 from Alex Sassmannshausen --- Created attachment 63072 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=63072&action=edit Bug 11897: Add Stock Rotation permissions to list * koha-tmpl/intranet-tmpl/prog/en/includes/permissions.inc: Add new permissions -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu May 4 11:39:15 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 04 May 2017 09:39:15 +0000 Subject: [Koha-bugs] [Bug 11897] Stock Rotation for Koha In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11897 --- Comment #90 from Alex Sassmannshausen --- Created attachment 63073 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=63073&action=edit Bug 11897: Interface for rotas from Tools menu * tools/stockrotation.pl: New file * koha-tmpl/intranet-tmpl/prog/en/modules/tools/stockrotation.tt: New file * koha-tmpl/intranet-tmpl/prog/en/includes/stockrotation-toolbar.inc: -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu May 4 11:39:21 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 04 May 2017 09:39:21 +0000 Subject: [Koha-bugs] [Bug 11897] Stock Rotation for Koha In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11897 --- Comment #91 from Alex Sassmannshausen --- Created attachment 63074 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=63074&action=edit Bug 11897: Interface for rota items from biblio * catalogue/stockrotation.pl: New file * koha-tmpl/intranet-tmpl/prog/en/modules/catalogue/stockrotation.tt: New file -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu May 4 11:39:26 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 04 May 2017 09:39:26 +0000 Subject: [Koha-bugs] [Bug 11897] Stock Rotation for Koha In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11897 --- Comment #92 from Alex Sassmannshausen --- Created attachment 63075 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=63075&action=edit Bug 11897: Add menu options for Stock Rotation * koha-tmpl/intranet-tmpl/prog/en/includes/biblio-view-menu.inc: Add menu option * koha-tmpl/intranet-tmpl/prog/en/includes/tools-menu.inc: Add menu option * koha-tmpl/intranet-tmpl/prog/en/modules/tools/tools-home.tt: Add menu option -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu May 4 11:39:32 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 04 May 2017 09:39:32 +0000 Subject: [Koha-bugs] [Bug 11897] Stock Rotation for Koha In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11897 --- Comment #93 from Alex Sassmannshausen --- Created attachment 63076 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=63076&action=edit Bug 11897: Bugfixes, unit tests, feedback, documentation. A (squashed) patch implementing significant changes to many parts of the module. Also adds thorough unit tests. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu May 4 11:39:37 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 04 May 2017 09:39:37 +0000 Subject: [Koha-bugs] [Bug 11897] Stock Rotation for Koha In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11897 --- Comment #94 from Alex Sassmannshausen --- Created attachment 63077 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=63077&action=edit Bug 11897: Fix style of button links, & form wording. * koha-tmpl/intranet-tmpl/prog/en/includes/stockrotation-toolbar.inc * koha-tmpl/intranet-tmpl/prog/en/modules/catalogue/stockrotation.tt * koha-tmpl/intranet-tmpl/prog/en/modules/tools/stockrotation.tt -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu May 4 11:39:42 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 04 May 2017 09:39:42 +0000 Subject: [Koha-bugs] [Bug 11897] Stock Rotation for Koha In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11897 --- Comment #95 from Alex Sassmannshausen --- Created attachment 63078 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=63078&action=edit Bug 11897: Add documentation for the cron script. * misc/cronjobs/stockrotation.pl: Add documentation. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu May 4 11:39:49 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 04 May 2017 09:39:49 +0000 Subject: [Koha-bugs] [Bug 11897] Stock Rotation for Koha In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11897 --- Comment #96 from Alex Sassmannshausen --- Created attachment 63079 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=63079&action=edit Bug 11897: Use camel case in Koha namespace modules. * Koha/Item.pm (stockrotationitem, add_to_rota): Use camel case. * Koha/Library.pm (stockrotationstages): Use camel case. * Koha/REST/V1/Stage.pm (move): Use camel case. * Koha/StockRotationItem.pm: New name for 'Koha/Stockrotationitem.pm'. (stage, advance): Use camel case. * Koha/StockRotationItems.pm: New name for 'Koha/Stockrotationitems.pm'. (object_class): Use camel case. * Koha/StockRotationRota.pm: New name for 'Koha/Stockrotationrota.pm'. (stockrotationstages, stockrotationitems, add_item): Use camel case. * Koha/StockRotationRotas.pm: New name for 'Koha/Stockrotationrotas.pm'. (object_class): Use camel case. * Koha/StockRotationStage.pm: New name for 'Koha/Stockrotationstage.pm'. (stockrotationitems, rota, siblings, next_siblings, previous_siblings) (next_sibling, previous_sibling, first_sibling, last_sibling): Use camel case. * Koha/StockRotationStages.pm: New name for 'Koha/Stockrotationstages.pm'. (object_class): Use camel case. * Koha/Util/StockRotation.pm: New name for 'Koha/Util/Stockrotation.pm'. (toggle_indemand, move_to_next_stage, remove_from_stage): Use camel case. * koha-tmpl/intranet-tmpl/prog/en/modules/admin/preferences/circulation.pref: Improve wording. * misc/cronjobs/stockrotation.pl: Use camel case. * catalogue/stockrotation.pl: Use camel case. * tools/stockrotation.pl: Use camel case. * t/db_dependent/Items.t: Use camel case. * t/db_dependent/Koha/Libraries.t: Use camel case. * t/db_dependent/StockRotationItems.t: New name for 't/db_dependent/Stockrotationitems.t' & use camel case. * t/db_dependent/StockRotationRotas.t: New name for 't/db_dependent/Stockrotationrotas.t' & use camel case. * t/db_dependent/StockRotationStages.t: New name for 't/db_dependent/Stockrotationstages.t' & use camel case. * t/db_dependent/api/v1/stockrotationstage.t: Use camel case. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu May 4 11:39:55 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 04 May 2017 09:39:55 +0000 Subject: [Koha-bugs] [Bug 11897] Stock Rotation for Koha In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11897 --- Comment #97 from Alex Sassmannshausen --- Created attachment 63080 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=63080&action=edit Bug 11897: Bugfix: Handle empty rotas. * Koha/StockRotationRota.pm (investigate): If current rota has no stages, return empty items & log entries in report. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu May 4 11:40:43 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 04 May 2017 09:40:43 +0000 Subject: [Koha-bugs] [Bug 11897] Stock Rotation for Koha In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11897 --- Comment #98 from Alex Sassmannshausen --- (In reply to Katrin Fischer from comment #79) > Sorry, don't want to break something - tried to resolve the conflicts, but > better leaving it up to the author. Ah, fast moving pre-release Koha :-) Should apply now. Thanks for trying! Alex -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu May 4 12:32:32 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 04 May 2017 10:32:32 +0000 Subject: [Koha-bugs] [Bug 7317] Add an Interlibrary Loan Module to Circulation and OPAC In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7317 Alex Sassmannshausen changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu May 4 12:32:37 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 04 May 2017 10:32:37 +0000 Subject: [Koha-bugs] [Bug 7317] Add an Interlibrary Loan Module to Circulation and OPAC In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7317 Alex Sassmannshausen changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #60485|0 |1 is obsolete| | --- Comment #29 from Alex Sassmannshausen --- Created attachment 63081 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=63081&action=edit Bug 7317: Add SQL templates & sysprefs. * installer/data/mysql/atomicupdate/ill_tables.sql: New file. * installer/data/mysql/kohastructure.sql: Add tables. * installer/data/mysql/sysprefs.sql: Add sysprefs. * installer/data/mysql/userflags.sql: Add userflags. * koha-tmpl/intranet-tmpl/prog/en/modules/admin/preferences/admin.pref: Add sysprefs to UI. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu May 4 12:32:48 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 04 May 2017 10:32:48 +0000 Subject: [Koha-bugs] [Bug 7317] Add an Interlibrary Loan Module to Circulation and OPAC In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7317 Alex Sassmannshausen changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #60486|0 |1 is obsolete| | --- Comment #30 from Alex Sassmannshausen --- Created attachment 63082 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=63082&action=edit Bug 7317: DO NOT PUSH: Updated Schema Files. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu May 4 12:32:56 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 04 May 2017 10:32:56 +0000 Subject: [Koha-bugs] [Bug 7317] Add an Interlibrary Loan Module to Circulation and OPAC In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7317 Alex Sassmannshausen changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #60487|0 |1 is obsolete| | --- Comment #31 from Alex Sassmannshausen --- Created attachment 63083 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=63083&action=edit Bug 7317: DO NOT PUSH: Update OPAC CSS -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu May 4 12:33:06 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 04 May 2017 10:33:06 +0000 Subject: [Koha-bugs] [Bug 7317] Add an Interlibrary Loan Module to Circulation and OPAC In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7317 Alex Sassmannshausen changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #60488|0 |1 is obsolete| | --- Comment #32 from Alex Sassmannshausen --- Created attachment 63084 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=63084&action=edit Bug 7317: ILLModule * Koha/Illrequest.pm * Koha/Illrequest/Config.pm * Koha/Illrequestattribute.pm * Koha/Illrequestattributes.pm * Koha/Illrequests.pm * Koha/REST/V1/Illrequests.pm * ill/ill-requests.pl * api/v1/swagger/paths.json * api/v1/swagger/paths/illrequests.json * etc/koha-conf.xml * koha-tmpl/intranet-tmpl/prog/css/staff-global.css * koha-tmpl/intranet-tmpl/prog/en/includes/circ-menu.inc * koha-tmpl/intranet-tmpl/prog/en/includes/ill-toolbar.inc * koha-tmpl/intranet-tmpl/prog/en/includes/permissions.inc * koha-tmpl/intranet-tmpl/prog/en/modules/ill/ill-requests.tt * koha-tmpl/intranet-tmpl/prog/en/modules/intranet-main.tt * koha-tmpl/opac-tmpl/bootstrap/en/includes/usermenu.inc * koha-tmpl/opac-tmpl/bootstrap/en/modules/opac-illrequests.tt * koha-tmpl/opac-tmpl/bootstrap/en/modules/opac-results-grouped.tt * koha-tmpl/opac-tmpl/bootstrap/en/modules/opac-results.tt * koha-tmpl/opac-tmpl/bootstrap/less/opac.less * opac/opac-illrequests.pl * t/db_dependent/Illrequest.t * t/db_dependent/Illrequest/Config.t * t/db_dependent/Illrequest/Dummy.t * t/db_dependent/api/v1/illrequests.t -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu May 4 12:33:14 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 04 May 2017 10:33:14 +0000 Subject: [Koha-bugs] [Bug 7317] Add an Interlibrary Loan Module to Circulation and OPAC In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7317 --- Comment #33 from Alex Sassmannshausen --- Created attachment 63085 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=63085&action=edit Bug 7317: Bugfix: copy ill folder during installation. * Makefile.PL: Add './ill' to list of installable directories. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu May 4 12:33:20 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 04 May 2017 10:33:20 +0000 Subject: [Koha-bugs] [Bug 7317] Add an Interlibrary Loan Module to Circulation and OPAC In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7317 --- Comment #34 from Alex Sassmannshausen --- Created attachment 63086 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=63086&action=edit Bug 7317: Allow journey to 'COMP' status. * Koha/Illrequest.pm (_core_status_graph): Add 'COMP' journey, and method. (mark_completed): new procedure. * ill/ill-requests.pl: Handle mark_completed. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu May 4 12:33:28 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 04 May 2017 10:33:28 +0000 Subject: [Koha-bugs] [Bug 7317] Add an Interlibrary Loan Module to Circulation and OPAC In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7317 --- Comment #35 from Alex Sassmannshausen --- Created attachment 63087 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=63087&action=edit Bug 7317: Make error messages slightly more user friendly. * koha-tmpl/intranet-tmpl/prog/en/modules/ill/ill-requests.tt: Change layout of errors, don't display cancel heading on cancel error. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu May 4 12:33:35 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 04 May 2017 10:33:35 +0000 Subject: [Koha-bugs] [Bug 7317] Add an Interlibrary Loan Module to Circulation and OPAC In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7317 --- Comment #36 from Alex Sassmannshausen --- Created attachment 63088 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=63088&action=edit Bug 7317: Allow display/hiding of arbitrary request columns Initially display a small selection of core fields, allow the user to progressively display additional metadata fields if required -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu May 4 12:33:41 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 04 May 2017 10:33:41 +0000 Subject: [Koha-bugs] [Bug 7317] Add an Interlibrary Loan Module to Circulation and OPAC In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7317 --- Comment #37 from Alex Sassmannshausen --- Created attachment 63089 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=63089&action=edit Bug 7317: Bugfix: Use correct column names in check_limits. * Koha/Illrequest.pm (check_limits): Change column names used to `branchcode` & `borrowernumber`. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu May 4 12:33:49 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 04 May 2017 10:33:49 +0000 Subject: [Koha-bugs] [Bug 7317] Add an Interlibrary Loan Module to Circulation and OPAC In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7317 --- Comment #38 from Alex Sassmannshausen --- Created attachment 63090 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=63090&action=edit Bug 7317: Add missing reference for `Koha::Illrequest`. * Koha/Illrequest.pm: Add missing `use` statement. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu May 4 12:35:09 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 04 May 2017 10:35:09 +0000 Subject: [Koha-bugs] [Bug 7317] Add an Interlibrary Loan Module to Circulation and OPAC In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7317 --- Comment #39 from Alex Sassmannshausen --- (In reply to Magnus Enger from comment #28) > It also looks like there is a missing "use Koha::Illrequests;" in > Koha/Illrequest.pm? > > When I try to use Koha::Illrequest in the Dancer-based NCIPServer I get this > error: > > [24015] error @1.447857> [hit #5]request to POST / crashed: Can't locate > object method "search" via package "Koha::Illrequests" (perhaps you forgot > to load "Koha::Illrequests"?) at /path/to/kohaclone/Koha/Illrequest.pm line > 684. in /usr/share/perl5/Dancer/Handler.pm l. 98 Hi, Thanks for pointing that out. I have now added a patch fixing this. I have also rebased and pushed up a few more patches we've been working on. Alex -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu May 4 13:18:20 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 04 May 2017 11:18:20 +0000 Subject: [Koha-bugs] [Bug 18295] C4::Items - Remove get_itemnumbers_of In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18295 Josef Moravec changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Patch doesn't apply CC| |josef.moravec at gmail.com --- Comment #3 from Josef Moravec --- fatal: sha1 information is lacking or useless (C4/Items.pm) -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu May 4 13:43:40 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 04 May 2017 11:43:40 +0000 Subject: [Koha-bugs] [Bug 18276] Koha::Biblio - Remove GetBiblioFromItemNumber In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18276 Josef Moravec changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Failed QA CC| |josef.moravec at gmail.com --- Comment #28 from Josef Moravec --- I've got this error on course reserve detail page in opac: Template process failed: undef error - The method onsite_checkout is not covered by tests! at /home/vagrant/kohaclone/C4/Templates.pm line 121. Also there are some problems reported by qa tools: FAIL C4/SIP/ILS/Item.pm FAIL forbidden patterns forbidden pattern: tab char (line 74) forbidden pattern: tab char (line 99) forbidden pattern: tab char (line 100) forbidden pattern: tab char (line 90) FAIL C4/SIP/ILS/Transaction/Hold.pm FAIL forbidden patterns forbidden pattern: tab char (line 108) FAIL circ/returns.pl FAIL valid Global symbol "$biblio" requires explicit package name circ/returns.pl had compilation errors. FAIL circ/transferstoreceive.pl FAIL valid Global symbol "$num" requires explicit package name Global symbol "$getransf" requires explicit package name Global symbol "%getransf" requires explicit package name syntax error Global symbol "$biblio" requires explicit package name Global symbol "%branchloop" requires explicit package name circ/transferstoreceive.pl has too many errors. FAIL koha-tmpl/intranet-tmpl/prog/en/modules/cataloguing/moveitem.tt FAIL forbidden patterns forbidden pattern: tab char (line 39) forbidden pattern: tab char (line 46) FAIL offline_circ/process_koc.pl FAIL valid Global symbol "$biblio" requires explicit package name offline_circ/process_koc.pl had compilation errors. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu May 4 14:21:27 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 04 May 2017 12:21:27 +0000 Subject: [Koha-bugs] [Bug 18358] OPAC course reserves don't show not for loan status In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18358 Owen Leonard changed: What |Removed |Added ---------------------------------------------------------------------------- Version|16.05 |master Severity|enhancement |normal -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu May 4 14:21:19 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 04 May 2017 12:21:19 +0000 Subject: [Koha-bugs] [Bug 18358] OPAC course reserves don't show not for loan status In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18358 Owen Leonard changed: What |Removed |Added ---------------------------------------------------------------------------- Summary|koha item-status.inc |OPAC course reserves don't |variable name |show not for loan status -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu May 4 14:22:52 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 04 May 2017 12:22:52 +0000 Subject: [Koha-bugs] [Bug 12063] Change date calculation for reserve expiration to skip all holidays In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12063 Marcel de Rooy changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #62001|0 |1 is obsolete| | --- Comment #77 from Marcel de Rooy --- Created attachment 63091 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=63091&action=edit Bug 12063: Change date calculation for reserve expiration to skip all holiday This patch makes koha automatically set expiration date when reserves become waitting. Also it adds a new syspref "ExcludeHolidaysFromMaxPickUpDelay" that allows to take holidays into account while calculating expiration date. Test plan: - Install this patch and run updatedatabase.pl script, - allow ExpireReservesMaxPickUpDelay in system preferences, - set ReservesMaxPickUpDelay to 5. - Place an hold on a checked out item and check in this item: The hold's expiration date should be today + 5. - Allow ExcludeHolidaysFromMaxPickUpDelay in system preferences, - add holiday during this pickup delay period, - Create a new hold and make it comes waitting: The hold's expiration date should be today + 5 + number of closed day(s). Also: - Check that ExpireReservesOnHolidays syspref works again without ExcludeHolidaysFromMaxPickUpDelay. - Check that cancel fees apply again if wanted. Signed-off-by: sonia BOUIS Signed-off-by: Marcel de Rooy -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu May 4 14:22:58 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 04 May 2017 12:22:58 +0000 Subject: [Koha-bugs] [Bug 12063] Change date calculation for reserve expiration to skip all holidays In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12063 Marcel de Rooy changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #62002|0 |1 is obsolete| | --- Comment #78 from Marcel de Rooy --- Created attachment 63092 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=63092&action=edit Bug 12063 - Remove Koha::Hold::waiting_expires_on since dateexpiration is set on database Signed-off-by: sonia BOUIS Signed-off-by: Marcel de Rooy -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu May 4 14:23:04 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 04 May 2017 12:23:04 +0000 Subject: [Koha-bugs] [Bug 12063] Change date calculation for reserve expiration to skip all holidays In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12063 Marcel de Rooy changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #62003|0 |1 is obsolete| | --- Comment #79 from Marcel de Rooy --- Created attachment 63093 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=63093&action=edit Bug 12063 - Keep patron's requested expiration date if it is prior to the calculated one Signed-off-by: Andreas Hedstr?m Mace Signed-off-by: Marcel de Rooy -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu May 4 14:23:09 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 04 May 2017 12:23:09 +0000 Subject: [Koha-bugs] [Bug 12063] Change date calculation for reserve expiration to skip all holidays In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12063 Marcel de Rooy changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #62004|0 |1 is obsolete| | --- Comment #80 from Marcel de Rooy --- Created attachment 63094 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=63094&action=edit Bug 12063 - Fix unit tests Signed-off-by: Marcel de Rooy -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu May 4 14:23:15 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 04 May 2017 12:23:15 +0000 Subject: [Koha-bugs] [Bug 12063] Change date calculation for reserve expiration to skip all holidays In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12063 Marcel de Rooy changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #62005|0 |1 is obsolete| | --- Comment #81 from Marcel de Rooy --- Created attachment 63095 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=63095&action=edit Bug 12063 - Fix QA failures - Remove expiration date calculation in C4::Letter since it's done when setting the reserve waiting, - remove expiration date calculation in circ/waitingreserves.pl. Use the one in DB, - add a new atomic update that calculate expiration date for waiting reserves, - add tests for days_foward function and fix the infinite loop. Signed-off-by: Marcel de Rooy -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu May 4 14:23:21 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 04 May 2017 12:23:21 +0000 Subject: [Koha-bugs] [Bug 12063] Change date calculation for reserve expiration to skip all holidays In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12063 Marcel de Rooy changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #62474|0 |1 is obsolete| | --- Comment #82 from Marcel de Rooy --- Created attachment 63096 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=63096&action=edit Bug 12063 - make perl atomic update follow skeleton.perl Signed-off-by: Marcel de Rooy -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu May 4 14:23:26 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 04 May 2017 12:23:26 +0000 Subject: [Koha-bugs] [Bug 12063] Change date calculation for reserve expiration to skip all holidays In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12063 Marcel de Rooy changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #63057|0 |1 is obsolete| | --- Comment #83 from Marcel de Rooy --- Created attachment 63097 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=63097&action=edit Bug 12063 - Remove checking of ExpireReservesMaxPickUpDelay in CancelExpiredReserves(). Koha::Hold::set_waiting calculate expiration date from today instead of hold's waiting date. Signed-off-by: Marcel de Rooy -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu May 4 14:23:32 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 04 May 2017 12:23:32 +0000 Subject: [Koha-bugs] [Bug 12063] Change date calculation for reserve expiration to skip all holidays In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12063 --- Comment #84 from Marcel de Rooy --- Created attachment 63098 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=63098&action=edit Bug 12063: [QA Follow-up] Adjustments to db revision Replace use by require. Add require Koha::Calendar (seriously needed to prevent crashing). Base expirationdate on today not on waitingdate (just as in Reserves). Remove if ( waitingdate ) construction. Not needed anymore. Remove $cancel_on_holidays. Not used. Note that the if construction around the new pref is not strictly needed at upgrade time (pref still zero). Fill the dbrev description. Signed-off-by: Marcel de Rooy -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu May 4 14:23:38 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 04 May 2017 12:23:38 +0000 Subject: [Koha-bugs] [Bug 12063] Change date calculation for reserve expiration to skip all holidays In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12063 --- Comment #85 from Marcel de Rooy --- Created attachment 63099 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=63099&action=edit Bug 12063: [QA Follow-up] Small change of two test scripts Removing dbh from one script, changing rollback in the other. Schema is leading now. Signed-off-by: Marcel de Rooy -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu May 4 14:30:31 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 04 May 2017 12:30:31 +0000 Subject: [Koha-bugs] [Bug 12063] Change date calculation for reserve expiration to skip all holidays In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12063 Marcel de Rooy changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA --- Comment #86 from Marcel de Rooy --- Final QA Comment: After a longer process, we reached Passed QA now. Added two small follow-ups. One serious problem in the db rev fixed. Still wanting to mention two points without triggering discussion again: [1] The construction around expirationdate still feels little bit unappropriate to me personally, but after some discussion we found a compromize. [2] The change in Letters.pm is still arguable. Previously, expirationdate was calculated here and could be used on a notice. Now, we do no longer need to calculate it theoretically. But take e.g. the hold slip; the notice is generated before the expiration date is set and therefore still empty. I recommend to have a look at this problem on a new report. I do not consider it as a blocker. Thanks, Alex. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu May 4 14:37:58 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 04 May 2017 12:37:58 +0000 Subject: [Koha-bugs] [Bug 18358] OPAC course reserves don't show not for loan status In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18358 Owen Leonard changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |RESOLVED Resolution|--- |DUPLICATE --- Comment #1 from Owen Leonard --- The original comment is a little too much information, so I'm obsoleting it. The problem *** This bug has been marked as a duplicate of bug 11979 *** -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu May 4 14:37:58 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 04 May 2017 12:37:58 +0000 Subject: [Koha-bugs] [Bug 11979] Display correct not for loan status description on course reserves In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11979 Owen Leonard changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |long_sam.tw at yahoo.com.tw --- Comment #7 from Owen Leonard --- *** Bug 18358 has been marked as a duplicate of this bug. *** -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Thu May 4 15:04:53 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 04 May 2017 13:04:53 +0000 Subject: [Koha-bugs] [Bug 8612] CSV export profile to have custom fields in export csv basket In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8612 Marcel de Rooy changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Failed QA --- Comment #95 from Marcel de Rooy --- I tested with a trival csv: biblio.title | some_text=aqorders.quantity The title is not shown, the quantity is. Have the impression that the regex might still be the cause. What did you test? -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu May 4 15:17:10 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 04 May 2017 13:17:10 +0000 Subject: [Koha-bugs] [Bug 18537] New: Update Ukrainian installer sample files for 17.05 Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18537 Bug ID: 18537 Summary: Update Ukrainian installer sample files for 17.05 Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: minor Priority: P5 - low Component: I18N/L10N Assignee: koha-bugs at lists.koha-community.org Reporter: dubyk at ukr.net QA Contact: testopia at bugs.koha-community.org CC: frederic at tamil.fr Created attachment 63100 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=63100&action=edit Update Ukrainian installer sample files for 17.05 Update and translate sample SQL file of the Ukrainian installer. To test: - Start with an empty database - Install uk-UA - Run the web installer in uk-UA/Ukrainian - Verify all files load without any problems. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Thu May 4 15:17:15 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 04 May 2017 13:17:15 +0000 Subject: [Koha-bugs] [Bug 18538] New: OPAC database user login internal server error Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18538 Bug ID: 18538 Summary: OPAC database user login internal server error Change sponsored?: --- Product: Koha Version: unspecified Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: OPAC Assignee: oleonard at myacpl.org Reporter: lari.taskula at jns.fi QA Contact: testopia at bugs.koha-community.org Reproduce: 1. Go to OPAC 2. Login with the database user 3. Observe Internal Server Error Check your logs: Can't call method "is_debarred" on an undefined value at /home/koha/kohaclone/opac/opac-user.pl line 96. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu May 4 15:17:28 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 04 May 2017 13:17:28 +0000 Subject: [Koha-bugs] [Bug 18538] OPAC database user login internal server error In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18538 Lari Taskula changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|oleonard at myacpl.org |lari.taskula at jns.fi -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu May 4 15:19:05 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 04 May 2017 13:19:05 +0000 Subject: [Koha-bugs] [Bug 7317] Add an Interlibrary Loan Module to Circulation and OPAC In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7317 --- Comment #40 from Magnus Enger --- The patches do apply cleanly, so thanks for that! There is however a problem with userflags. The patches have this: installer/data/mysql/atomicupdate/ill_tables.sql +INSERT INTO userflags (bit,flag,flagdesc,defaulton) +VALUES (21,'ill','The Interlibrary Loans Module',0); But the User Clubs feature have "stolen" number 21. This *is* reflected in installer/data/mysql/userflags.sql: +(22,'ill','The Interlibrary Loans Module',0) -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu May 4 15:20:33 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 04 May 2017 13:20:33 +0000 Subject: [Koha-bugs] [Bug 18538] OPAC database user login internal server error In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18538 Lari Taskula changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff Patch complexity|--- |Trivial patch -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu May 4 15:20:35 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 04 May 2017 13:20:35 +0000 Subject: [Koha-bugs] [Bug 18538] OPAC database user login internal server error In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18538 --- Comment #1 from Lari Taskula --- Created attachment 63101 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=63101&action=edit Bug 18538: OPAC databse user login internal server error Reproduce: 1. Go to OPAC 2. Login with the database user 3. Observe Internal Server Error Check your logs: Can't call method "is_debarred" on an undefined value at /home/koha/kohaclone/opac/opac-user.pl line 96. This patch fixes the mentioned crash. To test: 1. Reproduce the issue with above test plan 2. Apply this patch 3. Go to OPAC 4. Login with the database user 5. Observe successful login -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu May 4 15:24:48 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 04 May 2017 13:24:48 +0000 Subject: [Koha-bugs] [Bug 18179] Koha::Objects->find should not be called in list context In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18179 Marcel de Rooy changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |m.de.rooy at rijksmuseum.nl --- Comment #25 from Marcel de Rooy --- Note: 18361 also adds a subtest find. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu May 4 15:27:47 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 04 May 2017 13:27:47 +0000 Subject: [Koha-bugs] [Bug 18152] UNIMARC bib records imported with invalid 'a' char in label pos.9 In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18152 --- Comment #21 from Jonathan Druart --- I do not understand your last comment. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu May 4 15:38:16 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 04 May 2017 13:38:16 +0000 Subject: [Koha-bugs] [Bug 18152] UNIMARC bib records imported with invalid 'a' char in label pos.9 In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18152 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #63008|0 |1 is obsolete| | Attachment #63040|0 |1 is obsolete| | Attachment #63041|0 |1 is obsolete| | --- Comment #22 from Jonathan Druart --- Created attachment 63102 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=63102&action=edit Bug 18152 : fix unimarc label in SetMarcUnicodeFlag The standard UNIMARC requires than the 9th character (starting from 0) in labels must be blank (while it may be 'a' in marc21) the problem is that C4::Charset::SetMarcUnicodeFlag (called in particular when we import a record) always add 'a' char in the 9th label'pos whereas it should do it just for MARC21 and NORMARC (not for UNIMARC) : C4::Charset::SetMarcUnicodeFlag add 'a' char in the 9th label character for MARC21 and NORMARC (it's normal), but just before doing this it call "$marc_record->encoding('UTF-8')" which is a MARC::Record function which, when called with 'UTF-8' parameter, do only one thing : add 'a' char in the 9th label character This patch only removes this incorrect function call, so, when we import a bib record in UNIMARC : it no longer adds erroneous character (this does not change anything for MARC21 and NORMARC because SetMarcUnicodeFlag explicitly adds 'a' char in the 9th label for them) Signed-off-by: Alex Buckley Signed-off-by: Jonathan Druart -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu May 4 15:38:20 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 04 May 2017 13:38:20 +0000 Subject: [Koha-bugs] [Bug 18152] UNIMARC bib records imported with invalid 'a' char in label pos.9 In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18152 --- Comment #23 from Jonathan Druart --- Created attachment 63103 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=63103&action=edit Bug 18152: Add tests Signed-off-by: Jonathan Druart -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu May 4 15:38:13 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 04 May 2017 13:38:13 +0000 Subject: [Koha-bugs] [Bug 18152] UNIMARC bib records imported with invalid 'a' char in label pos.9 In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18152 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu May 4 15:39:04 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 04 May 2017 13:39:04 +0000 Subject: [Koha-bugs] [Bug 8612] CSV export profile to have custom fields in export csv basket In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8612 Philippe Audet-Fortin changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #63056|0 |1 is obsolete| | --- Comment #96 from Philippe Audet-Fortin --- Created attachment 63104 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=63104&action=edit Bug 8612: QA followup - expand tests Test plan: prove t/db_dependent/Acquisition/GetBasketAsCSV.t -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu May 4 15:41:18 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 04 May 2017 13:41:18 +0000 Subject: [Koha-bugs] [Bug 18179] Koha::Objects->find should not be called in list context In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18179 --- Comment #26 from Marcel de Rooy --- Same include: [%- IF borrower.category.category_type == 'I' %] [%- IF category_type == 'I' %] I am having the feeling that it should be borrower.category_type when I am looking at GetMember. Note that this change in the last patch could be considered out of scope here.. Also wondering about this hardcoded category too. I do not see in the sample patron categories. Please explain. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu May 4 15:41:27 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 04 May 2017 13:41:27 +0000 Subject: [Koha-bugs] [Bug 18152] UNIMARC bib records imported with invalid 'a' char in label pos.9 In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18152 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA --- Comment #24 from Jonathan Druart --- Seen with St?phane: It does not make really sense to modify position 9 of leader for UNIMARC records in SetMarcUnicodeFlag, this flag is not related to encoding. I have opened bug 18533 to remove the MARC::Record->encoding calls everywhere and replace them with SetMarcUnicodeFlag. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu May 4 15:48:22 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 04 May 2017 13:48:22 +0000 Subject: [Koha-bugs] [Bug 18179] Koha::Objects->find should not be called in list context In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18179 --- Comment #27 from Marcel de Rooy --- Jonathan: If you move the first patch somewhere else and remove the category change, please update to Passed QA. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu May 4 16:04:18 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 04 May 2017 14:04:18 +0000 Subject: [Koha-bugs] [Bug 13913] Renewal error message in OPAC is confusing In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13913 Owen Leonard changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff Patch complexity|--- |Trivial patch -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu May 4 16:04:22 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 04 May 2017 14:04:22 +0000 Subject: [Koha-bugs] [Bug 13913] Renewal error message in OPAC is confusing In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13913 --- Comment #3 from Owen Leonard --- Created attachment 63105 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=63105&action=edit Bug 13913 - Renewal error message in OPAC is confusing This patch adds some formatting to the error message a patron receives when there are renewal failures in the OPAC. This is pretty much the least which could be done to address this problem. However, I don't think the issue can be fixed without re-thinking how renewals are processed. Sending error messages back to opac-user.pl via URL parameter isn't flexible enough. To test, apply the patch and attempt to renew multiple items in the OPAC which cannot be renewed for some reason, for instance because they have been renewed too many times. The error messages should appear in a list rather than strung together in one long block of text. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu May 4 16:04:28 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 04 May 2017 14:04:28 +0000 Subject: [Koha-bugs] [Bug 18179] Koha::Objects->find should not be called in list context In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18179 --- Comment #28 from Jonathan Druart --- (In reply to Marcel de Rooy from comment #26) > Same include: > > [%- IF borrower.category.category_type == 'I' %] > > [%- IF category_type == 'I' %] > > I am having the feeling that it should be borrower.category_type when I am > looking at GetMember. Yes, right. I found 3 occurrences where borrower is passed to the template: members/pay.pl: borrower => $borrower, members/paycollect.pl: borrower => $borrower, members/routing-lists.pl: borrower => $borrower, $borrower comes from GetMember. And from 1 members/moremember.pl (Koha::Patron) So the change does not make sense. But it's a regression of bug 12461, should be fixed elsewhere. Please have a look at bug 17829 to get rid of all these issues!! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu May 4 16:05:20 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 04 May 2017 14:05:20 +0000 Subject: [Koha-bugs] [Bug 13913] Renewal error message in OPAC is confusing In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13913 --- Comment #4 from Owen Leonard --- I do NOT think my patch fixes this problem. It simply addresses a cosmetic issue and improves the situation until a real fix is made. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu May 4 16:06:28 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 04 May 2017 14:06:28 +0000 Subject: [Koha-bugs] [Bug 18179] Koha::Objects->find should not be called in list context In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18179 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #62879|0 |1 is obsolete| | Attachment #62880|0 |1 is obsolete| | --- Comment #29 from Jonathan Druart --- Created attachment 63106 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=63106&action=edit Bug 18179: Update existing calls This patch updates the existing occurrences of ->find called in a list context. There are certainly others that are not easy to catch with git grep. Test plan: Confirm that the 4 modified scripts still works as expected. We need this one ASAP in master to make sure we will not get other side-effects of this kind and to catch possible uncaught occurrences before the release. Tested scripts changed by this patch, they work as expected. Signed-off-by: Marc V?ron Signed-off-by: Nick Clemens Signed-off-by: Jonathan Druart bsoletes: 62657 - Bug 18179: Update existing calls -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu May 4 16:06:34 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 04 May 2017 14:06:34 +0000 Subject: [Koha-bugs] [Bug 18179] Koha::Objects->find should not be called in list context In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18179 --- Comment #30 from Jonathan Druart --- Created attachment 63107 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=63107&action=edit Bug 18179: Update 1 occurrence in booksellers.pl To test: 1 - Load http://localhost:8081/cgi-bin/koha/acqui/booksellers.pl?booksellerid=1 2 - Should get internal server erro 3 - Apply patch 4 - Reload 5 - Should not get error Signed-off-by: Jonathan Druart -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu May 4 16:06:22 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 04 May 2017 14:06:22 +0000 Subject: [Koha-bugs] [Bug 18179] Koha::Objects->find should not be called in list context In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18179 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu May 4 16:06:38 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 04 May 2017 14:06:38 +0000 Subject: [Koha-bugs] [Bug 18179] Koha::Objects->find should not be called in list context In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18179 --- Comment #31 from Jonathan Druart --- Created attachment 63108 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=63108&action=edit Bug 18179: Update 1 occurrence in moremember.pl Cannot use "->find" in list context at /home/vagrant/kohaclone/members/moremember.pl line 334. Test Plan: 1) Got to moremember.pl, note error 2) Apply this patch 3) Refresh page, no error! Signed-off-by: Jonathan Druart -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu May 4 16:06:43 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 04 May 2017 14:06:43 +0000 Subject: [Koha-bugs] [Bug 18179] Koha::Objects->find should not be called in list context In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18179 --- Comment #32 from Jonathan Druart --- Created attachment 63109 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=63109&action=edit Bug 18179: Use borrower.category_type in patron-title.inc I found 3 occurrences where borrower is passed to the template: members/pay.pl: borrower => $borrower, members/paycollect.pl: borrower => $borrower, members/routing-lists.pl: borrower => $borrower, $borrower comes from GetMember. And from 1 members/moremember.pl (Koha::Patron) So the change does not make sense. But it's a regression of bug 12461, should be fixed elsewhere. Signed-off-by: Jonathan Druart -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu May 4 16:07:26 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 04 May 2017 14:07:26 +0000 Subject: [Koha-bugs] [Bug 18162] Don't translate JSON keys In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18162 Owen Leonard changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|oleonard at myacpl.org |koha-bugs at lists.koha-commun | |ity.org CC| |frederic at tamil.fr Component|Templates |I18N/L10N -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu May 4 16:08:39 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 04 May 2017 14:08:39 +0000 Subject: [Koha-bugs] [Bug 18539] New: Forbid Koha::Objects->find calls in list context Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18539 Bug ID: 18539 Summary: Forbid Koha::Objects->find calls in list context Change sponsored?: --- Product: Koha Version: unspecified Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Architecture, internals, and plumbing Assignee: gmcharlt at gmail.com Reporter: jonathan.druart at bugs.koha-community.org QA Contact: testopia at bugs.koha-community.org See bug 18179 for more info. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu May 4 16:09:06 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 04 May 2017 14:09:06 +0000 Subject: [Koha-bugs] [Bug 18539] Forbid Koha::Objects->find calls in list context In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18539 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|gmcharlt at gmail.com |jonathan.druart at bugs.koha-c | |ommunity.org Status|NEW |ASSIGNED -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu May 4 16:09:27 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 04 May 2017 14:09:27 +0000 Subject: [Koha-bugs] [Bug 18179] Koha::Objects->find should not be called in list context In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18179 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #62656|0 |1 is obsolete| | --- Comment #33 from Jonathan Druart --- Comment on attachment 62656 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=62656 Bug 18179: Forbid list context calls for Koha::Objects->find See bug 18539 for this patch -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu May 4 16:09:38 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 04 May 2017 14:09:38 +0000 Subject: [Koha-bugs] [Bug 18179] Koha::Objects->find should not be called in list context In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18179 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |18539 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18539 [Bug 18539] Forbid Koha::Objects->find calls in list context -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu May 4 16:09:38 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 04 May 2017 14:09:38 +0000 Subject: [Koha-bugs] [Bug 18539] Forbid Koha::Objects->find calls in list context In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18539 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on| |18179 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18179 [Bug 18179] Koha::Objects->find should not be called in list context -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu May 4 16:09:59 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 04 May 2017 14:09:59 +0000 Subject: [Koha-bugs] [Bug 18179] Koha::Objects->find should not be called in list context In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18179 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #62657|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu May 4 16:11:20 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 04 May 2017 14:11:20 +0000 Subject: [Koha-bugs] [Bug 18539] Forbid Koha::Objects->find calls in list context In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18539 --- Comment #1 from Jonathan Druart --- Created attachment 63110 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=63110&action=edit Bug 18539: Forbid list context calls for Koha::Objects->find Reading https://perlmaven.com/how-to-return-undef-from-a-function this sound like the more correct behaviour. Considering: $template->param( stuff => Koha::Stuffs->find( $id ), foo => 1, ); without this patch, if the $id does not represent any rows in the DB, stuff will be assigned to 'foo' and $foo will be undef in the template. That can lead to very bad side-effects. With this patch we make sure that it will never happen again. Test plan: prove t/db_dependent/Koha/Objects.t should return green Signed-off-by: Marc V?ron Signed-off-by: Nick Clemens -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu May 4 16:11:36 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 04 May 2017 14:11:36 +0000 Subject: [Koha-bugs] [Bug 18539] Forbid Koha::Objects->find calls in list context In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18539 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu May 4 16:11:44 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 04 May 2017 14:11:44 +0000 Subject: [Koha-bugs] [Bug 18539] Forbid Koha::Objects->find calls in list context In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18539 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu May 4 16:11:46 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 04 May 2017 14:11:46 +0000 Subject: [Koha-bugs] [Bug 8612] CSV export profile to have custom fields in export csv basket In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8612 --- Comment #97 from Philippe Audet-Fortin --- (In reply to Marcel de Rooy from comment #95) > I tested with a trival csv: > biblio.title | some_text=aqorders.quantity > > The title is not shown, the quantity is. Have the impression that the regex > might still be the cause. > What did you test? I copy paste your csv and I got some blank fields too. I try by removing white spaces and it worked. (I had not seen your comment and I signoff too early. Sorry.) -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu May 4 16:17:25 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 04 May 2017 14:17:25 +0000 Subject: [Koha-bugs] [Bug 18295] C4::Items - Remove get_itemnumbers_of In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18295 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Patch doesn't apply |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu May 4 16:17:10 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 04 May 2017 14:17:10 +0000 Subject: [Koha-bugs] [Bug 18295] C4::Items - Remove get_itemnumbers_of In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18295 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #61225|0 |1 is obsolete| | --- Comment #4 from Jonathan Druart --- Created attachment 63111 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=63111&action=edit Bug 18295: C4::Items - get_itemnumbers_of The code from scripts and subroutines using this subroutine was not very elegant. Most of the time the code was unnecessarily complex. This patch removes this subroutine and adapt the code to use Koha::Items instead. 1. C4::Items::get_hostitemnumbers_of I did not understand why the code was so complicated, it seems that we only want to know if a given item has a given biblionumber 2. cataloguing/merge.pl We want to retrieve the itemnumber for a given biblio. We could also have done that with: Koha::Biblios->find( $biblionumber )->items; 3. labels/label-item-search.pl We want to loop over the items for a given biblio, no need to use get_itemnumbers_of and GetItemInfosOf. We just need to use: Koha::Items->search({ biblionumber => $biblionumber }) 4. reserve/request.pl We want to retrieve the itemnumbers of the biblio's items We could also have done that with: Koha::Biblios->find( $biblionumber )->items->get_column('itemnumber'); Test plan: 1.You need to create analytical record relationships ( EasyAnalyticalRecords needs to be set). Link an item to a biblio using the 'Edit > Link to host item' menu from the biblio detail page. >From the staff interface place a hold on the biblio. You should see the items from the biblio and the one you just linked 2. Merge two bibliographic records (with items), the resulting record should contain items from both original records 3. Create a new label batch, edit it. Add items to this batch ('Add items' button). Fill the input with a barcode. You should see all the items of a biblio. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu May 4 16:21:05 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 04 May 2017 14:21:05 +0000 Subject: [Koha-bugs] [Bug 18540] New: koha-indexdefs-to-zebra.xsl introduces MARC21 stuff into UNIMARC xslts Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18540 Bug ID: 18540 Summary: koha-indexdefs-to-zebra.xsl introduces MARC21 stuff into UNIMARC xslts Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: normal Priority: P5 - low Component: Architecture, internals, and plumbing Assignee: gmcharlt at gmail.com Reporter: tomascohen at gmail.com QA Contact: testopia at bugs.koha-community.org Bug 14332 introduced troubles because the koha-indexdefs-to-zebra.xsl is by no means MARC21-only or even biblio-only. To reproduce: - On current master, run: $ xsltproc etc/zebradb/xsl/koha-indexdefs-to-zebra.xsl etc/zebradb/marc_defs/unimarc/biblios/biblio-koha-indexdefs.xml > etc/zebradb/marc_defs/unimarc/biblios/biblio-zebra-indexdefs.xsl - Run: $ git diff => FAIL: The following is added to etc/zebradb/marc_defs/unimarc/biblios/biblio-zebra-indexdefs.xsl, thus UNIMARC field 245 is being sent to the Title index @@ -42,6 +43,7 @@ definition file (probably something like {biblio,authority}-koha-indexdefs.xml) + @@ -2681,6 +2683,19 @@ definition file (probably something like {biblio,authority}-koha-indexdefs.xml) + + + + 0 + + + + + + + + + -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu May 4 16:21:19 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 04 May 2017 14:21:19 +0000 Subject: [Koha-bugs] [Bug 18540] koha-indexdefs-to-zebra.xsl introduces MARC21 stuff into UNIMARC xslts In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18540 Tom?s Cohen Arazi changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on| |14332 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14332 [Bug 14332] Skip title articles on Opac using ind2 of tag 245 (MARC21 only) -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu May 4 16:21:19 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 04 May 2017 14:21:19 +0000 Subject: [Koha-bugs] [Bug 14332] Skip title articles on Opac using ind2 of tag 245 (MARC21 only ) In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14332 Tom?s Cohen Arazi changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |18540 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18540 [Bug 18540] koha-indexdefs-to-zebra.xsl introduces MARC21 stuff into UNIMARC xslts -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu May 4 16:27:04 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 04 May 2017 14:27:04 +0000 Subject: [Koha-bugs] [Bug 18098] Add an index with the count of not onloan items In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18098 Tom?s Cohen Arazi changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #60859|0 |1 is obsolete| | --- Comment #7 from Tom?s Cohen Arazi --- Created attachment 63112 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=63112&action=edit Bug 18098: Add an index with the count of not onloan items This patch adds a numeric index 'not-onloan-count' containing the value of 999$x. This subfield is filled by 'rebuild_zebra.pl' by making use of (bug's 18208) 'EmbedItemsAvailability' filter. bib1.att and indexes definitions are updated accordingly. To test: - Apply the patch - Pick the right biblio-zebra-indexdefs.xsl file for your setup and replace the one your Zebra uses [1] - Replace your bib1.att - Replace your ccl.properties - Have at least one record with more than one item, checkout some item(s) from that record(s). - Rebuild zebra's indexes: $ sudo koha-shell kohadev k$ cd kohaclone k$ misc/migration_tools/rebuild_zebra.pl -r -b -v -k (notice the dump directory is kept, you can try the XSLT yourself running: $ xsltproc \ etc/zebradb/marc_defs/marc21/biblios/biblio-zebra-indexdefs.xsl \ /tmp/the_dump_dir/biblios/exported_records | less => SUCCESS: There are records with the not-onloan-count index, and the value is correct! - Check Zebra yourself: $ yaz-client unix:/var/run/koha/kohadev/bibliosocket Z> base biblios Z> find @attr 1=9013 @attr 2=5 @attr 4=109 0 => SUCCESS: The search matches the amount of records with not-onloan items. Z> s 1+1 => SUCCESS: Records with 999$x having a value higher than 0 are rendered - Sign off :-D Note: While this work is complete on its purpose, it is part of an attempt to create a better way of filtering by availability. Sponsored-by: ByWater Solutions [1] In kohadevbox this would be /etc/koha/zebradb/marc_defs/marc21/biblios/biblio-zebra-indexdefs.xsl Edit: Added the missing XSLT changes for UNIMARC and NORMARC Signed-off-by: Josef Moravec Signed-off-by: Tomas Cohen Arazi Signed-off-by: Marcel de Rooy -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu May 4 16:27:17 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 04 May 2017 14:27:17 +0000 Subject: [Koha-bugs] [Bug 18120] REST API: CRUD endpoint for vendors In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18120 --- Comment #6 from Matthias Meusburger --- The last patch "Bug 18120: (followup) Make operationId unique" breaks the tests. Without the last patch, I've tested the endpoint and ran the tests successfully. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu May 4 16:27:21 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 04 May 2017 14:27:21 +0000 Subject: [Koha-bugs] [Bug 18098] Add an index with the count of not onloan items In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18098 Tom?s Cohen Arazi changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |Passed QA -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu May 4 16:27:43 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 04 May 2017 14:27:43 +0000 Subject: [Koha-bugs] [Bug 7317] Add an Interlibrary Loan Module to Circulation and OPAC In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7317 --- Comment #41 from Alex Sassmannshausen --- Created attachment 63113 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=63113&action=edit Bug 7317: Followup: Update atomicupdate file. * installer/data/mysql/atomicupdate/ill_tables.sql: Set ILL permission id to 22. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu May 4 16:28:31 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 04 May 2017 14:28:31 +0000 Subject: [Koha-bugs] [Bug 7317] Add an Interlibrary Loan Module to Circulation and OPAC In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7317 --- Comment #42 from Alex Sassmannshausen --- (In reply to Magnus Enger from comment #40) > The patches do apply cleanly, so thanks for that! There is however a problem > with userflags. The patches have this: > > installer/data/mysql/atomicupdate/ill_tables.sql > +INSERT INTO userflags (bit,flag,flagdesc,defaulton) > +VALUES (21,'ill','The Interlibrary Loans Module',0); > > But the User Clubs feature have "stolen" number 21. This *is* reflected in > installer/data/mysql/userflags.sql: > > +(22,'ill','The Interlibrary Loans Module',0) You are quite right! Thanks for pointing that out ? that should now be fixed. Alex -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu May 4 16:31:15 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 04 May 2017 14:31:15 +0000 Subject: [Koha-bugs] [Bug 11897] Stock Rotation for Koha In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11897 --- Comment #99 from Alex Sassmannshausen --- Created attachment 63114 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=63114&action=edit Bug 11897: Follow up: Update userflags/permission id. * installer/data/mysql/atomicupdate/stockrot_tables.sql: Set the ID for permissions and userflags to 22. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu May 4 16:35:45 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 04 May 2017 14:35:45 +0000 Subject: [Koha-bugs] [Bug 17936] Search bar not aligned on right in small screen sizes In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17936 Owen Leonard changed: What |Removed |Added ---------------------------------------------------------------------------- Patch complexity|--- |Trivial patch Status|NEW |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu May 4 16:35:48 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 04 May 2017 14:35:48 +0000 Subject: [Koha-bugs] [Bug 17936] Search bar not aligned on right in small screen sizes In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17936 --- Comment #1 from Owen Leonard --- Created attachment 63115 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=63115&action=edit Bug 17936 - Search bar not aligned on right in small screen sizes This patch tweaks the OPAC's CSS so that the main search form's fields have consistent width at small screen sizes. To test, apply the patch and process the LESS files. View the OPAC main page at a very narrow browser width and confirm that the text field width matches that of the dropdown and button. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu May 4 16:35:51 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 04 May 2017 14:35:51 +0000 Subject: [Koha-bugs] [Bug 17936] Search bar not aligned on right in small screen sizes In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17936 --- Comment #2 from Owen Leonard --- Created attachment 63116 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=63116&action=edit Bug 17936 [Generated CSS] Search bar not aligned on right in small screen sizes Processed and minified CSS. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu May 4 16:39:32 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 04 May 2017 14:39:32 +0000 Subject: [Koha-bugs] [Bug 17936] Search bar not aligned on right in small screen sizes In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17936 Owen Leonard changed: What |Removed |Added ---------------------------------------------------------------------------- OS|Linux |All Version|16.05 |master -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu May 4 16:59:10 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 04 May 2017 14:59:10 +0000 Subject: [Koha-bugs] [Bug 16892] Add automatic patron registration via OAuth2 login In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16892 Nick Clemens changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #61886|0 |1 is obsolete| | Attachment #61887|0 |1 is obsolete| | Attachment #61888|0 |1 is obsolete| | Attachment #61889|0 |1 is obsolete| | --- Comment #37 from Nick Clemens --- Created attachment 63117 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=63117&action=edit Bug 16892: Add automatic patron registration via OAuth2 login 10988 added the ability to log into the OPAC authenticating with Google Open ID Connect. This extends it, by allowing an unregistered patron to have an account automatically created with default category code and branch. This is accomplished by adding 3 system preferences. - GoogleOpenIDConnectAutoRegister whether it will attempt to auto-register the patron. - GoogleOpenIDConnectDefaultCategory This category code will be used to create Google OpenID Connect patrons. - GoogleOpenIDConnectDefaultBranch' This branch code will be used to create Google OpenID Connect patrons. Sponsored-by: Tulong Aklatan Signed-off-by: Eugene Jose Espinoza Signed-off-by: Nick Clemens -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu May 4 16:59:15 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 04 May 2017 14:59:15 +0000 Subject: [Koha-bugs] [Bug 16892] Add automatic patron registration via OAuth2 login In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16892 --- Comment #38 from Nick Clemens --- Created attachment 63118 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=63118&action=edit Bug 16892: System Preferences This adds the missing system preferences for a fresh install. Signed-off-by: Eugene Jose Espinoza Signed-off-by: Nick Clemens -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu May 4 16:59:19 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 04 May 2017 14:59:19 +0000 Subject: [Koha-bugs] [Bug 16892] Add automatic patron registration via OAuth2 login In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16892 --- Comment #39 from Nick Clemens --- Created attachment 63119 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=63119&action=edit Bug 16892: Follow up with adding missing IGNORE Signed-off-by: Eugene Jose Espinoza Signed-off-by: Nick Clemens -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu May 4 16:59:23 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 04 May 2017 14:59:23 +0000 Subject: [Koha-bugs] [Bug 16892] Add automatic patron registration via OAuth2 login In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16892 --- Comment #40 from Nick Clemens --- Created attachment 63120 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=63120&action=edit Bug 16892: Follow up use AddMember as per QA comment Same Test plan as before. Signed-off-by: Eugene Jose Espinoza Signed-off-by: Nick Clemens -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu May 4 17:02:18 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 04 May 2017 15:02:18 +0000 Subject: [Koha-bugs] [Bug 16892] Add automatic patron registration via OAuth2 login In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16892 --- Comment #41 from Nick Clemens --- Tested with new instrcutions, works as advertised, the code looks good to me I tested under plack/memcached and saw no difference when I removed the find for borrower so think that can be safely removed. One question, out of scope: For CAS we have casLogout - can we have something similar here? I think disconcerting if a patron signs in via google, signs out of Koha and walks away leaving their google auth intact unintentionally Leaving at SO for final comments from Jonathan -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu May 4 17:06:50 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 04 May 2017 15:06:50 +0000 Subject: [Koha-bugs] [Bug 18535] Clicking 'edit printer profile' in label creator causes software error In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18535 Nick Clemens changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on| |17900 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu May 4 17:08:49 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 04 May 2017 15:08:49 +0000 Subject: [Koha-bugs] [Bug 18276] Koha::Biblio - Remove GetBiblioFromItemNumber In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18276 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu May 4 17:09:01 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 04 May 2017 15:09:01 +0000 Subject: [Koha-bugs] [Bug 18276] Koha::Biblio - Remove GetBiblioFromItemNumber In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18276 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #62476|0 |1 is obsolete| | Attachment #62477|0 |1 is obsolete| | Attachment #62478|0 |1 is obsolete| | Attachment #62479|0 |1 is obsolete| | Attachment #62480|0 |1 is obsolete| | Attachment #62481|0 |1 is obsolete| | --- Comment #29 from Jonathan Druart --- Created attachment 63121 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=63121&action=edit Bug 18276: Remove GetBiblioFromItemNumber - Course reserves Values from the items, biblio and biblioitems tables are used in the template, so we need to pass all of them to the template, but separately. That way we easily see which field from which table we are displaying. Test plan: Create a course reserve and add items. Correct information must be displayed on the detail page of the course reserve, on staff and OPAC interface. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu May 4 17:09:12 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 04 May 2017 15:09:12 +0000 Subject: [Koha-bugs] [Bug 18276] Koha::Biblio - Remove GetBiblioFromItemNumber In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18276 --- Comment #30 from Jonathan Druart --- Created attachment 63122 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=63122&action=edit Bug 18276: Remove GetBiblioFromItemNumber - ILSDI Test plan: Hit /cgi-bin/koha/ilsdi.pl?service=GetPatronInfo&patron_id=51&show_holds=1 The results should be the same before and after this patch -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu May 4 17:09:20 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 04 May 2017 15:09:20 +0000 Subject: [Koha-bugs] [Bug 18276] Koha::Biblio - Remove GetBiblioFromItemNumber In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18276 --- Comment #31 from Jonathan Druart --- Created attachment 63123 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=63123&action=edit Bug 18276: Remove GetBiblioFromItemNumber - circulation pages Test plan: 1. Checkout items in a batch The information displayed should be ok (title, subtitles, author, itemnotes, barcode) 2. Checkout an item using the standard checkout page You should correctly see the information of the item that has been checked out (title and author) -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu May 4 17:09:29 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 04 May 2017 15:09:29 +0000 Subject: [Koha-bugs] [Bug 18276] Koha::Biblio - Remove GetBiblioFromItemNumber In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18276 --- Comment #32 from Jonathan Druart --- Created attachment 63124 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=63124&action=edit Bug 18276: Remove GetBiblioFromItemNumber - Easy ones The subroutine C4::Biblio::GetBiblioFromItemNumber was wrong for several reasons: - badly named, we can get biblio info from a barcode - SELECT * from items, biblio and biblioitems makes things hard to follow and debug, we never know where do come from the value we display - sometimes called only for trivial information such as biblionumber, author or title This patchset suggests to replace it with calls to: - Koha::Items->find for item's info - $item->biblio for biblio's info - $item->biblio->biblioitem for biblioitem's info Test plan: Item's info should correctly be displayed on the following pages: - circulation history - transfer book - checkin - waiting holds QA will check the other changes reading the code, it's trivial -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu May 4 17:09:37 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 04 May 2017 15:09:37 +0000 Subject: [Koha-bugs] [Bug 18276] Koha::Biblio - Remove GetBiblioFromItemNumber In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18276 --- Comment #33 from Jonathan Druart --- Created attachment 63125 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=63125&action=edit Bug 18276: Remove the C4::Biblio::GetBiblioFromItemNumber subroutine -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu May 4 17:09:44 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 04 May 2017 15:09:44 +0000 Subject: [Koha-bugs] [Bug 18276] Koha::Biblio - Remove GetBiblioFromItemNumber In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18276 --- Comment #34 from Jonathan Druart --- Created attachment 63126 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=63126&action=edit Bug 18276: FIX status display for course reserves This include file is terribly wrong, it's called from different places that do not set the same flag. The status from detail and result page might be different from the one display on the course reserve table. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu May 4 17:10:49 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 04 May 2017 15:10:49 +0000 Subject: [Koha-bugs] [Bug 18276] Koha::Biblio - Remove GetBiblioFromItemNumber In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18276 --- Comment #35 from Jonathan Druart --- I would suggest to not make this change a priority for 17.05 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu May 4 17:29:10 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 04 May 2017 15:29:10 +0000 Subject: [Koha-bugs] [Bug 17944] Remove the sql code from itemtypes.pl administrative perl script In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17944 --- Comment #42 from Jonathan Druart --- Alex, Some additional remarks (we are aiming the perfect patch, right? :)) 1. The POD of the new method is incorrect, please adapt it. Note that a line should not be longer than 80 chars 2. The method can_be_deleted should be something like: sub can_be_deleted { my ($self) = @_; my $nb_items = Koha::Items->search( { itype => $self->itemtype } )->count; my $nb_biblioitems = Koha::Biblioitems->search( { itemtype => $self->itemtype } )->count; return $nb_items + $nb_biblioitems == 0; } $self is the current object, from this object you know the itemtype (code), so you so not need to pass it as an argument. 3. The tests are wrong: I have a biblio with biblionumber=1, so they fail (Duplicate entry '1' for key 'PRIMARY'). You need to use our TestBuilder module to generate random data. What you want is: a) Generate the $builder object: my $builder = t::lib::TestBuilder->new; b) create an item type: my $item_type = $builder->build_object({ class => 'Koha::ItemTypes' }); c) you want to test if an item type, not used, can be removed. It's time! is( $item_type->can_be_deleted, 1, 'An item type that is not used can be deleted' ); d) create an item using this item type: my $item = $builder->build_object({ class => 'Koha::Items', value => { itype => $item_type->itemtype }); e) Then you want to know if the item type can be removed is( $item_type->can_be_deleted, 0, 'An item type that is used by an item cannot be deleted ); Then you can continue with a biblioitem object. Please resubmit a patch without the delete method, just can_be_deleted step-by-step :) -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu May 4 17:29:51 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 04 May 2017 15:29:51 +0000 Subject: [Koha-bugs] [Bug 18541] New: Bug 18465 - Patron card creator: Add a grid to support layout design Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18541 Bug ID: 18541 Summary: Bug 18465 - Patron card creator: Add a grid to support layout design Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Label/patron card printing Assignee: cnighswonger at foundations.edu Reporter: veron at veron.ch QA Contact: testopia at bugs.koha-community.org In patron card creator, the layout tool has already a guide box that shows the position of a card on the page. The aim of this enhancement is to support the design process with an additonal layout grid to figure out the positions of text fields, barcode and images. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu May 4 17:30:14 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 04 May 2017 15:30:14 +0000 Subject: [Koha-bugs] [Bug 18541] Patron card creator: Add a grid to support layout design In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18541 Marc V?ron changed: What |Removed |Added ---------------------------------------------------------------------------- Summary|Bug 18465 - Patron card |Patron card creator: Add a |creator: Add a grid to |grid to support layout |support layout design |design -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu May 4 17:32:51 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 04 May 2017 15:32:51 +0000 Subject: [Koha-bugs] [Bug 17944] Remove the sql code from itemtypes.pl administrative perl script In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17944 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Failed QA -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu May 4 17:38:54 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 04 May 2017 15:38:54 +0000 Subject: [Koha-bugs] [Bug 18541] Patron card creator: Add a grid to support layout design In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18541 --- Comment #1 from Marc V?ron --- Created attachment 63127 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=63127&action=edit Bug 18541 - Patron card creator: Add a grid to support layout design Add a layout grid to patron card creator to figure out the positions of text fields, barcode and images. First draft, not ready to sign off. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu May 4 17:39:02 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 04 May 2017 15:39:02 +0000 Subject: [Koha-bugs] [Bug 16515] Did you mean? links don't wrap on smaller screens In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16515 Owen Leonard changed: What |Removed |Added ---------------------------------------------------------------------------- Patch complexity|--- |Trivial patch Status|NEW |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu May 4 17:39:05 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 04 May 2017 15:39:05 +0000 Subject: [Koha-bugs] [Bug 16515] Did you mean? links don't wrap on smaller screens In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16515 --- Comment #5 from Owen Leonard --- Created attachment 63128 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=63128&action=edit Bug 16515 - Did you mean? links don't wrap on smaller screens This patch tweaks some CSS in the OPAC to give the "Did you mean" block better layout on smaller screens. To test, apply the patch and process LESS files. Enable "Did you mean" plugins for the OPAC in Administration. Perform a search in the OPAC and confirm that the "Did you mean" block looks correct. Resize your browser to various widths and confirm that the block handles all sizes well. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu May 4 17:39:08 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 04 May 2017 15:39:08 +0000 Subject: [Koha-bugs] [Bug 16515] Did you mean? links don't wrap on smaller screens In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16515 --- Comment #6 from Owen Leonard --- Created attachment 63129 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=63129&action=edit Bug 16515 [Generated CSS] Did you mean? links don't wrap on smaller screens Processed and minified CSS. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu May 4 17:50:02 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 04 May 2017 15:50:02 +0000 Subject: [Koha-bugs] [Bug 18541] Patron card creator: Add a grid to support layout design In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18541 Marc V?ron changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #63127|0 |1 is obsolete| | --- Comment #2 from Marc V?ron --- Created attachment 63130 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=63130&action=edit Bug 18541 - Patron card creator: Add a grid to support layout design Add a layout grid to patron card creator to figure out the positions of text fields, barcode and images. Amended to apply on top of bug 18465 Draft, not ready to sign off. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu May 4 17:50:41 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 04 May 2017 15:50:41 +0000 Subject: [Koha-bugs] [Bug 18541] Patron card creator: Add a grid to support layout design In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18541 Marc V?ron changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|cnighswonger at foundations.ed |veron at veron.ch |u | Depends on| |18465 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18465 [Bug 18465] Patron card creator: Print on duplex card printer -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu May 4 17:50:41 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 04 May 2017 15:50:41 +0000 Subject: [Koha-bugs] [Bug 18465] Patron card creator: Print on duplex card printer In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18465 Marc V?ron changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |18541 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18541 [Bug 18541] Patron card creator: Add a grid to support layout design -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu May 4 18:06:12 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 04 May 2017 16:06:12 +0000 Subject: [Koha-bugs] [Bug 18535] Clicking 'edit printer profile' in label creator causes software error In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18535 Marc V?ron changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #63044|0 |1 is obsolete| | --- Comment #2 from Marc V?ron --- Created attachment 63131 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=63131&action=edit Bug 18535 - Clicking 'edit printer profile' in label creator causes software error 1) Go to Tools > Label creator 2) If you don't have a printer profile defined, create one. 3) Go to manage > Printer profiles 4) Click the 'edit' button on any of the profiles. 5) INTERNAL SERVER ERROR! "Can't use string ("fields") as a HASH ref while "strict refs" in use at /usr/share/koha/lib/C4/Creators/Lib.pm line 147" 6) Apply patch 7) Click the 'edit' button on any of the profiles. 8) Things work as expected Bug reproduced, is fixed by this patch Signed-off-by: Marc V?ron -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu May 4 18:06:11 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 04 May 2017 16:06:11 +0000 Subject: [Koha-bugs] [Bug 18458] Merging authority record incorrectly orders subfields In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18458 Marjorie Barry-Vila changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |marjorie.barry-vila at ccsr.qc | |.ca -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu May 4 18:06:56 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 04 May 2017 16:06:56 +0000 Subject: [Koha-bugs] [Bug 18535] Clicking 'edit printer profile' in label creator causes software error In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18535 Marc V?ron changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |veron at veron.ch Patch complexity|--- |Trivial patch Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu May 4 18:12:54 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 04 May 2017 16:12:54 +0000 Subject: [Koha-bugs] [Bug 16503] Label creator: grouping fields with quotes does not work in layout creator In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16503 Dennis Hohmann changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |dennis at dennishohmann.de -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu May 4 18:15:46 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 04 May 2017 16:15:46 +0000 Subject: [Koha-bugs] [Bug 17936] Search bar not aligned on right in small screen sizes In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17936 Marc V?ron changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #63115|0 |1 is obsolete| | --- Comment #3 from Marc V?ron --- Created attachment 63132 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=63132&action=edit Bug 17936 - Search bar not aligned on right in small screen sizes This patch tweaks the OPAC's CSS so that the main search form's fields have consistent width at small screen sizes. To test, apply the patch and process the LESS files. View the OPAC main page at a very narrow browser width and confirm that the text field width matches that of the dropdown and button. Signed-off-by: Marc V?ron -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu May 4 18:16:37 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 04 May 2017 16:16:37 +0000 Subject: [Koha-bugs] [Bug 17936] Search bar not aligned on right in small screen sizes In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17936 Marc V?ron changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #63116|0 |1 is obsolete| | --- Comment #4 from Marc V?ron --- Created attachment 63133 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=63133&action=edit Bug 17936 [Generated CSS] Search bar not aligned on right in small screen sizes Processed and minified CSS. Signed-off-by: Marc V?ron -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu May 4 18:16:55 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 04 May 2017 16:16:55 +0000 Subject: [Koha-bugs] [Bug 17936] Search bar not aligned on right in small screen sizes In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17936 Marc V?ron changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off CC| |veron at veron.ch -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu May 4 18:21:56 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 04 May 2017 16:21:56 +0000 Subject: [Koha-bugs] [Bug 18542] New: Move and style "new field" link in item search form Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18542 Bug ID: 18542 Summary: Move and style "new field" link in item search form Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: ASSIGNED Severity: enhancement Priority: P5 - low Component: Templates Assignee: oleonard at myacpl.org Reporter: oleonard at myacpl.org QA Contact: testopia at bugs.koha-community.org I propose to move the "New field" link in the item search form to the end of the last row in that section instead of below it, and to add a + icon. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu May 4 18:23:56 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 04 May 2017 16:23:56 +0000 Subject: [Koha-bugs] [Bug 18538] OPAC database user login internal server error In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18538 Marc V?ron changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #63101|0 |1 is obsolete| | --- Comment #2 from Marc V?ron --- Created attachment 63134 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=63134&action=edit Bug 18538: OPAC databse user login internal server error Reproduce: 1. Go to OPAC 2. Login with the database user 3. Observe Internal Server Error Check your logs: Can't call method "is_debarred" on an undefined value at /home/koha/kohaclone/opac/opac-user.pl line 96. This patch fixes the mentioned crash. To test: 1. Reproduce the issue with above test plan 2. Apply this patch 3. Go to OPAC 4. Login with the database user 5. Observe successful login Bug reproduced, is fixed by this patch. Signed-off-by: Marc V?ron -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu May 4 18:24:09 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 04 May 2017 16:24:09 +0000 Subject: [Koha-bugs] [Bug 18538] OPAC database user login internal server error In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18538 Marc V?ron changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off CC| |veron at veron.ch -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu May 4 18:26:19 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 04 May 2017 16:26:19 +0000 Subject: [Koha-bugs] [Bug 18518] The staff interface "blink" for different actions after upgrading to Firefox 53 In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18518 --- Comment #9 from Marc V?ron --- (In reply to Philippe Audet-Fortin from comment #8) > Created attachment 63039 [details] [review] > Bug 18518: Hide patron list dialog by default > (...) > Signed-off-by: paudet Philippe, did you forget to switch to signed off? -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu May 4 18:27:33 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 04 May 2017 16:27:33 +0000 Subject: [Koha-bugs] [Bug 18542] Move and style "new field" link in item search form In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18542 Owen Leonard changed: What |Removed |Added ---------------------------------------------------------------------------- Patch complexity|--- |Trivial patch Status|ASSIGNED |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu May 4 18:27:36 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 04 May 2017 16:27:36 +0000 Subject: [Koha-bugs] [Bug 18542] Move and style "new field" link in item search form In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18542 --- Comment #1 from Owen Leonard --- Created attachment 63135 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=63135&action=edit Bug 18542 - Move and style "new field" link in item search form This patch modifies the item search page JavaScript so that the "New field" link has a "+" icon and is always placed at the end of the last row in that section of the form. To test, apply the patch and open the item search form in the staff client. In the third section there should be a "+ New field" link at the end of the first row of fields. Clicking the "New field" link should clone that row and move the link to the end of the cloned row. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu May 4 18:28:50 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 04 May 2017 16:28:50 +0000 Subject: [Koha-bugs] [Bug 7062] barcode titles not truncating In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7062 Dennis Hohmann changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |dennis at dennishohmann.de -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu May 4 18:36:02 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 04 May 2017 16:36:02 +0000 Subject: [Koha-bugs] [Bug 17812] Return focus to barcode field after toggling on-site checkouts In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17812 Marc V?ron changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #63038|0 |1 is obsolete| | --- Comment #5 from Marc V?ron --- Created attachment 63136 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=63136&action=edit Bug 17812 - Return focus to barcode field after toggling on-site checkouts This patch changes the behavior of the checkout form so that after checking boxes in the "checkout settings" panel the cursor focus is automatically moved to the barcode field. To test, apply the patch and enable OnSiteCheckouts and decreaseLoanHighHolds system preferences. - Open any patron account in circulation. - Expand the "Checkout settings" panel. - Click the label or checkbox for "Automatic renewal", "Don't decrease checkout length based on holds" and "On-site checkout" - Confirm that the focus has moved to the barcode field. Works as advertised. Signed-off-by: Marc V?ron -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu May 4 18:37:04 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 04 May 2017 16:37:04 +0000 Subject: [Koha-bugs] [Bug 17812] Return focus to barcode field after toggling on-site checkouts In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17812 Marc V?ron changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off CC| |veron at veron.ch -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu May 4 18:42:41 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 04 May 2017 16:42:41 +0000 Subject: [Koha-bugs] [Bug 18542] Move and style "new field" link in item search form In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18542 Marc V?ron changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #63135|0 |1 is obsolete| | --- Comment #2 from Marc V?ron --- Created attachment 63137 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=63137&action=edit Bug 18542 - Move and style "new field" link in item search form This patch modifies the item search page JavaScript so that the "New field" link has a "+" icon and is always placed at the end of the last row in that section of the form. To test, apply the patch and open the item search form in the staff client. In the third section there should be a "+ New field" link at the end of the first row of fields. Clicking the "New field" link should clone that row and move the link to the end of the cloned row. Behaves as expected. Signed-off-by: Marc V?ron -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu May 4 18:43:22 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 04 May 2017 16:43:22 +0000 Subject: [Koha-bugs] [Bug 18542] Move and style "new field" link in item search form In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18542 Marc V?ron changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off CC| |veron at veron.ch -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu May 4 19:07:48 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 04 May 2017 17:07:48 +0000 Subject: [Koha-bugs] [Bug 15705] Notify the user on auto renewing In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15705 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |Signed Off -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu May 4 19:30:36 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 04 May 2017 17:30:36 +0000 Subject: [Koha-bugs] [Bug 15705] Notify the user on auto renewing In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15705 Nick Clemens changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu May 4 19:30:39 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 04 May 2017 17:30:39 +0000 Subject: [Koha-bugs] [Bug 15705] Notify the user on auto renewing In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15705 Nick Clemens changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #61495|0 |1 is obsolete| | Attachment #61496|0 |1 is obsolete| | Attachment #61499|0 |1 is obsolete| | Attachment #61501|0 |1 is obsolete| | Attachment #62072|0 |1 is obsolete| | Attachment #63036|0 |1 is obsolete| | Attachment #63037|0 |1 is obsolete| | --- Comment #64 from Nick Clemens --- Created attachment 63138 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=63138&action=edit Bug 15705: Notify the user on auto renewing When an issue is auto renewed, a notice will be sent to the patron. The notice will tell if the renewed has been successfully done. Note that this patch is not ready to be pushed yet, as it has some defects: - 1 notice per issue - no way to disable the notice generation - no way to specify patron categories to enable/disable the notifications Test plan: Use the automatic_renewals.pl script to auto renew issues. If the auto renew has failed or succeeded, a notice will be generated in the message_queue table. If the error is "too_soon" or is the same as the previous error, the notice won't be generated (we do not want to spam the patron). Signed-off-by: Janet McGowan Signed-off-by: Jonathan Field Signed-off-by: Nick Clemens -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu May 4 19:30:44 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 04 May 2017 17:30:44 +0000 Subject: [Koha-bugs] [Bug 15705] Notify the user on auto renewing In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15705 --- Comment #65 from Nick Clemens --- Created attachment 63139 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=63139&action=edit Bug 15705: Add specific warning messages for auto_too_much_oweing Signed-off-by: Janet McGowan Signed-off-by: Jonathan Field Signed-off-by: Nick Clemens -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu May 4 19:30:49 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 04 May 2017 17:30:49 +0000 Subject: [Koha-bugs] [Bug 15705] Notify the user on auto renewing In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15705 --- Comment #66 from Nick Clemens --- Created attachment 63140 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=63140&action=edit Bug 15705: Reset the last error when an auto renew successes The auto_renew_error has to be reset when an auto renew successes, otherwise the patron is not going to receive the correct notice. Test plan; - Checkin an item and mark it as auto renewal (specify a due date in the past to allow auto renewals) - Set OPACFineNoRenewalsBlockAutoRenew to 'Block' and 'OPACFineNoRenewals' to '1' - Execute the script => Auto renewed, column auto_renew_error is null - Add a fine of '2' to the patron - Execute the script => Not auto renewed, column auto_renew_error is 'auto_too_much_oweing' => On the interface youo see the correct message "Automatic renewal failed, patron has unpaid fines" - Pay the fine - Execute the script Without this patch the auto_renew_error is not reset and the patron is going to receive a letter telling him he own too much money to the library With this patch the patron will receive a letter to inform him the renew has been done! Signed-off-by: Jonathan Field Signed-off-by: Nick Clemens -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu May 4 19:30:53 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 04 May 2017 17:30:53 +0000 Subject: [Koha-bugs] [Bug 15705] Notify the user on auto renewing In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15705 --- Comment #67 from Nick Clemens --- Created attachment 63141 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=63141&action=edit Bug 15705: DBIC Schema changes Signed-off-by: Nick Clemens -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu May 4 19:30:58 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 04 May 2017 17:30:58 +0000 Subject: [Koha-bugs] [Bug 15705] Notify the user on auto renewing In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15705 --- Comment #68 from Nick Clemens --- Created attachment 63142 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=63142&action=edit Bug 15705: Add --send-notices to the cronjob script Signed-off-by: Nick Clemens -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu May 4 19:31:03 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 04 May 2017 17:31:03 +0000 Subject: [Koha-bugs] [Bug 15705] Notify the user on auto renewing In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15705 --- Comment #69 from Nick Clemens --- Created attachment 63143 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=63143&action=edit Bug 15705: DB Changes - Add [old_]issues.auto_renew_error and the AUTO_RENEWALS notice Signed-off-by: Nick Clemens -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu May 4 19:31:07 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 04 May 2017 17:31:07 +0000 Subject: [Koha-bugs] [Bug 15705] Notify the user on auto renewing In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15705 --- Comment #70 from Nick Clemens --- Created attachment 63144 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=63144&action=edit Bug 15705 (QA Followup) Remove unused variable, fix typo and add due date to notice Signed-off-by: Nick Clemens -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu May 4 20:06:12 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 04 May 2017 18:06:12 +0000 Subject: [Koha-bugs] [Bug 17812] Return focus to barcode field after toggling on-site checkouts In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17812 sandboxes at biblibre.com changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |sandboxes at biblibre.com --- Comment #6 from sandboxes at biblibre.com --- Patch tested with a sandbox, by Marjorie Barry-Vila -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu May 4 20:06:27 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 04 May 2017 18:06:27 +0000 Subject: [Koha-bugs] [Bug 17812] Return focus to barcode field after toggling on-site checkouts In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17812 sandboxes at biblibre.com changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #63136|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu May 4 20:06:35 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 04 May 2017 18:06:35 +0000 Subject: [Koha-bugs] [Bug 17812] Return focus to barcode field after toggling on-site checkouts In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17812 --- Comment #7 from sandboxes at biblibre.com --- Created attachment 63145 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=63145&action=edit Bug 17812 - Return focus to barcode field after toggling on-site checkouts This patch changes the behavior of the checkout form so that after checking boxes in the "checkout settings" panel the cursor focus is automatically moved to the barcode field. To test, apply the patch and enable OnSiteCheckouts and decreaseLoanHighHolds system preferences. - Open any patron account in circulation. - Expand the "Checkout settings" panel. - Click the label or checkbox for "Automatic renewal", "Don't decrease checkout length based on holds" and "On-site checkout" - Confirm that the focus has moved to the barcode field. Works as advertised. Signed-off-by: Marc V?ron Signed-off-by: Marjorie Barry-Vila -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu May 4 20:07:16 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 04 May 2017 18:07:16 +0000 Subject: [Koha-bugs] [Bug 18120] REST API: CRUD endpoint for vendors In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18120 Tom?s Cohen Arazi changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #61587|0 |1 is obsolete| | --- Comment #7 from Tom?s Cohen Arazi --- Created attachment 63146 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=63146&action=edit Bug 18120: (followup) Make operationId unique This patch renames the method names, and the operationID on the swagger spec so they are unique. Signed-off-by: Tomas Cohen Arazi -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu May 4 20:27:10 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 04 May 2017 18:27:10 +0000 Subject: [Koha-bugs] [Bug 17682] Change URL for Google Scholar in OPACSearchForTitleIn In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17682 Owen Leonard changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|oleonard at myacpl.org |koha-bugs at lists.koha-commun | |ity.org Version|16.05 |master --- Comment #1 from Owen Leonard --- This will require an update to the default system preferences SQL (variable OPACSearchForTitleIn), and probably a check during update for customized values. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Thu May 4 20:29:44 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 04 May 2017 18:29:44 +0000 Subject: [Koha-bugs] [Bug 16545] Make edit link a styled button in item search results In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16545 Owen Leonard changed: What |Removed |Added ---------------------------------------------------------------------------- Patch complexity|--- |Trivial patch Status|NEW |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu May 4 20:29:47 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 04 May 2017 18:29:47 +0000 Subject: [Koha-bugs] [Bug 16545] Make edit link a styled button in item search results In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16545 --- Comment #1 from Owen Leonard --- Created attachment 63147 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=63147&action=edit Bug 16545 - Make edit link a styled button in item search results This patch replaces the item search results "edit" link with a dropup button which offers "Edit item" and "Edit record" links. To test, apply the patch and perform an item search. Each results should have an "Edit" menu. Confirm that the menu links work correctly for items on more than one page. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu May 4 20:49:51 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 04 May 2017 18:49:51 +0000 Subject: [Koha-bugs] [Bug 16892] Add automatic patron registration via OAuth2 login In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16892 --- Comment #42 from M. Tompsett --- (In reply to Nick Clemens from comment #41) > I tested under plack/memcached and saw no difference when I removed the find > for borrower so think that can be safely removed. Thanks for testing that. > One question, out of scope: For CAS we have casLogout - can we have > something similar here? I think disconcerting if a patron signs in via > google, signs out of Koha and walks away leaving their google auth intact > unintentionally This is the problem. If you have multiple tabs, let's say gmail in one, and Koha in the other. If Koha does a forced logout, then your gmail tab will be affected. This is the problem that is widely known. I was thinking of actually doing another bug to drop-down choose what kind of log out. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu May 4 21:08:03 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 04 May 2017 19:08:03 +0000 Subject: [Koha-bugs] [Bug 18273] Bulkmarcimport inserts authority duplicates In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18273 Marjorie Barry-Vila changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |marjorie.barry-vila at ccsr.qc | |.ca -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu May 4 21:16:44 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 04 May 2017 19:16:44 +0000 Subject: [Koha-bugs] [Bug 12446] Enable an adult to have a guarantor In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12446 --- Comment #47 from Philippe Audet-Fortin --- Created attachment 63148 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=63148&action=edit Remove wrong importation in DataTables/Members.pm -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu May 4 21:32:49 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 04 May 2017 19:32:49 +0000 Subject: [Koha-bugs] [Bug 12446] Enable an adult to have a guarantor In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12446 Philippe Audet-Fortin changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #63148|0 |1 is obsolete| | --- Comment #48 from Philippe Audet-Fortin --- Created attachment 63149 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=63149&action=edit Remove wrong importation in DataTables/Members.pm https://bugs.koha-community.org/show_bug.cgi?id=12446 Signed-off-by: paudet -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu May 4 21:46:53 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 04 May 2017 19:46:53 +0000 Subject: [Koha-bugs] [Bug 16892] Add automatic patron registration via OAuth2 login In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16892 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |martin.renvoize at ptfs-europe | |.com --- Comment #43 from Martin Renvoize --- A federated logout is actually pretty rare in my experience, though it is possible. As you say Mark, it 'feels' strange to the user that logging out of seemingly unrelated apps can have the knock on effect of logging out apps in other tabs that happen to share an aouth2 openid connect identity provider. On a related note, I'm not sure I saw any code out end to support such a federated logout triggered by another service in our end either... but perhaps I missed it ;) -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu May 4 21:58:02 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 04 May 2017 19:58:02 +0000 Subject: [Koha-bugs] [Bug 18543] New: Automated emails for new patron accounts with the AutoEmailOpacUser preference Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18543 Bug ID: 18543 Summary: Automated emails for new patron accounts with the AutoEmailOpacUser preference Change sponsored?: --- Product: Koha Version: 16.11 Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Patrons Assignee: koha-bugs at lists.koha-community.org Reporter: karen at bywatersolutions.com QA Contact: testopia at bugs.koha-community.org CC: gmcharlt at gmail.com, kyle.m.hall at gmail.com When the AutoEmailOpacUser preference is set to Send, Koha should send an email with account details to newly created patrons. After some testing, we discovered that Koha will only send emails to patrons if the username and password are entered into the system by hand. The email is not sent when the username and password are automatically generated by the system. The expected behavior is that Koha would send the account details email to newly created patrons when the system automatically generates the username and the password. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Thu May 4 23:00:08 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 04 May 2017 21:00:08 +0000 Subject: [Koha-bugs] [Bug 18544] New: Two printing dialogues when printing cart Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18544 Bug ID: 18544 Summary: Two printing dialogues when printing cart Change sponsored?: --- Product: Koha Version: 16.11 Hardware: All OS: All Status: NEW Severity: normal Priority: P5 - low Component: Browser compatibility Assignee: oleonard at myacpl.org Reporter: mik at adminkuhn.ch QA Contact: testopia at bugs.koha-community.org To reproduce the bug: - Use Mozilla Firefox 48.0 or 53.0 (these were tested) - Add title to cart in OPAC - Open cart - Click the link "Print" - A printing dialogue appears - The popup window with cart seems to refresh in the background - A second printing dialogue appears (placed exactly over the first one) - Sometimes these dialogues do even crash This was tested on a Koha 16.11.0, Koha 16.11.4 and on the current Koha master. This was also using Opera 12.16 and Chromium 58.0 - these don't show this behaviour. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri May 5 00:39:57 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 04 May 2017 22:39:57 +0000 Subject: [Koha-bugs] [Bug 18002] Make onboarding tool include framework to be embedded in Acquisitions to help the users set up Acquisitions for the first time In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18002 Alex Buckley changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #60685|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri May 5 00:40:11 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 04 May 2017 22:40:11 +0000 Subject: [Koha-bugs] [Bug 18002] Make onboarding tool include framework to be embedded in Acquisitions to help the users set up Acquisitions for the first time In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18002 Alex Buckley changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #60686|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri May 5 00:40:24 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 04 May 2017 22:40:24 +0000 Subject: [Koha-bugs] [Bug 18002] Make onboarding tool include framework to be embedded in Acquisitions to help the users set up Acquisitions for the first time In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18002 Alex Buckley changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #60687|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri May 5 00:40:34 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 04 May 2017 22:40:34 +0000 Subject: [Koha-bugs] [Bug 18002] Make onboarding tool include framework to be embedded in Acquisitions to help the users set up Acquisitions for the first time In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18002 Alex Buckley changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #60688|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri May 5 00:41:00 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 04 May 2017 22:41:00 +0000 Subject: [Koha-bugs] [Bug 18002] Make onboarding tool include framework to be embedded in Acquisitions to help the users set up Acquisitions for the first time In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18002 Alex Buckley changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #61988|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri May 5 00:40:49 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 04 May 2017 22:40:49 +0000 Subject: [Koha-bugs] [Bug 18002] Make onboarding tool include framework to be embedded in Acquisitions to help the users set up Acquisitions for the first time In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18002 Alex Buckley changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #61987|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri May 5 00:41:28 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 04 May 2017 22:41:28 +0000 Subject: [Koha-bugs] [Bug 18002] Make onboarding tool include framework to be embedded in Acquisitions to help the users set up Acquisitions for the first time In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18002 --- Comment #32 from Alex Buckley --- Created attachment 63150 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=63150&action=edit Bug 18002 - Created a budget creation onboarding form to be displayed when the user first visits the acquisition area -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri May 5 00:51:52 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 04 May 2017 22:51:52 +0000 Subject: [Koha-bugs] [Bug 18002] Make onboarding tool include framework to be embedded in Acquisitions to help the users set up Acquisitions for the first time In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18002 Alex Buckley changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #63150|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri May 5 00:52:28 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 04 May 2017 22:52:28 +0000 Subject: [Koha-bugs] [Bug 18002] Make onboarding tool include framework to be embedded in Acquisitions to help the users set up Acquisitions for the first time In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18002 --- Comment #33 from Alex Buckley --- Created attachment 63151 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=63151&action=edit Bug 18002 - Created a budget creation onboarding form to be displayed when the user first visits the acquisition area -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri May 5 03:19:35 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 05 May 2017 01:19:35 +0000 Subject: [Koha-bugs] [Bug 17944] Remove the sql code from itemtypes.pl administrative perl script In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17944 Alex Buckley changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #63045|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri May 5 03:20:01 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 05 May 2017 01:20:01 +0000 Subject: [Koha-bugs] [Bug 17944] Remove the sql code from itemtypes.pl administrative perl script In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17944 --- Comment #43 from Alex Buckley --- Created attachment 63152 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=63152&action=edit Bug 17944 - Removed SQl query from itemtypes.pl and replaced it with can_be_deleted method in Koha/ItemType.pm -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri May 5 03:20:25 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 05 May 2017 01:20:25 +0000 Subject: [Koha-bugs] [Bug 17944] Remove the sql code from itemtypes.pl administrative perl script In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17944 Alex Buckley changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri May 5 03:25:53 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 05 May 2017 01:25:53 +0000 Subject: [Koha-bugs] [Bug 14803] Rental and fine fees are not updating on circulation screen In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14803 Srdjan Jankovic changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #62432|0 |1 is obsolete| | --- Comment #27 from Srdjan Jankovic --- Created attachment 63153 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=63153&action=edit bug 14803: KOHA.Checkouts js object * Use javascript to: - update fines/checkouts info - show/hide checkouts form and messages * Created svc/patron/fines -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri May 5 03:27:44 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 05 May 2017 01:27:44 +0000 Subject: [Koha-bugs] [Bug 14803] Rental and fine fees are not updating on circulation screen In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14803 --- Comment #28 from Srdjan Jankovic --- > But now, when I have no fines owed, I can't see the checkout form and even > any current checkouts... Oops. Corrected -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri May 5 03:28:46 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 05 May 2017 01:28:46 +0000 Subject: [Koha-bugs] [Bug 16892] Add automatic patron registration via OAuth2 login In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16892 --- Comment #44 from Nick Clemens --- Perhaps if OAuth is activated just a note added that when you log out of Koha you may still be logged in via google? I agree a user with many tabs open may not expect this, but a patron using a shared machine in the library who signs in to place a hold or renew may never visit their email or expect that they have signed in to that. I think a pop-up when logging out to say "Hey, you are logged in to google, and they know lots of stuff about you" wouldn't hurt, who can say if it would help :-) -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri May 5 03:32:14 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 05 May 2017 01:32:14 +0000 Subject: [Koha-bugs] [Bug 16892] Add automatic patron registration via OAuth2 login In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16892 --- Comment #45 from M. Tompsett --- (In reply to Nick Clemens from comment #44) > Perhaps if OAuth is activated just a note added that when you log out of > Koha you may still be logged in via google? [SNIP] Perhaps this type of discussion should happen on another bug report, as this bug has nothing to do with logging out. :) Also, yes, some sort of warning should be displayed, somewhere, somehow. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri May 5 03:55:16 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 05 May 2017 01:55:16 +0000 Subject: [Koha-bugs] [Bug 17944] Remove the sql code from itemtypes.pl administrative perl script In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17944 --- Comment #44 from Alex Buckley --- Hi Jonathan I have implemented the changes you suggested in a single patch for bug 17944. Because I have implemented the following return line (which you suggested) from can_be_deleted() subroutine: return $nb_items + $nb_biblioitems == 0; I had to slightly change the unit test from how you suggested it, this is because whenever there were items and/or biblioitems with the itemtype it meant that ' ' was returned. So the unit test callers are now: is( $item_type->can_be_deleted, '', 'An item type that is used by an item cannot be deleted' ); is ( $item_type->can_be_deleted, '', 'An item type that is used by a biblioitem cannot be deleted' ); Additionally as '' is returned if the itemtype is in use, rather than the number of items and biblioitems using the itemtype I have changed itemtypes.tt to saying: Cannot delete this item type. This record is in use. Deletion is not possible. If you would still like the number of items and biblioitems using the itemtype to be displayed to the user in itemtypes.tt then I will need to change the return for can_be_deleted to a longer if else statement. Could you please have a look at this patch? -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri May 5 05:40:35 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 05 May 2017 03:40:35 +0000 Subject: [Koha-bugs] [Bug 16545] Make edit link a styled button in item search results In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16545 M. Tompsett changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri May 5 05:40:38 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 05 May 2017 03:40:38 +0000 Subject: [Koha-bugs] [Bug 16545] Make edit link a styled button in item search results In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16545 M. Tompsett changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #63147|0 |1 is obsolete| | --- Comment #2 from M. Tompsett --- Created attachment 63154 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=63154&action=edit Bug 16545 - Make edit link a styled button in item search results This patch replaces the item search results "edit" link with a dropup button which offers "Edit item" and "Edit record" links. To test, apply the patch and perform an item search. Each results should have an "Edit" menu. Confirm that the menu links work correctly for items on more than one page. Signed-off-by: Mark Tompsett -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri May 5 05:59:32 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 05 May 2017 03:59:32 +0000 Subject: [Koha-bugs] [Bug 18545] New: Remove use of onclick from OPAC Cart Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18545 Bug ID: 18545 Summary: Remove use of onclick from OPAC Cart Change sponsored?: --- Product: Koha Version: unspecified Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: OPAC Assignee: oleonard at myacpl.org Reporter: aleisha at catalyst.net.nz QA Contact: testopia at bugs.koha-community.org -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri May 5 06:02:14 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 05 May 2017 04:02:14 +0000 Subject: [Koha-bugs] [Bug 18545] Remove use of onclick from OPAC Cart In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18545 Aleisha Amohia changed: What |Removed |Added ---------------------------------------------------------------------------- Patch complexity|--- |Small patch Status|NEW |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri May 5 06:02:18 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 05 May 2017 04:02:18 +0000 Subject: [Koha-bugs] [Bug 18545] Remove use of onclick from OPAC Cart In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18545 --- Comment #1 from Aleisha Amohia --- Created attachment 63155 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=63155&action=edit Bug 18545: Remove use of onclick from OPAC cart To test: 1) Apply patch and add one or more items to your cart 2) Confirm that clicking the following things still works as expected: - more details - brief display - send - download - print - select all - clear all - selecting by clicking checkbox - remove title - add title to list - place hold - add tag - empty and close Sponsored-by: Catalyst IT -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri May 5 06:02:42 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 05 May 2017 04:02:42 +0000 Subject: [Koha-bugs] [Bug 18545] Remove use of onclick from OPAC Cart In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18545 Aleisha Amohia changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|oleonard at myacpl.org |aleisha at catalyst.net.nz Change sponsored?|--- |Sponsored -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri May 5 06:29:49 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 05 May 2017 04:29:49 +0000 Subject: [Koha-bugs] [Bug 18545] Remove use of onclick from OPAC Cart In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18545 Marc V?ron changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #63155|0 |1 is obsolete| | --- Comment #2 from Marc V?ron --- Created attachment 63156 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=63156&action=edit Bug 18545: Remove use of onclick from OPAC cart To test: 1) Apply patch and add one or more items to your cart 2) Confirm that clicking the following things still works as expected: - more details - brief display - send - download - print - select all - clear all - selecting by clicking checkbox - remove title - add title to list - place hold - add tag - empty and close Sponsored-by: Catalyst IT Followed test plan, works as expected. Resolves issue with two print dialogues from Bug 18544. Signed-off-by: Marc V?ron -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri May 5 06:30:10 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 05 May 2017 04:30:10 +0000 Subject: [Koha-bugs] [Bug 18545] Remove use of onclick from OPAC Cart In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18545 Marc V?ron changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |veron at veron.ch Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri May 5 06:36:18 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 05 May 2017 04:36:18 +0000 Subject: [Koha-bugs] [Bug 18545] Remove use of onclick from OPAC Cart In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18545 Marc V?ron changed: What |Removed |Added ---------------------------------------------------------------------------- Severity|enhancement |minor --- Comment #3 from Marc V?ron --- Changing status to bug (minor) because of issue with print dialogues, see Bug 18544 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri May 5 06:39:48 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 05 May 2017 04:39:48 +0000 Subject: [Koha-bugs] [Bug 18545] Remove use of onclick from OPAC Cart In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18545 Marc V?ron changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |mik at adminkuhn.ch --- Comment #4 from Marc V?ron --- *** Bug 18544 has been marked as a duplicate of this bug. *** -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri May 5 06:39:48 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 05 May 2017 04:39:48 +0000 Subject: [Koha-bugs] [Bug 18544] Two printing dialogues when printing cart In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18544 Marc V?ron changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |RESOLVED Resolution|--- |DUPLICATE CC| |veron at veron.ch --- Comment #1 from Marc V?ron --- Tested on top of Bug 18545 with Firefox 53.0 (Win) and Firefox ESR 45.3 (Debian). Prining behaves now as expected. *** This bug has been marked as a duplicate of bug 18545 *** -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri May 5 06:46:19 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 05 May 2017 04:46:19 +0000 Subject: [Koha-bugs] [Bug 18546] New: Add a 'Close' link to OPAC cart Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18546 Bug ID: 18546 Summary: Add a 'Close' link to OPAC cart Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: OPAC Assignee: oleonard at myacpl.org Reporter: veron at veron.ch QA Contact: testopia at bugs.koha-community.org Opac cart has does not have a link "Empty and close", but no link or button for "Close". Would be nice to have one. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri May 5 06:47:02 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 05 May 2017 04:47:02 +0000 Subject: [Koha-bugs] [Bug 18545] Remove use of onclick from OPAC Cart In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18545 Marc V?ron changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |18546 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18546 [Bug 18546] Add a 'Close' link to OPAC cart -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri May 5 06:47:02 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 05 May 2017 04:47:02 +0000 Subject: [Koha-bugs] [Bug 18546] Add a 'Close' link to OPAC cart In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18546 Marc V?ron changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on| |18545 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18545 [Bug 18545] Remove use of onclick from OPAC Cart -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri May 5 07:16:18 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 05 May 2017 05:16:18 +0000 Subject: [Koha-bugs] [Bug 18541] Patron card creator: Add a grid to support layout design In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18541 Marc V?ron changed: What |Removed |Added ---------------------------------------------------------------------------- QA Contact|testopia at bugs.koha-communit |veron at veron.ch |y.org | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri May 5 08:29:36 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 05 May 2017 06:29:36 +0000 Subject: [Koha-bugs] [Bug 18436] Add home library to the SIP2 patron info response 64 In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18436 --- Comment #6 from george at shoutbomb.com --- We provide a solution that supports multiple ILS providers and SIP2 is the underlying service across those various ILS. When I cannot provide the needed feature using SIP2 I have to look to the ILS in hopes that they have an "api" that provides third-party support. In this case there was a need to derive the patron "home library" and this was not available via SIP2 and there are no third party api. So, the path was to ask for a change to SIP2, otherwise plan B was to develop a work around that in the long run was not sustainable. In the end I was able to verify that this patch works, but they were not ready to accept this patch. Instead, there was an option to utilize the AO segment to provide the patron home library. I am hoping they will incorporate this patch at a later point. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri May 5 08:31:51 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 05 May 2017 06:31:51 +0000 Subject: [Koha-bugs] [Bug 18436] Add home library to the SIP2 patron info response 64 In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18436 --- Comment #7 from george at shoutbomb.com --- We provide a solution that supports multiple ILS providers and SIP2 is the underlying service across those various ILS. When I cannot provide the needed feature using SIP2 I have to look to the ILS in hopes that they have an "api" that provides third-party support. In this case there was a need to derive the patron "home library" and this was not available via SIP2 and there are no third party api. So, the path was to ask for a change to SIP2, otherwise plan B was to develop a work around that in the long run was not sustainable. In the end I was able to verify that this patch works, but they were not ready to accept this patch. Instead, there was an option to utilize the AO segment to provide the patron home library. I am hoping they will incorporate this patch at a later point. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri May 5 09:44:04 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 05 May 2017 07:44:04 +0000 Subject: [Koha-bugs] [Bug 18547] New: On shelf holds allowed > "If all unavailable" ignores branch rules Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18547 Bug ID: 18547 Summary: On shelf holds allowed > "If all unavailable" ignores branch rules Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: normal Priority: P5 - low Component: Hold requests Assignee: koha-bugs at lists.koha-community.org Reporter: mirko at abunchofthings.net QA Contact: testopia at bugs.koha-community.org CC: gmcharlt at gmail.com If in the circ rules matrix you set "On shelf holds allowed" to "If all unavailable", default hold policy "From home library" is ignored. Test plan: - Have a test user from one branch (eg Centerville) - Set "On shelf holds allowed" to "If all unavailable" for your patron and item category (or everyone and everything) - For "Default checkout, hold and return policy", set hold policy to "From home library" -> make sure there is no "Default holds policy by item type" to override the setting - Have two items for a record. 1. An item with home branch same as test user (eg Centerville) -> check this item out to somebody else 2. an item with a different home branch (eg Fairfield) -> available, not checked out - Try to place a hold for your test user. Does not work. - Apply the patch - Try to place a hold. Should work now. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Fri May 5 09:44:26 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 05 May 2017 07:44:26 +0000 Subject: [Koha-bugs] [Bug 18547] On shelf holds allowed > "If all unavailable" ignores branch rules In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18547 Mirko Tietgen changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |https://bugs.koha-community | |.org/bugzilla3/show_bug.cgi | |?id=18015 Assignee|koha-bugs at lists.koha-commun |mirko at abunchofthings.net |ity.org | -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Fri May 5 09:44:26 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 05 May 2017 07:44:26 +0000 Subject: [Koha-bugs] [Bug 18015] On shelf holds allowed > "If all unavailable" ignores notforloan In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18015 Mirko Tietgen changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |https://bugs.koha-community | |.org/bugzilla3/show_bug.cgi | |?id=18547 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri May 5 09:46:16 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 05 May 2017 07:46:16 +0000 Subject: [Koha-bugs] [Bug 18547] On shelf holds allowed > "If all unavailable" ignores default hold policy In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18547 Mirko Tietgen changed: What |Removed |Added ---------------------------------------------------------------------------- Summary|On shelf holds allowed > |On shelf holds allowed > |"If all unavailable" |"If all unavailable" |ignores branch rules |ignores default hold policy -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri May 5 09:55:47 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 05 May 2017 07:55:47 +0000 Subject: [Koha-bugs] [Bug 18547] On shelf holds allowed > "If all unavailable" ignores default hold policy In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18547 --- Comment #1 from Mirko Tietgen --- Created attachment 63157 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=63157&action=edit Bug 18547 - On shelf holds allowed > "If all unavailable" ignores default hold policy If in the circ rules matrix you set "On shelf holds allowed" to "If all unavailable", default hold policy "From home library" is ignored. Test plan: - Have a test user from one branch (eg Centerville) - Set "On shelf holds allowed" to "If all unavailable" for your patron and item category (or everyone and everything) - For "Default checkout, hold and return policy", set hold policy to "From home library" -> make sure there is no "Default holds policy by item type" to override the setting - Have two items for a record. 1. An item with home branch same as test user (eg Centerville) -> check this item out to somebody else 2. an item with a different home branch (eg Fairfield) -> available, not checked out - Try to place a hold for your test user. Does not work. - Apply the patch - Try to place a hold. Should work now. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri May 5 09:56:13 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 05 May 2017 07:56:13 +0000 Subject: [Koha-bugs] [Bug 18547] On shelf holds allowed > "If all unavailable" ignores default hold policy In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18547 Mirko Tietgen changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri May 5 10:17:45 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 05 May 2017 08:17:45 +0000 Subject: [Koha-bugs] [Bug 18547] On shelf holds allowed > "If all unavailable" ignores default hold policy In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18547 Mirko Tietgen changed: What |Removed |Added ---------------------------------------------------------------------------- Severity|normal |major -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri May 5 10:43:40 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 05 May 2017 08:43:40 +0000 Subject: [Koha-bugs] [Bug 8612] CSV export profile to have custom fields in export csv basket In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8612 --- Comment #98 from Josef Moravec --- Created attachment 63158 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=63158&action=edit Bug 8612: QA followup - strip white chars from csv profile definition -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri May 5 10:46:40 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 05 May 2017 08:46:40 +0000 Subject: [Koha-bugs] [Bug 8612] CSV export profile to have custom fields in export csv basket In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8612 Josef Moravec changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |Signed Off --- Comment #99 from Josef Moravec --- (In reply to Marcel de Rooy from comment #95) > I tested with a trival csv: > biblio.title | some_text=aqorders.quantity > > The title is not shown, the quantity is. Have the impression that the regex > might still be the cause. > What did you test? The reason it doesn't work for you are the spaces between fields in your definition. The help paragraph on csv profile page doesn't say anything about spaces, so i decided to strip the white chars from definition before generating csv. It doesn't hurt and could help to avoid unexpected issues. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri May 5 11:30:17 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 05 May 2017 09:30:17 +0000 Subject: [Koha-bugs] [Bug 18537] Update Ukrainian installer sample files for 17.05 In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18537 Serhij Dubyk changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |dubyk at ukr.net -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri May 5 11:39:40 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 05 May 2017 09:39:40 +0000 Subject: [Koha-bugs] [Bug 18242] Remove primary key on old_issues.issue_id In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18242 --- Comment #19 from Mason James --- Hi, the atches don't appear to work for 16.05.x: If this is needed, please provide patches for 16.05.x ----------- mason at xen1:~/g/k/16.05.x$ git bz apply 18242 Bug 18242 - Remove primary key on old_issues.issue_id 61254 - Bug 18242: [SOLUTION 2]Add tests 61255 - Bug 18242: [SOLUTION 2]Handle correctly move to old_issues 61794 - Bug 18242: 16.11.x adaptation - Old::Checkouts vs OldIssues Apply? [(y)es, (n)o, (i)nteractive] y Applying: Bug 18242: [SOLUTION 2]Add tests Using index info to reconstruct a base tree... M t/db_dependent/Circulation/Returns.t Falling back to patching base and 3-way merge... Auto-merging t/db_dependent/Circulation/Returns.t CONFLICT (content): Merge conflict in t/db_dependent/Circulation/Returns.t Failed to merge in the changes. Patch failed at 0001 Bug 18242: [SOLUTION 2]Add tests The copy of the patch that failed is found in: /home/mason/g/k/16.05.x/.git/rebase-apply/patch When you have resolved this problem run "git bz apply --continue". If you would prefer to skip this patch, instead run "git bz apply --skip". To restore the original branch and stop patching run "git bz apply --abort". Patch left in /tmp/Bug-18242-SOLUTION-2Add-tests-uyNJwm.patch -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri May 5 11:41:43 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 05 May 2017 09:41:43 +0000 Subject: [Koha-bugs] [Bug 14803] Rental and fine fees are not updating on circulation screen In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14803 Josef Moravec changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Failed QA --- Comment #29 from Josef Moravec --- I have to more concerns about it: 1) The barcode field doesn't have focus after page is loaded - probably easy to fix, but important 2) Looks like it waits than issues are loaded and then show the barcode input field, maybe I am wrong and it just looks like, but in any case it is much slower then current master... 3) Message "loading, you can continue scanning" is badly placed (in the left top corner) -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri May 5 11:42:49 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 05 May 2017 09:42:49 +0000 Subject: [Koha-bugs] [Bug 18468] When adding from a staged file order discounts are not passed into C4:: Acquisitions::populate_order_with_prices In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18468 jmbroust changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |jean-manuel.broust at univ-lyo | |n2.fr --- Comment #5 from jmbroust --- Hello, I'm into testing Koha 16.11.06 and i noticed the same problem. Can this patch be backported to 16.11 or shall I open a new bug ? Thanx. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri May 5 11:47:22 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 05 May 2017 09:47:22 +0000 Subject: [Koha-bugs] [Bug 18548] New: running koha-create --request-db without an instance name should abort Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18548 Bug ID: 18548 Summary: running koha-create --request-db without an instance name should abort Change sponsored?: --- Product: Koha Version: 16.11 Hardware: All OS: Linux Status: NEW Severity: enhancement Priority: P5 - low Component: Command-line Utilities Assignee: gmcharlt at gmail.com Reporter: eric.vantillard at evaxion.fr QA Contact: testopia at bugs.koha-community.org CC: robin at catalyst.net.nz running `koha-create --request-db` without an instance name will exit with this error message getent: invalid option -- 'k' Try `getent --help' or `getent --usage' for more information. [...] It should detect that the instance name is missing and exit with an error message explaining that the instance name is mandatory -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri May 5 11:57:24 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 05 May 2017 09:57:24 +0000 Subject: [Koha-bugs] [Bug 18276] Koha::Biblio - Remove GetBiblioFromItemNumber In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18276 Josef Moravec changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Failed QA --- Comment #36 from Josef Moravec --- (In reply to Jonathan Druart from comment #30) > Created attachment 63122 [details] [review] > Bug 18276: Remove GetBiblioFromItemNumber - ILSDI > > Test plan: > Hit /cgi-bin/koha/ilsdi.pl?service=GetPatronInfo&patron_id=51&show_holds=1 > The results should be the same before and after this patch Works good for item level holds, with title level holds I see: "Can't call method "biblio" on an undefined value at /home/vagrant/kohaclone/C4/ILSDI/Services.pm line 422" -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri May 5 12:06:42 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 05 May 2017 10:06:42 +0000 Subject: [Koha-bugs] [Bug 18276] Koha::Biblio - Remove GetBiblioFromItemNumber In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18276 --- Comment #37 from Josef Moravec --- All other looks good for me -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri May 5 12:10:03 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 05 May 2017 10:10:03 +0000 Subject: [Koha-bugs] [Bug 18549] New: There should be a warning that logging out of Koha will leave browser session logged in to OAuth Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18549 Bug ID: 18549 Summary: There should be a warning that logging out of Koha will leave browser session logged in to OAuth Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: normal Priority: P5 - low Component: Authentication Assignee: gmcharlt at gmail.com Reporter: nick at bywatersolutions.com QA Contact: testopia at bugs.koha-community.org CC: dpavlin at rot13.org >From bug 16892 Nick: For CAS we have casLogout - can we have something similar here? I think disconcerting if a patron signs in via google, signs out of Koha and walks away leaving their google auth intact unintentionally Mark: This is the problem. If you have multiple tabs, let's say gmail in one, and Koha in the other. If Koha does a forced logout, then your gmail tab will be affected. This is the problem that is widely known. I was thinking of actually doing another bug to drop-down choose what kind of log out. Martin: A federated logout is actually pretty rare in my experience, though it is possible. As you say Mark, it 'feels' strange to the user that logging out of seemingly unrelated apps can have the knock on effect of logging out apps in other tabs that happen to share an aouth2 openid connect identity provider. On a related note, I'm not sure I saw any code out end to support such a federated logout triggered by another service in our end either... but perhaps I missed it ;) Nick: Perhaps if OAuth is activated just a note added that when you log out of Koha you may still be logged in via google? I agree a user with many tabs open may not expect this, but a patron using a shared machine in the library who signs in to place a hold or renew may never visit their email or expect that they have signed in to that. I think a pop-up when logging out to say "Hey, you are logged in to google, and they know lots of stuff about you" wouldn't hurt, who can say if it would help :-) Mark: Perhaps this type of discussion should happen on another bug report, as this bug has nothing to do with logging out. :) Also, yes, some sort of warning should be displayed, somewhere, somehow. Nick: It can happen here now :-) -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri May 5 12:11:27 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 05 May 2017 10:11:27 +0000 Subject: [Koha-bugs] [Bug 18549] There should be a warning that logging out of Koha will leave browser session logged in to OAuth In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18549 Nick Clemens changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |martin.renvoize at ptfs-europe | |.com, mtompset at hotmail.com, | |nick at bywatersolutions.com -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri May 5 12:12:20 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 05 May 2017 10:12:20 +0000 Subject: [Koha-bugs] [Bug 16892] Add automatic patron registration via OAuth2 login In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16892 Nick Clemens changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |https://bugs.koha-community | |.org/bugzilla3/show_bug.cgi | |?id=18549 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri May 5 12:12:20 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 05 May 2017 10:12:20 +0000 Subject: [Koha-bugs] [Bug 18549] There should be a warning that logging out of Koha will leave browser session logged in to OAuth In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18549 Nick Clemens changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |https://bugs.koha-community | |.org/bugzilla3/show_bug.cgi | |?id=16892 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri May 5 12:21:44 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 05 May 2017 10:21:44 +0000 Subject: [Koha-bugs] [Bug 18548] running koha-create --request-db without an instance name should abort In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18548 Josef Moravec changed: What |Removed |Added ---------------------------------------------------------------------------- Version|16.11 |master Assignee|gmcharlt at gmail.com |josef.moravec at gmail.com Severity|enhancement |minor CC| |josef.moravec at gmail.com -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri May 5 12:23:14 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 05 May 2017 10:23:14 +0000 Subject: [Koha-bugs] [Bug 18548] running koha-create --request-db without an instance name should abort In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18548 Josef Moravec changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri May 5 12:23:17 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 05 May 2017 10:23:17 +0000 Subject: [Koha-bugs] [Bug 18548] running koha-create --request-db without an instance name should abort In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18548 --- Comment #1 from Josef Moravec --- Created attachment 63159 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=63159&action=edit Bug 18548: Print usage when missing instance name in koha-create script Test plan: 1. Run: debian/scripts/koha-create --request-db -> Without patch you see the getent error message -> With patch you see usage and "Missing instance name" message -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri May 5 12:46:35 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 05 May 2017 10:46:35 +0000 Subject: [Koha-bugs] [Bug 18066] Hea - Version 2 In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18066 Josef Moravec changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |16497 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16497 [Bug 16497] REST API: add routes to list libraries -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri May 5 12:46:35 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 05 May 2017 10:46:35 +0000 Subject: [Koha-bugs] [Bug 16497] REST API: add routes to list libraries In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16497 Josef Moravec changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on| |18066 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18066 [Bug 18066] Hea - Version 2 -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Fri May 5 12:51:13 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 05 May 2017 10:51:13 +0000 Subject: [Koha-bugs] [Bug 16497] REST API: add routes to list libraries In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16497 Josef Moravec changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Fri May 5 12:51:16 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 05 May 2017 10:51:16 +0000 Subject: [Koha-bugs] [Bug 16497] REST API: add routes to list libraries In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16497 Josef Moravec changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #61164|0 |1 is obsolete| | --- Comment #17 from Josef Moravec --- Created attachment 63160 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=63160&action=edit [SIGNED-OFF] Bug 16497: [REST] Add /api/v1/libraries CRUD for libraries via REST API. GET /api/v1/libraries - List all libraries GET /api/v1/libraries/{branchcode} - Get one Library POST /api/v1/libraries - Add new Library DELETE /api/v1/libraries/{branchcode} - Delete Library Test plan: - apply patch - run tests: t/db_dependent/api/v1/libraries.t - test API with some API tool or simple curl e.g.: curl http://host:port/api/v1/libraries curl http://host:port/api/v1/libraries/cpl Signed-off-by: Josef Moravec -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Fri May 5 12:51:23 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 05 May 2017 10:51:23 +0000 Subject: [Koha-bugs] [Bug 16497] REST API: add routes to list libraries In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16497 --- Comment #18 from Josef Moravec --- Created attachment 63161 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=63161&action=edit [SIGNED-OFF] Bug 16497: Add missing field in definitions due to bug 18066 Signed-off-by: Josef Moravec -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Fri May 5 12:52:33 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 05 May 2017 10:52:33 +0000 Subject: [Koha-bugs] [Bug 18549] There should be a warning that logging out of Koha will leave browser session logged in to OAuth In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18549 M. Tompsett changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |ASSIGNED Assignee|gmcharlt at gmail.com |mtompset at hotmail.com --- Comment #1 from M. Tompsett --- Thanks for the CC user on this bug. I'll attempt something for this problem, and see what you folks think. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri May 5 12:54:52 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 05 May 2017 10:54:52 +0000 Subject: [Koha-bugs] [Bug 18541] Patron card creator: Add a grid to support layout design In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18541 Marc V?ron changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #63130|0 |1 is obsolete| | --- Comment #3 from Marc V?ron --- Created attachment 63162 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=63162&action=edit Bug 18541 - Patron card creator: Add a grid to support layout design Add a layout grid to patron card creator to figure out the positions of text fields, barcode and images. Amended to apply on top of bug 18465 Amended to show info about units Draft, not ready to sign off. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri May 5 12:57:51 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 05 May 2017 10:57:51 +0000 Subject: [Koha-bugs] [Bug 15758] Move the C4::Branch related code to Koha::Libraries - part 4 In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15758 Nick Clemens changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |18534 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18534 [Bug 18534] When IndependentBranches is enabled the pickup location displayed incorrectly on request.pl -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri May 5 12:57:51 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 05 May 2017 10:57:51 +0000 Subject: [Koha-bugs] [Bug 18534] When IndependentBranches is enabled the pickup location displayed incorrectly on request.pl In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18534 Nick Clemens changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on| |15758 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15758 [Bug 15758] Move the C4::Branch related code to Koha::Libraries - part 4 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri May 5 13:04:15 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 05 May 2017 11:04:15 +0000 Subject: [Koha-bugs] [Bug 18549] There should be a warning that logging out of Koha will leave browser session logged in to OAuth In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18549 --- Comment #2 from Martin Renvoize --- Cheers for splitting this out. Great to hear you're going to give it a punt Mark, I'd love to see the federated logout fully implemented, but I'm not expecting that here. If we do go down that route, I feel we need to impliment both ends in the same bug.. i.e. both our 'SLO caller' which needs to be attached to the logout button and the 'SLO listener' which if memory servers is a double iframe based hack in OpenID Connect. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri May 5 13:22:09 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 05 May 2017 11:22:09 +0000 Subject: [Koha-bugs] [Bug 18205] REST interface to Koha::Logger In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18205 Josef Moravec changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |josef.moravec at gmail.com Status|Needs Signoff |Patch doesn't apply --- Comment #4 from Josef Moravec --- Does not apply on top of 18137... -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri May 5 13:31:55 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 05 May 2017 11:31:55 +0000 Subject: [Koha-bugs] [Bug 18548] running koha-create --request-db without an instance name should abort In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18548 Eric Vantillard changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |RESOLVED Resolution|--- |FIXED --- Comment #2 from Eric Vantillard --- test done. it's fine. thank you -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri May 5 13:42:52 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 05 May 2017 11:42:52 +0000 Subject: [Koha-bugs] [Bug 18548] running koha-create --request-db without an instance name should abort In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18548 Josef Moravec changed: What |Removed |Added ---------------------------------------------------------------------------- Status|RESOLVED |REOPENED Resolution|FIXED |--- --- Comment #3 from Josef Moravec --- (In reply to Eric Vantillard from comment #2) > test done. it's fine. thank you Please note: "RESOLVED FIXED" status is for bugs pushed to all relevant versions, if you test it and it works for you, you should use "signed off" status. See https://wiki.koha-community.org/wiki/Development_workflow anyway thanks for testing! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri May 5 13:43:07 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 05 May 2017 11:43:07 +0000 Subject: [Koha-bugs] [Bug 18548] running koha-create --request-db without an instance name should abort In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18548 Josef Moravec changed: What |Removed |Added ---------------------------------------------------------------------------- Status|REOPENED |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri May 5 13:45:09 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 05 May 2017 11:45:09 +0000 Subject: [Koha-bugs] [Bug 18548] running koha-create --request-db without an instance name should abort In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18548 Eric Vantillard changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off --- Comment #4 from Eric Vantillard --- understood. thanks -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri May 5 14:12:04 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 05 May 2017 12:12:04 +0000 Subject: [Koha-bugs] [Bug 18120] REST API: CRUD endpoint for vendors In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18120 Matthias Meusburger changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #61182|0 |1 is obsolete| | --- Comment #8 from Matthias Meusburger --- Created attachment 63163 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=63163&action=edit Bug 18120: REST api | /acquisitions/vendors unit tests This patch introduces unit tests that need to be passed by an /acquisitions/vendors/ REST endpoint. To test: - Apply the patch - Run: $ sudo koha-shell kohadev k$ prove t/db_dependent/api/v1/acquisitions_vendors.t => FAIL: The endpoint is not present, should fail. Sponsored-by: ByWater Solutions Signed-off-by: Matthias Meusburger -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri May 5 14:12:28 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 05 May 2017 12:12:28 +0000 Subject: [Koha-bugs] [Bug 18120] REST API: CRUD endpoint for vendors In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18120 Matthias Meusburger changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #61183|0 |1 is obsolete| | --- Comment #9 from Matthias Meusburger --- Created attachment 63164 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=63164&action=edit Bug 18120: REST api | Add a 'vendors' endpoint This patch introduces an /acquisitions/vendors endpoint. To test: - Apply the patch - Run: $ sudo koha-shell kohadev k$ prove t/db_dependent/api/v1/acquisitions_vendors.t => SUCCESS: Tests pass - Sign off :-D Sponsored-by: ByWater Solutions Signed-off-by: Matthias Meusburger -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri May 5 14:13:11 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 05 May 2017 12:13:11 +0000 Subject: [Koha-bugs] [Bug 18120] REST API: CRUD endpoint for vendors In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18120 Matthias Meusburger changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #63146|0 |1 is obsolete| | --- Comment #10 from Matthias Meusburger --- Created attachment 63165 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=63165&action=edit Bug 18120: (followup) Make operationId unique This patch renames the method names, and the operationID on the swagger spec so they are unique. Signed-off-by: Tomas Cohen Arazi Signed-off-by: Matthias Meusburger -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri May 5 14:13:43 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 05 May 2017 12:13:43 +0000 Subject: [Koha-bugs] [Bug 18120] REST API: CRUD endpoint for vendors In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18120 Matthias Meusburger changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri May 5 14:45:04 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 05 May 2017 12:45:04 +0000 Subject: [Koha-bugs] [Bug 18549] There should be a warning that logging out of Koha will leave browser session logged in to OAuth In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18549 --- Comment #3 from M. Tompsett --- (In reply to Martin Renvoize from comment #2) > If we do go down that route, I feel we need to > impliment both ends in the same bug.. i.e. both our 'SLO caller' which needs > to be attached to the logout button and the 'SLO listener' which if memory > servers is a double iframe based hack in OpenID Connect. Or a simpler logout redirect. http://stackoverflow.com/questions/4202161/google-account-logout-and-redirect Though, I vaguely recall seeing the iframe business, and thinking, "YUCK!" The thought is a modal popup with a nice message explaining the two choices: Koha Only or Koha+Google. The first does the normal URL, the later does the redirect URL. Seem like a decent plan? -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri May 5 14:47:26 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 05 May 2017 12:47:26 +0000 Subject: [Koha-bugs] [Bug 18549] There should be a warning that logging out of Koha will leave browser session logged in to OAuth In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18549 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |jonathan.druart at bugs.koha-c | |ommunity.org -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri May 5 15:04:38 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 05 May 2017 13:04:38 +0000 Subject: [Koha-bugs] [Bug 18550] New: Patron card creator: Print output does not respect layout units Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18550 Bug ID: 18550 Summary: Patron card creator: Print output does not respect layout units Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: normal Priority: P5 - low Component: Label/patron card printing Assignee: cnighswonger at foundations.edu Reporter: veron at veron.ch QA Contact: testopia at bugs.koha-community.org Text, images and barcode positions are always layed out based on PostScript points, regardless of unit defined in card layout. To reproduce: - Test on top of Bug 18584 (introduces layout grid) - Create a card layout wir a text field, an image and barcode. Use points as layout unit - Activate layout grid - Create PDF output, save. - Change layout unit to mm. - Create PDF output, save. - Compare PDFs. Verify that the positions are unchanged. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri May 5 15:07:21 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 05 May 2017 13:07:21 +0000 Subject: [Koha-bugs] [Bug 18550] Patron card creator: Print output does not respect layout units In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18550 Marc V?ron changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|cnighswonger at foundations.ed |veron at veron.ch |u | Depends on| |18541 --- Comment #1 from Marc V?ron --- Please test on top of Bug 18541 - Patron card creator: Add a grid to support layout design Sorry for wrong bug number in intitial comment. Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18541 [Bug 18541] Patron card creator: Add a grid to support layout design -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri May 5 15:07:21 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 05 May 2017 13:07:21 +0000 Subject: [Koha-bugs] [Bug 18541] Patron card creator: Add a grid to support layout design In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18541 Marc V?ron changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |18550 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18550 [Bug 18550] Patron card creator: Print output does not respect layout units -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri May 5 15:11:43 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 05 May 2017 13:11:43 +0000 Subject: [Koha-bugs] [Bug 18276] Koha::Biblio - Remove GetBiblioFromItemNumber In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18276 --- Comment #38 from Jonathan Druart --- Created attachment 63166 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=63166&action=edit Bug 18276: (follow-up) Remove GetBiblioFromItemNumber - ILSDI Take into account biblio level holds -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri May 5 15:12:11 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 05 May 2017 13:12:11 +0000 Subject: [Koha-bugs] [Bug 18276] Koha::Biblio - Remove GetBiblioFromItemNumber In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18276 --- Comment #39 from Jonathan Druart --- (In reply to Josef Moravec from comment #36) > Works good for item level holds, with title level holds I see: > > "Can't call method "biblio" on an undefined value at > /home/vagrant/kohaclone/C4/ILSDI/Services.pm line 422" Great catch Josef! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri May 5 15:12:19 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 05 May 2017 13:12:19 +0000 Subject: [Koha-bugs] [Bug 18276] Koha::Biblio - Remove GetBiblioFromItemNumber In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18276 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri May 5 15:13:14 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 05 May 2017 13:13:14 +0000 Subject: [Koha-bugs] [Bug 18550] Patron card creator: Print output does not respect layout units In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18550 --- Comment #2 from Marc V?ron --- Created attachment 63167 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=63167&action=edit Bug 18550 - Patron card creator: Print output does not respect layout units To reproduce: Text, images and barcode positions are always layed out based on PostScript points, regardless of unit defined in card layout. To reproduce: - Test on top of Bug 18541 (introduces layout grid) - Create a card layout wir a text field, an image and barcode. Use points as layout unit - Activate layout grid - Create PDF output, save. - Change layout unit to mm. - Create PDF output, save. - Compare PDFs. Verify that the positions are unchanged (still using points). - Apply patch - Create again PDF - Verify that elements are positionad as expected (using unit, e.g. mm) Note: Patch not yet ready to sign-off because of som e c/p, but tests are welcome. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri May 5 15:13:43 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 05 May 2017 13:13:43 +0000 Subject: [Koha-bugs] [Bug 18468] When adding from a staged file order discounts are not passed into C4:: Acquisitions::populate_order_with_prices In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18468 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |katrin.fischer at bsz-bw.de --- Comment #6 from Jonathan Druart --- (In reply to jmbroust from comment #5) > Hello, I'm into testing Koha 16.11.06 and i noticed the same problem. Can > this patch be backported to 16.11 or shall I open a new bug ? Thanx. Ccing Katrin, Rmaint 16.11. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri May 5 15:28:12 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 05 May 2017 13:28:12 +0000 Subject: [Koha-bugs] [Bug 18242] Remove primary key on old_issues.issue_id In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18242 --- Comment #20 from Jonathan Druart --- Created attachment 63168 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=63168&action=edit Bug 18242: 16.05 version - [SOLUTION 2]Add tests -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri May 5 15:28:16 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 05 May 2017 13:28:16 +0000 Subject: [Koha-bugs] [Bug 18242] Remove primary key on old_issues.issue_id In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18242 --- Comment #21 from Jonathan Druart --- Created attachment 63169 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=63169&action=edit Bug 18242: 16.05 version - [SOLUTION 2]Handle correctly move to old_issues The table old_issues has a primary key defined on the issue_id column. This issue_id comes from the issues table when an item is checked in. In some case the value of issue_id already exists in the table Basically this happens when an item is returned and mysqld is restarted: The auto increment value for issues.issue_id will be reset to MAX(issue_id)+1 (which is the value of the last entry of old_issues). See also the description of bug 18003 for more informations. In this solution the change is done at code level instead of DB structure: If old_issues.issue_id already exists before moving from the issues table, the issue_id is updated (not on cascade for accountlines.issue_id, should it?) before the move. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri May 5 15:28:20 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 05 May 2017 13:28:20 +0000 Subject: [Koha-bugs] [Bug 18242] Remove primary key on old_issues.issue_id In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18242 --- Comment #22 from Jonathan Druart --- Created attachment 63170 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=63170&action=edit Bug 18242: 16.05 version - 16.11.x adaptation - Old::Checkouts vs OldIssues -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri May 5 15:29:07 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 05 May 2017 13:29:07 +0000 Subject: [Koha-bugs] [Bug 18242] Remove primary key on old_issues.issue_id In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18242 --- Comment #23 from Jonathan Druart --- Last 3 patches are for 16.05.x I DID NOT TEST THEM! If you want them for 16.05.x, please test. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri May 5 15:51:15 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 05 May 2017 13:51:15 +0000 Subject: [Koha-bugs] [Bug 17944] Remove the sql code from itemtypes.pl administrative perl script In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17944 --- Comment #45 from Jonathan Druart --- Alex, great! The patch is much better :) Indeed the return value of can_be_deleted should be 1 or 0. You can achieve that with: return $nb_items + $nb_biblioitems == 0 ? 1 : 0; You will avoid the empty string return value. In the tests: The last test says 'An item type that is used by a biblioitem cannot be deleted'. But actually you are testing that "an item that is used by AN item AND A biblioitem cannot be deleted'. You should delete the item to make it test what you want to test. Finally you will need to update the admin script. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri May 5 15:51:42 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 05 May 2017 13:51:42 +0000 Subject: [Koha-bugs] [Bug 17944] Remove the sql code from itemtypes.pl administrative perl script In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17944 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |In Discussion --- Comment #46 from Jonathan Druart --- I am switching the status to 'in discussion' until it's ready to be tested. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri May 5 15:55:13 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 05 May 2017 13:55:13 +0000 Subject: [Koha-bugs] [Bug 18515] Use news based help system for OPAC In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18515 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |jonathan.druart at bugs.koha-c | |ommunity.org --- Comment #1 from Jonathan Druart --- Please wait for dependent patches before starting here. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri May 5 16:15:42 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 05 May 2017 14:15:42 +0000 Subject: [Koha-bugs] [Bug 18546] Add a 'Close' link to OPAC cart In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18546 --- Comment #1 from Owen Leonard --- It's there, but it's hidden because of a collision with Bootstrap's CSS: Hide window The "hide" class makes it disappear :( I'm glad someone noticed because I didn't! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri May 5 16:16:14 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 05 May 2017 14:16:14 +0000 Subject: [Koha-bugs] [Bug 18546] Unhide the 'Hide window' link in OPAC cart In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18546 Owen Leonard changed: What |Removed |Added ---------------------------------------------------------------------------- Severity|enhancement |normal Summary|Add a 'Close' link to OPAC |Unhide the 'Hide window' |cart |link in OPAC cart -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri May 5 16:24:00 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 05 May 2017 14:24:00 +0000 Subject: [Koha-bugs] [Bug 18551] New: Hide with CSS dynamic elements in member search Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18551 Bug ID: 18551 Summary: Hide with CSS dynamic elements in member search Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: minor Priority: P5 - low Component: Patrons Assignee: koha-bugs at lists.koha-community.org Reporter: fridolin.somers at biblibre.com QA Contact: testopia at bugs.koha-community.org CC: gmcharlt at gmail.com, kyle.m.hall at gmail.com In member search page, the result table is in Ajax so fully managed by Javascript. There is also a yellow dialog message prepared in HTML. Thoses elements are hidden by JS code : ie $("#patron_list_dialog").hide(). The problem is that the static page is first loaded an displayed then the JS code runs an hides the elements. On a low performance computer, this action is visible and looks like there is a blinking yellow message. I propose to hide with CSS so that thoses elements are not displayed in static page and are there shown in dynamic JS code. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri May 5 16:24:12 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 05 May 2017 14:24:12 +0000 Subject: [Koha-bugs] [Bug 18551] Hide with CSS dynamic elements in member search In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18551 Fridolin SOMERS changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|koha-bugs at lists.koha-commun |fridolin.somers at biblibre.co |ity.org |m -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Fri May 5 16:31:15 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 05 May 2017 14:31:15 +0000 Subject: [Koha-bugs] [Bug 18551] Hide with CSS dynamic elements in member search In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18551 Fridolin SOMERS changed: What |Removed |Added ---------------------------------------------------------------------------- Patch complexity|--- |Trivial patch Status|NEW |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri May 5 16:31:18 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 05 May 2017 14:31:18 +0000 Subject: [Koha-bugs] [Bug 18551] Hide with CSS dynamic elements in member search In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18551 --- Comment #1 from Fridolin SOMERS --- Created attachment 63171 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=63171&action=edit Bug 18551 - Hide with CSS dynamic elements in member search In member search page, the result table is in Ajax so fully managed by Javascript. There is also a yellow dialog message prepared in HTML. Thoses elements are hidden by JS code : ie $("#patron_list_dialog").hide(). The problem is that the static page is first loaded an displayed then the JS code runs an hides the elements. On a low performance computer, this action is visible and looks like there is a blinking yellow message. I propose to hide with CSS so that thoses elements are not displayed in static page and are there shown in dynamic JS code. Test plan : Check display is unchanged : - Go to home page /cgi-bin/koha/members/members-home.pl - Perform patron search from header search box - Perform patron search by clicking on a letter - Perform patron search from filters (left of results table) - Select a patron and add it to a list => you see the yellow message -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri May 5 16:51:54 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 05 May 2017 14:51:54 +0000 Subject: [Koha-bugs] [Bug 15406] Very SLOW OAI server performance In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15406 Tom?s Cohen Arazi changed: What |Removed |Added ---------------------------------------------------------------------------- Resolution|--- |DUPLICATE Status|In Discussion |RESOLVED CC| |tomascohen at gmail.com --- Comment #7 from Tom?s Cohen Arazi --- *** This bug has been marked as a duplicate of bug 15108 *** -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri May 5 16:51:54 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 05 May 2017 14:51:54 +0000 Subject: [Koha-bugs] [Bug 15108] OAI-PMH provider improvements In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15108 Tom?s Cohen Arazi changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |dhd.koha at gmail.com --- Comment #89 from Tom?s Cohen Arazi --- *** Bug 15406 has been marked as a duplicate of this bug. *** -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri May 5 16:51:56 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 05 May 2017 14:51:56 +0000 Subject: [Koha-bugs] [Bug 15342] Performance 3.22 - Omnibus In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15342 Bug 15342 depends on bug 15406, which changed state. Bug 15406 Summary: Very SLOW OAI server performance https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15406 What |Removed |Added ---------------------------------------------------------------------------- Status|In Discussion |RESOLVED Resolution|--- |DUPLICATE -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri May 5 17:00:48 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 05 May 2017 15:00:48 +0000 Subject: [Koha-bugs] [Bug 15108] OAI-PMH provider improvements In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15108 Tom?s Cohen Arazi changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #60331|0 |1 is obsolete| | --- Comment #90 from Tom?s Cohen Arazi --- Created attachment 63172 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=63172&action=edit Bug 15108: OAI-PMH provider improvements - Fixed date handling to use UTC as specs require. - Added support for second precision in time stamps. - Added support for marc21 metadata prefix as recommended in the guidelines (synonym for marcxml). - Improved performance of database queries especially for large collections. - Unified functionality of ListRecords and ListIdentifiers to a common base class. - If items are included in the records, their timestamps are taken into account everywhere so that whichever is the most recent (timestamp of biblioitem or any of its items) is considered the record's timestamp. - Fixed OAI.xslt to show correct record range. - Incorporated extended tests from Bug 17493 and their tweaks from Bug 15108. Signed-off-by: Josef Moravec Signed-off-by: Olli-Antti Kivilahti Signed-off-by: Tomas Cohen Arazi -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri May 5 17:01:11 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 05 May 2017 15:01:11 +0000 Subject: [Koha-bugs] [Bug 15108] OAI-PMH provider improvements In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15108 Tom?s Cohen Arazi changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #60608|0 |1 is obsolete| | Attachment #60836|0 |1 is obsolete| | --- Comment #91 from Tom?s Cohen Arazi --- Created attachment 63173 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=63173&action=edit Bug 15108: (followup) OAI-PMH provider improvements Fixed OAI-PMH Server tests to delete any existing issues before deleting biblios, to delete oai_sets to avoid sets in the responses and to work with UNIMARC and NORMARC as well as MARC21. Signed-off-by: Olli-Antti Kivilahti Signed-off-by: Tomas Cohen Arazi -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri May 5 17:01:22 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 05 May 2017 15:01:22 +0000 Subject: [Koha-bugs] [Bug 15108] OAI-PMH provider improvements In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15108 --- Comment #92 from Tom?s Cohen Arazi --- Created attachment 63174 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=63174&action=edit Bug 15108: (QA followup) Fix atomic update file Signed-off-by: Tomas Cohen Arazi -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri May 5 17:05:24 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 05 May 2017 15:05:24 +0000 Subject: [Koha-bugs] [Bug 15108] OAI-PMH provider improvements In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15108 Tom?s Cohen Arazi changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |tomascohen at gmail.com Status|Signed Off |Passed QA --- Comment #93 from Tom?s Cohen Arazi --- This patchset is a really cool improvement to our OAI server implementation. The patches themselves are not organized as we are pushing for, but the overall result (covered by more tests) and the speed improvement (plus the small fixes) are a good point, and the fact that Frederic has been looking after this one (I talked him about it personally) gives me the confidence that this is a good addition for the 17.05 release. Good job, Ere :-D -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri May 5 17:06:56 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 05 May 2017 15:06:56 +0000 Subject: [Koha-bugs] [Bug 7317] Add an Interlibrary Loan Module to Circulation and OPAC In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7317 --- Comment #43 from Alex Sassmannshausen --- Created attachment 63175 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=63175&action=edit Bug 7317: Add `USE Koha` to intranet-main.tt. * koha-tmpl/intranet-tmpl/prog/en/modules/intranet-main.tt: Add `USE Koha`. This is to be able to display link on ILLModule being enabled. Through use cases we have found that permissions to access staff ILL is very cumbersome. At some point we should add a per borrower category permission, rather than a per user permission. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri May 5 17:15:23 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 05 May 2017 15:15:23 +0000 Subject: [Koha-bugs] [Bug 18502] koha-shell broken on dev installs In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18502 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to Master --- Comment #5 from Jonathan Druart --- Pushed to master for 17.05, thanks! For GBSD we want kohadevboxes to be populated automatically. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri May 5 17:25:57 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 05 May 2017 15:25:57 +0000 Subject: [Koha-bugs] [Bug 7317] Add an Interlibrary Loan Module to Circulation and OPAC In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7317 --- Comment #44 from Alex Sassmannshausen --- Created attachment 63176 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=63176&action=edit Bug 7317: Add branch details to generic emails. * Koha/Illrequest.pm (generic_confirm): Add a branch details block at end of generic email template. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri May 5 17:27:41 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 05 May 2017 15:27:41 +0000 Subject: [Koha-bugs] [Bug 7317] Add an Interlibrary Loan Module to Circulation and OPAC In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7317 --- Comment #45 from Alex Sassmannshausen --- Hi Daphne (In reply to Daphne Hoolahan from comment #25) > I will also add a block with library details to the generic email template. > Probably just after the "Kind regards". What do you think? > > That's an excellent idea. I've now added logic for adding this kind of branch details block. Please feel free to test and let me know what you think! Alex -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri May 5 17:55:10 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 05 May 2017 15:55:10 +0000 Subject: [Koha-bugs] [Bug 18518] The staff interface "blink" for different actions after upgrading to Firefox 53 In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18518 Fridolin SOMERS changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |fridolin.somers at biblibre.co | |m -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri May 5 17:59:32 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 05 May 2017 15:59:32 +0000 Subject: [Koha-bugs] [Bug 18518] The staff interface "blink" for different actions after upgrading to Firefox 53 In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18518 --- Comment #10 from Fridolin SOMERS --- Oh I've proposed also a patch on Bug 18551. I've also hidden the table. Should I rebase my bug on this one or provide a followup in this one ? -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri May 5 17:59:53 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 05 May 2017 15:59:53 +0000 Subject: [Koha-bugs] [Bug 18551] Hide with CSS dynamic elements in member search In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18551 Fridolin SOMERS changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |https://bugs.koha-community | |.org/bugzilla3/show_bug.cgi | |?id=18518 --- Comment #2 from Fridolin SOMERS --- Ah maybe depends on 18518 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri May 5 17:59:53 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 05 May 2017 15:59:53 +0000 Subject: [Koha-bugs] [Bug 18518] The staff interface "blink" for different actions after upgrading to Firefox 53 In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18518 Fridolin SOMERS changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |https://bugs.koha-community | |.org/bugzilla3/show_bug.cgi | |?id=18551 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri May 5 18:00:04 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 05 May 2017 16:00:04 +0000 Subject: [Koha-bugs] [Bug 18551] Hide with CSS dynamic elements in member search In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18551 Fridolin SOMERS changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |In Discussion -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri May 5 18:01:20 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 05 May 2017 16:01:20 +0000 Subject: [Koha-bugs] [Bug 18548] running koha-create --request-db without an instance name should abort In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18548 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |jonathan.druart at bugs.koha-c | |ommunity.org --- Comment #5 from Jonathan Druart --- Josef, Regarding `git grep -i "missing instance" debian/scripts/` I'd suggest to follow the same pattern: [ $# -ge 1 ] || ( usage ; die "Missing instance name..." ) -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri May 5 18:03:48 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 05 May 2017 16:03:48 +0000 Subject: [Koha-bugs] [Bug 18137] REST API: Migrate from Mojolicious::Plugin:: Swagger2 to Mojolicious::Plugin::OpenAPI In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18137 --- Comment #54 from Tom?s Cohen Arazi --- Ok, I tested this successfully using: $ sudo cpanm Mojolicious at 7.31 $ sudo cpanm JSON::Validator at 0.96 $ sudo cpanm Mojolicious::Plugin::OpenAPI at 1.13 Tests pass: kohadev-koha at kohadevbox:/home/vagrant/kohaclone$ prove t/db_dependent/api/v1/ t/db_dependent/api/v1/auth.t ..... Use of uninitialized value $lasttime in numeric lt (<) at /home/vagrant/kohaclone/C4/Auth.pm line 1673. t/db_dependent/api/v1/auth.t ..... ok t/db_dependent/api/v1/cities.t ... ok t/db_dependent/api/v1/holds.t .... ok t/db_dependent/api/v1/patrons.t .. ok All tests successful. Files=4, Tests=31, 10 wallclock secs ( 0.05 usr 0.00 sys + 8.52 cusr 1.26 csys = 9.83 CPU) Result: PASS I also tested the API using Firefox's HttpRequester, with excellent results. I'm signing this patchset, but will wait for Mirko to tell about the deps, because otherwise we could end up breaking the stable release due to unpackaged dependencies. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri May 5 18:06:22 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 05 May 2017 16:06:22 +0000 Subject: [Koha-bugs] [Bug 18137] REST API: Migrate from Mojolicious::Plugin:: Swagger2 to Mojolicious::Plugin::OpenAPI In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18137 Tom?s Cohen Arazi changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #63025|0 |1 is obsolete| | --- Comment #55 from Tom?s Cohen Arazi --- Created attachment 63177 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=63177&action=edit Bug 18137: Add useful Koha::Exceptions Signed-off-by: Olli-Antti Kivilahti Signed-off-by: Josef Moravec Signed-off-by: Tomas Cohen Arazi -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri May 5 18:06:33 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 05 May 2017 16:06:33 +0000 Subject: [Koha-bugs] [Bug 18137] REST API: Migrate from Mojolicious::Plugin:: Swagger2 to Mojolicious::Plugin::OpenAPI In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18137 Tom?s Cohen Arazi changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #63026|0 |1 is obsolete| | --- Comment #56 from Tom?s Cohen Arazi --- Created attachment 63178 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=63178&action=edit Bug 18137: Migrate from Swagger2 to Mojolicious::Plugin::OpenAPI This patch migrates from Swagger2 to Mojolicious::Plugin::OpenAPI as Swagger2 is no longer actively maintained. This migration involves some minor changes to our Swagger specification documents and to controllers. Each operation is migrated in following patches separately. Please see Mojolicious::Plugin::OpenAPI and its tutorial for more documentation. The patch also refactors some API authentication -related code by taking advantage of Koha::Exceptions. Authentication is now handled via Mojolicious's "under->to" functionality. The actual authentication & authorization checks are moved to Koha::REST::V1::Auth. Added a HTTP 503 response for when database update is required, instead of returning an authentication failure as before. To test: 1. prove t/db_dependent/api/v1/auth.t Signed-off-by: Olli-Antti Kivilahti Signed-off-by: Josef Moravec Signed-off-by: Tomas Cohen Arazi -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri May 5 18:06:55 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 05 May 2017 16:06:55 +0000 Subject: [Koha-bugs] [Bug 18137] REST API: Migrate from Mojolicious::Plugin:: Swagger2 to Mojolicious::Plugin::OpenAPI In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18137 Tom?s Cohen Arazi changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #63029|0 |1 is obsolete| | --- Comment #58 from Tom?s Cohen Arazi --- Created attachment 63180 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=63180&action=edit Bug 18137: Make /cities Mojolicious::Plugin::OpenAPI compatible Also: - adding some missing and new response definitions into Swagger spec. To test: 1. prove t/db_dependent/api/v1/cities.t Signed-off-by: Olli-Antti Kivilahti Signed-off-by: Josef Moravec Signed-off-by: Tomas Cohen Arazi -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri May 5 18:06:45 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 05 May 2017 16:06:45 +0000 Subject: [Koha-bugs] [Bug 18137] REST API: Migrate from Mojolicious::Plugin:: Swagger2 to Mojolicious::Plugin::OpenAPI In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18137 Tom?s Cohen Arazi changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #63027|0 |1 is obsolete| | --- Comment #57 from Tom?s Cohen Arazi --- Created attachment 63179 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=63179&action=edit Bug 18137: Make /patrons Mojolicious::Plugin::OpenAPI compatible Also: - adding some missing and new response definitions into Swagger spec. - fixing failing test due to Bug 17932's change of boolean values To test: 1. prove t/db_dependent/api/v1/patrons.t Signed-off-by: Olli-Antti Kivilahti Signed-off-by: Josef Moravec Signed-off-by: Tomas Cohen Arazi -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri May 5 18:07:11 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 05 May 2017 16:07:11 +0000 Subject: [Koha-bugs] [Bug 18137] REST API: Migrate from Mojolicious::Plugin:: Swagger2 to Mojolicious::Plugin::OpenAPI In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18137 --- Comment #59 from Tom?s Cohen Arazi --- Created attachment 63181 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=63181&action=edit Bug 18137: Make /holds Mojolicious::Plugin::OpenAPI compatible Also - adding some missing and new response definitions into Swagger spec. - fixing failing tests due to Bug 17932's change of boolean values To test: 1. prove t/db_dependent/api/v1/holds.t Signed-off-by: Olli-Antti Kivilahti Signed-off-by: Josef Moravec Signed-off-by: Tomas Cohen Arazi -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri May 5 18:07:21 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 05 May 2017 16:07:21 +0000 Subject: [Koha-bugs] [Bug 18137] REST API: Migrate from Mojolicious::Plugin:: Swagger2 to Mojolicious::Plugin::OpenAPI In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18137 --- Comment #60 from Tom?s Cohen Arazi --- Created attachment 63182 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=63182&action=edit Bug 18137: Remove x-mojo-around-action Mojolicious::Plugin::OpenAPI does not support x-mojo-around action. This patch removes it from our specification document. Signed-off-by: Olli-Antti Kivilahti Signed-off-by: Josef Moravec Signed-off-by: Tomas Cohen Arazi -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri May 5 18:07:32 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 05 May 2017 16:07:32 +0000 Subject: [Koha-bugs] [Bug 18137] REST API: Migrate from Mojolicious::Plugin:: Swagger2 to Mojolicious::Plugin::OpenAPI In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18137 Tom?s Cohen Arazi changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #63030|0 |1 is obsolete| | --- Comment #61 from Tom?s Cohen Arazi --- Created attachment 63183 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=63183&action=edit Bug 18137: (follow-up) Fix handling DBIx::Class::Exception messages - DBIx::Class::Exception should use ->{msg} Signed-off-by: Josef Moravec Signed-off-by: Tomas Cohen Arazi -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri May 5 18:07:43 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 05 May 2017 16:07:43 +0000 Subject: [Koha-bugs] [Bug 18137] REST API: Migrate from Mojolicious::Plugin:: Swagger2 to Mojolicious::Plugin::OpenAPI In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18137 Tom?s Cohen Arazi changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #63031|0 |1 is obsolete| | --- Comment #62 from Tom?s Cohen Arazi --- Created attachment 63184 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=63184&action=edit Bug 18137: (QA-follow-up) Fix pod fail Signed-off-by: Josef Moravec Signed-off-by: Tomas Cohen Arazi -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri May 5 18:07:53 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 05 May 2017 16:07:53 +0000 Subject: [Koha-bugs] [Bug 18137] REST API: Migrate from Mojolicious::Plugin:: Swagger2 to Mojolicious::Plugin::OpenAPI In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18137 Tom?s Cohen Arazi changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #63032|0 |1 is obsolete| | --- Comment #63 from Tom?s Cohen Arazi --- Created attachment 63185 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=63185&action=edit Bug 18137: (follow-up) Sort definitions.json Before this file grows, we should sort it alphabetically. To test: 1. prove t/db_dependent/api/v1 Signed-off-by: Josef Moravec Signed-off-by: Tomas Cohen Arazi -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri May 5 18:08:05 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 05 May 2017 16:08:05 +0000 Subject: [Koha-bugs] [Bug 18137] REST API: Migrate from Mojolicious::Plugin:: Swagger2 to Mojolicious::Plugin::OpenAPI In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18137 Tom?s Cohen Arazi changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #63034|0 |1 is obsolete| | --- Comment #64 from Tom?s Cohen Arazi --- Created attachment 63186 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=63186&action=edit Bug 18137: List Mojolicious::Plugin::OpenAPI and JSON::Validator as dependencies Signed-off-by: Olli-Antti Kivilahti Signed-off-by: Josef Moravec Signed-off-by: Tomas Cohen Arazi -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri May 5 18:08:58 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 05 May 2017 16:08:58 +0000 Subject: [Koha-bugs] [Bug 18137] REST API: Migrate from Mojolicious::Plugin:: Swagger2 to Mojolicious::Plugin::OpenAPI In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18137 Tom?s Cohen Arazi changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #63028|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri May 5 18:09:20 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 05 May 2017 16:09:20 +0000 Subject: [Koha-bugs] [Bug 18137] REST API: Migrate from Mojolicious::Plugin:: Swagger2 to Mojolicious::Plugin::OpenAPI In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18137 Tom?s Cohen Arazi changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #63033|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri May 5 18:09:29 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 05 May 2017 16:09:29 +0000 Subject: [Koha-bugs] [Bug 18137] REST API: Migrate from Mojolicious::Plugin:: Swagger2 to Mojolicious::Plugin::OpenAPI In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18137 Tom?s Cohen Arazi changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #63177|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri May 5 18:09:37 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 05 May 2017 16:09:37 +0000 Subject: [Koha-bugs] [Bug 18137] REST API: Migrate from Mojolicious::Plugin:: Swagger2 to Mojolicious::Plugin::OpenAPI In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18137 Tom?s Cohen Arazi changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #63178|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri May 5 18:09:44 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 05 May 2017 16:09:44 +0000 Subject: [Koha-bugs] [Bug 18137] REST API: Migrate from Mojolicious::Plugin:: Swagger2 to Mojolicious::Plugin::OpenAPI In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18137 Tom?s Cohen Arazi changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #63179|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri May 5 18:09:52 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 05 May 2017 16:09:52 +0000 Subject: [Koha-bugs] [Bug 18137] REST API: Migrate from Mojolicious::Plugin:: Swagger2 to Mojolicious::Plugin::OpenAPI In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18137 Tom?s Cohen Arazi changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #63180|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri May 5 18:10:08 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 05 May 2017 16:10:08 +0000 Subject: [Koha-bugs] [Bug 18137] REST API: Migrate from Mojolicious::Plugin:: Swagger2 to Mojolicious::Plugin::OpenAPI In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18137 Tom?s Cohen Arazi changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #63182|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri May 5 18:10:00 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 05 May 2017 16:10:00 +0000 Subject: [Koha-bugs] [Bug 18137] REST API: Migrate from Mojolicious::Plugin:: Swagger2 to Mojolicious::Plugin::OpenAPI In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18137 Tom?s Cohen Arazi changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #63181|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri May 5 18:10:18 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 05 May 2017 16:10:18 +0000 Subject: [Koha-bugs] [Bug 18137] REST API: Migrate from Mojolicious::Plugin:: Swagger2 to Mojolicious::Plugin::OpenAPI In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18137 Tom?s Cohen Arazi changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #63183|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri May 5 18:10:21 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 05 May 2017 16:10:21 +0000 Subject: [Koha-bugs] [Bug 18450] Renew in header bypasses hold block and renewal limits In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18450 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Failed QA CC| |jonathan.druart at bugs.koha-c | |ommunity.org -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri May 5 18:10:26 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 05 May 2017 16:10:26 +0000 Subject: [Koha-bugs] [Bug 18137] REST API: Migrate from Mojolicious::Plugin:: Swagger2 to Mojolicious::Plugin::OpenAPI In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18137 Tom?s Cohen Arazi changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #63184|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri May 5 18:10:34 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 05 May 2017 16:10:34 +0000 Subject: [Koha-bugs] [Bug 18137] REST API: Migrate from Mojolicious::Plugin:: Swagger2 to Mojolicious::Plugin::OpenAPI In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18137 Tom?s Cohen Arazi changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #63185|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri May 5 18:10:42 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 05 May 2017 16:10:42 +0000 Subject: [Koha-bugs] [Bug 18137] REST API: Migrate from Mojolicious::Plugin:: Swagger2 to Mojolicious::Plugin::OpenAPI In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18137 Tom?s Cohen Arazi changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #63186|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri May 5 18:11:12 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 05 May 2017 16:11:12 +0000 Subject: [Koha-bugs] [Bug 18137] REST API: Migrate from Mojolicious::Plugin:: Swagger2 to Mojolicious::Plugin::OpenAPI In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18137 --- Comment #65 from Tom?s Cohen Arazi --- I messed up with the packages/obsoletes, re-submitting. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri May 5 18:11:33 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 05 May 2017 16:11:33 +0000 Subject: [Koha-bugs] [Bug 18137] REST API: Migrate from Mojolicious::Plugin:: Swagger2 to Mojolicious::Plugin::OpenAPI In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18137 --- Comment #66 from Tom?s Cohen Arazi --- Created attachment 63187 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=63187&action=edit Bug 18137: Add useful Koha::Exceptions Signed-off-by: Olli-Antti Kivilahti Signed-off-by: Josef Moravec Signed-off-by: Tomas Cohen Arazi -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri May 5 18:11:39 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 05 May 2017 16:11:39 +0000 Subject: [Koha-bugs] [Bug 18137] REST API: Migrate from Mojolicious::Plugin:: Swagger2 to Mojolicious::Plugin::OpenAPI In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18137 --- Comment #67 from Tom?s Cohen Arazi --- Created attachment 63188 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=63188&action=edit Bug 18137: Migrate from Swagger2 to Mojolicious::Plugin::OpenAPI This patch migrates from Swagger2 to Mojolicious::Plugin::OpenAPI as Swagger2 is no longer actively maintained. This migration involves some minor changes to our Swagger specification documents and to controllers. Each operation is migrated in following patches separately. Please see Mojolicious::Plugin::OpenAPI and its tutorial for more documentation. The patch also refactors some API authentication -related code by taking advantage of Koha::Exceptions. Authentication is now handled via Mojolicious's "under->to" functionality. The actual authentication & authorization checks are moved to Koha::REST::V1::Auth. Added a HTTP 503 response for when database update is required, instead of returning an authentication failure as before. To test: 1. prove t/db_dependent/api/v1/auth.t Signed-off-by: Olli-Antti Kivilahti Signed-off-by: Josef Moravec Signed-off-by: Tomas Cohen Arazi -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri May 5 18:11:44 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 05 May 2017 16:11:44 +0000 Subject: [Koha-bugs] [Bug 18137] REST API: Migrate from Mojolicious::Plugin:: Swagger2 to Mojolicious::Plugin::OpenAPI In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18137 --- Comment #68 from Tom?s Cohen Arazi --- Created attachment 63189 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=63189&action=edit Bug 18137: Make /patrons Mojolicious::Plugin::OpenAPI compatible Also: - adding some missing and new response definitions into Swagger spec. - fixing failing test due to Bug 17932's change of boolean values To test: 1. prove t/db_dependent/api/v1/patrons.t Signed-off-by: Olli-Antti Kivilahti Signed-off-by: Josef Moravec Signed-off-by: Tomas Cohen Arazi -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri May 5 18:11:49 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 05 May 2017 16:11:49 +0000 Subject: [Koha-bugs] [Bug 18137] REST API: Migrate from Mojolicious::Plugin:: Swagger2 to Mojolicious::Plugin::OpenAPI In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18137 --- Comment #69 from Tom?s Cohen Arazi --- Created attachment 63190 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=63190&action=edit Bug 18137: Make /cities Mojolicious::Plugin::OpenAPI compatible Also: - adding some missing and new response definitions into Swagger spec. To test: 1. prove t/db_dependent/api/v1/cities.t Signed-off-by: Olli-Antti Kivilahti Signed-off-by: Josef Moravec Signed-off-by: Tomas Cohen Arazi -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri May 5 18:11:54 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 05 May 2017 16:11:54 +0000 Subject: [Koha-bugs] [Bug 18137] REST API: Migrate from Mojolicious::Plugin:: Swagger2 to Mojolicious::Plugin::OpenAPI In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18137 --- Comment #70 from Tom?s Cohen Arazi --- Created attachment 63191 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=63191&action=edit Bug 18137: Make /holds Mojolicious::Plugin::OpenAPI compatible Also - adding some missing and new response definitions into Swagger spec. - fixing failing tests due to Bug 17932's change of boolean values To test: 1. prove t/db_dependent/api/v1/holds.t Signed-off-by: Olli-Antti Kivilahti Signed-off-by: Josef Moravec Signed-off-by: Tomas Cohen Arazi -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri May 5 18:11:59 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 05 May 2017 16:11:59 +0000 Subject: [Koha-bugs] [Bug 18137] REST API: Migrate from Mojolicious::Plugin:: Swagger2 to Mojolicious::Plugin::OpenAPI In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18137 --- Comment #71 from Tom?s Cohen Arazi --- Created attachment 63192 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=63192&action=edit Bug 18137: Remove x-mojo-around-action Mojolicious::Plugin::OpenAPI does not support x-mojo-around action. This patch removes it from our specification document. Signed-off-by: Olli-Antti Kivilahti Signed-off-by: Josef Moravec Signed-off-by: Tomas Cohen Arazi -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri May 5 18:12:03 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 05 May 2017 16:12:03 +0000 Subject: [Koha-bugs] [Bug 18137] REST API: Migrate from Mojolicious::Plugin:: Swagger2 to Mojolicious::Plugin::OpenAPI In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18137 --- Comment #72 from Tom?s Cohen Arazi --- Created attachment 63193 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=63193&action=edit Bug 18137: (follow-up) Fix handling DBIx::Class::Exception messages - DBIx::Class::Exception should use ->{msg} Signed-off-by: Josef Moravec Signed-off-by: Tomas Cohen Arazi -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri May 5 18:12:08 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 05 May 2017 16:12:08 +0000 Subject: [Koha-bugs] [Bug 18137] REST API: Migrate from Mojolicious::Plugin:: Swagger2 to Mojolicious::Plugin::OpenAPI In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18137 --- Comment #73 from Tom?s Cohen Arazi --- Created attachment 63194 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=63194&action=edit Bug 18137: (QA-follow-up) Fix pod fail Signed-off-by: Josef Moravec Signed-off-by: Tomas Cohen Arazi -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri May 5 18:12:18 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 05 May 2017 16:12:18 +0000 Subject: [Koha-bugs] [Bug 18137] REST API: Migrate from Mojolicious::Plugin:: Swagger2 to Mojolicious::Plugin::OpenAPI In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18137 --- Comment #75 from Tom?s Cohen Arazi --- Created attachment 63196 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=63196&action=edit Bug 18137: List Mojolicious::Plugin::OpenAPI and JSON::Validator as dependencies Signed-off-by: Olli-Antti Kivilahti Signed-off-by: Josef Moravec Signed-off-by: Tomas Cohen Arazi -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri May 5 18:12:13 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 05 May 2017 16:12:13 +0000 Subject: [Koha-bugs] [Bug 18137] REST API: Migrate from Mojolicious::Plugin:: Swagger2 to Mojolicious::Plugin::OpenAPI In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18137 --- Comment #74 from Tom?s Cohen Arazi --- Created attachment 63195 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=63195&action=edit Bug 18137: (follow-up) Sort definitions.json Before this file grows, we should sort it alphabetically. To test: 1. prove t/db_dependent/api/v1 Signed-off-by: Josef Moravec Signed-off-by: Tomas Cohen Arazi -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri May 5 19:56:49 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 05 May 2017 17:56:49 +0000 Subject: [Koha-bugs] [Bug 18552] New: Borrower debarments do not show on member detail page. Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18552 Bug ID: 18552 Summary: Borrower debarments do not show on member detail page. Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Patrons Assignee: koha-bugs at lists.koha-community.org Reporter: barton at bywatersolutions.com QA Contact: testopia at bugs.koha-community.org CC: gmcharlt at gmail.com, kyle.m.hall at gmail.com To re-create: 1) Scan a borrower's cardnumber into the 'Check out' text area on the main page. 2) Click on the restrictions tab and set a manual restriction. 3) This will show Restricted: Patron's account is restricted until xxx with the explanation: yyyy 4) Click on the 'details' tab on the left. The restriction message shows at the top of the page, but 5) Click on the restrictions tab on the bottom of the page, the text under that tab shows: Patron is currently unrestricted. Add manual restriction I have replicated this issue in 16.11 and master. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri May 5 19:57:26 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 05 May 2017 17:57:26 +0000 Subject: [Koha-bugs] [Bug 18552] Borrower debarments do not show on member detail page. In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18552 Barton Chittenden changed: What |Removed |Added ---------------------------------------------------------------------------- Severity|enhancement |normal -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Fri May 5 20:20:24 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 05 May 2017 18:20:24 +0000 Subject: [Koha-bugs] [Bug 12532] Redirect guarantee email to guarantor In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12532 --- Comment #47 from Philippe Audet-Fortin --- Created attachment 63197 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=63197&action=edit Delete a dupilcated row in systempreferences table Deleted RedirectGuaranteeEmail from systempreference table. Both RedirectGuaranteeEmail and EnableRedirectGuaranteeEmail were use for the same raison and RedirectGuaranteeEmail was only use for test. Repalced all occurences with EnableRedirectGuaranteeEmail. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri May 5 20:32:07 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 05 May 2017 18:32:07 +0000 Subject: [Koha-bugs] [Bug 18548] running koha-create --request-db without an instance name should abort In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18548 Josef Moravec changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |ASSIGNED --- Comment #6 from Josef Moravec --- (In reply to Jonathan Druart from comment #5) > Josef, > Regarding `git grep -i "missing instance" debian/scripts/` I'd suggest to > follow the same pattern: > [ $# -ge 1 ] || ( usage ; die "Missing instance name..." ) thanks Jonathan, I'll make new patch... -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri May 5 21:22:07 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 05 May 2017 19:22:07 +0000 Subject: [Koha-bugs] [Bug 18549] There should be a warning that logging out of Koha will leave browser session logged in to OAuth In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18549 --- Comment #4 from M. Tompsett --- Created attachment 63198 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=63198&action=edit Bug 18549: Provide logout modal dialogue I'm sure someone else could make the bootstrap and javascript prettier. However, this functions. TEST PLAN --------- 1) log in with Google OAuth and log out -- notice if you click login again, you continue as if you never logged out. This is because the current log out is a Koha only logout. 2) apply patch 3) log in with Google OAuth and log out 4) click 'Koha only' 5) log in with Google OAuth -- same continuation as before. 6) log out, but click 'Koha and Google' 7) log in with Google OAuth -- authentication is required again 8) koha qa test tools -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri May 5 21:22:03 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 05 May 2017 19:22:03 +0000 Subject: [Koha-bugs] [Bug 18549] There should be a warning that logging out of Koha will leave browser session logged in to OAuth In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18549 M. Tompsett changed: What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri May 5 22:21:26 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 05 May 2017 20:21:26 +0000 Subject: [Koha-bugs] [Bug 17762] Ability to translate notices In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17762 Nick Clemens changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri May 5 22:21:28 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 05 May 2017 20:21:28 +0000 Subject: [Koha-bugs] [Bug 17762] Ability to translate notices In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17762 Nick Clemens changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #61614|0 |1 is obsolete| | Attachment #61615|0 |1 is obsolete| | Attachment #61616|0 |1 is obsolete| | Attachment #61617|0 |1 is obsolete| | Attachment #61618|0 |1 is obsolete| | Attachment #61619|0 |1 is obsolete| | Attachment #61620|0 |1 is obsolete| | Attachment #61621|0 |1 is obsolete| | Attachment #61622|0 |1 is obsolete| | Attachment #61623|0 |1 is obsolete| | Attachment #61624|0 |1 is obsolete| | --- Comment #43 from Nick Clemens --- Created attachment 63199 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=63199&action=edit Bug 17762: DB changes - Add new 'lang' columns to letter and borrowers tables Sponsored-by: Orex Digital Signed-off-by: Hugo Agud Signed-off-by: Nick Clemens -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri May 5 22:21:33 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 05 May 2017 20:21:33 +0000 Subject: [Koha-bugs] [Bug 17762] Ability to translate notices In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17762 --- Comment #44 from Nick Clemens --- Created attachment 63200 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=63200&action=edit Bug 17762: Add the new TranslateNotices syspref This whole patch set adds the ability to translate notices in different languages. That way, if a library has patrons from different countries, they will not have to send the notices in only one language but they will be able to translate them. Test plan: - Switch on TranslateNotices - Translate the interface in different languages - Edit patron's details => You should see a new "prefered language" entry That language will be used to send notices to this patron - Edit several notice templates => You should see different tabs, 1 tab per language translated at the opac (which sounds to make sense) - Now the notice generated for this patron should be the one translated in the language picked for him To confirm that, try to generate several notices for this patron. If the notice is not translated, the default one should be used. Sponsored-by: Orex Digital Signed-off-by: Hugo Agud Signed-off-by: Nick Clemens -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri May 5 22:21:36 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 05 May 2017 20:21:36 +0000 Subject: [Koha-bugs] [Bug 17762] Ability to translate notices In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17762 --- Comment #45 from Nick Clemens --- Created attachment 63201 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=63201&action=edit Bug 17762: Add the lang attribute to the patron form Not the opac because we do not want the patron to modify it, they won't be necessary translated. Sponsored-by: Orex Digital Signed-off-by: Hugo Agud Signed-off-by: Nick Clemens -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri May 5 22:21:40 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 05 May 2017 20:21:40 +0000 Subject: [Koha-bugs] [Bug 17762] Ability to translate notices In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17762 --- Comment #46 from Nick Clemens --- Created attachment 63202 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=63202&action=edit Bug 17762: Remove FK on message_transports I don't really understand where does come from this foreign key but at first glance it does not make sense. Note that it seems we could also remove message_transports.branchcode Sponsored-by: Orex Digital Signed-off-by: Hugo Agud Signed-off-by: Nick Clemens -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri May 5 22:21:44 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 05 May 2017 20:21:44 +0000 Subject: [Koha-bugs] [Bug 17762] Ability to translate notices In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17762 --- Comment #47 from Nick Clemens --- Created attachment 63203 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=63203&action=edit Bug 17762: Add lang to the PK of letter We need to enlarge the PK of the letter table. Sponsored-by: Orex Digital Signed-off-by: Hugo Agud Signed-off-by: Nick Clemens -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri May 5 22:21:48 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 05 May 2017 20:21:48 +0000 Subject: [Koha-bugs] [Bug 17762] Ability to translate notices In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17762 --- Comment #48 from Nick Clemens --- Created attachment 63204 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=63204&action=edit Bug 17762: Update the letter form interface If the pref is on, the notice template will be translatable in different languages Sponsored-by: Orex Digital Signed-off-by: Hugo Agud Signed-off-by: Nick Clemens -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri May 5 22:21:55 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 05 May 2017 20:21:55 +0000 Subject: [Koha-bugs] [Bug 17762] Ability to translate notices In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17762 --- Comment #49 from Nick Clemens --- Created attachment 63205 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=63205&action=edit Bug 17762: Send lang to GetPreparedLetter This patch set the lang parameter when C4::Letters::GetPreparedLetter is called to generate the notice. Note that we do not need to pass it if want_librarian is set. TODO: I do not know what to do with TransferSlip Sponsored-by: Orex Digital Signed-off-by: Hugo Agud Signed-off-by: Nick Clemens -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri May 5 22:22:03 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 05 May 2017 20:22:03 +0000 Subject: [Koha-bugs] [Bug 17762] Ability to translate notices In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17762 --- Comment #51 from Nick Clemens --- Created attachment 63207 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=63207&action=edit Bug 17762: Fix sql fields insertion The "Insert ->" buttons used to copy the sql field to the textarea was based on the id of the fieldset. This id has to be unique to work as expected. It is now composed of mtt + lang instead of mtt only Signed-off-by: Hugo Agud Signed-off-by: Nick Clemens -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri May 5 22:22:11 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 05 May 2017 20:22:11 +0000 Subject: [Koha-bugs] [Bug 17762] Ability to translate notices In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17762 --- Comment #52 from Nick Clemens --- Created attachment 63208 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=63208&action=edit Bug 17762: Fix test for NewsChannels.t Signed-off-by: Nick Clemens -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri May 5 22:22:15 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 05 May 2017 20:22:15 +0000 Subject: [Koha-bugs] [Bug 17762] Ability to translate notices In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17762 --- Comment #53 from Nick Clemens --- Created attachment 63209 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=63209&action=edit Bug 17762: DBIC Schema changes Signed-off-by: Nick Clemens -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri May 5 22:21:59 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 05 May 2017 20:21:59 +0000 Subject: [Koha-bugs] [Bug 17762] Ability to translate notices In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17762 --- Comment #50 from Nick Clemens --- Created attachment 63206 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=63206&action=edit Bug 17762: Add the lang parameter to C4::Letters::getletter Sponsored-by: Orex Digital Signed-off-by: Hugo Agud Signed-off-by: Nick Clemens -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri May 5 22:22:19 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 05 May 2017 20:22:19 +0000 Subject: [Koha-bugs] [Bug 17762] Ability to translate notices In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17762 --- Comment #54 from Nick Clemens --- Created attachment 63210 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=63210&action=edit Bug 17762 (QA Followup) Use default lang if pref disabled -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri May 5 22:22:23 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 05 May 2017 20:22:23 +0000 Subject: [Koha-bugs] [Bug 17762] Ability to translate notices In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17762 --- Comment #55 from Nick Clemens --- Created attachment 63211 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=63211&action=edit Bug 17762 (QA Followup) Fix Letters.t - add lang to fixtures -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri May 5 22:24:29 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 05 May 2017 20:24:29 +0000 Subject: [Koha-bugs] [Bug 17762] Ability to translate notices In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17762 Nick Clemens changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |nick at bywatersolutions.com --- Comment #56 from Nick Clemens --- All looks good, I added a followup so that we don't send translated notices if the pref is off. One question, you have: a/members/moremember.pl 335 # Display the language description instead of the code 336 # Note that this is certainly wrong It seems to work, why is it wrong? -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri May 5 22:30:21 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 05 May 2017 20:30:21 +0000 Subject: [Koha-bugs] [Bug 18549] There should be a warning that logging out of Koha will leave browser session logged in to OAuth In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18549 Nick Clemens changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri May 5 22:30:23 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 05 May 2017 20:30:23 +0000 Subject: [Koha-bugs] [Bug 18549] There should be a warning that logging out of Koha will leave browser session logged in to OAuth In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18549 Nick Clemens changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #63198|0 |1 is obsolete| | --- Comment #5 from Nick Clemens --- Created attachment 63212 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=63212&action=edit Bug 18549: Provide logout modal dialogue I'm sure someone else could make the bootstrap and javascript prettier. However, this functions. TEST PLAN --------- 1) log in with Google OAuth and log out -- notice if you click login again, you continue as if you never logged out. This is because the current log out is a Koha only logout. 2) apply patch 3) log in with Google OAuth and log out 4) click 'Koha only' 5) log in with Google OAuth -- same continuation as before. 6) log out, but click 'Koha and Google' 7) log in with Google OAuth -- authentication is required again 8) koha qa test tools Signed-off-by: Nick Clemens -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri May 5 22:37:31 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 05 May 2017 20:37:31 +0000 Subject: [Koha-bugs] [Bug 18267] Update price and tax fields in EDI to reflect DB changes In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18267 Nick Clemens changed: What |Removed |Added ---------------------------------------------------------------------------- Severity|enhancement |normal QA Contact|testopia at bugs.koha-communit |kyle at bywatersolutions.com |y.org | CC| |nick at bywatersolutions.com --- Comment #8 from Nick Clemens --- Marking as bug, asking Kyle to look as he is working with EDI -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri May 5 22:42:20 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 05 May 2017 20:42:20 +0000 Subject: [Koha-bugs] [Bug 17812] Return focus to barcode field after toggling on-site checkouts In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17812 Nick Clemens changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri May 5 22:42:24 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 05 May 2017 20:42:24 +0000 Subject: [Koha-bugs] [Bug 17812] Return focus to barcode field after toggling on-site checkouts In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17812 Nick Clemens changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #63145|0 |1 is obsolete| | --- Comment #8 from Nick Clemens --- Created attachment 63213 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=63213&action=edit Bug 17812 - Return focus to barcode field after toggling on-site checkouts This patch changes the behavior of the checkout form so that after checking boxes in the "checkout settings" panel the cursor focus is automatically moved to the barcode field. To test, apply the patch and enable OnSiteCheckouts and decreaseLoanHighHolds system preferences. - Open any patron account in circulation. - Expand the "Checkout settings" panel. - Click the label or checkbox for "Automatic renewal", "Don't decrease checkout length based on holds" and "On-site checkout" - Confirm that the focus has moved to the barcode field. Works as advertised. Signed-off-by: Marc V?ron Signed-off-by: Marjorie Barry-Vila Signed-off-by: Nick Clemens -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri May 5 22:42:51 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 05 May 2017 20:42:51 +0000 Subject: [Koha-bugs] [Bug 12446] Enable an adult to have a guarantor In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12446 --- Comment #49 from Philippe Audet-Fortin --- Created attachment 63214 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=63214&action=edit ID change for jQuery listener In modules/common/patron_search.tt, jQuery was listenning for #borrower_data but should have listen for #guarantor_data. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri May 5 22:43:36 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 05 May 2017 20:43:36 +0000 Subject: [Koha-bugs] [Bug 18538] OPAC database user login internal server error In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18538 Nick Clemens changed: What |Removed |Added ---------------------------------------------------------------------------- Severity|enhancement |normal CC| |nick at bywatersolutions.com -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri May 5 22:43:55 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 05 May 2017 20:43:55 +0000 Subject: [Koha-bugs] [Bug 18444] Add TalkingTechItivaPhoneNotification to sysprefs.sql In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18444 Nick Clemens changed: What |Removed |Added ---------------------------------------------------------------------------- Severity|enhancement |normal CC| |nick at bywatersolutions.com -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri May 5 23:19:27 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 05 May 2017 21:19:27 +0000 Subject: [Koha-bugs] [Bug 18553] New: Incorrect "Loading..." tag on moremember.tt when no clubs defined Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18553 Bug ID: 18553 Summary: Incorrect "Loading..." tag on moremember.tt when no clubs defined Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: minor Priority: P5 - low Component: Patrons Assignee: koha-bugs at lists.koha-community.org Reporter: nick at bywatersolutions.com QA Contact: testopia at bugs.koha-community.org CC: gmcharlt at gmail.com, kyle.m.hall at gmail.com -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri May 5 23:22:18 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 05 May 2017 21:22:18 +0000 Subject: [Koha-bugs] [Bug 18553] Incorrect "Loading..." tag on moremember.tt when no clubs defined In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18553 Nick Clemens changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri May 5 23:22:20 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 05 May 2017 21:22:20 +0000 Subject: [Koha-bugs] [Bug 18553] Incorrect "Loading..." tag on moremember.tt when no clubs defined In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18553 --- Comment #1 from Nick Clemens --- Created attachment 63215 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=63215&action=edit Bug 18553 - Incorrect "Loading..." tag on moremember.tt when no clubs defined To test: 1 - Have no clubs 2 - View Details tab for a patron 3 - Note the 'Loading' tag near the tabs 4 - Apply patch 5 - Load patron details and notice 'Loading' is gone 6 - Add a club and verify tab shows as expected -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Fri May 5 23:22:48 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 05 May 2017 21:22:48 +0000 Subject: [Koha-bugs] [Bug 18553] Incorrect "Loading..." tag on moremember.tt when no clubs defined In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18553 Nick Clemens changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|koha-bugs at lists.koha-commun |nick at bywatersolutions.com |ity.org | Patch complexity|--- |Trivial patch Depends on| |12461 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12461 [Bug 12461] Add patron clubs feature -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Fri May 5 23:22:48 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 05 May 2017 21:22:48 +0000 Subject: [Koha-bugs] [Bug 12461] Add patron clubs feature In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12461 Nick Clemens changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |18553 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18553 [Bug 18553] Incorrect "Loading..." tag on moremember.tt when no clubs defined -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat May 6 04:59:58 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 06 May 2017 02:59:58 +0000 Subject: [Koha-bugs] [Bug 18553] Incorrect "Loading..." tag on moremember.tt when no clubs defined In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18553 M. Tompsett changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat May 6 05:00:00 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 06 May 2017 03:00:00 +0000 Subject: [Koha-bugs] [Bug 18553] Incorrect "Loading..." tag on moremember.tt when no clubs defined In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18553 M. Tompsett changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #63215|0 |1 is obsolete| | --- Comment #2 from M. Tompsett --- Created attachment 63216 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=63216&action=edit Bug 18553 - Incorrect "Loading..." tag on moremember.tt when no clubs defined To test: 1 - Have no clubs 2 - View Details tab for a patron 3 - Note the 'Loading' tag near the tabs 4 - Apply patch 5 - Load patron details and notice 'Loading' is gone 6 - Add a club and verify tab shows as expected Signed-off-by: Mark Tompsett -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat May 6 11:00:58 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 06 May 2017 09:00:58 +0000 Subject: [Koha-bugs] [Bug 18551] Hide with CSS dynamic elements in member search In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18551 Marc V?ron changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |francois.charbonnier at inlibr | |o.com --- Comment #3 from Marc V?ron --- *** Bug 18518 has been marked as a duplicate of this bug. *** -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat May 6 11:00:58 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 06 May 2017 09:00:58 +0000 Subject: [Koha-bugs] [Bug 18518] The staff interface "blink" for different actions after upgrading to Firefox 53 In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18518 Marc V?ron changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |RESOLVED Resolution|--- |DUPLICATE --- Comment #11 from Marc V?ron --- (In reply to Fridolin SOMERS from comment #10) > Oh I've proposed also a patch on Bug 18551. > > I've also hidden the table. > > Should I rebase my bug on this one or provide a followup in this one ? It's OK for me to mark this bug as duplicate of 18551 *** This bug has been marked as a duplicate of bug 18551 *** -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat May 6 11:40:51 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 06 May 2017 09:40:51 +0000 Subject: [Koha-bugs] [Bug 18551] Hide with CSS dynamic elements in member search In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18551 Marc V?ron changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |veron at veron.ch --- Comment #4 from Marc V?ron --- I tested but did not yet sign off because this bug is marked as 'In discussion' With this patch, two of the reasons are gone (yellow dialogue and data table). I think there is one more thing to be addressed: The form for the search filters shortly displays and then hides again. It moves the whole page down and up again. Do you have an idea how to fix it? -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat May 6 22:41:20 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 06 May 2017 20:41:20 +0000 Subject: [Koha-bugs] [Bug 10662] Build OAI-PMH Harvesting Client In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10662 Dennis Hohmann changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |dennis at dennishohmann.de -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun May 7 09:11:47 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 07 May 2017 07:11:47 +0000 Subject: [Koha-bugs] [Bug 18541] Patron card creator: Add a grid to support layout design In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18541 Marc V?ron changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #63162|0 |1 is obsolete| | --- Comment #4 from Marc V?ron --- Created attachment 63217 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=63217&action=edit Bug 18541 - Patron card creator: Add a grid to support layout design Add a layout grid to patron card creator to figure out the positions of text fields, barcode and images. To test: - Apply on top of patch 18465 - Go to Home > Tools > Patron card creator - Edit or create a layout - Turn on new choice 'Guide grid' in section 'General settings' - Leave 'Units' unchanged - Crate a PDF using 'Card batches' - Notice that card is printed with a layout grid that reflects selected unit with each 5th and 10th line in different color unit description displayed bottom left, card dimensions dispayed bottom right in small print inside the layout grid - Print PDF. Set printer settings in Adobe Reader or other PDF printing software to 'Actual size' to prevent scaling to printer's printable region - Mesure out printed PDF and verify that grid corresponds to selecte unit. - Go back to layout definition and choose an other unit, repeat steps to verify that grid respects - Go back to layout definition, turn grid off, create PDF, vrify that grid does not display in PDF Note for testers / QAers: Position of card elements (text, image...) do not respect the unit, this will be fixed in Bug 18550 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun May 7 09:49:07 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 07 May 2017 07:49:07 +0000 Subject: [Koha-bugs] [Bug 18541] Patron card creator: Add a grid to support layout design In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18541 Marc V?ron changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #63217|0 |1 is obsolete| | --- Comment #5 from Marc V?ron --- Created attachment 63218 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=63218&action=edit Bug 18541 - Patron card creator: Add a grid to support layout design Add a layout grid to patron card creator to figure out the positions of text fields, barcode and images. To test: - Apply on top of patch 18465 - Go to Home > Tools > Patron card creator - Edit or create a layout - Turn on new choice 'Guide grid' in section 'General settings' - Leave 'Units' unchanged - Crate a PDF using 'Card batches' - Notice that card is printed with a layout grid that reflects selected unit with each 5th and 10th line in different color, unit description displayed bottom left, card dimensions displayed bottom right in small print inside the layout grid - Print PDF. Set printer settings in Adobe Reader or other PDF printing software to 'Actual size' to prevent scaling to printer's printable region - Mesure out printed PDF and verify that grid corresponds to selecte unit. - Go back to layout definition and choose an other unit, repeat steps to verify that grid respects selected unit. - Go back to layout definition, turn grid off, create PDF, verify that grid does not display in PDF Note for testers / QAers: Position of card elements (text, image...) do not respect the unit, this will be fixed in Bug 18550 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun May 7 09:50:13 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 07 May 2017 07:50:13 +0000 Subject: [Koha-bugs] [Bug 18541] Patron card creator: Add a grid to support layout design In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18541 Marc V?ron changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff Patch complexity|--- |Small patch -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun May 7 11:54:35 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 07 May 2017 09:54:35 +0000 Subject: [Koha-bugs] [Bug 18550] Patron card creator: Print output does not respect layout units In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18550 Marc V?ron changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #63167|0 |1 is obsolete| | --- Comment #3 from Marc V?ron --- Created attachment 63219 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=63219&action=edit Bug 18550 - Patron card creator: Print output does not respect layout units To reproduce: Text, images and barcode positions are always layed out based on PostScript points, regardless of unit defined in card layout. To reproduce: - Test on top of Bug 18541 (introduces layout grid) - Create a card layout with a text field, an image and a barcode. Use points as layout unit - Activate layout grid - Create PDF output, save - Change layout unit to mm - Create PDF output, save - Compare PDFs. Verify that the positions are unchanged (still using points) To test: - Apply patch - Create again PDF - Verify that elements are positionad as expected (using unit, e.g. mm) - Bonus test: Repeat with other units -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun May 7 11:55:24 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 07 May 2017 09:55:24 +0000 Subject: [Koha-bugs] [Bug 18550] Patron card creator: Print output does not respect layout units In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18550 Marc V?ron changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff Patch complexity|--- |Trivial patch -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun May 7 11:56:53 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 07 May 2017 09:56:53 +0000 Subject: [Koha-bugs] [Bug 18541] Patron card creator: Add a grid to support layout design In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18541 Marc V?ron changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |katrin.fischer at bsz-bw.de -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun May 7 11:57:13 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 07 May 2017 09:57:13 +0000 Subject: [Koha-bugs] [Bug 18550] Patron card creator: Print output does not respect layout units In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18550 Marc V?ron changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |katrin.fischer at bsz-bw.de -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun May 7 12:07:06 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 07 May 2017 10:07:06 +0000 Subject: [Koha-bugs] [Bug 17944] Remove the sql code from itemtypes.pl administrative perl script In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17944 Alex Buckley changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #63152|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun May 7 12:07:41 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 07 May 2017 10:07:41 +0000 Subject: [Koha-bugs] [Bug 17944] Remove the sql code from itemtypes.pl administrative perl script In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17944 --- Comment #47 from Alex Buckley --- Created attachment 63220 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=63220&action=edit Bug 17944 - Removed SQl query from itemtypes.pl and replaced it with can_be_deleted method in Koha/ItemType.pm In Koha/ItemTypes.t I have reworded unit test output and added test for item deletion. In addition to updating admin script by removing warn and changing if statement check -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun May 7 12:12:11 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 07 May 2017 10:12:11 +0000 Subject: [Koha-bugs] [Bug 17944] Remove the sql code from itemtypes.pl administrative perl script In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17944 Alex Buckley changed: What |Removed |Added ---------------------------------------------------------------------------- Status|In Discussion |Needs Signoff --- Comment #48 from Alex Buckley --- Hi Jonathan I have implemented: > return $nb_items + $nb_biblioitems == 0 ? 1 : 0; I have changed the wording of the last test and have implemented a test to remove the item. All tests run successfully. As for updating the admin script I have removed the warn and changed the if statement check so it is now: > if ($overalltotal == 0){ Was there any other updates you wanted for the itemtypes.pl admin script? -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun May 7 12:19:14 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 07 May 2017 10:19:14 +0000 Subject: [Koha-bugs] [Bug 4115] print a batch of patron cards from an import In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=4115 --- Comment #2 from Marc V?ron --- What about enhancing patron import to have the importet patrons in a patron list? List name could default to the filename the import comes from, maybe including date an dtime of import. The list could be used for printing patron cards (and other patron list based actions as well). -- You are receiving this mail because: You are watching all bug changes. You are the QA Contact for the bug. From bugzilla-daemon at bugs.koha-community.org Sun May 7 13:49:42 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 07 May 2017 11:49:42 +0000 Subject: [Koha-bugs] [Bug 15766] Give label and patron card batches a description In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15766 Marc V?ron changed: What |Removed |Added ---------------------------------------------------------------------------- Summary|A batch should be given a |Give label and patron card |description. |batches a description Version|3.22 |master CC| |veron at veron.ch --- Comment #11 from Marc V?ron --- Still valid on current master. Applies cleanly. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun May 7 13:51:41 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 07 May 2017 11:51:41 +0000 Subject: [Koha-bugs] [Bug 15766] Give label and patron card batches a description In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15766 Marc V?ron changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #61462|0 |1 is obsolete| | --- Comment #12 from Marc V?ron --- Created attachment 63221 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=63221&action=edit Bug 15766: Adding descriptions to patron card batches This patch adds a 'description' column to the creator_batches table. The description for a batch can be added and updated using ajax. To test: 1) Apply patch and update database (you will have to restart memcached) 2) Go to Tools -> Patron card creator -> Manage batches 3) There should now be a Description column next to Batch ID. This will be empty (as none of the batches have descriptions yet) 4) Click Edit for any batch 5) Notice new Batch description text field. Enter a description for the batch in here and click Save description. Some text should show saying the description was saved. 6) If you go back to the manage batches page, the description should now show under the Description column. Sponsored-by: Catalyst IT Signed-off-by: Eric Gosselin Tested on current master, works as expected. Signed-off-by: Marc V?ron -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun May 7 13:52:48 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 07 May 2017 11:52:48 +0000 Subject: [Koha-bugs] [Bug 15766] Give label and patron card batches a description In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15766 Marc V?ron changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #61463|0 |1 is obsolete| | --- Comment #13 from Marc V?ron --- Created attachment 63222 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=63222&action=edit Bug 15766: Adding descriptions to label batches Same fix, but for Label creator. Follow same test plan but in Tools->Label creator. Sponsored-by: Catalyst IT Signed-off-by: Eric Gosselin Tested on current master, works as expected. Signed-off-by: Marc V?ron -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun May 7 13:53:49 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 07 May 2017 11:53:49 +0000 Subject: [Koha-bugs] [Bug 15766] Give label and patron card batches a description In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15766 Marc V?ron changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #61464|0 |1 is obsolete| | --- Comment #14 from Marc V?ron --- Created attachment 63223 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=63223&action=edit Bug 15766: Changing code to use svc/creator_batches so file can be used for both modules Sponsored-by: Catalyst IT Signed-off-by: Eric Gosselin Tested on current master, works as expected. Signed-off-by: Marc V?ron -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun May 7 13:54:37 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 07 May 2017 11:54:37 +0000 Subject: [Koha-bugs] [Bug 15766] Give label and patron card batches a description In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15766 Marc V?ron changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun May 7 14:11:25 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 07 May 2017 12:11:25 +0000 Subject: [Koha-bugs] [Bug 18060] Add onboarding functionality to guide users through setting up labels for the first time In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18060 --- Comment #1 from Alex Buckley --- Created attachment 63224 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=63224&action=edit Bug 18060 - Initial label onboarding tool -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun May 7 15:24:09 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 07 May 2017 13:24:09 +0000 Subject: [Koha-bugs] [Bug 18060] Add onboarding functionality to guide users through setting up labels for the first time In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18060 Alex Buckley changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #63224|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun May 7 15:24:45 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 07 May 2017 13:24:45 +0000 Subject: [Koha-bugs] [Bug 18060] Add onboarding functionality to guide users through setting up labels for the first time In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18060 --- Comment #2 from Alex Buckley --- Created attachment 63225 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=63225&action=edit Bug 18060 - Initial label onboarding tool -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun May 7 15:38:04 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 07 May 2017 13:38:04 +0000 Subject: [Koha-bugs] [Bug 18450] Renew in header bypasses hold block and renewal limits In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18450 Alex Buckley changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #62811|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun May 7 15:38:32 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 07 May 2017 13:38:32 +0000 Subject: [Koha-bugs] [Bug 18450] Renew in header bypasses hold block and renewal limits In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18450 --- Comment #7 from Alex Buckley --- Created attachment 63226 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=63226&action=edit Bug 18450 - Implemented check if either AllowRenewLimitOverride or AllowRenewalIfOtherItemsAvaliable were set to allow, so the user is only blocked if both of these sysprefs are set to 'Dont allow' Test plan: 1. In More->Administration->Global system preferences ensure that both the AllowRenewalLimitOverride and AllowRenewalIfOtherItemsAvaliable preferences are both set to 'Dont allow'. 2. Place a hold on an item from a patron 3. Checkout the item out to a different patron 4. Renew the item and notice the 'Cannot renew: The item is on hold for another patron' warning 5. Click the 'Override and renew' button and notice that you can bypass the hold 6. Apply patch 7. Renew the item again and notice that the message does not have a 'Override and renew' button it just has the 'Ignore and continue' button 8. Go back to More->Administration->Global system preferences and set AllowRenewalLimitOverride to 'Allow' 9. Try renewing the same item again and notice that the 'Override and renew' button is displayed 10. In systems preferences now set the AllowRenewalIfOtherItemsAvailable syspref to 'Allow' and AllowRenewalLimitOverride to 'Dont allow' and notice the 'Override and renew' button is displayed 11. Now set both these sysprefs to 'Allow' and notice the 'Override and renew' button is displayed because you will not be violating these preferences. Note: Checking if the renewal exceeds the renewal level, if auto renew is set up, or if renewal is to soon is checked earlier in this conditional if statement earlier and so the check in this patch does not need to check the renewal level, auto renewal, if renewal is too soon. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun May 7 15:40:45 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 07 May 2017 13:40:45 +0000 Subject: [Koha-bugs] [Bug 18450] Renew in header bypasses hold block and renewal limits In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18450 Alex Buckley changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |Needs Signoff --- Comment #8 from Alex Buckley --- (In reply to Josef Moravec in comment 6) Thanks Josef. I have fixed up that issue now -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun May 7 15:53:51 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 07 May 2017 13:53:51 +0000 Subject: [Koha-bugs] [Bug 18547] On shelf holds allowed > "If all unavailable" ignores default hold policy In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18547 Alex Buckley changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun May 7 15:53:54 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 07 May 2017 13:53:54 +0000 Subject: [Koha-bugs] [Bug 18547] On shelf holds allowed > "If all unavailable" ignores default hold policy In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18547 Alex Buckley changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #63157|0 |1 is obsolete| | --- Comment #2 from Alex Buckley --- Created attachment 63227 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=63227&action=edit Bug 18547 - On shelf holds allowed > "If all unavailable" ignores default hold policy If in the circ rules matrix you set "On shelf holds allowed" to "If all unavailable", default hold policy "From home library" is ignored. Test plan: - Have a test user from one branch (eg Centerville) - Set "On shelf holds allowed" to "If all unavailable" for your patron and item category (or everyone and everything) - For "Default checkout, hold and return policy", set hold policy to "From home library" -> make sure there is no "Default holds policy by item type" to override the setting - Have two items for a record. 1. An item with home branch same as test user (eg Centerville) -> check this item out to somebody else 2. an item with a different home branch (eg Fairfield) -> available, not checked out - Try to place a hold for your test user. Does not work. - Apply the patch - Try to place a hold. Should work now. Followed test plan, worked as intended Signed-off-by: Alex Buckley -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun May 7 20:20:15 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 07 May 2017 18:20:15 +0000 Subject: [Koha-bugs] [Bug 18547] On shelf holds allowed > "If all unavailable" ignores default hold policy In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18547 Claudio changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |costalc at gmail.com -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun May 7 20:25:10 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 07 May 2017 18:25:10 +0000 Subject: [Koha-bugs] [Bug 18366] On shelf holds allowed > "If all unavailable" ignores library of the rule and considers all libraries In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18366 --- Comment #8 from Claudio --- Please pay attention to #18547 -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Sun May 7 20:58:22 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 07 May 2017 18:58:22 +0000 Subject: [Koha-bugs] [Bug 18002] Make onboarding tool include framework to be embedded in Acquisitions to help the users set up Acquisitions for the first time In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18002 Marc V?ron changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |veron at veron.ch --- Comment #34 from Marc V?ron --- Works nicely. QA tools still have something to complain about: FAIL koha-tmpl/intranet-tmpl/prog/en/includes/onboardinginclude3.inc FAIL valid_template : filter not found FAIL koha-tmpl/intranet-tmpl/prog/en/modules/acqui/acqui-home.tt FAIL spelling seperate ==> separate -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun May 7 21:20:50 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 07 May 2017 19:20:50 +0000 Subject: [Koha-bugs] [Bug 18547] On shelf holds allowed > "If all unavailable" ignores default hold policy In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18547 --- Comment #3 from Claudio --- I tested it in a local installation (16.11.07) but can not make it works... (see #18366) -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon May 8 01:08:04 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 07 May 2017 23:08:04 +0000 Subject: [Koha-bugs] [Bug 18060] Add onboarding functionality to guide users through setting up labels for the first time In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18060 Alex Buckley changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #63225|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon May 8 01:08:39 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 07 May 2017 23:08:39 +0000 Subject: [Koha-bugs] [Bug 18060] Add onboarding functionality to guide users through setting up labels for the first time In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18060 --- Comment #3 from Alex Buckley --- Created attachment 63228 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=63228&action=edit Bug 18060 - Initial label onboarding tool with working retrieval of layouts and templates -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon May 8 01:21:42 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 07 May 2017 23:21:42 +0000 Subject: [Koha-bugs] [Bug 18060] Add onboarding functionality to guide users through setting up labels for the first time In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18060 Alex Buckley changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #63228|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon May 8 01:22:09 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 07 May 2017 23:22:09 +0000 Subject: [Koha-bugs] [Bug 18060] Add onboarding functionality to guide users through setting up labels for the first time In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18060 --- Comment #4 from Alex Buckley --- Created attachment 63229 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=63229&action=edit Bug 18060 - Initial label onboarding tool with working retrieval of layouts and templates -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon May 8 02:47:01 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 08 May 2017 00:47:01 +0000 Subject: [Koha-bugs] [Bug 14803] Rental and fine fees are not updating on circulation screen In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14803 Srdjan Jankovic changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #63153|0 |1 is obsolete| | --- Comment #30 from Srdjan Jankovic --- Created attachment 63230 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=63230&action=edit bug 14803: KOHA.Checkouts js object * Use javascript to: - update fines/checkouts info - show/hide checkouts form and messages * Created svc/patron/fines -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon May 8 02:46:58 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 08 May 2017 00:46:58 +0000 Subject: [Koha-bugs] [Bug 14803] Rental and fine fees are not updating on circulation screen In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14803 Srdjan Jankovic changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon May 8 02:55:50 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 08 May 2017 00:55:50 +0000 Subject: [Koha-bugs] [Bug 14803] Rental and fine fees are not updating on circulation screen In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14803 --- Comment #31 from Srdjan Jankovic --- (In reply to Josef Moravec from comment #29) Hi Josef, thanks for testing this. > I have to more concerns about it: > 1) The barcode field doesn't have focus after page is loaded - probably easy > to fix, but important > 2) Looks like it waits than issues are loaded and then show the barcode > input field, maybe I am wrong and it just looks like, but in any case it is > much slower then current master... Ok, now it should be behaving like master. I tried to add some accuracy, but drawbacks are obviously too big... > 3) Message "loading, you can continue scanning" is badly placed (in the left > top corner) For me it is placed center of the table. At any rate I believe my patch did not change the table, it just makes a issuesTable.api().ajax.reload() call. Could you please a) check it in another browser b) compare to master. Thanks a lot. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon May 8 04:21:52 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 08 May 2017 02:21:52 +0000 Subject: [Koha-bugs] [Bug 18242] Remove primary key on old_issues.issue_id In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18242 --- Comment #24 from Mason James --- (In reply to Jonathan Druart from comment #23) > Last 3 patches are for 16.05.x > I DID NOT TEST THEM! > If you want them for 16.05.x, please test. thanks Jonathan, the patchset looks to be working as expected on 16.05.x :) -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon May 8 04:22:25 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 08 May 2017 02:22:25 +0000 Subject: [Koha-bugs] [Bug 18242] Remove primary key on old_issues.issue_id In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18242 --- Comment #25 from Mason James --- Pushed to 16.05.x, for 16.05.12 release -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon May 8 04:29:13 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 08 May 2017 02:29:13 +0000 Subject: [Koha-bugs] [Bug 18526] Test t/Token.t fails on master In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18526 Mason James changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |RESOLVED Resolution|--- |INVALID --- Comment #2 from Mason James --- (In reply to Marcel de Rooy from comment #1) > Title of this report is misleading. The test does not fail on master (at > least not with me). Oops, looks like I had my PERL5LIB set incorrectly here.. I've confirmed the bug is invalid, thanks for testing Marcel! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon May 8 04:47:50 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 08 May 2017 02:47:50 +0000 Subject: [Koha-bugs] [Bug 18329] Batch record deletion broken In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18329 Mason James changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on| |14504 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14504 [Bug 14504] Add command-line script to batch delete items based on data in items table -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon May 8 04:47:50 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 08 May 2017 02:47:50 +0000 Subject: [Koha-bugs] [Bug 14504] Add command-line script to batch delete items based on data in items table In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14504 Mason James changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |18329 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18329 [Bug 18329] Batch record deletion broken -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon May 8 12:09:15 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 08 May 2017 10:09:15 +0000 Subject: [Koha-bugs] [Bug 18554] New: Adjust a few typos including responsability Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18554 Bug ID: 18554 Summary: Adjust a few typos including responsability Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: minor Priority: P5 - low Component: Documentation Assignee: nengard at gmail.com Reporter: m.de.rooy at rijksmuseum.nl QA Contact: testopia at bugs.koha-community.org -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon May 8 12:15:30 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 08 May 2017 10:15:30 +0000 Subject: [Koha-bugs] [Bug 18554] Adjust a few typos including responsability In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18554 Marcel de Rooy changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon May 8 12:15:33 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 08 May 2017 10:15:33 +0000 Subject: [Koha-bugs] [Bug 18554] Adjust a few typos including responsability In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18554 --- Comment #1 from Marcel de Rooy --- Created attachment 63231 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=63231&action=edit Bug 18554: Adjust a few typos including responsability typo responsability typo defautl in authorities.pref typo reveived in t/db_dependent/Acquisition.t typo ;; in advance_notices.pl typo Stopping in restart_indexer (koha-indexer) typo instutitional in moremember.pl typo Corretly (Biblio.t) typo periodicy in help serials Signed-off-by: Marcel de Rooy -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon May 8 12:15:51 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 08 May 2017 10:15:51 +0000 Subject: [Koha-bugs] [Bug 18554] Adjust a few typos including responsability In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18554 Marcel de Rooy changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|nengard at gmail.com |m.de.rooy at rijksmuseum.nl Patch complexity|--- |Trivial patch -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon May 8 12:21:41 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 08 May 2017 10:21:41 +0000 Subject: [Koha-bugs] [Bug 18228] Make list permissions easier to use/understand In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18228 --- Comment #27 from Marcel de Rooy --- Can we move this further? -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon May 8 12:28:23 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 08 May 2017 10:28:23 +0000 Subject: [Koha-bugs] [Bug 15140] Add MARC21 776 to OPAC and staff display In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15140 sandboxes at biblibre.com changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off CC| |sandboxes at biblibre.com --- Comment #15 from sandboxes at biblibre.com --- Patch tested with a sandbox, by Felix Hemme -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon May 8 12:28:47 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 08 May 2017 10:28:47 +0000 Subject: [Koha-bugs] [Bug 15140] Add MARC21 776 to OPAC and staff display In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15140 sandboxes at biblibre.com changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #62908|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon May 8 12:28:41 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 08 May 2017 10:28:41 +0000 Subject: [Koha-bugs] [Bug 15140] Add MARC21 776 to OPAC and staff display In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15140 sandboxes at biblibre.com changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #62531|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon May 8 12:28:54 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 08 May 2017 10:28:54 +0000 Subject: [Koha-bugs] [Bug 15140] Add MARC21 776 to OPAC and staff display In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15140 --- Comment #16 from sandboxes at biblibre.com --- Created attachment 63232 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=63232&action=edit Bug 15140: Add MARC21 776 to OPAC and staff display Adds code to opac and staff detail XSLT in order to show 776$t (or $a) and a link based on 776$w (record control number). $w should be in the form: (MARCOrgCode)Record-number For instance: (NL-AmRIJ)12345 Note: You should have enabled default opac/intranet XSLT view. Test plan: [1] Add two 776s (one with $t and $w and one with $t only) [2] Verify that you see "Additional physical formats" on opac-detail. Does the link for $w work? [3] Check intranet detail too. [4] Empty 776$t and put text in $a. Check detail page again. Signed-off-by: Marcel de Rooy Signed-off-by: Felix Hemme -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon May 8 12:28:58 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 08 May 2017 10:28:58 +0000 Subject: [Koha-bugs] [Bug 15140] Add MARC21 776 to OPAC and staff display In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15140 --- Comment #17 from sandboxes at biblibre.com --- Created attachment 63233 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=63233&action=edit Bug 15140: Display $i when ind2==8 See MARC specification. Note that we have a preceding text before all 776s too. Test plan: [1] Set field 776 ind2 to 8. And add text in $i. [2] Look for this text on OPAC detail and staff detail. Signed-off-by: Marcel de Rooy Signed-off-by: Felix Hemme -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon May 8 12:43:19 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 08 May 2017 10:43:19 +0000 Subject: [Koha-bugs] [Bug 15140] Add MARC21 776 to OPAC and staff display In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15140 --- Comment #18 from Marcel de Rooy --- (In reply to sandboxes at biblibre.com from comment #17) > Signed-off-by: Felix Hemme Thx -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon May 8 12:46:45 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 08 May 2017 10:46:45 +0000 Subject: [Koha-bugs] [Bug 14495] WebDriver/ WebTester Factory for easy generation of Web testing UserAgents. In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14495 Lari Taskula changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #41533|0 |1 is obsolete| | --- Comment #12 from Lari Taskula --- Created attachment 63234 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=63234&action=edit Bug 14495 - WebDriver/WebTester Factory for easy generation of Web testing UserAgents. Has an optional dependency to Buugg 13799 Because life is short, getting test web drivers must be easy. use t::lib::WebDriverFactory; my ($firefox) = t::lib::WebDriverFactory::getUserAgentDrivers('firefox'); In Ubuntu 14.04, Selenium no longer requires a stand-alone testing Server, so running integration tests is much much more fun! This factory encapsulates all the boring bits about getting a web driver to mimic user behaviour in the GUI. And makes it super easy to get a test driver for any testing type environment. Adds support for Test::Mojo and Selenium, see t::lib::WebDriverFactory for installation and usage instructions. ---------------------------- -INSTALLATION INSTRUCTIONS:- ---------------------------- -All the WebDriver tests use the Selenium::PhantomJS-package by default. You MUST install the following dependencies: cpanm Selenium::Remote::Driver cpanm Selenium::PhantomJS apt-get install phantomjs #Minimum version acceptable is v1.09 Optionally you can install other Selenium browsers like Firefox Chrome IE But they are only useful when testing the WebDriver scripts on a graphical environment. You are better off using Selenium IDE to learn/test WebDriver scripts. run t::lib::webDriverFactory.t to see your configured capabilities. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon May 8 12:51:09 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 08 May 2017 10:51:09 +0000 Subject: [Koha-bugs] [Bug 14539] Introduction to castToObject(), aka. make a Koha:: Object from various input types In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14539 --- Comment #9 from Lari Taskula --- Created attachment 63235 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=63235&action=edit Bug 14539 - Koha::Objects->cast(). Introduction to cast() (ToObject), aka. make a Koha::Object from various input types and validate. Finds a Borrower-object (or any other type) from various different types of inputs. Also doubles as a validator function, dying if input is improper. USAGE: my $member = C4::Members::GetMember(borrowernumber => $borrowernumber); my $borrower = Koha::Borrowers->cast($member); Currently Koha is like an archeological dig site, we have different layers of dealing with various business objects. We started with DBI and numerous ways of passing an HASH around. There is no telling if it will be a List of column => values, or a reference to HASH, or a HASH or just any of the business object's (eg. Borrower's) unique identifiers (userid, cardnumber, borrowernumber). Then DBIx came to the rescue and now we are need to learn DBI and DBIx and SQL to do DB operatons in Koha. Migration to DBIx is on the way. Finally we have Koha::Object and subclasses, which include and use the DBIx, but those are not directly compatible, since Koha::Object is not a subclass of DBIx::Class making life occasionally miserable. Now we need to know 3 methods of DB accession. I am really frustrated with all of those different layers of history, and making things work nicely across all different programming patterns, I have had great success in using a casting system, where we take any value and try to make a Koha::Object-subclass out of it. So we try to cast a Scalar or a reference of Koha::Object-implementation or DBIx::ResultSet or HASH, to the desired Koha::Object-implementation. This is a nice validation/entry function in any subroutine dealing with business objects, making sure that we always have the "correct" implementation of the same business object. Unit tests included demonstrating the feature and possible pitfalls. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon May 8 13:07:03 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 08 May 2017 11:07:03 +0000 Subject: [Koha-bugs] [Bug 14539] Introduction to castToObject(), aka. make a Koha:: Object from various input types In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14539 Lari Taskula changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #41530|0 |1 is obsolete| | Attachment #63235|0 |1 is obsolete| | --- Comment #10 from Lari Taskula --- Created attachment 63236 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=63236&action=edit Bug 14539 - Koha::Objects->cast(). Introduction to cast() (ToObject), aka. make a Koha::Object from various input types and validate. Finds a Patron-object (or any other type) from various different types of inputs. Also doubles as a validator function, dying if input is improper. USAGE: my $member = C4::Members::GetMember(borrowernumber => $borrowernumber); my $borrower = Koha::Patrons->cast($member); Currently Koha is like an archeological dig site, we have different layers of dealing with various business objects. We started with DBI and numerous ways of passing an HASH around. There is no telling if it will be a List of column => values, or a reference to HASH, or a HASH or just any of the business object's (eg. Borrower's) unique identifiers (userid, cardnumber, borrowernumber). Then DBIx came to the rescue and now we are need to learn DBI and DBIx and SQL to do DB operatons in Koha. Migration to DBIx is on the way. Finally we have Koha::Object and subclasses, which include and use the DBIx, but those are not directly compatible, since Koha::Object is not a subclass of DBIx::Class making life occasionally miserable. Now we need to know 3 methods of DB accession. I am really frustrated with all of those different layers of history, and making things work nicely across all different programming patterns, I have had great success in using a casting system, where we take any value and try to make a Koha::Object-subclass out of it. So we try to cast a Scalar or a reference of Koha::Object-implementation or DBIx::ResultSet or HASH, to the desired Koha::Object-implementation. This is a nice validation/entry function in any subroutine dealing with business objects, making sure that we always have the "correct" implementation of the same business object. Unit tests included demonstrating the feature and possible pitfalls. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon May 8 13:10:52 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 08 May 2017 11:10:52 +0000 Subject: [Koha-bugs] [Bug 14539] Introduction to castToObject(), aka. make a Koha:: Object from various input types In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14539 Lari Taskula changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #63236|0 |1 is obsolete| | --- Comment #11 from Lari Taskula --- Created attachment 63237 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=63237&action=edit Bug 14539 - Koha::Objects->cast(). Introduction to cast() (ToObject), aka. make a Koha::Object from various input types and validate. Finds a Patron-object (or any other type) from various different types of inputs. Also doubles as a validator function, dying if input is improper. USAGE: my $member = C4::Members::GetMember(borrowernumber => $borrowernumber); my $borrower = Koha::Patrons->cast($member); Currently Koha is like an archeological dig site, we have different layers of dealing with various business objects. We started with DBI and numerous ways of passing an HASH around. There is no telling if it will be a List of column => values, or a reference to HASH, or a HASH or just any of the business object's (eg. Patron's) unique identifiers (userid, cardnumber, borrowernumber). Then DBIx came to the rescue and now we are need to learn DBI and DBIx and SQL to do DB operatons in Koha. Migration to DBIx is on the way. Finally we have Koha::Object and subclasses, which include and use the DBIx, but those are not directly compatible, since Koha::Object is not a subclass of DBIx::Class making life occasionally miserable. Now we need to know 3 methods of DB accession. I am really frustrated with all of those different layers of history, and making things work nicely across all different programming patterns, I have had great success in using a casting system, where we take any value and try to make a Koha::Object-subclass out of it. So we try to cast a Scalar or a reference of Koha::Object-implementation or DBIx::ResultSet or HASH, to the desired Koha::Object-implementation. This is a nice validation/entry function in any subroutine dealing with business objects, making sure that we always have the "correct" implementation of the same business object. Unit tests included demonstrating the feature and possible pitfalls. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon May 8 13:13:48 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 08 May 2017 11:13:48 +0000 Subject: [Koha-bugs] [Bug 14539] Introduction to castToObject(), aka. make a Koha:: Object from various input types In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14539 Lari Taskula changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |lari.taskula at jns.fi Status|Patch doesn't apply |BLOCKED --- Comment #12 from Lari Taskula --- Rebased on master, renamed occurrences of "Borrower" to "Patron", still blocked by 13995 but patches from both Bugs should apply at the time of this comment. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon May 8 14:36:21 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 08 May 2017 12:36:21 +0000 Subject: [Koha-bugs] [Bug 18442] Permission error when logging into staff interface as db user In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18442 Kyle M Hall changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to Master --- Comment #25 from Kyle M Hall --- Pushed to master for 17.05, thanks Alex, Jonathan! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon May 8 14:38:25 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 08 May 2017 12:38:25 +0000 Subject: [Koha-bugs] [Bug 18512] GetAuthorisedValues.GetByCode Template plugin should return code ( not empty string) if value not found In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18512 Kyle M Hall changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to Master CC| |kyle at bywatersolutions.com --- Comment #9 from Kyle M Hall --- Pushed to master for 17.05, thanks Nick, Jonathan! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon May 8 14:40:06 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 08 May 2017 12:40:06 +0000 Subject: [Koha-bugs] [Bug 17952] Lost items not skipped by overdue_notices.pl In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17952 Kyle M Hall changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to Master --- Comment #9 from Kyle M Hall --- Pushed to master for 17.05! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon May 8 14:47:10 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 08 May 2017 12:47:10 +0000 Subject: [Koha-bugs] [Bug 11879] Add a new borrower field : main contact method. In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11879 Philippe Audet-Fortin changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #58592|0 |1 is obsolete| | --- Comment #86 from Philippe Audet-Fortin --- Created attachment 63238 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=63238&action=edit Bug 11879: Add the "Main contact method" field in borrower informations. This patch adds the "Main Contact Method" field in the borrower modification form. This field is useful for reporting purposes, or to know which contact method to use first when trying to contact a borrower. Following Nicolas' fix, removed a $branch variable from patch, since it has been suppressed in Bug 17284. Test case : * Edit a borrower's informations. The "Main Contact Method" selectbox should appear in the form and its value should be saved correctly. Sponsored-by: CCSR -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon May 8 14:47:22 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 08 May 2017 12:47:22 +0000 Subject: [Koha-bugs] [Bug 11879] Add a new borrower field : main contact method. In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11879 Philippe Audet-Fortin changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #58593|0 |1 is obsolete| | --- Comment #87 from Philippe Audet-Fortin --- Created attachment 63239 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=63239&action=edit Bug 11879: Changes to Koha's schemas -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon May 8 15:01:13 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 08 May 2017 13:01:13 +0000 Subject: [Koha-bugs] [Bug 7550] Self checkout: limit display of patron image to logged-in patron In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7550 Kyle M Hall changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to Master CC| |kyle at bywatersolutions.com --- Comment #29 from Kyle M Hall --- Pushed to master for 17.05, thanks Jonathan, Marcel! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon May 8 15:01:54 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 08 May 2017 13:01:54 +0000 Subject: [Koha-bugs] [Bug 18405] Self checkout: Fix broken silent printing In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18405 Kyle M Hall changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |kyle at bywatersolutions.com Status|Passed QA |Pushed to Master --- Comment #4 from Kyle M Hall --- Pushed to master for 17.05, thanks Marc! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon May 8 15:02:35 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 08 May 2017 13:02:35 +0000 Subject: [Koha-bugs] [Bug 17993] Do not use modal authentication with CAS In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17993 Kyle M Hall changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |kyle at bywatersolutions.com Status|Passed QA |Pushed to Master --- Comment #13 from Kyle M Hall --- Pushed to master for 17.05, thanks Frido! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon May 8 15:03:44 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 08 May 2017 13:03:44 +0000 Subject: [Koha-bugs] [Bug 18415] Advanced Editor - Rancor - return focus to editor after successful macro In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18415 Kyle M Hall changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |kyle at bywatersolutions.com Status|Passed QA |Pushed to Master --- Comment #4 from Kyle M Hall --- Pushed to master for 17.05 thanks Nick! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon May 8 15:03:31 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 08 May 2017 13:03:31 +0000 Subject: [Koha-bugs] [Bug 11879] Add a new borrower field : main contact method. In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11879 Philippe Audet-Fortin changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Patch doesn't apply |Needs Signoff CC| |philippe.audet-fortin at inlib | |ro.com -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon May 8 15:05:26 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 08 May 2017 13:05:26 +0000 Subject: [Koha-bugs] [Bug 18152] UNIMARC bib records imported with invalid 'a' char in label pos.9 In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18152 Kyle M Hall changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to Master CC| |kyle at bywatersolutions.com --- Comment #25 from Kyle M Hall --- Pushed to master for 17.05, thanks Stephane, Jonathan! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon May 8 15:06:38 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 08 May 2017 13:06:38 +0000 Subject: [Koha-bugs] [Bug 17190] Mark REST API dependencies as mandatory in PerlDependencies.pm In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17190 Kyle M Hall changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |kyle at bywatersolutions.com Status|Passed QA |Pushed to Master --- Comment #6 from Kyle M Hall --- Pushed to master for 17.05, thanks Alex! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon May 8 15:17:59 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 08 May 2017 13:17:59 +0000 Subject: [Koha-bugs] [Bug 17812] Return focus to barcode field after toggling on-site checkouts In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17812 Kyle M Hall changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to Master CC| |kyle at bywatersolutions.com --- Comment #9 from Kyle M Hall --- Pushed to master for 17.05, thanks Owen! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon May 8 15:21:55 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 08 May 2017 13:21:55 +0000 Subject: [Koha-bugs] [Bug 18098] Add an index with the count of not onloan items In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18098 Kyle M Hall changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to Master CC| |kyle at bywatersolutions.com --- Comment #8 from Kyle M Hall --- Pushed to master for 17.05, thanks Tomas! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon May 8 15:22:35 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 08 May 2017 13:22:35 +0000 Subject: [Koha-bugs] [Bug 18233] t/db_dependent/00-strict.t has non-existant resetversion.pl In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18233 Kyle M Hall changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to Master CC| |kyle at bywatersolutions.com --- Comment #4 from Kyle M Hall --- Pushed to master for 17.05, thanks Olli! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon May 8 15:25:10 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 08 May 2017 13:25:10 +0000 Subject: [Koha-bugs] [Bug 18299] Removal of admin/env_tz_test.pl script In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18299 Kyle M Hall changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |kyle at bywatersolutions.com Status|Passed QA |Pushed to Master --- Comment #14 from Kyle M Hall --- Pushed to master for 17.05, thanks Alex! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon May 8 15:25:48 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 08 May 2017 13:25:48 +0000 Subject: [Koha-bugs] [Bug 18299] Removal of admin/env_tz_test.pl script In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18299 --- Comment #15 from Kyle M Hall --- (In reply to David Cook from comment #13) > (In reply to Jonathan Druart from comment #8) > > I was not aware of this script and I think it does not make sense to have it. > > I'd prefer to remove it than adding more code to the codebase to maintain it. > > > > Opinions? > > I was not aware of this script until recently, but I have been using it to > double-check that I've set up the timezone for Koha correctly in Apache. > > I'm OK with removing the script overall, but could we add timezone > information to the About page in the "Server information" tab? Can you file an enhancement bug for that? I imagine we should be able to make that happen pretty easily. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon May 8 15:29:19 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 08 May 2017 13:29:19 +0000 Subject: [Koha-bugs] [Bug 17762] Ability to translate notices In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17762 --- Comment #57 from Jonathan Druart --- (In reply to Nick Clemens from comment #56) > All looks good, I added a followup so that we don't send translated notices > if the pref is off. > > One question, you have: > a/members/moremember.pl > 335 # Display the language description instead of the code > 336 # Note that this is certainly wrong > > It seems to work, why is it wrong? I think we should display the description in the translated language. For instance "Spanish" is always "Espa?ol", whatever the language of the interface (same as the language list in the footer). It sounds wrong to me. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon May 8 15:34:15 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 08 May 2017 13:34:15 +0000 Subject: [Koha-bugs] [Bug 15108] OAI-PMH provider improvements In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15108 Kyle M Hall changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |kyle at bywatersolutions.com Status|Passed QA |Pushed to Master --- Comment #94 from Kyle M Hall --- Pushed to master for 17.05, thanks Ere, Tomas! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon May 8 15:53:34 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 08 May 2017 13:53:34 +0000 Subject: [Koha-bugs] [Bug 14570] Make it possible to add multiple guarantors to a record In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14570 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Failed QA -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon May 8 16:16:47 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 08 May 2017 14:16:47 +0000 Subject: [Koha-bugs] [Bug 18555] New: Create patron list from patron import Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18555 Bug ID: 18555 Summary: Create patron list from patron import Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Patrons Assignee: koha-bugs at lists.koha-community.org Reporter: veron at veron.ch QA Contact: testopia at bugs.koha-community.org CC: gmcharlt at gmail.com, kyle.m.hall at gmail.com Create a patron list from imported patrons to be used for printing patron cards and other patron list related actions. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Mon May 8 16:17:20 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 08 May 2017 14:17:20 +0000 Subject: [Koha-bugs] [Bug 18505] OPAC Search History page does not respect OpacPublic syspref In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18505 Kyle M Hall changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to Master CC| |kyle at bywatersolutions.com --- Comment #10 from Kyle M Hall --- Pushed to master for 17.05, thanks Martin! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon May 8 16:17:38 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 08 May 2017 14:17:38 +0000 Subject: [Koha-bugs] [Bug 18555] Create patron list from patron import In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18555 Marc V?ron changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|koha-bugs at lists.koha-commun |veron at veron.ch |ity.org | See Also| |https://bugs.koha-community | |.org/bugzilla3/show_bug.cgi | |?id=4115 -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Mon May 8 16:17:38 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 08 May 2017 14:17:38 +0000 Subject: [Koha-bugs] [Bug 4115] print a batch of patron cards from an import In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=4115 Marc V?ron changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |https://bugs.koha-community | |.org/bugzilla3/show_bug.cgi | |?id=18555 -- You are receiving this mail because: You are watching all bug changes. You are the QA Contact for the bug. From bugzilla-daemon at bugs.koha-community.org Mon May 8 16:23:34 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 08 May 2017 14:23:34 +0000 Subject: [Koha-bugs] [Bug 15855] Disabling multiple submission on search form In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15855 --- Comment #2 from Marc V?ron --- Created attachment 63240 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=63240&action=edit Bug 18555: Create patron list from patron import Create a patron list from imported patrons to be used for printing patron cards and other patron list related actions. To test: - Apply patch - Go to Home > Tools > Import patrons - Select a file to import and check new checkbox 'Create patron list' - Import file - Verify that in import results you see the time stamped name of the patronlist containig the imported patrons (if any patrons were imported) - Go to Home > Tools > Patron lists - Verify that the list shows up and contains the imported patrons -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon May 8 16:26:19 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 08 May 2017 14:26:19 +0000 Subject: [Koha-bugs] [Bug 15855] Disabling multiple submission on search form In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15855 Marc V?ron changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #63240|0 |1 is obsolete| | --- Comment #3 from Marc V?ron --- Comment on attachment 63240 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=63240 Bug 18555: Create patron list from patron import Sorry, mistaked with bug number, should put my glasses... -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon May 8 16:26:51 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 08 May 2017 14:26:51 +0000 Subject: [Koha-bugs] [Bug 18555] Create patron list from patron import In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18555 --- Comment #1 from Marc V?ron --- Created attachment 63241 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=63241&action=edit Bug 18555: Create patron list from patron import Create a patron list from imported patrons to be used for printing patron cards and other patron list related actions. To test: - Apply patch - Go to Home > Tools > Import patrons - Select a file to import and check new checkbox 'Create patron list' - Import file - Verify that in import results you see the time stamped name of the patronlist containig the imported patrons (if any patrons were imported) - Go to Home > Tools > Patron lists - Verify that the list shows up and contains the imported patrons https://bugs.koha-community.org/show_bug.cgi?id=15855 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon May 8 16:28:17 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 08 May 2017 14:28:17 +0000 Subject: [Koha-bugs] [Bug 18555] Create patron list from patron import In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18555 Marc V?ron changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #63241|0 |1 is obsolete| | --- Comment #2 from Marc V?ron --- Created attachment 63242 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=63242&action=edit Bug 18555: Create patron list from patron import Create a patron list from imported patrons to be used for printing patron cards and other patron list related actions. To test: - Apply patch - Go to Home > Tools > Import patrons - Select a file to import and check new checkbox 'Create patron list' - Import file - Verify that in import results you see the time stamped name of the patronlist containig the imported patrons (if any patrons were imported) - Go to Home > Tools > Patron lists - Verify that the list shows up and contains the imported patrons -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon May 8 16:28:43 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 08 May 2017 14:28:43 +0000 Subject: [Koha-bugs] [Bug 18555] Create patron list from patron import In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18555 Marc V?ron changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon May 8 16:30:20 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 08 May 2017 14:30:20 +0000 Subject: [Koha-bugs] [Bug 14539] Introduction to castToObject(), aka. make a Koha:: Object from various input types In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14539 Lari Taskula changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #63237|0 |1 is obsolete| | --- Comment #13 from Lari Taskula --- Created attachment 63243 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=63243&action=edit Bug 14539 - Koha::Objects->cast(). Introduction to cast() (ToObject), aka. make a Koha::Object from various input types and validate. Finds a Patron-object (or any other type) from various different types of inputs. Also doubles as a validator function, dying if input is improper. USAGE: my $member = C4::Members::GetMember(borrowernumber => $borrowernumber); my $borrower = Koha::Patrons->cast($member); Currently Koha is like an archeological dig site, we have different layers of dealing with various business objects. We started with DBI and numerous ways of passing an HASH around. There is no telling if it will be a List of column => values, or a reference to HASH, or a HASH or just any of the business object's (eg. Patron's) unique identifiers (userid, cardnumber, borrowernumber). Then DBIx came to the rescue and now we are need to learn DBI and DBIx and SQL to do DB operatons in Koha. Migration to DBIx is on the way. Finally we have Koha::Object and subclasses, which include and use the DBIx, but those are not directly compatible, since Koha::Object is not a subclass of DBIx::Class making life occasionally miserable. Now we need to know 3 methods of DB accession. I am really frustrated with all of those different layers of history, and making things work nicely across all different programming patterns, I have had great success in using a casting system, where we take any value and try to make a Koha::Object-subclass out of it. So we try to cast a Scalar or a reference of Koha::Object-implementation or DBIx::ResultSet or HASH, to the desired Koha::Object-implementation. This is a nice validation/entry function in any subroutine dealing with business objects, making sure that we always have the "correct" implementation of the same business object. Unit tests included demonstrating the feature and possible pitfalls. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon May 8 16:33:52 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 08 May 2017 14:33:52 +0000 Subject: [Koha-bugs] [Bug 13906] TestObjectFactory(ies) for Koha objects. Enable easy Test object creation from HASHes or from preconfigured test groups. In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13906 Lari Taskula changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #41531|0 |1 is obsolete| | Attachment #42430|0 |1 is obsolete| | Attachment #42602|0 |1 is obsolete| | Attachment #47244|0 |1 is obsolete| | Attachment #47253|0 |1 is obsolete| | --- Comment #26 from Lari Taskula --- Created attachment 63244 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=63244&action=edit Bug 13906 - TestObjectFactory(ies) for Koha objects. Enable easy Test object creation/deletion from HASHes. Doing tests should be easy. One biggest hindrance in doing tests is the difficulty of doing so in Koha. We use a lot of hard-coded SQL, which occasionally requires quite a bit of fiddling to get it right. Satisfying complex object dependency chains is hard. For example, testing Overdue notice sending, one must create -letters -overuderules -circulationrules -borrowers -biblios -items -issues (checkouts) ... Also one must take care to clean up the database modifications afterward to make encapsulated tests which don't leak over other tests. This is especially so for front-end testing. TestObjectFactories significantly alleviate this pain. They try to recover from errors, like when the previous test crashed and left testing objects into the DB, preventing adding them again. Also they store what object they created to 3 different levels of stashes to facilitate complex test configurations, and they have the dignity to clean-up the test contexts after testing has happened (if the script doesn't crash)! UNIT TESTS included! USAGE: use t::lib::TestObjects::PatronFactory; %#Setting up the test context my $testContext = {}; my $password = '1234'; my $patronFactory = t::lib::TestObjects::PatronFactory->new(); my $patrons = $patronFactory->createTestGroup([ {firstname => 'Olli-Antti', surname => 'Kivi', cardnumber => '1A01', branchcode => 'CPL', flags => '1', #superlibrarian, not exactly a very good way of doing permission testing? userid => 'mini_admin', password => $password, }, ], undef, $testContext); %#Test context set, starting testing: eval { ... #Run your tests here }; if ($@) { #Catch all leaking errors and gracefully terminate. warn $@; tearDown(); exit 1; } %#All tests done, tear down test context tearDown(); done_testing; sub tearDown { t::lib::TestObjects::ObjectFactory->tearDownTestContext($testContext); } -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon May 8 16:42:04 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 08 May 2017 14:42:04 +0000 Subject: [Koha-bugs] [Bug 14536] PageObject-pattern base implementation In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14536 Lari Taskula changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on|13995 | CC| |lari.taskula at jns.fi Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13995 [Bug 13995] Proper Exception handling -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon May 8 16:42:04 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 08 May 2017 14:42:04 +0000 Subject: [Koha-bugs] [Bug 13995] Proper Exception handling In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13995 Lari Taskula changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks|14536 | Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14536 [Bug 14536] PageObject-pattern base implementation -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon May 8 16:44:00 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 08 May 2017 14:44:00 +0000 Subject: [Koha-bugs] [Bug 12446] Enable an adult to have a guarantor In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12446 Philippe Audet-Fortin changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |Needs Signoff Assignee|remi.mayrand-provencher at inL |philippe.audet-fortin at inlib |ibro.com |ro.com CC| |philippe.audet-fortin at inlib | |ro.com -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon May 8 16:44:54 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 08 May 2017 14:44:54 +0000 Subject: [Koha-bugs] [Bug 12532] Redirect guarantee email to guarantor In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12532 Philippe Audet-Fortin changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |philippe.audet-fortin at inlib | |ro.com -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon May 8 16:45:58 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 08 May 2017 14:45:58 +0000 Subject: [Koha-bugs] [Bug 18518] The staff interface "blink" for different actions after upgrading to Firefox 53 In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18518 Philippe Audet-Fortin changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |philippe.audet-fortin at inlib | |ro.com -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon May 8 16:46:23 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 08 May 2017 14:46:23 +0000 Subject: [Koha-bugs] [Bug 17944] Remove the sql code from itemtypes.pl administrative perl script In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17944 --- Comment #49 from Jonathan Druart --- Comment on attachment 63220 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=63220 Bug 17944 - Removed SQl query from itemtypes.pl and replaced it with can_be_deleted method in Koha/ItemType.pm Review of attachment 63220: --> (https://bugs.koha-community.org/bugzilla3/page.cgi?id=splinter.html&bug=17944&attachment=63220) ----------------------------------------------------------------- ::: admin/itemtypes.pl @@ +139,5 @@ > $op = 'list'; > + > + } elsif ( $op eq 'delete_confirm' ) { > + my $ItemType = Koha::ItemType->new(); > + my $overalltotal = $ItemType->can_be_deleted(); You are not retrieving any item type here, ->can_be_deleted will only return 0. You need to call Koha::ItemType->find($id); to retrieve the item type object you want from the DB. @@ +154,2 @@ > my $itemtype = Koha::ItemTypes->find($itemtype_code); > + my $deleted = eval{ $itemtype->delete };; Unnecessary change. ::: t/db_dependent/Koha/ItemTypes.t @@ +139,5 @@ > +is( $item_type->can_be_deleted, 0, 'An item type that is used by an item cannot be deleted' ); > + > +my $biblio = $builder->build_object({ class => 'Koha::Biblioitems', value => { itemtype => $item_type->itemtype }}); > + > +is ( $item_type->can_be_deleted, 0, 'An item that is used by an item and a biblioitem cannot be deleted' ); This second try does not test what you want, see my previous comment: """ The last test says 'An item type that is used by a biblioitem cannot be deleted'. But actually you are testing that "an item that is used by AN item AND A biblioitem cannot be deleted'. You should delete the item to make it test what you want to test. """ -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon May 8 16:46:36 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 08 May 2017 14:46:36 +0000 Subject: [Koha-bugs] [Bug 17944] Remove the sql code from itemtypes.pl administrative perl script In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17944 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Failed QA -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon May 8 16:50:49 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 08 May 2017 14:50:49 +0000 Subject: [Koha-bugs] [Bug 18434] Elasticsearch indexing broken with newer catmandu version In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18434 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |ASSIGNED -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon May 8 16:58:45 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 08 May 2017 14:58:45 +0000 Subject: [Koha-bugs] [Bug 14536] PageObject-pattern base implementation In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14536 Lari Taskula changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #41534|0 |1 is obsolete| | Attachment #41678|0 |1 is obsolete| | Attachment #42435|0 |1 is obsolete| | Attachment #42716|0 |1 is obsolete| | Attachment #44410|0 |1 is obsolete| | Attachment #47254|0 |1 is obsolete| | --- Comment #24 from Lari Taskula --- Created attachment 63245 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=63245&action=edit Bug 14536 - PageObject-pattern base implementation This patch introduces: -PageObject base classes for OPAC and Intra, and example tests. More example tests in Buugg 14540, where setting test context is easier. -a interactive debug script to drive PageObjects more easily. ------------------ PageObjects are used to make robust and reusable integration test components to test various front-end features. PageObjects load a Selenium::Remote::Driver implementation, phantomjs by default and use this to do scripted user actions in the browser, eg. clicking HTML-elements, accepting popup dialogs, entering text to input fields. PageObjects encapsulate those very low-level operations into clear and easily usable actions or services, like doPasswordLogin(). PageObjects also seamlessly deal with navigation from one page to another, eg. my $mainpage = t::lib::Page::Mainpage->new(); $mainpage->doPasswordLogin('admin', '1234')->gotoPatrons()-> searchPatrons({keywordSearch => "Jane Doe"}); PageObjects make doing integration tests so great! You can google for the specifics of PageObject patterns and there are a ton of great tutorials explaining their function. Now PageObjects also have a debugging system where you can get the server response in a title+cookies+html-dump and a screenshot of the browser session. see t::lib::Page for more info! --------------------- Interactive debugger at misc/devel/interactiveWebDriverShell.pl loads the desired PageObject with the needed parameters to the debugger context and makes dynamic UserAgent scripting easy and fun! --------------------- Bug 14536: (follow-up) Adds polling to Page.pm and enhances navigation. This follow-up adds a subroutine poll to superclass Page.pm. Polling will execute an anonymous subroutine for as long as defined or until the subroutine is successful. --------------------- -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon May 8 17:00:08 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 08 May 2017 15:00:08 +0000 Subject: [Koha-bugs] [Bug 14536] PageObject-pattern base implementation In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14536 --- Comment #25 from Lari Taskula --- Squashed follow-ups into main patch, rebased on top of master (dependencies Bug 13906 and Bug 14495 still apply). -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon May 8 17:05:08 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 08 May 2017 15:05:08 +0000 Subject: [Koha-bugs] [Bug 12446] Enable an adult to have a guarantor In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12446 --- Comment #50 from Jonathan Druart --- Comment on attachment 63214 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=63214 ID change for jQuery listener Review of attachment 63214: --> (https://bugs.koha-community.org/bugzilla3/page.cgi?id=splinter.html&bug=12446&attachment=63214) ----------------------------------------------------------------- Philippe, Please do not add unnecessary changes to your patches: blank lines, indentation changes, trailing spaces should only be fixed when you are modifying these lines. ::: koha-tmpl/intranet-tmpl/prog/en/modules/common/patron_search.tt @@ +112,4 @@ > $("body").on("click",".select_user",function(e){ > e.preventDefault(); > var borrowernumber = $(this).data("borrowernumber"); > + var borrower_data = $("#guarantor_data"+borrowernumber).val(); You should not modify existing code without thinking about side-effects. Assume that existing code is useful and used by other scripts :) For instance with this change you break admin/add_user_search.pl when called to set the owner of a fund (from admin/aqbudgets.tt). -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon May 8 17:05:37 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 08 May 2017 15:05:37 +0000 Subject: [Koha-bugs] [Bug 12446] Enable an adult to have a guarantor In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12446 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Failed QA -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon May 8 17:06:13 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 08 May 2017 15:06:13 +0000 Subject: [Koha-bugs] [Bug 12446] Enable an adult to have a guarantor In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12446 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |https://bugs.koha-community | |.org/bugzilla3/show_bug.cgi | |?id=14570 --- Comment #51 from Jonathan Druart --- Aware of bug 14570? -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon May 8 17:06:13 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 08 May 2017 15:06:13 +0000 Subject: [Koha-bugs] [Bug 14570] Make it possible to add multiple guarantors to a record In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14570 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |https://bugs.koha-community | |.org/bugzilla3/show_bug.cgi | |?id=12446 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon May 8 17:06:53 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 08 May 2017 15:06:53 +0000 Subject: [Koha-bugs] [Bug 18556] New: Message "Patron's address in doubt" is confusing Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18556 Bug ID: 18556 Summary: Message "Patron's address in doubt" is confusing Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Staff Client Assignee: koha-bugs at lists.koha-community.org Reporter: barton at bywatersolutions.com QA Contact: testopia at bugs.koha-community.org CC: gmcharlt at gmail.com If a borrower has the patron account flag "Gone no address" set, the message "Patron's address in doubt" appears on the circulation check-out screen. This is confusing -- the borrowers table has the following fields that could be interpreted as an 'address' field: streetnumber streettype address address2 city state zipcode country B_streetnumber B_streettype B_address B_address2 B_city B_state B_zipcode B_country altcontactaddress1 altcontactaddress2 altcontactaddress3 altcontactstate altcontactzipcode altcontactcountry ... and it turns out that the message has *nothing* to do with any of these. I think that the message should read "Patron account flag 'Gone No Address' is set." -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon May 8 17:15:41 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 08 May 2017 15:15:41 +0000 Subject: [Koha-bugs] [Bug 14539] Introduction to castToObject(), aka. make a Koha:: Object from various input types In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14539 Lari Taskula changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #63243|0 |1 is obsolete| | --- Comment #14 from Lari Taskula --- Created attachment 63246 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=63246&action=edit Bug 14539 - Koha::Objects->cast(). Introduction to cast() (ToObject), aka. make a Koha::Object from various input types and validate. Finds a Patron-object (or any other type) from various different types of inputs. Also doubles as a validator function, dying if input is improper. USAGE: my $member = C4::Members::GetMember(borrowernumber => $borrowernumber); my $borrower = Koha::Patrons->cast($member); Currently Koha is like an archeological dig site, we have different layers of dealing with various business objects. We started with DBI and numerous ways of passing an HASH around. There is no telling if it will be a List of column => values, or a reference to HASH, or a HASH or just any of the business object's (eg. Patron's) unique identifiers (userid, cardnumber, borrowernumber). Then DBIx came to the rescue and now we are need to learn DBI and DBIx and SQL to do DB operatons in Koha. Migration to DBIx is on the way. Finally we have Koha::Object and subclasses, which include and use the DBIx, but those are not directly compatible, since Koha::Object is not a subclass of DBIx::Class making life occasionally miserable. Now we need to know 3 methods of DB accession. I am really frustrated with all of those different layers of history, and making things work nicely across all different programming patterns, I have had great success in using a casting system, where we take any value and try to make a Koha::Object-subclass out of it. So we try to cast a Scalar or a reference of Koha::Object-implementation or DBIx::ResultSet or HASH, to the desired Koha::Object-implementation. This is a nice validation/entry function in any subroutine dealing with business objects, making sure that we always have the "correct" implementation of the same business object. Unit tests included demonstrating the feature and possible pitfalls. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon May 8 17:18:12 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 08 May 2017 15:18:12 +0000 Subject: [Koha-bugs] [Bug 18438] Check in: Modal about holds hides important check in messages In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18438 --- Comment #20 from Jonathan Druart --- I do not understand where we are with these patches. What are the expected behaviour changes? -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon May 8 17:29:45 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 08 May 2017 15:29:45 +0000 Subject: [Koha-bugs] [Bug 18153] UNIMARC bib records exported with invalid 'a' char in label pos.9 In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18153 --- Comment #8 from Jonathan Druart --- The question is: Should not we call SetMarcUnicodeFlag from ModBiblioMarc to replace the whole "if ( $encoding eq "UNIMARC" ) {" block? (read s/encoding/marcflavour ...) -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon May 8 17:45:56 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 08 May 2017 15:45:56 +0000 Subject: [Koha-bugs] [Bug 16758] Caching issues in scripts running in daemon mode In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16758 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon May 8 17:46:07 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 08 May 2017 15:46:07 +0000 Subject: [Koha-bugs] [Bug 16758] Caching issues in scripts running in daemon mode In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16758 --- Comment #15 from Jonathan Druart --- Created attachment 63248 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=63248&action=edit Bug 16758: Use the default cache instance I do not see a valid reason not to use the default one instead of the syspref one. Signed-off-by: Jonathan Druart -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon May 8 17:46:02 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 08 May 2017 15:46:02 +0000 Subject: [Koha-bugs] [Bug 16758] Caching issues in scripts running in daemon mode In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16758 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #61820|0 |1 is obsolete| | --- Comment #14 from Jonathan Druart --- Created attachment 63247 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=63247&action=edit Bug 16758 - Caching issues in scripts running in daemon mode As L1 cache does not have expiration mechanism, scripts running in daemon mode (rebuild_zebra.pl -daemon, sip server ?, ...) would not be aware of any possible changes in the data being cached in upstream L2 cache. This patch adds ->flush_L1_caches() call in rebuild_zebra.pl inside daemon mode loop. To test: 1) apply patch 2) ensure that rebuild_zebra.pl -daemon is still working properly, without any noticeable performance degradation 3) stop memcached daemon and try to run rebuild_zebra.pl -daemon again: there should be a warning emitted stating that the script is running in daemon mode but without recommended caching system Signed-off-by: Josef Moravec Signed-off-by: Jonathan Druart -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon May 8 17:47:46 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 08 May 2017 15:47:46 +0000 Subject: [Koha-bugs] [Bug 18538] OPAC database user login internal server error In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18538 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |jonathan.druart at bugs.koha-c | |ommunity.org --- Comment #3 from Jonathan Druart --- Why do you want to login at the OPAC with the DB user? -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon May 8 17:50:05 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 08 May 2017 15:50:05 +0000 Subject: [Koha-bugs] [Bug 18553] Incorrect "Loading..." tag on moremember.tt when no clubs defined In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18553 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Failed QA CC| |jonathan.druart at bugs.koha-c | |ommunity.org --- Comment #3 from Jonathan Druart --- Same on circulation.pl -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon May 8 17:51:16 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 08 May 2017 15:51:16 +0000 Subject: [Koha-bugs] [Bug 18553] Incorrect "Loading..." tag on moremember.tt when no clubs defined In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18553 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |Signed Off --- Comment #4 from Jonathan Druart --- (In reply to Jonathan Druart from comment #3) > Same on circulation.pl I am going to fix it. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon May 8 17:54:07 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 08 May 2017 15:54:07 +0000 Subject: [Koha-bugs] [Bug 18538] OPAC database user login internal server error In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18538 --- Comment #4 from Lari Taskula --- (In reply to Jonathan Druart from comment #3) > Why do you want to login at the OPAC with the DB user? I was wondering the same, but previously it has been possible with a warning message displayed for the user. This error was caught by one of our PageObject tests. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon May 8 17:55:39 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 08 May 2017 15:55:39 +0000 Subject: [Koha-bugs] [Bug 18553] Incorrect "Loading..." tag on moremember.tt when no clubs defined In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18553 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon May 8 17:55:43 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 08 May 2017 15:55:43 +0000 Subject: [Koha-bugs] [Bug 18553] Incorrect "Loading..." tag on moremember.tt when no clubs defined In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18553 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #63216|0 |1 is obsolete| | --- Comment #5 from Jonathan Druart --- Created attachment 63249 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=63249&action=edit Bug 18553 - Incorrect "Loading..." tag on moremember.tt when no clubs defined To test: 1 - Have no clubs 2 - View Details tab for a patron 3 - Note the 'Loading' tag near the tabs 4 - Apply patch 5 - Load patron details and notice 'Loading' is gone 6 - Add a club and verify tab shows as expected Signed-off-by: Mark Tompsett Signed-off-by: Jonathan Druart -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon May 8 17:55:47 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 08 May 2017 15:55:47 +0000 Subject: [Koha-bugs] [Bug 18553] Incorrect "Loading..." tag on moremember.tt when no clubs defined In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18553 --- Comment #6 from Jonathan Druart --- Created attachment 63250 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=63250&action=edit Bug 18553 - Incorrect Loading... tag on circulation.tt when no clubs defined Signed-off-by: Jonathan Druart -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon May 8 17:57:36 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 08 May 2017 15:57:36 +0000 Subject: [Koha-bugs] [Bug 12461] Add patron clubs feature In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12461 --- Comment #83 from Jonathan Druart --- I do not understand the $return_scalar argument you use for get_club_enrollments and get_enrollable_clubs. Could you please explain? It seems useless, I suggest to remove it. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon May 8 18:10:56 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 08 May 2017 16:10:56 +0000 Subject: [Koha-bugs] [Bug 12461] Add patron clubs feature In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12461 --- Comment #84 from Kyle M Hall --- (In reply to Jonathan Druart from comment #83) > I do not understand the $return_scalar argument you use for > get_club_enrollments and get_enrollable_clubs. Could you please explain? > > It seems useless, I suggest to remove it. It is a hack solution to an big issue with template toolkit. Basically, when calling a method from Template Toolkit that would return a Koha::Objects derived class, the result will always be returned in list context. I've tried using the scalar plugin for TT but had no luck. Even worse, if the list has only 1 element, TT will convert it to just being that element with no list context. Then, if you try to call a TT list method ( such as 'size' ), it will try to call that method on the object instead and you'll get an error! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon May 8 18:16:48 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 08 May 2017 16:16:48 +0000 Subject: [Koha-bugs] [Bug 18538] OPAC database user login internal server error In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18538 --- Comment #5 from Jonathan Druart --- I'd prefer to handle the error (more or less gracefully) raising an exception from C4::Auth, rather than assuming that it's possible to login with this user. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon May 8 18:19:49 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 08 May 2017 16:19:49 +0000 Subject: [Koha-bugs] [Bug 18552] Borrower debarments do not show on member detail page. In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18552 Sally Healey changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |sally.healey at cheshireshared | |services.gov.uk -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon May 8 18:49:17 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 08 May 2017 16:49:17 +0000 Subject: [Koha-bugs] [Bug 18477] AR_PENDING notice does not populate values from article_requests table. In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18477 Kyle M Hall changed: What |Removed |Added ---------------------------------------------------------------------------- Patch complexity|--- |Trivial patch Status|NEW |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Mon May 8 18:49:26 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 08 May 2017 16:49:26 +0000 Subject: [Koha-bugs] [Bug 18477] AR_PENDING notice does not populate values from article_requests table. In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18477 --- Comment #1 from Kyle M Hall --- Created attachment 63251 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=63251&action=edit Bug 18477 - AR_PENDING notice does not populate values from article_requests table The default AR_PENDING letter does not print populate <> fields. Test Plan: 1) Enable article requests ( syspref: ArticleRequests => Enable, Circ and fine rules ALL/ALL (or a given category/itemtype): Article requests => Yes ) 2) Search for a title, click in to catalog detail, click 'Request Article' button. 3) Select Patron 4) Fill out request information 5) Click 'Place request' 6) Go to notices in patron record, inspect 'Article Request Received' notice. You should see the request information from step 4, but it doesn't display. 7) Apply this patch 8) Repeat steps 2-6, not the fields now display! -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Mon May 8 18:53:22 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 08 May 2017 16:53:22 +0000 Subject: [Koha-bugs] [Bug 18477] AR_PENDING notice does not populate values from article_requests table. In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18477 Kyle M Hall changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |kyle at bywatersolutions.com Severity|enhancement |major -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon May 8 18:58:56 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 08 May 2017 16:58:56 +0000 Subject: [Koha-bugs] [Bug 14540] Move member-flags.pl to PermissionsManager to better manage permissions for testing. In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14540 Lari Taskula changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #42410|0 |1 is obsolete| | Attachment #42434|0 |1 is obsolete| | Attachment #42550|0 |1 is obsolete| | Attachment #44490|0 |1 is obsolete| | --- Comment #23 from Lari Taskula --- Created attachment 63252 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=63252&action=edit Bug 14540 - Move member-flags.pl to PermissionsManager to better manage permissions for testing. Currently there is no nice way to grant/revoke permissions for Patrons in Koha. This is a big problem when doing integration testing and when working with permissions using the future REST API. Currently we have one web-script, member-flags.pl, which deals with all permission-related things. Basically it always DELETEs all your permissions and then adds them again with some modifications. There is no internal API for creating permissions and this makes automated testing significantly harder. To create permissions for a test patron, we must decrypt the arcane way of creating koha.borrowers.flags and add user_permissions with brittle SQL-queries. This makes for very messy test scripts, and quite frankly this is hardly ever done in Koha. Also the koha.borrowers.flags-column is pretty horrible. It is 19-bit binary array where each bit tells of the patron has all permissions for the respective permission module. This is very difficult to calculate and the mechanism is hard to understand. This feature is also unnecessary, since we are always interested in having the specific permissions. We don't need to know if one Patron has all the permissions for one module. Also what happens if more subpermissions are added to the module? Existing all-permission-holders lose their all-permissions-status? Instead we could have a nice internal API to work with permissions. My patch introduces a new database structure for permissions (not necessarily better), Koha::Object implementation of the DB structure, and most importantly, a Koha::Auth::PermissionManager which is a gateway to all permissions-related actions. This feature is well tested with unit tests and PageObject integration tests. See the tests for usage examples. Especially the t/db_dependent/Members/member-flags.t I hope you like it :) SELENIUM TESTS: Now that the new permission manager enables setting permissions easily in test environments. This patch introduces more complex PageObject regressions tests. -Logged in branch regression test for Intra. -OPAC password login/logout -OPAC anonymous search history preservation. VOCABULARY: Module (permission_modules) => a module which consists of specific Permissions. Typically covers one Module in Koha. Permission (permission) => a specific Permission of a Module. Granting a Patron the permission to do something. Patron permission (borrower_permissions) => A specific Permission a specific Patron has, eg. the permission to edit bibliographic records. TEST PLAN: -2. Note the permissions a bunch of patrons has. -1. run updatedatabase.pl 0. Observe that those patrons still have the same permissions. For modules which didn't have any subpermissions, a generic subpermission is added and the patrons should have it if they had the existing module permission. Basic login: 1. Go to Koha staff client 2. Make a password login. 3. Browse to any other staff client pages to confirm that the session is active and login persists on other pages. Modify permissions: 1. Go to member-flags.pl (Home ??? Patrons ??? Set permissions) 2. Change your permissions. Save. 3. Go back to member-flags.pl 4. Observe that you see the same permissions you just set. Modify superlibrarian permission: 1. Go to member-flags.pl (Home ??? Patrons ??? Set permissions) 2. Give the superlibrarian-permission. Observe all other permissions vanishing. Save. 3. Go back to member-flags.pl 4. Observe that you see only the superlibrarian-permission active. 5. Observe that the superlibrarian permission is the only top-level permission which doesn't have any subpermissions. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon May 8 19:01:12 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 08 May 2017 17:01:12 +0000 Subject: [Koha-bugs] [Bug 14540] Move member-flags.pl to PermissionsManager to better manage permissions for testing. In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14540 Lari Taskula changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #63252|0 |1 is obsolete| | --- Comment #24 from Lari Taskula --- Created attachment 63253 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=63253&action=edit Bug 14540 - Move member-flags.pl to PermissionsManager to better manage permissions for testing. Currently there is no nice way to grant/revoke permissions for Patrons in Koha. This is a big problem when doing integration testing and when working with permissions using the future REST API. Currently we have one web-script, member-flags.pl, which deals with all permission-related things. Basically it always DELETEs all your permissions and then adds them again with some modifications. There is no internal API for creating permissions and this makes automated testing significantly harder. To create permissions for a test patron, we must decrypt the arcane way of creating koha.borrowers.flags and add user_permissions with brittle SQL-queries. This makes for very messy test scripts, and quite frankly this is hardly ever done in Koha. Also the koha.borrowers.flags-column is pretty horrible. It is 19-bit binary array where each bit tells of the patron has all permissions for the respective permission module. This is very difficult to calculate and the mechanism is hard to understand. This feature is also unnecessary, since we are always interested in having the specific permissions. We don't need to know if one Patron has all the permissions for one module. Also what happens if more subpermissions are added to the module? Existing all-permission-holders lose their all-permissions-status? Instead we could have a nice internal API to work with permissions. My patch introduces a new database structure for permissions (not necessarily better), Koha::Object implementation of the DB structure, and most importantly, a Koha::Auth::PermissionManager which is a gateway to all permissions-related actions. This feature is well tested with unit tests and PageObject integration tests. See the tests for usage examples. Especially the t/db_dependent/Members/member-flags.t I hope you like it :) SELENIUM TESTS: Now that the new permission manager enables setting permissions easily in test environments. This patch introduces more complex PageObject regressions tests. -Logged in branch regression test for Intra. -OPAC password login/logout -OPAC anonymous search history preservation. VOCABULARY: Module (permission_modules) => a module which consists of specific Permissions. Typically covers one Module in Koha. Permission (permission) => a specific Permission of a Module. Granting a Patron the permission to do something. Patron permission (borrower_permissions) => A specific Permission a specific Patron has, eg. the permission to edit bibliographic records. TEST PLAN: -2. Note the permissions a bunch of patrons has. -1. run updatedatabase.pl 0. Observe that those patrons still have the same permissions. For modules which didn't have any subpermissions, a generic subpermission is added and the patrons should have it if they had the existing module permission. Basic login: 1. Go to Koha staff client 2. Make a password login. 3. Browse to any other staff client pages to confirm that the session is active and login persists on other pages. Modify permissions: 1. Go to member-flags.pl (Home ??? Patrons ??? Set permissions) 2. Change your permissions. Save. 3. Go back to member-flags.pl 4. Observe that you see the same permissions you just set. Modify superlibrarian permission: 1. Go to member-flags.pl (Home ??? Patrons ??? Set permissions) 2. Give the superlibrarian-permission. Observe all other permissions vanishing. Save. 3. Go back to member-flags.pl 4. Observe that you see only the superlibrarian-permission active. 5. Observe that the superlibrarian permission is the only top-level permission which doesn't have any subpermissions. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon May 8 19:04:13 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 08 May 2017 17:04:13 +0000 Subject: [Koha-bugs] [Bug 18228] Make list permissions easier to use/understand In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18228 --- Comment #28 from Jonathan Druart --- All looks good to me unless that it still sounds weird to loose this feature. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon May 8 19:07:10 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 08 May 2017 17:07:10 +0000 Subject: [Koha-bugs] [Bug 14540] Move member-flags.pl to PermissionsManager to better manage permissions for testing. In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14540 Lari Taskula changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #63253|0 |1 is obsolete| | --- Comment #25 from Lari Taskula --- Created attachment 63254 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=63254&action=edit Bug 14540 - Move member-flags.pl to PermissionsManager to better manage permissions for testing. Currently there is no nice way to grant/revoke permissions for Patrons in Koha. This is a big problem when doing integration testing and when working with permissions using the future REST API. Currently we have one web-script, member-flags.pl, which deals with all permission-related things. Basically it always DELETEs all your permissions and then adds them again with some modifications. There is no internal API for creating permissions and this makes automated testing significantly harder. To create permissions for a test patron, we must decrypt the arcane way of creating koha.borrowers.flags and add user_permissions with brittle SQL-queries. This makes for very messy test scripts, and quite frankly this is hardly ever done in Koha. Also the koha.borrowers.flags-column is pretty horrible. It is 19-bit binary array where each bit tells of the patron has all permissions for the respective permission module. This is very difficult to calculate and the mechanism is hard to understand. This feature is also unnecessary, since we are always interested in having the specific permissions. We don't need to know if one Patron has all the permissions for one module. Also what happens if more subpermissions are added to the module? Existing all-permission-holders lose their all-permissions-status? Instead we could have a nice internal API to work with permissions. My patch introduces a new database structure for permissions (not necessarily better), Koha::Object implementation of the DB structure, and most importantly, a Koha::Auth::PermissionManager which is a gateway to all permissions-related actions. This feature is well tested with unit tests and PageObject integration tests. See the tests for usage examples. Especially the t/db_dependent/Members/member-flags.t I hope you like it :) SELENIUM TESTS: Now that the new permission manager enables setting permissions easily in test environments. This patch introduces more complex PageObject regressions tests. -Logged in branch regression test for Intra. -OPAC password login/logout -OPAC anonymous search history preservation. VOCABULARY: Module (permission_modules) => a module which consists of specific Permissions. Typically covers one Module in Koha. Permission (permission) => a specific Permission of a Module. Granting a Patron the permission to do something. Patron permission (borrower_permissions) => A specific Permission a specific Patron has, eg. the permission to edit bibliographic records. TEST PLAN: -2. Note the permissions a bunch of patrons has. -1. run updatedatabase.pl 0. Observe that those patrons still have the same permissions. For modules which didn't have any subpermissions, a generic subpermission is added and the patrons should have it if they had the existing module permission. Basic login: 1. Go to Koha staff client 2. Make a password login. 3. Browse to any other staff client pages to confirm that the session is active and login persists on other pages. Modify permissions: 1. Go to member-flags.pl (Home ??? Patrons ??? Set permissions) 2. Change your permissions. Save. 3. Go back to member-flags.pl 4. Observe that you see the same permissions you just set. Modify superlibrarian permission: 1. Go to member-flags.pl (Home ??? Patrons ??? Set permissions) 2. Give the superlibrarian-permission. Observe all other permissions vanishing. Save. 3. Go back to member-flags.pl 4. Observe that you see only the superlibrarian-permission active. 5. Observe that the superlibrarian permission is the only top-level permission which doesn't have any subpermissions. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon May 8 19:10:12 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 08 May 2017 17:10:12 +0000 Subject: [Koha-bugs] [Bug 7174] Authentication rewriting In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7174 Lari Taskula changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #41536|0 |1 is obsolete| | Attachment #41537|0 |1 is obsolete| | --- Comment #24 from Lari Taskula --- Created attachment 63255 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=63255&action=edit Bug 7174 - Authentication Rewrite - Core Depends heavily on Buugg 14540, which introduces many tests to spot regression caused by this feature. Introduces a new modular authentication system based on Exception signaling and reusable authentication components/challenges. This system is cross-framework -compatible, currently supporting Mojolicious and CGI, but adding support for any other framework is straightforward. Central idea is to provide a single authentication function to deal with all types of authentication scenarios, REST API, Cookie, Password, LDAP... Also it is important to make a system that is easy to extend and can deal with many future authentication scenarios. Currently only CGI password, LDAP and cookie login is tested. Legacy behaviour is used to deal with other types of authentication. See the attached schematic in Bugzilla for a more architectural overview. Also fixes few bugs related to anonymous_search_history The basic principle is: 1. We get an authentication request from any Web/GUI-framework, for ex CGI. 2. Request is normalized by extracting all necessary authentication data elements to a separate data structure. 3. Based on the found authentication data elements, system decides which authentication route to take. 4. Route implements all challenges needed to authenticate the request. Route returns the authenticated Koha::Borrower or an Exception if login failed. 5. The user environment/session is set/deleted based on the Route result. 6. a Koha::Borrower and the CGISESSID-cookie is returned to the calling framework in the format the framework needs. 7. Framework needs to catch possible exceptions and deal with them. Eg. login failed, no permission, under maintenance. 8. Authentication succeeds and session is set, or failure is reported to user. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon May 8 20:09:04 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 08 May 2017 18:09:04 +0000 Subject: [Koha-bugs] [Bug 18557] New: Mysqlim CURRENT_DATE in Koha::Clubs::get_enrollable Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18557 Bug ID: 18557 Summary: Mysqlim CURRENT_DATE in Koha::Clubs::get_enrollable Change sponsored?: --- Product: Koha Version: unspecified Hardware: All OS: All Status: ASSIGNED Severity: normal Priority: P5 - low Component: Architecture, internals, and plumbing Assignee: kyle at bywatersolutions.com Reporter: jonathan.druart at bugs.koha-community.org QA Contact: testopia at bugs.koha-community.org Depends on: 12461 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12461 [Bug 12461] Add patron clubs feature -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon May 8 20:09:04 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 08 May 2017 18:09:04 +0000 Subject: [Koha-bugs] [Bug 12461] Add patron clubs feature In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12461 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |18557 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18557 [Bug 18557] Mysqlim CURRENT_DATE in Koha::Clubs::get_enrollable -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon May 8 20:37:01 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 08 May 2017 18:37:01 +0000 Subject: [Koha-bugs] [Bug 18558] New: Koha::Clubs::get_enrollable explodes if no patron given Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18558 Bug ID: 18558 Summary: Koha::Clubs::get_enrollable explodes if no patron given Change sponsored?: --- Product: Koha Version: unspecified Hardware: All OS: All Status: ASSIGNED Severity: normal Priority: P5 - low Component: Architecture, internals, and plumbing Assignee: kyle at bywatersolutions.com Reporter: jonathan.druart at bugs.koha-community.org QA Contact: testopia at bugs.koha-community.org Depends on: 12461 The method should not make $params->{borrower} mandatory. But if not passed, the method explodes with Can't call method "branchcode" on an undefined value at /home/vagrant/kohaclone/Koha/Clubs.pm line 60. Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12461 [Bug 12461] Add patron clubs feature -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon May 8 20:37:01 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 08 May 2017 18:37:01 +0000 Subject: [Koha-bugs] [Bug 12461] Add patron clubs feature In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12461 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |18558 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18558 [Bug 18558] Koha::Clubs::get_enrollable explodes if no patron given -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon May 8 20:47:42 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 08 May 2017 18:47:42 +0000 Subject: [Koha-bugs] [Bug 18558] Koha::Clubs->get_enrollable explodes if no patron given In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18558 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Summary|Koha::Clubs::get_enrollable |Koha::Clubs->get_enrollable |explodes if no patron given |explodes if no patron given -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon May 8 20:48:18 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 08 May 2017 18:48:18 +0000 Subject: [Koha-bugs] [Bug 18559] New: Koha:: Clubs - methods should not get the return type in parameter Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18559 Bug ID: 18559 Summary: Koha::Clubs - methods should not get the return type in parameter Change sponsored?: --- Product: Koha Version: unspecified Hardware: All OS: All Status: ASSIGNED Severity: normal Priority: P5 - low Component: Architecture, internals, and plumbing Assignee: kyle at bywatersolutions.com Reporter: jonathan.druart at bugs.koha-community.org QA Contact: testopia at bugs.koha-community.org Depends on: 12461, 18553 Koha::Clubs->get_club_enrollments and Koha::Clubs->get_enrollable_clubs take a $return_scalar parameter. The return value type should not be a parameter. We should return _new_from_dbic or Koha::Objects->search in any cases. Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12461 [Bug 12461] Add patron clubs feature https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18553 [Bug 18553] Incorrect "Loading..." tag on moremember.tt when no clubs defined -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon May 8 20:48:18 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 08 May 2017 18:48:18 +0000 Subject: [Koha-bugs] [Bug 12461] Add patron clubs feature In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12461 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |18559 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18559 [Bug 18559] Koha::Clubs - methods should not get the return type in parameter -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon May 8 20:48:18 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 08 May 2017 18:48:18 +0000 Subject: [Koha-bugs] [Bug 18553] Incorrect "Loading..." tag on moremember.tt when no clubs defined In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18553 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |18559 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18559 [Bug 18559] Koha::Clubs - methods should not get the return type in parameter -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon May 8 20:50:18 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 08 May 2017 18:50:18 +0000 Subject: [Koha-bugs] [Bug 18559] Koha:: Clubs - methods should not get the return type in parameter In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18559 --- Comment #1 from Jonathan Druart --- Created attachment 63256 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=63256&action=edit Bug 18559: Koha::Clubs - Remove $return_scalar from parameters -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon May 8 20:50:38 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 08 May 2017 18:50:38 +0000 Subject: [Koha-bugs] [Bug 18559] Koha:: Clubs - methods should not get the return type in parameter In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18559 --- Comment #2 from Jonathan Druart --- Kyle, Here is my try. But tests fail now... -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon May 8 21:45:59 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 08 May 2017 19:45:59 +0000 Subject: [Koha-bugs] [Bug 17015] New Koha Calendar In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17015 Mehdi Hamidi changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #60904|0 |1 is obsolete| | --- Comment #70 from Mehdi Hamidi --- Created attachment 63257 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=63257&action=edit Bug 17015 - Koha now uses the new DiscreteCalendar module -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon May 8 22:17:28 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 08 May 2017 20:17:28 +0000 Subject: [Koha-bugs] [Bug 13944] Fund sorting is inconsistent across different parts of Koha In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13944 --- Comment #3 from Marjorie Barry-Vila --- Hi, I prefer too, sort by fund name. But now in 16.11, fund pulldown for an order line ( acqui/neworderempty.pl ) is sort by Fund code. But in acqui/invoice.pl, shipping funds are sort by Name (and other problem, all funds are displayed). Anyone want to works on it? Regards, Marjorie -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon May 8 22:17:51 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 08 May 2017 20:17:51 +0000 Subject: [Koha-bugs] [Bug 14850] Funds from inactive budgets appear in 'Funds' dropdown on acqui/invoice.pl In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14850 Marjorie Barry-Vila changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |marjorie.barry-vila at ccsr.qc | |.ca -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon May 8 22:29:14 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 08 May 2017 20:29:14 +0000 Subject: [Koha-bugs] [Bug 13944] Fund sorting is inconsistent across different parts of Koha In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13944 --- Comment #4 from Sandre Cunha --- I think fund name would be the best option. Between our operating and our trust fund budget, we have a lot of fund codes, and sorting by the code would not put the fund lines in any kind of meaningful order. At least if the sort is by fund name, one has the option of adding words or letters to force the sort into the order one wants. The sorting by order of creation is a nightmare when you are trying to create a budget and group things in a logical way. If you miss one, or had a couple of last minute additions, you either have to re-do the whole thing, or just let them hang out at the bottom, rather in a related group. It would be nice to be able to re-sort them, but if the default was to sort by name, this issue would less of a problem. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon May 8 22:29:31 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 08 May 2017 20:29:31 +0000 Subject: [Koha-bugs] [Bug 15399] MARCXML records larger than 1 MB (1048576 bytes) are not searchable. In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15399 --- Comment #12 from Barton Chittenden --- (In reply to Barton Chittenden from comment #8) > It turns out that the 1024 K limit is the default max record size in > zebrasrv; this can be changed using the -k option to zebrasrv. > > man zebrasrv shows: > > -k size > Maximum record size/message size, in kilobytes. Default is 1024 KB (1 MB). > > This could be increased in koha-start-zebra, koha-restart-zebra and > koha-zebra. I imagine the change would look something like this: > > from > > zebrasrv \ > -v $loglevels \ > -f "/etc/koha/sites/$instancename/koha-conf.xml" && \ > return 0 || \ > return 1 > > to > > zebrasrv \ > -v $loglevels \ > -k $max_record_size > -f "/etc/koha/sites/$instancename/koha-conf.xml" && \ > return 0 || \ > return 1 > > where $max_record_size would be read from $KOHA_CONF in the same manner that > $loglevels is. Based on my testing, I believe that the documentation is wrong -- the value of -k is in bytes, not Kilobytes. -- This may be a moot point, considering the issues with Z39.50. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon May 8 22:31:02 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 08 May 2017 20:31:02 +0000 Subject: [Koha-bugs] [Bug 15399] MARCXML records larger than 1 MB (1048576 bytes) are not searchable. In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15399 --- Comment #13 from Barton Chittenden --- (In reply to alfre69 from comment #9) > If you increase $max_record_size too much it breaks the Z39.50 server. > > A yaz-client search report this: > > Target has closed the association. > Reason: protocolError, message: Incoming package too large Does this error occur on *all* searches, or simply searches whose results are greater than 1 MB? -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon May 8 22:53:29 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 08 May 2017 20:53:29 +0000 Subject: [Koha-bugs] [Bug 17509] Notify patrons to return items requested on hold by another person In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17509 --- Comment #23 from Radek ?iman (R-Bit Technology, s.r.o.) --- Created attachment 63258 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=63258&action=edit Bug 17509: Added tests prove t/db_dependent/Reserves/Notification.t -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon May 8 22:55:34 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 08 May 2017 20:55:34 +0000 Subject: [Koha-bugs] [Bug 17509] Notify patrons to return items requested on hold by another person In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17509 Radek ?iman (R-Bit Technology, s.r.o.) changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon May 8 23:43:34 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 08 May 2017 21:43:34 +0000 Subject: [Koha-bugs] [Bug 17944] Remove the sql code from itemtypes.pl administrative perl script In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17944 Alex Buckley changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #63220|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon May 8 23:44:06 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 08 May 2017 21:44:06 +0000 Subject: [Koha-bugs] [Bug 17944] Remove the sql code from itemtypes.pl administrative perl script In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17944 --- Comment #50 from Alex Buckley --- Created attachment 63259 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=63259&action=edit Bug 17944 - Removed SQl query from itemtypes.pl and replaced it with can_be_deleted method in Koha/ItemType.pm In Koha/ItemTypes.t I have reworded unit test output and added test for item deletion. In addition to updating admin script by removing warn and changing if statement check -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon May 8 23:59:36 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 08 May 2017 21:59:36 +0000 Subject: [Koha-bugs] [Bug 17944] Remove the sql code from itemtypes.pl administrative perl script In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17944 Alex Buckley changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |Needs Signoff --- Comment #51 from Alex Buckley --- Hi Jonathan In the patch I just attached I have addressed all of your points: 1) > You are not retrieving any item type here, ->can_be_deleted will only return 0. > You need to call Koha::ItemType->find($id); to retrieve the item type object > you want from the DB. I have changed the itemtypes.pl admin script (see below) so it now performs the can_be_deleted() function on the result of the find() function, therefore it is actually retrieving a item type here: > 142 my $ItemType = Koha::ItemTypes->find($itemtype_code); > 143 my $overalltotal = $ItemType->can_be_deleted(); > 144 if ($overalltotal == 0) { > 145 push @messages, { type => 'error', code => 'cannot_be_delet ed'}; 2) > my $itemtype = Koha::ItemTypes->find($itemtype_code); > + my $deleted = eval{ $itemtype->delete };; > Unnecessary change. I have changed the above code removing the changes to the second line and removing the second semi colon in the second line (see below): > 153 my $itemtype = Koha::ItemTypes->find($itemtype_code); > 154 my $deleted = eval { $itemtype->delete }; 3) > This second try does not test what you want, see my previous comment: > """ > The last test says 'An item type that is used by a biblioitem cannot be > deleted'. But actually you are testing that "an item that is used by AN item > AND A biblioitem cannot be deleted'. > You should delete the item to make it test what you want to test. > """ I have changed the test output from 'an item that is used by AN item AND A biblioitem cannot be deleted' to 'An item type that is used by an item and a biblioitem cannot be deleted' because we are actually running the can_be_deleted() function on itemtype not an item. Additionally I have implemented a test for deleting the item and biblioitem that use the itemtype in question. Then I have implemented another further test to show that now the item and biblioitem have been removed the can_be_deleted() function correctly shows that the itemtype can be deleted: > 145 is ( $item->delete, 1, 'An item has been deleted' ); > 146 > 147 is ( $biblio->delete, 1, 'A biblioitem has been deleted' ); > 148 > 149 is ( $item_type->can_be_deleted, 1, 'The item type that was being u sed > by the removed item and biblioitem can now be deleted' ); I have run the ItemTypes.t unit test and all tests are successful: > kohadev-koha at kohadevbox:/home/vagrant/kohaclone/t/db_dependent/Koha$ prove -v > ItemTypes.t > ItemTypes.t .. > 1..26 > ok 1 - use Koha::ItemType; > ok 2 - use Koha::ItemTypes; > ok 3 - first result > ok 4 - itemtype/code > ok 5 - description > ok 6 - rentalcharge > ok 7 - imageurl > ok 8 - summary > ok 9 - checkinmsg > ok 10 - checkinmsgtype > ok 11 - second result > ok 12 - itemtype/code > ok 13 - description > ok 14 - rentalcharge > ok 15 - imageurl > ok 16 - summary > ok 17 - checkinmsg > ok 18 - checkinmsgtype > ok 19 - There are 3 item types > ok 20 - item types should be sorted by translated description > ok 21 - An item type that is not used can be deleted > ok 22 - An item type that is used by an item cannot be deleted > ok 23 - An item that is used by an item and a biblioitem cannot be deleted > ok 24 - An item has been deleted > ok 25 - A biblioitem has been deleted > ok 26 - The item type that was being used by the removed item and biblioitem > can be deleted > ok > All tests successful. Cheers Alex -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue May 9 00:33:15 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 08 May 2017 22:33:15 +0000 Subject: [Koha-bugs] [Bug 18534] When IndependentBranches is enabled the pickup location displayed incorrectly on request.pl In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18534 Alex Buckley changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue May 9 00:33:21 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 08 May 2017 22:33:21 +0000 Subject: [Koha-bugs] [Bug 18534] When IndependentBranches is enabled the pickup location displayed incorrectly on request.pl In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18534 Alex Buckley changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #63043|0 |1 is obsolete| | --- Comment #2 from Alex Buckley --- Created attachment 63260 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=63260&action=edit Bug 18534 - When IndependentBranches is enabled the pickup location displayed incorrectly on request.pl To recreate: 1 - Place a hold for pickup at Midway 2 - Enable independentbranches 3 - Login to staff interface as admin without superlibrarian status from a different branch 4 - View the holds for the title you placed a hold on 5 - The hold placed in step 1 should show a dropdown with current branch as pickup location, current branch is the only in that dropdown 6 - Verify it displays correctly for superlibrarian 7 - Apply patch 8 - The correct pickup location should show and not be editable 9 - Verify it is a dropdown Signed-off-by: Alex Buckley -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue May 9 00:41:46 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 08 May 2017 22:41:46 +0000 Subject: [Koha-bugs] [Bug 18477] AR_PENDING notice does not populate values from article_requests table. In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18477 Eric Phetteplace changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #63251|0 |1 is obsolete| | --- Comment #2 from Eric Phetteplace --- Created attachment 63261 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=63261&action=edit Bug 18477 - AR_PENDING notice does not populate values from article_requests table The default AR_PENDING letter does not print populate <> fields. Test Plan: 1) Enable article requests ( syspref: ArticleRequests => Enable, Circ and fine rules ALL/ALL (or a given category/itemtype): Article requests => Yes ) 2) Search for a title, click in to catalog detail, click 'Request Article' button. 3) Select Patron 4) Fill out request information 5) Click 'Place request' 6) Go to notices in patron record, inspect 'Article Request Received' notice. You should see the request information from step 4, but it doesn't display. 7) Apply this patch 8) Repeat steps 2-6, not the fields now display! Signed-off-by: Eric Phetteplace -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue May 9 00:42:23 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 08 May 2017 22:42:23 +0000 Subject: [Koha-bugs] [Bug 18477] AR_PENDING notice does not populate values from article_requests table. In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18477 Eric Phetteplace changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue May 9 00:48:53 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 08 May 2017 22:48:53 +0000 Subject: [Koha-bugs] [Bug 18528] Patron card creator template: switch form fields for card height and card width In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18528 Alex Buckley changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue May 9 00:48:59 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 08 May 2017 22:48:59 +0000 Subject: [Koha-bugs] [Bug 18528] Patron card creator template: switch form fields for card height and card width In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18528 Alex Buckley changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #63017|0 |1 is obsolete| | --- Comment #3 from Alex Buckley --- Created attachment 63262 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=63262&action=edit Bug 18528: Patron card creator template: switch form fields for card height and card width This patch changes the sequnce of form fields for card height and card width. To test: - Apply patch - Edit or create a patron card template - Verify that the fields display in sequence Page height - Page width -Card height - Card width Followed test plan, worked as intended Signed-off-by: Alex Buckley -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue May 9 01:48:22 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 08 May 2017 23:48:22 +0000 Subject: [Koha-bugs] [Bug 18541] Patron card creator: Add a grid to support layout design In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18541 Alex Buckley changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |alexbuckley at catalyst.net.nz --- Comment #6 from Alex Buckley --- Created attachment 63263 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=63263&action=edit Unit description and card dimension on patron card batch Hi Marc This patch works well but I have one question: You say in your test plan that the card batches should have the unit description displayed in the bottom left (which I have got) but the card dimensions should be in the bottom right however I have found mine is in the top right (see screenshot) is this what you intended? -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue May 9 01:53:55 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 08 May 2017 23:53:55 +0000 Subject: [Koha-bugs] [Bug 18541] Patron card creator: Add a grid to support layout design In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18541 --- Comment #7 from Marc V?ron --- (In reply to Alex Buckley from comment #6) > Created attachment 63263 [details] > Unit description and card dimension on patron card batch > > Hi Marc > > This patch works well but I have one question: > > You say in your test plan that the card batches should have the unit > description displayed in the bottom left (which I have got) but the card > dimensions should be in the bottom right however I have found mine is in the > top right (see screenshot) is this what you intended? Hi Alex, Yes indeed, I misaked with my description. It should appear top right (as you describe) to indicate that the coordinate system is from bottom left = 0/0 to top right. If you sign off, can you please change the test plan in the patch attached? Thanks! Marc -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue May 9 03:21:29 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 09 May 2017 01:21:29 +0000 Subject: [Koha-bugs] [Bug 18551] Hide with CSS dynamic elements in member search In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18551 Liz Rea changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |liz at catalyst.net.nz --- Comment #5 from Liz Rea --- This is happening all over, and I think possibly it's more to do with when the JS is loading. Maybe instead of document.ready, we need document.onload? -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue May 9 04:59:33 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 09 May 2017 02:59:33 +0000 Subject: [Koha-bugs] [Bug 14716] opac-detail.pl -- Series link fails when series title ends with semicolon preceded by space. In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14716 --- Comment #23 from Mason James --- (In reply to Katrin Fischer from comment #22) > Removing the ; would be an incomplete fix, but much easier to do as a > workaround solution. ..after re-readed this bug, i agree with Katrin :0) -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue May 9 06:13:37 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 09 May 2017 04:13:37 +0000 Subject: [Koha-bugs] [Bug 18560] New: RSS Feed link from OPAC shelves is broken Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18560 Bug ID: 18560 Summary: RSS Feed link from OPAC shelves is broken Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: minor Priority: P5 - low Component: OPAC Assignee: oleonard at myacpl.org Reporter: mtompset at hotmail.com QA Contact: testopia at bugs.koha-community.org -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue May 9 06:13:49 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 09 May 2017 04:13:49 +0000 Subject: [Koha-bugs] [Bug 18560] RSS Feed link from OPAC shelves is broken In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18560 M. Tompsett changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|oleonard at myacpl.org |mtompset at hotmail.com Status|NEW |ASSIGNED -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue May 9 06:18:19 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 09 May 2017 04:18:19 +0000 Subject: [Koha-bugs] [Bug 18560] RSS Feed link from OPAC shelves is broken In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18560 M. Tompsett changed: What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue May 9 06:18:21 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 09 May 2017 04:18:21 +0000 Subject: [Koha-bugs] [Bug 18560] RSS Feed link from OPAC shelves is broken In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18560 --- Comment #1 from M. Tompsett --- Created attachment 63264 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=63264&action=edit Bug 18560: RSS link in opac shelves is broken TEST PLAN --------- 1) have books entered 2) log in create a list 3) add books to list 4) display list 5) click the RSS link button. -- bad HASH error. 6) apply patch 7) repeat steps 4&5 -- readble junk without error messages. 8) run koha qa test tools -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue May 9 06:32:10 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 09 May 2017 04:32:10 +0000 Subject: [Koha-bugs] [Bug 18493] Add more languages to advanced search languages dropdown In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18493 Marc V?ron changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #62679|0 |1 is obsolete| | --- Comment #3 from Marc V?ron --- Created attachment 63265 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=63265&action=edit Bug 18493: Add new searchable languages This patch adds the following languages into advanced search "Languages" dropdown: Bosnian Welsh Esperanto Estonian Irish Gaelic Scottish Gaelic Ancient Greek Kazakh Greenlandic Karelian Cornish Lithuanian Latvian Burmese Punjabi Pashto Finnish Kalo Sanskrit Akkala Sami Kildin Sami Ter Sami Pite Sami Kemi Sami Ume Sami Southern Sami Northern Sami Sami languages Lule Sami Inari Sami Skolt Sami Somali Sotho Votic Yiddish To test: 1. perl installer/data/mysql/updatedatabase.pl 2. Go to intranet advanced search 3. Click "More options" 4. See "Limits" fieldset, it should have "Language" drop down 5. Observe that the languages provided in this patch are visible in this dropdown Signed-off-by: Marc V?ron -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue May 9 06:32:28 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 09 May 2017 04:32:28 +0000 Subject: [Koha-bugs] [Bug 18493] Add more languages to advanced search languages dropdown In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18493 Marc V?ron changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |veron at veron.ch Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue May 9 06:50:14 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 09 May 2017 04:50:14 +0000 Subject: [Koha-bugs] [Bug 18560] RSS Feed link from OPAC shelves is broken In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18560 Marc V?ron changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #63264|0 |1 is obsolete| | --- Comment #2 from Marc V?ron --- Created attachment 63266 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=63266&action=edit Bug 18560: RSS link in opac shelves is broken TEST PLAN --------- 1) have books entered 2) log in create a list 3) add books to list 4) display list 5) click the RSS link button. -- bad HASH error. 6) apply patch 7) repeat steps 4&5 -- readble junk without error messages. 8) run koha qa test tools Signed-off-by: Marc V?ron -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue May 9 07:25:03 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 09 May 2017 05:25:03 +0000 Subject: [Koha-bugs] [Bug 18554] Adjust a few typos including responsability In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18554 --- Comment #2 from Marc V?ron --- Created attachment 63267 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=63267&action=edit BUG 18505: opac-search-history does not respect opacPublic The opac-search-history page was available regardless of the opacPublic setting, this patch corrects that. Test plan, set opacPublic to 'No', test whether opac-search-history page is available when not logged in, note that it is. Apply patch, test whether opac-search-history is still available when not logged in, note that you should be redirected to the login page. Signed-off-by: Katrin Fischer Signed-off-by: Nick Clemens Signed-off-by: Kyle M Hall Signed-off-by: Marc V?ron -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue May 9 07:25:45 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 09 May 2017 05:25:45 +0000 Subject: [Koha-bugs] [Bug 18554] Adjust a few typos including responsability In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18554 Marc V?ron changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |veron at veron.ch Attachment #63267|0 |1 is obsolete| | --- Comment #3 from Marc V?ron --- Comment on attachment 63267 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=63267 BUG 18505: opac-search-history does not respect opacPublic Sorry, mistaked... -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue May 9 07:27:16 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 09 May 2017 05:27:16 +0000 Subject: [Koha-bugs] [Bug 18554] Adjust a few typos including responsability In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18554 Marc V?ron changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #63231|0 |1 is obsolete| | --- Comment #4 from Marc V?ron --- Created attachment 63268 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=63268&action=edit Bug 18554: Adjust a few typos including responsability typo responsability typo defautl in authorities.pref typo reveived in t/db_dependent/Acquisition.t typo ;; in advance_notices.pl typo Stopping in restart_indexer (koha-indexer) typo instutitional in moremember.pl typo Corretly (Biblio.t) typo periodicy in help serials Signed-off-by: Marcel de Rooy Signed-off-by: Marc V?ron -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue May 9 07:27:53 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 09 May 2017 05:27:53 +0000 Subject: [Koha-bugs] [Bug 18554] Adjust a few typos including responsability In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18554 Marc V?ron changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue May 9 08:26:45 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 09 May 2017 06:26:45 +0000 Subject: [Koha-bugs] [Bug 17509] Notify patrons to return items requested on hold by another person In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17509 Josef Moravec changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #57157|0 |1 is obsolete| | --- Comment #24 from Josef Moravec --- Created attachment 63269 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=63269&action=edit [SIGNED-OFF] Bug 17509: Added NotifyToReturnItemWhenHoldIsPlaced syspref This system preference will allow to ask patrons to return items whenever a new hold is placed on them Test plan: 1) Open System preferences / Circulation / Holds Policy 2) Change value from Enable to Don't enable and vice versa 3) Check NotifyToReturnItemWhenHoldIsPlaced is changed in database Signed-off-by: Josef Moravec -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue May 9 08:27:04 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 09 May 2017 06:27:04 +0000 Subject: [Koha-bugs] [Bug 17509] Notify patrons to return items requested on hold by another person In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17509 Josef Moravec changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #57159|0 |1 is obsolete| | --- Comment #25 from Josef Moravec --- Created attachment 63270 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=63270&action=edit [SIGNED-OFF] Bug 17509: Added system preference to restrict recipients based on library Test plan: 1) apply patch 2) go to System preferences / Circulation / Holds Policy 3) change which patrons will be contacted 4) compare your change against database value NotifyToReturnItemFromLibrary Signed-off-by: Josef Moravec -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue May 9 08:27:14 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 09 May 2017 06:27:14 +0000 Subject: [Koha-bugs] [Bug 17509] Notify patrons to return items requested on hold by another person In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17509 Josef Moravec changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #57160|0 |1 is obsolete| | --- Comment #26 from Josef Moravec --- Created attachment 63271 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=63271&action=edit [SIGNED-OFF] Bug 17509: Improved system preferences for item return notification Test plan: 1) apply patch 2) go to System preferences / Circulation / Holds Policy 3) change NotifyToReturn* variables as you wish 4) verify your changes in database Signed-off-by: Josef Moravec -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue May 9 08:27:20 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 09 May 2017 06:27:20 +0000 Subject: [Koha-bugs] [Bug 17509] Notify patrons to return items requested on hold by another person In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17509 Josef Moravec changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #57161|0 |1 is obsolete| | --- Comment #27 from Josef Moravec --- Created attachment 63272 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=63272&action=edit [SIGNED-OFF] Bug 17509: renamed atomic file to suit conventions Signed-off-by: Josef Moravec -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue May 9 08:27:25 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 09 May 2017 06:27:25 +0000 Subject: [Koha-bugs] [Bug 17509] Notify patrons to return items requested on hold by another person In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17509 Josef Moravec changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #57162|0 |1 is obsolete| | --- Comment #28 from Josef Moravec --- Created attachment 63273 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=63273&action=edit [SIGNED-OFF] Bug 17509: Removed old name of atomic update file Signed-off-by: Josef Moravec -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue May 9 08:27:30 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 09 May 2017 06:27:30 +0000 Subject: [Koha-bugs] [Bug 17509] Notify patrons to return items requested on hold by another person In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17509 Josef Moravec changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #57163|0 |1 is obsolete| | --- Comment #29 from Josef Moravec --- Created attachment 63274 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=63274&action=edit [SIGNED-OFF] Bug 17509: Added notification letter HOLDPLACED_CONTACT Signed-off-by: Josef Moravec -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue May 9 08:27:35 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 09 May 2017 06:27:35 +0000 Subject: [Koha-bugs] [Bug 17509] Notify patrons to return items requested on hold by another person In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17509 Josef Moravec changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #57164|0 |1 is obsolete| | --- Comment #30 from Josef Moravec --- Created attachment 63275 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=63275&action=edit [SIGNED-OFF] Bug 17509: notify patrons to return an item whenever a hold is placed on it Test plan: 1) apply patch 2) run database update 3) enable sending an email to the patrons to return an item whenever a hold request is placed on it 4) place a hold 5) patrons having checked-out the item on hold are notified by email (see HOLDPLACED_CONTACT letter) Signed-off-by: Josef Moravec -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue May 9 08:27:40 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 09 May 2017 06:27:40 +0000 Subject: [Koha-bugs] [Bug 17509] Notify patrons to return items requested on hold by another person In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17509 Josef Moravec changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #57165|0 |1 is obsolete| | --- Comment #31 from Josef Moravec --- Created attachment 63276 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=63276&action=edit [SIGNED-OFF] Bug 17509: Fixed invalid patterns Signed-off-by: Josef Moravec -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue May 9 08:27:45 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 09 May 2017 06:27:45 +0000 Subject: [Koha-bugs] [Bug 17509] Notify patrons to return items requested on hold by another person In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17509 --- Comment #32 from Josef Moravec --- Created attachment 63277 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=63277&action=edit [SIGNED-OFF] Bug 17509: Added tests prove t/db_dependent/Reserves/Notification.t Signed-off-by: Josef Moravec Test pass -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue May 9 08:28:16 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 09 May 2017 06:28:16 +0000 Subject: [Koha-bugs] [Bug 17509] Notify patrons to return items requested on hold by another person In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17509 Josef Moravec changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #63258|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue May 9 08:28:58 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 09 May 2017 06:28:58 +0000 Subject: [Koha-bugs] [Bug 17509] Notify patrons to return items requested on hold by another person In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17509 Josef Moravec changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off --- Comment #33 from Josef Moravec --- I tested the last patch and rebased the whole patchset on master. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue May 9 08:32:56 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 09 May 2017 06:32:56 +0000 Subject: [Koha-bugs] [Bug 18548] running koha-create --request-db without an instance name should abort In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18548 Josef Moravec changed: What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue May 9 08:32:59 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 09 May 2017 06:32:59 +0000 Subject: [Koha-bugs] [Bug 18548] running koha-create --request-db without an instance name should abort In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18548 Josef Moravec changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #63159|0 |1 is obsolete| | --- Comment #7 from Josef Moravec --- Created attachment 63278 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=63278&action=edit Bug 18548: Print usage when missing instance name in koha-create script Test plan: 1. Run: debian/scripts/koha-create --request-db -> Without patch you see the getent error message -> With patch you see usage and "Missing instance name" message -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue May 9 08:33:42 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 09 May 2017 06:33:42 +0000 Subject: [Koha-bugs] [Bug 18548] running koha-create --request-db without an instance name should abort In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18548 Josef Moravec changed: What |Removed |Added ---------------------------------------------------------------------------- Keywords| |Academy -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue May 9 09:03:13 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 09 May 2017 07:03:13 +0000 Subject: [Koha-bugs] [Bug 18551] Hide with CSS dynamic elements in member search In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18551 Fridolin SOMERS changed: What |Removed |Added ---------------------------------------------------------------------------- Status|In Discussion |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue May 9 09:08:12 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 09 May 2017 07:08:12 +0000 Subject: [Koha-bugs] [Bug 18551] Hide with CSS dynamic elements in member search In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18551 --- Comment #6 from Fridolin SOMERS --- (In reply to Liz Rea from comment #5) > This is happening all over, and I think possibly it's more to do with when > the JS is loading. > > Maybe instead of document.ready, we need document.onload? Ah, I dont know that. I think we should has this on koha-dev. But I think this patch will always be usefull because it converts existing hide() JS call into CSS, which is more performant. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue May 9 09:31:38 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 09 May 2017 07:31:38 +0000 Subject: [Koha-bugs] [Bug 15399] MARCXML records larger than 1 MB (1048576 bytes) are not searchable. In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15399 --- Comment #14 from Fridolin SOMERS --- We had the same issue and proposed rebuild_zebra.pl options on Bug 10482 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue May 9 09:34:38 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 09 May 2017 07:34:38 +0000 Subject: [Koha-bugs] [Bug 15399] MARCXML records larger than 1 MB (1048576 bytes) are not searchable. In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15399 --- Comment #15 from Fridolin SOMERS --- Looks like the perl Module Net-Z3950-ZOOM also has an option to specify max record size (1MB by default). http://search.cpan.org/~mirk/Net-Z3950-ZOOM/lib/ZOOM.pod#option()_/_option_binary() -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue May 9 10:05:12 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 09 May 2017 08:05:12 +0000 Subject: [Koha-bugs] [Bug 8612] CSV export profile to have custom fields in export csv basket In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8612 Josef Moravec changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #63158|0 |1 is obsolete| | --- Comment #100 from Josef Moravec --- Created attachment 63279 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=63279&action=edit Bug 8612: QA followup - strip white chars from csv profile definition, expand test -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue May 9 10:06:03 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 09 May 2017 08:06:03 +0000 Subject: [Koha-bugs] [Bug 8612] CSV export profile to have custom fields in export csv basket In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8612 --- Comment #101 from Josef Moravec --- Ok, it was not good solution, now should be better ;) -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue May 9 10:22:03 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 09 May 2017 08:22:03 +0000 Subject: [Koha-bugs] [Bug 18438] Check in: Modal about holds hides important check in messages In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18438 --- Comment #21 from Josef Moravec --- (In reply to Jonathan Druart from comment #20) > I do not understand where we are with these patches. > What are the expected behaviour changes? As I understand, the change is, that the page doesn't reload after dismissing hold modal window, so the message under the window does not disappear and user haven't wait for another reload... -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue May 9 10:23:29 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 09 May 2017 08:23:29 +0000 Subject: [Koha-bugs] [Bug 14570] Make it possible to add multiple guarantors to a record In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14570 Josef Moravec changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |josef.moravec at gmail.com -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue May 9 10:28:09 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 09 May 2017 08:28:09 +0000 Subject: [Koha-bugs] [Bug 13995] Proper Exception handling In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13995 --- Comment #24 from Josef Moravec --- (In reply to Olli-Antti Kivilahti from comment #23) > Created attachment 60963 [details] [review] > Bug 13995 - Proper Exception handling Is it ready for testing again? What is the test plan? -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue May 9 11:00:04 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 09 May 2017 09:00:04 +0000 Subject: [Koha-bugs] [Bug 15399] MARCXML records larger than 1 MB (1048576 bytes) are not searchable. In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15399 --- Comment #16 from alfre69 --- (In reply to Barton Chittenden from comment #13) > (In reply to alfre69 from comment #9) > > If you increase $max_record_size too much it breaks the Z39.50 server. > > > > A yaz-client search report this: > > > > Target has closed the association. > > Reason: protocolError, message: Incoming package too large > > Does this error occur on *all* searches, or simply searches whose results > are greater than 1 MB? It occurs on all searches, so the Z39.50 server is not usable when increasing $max_record_size. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue May 9 11:20:05 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 09 May 2017 09:20:05 +0000 Subject: [Koha-bugs] [Bug 18549] There should be a warning that logging out of Koha will leave browser session logged in to OAuth In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18549 --- Comment #6 from Martin Renvoize --- I think this bug is somewhat misleading to the user, unfortunately. Here's some questions that only the most technically aware will think to ask at this point. 1) If I login to app A (also a google openid connect consumer), then login to koha, then logout of app A will I be logged out of Koha too? - Current answer - No 2) If I loging to google, then login to Koha, then logout of Google will I also be logged out of Koha - Current answer - No 3) I've logged into Koha, then logged into App A, I then logout of Koha using the 'Logout of Koha and Google' option.. can I assume I'm also logged out of App A - Current Answer - No (and we can never ensure that either, as App A needs to support SLO too) I think the current (as in, in master) implementation is more 'the norm' and that adding this patch actually obfuscates that clarity a bit more.. By allowing a 'logout of google too' option, you're inferring that a google logout affects koha in some way, when in fact it does not. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue May 9 11:21:01 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 09 May 2017 09:21:01 +0000 Subject: [Koha-bugs] [Bug 18549] There should be a warning that logging out of Koha will leave browser session logged in to OAuth In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18549 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |matthias.meusburger at biblibr | |e.com -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue May 9 11:21:30 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 09 May 2017 09:21:30 +0000 Subject: [Koha-bugs] [Bug 18549] There should be a warning that logging out of Koha will leave browser session logged in to OAuth In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18549 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |katrin.fischer at bsz-bw.de -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue May 9 11:22:22 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 09 May 2017 09:22:22 +0000 Subject: [Koha-bugs] [Bug 18549] There should be a warning that logging out of Koha will leave browser session logged in to OAuth In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18549 --- Comment #7 from Martin Renvoize --- Would appreciate some more input on this really, I think for me it's all about being clear about what is happening and what we support. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue May 9 12:04:32 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 09 May 2017 10:04:32 +0000 Subject: [Koha-bugs] [Bug 18541] Patron card creator: Add a grid to support layout design In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18541 Alex Buckley changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #63218|0 |1 is obsolete| | --- Comment #8 from Alex Buckley --- Created attachment 63280 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=63280&action=edit Bug 18541 - Patron card creator: Add a grid to support layout design Add a layout grid to patron card creator to figure out the positions of text fields, barcode and images. To test: - Apply on top of patch 18465 - Go to Home > Tools > Patron card creator - Edit or create a layout - Turn on new choice 'Guide grid' in section 'General settings' - Leave 'Units' unchanged - Crate a PDF using 'Card batches' - Notice that card is printed with a layout grid that reflects selected unit with each 5th and 10th line in different color, unit description displayed bottom left, card dimensions displayed top right in small print inside the layout grid - Print PDF. Set printer settings in Adobe Reader or other PDF printing software to 'Actual size' to prevent scaling to printer's printable region - Mesure out printed PDF and verify that grid corresponds to selecte unit. - Go back to layout definition and choose an other unit, repeat steps to verify that grid respects selected unit. - Go back to layout definition, turn grid off, create PDF, verify that grid does not display in PDF Note for testers / QAers: Position of card elements (text, image...) do not respect the unit, this will be fixed in Bug 18550 Followed test plan and it worked as intended Signed-off-by: Alex Buckley -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue May 9 12:04:29 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 09 May 2017 10:04:29 +0000 Subject: [Koha-bugs] [Bug 18541] Patron card creator: Add a grid to support layout design In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18541 Alex Buckley changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue May 9 13:51:19 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 09 May 2017 11:51:19 +0000 Subject: [Koha-bugs] [Bug 18553] Incorrect "Loading..." tag on moremember.tt when no clubs defined In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18553 Kyle M Hall changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to Master CC| |kyle at bywatersolutions.com --- Comment #7 from Kyle M Hall --- Pushed to master for 17.05, thanks Jonathan! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue May 9 14:02:27 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 09 May 2017 12:02:27 +0000 Subject: [Koha-bugs] [Bug 18557] Mysqlim CURRENT_DATE in Koha::Clubs::get_enrollable In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18557 Kyle M Hall changed: What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |Needs Signoff Patch complexity|--- |Trivial patch -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue May 9 14:02:31 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 09 May 2017 12:02:31 +0000 Subject: [Koha-bugs] [Bug 18557] Mysqlim CURRENT_DATE in Koha::Clubs::get_enrollable In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18557 --- Comment #1 from Kyle M Hall --- Created attachment 63281 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=63281&action=edit Bug 18557 - Mysqlim CURRENT_DATE in Koha::Clubs::get_enrollable Test Plan: 1) Apply this patch 2) prove t/db_dependent/Clubs.t -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue May 9 14:14:13 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 09 May 2017 12:14:13 +0000 Subject: [Koha-bugs] [Bug 17015] New Koha Calendar In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17015 Mehdi Hamidi changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #62375|0 |1 is obsolete| | --- Comment #71 from Mehdi Hamidi --- Created attachment 63282 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=63282&action=edit Bug 17015 - DiscreteCalendar UI, Back-End and necessary scripts -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue May 9 14:16:27 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 09 May 2017 12:16:27 +0000 Subject: [Koha-bugs] [Bug 18137] REST API: Migrate from Mojolicious::Plugin:: Swagger2 to Mojolicious::Plugin::OpenAPI In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18137 Lari Taskula changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #63196|0 |1 is obsolete| | --- Comment #76 from Lari Taskula --- Created attachment 63283 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=63283&action=edit Bug 18137: List Mojolicious::Plugin::OpenAPI and JSON::Validator as dependencies Signed-off-by: Olli-Antti Kivilahti Signed-off-by: Josef Moravec Signed-off-by: Tomas Cohen Arazi -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue May 9 14:18:57 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 09 May 2017 12:18:57 +0000 Subject: [Koha-bugs] [Bug 18137] REST API: Migrate from Mojolicious::Plugin:: Swagger2 to Mojolicious::Plugin::OpenAPI In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18137 --- Comment #77 from Lari Taskula --- (In reply to Lari Taskula from comment #76) > Created attachment 63283 [details] [review] > Bug 18137: List Mojolicious::Plugin::OpenAPI and JSON::Validator as > dependencies > > Signed-off-by: Olli-Antti Kivilahti > > Signed-off-by: Josef Moravec > Signed-off-by: Tomas Cohen Arazi Rebased on master. This patch now maintains requirement as defined by Bug 17190. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue May 9 14:45:04 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 09 May 2017 12:45:04 +0000 Subject: [Koha-bugs] [Bug 18555] Create patron list from patron import In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18555 Josef Moravec changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue May 9 14:45:07 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 09 May 2017 12:45:07 +0000 Subject: [Koha-bugs] [Bug 18555] Create patron list from patron import In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18555 Josef Moravec changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #63242|0 |1 is obsolete| | --- Comment #3 from Josef Moravec --- Created attachment 63284 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=63284&action=edit [SIGNED-OFF] Bug 18555: Create patron list from patron import Create a patron list from imported patrons to be used for printing patron cards and other patron list related actions. To test: - Apply patch - Go to Home > Tools > Import patrons - Select a file to import and check new checkbox 'Create patron list' - Import file - Verify that in import results you see the time stamped name of the patronlist containig the imported patrons (if any patrons were imported) - Go to Home > Tools > Patron lists - Verify that the list shows up and contains the imported patrons Signed-off-by: Josef Moravec -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue May 9 14:50:10 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 09 May 2017 12:50:10 +0000 Subject: [Koha-bugs] [Bug 18549] There should be a warning that logging out of Koha will leave browser session logged in to OAuth In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18549 --- Comment #8 from Nick Clemens --- (In reply to Martin Renvoize from comment #7) > Would appreciate some more input on this really, I think for me it's all > about being clear about what is happening and what we support. Your points about the 'logout of google' option are fair, I just still feel like there should be at least a warning that you might be logged in to google. I suppose if an institution is enabling this option they bear some responsibility for training their users, a warning just seems friendly. Perhaps a syspref to allow warning or federated logout with explanatory text in the manual about what apps need to support to allow this logout to work? -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue May 9 14:50:40 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 09 May 2017 12:50:40 +0000 Subject: [Koha-bugs] [Bug 18557] Mysqlim CURRENT_DATE in Koha::Clubs::get_enrollable In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18557 Josef Moravec changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue May 9 14:50:43 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 09 May 2017 12:50:43 +0000 Subject: [Koha-bugs] [Bug 18557] Mysqlim CURRENT_DATE in Koha::Clubs::get_enrollable In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18557 Josef Moravec changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #63281|0 |1 is obsolete| | --- Comment #2 from Josef Moravec --- Created attachment 63285 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=63285&action=edit [SIGNED-OFF] Bug 18557 - Mysqlim CURRENT_DATE in Koha::Clubs::get_enrollable Test Plan: 1) Apply this patch 2) prove t/db_dependent/Clubs.t Signed-off-by: Josef Moravec -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue May 9 15:07:17 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 09 May 2017 13:07:17 +0000 Subject: [Koha-bugs] [Bug 17015] New Koha Calendar In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17015 --- Comment #72 from Mehdi Hamidi --- Rebased the patch so it applies properly on master. We tweaked the code so it works on kohadevbox as well. Mehdi Hamidi -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue May 9 15:08:26 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 09 May 2017 13:08:26 +0000 Subject: [Koha-bugs] [Bug 18438] Check in: Modal about holds hides important check in messages In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18438 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |ASSIGNED --- Comment #22 from Jonathan Druart --- (In reply to Josef Moravec from comment #21) > (In reply to Jonathan Druart from comment #20) > > I do not understand where we are with these patches. > > What are the expected behaviour changes? > > As I understand, the change is, that the page doesn't reload after > dismissing hold modal window, so the message under the window does not > disappear and user haven't wait for another reload... Yes, it is what I understood too, but it is the behaviour I already get against master. Alex, can you squash the patches and provide a simple test plan please? -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue May 9 15:13:52 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 09 May 2017 13:13:52 +0000 Subject: [Koha-bugs] [Bug 18549] There should be a warning that logging out of Koha will leave browser session logged in to OAuth In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18549 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |In Discussion -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue May 9 15:16:34 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 09 May 2017 13:16:34 +0000 Subject: [Koha-bugs] [Bug 18557] Mysqlim CURRENT_DATE in Koha::Clubs::get_enrollable In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18557 --- Comment #3 from Jonathan Druart --- Kyle, my understanding is that the best would be to use dt_from_string: my $dtf = Koha::Database->new->schema->storage->datetime_parser; then ->search({ date_end => { '>=' => $dtf->format_datetime( dt_from_string() ) } }) Do not you think? -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue May 9 15:17:23 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 09 May 2017 13:17:23 +0000 Subject: [Koha-bugs] [Bug 12063] Change date calculation for reserve expiration to skip all holidays In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12063 Kyle M Hall changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to Master CC| |kyle at bywatersolutions.com --- Comment #87 from Kyle M Hall --- Pushed to master for 17.05, thanks Alex, Marcel! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue May 9 15:20:52 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 09 May 2017 13:20:52 +0000 Subject: [Koha-bugs] [Bug 18560] RSS Feed link from OPAC shelves is broken In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18560 Owen Leonard changed: What |Removed |Added ---------------------------------------------------------------------------- Patch complexity|--- |Trivial patch Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue May 9 15:20:54 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 09 May 2017 13:20:54 +0000 Subject: [Koha-bugs] [Bug 18560] RSS Feed link from OPAC shelves is broken In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18560 Owen Leonard changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #63266|0 |1 is obsolete| | --- Comment #3 from Owen Leonard --- Created attachment 63286 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=63286&action=edit [SIGNED-OFF] Bug 18560: RSS link in opac shelves is broken TEST PLAN --------- 1) have books entered 2) log in create a list 3) add books to list 4) display list 5) click the RSS link button. -- bad HASH error. 6) apply patch 7) repeat steps 4&5 -- readble junk without error messages. 8) run koha qa test tools Signed-off-by: Marc V?ron Signed-off-by: Owen Leonard Sure this doesn't need a signoff, but I was already signing off when Marc did! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue May 9 15:28:54 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 09 May 2017 13:28:54 +0000 Subject: [Koha-bugs] [Bug 18551] Hide with CSS dynamic elements in member search In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18551 --- Comment #7 from Josef Moravec --- Created attachment 63287 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=63287&action=edit Bug 18551: followup - hide advanced filters in header, move hidding to css file Test plan: The same as first patch, but also with advanced search form in header hidden on page load - see comment 4 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue May 9 15:29:47 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 09 May 2017 13:29:47 +0000 Subject: [Koha-bugs] [Bug 14716] opac-detail.pl -- Series link fails when series title ends with semicolon preceded by space. In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14716 --- Comment #24 from Peggy Thrasher --- I would certainly support a patch that solves the semi-colon problem even if the other issues are not resolved. If we could make the system work correctly when the MARC record follows the standard that would be a big improvement. Thanks Peggy -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue May 9 15:31:02 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 09 May 2017 13:31:02 +0000 Subject: [Koha-bugs] [Bug 18125] Edit button can duplicate some circulation rule In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18125 Owen Leonard changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off Patch complexity|--- |Trivial patch -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue May 9 15:31:05 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 09 May 2017 13:31:05 +0000 Subject: [Koha-bugs] [Bug 18125] Edit button can duplicate some circulation rule In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18125 Owen Leonard changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #60329|0 |1 is obsolete| | --- Comment #12 from Owen Leonard --- Created attachment 63288 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=63288&action=edit [SIGNED-OFF] Disabled the select for patron Category and Item Type Test plan 1 - Edit a circulation rule and check you can modify the patron Category and item type 2 - Apply patch 3 - Edit a circulation rule : you can't change anymore https://bugs.koha-community.org/show_bug.cgi?id=18125 Signed-off-by: Owen Leonard -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue May 9 15:45:07 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 09 May 2017 13:45:07 +0000 Subject: [Koha-bugs] [Bug 18309] UNIMARC update from IFLA In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18309 --- Comment #15 from Koha Team Lyon 3 --- I have tried to install it on a sandbox but it can't apply : Cannot rebuild zebra: The command perl /home/koha/src/misc/migration_tools/rebuild_zebra.pl -a -b -r --wait-for-lock fails with the following error: 'perl /home/koha/src/misc/migration_tools/rebuild_zebra.pl -a -b -r --wait-for-lock' exited with value 255 The error message is: Control fields (generally, just tags below 010) do not have subfields, use data() at /home/koha/src/Koha/Filter/MARC/EmbedItemsAvailability.pm line 75. at /home/koha/lib/contrib/sandbox/cron/../Run.pm line 28. Do we have to add zebra files modification in this patch or to do a new one that blocks this one ? Sonia -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue May 9 15:48:55 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 09 May 2017 13:48:55 +0000 Subject: [Koha-bugs] [Bug 18549] There should be a warning that logging out of Koha will leave browser session logged in to OAuth In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18549 --- Comment #9 from M. Tompsett --- (In reply to Martin Renvoize from comment #6) > I think this bug is somewhat misleading to the user, unfortunately. [SNIP] > I think the current (as in, in master) implementation is more 'the norm' It is. The problem is that if users walk away, someone else can click 'login' and become the person who just left. > and that adding this patch actually obfuscates that clarity a bit more. That's what the whole dialogue message is supposed to make clear. If your objection is with the explanation, then feel free to suggest alternative wording. > By allowing a 'logout of google too' option, you're inferring > that a google logout affects koha in some way, when in fact it > does not. No, I am implying that by choosing that option, other google related tabs/windows in the same browser may be affected. You inferred incorrectly, so clearly the dialogue message needs tweaking, because 'Koha and Google' is the button name, not what you are logging in and out of manually in random order. TAB A: GMail TAB B: Koha OPAC logged in via OAuth Click logout in OPAC. Get dialogue (because you've applied this patch) Click 'Koha and Google' your TAB A will be affected, and you will be forced to relogin in to continue reading your GMail. But if you click 'Koha only', TAB A is not affected, but you suffer the next user can become you problem when the next person clicks the Koha OPAC login. I suspect this is why people go with the most complex and horrid iframe solution, because that may do some authorization revoking without actually logging out and thus not have the potential identity theft issue. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue May 9 15:57:38 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 09 May 2017 13:57:38 +0000 Subject: [Koha-bugs] [Bug 16116] Change of issue publication date doesn' t reflect on the next issue generated In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16116 Marcel de Rooy changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |m.de.rooy at rijksmuseum.nl --- Comment #9 from Marcel de Rooy --- Would it be possible for Francois, Gaetan or Julian to test this patch too? I am not so sure if the proposed changes really solve all problems in this area. Another signoff would not be a bad idea. Another point (referring to an earlier remark): > Before 3.20, when receiving a new issue, you could change the "Published on" > date and Koha will adjust the subscription's next issue publication date for > all the new issues to be received. Would it be an idea to add an option to the subscription that makes it possible to rebase issue dates somehow ? We now have a 'buggy' mix of using last issue and first acqui date. Maybe an additional base date to use optionally (overruling first acqui)? Other ideas ? -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue May 9 16:00:55 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 09 May 2017 14:00:55 +0000 Subject: [Koha-bugs] [Bug 18561] New: Use font awesome icons for plus signs in forms Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18561 Bug ID: 18561 Summary: Use font awesome icons for plus signs in forms Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Staff Client Assignee: koha-bugs at lists.koha-community.org Reporter: josef.moravec at gmail.com QA Contact: testopia at bugs.koha-community.org CC: gmcharlt at gmail.com -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Tue May 9 16:05:55 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 09 May 2017 14:05:55 +0000 Subject: [Koha-bugs] [Bug 18561] Use font awesome icons for plus signs in forms In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18561 Josef Moravec changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|koha-bugs at lists.koha-commun |josef.moravec at gmail.com |ity.org | Component|Staff Client |Templates -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue May 9 16:08:33 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 09 May 2017 14:08:33 +0000 Subject: [Koha-bugs] [Bug 18561] Use font awesome icons for plus signs in forms In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18561 Josef Moravec changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue May 9 16:08:36 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 09 May 2017 14:08:36 +0000 Subject: [Koha-bugs] [Bug 18561] Use font awesome icons for plus signs in forms In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18561 --- Comment #1 from Josef Moravec --- Created attachment 63289 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=63289&action=edit Bug 18561: Use Font Awesome icons for plus (and minus) signs in forms Test plan: 0. Apply the patch 1. Go to these forms and confirm that you can see new plus (minus) sign icon and that this cion does work as before - Acquisiton - search for orders form in header - Patrons - patron search in header - Advanced catalogue search - more options has to be activated - Opac - advanced search - more options has to be activated -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue May 9 16:09:33 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 09 May 2017 14:09:33 +0000 Subject: [Koha-bugs] [Bug 18561] Use font awesome icons for plus signs in forms In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18561 Josef Moravec changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |oleonard at myacpl.org --- Comment #2 from Josef Moravec --- Owen, does it make sense to you? -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue May 9 16:10:10 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 09 May 2017 14:10:10 +0000 Subject: [Koha-bugs] [Bug 18356] Prediction pattern wrong, skips years, for some year based frequencies In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18356 Marcel de Rooy changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |m.de.rooy at rijksmuseum.nl Assignee|koha-bugs at lists.koha-commun |m.de.rooy at rijksmuseum.nl |ity.org | Status|NEW |ASSIGNED --- Comment #1 from Marcel de Rooy --- Found similar things. Taking a look.. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue May 9 16:15:33 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 09 May 2017 14:15:33 +0000 Subject: [Koha-bugs] [Bug 18557] Mysqlim CURRENT_DATE in Koha::Clubs::get_enrollable In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18557 --- Comment #4 from Kyle M Hall --- (In reply to Jonathan Druart from comment #3) > Kyle, my understanding is that the best would be to use dt_from_string: > > my $dtf = Koha::Database->new->schema->storage->datetime_parser; > then > ->search({ date_end => { '>=' => $dtf->format_datetime( dt_from_string() ) > } }) > > Do not you think? That works for me! Followup incoming! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue May 9 16:16:28 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 09 May 2017 14:16:28 +0000 Subject: [Koha-bugs] [Bug 18557] Mysqlim CURRENT_DATE in Koha::Clubs::get_enrollable In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18557 --- Comment #5 from Kyle M Hall --- Created attachment 63290 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=63290&action=edit Bug 18557 [QA Followup] - Use dt_from_string -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue May 9 16:40:16 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 09 May 2017 14:40:16 +0000 Subject: [Koha-bugs] [Bug 17240] Allow processes that rely on background jobs run in Plack mode In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17240 --- Comment #14 from Fridolin SOMERS --- Created attachment 63291 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=63291&action=edit Bug 17240 - Allow processes that rely on background jobs run in Plack mode - followup 3 Followup 3 If not running in background mode, items are not displayed in result page in tools/batchMod.pl. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue May 9 16:48:26 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 09 May 2017 14:48:26 +0000 Subject: [Koha-bugs] [Bug 11879] Add a new borrower field : main contact method. In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11879 Josef Moravec changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |josef.moravec at gmail.com Status|Needs Signoff |Failed QA --- Comment #88 from Josef Moravec --- I found some issues with this patchset: 1) It removes field overdrive_auth_token field from tables borrowers and deletedborrowers 2) Automic update and kohastructure has to be consistent in field order, in atomic, the new field is added after 'privacy', in kohastructure at the end - it is bad -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue May 9 16:50:37 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 09 May 2017 14:50:37 +0000 Subject: [Koha-bugs] [Bug 18561] Use font awesome icons for plus signs in forms In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18561 Owen Leonard changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |In Discussion --- Comment #3 from Owen Leonard --- I think this would not work well with screen readers. I suppose they way it is right now (with a text +) is probably not great for screen readers either. Filament Group has a good reputation for thoughtful articles on this kind of thing: https://www.filamentgroup.com/lab/bulletproof_icon_fonts.html Their "Critical icons" section is interesting, but requires the js library Modernizr. I think this issue requires some more discussion and investigation. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue May 9 16:52:12 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 09 May 2017 14:52:12 +0000 Subject: [Koha-bugs] [Bug 14803] Rental and fine fees are not updating on circulation screen In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14803 --- Comment #32 from Josef Moravec --- (In reply to Srdjan Jankovic from comment #31) > (In reply to Josef Moravec from comment #29) > > Hi Josef, thanks for testing this. > > > I have to more concerns about it: > > 1) The barcode field doesn't have focus after page is loaded - probably easy > > to fix, but important > > 2) Looks like it waits than issues are loaded and then show the barcode > > input field, maybe I am wrong and it just looks like, but in any case it is > > much slower then current master... > > Ok, now it should be behaving like master. I tried to add some accuracy, but > drawbacks are obviously too big... It is Ok now, thanks > > 3) Message "loading, you can continue scanning" is badly placed (in the left > > top corner) > > For me it is placed center of the table. At any rate I believe my patch did > not change the table, it just makes a issuesTable.api().ajax.reload() call. > Could you please a) check it in another browser b) compare to master. Thanks > a lot. Hm, strange... On master it's ok for me, on this patchset still bad... but I can't find out where's the problem... -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue May 9 17:03:27 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 09 May 2017 15:03:27 +0000 Subject: [Koha-bugs] [Bug 18450] Renew in header bypasses hold block and renewal limits In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18450 Josef Moravec changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #62447|0 |1 is obsolete| | --- Comment #9 from Josef Moravec --- Created attachment 63292 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=63292&action=edit [SIGNED-OFF] Bug 18450 - Implemented a check to determine if the 'Override and renew' button is displayed based on the setting of the AllowRenewalLimitOverride and AllowRenewalIfOtherItemsAvaliable preferences. This will display the 'Override and renew' button only if both preferences are set to 'Allow'. Test plan: 1. In More->Administration->Global system preferences ensure that both the AllowRenewalLimitOverride and AllowRenewalIfOtherItemsAvaliable preferences are both set to 'Dont allow'. 2. Place a hold on an item from a patron 3. Checkout the item out to a different patron 4. Renew the item and notice the 'Cannot renew: The item is on hold for another patron' 5. Click the 'Override and renew' button and notice that although you can bypass the hold 6. Apply patch 7. Renew the item again and notice that the message does not have a 'Override and renew' button it just has the 'Ignore and continue' button 8. Go back to More->Administration->Global system preferences and set AllowRenewalLimitOverride to 'Allow' 9. Try renewing the same item again and notice that the 'Override and renew' button is still not being displayed. 10. In systems preferences now set the AllowRenewalIfOtherItemsAvailable to 'Allow' 11. Try renewing the item again and notice that now both of these preferences are allowed the 'Override and renew' button is displayed because you will not be violating these preferences. Note: Checking if the renewal exceeds the renewal level, if auto renew is set up, or if renewal is to soon is checked earlier in this conditional if statement earlier and so the check in this patch does not need to check the renewal level, auto renewal, if renewal is too soon. Folloed test plan, works as expected. Signed-off-by: Marc V?ron Signed-off-by: Josef Moravec -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue May 9 17:04:10 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 09 May 2017 15:04:10 +0000 Subject: [Koha-bugs] [Bug 18450] Renew in header bypasses hold block and renewal limits In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18450 Josef Moravec changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue May 9 17:04:14 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 09 May 2017 15:04:14 +0000 Subject: [Koha-bugs] [Bug 18450] Renew in header bypasses hold block and renewal limits In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18450 Josef Moravec changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #63226|0 |1 is obsolete| | --- Comment #10 from Josef Moravec --- Created attachment 63293 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=63293&action=edit [SIGNED-OFF] Bug 18450 - Implemented check if either AllowRenewLimitOverride or AllowRenewalIfOtherItemsAvaliable were set to allow, so the user is only blocked if both of these sysprefs are set to 'Dont allow' Test plan: 1. In More->Administration->Global system preferences ensure that both the AllowRenewalLimitOverride and AllowRenewalIfOtherItemsAvaliable preferences are both set to 'Dont allow'. 2. Place a hold on an item from a patron 3. Checkout the item out to a different patron 4. Renew the item and notice the 'Cannot renew: The item is on hold for another patron' warning 5. Click the 'Override and renew' button and notice that you can bypass the hold 6. Apply patch 7. Renew the item again and notice that the message does not have a 'Override and renew' button it just has the 'Ignore and continue' button 8. Go back to More->Administration->Global system preferences and set AllowRenewalLimitOverride to 'Allow' 9. Try renewing the same item again and notice that the 'Override and renew' button is displayed 10. In systems preferences now set the AllowRenewalIfOtherItemsAvailable syspref to 'Allow' and AllowRenewalLimitOverride to 'Dont allow' and notice the 'Override and renew' button is displayed 11. Now set both these sysprefs to 'Allow' and notice the 'Override and renew' button is displayed because you will not be violating these preferences. Note: Checking if the renewal exceeds the renewal level, if auto renew is set up, or if renewal is to soon is checked earlier in this conditional if statement earlier and so the check in this patch does not need to check the renewal level, auto renewal, if renewal is too soon. Signed-off-by: Josef Moravec -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue May 9 17:14:17 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 09 May 2017 15:14:17 +0000 Subject: [Koha-bugs] [Bug 18276] Koha::Biblio - Remove GetBiblioFromItemNumber In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18276 Josef Moravec changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue May 9 17:14:21 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 09 May 2017 15:14:21 +0000 Subject: [Koha-bugs] [Bug 18276] Koha::Biblio - Remove GetBiblioFromItemNumber In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18276 Josef Moravec changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #63121|0 |1 is obsolete| | Attachment #63122|0 |1 is obsolete| | Attachment #63123|0 |1 is obsolete| | Attachment #63124|0 |1 is obsolete| | Attachment #63125|0 |1 is obsolete| | Attachment #63126|0 |1 is obsolete| | Attachment #63166|0 |1 is obsolete| | --- Comment #40 from Josef Moravec --- Created attachment 63294 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=63294&action=edit [SIGNED-OFF] Bug 18276: Remove GetBiblioFromItemNumber - Course reserves Values from the items, biblio and biblioitems tables are used in the template, so we need to pass all of them to the template, but separately. That way we easily see which field from which table we are displaying. Test plan: Create a course reserve and add items. Correct information must be displayed on the detail page of the course reserve, on staff and OPAC interface. Signed-off-by: Josef Moravec -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue May 9 17:14:28 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 09 May 2017 15:14:28 +0000 Subject: [Koha-bugs] [Bug 18276] Koha::Biblio - Remove GetBiblioFromItemNumber In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18276 --- Comment #41 from Josef Moravec --- Created attachment 63295 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=63295&action=edit [SIGNED-OFF] Bug 18276: Remove GetBiblioFromItemNumber - ILSDI Test plan: Hit /cgi-bin/koha/ilsdi.pl?service=GetPatronInfo&patron_id=51&show_holds=1 The results should be the same before and after this patch Signed-off-by: Josef Moravec -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue May 9 17:14:33 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 09 May 2017 15:14:33 +0000 Subject: [Koha-bugs] [Bug 18276] Koha::Biblio - Remove GetBiblioFromItemNumber In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18276 --- Comment #42 from Josef Moravec --- Created attachment 63296 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=63296&action=edit [SIGNED-OFF] Bug 18276: Remove GetBiblioFromItemNumber - circulation pages Test plan: 1. Checkout items in a batch The information displayed should be ok (title, subtitles, author, itemnotes, barcode) 2. Checkout an item using the standard checkout page You should correctly see the information of the item that has been checked out (title and author) Signed-off-by: Josef Moravec -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue May 9 17:14:39 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 09 May 2017 15:14:39 +0000 Subject: [Koha-bugs] [Bug 18276] Koha::Biblio - Remove GetBiblioFromItemNumber In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18276 --- Comment #43 from Josef Moravec --- Created attachment 63297 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=63297&action=edit [SIGNED-OFF] Bug 18276: Remove GetBiblioFromItemNumber - Easy ones The subroutine C4::Biblio::GetBiblioFromItemNumber was wrong for several reasons: - badly named, we can get biblio info from a barcode - SELECT * from items, biblio and biblioitems makes things hard to follow and debug, we never know where do come from the value we display - sometimes called only for trivial information such as biblionumber, author or title This patchset suggests to replace it with calls to: - Koha::Items->find for item's info - $item->biblio for biblio's info - $item->biblio->biblioitem for biblioitem's info Test plan: Item's info should correctly be displayed on the following pages: - circulation history - transfer book - checkin - waiting holds QA will check the other changes reading the code, it's trivial Signed-off-by: Josef Moravec -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue May 9 17:14:44 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 09 May 2017 15:14:44 +0000 Subject: [Koha-bugs] [Bug 18276] Koha::Biblio - Remove GetBiblioFromItemNumber In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18276 --- Comment #44 from Josef Moravec --- Created attachment 63298 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=63298&action=edit [SIGNED-OFF] Bug 18276: Remove the C4::Biblio::GetBiblioFromItemNumber subroutine Signed-off-by: Josef Moravec -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue May 9 17:14:49 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 09 May 2017 15:14:49 +0000 Subject: [Koha-bugs] [Bug 18276] Koha::Biblio - Remove GetBiblioFromItemNumber In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18276 --- Comment #45 from Josef Moravec --- Created attachment 63299 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=63299&action=edit [SIGNED-OFF] Bug 18276: FIX status display for course reserves This include file is terribly wrong, it's called from different places that do not set the same flag. The status from detail and result page might be different from the one display on the course reserve table. Signed-off-by: Josef Moravec -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue May 9 17:14:56 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 09 May 2017 15:14:56 +0000 Subject: [Koha-bugs] [Bug 18276] Koha::Biblio - Remove GetBiblioFromItemNumber In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18276 --- Comment #46 from Josef Moravec --- Created attachment 63300 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=63300&action=edit [SIGNED-OFF] Bug 18276: (follow-up) Remove GetBiblioFromItemNumber - ILSDI Take into account biblio level holds Signed-off-by: Josef Moravec -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue May 9 17:51:44 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 09 May 2017 15:51:44 +0000 Subject: [Koha-bugs] [Bug 18277] Koha::Biblio - Remove GetBiblionumberFromItemnumber In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18277 Josef Moravec changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue May 9 17:51:52 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 09 May 2017 15:51:52 +0000 Subject: [Koha-bugs] [Bug 18277] Koha::Biblio - Remove GetBiblionumberFromItemnumber In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18277 --- Comment #6 from Josef Moravec --- Created attachment 63302 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=63302&action=edit [SIGNED-OFF] Bug 18277: Remove GetBiblionumberFromItemnumber - linkitem Test plan: Enable EasyAnalyticalRecords and link an item to another one (Edit > link to host item) Signed-off-by: Josef Moravec -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue May 9 17:51:47 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 09 May 2017 15:51:47 +0000 Subject: [Koha-bugs] [Bug 18277] Koha::Biblio - Remove GetBiblionumberFromItemnumber In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18277 Josef Moravec changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #61127|0 |1 is obsolete| | Attachment #61128|0 |1 is obsolete| | Attachment #61129|0 |1 is obsolete| | Attachment #61130|0 |1 is obsolete| | --- Comment #5 from Josef Moravec --- Created attachment 63301 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=63301&action=edit [SIGNED-OFF] Bug 18277: Remove GetBiblionumberFromItemnumber - Easy ones To retrieve a biblionumber from an itemnumber, we can use: Koha::Item->biblio->biblionumber This is only what this patchset does. Doing that we will be able to get rid of the C4::Biblio::GetBiblionumberFromItemnumber subroutine. Test plan: - Acquisition module: cancel a receipt - Export a record to CSV - Modify items in a batch Item's info should be correct Other changes with be checked by QA team, by reading the code. Signed-off-by: Josef Moravec -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue May 9 17:51:56 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 09 May 2017 15:51:56 +0000 Subject: [Koha-bugs] [Bug 18277] Koha::Biblio - Remove GetBiblionumberFromItemnumber In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18277 --- Comment #7 from Josef Moravec --- Created attachment 63303 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=63303&action=edit [SIGNED-OFF] Bug 18277: Remove GetBiblionumberFromItemnumber - create_analytical_rel.pl I have no idea how to test this patch, see bug 5528, or simply read the code. Signed-off-by: Josef Moravec -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue May 9 17:52:02 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 09 May 2017 15:52:02 +0000 Subject: [Koha-bugs] [Bug 18277] Koha::Biblio - Remove GetBiblionumberFromItemnumber In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18277 --- Comment #8 from Josef Moravec --- Created attachment 63304 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=63304&action=edit [SIGNED-OFF] Bug 18277: Remove the C4::Biblio::GetBiblionumberFromItemnumber Signed-off-by: Josef Moravec -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue May 9 18:09:17 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 09 May 2017 16:09:17 +0000 Subject: [Koha-bugs] [Bug 18320] patroncards/edit-layout.pl raises warnings In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18320 Owen Leonard changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Failed QA --- Comment #3 from Owen Leonard --- I'm assuming based on Comment 2 that this should be 'Failed QA' -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue May 9 18:10:40 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 09 May 2017 16:10:40 +0000 Subject: [Koha-bugs] [Bug 18561] Use font awesome icons for plus signs in forms In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18561 --- Comment #4 from Josef Moravec --- (In reply to Owen Leonard from comment #3) > I think this would not work well with screen readers. I suppose they way it > is right now (with a text +) is probably not great for screen readers either. > > Filament Group has a good reputation for thoughtful articles on this kind of > thing: > > https://www.filamentgroup.com/lab/bulletproof_icon_fonts.html > > Their "Critical icons" section is interesting, but requires the js library > Modernizr. > > I think this issue requires some more discussion and investigation. Good point Owen, thanks! Accessibility should be important for us of course... -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue May 9 18:58:50 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 09 May 2017 16:58:50 +0000 Subject: [Koha-bugs] [Bug 17915] warning in Stage MARC records for import when matching rule with offset In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17915 --- Comment #2 from Owen Leonard --- I can't reproduce this problem in master -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue May 9 19:00:06 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 09 May 2017 17:00:06 +0000 Subject: [Koha-bugs] [Bug 15246] Adding new patron triggers foreign key error if branchcode is hidden In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15246 Michael Kuhn changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |mik at adminkuhn.ch --- Comment #3 from Michael Kuhn --- Under the described circumstances (Koha system preference "BorrowerUnwantedField" containing "branchcode") almost the same problem occurrs when trying to add new patrons. In this case: 1. Environment: Debian GNU/Linux 8 with Koha 16.11.04 and Plack activated. 2. Trying to add a new patron using the staff client will result in the URL ".../cgi-bin/koha/members/memberentry.pl" showing just a white page saying "Internal Server error". 3. The log file "plack-error.log" will show the following error (just as an example): DBD::mysql::st execute failed: Cannot add or update a child row: a foreign key constraint fails (`koha_phsh`.`borrowers`, CONSTRAINT `borrowers_ibfk_2` FOREIGN KEY (`branchcode`) REFERENCES `branches` (`branchcode`)) [for Statement "INSERT INTO `borrowers` ( `address`, `address2`, `altcontactaddress1`, `altcontactaddress2`, `altcontactaddress3`, `altcontactcountry`, `altcontactfirstname`, `altcontactphone`, `altcontactstate`, `altcontactsurname`, `altcontactzipcode`, `borrowernotes`, `cardnumber`, `categorycode`, `city`, `contactnote`, `country`, `dateenrolled`, `dateexpiry`, `dateofbirth`, `debarred`, `email`, `emailpro`, `firstname`, `mobile`, `opacnote`, `othernames`, `password`, `phone`, `phonepro`, `privacy`, `privacy_guarantor_checkouts`, `sex`, `sms_provider_id`, `sort1`, `sort2`, `state`, `streetnumber`, `surname`, `title`, `userid`, `zipcode`) VALUES ( ?, ?, ?, ?, ?, ?, ?, ?, ?, ?, ?, ?, ?, ?, ?, ?, ?, ?, ?, ?, ?, ?, ?, ?, ?, ?, ?, ?, ?, ?, ?, ?, ?, ?, ?, ?, ?, ?, ?, ?, ?, ? )" with ParamValues: 0="", 1="", 2="", 3="", 4="", 5="", 6="", 7="", 8="", 9="", 10="", 11="", 12="11111111111", 13="13", 14="", 15="", 16="", 17='2017-05-09', 18='2100-08-09T00:00:00', 19=undef, 20=undef, 21="", 22="", 23="", 24="", 25="", 26="", 27='!', 28="", 29="", 30=0, 31=0, 32="", 33=undef, 34="", 35="", 36="", 37="", 38="XXXX", 39="", 40='xxxx', 41=""] at /usr/share/perl5/DBIx/Class/Storage/DBI.pm line 1832. DBIx::Class::Storage::DBI::_dbh_execute(): Cannot add or update a child row: a foreign key constraint fails (`koha_phsh`.`borrowers`, CONSTRAINT `borrowers_ibfk_2` FOREIGN KEY (`branchcode`) REFERENCES `branches` (`branchcode`)) at /usr/share/koha/lib/Koha/Object.pm line 120 4. The problem can be solved by removing "branchcode" from Koha system preference "BorrowerUnwantedField". 5. As Laura has suggested it may be a good idea to add a hint to the preference "BorrowerUnwantedField" concerning field "branchcode" - so most people wouldn't even try to include it. Or, as Owen Leonard has suggested, to automatically select the logged-in branch for new patrons; even if the field "branchcode" is hidden; although this may not always be the correct choice, if the library has more than one branch. So maybe it would be safest to just forbid adding the mandatory field "branchcode" to Koha system preference "BorrowerUnwantedField". -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Tue May 9 19:39:02 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 09 May 2017 17:39:02 +0000 Subject: [Koha-bugs] [Bug 18125] Edit button can duplicate some circulation rule In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18125 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |jonathan.druart at bugs.koha-c | |ommunity.org --- Comment #13 from Jonathan Druart --- I am not sure this is acceptable, it will become hard to copy rules. Maybe we need an additional "Copy" action button? -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue May 9 19:48:45 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 09 May 2017 17:48:45 +0000 Subject: [Koha-bugs] [Bug 18557] Mysqlim CURRENT_DATE in Koha::Clubs::get_enrollable In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18557 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue May 9 19:48:49 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 09 May 2017 17:48:49 +0000 Subject: [Koha-bugs] [Bug 18557] Mysqlim CURRENT_DATE in Koha::Clubs::get_enrollable In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18557 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #63285|0 |1 is obsolete| | Attachment #63290|0 |1 is obsolete| | --- Comment #6 from Jonathan Druart --- Created attachment 63305 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=63305&action=edit Bug 18557 - Mysqlim CURRENT_DATE in Koha::Clubs::get_enrollable Test Plan: 1) Apply this patch 2) prove t/db_dependent/Clubs.t Signed-off-by: Josef Moravec Signed-off-by: Jonathan Druart -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue May 9 19:48:53 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 09 May 2017 17:48:53 +0000 Subject: [Koha-bugs] [Bug 18557] Mysqlim CURRENT_DATE in Koha::Clubs::get_enrollable In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18557 --- Comment #7 from Jonathan Druart --- Created attachment 63306 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=63306&action=edit Bug 18557 [QA Followup] - Use dt_from_string Signed-off-by: Jonathan Druart -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue May 9 19:57:47 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 09 May 2017 17:57:47 +0000 Subject: [Koha-bugs] [Bug 18114] koha-start-* and koha-stop-* should be replaced with the new command style In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18114 Tom?s Cohen Arazi changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on| |17467, 17468 Version|unspecified |master CC| |tomascohen at gmail.com Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17467 [Bug 17467] There should be a koha-zebra script to handle Zebra daemons for instances https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17468 [Bug 17468] Remove koha-*-zebra scripts in favor of koha-zebra -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Tue May 9 19:57:47 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 09 May 2017 17:57:47 +0000 Subject: [Koha-bugs] [Bug 17467] There should be a koha-zebra script to handle Zebra daemons for instances In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17467 Tom?s Cohen Arazi changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |18114 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18114 [Bug 18114] koha-start-* and koha-stop-* should be replaced with the new command style -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue May 9 19:57:47 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 09 May 2017 17:57:47 +0000 Subject: [Koha-bugs] [Bug 17468] Remove koha-*-zebra scripts in favor of koha-zebra In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17468 Tom?s Cohen Arazi changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |18114 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18114 [Bug 18114] koha-start-* and koha-stop-* should be replaced with the new command style -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue May 9 19:57:57 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 09 May 2017 17:57:57 +0000 Subject: [Koha-bugs] [Bug 18114] koha-start-* and koha-stop-* should be replaced with the new command style In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18114 Tom?s Cohen Arazi changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|koha-bugs at lists.koha-commun |tomascohen at gmail.com |ity.org | -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Tue May 9 20:05:53 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 09 May 2017 18:05:53 +0000 Subject: [Koha-bugs] [Bug 18562] New: There should be a koha-sip script to handle SIP daemons for instances Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18562 Bug ID: 18562 Summary: There should be a koha-sip script to handle SIP daemons for instances Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Command-line Utilities Assignee: gmcharlt at gmail.com Reporter: tomascohen at gmail.com QA Contact: testopia at bugs.koha-community.org CC: robin at catalyst.net.nz -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue May 9 20:06:09 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 09 May 2017 18:06:09 +0000 Subject: [Koha-bugs] [Bug 18562] There should be a koha-sip script to handle SIP daemons for instances In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18562 Tom?s Cohen Arazi changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |18114 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18114 [Bug 18114] koha-start-* and koha-stop-* should be replaced with the new command style -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue May 9 20:06:09 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 09 May 2017 18:06:09 +0000 Subject: [Koha-bugs] [Bug 18114] koha-start-* and koha-stop-* should be replaced with the new command style In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18114 Tom?s Cohen Arazi changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on| |18562 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18562 [Bug 18562] There should be a koha-sip script to handle SIP daemons for instances -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue May 9 20:06:16 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 09 May 2017 18:06:16 +0000 Subject: [Koha-bugs] [Bug 18562] There should be a koha-sip script to handle SIP daemons for instances In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18562 Tom?s Cohen Arazi changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|gmcharlt at gmail.com |tomascohen at gmail.com -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue May 9 20:40:26 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 09 May 2017 18:40:26 +0000 Subject: [Koha-bugs] [Bug 17776] Shibboleth Authentication is broken in plack In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17776 Tom?s Cohen Arazi changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |tomascohen at gmail.com Assignee|gmcharlt at gmail.com |martin.renvoize at ptfs-europe | |.com -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue May 9 20:42:42 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 09 May 2017 18:42:42 +0000 Subject: [Koha-bugs] [Bug 17212] ITEMTYPECAT broken if there is another authorised value with same code In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17212 Marjorie Barry-Vila changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |marjorie.barry-vila at ccsr.qc | |.ca -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue May 9 20:50:12 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 09 May 2017 18:50:12 +0000 Subject: [Koha-bugs] [Bug 18450] Renew in header bypasses hold block and renewal limits In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18450 --- Comment #11 from Jonathan Druart --- If I do not misread the second patch, we have: IF NOT A AND B: Do stuff ELSIF A AND NOT B: Do the same stuff If that the case, we can simplify with: IT NOT A AND B OR A AND NOT B: Do the stuff -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue May 9 20:58:52 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 09 May 2017 18:58:52 +0000 Subject: [Koha-bugs] [Bug 17944] Remove the sql code from itemtypes.pl administrative perl script In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17944 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue May 9 20:58:58 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 09 May 2017 18:58:58 +0000 Subject: [Koha-bugs] [Bug 17944] Remove the sql code from itemtypes.pl administrative perl script In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17944 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #63259|0 |1 is obsolete| | --- Comment #52 from Jonathan Druart --- Created attachment 63307 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=63307&action=edit Bug 17944 - Removed SQl query from itemtypes.pl and replaced it with can_be_deleted method in Koha/ItemType.pm In Koha/ItemTypes.t I have reworded unit test output and added test for item deletion. In addition to updating admin script by removing warn and changing if statement check Signed-off-by: Jonathan Druart -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue May 9 20:59:05 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 09 May 2017 18:59:05 +0000 Subject: [Koha-bugs] [Bug 17944] Remove the sql code from itemtypes.pl administrative perl script In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17944 --- Comment #53 from Jonathan Druart --- Created attachment 63308 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=63308&action=edit Bug 17944: QA follow-up - Remove an unused use statement - Fix pod - Use snake_case - Fix test "An itemtype cannot be deleted if and only if there is biblioitem linked with it" Signed-off-by: Jonathan Druart -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue May 9 21:00:51 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 09 May 2017 19:00:51 +0000 Subject: [Koha-bugs] [Bug 17944] Remove the sql code from itemtypes.pl administrative perl script In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17944 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #63307|0 |1 is obsolete| | Attachment #63308|0 |1 is obsolete| | --- Comment #54 from Jonathan Druart --- Created attachment 63309 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=63309&action=edit Bug 17944 - Add Koha::ItemType->can_be_deleted and use it from admin/itemtypes.pl Removed the sql code from Itemtypes.pm and replaced it with DBIx database query in the itemtypes.pl administrative script Test plan: 1. In the staff interface, stage and manage MARC records for import 2. Try to delete an itemtype. If there are items of that itemtype in the database then a message telling you the number of items of that itemtype there are will be displayed. 3. Record that number 4. View the admin/itemtpes.pl script and confirm that there is sql code written in this file. 5. Apply this patch 6. View the admin/itemtypes.pl script and observe that there is no sql in this file. There is however DBIx code, for example $schema->resultset('Item')->search({ 'itype' => $itemtype_code} ); which is searching for items with the itype value matching $itemtype_code value. 7. In the staff interface try to delete the same itemtype 8. Record the number of items there are with that itemtype in the resulting message 9. The numbers recorded in steps 3 and 8 should match showing that the DBIx code is working as intended Signed-off-by: Jonathan Druart -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue May 9 21:00:56 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 09 May 2017 19:00:56 +0000 Subject: [Koha-bugs] [Bug 17944] Remove the sql code from itemtypes.pl administrative perl script In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17944 --- Comment #55 from Jonathan Druart --- Created attachment 63310 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=63310&action=edit Bug 17944: QA follow-up - Remove an unused use statement - Fix pod - Use snake_case - Fix test "An itemtype cannot be deleted if and only if there is biblioitem linked with it" Signed-off-by: Jonathan Druart -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue May 9 21:05:20 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 09 May 2017 19:05:20 +0000 Subject: [Koha-bugs] [Bug 18563] New: Force koha.ics to only show up on first day of created calendar appointment Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18563 Bug ID: 18563 Summary: Force koha.ics to only show up on first day of created calendar appointment Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: OPAC Assignee: oleonard at myacpl.org Reporter: jandrews at washoecounty.us QA Contact: testopia at bugs.koha-community.org This is a follow-up to bug 5456 - create a link to opac-ics.pl. The functionality established by that bug fix creates a file that can be imported to a calendar program. In Outlook, with a due time of 11:59, a 1-hour appointment is created, resulting in a 2-day "date due" appointment in the calendar. The appointment created should be limited to the first (actual due) date. [tag] [reply] [?] Comment 13 John Andrews 2017-05-02 16:16:58 UTC There's a problem with the lack of end time -- when importing this into my outlook calendar, because there's no end time, outlook automatically creates an hour long event. Which means that the due date reminder shows up both on the due date, and on the day AFTER the due date. In our case, the time due is 11:59 pm, so the appointment gets created in outlook as from 11:59 pm on the due date until 12:59 am on the next day. Is there a way to force the appointment to start and end at the same time? [tag] [reply] [?] Comment 14 Magnus Enger 2017-05-03 08:05:18 UTC (In reply to John Andrews from comment #13) Please report this as a new bug/issue. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue May 9 21:05:35 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 09 May 2017 19:05:35 +0000 Subject: [Koha-bugs] [Bug 5456] Create a link to opac-ics.pl In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5456 John Andrews changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |https://bugs.koha-community | |.org/bugzilla3/show_bug.cgi | |?id=18563 -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue May 9 21:05:35 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 09 May 2017 19:05:35 +0000 Subject: [Koha-bugs] [Bug 18563] Force koha.ics to only show up on first day of created calendar appointment In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18563 John Andrews changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |https://bugs.koha-community | |.org/bugzilla3/show_bug.cgi | |?id=5456 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue May 9 21:08:03 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 09 May 2017 19:08:03 +0000 Subject: [Koha-bugs] [Bug 17320] MySQL 5.7 doesn't work well with SQL using '0000-00-00' In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17320 --- Comment #10 from Jonathan Druart --- The test plan is wrong, we need to test the patch with older versions of MySQL as well. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue May 9 21:09:18 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 09 May 2017 19:09:18 +0000 Subject: [Koha-bugs] [Bug 18564] New: kola-common.cnf parsing is too restrictive Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18564 Bug ID: 18564 Summary: kola-common.cnf parsing is too restrictive Change sponsored?: --- Product: Koha Version: 16.11 Hardware: All OS: All Status: NEW Severity: minor Priority: P5 - low Component: Installation and upgrade (command-line installer) Assignee: gmcharlt at gmail.com Reporter: eric.vantillard at evaxion.fr QA Contact: testopia at bugs.koha-community.org my koha-common.cnf is using this form: [client] host=db user=root password="move_rootpwd_to_dotenv" this file is working has expected with mysql tools. but koha-create parsing will not find the db host resulting in koha-conf.xml containing no values in hostname element. as a result trying to connect to the web serveur will raise an error : Software error: DBIx::Class::Storage::DBI::catch {...} (): DBI Connection failed: Can't connect to local MySQL server through socket '/var/run/mysqld/mysqld.sock' (2) at /usr/share/perl5/DBIx/Class/Storage/DBI.pm line 1490. at /usr/share/koha/lib/Koha/Database.pm line 90 Compilation failed in require at /usr/share/koha/intranet/cgi-bin/mainpage.pl line 31. BEGIN failed--compilation aborted at /usr/share/koha/intranet/cgi-bin/mainpage.pl line 31. For help, please send mail to the webmaster ([no address given]), giving this error message and the time and date of the error. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue May 9 21:20:05 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 09 May 2017 19:20:05 +0000 Subject: [Koha-bugs] [Bug 18564] kola-common.cnf parsing is too restrictive In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18564 --- Comment #1 from Eric Vantillard --- adding spaces around the equal sign will resolve the issue the problem is in kohl-create function getmysqlhost() https://github.com/Koha-Community/Koha/blob/master/debian/scripts/koha-create#L124 the awk search require spaces -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue May 9 21:23:29 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 09 May 2017 19:23:29 +0000 Subject: [Koha-bugs] [Bug 7518] searches with quotation marks don't work In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7518 Magnus Enger changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |https://bugs.koha-community | |.org/bugzilla3/show_bug.cgi | |?id=18294 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue May 9 21:23:29 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 09 May 2017 19:23:29 +0000 Subject: [Koha-bugs] [Bug 18294] Keyword searches surrounded by double quotes fail on staff client and OPAC In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18294 Magnus Enger changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |https://bugs.koha-community | |.org/bugzilla3/show_bug.cgi | |?id=7518 CC| |magnus at libriotech.no -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue May 9 21:25:13 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 09 May 2017 19:25:13 +0000 Subject: [Koha-bugs] [Bug 18563] Force koha.ics to only show up on first day of created calendar appointment In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18563 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- See Also|https://bugs.koha-community | |.org/bugzilla3/show_bug.cgi | |?id=5456 | CC| |jonathan.druart at bugs.koha-c | |ommunity.org Severity|enhancement |normal Depends on| |5456 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5456 [Bug 5456] Create a link to opac-ics.pl -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue May 9 21:25:13 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 09 May 2017 19:25:13 +0000 Subject: [Koha-bugs] [Bug 5456] Create a link to opac-ics.pl In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5456 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |18563 See Also|https://bugs.koha-community | |.org/bugzilla3/show_bug.cgi | |?id=18563 | Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18563 [Bug 18563] Force koha.ics to only show up on first day of created calendar appointment -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue May 9 21:31:20 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 09 May 2017 19:31:20 +0000 Subject: [Koha-bugs] [Bug 18294] Keyword searches surrounded by double quotes fail on staff client and OPAC In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18294 Tom?s Cohen Arazi changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |tomascohen at gmail.com --- Comment #2 from Tom?s Cohen Arazi --- (In reply to Barton Chittenden from comment #1) > Note that this issue is separate from the URL encoding issues in Bug 13301. Barton, have you tried enabling the QueryParser? I'm more inclined to fix the QueryParser if there are issues with it, and stop spending time on the legacy query parsing code. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue May 9 21:33:31 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 09 May 2017 19:33:31 +0000 Subject: [Koha-bugs] [Bug 18294] Keyword searches surrounded by double quotes fail on staff client and OPAC In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18294 --- Comment #3 from Magnus Enger --- I had a customer complaining about this exact issue. Setting UseQueryParser = Try solves it. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue May 9 21:35:35 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 09 May 2017 19:35:35 +0000 Subject: [Koha-bugs] [Bug 18294] Keyword searches surrounded by double quotes fail on staff client and OPAC In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18294 --- Comment #4 from Magnus Enger --- (In reply to Magnus Enger from comment #3) > I had a customer complaining about this exact issue. Setting UseQueryParser > = Try solves it. Not sure if that might cause other issues, though... -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue May 9 21:44:45 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 09 May 2017 19:44:45 +0000 Subject: [Koha-bugs] [Bug 11299] Add a button that automatically links authority records to a biblio record during edition. (AJAX) In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11299 --- Comment #34 from Bouzid --- Created attachment 63311 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=63311&action=edit Bug11299 - Fix problems when authority is not found and i want add it -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue May 9 21:45:53 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 09 May 2017 19:45:53 +0000 Subject: [Koha-bugs] [Bug 11299] Add a button that automatically links authority records to a biblio record during edition. (AJAX) In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11299 --- Comment #35 from Bouzid --- Created attachment 63312 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=63312&action=edit Bug 11299 - QA fix -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue May 9 21:46:02 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 09 May 2017 19:46:02 +0000 Subject: [Koha-bugs] [Bug 11299] Add a button that automatically links authority records to a biblio record during edition. (AJAX) In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11299 Bouzid changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #63311|0 |1 is obsolete| | --- Comment #36 from Bouzid --- Created attachment 63313 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=63313&action=edit Bug11299 - Fix problems when authority is not found and i want add it -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue May 9 21:56:07 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 09 May 2017 19:56:07 +0000 Subject: [Koha-bugs] [Bug 11299] Add a button that automatically links authority records to a biblio record during edition. (AJAX) In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11299 Bouzid changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |Needs Signoff --- Comment #37 from Bouzid --- Hi Katrin, Thanks for the feedback. I fix all problems from the QA script and all problems when you open window for add authority. Now, if the authority is not found, when you click add authority, it's open the window with the correct authority type. Thanks. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue May 9 22:04:10 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 09 May 2017 20:04:10 +0000 Subject: [Koha-bugs] [Bug 18564] kola-common.cnf parsing is too restrictive In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18564 --- Comment #2 from Eric Vantillard --- maybe something like that awk ' BEGIN { FS="=" } $1 ~/\[/ { inclient=0 } $1 ~/\[client\]/ { inclient=1 next } inclient==1 && $1 ~/host/ { print $2 } ' /etc/mysql/koha-common.cnf -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue May 9 22:25:06 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 09 May 2017 20:25:06 +0000 Subject: [Koha-bugs] [Bug 18565] New: Create system preference for OPACShowDueDate Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18565 Bug ID: 18565 Summary: Create system preference for OPACShowDueDate Change sponsored?: --- Product: Koha Version: 16.11 Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: System Administration Assignee: koha-bugs at lists.koha-community.org Reporter: jzairo at bywatersolutions.com QA Contact: testopia at bugs.koha-community.org CC: gmcharlt at gmail.com We have a few options through the system preferences to hide fields in the OPAC, such as OPACShowBarcode which allows you to show or hide the barcode on the holdings tab and OPACShowHoldQueueDetails which allows you to show or hide the holds priority to patrons in the OPAC. It would be great to have a system preference to show or hide the duedate on the holdings tab, like an option for OPACShowDueDate. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Tue May 9 22:25:40 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 09 May 2017 20:25:40 +0000 Subject: [Koha-bugs] [Bug 18565] Create system preference for OPACShowDueDate In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18565 Jessie Zairo changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |kyle at bywatersolutions.com, | |nick at bywatersolutions.com -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue May 9 23:01:23 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 09 May 2017 21:01:23 +0000 Subject: [Koha-bugs] [Bug 18564] koha-common.cnf parsing is too restrictive In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18564 Chris Cormack changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |chris at bigballofwax.co.nz Summary|kola-common.cnf parsing is |koha-common.cnf parsing is |too restrictive |too restrictive -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed May 10 04:31:20 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 10 May 2017 02:31:20 +0000 Subject: [Koha-bugs] [Bug 18438] Check in: Modal about holds hides important check in messages In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18438 --- Comment #23 from Alex Buckley --- Hi Jonathan Sure thing, I'll do that when I have a bit of time this evening -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed May 10 05:43:03 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 10 May 2017 03:43:03 +0000 Subject: [Koha-bugs] [Bug 17438] Warnings from Business::ISBN::Data in webinstaller In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17438 Marc V?ron changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |veron at veron.ch --- Comment #3 from Marc V?ron --- I got the same while upgrading to the newest master 16.12.00.032 Perl modules on aobut page: Business::ISBN (2.05) 2.09 [Wed May 10 05:33:06 2017] updatedatabase.pl: ISBN_RANGE_MESSAGE is set to [] but that file does not exist! [Wed May 10 05:33:06 2017] updatedatabase.pl: Trying to use the default locations [Wed May 10 05:33:06 2017] updatedatabase.pl: at /usr/share/perl5/Business/ISBN.pm line 76. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Wed May 10 06:12:21 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 10 May 2017 04:12:21 +0000 Subject: [Koha-bugs] [Bug 18551] Hide with CSS dynamic elements in member search In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18551 Marc V?ron changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #63171|0 |1 is obsolete| | --- Comment #8 from Marc V?ron --- Created attachment 63314 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=63314&action=edit Bug 18551 - Hide with CSS dynamic elements in member search In member search page, the result table is in Ajax so fully managed by Javascript. There is also a yellow dialog message prepared in HTML. Thoses elements are hidden by JS code : ie $("#patron_list_dialog").hide(). The problem is that the static page is first loaded an displayed then the JS code runs an hides the elements. On a low performance computer, this action is visible and looks like there is a blinking yellow message. I propose to hide with CSS so that thoses elements are not displayed in static page and are there shown in dynamic JS code. Test plan : Check display is unchanged : - Go to home page /cgi-bin/koha/members/members-home.pl - Perform patron search from header search box - Perform patron search by clicking on a letter - Perform patron search from filters (left of results table) - Select a patron and add it to a list => you see the yellow message Yellow message does no longer appear with this patch. Signed-off-by: Marc V?ron -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed May 10 06:14:39 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 10 May 2017 04:14:39 +0000 Subject: [Koha-bugs] [Bug 18551] Hide with CSS dynamic elements in member search In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18551 Marc V?ron changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #63287|0 |1 is obsolete| | --- Comment #9 from Marc V?ron --- Created attachment 63315 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=63315&action=edit Bug 18551: followup - hide advanced filters in header, move hidding to css file Test plan: The same as first patch, but also with advanced search form in header hidden on page load - see comment 4 Issue with advanced search form is gone. Signed-off-by: Marc V?ron -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed May 10 06:31:10 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 10 May 2017 04:31:10 +0000 Subject: [Koha-bugs] [Bug 18551] Hide with CSS dynamic elements in member search In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18551 --- Comment #10 from Marc V?ron --- Two issues are addressed with first two patches, I signed the patches off. But there is one more problem showing up (It was hidden by the first two problems): To reproduce: - Apply first two patches - Go to Home > Patrons - Have a close look to the tabs Search Patrons / Check out / Check in ... - You will see that first there is no green line around the tabs and the first tab 'Search patrons' is not in bold. The height of the whole search part changes, moving the rest of the page contents up. Then the green line appears, font of 'Search patron' changes to bold, the area of the search part expands and the rest of the page moves down again. - You can reproduce by performing a search as well -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed May 10 06:41:46 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 10 May 2017 04:41:46 +0000 Subject: [Koha-bugs] [Bug 18566] New: Staff client should always show purchase suggestion Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18566 Bug ID: 18566 Summary: Staff client should always show purchase suggestion Change sponsored?: --- Product: Koha Version: 16.11 Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Acquisitions Assignee: koha-bugs at lists.koha-community.org Reporter: mishravk79 at gmail.com QA Contact: testopia at bugs.koha-community.org Koha allows the staff to put the purchase suggestions on users behalf through staff interface though in system preferences it has been marked as "not allowed". But acquisition home page is missing "suggestion management" link therefore staff is not able to view the same if he/she has made suggestions on users behalf. The requirement is it should always show the suggestions whether system preference allows or not allows the users to make suggestions via OPAC. I have tested it on 16.11.07 installed on debian via package. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Wed May 10 06:42:28 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 10 May 2017 04:42:28 +0000 Subject: [Koha-bugs] [Bug 18566] Staff client should always show purchase suggestion In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18566 Vinod changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |indradg at l2c2.co.in, | |mishravk79 at gmail.com -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed May 10 06:46:34 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 10 May 2017 04:46:34 +0000 Subject: [Koha-bugs] [Bug 17925] Disable debugging in reports/bor_issues_top.pl In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17925 Mason James changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed May 10 06:46:38 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 10 May 2017 04:46:38 +0000 Subject: [Koha-bugs] [Bug 17925] Disable debugging in reports/bor_issues_top.pl In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17925 Mason James changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #59208|0 |1 is obsolete| | --- Comment #5 from Mason James --- Created attachment 63316 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=63316&action=edit Bug 17925: Disable debugging in reports/bor_issues_top.pl Remove setting $debug to 1. This prevents creation of file tmp/bor_issues_top.debug.log. Enable warnings pragma. Resolve a uninitialized warning on $sep like: Use of uninitialized value $CGI::Compile::ROOT::usr_share_koha_masterclone_reports_bor_issues_top_2epl::sep in string eq at /usr/share/koha/masterclone/reports/bor_issues_top.pl line 66. Test plan: Restart Plack (as you always do when testing). Remove file /tmp/bor_issues_top.debug.log. Open Reports/Patrons with the most checkouts. Check if the file in /tmp has not been created again. Check the log for warnings after you restarted Plack. Signed-off-by: Marcel de Rooy Signed-off-by: Mason James -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed May 10 06:47:28 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 10 May 2017 04:47:28 +0000 Subject: [Koha-bugs] [Bug 17925] Disable debugging in reports/bor_issues_top.pl In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17925 Mason James changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |mtj at kohaaloha.com --- Comment #6 from Mason James --- seems to work as expected, thanks Marcel! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed May 10 07:06:37 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 10 May 2017 05:06:37 +0000 Subject: [Koha-bugs] [Bug 18548] running koha-create --request-db without an instance name should abort In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18548 dilan at calyx.net.au changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |dilan at calyx.net.au --- Comment #8 from dilan at calyx.net.au --- Just tried it Josef. It's still giving a 'getent [...]' message instead. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed May 10 07:35:36 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 10 May 2017 05:35:36 +0000 Subject: [Koha-bugs] [Bug 18548] running koha-create --request-db without an instance name should abort In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18548 --- Comment #9 from Josef Moravec --- (In reply to dilan from comment #8) > Just tried it Josef. It's still giving a 'getent [...]' message instead. Can't help it, but it works for me... how do you try to test it? On devbox? -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed May 10 07:41:32 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 10 May 2017 05:41:32 +0000 Subject: [Koha-bugs] [Bug 16515] Did you mean? links don't wrap on smaller screens In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16515 dilan at calyx.net.au changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #63129|0 |1 is obsolete| | --- Comment #7 from dilan at calyx.net.au --- Created attachment 63317 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=63317&action=edit Bug 16515 [Generated CSS] Did you mean? links don't wrap on smaller screens Processed and minified CSS. Works as expected and looks much tidier now. Signed-off-by: Dilan Johnpulle -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed May 10 07:41:25 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 10 May 2017 05:41:25 +0000 Subject: [Koha-bugs] [Bug 16515] Did you mean? links don't wrap on smaller screens In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16515 dilan at calyx.net.au changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed May 10 08:11:46 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 10 May 2017 06:11:46 +0000 Subject: [Koha-bugs] [Bug 16515] Did you mean? links don't wrap on smaller screens In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16515 dilan at calyx.net.au changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |dilan at calyx.net.au --- Comment #8 from dilan at calyx.net.au --- Created attachment 63318 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=63318&action=edit Screenshot after applying patch -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed May 10 08:31:05 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 10 May 2017 06:31:05 +0000 Subject: [Koha-bugs] [Bug 18548] running koha-create --request-db without an instance name should abort In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18548 --- Comment #10 from dilan at calyx.net.au --- Created attachment 63319 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=63319&action=edit Screenshot after applying patch - not working Yeah on a devbox. Have a look at the attachment. This is the message I get after applying the patch. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed May 10 09:11:49 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 10 May 2017 07:11:49 +0000 Subject: [Koha-bugs] [Bug 18548] running koha-create --request-db without an instance name should abort In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18548 --- Comment #11 from Josef Moravec --- (In reply to dilan from comment #10) > Created attachment 63319 [details] > Screenshot after applying patch - not working > > Yeah on a devbox. Have a look at the attachment. This is the message I get > after applying the patch. On devbox you should run it as debian/scripts/koha-create because that's the modified file - the koha-create in system is that one installled by package - so old version -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed May 10 10:05:31 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 10 May 2017 08:05:31 +0000 Subject: [Koha-bugs] [Bug 18351] No warning when deleting budgets that have funds attached In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18351 Josef Moravec changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |josef.moravec at gmail.com --- Comment #7 from Josef Moravec --- (In reply to Aleisha Amohia from comment #6) > I was about to fix the comment above but I realised that this seems to have > been fixed in the latest version of Koha - can someone please check and try > to reproduce this bug? I could reproduce the bug on current master. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed May 10 10:25:06 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 10 May 2017 08:25:06 +0000 Subject: [Koha-bugs] [Bug 17821] due date in intranet search results should use TT date plugin In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17821 Julian Maurice changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |julian.maurice at biblibre.com --- Comment #12 from Julian Maurice --- Pushed to 3.22.x for 3.22.21 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed May 10 10:41:33 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 10 May 2017 08:41:33 +0000 Subject: [Koha-bugs] [Bug 18550] Patron card creator: Print output does not respect layout units In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18550 Josef Moravec changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed May 10 10:41:36 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 10 May 2017 08:41:36 +0000 Subject: [Koha-bugs] [Bug 18550] Patron card creator: Print output does not respect layout units In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18550 Josef Moravec changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #63219|0 |1 is obsolete| | --- Comment #4 from Josef Moravec --- Created attachment 63320 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=63320&action=edit [SIGNED-OFF] Bug 18550 - Patron card creator: Print output does not respect layout units To reproduce: Text, images and barcode positions are always layed out based on PostScript points, regardless of unit defined in card layout. To reproduce: - Test on top of Bug 18541 (introduces layout grid) - Create a card layout with a text field, an image and a barcode. Use points as layout unit - Activate layout grid - Create PDF output, save - Change layout unit to mm - Create PDF output, save - Compare PDFs. Verify that the positions are unchanged (still using points) To test: - Apply patch - Create again PDF - Verify that elements are positionad as expected (using unit, e.g. mm) - Bonus test: Repeat with other units Signed-off-by: Josef Moravec -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed May 10 11:00:58 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 10 May 2017 09:00:58 +0000 Subject: [Koha-bugs] [Bug 13913] Renewal error message in OPAC is confusing In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13913 Josef Moravec changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #63105|0 |1 is obsolete| | --- Comment #5 from Josef Moravec --- Created attachment 63321 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=63321&action=edit [SIGNED-OFF] Bug 13913 - Renewal error message in OPAC is confusing This patch adds some formatting to the error message a patron receives when there are renewal failures in the OPAC. This is pretty much the least which could be done to address this problem. However, I don't think the issue can be fixed without re-thinking how renewals are processed. Sending error messages back to opac-user.pl via URL parameter isn't flexible enough. To test, apply the patch and attempt to renew multiple items in the OPAC which cannot be renewed for some reason, for instance because they have been renewed too many times. The error messages should appear in a list rather than strung together in one long block of text. Signed-off-by: Josef Moravec -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed May 10 11:00:55 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 10 May 2017 09:00:55 +0000 Subject: [Koha-bugs] [Bug 13913] Renewal error message in OPAC is confusing In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13913 Josef Moravec changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed May 10 11:06:30 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 10 May 2017 09:06:30 +0000 Subject: [Koha-bugs] [Bug 13452] Average checkout report always uses biblioitems.itemtype In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13452 Josef Moravec changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed May 10 11:06:33 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 10 May 2017 09:06:33 +0000 Subject: [Koha-bugs] [Bug 13452] Average checkout report always uses biblioitems.itemtype In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13452 Josef Moravec changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #40798|0 |1 is obsolete| | Attachment #48987|0 |1 is obsolete| | Attachment #56246|0 |1 is obsolete| | --- Comment #14 from Josef Moravec --- Created attachment 63322 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=63322&action=edit [SIGNED-OFF] Bug 13452: 'Average loan time' report to obey item-level_itypes preference Fixes the 'Average loan time' report so that the system preference setting item-level_itypes is taken into account. Before the patch, the report was always using the biblio level itemtype. With the patch, it will depend on the pref setting. To test: - Run various reports, compare results with both possible pref settings - Try limiting your search in various ways, especially on a specific itemtype - Make sure you switch checkboxes in testing, using itemtype as the row or as the column Notes: - Filtering on a specific itemtype on master was not working if the itemtype was chosen as column. The patch should fix that. - Fixes headings and breadcrumbs so that the name of the report is the same as on the reports start page Signed-off-by: Indranil Das Gupta (L2C2 Technologies) Signed-off-by: Josef Moravec -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed May 10 11:06:58 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 10 May 2017 09:06:58 +0000 Subject: [Koha-bugs] [Bug 13452] Average checkout report always uses biblioitems.itemtype In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13452 --- Comment #16 from Josef Moravec --- Created attachment 63324 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=63324&action=edit [SIGNED-OFF] Bug 13452: Fix for plack Signed-off-by: Josef Moravec -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed May 10 11:06:50 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 10 May 2017 09:06:50 +0000 Subject: [Koha-bugs] [Bug 13452] Average checkout report always uses biblioitems.itemtype In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13452 --- Comment #15 from Josef Moravec --- Created attachment 63323 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=63323&action=edit [SIGNED-OFF] Bug 13452: Fix obvious issues in issues_avg_stats.pl - Remove joins with issuingrules which are not needed - Fix the SQL query so that $weight is now the value of COUNT(*) instead of a timestamp - QA fix: '$column eq $itype' instead of '$column =~ $itype' (same for $line) Signed-off-by: Srdjan Signed-off-by: Josef Moravec -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed May 10 11:24:49 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 10 May 2017 09:24:49 +0000 Subject: [Koha-bugs] [Bug 18439] Resend button for notices being hidden by CSS and never unhidden In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18439 Julian Maurice changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |julian.maurice at biblibre.com --- Comment #9 from Julian Maurice --- Pushed to 3.22.x for 3.22.21 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed May 10 11:26:01 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 10 May 2017 09:26:01 +0000 Subject: [Koha-bugs] [Bug 18439] Resend button for notices being hidden by CSS and never unhidden In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18439 --- Comment #10 from Julian Maurice --- (In reply to Julian Maurice from comment #9) > Pushed to 3.22.x for 3.22.21 Wrong bug, sorry. This patch is not needed in 3.22.x -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed May 10 11:26:48 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 10 May 2017 09:26:48 +0000 Subject: [Koha-bugs] [Bug 18364] LOCK and UNLOCK are not transaction-safe In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18364 --- Comment #17 from Julian Maurice --- Pushed to 3.22.x for 3.22.21 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed May 10 11:29:27 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 10 May 2017 09:29:27 +0000 Subject: [Koha-bugs] [Bug 17853] MARC21: Don't remove () from link text for 780/785 In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17853 Josef Moravec changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed May 10 11:29:15 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 10 May 2017 09:29:15 +0000 Subject: [Koha-bugs] [Bug 17814] koha-plack --stop should make sure that Plack really stop In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17814 Julian Maurice changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |julian.maurice at biblibre.com --- Comment #14 from Julian Maurice --- Pushed to 3.22.x for 3.22.21 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed May 10 11:29:30 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 10 May 2017 09:29:30 +0000 Subject: [Koha-bugs] [Bug 17853] MARC21: Don't remove () from link text for 780/785 In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17853 Josef Moravec changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #62078|0 |1 is obsolete| | Attachment #62079|0 |1 is obsolete| | --- Comment #11 from Josef Moravec --- Created attachment 63325 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=63325&action=edit [SIGNED-OFF] Bug 17853 - Don't remove () from link text To test: - Catalogue a record with 780, Indicators 00 and $a some text including parentheses. e.g. Hospitals (Chicago, Ill. : 1936) - Verify that the () are not shown in the link text and are not part of the URL. - Apply patch - Verify that the () are shown in the link text and are not part of the URL. Signed-off-by: Felix Hemme Signed-off-by: Nick Clemens Signed-off-by: Josef Moravec -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed May 10 11:29:38 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 10 May 2017 09:29:38 +0000 Subject: [Koha-bugs] [Bug 17853] MARC21: Don't remove () from link text for 780/785 In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17853 --- Comment #12 from Josef Moravec --- Created attachment 63326 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=63326&action=edit [SIGNED-OFF] Bug 17853 - Don't remove () from field 785 link text To test: - Catalogue a record with 780, Indicators 00 and $a some text including parentheses. e.g. Hospitals (Chicago, Ill. : 1936) - Verify that the () are not shown in the link text and are not part of the URL. - Apply patch - Verify that the () are shown in the link text and are not part of the URL. Signed-off-by: Josef Moravec -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed May 10 11:31:05 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 10 May 2017 09:31:05 +0000 Subject: [Koha-bugs] [Bug 17911] Message and timeout mismatch at the end of the install process In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17911 Julian Maurice changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |julian.maurice at biblibre.com --- Comment #7 from Julian Maurice --- Pushed to 3.22.x for 3.22.21 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed May 10 11:34:20 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 10 May 2017 09:34:20 +0000 Subject: [Koha-bugs] [Bug 17006] REST API: add route to change patron's password In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17006 Mirko Tietgen changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |mirko at abunchofthings.net Status|Signed Off |Failed QA --- Comment #25 from Mirko Tietgen --- I can't apply the last patch. Wende an: Bug 17006: (follow-up) Use Koha::Exceptions for change password endpoint fatal: sha1 information is lacking or useless (Koha/REST/V1/Patron.pm). Dem Repository fehlen notwendige Blobs um auf einen 3-Wege-Merge zur?ckzufallen. Kann nicht zu 3-Wege-Merge zur?ckfallen. Anwendung des Patches fehlgeschlagen bei 0001 Bug 17006: (follow-up) Use Koha::Exceptions for change password endpoint -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed May 10 11:45:24 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 10 May 2017 09:45:24 +0000 Subject: [Koha-bugs] [Bug 18423] Add child button not always appearing - problem in template variable In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18423 Julian Maurice changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |julian.maurice at biblibre.com --- Comment #21 from Julian Maurice --- Pushed to 3.22.x for 3.22.21 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed May 10 11:51:29 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 10 May 2017 09:51:29 +0000 Subject: [Koha-bugs] [Bug 18309] UNIMARC update from IFLA In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18309 --- Comment #16 from Fridolin SOMERS --- (In reply to Koha Team Lyon 3 from comment #15) > Control fields (generally, just tags below 010) do not have subfields, use > data() at /home/koha/src/Koha/Filter/MARC/EmbedItemsAvailability.pm line 75. > at /home/koha/lib/contrib/sandbox/cron/../Run.pm line 28. This is a real bug, in Koha::Filter::MARC::EmbedItemsAvailability::_processrecord, $biblionumber_field should be corrected to allow controlfield like 001. Please create a new bug report. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed May 10 11:52:27 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 10 May 2017 09:52:27 +0000 Subject: [Koha-bugs] [Bug 12021] SIP2 checkin should alert on transfer and use CT for return branch In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12021 Julian Maurice changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |julian.maurice at biblibre.com --- Comment #22 from Julian Maurice --- Pushed to 3.22.x for 3.22.21 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed May 10 11:55:39 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 10 May 2017 09:55:39 +0000 Subject: [Koha-bugs] [Bug 18460] Remove itemtype-related Serials.t warnings In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18460 Julian Maurice changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |julian.maurice at biblibre.com --- Comment #8 from Julian Maurice --- Pushed to 3.22.x for 3.22.21 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed May 10 11:59:08 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 10 May 2017 09:59:08 +0000 Subject: [Koha-bugs] [Bug 18335] Check in: Make patron info in hold messages obey syspref AddressFormat In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18335 Julian Maurice changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |julian.maurice at biblibre.com --- Comment #8 from Julian Maurice --- Pushed to 3.22.x for 3.22.21 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed May 10 12:02:36 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 10 May 2017 10:02:36 +0000 Subject: [Koha-bugs] [Bug 18525] Can't create order line from accepted suggestion In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18525 Nick Clemens changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #62998|0 |1 is obsolete| | --- Comment #4 from Nick Clemens --- Created attachment 63327 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=63327&action=edit Bug 18525: (bug 14828 follow-up) FIX ordering from suggestion when item-level_itypes = biblio When ordering from a suggestion with item-level_itypes = biblio the app crashes with Template process failed: undef error - The method selected is not covered by tests! at /home/vagrant/kohaclone/C4/Templates.pm line 121. C4::ItemTypes->all did not set a selected flag. The item type is only display when ordering (and not modifying an order). The flag is never set, the test can be removed. Test plan: Confirm that the error is gone Signed-off-by: Katrin Fischer Signed-off-by: Nick Clemens -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed May 10 12:02:33 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 10 May 2017 10:02:33 +0000 Subject: [Koha-bugs] [Bug 18525] Can't create order line from accepted suggestion In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18525 Nick Clemens changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed May 10 12:04:15 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 10 May 2017 10:04:15 +0000 Subject: [Koha-bugs] [Bug 18429] Receiving an item should update the datelastseen In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18429 Julian Maurice changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |julian.maurice at biblibre.com --- Comment #11 from Julian Maurice --- Pushed to 3.22.x for 3.22.21 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed May 10 12:05:43 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 10 May 2017 10:05:43 +0000 Subject: [Koha-bugs] [Bug 18443] Get rid of warning 'uninitialized value $user' in C4/Auth.pm In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18443 Julian Maurice changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |julian.maurice at biblibre.com --- Comment #6 from Julian Maurice --- Pushed to 3.22.x for 3.22.21 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed May 10 12:08:27 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 10 May 2017 10:08:27 +0000 Subject: [Koha-bugs] [Bug 18477] AR_PENDING notice does not populate values from article_requests table. In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18477 Nick Clemens changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|koha-bugs at lists.koha-commun |kyle at bywatersolutions.com |ity.org | CC| |nick at bywatersolutions.com -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed May 10 12:22:54 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 10 May 2017 10:22:54 +0000 Subject: [Koha-bugs] [Bug 4460] Amazon' s AssociateID tag not used in links so referred revenue lost In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=4460 Nick Clemens changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed May 10 12:22:57 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 10 May 2017 10:22:57 +0000 Subject: [Koha-bugs] [Bug 4460] Amazon' s AssociateID tag not used in links so referred revenue lost In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=4460 Nick Clemens changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #62922|0 |1 is obsolete| | --- Comment #37 from Nick Clemens --- Created attachment 63328 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=63328&action=edit Bug 4460: Amazon's AssociateID tag not used in links so referred revenue lost Reworking based on output of: git grep "gp\/reader" Additionally, some changes might be in order though gp/reader works. https://affiliate-program.amazon.com/help/topic/t64/a1 suggests using dp A dp was discovered, so that part of the URL was left unchanged. The "/ref..." part was changed to just an Amazon tag ("?tag={AAT}") if defined. TEST PLAN --------- 1) Added: "100 years of Canadian foreign policy / edited by Robert Bothwell and Jean Daudelin." 2) Added a second book with the word foreign in the title. 3) Waited for reindex 4) Checked out the Canadian foreign policy book. 5) Applied patch 6) Made sure that: - AmazonAssocTag was set to TEST (easy to notice) - AmazonCoverImages was set to 'Show' - OPACAmazonCoverImages was set to 'Show' 7) Searched intranet for 'foreign' to find the detail page -- hovering over picture shows URL with ?tag=TEST in it. 8) Went to the OPAC Detail page 9) Toggling OPACURLOpenInNewWindow, confirmed that URL for the picture contained ?tag=TEST in it. 10) Logged into the OPAC 11) Confirmed the URL in the checked out list on your summary page contained ?tag=TEST in it. 12) Confirmed the URL in the checked out list on your reading history page contained ?tag=TEST in it. 13) Confirmed links worked (went to expected page) 14) run koha qa test tools Followed test plan. Works as expected. Signed-off-by: Marc V?ron Signed-off-by: Marc V?ron Signed-off-by: Katrin Fischer Signed-off-by: Nick Clemens -- You are receiving this mail because: You are watching all bug changes. You are the QA Contact for the bug. From bugzilla-daemon at bugs.koha-community.org Wed May 10 12:27:04 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 10 May 2017 10:27:04 +0000 Subject: [Koha-bugs] [Bug 18567] New: Amazon #reader-link feature is not available for all titles, causes error Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18567 Bug ID: 18567 Summary: Amazon #reader-link feature is not available for all titles, causes error Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: normal Priority: P5 - low Component: Templates Assignee: oleonard at myacpl.org Reporter: nick at bywatersolutions.com QA Contact: testopia at bugs.koha-community.org When clicking on an amazon image, if the link includes the '#reader-link' at the end you may get an error messsage: Example: http://www.amazon.com/gp/reader/0773534342/ref=sib_dp_pt/002-7879865-0184864#reader-link Additionally, it would be nice to make these links open in a new tab/window rather than the current. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed May 10 12:27:45 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 10 May 2017 10:27:45 +0000 Subject: [Koha-bugs] [Bug 18567] Amazon #reader-link feature is not available for all titles, causes error In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18567 Nick Clemens changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |katrin.fischer at bsz-bw.de, | |mtompset at hotmail.com, | |nick at bywatersolutions.com -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed May 10 12:31:13 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 10 May 2017 10:31:13 +0000 Subject: [Koha-bugs] [Bug 1707] Search for patron '%' returns all results In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=1707 Nick Clemens changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Failed QA -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed May 10 12:31:49 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 10 May 2017 10:31:49 +0000 Subject: [Koha-bugs] [Bug 17006] REST API: add route to change patron's password In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17006 Josef Moravec changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #57356|0 |1 is obsolete| | Attachment #57357|0 |1 is obsolete| | Attachment #57358|0 |1 is obsolete| | Attachment #57359|0 |1 is obsolete| | Attachment #57360|0 |1 is obsolete| | --- Comment #26 from Josef Moravec --- Created attachment 63329 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=63329&action=edit Bug 17006: Add API route for changing patron's password PATCH /patrons/{borrowernumber}/password (change password) Required body params: - current_password - new_password To test: 1. Apply patch 2. Run t/db_dependent/api/v1/patrons.t 3. Send PATCH request to http://library/api/v1/patrons/YYY/password where YYY is existing borrowernumber (borrowers flag required) 4. Make sure that password was changed. 5. Try also too short password, and wrong current password and observe that errors are displayed appropriately. You may find this useful for testing: curl -X PATCH http://library/api/v1/patrons/123/password --data '{"current_password":"123456", "new_password":"1234"}' --cookie 'CGISESSID=055ca5a9a3ad3fb5052143bd015c1c10' Signed-off-by: Aleisha Amohia Signed-off-by: Josef Moravec -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed May 10 12:32:08 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 10 May 2017 10:32:08 +0000 Subject: [Koha-bugs] [Bug 17006] REST API: add route to change patron's password In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17006 --- Comment #28 from Josef Moravec --- Created attachment 63331 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=63331&action=edit Bug 17006: (follow-up) Test for changing another user's password The previous patches work for changing your own password, but the tests are lacking a case where librarian attempts to change patron's password. This feature was unnoticed and not implemented. To test: 1. Run t/db_dependent/api/v1/patrons.t 2. Observe failing test 3. Proceed to next patch to fix the failing test Signed-off-by: Josef Moravec -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed May 10 12:32:16 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 10 May 2017 10:32:16 +0000 Subject: [Koha-bugs] [Bug 17006] REST API: add route to change patron's password In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17006 --- Comment #29 from Josef Moravec --- Created attachment 63332 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=63332&action=edit Bug 17006: (follow-up) Let librarians change patron's passwords This should obviously be part of this feature but was left unnoticed in the first patch. If user has "borrowers"-flag, they should be able to change patron's password without providing old password. To test: 1. Run t/db_dependent/api/v1/patrons.t 2. Observe failing test 3. Apply patch 4. Run t/db_dependent/api/v1/patrons.t 5. Observe passing test 6. Send PATCH request to http://library/api/v1/patrons/YYY/password where YYY is existing borrowernumber (borrowers flag required) and where YYY is not the same borrowernumber as your logged-in user's borrowernumber 7. Make sure that password was changed for YYY. You may find this useful for testing: curl -X PATCH http://library/api/v1/patrons/123/password \ --data '{"new_password":"1234"}' \ --cookie 'CGISESSID=055ca5a9a3ad3fb5052143bd015c1c10' Signed-off-by: Josef Moravec -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed May 10 12:32:02 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 10 May 2017 10:32:02 +0000 Subject: [Koha-bugs] [Bug 17006] REST API: add route to change patron's password In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17006 --- Comment #27 from Josef Moravec --- Created attachment 63330 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=63330&action=edit Bug 17006: Respect system preference "OpacPasswordChange" Allow patron to change their own password without borrowers-flag only if OpacPasswordChange system preference is enabled. To test: 1. Apply patch 2. Run t/db_dependent/api/v1/patrons.t 3. Set OpacPasswordChange system preference to "Don't allow". 4. Send PATCH request to http://library/api/v1/patrons/YYY/password where YYY is existing borrowernumber for a borrower that does not have any permissions 5. Observe permission error. 6. Set OpacPasswordChange system preference to "Allow". 7. Repeat step 4 and make sure that password was changed. Signed-off-by: Aleisha Amohia Signed-off-by: Josef Moravec -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed May 10 12:32:23 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 10 May 2017 10:32:23 +0000 Subject: [Koha-bugs] [Bug 17006] REST API: add route to change patron's password In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17006 --- Comment #30 from Josef Moravec --- Created attachment 63333 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=63333&action=edit Bug 17006: (follow-up) Use Koha::Exceptions for change password endpoint Koha::Exceptions are a nice way to handle erros and they should be used much more than they are now. This patch adds Koha::Exceptions into Koha::Patron->change_password_to sub and catches the exceptions in the controller. 1. Apply patch 2. Run t/db_dependent/api/v1/patrons.t 3. Send PATCH request to http://library/api/v1/patrons/YYY/password where YYY is existing borrowernumber (borrowers flag required) 4. Make sure that password was changed. 5. Try also too short password, and wrong current password and observe that errors are displayed appropriately. curl -X PATCH http://library/api/v1/patrons/123/password \ --data '{"current_password":"123", "new_password":"1234"}' \ --cookie 'CGISESSID=055ca5a9a3ad3fb5052143bd015c1c10' Signed-off-by: Josef Moravec -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed May 10 12:33:15 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 10 May 2017 10:33:15 +0000 Subject: [Koha-bugs] [Bug 17006] REST API: add route to change patron's password In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17006 Josef Moravec changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |Signed Off --- Comment #31 from Josef Moravec --- (In reply to Mirko Tietgen from comment #25) > I can't apply the last patch. > > Wende an: Bug 17006: (follow-up) Use Koha::Exceptions for change password > endpoint > fatal: sha1 information is lacking or useless (Koha/REST/V1/Patron.pm). > Dem Repository fehlen notwendige Blobs um auf einen 3-Wege-Merge > zur?ckzufallen. > Kann nicht zu 3-Wege-Merge zur?ckfallen. > Anwendung des Patches fehlgeschlagen bei 0001 Bug 17006: (follow-up) Use > Koha::Exceptions for change password endpoint Rebased on master -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed May 10 12:37:20 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 10 May 2017 10:37:20 +0000 Subject: [Koha-bugs] [Bug 18340] Progress bar length is wrong In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18340 Nick Clemens changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed May 10 12:37:23 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 10 May 2017 10:37:23 +0000 Subject: [Koha-bugs] [Bug 18340] Progress bar length is wrong In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18340 Nick Clemens changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #61841|0 |1 is obsolete| | --- Comment #3 from Nick Clemens --- Created attachment 63334 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=63334&action=edit Bug 18340: Fix progress bar length The progress bar (for background jobs) should be fully filled when 100% is hit, right? :) It has been introduced quite long time ago when the size of the progress bar has been changed from 150 to 200px, and the code has been refactored. Test plan: Launch a big modification/deletion of records/items in a batch. You should see the progress bar progressing to 100 and reach 100! Signed-off-by: Josef Moravec Signed-off-by: Nick Clemens -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed May 10 12:47:52 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 10 May 2017 10:47:52 +0000 Subject: [Koha-bugs] [Bug 1707] Search for patron '%' returns all results In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=1707 --- Comment #13 from Jonathan Druart --- We cannot really know the search has been truncated. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed May 10 12:48:25 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 10 May 2017 10:48:25 +0000 Subject: [Koha-bugs] [Bug 1707] Search for patron '%' returns all results In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=1707 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|jonathan.druart at bugs.koha-c |koha-bugs at lists.koha-commun |ommunity.org |ity.org -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Wed May 10 12:54:04 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 10 May 2017 10:54:04 +0000 Subject: [Koha-bugs] [Bug 15438] Checking out an on-hold item sends holder' s borrowernumber in AF (screen message) field. In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15438 --- Comment #22 from Nick Clemens --- (In reply to Colin Campbell from comment #21) > That should be governed by the system preference can you confirm how thats > set Both prefs below are set to 'Don't Allow' AllowItemsOnHoldCheckout AllowItemsOnHoldCheckoutSCO Before the patch, checkout is denied After the patch, checkout is successful -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed May 10 13:05:50 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 10 May 2017 11:05:50 +0000 Subject: [Koha-bugs] [Bug 1707] Search for patron '%' returns all results In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=1707 --- Comment #14 from Nick Clemens --- Created attachment 63335 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=63335&action=edit Bug 1707 (QA Followup) Add a warning that attribute searches will be truncated -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed May 10 13:06:39 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 10 May 2017 11:06:39 +0000 Subject: [Koha-bugs] [Bug 1707] Search for patron '%' returns all results In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=1707 --- Comment #15 from Nick Clemens --- (In reply to Jonathan Druart from comment #13) > We cannot really know the search has been truncated. True, but in that case we can just always warn - if we are going to have a hardcoded limit it just needs to be announced -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Wed May 10 13:18:08 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 10 May 2017 11:18:08 +0000 Subject: [Koha-bugs] [Bug 17006] REST API: add route to change patron's password In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17006 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |https://bugs.koha-community | |.org/bugzilla3/show_bug.cgi | |?id=18298 CC| |jonathan.druart at bugs.koha-c | |ommunity.org -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed May 10 13:18:08 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 10 May 2017 11:18:08 +0000 Subject: [Koha-bugs] [Bug 18298] Enforce password complexity In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18298 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |https://bugs.koha-community | |.org/bugzilla3/show_bug.cgi | |?id=17006 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed May 10 13:24:17 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 10 May 2017 11:24:17 +0000 Subject: [Koha-bugs] [Bug 18554] Adjust a few typos including responsability In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18554 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed May 10 13:24:21 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 10 May 2017 11:24:21 +0000 Subject: [Koha-bugs] [Bug 18554] Adjust a few typos including responsability In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18554 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #63268|0 |1 is obsolete| | --- Comment #5 from Jonathan Druart --- Created attachment 63336 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=63336&action=edit Bug 18554: Adjust a few typos including responsability typo responsability typo defautl in authorities.pref typo reveived in t/db_dependent/Acquisition.t typo ;; in advance_notices.pl typo Stopping in restart_indexer (koha-indexer) typo instutitional in moremember.pl typo Corretly (Biblio.t) typo periodicy in help serials Signed-off-by: Marcel de Rooy Signed-off-by: Marc V?ron Signed-off-by: Jonathan Druart -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed May 10 13:26:07 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 10 May 2017 11:26:07 +0000 Subject: [Koha-bugs] [Bug 17818] Duplicating a subfield yields an empty subfield tag [follow-up ] In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17818 Julian Maurice changed: What |Removed |Added ---------------------------------------------------------------------------- Status|REOPENED |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed May 10 13:26:17 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 10 May 2017 11:26:17 +0000 Subject: [Koha-bugs] [Bug 17818] Duplicating a subfield yields an empty subfield tag [follow-up ] In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17818 Julian Maurice changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed May 10 13:26:24 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 10 May 2017 11:26:24 +0000 Subject: [Koha-bugs] [Bug 17818] Duplicating a subfield yields an empty subfield tag [follow-up ] In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17818 Julian Maurice changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed May 10 13:26:38 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 10 May 2017 11:26:38 +0000 Subject: [Koha-bugs] [Bug 17818] Duplicating a subfield yields an empty subfield tag [follow-up ] In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17818 Julian Maurice changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to Stable --- Comment #10 from Julian Maurice --- Pushed to 3.22.x for 3.22.21 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed May 10 13:32:38 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 10 May 2017 11:32:38 +0000 Subject: [Koha-bugs] [Bug 1707] Search for patron '%' returns all results In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=1707 --- Comment #16 from Jonathan Druart --- (In reply to Nick Clemens from comment #15) > (In reply to Jonathan Druart from comment #13) > > We cannot really know the search has been truncated. > > True, but in that case we can just always warn - if we are going to have a > hardcoded limit it just needs to be announced Yes but the note is wrong, and will be hard to make it correct :) Note you added says "Note: Patron attribute searching is enabled, to avoid memory issues a limit of 100 patrons will be returned during "standard" searches" If you are searching for a pattern that is used 250x in patron attribute, and 100x in other standard fields, we will certainly get less 100 results even if the whole set would have been 100. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Wed May 10 13:54:07 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 10 May 2017 11:54:07 +0000 Subject: [Koha-bugs] [Bug 18560] RSS Feed link from OPAC shelves is broken In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18560 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |jonathan.druart at bugs.koha-c | |ommunity.org Status|Signed Off |Failed QA --- Comment #4 from Jonathan Druart --- Mark, You are not allowed to call _result outside of Koha::* Actually you do not need to retrieve the author and the title, they are both returned by GetBiblioData few lines above. And actually I do not understand this "if rss" conditional block, it looks useless. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed May 10 13:54:44 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 10 May 2017 11:54:44 +0000 Subject: [Koha-bugs] [Bug 18560] RSS Feed link from OPAC shelves is broken In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18560 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Severity|minor |major -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed May 10 14:14:13 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 10 May 2017 12:14:13 +0000 Subject: [Koha-bugs] [Bug 17925] Disable debugging in reports/bor_issues_top.pl In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17925 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed May 10 14:14:17 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 10 May 2017 12:14:17 +0000 Subject: [Koha-bugs] [Bug 17925] Disable debugging in reports/bor_issues_top.pl In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17925 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #63316|0 |1 is obsolete| | --- Comment #7 from Jonathan Druart --- Created attachment 63337 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=63337&action=edit Bug 17925: Disable debugging in reports/bor_issues_top.pl Remove setting $debug to 1. This prevents creation of file tmp/bor_issues_top.debug.log. Enable warnings pragma. Resolve a uninitialized warning on $sep like: Use of uninitialized value $CGI::Compile::ROOT::usr_share_koha_masterclone_reports_bor_issues_top_2epl::sep in string eq at /usr/share/koha/masterclone/reports/bor_issues_top.pl line 66. Test plan: Restart Plack (as you always do when testing). Remove file /tmp/bor_issues_top.debug.log. Open Reports/Patrons with the most checkouts. Check if the file in /tmp has not been created again. Check the log for warnings after you restarted Plack. Signed-off-by: Marcel de Rooy Signed-off-by: Mason James Signed-off-by: Jonathan Druart -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed May 10 14:21:17 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 10 May 2017 12:21:17 +0000 Subject: [Koha-bugs] [Bug 16515] Did you mean? links don't wrap on smaller screens In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16515 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed May 10 14:21:22 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 10 May 2017 12:21:22 +0000 Subject: [Koha-bugs] [Bug 16515] Did you mean? links don't wrap on smaller screens In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16515 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #63128|0 |1 is obsolete| | Attachment #63317|0 |1 is obsolete| | --- Comment #9 from Jonathan Druart --- Created attachment 63338 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=63338&action=edit Bug 16515 - Did you mean? links don't wrap on smaller screens This patch tweaks some CSS in the OPAC to give the "Did you mean" block better layout on smaller screens. To test, apply the patch and process LESS files. Enable "Did you mean" plugins for the OPAC in Administration. Perform a search in the OPAC and confirm that the "Did you mean" block looks correct. Resize your browser to various widths and confirm that the block handles all sizes well. Signed-off-by: Jonathan Druart -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed May 10 14:21:51 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 10 May 2017 12:21:51 +0000 Subject: [Koha-bugs] [Bug 16515] Did you mean? links don't wrap on smaller screens In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16515 --- Comment #10 from Jonathan Druart --- Created attachment 63339 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=63339&action=edit Bug 16515 [Generated CSS] Did you mean? links don't wrap on smaller screens Processed and minified CSS. Works as expected and looks much tidier now. Signed-off-by: Dilan Johnpulle Signed-off-by: Jonathan Druart -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed May 10 14:21:58 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 10 May 2017 12:21:58 +0000 Subject: [Koha-bugs] [Bug 10382] collection not returning to null when removed from course reserves In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10382 Nick Clemens changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |nick at bywatersolutions.com Assignee|kyle at bywatersolutions.com |alex.arnaud at biblibre.com -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed May 10 14:39:46 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 10 May 2017 12:39:46 +0000 Subject: [Koha-bugs] [Bug 18560] RSS Feed link from OPAC shelves is broken In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18560 M. Tompsett changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed May 10 14:39:49 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 10 May 2017 12:39:49 +0000 Subject: [Koha-bugs] [Bug 18560] RSS Feed link from OPAC shelves is broken In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18560 M. Tompsett changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #63286|0 |1 is obsolete| | --- Comment #5 from M. Tompsett --- Created attachment 63340 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=63340&action=edit Bug 18560: RSS link in opac shelves is broken Removed pointless code. TEST PLAN --------- 1) have books entered 2) log in create a list 3) add books to list 4) display list 5) click the RSS link button. -- bad HASH error. 6) apply patch 7) repeat steps 4&5 -- readble junk without error messages. 8) run koha qa test tools -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed May 10 14:41:31 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 10 May 2017 12:41:31 +0000 Subject: [Koha-bugs] [Bug 18560] RSS Feed link from OPAC shelves is broken In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18560 --- Comment #6 from M. Tompsett --- (In reply to Jonathan Druart from comment #4) > You are not allowed to call _result outside of Koha::* Sorry, was just looking for a quick fix. > Actually you do not need to retrieve the author and the title, they are both > returned by GetBiblioData few lines above. Confirmed. > And actually I do not understand this "if rss" conditional block, it looks > useless. Patch revised accordingly. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed May 10 15:11:54 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 10 May 2017 13:11:54 +0000 Subject: [Koha-bugs] [Bug 18568] New: blog Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18568 Bug ID: 18568 Summary: blog Change sponsored?: --- Product: Project Infrastructure Version: unspecified Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Continuous Integration Assignee: tomascohen at gmail.com Reporter: hamidarmy at gmail.com http://parsablog.com/ -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed May 10 15:12:04 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 10 May 2017 13:12:04 +0000 Subject: [Koha-bugs] [Bug 18055] Speed up '00-strict.t' test In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18055 Josef Moravec changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed May 10 15:12:08 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 10 May 2017 13:12:08 +0000 Subject: [Koha-bugs] [Bug 18055] Speed up '00-strict.t' test In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18055 Josef Moravec changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #59902|0 |1 is obsolete| | --- Comment #24 from Josef Moravec --- Created attachment 63341 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=63341&action=edit [SIGNED-OFF] Bug 18055 - Speed up '00-strict.t' test, with Parallel::ForkManager to test... 1/ run 00-strict.t test, (16.5 mins on a 4xcpu system) $ time prove t/db_dependent/00-strict.t ... Files=1, Tests=654, 994 wallclock secs ( 0.19 usr 0.04 sys + 873.40 cusr 116.20 csys = 989.83 CPU) Result: PASS real 16m34.104s 2/ apply patch 3/ install Parallel::ForkManager package $ sudo apt-get install libparallel-forkmanager-perl libsys-cpu-perl 4/ run 00-strict.t test again, (now 6 mins.. much faster) $ time prove t/db_dependent/00-strict.t ... Files=1, Tests=654, 364 wallclock secs ( 0.07 usr 0.01 sys + 1159.20 cusr 153.41 csys = 1312.69 CPU) Result: PASS real 6m4.355s Signed-off-by: Josef Moravec -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed May 10 15:14:28 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 10 May 2017 13:14:28 +0000 Subject: [Koha-bugs] [Bug 18568] blog In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18568 --- Comment #1 from hamidarmy --- http://parsablog.com/ http://iaoa.ir/ http://parsablog.com/backlink/ http://parsablog.com/register http://www.dayaneshop.ir/ http://payeganshop.ir/ http://bloglinks.ir/ http://flyblog.ir/ http://createablog.ir/ -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed May 10 15:32:07 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 10 May 2017 13:32:07 +0000 Subject: [Koha-bugs] [Bug 18569] New: Quick add patron will not copy over details from cities and towns pull down into patron details Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18569 Bug ID: 18569 Summary: Quick add patron will not copy over details from cities and towns pull down into patron details Change sponsored?: --- Product: Koha Version: 16.11 Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Patrons Assignee: nick at bywatersolutions.com Reporter: kelly at bywatersolutions.com QA Contact: testopia at bugs.koha-community.org CC: gmcharlt at gmail.com, kelly at bywatersolutions.com, kyle.m.hall at gmail.com When using the quick add patron option in koha 16.11 : If a library has cities and towns pre-populated in a drop down list and has added this field into the quick add patron form this information will not copy into the full patron form after saving. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed May 10 15:34:00 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 10 May 2017 13:34:00 +0000 Subject: [Koha-bugs] [Bug 17712] Move availability calculation to the Koha namespace In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17712 Benjamin Rokseth changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |benjamin.rokseth at kul.oslo.k | |ommune.no --- Comment #42 from Benjamin Rokseth --- Sorry to see you're so alone on this, as it sounds like a very good idea! I will sign it off, though I have some concerns, particularly on performance. Passing koha objects around this way seems very javaish, and I don't really see the point, if all you really need is foreign keys. But then again, its circumstantial, and could be remedied at a later stage if needed. And it's a bit unfair on such a large codechange, which is actually relatively easy to read and follow. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed May 10 15:35:32 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 10 May 2017 13:35:32 +0000 Subject: [Koha-bugs] [Bug 18536] Generating CSV using profile in serials late issues doesn' t work as described In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18536 Josef Moravec changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #63058|0 |1 is obsolete| | --- Comment #2 from Josef Moravec --- Created attachment 63342 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=63342&action=edit Bug 18536: Generating CSV using profile in serials late issues doesn't work as described Description on editing csv profiles says: "You can also use your own headers (instead of the ones from Koha) by prefixing the field name with an header, followed by the equal sign." So the header should be optional, but in fact it's mandatory. Also the regular expression to cut table name from beginning of db column is not right. Test plan: 0. Don't apply the patch 1. Make two CSV profiles for exporting late issues a) SUPPLIER=aqbooksellers.name|TITLE=subscription.title|ISSUENUMBER=serial.serialseq|LATE SINCE=serial.planneddate b) aqbooksellers.name|TITLE=subscription.title|ISSUE NUMBER=serial.serialseq|LATE SINCE=serial.planneddate 2. Export late issues, profile a) works as expected, profile b) doesn't 3. Apply the patch 4. Both profiles should work -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Wed May 10 15:36:43 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 10 May 2017 13:36:43 +0000 Subject: [Koha-bugs] [Bug 18536] Generating CSV using profile in serials late issues doesn' t work as described In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18536 Josef Moravec changed: What |Removed |Added ---------------------------------------------------------------------------- Severity|enhancement |minor -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed May 10 15:38:03 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 10 May 2017 13:38:03 +0000 Subject: [Koha-bugs] [Bug 10382] collection not returning to null when removed from course reserves In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10382 Alex Sassmannshausen changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |alex.sassmannshausen at ptfs-e | |urope.com --- Comment #27 from Alex Sassmannshausen --- (In reply to Alex Arnaud from comment #25) > (In reply to Jonathan Druart from comment #24) > > This stuff smells like a very bad codding pattern. > > Could not we use empty string and undef/NULL to handle empty values? > > Hello Jonathan, > > I don't really see how to do that. > > If you create a course item this way: > > my $ci_id2 = ModCourseItem( > itemnumber => $itemnumber, > itype => '', > ccode => 'BOOK', > holdingbranch => '', > location => '', > ); > > or this way > > my $ci_id2 = ModCourseItem( > itemnumber => $itemnumber, > ccode => 'BOOK', > holdingbranch => '', > location => '', > ); > > This results to the same when getting the course with GetCourseItem: itype > is undef. > Empty or null value are retrieved the same and we are unable to know if the > value has changed or not. Yeah, it looks to me like: - either you need to add a boolean column for each field that can be changed when added to course-modifier to indicate the value was changed - you add a column with a parseable string that indicates which fields were changed - you use a magic string like '' to indicate absence of change - you add a linking table, which has an entry for each itemnumber and each changed column The latter means we would remove the ccode, holdingbranch, location, itype fields from the course_items table, and would solve the code smell but might be more work to implement. Other than that, I recon the '' is the most workable solution. my 2?, Alex -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed May 10 15:39:43 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 10 May 2017 13:39:43 +0000 Subject: [Koha-bugs] [Bug 17712] Move availability calculation to the Koha namespace In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17712 Benjamin Rokseth changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #62719|0 |1 is obsolete| | --- Comment #43 from Benjamin Rokseth --- Created attachment 63343 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=63343&action=edit Bug 17712: Add new Koha::Exceptions To describe problems or notes to availability, we will be using Koha::Exceptions. This patch adds many useful Koha::Exceptions that we can use for this purpose. Signed-off-by: Benjamin Rokseth -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed May 10 15:39:51 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 10 May 2017 13:39:51 +0000 Subject: [Koha-bugs] [Bug 17712] Move availability calculation to the Koha namespace In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17712 Benjamin Rokseth changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #62720|0 |1 is obsolete| | --- Comment #44 from Benjamin Rokseth --- Created attachment 63344 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=63344&action=edit Bug 17712: Koha::Availability, a base for availability information This patch adds a new class, Koha::Availability, which is designed to contain availability information for each type of availability in an uniform way. Because of this, Koha::Availability has no actual availability calculation logic, but simply methods to get and set availability information into the object. With such design, we can next create new classes Koha::Availability::Hold and Koha::Availability::Checkout and let them inherit Koha::Availability so that they are able to handle availaibility information in an uniform way. Koha::Availability::Hold Koha::Availability::Checkout | | \_________________________________/ | Koha::Availability Koha::Availability can represent four levels of availability statuses: 1. available 2. available, with an additional note 3. available, but requires confirmation 4. unavailable Additional notes, reasons for a need to confirm and reasons for unavailabilities are kept in a HASHref, where each value in my proposal is a Koha::Exceptions::*. This allows us to easily store any additional data directly into the reason. For example, if we want to check biblio availability for hold and find out it is not available, the HASHref for unavailabilities has a Koha::Exceptions::Patron::Debt that contains parameters "current_outstanding" and "max_outstanding" which lets us pick up the information easily later on without making new queries. To test: 1. Run t/Koha/Availability.t Signed-off-by: Benjamin Rokseth -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed May 10 15:39:57 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 10 May 2017 13:39:57 +0000 Subject: [Koha-bugs] [Bug 17712] Move availability calculation to the Koha namespace In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17712 Benjamin Rokseth changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #62721|0 |1 is obsolete| | --- Comment #45 from Benjamin Rokseth --- Created attachment 63345 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=63345&action=edit Bug 17712: Add base for item and biblio availability This patch adds two new classes: - Koha::Biblio::Availability - Koha::Item::Availability These classes represent biblio- and item-level availabilities and the purpose of this patch is simply to provide constructors that validate given biblio/item and patron parameters. Hold / checkout / search view availabilities (the actual answers to availability) will be provided in the next patches. To test: 1. Run t/db_dependent/Koha/Item/Availability.t 2. Run t/db_dependent/Koha/Biblio/Availability.t Signed-off-by: Benjamin Rokseth -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed May 10 15:40:04 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 10 May 2017 13:40:04 +0000 Subject: [Koha-bugs] [Bug 17712] Move availability calculation to the Koha namespace In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17712 Benjamin Rokseth changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #62722|0 |1 is obsolete| | --- Comment #46 from Benjamin Rokseth --- Created attachment 63346 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=63346&action=edit Bug 17712: Centralize availability-related checks There are some problems to our current approach for "availability" which makes it complicated to integrate with e.g. REST API. Firstly, there has been no unified way of representing reasons for unavailability. Previously, each implementation of availability calculation has chosen its own way for describing the reasons. For example, CanItemBeReserved string "ageRestricted" vs. CanBookBeIssued key "AGE_RESTRICTION" in a HASHref. Secondly, some of the availability logic is contained outside centralized methods like CanItemBeReserved which is missing checks e.g. for maxreserves (checked instead in opac-reserve.pl) and patron fines. Perhaps this issue could be fixed in another Bug, but I propose we squash it at the same time with this Bug. Currently, because of this, we will not get reliable responses to holdability from CanItemBeReserved alone. This causes problems for API integration where we need to be able to describe the reason in an uniform way and additionally provide information on what needs to be done to fix the issue. Also, we do not want to duplicate all the external checks from .pl files into our REST controllers. Instead of modifying the old methods, I propose a new structure for the whole availability-problem and let us deal with proper "status-codes" to easily integrate availability & additional availability-related information into e.g. REST API. My proposal is an approach to centralize the availability-related checks and have them return uniform reasons to describe reasons for availability problems. Ultimately, we could ask availability something like this: my $holdability = Koha::Availability::Hold->biblio({ biblio => $biblio, patron => $patron, to_branch => 'CPL', })->in_opac; ...and $holdability->unavailabilities HASHref would contain Koha::Exceptions possibily with additional parameters to let us know why this biblio is not holdable in OPAC. This patch adds all availability related logic with centralization in mind. From these individual methods we are able to construct full availability queries in order to determine if something is actually available in some way and also describe the problems with the help of Koha::Exceptions. Since availability is a mixture of multiple different smaller checks from multiple categories like item, patron, issuing rules, etc, they can be categorized into their own subclasses. This lets us centralize availability-related methods per category into their own modules. To test: 1. prove t/db_dependent/Koha/Availability/Checks/* Signed-off-by: Benjamin Rokseth -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed May 10 15:40:12 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 10 May 2017 13:40:12 +0000 Subject: [Koha-bugs] [Bug 17712] Move availability calculation to the Koha namespace In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17712 Benjamin Rokseth changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #62723|0 |1 is obsolete| | --- Comment #47 from Benjamin Rokseth --- Created attachment 63347 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=63347&action=edit Bug 17712: Item availability for hold Adds Koha::Item::Availability::Hold class for item hold availability. This patch adds item holdability queries in two contexts: 1. in_opac (perspective of patron themselves) 2. in_intranet (perspective of a librarian to patron) Returns a Koha::Item::Availability::Hold object, which contains all information on availability for hold in that context. This may include additional notes, reasons to ask for confirmation or reasons for unavailability. Example: To find out if patron can hold an item in OPAC, we will write: my $availability = Koha::Availability::Hold->item({ patron => $patron, item => $item, to_branch => $branchcode, # transfer allowed from holdingbranch to to_branch? })->in_opac; if ($availability->available) { # yes! } else { foreach my $reason (keys %{$availability->unavailabilities}) { # each reason for unavailability } foreach my $reason (keys %{$availability->confirmations}) { # each reason that requires confirmation } foreach my $reason (keys %{$availability->notes}) { # each additional note } } Signed-off-by: Benjamin Rokseth -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed May 10 15:40:22 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 10 May 2017 13:40:22 +0000 Subject: [Koha-bugs] [Bug 17712] Move availability calculation to the Koha namespace In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17712 Benjamin Rokseth changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #62724|0 |1 is obsolete| | --- Comment #48 from Benjamin Rokseth --- Created attachment 63348 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=63348&action=edit Bug 17712: Biblio availability for hold Usage: $holdability = Koha::Availability::Hold->biblio({ biblio => $biblio, patron => $patron, to_branch => "CPL", })->in_opac; if ($holdability->available) { # yup! # arrayref of Koha::Item::Availability::Hold -objects: # 1. all available items (items may contain confirmations / notes) my $item_availabilities = $holdability->item_availabilities; # 2. all unavailable items my $item_unavailabilities = $holdability->item_unavailabilites; } Returns a Koha::Biblio::Availability::Hold -object. Signed-off-by: Benjamin Rokseth -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed May 10 15:40:29 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 10 May 2017 13:40:29 +0000 Subject: [Koha-bugs] [Bug 17712] Move availability calculation to the Koha namespace In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17712 Benjamin Rokseth changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #62725|0 |1 is obsolete| | --- Comment #49 from Benjamin Rokseth --- Created attachment 63349 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=63349&action=edit Bug 17712: Item availability for checkout Usage: my $issuability = Koha::Availability::Checkout->item({ item => $item, patron => $patron, duedate => $duedate # custom due date })->in_intranet; if ($issuability->available) { # yes! } else { # not available for checkout. $issuability contains all the reasons for this. } Signed-off-by: Benjamin Rokseth -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed May 10 15:40:37 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 10 May 2017 13:40:37 +0000 Subject: [Koha-bugs] [Bug 17712] Move availability calculation to the Koha namespace In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17712 Benjamin Rokseth changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #62726|0 |1 is obsolete| | --- Comment #50 from Benjamin Rokseth --- Created attachment 63350 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=63350&action=edit Bug 17712: Item and biblio availability in search context Usage: my $availability = Koha::Availability::Search->item({ item => $item, })->in_opac; if ($availability->available) { # yes } Signed-off-by: Benjamin Rokseth -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed May 10 15:43:51 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 10 May 2017 13:43:51 +0000 Subject: [Koha-bugs] [Bug 17712] Move availability calculation to the Koha namespace In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17712 Benjamin Rokseth changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off --- Comment #51 from Benjamin Rokseth --- tests pass. works as described. Ran some manual tests by perl evaluated code -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed May 10 16:31:55 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 10 May 2017 14:31:55 +0000 Subject: [Koha-bugs] [Bug 17712] Move availability calculation to the Koha namespace In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17712 --- Comment #52 from Lari Taskula --- (In reply to Benjamin Rokseth from comment #42) > Sorry to see you're so alone on this, as it sounds like a very good idea! I > will sign it off, though I have some concerns, particularly on performance. > > Passing koha objects around this way seems very javaish, and I don't really > see the point, if all you really need is foreign keys. > > But then again, its circumstantial, and could be remedied at a later stage > if needed. And it's a bit unfair on such a large codechange, which is > actually relatively easy to read and follow. Thanks for the support, new ideas, and the sign-off, Benjamin, and glad to hear from you! I found this a very challenging project and surely there is room for further performance improvements as well as other changes - under heavy pressure some of the choices made may have not been optimal. Follow-ups are welcome :) BTW, this is also under busy testing by our librarians and in the following days I'll have a desk-full of test reports and possibly follow-ups coming in for this Bug :) -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed May 10 16:36:33 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 10 May 2017 14:36:33 +0000 Subject: [Koha-bugs] [Bug 14608] HEA : add possibility of sharing usage statistics in Administration page In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14608 --- Comment #60 from Julian Maurice --- Pushed to 3.22.x for 3.22.21 (required for bug 18066) -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed May 10 16:36:45 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 10 May 2017 14:36:45 +0000 Subject: [Koha-bugs] [Bug 18066] Hea - Version 2 In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18066 --- Comment #54 from Julian Maurice --- Pushed to 3.22.x for 3.22.21 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed May 10 16:43:09 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 10 May 2017 14:43:09 +0000 Subject: [Koha-bugs] [Bug 18547] On shelf holds allowed > "If all unavailable" ignores default hold policy In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18547 --- Comment #4 from Claudio --- (In reply to Alex Buckley from comment #2) > Created attachment 63227 [details] [review] > Bug 18547 - On shelf holds allowed > "If all unavailable" ignores default > hold policy > > If in the circ rules matrix you set "On shelf holds allowed" to "If all > unavailable", > default hold policy "From home library" is ignored. > > Test plan: > > - Have a test user from one branch (eg Centerville) > > - Set "On shelf holds allowed" to "If all unavailable" for your patron and > item > category (or everyone and everything) > - For "Default checkout, hold and return policy", set hold policy to "From > home library" > -> make sure there is no "Default holds policy by item type" to override > the setting > > - Have two items for a record. > 1. An item with home branch same as test user (eg Centerville) > -> check this item out to somebody else > 2. an item with a different home branch (eg Fairfield) > -> available, not checked out > - Try to place a hold for your test user. Does not work. > > - Apply the patch > - Try to place a hold. Should work now. > > Followed test plan, worked as intended > Signed-off-by: Alex Buckley Alex, this is a great fix but does not work. I cannot figure the reason... -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed May 10 16:45:32 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 10 May 2017 14:45:32 +0000 Subject: [Koha-bugs] [Bug 18376] authority framework creation fails under Plack In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18376 --- Comment #2 from Owen Leonard --- > You may not be able to reproduce the error with plack. I could not in kohadevbox. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed May 10 16:55:44 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 10 May 2017 14:55:44 +0000 Subject: [Koha-bugs] [Bug 18570] New: Password recovery e-mail only sent after message queue is processed Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18570 Bug ID: 18570 Summary: Password recovery e-mail only sent after message queue is processed Change sponsored?: --- Product: Koha Version: unspecified Hardware: All OS: All Status: NEW Severity: normal Priority: P5 - low Component: Authentication Assignee: gmcharlt at gmail.com Reporter: jens.weber at phsh.ch QA Contact: testopia at bugs.koha-community.org CC: dpavlin at rot13.org The password recovery process triggers an e-mail to the patron with a link to reset his or her password. This e-mail is put into the message queue like any other notification (e.g. filled HOLD) and hence only sent the next time process_message_queue.pl is triggered with the time setting in cron.d (the default here being every 15 minutes!). This behavior is not what a user would expect from such a function (especially not with the wording from opac-password-recovery.tt: 'An email **has been sent**'). Accordingly -- even though this is not a malfunction -- I flagged this a bug and not an enhancement, as from the point of view of the patron it must seem to be a bug/problem if the e-mail does not arrive in a normal time span. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed May 10 17:01:31 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 10 May 2017 15:01:31 +0000 Subject: [Koha-bugs] [Bug 18547] On shelf holds allowed > "If all unavailable" ignores default hold policy In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18547 --- Comment #5 from Mirko Tietgen --- (In reply to Claudio from comment #4) > Alex, this is a great fix but does not work. I cannot figure the reason... We use this patch in production and it works. Maybe you have another problem related to this feature which is not covered by the patch. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed May 10 17:05:22 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 10 May 2017 15:05:22 +0000 Subject: [Koha-bugs] [Bug 18566] Staff client should always show purchase suggestion In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18566 --- Comment #1 from Owen Leonard --- I think there are two related problems here: 1) There isn't a separate preference for enabling and disabling suggestions in the OPAC and staff client. Having that would allow you to enable staff-mediated suggestions through the staff client but not OPAC suggestions. 2) Turning off suggestions in system preferences hides suggestion management in Acquisitions and the OPAC, but not from the patron tabs in circulation. As long as there is only one suggestions system preference I would think turning it off would hide the option of accessing suggestions-related pages everywhere, including members/purchase-suggestions.pl -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Wed May 10 17:11:49 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 10 May 2017 15:11:49 +0000 Subject: [Koha-bugs] [Bug 18570] Password recovery e-mail only sent after message queue is processed In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18570 Jens Weber changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|gmcharlt at gmail.com |koha-bugs at lists.koha-commun | |ity.org Component|Authentication |Notices -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Wed May 10 17:13:43 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 10 May 2017 15:13:43 +0000 Subject: [Koha-bugs] [Bug 17936] Search bar not aligned on right in small screen sizes In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17936 Nick Clemens changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed May 10 17:13:47 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 10 May 2017 15:13:47 +0000 Subject: [Koha-bugs] [Bug 17936] Search bar not aligned on right in small screen sizes In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17936 Nick Clemens changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #63132|0 |1 is obsolete| | Attachment #63133|0 |1 is obsolete| | --- Comment #5 from Nick Clemens --- Created attachment 63351 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=63351&action=edit Bug 17936 - Search bar not aligned on right in small screen sizes This patch tweaks the OPAC's CSS so that the main search form's fields have consistent width at small screen sizes. To test, apply the patch and process the LESS files. View the OPAC main page at a very narrow browser width and confirm that the text field width matches that of the dropdown and button. Signed-off-by: Marc V?ron Signed-off-by: Nick Clemens -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed May 10 17:13:51 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 10 May 2017 15:13:51 +0000 Subject: [Koha-bugs] [Bug 17936] Search bar not aligned on right in small screen sizes In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17936 --- Comment #6 from Nick Clemens --- Created attachment 63352 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=63352&action=edit Bug 17936 [Generated CSS] Search bar not aligned on right in small screen sizes Processed and minified CSS. Signed-off-by: Marc V?ron Signed-off-by: Nick Clemens -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed May 10 17:17:50 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 10 May 2017 15:17:50 +0000 Subject: [Koha-bugs] [Bug 17550] Display initials in patron search autocomplete In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17550 Owen Leonard changed: What |Removed |Added ---------------------------------------------------------------------------- Summary|Display additional patron |Display initials in patron |data in patron suggestion |search autocomplete |form | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed May 10 17:19:39 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 10 May 2017 15:19:39 +0000 Subject: [Koha-bugs] [Bug 18389] bulkmarcimport.pl does not take notice of MARC modification templates In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18389 Jon Knight changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #61907|0 |1 is obsolete| | CC| |J.P.Knight at lboro.ac.uk --- Comment #1 from Jon Knight --- Created attachment 63353 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=63353&action=edit The same patch as above only generated within git and without touch existing whitespace formatting oddities in the script. When I mentioned this bug/patch on the Koha IRC channel originally I was told I needed to read up on how to submit bugs/patch because I'd done something wrong. I've read a load of wiki pages, etc now and I think the issue might have been that I tidied up the white space formatting in another part of the same script and didn't have the patch generated by git (rather I just used context diffing on our non-git installation). Hopefully this patch will find more favour. :-) -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed May 10 17:20:00 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 10 May 2017 15:20:00 +0000 Subject: [Koha-bugs] [Bug 18566] Staff client should always show purchase suggestion In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18566 --- Comment #2 from Vinod --- I tested and found the link is however working and shows suggestion management if directly we give URL of suggestion management even it is off in system preference. There is some problematic situation as i tested: 1. Created suggestion on user behalf through staff interfacewhen system preference is off. 2. Came to Koha staff interface and selected the displayed pending suggestion. 3. Made this suggestion status as checked and came back to staff home page. 4. Now i wish to find above title for further process but did not able to locate only it can be seen again in concern member detail page ( Point no. 1 above) 5. I directly given URL of suggestion management and found on the screen which showed me as usual options of suggestion management and title status as checked. I think few more options is needed in this regard. 1. Display of suggestion management always in staff client as well as in member detail page only through staff interface. 2. Purchase suggestion is needed by category of members and that can be made in circulation privileges OR category of member i.e. Purchase suggestion allowed or not -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed May 10 17:27:24 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 10 May 2017 15:27:24 +0000 Subject: [Koha-bugs] [Bug 18571] New: koha-conf.xml should include ES entry Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18571 Bug ID: 18571 Summary: koha-conf.xml should include ES entry Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Packaging Assignee: koha-bugs at lists.koha-community.org Reporter: tomascohen at gmail.com QA Contact: testopia at bugs.koha-community.org CC: mirko at abunchofthings.net Elasticsearch as a search engine has become a real option. Switching from Zebra into ES is syspref handled. Koha instances should get created with an ES config entry poiting to localhost:9200 to make it easier for users to try it. Advanced users (having external ES servers/clusters can tweak themselves the file, but we need to provide a working setup for regular users. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Wed May 10 17:27:33 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 10 May 2017 15:27:33 +0000 Subject: [Koha-bugs] [Bug 18571] koha-conf.xml should include ES entry In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18571 Tom?s Cohen Arazi changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|koha-bugs at lists.koha-commun |tomascohen at gmail.com |ity.org | -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed May 10 17:31:36 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 10 May 2017 15:31:36 +0000 Subject: [Koha-bugs] [Bug 18572] New: Improper branchcode set during OPAC renewal Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18572 Bug ID: 18572 Summary: Improper branchcode set during OPAC renewal Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: major Priority: P5 - low Component: OPAC Assignee: oleonard at myacpl.org Reporter: nick at bywatersolutions.com QA Contact: testopia at bugs.koha-community.org Bug 17781 fixed an inconsistency in renewals, but it broke functionality in the OPAC To recreate: 1 - Set 'OpacRenewalBranch' to 'OPACrenew' 2 - Renew an item via the OPAC 3 - Check the statistics table 4 - Branch will be the user's branch, not OPACrenew -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed May 10 17:32:09 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 10 May 2017 15:32:09 +0000 Subject: [Koha-bugs] [Bug 18572] Improper branchcode set during OPAC renewal In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18572 Nick Clemens changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |nick at bywatersolutions.com Depends on| |17781 Assignee|oleonard at myacpl.org |kyle at bywatersolutions.com Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17781 [Bug 17781] Improper branchcode set during renewal -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed May 10 17:32:09 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 10 May 2017 15:32:09 +0000 Subject: [Koha-bugs] [Bug 17781] Improper branchcode set during renewal In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17781 Nick Clemens changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |18572 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18572 [Bug 18572] Improper branchcode set during OPAC renewal -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed May 10 17:38:09 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 10 May 2017 15:38:09 +0000 Subject: [Koha-bugs] [Bug 18573] New: Error when adding anonymous suggestion in the OPAC Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18573 Bug ID: 18573 Summary: Error when adding anonymous suggestion in the OPAC Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: ASSIGNED Severity: major Priority: P5 - low Component: OPAC Assignee: jonathan.druart at bugs.koha-community.org Reporter: oleonard at myacpl.org QA Contact: testopia at bugs.koha-community.org I have enabled AnonSuggestions and defined a valid borrowernumber in AnonymousPatron. When I go to /cgi-bin/koha/opac-suggestions.pl?op=add I get an error: Template process failed: undef error - The method default is not covered by tests! at /home/vagrant/kohaclone/C4/Templates.pm line 121. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed May 10 17:41:56 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 10 May 2017 15:41:56 +0000 Subject: [Koha-bugs] [Bug 7317] Add an Interlibrary Loan Module to Circulation and OPAC In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7317 --- Comment #46 from Alex Sassmannshausen --- Created attachment 63354 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=63354&action=edit Bug 7317: Invoke `handle_commit_maybe` on custom capabilities. * ill/ill-requests.pl: Invoke `handle_commit_maybe` on custom capabilities in our controller to handle 'commit' stage. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed May 10 17:44:25 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 10 May 2017 15:44:25 +0000 Subject: [Koha-bugs] [Bug 18568] blog In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18568 Owen Leonard changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |RESOLVED Resolution|--- |INVALID -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed May 10 17:46:20 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 10 May 2017 15:46:20 +0000 Subject: [Koha-bugs] [Bug 18574] New: Clean Patron Records tool doesn' t limit to the selected library Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18574 Bug ID: 18574 Summary: Clean Patron Records tool doesn't limit to the selected library Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: critical Priority: P5 - low Component: Tools Assignee: gmcharlt at gmail.com Reporter: kyle at bywatersolutions.com QA Contact: testopia at bugs.koha-community.org The library selector simply does nothing because at some point the javascript that powers it was removed. This is very bad because the librarian may batch delete patrons assuming it is limiting by branch correctly and instead delete patrons for all the libraries! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed May 10 17:46:55 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 10 May 2017 15:46:55 +0000 Subject: [Koha-bugs] [Bug 18574] Clean Patron Records tool doesn' t limit to the selected library In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18574 Kyle M Hall changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|gmcharlt at gmail.com |kyle at bywatersolutions.com -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed May 10 17:49:19 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 10 May 2017 15:49:19 +0000 Subject: [Koha-bugs] [Bug 18574] Clean Patron Records tool doesn' t limit to the selected library In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18574 Kyle M Hall changed: What |Removed |Added ---------------------------------------------------------------------------- Patch complexity|--- |Trivial patch Status|NEW |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed May 10 17:49:21 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 10 May 2017 15:49:21 +0000 Subject: [Koha-bugs] [Bug 18574] Clean Patron Records tool doesn' t limit to the selected library In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18574 --- Comment #1 from Kyle M Hall --- Created attachment 63355 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=63355&action=edit Bug 18574 - Clean Patron Records tool doesn't limit to the selected library The library selector simply does nothing because at some point the javascript that powers it was removed. This is very bad because the librarian may batch delete patrons assuming it is limiting by branch correctly and instead delete patrons for all the libraries! Test Plan: 1) Note that the library pulldown on tools/cleanborrowers.pl does nothing 2) Apply this patch 3) Note that chaning the value in the pulldown now refreshed the page and sets the library correctly! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed May 10 17:49:24 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 10 May 2017 15:49:24 +0000 Subject: [Koha-bugs] [Bug 18568] blog In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18568 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |jonathan.druart at bugs.koha-c | |ommunity.org -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed May 10 18:00:08 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 10 May 2017 16:00:08 +0000 Subject: [Koha-bugs] [Bug 18569] Quick add patron will not copy over details from cities and towns pull down into patron details In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18569 Nick Clemens changed: What |Removed |Added ---------------------------------------------------------------------------- Version|16.11 |master -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed May 10 18:01:32 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 10 May 2017 16:01:32 +0000 Subject: [Koha-bugs] [Bug 18575] New: QueryFuzzy not enabled for Title search in Zebra Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18575 Bug ID: 18575 Summary: QueryFuzzy not enabled for Title search in Zebra Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Searching Assignee: gmcharlt at gmail.com Reporter: barton at bywatersolutions.com QA Contact: testopia at bugs.koha-community.org Prerequisite: Hitchhiker's Guide To the Galaxy is searchable in the catalog. To replicate: 1) Set the system preference QueryFuzzy to 'Enable' 2) Run the following search: ti: Hitchhikers Guide To the Galaxy This will fail. 3) A keyword search for Hitchhikers Guide To the Galaxy will get hits. Technical notes: I enabled 'request' logging in koha-conf.xml: none,fatal,warn,request In the zebra logs, I see the truncation attribute @attr 5=103 In the keyword search, but not in the title search. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed May 10 18:03:59 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 10 May 2017 16:03:59 +0000 Subject: [Koha-bugs] [Bug 18573] Error when adding anonymous suggestion in the OPAC In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18573 --- Comment #1 from Owen Leonard --- git bisect points to Bug 17847 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed May 10 18:12:31 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 10 May 2017 16:12:31 +0000 Subject: [Koha-bugs] [Bug 17847] Move C4::Koha::GetAuthvalueDropbox to Koha::AuthorisedValues In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17847 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |18573 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18573 [Bug 18573] Error when adding anonymous suggestion in the OPAC -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed May 10 18:12:31 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 10 May 2017 16:12:31 +0000 Subject: [Koha-bugs] [Bug 18573] Error when adding anonymous suggestion in the OPAC In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18573 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on| |17847 --- Comment #2 from Jonathan Druart --- On bug 17847, av-build-dropbox.inc has been updated for the intranet, not OPAC Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17847 [Bug 17847] Move C4::Koha::GetAuthvalueDropbox to Koha::AuthorisedValues -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed May 10 18:15:23 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 10 May 2017 16:15:23 +0000 Subject: [Koha-bugs] [Bug 18573] Error when adding anonymous suggestion in the OPAC In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18573 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed May 10 18:15:27 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 10 May 2017 16:15:27 +0000 Subject: [Koha-bugs] [Bug 18573] Error when adding anonymous suggestion in the OPAC In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18573 --- Comment #3 from Jonathan Druart --- Created attachment 63356 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=63356&action=edit Bug 18573: (bug 17847 follow-up) Update av-build-dropbox.inc for OPAC On bug 17847, av-build-dropbox.inc has been updated for the intranet, not OPAC There is only one call to av-build-dropbox.inc at the OPAC, from opac-suggestion.tt Test plan: Create a new suggestion, anonymous or with a logged in user => Without this patch you got Template process failed: undef error - The method default is not covered by tests! at /home/vagrant/kohaclone/C4/Templates.pm line 121. => With this patch applied you should see the item type dropdown list correctly filled -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed May 10 18:15:44 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 10 May 2017 16:15:44 +0000 Subject: [Koha-bugs] [Bug 18478] Hold Notices sent via SMS gateway fail In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18478 Lisette changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |lisetteslatah at gmail.com -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed May 10 18:19:20 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 10 May 2017 16:19:20 +0000 Subject: [Koha-bugs] [Bug 18569] Quick add patron will not copy over details from cities and towns pull down into patron details In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18569 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |ASSIGNED Depends on| |3534 CC| |jonathan.druart at bugs.koha-c | |ommunity.org Severity|enhancement |normal Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=3534 [Bug 3534] Patron quick add form -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed May 10 18:19:20 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 10 May 2017 16:19:20 +0000 Subject: [Koha-bugs] [Bug 3534] Patron quick add form In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=3534 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |18569 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18569 [Bug 18569] Quick add patron will not copy over details from cities and towns pull down into patron details -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed May 10 18:45:25 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 10 May 2017 16:45:25 +0000 Subject: [Koha-bugs] [Bug 12349] patron name on suggestions should be linked In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12349 --- Comment #1 from Owen Leonard --- Created attachment 63357 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=63357&action=edit Bug 18154 - Show card number in detailled suggestion pages This patch modifies the main suggestion management page to link patron names to their details rather than with a "mailto:" link. This patch also includes the following changes: - A fix for Bug 18154, Show card number in suggestion details view. - Changes for brevity to labels in the suggestion details & edit view. - Addition of the datepicker class to date fields in the suggestion edit view. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed May 10 18:45:22 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 10 May 2017 16:45:22 +0000 Subject: [Koha-bugs] [Bug 12349] patron name on suggestions should be linked In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12349 Owen Leonard changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff Patch complexity|--- |Small patch -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed May 10 18:47:41 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 10 May 2017 16:47:41 +0000 Subject: [Koha-bugs] [Bug 18154] Show card number in detailled suggestion pages In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18154 Owen Leonard changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |RESOLVED Resolution|--- |DUPLICATE --- Comment #1 from Owen Leonard --- I have submitted a patch on Bug 12349 which fulfills this request so I'm marking it a duplicate. *** This bug has been marked as a duplicate of bug 12349 *** -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Wed May 10 18:47:41 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 10 May 2017 16:47:41 +0000 Subject: [Koha-bugs] [Bug 12349] patron name on suggestions should be linked In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12349 Owen Leonard changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |alexandre.breton at ccsr.qc.ca --- Comment #2 from Owen Leonard --- *** Bug 18154 has been marked as a duplicate of this bug. *** -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Wed May 10 18:49:57 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 10 May 2017 16:49:57 +0000 Subject: [Koha-bugs] =?utf-8?q?=5BBug_11147=5D__Changes_on_the_=E2=80=9Cne?= =?utf-8?q?w_purchase_suggestion=E2=80=9D_page?= In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11147 Owen Leonard changed: What |Removed |Added ---------------------------------------------------------------------------- Resolution|--- |WONTFIX Status|NEW |RESOLVED -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed May 10 18:54:49 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 10 May 2017 16:54:49 +0000 Subject: [Koha-bugs] [Bug 15561] Add ability to charge cancelation fee from "Holds over" tab In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15561 Kyle M Hall changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |Signed Off -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed May 10 18:54:52 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 10 May 2017 16:54:52 +0000 Subject: [Koha-bugs] [Bug 15561] Add ability to charge cancelation fee from "Holds over" tab In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15561 Kyle M Hall changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #52906|0 |1 is obsolete| | Attachment #52908|0 |1 is obsolete| | Attachment #53724|0 |1 is obsolete| | --- Comment #20 from Kyle M Hall --- Created attachment 63358 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=63358&action=edit Bug 15561 - Add ability to charge cancelation fee from "Holds over" tab The fee set in ExpireReservesMaxPickUpDelayCharge can only be charged by the automatic expiration cron script. Some libraries would prefer to manually cancel holds via the "Holds over" tab of the "Holds awaiting pickup" page but still be able to charge the cancellation fee. Test Plan: 1) Apply this patch 2) Set ExpireReservesMaxPickUpDelayCharge to some number 3) Go to the Holds awaiting pickup page 4) Go to the Holds over tab 5) Note the new checkbox for charging the fee 6) Test canceling a single hold with the checkbox checked 7) Note a fee is charged 8) Test canceling a single hold with the checkbox unchecked 9) Note a fee is not charged 10) Test canceling all holds with the checkbox checked 11) Note the patrons are charged fees 12) Test canceling all holds without the checkbox checked 13) Note the patrons are not charged fees Signed-off-by: Jason Burds -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed May 10 18:55:00 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 10 May 2017 16:55:00 +0000 Subject: [Koha-bugs] [Bug 15561] Add ability to charge cancelation fee from "Holds over" tab In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15561 --- Comment #21 from Kyle M Hall --- Created attachment 63359 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=63359&action=edit Bug 15561 [QA Followup] - Add unit tests -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed May 10 18:55:03 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 10 May 2017 16:55:03 +0000 Subject: [Koha-bugs] [Bug 15561] Add ability to charge cancelation fee from "Holds over" tab In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15561 --- Comment #22 from Kyle M Hall --- Created attachment 63360 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=63360&action=edit Bug 15561 [QA Followup] - Rename ExpireReservesMaxPickUpDelayCharge to WaitingHoldCancelationFee -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed May 10 18:55:07 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 10 May 2017 16:55:07 +0000 Subject: [Koha-bugs] [Bug 15561] Add ability to charge cancelation fee from "Holds over" tab In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15561 --- Comment #23 from Kyle M Hall --- Created attachment 63361 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=63361&action=edit Bug 15561 [QA Followup] - Add atomic update, fix other issues -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed May 10 19:06:41 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 10 May 2017 17:06:41 +0000 Subject: [Koha-bugs] [Bug 18399] Reason is missing in suggestion management part In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18399 Owen Leonard changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |ASSIGNED -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Wed May 10 19:06:49 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 10 May 2017 17:06:49 +0000 Subject: [Koha-bugs] [Bug 18399] Reason is missing in suggestion management part In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18399 Owen Leonard changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|koha-bugs at lists.koha-commun |oleonard at myacpl.org |ity.org | -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed May 10 19:33:40 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 10 May 2017 17:33:40 +0000 Subject: [Koha-bugs] [Bug 17015] New Koha Calendar In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17015 Mehdi Hamidi changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #60906|0 |1 is obsolete| | Attachment #62376|0 |1 is obsolete| | Attachment #62380|0 |1 is obsolete| | Attachment #63257|0 |1 is obsolete| | Attachment #63282|0 |1 is obsolete| | --- Comment #73 from Mehdi Hamidi --- Created attachment 63362 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=63362&action=edit Bug 17015 - DiscreteCalendar UI, Back-End and necessary scripts -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Wed May 10 19:34:33 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 10 May 2017 17:34:33 +0000 Subject: [Koha-bugs] [Bug 17015] New Koha Calendar In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17015 Mehdi Hamidi changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #63362|0 |1 is obsolete| | --- Comment #74 from Mehdi Hamidi --- Created attachment 63363 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=63363&action=edit Bug 17015 - DiscreteCalendar UI, Back-End and necessary scripts -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed May 10 19:34:47 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 10 May 2017 17:34:47 +0000 Subject: [Koha-bugs] [Bug 17015] New Koha Calendar In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17015 --- Comment #75 from Mehdi Hamidi --- Created attachment 63364 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=63364&action=edit Bug 17015 - Tests for DiscreteCalendar -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Wed May 10 19:35:00 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 10 May 2017 17:35:00 +0000 Subject: [Koha-bugs] [Bug 17015] New Koha Calendar In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17015 --- Comment #76 from Mehdi Hamidi --- Created attachment 63365 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=63365&action=edit Bug 17015 - Koha now uses the new DiscreteCalendar module -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Wed May 10 19:35:09 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 10 May 2017 17:35:09 +0000 Subject: [Koha-bugs] [Bug 17015] New Koha Calendar In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17015 --- Comment #77 from Mehdi Hamidi --- Created attachment 63366 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=63366&action=edit Bug 17015 - Updated Koha tests to use the new DiscreteCalendar module -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed May 10 19:35:18 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 10 May 2017 17:35:18 +0000 Subject: [Koha-bugs] [Bug 17015] New Koha Calendar In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17015 --- Comment #78 from Mehdi Hamidi --- Created attachment 63367 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=63367&action=edit Bug 17015 - Peformance tests for Koha::DiscreteCalendar -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Wed May 10 19:36:12 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 10 May 2017 17:36:12 +0000 Subject: [Koha-bugs] [Bug 18478] Hold Notices sent via SMS gateway fail In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18478 Kyle M Hall changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |RESOLVED Resolution|--- |WORKSFORME CC| |kyle at bywatersolutions.com --- Comment #1 from Kyle M Hall --- Appears to be a configuration issue and not a bug. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Wed May 10 19:42:30 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 10 May 2017 17:42:30 +0000 Subject: [Koha-bugs] [Bug 7317] Add an Interlibrary Loan Module to Circulation and OPAC In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7317 --- Comment #47 from Magnus Enger --- (In reply to Alex Sassmannshausen from comment #46) > Created attachment 63354 [details] [review] > Bug 7317: Invoke `handle_commit_maybe` on custom capabilities. > > * ill/ill-requests.pl: Invoke `handle_commit_maybe` on custom > capabilities in our controller to handle 'commit' stage. That fixes the problem of returning to detail view after executing the relevant code! Thanks for a quick fix. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed May 10 19:55:57 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 10 May 2017 17:55:57 +0000 Subject: [Koha-bugs] [Bug 18478] Hold Notices sent via SMS gateway fail In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18478 Nick Clemens changed: What |Removed |Added ---------------------------------------------------------------------------- Status|RESOLVED |REOPENED CC| |nick at bywatersolutions.com Resolution|WORKSFORME |--- --- Comment #2 from Nick Clemens --- Oops, confirmed -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed May 10 19:58:35 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 10 May 2017 17:58:35 +0000 Subject: [Koha-bugs] [Bug 18547] On shelf holds allowed > "If all unavailable" ignores default hold policy In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18547 --- Comment #6 from Claudio --- (In reply to Mirko Tietgen from comment #5) > (In reply to Claudio from comment #4) > > > Alex, this is a great fix but does not work. I cannot figure the reason... > > We use this patch in production and it works. Maybe you have another problem > related to this feature which is not covered by the patch. Thanks Mirko! I noticed that changing ReservesControlBranch syspref to "item's home library" the fix works (in my Koha installation ReservesControlBranch was set to "patron's home library"). Is it right? -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed May 10 19:58:51 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 10 May 2017 17:58:51 +0000 Subject: [Koha-bugs] [Bug 14744] Cannot select guarantor when quote in one of the fields In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14744 Chris Kirby changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |chris.kirby at ilsleypubliclib | |rary.org -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed May 10 21:12:37 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 10 May 2017 19:12:37 +0000 Subject: [Koha-bugs] [Bug 18571] koha-conf.xml should include ES entry In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18571 Tom?s Cohen Arazi changed: What |Removed |Added ---------------------------------------------------------------------------- Patch complexity|--- |Trivial patch Status|NEW |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed May 10 21:12:41 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 10 May 2017 19:12:41 +0000 Subject: [Koha-bugs] [Bug 18571] koha-conf.xml should include ES entry In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18571 --- Comment #1 from Tom?s Cohen Arazi --- Created attachment 63368 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=63368&action=edit Bug 18571: Add default ES configuration to koha-conf-site.xml.in This patch adds a default configuration entry for elasticsearch. It will add localhost:9200 to the server subsection, and koha_instance (replacing instance for the corresponding instance name) for the namespace. To test: - Apply the patch - Copy the file to the /etc/koha dir: $ sudo cp kohaclone/debian/templates/koha-conf-site.xml.in /etc/koha - Create a new instance: $ sudo koha-create --create-db test => SUCCESS: /etc/koha/sites/test/koha-conf.xml includes the mentioned section: localhost:9200 koha_test - Sign off :-D Note: As the use of ES is syspref driven, this default entry doesn't have any use until ES is installed and SearchEngine set to Elasticsearch. So it doesn't hurt but will help end users test the ES integration. Advanced users will take care of this config entry manually (pointing to external servers/clusters, etc). -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed May 10 21:13:04 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 10 May 2017 19:13:04 +0000 Subject: [Koha-bugs] [Bug 18571] koha-conf.xml should include ES entry In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18571 Tom?s Cohen Arazi changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |kyle at bywatersolutions.com -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed May 10 22:27:33 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 10 May 2017 20:27:33 +0000 Subject: [Koha-bugs] [Bug 18573] Error when adding a suggestion in the OPAC In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18573 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Summary|Error when adding anonymous |Error when adding a |suggestion in the OPAC |suggestion in the OPAC -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed May 10 22:32:28 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 10 May 2017 20:32:28 +0000 Subject: [Koha-bugs] [Bug 18573] Error when adding a suggestion in the OPAC In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18573 Marc V?ron changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #63356|0 |1 is obsolete| | --- Comment #4 from Marc V?ron --- Created attachment 63369 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=63369&action=edit Bug 18573: (bug 17847 follow-up) Update av-build-dropbox.inc for OPAC On bug 17847, av-build-dropbox.inc has been updated for the intranet, not OPAC There is only one call to av-build-dropbox.inc at the OPAC, from opac-suggestion.tt Test plan: Create a new suggestion, anonymous or with a logged in user => Without this patch you got Template process failed: undef error - The method default is not covered by tests! at /home/vagrant/kohaclone/C4/Templates.pm line 121. => With this patch applied you should see the item type dropdown list correctly filled Reproduced without patch, OK with patch Signed-off-by: Marc V?ron -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed May 10 22:32:56 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 10 May 2017 20:32:56 +0000 Subject: [Koha-bugs] [Bug 18573] Error when adding a suggestion in the OPAC In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18573 Marc V?ron changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off CC| |veron at veron.ch -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed May 10 22:39:47 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 10 May 2017 20:39:47 +0000 Subject: [Koha-bugs] [Bug 18574] Clean Patron Records tool doesn' t limit to the selected library In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18574 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |jonathan.druart at bugs.koha-c | |ommunity.org --- Comment #2 from Jonathan Druart --- Indentation is wrong. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed May 10 22:51:12 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 10 May 2017 20:51:12 +0000 Subject: [Koha-bugs] [Bug 18549] There should be a warning that logging out of Koha will leave browser session logged in to OAuth In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18549 --- Comment #10 from Katrin Fischer --- We had a lot of similar discussions about Shibboleth around here. The patrons use public computers in the library to search, place holds etc. and then they walk away, unaware that they are still logged into email and several other services the single sign on works for - although they logged out of the OPAC. We could make the warning optional, but I think it would be a nice thing to have. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed May 10 23:06:52 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 10 May 2017 21:06:52 +0000 Subject: [Koha-bugs] [Bug 12349] patron name on suggestions should be linked In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12349 Marc V?ron changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #63357|0 |1 is obsolete| | --- Comment #3 from Marc V?ron --- Created attachment 63370 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=63370&action=edit Bug 18154 - Show card number in detailled suggestion pages This patch modifies the main suggestion management page to link patron names to their details rather than with a "mailto:" link. This patch also includes the following changes: - A fix for Bug 18154, Show card number in suggestion details view. - Changes for brevity to labels in the suggestion details & edit view. - Addition of the datepicker class to date fields in the suggestion edit view. Signed-off-by: Marc V?ron -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Wed May 10 23:07:20 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 10 May 2017 21:07:20 +0000 Subject: [Koha-bugs] [Bug 12349] patron name on suggestions should be linked In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12349 Marc V?ron changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Wed May 10 23:16:34 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 10 May 2017 21:16:34 +0000 Subject: [Koha-bugs] [Bug 18438] Check in: Modal about holds hides important check in messages In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18438 Alex Buckley changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #63003|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed May 10 23:16:49 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 10 May 2017 21:16:49 +0000 Subject: [Koha-bugs] [Bug 18438] Check in: Modal about holds hides important check in messages In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18438 Alex Buckley changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #63004|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed May 10 23:17:01 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 10 May 2017 21:17:01 +0000 Subject: [Koha-bugs] [Bug 18438] Check in: Modal about holds hides important check in messages In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18438 Alex Buckley changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #63005|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed May 10 23:17:16 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 10 May 2017 21:17:16 +0000 Subject: [Koha-bugs] [Bug 18438] Check in: Modal about holds hides important check in messages In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18438 Alex Buckley changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #63006|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed May 10 23:17:27 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 10 May 2017 21:17:27 +0000 Subject: [Koha-bugs] [Bug 18438] Check in: Modal about holds hides important check in messages In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18438 Alex Buckley changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #63007|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed May 10 23:18:33 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 10 May 2017 21:18:33 +0000 Subject: [Koha-bugs] [Bug 18438] Check in: Modal about holds hides important check in messages In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18438 --- Comment #24 from Alex Buckley --- Created attachment 63371 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=63371&action=edit Bug 18438 - Implemented data-dismiss="modal" in returns.tt so that any warning messages hidden by a hold modal are displayed after it is dismissed Test plan: 1. Check out an item to one patron whilst having that item also being on hold to another patron 2. Check the item back in 3. Notice a modal box appears greying out the background with three buttons 'Confirm hold', 'Print and confirm' and 'Ignore'. Click confirm and notice that the page refreshes and no yellow warning messages are able to be displayed 4. Now that you have checked the item in. Try checking it in a second time by clicking on the Checkin tab and writing in the barcode. 5. The modal box will appear again, this time with three buttons 'Confirm', 'Print and confirm' and 'Cancel hold' 6. Click the 'Confirm' button and the page refreshes again and the yellow warning message hidden by the modal box is not properly displayed to the user. Notice that the focus is on the barcode input box. 7. Apply patch 8. Try checking in the item again, and this time after clicking the 'confirm' button on the modal box notice that the yellow warning message is displayed telling the user the item was "Not checked out". Also notice the focus is in the barcode inputbox. 9. Drop the hold on the item and make sure it is not checked out. 10. Repeat steps 1 and 2 and notice after clicking the 'Confirm hold' button the page refreshes and the item is successfully checked back in. With the focus on the barcode input. 11. View koha-tmpl/intranet-tmpl/prog/en/modules/circ/returns.tt and notice that the button on line 345 does not use an onclick parameter Signed-off-by: Marc V?ron Signed-off-by: Josef Moravec -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed May 10 23:19:01 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 10 May 2017 21:19:01 +0000 Subject: [Koha-bugs] [Bug 18438] Check in: Modal about holds hides important check in messages In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18438 Alex Buckley changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #63371|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed May 10 23:19:56 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 10 May 2017 21:19:56 +0000 Subject: [Koha-bugs] [Bug 18438] Check in: Modal about holds hides important check in messages In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18438 --- Comment #25 from Alex Buckley --- Created attachment 63372 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=63372&action=edit Bug 18438 - Implemented data-dismiss="modal" in returns.tt so that any warning messages hidden by a hold modal are displayed after it is dismissed Test plan: 1. Check out an item to one patron whilst having that item also being on hold to another patron 2. Check the item back in 3. Notice a modal box appears greying out the background with three buttons 'Confirm hold', 'Print and confirm' and 'Ignore'. Click confirm and notice that the page refreshes and no yellow warning messages are able to be displayed 4. Now that you have checked the item in. Try checking it in a second time by clicking on the Checkin tab and writing in the barcode. 5. The modal box will appear again, this time with three buttons 'Confirm', 'Print and confirm' and 'Cancel hold' 6. Click the 'Confirm' button and the page refreshes again and the yellow warning message hidden by the modal box is not properly displayed to the user. Notice that the focus is on the barcode input box. 7. Apply patch 8. Try checking in the item again, and this time after clicking the 'confirm' button on the modal box notice that the yellow warning message is displayed telling the user the item was "Not checked out". Also notice the focus is in the barcode inputbox. 9. Drop the hold on the item and make sure it is not checked out. 10. Repeat steps 1 and 2 and notice after clicking the 'Confirm hold' button the page refreshes and the item is successfully checked back in. With the focus on the barcode input. 11. View koha-tmpl/intranet-tmpl/prog/en/modules/circ/returns.tt and notice that the button on line 345 does not use an onclick parameter -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed May 10 23:21:18 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 10 May 2017 21:21:18 +0000 Subject: [Koha-bugs] [Bug 18438] Check in: Modal about holds hides important check in messages In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18438 Alex Buckley changed: What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |Needs Signoff --- Comment #26 from Alex Buckley --- This patch is just the previous 5 patches squashed down to one with an up to date test plan, the patch functionality itself has not been changed -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed May 10 23:46:21 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 10 May 2017 21:46:21 +0000 Subject: [Koha-bugs] [Bug 18389] bulkmarcimport.pl does not take notice of MARC modification templates In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18389 --- Comment #2 from Katrin Fischer --- Comment on attachment 63353 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=63353 The same patch as above only generated within git and without touch existing whitespace formatting oddities in the script. Review of attachment 63353: --> (https://bugs.koha-community.org/bugzilla3/page.cgi?id=splinter.html&bug=18389&attachment=63353) ----------------------------------------------------------------- Hi Jon, the patch is looking good, thx for your contribution! Looking at the code, I am missing documentation of the new option - could you add it please so it shows up when bulkmarcimport is run without params or with -h? Also noticed another small thing: ::: misc/migration_tools/bulkmarcimport.pl @@ +3,4 @@ > > use strict; > use warnings; > +use Modern::Perl; use Modern::Perl; replaces use strict; and use warnings; so the 2 lines above should be deleted. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed May 10 23:47:05 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 10 May 2017 21:47:05 +0000 Subject: [Koha-bugs] [Bug 18389] bulkmarcimport.pl does not take notice of MARC modification templates In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18389 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |katrin.fischer at bsz-bw.de Status|NEW |Needs Signoff --- Comment #3 from Katrin Fischer --- Oh, and also don't forget to switch to "Needs sign-off" when you upload a patch for testing! Spotted this in my mailbox, but it will now show on the Dashboard etc. otherwise! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed May 10 23:47:22 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 10 May 2017 21:47:22 +0000 Subject: [Koha-bugs] [Bug 18389] bulkmarcimport.pl does not take notice of MARC modification templates In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18389 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Version|16.11 |master Status|Needs Signoff |Failed QA -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed May 10 23:58:53 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 10 May 2017 21:58:53 +0000 Subject: [Koha-bugs] [Bug 18536] Generating CSV using profile in serials late issues doesn' t work as described In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18536 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Patch complexity|--- |Small patch Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed May 10 23:58:57 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 10 May 2017 21:58:57 +0000 Subject: [Koha-bugs] [Bug 18536] Generating CSV using profile in serials late issues doesn' t work as described In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18536 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #63342|0 |1 is obsolete| | --- Comment #3 from Katrin Fischer --- Created attachment 63373 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=63373&action=edit [SIGNED OFF] Bug 18536: Generating CSV using profile in serials late issues doesn't work as described Description on editing csv profiles says: "You can also use your own headers (instead of the ones from Koha) by prefixing the field name with an header, followed by the equal sign." So the header should be optional, but in fact it's mandatory. Also the regular expression to cut table name from beginning of db column is not right. Test plan: 0. Don't apply the patch 1. Make two CSV profiles for exporting late issues a) SUPPLIER=aqbooksellers.name|TITLE=subscription.title|ISSUENUMBER=serial.serialseq|LATE SINCE=serial.planneddate b) aqbooksellers.name|TITLE=subscription.title|ISSUE NUMBER=serial.serialseq|LATE SINCE=serial.planneddate 2. Export late issues, profile a) works as expected, profile b) doesn't 3. Apply the patch 4. Both profiles should work Signed-off-by: Katrin Fischer -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu May 11 00:16:12 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 10 May 2017 22:16:12 +0000 Subject: [Koha-bugs] [Bug 18574] Clean Patron Records tool doesn' t limit to the selected library In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18574 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu May 11 00:16:16 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 10 May 2017 22:16:16 +0000 Subject: [Koha-bugs] [Bug 18574] Clean Patron Records tool doesn' t limit to the selected library In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18574 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #63355|0 |1 is obsolete| | --- Comment #3 from Katrin Fischer --- Created attachment 63374 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=63374&action=edit [SIGNED OFF] Bug 18574 - Clean Patron Records tool doesn't limit to the selected library The library selector simply does nothing because at some point the javascript that powers it was removed. This is very bad because the librarian may batch delete patrons assuming it is limiting by branch correctly and instead delete patrons for all the libraries! Test Plan: 1) Note that the library pulldown on tools/cleanborrowers.pl does nothing 2) Apply this patch 3) Note that chaning the value in the pulldown now refreshed the page and sets the library correctly! Signed-off-by: Katrin Fischer -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu May 11 00:18:21 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 10 May 2017 22:18:21 +0000 Subject: [Koha-bugs] [Bug 18574] Clean Patron Records tool doesn' t limit to the selected library In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18574 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |katrin.fischer at bsz-bw.de --- Comment #4 from Katrin Fischer --- Fixed the tabs! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu May 11 00:23:24 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 10 May 2017 22:23:24 +0000 Subject: [Koha-bugs] [Bug 18549] There should be a warning that logging out of Koha will leave browser session logged in to OAuth In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18549 --- Comment #11 from M. Tompsett --- (In reply to Katrin Fischer from comment #10) > We could make the warning optional, but I think it would be a nice thing to > have. A system preference: Koha Only (default), Koha and Google, Prompt (recommended to give users freedom of choice)? If Koha Only, log out URL generates page similar to currently. If Koha and Google, log out URL generates the double logout version. If Prompt, modal popup like now. Would that be acceptable? I've been tinkering with revoking the authorization token after log in, the problem is Google stores session information in cookies, which I am having difficulty eliminating. This makes clicking on the previous email auto-magically log in. google.com: SSID and SID, accounts.google.com: LSID, ACCOUNT_CHOOSER. Get rid of those four cookies manually, and a login is forced without the previous email being remembered. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu May 11 00:24:21 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 10 May 2017 22:24:21 +0000 Subject: [Koha-bugs] [Bug 18560] RSS Feed link from OPAC shelves is broken In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18560 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |katrin.fischer at bsz-bw.de --- Comment #7 from Katrin Fischer --- We are a bit sparse with information in the RSS feed, for example if the entry is an article record, you would like to show the source as well. But this definitely fixes a bug. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu May 11 00:24:58 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 10 May 2017 22:24:58 +0000 Subject: [Koha-bugs] [Bug 18560] RSS Feed link from OPAC shelves is broken In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18560 --- Comment #8 from Katrin Fischer --- Created attachment 63375 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=63375&action=edit [SIGNED OFF] Bug 18560: RSS link in opac shelves is broken TEST PLAN --------- 1) have books entered 2) log in create a list 3) add books to list 4) display list 5) click the RSS link button. -- bad HASH error. 6) apply patch 7) repeat steps 4&5 -- readble junk without error messages. 8) run koha qa test tools Signed-off-by: Katrin Fischer -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu May 11 00:25:49 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 10 May 2017 22:25:49 +0000 Subject: [Koha-bugs] [Bug 18560] RSS Feed link from OPAC shelves is broken In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18560 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu May 11 00:25:51 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 10 May 2017 22:25:51 +0000 Subject: [Koha-bugs] [Bug 18560] RSS Feed link from OPAC shelves is broken In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18560 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #63340|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu May 11 00:27:51 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 10 May 2017 22:27:51 +0000 Subject: [Koha-bugs] [Bug 14625] LDAP: mapped ExtendedPatronAttributes cause error when updated on authentication In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14625 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |martin.renvoize at ptfs-europe | |.com -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu May 11 00:29:33 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 10 May 2017 22:29:33 +0000 Subject: [Koha-bugs] [Bug 2093] Add OPAC dashboard for logged-in users In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=2093 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Failed QA -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu May 11 00:37:33 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 10 May 2017 22:37:33 +0000 Subject: [Koha-bugs] [Bug 11299] Add a button that automatically links authority records to a biblio record during edition. (AJAX) In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11299 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Failed QA --- Comment #38 from Katrin Fischer --- Hi Bouzid, one step further! - QA test tools pass now - Adding a new authority entry after checking works nicely. - Adding a new authority that was checked negative works much better too, but fields are not prepopulated as noted in the test plan, could you check? If this is not intended for now, we could also change the test plan and solve this later on, as long as we don't leave broken code. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu May 11 00:57:32 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 10 May 2017 22:57:32 +0000 Subject: [Koha-bugs] [Bug 18543] Automated emails for new patron accounts with the AutoEmailOpacUser preference In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18543 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |katrin.fischer at bsz-bw.de --- Comment #1 from Katrin Fischer --- Hi Karen, I think Koha can't generate the password automatically yet, so that might be a different enhancement. But you are right about the username. The current behaviour has led to a lot of questions as libraries are never sure if the email has been sent out (no way to check) and there is a lot of undocumented conditions for it to happen. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Thu May 11 01:02:06 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 10 May 2017 23:02:06 +0000 Subject: [Koha-bugs] [Bug 18404] Allow check in receipts through slip In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18404 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Resolution|--- |DUPLICATE Status|NEW |RESOLVED CC| |katrin.fischer at bsz-bw.de --- Comment #1 from Katrin Fischer --- *** This bug has been marked as a duplicate of bug 12224 *** -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu May 11 01:02:06 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 10 May 2017 23:02:06 +0000 Subject: [Koha-bugs] [Bug 12224] Allow easy printing of patron check-in slip In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12224 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |amalalib09 at gmail.com --- Comment #23 from Katrin Fischer --- *** Bug 18404 has been marked as a duplicate of this bug. *** -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu May 11 01:02:26 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 10 May 2017 23:02:26 +0000 Subject: [Koha-bugs] [Bug 9251] Add option to print checkin and renewal quick slip In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9251 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |katrin.fischer at bsz-bw.de --- Comment #5 from Katrin Fischer --- Hi Litty, I think they were talking about the print menu in the staff patron account, but there is no patch, so it could be implemented differently. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Thu May 11 03:33:51 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 11 May 2017 01:33:51 +0000 Subject: [Koha-bugs] [Bug 17791] On UNIMARC system, USMARC field 100$a gets overwritten In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17791 Chris Cormack changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |chris at bigballofwax.co.nz Severity|major |new feature --- Comment #9 from Chris Cormack --- Changing to a new feature as this is adding support for on the fly conversion of MARC records from Z39.50 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu May 11 05:18:10 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 11 May 2017 03:18:10 +0000 Subject: [Koha-bugs] [Bug 18576] New: MARC Bibliographic framework test does not check for framework created Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18576 Bug ID: 18576 Summary: MARC Bibliographic framework test does not check for framework created Change sponsored?: --- Product: Koha Version: 16.11 Hardware: All OS: All Status: NEW Severity: minor Priority: P5 - low Component: System Administration Assignee: koha-bugs at lists.koha-community.org Reporter: bob-ewart at bobsown.com QA Contact: testopia at bugs.koha-community.org CC: gmcharlt at gmail.com Add a new bibliographic framework code without setting the MARC structure. Run the MARC Bibliographic framework test. It should report that framework code as an error (not setup). -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Thu May 11 05:18:25 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 11 May 2017 03:18:25 +0000 Subject: [Koha-bugs] [Bug 18576] MARC Bibliographic framework test does not check for framework created In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18576 Bob Ewart changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |bob-ewart at bobsown.com -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu May 11 05:28:59 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 11 May 2017 03:28:59 +0000 Subject: [Koha-bugs] [Bug 18577] New: Importing a batch using a framework not fully set up causes and endless loop Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18577 Bug ID: 18577 Summary: Importing a batch using a framework not fully set up causes and endless loop Change sponsored?: --- Product: Koha Version: 16.11 Hardware: All OS: All Status: NEW Severity: major Priority: P5 - low Component: MARC Bibliographic record staging/import Assignee: gmcharlt at gmail.com Reporter: bob-ewart at bobsown.com QA Contact: testopia at bugs.koha-community.org Importing a batch using a framework code that is defined but not set up causes the import to go into an endless loop. Create a new framework code but don't set what it is based on. Then import a batch using that framework. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu May 11 05:32:39 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 11 May 2017 03:32:39 +0000 Subject: [Koha-bugs] [Bug 18577] Importing a batch using a framework not fully set up causes and endless loop In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18577 Bob Ewart changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |bob-ewart at bobsown.com -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu May 11 07:42:29 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 11 May 2017 05:42:29 +0000 Subject: [Koha-bugs] [Bug 13642] Adding new features for Dublin Core metadata In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13642 --- Comment #163 from David Cook --- FYI, Magnus and I are doing a RDF project with Stockholm University Library, and we've been looking at RDF::Trine again. I've found a bug in the most recent code (version 1.016), and sent a pull request, and the module author said that he's hoping to review it and get that merged into master in the next few days. But it means that we do want to be using the newest version of RDF::Trine. I'm going to send an email out in a moment and copy in Mirko as the latest package maintainer. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu May 11 09:13:53 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 11 May 2017 07:13:53 +0000 Subject: [Koha-bugs] [Bug 18578] New: Use subdirectory in / tmp for session storage during installation Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18578 Bug ID: 18578 Summary: Use subdirectory in /tmp for session storage during installation Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Installation and upgrade (web-based installer) Assignee: koha-bugs at lists.koha-community.org Reporter: m.de.rooy at rijksmuseum.nl QA Contact: testopia at bugs.koha-community.org CC: gmcharlt at gmail.com Apply the change from bug 15553 to InstallAuth.pm too. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu May 11 09:39:20 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 11 May 2017 07:39:20 +0000 Subject: [Koha-bugs] [Bug 18578] Use subdirectory in / tmp for session storage during installation In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18578 Marcel de Rooy changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu May 11 09:39:23 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 11 May 2017 07:39:23 +0000 Subject: [Koha-bugs] [Bug 18578] Use subdirectory in / tmp for session storage during installation In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18578 --- Comment #1 from Marcel de Rooy --- Created attachment 63376 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=63376&action=edit Bug 18578: Use subdirectory in /tmp for session storage during installation Apply the change from bug 15553 to InstallAuth.pm too. Test plan: [1] Remove all cgisess_* files from your /tmp directory. [2] Remove directory /tmp/cgisess_koha_[your instance], if there. [3] Run the webinstaller /cgi-bin/koha/installer/install.pl?step=1&op=updatestructure [4] Check if you have cgisess_ files in /tmp/cgisess_koha_[your instance]. Signed-off-by: Marcel de Rooy -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Thu May 11 09:39:55 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 11 May 2017 07:39:55 +0000 Subject: [Koha-bugs] [Bug 18578] Use subdirectory in / tmp for session storage during installation In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18578 Marcel de Rooy changed: What |Removed |Added ---------------------------------------------------------------------------- Severity|enhancement |minor See Also| |https://bugs.koha-community | |.org/bugzilla3/show_bug.cgi | |?id=15553 Patch complexity|--- |Trivial patch Assignee|koha-bugs at lists.koha-commun |m.de.rooy at rijksmuseum.nl |ity.org | -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Thu May 11 09:39:55 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 11 May 2017 07:39:55 +0000 Subject: [Koha-bugs] [Bug 15553] cgisess_ files polluting the /tmp directory In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15553 Marcel de Rooy changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |https://bugs.koha-community | |.org/bugzilla3/show_bug.cgi | |?id=18578 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu May 11 10:40:29 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 11 May 2017 08:40:29 +0000 Subject: [Koha-bugs] [Bug 18250] koha-common should start after memcached In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18250 Jacek Ablewicz changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |https://bugs.koha-community | |.org/bugzilla3/show_bug.cgi | |?id=16758 -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu May 11 10:40:29 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 11 May 2017 08:40:29 +0000 Subject: [Koha-bugs] [Bug 16758] Caching issues in scripts running in daemon mode In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16758 Jacek Ablewicz changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |https://bugs.koha-community | |.org/bugzilla3/show_bug.cgi | |?id=18250 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu May 11 10:41:47 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 11 May 2017 08:41:47 +0000 Subject: [Koha-bugs] [Bug 18250] koha-common should start after memcached In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18250 Jacek Ablewicz changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |abl at biblos.pk.edu.pl -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu May 11 11:46:19 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 11 May 2017 09:46:19 +0000 Subject: [Koha-bugs] [Bug 18450] Renew in header bypasses hold block and renewal limits In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18450 Alex Buckley changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #63292|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu May 11 11:46:32 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 11 May 2017 09:46:32 +0000 Subject: [Koha-bugs] [Bug 18450] Renew in header bypasses hold block and renewal limits In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18450 Alex Buckley changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #63293|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu May 11 11:46:58 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 11 May 2017 09:46:58 +0000 Subject: [Koha-bugs] [Bug 18450] Renew in header bypasses hold block and renewal limits In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18450 --- Comment #12 from Alex Buckley --- Created attachment 63377 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=63377&action=edit Bug 18450 - Implemented check if either AllowRenewLimitOverride or AllowRenewalIfOtherItemsAvaliable were set to allow, so the user is only blocked if both of these sysprefs are set to 'Dont allow' Test plan: 1. In More->Administration->Global system preferences ensure that both the AllowRenewalLimitOverride and AllowRenewalIfOtherItemsAvaliable preferences are both set to 'Dont allow'. 2. Place a hold on an item from a patron 3. Checkout the item out to a different patron 4. Renew the item and notice the 'Cannot renew: The item is on hold for another patron' warning 5. Click the 'Override and renew' button and notice that you can bypass the hold 6. Apply patch 7. Renew the item again and notice that the message does not have a 'Override and renew' button it just has the 'Ignore and continue' button 8. Go back to More->Administration->Global system preferences and set AllowRenewalLimitOverride to 'Allow' 9. Try renewing the same item again and notice that the 'Override and renew' button is displayed 10. In systems preferences now set the AllowRenewalIfOtherItemsAvailable syspref to 'Allow' and AllowRenewalLimitOverride to 'Dont allow' and notice the 'Override and renew' button is displayed 11. Now set both these sysprefs to 'Allow' and notice the 'Override and renew' button is displayed because you will not be violating these preferences. Note: Checking if the renewal exceeds the renewal level, if auto renew is set up, or if renewal is to soon is checked earlier in this conditional if statement earlier and so the check in this patch does not need to check the renewal level, auto renewal, if renewal is too soon. Signed-off-by: Josef Moravec -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu May 11 11:49:38 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 11 May 2017 09:49:38 +0000 Subject: [Koha-bugs] [Bug 18450] Renew in header bypasses hold block and renewal limits In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18450 Alex Buckley changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Needs Signoff --- Comment #13 from Alex Buckley --- I have just squashed the two previous patches into 1 and attached it to this bug report, and as Jonathan suggested in comment 11 I have implemented the following logic in the renew.tt file: IT NOT A AND B OR A AND NOT B: Do the stuff -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu May 11 11:52:25 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 11 May 2017 09:52:25 +0000 Subject: [Koha-bugs] [Bug 18574] Clean Patron Records tool doesn' t limit to the selected library In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18574 Julian Maurice changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |julian.maurice at biblibre.com --- Comment #5 from Julian Maurice --- QAing this now -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu May 11 12:00:30 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 11 May 2017 10:00:30 +0000 Subject: [Koha-bugs] [Bug 18574] Clean Patron Records tool doesn' t limit to the selected library In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18574 --- Comment #6 from Julian Maurice --- Created attachment 63378 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=63378&action=edit Bug 18574 - Clean Patron Records tool doesn't limit to the selected library The library selector simply does nothing because at some point the javascript that powers it was removed. This is very bad because the librarian may batch delete patrons assuming it is limiting by branch correctly and instead delete patrons for all the libraries! Test Plan: 1) Note that the library pulldown on tools/cleanborrowers.pl does nothing 2) Apply this patch 3) Note that chaning the value in the pulldown now refreshed the page and sets the library correctly! Signed-off-by: Katrin Fischer Signed-off-by: Julian Maurice -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu May 11 12:02:30 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 11 May 2017 10:02:30 +0000 Subject: [Koha-bugs] [Bug 18574] Clean Patron Records tool doesn' t limit to the selected library In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18574 Julian Maurice changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA --- Comment #7 from Julian Maurice --- Passed QA For reference, this bug was introduced by bug 17083 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu May 11 12:08:05 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 11 May 2017 10:08:05 +0000 Subject: [Koha-bugs] [Bug 18573] Error when adding a suggestion in the OPAC In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18573 Julian Maurice changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |julian.maurice at biblibre.com --- Comment #5 from Julian Maurice --- QAing this now -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu May 11 12:15:39 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 11 May 2017 10:15:39 +0000 Subject: [Koha-bugs] [Bug 18573] Error when adding a suggestion in the OPAC In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18573 Julian Maurice changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #63369|0 |1 is obsolete| | --- Comment #6 from Julian Maurice --- Created attachment 63379 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=63379&action=edit Bug 18573: (bug 17847 follow-up) Update av-build-dropbox.inc for OPAC On bug 17847, av-build-dropbox.inc has been updated for the intranet, not OPAC There is only one call to av-build-dropbox.inc at the OPAC, from opac-suggestion.tt Test plan: Create a new suggestion, anonymous or with a logged in user => Without this patch you got Template process failed: undef error - The method default is not covered by tests! at /home/vagrant/kohaclone/C4/Templates.pm line 121. => With this patch applied you should see the item type dropdown list correctly filled Reproduced without patch, OK with patch Signed-off-by: Marc V?ron Signed-off-by: Julian Maurice -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu May 11 12:15:37 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 11 May 2017 10:15:37 +0000 Subject: [Koha-bugs] [Bug 18002] Make onboarding tool include framework to be embedded in Acquisitions to help the users set up Acquisitions for the first time In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18002 Alex Buckley changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #63151|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu May 11 12:15:59 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 11 May 2017 10:15:59 +0000 Subject: [Koha-bugs] [Bug 18573] Error when adding a suggestion in the OPAC In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18573 Julian Maurice changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu May 11 12:16:45 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 11 May 2017 10:16:45 +0000 Subject: [Koha-bugs] [Bug 18002] Make onboarding tool include framework to be embedded in Acquisitions to help the users set up Acquisitions for the first time In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18002 --- Comment #35 from Alex Buckley --- Created attachment 63380 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=63380&action=edit Bug 18002 - Created a budget creation onboarding form to be displayed when the user first visits the acquisition area -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu May 11 12:26:13 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 11 May 2017 10:26:13 +0000 Subject: [Koha-bugs] [Bug 18002] Make onboarding tool include framework to be embedded in Acquisitions to help the users set up Acquisitions for the first time In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18002 --- Comment #36 from Alex Buckley --- (In reply to Marc Veron in comment 34) Hi Marc For some reason when I run the qa tool it only shows that all qa tests are successful. However I was able to fix up the error in acqui-home.tt easily which is in the rebased patch I have just attached to this bug report, but I am not sure how fix up the issue with the onboardinginclude3.tt could you please suggest how you would solve that issue? -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu May 11 12:42:56 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 11 May 2017 10:42:56 +0000 Subject: [Koha-bugs] [Bug 18560] RSS Feed link from OPAC shelves is broken In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18560 --- Comment #9 from Julian Maurice --- Created attachment 63381 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=63381&action=edit Bug 18560: RSS link in opac shelves is broken TEST PLAN --------- 1) have books entered 2) log in create a list 3) add books to list 4) display list 5) click the RSS link button. -- bad HASH error. 6) apply patch 7) repeat steps 4&5 -- readble junk without error messages. 8) run koha qa test tools Signed-off-by: Katrin Fischer Signed-off-by: Julian Maurice -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu May 11 12:45:15 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 11 May 2017 10:45:15 +0000 Subject: [Koha-bugs] [Bug 18560] RSS Feed link from OPAC shelves is broken In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18560 Julian Maurice changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |julian.maurice at biblibre.com Status|Signed Off |Passed QA --- Comment #10 from Julian Maurice --- Simple patch, fixes the bug as expected -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu May 11 13:00:50 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 11 May 2017 11:00:50 +0000 Subject: [Koha-bugs] [Bug 16758] Caching issues in scripts running in daemon mode In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16758 --- Comment #16 from Jacek Ablewicz --- (In reply to Jonathan Druart from comment #12) > Why do you get the "syspref" cache instance? > I guess there is no reason, I'd suggest to remove it and retrieve the > default one. When rebuild_zebra.pl starts, it immediately initialises all 3 instances (config, syspref and default - in that order), so it probably doesn't matter much which one is used for checking if memcached is in use or not in use. Bug 18250 seems to be a bigger issue (possibility that zebra_daemon gets started before memcached is up and running). Overall, I don't think this is such a major issue for zebra daemon right now, because by a look of it, rebuild_zebra.pl uses very limited set of cached values, and predominantly (if not only) such kinds of values that are never changed in the production systems, like: syspref_cas* (due to BEGIN block in Auth.pm), syspref_marcflavour, syspref_includeseefrominsearches It fetches repeatedly MarcSubfieldStructure-* from default cache instance, but I think it's mostly used for determining tag numbers (item tag number, biblio/biblioitem tag number), which don't change very often (if ever) in the production environments. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu May 11 13:10:08 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 11 May 2017 11:10:08 +0000 Subject: [Koha-bugs] [Bug 17257] Cannot create a patron under MySQL 5.7 In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17257 Julian Maurice changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |julian.maurice at biblibre.com Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu May 11 13:09:56 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 11 May 2017 11:09:56 +0000 Subject: [Koha-bugs] [Bug 17257] Cannot create a patron under MySQL 5.7 In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17257 --- Comment #10 from Julian Maurice --- Created attachment 63382 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=63382&action=edit Bug 17257: Fix add/edit patrons under MySQL 5.7 If no guarantor is defined the patron won't be added/modified and an error will be raised: DBD::mysql::st execute failed: Incorrect integer value: '' for column 'guarantorid' Test plan: Using MySQL 5.7 (and/or sql_mode=STRICT_TRANS_TABLES) Create a patron without guarantor Signed-off-by: Srdjan Tested with MariaDB 10.0.30 (sql_mode='STRICT_TRANS_TABLES') Signed-off-by: Julian Maurice -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu May 11 14:18:12 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 11 May 2017 12:18:12 +0000 Subject: [Koha-bugs] [Bug 18370] Columns settings patrons>id=memberresultst : display bug In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18370 --- Comment #10 from Julian Maurice --- Comment on attachment 61870 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=61870 Bug 18370: Columns visibility on patron search - Hide the correct column Review of attachment 61870: --> (https://bugs.koha-community.org/bugzilla3/page.cgi?id=splinter.html&bug=18370&attachment=61870) ----------------------------------------------------------------- ::: koha-tmpl/intranet-tmpl/prog/en/modules/members/member.tt @@ +163,5 @@ > // Apply DataTables on the results table > var columns_settings = [% ColumnsSettings.GetColumns( 'members', 'member', 'memberresultst', 'json' ) %]; > + [% UNLESS CAN_user_tools_manage_patron_lists %] > + [%# Remove the first column if we do not display the checkbox %] > + columns_settings = columns_settings.slice(1, -1); slice(1, -1) removes the first and the last elements of the array slice(1) is what you want. An even better solution is to use Array.splice, because it modifies directly the array (and it's faster) -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu May 11 14:18:34 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 11 May 2017 12:18:34 +0000 Subject: [Koha-bugs] [Bug 18370] Columns settings patrons>id=memberresultst : display bug In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18370 Julian Maurice changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Failed QA CC| |julian.maurice at biblibre.com -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu May 11 14:42:19 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 11 May 2017 12:42:19 +0000 Subject: [Koha-bugs] [Bug 18504] Amount owed on fines tab should be formatted as price if < 10 or credit In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18504 --- Comment #3 from Julian Maurice --- Created attachment 63383 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=63383&action=edit Bug 18504 - Amount owed on fines tab should be formatted as price if <10 or credit To test: 1 - Give a patron a fine of 1 2 - View opac fines tab, it shows as '1' 3 - Give patron a credit of '1' 4 - View opac fines tab, it shows as '1' 5 - Apply patch 6 - Both now show as '1.00' Signed-off-by: Lisa Gugliotti Signed-off-by: Julian Maurice -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu May 11 14:42:34 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 11 May 2017 12:42:34 +0000 Subject: [Koha-bugs] [Bug 18504] Amount owed on fines tab should be formatted as price if < 10 or credit In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18504 Julian Maurice changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |julian.maurice at biblibre.com Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu May 11 14:49:37 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 11 May 2017 12:49:37 +0000 Subject: [Koha-bugs] [Bug 18579] New:=?UTF-8?Q?=20Probl=C3=A8me=20with=20?=:Filter::MARC:: EmbedItemsAvailability Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18579 Bug ID: 18579 Summary: Probl?me with :Filter::MARC::EmbedItemsAvailability Change sponsored?: --- Product: Koha Version: unspecified Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Cataloging Assignee: gmcharlt at gmail.com Reporter: koha at univ-lyon3.fr QA Contact: testopia at bugs.koha-community.org CC: m.de.rooy at rijksmuseum.nl This is a real bug, in Koha::Filter::MARC::EmbedItemsAvailability::_processrecord, $biblionumber_field should be corrected to allow controlfield like 001. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu May 11 14:51:08 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 11 May 2017 12:51:08 +0000 Subject: [Koha-bugs] [Bug 18579]=?UTF-8?Q?=20Probl=C3=A8me=20with=20?=:Filter::MARC:: EmbedItemsAvailability In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18579 Koha Team Lyon 3 changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |fridolin.somers at biblibre.co | |m, koha at univ-lyon3.fr -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu May 11 14:56:27 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 11 May 2017 12:56:27 +0000 Subject: [Koha-bugs] [Bug 18579]=?UTF-8?Q?=20Probl=C3=A8me=20with=20?=:Filter::MARC:: EmbedItemsAvailability In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18579 Julian Maurice changed: What |Removed |Added ---------------------------------------------------------------------------- Severity|enhancement |critical CC| |julian.maurice at biblibre.com --- Comment #1 from Julian Maurice --- Upgrading severity to critical, this prevents reindexing zebra: $ misc/migration_tools/rebuild_zebra.pl -r -b -v Zebra configuration information ================================ Zebra biblio directory = /home/koha/env/master/var/lib/zebradb/biblios Zebra authorities directory = /home/koha/env/master/var/lib/zebradb/authorities Koha directory = /home/koha/env/master/src Lockfile = /home/koha/env/master/var/lock/zebradb/rebuild/rebuild..LCK BIBLIONUMBER in : 001$@ BIBLIOITEMNUMBER in : 090$a ================================ skipping authorities ==================== exporting biblio ==================== 1Control fields (generally, just tags below 010) do not have subfields, use data() at /home/koha/env/master/src/Koha/Filter/MARC/EmbedItemsAvailability.pm line 75. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu May 11 14:59:49 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 11 May 2017 12:59:49 +0000 Subject: [Koha-bugs] [Bug 18579]=?UTF-8?Q?=20Probl=C3=A8me=20with=20?=:Filter::MARC:: EmbedItemsAvailability In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18579 --- Comment #2 from Marcel de Rooy --- (In reply to Koha Team Lyon 3 from comment #0) > This is a real bug, in > Koha::Filter::MARC::EmbedItemsAvailability::_processrecord, > $biblionumber_field > should be corrected to allow controlfield like 001. Good catch! Should use logic as in Koha/SearchEngine/Search.pm (extract_biblionumber). Ping Tomas -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu May 11 15:00:04 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 11 May 2017 13:00:04 +0000 Subject: [Koha-bugs] [Bug 18579]=?UTF-8?Q?=20Probl=C3=A8me=20with=20?=:Filter::MARC:: EmbedItemsAvailability In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18579 Marcel de Rooy changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |tomascohen at gmail.com -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu May 11 15:00:13 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 11 May 2017 13:00:13 +0000 Subject: [Koha-bugs] [Bug 18579] Problem with :Filter::MARC::EmbedItemsAvailability In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18579 Marcel de Rooy changed: What |Removed |Added ---------------------------------------------------------------------------- Summary|Probl?me with |Problem with |:Filter::MARC::EmbedItemsAv |:Filter::MARC::EmbedItemsAv |ailability |ailability -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu May 11 15:03:48 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 11 May 2017 13:03:48 +0000 Subject: [Koha-bugs] [Bug 18579] Problem with :Filter::MARC::EmbedItemsAvailability In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18579 Tom?s Cohen Arazi changed: What |Removed |Added ---------------------------------------------------------------------------- Version|unspecified |master Assignee|gmcharlt at gmail.com |tomascohen at gmail.com -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu May 11 15:09:59 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 11 May 2017 13:09:59 +0000 Subject: [Koha-bugs] [Bug 18153] UNIMARC bib records exported with invalid 'a' char in label pos.9 In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18153 --- Comment #9 from stephane.delaune at biblibre.com --- (In reply to Jonathan Druart from comment #8) > The question is: > Should not we call SetMarcUnicodeFlag from ModBiblioMarc to replace the > whole "if ( $encoding eq "UNIMARC" ) {" block? > > (read s/encoding/marcflavour ...) The purpose of this patch is not to fix the wrong call of ?MARC::Record->encoding('utf-8')? to import (it's the goal of bug 18152), nor even everywhere (it's the goal of bug 18533) ; the goal is to fix exported records. Indeed, a lot of existing unimarc records in a lot of Koha are erroneous because of this bug, the goal is that they do not remain erroneous when exported. I don't see the relationship with ModBiblioMarc who has been corrected to not add the bad character, not to delete it (and export don't call ModBiblioMarc) -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu May 11 15:30:21 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 11 May 2017 13:30:21 +0000 Subject: [Koha-bugs] [Bug 18442] Permission error when logging into staff interface as db user In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18442 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |katrin.fischer at bsz-bw.de -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu May 11 15:52:57 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 11 May 2017 13:52:57 +0000 Subject: [Koha-bugs] [Bug 17083] Remove more event attributes from tools templates In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17083 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |18574 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18574 [Bug 18574] Clean Patron Records tool doesn't limit to the selected library -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu May 11 15:52:57 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 11 May 2017 13:52:57 +0000 Subject: [Koha-bugs] [Bug 18574] Clean Patron Records tool doesn' t limit to the selected library In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18574 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on| |17083 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17083 [Bug 17083] Remove more event attributes from tools templates -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu May 11 15:53:15 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 11 May 2017 13:53:15 +0000 Subject: [Koha-bugs] [Bug 18574] Clean Patron Records tool doesn' t limit to the selected library In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18574 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #63374|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu May 11 16:07:10 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 11 May 2017 14:07:10 +0000 Subject: [Koha-bugs] [Bug 18342] Set memcached as 'enabled' by default In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18342 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |jonathan.druart at bugs.koha-c | |ommunity.org --- Comment #2 from Jonathan Druart --- (In reply to Marcel de Rooy from comment #1) > And remove the other cache types: Cache::Memory etc. Not Cache::Memory, it should be kept as a fallback way in case memcached is not reachable. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu May 11 16:14:22 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 11 May 2017 14:14:22 +0000 Subject: [Koha-bugs] [Bug 18442] Permission error when logging into staff interface as db user In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18442 Mason James changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |mtj at kohaaloha.com -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu May 11 16:14:30 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 11 May 2017 14:14:30 +0000 Subject: [Koha-bugs] [Bug 18399] Reason is missing in suggestion management part In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18399 Owen Leonard changed: What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |Needs Signoff Patch complexity|--- |Trivial patch -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu May 11 16:14:33 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 11 May 2017 14:14:33 +0000 Subject: [Koha-bugs] [Bug 18399] Reason is missing in suggestion management part In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18399 --- Comment #1 from Owen Leonard --- Created attachment 63384 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=63384&action=edit Bug 18399 - Reason is missing in suggestion management part This patch adds a form field for suggestion status "reason" to the suggestion edit form. To test, edit an existing suggestion and try entering a suggestion status explanation in the new form field. Your changes should be saved correctly. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu May 11 16:27:31 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 11 May 2017 14:27:31 +0000 Subject: [Koha-bugs] [Bug 16784] Export suggestions from OPAC as CSV In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16784 --- Comment #1 from Owen Leonard --- Wouldn't this make more sense as a feature in the staff client? -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Thu May 11 16:48:19 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 11 May 2017 14:48:19 +0000 Subject: [Koha-bugs] [Bug 18580] New: Account-pay does not apply credits / clear old fines as did recordpayment Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18580 Bug ID: 18580 Summary: Account-pay does not apply credits / clear old fines as did recordpayment Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Circulation Assignee: koha-bugs at lists.koha-community.org Reporter: colin.campbell at ptfs-europe.com QA Contact: testopia at bugs.koha-community.org CC: gmcharlt at gmail.com, kyle.m.hall at gmail.com the recordpayment routine in C4::Accounts cleared old paid fines and applied credit amounts as part of its pay routine. The behaviour was implicit and not signalled or commented in the code. The pay routine in Koha::Account which is now called by paycollect.pl instead of the old routine does not leaving these on the users fine display although they owe 0. Staff cannot manually remove these. For example a user has the following accountlines +-----------+-------------+-------------------+ | amount | accounttype | amountoutstanding | +-----------+-------------+-------------------+ | -1.300000 | C | -1.300000 | | 0.650000 | Res | 0.650000 | | 0.650000 | Res | 0.650000 | | 0.650000 | Res | 0.650000 | +-----------+-------------+-------------------+ after recordpayment has been called with an amount of 0.65 the lines are +-----------+-------------+-------------------+ | amount | accounttype | amountoutstanding | +-----------+-------------+-------------------+ | -1.300000 | C | 0.000000 | | 0.650000 | Res | 0.000000 | | 0.650000 | Res | 0.000000 | | 0.650000 | Res | 0.000000 | | -0.650000 | Pay | 0.000000 | +-----------+-------------+-------------------+ However now calling Account->pay for the same amount results in +-----------+-------------+-------------------+ | amount | accounttype | amountoutstanding | +-----------+-------------+-------------------+ | -1.300000 | C | -1.300000 | | 0.650000 | Res | 0.000000 | | 0.650000 | Res | 0.650000 | | 0.650000 | Res | 0.650000 | | -0.650000 | Pay | 0.000000 | +-----------+-------------+-------------------+ leaving the credit and two fines with an amountoutstanding although the user has nothing to pay (the amountoutstanding columns sum to 0) and leading to misleading displays. The difference is driven by the line where @outstanding_fines is retrieved the selection is amountoutstanding > 0. In recordpayment it was amountoutstanding <> 0 so that negative amounts were included and processed as part of the payment, rather than ignored. The fact that this implicit behaviour was not commented made it easy to miss. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Thu May 11 16:52:34 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 11 May 2017 14:52:34 +0000 Subject: [Koha-bugs] [Bug 18581] New: Add standard edit and delete buttons to suggestions list Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18581 Bug ID: 18581 Summary: Add standard edit and delete buttons to suggestions list Change sponsored?: --- Product: Koha Version: master Hardware: All URL: /cgi-bin/koha/suggestion/suggestion.pl OS: All Status: ASSIGNED Severity: enhancement Priority: P5 - low Component: Acquisitions Assignee: oleonard at myacpl.org Reporter: oleonard at myacpl.org QA Contact: testopia at bugs.koha-community.org Right now the list of suggestions in the staff client has an "[edit]" link but no corresponding delete button, although there is a delete button on the detailed view. I propose to add the standard pair of edit and delete buttons to the table. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu May 11 17:04:43 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 11 May 2017 15:04:43 +0000 Subject: [Koha-bugs] [Bug 10382] collection not returning to null when removed from course reserves In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10382 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Failed QA --- Comment #28 from Jonathan Druart --- Please add a reference to the DB changes in the commit message. You also have to provide the same changes for kohastructure! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu May 11 17:06:37 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 11 May 2017 15:06:37 +0000 Subject: [Koha-bugs] [Bug 18579] Problem with :Filter::MARC::EmbedItemsAvailability In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18579 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |jonathan.druart at bugs.koha-c | |ommunity.org -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu May 11 17:06:42 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 11 May 2017 15:06:42 +0000 Subject: [Koha-bugs] [Bug 18579] Problem with :Filter::MARC::EmbedItemsAvailability In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18579 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |ASSIGNED -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu May 11 17:07:31 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 11 May 2017 15:07:31 +0000 Subject: [Koha-bugs] [Bug 18581] Add standard edit and delete buttons to suggestions list In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18581 Owen Leonard changed: What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |Needs Signoff Patch complexity|--- |Small patch -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu May 11 17:07:34 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 11 May 2017 15:07:34 +0000 Subject: [Koha-bugs] [Bug 18581] Add standard edit and delete buttons to suggestions list In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18581 --- Comment #1 from Owen Leonard --- Created attachment 63385 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=63385&action=edit Bug 18581 - Add standard edit and delete buttons to suggestions list This patch modifies the table of suggestions in the staff client, moving the edit link to the standard last column and styling it correctly. A delete button is added as well. Unrelated change: I removed the column containing suggestionid because I don't think it's human-relevant information. To test, apply the patch and go to Acquisitions -> Suggestions. - In each tab, the table of suggestions should have an unsorted last column containing "edit" and "delete" links which should be styled correctly and working correctly. - On the detailed view of a suggestion, the "delete" button in the toolbar should still work correctly. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu May 11 17:10:21 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 11 May 2017 15:10:21 +0000 Subject: [Koha-bugs] [Bug 18582] New: Hide empty rows in detailed suggestion view Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18582 Bug ID: 18582 Summary: Hide empty rows in detailed suggestion view Change sponsored?: --- Product: Koha Version: master Hardware: All URL: /cgi-bin/koha/suggestion/suggestion.pl OS: All Status: ASSIGNED Severity: enhancement Priority: P5 - low Component: Acquisitions Assignee: oleonard at myacpl.org Reporter: oleonard at myacpl.org QA Contact: testopia at bugs.koha-community.org In the suggestion detailed view, every field is displayed even if it is empty. This view should hide rows which contain no data. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu May 11 17:11:24 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 11 May 2017 15:11:24 +0000 Subject: [Koha-bugs] [Bug 18399] Reason is missing in suggestion management part In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18399 Owen Leonard changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |ASSIGNED -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu May 11 17:11:37 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 11 May 2017 15:11:37 +0000 Subject: [Koha-bugs] [Bug 18399] Reason is missing in suggestion management part In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18399 Owen Leonard changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #63384|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu May 11 17:12:40 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 11 May 2017 15:12:40 +0000 Subject: [Koha-bugs] [Bug 18580] Account-pay does not apply credits / clear old fines as did recordpayment In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18580 Colin Campbell changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|koha-bugs at lists.koha-commun |colin.campbell at ptfs-europe. |ity.org |com Status|NEW |Needs Signoff --- Comment #1 from Colin Campbell --- Created attachment 63386 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=63386&action=edit proposed patch This is a minimal patch which restores the previous behaviour which some operations relied on. Its a bit of a code smell that this is handled as a side-effect of a payment, but as Accounts never explicitly handled credit amounts it would require a bit of a rethink to the Accounts api -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu May 11 17:17:10 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 11 May 2017 15:17:10 +0000 Subject: [Koha-bugs] [Bug 18204] Authority searches are not saved in Search history In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18204 --- Comment #3 from leire at scanbit.net --- Created attachment 63387 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=63387&action=edit Bug 18204 - Authority searches are not saved in Search history When you search an authority in Authority search, this search is not saved in Search history. EnableOpacSearchHistory is enabled Steps to test: 1- Login your account (opac) 2- Search an authority in Authority search 3- Go to Search history -> Authority 4- It says "Your authority search history is empty" -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu May 11 17:22:09 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 11 May 2017 15:22:09 +0000 Subject: [Koha-bugs] [Bug 18204] Authority searches are not saved in Search history In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18204 leire at scanbit.net changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Patch doesn't apply |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu May 11 17:37:48 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 11 May 2017 15:37:48 +0000 Subject: [Koha-bugs] [Bug 18370] Columns settings patrons>id=memberresultst : display bug In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18370 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |Signed Off -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu May 11 17:37:53 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 11 May 2017 15:37:53 +0000 Subject: [Koha-bugs] [Bug 18370] Columns settings patrons>id=memberresultst : display bug In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18370 --- Comment #11 from Jonathan Druart --- Created attachment 63388 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=63388&action=edit Bug 18370: Use splice instead of splice -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu May 11 17:42:08 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 11 May 2017 15:42:08 +0000 Subject: [Koha-bugs] [Bug 18577] Importing a batch using a framework not fully set up causes and endless loop In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18577 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |jonathan.druart at bugs.koha-c | |ommunity.org Version|16.11 |unspecified -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu May 11 17:42:14 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 11 May 2017 15:42:14 +0000 Subject: [Koha-bugs] [Bug 18576] MARC Bibliographic framework test does not check for framework created In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18576 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |jonathan.druart at bugs.koha-c | |ommunity.org Version|16.11 |unspecified -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu May 11 17:43:47 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 11 May 2017 15:43:47 +0000 Subject: [Koha-bugs] [Bug 18153] UNIMARC bib records exported with invalid 'a' char in label pos.9 In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18153 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |julian.maurice at biblibre.com --- Comment #10 from Jonathan Druart --- I have asked Julian to take a look. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu May 11 17:43:49 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 11 May 2017 15:43:49 +0000 Subject: [Koha-bugs] [Bug 18583] New: Add the ability to merge multiple authorities Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18583 Bug ID: 18583 Summary: Add the ability to merge multiple authorities Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Cataloging Assignee: gmcharlt at gmail.com Reporter: nick at bywatersolutions.com QA Contact: testopia at bugs.koha-community.org CC: m.de.rooy at rijksmuseum.nl Since bug 8064 it is possible to merge multiple bibliographic records at once, it would be nice to be able to do the same thing with authority records. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu May 11 17:45:20 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 11 May 2017 15:45:20 +0000 Subject: [Koha-bugs] [Bug 18583] Add the ability to merge multiple authorities In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18583 Nick Clemens changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|gmcharlt at gmail.com |m.de.rooy at rijksmuseum.nl -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu May 11 17:49:02 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 11 May 2017 15:49:02 +0000 Subject: [Koha-bugs] [Bug 18547] On shelf holds allowed > "If all unavailable" ignores default hold policy In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18547 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |jonathan.druart at bugs.koha-c | |ommunity.org --- Comment #7 from Jonathan Druart --- Any chances to see tests covering this change? -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu May 11 17:50:30 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 11 May 2017 15:50:30 +0000 Subject: [Koha-bugs] [Bug 18477] AR_PENDING notice does not populate values from article_requests table. In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18477 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |jonathan.druart at bugs.koha-c | |ommunity.org Status|Signed Off |Failed QA --- Comment #3 from Jonathan Druart --- Please provide tests! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu May 11 18:08:09 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 11 May 2017 16:08:09 +0000 Subject: [Koha-bugs] [Bug 18560] RSS Feed link from OPAC shelves is broken In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18560 --- Comment #11 from M. Tompsett --- (In reply to Katrin Fischer from comment #7) > We are a bit sparse with information in the RSS feed, for example if the > entry is an article record, you would like to show the source as well. But > this definitely fixes a bug. Actually, that's the other thing I did notice. RSS feeds are not consistent in what they output. This one needs improvement, but that is beyond the scope of this specific bug. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu May 11 18:10:42 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 11 May 2017 16:10:42 +0000 Subject: [Koha-bugs] [Bug 18579] Problem with :Filter::MARC::EmbedItemsAvailability In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18579 --- Comment #3 from Tom?s Cohen Arazi --- Created attachment 63389 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=63389&action=edit Bug 18579: Regression tests This patch makes sure the tests have the biblio.biblionumber mapping mocked so we test the case where the mapping is to a control field instead of just regular data fields (in the case of UNIMARC). To test: - Apply the patch - Run: $ prove t/db_dependent/Koha/Filter/EmbedItemsAvailability.t => FAIL: Tests fail due to an attemp to access a subfield on a control field. Sponsored-by: ByWater Solutions -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu May 11 18:10:46 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 11 May 2017 16:10:46 +0000 Subject: [Koha-bugs] [Bug 18579] Problem with :Filter::MARC::EmbedItemsAvailability In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18579 --- Comment #4 from Tom?s Cohen Arazi --- Created attachment 63390 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=63390&action=edit Bug 18579: Make EmbedItemsAvailability handle control fields correctly This patch makes the EmbedItemsAvailability filter handle the biblio.biblionumber > control field mapping gracefully. Right now, it was assuming a regular data field was used, and such is not the case for UNIMARC (001). To test: - Apply the tests patch - Run: $ sudo koha-shell kohadev k$ cd kohaclone k$ prove t/db_dependent/Koha/Filter/EmbedItemsAvailability.t => FAIL: Tests fail to run - Apply this patch - Run: k$ prove t/db_dependent/Koha/Filter/EmbedItemsAvailability.t => SUCCESS: Tests pass! - Sign off :-D Sponsored-by: ByWater Solutions -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu May 11 18:11:07 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 11 May 2017 16:11:07 +0000 Subject: [Koha-bugs] [Bug 18579] Problem with :Filter::MARC::EmbedItemsAvailability In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18579 Tom?s Cohen Arazi changed: What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu May 11 18:12:11 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 11 May 2017 16:12:11 +0000 Subject: [Koha-bugs] [Bug 18579] Problem with :Filter::MARC::EmbedItemsAvailability In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18579 --- Comment #5 from Tom?s Cohen Arazi --- Hi, please test on your UNIMARC test environment! I provided a fix for the tests so they actually cover the control field case, and the patch correctly makes it work as expected (thanks marcelr for the pointer). -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu May 11 18:31:45 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 11 May 2017 16:31:45 +0000 Subject: [Koha-bugs] [Bug 14803] Rental and fine fees are not updating on circulation screen In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14803 Fiona Borthwick changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |fiona.borthwick at ptfs-europe | |.com -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu May 11 18:32:01 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 11 May 2017 16:32:01 +0000 Subject: [Koha-bugs] [Bug 15404] CanBookBeReserved: No count of biblio level holds if ReservesControlBranch is item' s home library In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15404 Fiona Borthwick changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |fiona.borthwick at ptfs-europe | |.com -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu May 11 18:45:56 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 11 May 2017 16:45:56 +0000 Subject: [Koha-bugs] [Bug 18584] New: Removing trailing-space from our codebase Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18584 Bug ID: 18584 Summary: Removing trailing-space from our codebase Change sponsored?: --- Product: Koha Version: unspecified Hardware: All OS: All Status: NEW Severity: trivial Priority: P5 - low Component: Architecture, internals, and plumbing Assignee: gmcharlt at gmail.com Reporter: jonathan.druart at bugs.koha-community.org QA Contact: testopia at bugs.koha-community.org This bug report is opened for didactic purpose. If you already contributed to Koha you must not contribute here. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu May 11 18:49:30 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 11 May 2017 16:49:30 +0000 Subject: [Koha-bugs] [Bug 18582] Hide empty rows in detailed suggestion view In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18582 Owen Leonard changed: What |Removed |Added ---------------------------------------------------------------------------- Patch complexity|--- |Trivial patch Status|ASSIGNED |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu May 11 18:49:32 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 11 May 2017 16:49:32 +0000 Subject: [Koha-bugs] [Bug 18582] Hide empty rows in detailed suggestion view In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18582 --- Comment #1 from Owen Leonard --- Created attachment 63391 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=63391&action=edit Bug 18582 - Hide empty rows in detailed suggestion view This patch adds a check for the existence of various template variables before showing the row containing that data. This will prevent the display of rows containing labels but no data in the suggestions detailed view. To test, apply the patch and go to Acquisitions -> Suggestions. View the detail page of various suggestions and confirm that only fields with data are displaying. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu May 11 18:54:18 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 11 May 2017 16:54:18 +0000 Subject: [Koha-bugs] [Bug 18514] Allow library to search their Koha and Overdrive collections using ElasticSearch In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18514 Nick Clemens changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |kyle at bywatersolutions.com, | |nate at bywatersolutions.com, | |nick at bywatersolutions.com -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu May 11 18:57:12 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 11 May 2017 16:57:12 +0000 Subject: [Koha-bugs] [Bug 18584] Our legacy code contains trailing-spaces In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18584 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |ASSIGNED Summary|Removing trailing-space |Our legacy code contains |from our codebase |trailing-spaces -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu May 11 19:59:21 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 11 May 2017 17:59:21 +0000 Subject: [Koha-bugs] [Bug 18342] Set memcached as 'enabled' by default In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18342 Jacek Ablewicz changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |abl at biblos.pk.edu.pl --- Comment #3 from Jacek Ablewicz --- (In reply to Jonathan Druart from comment #2) > (In reply to Marcel de Rooy from comment #1) > > And remove the other cache types: Cache::Memory etc. IMO at least fastmmap definitely should be removed, it's long overdue. > > Not Cache::Memory, it should be kept as a fallback way in case memcached is > not reachable Cache::Memory does't work all that well as a fallback mechanism.. Under normal circumstances it's just slowing things out (values are stored there, but never retrieved back). And under more unusual circumstances (e.g. if we want to flush L1 cache in daemon scripts periodically) it's pretty much the same - while Cache::Memory supports expiration, currently we don't use it (properly), and the final result is once again 100% waste of CPU cycles, without any gains at all. I wonder if a better fallback for memcached L2 cache could rather be: no L2 cache, or maybe some kind of dummy L2 cache. It does mater only in case of daemon scripts - if it's not a daemon script etc., Cache::Memory will always be a waste of time anyway. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri May 12 03:57:57 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 12 May 2017 01:57:57 +0000 Subject: [Koha-bugs] [Bug 17602] Integrate support for ONeclickDigital/Recorded Books API In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17602 Srdjan Jankovic changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #62250|0 |1 is obsolete| | --- Comment #16 from Srdjan Jankovic --- Created attachment 63392 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=63392&action=edit Bug 17602 Add Oneclickdigital integration to Koha Add OneClickdigital to the users page in the public interface To Test: 1/ Apply all 3 patches 2/ Set the sysprefs to valid values (you will need a test account with Oneclickdigital) 3/ Try a search 4/ Login to the OPAC, try to place a hold, or check an item out 5/ Check the opac-user page, see if your items are showing on the oneclickdigital tab -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri May 12 04:24:32 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 12 May 2017 02:24:32 +0000 Subject: [Koha-bugs] [Bug 18585] Connect to RDF triplestore In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18585 David Cook changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |https://bugs.koha-community | |.org/bugzilla3/show_bug.cgi | |?id=10787 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri May 12 04:24:32 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 12 May 2017 02:24:32 +0000 Subject: [Koha-bugs] [Bug 10787] Linked Data/RDF Omnibus In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10787 David Cook changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |https://bugs.koha-community | |.org/bugzilla3/show_bug.cgi | |?id=18585 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri May 12 04:24:26 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 12 May 2017 02:24:26 +0000 Subject: [Koha-bugs] [Bug 18585] New: Connect to RDF triplestore Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18585 Bug ID: 18585 Summary: Connect to RDF triplestore Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Cataloging Assignee: gmcharlt at gmail.com Reporter: dcook at prosentient.com.au QA Contact: testopia at bugs.koha-community.org CC: m.de.rooy at rijksmuseum.nl In order to store RDF data, we need to be able to connect to a triplestore. This enhancement simply allows us to connect to a separate triplestore. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri May 12 07:04:10 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 12 May 2017 05:04:10 +0000 Subject: [Koha-bugs] [Bug 18585] Connect to RDF triplestore In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18585 David Cook changed: What |Removed |Added ---------------------------------------------------------------------------- Patch complexity|--- |Small patch Status|NEW |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri May 12 07:04:12 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 12 May 2017 05:04:12 +0000 Subject: [Koha-bugs] [Bug 18585] Connect to RDF triplestore In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18585 --- Comment #1 from David Cook --- Created attachment 63393 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=63393&action=edit Bug 18585 - Connect to RDF triplestore This commit adds a 'triplestore' method to C4::Context, which returns a RDF::Trine::Model object if triplestore.yaml is properly configured. (At the moment, it just supports RDF::Trine::Store::SPARQL, but it would be trivial to add support for RDF::Trine::Store::DBI too.) This code will provide a base from which people can use RDF::Trine for querying and updating a RDF triplestore. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri May 12 07:30:42 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 12 May 2017 05:30:42 +0000 Subject: [Koha-bugs] [Bug 18579] Problem with :Filter::MARC::EmbedItemsAvailability In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18579 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Patch complexity|--- |Small patch -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri May 12 07:30:45 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 12 May 2017 05:30:45 +0000 Subject: [Koha-bugs] [Bug 18579] Problem with :Filter::MARC::EmbedItemsAvailability In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18579 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #63389|0 |1 is obsolete| | Attachment #63390|0 |1 is obsolete| | --- Comment #6 from Katrin Fischer --- Created attachment 63394 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=63394&action=edit [SIGNED OFF] Bug 18579: Regression tests This patch makes sure the tests have the biblio.biblionumber mapping mocked so we test the case where the mapping is to a control field instead of just regular data fields (in the case of UNIMARC). To test: - Apply the patch - Run: $ prove t/db_dependent/Koha/Filter/EmbedItemsAvailability.t => FAIL: Tests fail due to an attemp to access a subfield on a control field. Sponsored-by: ByWater Solutions Signed-off-by: Katrin Fischer -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri May 12 07:31:31 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 12 May 2017 05:31:31 +0000 Subject: [Koha-bugs] [Bug 18579] Problem with :Filter::MARC::EmbedItemsAvailability In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18579 --- Comment #7 from Katrin Fischer --- Created attachment 63395 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=63395&action=edit [SIGNED OFF] Bug 18579: Make EmbedItemsAvailability handle control fields correctly This patch makes the EmbedItemsAvailability filter handle the biblio.biblionumber > control field mapping gracefully. Right now, it was assuming a regular data field was used, and such is not the case for UNIMARC (001). To test: - Apply the tests patch - Run: $ sudo koha-shell kohadev k$ cd kohaclone k$ prove t/db_dependent/Koha/Filter/EmbedItemsAvailability.t => FAIL: Tests fail to run - Apply this patch - Run: k$ prove t/db_dependent/Koha/Filter/EmbedItemsAvailability.t => SUCCESS: Tests pass! - Sign off :-D Sponsored-by: ByWater Solutions Signed-off-by: Katrin Fischer -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri May 12 07:31:48 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 12 May 2017 05:31:48 +0000 Subject: [Koha-bugs] [Bug 18579] Problem with :Filter::MARC::EmbedItemsAvailability In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18579 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off CC| |katrin.fischer at bsz-bw.de -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri May 12 07:35:43 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 12 May 2017 05:35:43 +0000 Subject: [Koha-bugs] [Bug 18326] Add Mojolicious as a required dependency In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18326 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Resolution|--- |FIXED Status|Needs Signoff |RESOLVED CC| |katrin.fischer at bsz-bw.de --- Comment #4 from Katrin Fischer --- I think this patch might be obsolete - it's already marked required on master: }, 'Mojolicious' => { 'usage' => 'REST API', 'required' => '1', 'min_ver' => '6.0', }, Not sure which status... choosing to close, please reopen if I am mistaken. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri May 12 07:41:11 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 12 May 2017 05:41:11 +0000 Subject: [Koha-bugs] [Bug 18579] Problem with :Filter::MARC::EmbedItemsAvailability In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18579 Marcel de Rooy changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #63394|0 |1 is obsolete| | Attachment #63395|0 |1 is obsolete| | --- Comment #8 from Marcel de Rooy --- Created attachment 63396 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=63396&action=edit Bug 18579: Regression tests This patch makes sure the tests have the biblio.biblionumber mapping mocked so we test the case where the mapping is to a control field instead of just regular data fields (in the case of UNIMARC). To test: - Apply the patch - Run: $ prove t/db_dependent/Koha/Filter/EmbedItemsAvailability.t => FAIL: Tests fail due to an attemp to access a subfield on a control field. Sponsored-by: ByWater Solutions Signed-off-by: Katrin Fischer Signed-off-by: Marcel de Rooy -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri May 12 07:41:16 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 12 May 2017 05:41:16 +0000 Subject: [Koha-bugs] [Bug 18579] Problem with :Filter::MARC::EmbedItemsAvailability In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18579 --- Comment #9 from Marcel de Rooy --- Created attachment 63397 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=63397&action=edit Bug 18579: Make EmbedItemsAvailability handle control fields correctly This patch makes the EmbedItemsAvailability filter handle the biblio.biblionumber > control field mapping gracefully. Right now, it was assuming a regular data field was used, and such is not the case for UNIMARC (001). To test: - Apply the tests patch - Run: $ sudo koha-shell kohadev k$ cd kohaclone k$ prove t/db_dependent/Koha/Filter/EmbedItemsAvailability.t => FAIL: Tests fail to run - Apply this patch - Run: k$ prove t/db_dependent/Koha/Filter/EmbedItemsAvailability.t => SUCCESS: Tests pass! - Sign off :-D Sponsored-by: ByWater Solutions Signed-off-by: Katrin Fischer Signed-off-by: Marcel de Rooy -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri May 12 07:41:08 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 12 May 2017 05:41:08 +0000 Subject: [Koha-bugs] [Bug 18579] Problem with :Filter::MARC::EmbedItemsAvailability In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18579 Marcel de Rooy changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri May 12 07:41:24 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 12 May 2017 05:41:24 +0000 Subject: [Koha-bugs] [Bug 17809] Correct some authorised values in fr-FR In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17809 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Failed QA CC| |katrin.fischer at bsz-bw.de --- Comment #16 from Katrin Fischer --- I am worried about the atomicupdate - it looks like only checks for the authorised value code, but not for the category, so this might lead to wrong warning messages. Some of those codes look like classifications we might have as collections in our databases for example. + my $number_cc = $schema->resultset('AuthorisedValue')->search( + { + authorised_value => 'CC' + } + )->count; + if ( $number_cc > 1 ) { -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri May 12 07:41:34 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 12 May 2017 05:41:34 +0000 Subject: [Koha-bugs] [Bug 18579] Problem with :Filter::MARC::EmbedItemsAvailability In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18579 Marcel de Rooy changed: What |Removed |Added ---------------------------------------------------------------------------- QA Contact|testopia at bugs.koha-communit |m.de.rooy at rijksmuseum.nl |y.org | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri May 12 07:44:09 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 12 May 2017 05:44:09 +0000 Subject: [Koha-bugs] [Bug 18400] Noisy warns in opac-search.pl during itemtype sorting In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18400 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|oleonard at myacpl.org |nick at bywatersolutions.com CC| |katrin.fischer at bsz-bw.de -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri May 12 07:48:57 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 12 May 2017 05:48:57 +0000 Subject: [Koha-bugs] [Bug 18400] Noisy warns in opac-search.pl during itemtype sorting In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18400 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off --- Comment #5 from Katrin Fischer --- Looks like Marc actually signed off, but status wasn't switched! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri May 12 07:50:45 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 12 May 2017 05:50:45 +0000 Subject: [Koha-bugs] [Bug 18204] Authority searches are not saved in Search history In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18204 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |katrin.fischer at bsz-bw.de Attachment #60809|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri May 12 07:53:39 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 12 May 2017 05:53:39 +0000 Subject: [Koha-bugs] [Bug 18204] Authority searches are not saved in Search history In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18204 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Patch complexity|--- |Trivial patch Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri May 12 07:53:43 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 12 May 2017 05:53:43 +0000 Subject: [Koha-bugs] [Bug 18204] Authority searches are not saved in Search history In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18204 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #63387|0 |1 is obsolete| | --- Comment #4 from Katrin Fischer --- Created attachment 63398 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=63398&action=edit [SIGNED OFF] Bug 18204 - Authority searches are not saved in Search history When you search an authority in Authority search, this search is not saved in Search history. EnableOpacSearchHistory is enabled Steps to test: 1- Login your account (opac) 2- Search an authority in Authority search 3- Go to Search history -> Authority 4- It says "Your authority search history is empty" Signed-off-by: Katrin Fischer -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri May 12 07:54:26 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 12 May 2017 05:54:26 +0000 Subject: [Koha-bugs] [Bug 18055] Speed up '00-strict.t' test In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18055 Marcel de Rooy changed: What |Removed |Added ---------------------------------------------------------------------------- Severity|normal |enhancement CC| |m.de.rooy at rijksmuseum.nl --- Comment #25 from Marcel de Rooy --- Marking this as an enhancement rather than a bugfix. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri May 12 07:54:50 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 12 May 2017 05:54:50 +0000 Subject: [Koha-bugs] [Bug 18204] Authority searches are not saved in Search history In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18204 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Severity|normal |major --- Comment #5 from Katrin Fischer --- Hi, thx for the patch! Is this a first? I have noticed the author line reads: From: LeireDiez Is this how you want it? The names will show up on the dashboard and in the release notes :) -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri May 12 07:57:58 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 12 May 2017 05:57:58 +0000 Subject: [Koha-bugs] [Bug 18383] items.onloan schema comment seems to be incorrect. In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18383 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |katrin.fischer at bsz-bw.de --- Comment #2 from Katrin Fischer --- Hi Pongtawat, thx for the patch! Please remember to switch the status from NEW to "Needs Sign-off" after attaching a patch, otherwise this will not show up in people's searches and can get be overlooked. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri May 12 07:58:08 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 12 May 2017 05:58:08 +0000 Subject: [Koha-bugs] [Bug 18383] items.onloan schema comment seems to be incorrect. In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18383 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff Version|16.11 |master -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri May 12 07:59:47 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 12 May 2017 05:59:47 +0000 Subject: [Koha-bugs] [Bug 18383] items.onloan schema comment seems to be incorrect. In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18383 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Patch complexity|--- |String patch Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri May 12 07:59:50 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 12 May 2017 05:59:50 +0000 Subject: [Koha-bugs] [Bug 18383] items.onloan schema comment seems to be incorrect. In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18383 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #61844|0 |1 is obsolete| | --- Comment #3 from Katrin Fischer --- Created attachment 63399 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=63399&action=edit [SIGNED OFF] Bug 18383 - Correct items.onloan schema comment Signed-off-by: Katrin Fischer -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri May 12 08:00:33 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 12 May 2017 06:00:33 +0000 Subject: [Koha-bugs] [Bug 18537] Update Ukrainian installer sample files for 17.05 In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18537 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |katrin.fischer at bsz-bw.de Status|NEW |Needs Signoff --- Comment #1 from Katrin Fischer --- Don't forget to switch to "needs sign-off"! :) -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Fri May 12 08:01:08 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 12 May 2017 06:01:08 +0000 Subject: [Koha-bugs] [Bug 18444] Add TalkingTechItivaPhoneNotification to sysprefs.sql In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18444 Marcel de Rooy changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri May 12 08:01:11 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 12 May 2017 06:01:11 +0000 Subject: [Koha-bugs] [Bug 18444] Add TalkingTechItivaPhoneNotification to sysprefs.sql In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18444 Marcel de Rooy changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #62917|0 |1 is obsolete| | --- Comment #5 from Marcel de Rooy --- Created attachment 63400 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=63400&action=edit Bug 18444: Add TalkingTechItivaPhoneNotification to sysprefs.sql Signed-off-by: Katrin Fischer Signed-off-by: Marcel de Rooy -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri May 12 08:01:22 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 12 May 2017 06:01:22 +0000 Subject: [Koha-bugs] [Bug 18444] Add TalkingTechItivaPhoneNotification to sysprefs.sql In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18444 Marcel de Rooy changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |m.de.rooy at rijksmuseum.nl QA Contact|testopia at bugs.koha-communit |m.de.rooy at rijksmuseum.nl |y.org | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri May 12 08:04:17 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 12 May 2017 06:04:17 +0000 Subject: [Koha-bugs] [Bug 18376] authority framework creation fails under Plack In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18376 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |katrin.fischer at bsz-bw.de --- Comment #3 from Katrin Fischer --- I can see the error, trying to sign off. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri May 12 08:06:27 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 12 May 2017 06:06:27 +0000 Subject: [Koha-bugs] [Bug 18376] authority framework creation fails under Plack In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18376 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Severity|minor |normal -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri May 12 08:07:13 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 12 May 2017 06:07:13 +0000 Subject: [Koha-bugs] [Bug 18376] authority framework creation fails under Plack In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18376 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri May 12 08:07:17 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 12 May 2017 06:07:17 +0000 Subject: [Koha-bugs] [Bug 18376] authority framework creation fails under Plack In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18376 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #61817|0 |1 is obsolete| | --- Comment #4 from Katrin Fischer --- Created attachment 63401 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=63401&action=edit [SIGNED OFF] Bug 18376 - authority framework creation fails under Plack With plack, when creating a new authority framework from another, you get the error : Can't call method "prepare" on an undefined value at (...)/src/admin/auth_tag_structure.pl line 267. Looks like plack does not like when the var $dbh from the script is called inside a sub. This patch adds a local var $dbh inside sub duplicate_auth_framework(), like in sub StringSearch(). Also correctes a redefine of my $sth. Test plan: - Go to Administration > Authority types - Create a new type - On this new type click on Actions > MARC Structure - Select another type and click OK => You must get a table filled with the tag structure Check with and without plack You may not be able to reproduce the error with plack. Signed-off-by: Katrin Fischer -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri May 12 08:13:14 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 12 May 2017 06:13:14 +0000 Subject: [Koha-bugs] [Bug 15924] Coce not enabled on lists In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15924 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |katrin.fischer at bsz-bw.de --- Comment #4 from Katrin Fischer --- Hi Nick, I think you mentioned a test server for Coce a while ago, is this still available for testing? -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri May 12 08:17:16 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 12 May 2017 06:17:16 +0000 Subject: [Koha-bugs] [Bug 18581] Add standard edit and delete buttons to suggestions list In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18581 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #63385|0 |1 is obsolete| | --- Comment #2 from Katrin Fischer --- Created attachment 63402 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=63402&action=edit [SIGNED OFF] Bug 18581 - Add standard edit and delete buttons to suggestions list This patch modifies the table of suggestions in the staff client, moving the edit link to the standard last column and styling it correctly. A delete button is added as well. Unrelated change: I removed the column containing suggestionid because I don't think it's human-relevant information. To test, apply the patch and go to Acquisitions -> Suggestions. - In each tab, the table of suggestions should have an unsorted last column containing "edit" and "delete" links which should be styled correctly and working correctly. - On the detailed view of a suggestion, the "delete" button in the toolbar should still work correctly. Signed-off-by: Katrin Fischer -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri May 12 08:17:13 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 12 May 2017 06:17:13 +0000 Subject: [Koha-bugs] [Bug 18581] Add standard edit and delete buttons to suggestions list In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18581 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri May 12 08:18:43 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 12 May 2017 06:18:43 +0000 Subject: [Koha-bugs] [Bug 16116] Change of issue publication date doesn' t reflect on the next issue generated In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16116 Marcel de Rooy changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Failed QA --- Comment #10 from Marcel de Rooy --- Moving this patch out of the SO queue for now. This should not be pushed in its current form just before release. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri May 12 08:35:57 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 12 May 2017 06:35:57 +0000 Subject: [Koha-bugs] [Bug 10267] No error message when entering an invalid cardnumber In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10267 Marcel de Rooy changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Failed QA CC| |m.de.rooy at rijksmuseum.nl --- Comment #14 from Marcel de Rooy --- Hmm I do not really understand why we need this message. You cannot type more than 16 chars or paste them. There is a hint that it should be between 1 and 16. Currently, the message shows up at 16 chars. This makes me think that I entered too much chars, but I did not. I think that if we want to do something on this matter, we need to search for another angle. But I am not convinced that we should; the hint is clear to me. We could allow more than 16 chars and then mark it red or something ? -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri May 12 08:37:07 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 12 May 2017 06:37:07 +0000 Subject: [Koha-bugs] [Bug 18585] Connect to RDF triplestore In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18585 Magnus Enger changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |magnus at libriotech.no -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri May 12 08:48:51 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 12 May 2017 06:48:51 +0000 Subject: [Koha-bugs] [Bug 18545] Remove use of onclick from OPAC Cart In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18545 Marcel de Rooy changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Failed QA CC| |m.de.rooy at rijksmuseum.nl --- Comment #5 from Marcel de Rooy --- If I add two items to the cart, and I select them both by clicking All, and than deselect the first one, and than click Remove, all items are cleared from the cart. Failed QA -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri May 12 08:49:54 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 12 May 2017 06:49:54 +0000 Subject: [Koha-bugs] [Bug 18586] New: Create module to mint RDF subject URIs Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18586 Bug ID: 18586 Summary: Create module to mint RDF subject URIs Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Cataloging Assignee: gmcharlt at gmail.com Reporter: dcook at prosentient.com.au QA Contact: testopia at bugs.koha-community.org CC: m.de.rooy at rijksmuseum.nl In the relational database, we use biblionumber as the ID for bibliographic records, but a triplestore we need to use a RDF URI. So I'm going to put together a module with a little method for minting URIs. While we could just agree on a convention, it probably makes sense to use the convention in the module and then use the module elsewhere to keep things consistent. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri May 12 08:50:03 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 12 May 2017 06:50:03 +0000 Subject: [Koha-bugs] [Bug 10787] Linked Data/RDF Omnibus In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10787 David Cook changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |https://bugs.koha-community | |.org/bugzilla3/show_bug.cgi | |?id=18586 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri May 12 08:50:03 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 12 May 2017 06:50:03 +0000 Subject: [Koha-bugs] [Bug 18586] Create module to mint RDF subject URIs In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18586 David Cook changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |https://bugs.koha-community | |.org/bugzilla3/show_bug.cgi | |?id=10787 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri May 12 08:54:26 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 12 May 2017 06:54:26 +0000 Subject: [Koha-bugs] [Bug 18585] Connect to RDF triplestore In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18585 --- Comment #2 from David Cook --- Created attachment 63403 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=63403&action=edit Bug 18585 - Connect to RDF triplestore (add dependency) Add RDF::Trine to the list of Perl dependencies -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri May 12 08:56:26 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 12 May 2017 06:56:26 +0000 Subject: [Koha-bugs] [Bug 18430] Plugins page should have a link to viewing other types In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18430 Marcel de Rooy changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |m.de.rooy at rijksmuseum.nl Attachment #62150|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri May 12 08:56:52 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 12 May 2017 06:56:52 +0000 Subject: [Koha-bugs] [Bug 18430] Plugins page should have a link to viewing other types In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18430 Marcel de Rooy changed: What |Removed |Added ---------------------------------------------------------------------------- QA Contact|testopia at bugs.koha-communit |m.de.rooy at rijksmuseum.nl |y.org | Severity|normal |enhancement --- Comment #4 from Marcel de Rooy --- Marking as an enhancement. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri May 12 09:08:13 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 12 May 2017 07:08:13 +0000 Subject: [Koha-bugs] [Bug 18529] Template cleanup of patron clubs pages In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18529 Marcel de Rooy changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri May 12 09:08:17 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 12 May 2017 07:08:17 +0000 Subject: [Koha-bugs] [Bug 18529] Template cleanup of patron clubs pages In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18529 Marcel de Rooy changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #63024|0 |1 is obsolete| | --- Comment #3 from Marcel de Rooy --- Created attachment 63404 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=63404&action=edit Bug 18529 - Template cleanup of patron clubs pages This patch addresses template issues with the newly-added patron clubs pages. - Move Clubs tab out of second position in Circulation page tabs. - Link patron name in enrollments list to the patron record - Make page titles on some pages more specific - Correct label "for" attributes so that it matches input id - Correst style of buttons: Buttons in tables must be "btn-xs," all Bootstrap buttons must have "btn-default." - Correct "Edit" icons: Should be "fa-pencil" This patch also revises the club template editing form to make it more consistent with similar interfaces in Koha and (hopefully) make it more clear. To test, apply the patch and test adding clubs and club templates and enrolling patrons in clubs via the staff client and OPAC. Confirm that everything looks and work okay. Signed-off-by: Josef Moravec Signed-off-by: Marcel de Rooy -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri May 12 09:08:46 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 12 May 2017 07:08:46 +0000 Subject: [Koha-bugs] [Bug 11122] Fix display of publication year/ copyrightdate and publishercode on various pages in acquisitions In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11122 Josef Moravec changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri May 12 09:08:50 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 12 May 2017 07:08:50 +0000 Subject: [Koha-bugs] [Bug 11122] Fix display of publication year/ copyrightdate and publishercode on various pages in acquisitions In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11122 Josef Moravec changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #62935|0 |1 is obsolete| | Attachment #62936|0 |1 is obsolete| | Attachment #62937|0 |1 is obsolete| | --- Comment #35 from Josef Moravec --- Created attachment 63405 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=63405&action=edit [SIGNED-OFF] Bug 11122 - publisher code and publication year not fetched in acq orders In acquisition, several templates try to display publisher code and publication year : invoice.tt, parcel.tt, transferorder.tt. Thoses pages use C4::Acquisition methods GetPendingOrders or GetInvoiceDetails. The bug is that in the SQL query of those methods, biblioitems.publishercode and biblioitems.publicationyear. In uncertainprice.pl those datas are fetch using GetBiblioData. It whould be better to fetch them in GetPendingOrders and GetInvoiceDetails. This patch changes SQL queries to fetch wanted datas : aqorders.*,biblio.title,biblio.author,biblioitems.isbn,biblioitems.publishercode,biblioitems.publicationyear. GetInvoiceDetails also needs : biblio.seriestitle,biblioitems.volume. This patch also unifies the way biblio datas are displayed : [title] by [author] – [isbn] Publisher: [publishercode], [publicationyear] Test plan : - Choose a biblio record containing a data in : biblio.title, biblio.author, biblioitems.isbn, biblioitems.publishercode, biblioitems.publicationyear, biblio.seriestitle, biblioitems.volume. - Create an order using this biblio. - Look at this order in pages : parcel.pl, transferorder.pl, uncertainprice.pl => You see publisher code and publication year - Look at this order in page : invoice.pl => You see publisher code, publication year, series title and volume Signed-off-by: Katrin Fischer Signed-off-by: Josef Moravec -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri May 12 09:08:56 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 12 May 2017 07:08:56 +0000 Subject: [Koha-bugs] [Bug 11122] Fix display of publication year/ copyrightdate and publishercode on various pages in acquisitions In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11122 --- Comment #36 from Josef Moravec --- Created attachment 63406 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=63406&action=edit [SIGNED-OFF] Bug 11122: Address MARC21 vs. UNIMARC issue In comment #6 and comment #17, Katrin pointed out the discrepancy between UNIMARC (using publisheryear) vs. Other MARC installations (using copyrightdate). This was dealt with in invoice.tt already. This patch does similar logic for the other 3 template files. Signed-off-by: Katrin Fischer Signed-off-by: Josef Moravec -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri May 12 09:09:07 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 12 May 2017 07:09:07 +0000 Subject: [Koha-bugs] [Bug 11122] Fix display of publication year/ copyrightdate and publishercode on various pages in acquisitions In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11122 --- Comment #37 from Josef Moravec --- Created attachment 63407 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=63407&action=edit [SIGNED-OFF] Bug 11122: Follow up - Fix some display issues and typos This patch fixes the display of copyrightdate for MARC21 installations. As MARC21 already requires you to add punctuation in cataloguing, there is usually no need for punctutation in the templates. Also fixes a template variable name typo and the basket summary page. To test (all 3 patches): - Add several order lines to an order, one should be uncertain - Verify that the publisher and publication year are displayed - Check the uncertain price page - Verify that the publisher code and publication year are displayed - Fix uncertain price and close your order - Basket summary: Verify... (you know what) - Cancel one of your orders - Verify... for cancelled orders - Receive shipment - Verify... for unreceived orders - Receive order - Verify ... for received orders - Finish receiving - Verify ... on the invoice summary page Signed-off-by: Josef Moravec -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri May 12 09:10:07 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 12 May 2017 07:10:07 +0000 Subject: [Koha-bugs] [Bug 18370] Columns settings patrons>id=memberresultst : display bug In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18370 Julian Maurice changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #61870|0 |1 is obsolete| | --- Comment #12 from Julian Maurice --- Created attachment 63408 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=63408&action=edit Bug 18370: Columns visibility on patron search - Hide the correct column When a column is hidden by default on the patron search result table, if the logged in user does not have the "tools > manage_patron_lists" permission, the wrong column will be hidden. Test plan: Edit the column visibility detail for "Patrons > id=memberresultst" Set "Fines" hidden by default Search for patrons => Without this patch, if the logged in user does not have the manage_patron_lists permission, the wrong column will be hidden/displayed. Signed-off-by: S?verine Queune Signed-off-by: Julian Maurice -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri May 12 09:10:13 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 12 May 2017 07:10:13 +0000 Subject: [Koha-bugs] [Bug 18370] Columns settings patrons>id=memberresultst : display bug In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18370 Julian Maurice changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #63388|0 |1 is obsolete| | --- Comment #13 from Julian Maurice --- Created attachment 63409 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=63409&action=edit Bug 18370: Use splice instead of splice Signed-off-by: Julian Maurice -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri May 12 09:10:26 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 12 May 2017 07:10:26 +0000 Subject: [Koha-bugs] [Bug 18370] Columns settings patrons>id=memberresultst : display bug In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18370 Julian Maurice changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri May 12 09:12:31 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 12 May 2017 07:12:31 +0000 Subject: [Koha-bugs] [Bug 18529] Template cleanup of patron clubs pages In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18529 Marcel de Rooy changed: What |Removed |Added ---------------------------------------------------------------------------- QA Contact|testopia at bugs.koha-communit |m.de.rooy at rijksmuseum.nl |y.org | CC| |m.de.rooy at rijksmuseum.nl --- Comment #4 from Marcel de Rooy --- Looks good to me while glancing thru template changes and testing it 'diagonally'. Kyle: If I am not mistaken, you know the feature well. Please have a look too. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri May 12 09:14:42 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 12 May 2017 07:14:42 +0000 Subject: [Koha-bugs] [Bug 10787] Linked Data/RDF Omnibus In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10787 Magnus Enger changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on| |18585 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18585 [Bug 18585] Connect to RDF triplestore -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri May 12 09:14:42 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 12 May 2017 07:14:42 +0000 Subject: [Koha-bugs] [Bug 18585] Connect to RDF triplestore In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18585 Magnus Enger changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |10787 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10787 [Bug 10787] Linked Data/RDF Omnibus -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri May 12 09:14:58 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 12 May 2017 07:14:58 +0000 Subject: [Koha-bugs] [Bug 10788] Add a Linked Data/RDF browser to the OPAC In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10788 Magnus Enger changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on| |18585 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18585 [Bug 18585] Connect to RDF triplestore -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri May 12 09:14:58 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 12 May 2017 07:14:58 +0000 Subject: [Koha-bugs] [Bug 18585] Connect to RDF triplestore In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18585 Magnus Enger changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |10788 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10788 [Bug 10788] Add a Linked Data/RDF browser to the OPAC -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri May 12 09:21:56 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 12 May 2017 07:21:56 +0000 Subject: [Koha-bugs] [Bug 18579] Problem with :Filter::MARC::EmbedItemsAvailability In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18579 Julian Maurice changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Failed QA --- Comment #10 from Julian Maurice --- There are still problems in a UNIMARC setup: # Failed test 'EmbedItemsAvailability tests' # at t/db_dependent/Koha/Filter/EmbedItemsAvailability.t line 151. Can't call method "subfield" on an undefined value at t/db_dependent/Koha/Filter/EmbedItemsAvailability.t line 145. and rebuild_zebra.pl die with: Arguments must be MARC::Field objects at /home/koha/env/master/src/Koha/Filter/MARC/EmbedItemsAvailability.pm line 93 I'm working on a patch -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri May 12 09:22:37 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 12 May 2017 07:22:37 +0000 Subject: [Koha-bugs] [Bug 14625] LDAP: mapped ExtendedPatronAttributes cause error when updated on authentication In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14625 --- Comment #10 from Martin Renvoize --- Code looks sane and does the trick.. but we'll need an update to the unit tests to cover the change before it'll get past QA. Oliver, are you happy to have a go at adding a test to Auth_with_ldap.t? -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri May 12 09:22:52 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 12 May 2017 07:22:52 +0000 Subject: [Koha-bugs] [Bug 14625] LDAP: mapped ExtendedPatronAttributes cause error when updated on authentication In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14625 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Failed QA -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri May 12 09:24:20 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 12 May 2017 07:24:20 +0000 Subject: [Koha-bugs] [Bug 14625] LDAP: mapped ExtendedPatronAttributes cause error when updated on authentication In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14625 --- Comment #11 from Martin Renvoize --- Created attachment 63410 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=63410&action=edit Bug 14625 - LDAP: skip extended patron attributes in 'borrowers' attribute update * Any extended patron attributes will cause the update to fail as those attributes don't exist in the 'borrowers' table * The update of the extended patron attributes is already dealt with in checkpw_ldap() * Ergo: just skip those attributes here Signed-off-by: Martin Renvoize -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri May 12 09:24:45 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 12 May 2017 07:24:45 +0000 Subject: [Koha-bugs] [Bug 14625] LDAP: mapped ExtendedPatronAttributes cause error when updated on authentication In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14625 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #45222|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri May 12 09:25:07 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 12 May 2017 07:25:07 +0000 Subject: [Koha-bugs] [Bug 14625] LDAP: mapped ExtendedPatronAttributes cause error when updated on authentication In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14625 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #63410|Bug 14625 - LDAP: skip |[SIGNED OFF] Bug 14625 - description|extended patron attributes |LDAP: skip extended patron |in 'borrowers' attribute |attributes in 'borrowers' |update |attribute update -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri May 12 09:27:02 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 12 May 2017 07:27:02 +0000 Subject: [Koha-bugs] [Bug 18579] Problem with :Filter::MARC::EmbedItemsAvailability In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18579 --- Comment #11 from Marcel de Rooy --- Good catch Julian. (Poor Tomas ;) -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri May 12 09:27:11 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 12 May 2017 07:27:11 +0000 Subject: [Koha-bugs] [Bug 18585] Connect to RDF triplestore In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18585 Josef Moravec changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri May 12 09:27:14 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 12 May 2017 07:27:14 +0000 Subject: [Koha-bugs] [Bug 18585] Connect to RDF triplestore In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18585 Josef Moravec changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #63393|0 |1 is obsolete| | Attachment #63403|0 |1 is obsolete| | --- Comment #3 from Josef Moravec --- Created attachment 63411 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=63411&action=edit [SIGNED-OFF] Bug 18585 - Connect to RDF triplestore This commit adds a 'triplestore' method to C4::Context, which returns a RDF::Trine::Model object if triplestore.yaml is properly configured. (At the moment, it just supports RDF::Trine::Store::SPARQL, but it would be trivial to add support for RDF::Trine::Store::DBI too.) This code will provide a base from which people can use RDF::Trine for querying and updating a RDF triplestore. Signed-off-by: Josef Moravec -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri May 12 09:27:18 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 12 May 2017 07:27:18 +0000 Subject: [Koha-bugs] [Bug 18585] Connect to RDF triplestore In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18585 --- Comment #4 from Josef Moravec --- Created attachment 63412 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=63412&action=edit [SIGNED-OFF] Bug 18585 - Connect to RDF triplestore (add dependency) Add RDF::Trine to the list of Perl dependencies Signed-off-by: Josef Moravec -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri May 12 09:27:22 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 12 May 2017 07:27:22 +0000 Subject: [Koha-bugs] [Bug 18585] Connect to RDF triplestore In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18585 --- Comment #5 from Josef Moravec --- Created attachment 63413 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=63413&action=edit [SIGNED-OFF] Bug 18585 - Followup - fix pod Signed-off-by: Josef Moravec -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri May 12 09:29:12 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 12 May 2017 07:29:12 +0000 Subject: [Koha-bugs] [Bug 18400] Noisy warns in opac-search.pl during itemtype sorting In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18400 Marcel de Rooy changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |m.de.rooy at rijksmuseum.nl --- Comment #6 from Marcel de Rooy --- QA: Looking here now -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri May 12 09:32:02 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 12 May 2017 07:32:02 +0000 Subject: [Koha-bugs] [Bug 14625] LDAP: mapped ExtendedPatronAttributes cause error when updated on authentication In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14625 --- Comment #12 from Martin Renvoize --- I've signed off the proposed patch, but marked the overall bug as failed qa untill we have test coverage. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri May 12 09:34:19 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 12 May 2017 07:34:19 +0000 Subject: [Koha-bugs] [Bug 18579] Problem with :Filter::MARC::EmbedItemsAvailability In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18579 --- Comment #12 from Julian Maurice --- Created attachment 63414 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=63414&action=edit Bug 18579: Fix call to append_fields, fix tests MARC::Record::append_fields takes a list of MARC::Field (not an arrayref) Use $record->subfield() instead of $record->field()->subfield() to avoid errors when field doesn't exist -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri May 12 09:35:37 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 12 May 2017 07:35:37 +0000 Subject: [Koha-bugs] [Bug 14625] LDAP: mapped ExtendedPatronAttributes cause error when updated on authentication In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14625 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |tomascohen at gmail.com -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri May 12 09:37:50 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 12 May 2017 07:37:50 +0000 Subject: [Koha-bugs] [Bug 18579] Problem with :Filter::MARC::EmbedItemsAvailability In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18579 Julian Maurice changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |Signed Off --- Comment #13 from Julian Maurice --- Back to Signed off -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri May 12 09:38:58 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 12 May 2017 07:38:58 +0000 Subject: [Koha-bugs] [Bug 14625] LDAP: mapped ExtendedPatronAttributes cause error when updated on authentication In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14625 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- Priority|P5 - low |P3 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri May 12 09:39:06 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 12 May 2017 07:39:06 +0000 Subject: [Koha-bugs] [Bug 14625] LDAP: mapped ExtendedPatronAttributes cause error when updated on authentication In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14625 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- QA Contact|testopia at bugs.koha-communit |martin.renvoize at ptfs-europe |y.org |.com -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri May 12 09:59:40 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 12 May 2017 07:59:40 +0000 Subject: [Koha-bugs] [Bug 14625] LDAP: mapped ExtendedPatronAttributes cause error when updated on authentication In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14625 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |Signed Off --- Comment #13 from Martin Renvoize --- On second thoughts, as update_local isn't currently tested at all I think perhaps it widens the scope a bit too much to expect you to write the tests. I'll open another bug to write the tests for the whole of update_local and hopefully I'll get around to writing them this century! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri May 12 10:00:54 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 12 May 2017 08:00:54 +0000 Subject: [Koha-bugs] [Bug 18579] Problem with :Filter::MARC::EmbedItemsAvailability In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18579 Marcel de Rooy changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri May 12 10:00:58 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 12 May 2017 08:00:58 +0000 Subject: [Koha-bugs] [Bug 18579] Problem with :Filter::MARC::EmbedItemsAvailability In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18579 Marcel de Rooy changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #63414|0 |1 is obsolete| | --- Comment #14 from Marcel de Rooy --- Created attachment 63415 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=63415&action=edit Bug 18579: Fix call to append_fields, fix tests MARC::Record::append_fields takes a list of MARC::Field (not an arrayref) Use $record->subfield() instead of $record->field()->subfield() to avoid errors when field doesn't exist Signed-off-by: Marcel de Rooy -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri May 12 10:02:55 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 12 May 2017 08:02:55 +0000 Subject: [Koha-bugs] [Bug 18587] New: LDAP: update_local is entirely untested! Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18587 Bug ID: 18587 Summary: LDAP: update_local is entirely untested! Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: major Priority: P3 Component: Authentication Assignee: gmcharlt at gmail.com Reporter: martin.renvoize at ptfs-europe.com QA Contact: testopia at bugs.koha-community.org CC: dpavlin at rot13.org, gmcharlt at gmail.com, hblancoca at gmail.com, katrin.fischer at bsz-bw.de, martin.renvoize at ptfs-europe.com, mtj at kohaaloha.com, oliver.bock at aei.mpg.de, tomascohen at gmail.com Depends on: 14625 The update_local routine inside C4/Auth_with_ldap.pm is entirely untested :(. Reading the code, there are assumptions within it that don't hold true either. For instance, it is assumed that the routine always returns 'cardnumber', when in fact, it can return 'undef' or an integer specifying the number of rows updated by the procedure.. which should only ever be '1'. Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14625 [Bug 14625] LDAP: mapped ExtendedPatronAttributes cause error when updated on authentication -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri May 12 10:02:55 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 12 May 2017 08:02:55 +0000 Subject: [Koha-bugs] [Bug 14625] LDAP: mapped ExtendedPatronAttributes cause error when updated on authentication In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14625 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |18587 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18587 [Bug 18587] LDAP: update_local is entirely untested! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri May 12 10:06:35 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 12 May 2017 08:06:35 +0000 Subject: [Koha-bugs] [Bug 14625] LDAP: mapped ExtendedPatronAttributes cause error when updated on authentication In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14625 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- QA Contact|martin.renvoize at ptfs-europe |testopia at bugs.koha-communit |.com |y.org -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri May 12 10:15:49 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 12 May 2017 08:15:49 +0000 Subject: [Koha-bugs] [Bug 18204] Authority searches are not saved in Search history In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18204 --- Comment #6 from leire at scanbit.net --- Hi, Yes, it's my first patch! But my plan is to upload fixes that I will solve. My name is Leire D?ez, I've seen that it usually shows up the person's name and last name, so I think that's fine. Thanks you! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri May 12 10:18:41 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 12 May 2017 08:18:41 +0000 Subject: [Koha-bugs] [Bug 18537] Update Ukrainian installer sample files for 17.05 In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18537 --- Comment #2 from Serhij Dubyk --- (In reply to Katrin Fischer from comment #1) > Don't forget to switch to "needs sign-off"! :) Thanks, Katrin! -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Fri May 12 10:33:20 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 12 May 2017 08:33:20 +0000 Subject: [Koha-bugs] [Bug 18400] Noisy warns in opac-search.pl during itemtype sorting In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18400 Marcel de Rooy changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |https://bugs.koha-community | |.org/bugzilla3/show_bug.cgi | |?id=10937 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri May 12 10:33:20 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 12 May 2017 08:33:20 +0000 Subject: [Koha-bugs] [Bug 10937] Advanced search: Hide itemtypes from search form & Group itemtypes together into one search option In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10937 Marcel de Rooy changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |m.de.rooy at rijksmuseum.nl See Also| |https://bugs.koha-community | |.org/bugzilla3/show_bug.cgi | |?id=18400 --- Comment #66 from Marcel de Rooy --- Adding a see also to bug 18400. The functionality around ITEMTYPECAT looks pretty weird to me btw. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri May 12 10:37:37 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 12 May 2017 08:37:37 +0000 Subject: [Koha-bugs] [Bug 17618] perl-modules Debian package name change in Perl 5.22 In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17618 Mirko Tietgen changed: What |Removed |Added ---------------------------------------------------------------------------- Severity|enhancement |normal -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri May 12 11:04:51 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 12 May 2017 09:04:51 +0000 Subject: [Koha-bugs] [Bug 18400] Noisy warns in opac-search.pl during itemtype sorting In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18400 Marcel de Rooy changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri May 12 11:04:54 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 12 May 2017 09:04:54 +0000 Subject: [Koha-bugs] [Bug 18400] Noisy warns in opac-search.pl during itemtype sorting In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18400 Marcel de Rooy changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #62232|0 |1 is obsolete| | --- Comment #7 from Marcel de Rooy --- Created attachment 63416 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=63416&action=edit Bug 18400 - Noisy warns in opac-search.pl during itemtype sorting To fix the warns we use a copy of itemtypes which is not touched by other code To test: Apply patches Ensure search still works Followed test plan, search works as expected. Signed-off-by: Marc V?ron Signed-off-by: Marcel de Rooy -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri May 12 11:04:59 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 12 May 2017 09:04:59 +0000 Subject: [Koha-bugs] [Bug 18400] Noisy warns in opac-search.pl during itemtype sorting In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18400 --- Comment #8 from Marcel de Rooy --- Created attachment 63417 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=63417&action=edit Bug 18400: [QA Follow-up] Move sort outside the loop GetItemTypesCategorized can return descriptions that are still undef since Authorized values does not enforce a description in lib and lib_opac. When I add one ITEMTYPECAT auth value without descriptions, I can still generate the string comparison warnings on the itemtypes sort. In order to prevent the warning, we should add an empty string in the assignment on line 229. We do not need to copy the itemtypes hash if we move the sort outside the @advanced_search_types foreach. There is no need to sort it more than once. Note that I did not see any reasons btw for corruption of the structure inside this loop. Note: If we use ITEMTYPECAT without descriptions, we should probably leave them out. No need to show a checkbox without description on Advanced Search, but I would recommend to solve that on its own report. The whole ITEMTYPECAT functionality has imo not been designed properly. Signed-off-by: Marcel de Rooy -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri May 12 11:05:36 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 12 May 2017 09:05:36 +0000 Subject: [Koha-bugs] [Bug 18400] Noisy warns in opac-search.pl during itemtype sorting In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18400 Marcel de Rooy changed: What |Removed |Added ---------------------------------------------------------------------------- Patch complexity|--- |Small patch QA Contact|testopia at bugs.koha-communit |m.de.rooy at rijksmuseum.nl |y.org | Version|16.11 |master -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri May 12 11:06:05 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 12 May 2017 09:06:05 +0000 Subject: [Koha-bugs] [Bug 18400] Noisy warns in opac-search.pl during itemtype sorting In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18400 --- Comment #9 from Marcel de Rooy --- QA Comment: See commit message of the follow-up. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri May 12 11:06:24 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 12 May 2017 09:06:24 +0000 Subject: [Koha-bugs] [Bug 17618] perl-modules Debian package name change in Perl 5.22 In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17618 --- Comment #5 from Mirko Tietgen --- Created attachment 63418 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=63418&action=edit Bug 17618 - perl-modules Debian package name change Newer versios of perl-modules have a version number in the package name. This patch makes Koha aware of perl-modules-5.22 and perl-modules-5.24 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri May 12 11:06:48 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 12 May 2017 09:06:48 +0000 Subject: [Koha-bugs] [Bug 17618] perl-modules Debian package name change In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17618 Mirko Tietgen changed: What |Removed |Added ---------------------------------------------------------------------------- Summary|perl-modules Debian package |perl-modules Debian package |name change in Perl 5.22 |name change -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri May 12 11:07:14 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 12 May 2017 09:07:14 +0000 Subject: [Koha-bugs] [Bug 17618] perl-modules Debian package name change In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17618 Mirko Tietgen changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #57464|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri May 12 11:07:24 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 12 May 2017 09:07:24 +0000 Subject: [Koha-bugs] [Bug 17618] perl-modules Debian package name change In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17618 Mirko Tietgen changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #57465|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri May 12 11:15:30 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 12 May 2017 09:15:30 +0000 Subject: [Koha-bugs] [Bug 18153] UNIMARC bib records exported with invalid 'a' char in label pos.9 In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18153 --- Comment #11 from Julian Maurice --- QAing this now -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri May 12 11:17:41 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 12 May 2017 09:17:41 +0000 Subject: [Koha-bugs] [Bug 17853] MARC21: Don't remove () from link text for 780/785 In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17853 Marcel de Rooy changed: What |Removed |Added ---------------------------------------------------------------------------- QA Contact|testopia at bugs.koha-communit |m.de.rooy at rijksmuseum.nl |y.org | CC| |m.de.rooy at rijksmuseum.nl --- Comment #13 from Marcel de Rooy --- QA: Looking here now -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri May 12 11:29:14 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 12 May 2017 09:29:14 +0000 Subject: [Koha-bugs] [Bug 17853] MARC21: Don't remove () from link text for 780/785 In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17853 Marcel de Rooy changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Failed QA --- Comment #14 from Marcel de Rooy --- For both 780 and 785 fields a and t are put into variable f780/5. Since you replace this variable by subfield a, we loose information. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri May 12 11:33:36 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 12 May 2017 09:33:36 +0000 Subject: [Koha-bugs] [Bug 18535] Clicking 'edit printer profile' in label creator causes software error In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18535 Marcel de Rooy changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri May 12 11:33:38 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 12 May 2017 09:33:38 +0000 Subject: [Koha-bugs] [Bug 18535] Clicking 'edit printer profile' in label creator causes software error In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18535 Marcel de Rooy changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #63131|0 |1 is obsolete| | --- Comment #3 from Marcel de Rooy --- Created attachment 63419 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=63419&action=edit Bug 18535 - Clicking 'edit printer profile' in label creator causes software error 1) Go to Tools > Label creator 2) If you don't have a printer profile defined, create one. 3) Go to manage > Printer profiles 4) Click the 'edit' button on any of the profiles. 5) INTERNAL SERVER ERROR! "Can't use string ("fields") as a HASH ref while "strict refs" in use at /usr/share/koha/lib/C4/Creators/Lib.pm line 147" 6) Apply patch 7) Click the 'edit' button on any of the profiles. 8) Things work as expected Bug reproduced, is fixed by this patch Signed-off-by: Marc V?ron Signed-off-by: Marcel de Rooy -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri May 12 11:33:52 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 12 May 2017 09:33:52 +0000 Subject: [Koha-bugs] [Bug 18535] Clicking 'edit printer profile' in label creator causes software error In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18535 Marcel de Rooy changed: What |Removed |Added ---------------------------------------------------------------------------- QA Contact|testopia at bugs.koha-communit |m.de.rooy at rijksmuseum.nl |y.org | CC| |m.de.rooy at rijksmuseum.nl -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri May 12 11:34:21 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 12 May 2017 09:34:21 +0000 Subject: [Koha-bugs] [Bug 14625] LDAP: mapped ExtendedPatronAttributes cause error when updated on authentication In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14625 --- Comment #14 from Oliver Bock --- (In reply to Martin Renvoize from comment #13) > On second thoughts, as update_local isn't currently tested at all I think > perhaps it widens the scope a bit too much to expect you to write the tests. Yep, I agree :-) Glad to see progress! Thanks -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri May 12 11:34:49 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 12 May 2017 09:34:49 +0000 Subject: [Koha-bugs] [Bug 18201] Export data -Fix "Remove non-local items" option and add " Removes non-local records" option for existing functionality In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18201 Marcel de Rooy changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |m.de.rooy at rijksmuseum.nl Attachment #62149|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri May 12 11:56:51 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 12 May 2017 09:56:51 +0000 Subject: [Koha-bugs] [Bug 18201] Export data -Fix "Remove non-local items" option and add " Removes non-local records" option for existing functionality In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18201 Marcel de Rooy changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Failed QA -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri May 12 11:56:39 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 12 May 2017 09:56:39 +0000 Subject: [Koha-bugs] [Bug 18201] Export data -Fix "Remove non-local items" option and add " Removes non-local records" option for existing functionality In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18201 --- Comment #4 from Marcel de Rooy --- Not sure if we should classify this as a bug or an enhancement. It also includes strings. And if I read "Remove records", I suppose that will scare some people. Would it be better to talk about excluding records or items from an export ? Another confusing thing is that we now have a library selection in the top of the form and an option "Remove .. not owned by library" in the bottom. It seems contradictory, or needs further explanation on the form. What actually is a record not owned by a library? It makes sense for items, but how does it relate to biblios ? Changing status to reflect need for feedback. All by all, I think we need some more thought here and I would suggest to classify it as an enhancement. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri May 12 11:57:01 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 12 May 2017 09:57:01 +0000 Subject: [Koha-bugs] [Bug 18201] Export data -Fix "Remove non-local items" option and add " Removes non-local records" option for existing functionality In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18201 Marcel de Rooy changed: What |Removed |Added ---------------------------------------------------------------------------- QA Contact|testopia at bugs.koha-communit |m.de.rooy at rijksmuseum.nl |y.org | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri May 12 12:11:27 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 12 May 2017 10:11:27 +0000 Subject: [Koha-bugs] [Bug 18383] items.onloan schema comment seems to be incorrect. In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18383 Marcel de Rooy changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri May 12 12:11:30 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 12 May 2017 10:11:30 +0000 Subject: [Koha-bugs] [Bug 18383] items.onloan schema comment seems to be incorrect. In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18383 Marcel de Rooy changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #63399|0 |1 is obsolete| | --- Comment #4 from Marcel de Rooy --- Created attachment 63420 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=63420&action=edit Bug 18383 - Correct items.onloan schema comment Signed-off-by: Katrin Fischer Signed-off-by: Marcel de Rooy Amended to include items and deleteditems. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri May 12 12:12:00 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 12 May 2017 10:12:00 +0000 Subject: [Koha-bugs] [Bug 18383] items.onloan schema comment seems to be incorrect. In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18383 Marcel de Rooy changed: What |Removed |Added ---------------------------------------------------------------------------- QA Contact|testopia at bugs.koha-communit |m.de.rooy at rijksmuseum.nl |y.org | Assignee|gmcharlt at gmail.com |pongtawat at punsarn.asia CC| |m.de.rooy at rijksmuseum.nl -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri May 12 12:23:31 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 12 May 2017 10:23:31 +0000 Subject: [Koha-bugs] [Bug 7317] Add an Interlibrary Loan Module to Circulation and OPAC In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7317 --- Comment #48 from Alex Sassmannshausen --- Created attachment 63421 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=63421&action=edit Bug 7317: Bugfix: Ensure current branch exists. * Koha/Illrequest.pm (generic_confirm): Load $branch variable earlier, with 'current_branchcode'. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri May 12 12:26:01 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 12 May 2017 10:26:01 +0000 Subject: [Koha-bugs] [Bug 18153] UNIMARC bib records exported with invalid 'a' char in label pos.9 In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18153 Julian Maurice changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Failed QA --- Comment #12 from Julian Maurice --- QA: 1. With the patch, the export tool also modifies the leader of exported authorities (position 9 is for authority type, so this is a problem) 2. The code is poorly formatted and is missing a comment to explain why we need to do this. 3. It only fixes exported records from the export tool and only for iso2709 format. If I export in marcxml or if I use the 'Save' button from the detail page, the leader is still invalid. 4. This patch states clearly that the leader may be invalid in Koha but tries to fix it at export-time instead of fixing it directly in Koha. I think it is possible to fix the leader at save-time, so that every biblio created/modified (whether it's by import or manually) will be saved with a correct leader. And maybe at read-time too, for already existing invalid records. @QAers, any opinions ? Failing QA for 1 and 2. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri May 12 12:25:55 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 12 May 2017 10:25:55 +0000 Subject: [Koha-bugs] [Bug 18588] New: Integrate ILL generic_emails in notices system. Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18588 Bug ID: 18588 Summary: Integrate ILL generic_emails in notices system. Change sponsored?: --- Product: Koha Version: unspecified Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Circulation Assignee: koha-bugs at lists.koha-community.org Reporter: alex.sassmannshausen at ptfs-europe.com QA Contact: testopia at bugs.koha-community.org CC: gmcharlt at gmail.com, kyle.m.hall at gmail.com Currently ILLModule provides a hard-coded (English) email template to request ILLs from 'Partner' Libraries. This template should use the existing notices system to allow the template to be customized and translated. Alex -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri May 12 12:26:11 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 12 May 2017 10:26:11 +0000 Subject: [Koha-bugs] [Bug 18588] Integrate ILL generic_emails in notices system. In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18588 Alex Sassmannshausen changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|koha-bugs at lists.koha-commun |alex.sassmannshausen at ptfs-e |ity.org |urope.com Depends on| |7317 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7317 [Bug 7317] Add an Interlibrary Loan Module to Circulation and OPAC -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri May 12 12:26:11 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 12 May 2017 10:26:11 +0000 Subject: [Koha-bugs] [Bug 7317] Add an Interlibrary Loan Module to Circulation and OPAC In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7317 Alex Sassmannshausen changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |18588 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18588 [Bug 18588] Integrate ILL generic_emails in notices system. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri May 12 12:28:36 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 12 May 2017 10:28:36 +0000 Subject: [Koha-bugs] [Bug 18582] Hide empty rows in detailed suggestion view In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18582 Josef Moravec changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri May 12 12:28:40 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 12 May 2017 10:28:40 +0000 Subject: [Koha-bugs] [Bug 18582] Hide empty rows in detailed suggestion view In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18582 Josef Moravec changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #63391|0 |1 is obsolete| | --- Comment #2 from Josef Moravec --- Created attachment 63422 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=63422&action=edit [SIGNED-OFF] Bug 18582 - Hide empty rows in detailed suggestion view This patch adds a check for the existence of various template variables before showing the row containing that data. This will prevent the display of rows containing labels but no data in the suggestions detailed view. To test, apply the patch and go to Acquisitions -> Suggestions. View the detail page of various suggestions and confirm that only fields with data are displaying. Signed-off-by: Josef Moravec -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri May 12 12:44:36 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 12 May 2017 10:44:36 +0000 Subject: [Koha-bugs] [Bug 18578] Use subdirectory in / tmp for session storage during installation In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18578 Josef Moravec changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri May 12 12:44:39 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 12 May 2017 10:44:39 +0000 Subject: [Koha-bugs] [Bug 18578] Use subdirectory in / tmp for session storage during installation In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18578 Josef Moravec changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #63376|0 |1 is obsolete| | --- Comment #2 from Josef Moravec --- Created attachment 63423 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=63423&action=edit [SIGNED-OFF] Bug 18578: Use subdirectory in /tmp for session storage during installation Apply the change from bug 15553 to InstallAuth.pm too. Test plan: [1] Remove all cgisess_* files from your /tmp directory. [2] Remove directory /tmp/cgisess_koha_[your instance], if there. [3] Run the webinstaller /cgi-bin/koha/installer/install.pl?step=1&op=updatestructure [4] Check if you have cgisess_ files in /tmp/cgisess_koha_[your instance]. Signed-off-by: Marcel de Rooy Signed-off-by: Josef Moravec -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri May 12 12:46:23 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 12 May 2017 10:46:23 +0000 Subject: [Koha-bugs] [Bug 18579] Problem with :Filter::MARC::EmbedItemsAvailability In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18579 --- Comment #15 from Tom?s Cohen Arazi --- (In reply to Marcel de Rooy from comment #11) > Good catch Julian. (Poor Tomas ;) Hahaha -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri May 12 12:49:09 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 12 May 2017 10:49:09 +0000 Subject: [Koha-bugs] [Bug 18578] Use subdirectory in / tmp for session storage during installation In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18578 --- Comment #3 from Marcel de Rooy --- Thanks Josef -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri May 12 12:57:11 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 12 May 2017 10:57:11 +0000 Subject: [Koha-bugs] [Bug 18589] New: Show ILLs as part of patron profile Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18589 Bug ID: 18589 Summary: Show ILLs as part of patron profile Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Circulation Assignee: koha-bugs at lists.koha-community.org Reporter: magnus at libriotech.no QA Contact: testopia at bugs.koha-community.org CC: gmcharlt at gmail.com, kyle.m.hall at gmail.com Bug 7317 adds a "Interlibrary loans" tab on the left hand side of patron details, under Purchase suggestions. But this behaves more like a link than a tab, taking you to the ILL module and a list limited to the patron in question. It would be better if this view looked more like a part of the patron details, with the tabs on the left hand side and the buttons on top. Compare this to the "Modification log" tab/link, which actually takes you to the log "module", but still looks like part of the patron profile. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri May 12 13:03:32 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 12 May 2017 11:03:32 +0000 Subject: [Koha-bugs] [Bug 18589] Show ILLs as part of patron profile In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18589 Magnus Enger changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on| |7317 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7317 [Bug 7317] Add an Interlibrary Loan Module to Circulation and OPAC -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri May 12 13:03:32 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 12 May 2017 11:03:32 +0000 Subject: [Koha-bugs] [Bug 7317] Add an Interlibrary Loan Module to Circulation and OPAC In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7317 Magnus Enger changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |18589 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18589 [Bug 18589] Show ILLs as part of patron profile -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri May 12 13:05:07 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 12 May 2017 11:05:07 +0000 Subject: [Koha-bugs] [Bug 18590] New: Make it possible to search among ILL requests Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18590 Bug ID: 18590 Summary: Make it possible to search among ILL requests Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Circulation Assignee: koha-bugs at lists.koha-community.org Reporter: magnus at libriotech.no QA Contact: testopia at bugs.koha-community.org CC: gmcharlt at gmail.com, kyle.m.hall at gmail.com A library that does a lot of ILL might want to be able to search them. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri May 12 13:05:17 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 12 May 2017 11:05:17 +0000 Subject: [Koha-bugs] [Bug 18590] Make it possible to search among ILL requests In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18590 Magnus Enger changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on| |7317 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7317 [Bug 7317] Add an Interlibrary Loan Module to Circulation and OPAC -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Fri May 12 13:05:17 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 12 May 2017 11:05:17 +0000 Subject: [Koha-bugs] [Bug 7317] Add an Interlibrary Loan Module to Circulation and OPAC In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7317 Magnus Enger changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |18590 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18590 [Bug 18590] Make it possible to search among ILL requests -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri May 12 13:22:32 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 12 May 2017 11:22:32 +0000 Subject: [Koha-bugs] [Bug 17084] Automatic debian/control updates (master) In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17084 Mirko Tietgen changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to Master |ASSIGNED Depends on| |17618 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17618 [Bug 17618] perl-modules Debian package name change -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri May 12 13:22:32 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 12 May 2017 11:22:32 +0000 Subject: [Koha-bugs] [Bug 17618] perl-modules Debian package name change In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17618 Mirko Tietgen changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |17084 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17084 [Bug 17084] Automatic debian/control updates (master) -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri May 12 13:25:49 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 12 May 2017 11:25:49 +0000 Subject: [Koha-bugs] [Bug 17111] Automatic debian/control updates (oldstable/16.05.x) In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17111 Mirko Tietgen changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to Stable |ASSIGNED -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri May 12 13:53:28 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 12 May 2017 11:53:28 +0000 Subject: [Koha-bugs] [Bug 18591] New: Allow an arbitrary number of comments on ILLs Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18591 Bug ID: 18591 Summary: Allow an arbitrary number of comments on ILLs Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Circulation Assignee: koha-bugs at lists.koha-community.org Reporter: magnus at libriotech.no QA Contact: testopia at bugs.koha-community.org CC: gmcharlt at gmail.com, kyle.m.hall at gmail.com Blocks: 7317 Some libraries would like to be able to connect an arbitrary number of comments to each ILL request. This could be comments from the patron, messages between different librarians working on the same ILLS, comments about what other libraries have been tried before the current one etc. This would require a new table with fields like - unique ID - text of the comment - borrowernumber of the librarian who made the comment - timestamp Maybe it would be possible to include comments from the OPAC too? Not sure if that makes sense. Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7317 [Bug 7317] Add an Interlibrary Loan Module to Circulation and OPAC -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri May 12 13:53:28 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 12 May 2017 11:53:28 +0000 Subject: [Koha-bugs] [Bug 7317] Add an Interlibrary Loan Module to Circulation and OPAC In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7317 Magnus Enger changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on| |18591 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18591 [Bug 18591] Allow an arbitrary number of comments on ILLs -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri May 12 13:53:57 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 12 May 2017 11:53:57 +0000 Subject: [Koha-bugs] [Bug 7317] Add an Interlibrary Loan Module to Circulation and OPAC In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7317 Magnus Enger changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |18591 Depends on|18591 | Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18591 [Bug 18591] Allow an arbitrary number of comments on ILLs -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri May 12 13:53:57 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 12 May 2017 11:53:57 +0000 Subject: [Koha-bugs] [Bug 18591] Allow an arbitrary number of comments on ILLs In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18591 Magnus Enger changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks|7317 | Depends on| |7317 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7317 [Bug 7317] Add an Interlibrary Loan Module to Circulation and OPAC -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri May 12 14:04:22 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 12 May 2017 12:04:22 +0000 Subject: [Koha-bugs] [Bug 18592] New: Link from bib detail view to ILL module Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18592 Bug ID: 18592 Summary: Link from bib detail view to ILL module Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Circulation Assignee: koha-bugs at lists.koha-community.org Reporter: magnus at libriotech.no QA Contact: testopia at bugs.koha-community.org CC: gmcharlt at gmail.com, kyle.m.hall at gmail.com Depends on: 7317 If there is an ILL associated with a given biblionumber, there should be a link from the bib detail view to the ILL details in the ILL module. Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7317 [Bug 7317] Add an Interlibrary Loan Module to Circulation and OPAC -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri May 12 14:04:22 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 12 May 2017 12:04:22 +0000 Subject: [Koha-bugs] [Bug 7317] Add an Interlibrary Loan Module to Circulation and OPAC In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7317 Magnus Enger changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |18592 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18592 [Bug 18592] Link from bib detail view to ILL module -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri May 12 14:24:02 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 12 May 2017 12:24:02 +0000 Subject: [Koha-bugs] [Bug 18204] Authority searches are not saved in Search history In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18204 --- Comment #7 from Julian Maurice --- Created attachment 63424 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=63424&action=edit Bug 18204 - Authority searches are not saved in Search history When you search an authority in Authority search, this search is not saved in Search history. EnableOpacSearchHistory is enabled Steps to test: 1- Login your account (opac) 2- Search an authority in Authority search 3- Go to Search history -> Authority 4- It says "Your authority search history is empty" Signed-off-by: Katrin Fischer Signed-off-by: Julian Maurice -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri May 12 14:24:23 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 12 May 2017 12:24:23 +0000 Subject: [Koha-bugs] [Bug 18204] Authority searches are not saved in Search history In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18204 Julian Maurice changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA CC| |julian.maurice at biblibre.com -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri May 12 14:31:11 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 12 May 2017 12:31:11 +0000 Subject: [Koha-bugs] [Bug 18593] New: Suggestion isn' t update when merging biblio suggested with another biblio Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18593 Bug ID: 18593 Summary: Suggestion isn't update when merging biblio suggested with another biblio Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: normal Priority: P5 - low Component: Acquisitions Assignee: koha-bugs at lists.koha-community.org Reporter: koha at univ-lyon3.fr QA Contact: testopia at bugs.koha-community.org -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri May 12 14:36:50 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 12 May 2017 12:36:50 +0000 Subject: [Koha-bugs] [Bug 18593] Suggestion isn' t update when merging biblio suggested with another biblio In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18593 Koha Team Lyon 3 changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |koha at univ-lyon3.fr --- Comment #1 from Koha Team Lyon 3 --- When we place an order from a suggestion, a biblio record is created and its number is stocked in suggestion table. If we merge this biblio record with another one (and prefering the other one), the biblio number is changed in the order but not in the suggestion, so we lost the link between this order and the suggestion. ANd the patron will not be alerted when the document will be received. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Fri May 12 14:42:34 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 12 May 2017 12:42:34 +0000 Subject: [Koha-bugs] [Bug 18574] Clean Patron Records tool doesn' t limit to the selected library In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18574 Kyle M Hall changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to Master --- Comment #8 from Kyle M Hall --- Pushed to master for 17.05! Thanks for the quick turnaround Katrin, Julian! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri May 12 14:43:31 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 12 May 2017 12:43:31 +0000 Subject: [Koha-bugs] [Bug 18579] Problem with :Filter::MARC::EmbedItemsAvailability In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18579 Kyle M Hall changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |kyle at bywatersolutions.com Status|Passed QA |Pushed to Master --- Comment #16 from Kyle M Hall --- Pushed to master for 17.05, thanks Tomas, Julian! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri May 12 14:44:46 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 12 May 2017 12:44:46 +0000 Subject: [Koha-bugs] [Bug 18560] RSS Feed link from OPAC shelves is broken In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18560 Kyle M Hall changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |kyle at bywatersolutions.com Attachment #63375|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri May 12 14:45:24 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 12 May 2017 12:45:24 +0000 Subject: [Koha-bugs] [Bug 18560] RSS Feed link from OPAC shelves is broken In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18560 Kyle M Hall changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to Master --- Comment #12 from Kyle M Hall --- Pushed to master for 17.05, thanks Mark! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri May 12 14:46:45 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 12 May 2017 12:46:45 +0000 Subject: [Koha-bugs] [Bug 18573] Error when adding a suggestion in the OPAC In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18573 Kyle M Hall changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to Master CC| |kyle at bywatersolutions.com --- Comment #7 from Kyle M Hall --- Pushed to master for 17.05, thanks Jonathan! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri May 12 14:49:55 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 12 May 2017 12:49:55 +0000 Subject: [Koha-bugs] [Bug 16758] Caching issues in scripts running in daemon mode In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16758 Kyle M Hall changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |kyle at bywatersolutions.com Status|Passed QA |Pushed to Master --- Comment #17 from Kyle M Hall --- Pushed to master for 17.05, thanks Jacek, Jonathan! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri May 12 14:50:31 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 12 May 2017 12:50:31 +0000 Subject: [Koha-bugs] [Bug 18594] New: Add audible alarm for batch import Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18594 Bug ID: 18594 Summary: Add audible alarm for batch import Change sponsored?: --- Product: Koha Version: unspecified Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: MARC Bibliographic record staging/import Assignee: gmcharlt at gmail.com Reporter: bob-ewart at bobsown.com QA Contact: testopia at bugs.koha-community.org Please add the audible alarms to staging, importing and undo MARC record imports. They can take a long time, especially with large batches. The audible alarms will be very helpful in knowing when to come back to the terminal. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri May 12 14:50:40 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 12 May 2017 12:50:40 +0000 Subject: [Koha-bugs] [Bug 18594] Add audible alarm for batch import In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18594 Bob Ewart changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |bob-ewart at bobsown.com -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri May 12 14:50:54 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 12 May 2017 12:50:54 +0000 Subject: [Koha-bugs] [Bug 18525] Can't create order line from accepted suggestion In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18525 Kyle M Hall changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to Master CC| |kyle at bywatersolutions.com --- Comment #5 from Kyle M Hall --- Pushed to master for 17.05, thanks Jonathan! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri May 12 14:51:57 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 12 May 2017 12:51:57 +0000 Subject: [Koha-bugs] [Bug 4460] Amazon' s AssociateID tag not used in links so referred revenue lost In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=4460 Kyle M Hall changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |kyle at bywatersolutions.com Status|Passed QA |Pushed to Master --- Comment #38 from Kyle M Hall --- Pushed to master for 17.05, thanks Mark! -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri May 12 14:52:39 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 12 May 2017 12:52:39 +0000 Subject: [Koha-bugs] [Bug 18535] Clicking 'edit printer profile' in label creator causes software error In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18535 Kyle M Hall changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to Master CC| |kyle at bywatersolutions.com --- Comment #4 from Kyle M Hall --- Pushed to master for 17.05, thanks Nick! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri May 12 14:53:35 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 12 May 2017 12:53:35 +0000 Subject: [Koha-bugs] [Bug 18557] Mysqlim CURRENT_DATE in Koha::Clubs::get_enrollable In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18557 Kyle M Hall changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to Master --- Comment #8 from Kyle M Hall --- Pushed to master for 17.05! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri May 12 14:54:33 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 12 May 2017 12:54:33 +0000 Subject: [Koha-bugs] [Bug 18340] Progress bar length is wrong In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18340 Kyle M Hall changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |kyle at bywatersolutions.com Status|Passed QA |Pushed to Master --- Comment #4 from Kyle M Hall --- Pushed to master for 17.05, thanks Jonathan! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri May 12 14:55:37 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 12 May 2017 12:55:37 +0000 Subject: [Koha-bugs] [Bug 18370] Columns settings patrons>id=memberresultst : display bug In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18370 Kyle M Hall changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to Master CC| |kyle at bywatersolutions.com --- Comment #14 from Kyle M Hall --- Pushed to master for 17.05, thanks Jonathan! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri May 12 14:57:49 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 12 May 2017 12:57:49 +0000 Subject: [Koha-bugs] [Bug 18400] Noisy warns in opac-search.pl during itemtype sorting In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18400 Kyle M Hall changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |kyle at bywatersolutions.com Status|Passed QA |Pushed to Master --- Comment #10 from Kyle M Hall --- Pushed to master for 17.05, thanks Nick, Marcel! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri May 12 14:58:30 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 12 May 2017 12:58:30 +0000 Subject: [Koha-bugs] [Bug 18444] Add TalkingTechItivaPhoneNotification to sysprefs.sql In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18444 Kyle M Hall changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to Master CC| |kyle at bywatersolutions.com --- Comment #6 from Kyle M Hall --- Pushed to master for 17.05, thanks Lari! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri May 12 14:59:09 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 12 May 2017 12:59:09 +0000 Subject: [Koha-bugs] [Bug 17257] Cannot create a patron under MySQL 5.7 In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17257 Kyle M Hall changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |kyle at bywatersolutions.com Attachment #61425|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri May 12 14:59:59 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 12 May 2017 12:59:59 +0000 Subject: [Koha-bugs] [Bug 17257] Cannot create a patron under MySQL 5.7 In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17257 Kyle M Hall changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to Master --- Comment #11 from Kyle M Hall --- Pushed to master for 17.05, thanks Jonathan! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri May 12 15:01:03 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 12 May 2017 13:01:03 +0000 Subject: [Koha-bugs] [Bug 18529] Template cleanup of patron clubs pages In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18529 Kyle M Hall changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |kyle at bywatersolutions.com --- Comment #5 from Kyle M Hall --- (In reply to Marcel de Rooy from comment #4) > Looks good to me while glancing thru template changes and testing it > 'diagonally'. > Kyle: If I am not mistaken, you know the feature well. Please have a look > too. Looks good to me! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri May 12 15:02:34 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 12 May 2017 13:02:34 +0000 Subject: [Koha-bugs] [Bug 18537] Update Ukrainian installer sample files for 17.05 In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18537 --- Comment #3 from Serhij Dubyk --- Updated Ukrainian installation sql-files can be seen alive on demonstration installations (http://koha.org.ua/wiki/index.php?title=%D0%94%D0%B5%D0%BC%D0%BE%D0%BD%D1%81%D1%82%D1%80%D0%B0%D1%86%D1%96%D0%B9%D0%BD%D1%96_%D1%81%D0%B5%D1%80%D0%B2%D0%B5%D1%80%D0%B8_%D0%90%D0%91%D0%86%D0%A1_Koha_%D1%82%D0%B0_%D0%B2%D1%96%D1%80%D1%82%D1%83%D0%B0%D0%BB%D1%8C%D0%BD%D1%96_%D0%BE%D0%B1%D1%80%D0%B0%D0%B7%D0%B8) of Ukrainian users group of Koha. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Fri May 12 15:03:02 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 12 May 2017 13:03:02 +0000 Subject: [Koha-bugs] [Bug 18529] Template cleanup of patron clubs pages In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18529 Kyle M Hall changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to Master --- Comment #6 from Kyle M Hall --- Pushed to master for 17.05, thanks much Owen! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri May 12 15:04:22 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 12 May 2017 13:04:22 +0000 Subject: [Koha-bugs] [Bug 18383] items.onloan schema comment seems to be incorrect. In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18383 Kyle M Hall changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to Master CC| |kyle at bywatersolutions.com --- Comment #5 from Kyle M Hall --- Pushed to master for 17.05, thanks pongtawat! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri May 12 15:05:47 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 12 May 2017 13:05:47 +0000 Subject: [Koha-bugs] [Bug 16515] Did you mean? links don't wrap on smaller screens In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16515 Kyle M Hall changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to Master CC| |kyle at bywatersolutions.com --- Comment #11 from Kyle M Hall --- Pushed to master for 17.05, thanks Owen! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri May 12 15:06:24 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 12 May 2017 13:06:24 +0000 Subject: [Koha-bugs] [Bug 18504] Amount owed on fines tab should be formatted as price if < 10 or credit In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18504 Kyle M Hall changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |kyle at bywatersolutions.com Attachment #62805|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri May 12 15:07:02 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 12 May 2017 13:07:02 +0000 Subject: [Koha-bugs] [Bug 18595] New: Move C4::Members::Messaging to Koha namespace Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18595 Bug ID: 18595 Summary: Move C4::Members::Messaging to Koha namespace Change sponsored?: --- Product: Koha Version: unspecified Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Architecture, internals, and plumbing Assignee: gmcharlt at gmail.com Reporter: lari.taskula at jns.fi QA Contact: testopia at bugs.koha-community.org Bug 17499 adds Koha-objects for messaging preferences. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri May 12 15:07:08 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 12 May 2017 13:07:08 +0000 Subject: [Koha-bugs] [Bug 18504] Amount owed on fines tab should be formatted as price if < 10 or credit In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18504 Kyle M Hall changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to Master --- Comment #4 from Kyle M Hall --- Pushed to master for 17.05, thanks Nick! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri May 12 15:07:11 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 12 May 2017 13:07:11 +0000 Subject: [Koha-bugs] [Bug 18595] Move C4::Members::Messaging to Koha namespace In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18595 Lari Taskula changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on| |17499 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17499 [Bug 17499] Koha objects for messaging preferences -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri May 12 15:07:11 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 12 May 2017 13:07:11 +0000 Subject: [Koha-bugs] [Bug 17499] Koha objects for messaging preferences In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17499 Lari Taskula changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |18595 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18595 [Bug 18595] Move C4::Members::Messaging to Koha namespace -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri May 12 15:07:33 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 12 May 2017 13:07:33 +0000 Subject: [Koha-bugs] [Bug 18596] New: Quick add form duplicating password confirm Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18596 Bug ID: 18596 Summary: Quick add form duplicating password confirm Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: normal Priority: P5 - low Component: Patrons Assignee: koha-bugs at lists.koha-community.org Reporter: nick at bywatersolutions.com QA Contact: testopia at bugs.koha-community.org CC: gmcharlt at gmail.com, kyle.m.hall at gmail.com If password is in BorrowerMandatoryField we end up with two confirm fields - the test for matching and copying the field is unneccessary since we copy all required fields anyways. To recreate: 1 - Add password to BorrowerMandatoryField 2 - View quick add form 3 - Confirm password twice -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Fri May 12 15:09:27 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 12 May 2017 13:09:27 +0000 Subject: [Koha-bugs] [Bug 17925] Disable debugging in reports/bor_issues_top.pl In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17925 Kyle M Hall changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |kyle at bywatersolutions.com Status|Passed QA |Pushed to Master --- Comment #8 from Kyle M Hall --- Pushed to master for 17.05, thanks Marcel! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri May 12 15:10:21 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 12 May 2017 13:10:21 +0000 Subject: [Koha-bugs] [Bug 18596] Quick add form duplicating password confirm In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18596 Nick Clemens changed: What |Removed |Added ---------------------------------------------------------------------------- Patch complexity|--- |Trivial patch Status|NEW |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Fri May 12 15:10:23 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 12 May 2017 13:10:23 +0000 Subject: [Koha-bugs] [Bug 18596] Quick add form duplicating password confirm In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18596 --- Comment #1 from Nick Clemens --- Created attachment 63425 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=63425&action=edit Bug 18596 - Quick add form duplicating password confirm To test: 1 - Add password to BorrowerMandatoryField 2 - View quick add form 3 - See confirm password twice 4 - Apply patch 5 - See confirm password once 6 - Add password to QuickAddFields 7 - Confirm one confirm field 8 - Remove password form BorrowerMandatory field 9 - Confirm there is one confirm field and password fields are not required -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Fri May 12 15:10:51 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 12 May 2017 13:10:51 +0000 Subject: [Koha-bugs] [Bug 18596] Quick add form duplicating password confirm In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18596 Nick Clemens changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on| |3534 Assignee|koha-bugs at lists.koha-commun |nick at bywatersolutions.com |ity.org | Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=3534 [Bug 3534] Patron quick add form -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri May 12 15:10:51 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 12 May 2017 13:10:51 +0000 Subject: [Koha-bugs] [Bug 3534] Patron quick add form In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=3534 Nick Clemens changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |18596 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18596 [Bug 18596] Quick add form duplicating password confirm -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri May 12 15:18:29 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 12 May 2017 13:18:29 +0000 Subject: [Koha-bugs] [Bug 17936] Search bar not aligned on right in small screen sizes In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17936 Kyle M Hall changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |kyle at bywatersolutions.com Status|Passed QA |Pushed to Master --- Comment #7 from Kyle M Hall --- Pushed to master for 17.05, thanks Owen! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri May 12 15:19:23 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 12 May 2017 13:19:23 +0000 Subject: [Koha-bugs] [Bug 18596] Quick add form duplicating password confirm In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18596 Nick Clemens changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #63425|0 |1 is obsolete| | --- Comment #2 from Nick Clemens --- Created attachment 63426 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=63426&action=edit Bug 18596 - Quick add form duplicating password confirm To test: 1 - Add password to BorrowerMandatoryField 2 - View quick add form 3 - See confirm password twice 4 - Apply patch 5 - See confirm password once 6 - Add password to QuickAddFields 7 - Confirm one confirm field 8 - Remove password form BorrowerMandatory field 9 - Confirm there is one confirm field and password fields are not required -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri May 12 15:21:00 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 12 May 2017 13:21:00 +0000 Subject: [Koha-bugs] [Bug 18494] Fix Letters.t (follow-up of 15702) In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18494 Kyle M Hall changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to Master CC| |kyle at bywatersolutions.com --- Comment #16 from Kyle M Hall --- Pushed to master for 17.05, thanks Mark! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri May 12 15:25:38 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 12 May 2017 13:25:38 +0000 Subject: [Koha-bugs] [Bug 17499] Koha objects for messaging preferences In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17499 --- Comment #1 from Lari Taskula --- Created attachment 63427 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=63427&action=edit Bug 17499: Add Koha-objects for messaging preferences This patch adds Koha-objects for messaging preferences. This patch does not add any extra logic into these objects. Includes test coverage for basic usage. To test: 1. Run t/db_dependent/Koha/Patron/Message/Preferences.t -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri May 12 15:25:59 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 12 May 2017 13:25:59 +0000 Subject: [Koha-bugs] [Bug 17499] Koha objects for messaging preferences In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17499 --- Comment #2 from Lari Taskula --- Created attachment 63428 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=63428&action=edit Bug 17499: Add useful Koha::Exceptions This patch adds some basic Koha::Exceptions that will be useful. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri May 12 15:26:11 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 12 May 2017 13:26:11 +0000 Subject: [Koha-bugs] [Bug 17499] Koha objects for messaging preferences In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17499 --- Comment #3 from Lari Taskula --- Created attachment 63429 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=63429&action=edit Bug 17499: Add basic validation for messaging preference This patch adds simple validation for messaging preferences. The validation includes - check that only either borrowernumber or categorycode is given, but not both - throw exception if patron for the given borrowernumber is not found - throw exception if category for the given categorycode is not found To test: 1. Run t/db_dependent/Koha/Patron/Message/Preferences.t -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri May 12 15:26:24 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 12 May 2017 13:26:24 +0000 Subject: [Koha-bugs] [Bug 17499] Koha objects for messaging preferences In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17499 --- Comment #4 from Lari Taskula --- Created attachment 63430 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=63430&action=edit Bug 17499: Throw an exception on duplicate messaging preference When trying to add a duplicate messaging preference that has the same borrowernumber or category, and message_attribute_id as another preference, throw Koha::Exceptions::DuplicateObject. To test: 1. Run t/db_dependent/Koha/Patron/Message/Preferences.t -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri May 12 15:26:35 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 12 May 2017 13:26:35 +0000 Subject: [Koha-bugs] [Bug 17499] Koha objects for messaging preferences In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17499 --- Comment #5 from Lari Taskula --- Created attachment 63431 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=63431&action=edit Bug 17499: Add a method for getting messaging options This patch adds a method for getting available messaging options. To test: 1. Run t/db_dependent/Koha/Patron/Message/Preferences.t -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri May 12 15:26:48 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 12 May 2017 13:26:48 +0000 Subject: [Koha-bugs] [Bug 17499] Koha objects for messaging preferences In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17499 --- Comment #6 from Lari Taskula --- Created attachment 63432 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=63432&action=edit Bug 17499: Add a method for setting default messaging preferences This patch adds a method Koha::Patron::Message::Preference->new_from_default that can be used to add category's default messaging preferences to patron for a given message type. Example call: Koha::Patron::Message::Preference->new_from_default({ borrowernumber => 123, categorycode => "ABC", message_attribute_id => 1, }); Also adds a simple method for Koha::Patron, set_default_messaging_preferences. Usage: $patron->set_default_messaging_preferences() To test: 1. Run t/db_dependent/Koha/Patron/Message/Preferences.t -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri May 12 15:27:00 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 12 May 2017 13:27:00 +0000 Subject: [Koha-bugs] [Bug 17499] Koha objects for messaging preferences In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17499 --- Comment #7 from Lari Taskula --- Created attachment 63433 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=63433&action=edit Bug 17499: Improve object usability by enabling direct access to transport preferences Since messaging preference is a feature that has multiple related database tables, usage via Koha-objects is sometimes frustrating. This patch adds a feature for Koha::Patron::Message::Preference which enables access to message transport preferences directly via this object. It allows us to skip calls to Koha::Patron::Message::Transport::Preference(s) because we can now get and set via K::P::M::Preference. Get: $preference->message_transport_types Returns a hashref, where each key is stored transport type and value for the key is letter code for the transport. Set: $preference->set({ message_transport_types => ['sms'] }) or $preference->message_transport_types('email', 'sms') or $preference->message_transport_types(['email', 'sms']) Returns $self (Koha::Patron::Message::Preference object) To test: 1. Run t/db_dependent/Koha/Patron/Message/Preferences.t -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri May 12 15:27:13 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 12 May 2017 13:27:13 +0000 Subject: [Koha-bugs] [Bug 17499] Koha objects for messaging preferences In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17499 --- Comment #8 from Lari Taskula --- Created attachment 63434 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=63434&action=edit Bug 17499: Simplify searching by message_name This patch adds optional search & find parameter message_name for Koha::Patron::Message::Preferences->search and ->find. This simplifies object usage by allowing us to skip joins or finding the attribute id ourselves. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri May 12 15:29:16 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 12 May 2017 13:29:16 +0000 Subject: [Koha-bugs] [Bug 18595] Move C4::Members::Messaging to Koha namespace In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18595 --- Comment #1 from Lari Taskula --- Created attachment 63435 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=63435&action=edit Bug 18595: Unit tests for Koha::Patron::Categories->default_messaging This patch adds unit tests for Koha::Patron::Categories->default_messaging. Tests will help preparing for moving C4::Members::Messaging to Koha-objects. To test: 1. Run t/db_dependent/Koha/Patron/Categories.t -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri May 12 15:29:26 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 12 May 2017 13:29:26 +0000 Subject: [Koha-bugs] [Bug 18595] Move C4::Members::Messaging to Koha namespace In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18595 --- Comment #2 from Lari Taskula --- Created attachment 63436 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=63436&action=edit Bug 18595: Move C4::Members::Messaging::GetMessagingOptions This patch moves C4::Members::GetMessagingOptions to Koha::Patron::Message::Preferences->get_options. The patch makes a heavy touch on core messaging preference features, but should not introduce any visible changes for end user. Keep this in mind if testing. If you notice any changes in Koha, something is probably wrong! This patch also removes previously unused GetMessagingOptions in opac-messaging.pl To test: Make sure you have enabled the following system preferences: - opacuserlogin - EnhancedMessagingPreferences - EnhancedMessagingPreferencesOPAC ---- GENERAL ---- 1. Apply patch 2. Search Koha source code for references of "GetMessagingOptions" (grep -r 'GetMessagingOptions'). 3. Observe no results in source code. ---- OPAC ---- 1. Login to OPAC. 2. Go to "your messaging" (cgi-bin/koha/opac-messaging.pl). 3. Observe the preferences looking normal and as they should be. 4. Set any combination of messaging preferences. 5. Observe them apply as expected, repeat step 4-5 as much as you like. ---- INTRANET ---- 1. Login to intranet. 2. Go to edit patron's details and scroll down to their messaging preferences. 3. Observe the preferences looking normal and as they should be. 4. Set any combination of messaging preferences. 5. Observe them apply as expected, repeat step 4-5 as much as you like. 6. Go to Administration -> Patron categories -> Edit (for any category) 7. Scroll down to observe default messaging preferences for this patron category 8. Observe the preferences looking normal and as they should be. 9. Set any combination of messaging preferences. 10. Observe them apply as expected, repeat step 9-10 as much as you like. 11. Go to cgi-bin/koha/members/memberentry.pl?op=add&categorycode=XXX, replace XXX with the categorycode you were just editing. 12. Fill in required data, do not modify messaging preferences, click Save. 13. Observe a new patron with default messaging preferences. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri May 12 15:29:36 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 12 May 2017 13:29:36 +0000 Subject: [Koha-bugs] [Bug 18595] Move C4::Members::Messaging to Koha namespace In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18595 --- Comment #3 from Lari Taskula --- Created attachment 63437 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=63437&action=edit Bug 18595: Move C4::Members::Messaging::SetMessagingPreferencesFromDefaults This patch moves C4::Members::SetMessagingPreferencesFromDefaults to Koha::Patron->set_default_messaging_preferences The patch makes a heavy touch on core messaging preference features, but should not introduce any visible changes for end user. Keep this in mind if testing. If you notice any changes in Koha, something is probably wrong! To test: Make sure you have enabled the following system preferences: - EnhancedMessagingPreferences ---- GENERAL ---- 1. Apply patch 2. Search Koha source code for references of "SetMessagingPreferencesFromDefaults" (grep -r 'SetMessagingPreferencesFromDefaults'). 3. Observe no results in source code. ---- INTRANET ---- 1. Login to intranet. 2. Go to Administration -> Patron categories -> Edit (for any category) 3. Scroll down to observe default messaging preferences for this patron category 4. Observe the preferences, remember them for the next step. 5. Go to cgi-bin/koha/members/memberentry.pl?op=add&categorycode=XXX, replace XXX with the categorycode you were just editing. 6. Look at messaging preferences. They should be same as in step 4. 7. Fill in required data, do not modify messaging preferences, click Save. 8. Observe a new patron with default messaging preferences. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri May 12 15:29:44 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 12 May 2017 13:29:44 +0000 Subject: [Koha-bugs] [Bug 18343] Manage MARC import DBH should not be shared In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18343 --- Comment #4 from Fridolin SOMERS --- (In reply to Jonathan Druart from comment #3) > Why do not you implement transaction using DBIx::Class directly? > That will be easier and backportable as well. It was to have a quick fix. Is it backportable to 3.22 ? -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri May 12 15:29:46 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 12 May 2017 13:29:46 +0000 Subject: [Koha-bugs] [Bug 18595] Move C4::Members::Messaging to Koha namespace In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18595 --- Comment #4 from Lari Taskula --- Created attachment 63438 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=63438&action=edit Bug 18595: Unit tests preparing for GetMessagingPreferences move This patch prepares removing GetMessagingPreferences by adding some useful unit tests for subroutines that the move targets. Reserves.t already covers print notice, but this patch adds tests for a set transport type. To test: 1. Run t/db_dependent/Circulation.t 2. Run t/db_dependent/Reserves.t 3. Observe test pass -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri May 12 15:29:57 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 12 May 2017 13:29:57 +0000 Subject: [Koha-bugs] [Bug 18595] Move C4::Members::Messaging to Koha namespace In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18595 --- Comment #5 from Lari Taskula --- Created attachment 63439 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=63439&action=edit Bug 18595: Move C4::Members::Messaging::GetMessagingPreferences Unit tests: 1. Run t/db_dependent/Circulation.t 2. Run t/db_dependent/Reserves.t 3. Run t/db_dependent/Koha/Patron/Categories.t -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri May 12 15:30:08 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 12 May 2017 13:30:08 +0000 Subject: [Koha-bugs] [Bug 18595] Move C4::Members::Messaging to Koha namespace In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18595 --- Comment #6 from Lari Taskula --- Created attachment 63440 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=63440&action=edit Bug 18595: Move C4::Members::Messaging::SetMessagingPreference Move default values for days in advance and wants_digest outside set method, because otherwise it would conflict with the standard way of how set works in Koha-objects (one may accidentally reset those parameters because they don't pass them and excpect them to remain unchanged). -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri May 12 15:30:20 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 12 May 2017 13:30:20 +0000 Subject: [Koha-bugs] [Bug 18595] Move C4::Members::Messaging to Koha namespace In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18595 --- Comment #7 from Lari Taskula --- Created attachment 63441 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=63441&action=edit Bug 18595: Remove references to C4::Members::Messaging -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri May 12 15:36:26 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 12 May 2017 13:36:26 +0000 Subject: [Koha-bugs] [Bug 8993] LDAP authentication improvements: multiple branch and transformation modules In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8993 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |katrin.fischer at bsz-bw.de Status|Needs Signoff |Failed QA --- Comment #65 from Katrin Fischer --- The last 2 comments from Blou read like FQA - setting status. Julian, can you please comment? -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri May 12 15:39:11 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 12 May 2017 13:39:11 +0000 Subject: [Koha-bugs] [Bug 18595] Move C4::Members::Messaging to Koha namespace In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18595 --- Comment #8 from Lari Taskula --- I attached the patches that I was working on last year. I would like to point out that the work was left unfinished. Especially the patches without a proper test plan are probably somewhat untested and need more testing. There could be new occurrences to C4::Members::Messaging that also need to be handled by these patches. Please keep this in mind if testing. I remember there was some bug related to category messaging preference view and I'm not sure if that got fixed. I was hoping someone in the community finds this work useful and wants to take it to the finish line. Feel free to steal this Bug or help fixing issues by follow-ups. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri May 12 15:43:18 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 12 May 2017 13:43:18 +0000 Subject: [Koha-bugs] [Bug 18569] Quick add patron will not copy over details from cities and towns pull down into patron details In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18569 Nick Clemens changed: What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |Needs Signoff Patch complexity|--- |Trivial patch -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri May 12 15:43:21 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 12 May 2017 13:43:21 +0000 Subject: [Koha-bugs] [Bug 18569] Quick add patron will not copy over details from cities and towns pull down into patron details In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18569 --- Comment #1 from Nick Clemens --- Created attachment 63442 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=63442&action=edit Bug 18569 - Quick add patron will not copy over details from cities and towns pull down into patron details As the quick add form is created dynamically we must alter the function that updates there fields to use a selector so it is not bound on the intial elements To test: 1 - Add city field to QuickAddFields 2 - Define some cities in Admin->Cities and towns 3 - Test using the dropdown in uqick add form 4 - Nothing happens 5 - Switch to full form 6 - use cities dropdown 7 - it works 8 - switch to quick add form 9 - dropdown is not updated 10 - Apply patch 11 - Things should now update correctly on both forms and update when switching forms -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri May 12 15:59:53 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 12 May 2017 13:59:53 +0000 Subject: [Koha-bugs] [Bug 17505] REST API: Add route for messaging preferences In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17505 --- Comment #2 from Lari Taskula --- Hey. Any update on this? I will start working on it if you haven't already. I attached Koha-objects to Bug 17499 which could be useful for this one. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri May 12 16:02:59 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 12 May 2017 14:02:59 +0000 Subject: [Koha-bugs] [Bug 18597] New: Quick add form does not transfer patron attributes values when switching forms /saving Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18597 Bug ID: 18597 Summary: Quick add form does not transfer patron attributes values when switching forms/saving Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Patrons Assignee: koha-bugs at lists.koha-community.org Reporter: nick at bywatersolutions.com QA Contact: testopia at bugs.koha-community.org CC: gmcharlt at gmail.com, kyle.m.hall at gmail.com To recreate 1 - Have some patron attributes (with/without auth values set) 2 - Add them to QuickAddFields (patron_attr2 for example) 3 - view quick add form and set some values 4 - Switch to full form, values not transferred 5 - Swithc to quick add, view values, save 6 - Values are not saved :-( -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Fri May 12 16:06:06 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 12 May 2017 14:06:06 +0000 Subject: [Koha-bugs] [Bug 18594] Add audible alarm for batch import In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18594 Owen Leonard changed: What |Removed |Added ---------------------------------------------------------------------------- Component|MARC Bibliographic record |Templates |staging/import | Assignee|gmcharlt at gmail.com |oleonard at myacpl.org Version|unspecified |master --- Comment #1 from Owen Leonard --- Audio alert customization depends on having the correct selector to act as a "hook" for the alert, so this is a template bug. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri May 12 16:08:19 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 12 May 2017 14:08:19 +0000 Subject: [Koha-bugs] [Bug 18597] Quick add form does not transfer patron attributes values when switching forms /saving In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18597 Nick Clemens changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff Patch complexity|--- |Trivial patch -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri May 12 16:08:22 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 12 May 2017 14:08:22 +0000 Subject: [Koha-bugs] [Bug 18597] Quick add form does not transfer patron attributes values when switching forms /saving In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18597 --- Comment #1 from Nick Clemens --- Created attachment 63443 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=63443&action=edit Bug 18597 - Quick add form does not transfer patron attributes values when switching forms/saving The function that switches between quick add/fulll form assumes labels are followed by values - patron_attr don't follow this pattern. This patch just moves the hidden input field To test: 1 - Have some patron attributes (with/without auth values set) 2 - Add them to QuickAddFields (patron_attr2 for example) 3 - view quick add form and set some values 4 - Switch to full form, values not transferred 5 - Switch to quick add, view values, save 6 - Values are not saved :-( 7 - Apply patch 8 - Repeat 3 - 5 9 - Values are transferred and saved :-) -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri May 12 16:08:40 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 12 May 2017 14:08:40 +0000 Subject: [Koha-bugs] [Bug 18597] Quick add form does not transfer patron attributes values when switching forms /saving In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18597 Nick Clemens changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on| |3534 Assignee|koha-bugs at lists.koha-commun |nick at bywatersolutions.com |ity.org | Severity|enhancement |normal Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=3534 [Bug 3534] Patron quick add form -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Fri May 12 16:08:40 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 12 May 2017 14:08:40 +0000 Subject: [Koha-bugs] [Bug 3534] Patron quick add form In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=3534 Nick Clemens changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |18597 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18597 [Bug 18597] Quick add form does not transfer patron attributes values when switching forms/saving -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri May 12 16:15:44 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 12 May 2017 14:15:44 +0000 Subject: [Koha-bugs] [Bug 18571] koha-conf.xml should include ES entry In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18571 Mirko Tietgen changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #63368|0 |1 is obsolete| | --- Comment #2 from Mirko Tietgen --- Created attachment 63444 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=63444&action=edit Bug 18571: Add default ES configuration to koha-conf-site.xml.in This patch adds a default configuration entry for elasticsearch. It will add localhost:9200 to the server subsection, and koha_instance (replacing instance for the corresponding instance name) for the namespace. To test: - Apply the patch - Copy the file to the /etc/koha dir: $ sudo cp kohaclone/debian/templates/koha-conf-site.xml.in /etc/koha - Create a new instance: $ sudo koha-create --create-db test => SUCCESS: /etc/koha/sites/test/koha-conf.xml includes the mentioned section: localhost:9200 koha_test - Sign off :-D Note: As the use of ES is syspref driven, this default entry doesn't have any use until ES is installed and SearchEngine set to Elasticsearch. So it doesn't hurt but will help end users test the ES integration. Advanced users will take care of this config entry manually (pointing to external servers/clusters, etc). Signed-off-by: Mirko Tietgen -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri May 12 16:15:58 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 12 May 2017 14:15:58 +0000 Subject: [Koha-bugs] [Bug 18571] koha-conf.xml should include ES entry In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18571 Mirko Tietgen changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri May 12 16:21:48 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 12 May 2017 14:21:48 +0000 Subject: [Koha-bugs] [Bug 18343] Manage MARC import DBH should not be shared In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18343 --- Comment #5 from Jonathan Druart --- The quick fix is to use DBIx::Class transactions. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri May 12 16:26:56 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 12 May 2017 14:26:56 +0000 Subject: [Koha-bugs] [Bug 17942] Update style of the web installer with Bootstrap 3 In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17942 Kyle M Hall changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |kyle at bywatersolutions.com Status|Passed QA |Pushed to Master --- Comment #50 from Kyle M Hall --- Pushed to master for 17.05, thanks Owen, Jonathan! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri May 12 16:27:50 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 12 May 2017 14:27:50 +0000 Subject: [Koha-bugs] [Bug 18035] Front-end changes to serials -> Numbering patterns In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18035 Kyle M Hall changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |kyle at bywatersolutions.com Status|Passed QA |Pushed to Master --- Comment #10 from Kyle M Hall --- Pushed to master for 17.05, thanks Aleisha! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri May 12 16:30:28 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 12 May 2017 14:30:28 +0000 Subject: [Koha-bugs] [Bug 18598] New: Quick add form doesn't clear values when switching Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18598 Bug ID: 18598 Summary: Quick add form doesn't clear values when switching Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: normal Priority: P5 - low Component: Patrons Assignee: koha-bugs at lists.koha-community.org Reporter: nick at bywatersolutions.com QA Contact: testopia at bugs.koha-community.org CC: gmcharlt at gmail.com, kyle.m.hall at gmail.com To test: 1 - Fill out some fields in quick add 2 - Switch to full form and clear fields 3 - Switch back and fields are still populated 4 - Fill a field in long form 5 - Switch to quick add and clear it 6 - Save 7 - Value set in 4 is saved -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri May 12 16:33:50 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 12 May 2017 14:33:50 +0000 Subject: [Koha-bugs] [Bug 18598] Quick add form doesn't clear values when switching In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18598 Nick Clemens changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff Depends on| |3534 Patch complexity|--- |Trivial patch Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=3534 [Bug 3534] Patron quick add form -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Fri May 12 16:33:50 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 12 May 2017 14:33:50 +0000 Subject: [Koha-bugs] [Bug 3534] Patron quick add form In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=3534 Nick Clemens changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |18598 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18598 [Bug 18598] Quick add form doesn't clear values when switching -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri May 12 16:33:54 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 12 May 2017 14:33:54 +0000 Subject: [Koha-bugs] [Bug 18598] Quick add form doesn't clear values when switching In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18598 --- Comment #1 from Nick Clemens --- Created attachment 63445 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=63445&action=edit Bug 18598 - Quick add form doesn't clear values when switching To test: 1 - Fill out some fields in quick add 2 - Switch to full form and clear fields 3 - Switch back and fields are still populated 4 - Fill a field in long form 5 - Switch to quick add and clear it 6 - Save 7 - Value set in 4 is saved 8 - Apply patch 9 - Repeat 1-6 - values should be cleared and not saved -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Fri May 12 16:34:12 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 12 May 2017 14:34:12 +0000 Subject: [Koha-bugs] [Bug 17762] Ability to translate notices In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17762 Kyle M Hall changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to Master CC| |kyle at bywatersolutions.com --- Comment #58 from Kyle M Hall --- Pushed to master for 17.05, thanks Jonathan, Nick! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri May 12 16:34:13 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 12 May 2017 14:34:13 +0000 Subject: [Koha-bugs] [Bug 18598] Quick add form doesn't clear values when switching In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18598 Nick Clemens changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|koha-bugs at lists.koha-commun |nick at bywatersolutions.com |ity.org | -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Fri May 12 16:35:18 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 12 May 2017 14:35:18 +0000 Subject: [Koha-bugs] [Bug 18554] Adjust a few typos including responsability In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18554 Kyle M Hall changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |kyle at bywatersolutions.com Status|Passed QA |Pushed to Master --- Comment #6 from Kyle M Hall --- Pushed to master for 17.05, thanks Marcel! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri May 12 16:36:15 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 12 May 2017 14:36:15 +0000 Subject: [Koha-bugs] [Bug 15179] Marc field 084 does not show on bibliographic record In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15179 Kyle M Hall changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |kyle at bywatersolutions.com Status|Passed QA |Pushed to Master --- Comment #9 from Kyle M Hall --- Pushed to master for 17.05, thanks Karen, Nick! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri May 12 16:40:19 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 12 May 2017 14:40:19 +0000 Subject: [Koha-bugs] [Bug 15582] Ability to block auto renewals if the OPACFineNoRenewals amount is reached In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15582 Kyle M Hall changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |kyle at bywatersolutions.com Status|Passed QA |Pushed to Master --- Comment #44 from Kyle M Hall --- Pushed to master for 17.05, thanks Jonathan! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri May 12 16:42:11 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 12 May 2017 14:42:11 +0000 Subject: [Koha-bugs] [Bug 17618] perl-modules Debian package name change In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17618 Tom?s Cohen Arazi changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off Patch complexity|--- |Trivial patch -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri May 12 16:42:15 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 12 May 2017 14:42:15 +0000 Subject: [Koha-bugs] [Bug 17618] perl-modules Debian package name change In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17618 Tom?s Cohen Arazi changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #63418|0 |1 is obsolete| | --- Comment #6 from Tom?s Cohen Arazi --- Created attachment 63446 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=63446&action=edit Bug 17618: perl-modules Debian package name change Newer versios of perl-modules have a version number in the package name. This patch makes Koha aware of perl-modules-5.22 and perl-modules-5.24 Signed-off-by: Tomas Cohen Arazi -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri May 12 16:45:23 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 12 May 2017 14:45:23 +0000 Subject: [Koha-bugs] [Bug 18596] Quick add form duplicating password confirm In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18596 Nick Clemens changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri May 12 16:45:25 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 12 May 2017 14:45:25 +0000 Subject: [Koha-bugs] [Bug 18596] Quick add form duplicating password confirm In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18596 Nick Clemens changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #63426|0 |1 is obsolete| | --- Comment #3 from Nick Clemens --- Created attachment 63447 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=63447&action=edit [SIGNED-OFF] Bug 18596 - Quick add form duplicating password confirm To test: 1 - Add password to BorrowerMandatoryField 2 - View quick add form 3 - See confirm password twice 4 - Apply patch 5 - See confirm password once 6 - Add password to QuickAddFields 7 - Confirm one confirm field 8 - Remove password form BorrowerMandatory field 9 - Confirm there is one confirm field and password fields are not required Signed-off-by: Peggy Thrasher -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri May 12 16:46:03 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 12 May 2017 14:46:03 +0000 Subject: [Koha-bugs] [Bug 18597] Quick add form does not transfer patron attributes values when switching forms /saving In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18597 Nick Clemens changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri May 12 16:46:05 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 12 May 2017 14:46:05 +0000 Subject: [Koha-bugs] [Bug 18597] Quick add form does not transfer patron attributes values when switching forms /saving In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18597 Nick Clemens changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #63443|0 |1 is obsolete| | --- Comment #2 from Nick Clemens --- Created attachment 63448 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=63448&action=edit [SIGNED-OFF] Bug 18597 - Quick add form does not transfer patron attributes values when switching forms/saving The function that switches between quick add/fulll form assumes labels are followed by values - patron_attr don't follow this pattern. This patch just moves the hidden input field To test: 1 - Have some patron attributes (with/without auth values set) 2 - Add them to QuickAddFields (patron_attr2 for example) 3 - view quick add form and set some values 4 - Switch to full form, values not transferred 5 - Switch to quick add, view values, save 6 - Values are not saved :-( 7 - Apply patch 8 - Repeat 3 - 5 9 - Values are transferred and saved :-) Signed-off-by: Peggy Thrasher -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri May 12 16:48:31 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 12 May 2017 14:48:31 +0000 Subject: [Koha-bugs] [Bug 18571] koha-conf.xml should include ES entry In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18571 Tom?s Cohen Arazi changed: What |Removed |Added ---------------------------------------------------------------------------- Severity|enhancement |normal -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri May 12 16:48:51 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 12 May 2017 14:48:51 +0000 Subject: [Koha-bugs] [Bug 15705] Notify the user on auto renewing In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15705 Kyle M Hall changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to Master CC| |kyle at bywatersolutions.com --- Comment #71 from Kyle M Hall --- Pushed to master for 17.05, thanks Jonathan, Nick! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri May 12 16:52:39 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 12 May 2017 14:52:39 +0000 Subject: [Koha-bugs] [Bug 17465] Add a System Preference to control number of Saved Reports displayed In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17465 Kyle M Hall changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to Master CC| |kyle at bywatersolutions.com --- Comment #4 from Kyle M Hall --- Pushed to master for 17.05, thanks Aleisha! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri May 12 16:53:18 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 12 May 2017 14:53:18 +0000 Subject: [Koha-bugs] [Bug 18596] Quick add form duplicating password confirm In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18596 Owen Leonard changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #63447|0 |1 is obsolete| | --- Comment #4 from Owen Leonard --- Created attachment 63449 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=63449&action=edit [SIGNED-OFF] Bug 18596 - Quick add form duplicating password confirm To test: 1 - Add password to BorrowerMandatoryField 2 - View quick add form 3 - See confirm password twice 4 - Apply patch 5 - See confirm password once 6 - Add password to QuickAddFields 7 - Confirm one confirm field 8 - Remove password form BorrowerMandatory field 9 - Confirm there is one confirm field and password fields are not required Signed-off-by: Owen Leonard -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri May 12 16:54:28 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 12 May 2017 14:54:28 +0000 Subject: [Koha-bugs] [Bug 17618] perl-modules Debian package name change In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17618 Mirko Tietgen changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA --- Comment #7 from Mirko Tietgen --- Packaging patch, has been tested in the nightly builds too. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri May 12 16:55:37 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 12 May 2017 14:55:37 +0000 Subject: [Koha-bugs] [Bug 17618] perl-modules Debian package name change In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17618 Mirko Tietgen changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #63446|0 |1 is obsolete| | --- Comment #8 from Mirko Tietgen --- Created attachment 63450 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=63450&action=edit Bug 17618: perl-modules Debian package name change Newer versios of perl-modules have a version number in the package name. This patch makes Koha aware of perl-modules-5.22 and perl-modules-5.24 Signed-off-by: Tomas Cohen Arazi Signed-off-by: Mirko Tietgen -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri May 12 17:00:04 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 12 May 2017 15:00:04 +0000 Subject: [Koha-bugs] [Bug 18314] Account lockout In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18314 Kyle M Hall changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to Master CC| |kyle at bywatersolutions.com --- Comment #35 from Kyle M Hall --- Pushed to master for 17.05, thanks Jonathan, Nick! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri May 12 17:00:50 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 12 May 2017 15:00:50 +0000 Subject: [Koha-bugs] [Bug 18350] Moving call number in subscriptions tab in OPAC biblio detail In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18350 Kyle M Hall changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |kyle at bywatersolutions.com Status|Passed QA |Pushed to Master --- Comment #5 from Kyle M Hall --- Pushed to master for 17.05, thanks Aleisha, Nick! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri May 12 17:01:41 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 12 May 2017 15:01:41 +0000 Subject: [Koha-bugs] [Bug 17618] perl-modules Debian package name change In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17618 Kyle M Hall changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |kyle at bywatersolutions.com Status|Passed QA |Pushed to Master --- Comment #9 from Kyle M Hall --- Pushed to master for 17.05, thanks Mirko! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri May 12 17:04:11 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 12 May 2017 15:04:11 +0000 Subject: [Koha-bugs] [Bug 18450] Renew in header bypasses hold block and renewal limits In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18450 Owen Leonard changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri May 12 17:45:34 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 12 May 2017 15:45:34 +0000 Subject: [Koha-bugs] [Bug 18201] Export data -Fix "Remove non-local items" option and add " Removes non-local records" option for existing functionality In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18201 Nick Clemens changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |In Discussion --- Comment #5 from Nick Clemens --- (In reply to Marcel de Rooy from comment #4) > Not sure if we should classify this as a bug or an enhancement. I assigned 'bug' because the current options don't do what people expect, it is essentially broken > if I read "Remove records", I suppose that will scare > some people. Would it be better to talk about excluding records or items > from an export ? 'Exclude' is okay by me, but remove is the current language so I thought it should be preserved > Another confusing thing is that we now have a library selection in the top > of the form and an option "Remove .. not owned by library" in the bottom. It > seems contradictory, or needs further explanation on the form. I take your point, but that is actually the current state, the checkbox just appears to have a different function, it actually limits to records owned by the library you are signed in at. Would you prefer to remove this option? The only use case I see is that you can select one library at the top - check the box at the bottom and now get only records owned by both branches. Select all but your own branch at the top, check the box, and then you have a list of items you own that are not unique, may be useful in cosortia where unique items must be preserved but can be achieved via reports > > What actually is a record not owned by a library? It makes sense for items, > but how does it relate to biblios ? 'Owned by' in this context means 'hosts an item owned by' - A record is owned by a library if they own an item on that record > Changing status to reflect need for feedback. > All by all, I think we need some more thought here and I would suggest to > classify it as an enhancement. My goal was to preserve current functionality but provide expected functionality, I can accept if it is viewed as an enhancement but need some direction on what should be changed -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri May 12 18:07:56 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 12 May 2017 16:07:56 +0000 Subject: [Koha-bugs] [Bug 17505] REST API: Add route for messaging preferences In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17505 --- Comment #3 from Jiri Kozlovsky --- (In reply to Lari Taskula from comment #2) > Hey. Any update on this? I will start working on it if you haven't already. > I attached Koha-objects to Bug 17499 which could be useful for this one. Hey there Lari. Yes, I've already done some work, but now I'm going to be away from work on Koha until I finish final school exams for bachelor's degree. If you want, you can take a look at the work & finish it ;) All the work is in this single commit: https://github.com/open-source-knihovna/KohaCZ/commit/7bddf4f709fce467296ddce814b4612aeaa00088 Basically I made it work for GET request. Feel free to change my coding style as you wish :D -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri May 12 20:35:20 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 12 May 2017 18:35:20 +0000 Subject: [Koha-bugs] [Bug 18201] Export data -Fix "Remove non-local items" option and add " Removes non-local records" option for existing functionality In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18201 Christopher Brannon changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |cbrannon at cdalibrary.org --- Comment #6 from Christopher Brannon --- (In reply to Marcel de Rooy from comment #4) > Not sure if we should classify this as a bug or an enhancement. It also > includes strings. It's main goal is to fix something that isn't working as expected. Plumbing shouldn't change it to an enhancement in my opinion. > And if I read "Remove records", I suppose that will scare > some people. Would it be better to talk about excluding records or items > from an export ? I think the term "exclude" would be better. > Another confusing thing is that we now have a library selection in the top > of the form and an option "Remove .. not owned by library" in the bottom. It > seems contradictory, or needs further explanation on the form. I think the options should be up with the "Select records to export" section, and the "Remove non-local items" should say "Exclude bib records without items from signed in library". Nick, you will hate this idea, but to be consistent and clear, the options would do well to read: Exclude items records: Exclude bib records without items from [SIGNED IN LIBRARY NAME]: Exclude fields: That's my two cents. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri May 12 20:47:05 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 12 May 2017 18:47:05 +0000 Subject: [Koha-bugs] [Bug 18434] Elasticsearch indexing broken with newer catmandu version In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18434 --- Comment #4 from Tom?s Cohen Arazi --- Created attachment 63451 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=63451&action=edit Bug 18434: Add tests for K:SE:E::get_fixer_rules This patch tries to introduce exhaustive tests for this class method. I didn't try to provide a regression test for the current bug per-se, but cover the current method behaviour as much as I could. A minor bug is highlighted by this new tests, I'll provide a followup for it. To test: - Run: $ sudo koha-shell kohadev k$ de kohaclone k$ prove t/db_dependent/Koha_Elasticsearch.t => FAIL: The returned fixer rules are not the expected ones Signed-off-by: Tomas Cohen Arazi -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri May 12 20:47:13 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 12 May 2017 18:47:13 +0000 Subject: [Koha-bugs] [Bug 18434] Elasticsearch indexing broken with newer catmandu version In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18434 Tom?s Cohen Arazi changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #62702|0 |1 is obsolete| | --- Comment #5 from Tom?s Cohen Arazi --- Created attachment 63452 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=63452&action=edit Bug 18434: Elasticsearch indexing broken with newer catmandu version To test: 1 - Make sure you have latest koha deps, catmandu versions should be: libcatmandu-marc-perl 1.09-1~kohadev1 libcatmandu-perl 1.0304-2~kohadev1 2 - Reindex elastic 3 - Try searching and likely notice odd results 4 - Try: curl -XGET 'http://localhost:9200/koha_kohadev_biblios/data/792?pretty=true' with a known biblionumber and notice some null fields 5 - Apply patch 6 - Reindex 7 - Note fields are populated and search works as expected Signed-off-by: Chris Cormack Signed-off-by: Tomas Cohen Arazi -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri May 12 20:47:19 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 12 May 2017 18:47:19 +0000 Subject: [Koha-bugs] [Bug 18434] Elasticsearch indexing broken with newer catmandu version In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18434 --- Comment #6 from Tom?s Cohen Arazi --- Created attachment 63453 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=63453&action=edit Bug 18434: (followup) Remove unneeded comma in fixer rules Signed-off-by: Tomas Cohen Arazi -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri May 12 20:51:07 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 12 May 2017 18:51:07 +0000 Subject: [Koha-bugs] [Bug 18434] Elasticsearch indexing broken with newer catmandu version In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18434 --- Comment #7 from Tom?s Cohen Arazi --- (In reply to Tom?s Cohen Arazi from comment #6) > Created attachment 63453 [details] [review] > Bug 18434: (followup) Remove unneeded comma in fixer rules > > Signed-off-by: Tomas Cohen Arazi I forgot to metion: To test: - Run: $ prove t/db_dependent/Koha_Elasticsearch.t => SUCCESS: All should be green! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri May 12 22:35:48 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 12 May 2017 20:35:48 +0000 Subject: [Koha-bugs] [Bug 17499] Koha objects for messaging preferences In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17499 Mike changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |black23 at gmail.com -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri May 12 23:14:41 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 12 May 2017 21:14:41 +0000 Subject: [Koha-bugs] [Bug 16149] Generate and send custom notices based on report output In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16149 Nick Clemens changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #62217|0 |1 is obsolete| | --- Comment #3 from Nick Clemens --- Created attachment 63454 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=63454&action=edit Bug 16149 - Generate and send custom notices based on report output Ths patch add an EmailReport function to C4::Reports::Guided It accepts a notice (module, code, branch) and a report and attempts to email notices to patron, generating content using report content. Notice must be in template toolkit syntax, only columns in report are available for notice. To test: 1 - Specify various options 2 - Ensure errors are returned if options are incomplete or incorrect 3 - Pass a report containing 'from' and 'email' and 'borrowernumber' columns and ensure message queue populated as expected -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri May 12 23:14:45 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 12 May 2017 21:14:45 +0000 Subject: [Koha-bugs] [Bug 16149] Generate and send custom notices based on report output In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16149 --- Comment #4 from Nick Clemens --- Created attachment 63455 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=63455&action=edit Bug 16149 - Unit tests To test: prove -v t/db_dependent/Reports/Guided.t -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri May 12 23:14:38 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 12 May 2017 21:14:38 +0000 Subject: [Koha-bugs] [Bug 16149] Generate and send custom notices based on report output In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16149 Nick Clemens changed: What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri May 12 23:46:30 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 12 May 2017 21:46:30 +0000 Subject: [Koha-bugs] [Bug 18599] New: "Record URL" link href is broken for multiple 856$u links in MARC record Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18599 Bug ID: 18599 Summary: "Record URL" link href is broken for multiple 856$u links in MARC record Change sponsored?: --- Product: Koha Version: 16.11 Hardware: All OS: All Status: NEW Severity: normal Priority: P5 - low Component: Course reserves Assignee: koha-bugs at lists.koha-community.org Reporter: ephetteplace at cca.edu QA Contact: testopia at bugs.koha-community.org If you place a course reserve on a bib where the MARC record contains multiple 856 $u URLs, the resulting "Record URL" link in the Link column on both the staff and public catalogs (i.e. /cgi-bin/koha/course_reserves/course-details.pl?course_id=XXX and /cgi-bin/koha/opac-course-details.pl?course_id=XXX) is broken. It looks as if the URL is constructed by concatenating both 856 URLs and separating them with a vertical bar character surrounded by spaces, " | ". Testing Plan: - create a bib record with at least two MARC 856 fields with valid URLs in their $u subfields - add an item to the bib record - enable course reserves (UseCourseReserves) - create a course - add an item from the aforementioned record on course reserve - visit its course details page - note that the "Record URL" link in the Link column is broken I'm not sure if the problem lies within Course Reserves itself; I investigated briefly and I see "cr.item.url" is the field utilized by the template. I don't need a "url" field in course_reserves or related database tables, I'm guessing it's a field on the connected item record. I'm seeing this on 16.11 but I haven't tested master. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Sat May 13 08:17:28 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 13 May 2017 06:17:28 +0000 Subject: [Koha-bugs] [Bug 17827] Untranslatable "by" in MARC21slim2intranetResults.xsl In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17827 Serhij Dubyk changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Sat May 13 08:19:50 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 13 May 2017 06:19:50 +0000 Subject: [Koha-bugs] [Bug 17827] Untranslatable "by" in MARC21slim2intranetResults.xsl In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17827 Serhij Dubyk changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |dubyk at ukr.net -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat May 13 08:20:02 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 13 May 2017 06:20:02 +0000 Subject: [Koha-bugs] [Bug 17791] On UNIMARC system, USMARC field 100$a gets overwritten In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17791 Serhij Dubyk changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |dubyk at ukr.net -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat May 13 13:32:00 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 13 May 2017 11:32:00 +0000 Subject: [Koha-bugs] [Bug 18420] Some tests fail without patron category 'S' In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18420 --- Comment #39 from Katrin Fischer --- Still having problems, please rebase! Applying: Bug 18420: Do not use 'S' as patron category code in other tests Using index info to reconstruct a base tree... M t/db_dependent/Acquisition/OrderUsers.t M t/db_dependent/Circulation.t M t/db_dependent/Holds/HoldFulfillmentPolicy.t M t/db_dependent/Holds/HoldItemtypeLimit.t Falling back to patching base and 3-way merge... Auto-merging t/db_dependent/Holds/HoldItemtypeLimit.t Auto-merging t/db_dependent/Holds/HoldFulfillmentPolicy.t Auto-merging t/db_dependent/Circulation.t CONFLICT (content): Merge conflict in t/db_dependent/Circulation.t -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat May 13 13:42:28 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 13 May 2017 11:42:28 +0000 Subject: [Koha-bugs] [Bug 18409] Error when updating pickup library on patron pages In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18409 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |katrin.fischer at bsz-bw.de --- Comment #6 from Katrin Fischer --- Patch doesn't apply cleanly to 16.11.x - please rebase/comment if this is needed there! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat May 13 13:43:09 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 13 May 2017 11:43:09 +0000 Subject: [Koha-bugs] [Bug 18468] When adding from a staged file order discounts are not passed into C4:: Acquisitions::populate_order_with_prices In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18468 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Resolution|--- |FIXED Status|Pushed to Master |RESOLVED --- Comment #7 from Katrin Fischer --- Dependency is not in 16.11.x. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat May 13 13:44:27 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 13 May 2017 11:44:27 +0000 Subject: [Koha-bugs] [Bug 18435] Message about Materials specified does not display when items are checked out and checked in In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18435 --- Comment #5 from Katrin Fischer --- This patch has been pushed to 16.11.x and will be in 16.11.08. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat May 13 13:46:54 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 13 May 2017 11:46:54 +0000 Subject: [Koha-bugs] [Bug 18435] Message about Materials specified does not display when items are checked out and checked in In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18435 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to Master |Pushed to Stable -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat May 13 13:46:45 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 13 May 2017 11:46:45 +0000 Subject: [Koha-bugs] [Bug 18457] process_message_queue.pl will die if a patron has no sms_provider_id set but sms via email is enabled for that patron In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18457 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to Master |Pushed to Stable CC| |katrin.fischer at bsz-bw.de --- Comment #7 from Katrin Fischer --- These patches have been pushed to 16.11.x and will be in 16.11.08. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat May 13 13:49:32 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 13 May 2017 11:49:32 +0000 Subject: [Koha-bugs] [Bug 15702] Trim whitespace from patron details upon submission In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15702 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |katrin.fischer at bsz-bw.de --- Comment #20 from Katrin Fischer --- These patches have been pushed to 16.11.x and will be in 16.11.08. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat May 13 13:49:38 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 13 May 2017 11:49:38 +0000 Subject: [Koha-bugs] [Bug 15702] Trim whitespace from patron details upon submission In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15702 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to Master |Pushed to Stable -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat May 13 13:50:25 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 13 May 2017 11:50:25 +0000 Subject: [Koha-bugs] [Bug 18466] No article requests breaks the opac-user-views block In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18466 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |katrin.fischer at bsz-bw.de Status|Pushed to Master |Pushed to Stable --- Comment #7 from Katrin Fischer --- This patch has been pushed to 16.11.x and will be in 16.11.08. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat May 13 13:52:33 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 13 May 2017 11:52:33 +0000 Subject: [Koha-bugs] [Bug 15815] Improve wording in popup warning when deleting patron from patron-batch In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15815 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Summary|improve wording in popup |Improve wording in popup |warning when deleting |warning when deleting |patron from patron-batch |patron from patron-batch Status|Pushed to Master |Pushed to Stable CC| |katrin.fischer at bsz-bw.de --- Comment #6 from Katrin Fischer --- This patch has been pushed to 16.11.x and will be in 16.11.08. Wording change - tiny enough for backporting :) -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat May 13 13:53:58 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 13 May 2017 11:53:58 +0000 Subject: [Koha-bugs] [Bug 18452] Should say 'URL' instead of 'url' in catalog detail In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18452 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Severity|enhancement |trivial CC| |katrin.fischer at bsz-bw.de --- Comment #5 from Katrin Fischer --- This patch has been pushed to 16.11.x and will be in 16.11.08. Corrects spelling - changing from enhancement to trivial. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat May 13 13:54:03 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 13 May 2017 11:54:03 +0000 Subject: [Koha-bugs] [Bug 18452] Should say 'URL' instead of 'url' in catalog detail In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18452 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to Master |Pushed to Stable -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat May 13 13:56:19 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 13 May 2017 11:56:19 +0000 Subject: [Koha-bugs] [Bug 18461] Internal server error while approving OPAC-edited patron attributes containing umlauts (=?UTF-8?Q?=C3=A4=C3=B6=C3=BC?=) In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18461 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |katrin.fischer at bsz-bw.de Status|Pushed to Master |RESOLVED Resolution|--- |FIXED --- Comment #14 from Katrin Fischer --- Depends on bug 13757 which is not part of 16.11.x. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat May 13 13:59:58 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 13 May 2017 11:59:58 +0000 Subject: [Koha-bugs] [Bug 18471] Receiving order with unitprice greater than 1000 processing incorrectly In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18471 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |katrin.fischer at bsz-bw.de --- Comment #11 from Katrin Fischer --- Patch doesn't apply to 16.11.x - please rebase/comment if it's needed there. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat May 13 14:02:18 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 13 May 2017 12:02:18 +0000 Subject: [Koha-bugs] [Bug 18467] Error calling count on undefined bib in basket.pl if order cancelled and record deleted In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18467 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |katrin.fischer at bsz-bw.de --- Comment #12 from Katrin Fischer --- This doesn't apply cleanly on 16.11.x, please rebase/comment if it's needed there. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat May 13 14:04:50 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 13 May 2017 12:04:50 +0000 Subject: [Koha-bugs] [Bug 18179] Koha::Objects->find should not be called in list context In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18179 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |katrin.fischer at bsz-bw.de --- Comment #34 from Katrin Fischer --- (In reply to Jonathan Druart from comment #10) > @RMaints, I would not backport the first patch, but the second one is safe > ("Update existing calls"). Tried to backport, but there is a conflict in pay.pl. Can you take a look please? -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat May 13 14:06:25 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 13 May 2017 12:06:25 +0000 Subject: [Koha-bugs] [Bug 18482] False duplicates detected on adding a batch from a stage file In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18482 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |katrin.fischer at bsz-bw.de --- Comment #8 from Katrin Fischer --- There is a conflict in acqui/addorderiso2709.pl when applying this to 16.11.x, can you please check? -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat May 13 14:07:19 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 13 May 2017 12:07:19 +0000 Subject: [Koha-bugs] [Bug 15738] Summary page says item has no fines, but Fines tab says otherwise In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15738 --- Comment #14 from Katrin Fischer --- This patch has been pushed to 16.11.x and will be in 16.11.08. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat May 13 14:15:37 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 13 May 2017 12:15:37 +0000 Subject: [Koha-bugs] [Bug 18419] Broken patron-blank image in viewlog.tt In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18419 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |katrin.fischer at bsz-bw.de Status|Pushed to Master |Pushed to Stable --- Comment #7 from Katrin Fischer --- This patch has been pushed to 16.11.x and will be in 16.11.08. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat May 13 14:20:53 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 13 May 2017 12:20:53 +0000 Subject: [Koha-bugs] [Bug 17916] "Delete MARC modification template" fails to actually delete it In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17916 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to Master |Pushed to Stable --- Comment #6 from Katrin Fischer --- This patch has been pushed to 16.11.x and will be in 16.11.08. Small conflict in the template. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat May 13 14:22:50 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 13 May 2017 12:22:50 +0000 Subject: [Koha-bugs] [Bug 18453] "Export" column is not hidden when ExportCircHistory is off In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18453 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Resolution|--- |FIXED Status|Pushed to Master |RESOLVED CC| |katrin.fischer at bsz-bw.de --- Comment #15 from Katrin Fischer --- Dependency is not in 16.11.x. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat May 13 14:24:35 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 13 May 2017 12:24:35 +0000 Subject: [Koha-bugs] [Bug 18479] Holds 'Placed on' column in opac-user.pl not sorting correctly In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18479 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |katrin.fischer at bsz-bw.de --- Comment #5 from Katrin Fischer --- Patch doesn't apply cleanly to 16.11.x - please rebase! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat May 13 14:25:25 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 13 May 2017 12:25:25 +0000 Subject: [Koha-bugs] [Bug 18456] Update Italian installer sample files for 17.05 In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18456 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |katrin.fischer at bsz-bw.de --- Comment #7 from Katrin Fischer --- This is specific for 17.05 and won't get backported. Please note: The commit on master is missing the bug number so this won't show up in the release notes. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat May 13 14:27:45 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 13 May 2017 12:27:45 +0000 Subject: [Koha-bugs] [Bug 13835] Popup with searches: results hidden by language menu in footer In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13835 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to Master |Pushed to Stable CC| |katrin.fischer at bsz-bw.de --- Comment #10 from Katrin Fischer --- This patch has been pushed to 16.11.x and will be in 16.11.08. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat May 13 14:29:27 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 13 May 2017 12:29:27 +0000 Subject: [Koha-bugs] [Bug 17855] New onboarding tool feature to guide users through setting up Koha, and minor web installer UI improvements In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17855 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to Master |RESOLVED Resolution|--- |FIXED --- Comment #234 from Katrin Fischer --- This won't get ported back to 16.11.x as it is a new feature. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat May 13 14:29:28 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 13 May 2017 12:29:28 +0000 Subject: [Koha-bugs] [Bug 17942] Update style of the web installer with Bootstrap 3 In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17942 Bug 17942 depends on bug 17855, which changed state. Bug 17855 Summary: New onboarding tool feature to guide users through setting up Koha, and minor web installer UI improvements https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17855 What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to Master |RESOLVED Resolution|--- |FIXED -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat May 13 14:29:29 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 13 May 2017 12:29:29 +0000 Subject: [Koha-bugs] [Bug 17944] Remove the sql code from itemtypes.pl administrative perl script In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17944 Bug 17944 depends on bug 17855, which changed state. Bug 17855 Summary: New onboarding tool feature to guide users through setting up Koha, and minor web installer UI improvements https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17855 What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to Master |RESOLVED Resolution|--- |FIXED -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat May 13 14:29:30 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 13 May 2017 12:29:30 +0000 Subject: [Koha-bugs] [Bug 17954] Remove the sql code from the smart-rules.pl administrative script In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17954 Bug 17954 depends on bug 17855, which changed state. Bug 17855 Summary: New onboarding tool feature to guide users through setting up Koha, and minor web installer UI improvements https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17855 What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to Master |RESOLVED Resolution|--- |FIXED -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat May 13 14:29:30 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 13 May 2017 12:29:30 +0000 Subject: [Koha-bugs] [Bug 17956] Provide additional functionality in the onboarding tool through configuring z-targets , and providing information on setting up SIP and LDAP services In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17956 Bug 17956 depends on bug 17855, which changed state. Bug 17855 Summary: New onboarding tool feature to guide users through setting up Koha, and minor web installer UI improvements https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17855 What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to Master |RESOLVED Resolution|--- |FIXED -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat May 13 14:29:30 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 13 May 2017 12:29:30 +0000 Subject: [Koha-bugs] [Bug 18039] Move the mandatory and optional files for non-english languages into ' default' directory so bug 17855 permits use of other languages In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18039 Bug 18039 depends on bug 17855, which changed state. Bug 17855 Summary: New onboarding tool feature to guide users through setting up Koha, and minor web installer UI improvements https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17855 What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to Master |RESOLVED Resolution|--- |FIXED -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat May 13 14:29:31 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 13 May 2017 12:29:31 +0000 Subject: [Koha-bugs] [Bug 17955] Remove the sql code and unnecessary use pragmas from the onboarding.pl script In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17955 Bug 17955 depends on bug 17855, which changed state. Bug 17855 Summary: New onboarding tool feature to guide users through setting up Koha, and minor web installer UI improvements https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17855 What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to Master |RESOLVED Resolution|--- |FIXED -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat May 13 14:29:31 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 13 May 2017 12:29:31 +0000 Subject: [Koha-bugs] [Bug 18059] Add further explanation of the steps in the onboarding tool In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18059 Bug 18059 depends on bug 17855, which changed state. Bug 17855 Summary: New onboarding tool feature to guide users through setting up Koha, and minor web installer UI improvements https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17855 What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to Master |RESOLVED Resolution|--- |FIXED -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat May 13 14:30:03 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 13 May 2017 12:30:03 +0000 Subject: [Koha-bugs] [Bug 12461] Add patron clubs feature In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12461 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Resolution|--- |FIXED Status|Pushed to Master |RESOLVED --- Comment #85 from Katrin Fischer --- This won't get ported back to 16.11.x as it is a new feature. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat May 13 14:30:05 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 13 May 2017 12:30:05 +0000 Subject: [Koha-bugs] [Bug 14143] Patron cards: Crash ( confusion between table names creator_templates and club_template_enrollment_fields In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14143 Bug 14143 depends on bug 12461, which changed state. Bug 12461 Summary: Add patron clubs feature https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12461 What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to Master |RESOLVED Resolution|--- |FIXED -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat May 13 14:30:06 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 13 May 2017 12:30:06 +0000 Subject: [Koha-bugs] [Bug 18529] Template cleanup of patron clubs pages In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18529 Bug 18529 depends on bug 12461, which changed state. Bug 12461 Summary: Add patron clubs feature https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12461 What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to Master |RESOLVED Resolution|--- |FIXED -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat May 13 14:30:06 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 13 May 2017 12:30:06 +0000 Subject: [Koha-bugs] [Bug 18530] Remove event attributes from patron clubs templates In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18530 Bug 18530 depends on bug 12461, which changed state. Bug 12461 Summary: Add patron clubs feature https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12461 What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to Master |RESOLVED Resolution|--- |FIXED -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat May 13 14:30:07 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 13 May 2017 12:30:07 +0000 Subject: [Koha-bugs] [Bug 18553] Incorrect "Loading..." tag on moremember.tt when no clubs defined In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18553 Bug 18553 depends on bug 12461, which changed state. Bug 12461 Summary: Add patron clubs feature https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12461 What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to Master |RESOLVED Resolution|--- |FIXED -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat May 13 14:30:07 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 13 May 2017 12:30:07 +0000 Subject: [Koha-bugs] [Bug 18557] Mysqlim CURRENT_DATE in Koha::Clubs::get_enrollable In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18557 Bug 18557 depends on bug 12461, which changed state. Bug 12461 Summary: Add patron clubs feature https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12461 What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to Master |RESOLVED Resolution|--- |FIXED -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat May 13 14:30:07 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 13 May 2017 12:30:07 +0000 Subject: [Koha-bugs] [Bug 18558] Koha::Clubs->get_enrollable explodes if no patron given In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18558 Bug 18558 depends on bug 12461, which changed state. Bug 12461 Summary: Add patron clubs feature https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12461 What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to Master |RESOLVED Resolution|--- |FIXED -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat May 13 14:30:08 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 13 May 2017 12:30:08 +0000 Subject: [Koha-bugs] [Bug 18559] Koha:: Clubs - methods should not get the return type in parameter In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18559 Bug 18559 depends on bug 12461, which changed state. Bug 12461 Summary: Add patron clubs feature https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12461 What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to Master |RESOLVED Resolution|--- |FIXED -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat May 13 14:30:56 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 13 May 2017 12:30:56 +0000 Subject: [Koha-bugs] [Bug 14143] Patron cards: Crash ( confusion between table names creator_templates and club_template_enrollment_fields In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14143 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Resolution|--- |FIXED Status|Pushed to Master |RESOLVED CC| |katrin.fischer at bsz-bw.de --- Comment #11 from Katrin Fischer --- Dependency bug 12461 is not part of 16.11.x. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat May 13 14:31:34 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 13 May 2017 12:31:34 +0000 Subject: [Koha-bugs] [Bug 18110] Adds FR to the syspref AddressFormat In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18110 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Resolution|--- |FIXED Status|Pushed to Master |RESOLVED CC| |katrin.fischer at bsz-bw.de --- Comment #47 from Katrin Fischer --- This won't get ported back to 16.11.x as it is an enhancement. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat May 13 14:32:12 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 13 May 2017 12:32:12 +0000 Subject: [Koha-bugs] [Bug 18401] Add the Koha::Checkout->patron method In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18401 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Resolution|--- |FIXED Status|Pushed to Master |RESOLVED CC| |katrin.fischer at bsz-bw.de --- Comment #6 from Katrin Fischer --- This won't get ported back to 16.11.x as it is an enhancement. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat May 13 14:32:13 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 13 May 2017 12:32:13 +0000 Subject: [Koha-bugs] [Bug 18402] Add the Koha::Item->checkout method In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18402 Bug 18402 depends on bug 18401, which changed state. Bug 18401 Summary: Add the Koha::Checkout->patron method https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18401 What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to Master |RESOLVED Resolution|--- |FIXED -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat May 13 14:32:41 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 13 May 2017 12:32:41 +0000 Subject: [Koha-bugs] [Bug 18402] Add the Koha::Item->checkout method In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18402 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Resolution|--- |FIXED CC| |katrin.fischer at bsz-bw.de Status|Pushed to Master |RESOLVED --- Comment #10 from Katrin Fischer --- This won't get ported back to 16.11.x as it is an enhancement. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat May 13 14:32:41 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 13 May 2017 12:32:41 +0000 Subject: [Koha-bugs] [Bug 18403] Hide patron information if not part of the logged in user library group In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18403 Bug 18403 depends on bug 18402, which changed state. Bug 18402 Summary: Add the Koha::Item->checkout method https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18402 What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to Master |RESOLVED Resolution|--- |FIXED -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat May 13 14:33:29 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 13 May 2017 12:33:29 +0000 Subject: [Koha-bugs] [Bug 18484] opac-advsearch.tt missing closing div tag for .container-fluid In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18484 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |katrin.fischer at bsz-bw.de Status|Pushed to Master |Pushed to Stable --- Comment #5 from Katrin Fischer --- This patch has been pushed to 16.11.x and will be in 16.11.08. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat May 13 14:34:08 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 13 May 2017 12:34:08 +0000 Subject: [Koha-bugs] [Bug 14224] patron notes about item shown at check in In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14224 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Resolution|--- |FIXED Status|Pushed to Master |RESOLVED --- Comment #121 from Katrin Fischer --- This won't get ported back to 16.11.x as it is a new feature -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat May 13 14:34:09 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 13 May 2017 12:34:09 +0000 Subject: [Koha-bugs] [Bug 17698] Make patron notes show up on staff dashboard In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17698 Bug 17698 depends on bug 14224, which changed state. Bug 14224 Summary: patron notes about item shown at check in https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14224 What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to Master |RESOLVED Resolution|--- |FIXED -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat May 13 14:34:37 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 13 May 2017 12:34:37 +0000 Subject: [Koha-bugs] [Bug 16344] Add a circ rule to limit the auto renewals given a specific date In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16344 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |katrin.fischer at bsz-bw.de Status|Pushed to Master |RESOLVED Resolution|--- |FIXED --- Comment #43 from Katrin Fischer --- This won't get ported back to 16.11.x as it is an enhancement. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat May 13 14:34:41 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 13 May 2017 12:34:41 +0000 Subject: [Koha-bugs] [Bug 16413] Prototype for GetLatestAutoRenewDate and GetSoonestRenewDate should be changed In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16413 Bug 16413 depends on bug 16344, which changed state. Bug 16344 Summary: Add a circ rule to limit the auto renewals given a specific date https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16344 What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to Master |RESOLVED Resolution|--- |FIXED -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat May 13 14:34:40 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 13 May 2017 12:34:40 +0000 Subject: [Koha-bugs] [Bug 15582] Ability to block auto renewals if the OPACFineNoRenewals amount is reached In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15582 Bug 15582 depends on bug 16344, which changed state. Bug 16344 Summary: Add a circ rule to limit the auto renewals given a specific date https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16344 What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to Master |RESOLVED Resolution|--- |FIXED -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat May 13 14:37:08 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 13 May 2017 12:37:08 +0000 Subject: [Koha-bugs] [Bug 18502] koha-shell broken on dev installs In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18502 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |katrin.fischer at bsz-bw.de --- Comment #6 from Katrin Fischer --- Missing piece for including bug 16733 - will come back to this later. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat May 13 14:39:05 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 13 May 2017 12:39:05 +0000 Subject: [Koha-bugs] [Bug 18442] Permission error when logging into staff interface as db user In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18442 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to Master |Pushed to Stable --- Comment #26 from Katrin Fischer --- These patches have been pushed to 16.11.x and will be in 16.11.08. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat May 13 14:40:13 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 13 May 2017 12:40:13 +0000 Subject: [Koha-bugs] [Bug 18152] UNIMARC bib records imported with invalid 'a' char in label pos.9 In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18152 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to Master |Pushed to Stable CC| |katrin.fischer at bsz-bw.de --- Comment #26 from Katrin Fischer --- These patches have been pushed to 16.11.x and will be in 16.11.08. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat May 13 14:44:32 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 13 May 2017 12:44:32 +0000 Subject: [Koha-bugs] [Bug 18512] GetAuthorisedValues.GetByCode Template plugin should return code ( not empty string) if value not found In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18512 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |katrin.fischer at bsz-bw.de --- Comment #10 from Katrin Fischer --- Tests don't pass applied on 16.11.x - not pushing this, please check. Test Summary Report ------------------- t/db_dependent/Template/Plugin/AuthorisedValues.t (Wstat: 65280 Tests: 1 Failed: 1) Failed test: 1 Non-zero exit status: 255 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat May 13 14:47:02 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 13 May 2017 12:47:02 +0000 Subject: [Koha-bugs] [Bug 17952] Lost items not skipped by overdue_notices.pl In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17952 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |katrin.fischer at bsz-bw.de --- Comment #10 from Katrin Fischer --- I am not clear on this one - did we calculate fines on lost items before this patch? -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat May 13 14:48:13 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 13 May 2017 12:48:13 +0000 Subject: [Koha-bugs] [Bug 7550] Self checkout: limit display of patron image to logged-in patron In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7550 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |katrin.fischer at bsz-bw.de Status|Pushed to Master |Pushed to Stable --- Comment #30 from Katrin Fischer --- These patches have been pushed to 16.11.x and will be in 16.11.08. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat May 13 14:48:58 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 13 May 2017 12:48:58 +0000 Subject: [Koha-bugs] [Bug 18405] Self checkout: Fix broken silent printing In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18405 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to Master |Pushed to Stable CC| |katrin.fischer at bsz-bw.de --- Comment #5 from Katrin Fischer --- This patch has been pushed to 16.11.x and will be in 16.11.08. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat May 13 14:50:52 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 13 May 2017 12:50:52 +0000 Subject: [Koha-bugs] [Bug 17993] Do not use modal authentication with CAS In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17993 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to Master |Pushed to Stable CC| |katrin.fischer at bsz-bw.de --- Comment #14 from Katrin Fischer --- These patches have been pushed to 16.11.x and will be in 16.11.08. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat May 13 16:45:29 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 13 May 2017 14:45:29 +0000 Subject: [Koha-bugs] [Bug 17952] Lost items not skipped by overdue_notices.pl In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17952 --- Comment #11 from Martin Renvoize --- To clarify, this patch adds two performance enhancements in one patch. a) It prevents re-instantiation of Koha::Calendar objects inside the loop (no functionality change here) b) It enhances the SQL query to skip all lost items during overdue calculation. (this is a change of logic, but I don't think it's a change of functionality) -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat May 13 16:50:07 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 13 May 2017 14:50:07 +0000 Subject: [Koha-bugs] [Bug 17952] Lost items not skipped by overdue_notices.pl In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17952 --- Comment #12 from Martin Renvoize --- Hmm, on second read.. it is a change of functionality in so much as listitems were not skipped before. In all my own test cases we have overdue rules set at times long before itemlost marking rules.. so you would never see the change.. I imagine that is the usual case.. hmm.. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat May 13 23:39:20 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 13 May 2017 21:39:20 +0000 Subject: [Koha-bugs] [Bug 18572] Improper branchcode set during OPAC renewal In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18572 David Kuhn changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |techservspec at gmail.com -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun May 14 00:07:46 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 13 May 2017 22:07:46 +0000 Subject: [Koha-bugs] [Bug 17952] Lost items not skipped by overdue_notices.pl In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17952 --- Comment #13 from Katrin Fischer --- Yeah, I am mostly worried about pushing a behaviour change to the stable release. We don't use the longoverdues script atm, but I know libraries are manually setting the lost status when an item is reported lost. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun May 14 00:39:55 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 13 May 2017 22:39:55 +0000 Subject: [Koha-bugs] [Bug 14866] Make high holds work with different item types and number of open days In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14866 Lisette changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |lisetteslatah at gmail.com -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun May 14 08:02:30 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 14 May 2017 06:02:30 +0000 Subject: [Koha-bugs] [Bug 18434] Elasticsearch indexing broken with newer catmandu version In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18434 Chris Cormack changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |chris at bigballofwax.co.nz --- Comment #8 from Chris Cormack --- Should this be needs signoff, or signed off. Rather than Assigned? -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun May 14 08:39:54 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 14 May 2017 06:39:54 +0000 Subject: [Koha-bugs] [Bug 16402] DB structure cannot be loaded in MySQL 5.7 In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16402 Mason James changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |mtj at kohaaloha.com -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun May 14 08:40:14 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 14 May 2017 06:40:14 +0000 Subject: [Koha-bugs] [Bug 13669] Web installer fails to load sample data on MySQL 5.6+ In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13669 Mason James changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |mtj at kohaaloha.com -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun May 14 08:40:48 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 14 May 2017 06:40:48 +0000 Subject: [Koha-bugs] [Bug 17258] [OMIBUS] MySQL 5.7 In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17258 Mason James changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |mtj at kohaaloha.com -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun May 14 08:46:49 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 14 May 2017 06:46:49 +0000 Subject: [Koha-bugs] [Bug 17328] Koha fixes for Mysql 5.7 In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17328 Mason James changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |mtj at kohaaloha.com -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun May 14 08:47:15 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 14 May 2017 06:47:15 +0000 Subject: [Koha-bugs] [Bug 17306] Update scripts fail with Mysql 5.7 In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17306 Mason James changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |mtj at kohaaloha.com -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun May 14 08:47:30 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 14 May 2017 06:47:30 +0000 Subject: [Koha-bugs] [Bug 16858] import_borrowers.pl does not load because of mysql 5.7 In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16858 Mason James changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |mtj at kohaaloha.com -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun May 14 09:44:11 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 14 May 2017 07:44:11 +0000 Subject: [Koha-bugs] [Bug 18002] Make onboarding tool include framework to be embedded in Acquisitions to help the users set up Acquisitions for the first time In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18002 Alex Buckley changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #63380|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun May 14 09:44:44 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 14 May 2017 07:44:44 +0000 Subject: [Koha-bugs] [Bug 18002] Make onboarding tool include framework to be embedded in Acquisitions to help the users set up Acquisitions for the first time In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18002 --- Comment #37 from Alex Buckley --- Created attachment 63456 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=63456&action=edit Bug 18002 - Created a budget creation onboarding form to be displayed when the user first visits the acquisition area -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun May 14 09:49:23 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 14 May 2017 07:49:23 +0000 Subject: [Koha-bugs] [Bug 18002] Make onboarding tool include framework to be embedded in Acquisitions to help the users set up Acquisitions for the first time In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18002 --- Comment #38 from Alex Buckley --- I have fixed up the spelling mistake that was causing a qa error in acqui-home.tt and I have implemented [% USE Price %] at the top of the onboardinginclude3.inc file (thanks to Marc Veron for the suggestion), so both errors should now be fixed. The two qa errors were not being thrown on my machine before making these changes and so I cannot guarantee that this patch has fixed the two errors. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun May 14 10:34:47 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 14 May 2017 08:34:47 +0000 Subject: [Koha-bugs] [Bug 18002] Make onboarding tool include framework to be embedded in Acquisitions to help the users set up Acquisitions for the first time In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18002 --- Comment #39 from Katrin Fischer --- Just tested, looks all green for me now: kohadev-koha at kohadevbox:/home/vagrant/kohaclone$ qa -c 1 -v 2 testing 1 commit(s) (applied to 830786a 'Bug 17461: Warn about plugins that ca') Processing files before patches |========================>| 12 / 12 (100.00%) Processing files after patches |========================>| 12 / 12 (100.00%) OK C4/Budgets.pm OK critic OK forbidden patterns OK git manipulation OK pod OK spelling OK valid OK acqui/acqui-home.pl OK critic OK forbidden patterns OK git manipulation OK pod OK spelling OK valid OK admin/aqbudgetperiods.pl OK critic OK forbidden patterns OK git manipulation OK pod OK spelling OK valid OK admin/aqbudgets.pl OK critic OK forbidden patterns OK git manipulation OK pod OK spelling OK valid OK admin/currency.pl OK critic OK forbidden patterns OK git manipulation OK pod OK spelling OK valid OK koha-tmpl/intranet-tmpl/prog/en/includes/budgets-active-currency.inc OK forbidden patterns OK git manipulation OK spelling OK tt_valid OK valid_template OK koha-tmpl/intranet-tmpl/prog/en/includes/onboardinginclude1.inc OK forbidden patterns OK git manipulation OK spelling OK tt_valid OK valid_template OK koha-tmpl/intranet-tmpl/prog/en/includes/onboardinginclude2.inc OK forbidden patterns OK git manipulation OK spelling OK tt_valid OK valid_template OK koha-tmpl/intranet-tmpl/prog/en/includes/onboardinginclude3.inc OK forbidden patterns OK git manipulation OK spelling OK tt_valid OK valid_template OK koha-tmpl/intranet-tmpl/prog/en/modules/acqui/acqui-home.tt OK forbidden patterns OK git manipulation OK spelling OK tt_valid OK valid_template OK koha-tmpl/intranet-tmpl/prog/en/modules/admin/aqbudgetperiods.tt OK forbidden patterns OK git manipulation OK spelling OK tt_valid OK valid_template OK koha-tmpl/intranet-tmpl/prog/en/modules/admin/aqbudgets.tt OK forbidden patterns OK git manipulation OK spelling OK tt_valid OK valid_template -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun May 14 11:17:22 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 14 May 2017 09:17:22 +0000 Subject: [Koha-bugs] [Bug 18415] Advanced Editor - Rancor - return focus to editor after successful macro In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18415 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |katrin.fischer at bsz-bw.de Status|Pushed to Master |Pushed to Stable --- Comment #5 from Katrin Fischer --- This patch has been pushed to 16.11.x and will be in 16.11.08. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun May 14 11:19:39 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 14 May 2017 09:19:39 +0000 Subject: [Koha-bugs] [Bug 17190] Mark REST API dependencies as mandatory in PerlDependencies.pm In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17190 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to Master |Pushed to Stable --- Comment #7 from Katrin Fischer --- This patch has been pushed to 16.11.x and will be in 16.11.08. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun May 14 11:20:14 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 14 May 2017 09:20:14 +0000 Subject: [Koha-bugs] [Bug 17190] Mark REST API dependencies as mandatory in PerlDependencies.pm In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17190 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Severity|enhancement |normal -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun May 14 11:23:09 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 14 May 2017 09:23:09 +0000 Subject: [Koha-bugs] [Bug 17812] Return focus to barcode field after toggling on-site checkouts In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17812 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to Master |Pushed to Stable CC| |katrin.fischer at bsz-bw.de --- Comment #10 from Katrin Fischer --- This patch has been pushed to 16.11.x and will be in 16.11.08. Marked as enhancement, but I think it might be annoying enough to qualify as a but for some. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun May 14 11:23:37 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 14 May 2017 09:23:37 +0000 Subject: [Koha-bugs] [Bug 18098] Add an index with the count of not onloan items In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18098 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |katrin.fischer at bsz-bw.de Resolution|--- |FIXED Status|Pushed to Master |RESOLVED --- Comment #9 from Katrin Fischer --- This won't get ported back to 16.11.x as it is an enhancement. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun May 14 11:24:22 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 14 May 2017 09:24:22 +0000 Subject: [Koha-bugs] [Bug 18233] t/db_dependent/00-strict.t has non-existant resetversion.pl In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18233 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |katrin.fischer at bsz-bw.de Status|Pushed to Master |Pushed to Stable --- Comment #5 from Katrin Fischer --- This patch has been pushed to 16.11.x and will be in 16.11.08. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun May 14 11:24:50 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 14 May 2017 09:24:50 +0000 Subject: [Koha-bugs] [Bug 18299] Removal of admin/env_tz_test.pl script In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18299 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Resolution|--- |FIXED CC| |katrin.fischer at bsz-bw.de Status|Pushed to Master |RESOLVED --- Comment #16 from Katrin Fischer --- This won't get ported back to 16.11.x as it is an enhancement. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun May 14 11:26:23 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 14 May 2017 09:26:23 +0000 Subject: [Koha-bugs] [Bug 15108] OAI-PMH provider improvements In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15108 --- Comment #95 from Katrin Fischer --- I think part of this would well qualify as bug fixes, but overall it's a big patch and I am not confident pushing it to the stable version. What do people think? -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun May 14 11:27:44 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 14 May 2017 09:27:44 +0000 Subject: [Koha-bugs] [Bug 18494] Fix Letters.t (follow-up of 15702) In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18494 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |katrin.fischer at bsz-bw.de Status|Pushed to Master |Pushed to Stable --- Comment #17 from Katrin Fischer --- This patch has been pushed to 16.11.x and will be in 16.11.08. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun May 14 11:28:19 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 14 May 2017 09:28:19 +0000 Subject: [Koha-bugs] [Bug 18505] OPAC Search History page does not respect OpacPublic syspref In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18505 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to Master |Pushed to Stable --- Comment #11 from Katrin Fischer --- This patch has been pushed to 16.11.x and will be in 16.11.08. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun May 14 11:28:55 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 14 May 2017 09:28:55 +0000 Subject: [Koha-bugs] [Bug 18559] Koha:: Clubs - methods should not get the return type in parameter In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18559 Bug 18559 depends on bug 18553, which changed state. Bug 18553 Summary: Incorrect "Loading..." tag on moremember.tt when no clubs defined https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18553 What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to Master |RESOLVED Resolution|--- |FIXED -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun May 14 11:28:55 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 14 May 2017 09:28:55 +0000 Subject: [Koha-bugs] [Bug 18553] Incorrect "Loading..." tag on moremember.tt when no clubs defined In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18553 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to Master |RESOLVED CC| |katrin.fischer at bsz-bw.de Resolution|--- |FIXED --- Comment #8 from Katrin Fischer --- Depends on patrons clug feature, which is not in 16.11.x. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun May 14 11:31:27 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 14 May 2017 09:31:27 +0000 Subject: [Koha-bugs] [Bug 12063] Change date calculation for reserve expiration to skip all holidays In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12063 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Resolution|--- |FIXED Status|Pushed to Master |RESOLVED --- Comment #88 from Katrin Fischer --- This won't get ported back to 16.11.x as it is an enhancement. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun May 14 11:32:12 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 14 May 2017 09:32:12 +0000 Subject: [Koha-bugs] [Bug 12063] Change date calculation for reserve expiration to skip all holidays In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12063 --- Comment #89 from Katrin Fischer --- I think it would be good to have the "Text to go in the release notes" filled for this one, describing the change to the libraries updating. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun May 14 11:40:10 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 14 May 2017 09:40:10 +0000 Subject: [Koha-bugs] [Bug 12063] Change date calculation for reserve expiration to skip all holidays In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12063 --- Comment #90 from Katrin Fischer --- Also, what changes for libraries not using the cronjob to automatically expire holds? We don't use this because libraries often want to leave the book on a few days longer during holidays etc. and because the slip for the next patron is not printed automatically and there is no clue for the library that they have to print a new one. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun May 14 11:41:17 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 14 May 2017 09:41:17 +0000 Subject: [Koha-bugs] [Bug 18574] Clean Patron Records tool doesn' t limit to the selected library In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18574 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to Master |Pushed to Stable --- Comment #9 from Katrin Fischer --- This patch has been pushed to 16.11.x and will be in 16.11.08. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun May 14 11:42:37 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 14 May 2017 09:42:37 +0000 Subject: [Koha-bugs] [Bug 18346] Improved web installer containing basic and advanced setup modes In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18346 --- Comment #14 from Alex Buckley --- Created attachment 63457 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=63457&action=edit Bug 18346 - Merging the pushed onboarding tool with web imstaller improvements. Currently not all files in default and optional directories are being displayed -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun May 14 11:42:53 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 14 May 2017 09:42:53 +0000 Subject: [Koha-bugs] [Bug 18346] Improved web installer containing basic and advanced setup modes In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18346 Alex Buckley changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |ASSIGNED --- Comment #15 from Alex Buckley --- I am currently working on this bug so please do not try testing the patches yet. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun May 14 11:45:45 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 14 May 2017 09:45:45 +0000 Subject: [Koha-bugs] [Bug 18579] Problem with :Filter::MARC::EmbedItemsAvailability In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18579 --- Comment #17 from Katrin Fischer --- Patches don't apply to 16.11.x - please provide patches for 16.11.x if it's needed there too! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun May 14 11:46:29 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 14 May 2017 09:46:29 +0000 Subject: [Koha-bugs] [Bug 18560] RSS Feed link from OPAC shelves is broken In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18560 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to Master |Pushed to Stable --- Comment #13 from Katrin Fischer --- This patch has been pushed to 16.11.x and will be in 16.11.08. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun May 14 11:47:29 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 14 May 2017 09:47:29 +0000 Subject: [Koha-bugs] [Bug 18573] Error when adding a suggestion in the OPAC In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18573 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |katrin.fischer at bsz-bw.de Status|Pushed to Master |RESOLVED Resolution|--- |FIXED --- Comment #8 from Katrin Fischer --- Dependency is not part of 16.11.x, so this should not be needed there. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun May 14 11:49:11 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 14 May 2017 09:49:11 +0000 Subject: [Koha-bugs] [Bug 16758] Caching issues in scripts running in daemon mode In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16758 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |katrin.fischer at bsz-bw.de Status|Pushed to Master |Pushed to Stable --- Comment #18 from Katrin Fischer --- These patches have been pushed to 16.11.x and will be in 16.11.08. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun May 14 11:49:40 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 14 May 2017 09:49:40 +0000 Subject: [Koha-bugs] [Bug 18525] Can't create order line from accepted suggestion In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18525 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on| |14828 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14828 [Bug 14828] Move the item types related code to Koha::ItemTypes -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun May 14 11:49:40 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 14 May 2017 09:49:40 +0000 Subject: [Koha-bugs] [Bug 14828] Move the item types related code to Koha::ItemTypes In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14828 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |18525 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18525 [Bug 18525] Can't create order line from accepted suggestion -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun May 14 11:51:00 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 14 May 2017 09:51:00 +0000 Subject: [Koha-bugs] [Bug 18525] Can't create order line from accepted suggestion In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18525 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to Master |Pushed to Stable --- Comment #6 from Katrin Fischer --- This patch has been pushed to 16.11.x and will be in 16.11.08. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun May 14 11:52:21 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 14 May 2017 09:52:21 +0000 Subject: [Koha-bugs] [Bug 4460] Amazon' s AssociateID tag not used in links so referred revenue lost In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=4460 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to Master |Pushed to Stable --- Comment #39 from Katrin Fischer --- This patch has been pushed to 16.11.x and will be in 16.11.08. Always glad to see this 4 digit bug numbers resolved. -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun May 14 11:53:05 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 14 May 2017 09:53:05 +0000 Subject: [Koha-bugs] [Bug 18535] Clicking 'edit printer profile' in label creator causes software error In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18535 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |katrin.fischer at bsz-bw.de Status|Pushed to Master |Pushed to Stable --- Comment #5 from Katrin Fischer --- This patch has been pushed to 16.11.x and will be in 16.11.08. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun May 14 11:54:50 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 14 May 2017 09:54:50 +0000 Subject: [Koha-bugs] [Bug 18557] Mysqlim CURRENT_DATE in Koha::Clubs::get_enrollable In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18557 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to Master |RESOLVED Resolution|--- |FIXED CC| |katrin.fischer at bsz-bw.de --- Comment #9 from Katrin Fischer --- Depends on bug 12461 which is not part of 16.11.x. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun May 14 11:55:27 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 14 May 2017 09:55:27 +0000 Subject: [Koha-bugs] [Bug 18340] Progress bar length is wrong In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18340 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to Master |Pushed to Stable CC| |katrin.fischer at bsz-bw.de --- Comment #5 from Katrin Fischer --- This patch has been pushed to 16.11.x and will be in 16.11.08. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun May 14 11:56:31 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 14 May 2017 09:56:31 +0000 Subject: [Koha-bugs] [Bug 18370] Columns settings patrons>id=memberresultst : display bug In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18370 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |katrin.fischer at bsz-bw.de Status|Pushed to Master |Pushed to Stable --- Comment #15 from Katrin Fischer --- These patches have been pushed to 16.11.x and will be in 16.11.08. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun May 14 12:00:01 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 14 May 2017 10:00:01 +0000 Subject: [Koha-bugs] [Bug 18400] Noisy warns in opac-search.pl during itemtype sorting In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18400 --- Comment #11 from Katrin Fischer --- Patches don't apply cleanly on 16.11.x - please rebase if you think it should be in the next stable release! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun May 14 12:01:05 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 14 May 2017 10:01:05 +0000 Subject: [Koha-bugs] [Bug 18444] Add TalkingTechItivaPhoneNotification to sysprefs.sql In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18444 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to Master |Pushed to Stable --- Comment #7 from Katrin Fischer --- This patch has been pushed to 16.11.x and will be in 16.11.08. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun May 14 12:02:00 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 14 May 2017 10:02:00 +0000 Subject: [Koha-bugs] [Bug 17257] Cannot create a patron under MySQL 5.7 In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17257 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to Master |Pushed to Stable CC| |katrin.fischer at bsz-bw.de --- Comment #12 from Katrin Fischer --- This patch has been pushed to 16.11.x and will be in 16.11.08. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun May 14 12:02:33 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 14 May 2017 10:02:33 +0000 Subject: [Koha-bugs] [Bug 18529] Template cleanup of patron clubs pages In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18529 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Resolution|--- |FIXED CC| |katrin.fischer at bsz-bw.de Status|Pushed to Master |RESOLVED --- Comment #7 from Katrin Fischer --- Depends on bug 12461 which is not part of 16.11.x. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun May 14 12:03:13 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 14 May 2017 10:03:13 +0000 Subject: [Koha-bugs] [Bug 18383] items.onloan schema comment seems to be incorrect. In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18383 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to Master |Pushed to Stable --- Comment #6 from Katrin Fischer --- This patch has been pushed to 16.11.x and will be in 16.11.08. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun May 14 12:03:45 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 14 May 2017 10:03:45 +0000 Subject: [Koha-bugs] [Bug 16515] Did you mean? links don't wrap on smaller screens In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16515 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to Master |Pushed to Stable --- Comment #12 from Katrin Fischer --- This patch has been pushed to 16.11.x and will be in 16.11.08. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun May 14 12:04:17 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 14 May 2017 10:04:17 +0000 Subject: [Koha-bugs] [Bug 16515] Did you mean? links don't wrap on smaller screens In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16515 --- Comment #13 from Katrin Fischer --- ...patches even -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun May 14 12:05:00 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 14 May 2017 10:05:00 +0000 Subject: [Koha-bugs] [Bug 18504] Amount owed on fines tab should be formatted as price if < 10 or credit In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18504 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to Master |Pushed to Stable CC| |katrin.fischer at bsz-bw.de --- Comment #5 from Katrin Fischer --- This patch has been pushed to 16.11.x and will be in 16.11.08. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun May 14 12:15:45 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 14 May 2017 10:15:45 +0000 Subject: [Koha-bugs] [Bug 18208] Add RecordProcessor filter to inject not onloan count to MARC records In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18208 Tom?s Cohen Arazi changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |18579 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18579 [Bug 18579] Problem with :Filter::MARC::EmbedItemsAvailability -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun May 14 12:15:45 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 14 May 2017 10:15:45 +0000 Subject: [Koha-bugs] [Bug 18579] Problem with :Filter::MARC::EmbedItemsAvailability In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18579 Tom?s Cohen Arazi changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on| |18208 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18208 [Bug 18208] Add RecordProcessor filter to inject not onloan count to MARC records -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun May 14 12:17:03 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 14 May 2017 10:17:03 +0000 Subject: [Koha-bugs] [Bug 17925] Disable debugging in reports/bor_issues_top.pl In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17925 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |katrin.fischer at bsz-bw.de Status|Pushed to Master |Pushed to Stable --- Comment #9 from Katrin Fischer --- This patch has been pushed to 16.11.x and will be in 16.11.08. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun May 14 12:18:16 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 14 May 2017 10:18:16 +0000 Subject: [Koha-bugs] [Bug 17936] Search bar not aligned on right in small screen sizes In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17936 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |katrin.fischer at bsz-bw.de Status|Pushed to Master |Pushed to Stable --- Comment #8 from Katrin Fischer --- These patches have been pushed to 16.11.x and will be in 16.11.08. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun May 14 12:18:55 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 14 May 2017 10:18:55 +0000 Subject: [Koha-bugs] [Bug 17942] Update style of the web installer with Bootstrap 3 In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17942 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to Master |RESOLVED Resolution|--- |FIXED --- Comment #51 from Katrin Fischer --- Depends on bug 18462 which is not in 16.11.x (new feature for 17.05) -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun May 14 12:19:18 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 14 May 2017 10:19:18 +0000 Subject: [Koha-bugs] [Bug 18035] Front-end changes to serials -> Numbering patterns In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18035 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to Master |RESOLVED CC| |katrin.fischer at bsz-bw.de Resolution|--- |FIXED --- Comment #11 from Katrin Fischer --- This won't get ported back to 16.11.x as it is an enhancement. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun May 14 12:19:57 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 14 May 2017 10:19:57 +0000 Subject: [Koha-bugs] [Bug 17762] Ability to translate notices In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17762 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Resolution|--- |FIXED Status|Pushed to Master |RESOLVED CC| |katrin.fischer at bsz-bw.de --- Comment #59 from Katrin Fischer --- Very much looking forward to this! This won't get ported back to 16.11.x as it is an enhancement. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun May 14 12:25:17 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 14 May 2017 10:25:17 +0000 Subject: [Koha-bugs] [Bug 18554] Adjust a few typos including responsability In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18554 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |katrin.fischer at bsz-bw.de --- Comment #7 from Katrin Fischer --- Doesn't apply cleanly to 16.11.x - please rebase if you want it to be included there. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun May 14 12:26:42 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 14 May 2017 10:26:42 +0000 Subject: [Koha-bugs] [Bug 15179] Marc field 084 does not show on bibliographic record In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15179 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Resolution|--- |FIXED Status|Pushed to Master |RESOLVED --- Comment #10 from Katrin Fischer --- This won't get ported back to 16.11.x as it is an enhancement. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun May 14 12:27:25 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 14 May 2017 10:27:25 +0000 Subject: [Koha-bugs] [Bug 15705] Notify the user on auto renewing In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15705 Bug 15705 depends on bug 15582, which changed state. Bug 15582 Summary: Ability to block auto renewals if the OPACFineNoRenewals amount is reached https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15582 What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to Master |RESOLVED Resolution|--- |FIXED -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun May 14 12:27:24 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 14 May 2017 10:27:24 +0000 Subject: [Koha-bugs] [Bug 15582] Ability to block auto renewals if the OPACFineNoRenewals amount is reached In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15582 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to Master |RESOLVED Resolution|--- |FIXED --- Comment #45 from Katrin Fischer --- This won't get ported back to 16.11.x as it is an enhancement. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun May 14 12:28:01 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 14 May 2017 10:28:01 +0000 Subject: [Koha-bugs] [Bug 18532] AUTO_RENEWALS should be a patron messaging preference In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18532 Bug 18532 depends on bug 15705, which changed state. Bug 15705 Summary: Notify the user on auto renewing https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15705 What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to Master |RESOLVED Resolution|--- |FIXED -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun May 14 12:28:00 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 14 May 2017 10:28:00 +0000 Subject: [Koha-bugs] [Bug 15705] Notify the user on auto renewing In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15705 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to Master |RESOLVED Resolution|--- |FIXED --- Comment #72 from Katrin Fischer --- This won't get ported back to 16.11.x as it is an enhancement. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun May 14 12:28:42 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 14 May 2017 10:28:42 +0000 Subject: [Koha-bugs] [Bug 17465] Add a System Preference to control number of Saved Reports displayed In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17465 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to Master |RESOLVED CC| |katrin.fischer at bsz-bw.de Resolution|--- |FIXED --- Comment #5 from Katrin Fischer --- This won't get ported back to 16.11.x as it is an enhancement. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun May 14 12:29:26 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 14 May 2017 10:29:26 +0000 Subject: [Koha-bugs] [Bug 18314] Account lockout In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18314 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Resolution|--- |FIXED Status|Pushed to Master |RESOLVED CC| |katrin.fischer at bsz-bw.de --- Comment #36 from Katrin Fischer --- Like! This won't get ported back to 16.11.x as it is an enhancement. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun May 14 12:30:09 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 14 May 2017 10:30:09 +0000 Subject: [Koha-bugs] [Bug 18350] Moving call number in subscriptions tab in OPAC biblio detail In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18350 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Resolution|--- |FIXED Status|Pushed to Master |RESOLVED CC| |katrin.fischer at bsz-bw.de --- Comment #6 from Katrin Fischer --- This won't get ported back to 16.11.x as it is an enhancement. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun May 14 12:31:13 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 14 May 2017 10:31:13 +0000 Subject: [Koha-bugs] [Bug 17618] perl-modules Debian package name change In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17618 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to Master |Pushed to Stable CC| |katrin.fischer at bsz-bw.de --- Comment #10 from Katrin Fischer --- This patch has been pushed to 16.11.x and will be in 16.11.08. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun May 14 12:33:05 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 14 May 2017 10:33:05 +0000 Subject: [Koha-bugs] [Bug 17942] Update style of the web installer with Bootstrap 3 In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17942 --- Comment #52 from Katrin Fischer --- Actually depends on bug 17855! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun May 14 12:53:08 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 14 May 2017 10:53:08 +0000 Subject: [Koha-bugs] [Bug 16733] More flexible paths in debian scripts (for dev installs) In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16733 --- Comment #43 from Katrin Fischer --- I have made an attempt to backport this, but I am running into conflicts. - Patches from this (bug 16733) apply cleanly - Patches from next dependency bug 16749 conflict: could not apply 35fad66... Bug 16749: Adjustments for koha-plack Jonathan, if you still want this in, please help me figure this out! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun May 14 12:59:40 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 14 May 2017 10:59:40 +0000 Subject: [Koha-bugs] [Bug 18367] Fix untranslatable string from Bug 18264 In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18367 --- Comment #3 from Katrin Fischer --- Yep, it would be better. Grammar works differently in different languages, so always better not to assume every language can 'glue' sentences together like in English. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun May 14 13:55:03 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 14 May 2017 11:55:03 +0000 Subject: [Koha-bugs] [Bug 18264] Course reserves - use itemnumber for editing existing reserve items In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18264 --- Comment #17 from Katrin Fischer --- Tried to backport these patches, but with the patches applied, I have an error under Plack when adding an item to a course by barcode: The method biblio is not covered by tests! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun May 14 14:00:10 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 14 May 2017 12:00:10 +0000 Subject: [Koha-bugs] [Bug 18307] Branchname is no longer displayed in subscription tab view In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18307 --- Comment #11 from Katrin Fischer --- (In reply to Mason James from comment #10) > (In reply to Mason James from comment #9) > > (In reply to Katrin Fischer from comment #8) > > > This patch has been pushed to 16.11.x and will be in 16.11.07. > > > > Blocked by Enhancement, skipping for 16.05.x > > hi Katrin, 16.11.x may need patch BZ-17946 now Hi Mason, I checked, there is a dependency noted, but the patch works without bug 17946 which is marked enhancement. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun May 14 14:00:49 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 14 May 2017 12:00:49 +0000 Subject: [Koha-bugs] [Bug 18411] t/db_dependent/www/search_utf8.t fails on 16.11.x In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18411 --- Comment #7 from Katrin Fischer --- Anything we can do here? Jenkins is still not happy. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun May 14 14:02:21 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 14 May 2017 12:02:21 +0000 Subject: [Koha-bugs] [Bug 18468] When adding from a staged file order discounts are not passed into C4:: Acquisitions::populate_order_with_prices In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18468 --- Comment #8 from Katrin Fischer --- Just noticed the earlier comments - checking. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun May 14 14:04:42 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 14 May 2017 12:04:42 +0000 Subject: [Koha-bugs] [Bug 18468] When adding from a staged file order discounts are not passed into C4:: Acquisitions::populate_order_with_prices In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18468 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Resolution|FIXED |--- Status|RESOLVED |REOPENED --- Comment #9 from Katrin Fischer --- The patch from master doesn't apply cleanly on 16.11.x and I am not sure how to resolve the conflict. Can someone take a look and provide a patch for 16.11.x? -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun May 14 14:13:51 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 14 May 2017 12:13:51 +0000 Subject: [Koha-bugs] [Bug 18444] Add TalkingTechItivaPhoneNotification to sysprefs.sql In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18444 --- Comment #8 from Katrin Fischer --- This causes tests to fail on Jenkins: https://jenkins.koha-community.org/job/Koha_16.11.x_D8/lastBuild/testReport/junit/(root)/t_db_dependent_check_sysprefs_t/Syspref_TalkingTechItivaPhoneNotification_exists_in_the_database__356_/ I think we should have a database update too, checking for its existence and inserting it in the database if it's not there already. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun May 14 14:23:29 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 14 May 2017 12:23:29 +0000 Subject: [Koha-bugs] [Bug 18600] New: Missing db update for TalkingTechItivaPhoneNotification Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18600 Bug ID: 18600 Summary: Missing db update for TalkingTechItivaPhoneNotification Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: normal Priority: P5 - low Component: System Administration Assignee: koha-bugs at lists.koha-community.org Reporter: katrin.fischer at bsz-bw.de QA Contact: testopia at bugs.koha-community.org CC: gmcharlt at gmail.com Adding TalkingTechItivaPhoneNotification to sysprefs.sql is causing a test to fail on Jenkins: https://jenkins.koha-community.org/job/Koha_16.11.x_D8/lastBuild/testReport/junit/(root)/t_db_dependent_check_sysprefs_t/Syspref_TalkingTechItivaPhoneNotification_exists_in_the_database__356_/ I think we are missing a database update statement, checking for the existence of the system preference in the database and adding it, when it's not already there yet. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun May 14 14:23:36 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 14 May 2017 12:23:36 +0000 Subject: [Koha-bugs] [Bug 18444] Add TalkingTechItivaPhoneNotification to sysprefs.sql In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18444 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |18600 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18600 [Bug 18600] Missing db update for TalkingTechItivaPhoneNotification -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun May 14 14:23:36 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 14 May 2017 12:23:36 +0000 Subject: [Koha-bugs] [Bug 18600] Missing db update for TalkingTechItivaPhoneNotification In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18600 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on| |18444 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18444 [Bug 18444] Add TalkingTechItivaPhoneNotification to sysprefs.sql -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Sun May 14 14:46:06 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 14 May 2017 12:46:06 +0000 Subject: [Koha-bugs] [Bug 18434] Elasticsearch indexing broken with newer catmandu version In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18434 --- Comment #9 from Tom?s Cohen Arazi --- (In reply to Chris Cormack from comment #8) > Should this be needs signoff, or signed off. Rather than Assigned? It should be pqa imho, but nick was going to double check the tests. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun May 14 23:50:39 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 14 May 2017 21:50:39 +0000 Subject: [Koha-bugs] [Bug 11882] Add a new button to the checkout confirmation dialog when checking out an on hold item In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11882 --- Comment #35 from Katrin Fischer --- Please fix the bug - this feature is not usable at the moment. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun May 14 23:53:56 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 14 May 2017 21:53:56 +0000 Subject: [Koha-bugs] [Bug 18455] Holiday range has incorrect starting date when crossing a weekly holiday In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18455 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Severity|normal |major CC| |katrin.fischer at bsz-bw.de --- Comment #1 from Katrin Fischer --- We have run into this repeatedly in a current project, but it was hard to come up with a test plan that would make this reproducable. Thx, Mark! I am upping severity a bit, as this has actually led to circulation dying in one of the libraries that ran into this. Repeatable holidays holidays for every day of the year. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Mon May 15 04:46:48 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 15 May 2017 02:46:48 +0000 Subject: [Koha-bugs] [Bug 18579] Problem with :Filter::MARC::EmbedItemsAvailability In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18579 --- Comment #18 from Tom?s Cohen Arazi --- (In reply to Katrin Fischer from comment #17) > Patches don't apply to 16.11.x - please provide patches for 16.11.x if it's > needed there too! Not needed! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon May 15 05:26:33 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 15 May 2017 03:26:33 +0000 Subject: [Koha-bugs] [Bug 18419] Broken patron-blank image in viewlog.tt In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18419 --- Comment #8 from Eric Phetteplace --- Such a quick fix! Thanks everyone! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon May 15 05:51:54 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 15 May 2017 03:51:54 +0000 Subject: [Koha-bugs] [Bug 18438] Check in: Modal about holds hides important check in messages In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18438 Marc V?ron changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #63372|0 |1 is obsolete| | --- Comment #27 from Marc V?ron --- Created attachment 63458 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=63458&action=edit Bug 18438 - Implemented data-dismiss="modal" in returns.tt so that any warning messages hidden by a hold modal are displayed after it is dismissed Test plan: 1. Check out an item to one patron whilst having that item also being on hold to another patron 2. Check the item back in 3. Notice a modal box appears greying out the background with three buttons 'Confirm hold', 'Print and confirm' and 'Ignore'. Click confirm and notice that the page refreshes and no yellow warning messages are able to be displayed 4. Now that you have checked the item in. Try checking it in a second time by clicking on the Checkin tab and writing in the barcode. 5. The modal box will appear again, this time with three buttons 'Confirm', 'Print and confirm' and 'Cancel hold' 6. Click the 'Confirm' button and the page refreshes again and the yellow warning message hidden by the modal box is not properly displayed to the user. Notice that the focus is on the barcode input box. 7. Apply patch 8. Try checking in the item again, and this time after clicking the 'confirm' button on the modal box notice that the yellow warning message is displayed telling the user the item was "Not checked out". Also notice the focus is in the barcode inputbox. 9. Drop the hold on the item and make sure it is not checked out. 10. Repeat steps 1 and 2 and notice after clicking the 'Confirm hold' button the page refreshes and the item is successfully checked back in. With the focus on the barcode input. 11. View koha-tmpl/intranet-tmpl/prog/en/modules/circ/returns.tt and notice that the button on line 345 does not use an onclick parameter Followed test plan, works as expected. Signed-off-by: Marc V?ron -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon May 15 05:52:37 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 15 May 2017 03:52:37 +0000 Subject: [Koha-bugs] [Bug 18438] Check in: Modal about holds hides important check in messages In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18438 Marc V?ron changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon May 15 06:19:50 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 15 May 2017 04:19:50 +0000 Subject: [Koha-bugs] [Bug 12691] Use Koha.Preference for calls to SCOUserJS, SCOUserCSS, OPACUserCSS, opacuserjs, etc in Self-Checkout In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12691 --- Comment #7 from M. Tompsett --- Comment on attachment 62993 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=62993 [SIGNED OFF] Bug 12691: Use Koha.Preference in Self-Checkout Review of attachment 62993: --> (https://bugs.koha-community.org/bugzilla3/page.cgi?id=splinter.html&bug=12691&attachment=62993) ----------------------------------------------------------------- ::: koha-tmpl/opac-tmpl/bootstrap/en/modules/sco/sco-main.tt @@ +202,4 @@ > > > > + [% IF ( Koha.Preference('ShowPatronImageInWebBasedSelfCheck') && image_exists ) %] This image_exists and display_patron_image logic doesn't quite match up, and is where the application logic fails. The old logic would still generate the span2 if the image doesn't exist. This logic will not. ::: opac/sco/sco-main.pl @@ +292,4 @@ > ); > if (C4::Context->preference('ShowPatronImageInWebBasedSelfCheck')) { > my $patron_image = Koha::Patron::Images->find($borrower->{borrowernumber}); > + $template->param( image_exists => 1 ) if $patron_image; While the master code has changed, I see no reason for this change, except perhaps to optimize URL calls. But if that were the case, then an ELSE in the template file would be better, so as to generate an empty span2. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon May 15 07:38:05 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 15 May 2017 05:38:05 +0000 Subject: [Koha-bugs] [Bug 18579] Problem with :Filter::MARC::EmbedItemsAvailability In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18579 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to Master |RESOLVED Resolution|--- |FIXED -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon May 15 08:44:55 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 15 May 2017 06:44:55 +0000 Subject: [Koha-bugs] [Bug 17240] Allow processes that rely on background jobs run in Plack mode In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17240 Fridolin SOMERS changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #63291|0 |1 is obsolete| | --- Comment #15 from Fridolin SOMERS --- Created attachment 63459 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=63459&action=edit Bug 17240 - Allow processes that rely on background jobs run in Plack mode - followup 3 Followup 3 If not running in background mode, items are not displayed in result page in tools/batchMod.pl. Also the number of items and fields are missing in message. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon May 15 09:11:34 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 15 May 2017 07:11:34 +0000 Subject: [Koha-bugs] [Bug 18601] New: Working title Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18601 Bug ID: 18601 Summary: Working title Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Test Suite Assignee: chris at bigballofwax.co.nz Reporter: m.de.rooy at rijksmuseum.nl QA Contact: gmcharlt at gmail.com -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon May 15 09:11:44 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 15 May 2017 07:11:44 +0000 Subject: [Koha-bugs] [Bug 18601] Working title In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18601 Marcel de Rooy changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|chris at bigballofwax.co.nz |m.de.rooy at rijksmuseum.nl Severity|enhancement |normal -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon May 15 09:35:31 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 15 May 2017 07:35:31 +0000 Subject: [Koha-bugs] [Bug 15108] OAI-PMH provider improvements In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15108 --- Comment #96 from Marcel de Rooy --- One of the OAI unit tests seems to have an issue with transactions. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon May 15 09:53:38 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 15 May 2017 07:53:38 +0000 Subject: [Koha-bugs] [Bug 18603] New: team PhoNE number, QuickBooks help number-QuickBooks Number; QuickBooks help PhoNE number, QuickBooks Number, QuickBooks Tech SuPpoRT Toll freeNumber, QuickBooks SuPpoRT TELEPhoNE Number, QuickBooks Tech SuPpoRT TELEPhoNE number, QuickBooks Tech SuPpoRT n Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18603 Bug ID: 18603 Summary: team PhoNE number, QuickBooks help number-QuickBooks Number; QuickBooks help PhoNE number, QuickBooks Number, QuickBooks Tech SuPpoRT Toll freeNumber, QuickBooks SuPpoRT TELEPhoNE Number, QuickBooks Tech SuPpoRT TELEPhoNE number, QuickBooks Tech SuPpoRT n Change sponsored?: --- Product: Koha Version: 16.11 Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Authentication Assignee: gmcharlt at gmail.com Reporter: dk923483 at gmail.com QA Contact: testopia at bugs.koha-community.org CC: dpavlin at rot13.org team PhoNE number, QuickBooks help number-QuickBooks Number; QuickBooks help PhoNE number, QuickBooks Number, QuickBooks Tech SuPpoRT Toll freeNumber, QuickBooks SuPpoRT TELEPhoNE Number, QuickBooks Tech SuPpoRT TELEPhoNE number, QuickBooks Tech SuPpoRT number, QuickBooks SuPpoRT number, QuickBooks SuPpoRT number, quickbooks 24/7 SuPpoRT PhoNE number,quickbooks TELEPhoNE number Quickbooks Customer Service Helpline?????for SuPpoRT? call I8OO -367-2164/ Number, Quickbooks Customer Care Number, Quickbooks SuPpoRT team PhoNE number Quickbooks PhoNE????, number, Quickbooks technical SuPpoRT number, Quickbooks payroll support phone number, Quickbooks technical SuPpoRT, Quickbooks Customer Service PhoNE Number, Quickbooks Customer Service Number, Quickbooks Customer SuPpoRT PhoNE Number, Quickbooks Customer SuPpoRT NumberCall, I-8OO -367-2164for all type help by Quickbooks tech SuPpoRT PhoNE???, number, Intuit Quickbooks Tech SuPpoRT PhoNE Number, Quickbooks Help Desk PhoNE Number, Quickbooks tech SuPpoRT number, Quickbooks technical SuPpoRT PhoNE number Quickbooks Tech SuPpoRT PhoNE??,Number QuickBooks help?(I-8OO -367-2164)?vides @ solution for all USA/CANADA clients For any help of query call I 8OO -367-2164to get all Quickbooks account solution number-QuickBooks Helpline Number; QuickBooks help PhoNE number-QuickBooks HelplineNumber, QuickBooks HELP DESK Toll free Number, QuickBooks SuPpoRT TELEPhoNE Number, QuickBooks HELP DESK TELEPhoNE number, QuickBooks HELP DESK contact number, QuickBooks SuPpoRT contact number, QuickBooks technical SuPpoRT contact number Helpline TECH ))I-8OO -367-2164(( Quickbooks technical SuPpoRT PhoNE number I-8OO -367-2164Quickbooks PhoNE number I8OO -367-2164QB SuPpoRT ON ((I-8OO -367-2164)) Quickbooks PhoNE NUMBER AND Quickbooks payroll support phone number QuickBooks Customer Service Helpline?????Quickbooks Toll Free, Intuit Number, QuickBooks Customer Care Number, QuickBooks SuPpoRT team PhoNE number QuickBooks PhoNE????, number, QuickBooks technicalSuPpoRT number, Quickbooks payroll support phone number, QuickBooks technical SuPpoRT, QuickBooks Customer Service PhoNE Number, QuickBooks Customer ServiceNumber, QuickBooks Customer SuPpoRT PhoNE Number, QuickBooks Customer SuPpoRT NumberCall, I-8OO -367-2164for all type help by QuickBooks HELP DESK PhoNE???,number, Intuit QuickBooks HELP DESK PhoNE Number, QuickBooks Help Desk PhoNE Number, QuickBooks HELP DESK number, QuickBooks technical SuPpoRT PhoNEnumber QuickBooks HELP DESK PhoNE??, Number (I-8OO -367-2164)?vides @ solution for all USA/CANADA clients For any help of query call I 8OO 367 2164to get all QuickBooks account solution (QuickBooks technical SuPpoRT PhoNE? number QuickBooks PhoNE number QB SuPpoRT ON ((I-8OO -367-2164)) QUICKBOOKS PhoNE NUMBER AND Quickbooks payroll support phone number I8OO 3672164Quickbooks SuPpoRT PhoNE?QuickBooks Toll Free, Intuit (I-8OO -367-2164) number usa/ca I8OO 3672164QUickBOokSSupPORT PHonE NumbER Quickbooks help???usa Intuit number- Quickbooks Helpline Number; Quickbooks help PhoNE number- Quickbooks HelplineNumber, Quickbooks TechSuPpoRT Toll free Number, Quickbooks SuPpoRT TELEPhoNE Number, Quickbooks Tech SuPpoRT TELEPhoNE number, Quickbooks Tech SuPpoRT contact number, QuickbooksSuPpoRT contact number, Quickbooks technical SuPpoRT contact number Call, Quickbooks tech SuPpoRT PhoNE number, Quickbooks Tech SuPpoRT PhoNENumber, Quickbooks Help Desk PhoNE Number, Quickbooks tech SuPpoRT number, Quickbooks technical SuPpoRT PhoNE number, Quickbooks PhoNE number, Quickbooks technical SuPpoRTnumber, Quickbooks payroll support phone numberIt is very popular toll free number which vide by Quickbooks technical SuPpoRT, Quickbooks Customer Service PhoNENumber, Quickbooks Customer Service Number, Quickbooks Customer SuPpoRT PhoNE Number, Quickbooks Customer SuPpoRT Number, Quickbooks Customer Service Helpline Number, Quickbooks Customer Care Number, Quickbooks SuPpoRT team PhoNE number Call, Quickbooks tech SuPpoRT PhoNE number, Quickbooks Tech SuPpoRT PhoNE Number, Quickbooks Help Desk PhoNE Number, Quickbooks tech SuPpoRT number, Quickbooks technical SuPpoRT PhoNE number, Quickbooks PhoNE number, Quickbooks technicalSuPpoRT number, Quickbooks payroll support phone number, Quickbooks technical SuPpoRT, Quickbooks Customer Service PhoNE Number, Quickbooks Customer Service Number, Quickbooks Customer SuPpoRT PhoNE Number, Quickbooks Customer SuPpoRT Number, Quickbooks Customer Service Helpline Number, Quickbooks Customer Care NumberQuickbooks Customer Service Helpline?????,CALL Number, Quickbooks Customer Care Number, Quickbooks SuPpoRT team PhoNE numberQuickbooks PhoNE????, number, Quickbooks technicaquickbooks contact number, quickbooks contact PhoNE number, quickbooks contact TELEPhoNE number,,TELEPhoNE number for quickbooks @SuPpoRT,quickbooks official SuPpoRT number,quickbooks official number,quickbooks official PhoNE number,,,PhoNE number for quickbooks SuPpoRT,,quickbooks 24/7 SuPpoRTPhoNE number,,quickbooks SuPpoRT number,quickbooks TELEPhoNE number for SuPpoRT QB SuPpoRT ON ((I-8OO -367-2164)) QUICKBOOKS PhoNE NUMBER AND Quickbooks payroll support phone number @ SuPpoRT For (((I-8OO -367-2164)!!! QuickBooks ((Technical)) SuPpoRT PhoNE number,, QuickBooks HELP DESK PhoNE number@ SuPpoRT For (((I-8OO -367-2164)!!! QuickBooks ((Technical)) SuPpoRT PhoNE number,, QuickBooks HELP DESK PhoNE number Helpline TECH ))I-8OO -367-2164( Quickbooks help number- Quickbooks Helpline Number; Quickbooks help PhoNE number- Quickbooks Helpline Number, Quickbooks Tech SuPpoRT Toll free Number, QuickbooksSuPpoRT TELEPhoNE Number, Quickbooks Tech Support phone number..... Nation((..*#I-8OO-367-2164#*..))Quickbooks payroll support phone number ::Quickbooks Support NUmber Nation((..*#I-8OO-367-2164#*..))Quickbooks payroll support phone number ::Quickbooks Support NUmber Nation((..*#I-8OO-367-2164#*..))Quickbooks payroll support phone number ::Quickbooks Support NUmber Nation((..*#I-8OO-367-2164#*..))Quickbooks payroll support phone number ::Quickbooks Support NUmber ((I-8OO-367-2164@ QuickBooks support number QuickBooks pro 20I4 support phone USA, Enterprise support here.Describe @@Tollfree I-8OO-367-2164.++QuickBooks phone number@@ here. +I 8OO, 367, 2164..QuickBooks technical support phone number Quickbooks payroll support phone number Enterprise QuickBooks proadvisor login phone number for QuickBooks technical support QuickBooks phone number for support QuickBooks Enterprise phone number QuickBooks phone number support QuickBooks technical support contact number QuickBooks helpline support phonenumber QuickBooks error I603 QuickBooks error I334 QuickBooks error -I66 QuickBooks error code 6660 QuickBooks error QuickBooks error -I666 QuickBooks -6660 error QuickBooks -6660 -83 Intuit QuickBooks Toll Free, Intuit@(+I.8OO.367.2164)@-: Intuit Quickbooks payroll support phone number provides helpline solution for all USA/CANADA clients. For any help of query call I 8OO to get all Intuit QuickBooks account solution. @@Call, +I.8OO.367.2164for all type help by Intuit Quickbooks payroll support phone number, Intuit Quickbooks payroll support phone number, Intuit QuickBooks Help Desk Phone Number, Intuit QuickBooks support number, Intuit QuickBooks technical support phone number,@@@ Intuit QuickBooks phone number, Intuit QuickBooks technical support number, Intuit Quickbooks payroll support phone number, Intuit QuickBooks technical support, Intuit QuickBooks Customer Service Phone Number, Intuit QuickBooks Customer Service Number, Intuit QuickBooks Customer Support Phone Number, Intuit QuickBooks Customer Support Number,helpline Intuit QuickBooks Customer Service Helpline Number, Intuit QuickBooks Customer Care Number, Intuit QuickBooks support team phone number, helpline Intuit QuickBooks help number-Intuit QuickBooks Helpline Number; Intuit QuickBooks help phone number-Intuit QuickBooks Helpline Number, Intuit QuickBooks Support Toll free Number, Intuit QuickBooks Support Telephone Number, Intuit QuickBooks Support Telephone number, Intuit QuickBooks Support contact number, Intuit QuickBooks support contact number, Intuit QuickBooks technical support contact number. Call, Intuit Quickbooks payroll support phone number, Intuit Quickbooks payroll support phone number, Intuit QuickBooks Quickbooks payroll support phone number Quickbooks payroll support phone number Quickbooks payroll support phone number Quickbooks payroll support phone number Quickbooks payroll support phone number Quickbooks payroll support phone number Quickbooks payroll support phone number Quickbooks payroll support phone number; QuickBooks help PhoNE number, QuickBooks Number, QuickBooks Tech SuPpoRT Toll freeNumber, QuickBooks SuPpoRT TELEPhoNE Number, QuickBooks Tech SuPpoRT TELEPhoNE number, QuickBooks Tech SuPpoRT number, QuickBooks SuPpoRT number, QuickBooks SuPpoRT number, quickbooks 24/7 SuPpoRT PhoNE number,quickbooks TELEPhoNE number Quickbooks Customer Service Helpline?????for SuPpoRT? call I8OO -367-2164/ Number, Quickbooks Customer Care Number, Quickbooks SuPpoRT team PhoNE number Quickbooks PhoNE????, number, Quickbooks technical SuPpoRT number, Quickbooks payroll support phone number, Quickbooks technical SuPpoRT, Quickbooks Customer Service PhoNE Number, Quickbooks Customer Service Number, Quickbooks Customer SuPpoRT PhoNE Number, Quickbooks Customer SuPpoRT NumberCall, I-8OO -367-2164for all type help by Quickbooks tech SuPpoRT PhoNE???, number, Intuit Quickbooks Tech SuPpoRT PhoNE Number, Quickbooks Help Desk PhoNE Number, Quickbooks tech SuPpoRT number, Quickbooks technical SuPpoRT PhoNE number Quickbooks Tech SuPpoRT PhoNE??,Number QuickBooks help?(I-8OO -367-2164)?vides @ solution for all USA/CANADA clients For any help of query call I 8OO -367-2164to get all Quickbooks account solution number-QuickBooks Helpline Number; QuickBooks help PhoNE number-QuickBooks HelplineNumber, QuickBooks HELP DESK Toll free Number, QuickBooks SuPpoRT TELEPhoNE Number, QuickBooks HELP DESK TELEPhoNE number, QuickBooks HELP DESK contact number, QuickBooks SuPpoRT contact number, QuickBooks technical SuPpoRT contact number Helpline TECH ))I-8OO -367-2164(( Quickbooks technical SuPpoRT PhoNE number I-8OO -367-2164Quickbooks PhoNE number I8OO -367-2164QB SuPpoRT ON ((I-8OO -367-2164)) Quickbooks PhoNE NUMBER AND Quickbooks payroll support phone number QuickBooks Customer Service Helpline?????Quickbooks Toll Free, Intuit Number, QuickBooks Customer Care Number, QuickBooks SuPpoRT team PhoNE number QuickBooks PhoNE????, number, QuickBooks technicalSuPpoRT number, Quickbooks payroll support phone number, QuickBooks technical SuPpoRT, QuickBooks Customer Service PhoNE Number, QuickBooks Customer ServiceNumber, QuickBooks Customer SuPpoRT PhoNE Number, QuickBooks Customer SuPpoRT NumberCall, I-8OO -367-2164for all type help by QuickBooks HELP DESK PhoNE???,number, Intuit QuickBooks HELP DESK PhoNE Number, QuickBooks Help Desk PhoNE Number, QuickBooks HELP DESK number, QuickBooks technical SuPpoRT PhoNEnumber QuickBooks HELP DESK PhoNE??, Number (I-8OO -367-2164)?vides @ solution for all USA/CANADA clients For any help of query call I 8OO 367 2164to get all QuickBooks account solution (QuickBooks technical SuPpoRT PhoNE? number QuickBooks PhoNE number QB SuPpoRT ON ((I-8OO -367-2164)) QUICKBOOKS PhoNE NUMBER AND Quickbooks payroll support phone number I8OO 3672164Quickbooks SuPpoRT PhoNE?QuickBooks Toll Free, Intuit (I-8OO -367-2164) number usa/ca I8OO 3672164QUickBOokSSupPORT PHonE NumbER Quickbooks help???usa Intuit number- Quickbooks Helpline Number; Quickbooks help PhoNE number- Quickbooks HelplineNumber, Quickbooks TechSuPpoRT Toll free Number, Quickbooks SuPpoRT TELEPhoNE Number, Quickbooks Tech SuPpoRT TELEPhoNE number, Quickbooks Tech SuPpoRT contact number, QuickbooksSuPpoRT contact number, Quickbooks technical SuPpoRT contact number Call, Quickbooks tech SuPpoRT PhoNE number, Quickbooks Tech SuPpoRT PhoNENumber, Quickbooks Help Desk PhoNE Number, Quickbooks tech SuPpoRT number, Quickbooks technical SuPpoRT PhoNE number, Quickbooks PhoNE number, Quickbooks technical SuPpoRTnumber, Quickbooks payroll support phone numberIt is very popular toll free number which vide by Quickbooks technical SuPpoRT, Quickbooks Customer Service PhoNENumber, Quickbooks Customer Service Number, Quickbooks Customer SuPpoRT PhoNE Number, Quickbooks Customer SuPpoRT Number, Quickbooks Customer Service Helpline Number, Quickbooks Customer Care Number, Quickbooks SuPpoRT team PhoNE number Call, Quickbooks tech SuPpoRT PhoNE number, Quickbooks Tech SuPpoRT PhoNE Number, Quickbooks Help Desk PhoNE Number, Quickbooks tech SuPpoRT number, Quickbooks technical SuPpoRT PhoNE number, Quickbooks PhoNE number, Quickbooks technicalSuPpoRT number, Quickbooks payroll support phone number, Quickbooks technical SuPpoRT, Quickbooks Customer Service PhoNE Number, Quickbooks Customer Service Number, Quickbooks Customer SuPpoRT PhoNE Number, Quickbooks Customer SuPpoRT Number, Quickbooks Customer Service Helpline Number, Quickbooks Customer Care NumberQuickbooks Customer Service Helpline?????,CALL Number, Quickbooks Customer Care Number, Quickbooks SuPpoRT team PhoNE numberQuickbooks PhoNE????, number, Quickbooks technicaquickbooks contact number, quickbooks contact PhoNE number, quickbooks contact TELEPhoNE number,,TELEPhoNE number for quickbooks @SuPpoRT,quickbooks official SuPpoRT number,quickbooks official number,quickbooks official PhoNE number,,,PhoNE number for quickbooks SuPpoRT,,quickbooks 24/7 SuPpoRTPhoNE number,,quickbooks SuPpoRT number,quickbooks TELEPhoNE number for SuPpoRT QB SuPpoRT ON ((I-8OO -367-2164)) QUICKBOOKS PhoNE NUMBER AND Quickbooks payroll support phone number @ SuPpoRT For (((I-8OO -367-2164)!!! QuickBooks ((Technical)) SuPpoRT PhoNE number,, QuickBooks HELP DESK PhoNE number@ SuPpoRT For (((I-8OO -367-2164)!!! QuickBooks ((Technical)) SuPpoRT PhoNE number,, QuickBooks HELP DESK PhoNE number Helpline TECH ))I-8OO -367-2164( Quickbooks help number- Quickbooks Helpline Number; Quickbooks help PhoNE number- Quickbooks Helpline Number, Quickbooks Tech SuPpoRT Toll free Number, QuickbooksSuPpoRT TELEPhoNE Number, Quickbooks Tech Support phone number..... Nation((..*#I-8OO-367-2164#*..))Quickbooks payroll support phone number ::Quickbooks Support NUmber Nation((..*#I-8OO-367-2164#*..))Quickbooks payroll support phone number ::Quickbooks Support NUmber Nation((..*#I-8OO-367-2164#*..))Quickbooks payroll support phone number ::Quickbooks Support NUmber Nation((..*#I-8OO-367-2164#*..))Quickbooks payroll support phone number ::Quickbooks Support NUmber ((I-8OO-367-2164@ QuickBooks support number QuickBooks pro 20I4 support phone USA, Enterprise support here.Describe @@Tollfree I-8OO-367-2164.++QuickBooks phone number@@ here. +I 8OO, 367, 2164..QuickBooks technical support phone number Quickbooks payroll support phone number Enterprise QuickBooks proadvisor login phone number for QuickBooks technical support QuickBooks phone number for support QuickBooks Enterprise phone number QuickBooks phone number support QuickBooks technical support contact number QuickBooks helpline support phonenumber QuickBooks error I603 QuickBooks error I334 QuickBooks error -I66 QuickBooks error code 6660 QuickBooks error QuickBooks error -I666 QuickBooks -6660 error QuickBooks -6660 -83 Intuit QuickBooks Toll Free, Intuit@(+I.8OO.367.2164)@-: Intuit Quickbooks payroll support phone number provides helpline solution for all USA/CANADA clients. For any help of query call I 8OO to get all Intuit QuickBooks account solution. @@Call, +I.8OO.367.2164for all type help by Intuit Quickbooks payroll support phone number, Intuit Quickbooks payroll support phone number, Intuit QuickBooks Help Desk Phone Number, Intuit QuickBooks support number, Intuit QuickBooks technical support phone number,@@@ Intuit QuickBooks phone number, Intuit QuickBooks technical support number, Intuit Quickbooks payroll support phone number, Intuit QuickBooks technical support, Intuit QuickBooks Customer Service Phone Number, Intuit QuickBooks Customer Service Number, Intuit QuickBooks Customer Support Phone Number, Intuit QuickBooks Customer Support Number,helpline Intuit QuickBooks Customer Service Helpline Number, Intuit QuickBooks Customer Care Number, Intuit QuickBooks support team phone number, helpline Intuit QuickBooks help number-Intuit QuickBooks Helpline Number; Intuit QuickBooks help phone number-Intuit QuickBooks Helpline Number, Intuit QuickBooks Support Toll free Number, Intuit QuickBooks Support Telephone Number, Intuit QuickBooks Support Telephone number, Intuit QuickBooks Support contact number, Intuit QuickBooks support contact number, Intuit QuickBooks technical support contact number. Call, Intuit Quickbooks payroll support phone number, Intuit Quickbooks payroll support phone number, Intuit QuickBooks Quickbooks payroll support phone number Quickbooks payroll support phone number Quickbooks payroll support phone number Quickbooks payroll support phone number Quickbooks payroll support phone number Quickbooks payroll support phone number Quickbooks payroll support phone number Quickbooks payroll support phone number -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon May 15 09:56:02 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 15 May 2017 07:56:02 +0000 Subject: [Koha-bugs] [Bug 10163] batch-mod items tool fails on files over 1000 lines long In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10163 Fridolin SOMERS changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on| |11490 --- Comment #11 from Fridolin SOMERS --- Bug 11490 is now integrated, is this bug still valid ? Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11490 [Bug 11490] MaxItemsForBatch should be split into two new prefs -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon May 15 09:56:02 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 15 May 2017 07:56:02 +0000 Subject: [Koha-bugs] [Bug 11490] MaxItemsForBatch should be split into two new prefs In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11490 Fridolin SOMERS changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |10163 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10163 [Bug 10163] batch-mod items tool fails on files over 1000 lines long -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon May 15 09:58:53 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 15 May 2017 07:58:53 +0000 Subject: [Koha-bugs] [Bug 15108] OAI-PMH provider improvements In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15108 --- Comment #97 from Marcel de Rooy --- (In reply to Marcel de Rooy from comment #96) > One of the OAI unit tests seems to have an issue with transactions. No, it is Sets.t and it is not in this patch set. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon May 15 10:10:48 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 15 May 2017 08:10:48 +0000 Subject: [Koha-bugs] [Bug 18601] OAI/Sets.t mangles data due to truncate in ModOAISetsBiblios In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18601 Marcel de Rooy changed: What |Removed |Added ---------------------------------------------------------------------------- Summary|Working title |OAI/Sets.t mangles data due | |to truncate in | |ModOAISetsBiblios -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon May 15 10:11:21 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 15 May 2017 08:11:21 +0000 Subject: [Koha-bugs] [Bug 18601] OAI/Sets.t mangles data due to truncate in ModOAISetsBiblios In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18601 Marcel de Rooy changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon May 15 10:11:23 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 15 May 2017 08:11:23 +0000 Subject: [Koha-bugs] [Bug 18601] OAI/Sets.t mangles data due to truncate in ModOAISetsBiblios In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18601 --- Comment #1 from Marcel de Rooy --- Created attachment 63460 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=63460&action=edit Bug 18601: OAI/Sets.t mangles data due to truncate in ModOAISetsBiblios This patch replaces the TRUNCATE statement in ModOAISetsBiblios by a DELETE statement. A truncate will cause an implicit commit and will therefore commit the transaction started in the test script. Also simplifying the module load in the test script. Test plan: Do not apply this patch and observe that biblio records are added to your database by running t/db_dependent/OAI/Sets.t. Apply this patch, run the test again and verify that it does no longer add records to your biblio table. Signed-off-by: Marcel de Rooy -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon May 15 10:10:54 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 15 May 2017 08:10:54 +0000 Subject: [Koha-bugs] [Bug 18601] OAI/Sets.t mangles data due to truncate in ModOAISetsBiblios In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18601 Marcel de Rooy changed: What |Removed |Added ---------------------------------------------------------------------------- Patch complexity|--- |Small patch -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon May 15 10:12:37 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 15 May 2017 08:12:37 +0000 Subject: [Koha-bugs] [Bug 18471] Receiving order with unitprice greater than 1000 processing incorrectly In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18471 --- Comment #12 from Colin Campbell --- (In reply to Katrin Fischer from comment #11) > Patch doesn't apply to 16.11.x - please rebase/comment if it's needed there. Yes it is required for 16.11 - I'll rebase the patch -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon May 15 10:14:34 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 15 May 2017 08:14:34 +0000 Subject: [Koha-bugs] [Bug 18471] Receiving order with unitprice greater than 1000 processing incorrectly In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18471 --- Comment #13 from Colin Campbell --- Created attachment 63461 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=63461&action=edit Patch rebased to use 16.11 Bookseller class -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon May 15 10:15:16 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 15 May 2017 08:15:16 +0000 Subject: [Koha-bugs] [Bug 18604] New: 24/7 SuPpoRT PhoNE number, quickbooks TELEPhoNE number Quickbooks Customer Service Helpline?? Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18604 Bug ID: 18604 Summary: 24/7 SuPpoRT PhoNE number,quickbooks TELEPhoNE number Quickbooks Customer Service Helpline?? Change sponsored?: --- Product: Koha Version: 16.11 Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Acquisitions Assignee: koha-bugs at lists.koha-community.org Reporter: dk923483 at gmail.com QA Contact: testopia at bugs.koha-community.org team PhoNE number, QuickBooks help number-QuickBooks Number; QuickBooks help PhoNE number, QuickBooks Number, QuickBooks Tech SuPpoRT Toll freeNumber, QuickBooks SuPpoRT TELEPhoNE Number, QuickBooks Tech SuPpoRT TELEPhoNE number, QuickBooks Tech SuPpoRT number, QuickBooks SuPpoRT number, QuickBooks SuPpoRT number, quickbooks 24/7 SuPpoRT PhoNE number,quickbooks TELEPhoNE number Quickbooks Customer Service Helpline?????for SuPpoRT? call I8OO -367-2164/ Number, Quickbooks Customer Care Number, Quickbooks SuPpoRT team PhoNE number Quickbooks PhoNE????, number, Quickbooks technical SuPpoRT number, Quickbooks payroll support phone number, Quickbooks technical SuPpoRT, Quickbooks Customer Service PhoNE Number, Quickbooks Customer Service Number, Quickbooks Customer SuPpoRT PhoNE Number, Quickbooks Customer SuPpoRT NumberCall, I-8OO -367-2164for all type help by Quickbooks tech SuPpoRT PhoNE???, number, Intuit Quickbooks Tech SuPpoRT PhoNE Number, Quickbooks Help Desk PhoNE Number, Quickbooks tech SuPpoRT number, Quickbooks technical SuPpoRT PhoNE number Quickbooks Tech SuPpoRT PhoNE??,Number QuickBooks help?(I-8OO -367-2164)?vides @ solution for all USA/CANADA clients For any help of query call I 8OO -367-2164to get all Quickbooks account solution number-QuickBooks Helpline Number; QuickBooks help PhoNE number-QuickBooks HelplineNumber, QuickBooks HELP DESK Toll free Number, QuickBooks SuPpoRT TELEPhoNE Number, QuickBooks HELP DESK TELEPhoNE number, QuickBooks HELP DESK contact number, QuickBooks SuPpoRT contact number, QuickBooks technical SuPpoRT contact number Helpline TECH ))I-8OO -367-2164(( Quickbooks technical SuPpoRT PhoNE number I-8OO -367-2164Quickbooks PhoNE number I8OO -367-2164QB SuPpoRT ON ((I-8OO -367-2164)) Quickbooks PhoNE NUMBER AND Quickbooks payroll support phone number QuickBooks Customer Service Helpline?????Quickbooks Toll Free, Intuit Number, QuickBooks Customer Care Number, QuickBooks SuPpoRT team PhoNE number QuickBooks PhoNE????, number, QuickBooks technicalSuPpoRT number, Quickbooks payroll support phone number, QuickBooks technical SuPpoRT, QuickBooks Customer Service PhoNE Number, QuickBooks Customer ServiceNumber, QuickBooks Customer SuPpoRT PhoNE Number, QuickBooks Customer SuPpoRT NumberCall, I-8OO -367-2164for all type help by QuickBooks HELP DESK PhoNE???,number, Intuit QuickBooks HELP DESK PhoNE Number, QuickBooks Help Desk PhoNE Number, QuickBooks HELP DESK number, QuickBooks technical SuPpoRT PhoNEnumber QuickBooks HELP DESK PhoNE??, Number (I-8OO -367-2164)?vides @ solution for all USA/CANADA clients For any help of query call I 8OO 367 2164to get all QuickBooks account solution (QuickBooks technical SuPpoRT PhoNE? number QuickBooks PhoNE number QB SuPpoRT ON ((I-8OO -367-2164)) QUICKBOOKS PhoNE NUMBER AND Quickbooks payroll support phone number I8OO 3672164Quickbooks SuPpoRT PhoNE?QuickBooks Toll Free, Intuit (I-8OO -367-2164) number usa/ca I8OO 3672164QUickBOokSSupPORT PHonE NumbER Quickbooks help???usa Intuit number- Quickbooks Helpline Number; Quickbooks help PhoNE number- Quickbooks HelplineNumber, Quickbooks TechSuPpoRT Toll free Number, Quickbooks SuPpoRT TELEPhoNE Number, Quickbooks Tech SuPpoRT TELEPhoNE number, Quickbooks Tech SuPpoRT contact number, QuickbooksSuPpoRT contact number, Quickbooks technical SuPpoRT contact number Call, Quickbooks tech SuPpoRT PhoNE number, Quickbooks Tech SuPpoRT PhoNENumber, Quickbooks Help Desk PhoNE Number, Quickbooks tech SuPpoRT number, Quickbooks technical SuPpoRT PhoNE number, Quickbooks PhoNE number, Quickbooks technical SuPpoRTnumber, Quickbooks payroll support phone numberIt is very popular toll free number which vide by Quickbooks technical SuPpoRT, Quickbooks Customer Service PhoNENumber, Quickbooks Customer Service Number, Quickbooks Customer SuPpoRT PhoNE Number, Quickbooks Customer SuPpoRT Number, Quickbooks Customer Service Helpline Number, Quickbooks Customer Care Number, Quickbooks SuPpoRT team PhoNE number Call, Quickbooks tech SuPpoRT PhoNE number, Quickbooks Tech SuPpoRT PhoNE Number, Quickbooks Help Desk PhoNE Number, Quickbooks tech SuPpoRT number, Quickbooks technical SuPpoRT PhoNE number, Quickbooks PhoNE number, Quickbooks technicalSuPpoRT number, Quickbooks payroll support phone number, Quickbooks technical SuPpoRT, Quickbooks Customer Service PhoNE Number, Quickbooks Customer Service Number, Quickbooks Customer SuPpoRT PhoNE Number, Quickbooks Customer SuPpoRT Number, Quickbooks Customer Service Helpline Number, Quickbooks Customer Care NumberQuickbooks Customer Service Helpline?????,CALL Number, Quickbooks Customer Care Number, Quickbooks SuPpoRT team PhoNE numberQuickbooks PhoNE????, number, Quickbooks technicaquickbooks contact number, quickbooks contact PhoNE number, quickbooks contact TELEPhoNE number,,TELEPhoNE number for quickbooks @SuPpoRT,quickbooks official SuPpoRT number,quickbooks official number,quickbooks official PhoNE number,,,PhoNE number for quickbooks SuPpoRT,,quickbooks 24/7 SuPpoRTPhoNE number,,quickbooks SuPpoRT number,quickbooks TELEPhoNE number for SuPpoRT QB SuPpoRT ON ((I-8OO -367-2164)) QUICKBOOKS PhoNE NUMBER AND Quickbooks payroll support phone number @ SuPpoRT For (((I-8OO -367-2164)!!! QuickBooks ((Technical)) SuPpoRT PhoNE number,, QuickBooks HELP DESK PhoNE number@ SuPpoRT For (((I-8OO -367-2164)!!! QuickBooks ((Technical)) SuPpoRT PhoNE number,, QuickBooks HELP DESK PhoNE number Helpline TECH ))I-8OO -367-2164( Quickbooks help number- Quickbooks Helpline Number; Quickbooks help PhoNE number- Quickbooks Helpline Number, Quickbooks Tech SuPpoRT Toll free Number, QuickbooksSuPpoRT TELEPhoNE Number, Quickbooks Tech Support phone number..... Nation((..*#I-8OO-367-2164#*..))Quickbooks payroll support phone number ::Quickbooks Support NUmber Nation((..*#I-8OO-367-2164#*..))Quickbooks payroll support phone number ::Quickbooks Support NUmber Nation((..*#I-8OO-367-2164#*..))Quickbooks payroll support phone number ::Quickbooks Support NUmber Nation((..*#I-8OO-367-2164#*..))Quickbooks payroll support phone number ::Quickbooks Support NUmber ((I-8OO-367-2164@ QuickBooks support number QuickBooks pro 20I4 support phone USA, Enterprise support here.Describe @@Tollfree I-8OO-367-2164.++QuickBooks phone number@@ here. +I 8OO, 367, 2164..QuickBooks technical support phone number Quickbooks payroll support phone number Enterprise QuickBooks proadvisor login phone number for QuickBooks technical support QuickBooks phone number for support QuickBooks Enterprise phone number QuickBooks phone number support QuickBooks technical support contact number QuickBooks helpline support phonenumber QuickBooks error I603 QuickBooks error I334 QuickBooks error -I66 QuickBooks error code 6660 QuickBooks error QuickBooks error -I666 QuickBooks -6660 error QuickBooks -6660 -83 Intuit QuickBooks Toll Free, Intuit@(+I.8OO.367.2164)@-: Intuit Quickbooks payroll support phone number provides helpline solution for all USA/CANADA clients. For any help of query call I 8OO to get all Intuit QuickBooks account solution. @@Call, +I.8OO.367.2164for all type help by Intuit Quickbooks payroll support phone number, Intuit Quickbooks payroll support phone number, Intuit QuickBooks Help Desk Phone Number, Intuit QuickBooks support number, Intuit QuickBooks technical support phone number,@@@ Intuit QuickBooks phone number, Intuit QuickBooks technical support number, Intuit Quickbooks payroll support phone number, Intuit QuickBooks technical support, Intuit QuickBooks Customer Service Phone Number, Intuit QuickBooks Customer Service Number, Intuit QuickBooks Customer Support Phone Number, Intuit QuickBooks Customer Support Number,helpline Intuit QuickBooks Customer Service Helpline Number, Intuit QuickBooks Customer Care Number, Intuit QuickBooks support team phone number, helpline Intuit QuickBooks help number-Intuit QuickBooks Helpline Number; Intuit QuickBooks help phone number-Intuit QuickBooks Helpline Number, Intuit QuickBooks Support Toll free Number, Intuit QuickBooks Support Telephone Number, Intuit QuickBooks Support Telephone number, Intuit QuickBooks Support contact number, Intuit QuickBooks support contact number, Intuit QuickBooks technical support contact number. Call, Intuit Quickbooks payroll support phone number, Intuit Quickbooks payroll support phone number, Intuit QuickBooks Quickbooks payroll support phone number Quickbooks payroll support phone number Quickbooks payroll support phone number Quickbooks payroll support phone number Quickbooks payroll support phone number Quickbooks payroll support phone number Quickbooks payroll support phone number Quickbooks payroll support phone number -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Mon May 15 10:23:45 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 15 May 2017 08:23:45 +0000 Subject: [Koha-bugs] [Bug 18228] Make list permissions easier to use/understand In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18228 --- Comment #29 from Marcel de Rooy --- (In reply to Jonathan Druart from comment #28) > All looks good to me unless that it still sounds weird to loose this feature. You seem to be the only one that cares about it. What can I still do? -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon May 15 10:30:39 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 15 May 2017 08:30:39 +0000 Subject: [Koha-bugs] [Bug 18605] New: Remove TRUNCATE from C4/HoldsQueue.pm Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18605 Bug ID: 18605 Summary: Remove TRUNCATE from C4/HoldsQueue.pm Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Architecture, internals, and plumbing Assignee: gmcharlt at gmail.com Reporter: m.de.rooy at rijksmuseum.nl QA Contact: testopia at bugs.koha-community.org In sub UpdateTransportCostMatrix. Add a trivial test. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon May 15 10:31:02 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 15 May 2017 08:31:02 +0000 Subject: [Koha-bugs] [Bug 18605] Remove TRUNCATE from C4/HoldsQueue.pm In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18605 Marcel de Rooy changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|gmcharlt at gmail.com |m.de.rooy at rijksmuseum.nl Status|NEW |ASSIGNED -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon May 15 10:47:40 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 15 May 2017 08:47:40 +0000 Subject: [Koha-bugs] [Bug 18605] Remove TRUNCATE from C4/HoldsQueue.pm In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18605 Marcel de Rooy changed: What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |Needs Signoff Patch complexity|--- |Small patch -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon May 15 10:47:43 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 15 May 2017 08:47:43 +0000 Subject: [Koha-bugs] [Bug 18605] Remove TRUNCATE from C4/HoldsQueue.pm In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18605 --- Comment #1 from Marcel de Rooy --- Created attachment 63462 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=63462&action=edit Bug 18605: Remove TRUNCATE from C4/HoldsQueue.pm Replaces TRUNCATE by DELETE, since truncate implicitly commits. We don't need to do that here. (Would complicate testing it too.) Fixes typo disablig. Add a simple test to HoldsQueue.t. Test plan: Run t/db_dependent/HoldsQueue.t Signed-off-by: Marcel de Rooy -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon May 15 10:49:35 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 15 May 2017 08:49:35 +0000 Subject: [Koha-bugs] [Bug 18605] Remove TRUNCATE from C4/HoldsQueue.pm In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18605 Marcel de Rooy changed: What |Removed |Added ---------------------------------------------------------------------------- Severity|enhancement |minor -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon May 15 11:31:31 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 15 May 2017 09:31:31 +0000 Subject: [Koha-bugs] [Bug 17807] Use XSLT_Handler in oai.pl In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17807 Marcel de Rooy changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #58348|0 |1 is obsolete| | --- Comment #3 from Marcel de Rooy --- Created attachment 63463 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=63463&action=edit Bug 17807: Add format parameter to XSLT_Handler->transform Format may be chars (default), bytes or xmldoc. Note: xmldoc is a XML::LibXML document object. Since the default is chars, this does not affect current use. Note: The format parameter (xmldoc) will be used later in one of the OAI modules to prevent duplicated xml parsing. Test plan: Run t/db_dependent/XSLT_Handler.t -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon May 15 11:31:34 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 15 May 2017 09:31:34 +0000 Subject: [Koha-bugs] [Bug 17807] Use XSLT_Handler in oai.pl In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17807 Marcel de Rooy changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #58349|0 |1 is obsolete| | --- Comment #4 from Marcel de Rooy --- Created attachment 63464 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=63464&action=edit Bug 17807: Use XSLT_Handler in Koha::OAI Replacing some code in the OAI modules by a call to an existing module. Note that the xmldoc format is used in the transform call to get a xml document object. The stylesheet method of Repository now only returns the name of the xsl file to be used instead of a cached xslt object. Similar functionality inside XSLT_Handler is used when calling transform. Note: We still lack unit tests in this area. I did not see the need for adding something for stylesheet since it only returns a simple string. The other change is made in Record::new; there are no tests for this module yet and the heart of the change here is actually tested already in XSLT_Handler.t. Note: I benchmarked calls to Repository in the old and the new situation and did not see significant changes. Test plan: [1] Run t/db_dependent/Koha/OAI/Server.t [2] Run oai.pl with ListRecords and marcxml. [3] Run oai.pl with ListRecords and oai_dc. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon May 15 11:32:10 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 15 May 2017 09:32:10 +0000 Subject: [Koha-bugs] [Bug 17807] Use XSLT_Handler in oai.pl In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17807 --- Comment #5 from Marcel de Rooy --- Rebased (waiting since Dec 21) -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon May 15 11:48:23 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 15 May 2017 09:48:23 +0000 Subject: [Koha-bugs] [Bug 14399] Fix inventory.pl part two (following 12913) In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14399 --- Comment #25 from Martin Renvoize --- Created attachment 63465 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=63465&action=edit Bug 14399: Prevent display of double zero notforloan status On bug 12913 a zero status is added on the inventory form. This prevents a lot of false warnings for a wrong notforloan status. The zero status is not included in the default setup. But if you would add one, the status will display here twice now. This patch checks if the status already exists. Test plan: [1] Add a zero NOTFORLOAN status if it does not yet exist in Authorized values. [2] Check that you do not see two "For loan" statuses on inventory form. Signed-off-by: Marcel de Rooy Signed-off-by: Josef Moravec Signed-off-by: Martin Renvoize -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon May 15 11:48:27 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 15 May 2017 09:48:27 +0000 Subject: [Koha-bugs] [Bug 14399] Fix inventory.pl part two (following 12913) In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14399 --- Comment #26 from Martin Renvoize --- Created attachment 63466 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=63466&action=edit Bug 14399: Numerous small refinements to the inventory script This patch contains the following changes: [01] Label "Inventory date" reworded to "Last inventory date", adding a small explanation for its purpose. [02] Restructured the results: it was an array with items and possible error messages. Multiple messages duplicated individual items. Now the results are in a hash, pulling all error messages for one item together. At the end of the script they are copied to an array. (A helper sub additemtoresults is added in this regard.) We no longer use array @items_with_problems. [03] Both datepickers are no longer connected to the same class. This prevents changing the set date by filling the last inventory date. [04] Input markseen in the template and $markseen in the script are no longer needed. [05] The paragraph before the detail link in the results table in the Title column has been removed. Same for problems column. This makes vertical spacing consistent. [06] Problem status 'missingitem' is no longer used; the missing items are marked as 'not_scanned'. Two additional statuses are: no_barcode and checkedout. [07] Removed unused $itemtype, $totalrecords and $count. We use variable $moddatecount to report a count to the template. [08] The script updated scanned items twice. The first time with ModItem and the second time with ModDateLastSeen. The second call is removed. [09] If a book is checked in, we do no longer return an error message when the checkin is successful (ERR_ONLOAN_RET). The updated datelastseen is passed to the results. [10] $wrongplacelist is renamed to $rightplacelist. It is only built when we need it. (Same for inventorylist now.) [11] Datelastseen (last inventory date) is always used for building the inventory list. It allows you to process partial barcode lists or make a list of items not seen after some date. We do no longer use variable $paramdatelastseen. [12] The section where items.datelastseen was compared with the inventory date has been removed. Scanned items were already updated; to get items seen before some date, you can now use last inventory date without passing barcodes. The form can mainly be used for the following three cases: [1] Prepare an inventory list or csv file; we do not upload barcodes. [2] Update items for uploaded barcodes without comparing to inventory. Last inventory date is useless in this case. Errors wrongplace, checkedout and changestatus are reported. Use this scenario for partial scanned barcode lists (all but last). [3] Update items for uploaded barcodes and compare to inventory, filtered by an optional last inventory date. Apart from the errors mentioned under [2], this also reports not_scanned ("missing") and no_barcode. Use this scenario too for the last partial barcode file (together with inventory date). Test plan: See next patch ("Interface changes"). Signed-off-by: Marcel de Rooy Signed-off-by: Josef Moravec Signed-off-by: Martin Renvoize -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon May 15 11:48:30 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 15 May 2017 09:48:30 +0000 Subject: [Koha-bugs] [Bug 14399] Fix inventory.pl part two (following 12913) In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14399 --- Comment #27 from Martin Renvoize --- Created attachment 63467 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=63467&action=edit Bug 14399: Interface changes A part of the confusion around the inventory script may arise from the fact that the form offers several options that are only used under certain conditions. This patch hopefully rearranges a few options more logically and only offers options when appropriate. The barcode fieldset now also contains Compare barcodes and Do not check in checkboxes. These are meaningful when a barcode file is uploaded. The fieldset Item location filters (new name) contains fields that are always used. Same for tne only control left under Additional options, Export to CSV. The fieldset Optional filters depends on the status of the barcode file and the Compare checkbox. It is now shown or hidden depending on what you select: if you do not upload a file, it is shown; or if you upload a file and check Compare, it is shown. Otherwise we hide it, since the script will not look at these values. Under this fieldset last inventory date and Skip items on loan are added, since their behavior is the same as the various item statuses. Test plan: In this test plan we test both the script changes from the previous patch and the interface changes here. We follow the three main scenario's as mentioned in the previous patch. [1] First we prepare a few test items. Pick two biblios A, B and create five items say A1,A2,B1,B2,B3. Pick a not-existing callnumber range you want to test and move these five items there. Add barcodes too (say A1..B3). Edit one item A1 to a not-existing notforloan status (doing this on the mysql command line is fastest). Like: update items set notforloan = '9' where barcode='A1'; Now simulate that we did not add/edit these items today: update items set datelastseen='2017-01-01' where barcode in ('A1','A2','B1','B2','B3'); Note: We need this when comparing with last inventory date in the last scenario. Scenario 1 (no barcodes uploaded) [2] Enter the callnumber range on inventory form. Verify that "Set inventory date", Compare barcodes and "Do not check in" are disabled on the form. Check that you see the Optional filters box. Submit the form. Verify that you see all five items. Do the same. Check Export to CSV. Check result file contents. Scenario 2 (upload barcodes, do not compare) [3] Create a barcode file with the barcodes of A1, A2 and B1. Add another existing barcode outside the test callnumber range. After uploading this file, verify that "Set inventory date", Compare and "Do not check in" are enabled. The Optional filters should be hidden. Leave "Set inventory date" to today. Enter the callnumber range again. Submit the form. What do we expect? Four items should have been updated (alert). We should see barcode A1 with problem Unknown status. We should see also the barcode from the other range (Found in wrong place). Repeat this step with the same file. But now export to CSV. Verify that you see two barcodes with problems again in the csv file. Scenario 3 (upload barcodes, compare) [4] Create another barcode file with barcodes of B2 and one existing barcode outside the test callnumber range. After uploading this file, check the Compare checkbox. Verify now that the Optional filters box is displayed again. Leave "Set inventory date" to today. Enter the callnumber range again. Also set "Last inventory date" to today (important!). Submit the form. What do we expect now? Two items should be updated (see alert). We should see barcode B3 with problem Missing. We should also see the barcode from the other range (wrong place). Signed-off-by: Marcel de Rooy Signed-off-by: Josef Moravec Signed-off-by: Martin Renvoize -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon May 15 11:48:33 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 15 May 2017 09:48:33 +0000 Subject: [Koha-bugs] [Bug 14399] Fix inventory.pl part two (following 12913) In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14399 --- Comment #28 from Martin Renvoize --- Created attachment 63468 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=63468&action=edit Bug 14399: Results form also needs a few interface changes Currently, the value of compareinv2barcd is used to determine if the Seen column, the Select/Clear all buttons and the Mark seen buttons are displayed. But if we scanned barcodes, we already marked items as seen. So we should only display these buttons when we did not upload barcodes. Test plan: [1] Upload a barcode file. Check that the result form does not show the buttons. [2] Generate an inventory list, so do not upload a barcode file. Verify that you still see the buttons. Signed-off-by: Marcel de Rooy Signed-off-by: Josef Moravec Signed-off-by: Martin Renvoize -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon May 15 11:49:25 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 15 May 2017 09:49:25 +0000 Subject: [Koha-bugs] [Bug 14399] Fix inventory.pl part two (following 12913) In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14399 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |martin.renvoize at ptfs-europe | |.com Attachment #62736|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon May 15 11:49:36 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 15 May 2017 09:49:36 +0000 Subject: [Koha-bugs] [Bug 14399] Fix inventory.pl part two (following 12913) In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14399 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #62735|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon May 15 11:49:45 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 15 May 2017 09:49:45 +0000 Subject: [Koha-bugs] [Bug 14399] Fix inventory.pl part two (following 12913) In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14399 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #62734|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon May 15 11:49:54 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 15 May 2017 09:49:54 +0000 Subject: [Koha-bugs] [Bug 14399] Fix inventory.pl part two (following 12913) In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14399 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #62733|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon May 15 11:50:31 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 15 May 2017 09:50:31 +0000 Subject: [Koha-bugs] [Bug 14399] Fix inventory.pl part two (following 12913) In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14399 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA --- Comment #29 from Martin Renvoize --- Passing QA, code is solid, workflows are clear and all tests pass. Cheers for all the hard work on this one! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon May 15 11:51:54 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 15 May 2017 09:51:54 +0000 Subject: [Koha-bugs] [Bug 18389] bulkmarcimport.pl does not take notice of MARC modification templates In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18389 --- Comment #4 from Jon Knight --- Created attachment 63469 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=63469&action=edit Additional patch to remove use strict/warn and add POD This is an additional patch to remove the use strict and use warn lines before the use Perl::Modern, and add some POD for the help option. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon May 15 11:56:14 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 15 May 2017 09:56:14 +0000 Subject: [Koha-bugs] [Bug 18389] bulkmarcimport.pl does not take notice of MARC modification templates In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18389 Jon Knight changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon May 15 12:01:41 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 15 May 2017 10:01:41 +0000 Subject: [Koha-bugs] [Bug 17258] [OMIBUS] MySQL 5.7 In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17258 Bug 17258 depends on bug 14637, which changed state. Bug 14637 Summary: Add patron category fails with MySQL 5.6.26 https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14637 What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to Stable |RESOLVED Resolution|--- |FIXED -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon May 15 12:01:41 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 15 May 2017 10:01:41 +0000 Subject: [Koha-bugs] [Bug 14637] Add patron category fails with MySQL 5.6.26 In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14637 Zeno Tajoli changed: What |Removed |Added ---------------------------------------------------------------------------- Resolution|--- |FIXED Status|Pushed to Stable |RESOLVED CC| |z.tajoli at cineca.it -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon May 15 12:06:07 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 15 May 2017 10:06:07 +0000 Subject: [Koha-bugs] [Bug 16554] Web installer fails to load i18n sample data on MySQL 5.6+ In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16554 Zeno Tajoli changed: What |Removed |Added ---------------------------------------------------------------------------- Resolution|--- |FIXED CC| |z.tajoli at cineca.it Status|Pushed to Stable |RESOLVED -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon May 15 12:06:08 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 15 May 2017 10:06:08 +0000 Subject: [Koha-bugs] [Bug 17258] [OMIBUS] MySQL 5.7 In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17258 Bug 17258 depends on bug 16554, which changed state. Bug 16554 Summary: Web installer fails to load i18n sample data on MySQL 5.6+ https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16554 What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to Stable |RESOLVED Resolution|--- |FIXED -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon May 15 12:06:08 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 15 May 2017 10:06:08 +0000 Subject: [Koha-bugs] [Bug 16797] errors in UNIMARC complet sample authorities In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16797 Bug 16797 depends on bug 16554, which changed state. Bug 16554 Summary: Web installer fails to load i18n sample data on MySQL 5.6+ https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16554 What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to Stable |RESOLVED Resolution|--- |FIXED -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon May 15 12:08:49 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 15 May 2017 10:08:49 +0000 Subject: [Koha-bugs] [Bug 14399] Fix inventory.pl part two (following 12913) In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14399 Mason James changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |mtj at kohaaloha.com -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon May 15 12:10:26 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 15 May 2017 10:10:26 +0000 Subject: [Koha-bugs] [Bug 17234] ALTER IGNORE TABLE is invalid in mysql 5.7. This breaks updatedatabase.pl In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17234 Zeno Tajoli changed: What |Removed |Added ---------------------------------------------------------------------------- Resolution|--- |FIXED CC| |z.tajoli at cineca.it Status|Pushed to Stable |RESOLVED -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon May 15 12:10:28 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 15 May 2017 10:10:28 +0000 Subject: [Koha-bugs] [Bug 17914] The installer process tries to create borrowers.updated_on twice In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17914 Bug 17914 depends on bug 17234, which changed state. Bug 17234 Summary: ALTER IGNORE TABLE is invalid in mysql 5.7. This breaks updatedatabase.pl https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17234 What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to Stable |RESOLVED Resolution|--- |FIXED -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon May 15 12:10:29 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 15 May 2017 10:10:29 +0000 Subject: [Koha-bugs] [Bug 17762] Ability to translate notices In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17762 Bug 17762 depends on bug 17234, which changed state. Bug 17234 Summary: ALTER IGNORE TABLE is invalid in mysql 5.7. This breaks updatedatabase.pl https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17234 What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to Stable |RESOLVED Resolution|--- |FIXED -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon May 15 12:10:29 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 15 May 2017 10:10:29 +0000 Subject: [Koha-bugs] [Bug 14187] branchtransfer needs a primary key (id) for DBIx and common sense. In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14187 Bug 14187 depends on bug 17234, which changed state. Bug 17234 Summary: ALTER IGNORE TABLE is invalid in mysql 5.7. This breaks updatedatabase.pl https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17234 What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to Stable |RESOLVED Resolution|--- |FIXED -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon May 15 12:10:28 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 15 May 2017 10:10:28 +0000 Subject: [Koha-bugs] [Bug 17356] Add atomic update .perl skeleton file In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17356 Bug 17356 depends on bug 17234, which changed state. Bug 17234 Summary: ALTER IGNORE TABLE is invalid in mysql 5.7. This breaks updatedatabase.pl https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17234 What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to Stable |RESOLVED Resolution|--- |FIXED -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon May 15 12:10:27 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 15 May 2017 10:10:27 +0000 Subject: [Koha-bugs] [Bug 17258] [OMIBUS] MySQL 5.7 In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17258 Bug 17258 depends on bug 17234, which changed state. Bug 17234 Summary: ALTER IGNORE TABLE is invalid in mysql 5.7. This breaks updatedatabase.pl https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17234 What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to Stable |RESOLVED Resolution|--- |FIXED -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon May 15 12:10:30 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 15 May 2017 10:10:30 +0000 Subject: [Koha-bugs] [Bug 17813] Table borrower_attributes needs a primary key In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17813 Bug 17813 depends on bug 17234, which changed state. Bug 17234 Summary: ALTER IGNORE TABLE is invalid in mysql 5.7. This breaks updatedatabase.pl https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17234 What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to Stable |RESOLVED Resolution|--- |FIXED -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon May 15 12:13:41 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 15 May 2017 10:13:41 +0000 Subject: [Koha-bugs] [Bug 17260] updatedatabase.pl fails on invalid entries in ENUM and BOOLEAN columns In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17260 Zeno Tajoli changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to Stable |RESOLVED Resolution|--- |FIXED CC| |z.tajoli at cineca.it -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon May 15 12:13:42 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 15 May 2017 10:13:42 +0000 Subject: [Koha-bugs] [Bug 17258] [OMIBUS] MySQL 5.7 In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17258 Bug 17258 depends on bug 17260, which changed state. Bug 17260 Summary: updatedatabase.pl fails on invalid entries in ENUM and BOOLEAN columns https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17260 What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to Stable |RESOLVED Resolution|--- |FIXED -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon May 15 12:14:34 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 15 May 2017 10:14:34 +0000 Subject: [Koha-bugs] [Bug 17324] branchcode is NULL in letter triggers red upgrade message In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17324 Zeno Tajoli changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |z.tajoli at cineca.it Status|Pushed to Stable |RESOLVED Resolution|--- |FIXED -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon May 15 12:14:34 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 15 May 2017 10:14:34 +0000 Subject: [Koha-bugs] [Bug 17258] [OMIBUS] MySQL 5.7 In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17258 Bug 17258 depends on bug 17324, which changed state. Bug 17324 Summary: branchcode is NULL in letter triggers red upgrade message https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17324 What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to Stable |RESOLVED Resolution|--- |FIXED -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon May 15 12:16:33 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 15 May 2017 10:16:33 +0000 Subject: [Koha-bugs] [Bug 18389] bulkmarcimport.pl does not take notice of MARC modification templates In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18389 --- Comment #5 from Jon Knight --- Oh, and thanks for the advice Katrin - I'm still getting to grips with Koha and git (been an RCS/SVN user for years!). -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon May 15 12:17:09 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 15 May 2017 10:17:09 +0000 Subject: [Koha-bugs] [Bug 17323] MySQL 5.7 - Column search_history.time cannot be null In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17323 Zeno Tajoli changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |z.tajoli at cineca.it Status|Pushed to Master |RESOLVED Resolution|--- |FIXED -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon May 15 12:17:10 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 15 May 2017 10:17:10 +0000 Subject: [Koha-bugs] [Bug 17258] [OMIBUS] MySQL 5.7 In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17258 Bug 17258 depends on bug 17323, which changed state. Bug 17323 Summary: MySQL 5.7 - Column search_history.time cannot be null https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17323 What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to Master |RESOLVED Resolution|--- |FIXED -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon May 15 12:40:09 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 15 May 2017 10:40:09 +0000 Subject: [Koha-bugs] [Bug 17505] REST API: Add route for messaging preferences In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17505 --- Comment #4 from Lari Taskula --- (In reply to Jiri Kozlovsky from comment #3) > (In reply to Lari Taskula from comment #2) > > Hey. Any update on this? I will start working on it if you haven't already. > > I attached Koha-objects to Bug 17499 which could be useful for this one. > > Hey there Lari. Yes, I've already done some work, but now I'm going to be > away from work on Koha until I finish final school exams for bachelor's > degree. > > If you want, you can take a look at the work & finish it ;) All the work is > in this single commit: > https://github.com/open-source-knihovna/KohaCZ/commit/ > 7bddf4f709fce467296ddce814b4612aeaa00088 > > Basically I made it work for GET request. Feel free to change my coding > style as you wish :D Cheers! It looks awesome! I will integrate your work with mine, and attach a patch here. Good luck with your exams! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon May 15 13:47:39 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 15 May 2017 11:47:39 +0000 Subject: [Koha-bugs] [Bug 18606] New: Move rotating collections code to Koha::Object Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18606 Bug ID: 18606 Summary: Move rotating collections code to Koha::Object Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Architecture, internals, and plumbing Assignee: gmcharlt at gmail.com Reporter: josef.moravec at gmail.com QA Contact: testopia at bugs.koha-community.org -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon May 15 13:48:03 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 15 May 2017 11:48:03 +0000 Subject: [Koha-bugs] [Bug 18606] Move rotating collections code to Koha::Object In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18606 Josef Moravec changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|gmcharlt at gmail.com |josef.moravec at gmail.com Blocks| |15449 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15449 [Bug 15449] Move stuffs to the Koha namespace -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon May 15 13:48:03 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 15 May 2017 11:48:03 +0000 Subject: [Koha-bugs] [Bug 15449] Move stuffs to the Koha namespace In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15449 Josef Moravec changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on| |18606 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18606 [Bug 18606] Move rotating collections code to Koha::Object -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon May 15 13:48:17 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 15 May 2017 11:48:17 +0000 Subject: [Koha-bugs] [Bug 18606] Move rotating collections code to Koha::Object In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18606 Josef Moravec changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |ASSIGNED -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon May 15 14:04:02 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 15 May 2017 12:04:02 +0000 Subject: [Koha-bugs] [Bug 18603] team PhoNE number, QuickBooks help number-QuickBooks Number; QuickBooks help PhoNE number, QuickBooks Number, QuickBooks Tech SuPpoRT Toll freeNumber, QuickBooks SuPpoRT TELEPhoNE Number, QuickBooks Tech SuPpoRT TELEPhoNE number, QuickBooks Tech SuPpoRT n In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18603 Owen Leonard changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |RESOLVED Resolution|--- |INVALID -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon May 15 14:04:19 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 15 May 2017 12:04:19 +0000 Subject: [Koha-bugs] [Bug 18603] SPAM In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18603 Owen Leonard changed: What |Removed |Added ---------------------------------------------------------------------------- Summary|team PhoNE number, |SPAM |QuickBooks help | |number-QuickBooks Number; | |QuickBooks help PhoNE | |number, QuickBooks Number, | |QuickBooks Tech SuPpoRT | |Toll freeNumber, QuickBooks | |SuPpoRT TELEPhoNE Number, | |QuickBooks Tech SuPpoRT | |TELEPhoNE number, | |QuickBooks Tech SuPpoRT n | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon May 15 14:05:07 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 15 May 2017 12:05:07 +0000 Subject: [Koha-bugs] [Bug 18604] SPAM In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18604 Owen Leonard changed: What |Removed |Added ---------------------------------------------------------------------------- Summary|24/7 SuPpoRT PhoNE |SPAM |number,quickbooks TELEPhoNE | |number Quickbooks Customer | |Service Helpline?? | Status|NEW |RESOLVED Resolution|--- |INVALID -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon May 15 15:02:59 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 15 May 2017 13:02:59 +0000 Subject: [Koha-bugs] [Bug 18434] Elasticsearch indexing broken with newer catmandu version In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18434 Tom?s Cohen Arazi changed: What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon May 15 15:03:07 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 15 May 2017 13:03:07 +0000 Subject: [Koha-bugs] [Bug 18434] Elasticsearch indexing broken with newer catmandu version In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18434 Tom?s Cohen Arazi changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon May 15 15:07:34 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 15 May 2017 13:07:34 +0000 Subject: [Koha-bugs] [Bug 7317] Add an Interlibrary Loan Module to Circulation and OPAC In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7317 --- Comment #49 from Magnus Enger --- +sub available_backends { + my ( $self ) = @_; + my $backend_dir = $self->_config->backend_dir; + my @backends = (); + my @backends = <$backend_dir/*> if ( $backend_dir ); + my @backends = map { basename($_) } @backends; + return \@backends; +} This gives a warning: "my" variable @backends masks earlier declaration in same scope at /path/to/Koha/Illrequest.pm line 375. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon May 15 15:12:03 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 15 May 2017 13:12:03 +0000 Subject: [Koha-bugs] [Bug 18356] Prediction pattern wrong, skips years, for some year based frequencies In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18356 --- Comment #2 from Marcel de Rooy --- Created attachment 63470 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=63470&action=edit Bug 18356: Extend GetNextDate.t, add GetFictiveIssueNumber.t (unit=year) This patch deals with tests for yearly frequencies. Adjust/extend GetNextDate.t: [1] Adjust mixup of units/issues in a description. [2] Add testing +2 years on 29-2 of leap year for freq 1 issue/2 years. [3] Add tests for freq 9 issues/year. We also include testing the operation of rounding dates to first acquisition day and month when close enough. Add GetFictiveIssueNumber.t: [1] Two subtests are provided for irregular frequencies (very trivial) and for year frequencies (with three specific test cases). Test plan: [1] Run t/db_dependent/Serials/GetNextDate.t [2] Run t/db_dependent/Serials/GetFictiveIssueNumber.t Note: Without the second patch both tests should fail. This shows the need of the adjustments in the second patch. Signed-off-by: Marcel de Rooy -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon May 15 15:12:08 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 15 May 2017 13:12:08 +0000 Subject: [Koha-bugs] [Bug 18356] Prediction pattern wrong, skips years, for some year based frequencies In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18356 --- Comment #3 from Marcel de Rooy --- Created attachment 63471 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=63471&action=edit Bug 18356: Fix date calculations for yearly frequencies in Serials The problem as described on BZ 18356 is a combination of an error in GetFictiveIssueNumber and GetNextDate for unit==year. In GetFictiveIssueNumber the year should be decreased by one if you have more units per year and you did not yet reach firstacqui day and month. This affects calculations in GetNextDate with irregularities. In GetNextDate the Add_Delta_YM calculation should be applied only to frequencies based on years per unit. In the case of multiple units per year we calculate the number of days to add. And if we have reached the end of a year cycle, we 'round' up to firstacqui day and month as long as we are close enough. Otherwise we just add the number of calculated days, since we can safely assume that the publish dates have been adjusted manually. Test plan: [1] Verify that both GetNextDate.t as well as GetFictiveIssueNumber.t pass. [2] Look at the prediction pattern for a few frequencies. For example: 1 iss/y, 1 iss/2y, 5 iss/y. Signed-off-by: Marcel de Rooy -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon May 15 15:12:51 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 15 May 2017 13:12:51 +0000 Subject: [Koha-bugs] [Bug 18356] Prediction pattern wrong, skips years, for some year based frequencies In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18356 Marcel de Rooy changed: What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |Needs Signoff Patch complexity|--- |Small patch -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon May 15 15:27:44 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 15 May 2017 13:27:44 +0000 Subject: [Koha-bugs] [Bug 18607] New: Fix date calculations for monthly frequencies in Serials Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18607 Bug ID: 18607 Summary: Fix date calculations for monthly frequencies in Serials Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: normal Priority: P5 - low Component: Serials Assignee: koha-bugs at lists.koha-community.org Reporter: m.de.rooy at rijksmuseum.nl QA Contact: testopia at bugs.koha-community.org CC: colin.campbell at ptfs-europe.com Similar to bug 18356 -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon May 15 15:28:11 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 15 May 2017 13:28:11 +0000 Subject: [Koha-bugs] [Bug 18607] Fix date calculations for monthly frequencies in Serials In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18607 Marcel de Rooy changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on| |18356 CC| |nick at bywatersolutions.com Status|NEW |ASSIGNED Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18356 [Bug 18356] Prediction pattern wrong, skips years, for some year based frequencies -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon May 15 15:28:11 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 15 May 2017 13:28:11 +0000 Subject: [Koha-bugs] [Bug 18356] Prediction pattern wrong, skips years, for some year based frequencies In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18356 Marcel de Rooy changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |18607 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18607 [Bug 18607] Fix date calculations for monthly frequencies in Serials -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon May 15 15:32:28 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 15 May 2017 13:32:28 +0000 Subject: [Koha-bugs] [Bug 7317] Add an Interlibrary Loan Module to Circulation and OPAC In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7317 --- Comment #50 from Alex Sassmannshausen --- Created attachment 63472 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=63472&action=edit Bug 7317: Bugfix: remove `my` statements. * Koha/Illrequest.pm (available_backends): Remove incorrect `my` statements for @backends variable. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon May 15 15:33:44 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 15 May 2017 13:33:44 +0000 Subject: [Koha-bugs] [Bug 7317] Add an Interlibrary Loan Module to Circulation and OPAC In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7317 --- Comment #51 from Alex Sassmannshausen --- (In reply to Magnus Enger from comment #49) > +sub available_backends { > + my ( $self ) = @_; > + my $backend_dir = $self->_config->backend_dir; > + my @backends = (); > + my @backends = <$backend_dir/*> if ( $backend_dir ); > + my @backends = map { basename($_) } @backends; > + return \@backends; > +} > > This gives a warning: "my" variable @backends masks earlier declaration in > same scope at /path/to/Koha/Illrequest.pm line 375. Thanks for the report, should be fixed with the latest patch! Alex -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon May 15 15:41:06 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 15 May 2017 13:41:06 +0000 Subject: [Koha-bugs] [Bug 18434] Elasticsearch indexing broken with newer catmandu version In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18434 Nick Clemens changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon May 15 15:41:09 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 15 May 2017 13:41:09 +0000 Subject: [Koha-bugs] [Bug 18434] Elasticsearch indexing broken with newer catmandu version In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18434 Nick Clemens changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #63451|0 |1 is obsolete| | --- Comment #10 from Nick Clemens --- Created attachment 63473 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=63473&action=edit Bug 18434: Add tests for K:SE:E::get_fixer_rules This patch tries to introduce exhaustive tests for this class method. I didn't try to provide a regression test for the current bug per-se, but cover the current method behaviour as much as I could. (kidclamp) I added a quick test of _convert_marc_to_json to use the mocking here and illuminate what the change does, before the patches this should fail (fields are indexed in place of one another), after it should succeed (new indexed fields are appended). A minor bug is highlighted by this new tests, I'll provide a followup for it. To test: - Run: $ sudo koha-shell kohadev k$ de kohaclone k$ prove t/db_dependent/Koha_Elasticsearch.t => FAIL: The returned fixer rules are not the expected ones Signed-off-by: Tomas Cohen Arazi -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon May 15 15:43:20 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 15 May 2017 13:43:20 +0000 Subject: [Koha-bugs] [Bug 18228] Make list permissions easier to use/understand In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18228 --- Comment #30 from Jonathan Druart --- Nothing, but I would wait for the next release to push. Feature freeze is passed anyway. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon May 15 15:46:25 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 15 May 2017 13:46:25 +0000 Subject: [Koha-bugs] [Bug 17015] New Koha Calendar In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17015 Kyle M Hall changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |kyle at bywatersolutions.com -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon May 15 15:50:04 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 15 May 2017 13:50:04 +0000 Subject: [Koha-bugs] [Bug 18264] Course reserves - use itemnumber for editing existing reserve items In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18264 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on| |17974 --- Comment #18 from Jonathan Druart --- (In reply to Katrin Fischer from comment #17) > Tried to backport these patches, but with the patches applied, I have an > error under Plack when adding an item to a course by barcode: > The method biblio is not covered by tests! Koha::Item->biblio is added by bug 17974. Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17974 [Bug 17974] Add the Koha::Item->biblio method -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon May 15 15:50:04 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 15 May 2017 13:50:04 +0000 Subject: [Koha-bugs] [Bug 17974] Add the Koha::Item->biblio method In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17974 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |18264 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18264 [Bug 18264] Course reserves - use itemnumber for editing existing reserve items -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon May 15 15:53:34 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 15 May 2017 13:53:34 +0000 Subject: [Koha-bugs] [Bug 18228] Make list permissions easier to use/understand In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18228 --- Comment #31 from Jonathan Druart --- Created attachment 63474 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=63474&action=edit Bug 18228: Add missing comma in kohastructure.sql -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon May 15 16:13:51 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 15 May 2017 14:13:51 +0000 Subject: [Koha-bugs] [Bug 7317] Add an Interlibrary Loan Module to Circulation and OPAC In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7317 Alex Sassmannshausen changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #63472|0 |1 is obsolete| | --- Comment #52 from Alex Sassmannshausen --- Created attachment 63475 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=63475&action=edit Bug 7317: Bugfix: remove `my` statements & dereference. * Koha/Illrequest.pm (available_backends): Remove incorrect `my` statements for @backends variable. (custom_capability): Explicitly dereference `$self->capabilities`. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon May 15 16:17:29 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 15 May 2017 14:17:29 +0000 Subject: [Koha-bugs] [Bug 18608] New: Quickbooks Error (1-844-777-4237) Quickbooks Errorr & help live-Error Quickbooks Errorr H505.H101.H202.H303 Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18608 Bug ID: 18608 Summary: Quickbooks Error (1-844-777-4237) Quickbooks Errorr & help live-Error Quickbooks Errorr H505.H101.H202.H303 Change sponsored?: --- Product: Koha Version: unspecified Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Architecture, internals, and plumbing Assignee: gmcharlt at gmail.com Reporter: ginahagharmita at yopmail.com QA Contact: testopia at bugs.koha-community.org Quickbooks Error (1-844-777-4237) Quickbooks Errorr & help live-Error Quickbooks Errorr H505.H101.H202.H303 Quickbooks Error (1-844-777-4237) Quickbooks Errorr & help live-Error Quickbooks Errorr H505.H101.H202.H303 Quickbooks Error (1-844-777-4237)// Quickbooks Errorr.H505.H101.H202.H303 Quickbooks Error (1-844-777-4237)// Quickbooks ErrorrH505.H101.H202.H303. Quickbooks Error (1-844-777-4237)// Quickbooks ErrorrH505.H101.H202.H303. Quickbooks Error (1-844-777-4237)// Quickbooks ErrorrH505.H101.H202.H303. Quickbooks Error (1-844-777-4237)// Quickbooks ErrorrH505.H101.H202.H303. Quickbooks Error (1-844-777-4237)// Quickbooks ErrorrH505.H101.H202.H303. Quickbooks Error (1-844-777-4237)// Quickbooks ErrorrH505.H101.H202.H303. Quickbooks Error (1-844-777-4237)// Quickbooks ErrorrH505.H101.H202.H303. Quickbooks Error (1-844-777-4237)// Quickbooks ErrorrH505.H101.H202.H303. Quickbooks Error (1-844-777-4237)// Quickbooks ErrorrH505.H101.H202.H303. Quickbooks Error (1-844-777-4237)// Quickbooks ErrorrH505.H101.H202.H303. Quickbooks Error (1-844-777-4237)// Quickbooks ErrorrH505.H101.H202.H303. Quickbooks Error (1-844-777-4237)// Quickbooks ErrorrH505.H101.H202.H303. Quickbooks Error (1-844-777-4237)// Quickbooks ErrorrH505.H101.H202.H303. Quickbooks Error (1-844-777-4237)// Quickbooks ErrorrH505.H101.H202.H303. Quickbooks Error (1-844-777-4237)// Quickbooks ErrorrH505.H101.H202.H303. Quickbooks Error (1-844-777-4237)// Quickbooks ErrorrH505.H101.H202.H303. Quickbooks Error (1-844-777-4237)// Quickbooks ErrorrH505.H101.H202.H303. Quickbooks Error (1-844-777-4237)// Quickbooks ErrorrH505.H101.H202.H303. Quickbooks Error (1-844-777-4237)// Quickbooks ErrorrH505.H101.H202.H303. Quickbooks Error (1-844-777-4237)// Quickbooks ErrorrH505.H101.H202.H303. Quickbooks Error (1-844-777-4237)// Quickbooks ErrorrH505.H101.H202.H303. Quickbooks Error (1-844-777-4237)// Quickbooks ErrorrH505.H101.H202.H303. Quickbooks Error (1-844-777-4237)// Quickbooks ErrorrH505.H101.H202.H303. Quickbooks Error (1-844-777-4237)// Quickbooks ErrorrH505.H101.H202.H303. Quickbooks Error (1-844-777-4237)// Quickbooks ErrorrH505.H101.H202.H303. Quickbooks Error (1-844-777-4237)// Quickbooks ErrorrH505.H101.H202.H303. Quickbooks Error (1-844-777-4237)// Quickbooks ErrorrH505.H101.H202.H303. Quickbooks Error (1-844-777-4237)// Quickbooks ErrorrH505.H101.H202.H303. https://www.eventbrite.com/e/1-844-777-4237-quickbooks-error-help-live-247-quickbooks-errorh505h101h202h303-tickets-34622238046 http://quickbookssupportphonenumber2569.blogspot.com/2017/05/1-844-777-4237-quickbooks-error-help.html https://kdp.amazon.com/community/thread.jspa?threadID=682393 https://atttechemailsupportnumberblog.wordpress.com/2017/05/15/1-844-777-4237-quickbooks-error-help-live-247-quickbooks-error-h505/ https://www.eventbrite.com/e/1-844-777-4237-quickbooks-error-help-live-support-quickbooks-errorh505h101h202h303-tickets-34622482778 https://kdp.amazon.com/community/thread.jspa?threadID=682396 http://quickbookssupportphonenumber2569.blogspot.com/2017/05/1-844-777-4237-quickbooks-error-help_15.html https://atttechemailsupportnumberblog.wordpress.com/2017/05/15/1-844-777-4237-quickbooks-error-help-live-support-quickbooks-error-h505/ https://www.eventbrite.com/e/quickbooks-error-1-844-777-4237-quickbooks-errorr-help-live-error-quickbooks-errorr-h505h101h202h303-tickets-34622971239 https://kdp.amazon.com/community/thread.jspa?threadID=682524 http://quickbookssupportphonenumber2569.blogspot.com/2017/05/quickbooks-error-1-844-777-4237.html https://atttechemailsupportnumberblog.wordpress.com/2017/05/15/quickbooks-error-1-844-777-4237-quickbooks-errorr-help-live-error-quick/ https://bugs.contribs.org/show_bug.cgi?id=10302 Quickbooks Error (1-844-777-4237) Quickbooks Errorr & help live-Error Quickbooks Errorr H505.H101.H202.H303 Quickbooks Error (1-844-777-4237) Quickbooks Errorr & help live-Error Quickbooks Errorr H505.H101.H202.H303 Quickbooks Error (1-844-777-4237)// Quickbooks Errorr.H505.H101.H202.H303 Quickbooks Error (1-844-777-4237)// Quickbooks ErrorrH505.H101.H202.H303. Quickbooks Error (1-844-777-4237)// Quickbooks ErrorrH505.H101.H202.H303. Quickbooks Error (1-844-777-4237)// Quickbooks ErrorrH505.H101.H202.H303. Quickbooks Error (1-844-777-4237)// Quickbooks ErrorrH505.H101.H202.H303. Quickbooks Error (1-844-777-4237)// Quickbooks ErrorrH505.H101.H202.H303. Quickbooks Error (1-844-777-4237)// Quickbooks ErrorrH505.H101.H202.H303. Quickbooks Error (1-844-777-4237)// Quickbooks ErrorrH505.H101.H202.H303. Quickbooks Error (1-844-777-4237)// Quickbooks ErrorrH505.H101.H202.H303. Quickbooks Error (1-844-777-4237)// Quickbooks ErrorrH505.H101.H202.H303. Quickbooks Error (1-844-777-4237)// Quickbooks ErrorrH505.H101.H202.H303. Quickbooks Error (1-844-777-4237)// Quickbooks ErrorrH505.H101.H202.H303. Quickbooks Error (1-844-777-4237)// Quickbooks ErrorrH505.H101.H202.H303. Quickbooks Error (1-844-777-4237)// Quickbooks ErrorrH505.H101.H202.H303. Quickbooks Error (1-844-777-4237)// Quickbooks ErrorrH505.H101.H202.H303. Quickbooks Error (1-844-777-4237)// Quickbooks ErrorrH505.H101.H202.H303. Quickbooks Error (1-844-777-4237)// Quickbooks ErrorrH505.H101.H202.H303. Quickbooks Error (1-844-777-4237)// Quickbooks ErrorrH505.H101.H202.H303. Quickbooks Error (1-844-777-4237)// Quickbooks ErrorrH505.H101.H202.H303. Quickbooks Error (1-844-777-4237)// Quickbooks ErrorrH505.H101.H202.H303. Quickbooks Error (1-844-777-4237)// Quickbooks ErrorrH505.H101.H202.H303. Quickbooks Error (1-844-777-4237)// Quickbooks ErrorrH505.H101.H202.H303. Quickbooks Error (1-844-777-4237)// Quickbooks ErrorrH505.H101.H202.H303. Quickbooks Error (1-844-777-4237)// Quickbooks ErrorrH505.H101.H202.H303. Quickbooks Error (1-844-777-4237)// Quickbooks ErrorrH505.H101.H202.H303. Quickbooks Error (1-844-777-4237)// Quickbooks ErrorrH505.H101.H202.H303. Quickbooks Error (1-844-777-4237)// Quickbooks ErrorrH505.H101.H202.H303. Quickbooks Error (1-844-777-4237)// Quickbooks ErrorrH505.H101.H202.H303. Quickbooks Error (1-844-777-4237)// Quickbooks ErrorrH505.H101.H202.H303. https://www.eventbrite.com/e/1-844-777-4237-quickbooks-error-help-live-247-quickbooks-errorh505h101h202h303-tickets-34622238046 http://quickbookssupportphonenumber2569.blogspot.com/2017/05/1-844-777-4237-quickbooks-error-help.html https://kdp.amazon.com/community/thread.jspa?threadID=682393 https://atttechemailsupportnumberblog.wordpress.com/2017/05/15/1-844-777-4237-quickbooks-error-help-live-247-quickbooks-error-h505/ https://www.eventbrite.com/e/1-844-777-4237-quickbooks-error-help-live-support-quickbooks-errorh505h101h202h303-tickets-34622482778 https://kdp.amazon.com/community/thread.jspa?threadID=682396 http://quickbookssupportphonenumber2569.blogspot.com/2017/05/1-844-777-4237-quickbooks-error-help_15.html https://atttechemailsupportnumberblog.wordpress.com/2017/05/15/1-844-777-4237-quickbooks-error-help-live-support-quickbooks-error-h505/ https://www.eventbrite.com/e/quickbooks-error-1-844-777-4237-quickbooks-errorr-help-live-error-quickbooks-errorr-h505h101h202h303-tickets-34622971239 https://kdp.amazon.com/community/thread.jspa?threadID=682524 http://quickbookssupportphonenumber2569.blogspot.com/2017/05/quickbooks-error-1-844-777-4237.html https://atttechemailsupportnumberblog.wordpress.com/2017/05/15/quickbooks-error-1-844-777-4237-quickbooks-errorr-help-live-error-quick/ https://bugs.contribs.org/show_bug.cgi?id=10302 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon May 15 16:25:36 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 15 May 2017 14:25:36 +0000 Subject: [Koha-bugs] [Bug 17047] Mana Knowledge Base : share data In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17047 Baptiste changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #62607|0 |1 is obsolete| | --- Comment #71 from Baptiste --- Created attachment 63476 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=63476&action=edit Bug 17047 security token agst flooding for Mana-KB Rework messages from Mana-KB. - Add A syspref contains an authentication token. The token will be used to prevent anaonymous flooding of Mana-KB - To get an Authentication token, you have to fill a form and validate your e-mail address - Messages return codes are now correctly displayed and there shouldn't be any crash when Mana-KB webservices return a wrong answer or doesn't answer Test plan: 1 - Apply Patch + update database 2 - Copy the three lines about mana config in etc/koha-conf.xml in ../etc/koha-conf.xml (after for example) https://mana-kb.koha-community.org 3 - Check Mana syspref and AutoShareWithMana syspref are not activated 4 - Search the syspref ManaToken and follow the instructions 5 - subscriptions - Try create a new subscription for a first serial => Mana-KB shouldn't show you anything (except if the base hase been filled) - Share this serial with Mana-KB (on the serial individual's page there must be a Share button) - Try to create a new subscription for serial nr1 => a message should appear when you click on "next", click on "use", the fields should automaticaly appear - Activate AutoShareWithMana => Subscriptions - Create a new subscription for a second serial - There shouldn't be any Share button - Create a second subscription => the message should appear, click again on use 6 - SQL Report - Create a new SQL report, without notes. - On the table with all report (reports > use saved), there should be the action "Share" - If you click on share, you have an error message - Create a new report, with a title and notes longer than 20 characters - You can share it with mana => you will have a success message - On (report > use saved), there must be a message inviting you to search on Mana-KB for more results, enter a few word from title, notes, type of the report you shared, it should appear. You can use it, it will load it into your report list. 7 - Report mistakes. - On any table containing Mana-KB search results, you can report a mistake and add a comment. 8 - For each previous test, try to send wrong data, to delete the security token, to send nothing: it should show a correct warning message. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon May 15 16:32:31 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 15 May 2017 14:32:31 +0000 Subject: [Koha-bugs] [Bug 18434] Elasticsearch indexing broken with newer catmandu version In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18434 Tom?s Cohen Arazi changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #63473|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon May 15 16:32:34 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 15 May 2017 14:32:34 +0000 Subject: [Koha-bugs] [Bug 18434] Elasticsearch indexing broken with newer catmandu version In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18434 Tom?s Cohen Arazi changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #63452|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon May 15 16:32:37 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 15 May 2017 14:32:37 +0000 Subject: [Koha-bugs] [Bug 18434] Elasticsearch indexing broken with newer catmandu version In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18434 Tom?s Cohen Arazi changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #63453|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon May 15 16:33:19 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 15 May 2017 14:33:19 +0000 Subject: [Koha-bugs] [Bug 18434] Elasticsearch indexing broken with newer catmandu version In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18434 --- Comment #11 from Tom?s Cohen Arazi --- Created attachment 63477 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=63477&action=edit Bug 18434: Add tests for K:SE:E::get_fixer_rules This patch tries to introduce exhaustive tests for this class method. I didn't try to provide a regression test for the current bug per-se, but cover the current method behaviour as much as I could. (kidclamp) I added a quick test of _convert_marc_to_json to use the mocking here and illuminate what the change does, before the patches this should fail (fields are indexed in place of one another), after it should succeed (new indexed fields are appended). A minor bug is highlighted by this new tests, I'll provide a followup for it. To test: - Run: $ sudo koha-shell kohadev k$ de kohaclone k$ prove t/db_dependent/Koha_Elasticsearch.t => FAIL: The returned fixer rules are not the expected ones Signed-off-by: Tomas Cohen Arazi -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon May 15 16:33:23 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 15 May 2017 14:33:23 +0000 Subject: [Koha-bugs] [Bug 18434] Elasticsearch indexing broken with newer catmandu version In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18434 --- Comment #12 from Tom?s Cohen Arazi --- Created attachment 63478 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=63478&action=edit Bug 18434: Elasticsearch indexing broken with newer catmandu version To test: 1 - Make sure you have latest koha deps, catmandu versions should be: libcatmandu-marc-perl 1.09-1~kohadev1 libcatmandu-perl 1.0304-2~kohadev1 2 - Reindex elastic 3 - Try searching and likely notice odd results 4 - Try: curl -XGET 'http://localhost:9200/koha_kohadev_biblios/data/792?pretty=true' with a known biblionumber and notice some null fields 5 - Apply patch 6 - Reindex 7 - Note fields are populated and search works as expected Signed-off-by: Chris Cormack Signed-off-by: Tomas Cohen Arazi -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon May 15 16:33:53 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 15 May 2017 14:33:53 +0000 Subject: [Koha-bugs] [Bug 18434] Elasticsearch indexing broken with newer catmandu version In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18434 Tom?s Cohen Arazi changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon May 15 16:40:28 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 15 May 2017 14:40:28 +0000 Subject: [Koha-bugs] [Bug 18609] New: Make attachement of MARC records for list/ cart email optional Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18609 Bug ID: 18609 Summary: Make attachement of MARC records for list/cart email optional Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: normal Priority: P5 - low Component: OPAC Assignee: oleonard at myacpl.org Reporter: katrin.fischer at bsz-bw.de QA Contact: testopia at bugs.koha-community.org We just had a library reporting that a cart email was denied by a mail server because of the attachement. I think in the current situation we can expect mail servers to get even more critical. I propose that we make sending the attachement optional, maybe with a checkbox on the send cart/list form to avoid these problems. The checkbox could then be hidden with CSS for libraries that experience more problems with this. Alternatively we could also discuss generally removing the attachemeht, as we also offer the option to download in MARC format or a system preference to select the default behaviour. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon May 15 16:47:25 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 15 May 2017 14:47:25 +0000 Subject: [Koha-bugs] [Bug 18434] Elasticsearch indexing broken with newer catmandu version In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18434 --- Comment #13 from Tom?s Cohen Arazi --- Created attachment 63479 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=63479&action=edit Bug 18434: (QA followup) Move _convert_marc_to_json tests into Indexer.t Signed-off-by: Tomas Cohen Arazi -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon May 15 16:48:51 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 15 May 2017 14:48:51 +0000 Subject: [Koha-bugs] [Bug 18610] New: ElasticSearch indexing of facets needs to be updated for newer Catmandu versions Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18610 Bug ID: 18610 Summary: ElasticSearch indexing of facets needs to be updated for newer Catmandu versions Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: major Priority: P5 - low Component: Searching Assignee: gmcharlt at gmail.com Reporter: nick at bywatersolutions.com QA Contact: testopia at bugs.koha-community.org This is analogous to the problem on bug 18434 - in newer versions multiple mappings overwrite each other if not set to append. Bug 18434 takes care of main headings, facets need the same treatment and testing -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon May 15 16:49:02 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 15 May 2017 14:49:02 +0000 Subject: [Koha-bugs] [Bug 18610] ElasticSearch indexing of facets needs to be updated for newer Catmandu versions In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18610 Nick Clemens changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on| |18434 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18434 [Bug 18434] Elasticsearch indexing broken with newer catmandu version -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon May 15 16:49:02 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 15 May 2017 14:49:02 +0000 Subject: [Koha-bugs] [Bug 18434] Elasticsearch indexing broken with newer catmandu version In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18434 Nick Clemens changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |18610 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18610 [Bug 18610] ElasticSearch indexing of facets needs to be updated for newer Catmandu versions -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon May 15 17:08:59 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 15 May 2017 15:08:59 +0000 Subject: [Koha-bugs] [Bug 18551] Hide with CSS dynamic elements in member search In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18551 Philippe Audet-Fortin changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |philippe.audet-fortin at inlib | |ro.com --- Comment #11 from Philippe Audet-Fortin --- Hi Marc, Can you specify the browser you are using and its version, because I can't reproduce the problem. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon May 15 17:17:08 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 15 May 2017 15:17:08 +0000 Subject: [Koha-bugs] [Bug 18610] ElasticSearch indexing of facets needs to be updated for newer Catmandu versions In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18610 Tom?s Cohen Arazi changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon May 15 17:17:11 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 15 May 2017 15:17:11 +0000 Subject: [Koha-bugs] [Bug 18610] ElasticSearch indexing of facets needs to be updated for newer Catmandu versions In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18610 --- Comment #1 from Tom?s Cohen Arazi --- Created attachment 63480 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=63480&action=edit Bug 18610: regression tests This patch introduces tests fr K::SE::ES::Indexer::_convert_marc_to_json to test the facets that get extracted from the sample record. To test: - Run $ sudo koha-shell kohadev k$ cd kohaclone k$ prove t/db_dependent/Koha_Elasticsearch_Indexer.t \ t/db_dependent/Koha_Elasticsearch.t => FAIL: Test fails because only last field mapped for facetting is considered (overwrite behaviour). Sponsored-by: ByWater Solutions -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon May 15 17:17:21 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 15 May 2017 15:17:21 +0000 Subject: [Koha-bugs] [Bug 18610] ElasticSearch indexing of facets needs to be updated for newer Catmandu versions In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18610 --- Comment #2 from Tom?s Cohen Arazi --- Created attachment 63481 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=63481&action=edit Bug 18610: Make facet indexing append instead of overwrite so it works on newer Catmandu This patch makes get_fixer_rules add the $append string to the facets mapping as we did for bug 18434. To test: - Run: $ sudo koha-shell kohadev k$ cd kohaclone k$ prove t/db_dependent/Koha_Elasticsearch_Indexer.t t/db_dependent/Koha_Elasticsearch.t => FAIL: Tests fail! - Apply this patch - Run: k$ prove t/db_dependent/Koha_Elasticsearch_Indexer.t t/db_dependent/Koha_Elasticsearch.t => SUCCESS: Tests are all green! - Sign off :-D Sponsored-by: ByWater Solutions -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon May 15 17:28:44 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 15 May 2017 15:28:44 +0000 Subject: [Koha-bugs] [Bug 18551] Hide with CSS dynamic elements in member search In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18551 --- Comment #12 from Marc V?ron --- (In reply to Philippe Audet-Fortin from comment #11) > Hi Marc, > > Can you specify the browser you are using and its version, because I can't > reproduce the problem. Firefox 53.0 (Windows) Firefox ESR 45.3.0 (Debian) See following comment as well (slow down with toogle(500): https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18518#c5 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon May 15 17:43:47 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 15 May 2017 15:43:47 +0000 Subject: [Koha-bugs] [Bug 18571] koha-conf.xml should include ES entry In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18571 Nick Clemens changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon May 15 17:43:49 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 15 May 2017 15:43:49 +0000 Subject: [Koha-bugs] [Bug 18571] koha-conf.xml should include ES entry In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18571 Nick Clemens changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #63444|0 |1 is obsolete| | --- Comment #3 from Nick Clemens --- Created attachment 63482 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=63482&action=edit Bug 18571: Add default ES configuration to koha-conf-site.xml.in This patch adds a default configuration entry for elasticsearch. It will add localhost:9200 to the server subsection, and koha_instance (replacing instance for the corresponding instance name) for the namespace. To test: - Apply the patch - Copy the file to the /etc/koha dir: $ sudo cp kohaclone/debian/templates/koha-conf-site.xml.in /etc/koha - Create a new instance: $ sudo koha-create --create-db test => SUCCESS: /etc/koha/sites/test/koha-conf.xml includes the mentioned section: localhost:9200 koha_test - Sign off :-D Note: As the use of ES is syspref driven, this default entry doesn't have any use until ES is installed and SearchEngine set to Elasticsearch. So it doesn't hurt but will help end users test the ES integration. Advanced users will take care of this config entry manually (pointing to external servers/clusters, etc). Signed-off-by: Mirko Tietgen Signed-off-by: Nick Clemens -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon May 15 18:16:53 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 15 May 2017 16:16:53 +0000 Subject: [Koha-bugs] [Bug 16733] More flexible paths in debian scripts (for dev installs) In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16733 --- Comment #44 from Jonathan Druart --- I have fixed the conflict, applied all patches and pushed the branch on my github account, on the branch bug_16733-16.11.x: https://github.com/joubu/Koha/tree/bug_16733-16.11.x -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon May 15 18:37:40 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 15 May 2017 16:37:40 +0000 Subject: [Koha-bugs] [Bug 18611] New: Create labels action fails in manage-marc-import.pl if an item has been deleted from the import batch. Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18611 Bug ID: 18611 Summary: Create labels action fails in manage-marc-import.pl if an item has been deleted from the import batch. Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Label/patron card printing Assignee: cnighswonger at foundations.edu Reporter: barton at bywatersolutions.com QA Contact: testopia at bugs.koha-community.org On the manage marc import screen, clicking Import Batch on a batch containing a deleted item gives the message "Error attempting to create label batch. Please ask your system administrator to check the log for more details.", and creates an empty PDF file. To replicate: 1) Import a marc record including items. 2) Delete one of the items in the batch. 3) In Home ? Tools ? Manage staged MARC records, click '(Create label batch)' on the batch in question. 4) This will show the message "Error attempting to create label batch. Please ask your system administrator to check the log for more details." The logs in /var/log/koha/INSTANCE/intranet-error.log will look like this: 123456 [Mon May 15 11:14:21.848772 2017] [cgi:error] [pid 15635] [client a.b.c.d:xxxxx] AH01215: [Mon May 15 11:14:21 2017] manage-marc-import.pl: DBD::mysql::st execute failed: Cannot add or update a child row: a foreign key constraint fails (`koha_xyzzy`.`creator_batches`, CONSTRAINT `creator_batches_ibfk_3` FOREIGN KEY (`item_number`) REFERENCES `items` (`itemnumber`) ON DELETE CASCADE) [for Statement "INSERT INTO creator_batches (batch_id, item_number, branch_code, creator) VALUES (?,?,?,?);" with ParamValues: 0=164, 1=123456, 2="APL", 3='Labels'] at /usr/share/koha/lib/C4/Creators/Batch.pm line 69., referer: http://asdfsadf... [Mon May 15 11:14:21.849012 2017] [cgi:error] [pid 15635] [client a.b.c.d:xxxxx] AH01215: [Mon May 15 11:14:21 2017] manage-marc-import.pl: Database returned the following error on attempted INSERT: Cannot add or update a child row: a foreign key constraint fails (`koha_xyzzy`.`creator_batches`, CONSTRAINT `creator_batches_ibfk_3` FOREIGN KEY (`item_number`) REFERENCES `items` (`itemnumber`) ON DELETE CASCADE) at /usr/share/koha/lib/C4/Creators/Batch.pm line 71., referer: http://asdfsadf... [Mon May 15 11:14:21.849147 2017] [cgi:error] [pid 15635] [client a.b.c.d:xxxxx] AH01215: [Mon May 15 11:14:21 2017] manage-marc-import.pl: create_labelbatch_from_importbatch() : Error attempting to add item #123456 of import batch #11048 to label batch. at /usr/share/koha/intranet/cgi-bin/tools/manage-marc-import.pl line 198., referer: http://asdfsadf ... I think we need to have /usr/share/koha/lib/C4/Creators/Batch.pm exclude items where the itemnumber is null. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon May 15 18:38:02 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 15 May 2017 16:38:02 +0000 Subject: [Koha-bugs] [Bug 18611] Create labels action fails in manage-marc-import.pl if an item has been deleted from the import batch. In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18611 Barton Chittenden changed: What |Removed |Added ---------------------------------------------------------------------------- Severity|enhancement |normal -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon May 15 19:08:38 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 15 May 2017 17:08:38 +0000 Subject: [Koha-bugs] [Bug 18611] Create labels action fails in manage-marc-import.pl if an item has been deleted from the import batch. In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18611 --- Comment #1 from Barton Chittenden --- As a work-around, create a report of valid barcodes in a given import batch using the query found here: https://wiki.koha-community.org/wiki/SQL_Reports_Library#Workaround_for_Bug_18611 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon May 15 19:25:39 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 15 May 2017 17:25:39 +0000 Subject: [Koha-bugs] [Bug 18608] SPAM In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18608 Owen Leonard changed: What |Removed |Added ---------------------------------------------------------------------------- Resolution|--- |INVALID Status|NEW |RESOLVED Summary|Quickbooks Error |SPAM |(1-844-777-4237) Quickbooks | |Errorr & help live-Error | |Quickbooks Errorr | |H505.H101.H202.H303 | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon May 15 19:31:35 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 15 May 2017 17:31:35 +0000 Subject: [Koha-bugs] [Bug 18608] SPAM In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18608 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |jonathan.druart at bugs.koha-c | |ommunity.org -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon May 15 19:32:47 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 15 May 2017 17:32:47 +0000 Subject: [Koha-bugs] [Bug 18603] SPAM In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18603 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |jonathan.druart at bugs.koha-c | |ommunity.org -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon May 15 19:33:07 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 15 May 2017 17:33:07 +0000 Subject: [Koha-bugs] [Bug 18604] SPAM In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18604 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |jonathan.druart at bugs.koha-c | |ommunity.org -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Tue May 16 01:56:31 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 15 May 2017 23:56:31 +0000 Subject: [Koha-bugs] [Bug 18612] New: Quick add new patron do not save additional attributes Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18612 Bug ID: 18612 Summary: Quick add new patron do not save additional attributes Change sponsored?: --- Product: Koha Version: 16.11 Hardware: Other OS: Linux Status: NEW Severity: normal Priority: P5 - low Component: Patrons Assignee: koha-bugs at lists.koha-community.org Reporter: sven.halm at shalm.de QA Contact: testopia at bugs.koha-community.org CC: gmcharlt at gmail.com, kyle.m.hall at gmail.com I had created some Patron attribute types (example "Klasse" = "patron_attr_1") and added them to BorrowerMandatoryField and PatronQuickAddFields. If i create a new patron via "Quick add patron", the value is not saved. If i do the same action in full view the value is saved. Test ---- 1. add new category list in authorized values 2. add new Patron attribute type with Authorized value category from 1. 3. Add attributes to system preferences/patrons/BorrowerMandatoryField and PatronQuickAddFields 4. Quick add patron System: Ubuntu 16.04 LTS, koha 16.11, fresh installed system Screenshots ----------- Patron attribute type: http://prntscr.com/f89v3x Authorized Values: http://prntscr.com/f89vgz System preferences: http://prntscr.com/f89w91 Quick add patron: http://prntscr.com/f89wyk New patron after saving quick add: http://prntscr.com/f89xp8 New patron after edit additional attributes or saving via full formular: http://prntscr.com/f89y9p -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue May 16 04:42:56 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 16 May 2017 02:42:56 +0000 Subject: [Koha-bugs] [Bug 18612] Quick add new patron do not save additional attributes In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18612 Nick Clemens changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |nick at bywatersolutions.com Resolution|--- |DUPLICATE Status|NEW |RESOLVED --- Comment #1 from Nick Clemens --- *** This bug has been marked as a duplicate of bug 18597 *** -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Tue May 16 04:42:56 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 16 May 2017 02:42:56 +0000 Subject: [Koha-bugs] [Bug 18597] Quick add form does not transfer patron attributes values when switching forms /saving In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18597 Nick Clemens changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |sven.halm at shalm.de --- Comment #3 from Nick Clemens --- *** Bug 18612 has been marked as a duplicate of this bug. *** -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue May 16 07:57:50 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 16 May 2017 05:57:50 +0000 Subject: [Koha-bugs] [Bug 16733] More flexible paths in debian scripts (for dev installs) In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16733 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Status|RESOLVED |REOPENED Resolution|FIXED |--- --- Comment #45 from Katrin Fischer --- I've merged these patches in from Jonathan's branch, no conflicts this time. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue May 16 07:57:51 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 16 May 2017 05:57:51 +0000 Subject: [Koha-bugs] [Bug 16749] Additional fixes for debian scripts In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16749 Bug 16749 depends on bug 16733, which changed state. Bug 16733 Summary: More flexible paths in debian scripts (for dev installs) https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16733 What |Removed |Added ---------------------------------------------------------------------------- Status|RESOLVED |REOPENED Resolution|FIXED |--- -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue May 16 07:57:51 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 16 May 2017 05:57:51 +0000 Subject: [Koha-bugs] [Bug 17049] Improve PERL5LIB handling for packaged dev install ( follow-up for 16733) In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17049 Bug 17049 depends on bug 16733, which changed state. Bug 16733 Summary: More flexible paths in debian scripts (for dev installs) https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16733 What |Removed |Added ---------------------------------------------------------------------------- Status|RESOLVED |REOPENED Resolution|FIXED |--- -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue May 16 07:57:59 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 16 May 2017 05:57:59 +0000 Subject: [Koha-bugs] [Bug 16733] More flexible paths in debian scripts (for dev installs) In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16733 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Status|REOPENED |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue May 16 07:58:06 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 16 May 2017 05:58:06 +0000 Subject: [Koha-bugs] [Bug 16733] More flexible paths in debian scripts (for dev installs) In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16733 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue May 16 07:58:23 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 16 May 2017 05:58:23 +0000 Subject: [Koha-bugs] [Bug 16733] More flexible paths in debian scripts (for dev installs) In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16733 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue May 16 07:58:30 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 16 May 2017 05:58:30 +0000 Subject: [Koha-bugs] [Bug 16733] More flexible paths in debian scripts (for dev installs) In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16733 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to Stable -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue May 16 07:58:52 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 16 May 2017 05:58:52 +0000 Subject: [Koha-bugs] [Bug 18502] koha-shell broken on dev installs In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18502 Bug 18502 depends on bug 16749, which changed state. Bug 16749 Summary: Additional fixes for debian scripts https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16749 What |Removed |Added ---------------------------------------------------------------------------- Status|RESOLVED |REOPENED Resolution|FIXED |--- -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue May 16 07:58:58 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 16 May 2017 05:58:58 +0000 Subject: [Koha-bugs] [Bug 16749] Additional fixes for debian scripts In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16749 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Status|REOPENED |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue May 16 07:59:06 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 16 May 2017 05:59:06 +0000 Subject: [Koha-bugs] [Bug 16749] Additional fixes for debian scripts In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16749 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue May 16 07:58:51 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 16 May 2017 05:58:51 +0000 Subject: [Koha-bugs] [Bug 16749] Additional fixes for debian scripts In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16749 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Status|RESOLVED |REOPENED Resolution|FIXED |--- -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue May 16 07:59:14 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 16 May 2017 05:59:14 +0000 Subject: [Koha-bugs] [Bug 16749] Additional fixes for debian scripts In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16749 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue May 16 07:59:39 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 16 May 2017 05:59:39 +0000 Subject: [Koha-bugs] [Bug 16749] Additional fixes for debian scripts In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16749 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to Stable Severity|enhancement |normal --- Comment #68 from Katrin Fischer --- These patches have been pushed to 16.11.x and will be in 16.11.08. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue May 16 07:59:54 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 16 May 2017 05:59:54 +0000 Subject: [Koha-bugs] [Bug 18502] koha-shell broken on dev installs In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18502 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to Master |Pushed to Stable -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue May 16 08:00:02 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 16 May 2017 06:00:02 +0000 Subject: [Koha-bugs] [Bug 18502] koha-shell broken on dev installs In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18502 --- Comment #7 from Katrin Fischer --- This patch has been pushed to 16.11.x and will be in 16.11.08. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue May 16 08:00:20 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 16 May 2017 06:00:20 +0000 Subject: [Koha-bugs] [Bug 16733] More flexible paths in debian scripts (for dev installs) In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16733 --- Comment #46 from Katrin Fischer --- These patches have been pushed to 16.11.x and will be in 16.11.08. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue May 16 08:05:01 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 16 May 2017 06:05:01 +0000 Subject: [Koha-bugs] [Bug 18389] bulkmarcimport.pl does not take notice of MARC modification templates In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18389 --- Comment #6 from Katrin Fischer --- Thx for the follow-up! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue May 16 08:07:58 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 16 May 2017 06:07:58 +0000 Subject: [Koha-bugs] [Bug 18471] Receiving order with unitprice greater than 1000 processing incorrectly In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18471 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to Master |Pushed to Stable --- Comment #14 from Katrin Fischer --- Thx for the rebase patch, Colin! This patch has been pushed to 16.11.x and will be in 16.11.08. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue May 16 11:43:49 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 16 May 2017 09:43:49 +0000 Subject: [Koha-bugs] [Bug 18611] Create labels action fails in manage-marc-import.pl if an item has been deleted from the import batch. In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18611 Nick Clemens changed: What |Removed |Added ---------------------------------------------------------------------------- Patch complexity|--- |Trivial patch Status|NEW |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue May 16 11:43:51 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 16 May 2017 09:43:51 +0000 Subject: [Koha-bugs] [Bug 18611] Create labels action fails in manage-marc-import.pl if an item has been deleted from the import batch. In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18611 --- Comment #2 from Nick Clemens --- Created attachment 63483 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=63483&action=edit Bug 18611 - Create labels action fails in manage-marc-import.pl if an item has been deleted from the import batch. To test: 1 - Import a batch with some items 2 - Delete one of the imported items 3 - Browse to Tools->Staged MARC record management 4 - Click (Create label batch) for the batch you imported 5 - Recieve an error 6 - Apply patch 7 - Click (Create label batch) 8 - Batch is created with remaning items from the import -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue May 16 12:01:03 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 16 May 2017 10:01:03 +0000 Subject: [Koha-bugs] [Bug 12342] Patron registration datepicker dropdown shows only 10 years In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12342 Lucy Vaux-Harvey changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |lucy.vaux-harvey at ptfs-europ | |e.com -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue May 16 12:35:48 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 16 May 2017 10:35:48 +0000 Subject: [Koha-bugs] [Bug 12342] Patron registration datepicker dropdown shows only 10 years In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12342 Colin Campbell changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |colin.campbell at ptfs-europe. | |com --- Comment #17 from Colin Campbell --- (In reply to Kyle M Hall from comment #14) > Pushed to master, thanks Martin! Cant see it in current master has the patch been dropped? -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue May 16 13:59:15 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 16 May 2017 11:59:15 +0000 Subject: [Koha-bugs] [Bug 18187] finishreceive.pl: Save bookseller name into items acquisition source field In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18187 Marcel de Rooy changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |BLOCKED -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue May 16 13:59:49 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 16 May 2017 11:59:49 +0000 Subject: [Koha-bugs] [Bug 18445] Tests in t stumble over Auth's BEGIN block In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18445 Marcel de Rooy changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |BLOCKED --- Comment #7 from Marcel de Rooy --- Returning here later -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue May 16 15:03:49 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 16 May 2017 13:03:49 +0000 Subject: [Koha-bugs] [Bug 18610] ElasticSearch indexing of facets needs to be updated for newer Catmandu versions In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18610 Tom?s Cohen Arazi changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|gmcharlt at gmail.com |tomascohen at gmail.com CC| |tomascohen at gmail.com -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue May 16 15:05:01 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 16 May 2017 13:05:01 +0000 Subject: [Koha-bugs] [Bug 12825] GST / VAT rewrite In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12825 Marjorie Barry-Vila changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |marjorie.barry-vila at ccsr.qc | |.ca -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue May 16 15:17:26 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 16 May 2017 13:17:26 +0000 Subject: [Koha-bugs] [Bug 18551] Hide with CSS dynamic elements in member search In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18551 --- Comment #13 from Fridolin SOMERS --- Looks nice to me. It happens very fast on a good computer so it is not easy to reproduce. Use an old Pentium II ;) -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue May 16 15:45:42 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 16 May 2017 13:45:42 +0000 Subject: [Koha-bugs] [Bug 12342] Patron registration datepicker dropdown shows only 10 years In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12342 --- Comment #18 from Jonathan Druart --- (In reply to Colin Campbell from comment #17) > (In reply to Kyle M Hall from comment #14) > > Pushed to master, thanks Martin! > > Cant see it in current master has the patch been dropped? 7d3772503c Bug 12342: Patron registration datepicker dropdown shows only 10 years -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue May 16 15:46:33 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 16 May 2017 13:46:33 +0000 Subject: [Koha-bugs] [Bug 18613] New: Deleting a Letter from a library as superlibrarian deletes the " All libraries" rule Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18613 Bug ID: 18613 Summary: Deleting a Letter from a library as superlibrarian deletes the "All libraries" rule Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Tools Assignee: gmcharlt at gmail.com Reporter: baptiste.wojtkowski at biblibre.com QA Contact: testopia at bugs.koha-community.org To reproduce: 1- Connect as superlibrarian. 2- Create a rule for all libraries in tools/letter.pl 3- Copy this letter on a precise library, different from the one you are registred on 4- Try to delete the letter => it wants to delete the one from all libraries -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue May 16 15:52:28 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 16 May 2017 13:52:28 +0000 Subject: [Koha-bugs] [Bug 18613] Deleting a Letter from a library as superlibrarian deletes the " All libraries" rule In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18613 --- Comment #1 from Baptiste --- Created attachment 63484 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=63484&action=edit Bug 18613: Correct behaviour Remove a part of the code which automatically redirects on the library of logged-in user ( not ergonomic behaviour ). TEST PLAN: 1- Connect as superlibrarian. 2- Create a rule for all libraries in tools/letter.pl 3- Copy this letter on a precise library, different from the one you are registred on 4- Try to delete the letter => it wants to delete the one from all libraries 5- Apply Patch 6- Try again to delete the letter => it proposes you the good letter -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue May 16 15:55:12 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 16 May 2017 13:55:12 +0000 Subject: [Koha-bugs] [Bug 18613] Deleting a Letter from a library as superlibrarian deletes the " All libraries" rule In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18613 Baptiste changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #63484|0 |1 is obsolete| | --- Comment #2 from Baptiste --- Created attachment 63485 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=63485&action=edit Bug 18613: Correct behaviour Remove a part of the code which automatically redirects on the library of logged-in user ( not ergonomic behaviour ). TEST PLAN: 1- Connect as superlibrarian. 2- Create a rule for all libraries in tools/letter.pl 3- Copy this letter on a precise library, different from the one you are registred on 4- Try to delete the letter => it wants to delete the one from all libraries 5- Apply Patch 6- Try again to delete the letter => it proposes you the good letter -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue May 16 15:56:29 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 16 May 2017 13:56:29 +0000 Subject: [Koha-bugs] [Bug 18613] Deleting a Letter from a library as superlibrarian deletes the " All libraries" rule In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18613 Baptiste changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #63485|0 |1 is obsolete| | --- Comment #3 from Baptiste --- Created attachment 63486 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=63486&action=edit Bug 18613: Correct behaviour Remove a part of the code which automatically redirects on the library of logged-in user ( not ergonomic behaviour ). TEST PLAN: 1- Connect as superlibrarian. 2- Create a rule for all libraries in tools/letter.pl 3- Copy this letter on a precise library, different from the one you are registred on 4- Try to delete the letter => it wants to delete the one from all libraries 5- Apply Patch 6- Try again to delete the letter => it proposes you the good letter -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue May 16 15:58:32 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 16 May 2017 13:58:32 +0000 Subject: [Koha-bugs] [Bug 18613] Deleting a Letter from a library as superlibrarian deletes the " All libraries" rule In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18613 Baptiste changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff Assignee|gmcharlt at gmail.com |baptiste.wojtkowski at biblibr | |e.com -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue May 16 16:54:19 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 16 May 2017 14:54:19 +0000 Subject: [Koha-bugs] [Bug 18478] Hold Notices sent via SMS gateway fail In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18478 Nick Clemens changed: What |Removed |Added ---------------------------------------------------------------------------- Severity|enhancement |normal Assignee|koha-bugs at lists.koha-commun |nick at bywatersolutions.com |ity.org | -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Tue May 16 17:02:30 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 16 May 2017 15:02:30 +0000 Subject: [Koha-bugs] [Bug 18478] Hold Notices sent via SMS gateway fail In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18478 Nick Clemens changed: What |Removed |Added ---------------------------------------------------------------------------- Patch complexity|--- |Small patch Status|REOPENED |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue May 16 17:02:33 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 16 May 2017 15:02:33 +0000 Subject: [Koha-bugs] [Bug 18478] Hold Notices sent via SMS gateway fail In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18478 --- Comment #3 from Nick Clemens --- Created attachment 63487 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=63487&action=edit Bug 18478 - Hold Notices sent via SMS gateway fail It seems that for HOLD notices we rely on C4::Letters::SendQueuedMessages to populate the correct address. The sms code in this sub, however, assumed the smsalertnumebr is populated. Ths patch changes C4::Reserves::_koha_notify_reserve to use C4::Message::enqueue for SMS and email messages in order to ensure the correct addrress is populated To test: 1 - Define a messaging prefs for a patron to recieve hold notices via SMS 2 - Ensure you have defined an SMS message for 'HOLD' letter 3 - Set an SMS alert number for patron 4 - Set the SMS::Send driver to 'Email' 5 - Fill a hold for the patron 6 - Check the db and note the address is null 7 - Apply patch 8 - Fill another hold 9 - Check db and note address is populated 10 - Repeat for email notices and see the same change -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue May 16 17:02:36 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 16 May 2017 15:02:36 +0000 Subject: [Koha-bugs] [Bug 18478] Hold Notices sent via SMS gateway fail In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18478 --- Comment #4 from Nick Clemens --- Created attachment 63488 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=63488&action=edit Bug 18478 - Unit tests To test: 1 - Apply this patch first 2 - Prove t/db_dependent/Reserves.t 3 - Last tests fail 4 - Apply other patch 5 - All tests should pass -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue May 16 17:08:52 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 16 May 2017 15:08:52 +0000 Subject: [Koha-bugs] [Bug 18376] authority framework creation fails under Plack In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18376 --- Comment #5 from Fridolin SOMERS --- Thanks a lot Katrin -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue May 16 19:33:45 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 16 May 2017 17:33:45 +0000 Subject: [Koha-bugs] [Bug 18614] New: Add useful CSS classes to the *detail.pl pages Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18614 Bug ID: 18614 Summary: Add useful CSS classes to the *detail.pl pages Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: normal Priority: P5 - low Component: Templates Assignee: oleonard at myacpl.org Reporter: mtj at kohaaloha.com QA Contact: testopia at bugs.koha-community.org It would be really useful to add more CSS classes to the various *detail.pl pages more details to come... -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue May 16 21:23:52 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 16 May 2017 19:23:52 +0000 Subject: [Koha-bugs] [Bug 18615] New: LDAP configuration error causes server resource depletion under Plack Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18615 Bug ID: 18615 Summary: LDAP configuration error causes server resource depletion under Plack Change sponsored?: --- Product: Koha Version: 16.11 Hardware: HP OS: Linux Status: NEW Severity: normal Priority: P5 - low Component: Authentication Assignee: gmcharlt at gmail.com Reporter: helpdesk at neci.edu QA Contact: testopia at bugs.koha-community.org CC: dpavlin at rot13.org When running with Plack enabled, it is possible to get KOHA to keep spawning processes until the hosts's resources are exhausted. The immediate upshot is that KOHA hangs, the final result is that all other services on the host eventually stop functioning as well. Steps to reproduce: Enable useldapserver and specify an empty search base in the ldapserver element: 1 ... ... Restart koha-plack for the instance. The plack-error.log file starts filling up with "Compilation failed" errors on all modules that somehow invoke Auth_with_ldap.pm. The "top" command shows two active /etc/koha/plack processes owned by the koha-$instance user. Each process uses ~50% of the available CPU cycles. These processes are replaced continuously. ps aux | grep apache shows an every increasing number of Apache instances owned by the same user. Without Plack, the same configuration problem triggers an error page for KOHA, but the rest of the services on the host are not affected. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue May 16 21:48:49 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 16 May 2017 19:48:49 +0000 Subject: [Koha-bugs] [Bug 17805] Add new authority type EVENT_TERM In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17805 Tom?s Cohen Arazi changed: What |Removed |Added ---------------------------------------------------------------------------- Version|unspecified |master CC| |tomascohen at gmail.com -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue May 16 21:55:04 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 16 May 2017 19:55:04 +0000 Subject: [Koha-bugs] [Bug 18551] Hide with CSS dynamic elements in member search In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18551 --- Comment #14 from Philippe Audet-Fortin --- Created attachment 63489 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=63489&action=edit [SIGNED-OFF] Bug 18551 - Hide with CSS dynamic elements in member search In member search page, the result table is in Ajax so fully managed by Javascript. There is also a yellow dialog message prepared in HTML. Thoses elements are hidden by JS code : ie $("#patron_list_dialog").hide(). The problem is that the static page is first loaded an displayed then the JS code runs an hides the elements. On a low performance computer, this action is visible and looks like there is a blinking yellow message. I propose to hide with CSS so that thoses elements are not displayed in static page and are there shown in dynamic JS code. Test plan : Check display is unchanged : - Go to home page /cgi-bin/koha/members/members-home.pl - Perform patron search from header search box - Perform patron search by clicking on a letter - Perform patron search from filters (left of results table) - Select a patron and add it to a list => you see the yellow message Yellow message does no longer appear with this patch. Signed-off-by: Marc V?ron Signed-off-by: Philippe -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue May 16 21:55:12 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 16 May 2017 19:55:12 +0000 Subject: [Koha-bugs] [Bug 18551] Hide with CSS dynamic elements in member search In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18551 --- Comment #15 from Philippe Audet-Fortin --- Created attachment 63490 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=63490&action=edit [SIGNED-OFF] Bug 18551: followup - hide advanced filters in header, move hidding to css file Test plan: The same as first patch, but also with advanced search form in header hidden on page load - see comment 4 Issue with advanced search form is gone. Signed-off-by: Marc V?ron Signed-off-by: Philippe -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue May 16 21:56:46 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 16 May 2017 19:56:46 +0000 Subject: [Koha-bugs] [Bug 18551] Hide with CSS dynamic elements in member search In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18551 Philippe Audet-Fortin changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #63314|0 |1 is obsolete| | Attachment #63489|0 |1 is obsolete| | --- Comment #16 from Philippe Audet-Fortin --- Created attachment 63491 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=63491&action=edit [SIGNED-OFF] Bug 18551 - Hide with CSS dynamic elements in member search In member search page, the result table is in Ajax so fully managed by Javascript. There is also a yellow dialog message prepared in HTML. Thoses elements are hidden by JS code : ie $("#patron_list_dialog").hide(). The problem is that the static page is first loaded an displayed then the JS code runs an hides the elements. On a low performance computer, this action is visible and looks like there is a blinking yellow message. I propose to hide with CSS so that thoses elements are not displayed in static page and are there shown in dynamic JS code. Test plan : Check display is unchanged : - Go to home page /cgi-bin/koha/members/members-home.pl - Perform patron search from header search box - Perform patron search by clicking on a letter - Perform patron search from filters (left of results table) - Select a patron and add it to a list => you see the yellow message Yellow message does no longer appear with this patch. Signed-off-by: Marc V?ron Signed-off-by: Philippe -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue May 16 21:57:00 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 16 May 2017 19:57:00 +0000 Subject: [Koha-bugs] [Bug 18551] Hide with CSS dynamic elements in member search In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18551 Philippe Audet-Fortin changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #63315|0 |1 is obsolete| | Attachment #63490|0 |1 is obsolete| | --- Comment #17 from Philippe Audet-Fortin --- Created attachment 63492 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=63492&action=edit [SIGNED-OFF] Bug 18551: followup - hide advanced filters in header, move hidding to css file Test plan: The same as first patch, but also with advanced search form in header hidden on page load - see comment 4 Issue with advanced search form is gone. Signed-off-by: Marc V?ron Signed-off-by: Philippe -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue May 16 21:58:51 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 16 May 2017 19:58:51 +0000 Subject: [Koha-bugs] [Bug 18551] Hide with CSS dynamic elements in member search In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18551 Philippe Audet-Fortin changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue May 16 23:34:06 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 16 May 2017 21:34:06 +0000 Subject: [Koha-bugs] [Bug 18616] New: The "Add forgot password link to OPAC" should allow patrons to use their library card number in addition to userid Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18616 Bug ID: 18616 Summary: The "Add forgot password link to OPAC" should allow patrons to use their library card number in addition to userid Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: OPAC Assignee: oleonard at myacpl.org Reporter: techservspec at gmail.com QA Contact: testopia at bugs.koha-community.org Bug 8753 will only accept the patron's username. However some libraries do not use the username for identifying patrons, only their library card number. The "Forgot your password" feature should allow patrons to enter either their username or their card number in the Log In box (in addition to their email address) in order to reset their password. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue May 16 23:34:50 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 16 May 2017 21:34:50 +0000 Subject: [Koha-bugs] [Bug 18616] The "Add forgot password link to OPAC" should allow patrons to use their library card number in addition to username In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18616 David Kuhn changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |techservspec at gmail.com Summary|The "Add forgot password |The "Add forgot password |link to OPAC" should allow |link to OPAC" should allow |patrons to use their |patrons to use their |library card number in |library card number in |addition to userid |addition to username -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed May 17 00:54:59 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 16 May 2017 22:54:59 +0000 Subject: [Koha-bugs] [Bug 18617] New: starting plack on reboot can fail on non-standard apache configs Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18617 Bug ID: 18617 Summary: starting plack on reboot can fail on non-standard apache configs Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: System Administration Assignee: koha-bugs at lists.koha-community.org Reporter: liz at catalyst.net.nz QA Contact: testopia at bugs.koha-community.org CC: gmcharlt at gmail.com If you have a non-standard Koha apache configuration, for example you have virtualhosts in separate files instead of all in one file (you might do this if you were using Let's Encrypt, among other reasons) koha-list --plack --enabled can fail because it is looking for apache configurations in only one file (/etc/apache2/sites-available/instance.conf). I propose to make the check for plack enabled work more like the email enabled, where we touch a file in /var/lib/koha/instance when the service is enabled, and remove it when it is disabled. I'm happy to leave the current checking alone and include this as a bracer to the existing belt. To do: edit koha-plack to make enable and disable put a file in /var/lib/koha/instance called plack.enable edit koha-functions.sh to include checking for the file as part of is_plack_enabled There are probably other things to do as well. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed May 17 02:02:30 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 17 May 2017 00:02:30 +0000 Subject: [Koha-bugs] [Bug 18617] starting plack on reboot can fail on non-standard apache configs In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18617 Liz Rea changed: What |Removed |Added ---------------------------------------------------------------------------- Patch complexity|--- |Trivial patch Status|NEW |Needs Signoff -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed May 17 02:02:33 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 17 May 2017 00:02:33 +0000 Subject: [Koha-bugs] [Bug 18617] starting plack on reboot can fail on non-standard apache configs In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18617 --- Comment #1 from Liz Rea --- Created attachment 63493 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=63493&action=edit Bug 18617 - starting plack on reboot can fail on non-standard apache configs To test: apply this patch copy debian/scripts/koha-functions.sh to /usr/share/koha/bin copy debian/scripts/koha-plack to /usr/sbin create a dummy instance if you need to (koha-create --create-db whatever) enable plack - koha-plack --enable whatever check for existence of /var/lib/koha/whatever/plack.enabled do a koha-list --enabled --plack and your instance should be listed as enabled. rename your /etc/apache2/sites-available/whatever.conf to something else do a koha-list --enabled --plack - it should still be enabled do a koha-plack --disable whatever - it should remove /var/lib/koha/whatever/plack.enabled do a koha-list --enabled --plack - it should not be listed. Note: This does not deal with the issue of disabling plack not doing the right thing for config files that are not "/etc/apache2/sites-available/whatever.conf" - this only ensures that koha-list --enabled and --disabled reports correctly in that circumstance. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed May 17 03:45:31 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 17 May 2017 01:45:31 +0000 Subject: [Koha-bugs] [Bug 18438] Check in: Modal about holds hides important check in messages In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18438 Lisette changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |lisetteslatah at gmail.com -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed May 17 03:45:56 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 17 May 2017 01:45:56 +0000 Subject: [Koha-bugs] [Bug 14825] Accounts Rewrite Omnibus In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14825 Lisette changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |lisetteslatah at gmail.com -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed May 17 03:48:02 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 17 May 2017 01:48:02 +0000 Subject: [Koha-bugs] [Bug 15549] Forgive fines when checking out a currently checked out item In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15549 Lisette changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |lisetteslatah at gmail.com -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed May 17 04:05:42 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 17 May 2017 02:05:42 +0000 Subject: [Koha-bugs] [Bug 18569] Quick add patron will not copy over details from cities and towns pull down into patron details In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18569 dilan at calyx.net.au changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed May 17 04:05:46 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 17 May 2017 02:05:46 +0000 Subject: [Koha-bugs] [Bug 18569] Quick add patron will not copy over details from cities and towns pull down into patron details In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18569 dilan at calyx.net.au changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #63442|0 |1 is obsolete| | --- Comment #2 from dilan at calyx.net.au --- Created attachment 63494 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=63494&action=edit Bug 18569 - Quick add patron will not copy over details from cities and towns pull down into patron details Followed test plan and the city value updates in the quick add form correctly. Signed-off-by: Dilan Johnpulle -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed May 17 04:13:01 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 17 May 2017 02:13:01 +0000 Subject: [Koha-bugs] [Bug 18615] LDAP configuration error causes server resource depletion under Plack In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18615 Mason James changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |mtj at kohaaloha.com -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed May 17 04:16:00 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 17 May 2017 02:16:00 +0000 Subject: [Koha-bugs] [Bug 18615] LDAP configuration error causes server resource depletion under Plack In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18615 --- Comment #1 from Mason James --- (In reply to Sven Coenye from comment #0) > When running with Plack enabled, it is possible to get KOHA to keep spawning > processes until the hosts's resources are exhausted. The immediate upshot is > that KOHA hangs, the final result is that all other services on the host > eventually stop functioning as well. > > Steps to reproduce: > Enable useldapserver and specify an empty search base in the ldapserver > element: > 1 > > ... > > ... > > curious.. does the error only occur if the element is empty? -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed May 17 07:36:10 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 17 May 2017 05:36:10 +0000 Subject: [Koha-bugs] [Bug 18586] Create module to mint RDF subject URIs In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18586 Magnus Enger changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |magnus at libriotech.no -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed May 17 08:20:59 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 17 May 2017 06:20:59 +0000 Subject: [Koha-bugs] [Bug 16784] Export suggestions from OPAC as CSV In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16784 --- Comment #2 from vimal kumar --- (In reply to Owen Leonard from comment #1) > Wouldn't this make more sense as a feature in the staff client? Right -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Wed May 17 08:21:52 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 17 May 2017 06:21:52 +0000 Subject: [Koha-bugs] [Bug 16784] Export suggestions from OPAC as CSV In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16784 --- Comment #3 from vimal kumar --- (In reply to vimal kumar from comment #2) > (In reply to Owen Leonard from comment #1) > > Wouldn't this make more sense as a feature in the staff client? > > Right I agree with your suggestion. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed May 17 08:22:05 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 17 May 2017 06:22:05 +0000 Subject: [Koha-bugs] [Bug 18548] running koha-create --request-db without an instance name should abort In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18548 dilan at calyx.net.au changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed May 17 08:22:09 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 17 May 2017 06:22:09 +0000 Subject: [Koha-bugs] [Bug 18548] running koha-create --request-db without an instance name should abort In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18548 dilan at calyx.net.au changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #63278|0 |1 is obsolete| | --- Comment #12 from dilan at calyx.net.au --- Created attachment 63495 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=63495&action=edit Bug 18548: Print usage when missing instance name in koha-create script My apologies Josef, you are correct. It works prefectly with the right command. Signed-off-by: Dilan Johnpulle -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed May 17 09:16:25 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 17 May 2017 07:16:25 +0000 Subject: [Koha-bugs] [Bug 11999] Add two checks in CanBookBeReserved and CanItemBeReserved In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11999 Fridolin SOMERS changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |fridolin.somers at biblibre.co | |m --- Comment #48 from Fridolin SOMERS --- Bug 13113 added check for age restriction on CanItemBeReserved -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed May 17 09:17:51 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 17 May 2017 07:17:51 +0000 Subject: [Koha-bugs] [Bug 11999] Add two checks in CanBookBeReserved and CanItemBeReserved In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11999 Fridolin SOMERS changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on| |13113 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13113 [Bug 13113] Prevent juvenile/children from reserving ageRestricted material -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed May 17 09:17:51 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 17 May 2017 07:17:51 +0000 Subject: [Koha-bugs] [Bug 13113] Prevent juvenile/ children from reserving ageRestricted material In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13113 Fridolin SOMERS changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |11999 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11999 [Bug 11999] Add two checks in CanBookBeReserved and CanItemBeReserved -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed May 17 09:26:54 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 17 May 2017 07:26:54 +0000 Subject: [Koha-bugs] [Bug 11999] Add two checks in CanBookBeReserved and CanItemBeReserved In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11999 Fridolin SOMERS changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |https://bugs.koha-community | |.org/bugzilla3/show_bug.cgi | |?id=12632 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed May 17 09:26:54 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 17 May 2017 07:26:54 +0000 Subject: [Koha-bugs] [Bug 12632] Hold limits ignored for record level holds with item level itemtypes In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12632 Fridolin SOMERS changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |https://bugs.koha-community | |.org/bugzilla3/show_bug.cgi | |?id=11999 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed May 17 10:03:51 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 17 May 2017 08:03:51 +0000 Subject: [Koha-bugs] [Bug 18618] New: Mana - Add reading suggestions (crontab - scripts) Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18618 Bug ID: 18618 Summary: Mana - Add reading suggestions (crontab - scripts) Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Cataloging Assignee: gmcharlt at gmail.com Reporter: baptiste.wojtkowski at biblibre.com QA Contact: testopia at bugs.koha-community.org CC: m.de.rooy at rijksmuseum.nl -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed May 17 10:13:31 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 17 May 2017 08:13:31 +0000 Subject: [Koha-bugs] [Bug 18618] Mana - Add reading suggestions (crontab - scripts) In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18618 --- Comment #1 from Baptiste --- Created attachment 63496 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=63496&action=edit Bug 18618: Mana - Add scripts to send readings - There are 2 differents scripts: misc/cronjobs/mana_send_pairs.pl -> please use it if Mana is installed misc/cronjobs/mana_send_pairs_without_mana.pl -> designed to work if mana isn't enabled - Both of scripts anonymize the datas and send them to mana. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed May 17 10:13:40 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 17 May 2017 08:13:40 +0000 Subject: [Koha-bugs] [Bug 18618] Mana - Add reading suggestions (crontab - scripts) In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18618 --- Comment #2 from Baptiste --- Created attachment 63497 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=63497&action=edit Bug 18618: Mana - Add reading suggestion There is now a module to get suggestions from Mana. - It is activated by default on Mana. - When you browse on a notice, there is now a tab called "Suggestions" - On click on the tab, it will check in the database if it has suggestions. - Else, it will ask to Mana for suggestions and will store in the database. - The suggestions are stored in the NEW table reading_pairs - Implement new dbix objets: Reading_suggestion and Reading_suggestions -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed May 17 10:14:58 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 17 May 2017 08:14:58 +0000 Subject: [Koha-bugs] [Bug 18618] Mana - Add reading suggestions (crontab - scripts) In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18618 Baptiste changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on| |17047 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17047 [Bug 17047] Mana Knowledge Base : share data -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed May 17 10:14:58 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 17 May 2017 08:14:58 +0000 Subject: [Koha-bugs] [Bug 17047] Mana Knowledge Base : share data In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17047 Baptiste changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |18618 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18618 [Bug 18618] Mana - Add reading suggestions (crontab - scripts) -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed May 17 10:35:04 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 17 May 2017 08:35:04 +0000 Subject: [Koha-bugs] [Bug 18618] Mana - Add reading suggestions (crontab - scripts) In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18618 Baptiste changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |ASSIGNED Assignee|gmcharlt at gmail.com |baptiste.wojtkowski at biblibr | |e.com -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed May 17 11:06:47 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 17 May 2017 09:06:47 +0000 Subject: [Koha-bugs] [Bug 12461] Add patron clubs feature In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12461 Brenda Turnbull changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |bturnbull at livewirewarringto | |n.org -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed May 17 11:58:41 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 17 May 2017 09:58:41 +0000 Subject: [Koha-bugs] [Bug 17202] Deleting a rotating collection with items should either be prohibited or items should be removed In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17202 Fridolin SOMERS changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |fridolin.somers at biblibre.co | |m --- Comment #1 from Fridolin SOMERS --- Indeed, there are no foreign keys in collections_tracking table. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed May 17 12:15:21 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 17 May 2017 10:15:21 +0000 Subject: [Koha-bugs] [Bug 18103] REST API: Add endpoint for patron status / blocks In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18103 Mirko Tietgen changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |mirko at abunchofthings.net --- Comment #7 from Mirko Tietgen --- Is this ready to be tested? Please set the status to "Needs signoff" then. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed May 17 12:18:06 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 17 May 2017 10:18:06 +0000 Subject: [Koha-bugs] [Bug 18407] REST API: Include renewability information on checkouts In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18407 Mirko Tietgen changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on| |13895 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13895 [Bug 13895] Add API routes for checkouts retrieval and renewal -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed May 17 12:18:06 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 17 May 2017 10:18:06 +0000 Subject: [Koha-bugs] [Bug 13895] Add API routes for checkouts retrieval and renewal In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13895 Mirko Tietgen changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |18407 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18407 [Bug 18407] REST API: Include renewability information on checkouts -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed May 17 12:18:50 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 17 May 2017 10:18:50 +0000 Subject: [Koha-bugs] [Bug 18407] REST API: Include renewability information on checkouts In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18407 Mirko Tietgen changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on| |18137 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18137 [Bug 18137] REST API: Migrate from Mojolicious::Plugin::Swagger2 to Mojolicious::Plugin::OpenAPI -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed May 17 12:18:50 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 17 May 2017 10:18:50 +0000 Subject: [Koha-bugs] [Bug 18137] REST API: Migrate from Mojolicious::Plugin:: Swagger2 to Mojolicious::Plugin::OpenAPI In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18137 Mirko Tietgen changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |18407 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18407 [Bug 18407] REST API: Include renewability information on checkouts -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed May 17 12:21:37 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 17 May 2017 10:21:37 +0000 Subject: [Koha-bugs] [Bug 17202] Deleting a rotating collection with items should either be prohibited or items should be removed In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17202 Josef Moravec changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |https://bugs.koha-community | |.org/bugzilla3/show_bug.cgi | |?id=18606 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed May 17 12:21:37 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 17 May 2017 10:21:37 +0000 Subject: [Koha-bugs] [Bug 18606] Move rotating collections code to Koha::Object In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18606 Josef Moravec changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |https://bugs.koha-community | |.org/bugzilla3/show_bug.cgi | |?id=17202 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed May 17 12:22:08 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 17 May 2017 10:22:08 +0000 Subject: [Koha-bugs] [Bug 17202] Deleting a rotating collection with items should either be prohibited or items should be removed In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17202 --- Comment #2 from Josef Moravec --- (In reply to Fridolin SOMERS from comment #1) > Indeed, there are no foreign keys in collections_tracking table. I will add it as a part of bug 18606 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed May 17 12:33:21 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 17 May 2017 10:33:21 +0000 Subject: [Koha-bugs] [Bug 13737] [OMNIBUS] Add Koha RESTful Services In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13737 Mirko Tietgen changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |In Discussion CC| |mirko at abunchofthings.net --- Comment #6 from Mirko Tietgen --- This is no omnibus for the actual REST API development going on. Can we close this bug? -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed May 17 12:39:04 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 17 May 2017 10:39:04 +0000 Subject: [Koha-bugs] [Bug 16330] REST API: add routes to add, update and delete patrons In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16330 Mirko Tietgen changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |mirko at abunchofthings.net --- Comment #43 from Mirko Tietgen --- (In reply to Magnus Enger from comment #42) > What needs to happen for this bug to get moving? I second Magnus' question. What is the status here? -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed May 17 12:51:16 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 17 May 2017 10:51:16 +0000 Subject: [Koha-bugs] [Bug 18619] New: MARC modification templates does not delete Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18619 Bug ID: 18619 Summary: MARC modification templates does not delete Change sponsored?: --- Product: Koha Version: 16.11 Hardware: All OS: Linux Status: NEW Severity: major Priority: P5 - low Component: Tools Assignee: gmcharlt at gmail.com Reporter: mishravk79 at gmail.com QA Contact: testopia at bugs.koha-community.org Created attachment 63498 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=63498&action=edit MARC modification templates delete screen MARC modification templates templates does not allow for delete once it is created. 1. I have created first time one MARC modification templates 2. want to delete but it gives all the pop up warnings but did not delete. 3. When i want to cancel the delete option in-spite of closing the pop-up windows it gives the warning of deletion but did not delete it. 4. OK and Cancel both g9ives the delete warning but both not working at all. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed May 17 13:01:43 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 17 May 2017 11:01:43 +0000 Subject: [Koha-bugs] [Bug 16330] REST API: add routes to add, update and delete patrons In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16330 --- Comment #44 from Marcel de Rooy --- (In reply to Mirko Tietgen from comment #43) > (In reply to Magnus Enger from comment #42) > > What needs to happen for this bug to get moving? > > I second Magnus' question. What is the status here? The last time, Lari changed this to In Discussion.. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed May 17 13:15:17 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 17 May 2017 11:15:17 +0000 Subject: [Koha-bugs] [Bug 18619] MARC modification templates does not delete In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18619 --- Comment #1 from Vinod --- Created attachment 63498 [details] MARC modification templates delete screen MARC modification templates templates does not allow for delete once it is created. 1. I have created first time one MARC modification templates 2. want to delete but it gives all the pop up warnings but did not delete. 3. When i want to cancel the delete option in-spite of closing the pop-up windows it gives the warning of deletion but did not delete it. 4. OK and Cancel both g9ives the delete warning but both not working at all. The version of koha is 16.11.07 runs on debian 8 package installation. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed May 17 13:30:36 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 17 May 2017 11:30:36 +0000 Subject: [Koha-bugs] [Bug 18137] REST API: Migrate from Mojolicious::Plugin:: Swagger2 to Mojolicious::Plugin::OpenAPI In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18137 --- Comment #78 from Mirko Tietgen --- I have uploaded libmojolicious-perl_7.21+dfsg-1~kohadev1 to the unstable repository. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed May 17 14:13:48 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 17 May 2017 12:13:48 +0000 Subject: [Koha-bugs] [Bug 17453] Inter-site holds improvement In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17453 Zeno Tajoli changed: What |Removed |Added ---------------------------------------------------------------------------- Text to go in the| |At the moment users can release notes| |reserve items and choose | |any library as a pick up | |location, but there is no | |mechanism to prevent users | |from reserving items that | |are available on the shelf | |at any given location from | |reserving the item at the | |same location, essentially | |creating a Fetch and | |Collect scenario. | |This has | |an impact on staff | |workloads as they are | |having to process | |reservations and check | |shelves for items that | |students can already come | |and collect from the open | |library shelves. | |The aim of | |this enhancement is to | |decrease the impact on | |staff workload there | |should | |be a restriction in place | |that prevents users from | |requesting items for | |collection at a library | |where the item is currently | |available. CC| |z.tajoli at cineca.it -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed May 17 14:20:03 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 17 May 2017 12:20:03 +0000 Subject: [Koha-bugs] [Bug 17855] New onboarding tool feature to guide users through setting up Koha, and minor web installer UI improvements In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17855 Zeno Tajoli changed: What |Removed |Added ---------------------------------------------------------------------------- Text to go in the| |After the web installer has release notes| |finished the user is | |redirected to the | |onboarding tool (with no | |authentication required in | |between). In the onboarding | |tool they create a: | |Library, Patron category, | |Item type (if they were not | |installed in the web | |installer). | |In addition to | |always creating a: | |Patron | |(which has super librarian | |privileges which the user | |will use to log into Koha | |with), Circulation rule | |Then the user is redirected | |to a login page where they | |login using the patron they | |just created. If they | |entered the correct patron | |account credentials the | |Koha homepage will appear, | |and the user can start | |using Koha as intended due | |to all necessary data being | |installed. CC| |z.tajoli at cineca.it -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed May 17 14:22:09 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 17 May 2017 12:22:09 +0000 Subject: [Koha-bugs] [Bug 14224] patron notes about item shown at check in In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14224 Zeno Tajoli changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |z.tajoli at cineca.it Text to go in the| |This patch adds a "Note" release notes| |input field to checked out | |items in the "your summary" | |section. The field allows | |patrons to write notes | |about the item checked out, | |such as "this DVD is | |scratched", "the binding | |was torn", etc. The note | |will be emailed to the | |library and displayed on | |item check in. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed May 17 15:00:38 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 17 May 2017 13:00:38 +0000 Subject: [Koha-bugs] [Bug 14784] Missing checkin message for debarred patrons when issuing rules ' fine days = 0' In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14784 Philippe Audet-Fortin changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |philippe.audet-fortin at inlib | |ro.com Status|Failed QA |Signed Off --- Comment #18 from Philippe Audet-Fortin --- I tested Bouzid scenarios and I was able to reproduce the problem so it seems to be a real issue. After applying the patch I was able to see the message as expected. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed May 17 15:19:31 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 17 May 2017 13:19:31 +0000 Subject: [Koha-bugs] [Bug 14784] Missing checkin message for debarred patrons when issuing rules ' fine days = 0' In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14784 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed May 17 15:31:31 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 17 May 2017 13:31:31 +0000 Subject: [Koha-bugs] [Bug 18606] Move rotating collections code to Koha::Object In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18606 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |jonathan.druart at bugs.koha-c | |ommunity.org -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed May 17 15:52:17 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 17 May 2017 13:52:17 +0000 Subject: [Koha-bugs] [Bug 17705] Payments with cards through payment terminal In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17705 --- Comment #2 from Radek ?iman (R-Bit Technology, s.r.o.) --- Created attachment 63499 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=63499&action=edit Bug 17705: Database structure update This patch creates neccessary table and updates systempreferences. Test plan: 1) Apply the patch 2) Check the presence of pos_terminal_transactions table 3) Observe new systempreferences' values - PosTerminalIP - PosTerminalPort - PosTerminalCurrencyCode -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed May 17 15:58:00 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 17 May 2017 13:58:00 +0000 Subject: [Koha-bugs] [Bug 14399] Fix inventory.pl part two (following 12913) In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14399 Kyle M Hall changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |kyle at bywatersolutions.com Status|Passed QA |Pushed to Master --- Comment #30 from Kyle M Hall --- Pushed to master for 17.05, thanks Marcel! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed May 17 15:58:32 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 17 May 2017 13:58:32 +0000 Subject: [Koha-bugs] [Bug 18571] koha-conf.xml should include ES entry In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18571 Kyle M Hall changed: What |Removed |Added ---------------------------------------------------------------------------- Severity|normal |minor -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed May 17 15:59:11 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 17 May 2017 13:59:11 +0000 Subject: [Koha-bugs] [Bug 18571] koha-conf.xml should include ES entry In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18571 Kyle M Hall changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to Master --- Comment #4 from Kyle M Hall --- Pushed to master for 17.05, thanks Tomas! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed May 17 16:04:55 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 17 May 2017 14:04:55 +0000 Subject: [Koha-bugs] [Bug 17705] Payments with cards through payment terminal In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17705 --- Comment #3 from Radek ?iman (R-Bit Technology, s.r.o.) --- Created attachment 63500 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=63500&action=edit Bug 17705: Database schema objects updated Brings neccessary changes in the database schema. Test plan: 1) Apply the patch 2) Open Koha/Schema/Result 3) Observe new relation in Accountline.pm 4) Check presence of PosTerminalTransaction.pm -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed May 17 16:21:04 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 17 May 2017 14:21:04 +0000 Subject: [Koha-bugs] [Bug 18615] LDAP configuration error causes server resource depletion under Plack In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18615 --- Comment #2 from Sven Coenye --- The condition can be reached by triggering any of the "or die" clauses at the upper level of the Auth_with_ldap module. E.g. a blank hostname will also trigger it. More info: Although we originally ran into this on our production server, we have been able to reproduce this on a fresh KOHA install. Both hosts run Debian 8. The production server is a SysV virtual machine, the test server is bare metal using systemd. KOHA is the only application installed on the test machine. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed May 17 16:43:58 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 17 May 2017 14:43:58 +0000 Subject: [Koha-bugs] [Bug 15261] Verify if checkouts or reserves requests periods overlap with existing reserves In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15261 --- Comment #39 from Marcel de Rooy --- Typo: PreventChechoutOnSameReservePeriod -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed May 17 16:52:28 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 17 May 2017 14:52:28 +0000 Subject: [Koha-bugs] [Bug 15326] Add CMS feature In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15326 --- Comment #10 from Marcel de Rooy --- Applying: Bug 15326: [FOLLOW-UP] Add CMS feature fatal: sha1 information is lacking or useless (Koha/CmsPages.pm). Repository lacks necessary blobs to fall back on 3-way merge. Cannot fall back to three-way merge. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed May 17 17:18:42 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 17 May 2017 15:18:42 +0000 Subject: [Koha-bugs] [Bug 18564] koha-common.cnf parsing is too restrictive In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18564 --- Comment #3 from Eric Vantillard --- Created attachment 63501 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=63501&action=edit patch changing the awk script -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed May 17 17:33:11 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 17 May 2017 15:33:11 +0000 Subject: [Koha-bugs] [Bug 12461] Add patron clubs feature In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12461 Zeno Tajoli changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |z.tajoli at cineca.it Text to go in the| |This features would add the release notes| |ability to create clubs | |which patrons may be | |enrolled in. It would be | |particularly useful for | |tracking summer reading | |programs, book clubs and | |other such clubs. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed May 17 17:34:07 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 17 May 2017 15:34:07 +0000 Subject: [Koha-bugs] [Bug 18620] New: t/db_dependent/Letters.t failing on master Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18620 Bug ID: 18620 Summary: t/db_dependent/Letters.t failing on master Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: normal Priority: P5 - low Component: Test Suite Assignee: chris at bigballofwax.co.nz Reporter: nick at bywatersolutions.com QA Contact: gmcharlt at gmail.com These two fail only if SMS::Senddriver is set to email, changes will be made on bug 18478 to fix that, but prep work will be done here: # Failed test 'message marked failed if tried to send SMS message for borrower with no smsalertnumber set (bug 11208)' # Failed test 'The message should have been resent' These fail because no substitiution params are sent # Failed test 'GetPreparedLetter should return the default one if the lang parameter is not provided' # Failed test 'GetPreparedLetter should return the required notice if it exists' # Failed test 'GetPreparedLetter should return the default notice if the one required does not exist' Additionally 'GetPreparedLetter returns the content correctly' can fail on slow server because timestamp of record creation and time of test are assumed to match -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed May 17 17:34:44 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 17 May 2017 15:34:44 +0000 Subject: [Koha-bugs] [Bug 4969] Vendors can not be deleted / show only active vendors In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=4969 Zeno Tajoli changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |z.tajoli at cineca.it Text to go in the| |This patch provides the release notes| |functionality to hide | |inactive vendors from the | |vendor search. -- You are receiving this mail because: You are watching all bug changes. You are the QA Contact for the bug. From bugzilla-daemon at bugs.koha-community.org Wed May 17 17:36:08 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 17 May 2017 15:36:08 +0000 Subject: [Koha-bugs] [Bug 10978] redirect to basket list of a supplier after deleting a basket In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10978 Zeno Tajoli changed: What |Removed |Added ---------------------------------------------------------------------------- Text to go in the| |This patch redirects to the release notes| |vendor's list of baskets | |after deleting a basket, | |fixes breadcrumbs after | |deletion and also hides the | |toolbar actions after | |deletion (seeing as you | |can't edit/export etc a | |basket that no longer | |exists). CC| |z.tajoli at cineca.it -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed May 17 17:38:16 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 17 May 2017 15:38:16 +0000 Subject: [Koha-bugs] [Bug 18620] t/db_dependent/Letters.t failing on master In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18620 --- Comment #1 from Nick Clemens --- Created attachment 63502 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=63502&action=edit Bug 18620 - t/db_dependent/Letters.t failing on master To test: 1 - Set SMSSenDriver to 'Email' 2 - prove t/db_dependent/Letters.t 3 - Tests fail 4 - Apply patch 5 - prove t/db_dependent/Letters.t 6 - Less tests fail (should be 2 sms test failures) 7 - Set SMSSendDriver to another value or blank 8 - prove t/db_dependent/Letters.t 9 - Tests pass -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed May 17 17:38:13 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 17 May 2017 15:38:13 +0000 Subject: [Koha-bugs] [Bug 18620] t/db_dependent/Letters.t failing on master In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18620 Nick Clemens changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed May 17 17:39:07 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 17 May 2017 15:39:07 +0000 Subject: [Koha-bugs] [Bug 15503] Grab Item Information from Order Files In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15503 Zeno Tajoli changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |z.tajoli at cineca.it Text to go in the| |The goal of this release notes| |development is to | |automatically generate | |items in Koha with | |populated information based | |on a 9XX field and | |subfield, with the new | |syspref | |MarcItemFieldsToOrder. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed May 17 17:42:05 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 17 May 2017 15:42:05 +0000 Subject: [Koha-bugs] [Bug 17971] TT syntax for notices - Add support for plurals In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17971 Nick Clemens changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |18620 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18620 [Bug 18620] t/db_dependent/Letters.t failing on master -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed May 17 17:42:05 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 17 May 2017 15:42:05 +0000 Subject: [Koha-bugs] [Bug 18620] t/db_dependent/Letters.t failing on master In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18620 Nick Clemens changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on| |17971 Assignee|chris at bigballofwax.co.nz |nick at bywatersolutions.com Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17971 [Bug 17971] TT syntax for notices - Add support for plurals -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed May 17 17:43:34 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 17 May 2017 15:43:34 +0000 Subject: [Koha-bugs] [Bug 14537] Rename system preference 'OverdueNoticeBcc' to 'NoticeBcc' In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14537 Zeno Tajoli changed: What |Removed |Added ---------------------------------------------------------------------------- Text to go in the| |The system prefrerence release notes| |'OverdueNoticeBcc' seems, | |by its name, to imply that | |a BCC will be added to all | |overdue notices. The | |description says that the | |address will be added to | |all notices. The behavior | |of the system follows the | |description, not the system | |preference name. The system | |preference is re-named to | |NoticeBcc. CC| |z.tajoli at cineca.it -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed May 17 17:44:06 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 17 May 2017 15:44:06 +0000 Subject: [Koha-bugs] [Bug 11373] Add a "cash register" feature to the fine payment form. In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11373 Philippe Audet-Fortin changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |philippe.audet-fortin at inlib | |ro.com --- Comment #24 from Philippe Audet-Fortin --- It looks perfects! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed May 17 17:50:21 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 17 May 2017 15:50:21 +0000 Subject: [Koha-bugs] [Bug 14608] HEA : add possibility of sharing usage statistics in Administration page In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14608 Zeno Tajoli changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |z.tajoli at cineca.it Text to go in the| |This patch set adds: release notes| |- a | |reference to Hea at the end | |of the installation process | |- a link to the new page | |from the admin home page | |- | |a new page to easily | |configure shared statistics -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed May 17 17:59:02 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 17 May 2017 15:59:02 +0000 Subject: [Koha-bugs] [Bug 18620] t/db_dependent/Letters.t failing on master In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18620 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |jonathan.druart at bugs.koha-c | |ommunity.org -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed May 17 18:19:14 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 17 May 2017 16:19:14 +0000 Subject: [Koha-bugs] [Bug 17762] Ability to translate notices In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17762 Tom?s Cohen Arazi changed: What |Removed |Added ---------------------------------------------------------------------------- Severity|enhancement |new feature -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed May 17 18:20:45 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 17 May 2017 16:20:45 +0000 Subject: [Koha-bugs] [Bug 18620] t/db_dependent/Letters.t failing on master In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18620 Nick Clemens changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #63502|0 |1 is obsolete| | --- Comment #2 from Nick Clemens --- Created attachment 63503 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=63503&action=edit Bug 18620 - t/db_dependent/Letters.t failing on master To test: 1 - Set SMSSenDriver to 'Email' 2 - prove t/db_dependent/Letters.t 3 - Tests fail 4 - Apply patch 5 - prove t/db_dependent/Letters.t 6 - Less tests fail (should be 2 sms test failures) 7 - Set SMSSendDriver to another value or blank 8 - prove t/db_dependent/Letters.t 9 - Tests pass -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed May 17 18:22:31 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 17 May 2017 16:22:31 +0000 Subject: [Koha-bugs] [Bug 18620] t/db_dependent/Letters.t failing on master In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18620 Tom?s Cohen Arazi changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |tomascohen at gmail.com -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed May 17 18:22:36 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 17 May 2017 16:22:36 +0000 Subject: [Koha-bugs] [Bug 18620] t/db_dependent/Letters.t failing on master In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18620 Tom?s Cohen Arazi changed: What |Removed |Added ---------------------------------------------------------------------------- QA Contact|gmcharlt at gmail.com |tomascohen at gmail.com -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed May 17 18:27:46 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 17 May 2017 16:27:46 +0000 Subject: [Koha-bugs] [Bug 17233] Add 008 value builder plugin for MARC21 classifications In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17233 H?ctor Eduardo Castro Avalos changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |hector.hecaxmmx at gmail.com --- Comment #12 from H?ctor Eduardo Castro Avalos --- Hi Marcel > Would these adjustments be interesting too for the community? Of-course these adjustments are interesting specially for librarian and catalogers, but just one comment. This kind of record really need to be recorded in a separate table or database, since they tend to grow-up, imagine if you enter all SCDD21 or UDC schemas in conjunction with your authority works, will be chaos. If you want to export all classification records it is much better to get this records in separate database not mixed with another type or record. I like Koha but there are some things that need to be improved, for example MARC21 Holding, Free floating subdivision and of course classification records. The problem here is that Koha is developed by software engineers and they do not really consult librarian. Librarian thought Regards -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed May 17 19:02:15 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 17 May 2017 17:02:15 +0000 Subject: [Koha-bugs] [Bug 18478] Hold Notices sent via SMS gateway fail In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18478 Nick Clemens changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #63487|0 |1 is obsolete| | Attachment #63488|0 |1 is obsolete| | --- Comment #5 from Nick Clemens --- Created attachment 63504 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=63504&action=edit Bug 18478 - Some notices sent via SMS gateway fail It seems that for HOLD and DUE (and maybe more) notices we rely on C4::Letters::SendQueuedMessages to populate the correct address. This patch adjust that subroutine to correctly populate the field and/or fail messages if no SMS provider available To test: 1 - Define a messaging prefs for a patron to recieve hold notices via SMS 2 - Ensure you have defined an SMS message for 'HOLD' letter 3 - Set an SMS alert number for patron 4 - Set the SMS::Send driver to 'Email' 5 - Fill a hold for the patron 6 - Check the db and note the address is null 7 - run process_message_queue.pl 8 - Check db - address is null and message pending 9 - Apply patch 10 - run process_message_queue 11 - Message to_address should be populated and message sent -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed May 17 19:02:19 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 17 May 2017 17:02:19 +0000 Subject: [Koha-bugs] [Bug 18478] Hold Notices sent via SMS gateway fail In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18478 --- Comment #6 from Nick Clemens --- Created attachment 63505 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=63505&action=edit Bug 18478 - Unit tests -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed May 17 19:02:22 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 17 May 2017 17:02:22 +0000 Subject: [Koha-bugs] [Bug 18478] Hold Notices sent via SMS gateway fail In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18478 --- Comment #7 from Nick Clemens --- Created attachment 63506 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=63506&action=edit Bug 18478 - Additional unit tests This method was not previously covered, we don't change it , but no reason to throw away these tests to ensure messages are created as expected To test: 1 - Apply this patch first 2 - Prove t/db_dependent/Reserves.t 3 - Last tests fail 4 - Apply other patch 5 - All tests should pass -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed May 17 19:03:50 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 17 May 2017 17:03:50 +0000 Subject: [Koha-bugs] [Bug 18478] Some notices sent via SMS gateway fail In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18478 Nick Clemens changed: What |Removed |Added ---------------------------------------------------------------------------- Summary|Hold Notices sent via SMS |Some notices sent via SMS |gateway fail |gateway fail -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed May 17 19:25:44 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 17 May 2017 17:25:44 +0000 Subject: [Koha-bugs] [Bug 18621] New: After duplicate message system picks category expiry date rather than manual defined Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18621 Bug ID: 18621 Summary: After duplicate message system picks category expiry date rather than manual defined Change sponsored?: --- Product: Koha Version: 16.11 Hardware: All OS: All Status: NEW Severity: major Priority: P5 - low Component: Patrons Assignee: koha-bugs at lists.koha-community.org Reporter: mishravk79 at gmail.com QA Contact: testopia at bugs.koha-community.org CC: gmcharlt at gmail.com, kyle.m.hall at gmail.com After duplicate message system picks category expiry date rather than manual defined, the test is as follows: 1. Try to enter a new member 2. Give member Expiry date which is more than defined in concern category 3. If Koha found similar member than pop up a message 4. Select not a duplicate member (New member option) 5. Koha saved the record but the expiry date will pick from category rather than you assigned the member. 6. If the member is new and no message is populated than it will save expiry date as you defined. Koha version 16.11.07 on debian Jessie installed by package. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed May 17 19:33:23 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 17 May 2017 17:33:23 +0000 Subject: [Koha-bugs] [Bug 18622] New: Require Z39.50 feature to enter bibliographic detail during making purchase suggestion on behalf of Patron Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18622 Bug ID: 18622 Summary: Require Z39.50 feature to enter bibliographic detail during making purchase suggestion on behalf of Patron Change sponsored?: --- Product: Koha Version: 16.11 Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Acquisitions Assignee: koha-bugs at lists.koha-community.org Reporter: mishravk79 at gmail.com QA Contact: testopia at bugs.koha-community.org Koha Provides excellent feature of making purchase suggestion on behalf of patrons through staff client but i feel staff needs Z39.50 feature to fetch the bibliographic details like making purchase suggestion from external records or new entry etc. Or System should provide a option to enter the patron card number if staff is making purchase suggestion through another option. Option like " Requester Card Number" etc. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed May 17 21:17:40 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 17 May 2017 19:17:40 +0000 Subject: [Koha-bugs] [Bug 14537] Rename system preference 'OverdueNoticeBcc' to 'NoticeBcc' In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14537 Marc V?ron changed: What |Removed |Added ---------------------------------------------------------------------------- Text to go in the|The system prefrerence |The system preference release notes|'OverdueNoticeBcc' seems, |'OverdueNoticeBcc' seems, |by its name, to imply that |by its name, to imply that |a BCC will be added to all |a BCC will be added to all |overdue notices. The |overdue notices. The |description says that the |description says that the |address will be added to |address will be added to |all notices. The behavior |all notices. The behavior |of the system follows the |of the system follows the |description, not the system |description, not the system |preference name. The system |preference name. The system |preference is re-named to |preference is re-named to |NoticeBcc. |NoticeBcc. --- Comment #7 from Marc V?ron --- Fixed small typo in text for release notes (prefrence) -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed May 17 21:23:04 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 17 May 2017 19:23:04 +0000 Subject: [Koha-bugs] [Bug 14216] Koha should send a notice (via e-mail/print/or both) when changes are made to a patron account. In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14216 Lisette changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |lisetteslatah at gmail.com -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed May 17 21:23:25 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 17 May 2017 19:23:25 +0000 Subject: [Koha-bugs] [Bug 11556] Send any notice to any patron (or all patrons) on demand In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11556 Lisette changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |lisetteslatah at gmail.com -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed May 17 21:32:09 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 17 May 2017 19:32:09 +0000 Subject: [Koha-bugs] [Bug 18623] New: Send notification on creation of manual invoice Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18623 Bug ID: 18623 Summary: Send notification on creation of manual invoice Change sponsored?: --- Product: Koha Version: unspecified Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Notices Assignee: koha-bugs at lists.koha-community.org Reporter: lisetteslatah at gmail.com QA Contact: testopia at bugs.koha-community.org It would be nice if when adding a manual invoice (say for a damaged item) an e-mail notification could be sent. Currently to tell the patron without them logging into the OPAC or coming into the library we have to send the e-mail manually. This is time consuming if we have a lot of damaged items being processed at once. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed May 17 21:35:05 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 17 May 2017 19:35:05 +0000 Subject: [Koha-bugs] [Bug 17595] Add button for creating manual invoice (aka fine or fee) to patron toolbar In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17595 Lisette changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |lisetteslatah at gmail.com -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed May 17 21:35:49 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 17 May 2017 19:35:49 +0000 Subject: [Koha-bugs] [Bug 17702] Create configuration for account types In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17702 Lisette changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |lisetteslatah at gmail.com -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed May 17 21:36:37 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 17 May 2017 19:36:37 +0000 Subject: [Koha-bugs] [Bug 17596] Simplify accounting UI in staff client In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17596 Lisette changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |lisetteslatah at gmail.com -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed May 17 23:55:54 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 17 May 2017 21:55:54 +0000 Subject: [Koha-bugs] [Bug 17855] New onboarding tool feature to guide users through setting up Koha, and minor web installer UI improvements In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17855 Liz Rea changed: What |Removed |Added ---------------------------------------------------------------------------- Text to go in the|After the web installer has |Koha now has a new tool to release notes|finished the user is |get Koha users up and |redirected to the |running quickly after a new |onboarding tool (with no |install. The user is |authentication required in |prompted to create their |between). In the onboarding |first user, library, |tool they create a: |category code, item type, |Library, Patron category, |and circulation rule just |Item type (if they were not |after the database install |installed in the web |has completed. Getting |installer). |started with Koha has never |In addition to |been easier. |always creating a: | |Patron | |(which has super librarian | |privileges which the user | |will use to log into Koha | |with), Circulation rule | |Then the user is redirected | |to a login page where they | |login using the patron they | |just created. If they | |entered the correct patron | |account credentials the | |Koha homepage will appear, | |and the user can start | |using Koha as intended due | |to all necessary data being | |installed. | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu May 18 00:36:01 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 17 May 2017 22:36:01 +0000 Subject: [Koha-bugs] [Bug 12461] Add patron clubs feature In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12461 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Text to go in the|This features would add the |This features adds the release notes|ability to create clubs |ability to create clubs |which patrons may be |which patrons may be |enrolled in. It would be |enrolled in. It is |particularly useful for |particularly useful for |tracking summer reading |tracking summer reading |programs, book clubs and |programs, book clubs and |other such clubs. |other such clubs. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu May 18 00:36:32 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 17 May 2017 22:36:32 +0000 Subject: [Koha-bugs] [Bug 17233] Add 008 value builder plugin for MARC21 classifications In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17233 Chris Cormack changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |chris at bigballofwax.co.nz --- Comment #13 from Chris Cormack --- (In reply to H?ctor Eduardo Castro Avalos from comment #12) > The problem here is that Koha is developed by software engineers and they do > not really consult librarian. This is both unhelpful, insulting and blatantly wrong. Many of the developers are trained librarians, and I doubt a single feature in Koha has been added without being specced and asked for by librarians. Trying to divide the community will not result in a better system Please stop -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu May 18 00:42:23 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 17 May 2017 22:42:23 +0000 Subject: [Koha-bugs] [Bug 17453] Inter-site holds improvement In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17453 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Text to go in the|At the moment users can |Without this feature users release notes|reserve items and choose |could reserve items and |any library as a pick up |choose any library as a |location, but there is no |pick up location, but there |mechanism to prevent users |was no mechanism to prevent |from reserving items that |users from reserving items |are available on the shelf |that were available on the |at any given location from |shelf at any given location |reserving the item at the |from reserving the item at |same location, essentially |the same location, |creating a Fetch and |essentially creating a |Collect scenario. |Fetch and Collect scenario. |This has |This had an impact on staff |an impact on staff |workloads as they had to |workloads as they are |process reservations and |having to process |check shelves for items |reservations and check |that students could have |shelves for items that |collected from the open |students can already come |library shelves. |and collect from the open |This |library shelves. |enhancement decreases the |The aim of |impact on staff workload by |this enhancement is to |making it possible to |decrease the impact on |prevent users from |staff workload there |requesting items for pick |should |up at a library where the |be a restriction in place |item is currently |that prevents users from |available. |requesting items for | |collection at a library | |where the item is currently | |available. | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu May 18 00:44:06 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 17 May 2017 22:44:06 +0000 Subject: [Koha-bugs] [Bug 14224] patron notes about item shown at check in In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14224 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Text to go in the|This patch adds a "Note" |This feature adds a "Note" release notes|input field to checked out |input field to checked out |items in the "your summary" |items in the "your summary" |section. The field allows |section of the patron |patrons to write notes |account in the OPAC. The |about the item checked out, |field allows patrons to |such as "this DVD is |write notes about the item, |scratched", "the binding |such as "this DVD is |was torn", etc. The note |scratched", "the binding |will be emailed to the |was torn", etc. The note |library and displayed on |will be emailed to the |item check in. |library and displayed on | |check in. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu May 18 07:56:47 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 18 May 2017 05:56:47 +0000 Subject: [Koha-bugs] [Bug 18066] Hea - Version 2 In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18066 Zeno Tajoli changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |z.tajoli at cineca.it Text to go in the| |Hea is a website to collect release notes| |data from libraries using | |Koha. | |With this develop | |Hea could collect | |geolocation to display the | |Koha installations on a map | |and it collectd data per | |library instead of per Koha | |installation. | |Now under | |Administation there is a | |new web page to setup what | |share. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu May 18 08:15:26 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 18 May 2017 06:15:26 +0000 Subject: [Koha-bugs] [Bug 18066] Hea - Version 2 In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18066 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Text to go in the|Hea is a website to collect |Hea is a website to collect release notes|data from libraries using |usage data from libraries |Koha. |using Koha. With this |With this develop |development Hea can collect |Hea could collect |the geolocations of the |geolocation to display the |libraries in your |Koha installations on a map |installation create a map. |and it collectd data per |A new configuration page |library instead of per Koha |allows to configure easily |installation. |what information is shared |Now under |with the Koha community. |Administation there is a | |new web page to setup what | |share. | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu May 18 09:06:26 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 18 May 2017 07:06:26 +0000 Subject: [Koha-bugs] [Bug 18620] t/db_dependent/Letters.t failing on master In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18620 Marc V?ron changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #63503|0 |1 is obsolete| | --- Comment #3 from Marc V?ron --- Created attachment 63507 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=63507&action=edit Bug 18620 - t/db_dependent/Letters.t failing on master To test: 1 - Set SMSSenDriver to 'Email' 2 - prove t/db_dependent/Letters.t 3 - Tests fail 4 - Apply patch 5 - prove t/db_dependent/Letters.t 6 - Less tests fail (should be 2 sms test failures) 7 - Set SMSSendDriver to another value or blank 8 - prove t/db_dependent/Letters.t 9 - Tests pass Signed-off-by: Marc V?ron -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu May 18 09:06:36 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 18 May 2017 07:06:36 +0000 Subject: [Koha-bugs] [Bug 18620] t/db_dependent/Letters.t failing on master In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18620 Marc V?ron changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off CC| |veron at veron.ch -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu May 18 09:10:22 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 18 May 2017 07:10:22 +0000 Subject: [Koha-bugs] [Bug 18465] Patron card creator: Print on duplex card printer In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18465 --- Comment #13 from Marc V?ron --- Still applies on current master -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu May 18 09:11:05 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 18 May 2017 07:11:05 +0000 Subject: [Koha-bugs] [Bug 18541] Patron card creator: Add a grid to support layout design In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18541 --- Comment #9 from Marc V?ron --- Still applies on current master -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu May 18 09:11:52 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 18 May 2017 07:11:52 +0000 Subject: [Koha-bugs] [Bug 18550] Patron card creator: Print output does not respect layout units In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18550 --- Comment #5 from Marc V?ron --- Still applies on current master -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu May 18 09:13:31 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 18 May 2017 07:13:31 +0000 Subject: [Koha-bugs] [Bug 18528] Patron card creator template: switch form fields for card height and card width In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18528 --- Comment #4 from Marc V?ron --- Still applies on current master -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu May 18 09:15:13 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 18 May 2017 07:15:13 +0000 Subject: [Koha-bugs] [Bug 18555] Create patron list from patron import In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18555 --- Comment #4 from Marc V?ron --- Still applies on current master -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu May 18 09:16:28 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 18 May 2017 07:16:28 +0000 Subject: [Koha-bugs] [Bug 17381] Add system preference SCOMainUserBlock In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17381 --- Comment #5 from Marc V?ron --- Still applies on current master -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu May 18 09:18:44 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 18 May 2017 07:18:44 +0000 Subject: [Koha-bugs] [Bug 18472] Add system preferences to manage online help system In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18472 --- Comment #22 from Marc V?ron --- Still applies on current master -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu May 18 09:19:02 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 18 May 2017 07:19:02 +0000 Subject: [Koha-bugs] [Bug 18483] Customised help: Enhance staff client with news based, easily editable help system In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18483 --- Comment #19 from Marc V?ron --- Still applies on current master -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu May 18 09:40:44 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 18 May 2017 07:40:44 +0000 Subject: [Koha-bugs] [Bug 18624] New: Run time errors when searching authorities with Elastic search 5.3 Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18624 Bug ID: 18624 Summary: Run time errors when searching authorities with Elastic search 5.3 Change sponsored?: --- Product: Koha Version: master Hardware: PC OS: Linux Status: NEW Severity: critical Priority: P5 - low Component: Searching Assignee: gmcharlt at gmail.com Reporter: david.holoshka at ub.lu.se QA Contact: testopia at bugs.koha-community.org Searching for a known authority entry (eg. Bear or Meyer) results in either the following runtime errors or no result (sort none). Sort on finds nothing Header search only $a: Software error: Invalid marclist field provided: all at /usr/local/koha/Koha/SearchEngine/Elasticsearch/QueryBuilder.pm line 433. Koha::SearchEngine::Elasticsearch::QueryBuilder::build_authorities_query_compat(Koha::SearchEngine::Elasticsearch::QueryBuilder=HASH(0x90e2110), ARRAY(0x90d4630), ARRAY(0x90d4660), ARRAY(0x914bf30), ARRAY(0x912f6b0), ARRAY(0x912f0f8), "", "") called at /usr/local/koha/authorities/authorities-home.pl line 93 Search Main Heading : Software error: Can't use string ("9932563") as an ARRAY ref while "strict refs" in use at /usr/local/koha/Koha/SearchEngine/Elasticsearch/Search.pm line 202. auth index entry in elastic search: { "_index" : "koha_ulibrary_authorities", "_type" : "data", "_id" : "1756", "_score" : 1.0, "_source" : { "Personal-name-see-also-from" : null, "Meeting-name-heading" : null, "Personal-name" : [ "Bear, Roberta Meyer" ], "Corporate-name-see-also-from" : null, "Heading-use-series-added-entry" : " ", "es_id" : "1756", "See-also-from" : null, "Meeting-name-see-also-from" : null, "LC-card-number" : null, "record" : [ [ "LDR", null, null, "_", "00262nz a2200121o 4500" ], [ "001", null, null, "_", "11072" ], [ "003", null, null, "_", "LDU" ], [ "005", null, null, "_", "20170405133903.0" ], [ "008", null, null, "_", "170405930116 a aabn a aaa" ], [ "040", " ", " ", "a", "L", "c", "L" ], [ "100", "1", " ", "a", "Bear, Roberta Meyer" ], [ "400", "1", " ", "a", "Meyer Bear, Roberta" ], [ "942", " ", " ", "a", "PERSO_NAME" ], [ "999", " ", " ", "c", "1756", "d", "1756" ] ], "Match-heading-see-from" : null, "record-source" : [ "L", "L" ], "Heading-use-main-or-added-entry" : " ", "Meeting-name-see-from" : null, "Personal-name-heading" : [ "Bear, Roberta Meyer" ], "Heading-use-subject-added-entry" : "a", "Personal-name-see-from" : [ "Meyer Bear, Roberta" ], "Local-number" : [ "11072" ], "Corporate-name-see-from" : null, "Match" : null, "authtype" : [ "PERSO_NAME" ], "Kind-of-record" : "1", "Match-heading" : [ "Bear, Roberta Meyer" ], "Descriptive-cataloging-rules" : "1", "See-from" : null, "Heading" : [ "Bear, Roberta Meyer" ], "Heading-Main" : null, "Subject-heading-thesaurus" : "6", "Meeting-name" : null } }, We are using the default field mapping. Koha running on Debian, I have applied a patch not yet on main (Bug 18434 - Elasticsearch indexing broken with newer catmandu version ) to make the biblio search work. Mysql ES 5.3 (it seems to be working fine) on oracle java 8 Marc 21 All perl catmandu modules are the latest from cpanm. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu May 18 09:56:49 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 18 May 2017 07:56:49 +0000 Subject: [Koha-bugs] [Bug 18356] Prediction pattern wrong, skips years, for some year based frequencies In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18356 Marcel de Rooy changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |BLOCKED --- Comment #4 from Marcel de Rooy --- Still thinking about an adjustment. Please wait. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu May 18 11:21:12 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 18 May 2017 09:21:12 +0000 Subject: [Koha-bugs] [Bug 18606] Move rotating collections code to Koha::Object In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18606 --- Comment #1 from Josef Moravec --- Created attachment 63508 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=63508&action=edit Bug 18606: Add Koha::RotatingCollection[s] object classes Test plan: 1) Apply the patch 2) Update database 3) Go to tools -> Rotating collections and play with trying to break it: 3a) Add some collections 3b) Edit them 3c) Add some items to collections 3d) Remove some items 3e) Transfer some collections 3f) Try to remove collection without items 3g) Try to remove collection with items 4) Go to returns and: 4a) Try to return item from untransferred collection 4b) Try to return item from transferred collection 5) prove t/db_dependent/Koha/RotatingCollections.t t/db_dependent/Koha/Items.t t/db_dependent/Circulation.t t/db_dependent/Circulation/Returns.t -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu May 18 11:21:17 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 18 May 2017 09:21:17 +0000 Subject: [Koha-bugs] [Bug 18606] Move rotating collections code to Koha::Object In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18606 --- Comment #2 from Josef Moravec --- Created attachment 63509 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=63509&action=edit Bug 18606: Get rid of DeleteCollection -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu May 18 11:21:21 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 18 May 2017 09:21:21 +0000 Subject: [Koha-bugs] [Bug 18606] Move rotating collections code to Koha::Object In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18606 --- Comment #3 from Josef Moravec --- Created attachment 63510 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=63510&action=edit Bug 18606: Get rid of GetCollection -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu May 18 11:21:25 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 18 May 2017 09:21:25 +0000 Subject: [Koha-bugs] [Bug 18606] Move rotating collections code to Koha::Object In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18606 --- Comment #4 from Josef Moravec --- Created attachment 63511 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=63511&action=edit Bug 18606: Get rid off GetCollections -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu May 18 11:21:29 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 18 May 2017 09:21:29 +0000 Subject: [Koha-bugs] [Bug 18606] Move rotating collections code to Koha::Object In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18606 --- Comment #5 from Josef Moravec --- Created attachment 63512 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=63512&action=edit Bug 18606: Get rid of CreateCollection -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu May 18 11:21:33 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 18 May 2017 09:21:33 +0000 Subject: [Koha-bugs] [Bug 18606] Move rotating collections code to Koha::Object In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18606 --- Comment #6 from Josef Moravec --- Created attachment 63513 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=63513&action=edit Bug 18606: Get rid of UpdateCollection -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu May 18 11:21:37 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 18 May 2017 09:21:37 +0000 Subject: [Koha-bugs] [Bug 18606] Move rotating collections code to Koha::Object In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18606 --- Comment #7 from Josef Moravec --- Created attachment 63514 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=63514&action=edit Bug 18606: Database changes - Add foreign keys to collections_tracking -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu May 18 11:21:41 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 18 May 2017 09:21:41 +0000 Subject: [Koha-bugs] [Bug 18606] Move rotating collections code to Koha::Object In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18606 --- Comment #8 from Josef Moravec --- Created attachment 63515 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=63515&action=edit Bug 18606: Schema changes -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu May 18 11:21:46 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 18 May 2017 09:21:46 +0000 Subject: [Koha-bugs] [Bug 18606] Move rotating collections code to Koha::Object In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18606 --- Comment #9 from Josef Moravec --- Created attachment 63516 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=63516&action=edit Bug 18606: Get rid of GetItemsInCollection -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu May 18 11:21:50 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 18 May 2017 09:21:50 +0000 Subject: [Koha-bugs] [Bug 18606] Move rotating collections code to Koha::Object In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18606 --- Comment #10 from Josef Moravec --- Created attachment 63517 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=63517&action=edit Bug 18606: Get rid of GetCollectionItemBranches -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu May 18 11:21:58 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 18 May 2017 09:21:58 +0000 Subject: [Koha-bugs] [Bug 18606] Move rotating collections code to Koha::Object In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18606 --- Comment #12 from Josef Moravec --- Created attachment 63519 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=63519&action=edit Bug 18606: Get rid of AddItemToCollection -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu May 18 11:21:54 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 18 May 2017 09:21:54 +0000 Subject: [Koha-bugs] [Bug 18606] Move rotating collections code to Koha::Object In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18606 --- Comment #11 from Josef Moravec --- Created attachment 63518 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=63518&action=edit Bug 18606: Add RotatingCollectionTracking objects -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu May 18 11:22:02 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 18 May 2017 09:22:02 +0000 Subject: [Koha-bugs] [Bug 18606] Move rotating collections code to Koha::Object In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18606 --- Comment #13 from Josef Moravec --- Created attachment 63520 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=63520&action=edit Bug 18606: Get rid of RemoveItemFromCollection -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu May 18 11:22:09 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 18 May 2017 09:22:09 +0000 Subject: [Koha-bugs] [Bug 18606] Move rotating collections code to Koha::Object In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18606 --- Comment #14 from Josef Moravec --- Created attachment 63521 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=63521&action=edit Bug 18606: Get rid of TransferCollection -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu May 18 11:22:13 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 18 May 2017 09:22:13 +0000 Subject: [Koha-bugs] [Bug 18606] Move rotating collections code to Koha::Object In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18606 --- Comment #15 from Josef Moravec --- Created attachment 63522 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=63522&action=edit Bug 18606: Get rid of isItemInThisCollection -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu May 18 11:22:17 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 18 May 2017 09:22:17 +0000 Subject: [Koha-bugs] [Bug 18606] Move rotating collections code to Koha::Object In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18606 --- Comment #16 from Josef Moravec --- Created attachment 63523 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=63523&action=edit Bug 18606: Get rid of isItemInAnyCollection -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu May 18 11:22:22 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 18 May 2017 09:22:22 +0000 Subject: [Koha-bugs] [Bug 18606] Move rotating collections code to Koha::Object In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18606 --- Comment #17 from Josef Moravec --- Created attachment 63524 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=63524&action=edit Bug 18606: Remove lefover of C4::RotatingCollections -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu May 18 11:22:26 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 18 May 2017 09:22:26 +0000 Subject: [Koha-bugs] [Bug 18606] Move rotating collections code to Koha::Object In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18606 --- Comment #18 from Josef Moravec --- Created attachment 63525 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=63525&action=edit Bug 18606: Rework tests for rotating collections -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu May 18 11:22:30 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 18 May 2017 09:22:30 +0000 Subject: [Koha-bugs] [Bug 18606] Move rotating collections code to Koha::Object In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18606 --- Comment #19 from Josef Moravec --- Created attachment 63526 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=63526&action=edit Bug 18606: Fix issues to pass tests -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu May 18 11:22:38 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 18 May 2017 09:22:38 +0000 Subject: [Koha-bugs] [Bug 18606] Move rotating collections code to Koha::Object In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18606 --- Comment #21 from Josef Moravec --- Created attachment 63528 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=63528&action=edit Bug 18606: Unify handling of success/error messages -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu May 18 11:22:34 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 18 May 2017 09:22:34 +0000 Subject: [Koha-bugs] [Bug 18606] Move rotating collections code to Koha::Object In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18606 --- Comment #20 from Josef Moravec --- Created attachment 63527 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=63527&action=edit Bug 18606: Add test to t/db_dependent/Koha/Items.t -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu May 18 11:24:31 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 18 May 2017 09:24:31 +0000 Subject: [Koha-bugs] [Bug 18606] Move rotating collections code to Koha::Object In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18606 Josef Moravec changed: What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |Needs Signoff --- Comment #22 from Josef Moravec --- Not 100% ready, but I need some feedback. Note that the transfers subtesto to RotatingCollections.t is not passsing. I don't know how to implement item transfering in Koha::RotatingCollection module yet. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu May 18 11:42:11 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 18 May 2017 09:42:11 +0000 Subject: [Koha-bugs] [Bug 18598] Quick add form doesn't clear values when switching In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18598 Marc V?ron changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Failed QA CC| |veron at veron.ch --- Comment #2 from Marc V?ron --- I can reproduce the behaviour without patch. With patch, clearing works as described. However, with patch applied the values e.g. for surname are no longer transferred between the two forms. If I enter a surname AAA in quick add form and switch to full form, surname is empty. If then in full form I enter BBB as surname and switch back to quick add form, there is still AAA. Switching back to full form shows BBB. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu May 18 11:46:01 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 18 May 2017 09:46:01 +0000 Subject: [Koha-bugs] [Bug 16568] Talking Tech generates phone notifications for all overdue actions In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16568 PTFS Europe Sandboxes changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |sandboxes at ptfs-europe.com Status|Needs Signoff |Signed Off --- Comment #2 from PTFS Europe Sandboxes --- Patch tested with a sandbox, by Jonathan Field -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu May 18 11:46:14 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 18 May 2017 09:46:14 +0000 Subject: [Koha-bugs] [Bug 16568] Talking Tech generates phone notifications for all overdue actions In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16568 PTFS Europe Sandboxes changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #51719|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu May 18 11:46:22 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 18 May 2017 09:46:22 +0000 Subject: [Koha-bugs] [Bug 16568] Talking Tech generates phone notifications for all overdue actions In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16568 --- Comment #3 from PTFS Europe Sandboxes --- Created attachment 63529 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=63529&action=edit Bug 16568 - Talking Tech generates phone notifications for all overdue actions Regardless of whether the phone transport has been selected for a given overdue action or not, the Talking Tech outbound script generates and sends a line for that action. Test Plan: 1) Enable Talking Tech 2) Create one or more overdue actions without a phone transport selected and one or more with the phone transport selected 3) Generate the overdues csv file to send to Itive 4) Note the csv file has lines for actions that do not have the phone transport selected 5) Apply this patch 6) Repeat step 3 7) Note the csv file now only has lines for actions that have the phone transport selected Signed-off-by: Jonathan Field -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu May 18 12:11:30 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 18 May 2017 10:11:30 +0000 Subject: [Koha-bugs] [Bug 18137] REST API: Migrate from Mojolicious::Plugin:: Swagger2 to Mojolicious::Plugin::OpenAPI In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18137 --- Comment #79 from Mirko Tietgen --- I have uploaded preliminary versions of libjson-validator-perl_0.97-1_all.deb libmojolicious-plugin-openapi-perl_1.15-1~kohadev1_all.deb to the unstable repository. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu May 18 12:18:16 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 18 May 2017 10:18:16 +0000 Subject: [Koha-bugs] [Bug 18137] REST API: Migrate from Mojolicious::Plugin:: Swagger2 to Mojolicious::Plugin::OpenAPI In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18137 --- Comment #80 from Mirko Tietgen --- I have uploaded preliminary versions of libjson-validator-perl_0.97-1~kohadev1_all.deb libmojolicious-plugin-openapi-perl_1.15-1~kohadev1_all.deb to the unstable repository -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu May 18 14:31:12 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 18 May 2017 12:31:12 +0000 Subject: [Koha-bugs] [Bug 15879] Allow multiple plugin directories to be defined in koha-conf.xml In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15879 Zeno Tajoli changed: What |Removed |Added ---------------------------------------------------------------------------- Text to go in the| |Now is possible to define release notes| |multiple plugin directories | |in the Koha conf file. This | |would allow for ease of | |plugin development so that | |each plugin installed can | |live in its own git | |repository. For | |compatibility, the first | |plugindir instance defined | |is used for uploading | |plugins via the web | |interface. Patch complexity|--- |Small patch CC| |z.tajoli at cineca.it -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu May 18 14:39:39 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 18 May 2017 12:39:39 +0000 Subject: [Koha-bugs] [Bug 17762] Ability to translate notices In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17762 Zeno Tajoli changed: What |Removed |Added ---------------------------------------------------------------------------- Text to go in the| |This develop adds the release notes| |ability to translate | |notices in different | |languages. That way, if a | |library has patrons from | |different countries, they | |will not have to send the | |notices in only one | |language but they will be | |able to translate them. | |In | |patron's details page you | |can see a new "prefered | |language" entry, you select | |a language to use it in | |letters. CC| |z.tajoli at cineca.it -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu May 18 14:51:15 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 18 May 2017 12:51:15 +0000 Subject: [Koha-bugs] [Bug 12026] Shibboleth auto-provisioning - Create In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12026 Zeno Tajoli changed: What |Removed |Added ---------------------------------------------------------------------------- Text to go in the| |This patch was only ever release notes| |intended to 'add new' user | |record from Shibboleth into | |Koha ('provision') and not | |to 'sync' Shibboleth with | |an existing Koha user. It | |is possible to map | |Sbibboleth's attributes | |with Koha fields, the | |configuration is done in | |koha-conf.xml -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu May 18 14:54:38 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 18 May 2017 12:54:38 +0000 Subject: [Koha-bugs] [Bug 17486] Remove 'Mozilla Persona' as an authentication method In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17486 Zeno Tajoli changed: What |Removed |Added ---------------------------------------------------------------------------- Text to go in the| |'Persona' never really took release notes| |off, and although many | |browsers currently support | |it, very few services | |actually implement it. This | |has lead to it's founders, | |Mozilla, to end the | |project. On November 30th, | |2016, Mozilla closed the | |persona.org services. Now | |the feature is deleted from | |Koha. CC| |z.tajoli at cineca.it -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu May 18 15:11:15 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 18 May 2017 13:11:15 +0000 Subject: [Koha-bugs] [Bug 17960] Rename opac_news.new with opac_news.content In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17960 Zeno Tajoli changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |z.tajoli at cineca.it Text to go in the|NOTICE - If you are using |The db field opac_news.new release notes|opac_news.new in your |is renamed |notice templates, you |opac_news.content. |should update it to |So if |opac_news.content |you are using opac_news.new | |in your notice templates, | |you should update it to | |opac_news.content. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu May 18 15:18:46 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 18 May 2017 13:18:46 +0000 Subject: [Koha-bugs] [Bug 17233] Add 008 value builder plugin for MARC21 classifications In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17233 Zeno Tajoli changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |z.tajoli at cineca.it Text to go in the| |This patch adds 008 release notes| |cataloguing value builder | |for MARC21 classifications | |records (LCC, DDC/Dewey, | |UDC and so on). | |In fact now | |Koha doesn't really support | |classification records, | |this is a starting point. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu May 18 15:26:06 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 18 May 2017 13:26:06 +0000 Subject: [Koha-bugs] [Bug 8361] Issuing rule if no rule is defined In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8361 Zeno Tajoli changed: What |Removed |Added ---------------------------------------------------------------------------- Text to go in the| |In the previous versions if release notes| |no issuing rule is defined, | |Koha always grantd issuing. | |Now, with this develop, | |Koha refuses any check-out | |if no rule is found. CC| |z.tajoli at cineca.it -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu May 18 15:35:44 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 18 May 2017 13:35:44 +0000 Subject: [Koha-bugs] [Bug 10383] printable version of bib record doesn' t include subtitle in staff client In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10383 --- Comment #2 from Alex Arnaud --- Created attachment 63530 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=63530&action=edit Bug 10382 - Course reserves: handle empty values DB changes: - remove course_items_ibfk_2, - set course_items.itype to VARCHAR(20), - set course_items.ccode to VARCHAR(20), - set course_items.holdingbranch to VARCHAR(20), -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu May 18 15:39:20 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 18 May 2017 13:39:20 +0000 Subject: [Koha-bugs] [Bug 18625] New: update borrower last seen from SIP Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18625 Bug ID: 18625 Summary: update borrower last seen from SIP Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: SIP2 Assignee: koha-bugs at lists.koha-community.org Reporter: colin.campbell at ptfs-europe.com QA Contact: testopia at bugs.koha-community.org CC: colin.campbell at ptfs-europe.com Bug 16276 added a syspref and field for last seen. In addition to the places there it should also be updated from SIP. The rationale is this in addition to the self check functions handled by sip an increasing number of packages are available which use sip to authenticate users as being valid library patrons to access various resources e.g. computer equipment, ebooks or services via a proxy. Some library patrons may only be using the library to access the internet (validated by sip) and never borrower items or sign in via the opac. The proposal is to update last seen if the borrower is a subject of a 63 (Patron Information request) from sip. We have a number of sites currently maintaining this in a patron attribute. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu May 18 15:41:48 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 18 May 2017 13:41:48 +0000 Subject: [Koha-bugs] [Bug 16276] When automatically deleting expired borrowers, make sure they didn't log in recently In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16276 Colin Campbell changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |colin.campbell at ptfs-europe. | |com --- Comment #46 from Colin Campbell --- New bug 18625 to update the field if 'last seen' is from a sip patron info request (used to validate patron for access to resources) -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu May 18 15:51:19 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 18 May 2017 13:51:19 +0000 Subject: [Koha-bugs] [Bug 10383] printable version of bib record doesn' t include subtitle in staff client In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10383 Alex Arnaud changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |alex.arnaud at biblibre.com Attachment #63530|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu May 18 15:52:04 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 18 May 2017 13:52:04 +0000 Subject: [Koha-bugs] [Bug 10382] collection not returning to null when removed from course reserves In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10382 Alex Arnaud changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #61816|0 |1 is obsolete| | --- Comment #29 from Alex Arnaud --- Created attachment 63531 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=63531&action=edit Bug 10382 - Course reserves: handle empty values DB changes: - remove course_items_ibfk_2, - set course_items.itype to VARCHAR(20), - set course_items.ccode to VARCHAR(20), - set course_items.holdingbranch to VARCHAR(20), https://bugs.koha-community.org/show_bug.cgi?id=10383 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu May 18 15:52:31 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 18 May 2017 13:52:31 +0000 Subject: [Koha-bugs] [Bug 10382] collection not returning to null when removed from course reserves In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10382 Alex Arnaud changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu May 18 16:13:13 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 18 May 2017 14:13:13 +0000 Subject: [Koha-bugs] [Bug 18625] update borrower last seen from SIP In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18625 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on| |16276 CC| |jonathan.druart at bugs.koha-c | |ommunity.org Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16276 [Bug 16276] When automatically deleting expired borrowers, make sure they didn't log in recently -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Thu May 18 16:13:13 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 18 May 2017 14:13:13 +0000 Subject: [Koha-bugs] [Bug 16276] When automatically deleting expired borrowers, make sure they didn't log in recently In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16276 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |18625 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18625 [Bug 18625] update borrower last seen from SIP -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu May 18 16:35:34 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 18 May 2017 14:35:34 +0000 Subject: [Koha-bugs] [Bug 18626] New: Add ability to track cardnumber changes for patrons Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18626 Bug ID: 18626 Summary: Add ability to track cardnumber changes for patrons Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Patrons Assignee: koha-bugs at lists.koha-community.org Reporter: kyle at bywatersolutions.com QA Contact: testopia at bugs.koha-community.org CC: gmcharlt at gmail.com, kyle.m.hall at gmail.com Some libraries want to keep a history of cardnumber changes for a patron. This is a feature that another ILS has. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Thu May 18 16:35:40 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 18 May 2017 14:35:40 +0000 Subject: [Koha-bugs] [Bug 18626] Add ability to track cardnumber changes for patrons In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18626 Kyle M Hall changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|koha-bugs at lists.koha-commun |kyle at bywatersolutions.com |ity.org | -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu May 18 16:38:48 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 18 May 2017 14:38:48 +0000 Subject: [Koha-bugs] [Bug 18626] Add ability to track cardnumber changes for patrons In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18626 Kyle M Hall changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff Patch complexity|--- |Small patch -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu May 18 16:38:51 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 18 May 2017 14:38:51 +0000 Subject: [Koha-bugs] [Bug 18626] Add ability to track cardnumber changes for patrons In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18626 --- Comment #1 from Kyle M Hall --- Created attachment 63532 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=63532&action=edit Bug 18626 - Add ability to track cardnumber changes for patrons Some libraries want to keep a history of cardnumber changes for a patron. This is a feature that another ILS has. Test Plan: 1) Apply this patch 2) Enable the BorrowersLog 3) Modify a patron, update his or her cardnumber 4) Notice the entry in the action log containing the old and new cardnumbers 5) Edit a patron, leave the cardnumber the same 6) Note there is no cardnumber change entry in the action logs 7) Disable BorrowersLog, modify a patron cardnumber 8) Note there is no cardnumber change entry in teh action logs -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu May 18 16:53:09 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 18 May 2017 14:53:09 +0000 Subject: [Koha-bugs] [Bug 18620] t/db_dependent/Letters.t failing on master In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18620 --- Comment #4 from Jonathan Druart --- Nick, you are not fixing the issue here :) -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu May 18 16:55:06 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 18 May 2017 14:55:06 +0000 Subject: [Koha-bugs] [Bug 18620] t/db_dependent/Letters.t failing on master In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18620 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |18478 --- Comment #5 from Jonathan Druart --- (In reply to Jonathan Druart from comment #4) > Nick, you are not fixing the issue here :) Ok, forget that! Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18478 [Bug 18478] Some notices sent via SMS gateway fail -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu May 18 16:55:06 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 18 May 2017 14:55:06 +0000 Subject: [Koha-bugs] [Bug 18478] Some notices sent via SMS gateway fail In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18478 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on| |18620 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18620 [Bug 18620] t/db_dependent/Letters.t failing on master -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu May 18 16:55:30 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 18 May 2017 14:55:30 +0000 Subject: [Koha-bugs] [Bug 18478] Some notices sent via SMS gateway fail In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18478 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Version|16.11 |master CC| |jonathan.druart at bugs.koha-c | |ommunity.org -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu May 18 16:57:57 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 18 May 2017 14:57:57 +0000 Subject: [Koha-bugs] [Bug 18478] Some notices sent via SMS gateway fail In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18478 --- Comment #8 from Jonathan Druart --- One test fails for me prove t/db_dependent/Reserves.t t/db_dependent/Reserves.t .. 55/72 No reserves HOLD letter transported by sms at /home/vagrant/kohaclone/C4/Letters.pm line 697. Could not find a letter called 'HOLD' for sms in the 'reserves' module at /home/vagrant/kohaclone/C4/Reserves.pm line 1883. # No tests run! # Failed test 'No tests run for subtest "_koha_notify_reserve() tests"' # at t/db_dependent/Reserves.t line 779. Can't call method "to_address" on an undefined value at t/db_dependent/Reserves.t line 763. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu May 18 17:02:32 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 18 May 2017 15:02:32 +0000 Subject: [Koha-bugs] [Bug 17233] Add 008 value builder plugin for MARC21 classifications In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17233 --- Comment #14 from H?ctor Eduardo Castro Avalos --- (In reply to Chris Cormack from comment #13) Hi Chris > This is both unhelpful, insulting and blatantly wrong. > Many of the developers are trained librarians, and I doubt a single feature > in Koha has been added without being specced and asked for by librarians. > > Trying to divide the community will not result in a better system > > Please stop I wasn't try to insult anybody with a simple commentary. Ok, I accept that commentary is in the wrong way, but at the same time, I think it's not the way to react. I accept that you call my attention, but not in that way. And of course I do not want to divide the community, I think that this project is a good effort of many people around the world like you, who has spent a lot of time developing Koha. Please accept my apologize. Regards -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu May 18 17:05:55 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 18 May 2017 15:05:55 +0000 Subject: [Koha-bugs] [Bug 18478] Some notices sent via SMS gateway fail In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18478 --- Comment #9 from Jonathan Druart --- This: $message->{to_address} = $message->{to_address} ? $message->{to_address} : $member->{'smsalertnumber'}; is actually: $message->{to_address} ||= $member->{smsalertnumber}; -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu May 18 17:07:39 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 18 May 2017 15:07:39 +0000 Subject: [Koha-bugs] [Bug 18478] Some notices sent via SMS gateway fail In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18478 --- Comment #10 from Jonathan Druart --- The call to _update_message_to_address just before _send_message_by_email should not be needed, it is already called from _send_message_by_email. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu May 18 17:07:50 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 18 May 2017 15:07:50 +0000 Subject: [Koha-bugs] [Bug 18478] Some notices sent via SMS gateway fail In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18478 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Failed QA -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu May 18 17:08:11 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 18 May 2017 15:08:11 +0000 Subject: [Koha-bugs] [Bug 18620] t/db_dependent/Letters.t failing on master In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18620 --- Comment #6 from Jonathan Druart --- Waiting for bug 18478, to QA them altogether. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu May 18 17:11:59 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 18 May 2017 15:11:59 +0000 Subject: [Koha-bugs] [Bug 18538] OPAC database user login internal server error In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18538 --- Comment #6 from Jonathan Druart --- (In reply to Jonathan Druart from comment #5) > I'd prefer to handle the error (more or less gracefully) raising an > exception from C4::Auth, rather than assuming that it's possible to login > with this user. Make me think to "Bug 18403: Add sub output_and_exit_if_error - unknown_patron & cannot_see_patron_infos" -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu May 18 17:28:31 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 18 May 2017 15:28:31 +0000 Subject: [Koha-bugs] [Bug 18625] update borrower last seen from SIP In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18625 Colin Campbell changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|koha-bugs at lists.koha-commun |colin.campbell at ptfs-europe. |ity.org |com Status|NEW |Needs Signoff --- Comment #1 from Colin Campbell --- Created attachment 63533 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=63533&action=edit proposed patch -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Thu May 18 17:32:31 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 18 May 2017 15:32:31 +0000 Subject: [Koha-bugs] [Bug 10382] collection not returning to null when removed from course reserves In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10382 Alex Arnaud changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu May 18 17:37:14 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 18 May 2017 15:37:14 +0000 Subject: [Koha-bugs] [Bug 18625] update borrower last seen from SIP In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18625 Jonathan Field changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |jonathan.field at ptfs-europe. | |com -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu May 18 17:47:23 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 18 May 2017 15:47:23 +0000 Subject: [Koha-bugs] [Bug 18627] New: Items created via MarcItemFieldsToOrder are not linked to orders Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18627 Bug ID: 18627 Summary: Items created via MarcItemFieldsToOrder are not linked to orders Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: critical Priority: P5 - low Component: Acquisitions Assignee: koha-bugs at lists.koha-community.org Reporter: kyle at bywatersolutions.com QA Contact: testopia at bugs.koha-community.org If using MarcItemFieldsToOrder with AcqCreateItem = Create, the order and the items will be created, but they will not be linked via aqorders_items! -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu May 18 17:47:28 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 18 May 2017 15:47:28 +0000 Subject: [Koha-bugs] [Bug 18627] Items created via MarcItemFieldsToOrder are not linked to orders In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18627 Kyle M Hall changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|koha-bugs at lists.koha-commun |kyle at bywatersolutions.com |ity.org | -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu May 18 17:48:27 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 18 May 2017 15:48:27 +0000 Subject: [Koha-bugs] [Bug 18627] Items created via MarcItemFieldsToOrder are not linked to orders In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18627 Kyle M Hall changed: What |Removed |Added ---------------------------------------------------------------------------- Severity|critical |blocker -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu May 18 17:53:50 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 18 May 2017 15:53:50 +0000 Subject: [Koha-bugs] [Bug 18627] Items created via MarcItemFieldsToOrder are not linked to orders In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18627 Kyle M Hall changed: What |Removed |Added ---------------------------------------------------------------------------- Patch complexity|--- |Small patch Status|NEW |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu May 18 17:53:53 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 18 May 2017 15:53:53 +0000 Subject: [Koha-bugs] [Bug 18627] Items created via MarcItemFieldsToOrder are not linked to orders In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18627 --- Comment #1 from Kyle M Hall --- Created attachment 63534 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=63534&action=edit Bug 18627 - Items created via MarcItemFieldsToOrder are not linked to orders If using MarcItemFieldsToOrder with AcqCreateItem = Create, the order and the items will be created, but they will not be linked via aqorders_items! Test Plan: 1) Enable creation of items when ordering 2) Set up MarcItemFieldsToOrder 3) Upload an order record that uses the fields in step 2 4) Create a basket and add the records from the file 5) Note the order and items are created, but no rows in aqorders_items are created 6) Apply this patch 7) Repeat steps 3-4 8) Note the rows in aqorders_items are created! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu May 18 18:51:46 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 18 May 2017 16:51:46 +0000 Subject: [Koha-bugs] [Bug 18627] Items created via MarcItemFieldsToOrder are not linked to orders In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18627 Nick Clemens changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |nick at bywatersolutions.com -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu May 18 19:03:48 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 18 May 2017 17:03:48 +0000 Subject: [Koha-bugs] [Bug 18628] New: Reference books shows as unavailable Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18628 Bug ID: 18628 Summary: Reference books shows as unavailable Change sponsored?: --- Product: Koha Version: 16.11 Hardware: All OS: All Status: NEW Severity: minor Priority: P5 - low Component: Staff Client Assignee: koha-bugs at lists.koha-community.org Reporter: mishravk79 at gmail.com QA Contact: testopia at bugs.koha-community.org CC: gmcharlt at gmail.com Created attachment 63535 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=63535&action=edit Search result The search result in Staff client treat reference book as item unavailable so if there is a lost/damaged book than it counts both and shows total number of unavailable items. Suppose there is one damage and one reference book than total count of unavailable books is (2) screen shot available, even if there is single reference item it shows unavailable. Koha 16.11.07 on debian jessie 8 installed via package. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu May 18 19:11:37 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 18 May 2017 17:11:37 +0000 Subject: [Koha-bugs] [Bug 18629] New: Web installer 17.05 not properly translatable Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18629 Bug ID: 18629 Summary: Web installer 17.05 not properly translatable Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: major Priority: P5 - low Component: Installation and upgrade (web-based installer) Assignee: koha-bugs at lists.koha-community.org Reporter: veron at veron.ch QA Contact: testopia at bugs.koha-community.org CC: gmcharlt at gmail.com Web installer displays a mix between translated languages and English. That is ugly, because installing is the first contact with Koha. Tested with 17.05 de-DE and it-IT (both 100% translated) (Note: Results below are the similar for both it-IT and de-DE, same parts not translated) To test: Download po files from http://translate.koha-community.org/de/17.05/ or http://translate.koha-community.org/it/17.05/ Install the languages cd misc/translator perl translate -v install it-IT or perl translate -v install de-DE Drop database Create database Restart memcached and plack Go to staff client (calls web installer), enter database user and pw Select one of the languages de-DE or it-IT, Continue to the next step Result: ------------ Web installer ? Check Perl dependencies Alle erforderlichen Perl-Module sind installiert. Alle erforderlichen Abh?ngigkeiten sind installiert. Continue to the next step ------------ Continue... Result: ------------ Web installer ? Database settings Datenbankeinstellungen: Database type : mysql Database name : koha_kohadev Database host : localhost Database port : 3306 (probably okay if blank) Database user : koha_kohadev Continue to the next step ------------- Continue... Result: Similar as above Continue: Result: ------------- Web installer ? Set up database Jetzt sind wir soweit, dass die Datenbanktabellen angelegt und mit Beispieldaten gef?llt werden k?nnen. Continue to the next step ------------- Continue... (Result similar) Continue... (Result similar) Continue... Result (this time title translated, but not the text): ----------- MARC-Format ausw?hlen MARC stands for Machine Readable Cataloging. A MARC record contains bibliographic information about an item. MARC21 is used globally, whereas UNIMARC tends to be used in Europe. Marc21 Continue to the next step ------------ Continue... Result: ----------- Web installer ? Selecting default settings MARC-Frameworks: MARC21 Mandatory Select none (but toggles to 'Alle ausw?hlen' (...) Text at the end in English: 'When you've made aour selections.... Import Result: ------------ (...) Optional Daten hinzugef?gt (first word English) Mandatory Daten hinzugef?gt (same) At the end: Basic installation complete. In the next steps you will be guided through some basic requirements like defining Koha user with all administrative privileges (superlibrarian). Sie k?nnen die Koha Community unterst?tzen, indem Sie Ihre Nutzungsdaten teilen. If you wish to share some of your data, please enable the functionality in the "Share your usage statistics" section of the Administration module. Set up some of Koha's basic requirements ------------ Then: ------------ Web installer ? Installation complete Gratulation, die Installation ist abgeschlossen If this page does not redirect in 10 seconds, start onboarding process. ------------ Then in forms: Only field labels are translated, but not h3 tiltes and text For the first time, button is translated ('Best?tigen') Then: Web installer ? Create a new circulation rule Administrator account created! Form fields translated Then finally: ----------- Web installer ? Complete Ausleihregel erstellt! Congratulations you have finished and are ready to use Koha Koha nun benutzen ----------- More findings: - Some of the strings are not picked for translation (are not in the po files) - Some of the strings are in the po files, but seem not to be applied while installing -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Thu May 18 20:01:39 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 18 May 2017 18:01:39 +0000 Subject: [Koha-bugs] [Bug 18630] New: Translatability (Clubs): 'Cancel' is ambiguous and leads to mistakes Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18630 Bug ID: 18630 Summary: Translatability (Clubs): 'Cancel' is ambiguous and leads to mistakes Change sponsored?: --- Product: Koha Version: unspecified Hardware: All OS: All Status: NEW Severity: trivial Priority: P5 - low Component: Patrons Assignee: koha-bugs at lists.koha-community.org Reporter: veron at veron.ch QA Contact: testopia at bugs.koha-community.org CC: gmcharlt at gmail.com, kyle.m.hall at gmail.com The button to cancel a club enrollement is labelled with 'Cancel'. That is ambiguous and translates e.g. in German to 'Abbrechen' which can lead to mistakes. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Thu May 18 20:01:52 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 18 May 2017 18:01:52 +0000 Subject: [Koha-bugs] [Bug 18630] Translatability (Clubs): 'Cancel' is ambiguous and leads to mistakes In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18630 Marc V?ron changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|koha-bugs at lists.koha-commun |veron at veron.ch |ity.org | -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Thu May 18 20:07:51 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 18 May 2017 18:07:51 +0000 Subject: [Koha-bugs] [Bug 18630] Translatability (Clubs): 'Cancel' is ambiguous and leads to mistakes In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18630 --- Comment #1 from Marc V?ron --- Created attachment 63536 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=63536&action=edit Bug 18630: Translatability (Clubs): 'Cancel' is ambiguous and leads to mistakes The button to cancel a club enrollement is labelled with 'Cancel'. That is ambiguous and translates e.g. in German to 'Abbrechen' which can lead to mistakes. To test: - Apply patch - Enroll a patron to a club - Enable public enrollment in OPAC - Verify that the button to cancel enrollment in both OPAC and staff client reads 'Cancel enrollement' (instead of 'Cancel' without patch) (The button appears on the patron's detail pages in OPAC and staff client) -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu May 18 20:08:19 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 18 May 2017 18:08:19 +0000 Subject: [Koha-bugs] [Bug 18630] Translatability (Clubs): 'Cancel' is ambiguous and leads to mistakes In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18630 Marc V?ron changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff Patch complexity|--- |String patch -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu May 18 20:11:43 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 18 May 2017 18:11:43 +0000 Subject: [Koha-bugs] [Bug 10382] collection not returning to null when removed from course reserves In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10382 --- Comment #30 from Jonathan Druart --- I do not like the way this bug is fixed (especially the drop of the FK). I will not oppose to a push as I do not have anything else to suggest. I let the QA step to someone else. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu May 18 20:16:41 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 18 May 2017 18:16:41 +0000 Subject: [Koha-bugs] [Bug 14625] LDAP: mapped ExtendedPatronAttributes cause error when updated on authentication In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14625 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu May 18 20:16:47 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 18 May 2017 18:16:47 +0000 Subject: [Koha-bugs] [Bug 14625] LDAP: mapped ExtendedPatronAttributes cause error when updated on authentication In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14625 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #63410|0 |1 is obsolete| | --- Comment #15 from Jonathan Druart --- Created attachment 63537 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=63537&action=edit Bug 14625 - LDAP: skip extended patron attributes in 'borrowers' attribute update * Any extended patron attributes will cause the update to fail as those attributes don't exist in the 'borrowers' table * The update of the extended patron attributes is already dealt with in checkpw_ldap() * Ergo: just skip those attributes here Signed-off-by: Martin Renvoize Signed-off-by: Jonathan Druart I did not test this patch but code looks good -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu May 18 20:17:48 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 18 May 2017 18:17:48 +0000 Subject: [Koha-bugs] [Bug 18631] New: Cleanup_database.pl should take an option for modules in action_logs Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18631 Bug ID: 18631 Summary: Cleanup_database.pl should take an option for modules in action_logs Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Command-line Utilities Assignee: gmcharlt at gmail.com Reporter: nick at bywatersolutions.com QA Contact: testopia at bugs.koha-community.org CC: robin at catalyst.net.nz Cataloging log is a big one that often needs to be cleaned, other logs can be useful to keep longer, we should take the modules as an option and clear only those specified or exclude specified logs -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu May 18 20:18:01 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 18 May 2017 18:18:01 +0000 Subject: [Koha-bugs] [Bug 18631] Cleanup_database.pl should take an option for modules in action_logs In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18631 Nick Clemens changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |barton at bywatersolutions.com -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu May 18 20:18:10 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 18 May 2017 18:18:10 +0000 Subject: [Koha-bugs] [Bug 14625] LDAP: mapped ExtendedPatronAttributes cause error when updated on authentication In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14625 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|gmcharlt at gmail.com |oliver.bock at aei.mpg.de CC| |jonathan.druart at bugs.koha-c | |ommunity.org -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu May 18 20:27:31 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 18 May 2017 18:27:31 +0000 Subject: [Koha-bugs] [Bug 11122] Fix display of publication year/ copyrightdate and publishercode on various pages in acquisitions In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11122 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu May 18 20:27:38 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 18 May 2017 18:27:38 +0000 Subject: [Koha-bugs] [Bug 11122] Fix display of publication year/ copyrightdate and publishercode on various pages in acquisitions In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11122 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #63405|0 |1 is obsolete| | Attachment #63406|0 |1 is obsolete| | Attachment #63407|0 |1 is obsolete| | --- Comment #38 from Jonathan Druart --- Created attachment 63538 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=63538&action=edit Bug 11122 - publisher code and publication year not fetched in acq orders In acquisition, several templates try to display publisher code and publication year : invoice.tt, parcel.tt, transferorder.tt. Thoses pages use C4::Acquisition methods GetPendingOrders or GetInvoiceDetails. The bug is that in the SQL query of those methods, biblioitems.publishercode and biblioitems.publicationyear. In uncertainprice.pl those datas are fetch using GetBiblioData. It whould be better to fetch them in GetPendingOrders and GetInvoiceDetails. This patch changes SQL queries to fetch wanted datas : aqorders.*,biblio.title,biblio.author,biblioitems.isbn,biblioitems.publishercode,biblioitems.publicationyear. GetInvoiceDetails also needs : biblio.seriestitle,biblioitems.volume. This patch also unifies the way biblio datas are displayed : [title] by [author] – [isbn] Publisher: [publishercode], [publicationyear] Test plan : - Choose a biblio record containing a data in : biblio.title, biblio.author, biblioitems.isbn, biblioitems.publishercode, biblioitems.publicationyear, biblio.seriestitle, biblioitems.volume. - Create an order using this biblio. - Look at this order in pages : parcel.pl, transferorder.pl, uncertainprice.pl => You see publisher code and publication year - Look at this order in page : invoice.pl => You see publisher code, publication year, series title and volume Signed-off-by: Katrin Fischer Signed-off-by: Josef Moravec Signed-off-by: Jonathan Druart -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu May 18 20:36:52 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 18 May 2017 18:36:52 +0000 Subject: [Koha-bugs] [Bug 11122] Fix display of publication year/ copyrightdate and publishercode on various pages in acquisitions In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11122 --- Comment #39 from Jonathan Druart --- Created attachment 63539 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=63539&action=edit Bug 11122: Address MARC21 vs. UNIMARC issue In comment #6 and comment #17, Katrin pointed out the discrepancy between UNIMARC (using publisheryear) vs. Other MARC installations (using copyrightdate). This was dealt with in invoice.tt already. This patch does similar logic for the other 3 template files. Signed-off-by: Katrin Fischer Signed-off-by: Josef Moravec Signed-off-by: Jonathan Druart -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu May 18 20:36:58 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 18 May 2017 18:36:58 +0000 Subject: [Koha-bugs] [Bug 11122] Fix display of publication year/ copyrightdate and publishercode on various pages in acquisitions In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11122 --- Comment #40 from Jonathan Druart --- Created attachment 63540 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=63540&action=edit Bug 11122: Follow up - Fix some display issues and typos This patch fixes the display of copyrightdate for MARC21 installations. As MARC21 already requires you to add punctuation in cataloguing, there is usually no need for punctutation in the templates. Also fixes a template variable name typo and the basket summary page. To test (all 3 patches): - Add several order lines to an order, one should be uncertain - Verify that the publisher and publication year are displayed - Check the uncertain price page - Verify that the publisher code and publication year are displayed - Fix uncertain price and close your order - Basket summary: Verify... (you know what) - Cancel one of your orders - Verify... for cancelled orders - Receive shipment - Verify... for unreceived orders - Receive order - Verify ... for received orders - Finish receiving - Verify ... on the invoice summary page Signed-off-by: Josef Moravec Signed-off-by: Jonathan Druart -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu May 18 20:44:14 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 18 May 2017 18:44:14 +0000 Subject: [Koha-bugs] [Bug 18578] Use subdirectory in / tmp for session storage during installation In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18578 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu May 18 20:44:18 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 18 May 2017 18:44:18 +0000 Subject: [Koha-bugs] [Bug 18578] Use subdirectory in / tmp for session storage during installation In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18578 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #63423|0 |1 is obsolete| | --- Comment #4 from Jonathan Druart --- Created attachment 63541 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=63541&action=edit Bug 18578: Use subdirectory in /tmp for session storage during installation Apply the change from bug 15553 to InstallAuth.pm too. Test plan: [1] Remove all cgisess_* files from your /tmp directory. [2] Remove directory /tmp/cgisess_koha_[your instance], if there. [3] Run the webinstaller /cgi-bin/koha/installer/install.pl?step=1&op=updatestructure [4] Check if you have cgisess_ files in /tmp/cgisess_koha_[your instance]. Signed-off-by: Marcel de Rooy Signed-off-by: Josef Moravec Signed-off-by: Jonathan Druart -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu May 18 20:49:02 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 18 May 2017 18:49:02 +0000 Subject: [Koha-bugs] [Bug 18632] New: CGI::param called in list context flooding erro logs Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18632 Bug ID: 18632 Summary: CGI::param called in list context flooding erro logs Change sponsored?: --- Product: Koha Version: 16.11 Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: About Assignee: nengard at gmail.com Reporter: eric.vantillard at evaxion.fr QA Contact: testopia at bugs.koha-community.org see https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16154 Here are the error logs (I have removed duplicated errors) authorised_values.pl: CGI::param called in list context from package main line 195, this can lead to vulnerabilities. See the warning in "Fetching the value or values of a single named parameter" at /usr/share/perl5/CGI.pm line 436., referer: http://xxx/cgi-bin/koha/admin/authorised_values.pl classsources.pl: CGI::param called in list context from package main line 68, this can lead to vulnerabilities. See the warning in "Fetching the value or values of a single named parameter" at /usr/share/perl5/CGI.pm line 436., referer: http://xxx/cgi-bin/koha/admin/classsources.pl?op=edit_source&class_source=ddc import_export_framework.pl: CGI::param called in list context from package main line 87, this can lead to vulnerabilities. See the warning in "Fetching the value or values of a single named parameter" at /usr/share/perl5/CGI.pm line 436., referer: http://xxx/cgi-bin/koha/admin/biblio_framework.pl install.pl: CGI::param called in list context from package main line 207, this can lead to vulnerabilities. See the warning in "Fetching the value or values of a single named parameter" at /usr/share/perl5/CGI.pm line 436., referer: http://xxx/cgi-bin/koha/installer/install.pl itemsearch.pl: CGI::param called in list context from package Template::Document line 118, this can lead to vulnerabilities. See the warning in "Fetching the value or values of a single named parameter" at /usr/share/perl5/CGI.pm line 436., referer: http://xxx/cgi-bin/koha/about.pl itemsearch.pl: CGI::param called in list context from package Template::Document line 370, this can lead to vulnerabilities. See the warning in "Fetching the value or values of a single named parameter" at /usr/share/perl5/CGI.pm line 436., referer: http://xxx/cgi-bin/koha/about.pl itemsearch.pl: CGI::param called in list context from package Template::Document line 375, this can lead to vulnerabilities. See the warning in "Fetching the value or values of a single named parameter" at /usr/share/perl5/CGI.pm line 436., referer: http://xxx/cgi-bin/koha/about.pl itemsearch.pl: CGI::param called in list context from package Template::Document line 41, this can lead to vulnerabilities. See the warning in "Fetching the value or values of a single named parameter" at /usr/share/perl5/CGI.pm line 436., referer: http://xxx/cgi-bin/koha/about.pl itemsearch.pl: CGI::param called in list context from package Template::Document line 43, this can lead to vulnerabilities. See the warning in "Fetching the value or values of a single named parameter" at /usr/share/perl5/CGI.pm line 436., referer: http://xxx/cgi-bin/koha/about.pl -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu May 18 20:49:12 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 18 May 2017 18:49:12 +0000 Subject: [Koha-bugs] [Bug 18596] Quick add form duplicating password confirm In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18596 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Failed QA CC| |jonathan.druart at bugs.koha-c | |ommunity.org --- Comment #5 from Jonathan Druart --- My brain scratched just after the first line: var passwd_mandatory = [% IF mandatorypassword %]0[% ELSE %]1[% END %]; I'd suggest to not use a JS var and simply: [% UNLESS mandatorypassword %] if( input_label == 'password' ) $("#entryform label[for='password2']").parent().clone().appendTo("#quick_add_list"); [% END %] -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu May 18 20:57:16 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 18 May 2017 18:57:16 +0000 Subject: [Koha-bugs] [Bug 18627] Items created via MarcItemFieldsToOrder are not linked to orders In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18627 Kyle M Hall changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #63534|0 |1 is obsolete| | --- Comment #2 from Kyle M Hall --- Created attachment 63542 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=63542&action=edit Bug 18627 - Items created via MarcItemFieldsToOrder are not linked to orders If using MarcItemFieldsToOrder with AcqCreateItem = Create, the order and the items will be created, but they will not be linked via aqorders_items! Test Plan: 1) Enable creation of items when ordering 2) Set up MarcItemFieldsToOrder 3) Upload an order record that uses the fields in step 2 4) Create a basket and add the records from the file 5) Note the order and items are created, but no rows in aqorders_items are created 6) Apply this patch 7) Repeat steps 3-4 8) Note the rows in aqorders_items are created! Signed-off-by: Kyle M Hall Signed-off-by: Marci Chen -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu May 18 20:57:05 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 18 May 2017 18:57:05 +0000 Subject: [Koha-bugs] [Bug 18627] Items created via MarcItemFieldsToOrder are not linked to orders In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18627 Kyle M Hall changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu May 18 21:04:56 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 18 May 2017 19:04:56 +0000 Subject: [Koha-bugs] [Bug 18450] Renew in header bypasses hold block and renewal limits In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18450 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Failed QA --- Comment #14 from Jonathan Druart --- Nope, the last patch does: IF A AND B: Do the stuffs ELSIF ( NOT A AND B ) OR ( A AND NOT B ): Do the same stuffs Alex, could you submit another patch replacing this one, update the commit message with a shorter first line (ideally should be < 80chars), remove the signed-off by line and switch the status to "Needs Signoff" please? -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu May 18 21:09:05 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 18 May 2017 19:09:05 +0000 Subject: [Koha-bugs] [Bug 18434] Elasticsearch indexing broken with newer catmandu version In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18434 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Failed QA --- Comment #14 from Jonathan Druart --- 2 Tests fail for me: t/db_dependent/Koha_Elasticsearch_Indexer.t .. 1/6 # Failed test 'First mapped author should be 100a' # at t/db_dependent/Koha_Elasticsearch_Indexer.t line 120. # got: 'ARRAY(0x67369d8)' # expected: 'Author' # Failed test 'Second mapped author should be 110a' # at t/db_dependent/Koha_Elasticsearch_Indexer.t line 121. # got: 'ARRAY(0x66f79c0)' # expected: 'Corp Author' # Looks like you failed 2 tests of 2. # Failed test '_convert_marc_to_json() tests' # at t/db_dependent/Koha_Elasticsearch_Indexer.t line 124. # Looks like you failed 1 test of 6. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu May 18 21:15:19 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 18 May 2017 19:15:19 +0000 Subject: [Koha-bugs] [Bug 17456] Cataloging plugins: change of behaviour at fileds driven by plugins In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17456 Marjorie Barry-Vila changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |marjorie.barry-vila at ccsr.qc | |.ca -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu May 18 21:29:47 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 18 May 2017 19:29:47 +0000 Subject: [Koha-bugs] [Bug 18597] Quick add form does not transfer patron attributes values when switching forms /saving In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18597 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |jonathan.druart at bugs.koha-c | |ommunity.org --- Comment #4 from Jonathan Druart --- I do not manage to see the patron attributes on the quick add form. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu May 18 21:33:03 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 18 May 2017 19:33:03 +0000 Subject: [Koha-bugs] [Bug 18597] Quick add form does not transfer patron attributes values when switching forms /saving In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18597 --- Comment #5 from Jonathan Druart --- (In reply to Jonathan Druart from comment #4) > I do not manage to see the patron attributes on the quick add form. Ha, we have to guess the id of the attribute in DB. That's very badly implemented. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu May 18 21:33:56 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 18 May 2017 19:33:56 +0000 Subject: [Koha-bugs] [Bug 18597] Quick add form does not transfer patron attributes values when switching forms /saving In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18597 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu May 18 21:34:03 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 18 May 2017 19:34:03 +0000 Subject: [Koha-bugs] [Bug 18597] Quick add form does not transfer patron attributes values when switching forms /saving In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18597 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #63448|0 |1 is obsolete| | --- Comment #6 from Jonathan Druart --- Created attachment 63543 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=63543&action=edit Bug 18597 - Quick add form does not transfer patron attributes values when switching forms/saving The function that switches between quick add/fulll form assumes labels are followed by values - patron_attr don't follow this pattern. This patch just moves the hidden input field To test: 1 - Have some patron attributes (with/without auth values set) 2 - Add them to QuickAddFields (patron_attr2 for example) 3 - view quick add form and set some values 4 - Switch to full form, values not transferred 5 - Switch to quick add, view values, save 6 - Values are not saved :-( 7 - Apply patch 8 - Repeat 3 - 5 9 - Values are transferred and saved :-) Signed-off-by: Peggy Thrasher Signed-off-by: Jonathan Druart -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu May 18 21:45:12 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 18 May 2017 19:45:12 +0000 Subject: [Koha-bugs] [Bug 18376] authority framework creation fails under Plack In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18376 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu May 18 21:45:18 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 18 May 2017 19:45:18 +0000 Subject: [Koha-bugs] [Bug 18376] authority framework creation fails under Plack In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18376 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #63401|0 |1 is obsolete| | --- Comment #6 from Jonathan Druart --- Created attachment 63544 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=63544&action=edit Bug 18376 - authority framework creation fails under Plack With plack, when creating a new authority framework from another, you get the error : Can't call method "prepare" on an undefined value at (...)/src/admin/auth_tag_structure.pl line 267. Looks like plack does not like when the var $dbh from the script is called inside a sub. This patch adds a local var $dbh inside sub duplicate_auth_framework(), like in sub StringSearch(). Also correctes a redefine of my $sth. Test plan: - Go to Administration > Authority types - Create a new type - On this new type click on Actions > MARC Structure - Select another type and click OK => You must get a table filled with the tag structure Check with and without plack You may not be able to reproduce the error with plack. Signed-off-by: Katrin Fischer Signed-off-by: Jonathan Druart -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu May 18 21:45:23 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 18 May 2017 19:45:23 +0000 Subject: [Koha-bugs] [Bug 18376] authority framework creation fails under Plack In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18376 --- Comment #7 from Jonathan Druart --- Created attachment 63545 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=63545&action=edit Bug 18376: Do not need to prepare a single statement, use do Signed-off-by: Jonathan Druart -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu May 18 21:46:08 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 18 May 2017 19:46:08 +0000 Subject: [Koha-bugs] [Bug 18376] authority framework creation fails under Plack In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18376 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |jonathan.druart at bugs.koha-c | |ommunity.org --- Comment #8 from Jonathan Druart --- (In reply to Katrin Fischer from comment #3) > I can see the error, trying to sign off. Same, confirmed! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu May 18 21:46:35 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 18 May 2017 19:46:35 +0000 Subject: [Koha-bugs] [Bug 18376] authority framework creation fails under Plack In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18376 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Severity|normal |major --- Comment #9 from Jonathan Druart --- Upping the severity a bit as Plack is considered stable. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu May 18 21:51:18 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 18 May 2017 19:51:18 +0000 Subject: [Koha-bugs] [Bug 18551] Hide with CSS dynamic elements in member search In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18551 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #63491|0 |1 is obsolete| | Attachment #63492|0 |1 is obsolete| | --- Comment #18 from Jonathan Druart --- Created attachment 63546 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=63546&action=edit Bug 18551 - Hide with CSS dynamic elements in member search In member search page, the result table is in Ajax so fully managed by Javascript. There is also a yellow dialog message prepared in HTML. Thoses elements are hidden by JS code : ie $("#patron_list_dialog").hide(). The problem is that the static page is first loaded an displayed then the JS code runs an hides the elements. On a low performance computer, this action is visible and looks like there is a blinking yellow message. I propose to hide with CSS so that thoses elements are not displayed in static page and are there shown in dynamic JS code. Test plan : Check display is unchanged : - Go to home page /cgi-bin/koha/members/members-home.pl - Perform patron search from header search box - Perform patron search by clicking on a letter - Perform patron search from filters (left of results table) - Select a patron and add it to a list => you see the yellow message Yellow message does no longer appear with this patch. Signed-off-by: Marc V?ron Signed-off-by: Philippe Signed-off-by: Jonathan Druart -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu May 18 21:51:23 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 18 May 2017 19:51:23 +0000 Subject: [Koha-bugs] [Bug 18551] Hide with CSS dynamic elements in member search In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18551 --- Comment #19 from Jonathan Druart --- Created attachment 63547 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=63547&action=edit Bug 18551: followup - hide advanced filters in header, move hidding to css file Test plan: The same as first patch, but also with advanced search form in header hidden on page load - see comment 4 Issue with advanced search form is gone. Signed-off-by: Marc V?ron Signed-off-by: Philippe Signed-off-by: Jonathan Druart -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu May 18 21:51:11 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 18 May 2017 19:51:11 +0000 Subject: [Koha-bugs] [Bug 18551] Hide with CSS dynamic elements in member search In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18551 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu May 18 21:52:50 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 18 May 2017 19:52:50 +0000 Subject: [Koha-bugs] [Bug 16154] Replace CGI->param with CGI->multi_param in list context In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16154 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |18632 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18632 [Bug 18632] CGI::param called in list context flooding erro logs -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu May 18 21:52:50 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 18 May 2017 19:52:50 +0000 Subject: [Koha-bugs] [Bug 18632] CGI::param called in list context flooding erro logs In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18632 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on| |16154 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16154 [Bug 16154] Replace CGI->param with CGI->multi_param in list context -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu May 18 21:53:44 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 18 May 2017 19:53:44 +0000 Subject: [Koha-bugs] [Bug 16154] Replace CGI->param with CGI->multi_param in list context In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16154 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Component|Acquisitions |Architecture, internals, | |and plumbing -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu May 18 21:54:05 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 18 May 2017 19:54:05 +0000 Subject: [Koha-bugs] [Bug 18632] CGI::param called in list context flooding erro logs In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18632 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Severity|enhancement |normal Status|NEW |ASSIGNED Assignee|nengard at gmail.com |gmcharlt at gmail.com Component|About |Architecture, internals, | |and plumbing CC| |jonathan.druart at bugs.koha-c | |ommunity.org Version|16.11 |master -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu May 18 22:07:39 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 18 May 2017 20:07:39 +0000 Subject: [Koha-bugs] [Bug 11425] Search form for items In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11425 --- Comment #71 from Jonathan Druart --- The use of the CGI TT plugin floods logs with: itemsearch.pl: CGI::param called in list context from package Template::Document line 118, this can lead to vulnerabilities. See the warning in "Fetching the value or values of a single named parameter" at /usr/share/perl5/CGI.pm line 436., referer: http://xxx/cgi-bin/koha/about.pl Julian, can you check how we can fix that? -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu May 18 22:09:30 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 18 May 2017 20:09:30 +0000 Subject: [Koha-bugs] [Bug 18633] New: Logs are full of CGI:: param called in list context - itemsearch.pl Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18633 Bug ID: 18633 Summary: Logs are full of CGI::param called in list context - itemsearch.pl Change sponsored?: --- Product: Koha Version: unspecified Hardware: All OS: All Status: ASSIGNED Severity: normal Priority: P5 - low Component: Architecture, internals, and plumbing Assignee: julian.maurice at biblibre.com Reporter: jonathan.druart at bugs.koha-community.org QA Contact: testopia at bugs.koha-community.org The use of the CGI TT plugin in catalogue/itemsearch.tt floods logs with: itemsearch.pl: CGI::param called in list context from package Template::Document line 118, this can lead to vulnerabilities. See the warning in "Fetching the value or values of a single named parameter" at /usr/share/perl5/CGI.pm line 436., referer: http://xxx/cgi-bin/koha/about.pl -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu May 18 22:09:54 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 18 May 2017 20:09:54 +0000 Subject: [Koha-bugs] [Bug 11425] Search form for items In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11425 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |18633 --- Comment #72 from Jonathan Druart --- See bug 18633 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18633 [Bug 18633] Logs are full of CGI::param called in list context - itemsearch.pl -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu May 18 22:09:54 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 18 May 2017 20:09:54 +0000 Subject: [Koha-bugs] [Bug 18633] Logs are full of CGI:: param called in list context - itemsearch.pl In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18633 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on| |11425 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11425 [Bug 11425] Search form for items -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu May 18 22:10:00 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 18 May 2017 20:10:00 +0000 Subject: [Koha-bugs] [Bug 18633] Logs are full of CGI:: param called in list context - itemsearch.pl In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18633 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |https://bugs.koha-community | |.org/bugzilla3/show_bug.cgi | |?id=18632 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu May 18 22:10:00 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 18 May 2017 20:10:00 +0000 Subject: [Koha-bugs] [Bug 18632] CGI::param called in list context flooding erro logs In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18632 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |https://bugs.koha-community | |.org/bugzilla3/show_bug.cgi | |?id=18633 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu May 18 22:10:33 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 18 May 2017 20:10:33 +0000 Subject: [Koha-bugs] [Bug 16154] Replace CGI->param with CGI->multi_param in list context In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16154 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |18633 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18633 [Bug 18633] Logs are full of CGI::param called in list context - itemsearch.pl -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu May 18 22:10:51 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 18 May 2017 20:10:51 +0000 Subject: [Koha-bugs] [Bug 18632] CGI::param called in list context flooding erro logs In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18632 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|gmcharlt at gmail.com |jonathan.druart at bugs.koha-c | |ommunity.org -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu May 18 22:10:33 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 18 May 2017 20:10:33 +0000 Subject: [Koha-bugs] [Bug 18633] Logs are full of CGI:: param called in list context - itemsearch.pl In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18633 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on| |16154 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16154 [Bug 16154] Replace CGI->param with CGI->multi_param in list context -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu May 18 22:18:18 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 18 May 2017 20:18:18 +0000 Subject: [Koha-bugs] [Bug 17456] Cataloging plugins: change of behaviour at fileds driven by plugins In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17456 --- Comment #5 from Mike --- OK, we can close it. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu May 18 22:45:39 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 18 May 2017 20:45:39 +0000 Subject: [Koha-bugs] [Bug 18632] CGI::param called in list context flooding erro logs In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18632 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu May 18 22:45:43 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 18 May 2017 20:45:43 +0000 Subject: [Koha-bugs] [Bug 18632] CGI::param called in list context flooding erro logs In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18632 --- Comment #1 from Jonathan Druart --- Created attachment 63548 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=63548&action=edit Bug 18632: Remove 'CGI::param called in list context' warnings Once again, after bug 16154 and bug 16259 we need to remove more occurrence of CGi->param called in list context. Refer to bug 15809 for more information. Test plan: Make sure you do not see the error on the modified scripts. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu May 18 22:54:16 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 18 May 2017 20:54:16 +0000 Subject: [Koha-bugs] [Bug 18438] Check in: Modal about holds hides important check in messages In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18438 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu May 18 22:54:26 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 18 May 2017 20:54:26 +0000 Subject: [Koha-bugs] [Bug 18438] Check in: Modal about holds hides important check in messages In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18438 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #63458|0 |1 is obsolete| | --- Comment #28 from Jonathan Druart --- Created attachment 63549 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=63549&action=edit Bug 18438 - Implemented data-dismiss="modal" in returns.tt so that any warning messages hidden by a hold modal are displayed after it is dismissed Test plan: 1. Check out an item to one patron whilst having that item also being on hold to another patron 2. Check the item back in 3. Notice a modal box appears greying out the background with three buttons 'Confirm hold', 'Print and confirm' and 'Ignore'. Click confirm and notice that the page refreshes and no yellow warning messages are able to be displayed 4. Now that you have checked the item in. Try checking it in a second time by clicking on the Checkin tab and writing in the barcode. 5. The modal box will appear again, this time with three buttons 'Confirm', 'Print and confirm' and 'Cancel hold' 6. Click the 'Confirm' button and the page refreshes again and the yellow warning message hidden by the modal box is not properly displayed to the user. Notice that the focus is on the barcode input box. 7. Apply patch 8. Try checking in the item again, and this time after clicking the 'confirm' button on the modal box notice that the yellow warning message is displayed telling the user the item was "Not checked out". Also notice the focus is in the barcode inputbox. 9. Drop the hold on the item and make sure it is not checked out. 10. Repeat steps 1 and 2 and notice after clicking the 'Confirm hold' button the page refreshes and the item is successfully checked back in. With the focus on the barcode input. 11. View koha-tmpl/intranet-tmpl/prog/en/modules/circ/returns.tt and notice that the button on line 345 does not use an onclick parameter Followed test plan, works as expected. Signed-off-by: Marc V?ron Signed-off-by: Jonathan Druart Amended-patch: remove spaces -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu May 18 23:04:51 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 18 May 2017 21:04:51 +0000 Subject: [Koha-bugs] [Bug 18634] New: Missing empty line at end of opac.pref Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18634 Bug ID: 18634 Summary: Missing empty line at end of opac.pref Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: normal Priority: P5 - low Component: OPAC Assignee: oleonard at myacpl.org Reporter: philippe.blouin at inlibro.com QA Contact: testopia at bugs.koha-community.org The subject line says it all. When this line is missing, all Payment(PayPal) sysprefs don't show up in translated pages. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu May 18 23:05:53 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 18 May 2017 21:05:53 +0000 Subject: [Koha-bugs] [Bug 18634] Missing empty line at end of opac.pref In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18634 --- Comment #1 from Blou --- Created attachment 63550 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=63550&action=edit Bug 18634 - Missing empty line at end of opac.pref -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu May 18 23:07:57 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 18 May 2017 21:07:57 +0000 Subject: [Koha-bugs] [Bug 18634] Missing empty line at end of opac.pref In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18634 Blou changed: What |Removed |Added ---------------------------------------------------------------------------- Change sponsored?|--- |Sponsored CC| |philippe.blouin at inlibro.com Patch complexity|--- |String patch Status|NEW |Needs Signoff Assignee|oleonard at myacpl.org |philippe.blouin at inlibro.com --- Comment #2 from Blou --- It's a shame to have a commit line just for that, but really, that's the reason this is not translatable. Or rather, it translates but don't show up. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu May 18 23:09:30 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 18 May 2017 21:09:30 +0000 Subject: [Koha-bugs] [Bug 18634] Missing empty line at end of opac.pref In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18634 --- Comment #3 from Blou --- Sponsored by : CCSR -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri May 19 01:13:13 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 18 May 2017 23:13:13 +0000 Subject: [Koha-bugs] [Bug 18552] Borrower debarments do not show on member detail page. In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18552 Aleisha Amohia changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff Patch complexity|--- |Small patch -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri May 19 01:13:17 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 18 May 2017 23:13:17 +0000 Subject: [Koha-bugs] [Bug 18552] Borrower debarments do not show on member detail page. In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18552 --- Comment #1 from Aleisha Amohia --- Created attachment 63551 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=63551&action=edit Bug 18552: Borrower debarments not showing on member detail page To test: 1) Go to a borrowers details page and create a manual restriction 2) Notice the restriction shows at the top of the page but the restriction tab says the member is currently unrestricted 3) Apply patch and refresh page 4) Restrictions tab should now correctly show debarments and correct number is shown 5) Confirming deleting and adding restrictions still works as expected Sponsored-by: Catalyst IT -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Fri May 19 01:13:33 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 18 May 2017 23:13:33 +0000 Subject: [Koha-bugs] [Bug 18552] Borrower debarments do not show on member detail page. In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18552 Aleisha Amohia changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|koha-bugs at lists.koha-commun |aleisha at catalyst.net.nz |ity.org | Change sponsored?|--- |Sponsored CC| |aleisha at catalyst.net.nz -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri May 19 03:06:51 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 19 May 2017 01:06:51 +0000 Subject: [Koha-bugs] [Bug 18635] New: Koha::Patron->guarantees() should return results alphabetically Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18635 Bug ID: 18635 Summary: Koha::Patron->guarantees() should return results alphabetically Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Patrons Assignee: koha-bugs at lists.koha-community.org Reporter: nick at bywatersolutions.com QA Contact: testopia at bugs.koha-community.org CC: gmcharlt at gmail.com, kyle.m.hall at gmail.com Currently there is no sort here so patrons are returned in db order (unordered) We should return them alphabetically for display and other purposes -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Fri May 19 03:10:28 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 19 May 2017 01:10:28 +0000 Subject: [Koha-bugs] [Bug 18635] Koha::Patron->guarantees() should return results alphabetically In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18635 Nick Clemens changed: What |Removed |Added ---------------------------------------------------------------------------- Patch complexity|--- |Trivial patch Status|NEW |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Fri May 19 03:10:33 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 19 May 2017 01:10:33 +0000 Subject: [Koha-bugs] [Bug 18635] Koha::Patron->guarantees() should return results alphabetically In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18635 --- Comment #2 from Nick Clemens --- Created attachment 63553 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=63553&action=edit Bug 18635 - Koha::Patron->guarantees() should return results alphabetically To test: 1 - Add the same guarantor to a number of patrons, ensuring random order alphabetically 2 - View the guarantors record, note unordered list of guarantees 3 - Apply patch 4 - Guarantees are alphabetical -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Fri May 19 03:10:30 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 19 May 2017 01:10:30 +0000 Subject: [Koha-bugs] [Bug 18635] Koha::Patron->guarantees() should return results alphabetically In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18635 --- Comment #1 from Nick Clemens --- Created attachment 63552 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=63552&action=edit Bug 18635 - Unit tests To test: 1 - Apply this patch only 2 - Prove t/db_dependent/Patron.t 3 - Tests fail 4 - Apply other patch 5 - Tests pass -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Fri May 19 03:10:47 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 19 May 2017 01:10:47 +0000 Subject: [Koha-bugs] [Bug 18635] Koha::Patron->guarantees() should return results alphabetically In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18635 Nick Clemens changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|koha-bugs at lists.koha-commun |nick at bywatersolutions.com |ity.org | -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Fri May 19 04:01:35 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 19 May 2017 02:01:35 +0000 Subject: [Koha-bugs] [Bug 18598] Quick add form doesn't clear values when switching In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18598 Nick Clemens changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri May 19 04:01:38 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 19 May 2017 02:01:38 +0000 Subject: [Koha-bugs] [Bug 18598] Quick add form doesn't clear values when switching In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18598 Nick Clemens changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #63445|0 |1 is obsolete| | --- Comment #3 from Nick Clemens --- Created attachment 63554 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=63554&action=edit Bug 18598 - Quick add form doesn't clear values when switching To test: 1 - Fill out some fields in quick add 2 - Switch to full form and clear fields 3 - Switch back and fields are still populated 4 - Fill a field in long form 5 - Switch to quick add and clear it 6 - Save 7 - Value set in 4 is saved 8 - Apply patch 9 - Repeat 1-6 - values should be cleared and not saved -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri May 19 04:02:28 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 19 May 2017 02:02:28 +0000 Subject: [Koha-bugs] [Bug 18598] Quick add form doesn't clear values when switching In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18598 --- Comment #4 from Nick Clemens --- Yeah, I removed one too many lines in that first patch ( meant to remove the if condtiion, removed the whole block ) -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri May 19 04:25:28 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 19 May 2017 02:25:28 +0000 Subject: [Koha-bugs] [Bug 18596] Quick add form duplicating password confirm In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18596 Nick Clemens changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |Signed Off -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri May 19 04:25:31 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 19 May 2017 02:25:31 +0000 Subject: [Koha-bugs] [Bug 18596] Quick add form duplicating password confirm In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18596 --- Comment #6 from Nick Clemens --- Created attachment 63555 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=63555&action=edit Bug 18596 (QA Followup) Use TT in a less awkward way -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri May 19 05:00:16 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 19 May 2017 03:00:16 +0000 Subject: [Koha-bugs] [Bug 18231] Add the missing id-column to koha.issuingrules-table for DBIC fixtures In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18231 --- Comment #18 from M. Tompsett --- Comment on attachment 61219 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=61219 Bug 18231: Make sure we will not add the column twice Review of attachment 61219: --> (https://bugs.koha-community.org/bugzilla3/page.cgi?id=splinter.html&bug=18231&attachment=61219) ----------------------------------------------------------------- I was just expecting the .perl and removal of the .sql when I went to eyeball this. ::: Koha/Schema/Result/BorrowerAttributeType.pm @@ +154,5 @@ > ); > > > +# Created by DBIx::Class::Schema::Loader v0.07042 @ 2017-03-17 11:43:14 > +# DO NOT MODIFY THIS OR ANYTHING ABOVE! md5sum:0jCQN4xSJYbQC5e7fGn5WQ Why add this? ::: Koha/Schema/Result/Issue.pm @@ +222,5 @@ > ); > > > +# Created by DBIx::Class::Schema::Loader v0.07042 @ 2017-03-17 11:43:14 > +# DO NOT MODIFY THIS OR ANYTHING ABOVE! md5sum:zGLKwoUmq4pcvY16ei3VPg Why add this? ::: Koha/Schema/Result/Issuingrule.pm @@ +330,5 @@ > ); > > > +# Created by DBIx::Class::Schema::Loader v0.07042 @ 2017-03-17 11:43:14 > +# DO NOT MODIFY THIS OR ANYTHING ABOVE! md5sum:3K9yYzzg9IYRAuxSXd7CPg Why add this? ::: Koha/Schema/Result/OldIssue.pm @@ +207,5 @@ > ); > > > +# Created by DBIx::Class::Schema::Loader v0.07042 @ 2017-03-17 11:43:14 > +# DO NOT MODIFY THIS OR ANYTHING ABOVE! md5sum:yTyCAau9EZHBgdqN4Ptljg Why add this? ::: Koha/Schema/Result/SearchField.pm @@ +48,4 @@ > =head2 type > > data_type: 'enum' > + extra: {list => ["","string","date","number","boolean","sum"]} Is this from another bug? @@ +65,4 @@ > "type", > { > data_type => "enum", > + extra => { list => ["", "string", "date", "number", "boolean", "sum"] }, Is this from another bug? I think it may be valid, but I don't think this bug originally added it. ::: installer/data/mysql/atomicupdate/Bug-18231-id_to_ussingrules_table.perl @@ +1,3 @@ > +$DBversion = 'XXX'; # will be replaced by the RM > +if( CheckVersion( $DBversion ) ) { > + unless ( column_exists( 'issuingrules', 'issuingrules_id' ) ) { This column_exists() has been a fantastic add, since it was put in. :) -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri May 19 07:04:49 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 19 May 2017 05:04:49 +0000 Subject: [Koha-bugs] [Bug 18636] New: Can not save new patron on fresh install ( Conflict between autoMemberNum and BorrowerMandatoryField) Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18636 Bug ID: 18636 Summary: Can not save new patron on fresh install (Conflict between autoMemberNum and BorrowerMandatoryField) Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: normal Priority: P5 - low Component: Patrons Assignee: koha-bugs at lists.koha-community.org Reporter: veron at veron.ch QA Contact: testopia at bugs.koha-community.org CC: gmcharlt at gmail.com, kyle.m.hall at gmail.com Tested on a fresh install on current master To reproduce: - Go to Koha > Patrons > Add patron (full form) - Verify that label for card number reads: "Card number(leave blank for auto calc during registration):" - Do not enter anything in field card number - Enter surname, try to save - Form does not save because field card number is required Reason: - autoMemberNum is on by default (sysprefs.sql line 65) - BorrowerMandatoryField contains surname|cardnumber by default (sysprefs.sql line 86) - Full form does not save because card number is mandatory and empty Note: With quick add form and settings above, cardnumber is not displayed, form saves properly. What to do? - Better explanation for autoMemberNum and BorrowerMandatoryField - Set defaults for autoMemberNum and BorrowerMandatoryField in a way that they do not conflict? - Ignore cardnumber being a mandatory field if autoMemberNum is on? - Ask for settings in onboarding tool? -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Fri May 19 07:08:16 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 19 May 2017 05:08:16 +0000 Subject: [Koha-bugs] [Bug 18598] Quick add form doesn't clear values when switching In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18598 Marc V?ron changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri May 19 07:07:59 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 19 May 2017 05:07:59 +0000 Subject: [Koha-bugs] [Bug 18598] Quick add form doesn't clear values when switching In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18598 Marc V?ron changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #63554|0 |1 is obsolete| | --- Comment #5 from Marc V?ron --- Created attachment 63556 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=63556&action=edit Bug 18598 - Quick add form doesn't clear values when switching To test: 1 - Fill out some fields in quick add 2 - Switch to full form and clear fields 3 - Switch back and fields are still populated 4 - Fill a field in long form 5 - Switch to quick add and clear it 6 - Save 7 - Value set in 4 is saved 8 - Apply patch 9 - Repeat 1-6 - values should be cleared and not saved Signed-off-by: Marc V?ron -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri May 19 07:14:13 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 19 May 2017 05:14:13 +0000 Subject: [Koha-bugs] [Bug 18552] Borrower debarments do not show on member detail page. In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18552 Marc V?ron changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #63551|0 |1 is obsolete| | --- Comment #2 from Marc V?ron --- Created attachment 63557 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=63557&action=edit Bug 18552: Borrower debarments not showing on member detail page To test: 1) Go to a borrowers details page and create a manual restriction 2) Notice the restriction shows at the top of the page but the restriction tab says the member is currently unrestricted 3) Apply patch and refresh page 4) Restrictions tab should now correctly show debarments and correct number is shown 5) Confirming deleting and adding restrictions still works as expected Sponsored-by: Catalyst IT Followed test plan, works as expected Signed-off-by: Marc V?ron -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri May 19 07:14:30 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 19 May 2017 05:14:30 +0000 Subject: [Koha-bugs] [Bug 18552] Borrower debarments do not show on member detail page. In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18552 Marc V?ron changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |veron at veron.ch Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri May 19 07:26:45 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 19 May 2017 05:26:45 +0000 Subject: [Koha-bugs] [Bug 18634] Missing empty line at end of opac.pref In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18634 Marc V?ron changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |veron at veron.ch --- Comment #4 from Marc V?ron --- I could not reproduce on current master with de-DE and it-IT However an empty line 826 seems to be superfluous. Other *.pref-files do not have an empty line at the end. So I think it is better to just remove line 826. What do you think about? -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri May 19 07:30:43 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 19 May 2017 05:30:43 +0000 Subject: [Koha-bugs] [Bug 18635] Koha::Patron->guarantees() should return results alphabetically In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18635 Marc V?ron changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #63552|0 |1 is obsolete| | --- Comment #3 from Marc V?ron --- Created attachment 63558 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=63558&action=edit Bug 18635 - Unit tests To test: 1 - Apply this patch only 2 - Prove t/db_dependent/Patron.t 3 - Tests fail 4 - Apply other patch 5 - Tests pass Signed-off-by: Marc V?ron -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri May 19 07:34:37 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 19 May 2017 05:34:37 +0000 Subject: [Koha-bugs] [Bug 18635] Koha::Patron->guarantees() should return results alphabetically In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18635 Marc V?ron changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #63553|0 |1 is obsolete| | --- Comment #4 from Marc V?ron --- Created attachment 63559 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=63559&action=edit Bug 18635 - Koha::Patron->guarantees() should return results alphabetically To test: 1 - Add the same guarantor to a number of patrons, ensuring random order alphabetically 2 - View the guarantors record, note unordered list of guarantees 3 - Apply patch 4 - Guarantees are alphabetical Signed-off-by: Marc V?ron -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri May 19 07:34:50 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 19 May 2017 05:34:50 +0000 Subject: [Koha-bugs] [Bug 18635] Koha::Patron->guarantees() should return results alphabetically In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18635 Marc V?ron changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off CC| |veron at veron.ch -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri May 19 07:43:13 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 19 May 2017 05:43:13 +0000 Subject: [Koha-bugs] [Bug 18627] Items created via MarcItemFieldsToOrder are not linked to orders In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18627 Marcel de Rooy changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |m.de.rooy at rijksmuseum.nl --- Comment #3 from Marcel de Rooy --- QA: Looking here now -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri May 19 07:49:09 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 19 May 2017 05:49:09 +0000 Subject: [Koha-bugs] [Bug 18626] Add ability to track cardnumber changes for patrons In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18626 Marc V?ron changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #63532|0 |1 is obsolete| | --- Comment #2 from Marc V?ron --- Created attachment 63560 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=63560&action=edit Bug 18626 - Add ability to track cardnumber changes for patrons Some libraries want to keep a history of cardnumber changes for a patron. This is a feature that another ILS has. Test Plan: 1) Apply this patch 2) Enable the BorrowersLog 3) Modify a patron, update his or her cardnumber 4) Notice the entry in the action log containing the old and new cardnumbers 5) Edit a patron, leave the cardnumber the same 6) Note there is no cardnumber change entry in the action logs 7) Disable BorrowersLog, modify a patron cardnumber 8) Note there is no cardnumber change entry in teh action logs Followed test plan, works as expected Signed-off-by: Marc V?ron -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri May 19 07:49:30 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 19 May 2017 05:49:30 +0000 Subject: [Koha-bugs] [Bug 18626] Add ability to track cardnumber changes for patrons In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18626 Marc V?ron changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |veron at veron.ch Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri May 19 08:30:54 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 19 May 2017 06:30:54 +0000 Subject: [Koha-bugs] [Bug 15879] Allow multiple plugin directories to be defined in koha-conf.xml In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15879 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Text to go in the|Now is possible to define |It's now possible to define release notes|multiple plugin directories |multiple plugin directories |in the Koha conf file. This |in the Koha conf file. This |would allow for ease of |allows for ease of plugin |plugin development so that |development so that each |each plugin installed can |plugin installed can live |live in its own git |in its own git repository. |repository. For |For compatibility, the |compatibility, the first |first plugindir instance |plugindir instance defined |defined is used for |is used for uploading |uploading plugins via the |plugins via the web |web interface. |interface. | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri May 19 08:32:16 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 19 May 2017 06:32:16 +0000 Subject: [Koha-bugs] [Bug 18627] Items created via MarcItemFieldsToOrder are not linked to orders In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18627 Marcel de Rooy changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #63542|0 |1 is obsolete| | --- Comment #4 from Marcel de Rooy --- Created attachment 63561 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=63561&action=edit Bug 18627 - Items created via MarcItemFieldsToOrder are not linked to orders If using MarcItemFieldsToOrder with AcqCreateItem = Create, the order and the items will be created, but they will not be linked via aqorders_items! Test Plan: 1) Enable creation of items when ordering 2) Set up MarcItemFieldsToOrder 3) Upload an order record that uses the fields in step 2 4) Create a basket and add the records from the file 5) Note the order and items are created, but no rows in aqorders_items are created 6) Apply this patch 7) Repeat steps 3-4 8) Note the rows in aqorders_items are created! Signed-off-by: Kyle M Hall Signed-off-by: Marci Chen Signed-off-by: Marcel de Rooy -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri May 19 08:32:13 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 19 May 2017 06:32:13 +0000 Subject: [Koha-bugs] [Bug 18627] Items created via MarcItemFieldsToOrder are not linked to orders In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18627 Marcel de Rooy changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri May 19 08:32:38 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 19 May 2017 06:32:38 +0000 Subject: [Koha-bugs] [Bug 18627] Items created via MarcItemFieldsToOrder are not linked to orders In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18627 Marcel de Rooy changed: What |Removed |Added ---------------------------------------------------------------------------- QA Contact|testopia at bugs.koha-communit |m.de.rooy at rijksmuseum.nl |y.org | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri May 19 08:33:37 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 19 May 2017 06:33:37 +0000 Subject: [Koha-bugs] [Bug 17233] Add 008 value builder plugin for MARC21 classifications In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17233 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Text to go in the|This patch adds 008 |This patch adds a 008 release notes|cataloguing value builder |cataloguing value builder |for MARC21 classifications |for MARC21 classifications |records (LCC, DDC/Dewey, |records (LCC, DDC/Dewey, |UDC and so on). |UDC and so on). |In fact now |This is a |Koha doesn't really support |starting point for |classification records, |supporting classification |this is a starting point. |records in Koha. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri May 19 08:34:53 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 19 May 2017 06:34:53 +0000 Subject: [Koha-bugs] [Bug 17486] Remove 'Mozilla Persona' as an authentication method In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17486 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Text to go in the|'Persona' never really took |'Persona' never really took release notes|off, and although many |off, and although many |browsers currently support |browsers currently support |it, very few services |it, very few services |actually implement it. This |actually implement it. This |has lead to it's founders, |has lead its founders, |Mozilla, to end the |Mozilla, to end the |project. On November 30th, |project. On November 30th, |2016, Mozilla closed the |2016, Mozilla closed the |persona.org services. Now |persona.org services. Now |the feature is deleted from |the feature is deleted from |Koha. |Koha. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri May 19 08:38:02 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 19 May 2017 06:38:02 +0000 Subject: [Koha-bugs] [Bug 17762] Ability to translate notices In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17762 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Text to go in the|This develop adds the |It's now possible to release notes|ability to translate |translate notice templates |notices in different |into different languages. |languages. That way, if a |There is a new 'preferred |library has patrons from |language' setting available |different countries, they |in the user account, that |will not have to send the |controls which template |notices in only one |will be used when |language but they will be |generating notices. |able to translate them. | |In | |patron's details page you | |can see a new "prefered | |language" entry, you select | |a language to use it in | |letters. | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri May 19 08:38:32 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 19 May 2017 06:38:32 +0000 Subject: [Koha-bugs] [Bug 10382] collection not returning to null when removed from course reserves In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10382 Marcel de Rooy changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |m.de.rooy at rijksmuseum.nl --- Comment #31 from Marcel de Rooy --- (In reply to Jonathan Druart from comment #30) > I do not like the way this bug is fixed (especially the drop of the FK). Agree. Why not keep the FK and do not use 'UNCHANGED' etc. ? -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri May 19 08:39:47 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 19 May 2017 06:39:47 +0000 Subject: [Koha-bugs] [Bug 17960] Rename opac_news.new with opac_news.content In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17960 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Text to go in the|The db field opac_news.new |The database column release notes|is renamed |opac_news.new is renamed to |opac_news.content. |opac_news.content. The |So if |notice templates using that |you are using opac_news.new |placeholder should have |in your notice templates, |been updated automatically |you should update it to |(bug 18121). |opac_news.content. | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri May 19 08:43:38 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 19 May 2017 06:43:38 +0000 Subject: [Koha-bugs] [Bug 17665] SIP2 Item Information Response returns incorrect circulation status of ' 08' ( waiting on hold shelf ) if record has any holds In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17665 Marcel de Rooy changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |m.de.rooy at rijksmuseum.nl --- Comment #5 from Marcel de Rooy --- QA: Looking here now -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri May 19 08:45:49 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 19 May 2017 06:45:49 +0000 Subject: [Koha-bugs] [Bug 18629] Web installer 17.05 not properly translatable In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18629 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |bgkriegel at gmail.com, | |katrin.fischer at bsz-bw.de -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri May 19 08:48:12 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 19 May 2017 06:48:12 +0000 Subject: [Koha-bugs] [Bug 8361] Issuing rule if no rule is defined In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8361 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Text to go in the|In the previous versions if |In the previous versions if release notes|no issuing rule is defined, |no circulation rule was |Koha always grantd issuing. |defined, Koha always |Now, with this develop, |allowed to check out. Now, |Koha refuses any check-out |with this development, Koha |if no rule is found. |refuses check-out if no | |rule is found. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri May 19 09:07:56 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 19 May 2017 07:07:56 +0000 Subject: [Koha-bugs] [Bug 17665] SIP2 Item Information Response returns incorrect circulation status of ' 08' ( waiting on hold shelf ) if record has any holds In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17665 Marcel de Rooy changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri May 19 09:07:59 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 19 May 2017 07:07:59 +0000 Subject: [Koha-bugs] [Bug 17665] SIP2 Item Information Response returns incorrect circulation status of ' 08' ( waiting on hold shelf ) if record has any holds In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17665 Marcel de Rooy changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #62059|0 |1 is obsolete| | --- Comment #6 from Marcel de Rooy --- Created attachment 63562 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=63562&action=edit Bug 17665 - SIP2 Item Information Response returns incorrect circulation status of '08' ( waiting on hold shelf ) if record has any holds If a record has any holds on it, the SIP2 item information response will return a value of 08 "waiting on hold shelf" even if the item is not actually a waiting hold. This is clearly a bug. Test Plan: 1) Find an item that is not a waiting hold, but whose record has one or more holds. 2) Issue a SIP2 item information request 3) Note in the response, the circulation status field is '08' 4) Apply this patch 5) Repeat the item informationr request 6) Note the code is now '03' ( available ) 7) Check the item in to fill the hold 8) Repeat the item information request 9) Verify the circulation status is now '08' Followed test plan, works as expected Signed-off-by: Marc V?ron Signed-off-by: Marcel de Rooy -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri May 19 09:08:25 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 19 May 2017 07:08:25 +0000 Subject: [Koha-bugs] [Bug 17665] SIP2 Item Information Response returns incorrect circulation status of ' 08' ( waiting on hold shelf ) if record has any holds In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17665 Marcel de Rooy changed: What |Removed |Added ---------------------------------------------------------------------------- QA Contact|testopia at bugs.koha-communit |m.de.rooy at rijksmuseum.nl |y.org | Patch complexity|Trivial patch |Small patch -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri May 19 09:12:46 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 19 May 2017 07:12:46 +0000 Subject: [Koha-bugs] [Bug 18630] Translatability (Clubs): 'Cancel' is ambiguous and leads to mistakes In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18630 dilan at calyx.net.au changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |dilan at calyx.net.au --- Comment #2 from dilan at calyx.net.au --- Created attachment 63563 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=63563&action=edit Patch fails to apply with fatal sha1 error Patch fails to apply with the attached error message being displayed. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri May 19 09:25:26 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 19 May 2017 07:25:26 +0000 Subject: [Koha-bugs] [Bug 18630] Translatability (Clubs): 'Cancel' is ambiguous and leads to mistakes In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18630 --- Comment #3 from Marc V?ron --- (In reply to dilan from comment #2) > Created attachment 63563 [details] > Patch fails to apply with fatal sha1 error > > Patch fails to apply with the attached error message being displayed. Tested on current master: git bz apply 18630 Applies cleanly here -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri May 19 09:33:20 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 19 May 2017 07:33:20 +0000 Subject: [Koha-bugs] [Bug 18267] Update price and tax fields in EDI to reflect DB changes In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18267 Marcel de Rooy changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |m.de.rooy at rijksmuseum.nl Status|Signed Off |Failed QA --- Comment #9 from Marcel de Rooy --- Code looks good at first glance. But we are missing unit tests here. Sub process_invoice is changed in this patch set and sub update_price_from_invoice is added. Although it seems to be a private sub and could have been marked as such with an underscore. Apart from missing tests for the complete Koha/EDI.pm module, the patches do not have any test plans. I understand that it takes time to write unit tests, but if we keep passing by exception, they will not be written. Minor detail: The four titles "Proposed patch" do not really convey much information. We miss signoff lines. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri May 19 09:48:16 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 19 May 2017 07:48:16 +0000 Subject: [Koha-bugs] [Bug 11580] returnBeforeExpiry and closed day In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11580 --- Comment #10 from Baptiste --- I don't quite understand what is supposed to be done. Shall we move the whole fonction in which this code is added toward Koha::Calendar ? -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri May 19 10:13:07 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 19 May 2017 08:13:07 +0000 Subject: [Koha-bugs] [Bug 16568] Talking Tech generates phone notifications for all overdue actions In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16568 Marcel de Rooy changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |m.de.rooy at rijksmuseum.nl QA Contact|testopia at bugs.koha-communit |m.de.rooy at rijksmuseum.nl |y.org | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri May 19 10:13:42 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 19 May 2017 08:13:42 +0000 Subject: [Koha-bugs] [Bug 16568] Talking Tech generates phone notifications for all overdue actions In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16568 Marcel de Rooy changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri May 19 10:13:45 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 19 May 2017 08:13:45 +0000 Subject: [Koha-bugs] [Bug 16568] Talking Tech generates phone notifications for all overdue actions In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16568 Marcel de Rooy changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #63529|0 |1 is obsolete| | --- Comment #4 from Marcel de Rooy --- Created attachment 63564 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=63564&action=edit Bug 16568 - Talking Tech generates phone notifications for all overdue actions Regardless of whether the phone transport has been selected for a given overdue action or not, the Talking Tech outbound script generates and sends a line for that action. Test Plan: 1) Enable Talking Tech 2) Create one or more overdue actions without a phone transport selected and one or more with the phone transport selected 3) Generate the overdues csv file to send to Itive 4) Note the csv file has lines for actions that do not have the phone transport selected 5) Apply this patch 6) Repeat step 3 7) Note the csv file now only has lines for actions that have the phone transport selected Signed-off-by: Jonathan Field Signed-off-by: Marcel de Rooy -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri May 19 10:14:50 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 19 May 2017 08:14:50 +0000 Subject: [Koha-bugs] [Bug 16568] Talking Tech generates phone notifications for all overdue actions In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16568 --- Comment #5 from Marcel de Rooy --- Looks good to me (trivial change). Another point is moving these larger queries out of the scripts. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri May 19 10:23:16 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 19 May 2017 08:23:16 +0000 Subject: [Koha-bugs] [Bug 18629] Web installer 17.05 not properly translatable In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18629 --- Comment #1 from Marc V?ron --- For the titles, we have (e.g step1.tt): Koha › Web installer › [% UNLESS ( language ) %] Choose your language [% END %] [% IF ( language ) %] [% UNLESS ( checkmodule ) %] [% IF ( missing_modules ) %] Perl modules missing [% END %] [% IF ( problems ) %] Perl version obsolete [% END %] [% END %] Check Perl dependencies [% END %] We are inside HTMLtags, that's wrong: https://wiki.koha-community.org/wiki/Coding_Guidelines#HTML1:_Template_Toolkit_markup_inside_HTML -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri May 19 10:24:15 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 19 May 2017 08:24:15 +0000 Subject: [Koha-bugs] [Bug 18534] When IndependentBranches is enabled the pickup location displayed incorrectly on request.pl In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18534 Marcel de Rooy changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |m.de.rooy at rijksmuseum.nl --- Comment #3 from Marcel de Rooy --- QA: Looking here now -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri May 19 10:32:18 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 19 May 2017 08:32:18 +0000 Subject: [Koha-bugs] [Bug 17282] Ability to create charts for SQL reports In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17282 Alex Arnaud changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #55604|0 |1 is obsolete| | --- Comment #24 from Alex Arnaud --- Created attachment 63565 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=63565&action=edit Bug 17282: Ability to create charts for SQL reports Add a form under report's result that allow to configure and draw a chart (pie, bar, line and combination). Pie: Usefull only for a two-column report's result bar: Horizontal: Can be horizontal or vertical (check/uncheck horizontal checkbox), Group: allows to group columns (stacked bar chart), Line: show some columns as line in a bar chart (combination) line: line chart :) This patch adds 2 new js libraries: d3js and c3js: - c3.min.css - c3.min.js - d3.min.js Test plan: - Apply this patch, - make reports, - draw charts, - that's all Signed-off-by: Hector Castro Works as advertised Signed-off-by: Josef Moravec -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri May 19 10:32:26 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 19 May 2017 08:32:26 +0000 Subject: [Koha-bugs] [Bug 17282] Ability to create charts for SQL reports In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17282 Alex Arnaud changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #55605|0 |1 is obsolete| | --- Comment #25 from Alex Arnaud --- Created attachment 63566 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=63566&action=edit Bug 17282: (follow-up) Use drop-down menu for download chart instead To Test 1) Execute a report 2) Click in drop-down menu "Download" shows only three options 3) Draw a chart 4) Click again in drop-down menu "Download" shows a new option "Download chart" Signed-off-by: Alex Arnaud Signed-off-by: Josef Moravec -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri May 19 10:32:31 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 19 May 2017 08:32:31 +0000 Subject: [Koha-bugs] [Bug 17282] Ability to create charts for SQL reports In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17282 Alex Arnaud changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #55606|0 |1 is obsolete| | --- Comment #26 from Alex Arnaud --- Created attachment 63567 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=63567&action=edit Bug 17282 - Fix QA comments: - Don't scroll to the top when deleting a column, - prevents to delete all columns, - better handling of headers/results deleting Signed-off-by: Josef Moravec -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri May 19 10:32:38 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 19 May 2017 08:32:38 +0000 Subject: [Koha-bugs] [Bug 17282] Ability to create charts for SQL reports In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17282 Alex Arnaud changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #55607|0 |1 is obsolete| | --- Comment #27 from Alex Arnaud --- Created attachment 63568 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=63568&action=edit Bug 17282 - Ability to exclude the last line in report results This patch add a checkbox (exclude last line). This is useful when this last is the result of a sql rollup which is the sum of each column and make the chart not consistent Signed-off-by: Josef Moravec -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri May 19 10:32:45 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 19 May 2017 08:32:45 +0000 Subject: [Koha-bugs] [Bug 17282] Ability to create charts for SQL reports In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17282 Alex Arnaud changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #55868|0 |1 is obsolete| | --- Comment #28 from Alex Arnaud --- Created attachment 63569 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=63569&action=edit Bug 17282: Use fieldset.rows -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri May 19 10:32:50 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 19 May 2017 08:32:50 +0000 Subject: [Koha-bugs] [Bug 17282] Ability to create charts for SQL reports In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17282 Alex Arnaud changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #55869|0 |1 is obsolete| | --- Comment #29 from Alex Arnaud --- Created attachment 63570 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=63570&action=edit Bug 17282: Remove use of onclick -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri May 19 10:32:55 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 19 May 2017 08:32:55 +0000 Subject: [Koha-bugs] [Bug 17282] Ability to create charts for SQL reports In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17282 --- Comment #30 from Alex Arnaud --- Created attachment 63571 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=63571&action=edit Bug 17282 - Fix QA comments - Add a loading message, - prevent JS error when report fails, - fix (bootstrap 3 ?) displaying problems -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri May 19 10:33:52 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 19 May 2017 08:33:52 +0000 Subject: [Koha-bugs] [Bug 17282] Ability to create charts for SQL reports In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17282 Alex Arnaud changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #62529|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri May 19 10:45:40 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 19 May 2017 08:45:40 +0000 Subject: [Koha-bugs] [Bug 18534] When IndependentBranches is enabled the pickup location displayed incorrectly on request.pl In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18534 Marcel de Rooy changed: What |Removed |Added ---------------------------------------------------------------------------- Patch complexity|--- |Small patch Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri May 19 10:45:43 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 19 May 2017 08:45:43 +0000 Subject: [Koha-bugs] [Bug 18534] When IndependentBranches is enabled the pickup location displayed incorrectly on request.pl In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18534 Marcel de Rooy changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #63260|0 |1 is obsolete| | --- Comment #4 from Marcel de Rooy --- Created attachment 63572 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=63572&action=edit Bug 18534 - When IndependentBranches is enabled the pickup location displayed incorrectly on request.pl To recreate: 1 - Place a hold for pickup at Midway 2 - Enable independentbranches 3 - Login to staff interface as admin without superlibrarian status from a different branch 4 - View the holds for the title you placed a hold on 5 - The hold placed in step 1 should show a dropdown with current branch as pickup location, current branch is the only in that dropdown 6 - Verify it displays correctly for superlibrarian 7 - Apply patch 8 - The correct pickup location should show and not be editable 9 - Verify it is a dropdown Signed-off-by: Alex Buckley Signed-off-by: Marcel de Rooy -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri May 19 10:46:00 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 19 May 2017 08:46:00 +0000 Subject: [Koha-bugs] [Bug 18534] When IndependentBranches is enabled the pickup location displayed incorrectly on request.pl In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18534 Marcel de Rooy changed: What |Removed |Added ---------------------------------------------------------------------------- QA Contact|testopia at bugs.koha-communit |m.de.rooy at rijksmuseum.nl |y.org | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri May 19 10:56:02 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 19 May 2017 08:56:02 +0000 Subject: [Koha-bugs] [Bug 18125] Edit button can duplicate some circulation rule In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18125 Marcel de Rooy changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |m.de.rooy at rijksmuseum.nl Status|Signed Off |Failed QA --- Comment #14 from Marcel de Rooy --- (In reply to Jonathan Druart from comment #13) > I am not sure this is acceptable, it will become hard to copy rules. > Maybe we need an additional "Copy" action button? Indeed. I am not so sure if the advantage of this oneliner outweights the disadvantage of no longer being able to copy a rule. It should not be that hard to add a copy button? -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri May 19 10:58:54 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 19 May 2017 08:58:54 +0000 Subject: [Koha-bugs] [Bug 17944] Remove the sql code from itemtypes.pl administrative perl script In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17944 Marcel de Rooy changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |m.de.rooy at rijksmuseum.nl --- Comment #56 from Marcel de Rooy --- String changes. Return after freeze. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri May 19 11:05:51 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 19 May 2017 09:05:51 +0000 Subject: [Koha-bugs] [Bug 18125] Edit button can duplicate some circulation rule In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18125 --- Comment #15 from Baptiste --- (In reply to Marcel de Rooy from comment #14) > (In reply to Jonathan Druart from comment #13) > > I am not sure this is acceptable, it will become hard to copy rules. > > Maybe we need an additional "Copy" action button? > > Indeed. I am not so sure if the advantage of this oneliner outweights the > disadvantage of no longer being able to copy a rule. > It should not be that hard to add a copy button? Hum.. the problem with a copy button it that the working of this button wouldn't be intuitive. I mean if we create an copy button (like the old edit), this will not copy a rule if you don't modify the 2 first fields. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri May 19 11:10:21 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 19 May 2017 09:10:21 +0000 Subject: [Koha-bugs] [Bug 18125] Edit button can duplicate some circulation rule In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18125 --- Comment #16 from Marcel de Rooy --- (In reply to Baptiste from comment #15) > (In reply to Marcel de Rooy from comment #14) > > (In reply to Jonathan Druart from comment #13) > > > I am not sure this is acceptable, it will become hard to copy rules. > > > Maybe we need an additional "Copy" action button? > > > > Indeed. I am not so sure if the advantage of this oneliner outweights the > > disadvantage of no longer being able to copy a rule. > > It should not be that hard to add a copy button? > > Hum.. the problem with a copy button it that the working of this button > wouldn't be intuitive. > > I mean if we create an copy button (like the old edit), this will not copy a > rule if you don't modify the 2 first fields. Yeah, you may need to lift some check first and make sure it is applied later.. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri May 19 11:14:33 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 19 May 2017 09:14:33 +0000 Subject: [Koha-bugs] [Bug 13913] Renewal error message in OPAC is confusing In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13913 Marcel de Rooy changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |m.de.rooy at rijksmuseum.nl QA Contact|testopia at bugs.koha-communit |m.de.rooy at rijksmuseum.nl |y.org | --- Comment #6 from Marcel de Rooy --- Looks good to me. Cannot pass this in string freeze. The string is now in the po file with a lot of %s's. And with html tags in between they will become separate translations. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri May 19 11:15:22 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 19 May 2017 09:15:22 +0000 Subject: [Koha-bugs] [Bug 13452] Average checkout report always uses biblioitems.itemtype In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13452 Marcel de Rooy changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |m.de.rooy at rijksmuseum.nl --- Comment #17 from Marcel de Rooy --- String changes. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri May 19 11:16:38 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 19 May 2017 09:16:38 +0000 Subject: [Koha-bugs] [Bug 18536] Generating CSV using profile in serials late issues doesn' t work as described In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18536 Marcel de Rooy changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|koha-bugs at lists.koha-commun |josef.moravec at gmail.com |ity.org | QA Contact|testopia at bugs.koha-communit |m.de.rooy at rijksmuseum.nl |y.org | CC| |m.de.rooy at rijksmuseum.nl -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Fri May 19 11:21:00 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 19 May 2017 09:21:00 +0000 Subject: [Koha-bugs] [Bug 18629] Web installer 17.05 not properly translatable In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18629 --- Comment #2 from Marc V?ron --- Created attachment 63573 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=63573&action=edit Bug 18629 - Web installer 17.05 not properly translatable Fix for step1.tt Work in progress. Comments welcome. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Fri May 19 11:43:01 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 19 May 2017 09:43:01 +0000 Subject: [Koha-bugs] [Bug 18536] Generating CSV using profile in serials late issues doesn' t work as described In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18536 --- Comment #5 from Marcel de Rooy --- Created attachment 63575 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=63575&action=edit Bug 18536: [QA Follow-up] Tiny regex simplification Simplify regex for removing table name. No need to escape a dot between the square brackets. No need to specify a number of 1 between parentheses. Signed-off-by: Marcel de Rooy -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri May 19 11:42:57 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 19 May 2017 09:42:57 +0000 Subject: [Koha-bugs] [Bug 18536] Generating CSV using profile in serials late issues doesn' t work as described In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18536 --- Comment #4 from Marcel de Rooy --- Created attachment 63574 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=63574&action=edit Bug 18536: Generating CSV using profile in serials late issues doesn't work as described Description on editing csv profiles says: "You can also use your own headers (instead of the ones from Koha) by prefixing the field name with an header, followed by the equal sign." So the header should be optional, but in fact it's mandatory. Also the regular expression to cut table name from beginning of db column is not right. Test plan: 0. Don't apply the patch 1. Make two CSV profiles for exporting late issues a) SUPPLIER=aqbooksellers.name|TITLE=subscription.title|ISSUENUMBER=serial.serialseq|LATE SINCE=serial.planneddate b) aqbooksellers.name|TITLE=subscription.title|ISSUE NUMBER=serial.serialseq|LATE SINCE=serial.planneddate 2. Export late issues, profile a) works as expected, profile b) doesn't 3. Apply the patch 4. Both profiles should work Signed-off-by: Katrin Fischer Signed-off-by: Marcel de Rooy -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri May 19 11:43:37 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 19 May 2017 09:43:37 +0000 Subject: [Koha-bugs] [Bug 18536] Generating CSV using profile in serials late issues doesn' t work as described In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18536 Marcel de Rooy changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri May 19 11:43:27 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 19 May 2017 09:43:27 +0000 Subject: [Koha-bugs] [Bug 18536] Generating CSV using profile in serials late issues doesn' t work as described In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18536 Marcel de Rooy changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #63373|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri May 19 11:46:36 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 19 May 2017 09:46:36 +0000 Subject: [Koha-bugs] [Bug 18538] OPAC database user login internal server error In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18538 Marcel de Rooy changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |m.de.rooy at rijksmuseum.nl Status|Signed Off |In Discussion -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri May 19 11:49:11 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 19 May 2017 09:49:11 +0000 Subject: [Koha-bugs] [Bug 18547] On shelf holds allowed > "If all unavailable" ignores default hold policy In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18547 Marcel de Rooy changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |m.de.rooy at rijksmuseum.nl Status|Signed Off |Failed QA --- Comment #8 from Marcel de Rooy --- (In reply to Jonathan Druart from comment #7) > Any chances to see tests covering this change? Changing status. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri May 19 11:58:36 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 19 May 2017 09:58:36 +0000 Subject: [Koha-bugs] [Bug 12342] Patron registration datepicker dropdown shows only 10 years In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12342 Colin Campbell changed: What |Removed |Added ---------------------------------------------------------------------------- Resolution|FIXED |--- Status|RESOLVED |REOPENED --- Comment #19 from Colin Campbell --- Although the patch was applied patch code no longer there the bug has been reinstated and is being reported - marking as reopened -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri May 19 11:58:37 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 19 May 2017 09:58:37 +0000 Subject: [Koha-bugs] [Bug 18447] Datepicker only shows -10/+10 years for date of birth In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18447 Bug 18447 depends on bug 12342, which changed state. Bug 12342 Summary: Patron registration datepicker dropdown shows only 10 years https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12342 What |Removed |Added ---------------------------------------------------------------------------- Status|RESOLVED |REOPENED Resolution|FIXED |--- -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri May 19 12:14:29 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 19 May 2017 10:14:29 +0000 Subject: [Koha-bugs] [Bug 18629] Web installer 17.05 not properly translatable In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18629 Marc V?ron changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff --- Comment #3 from Marc V?ron --- Setting to 'Needs Signoff' for the changes in step1.tt To test: - Create po files - Verify that title and button text are picked by translator and appear in po file For other issues: Could it be that there were string changes since latest translations were uploaded to translate.koha-community.com ? BTW: Will bi back in about 8 hours -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Fri May 19 12:28:41 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 19 May 2017 10:28:41 +0000 Subject: [Koha-bugs] [Bug 18552] Borrower debarments do not show on member detail page. In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18552 Marcel de Rooy changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #63557|0 |1 is obsolete| | --- Comment #3 from Marcel de Rooy --- Created attachment 63576 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=63576&action=edit Bug 18552: Borrower debarments not showing on member detail page To test: 1) Go to a borrowers details page and create a manual restriction 2) Notice the restriction shows at the top of the page but the restriction tab says the member is currently unrestricted 3) Apply patch and refresh page 4) Restrictions tab should now correctly show debarments and correct number is shown 5) Confirming deleting and adding restrictions still works as expected Sponsored-by: Catalyst IT Followed test plan, works as expected Signed-off-by: Marc V?ron Signed-off-by: Marcel de Rooy -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri May 19 12:28:45 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 19 May 2017 10:28:45 +0000 Subject: [Koha-bugs] [Bug 18552] Borrower debarments do not show on member detail page. In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18552 --- Comment #4 from Marcel de Rooy --- Created attachment 63577 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=63577&action=edit Bug 18552: [QA Follow-up] Resolve warnings Like: Problem = a value of AutoResumeSuspendedHolds has been passed to param without key at /usr/share/koha/masterclone/C4/Templates.pm line 137. Problem = a value of relatives_borrowernumbers has been passed to param without key at /usr/share/koha/masterclone/C4/Templates.pm line 137. Problem is functions returning undef in list context (in this case housebound_role). No need to call Patrons::find a second time. Note: The call of GetDebarments in the first patch suffered from this too. It is in a fine place now too. But strictly speaking, should not have been moved. Signed-off-by: Marcel de Rooy -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri May 19 12:28:38 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 19 May 2017 10:28:38 +0000 Subject: [Koha-bugs] [Bug 18552] Borrower debarments do not show on member detail page. In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18552 Marcel de Rooy changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri May 19 12:29:24 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 19 May 2017 10:29:24 +0000 Subject: [Koha-bugs] [Bug 18552] Borrower debarments do not show on member detail page. In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18552 Marcel de Rooy changed: What |Removed |Added ---------------------------------------------------------------------------- QA Contact|testopia at bugs.koha-communit |m.de.rooy at rijksmuseum.nl |y.org | CC| |m.de.rooy at rijksmuseum.nl -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri May 19 12:33:18 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 19 May 2017 10:33:18 +0000 Subject: [Koha-bugs] [Bug 18613] Deleting a Letter from a library as superlibrarian deletes the " All libraries" rule In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18613 --- Comment #4 from Baptiste --- Created attachment 63578 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=63578&action=edit Bug 18613: Correct the behaviour TEST PLAN (reproducing bug) 1 - Set 'IndependantBranches' to enable 2 - Log in as Superlibrarian. 3 - Create 3 rules - 1 for all librairies (1) - 1 for the library of the superlibrarian (2) - 1 for another library (3) 4 - Try to delete them and see them and see that (3) isn't the good one (checking patch) 5 - Apply patch 6 - Try again 3- 7 - Connect as not superlibrarian 8 - Try again 3- -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri May 19 12:33:55 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 19 May 2017 10:33:55 +0000 Subject: [Koha-bugs] [Bug 18613] Deleting a Letter from a library as superlibrarian deletes the " All libraries" rule In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18613 Baptiste changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |baptiste.wojtkowski at biblibr | |e.com -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri May 19 12:33:57 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 19 May 2017 10:33:57 +0000 Subject: [Koha-bugs] [Bug 18613] Deleting a Letter from a library as superlibrarian deletes the " All libraries" rule In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18613 Baptiste changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #63486|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri May 19 12:46:10 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 19 May 2017 10:46:10 +0000 Subject: [Koha-bugs] [Bug 18637] New: Handle Free Text vendor notes on Edifact Quotes Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18637 Bug ID: 18637 Summary: Handle Free Text vendor notes on Edifact Quotes Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Acquisitions Assignee: koha-bugs at lists.koha-community.org Reporter: colin.campbell at ptfs-europe.com QA Contact: testopia at bugs.koha-community.org At present we store servicing instructions from the GIR segment of the quote in vendornote field of the order. We dont process the FTX segment (segment 25) of the quote. Some vendors (Ebsco) do use this for important information so we need to expand handling to handle Servicng instructions in GIR segment (both coded and free text) and vendor notes in FTX (both free text and coded ) and be able to include these in the generated orders -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Fri May 19 14:18:20 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 19 May 2017 12:18:20 +0000 Subject: [Koha-bugs] [Bug 18638] New: Bad display of prediction pattern with planified irregularities : translation issue Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18638 Bug ID: 18638 Summary: Bad display of prediction pattern with planified irregularities : translation issue Change sponsored?: --- Product: Koha Version: 3.22 Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Serials Assignee: koha-bugs at lists.koha-community.org Reporter: koha at univ-lyon3.fr QA Contact: testopia at bugs.koha-community.org CC: colin.campbell at ptfs-europe.com The problem occurs in french interface. Due to nested double quotes in French translation of a javascript message, the message is broken, both pages of prediction pattern are displayed at the same time and it's not possible to modify anything. ============================= In the po file we have this : #. SCRIPT #: intranet-tmpl/prog/en/modules/serials/subscription-add.tt:13 msgid "" "Warning! Present pattern has planned irregularities. Click on 'Test " "prediction pattern' to check if it's still valid" msgstr "" "Attention ! Le mod?le pr?sent a planifi? des irr?gularit?s.Cliquez sur " "\"Tester le pr?visionnel de bulletinage\" pour v?rifier s'il est toujours " "valable" ============================== In susbscription-add.tt we have : English alert(_("Warning! Present pattern has planned irregularities. Click on 'Test prediction pattern' to check if it's still valid")); French alert(_("Attention ! Le mod?le pr?sent a planifi? des irr?gularit?s.Cliquez sur "Tester le pr?visionnel de bulletinage" pour v?rifier s'il est toujours valable")); I suppose the double quotes are automatically escaped through po file creation but to get a correct rendering double quotes should be escaped by a double backslash. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri May 19 14:19:06 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 19 May 2017 12:19:06 +0000 Subject: [Koha-bugs] [Bug 18638] Bad display of prediction pattern with planified irregularities : translation issue In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18638 Koha Team Lyon 3 changed: What |Removed |Added ---------------------------------------------------------------------------- Priority|P5 - low |P3 CC| |koha at univ-lyon3.fr Severity|enhancement |normal -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Fri May 19 14:19:02 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 19 May 2017 12:19:02 +0000 Subject: [Koha-bugs] [Bug 18634] Missing empty line at end of opac.pref In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18634 --- Comment #5 from Blou --- For me, I enter "paypal" in the system preferences search and get 6 entries under Payment in English. I get nothing in French. Adding the empty line fixes it. Now, is it useless and senseless? I agree. I looked at circulation.pref for comfort before commiting, and saw the "semi-emtpy" line. I looked at fr-CA-pref.po for weirdness, could not find any. The # OPAC > Payments where right in the middle, all happy and comfy. If ONE wouldn't show up, I'd get it. But all six? It really points to opac.prefs, but I have no idea why (beside this dummy end line). :( -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri May 19 14:52:15 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 19 May 2017 12:52:15 +0000 Subject: [Koha-bugs] [Bug 18639] New: Separate replacement cost and retail price fields in acquisitions Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18639 Bug ID: 18639 Summary: Separate replacement cost and retail price fields in acquisitions Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Acquisitions Assignee: koha-bugs at lists.koha-community.org Reporter: nick at bywatersolutions.com QA Contact: testopia at bugs.koha-community.org Work to be done: 1 - Add a field 'replacementprice' to the aqorders table 2 - Display this field as 'Replacement price' when ordering 3 - Rename current 'Replacement price' field for orders to 'Retail price' 3a - 'Retail price' field will only be editable during initial ordering 3b - If 'Retail price' field is update, dependent fields will also be updated (currently they are only updated on change of 'lsit price') 4 - Allow for replacementprice to be populated via ItemFieldsToOrder preferences 5 - Adjust EDI scripts to allow for use of 'replacementprice' field 6 - Pass 'replacementprice' in aqorders through as 'items.replacementprice' when creating items 7 - aqorders.replacementprice should be editable throughout entire acquisitions workflow -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Fri May 19 14:52:41 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 19 May 2017 12:52:41 +0000 Subject: [Koha-bugs] [Bug 18639] Separate replacement cost and retail price fields in acquisitions In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18639 Nick Clemens changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|koha-bugs at lists.koha-commun |jonathan.druart at bugs.koha-c |ity.org |ommunity.org CC| |kyle at bywatersolutions.com -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri May 19 15:08:36 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 19 May 2017 13:08:36 +0000 Subject: [Koha-bugs] [Bug 18482] False duplicates detected on adding a batch from a stage file In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18482 --- Comment #9 from Koha Team Lyon 3 --- Created attachment 63579 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=63579&action=edit Bug 18482 False duplicates detected on adding a batch [16.11.x] add specific patch for 16.11.x. Just remove the biblio_count line that seems to been added more lately -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri May 19 15:23:22 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 19 May 2017 13:23:22 +0000 Subject: [Koha-bugs] [Bug 18627] Items created via MarcItemFieldsToOrder are not linked to orders In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18627 Kyle M Hall changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to Master --- Comment #5 from Kyle M Hall --- Pushed to master for 17.05! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri May 19 15:52:40 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 19 May 2017 13:52:40 +0000 Subject: [Koha-bugs] [Bug 14625] LDAP: mapped ExtendedPatronAttributes cause error when updated on authentication In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14625 Kyle M Hall changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to Master CC| |kyle at bywatersolutions.com --- Comment #16 from Kyle M Hall --- Pushed to master for 17.05, thanks Oliver! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri May 19 15:54:33 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 19 May 2017 13:54:33 +0000 Subject: [Koha-bugs] [Bug 18376] authority framework creation fails under Plack In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18376 Kyle M Hall changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to Master CC| |kyle at bywatersolutions.com --- Comment #10 from Kyle M Hall --- Pushed to master for 17.05, thanks Frido, Jonathan! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri May 19 16:00:49 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 19 May 2017 14:00:49 +0000 Subject: [Koha-bugs] [Bug 14625] LDAP: mapped ExtendedPatronAttributes cause error when updated on authentication In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14625 --- Comment #17 from Oliver Bock --- Great news! Hope this gets backported to 16.x as well. Thanks guys! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri May 19 16:25:17 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 19 May 2017 14:25:17 +0000 Subject: [Koha-bugs] [Bug 18438] Check in: Modal about holds hides important check in messages In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18438 Kyle M Hall changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |kyle at bywatersolutions.com Status|Passed QA |Pushed to Master --- Comment #29 from Kyle M Hall --- Pushed to master for 17.05, thanks Alex! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri May 19 16:27:50 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 19 May 2017 14:27:50 +0000 Subject: [Koha-bugs] [Bug 16568] Talking Tech generates phone notifications for all overdue actions In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16568 Kyle M Hall changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to Master --- Comment #6 from Kyle M Hall --- Pushed to master for 17.05! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri May 19 16:31:24 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 19 May 2017 14:31:24 +0000 Subject: [Koha-bugs] [Bug 17665] SIP2 Item Information Response returns incorrect circulation status of ' 08' ( waiting on hold shelf ) if record has any holds In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17665 Kyle M Hall changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to Master --- Comment #7 from Kyle M Hall --- Pushed to master for 17.05! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri May 19 16:33:48 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 19 May 2017 14:33:48 +0000 Subject: [Koha-bugs] [Bug 18534] When IndependentBranches is enabled the pickup location displayed incorrectly on request.pl In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18534 Kyle M Hall changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to Master CC| |kyle at bywatersolutions.com --- Comment #5 from Kyle M Hall --- Pushed to master for 17.05, thanks Nick! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri May 19 16:36:05 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 19 May 2017 14:36:05 +0000 Subject: [Koha-bugs] [Bug 18552] Borrower debarments do not show on member detail page. In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18552 Kyle M Hall changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |kyle at bywatersolutions.com Status|Passed QA |Pushed to Master --- Comment #5 from Kyle M Hall --- Pushed to master for 17.05, thanks Marcel! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri May 19 16:39:27 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 19 May 2017 14:39:27 +0000 Subject: [Koha-bugs] [Bug 18597] Quick add form does not transfer patron attributes values when switching forms /saving In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18597 Kyle M Hall changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |kyle at bywatersolutions.com Status|Passed QA |Pushed to Master --- Comment #7 from Kyle M Hall --- Pushed to master for 17.05, thanks Nick! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri May 19 16:43:34 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 19 May 2017 14:43:34 +0000 Subject: [Koha-bugs] [Bug 18536] Generating CSV using profile in serials late issues doesn' t work as described In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18536 Kyle M Hall changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |kyle at bywatersolutions.com Status|Passed QA |Pushed to Master --- Comment #6 from Kyle M Hall --- Pushed to master for 17.05, thanks Josef! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri May 19 16:47:04 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 19 May 2017 14:47:04 +0000 Subject: [Koha-bugs] [Bug 18578] Use subdirectory in / tmp for session storage during installation In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18578 Kyle M Hall changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to Master CC| |kyle at bywatersolutions.com --- Comment #5 from Kyle M Hall --- Pushed to master for 17.05, thanks Marcel! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri May 19 16:50:49 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 19 May 2017 14:50:49 +0000 Subject: [Koha-bugs] [Bug 18551] Hide with CSS dynamic elements in member search In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18551 Kyle M Hall changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |kyle at bywatersolutions.com Status|Passed QA |Pushed to Master --- Comment #20 from Kyle M Hall --- Pushed to master for 17.05, thanks Frido, Josef! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri May 19 17:06:41 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 19 May 2017 15:06:41 +0000 Subject: [Koha-bugs] [Bug 17196] Move marcxml out of the biblioitems table In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17196 Kyle M Hall changed: What |Removed |Added ---------------------------------------------------------------------------- Text to go in the|This development moves |This development moves release notes|marcxml out of the |marcxml out of the |biblioitems and |biblioitems and |deletedbiblioitems tables |deletedbiblioitems tables |and moves it to two new |and moves it to two new |tables: biblio_metadata and |tables: biblio_metadata and |deletedbiblio_metadata. SQL |deletedbiblio_metadata. SQL |queries on the marcxml data |queries using the |will get a performance |biblioitems table but not |boost. Storing the marcxml |the marcxml column will get |in a specific table will |a performance boost. |allow us to store several |Storing the marcxml in a |metadata formats (USMARC, |specific table will allow |MARCXML, MIJ, etc.). |us to store several |ATTENTION: all reports that |metadata formats (USMARC, |use ExtractValue to |MARCXML, MIJ, etc.). |retrieve MARC tags from |ATTENTION: all reports that |biblioitems.marcxml need to |use ExtractValue to |be updated/rewritten. |retrieve MARC tags from | |biblioitems.marcxml need to | |be updated/rewritten. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri May 19 17:24:16 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 19 May 2017 15:24:16 +0000 Subject: [Koha-bugs] [Bug 18066] Hea - Version 2 In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18066 Kyle M Hall changed: What |Removed |Added ---------------------------------------------------------------------------- Severity|enhancement |new feature CC| |kyle at bywatersolutions.com -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri May 19 17:57:47 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 19 May 2017 15:57:47 +0000 Subject: [Koha-bugs] [Bug 2954] Holds queue report should show date/time of last update In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=2954 Marjorie Barry-Vila changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |marjorie.barry-vila at ccsr.qc | |.ca -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri May 19 17:58:10 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 19 May 2017 15:58:10 +0000 Subject: [Koha-bugs] [Bug 18440] tmp_holdsqueue should have a timestamp In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18440 Marjorie Barry-Vila changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |marjorie.barry-vila at ccsr.qc | |.ca -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri May 19 18:33:35 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 19 May 2017 16:33:35 +0000 Subject: [Koha-bugs] [Bug 18569] Quick add patron will not copy over details from cities and towns pull down into patron details In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18569 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri May 19 18:33:40 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 19 May 2017 16:33:40 +0000 Subject: [Koha-bugs] [Bug 18569] Quick add patron will not copy over details from cities and towns pull down into patron details In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18569 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #63494|0 |1 is obsolete| | --- Comment #3 from Jonathan Druart --- Created attachment 63580 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=63580&action=edit Bug 18569 - Quick add patron will not copy over details from cities and towns pull down into patron details Followed test plan and the city value updates in the quick add form correctly. Signed-off-by: Dilan Johnpulle Signed-off-by: Jonathan Druart -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri May 19 18:38:45 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 19 May 2017 16:38:45 +0000 Subject: [Koha-bugs] [Bug 18548] running koha-create --request-db without an instance name should abort In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18548 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri May 19 18:38:50 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 19 May 2017 16:38:50 +0000 Subject: [Koha-bugs] [Bug 18548] running koha-create --request-db without an instance name should abort In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18548 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #63495|0 |1 is obsolete| | --- Comment #13 from Jonathan Druart --- Created attachment 63581 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=63581&action=edit Bug 18548: Print usage when missing instance name in koha-create script Test plan: 1. Run: debian/scripts/koha-create --request-db -> Without patch you see the getent error message -> With patch you see usage and "Missing instance name" message Signed-off-by: Dilan Johnpulle Signed-off-by: Jonathan Druart -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri May 19 20:22:41 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 19 May 2017 18:22:41 +0000 Subject: [Koha-bugs] [Bug 17898] Add a way to automatically convert SQL reports In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17898 Tom?s Cohen Arazi changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |tomascohen at gmail.com --- Comment #7 from Tom?s Cohen Arazi --- I've been trying to make up my mind before commenting. My conclusion is that this is a really hard task to achieve, and thus the current behaviour (i.e. propose a translated SQL, no magic stuff) is the way to go. I'd put it in a modal, and probably add a legend stating that they should contact someone who knows SQL to check before overwriting the old report (or the list). This is an example that won't work with this simplistic algorithm, but we could go forward without fixing it anyway, as reports are now broken for everyone anyway: $sql = q| SELECT biblionumber, marcxml, biblioitems.issn AS issn FROM biblioitems INNER JOIN biblio USING (biblionumber) WHERE biblionumber = 14|; $expected_converted_sql = q| SELECT biblionumber, metadata, biblioitems.issn AS issn FROM biblioitems INNER JOIN biblio USING (biblionumber) INNER JOIN biblio_metadata USING (biblionumber) WHERE biblionumber = 14|; so the algorithm works basically only if the query uses marcxml exclusively. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri May 19 20:28:52 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 19 May 2017 18:28:52 +0000 Subject: [Koha-bugs] [Bug 17898] Add a way to automatically convert SQL reports In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17898 --- Comment #8 from Tom?s Cohen Arazi --- (In reply to Tom?s Cohen Arazi from comment #7) > I've been trying to make up my mind before commenting. My conclusion is that > this is a really hard task to achieve, and thus the current behaviour (i.e. > propose a translated SQL, no magic stuff) is the way to go. I'd put it in a > modal, and probably add a legend stating that they should contact someone > who knows SQL to check before overwriting the old report (or the list). > > This is an example that won't work with this simplistic algorithm, but we > could go forward without fixing it anyway, as reports are now broken for > everyone anyway: > > $sql = q| > SELECT biblionumber, > marcxml, > biblioitems.issn AS issn > FROM biblioitems > INNER JOIN biblio USING (biblionumber) > WHERE biblionumber = 14|; > > $expected_converted_sql = q| > SELECT biblionumber, > metadata, > biblioitems.issn AS issn > FROM biblioitems > INNER JOIN biblio USING (biblionumber) > INNER JOIN biblio_metadata USING (biblionumber) > WHERE biblionumber = 14|; > > so the algorithm works basically only if the query uses marcxml exclusively. I'm sorry for the first part of my comment, it is already a modal, and has an 'Update' button. I just messed up with the rebase. I'd still add a note. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri May 19 20:29:16 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 19 May 2017 18:29:16 +0000 Subject: [Koha-bugs] [Bug 17898] Add a way to automatically convert SQL reports In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17898 Marc V?ron changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |veron at veron.ch -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri May 19 20:29:54 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 19 May 2017 18:29:54 +0000 Subject: [Koha-bugs] [Bug 17898] Add a way to automatically convert SQL reports In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17898 Tom?s Cohen Arazi changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #58961|0 |1 is obsolete| | --- Comment #10 from Tom?s Cohen Arazi --- Created attachment 63583 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=63583&action=edit Bug 17898: Followup - udpate templates for bootstrap 3 Signed-off-by: Tomas Cohen Arazi -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri May 19 20:29:47 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 19 May 2017 18:29:47 +0000 Subject: [Koha-bugs] [Bug 17898] Add a way to automatically convert SQL reports In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17898 Tom?s Cohen Arazi changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #58955|0 |1 is obsolete| | --- Comment #9 from Tom?s Cohen Arazi --- Created attachment 63582 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=63582&action=edit Bug 17898: Automagically convert SQL reports Bug 17196 move the marcxml out of the biblioitems table. That will break SQL reports using it. It would be handy to propose an automagically way to convert the SQL reports. We do not want to update the reports automatically without user inputs, it will be too hasardous. However we can lead the user to convert them. In this patchset I suggest to warn the user if a report is subject to be updated. TODO: Add a way to mark this job done (using a pref?) to remove the check and not to display false positives. Test plan: - Create some SQL reports (see https://wiki.koha-community.org/wiki/SQL_Reports_Library) - Go on the report list page (/reports/guided_reports.pl?phase=Use saved) - For the reports using biblioitems.marcxml you will see a new column warning you that it is obsolete - Click on update link => that will open a modal with the converted SQL query - Click on the update button => you will be informed that the query has been updated If all the reports are updated, the new column "Update" will no longer be displayed. Signed-off-by: Tomas Cohen Arazi -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri May 19 20:30:15 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 19 May 2017 18:30:15 +0000 Subject: [Koha-bugs] [Bug 17898] Add a way to automatically convert SQL reports In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17898 Tom?s Cohen Arazi changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri May 19 21:25:33 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 19 May 2017 19:25:33 +0000 Subject: [Koha-bugs] [Bug 18634] Missing empty line at end of opac.pref In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18634 --- Comment #6 from Marc V?ron --- Hi Blou I just did a git pull and then wanted to apply and sign off your patch. But now it seems that already without your patch the last line 826 has vanished. Maybe it was fixed by another patch? -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri May 19 22:25:04 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 19 May 2017 20:25:04 +0000 Subject: [Koha-bugs] [Bug 11210] Allow partial writeoff In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11210 Christopher Brannon changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |cbrannon at cdalibrary.org --- Comment #2 from Christopher Brannon --- I am glad to see this happen. It makes sense. Maybe this would be a good time to change this grouping of buttons in to an action button, defaulting to Pay all. Just a thought, since the number of buttons is growing. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat May 20 05:20:46 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 20 May 2017 03:20:46 +0000 Subject: [Koha-bugs] [Bug 1985] Email notification of new OPAC comments In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=1985 M. Tompsett changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|oleonard at myacpl.org |mtompset at hotmail.com --- Comment #48 from M. Tompsett --- I'm close to a resurrection of this. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat May 20 06:28:18 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 20 May 2017 04:28:18 +0000 Subject: [Koha-bugs] [Bug 18640] New: Addition of installation page to Koha manual covering web installer and onboarding tool Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18640 Bug ID: 18640 Summary: Addition of installation page to Koha manual covering web installer and onboarding tool Change sponsored?: --- Product: Koha Version: 17.05 Hardware: All OS: All Status: ASSIGNED Severity: enhancement Priority: P5 - low Component: Documentation Assignee: alexbuckley at catalyst.net.nz Reporter: alexbuckley at catalyst.net.nz QA Contact: testopia at bugs.koha-community.org The Koha installation process has changed quite a lot for Koha 17.05 with the addition of the onboarding tool and installer bootstrap styling and so the installation process should be covered in the Koha manual. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat May 20 08:54:32 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 20 May 2017 06:54:32 +0000 Subject: [Koha-bugs] [Bug 18641] New: Translatability: Get rid of template directives in translations for *reserves.tt files Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18641 Bug ID: 18641 Summary: Translatability: Get rid of template directives in translations for *reserves.tt files Change sponsored?: --- Product: Koha Version: unspecified Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: I18N/L10N Assignee: koha-bugs at lists.koha-community.org Reporter: veron at veron.ch QA Contact: testopia at bugs.koha-community.org CC: frederic at tamil.fr -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Sat May 20 09:01:15 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 20 May 2017 07:01:15 +0000 Subject: [Koha-bugs] [Bug 18641] Translatability: Get rid of template directives in translations for *reserves.tt files In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18641 --- Comment #1 from Marc V?ron --- Template directives should not be exposed in translation, but lines like the following pop up in the translation tool: Cancel [% IF TransferWhenCancelAllWaitingHolds %]and Transfer [% END %] All -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Sat May 20 09:23:11 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 20 May 2017 07:23:11 +0000 Subject: [Koha-bugs] [Bug 18641] Translatability: Get rid of template directives in translations for *reserves.tt files In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18641 --- Comment #2 from Marc V?ron --- Created attachment 63584 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=63584&action=edit Bug 18641 - Translatability: Get rid of template directives in translations for *reserves.tt files Template directives should not be exposed in translation, but lines like the following pop up in the translation tool: Cancel [% IF TransferWhenCancelAllWaitingHolds %]and Transfer [% END %] All This patch fixes it. To test: - Apply patch - Verify that code changes make sense - Verify that submit buttons of pendingreserves.tt and waitingreserves.tt still work and display the same string as before -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Sat May 20 09:24:23 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 20 May 2017 07:24:23 +0000 Subject: [Koha-bugs] [Bug 18641] Translatability: Get rid of template directives in translations for *reserves.tt files In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18641 Marc V?ron changed: What |Removed |Added ---------------------------------------------------------------------------- Patch complexity|--- |String patch Status|NEW |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Sat May 20 10:17:13 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 20 May 2017 08:17:13 +0000 Subject: [Koha-bugs] [Bug 18642] New: Internal Server Error in Guided reports wizard Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18642 Bug ID: 18642 Summary: Internal Server Error in Guided reports wizard Change sponsored?: --- Product: Koha Version: unspecified Hardware: All OS: All Status: NEW Severity: major Priority: P5 - low Component: Installation and upgrade (web-based installer) Assignee: koha-bugs at lists.koha-community.org Reporter: veron at veron.ch QA Contact: testopia at bugs.koha-community.org CC: gmcharlt at gmail.com Calling Guided reports wizard from Home > Reports results in an Internal Server Error. Plack error log says: Could not compile /home/marc/koha/reports/guided_reports.pl: Can't locate Data/Printer.pm in @INC It seems that the module Data::Printer is missing, but About page and installation tool do not complain about. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat May 20 10:39:30 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 20 May 2017 08:39:30 +0000 Subject: [Koha-bugs] [Bug 17898] Add a way to automatically convert SQL reports In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17898 Marc V?ron changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |18642 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18642 [Bug 18642] Internal Server Error in Guided reports wizard -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat May 20 10:39:30 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 20 May 2017 08:39:30 +0000 Subject: [Koha-bugs] [Bug 18642] Internal Server Error in Guided reports wizard In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18642 Marc V?ron changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on| |17898 --- Comment #1 from Marc V?ron --- Introduced by first patch in Bug 17898 - Add a way to automatically convert SQL reports Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17898 [Bug 17898] Add a way to automatically convert SQL reports -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat May 20 11:41:10 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 20 May 2017 09:41:10 +0000 Subject: [Koha-bugs] [Bug 18643] New: Remove dead code in reports/statistics ' Till reconciliation' Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18643 Bug ID: 18643 Summary: Remove dead code in reports/statistics 'Till reconciliation' Change sponsored?: --- Product: Koha Version: unspecified Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Architecture, internals, and plumbing Assignee: gmcharlt at gmail.com Reporter: veron at veron.ch QA Contact: testopia at bugs.koha-community.org File koha-tmpl/intranet-tmpl/prog/en/modules/reports/reports-home.tt contains a link to /cgi-bin/koha/reports/stats.screen.pl with label 'Till reconciliation' that is commented out since years. Remove this link and the related files: cgi-bin/koha/reports/stats.screen.pl koha-tmpl/intranet-tmpl/prog/en/modules/reports/stats_screen.tt -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat May 20 11:41:34 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 20 May 2017 09:41:34 +0000 Subject: [Koha-bugs] [Bug 18641] Translatability: Get rid of template directives in translations for *reserves.tt files In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18641 Marc V?ron changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|koha-bugs at lists.koha-commun |veron at veron.ch |ity.org | -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Sat May 20 11:49:50 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 20 May 2017 09:49:50 +0000 Subject: [Koha-bugs] [Bug 18643] Remove dead code in reports/statistics 'Till reconciliation' In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18643 --- Comment #1 from Marc V?ron --- Created attachment 63585 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=63585&action=edit Bug 18643: Remove dead code in reports/statistics 'Till reconciliation' File koha-tmpl/intranet-tmpl/prog/en/modules/reports/reports-home.tt contains a link to /cgi-bin/koha/reports/stats.screen.pl with label 'Till reconciliation' that is commented out since years. Remove this link and the related files: cgi-bin/koha/reports/stats.screen.pl koha-tmpl/intranet-tmpl/prog/en/modules/reports/stats_screen.tt To test: - Apply patch - Verify that Koha > Reports still display the same - Verify that two files stats.screen.pl and stats_screen.tt are gone and thet they are not used anywhere in the Koha codebase -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat May 20 11:56:40 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 20 May 2017 09:56:40 +0000 Subject: [Koha-bugs] [Bug 18643] Remove dead code in reports/statistics 'Till reconciliation' In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18643 Marc V?ron changed: What |Removed |Added ---------------------------------------------------------------------------- Patch complexity|--- |Trivial patch Status|NEW |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat May 20 12:31:28 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 20 May 2017 10:31:28 +0000 Subject: [Koha-bugs] [Bug 18644] New: Get rid of template directives when translating memberentrygen.tt Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18644 Bug ID: 18644 Summary: Get rid of template directives when translating memberentrygen.tt Change sponsored?: --- Product: Koha Version: unspecified Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: I18N/L10N Assignee: koha-bugs at lists.koha-community.org Reporter: veron at veron.ch QA Contact: testopia at bugs.koha-community.org CC: frederic at tamil.fr Example for pure tt directives in translations: [% UNLESS opduplicate %][% othernames | html %][% END %] -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Sat May 20 12:33:27 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 20 May 2017 10:33:27 +0000 Subject: [Koha-bugs] [Bug 18644] Get rid of template directives when translating memberentrygen.tt In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18644 --- Comment #1 from Marc V?ron --- Created attachment 63586 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=63586&action=edit Bug 18644: Get rid of template directives when translating memberentrygen.tt Work in progress, not yet ready for testing. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun May 21 00:40:09 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 20 May 2017 22:40:09 +0000 Subject: [Koha-bugs] [Bug 16711] OPAC Password recovery: Handling if multiple accounts have the same mail address In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16711 David Kuhn changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |techservspec at gmail.com -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun May 21 01:49:43 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 20 May 2017 23:49:43 +0000 Subject: [Koha-bugs] [Bug 16711] OPAC Password recovery: Handling if multiple accounts have the same mail address In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16711 --- Comment #6 from David Kuhn --- I second the idea that the card number/user id should be required to reset a password, since that should always be a unique identifier. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun May 21 07:34:30 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 21 May 2017 05:34:30 +0000 Subject: [Koha-bugs] [Bug 16711] OPAC Password recovery: Handling if multiple accounts have the same mail address In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16711 --- Comment #7 from Marc V?ron --- Thinking loud about sending information about all library accounts if in password recovery an email with multiple library accounts attached is given: What could be the reasons to have one email address and multiple accounts? - An individual has multiple library accounts, e.g. one for professional purposes and a private one. For exammple a teacher needs books for school and wants to separate that from their private lecture. In that case sending a reset links for multiple accounts would be OK (no privacy breach) because it is the same person. But atm the mail contains only a reset link, no information that would help to identifiy the account. So the individual could reset the wrong password. - A group (family, couple) shares the same email but they have different library accounts In that case, privacy is defined by the group: Either one individual has access to the email or all of the group have access. If all have access, one individual could change the password for an other one. That would be a privacy breach. OK then, it is not a good idea to send reset links for all accounts attached to an email account. IMO the easiest solution would be not to send recovery link(s), but to display an information similar to the one that appears if an email address is not found in the database (Error No account was found with the provided information. Please...) The message could be something like: ------------- Information Multiple library accounts are attached to this email. Please fill the field 'Login' to identify which password you want to reset. Please contact the library if you need further assistance. ------------- Additionally, there could be more enhancements (to be covered by separate bugs): - Have a syspref to prevent multiple accounts with same email (could get complicated for existing installs) - Have a precooked report that displays library accounts sharing one email address -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun May 21 10:03:10 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 21 May 2017 08:03:10 +0000 Subject: [Koha-bugs] [Bug 18060] Add onboarding functionality to guide users through setting up labels for the first time In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18060 --- Comment #5 from Alex Buckley --- Created attachment 63587 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=63587&action=edit Bug 18060 - Working label onboarding tool for creating a layout and a template -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun May 21 15:18:06 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 21 May 2017 13:18:06 +0000 Subject: [Koha-bugs] [Bug 18060] Add onboarding functionality to guide users through setting up labels for the first time In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18060 --- Comment #6 from Alex Buckley --- Created attachment 63588 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=63588&action=edit Bug 18060 - Implemented redirect to label-edit-profile.pl after the user has created a template using the label onboarding tool -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun May 21 15:20:18 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 21 May 2017 13:20:18 +0000 Subject: [Koha-bugs] [Bug 18060] Add onboarding functionality to guide users through setting up labels for the first time In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18060 --- Comment #7 from Alex Buckley --- Created attachment 63589 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=63589&action=edit Bug 18060 - Removed unused form in onboardinginclude3.inc -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun May 21 15:38:41 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 21 May 2017 13:38:41 +0000 Subject: [Koha-bugs] [Bug 18060] Add onboarding functionality to guide users through setting up labels for the first time In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18060 --- Comment #8 from Alex Buckley --- Test plan: 1. Make sure the creator_layouts, creator_templates and printers_profile database tables are empty 2. In the Koha staff interface navigate to Tools->Label-creator 3. Notice that a blank screen appears 4. Apply patches attached to this bug report 5. Refresh the label-home.pl page 6. Notice a form to create a layout appears 7. Fill out this layout creation form and submit it 8. Notice another form also on label-home.pl appears to create a template 9. Fill out the template creation form and submit the form 10. Notice you are redirected to label-edit-profile.pl to create a printer profile 11. Test if the label onboarding tool forms are displaying appropriately by clicking on Manage->Label templates and delete the template you just created 12. Now go to label-home.pl and notice that the template creation form is displayed 13. Fill out the form and submit it 14. Notice you are not redirected to label-edit-profile.pl because you have already created a profile which has not been deleted instead a blank label-home.pl is displayed -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun May 21 16:03:01 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 21 May 2017 14:03:01 +0000 Subject: [Koha-bugs] [Bug 18645] New: Creation of informational tool displayed after running Koha update Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18645 Bug ID: 18645 Summary: Creation of informational tool displayed after running Koha update Change sponsored?: --- Product: Koha Version: 17.05 Hardware: All OS: All Status: ASSIGNED Severity: enhancement Priority: P5 - low Component: Installation and upgrade (web-based installer) Assignee: alexbuckley at catalyst.net.nz Reporter: alexbuckley at catalyst.net.nz QA Contact: testopia at bugs.koha-community.org CC: gmcharlt at gmail.com After Koha site admins update their Koha version at present they simply log into the staff interface and the home page is displayed with no further information about what was installed. The enhancement that will be built to fill this niche will display all new sysprefs created since the users previous version by comparing version numbers (old version and new one just installed), the site admin will be able to review and modify the system preferences. Additionally links to the release notes (and manual where applicable) will be provided. If time permitting a further addition to this enhancement would be information about major new features in each release. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun May 21 16:26:51 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 21 May 2017 14:26:51 +0000 Subject: [Koha-bugs] [Bug 18646] New: Recommendation system for OPAC which integrates with the Mana database Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18646 Bug ID: 18646 Summary: Recommendation system for OPAC which integrates with the Mana database Change sponsored?: --- Product: Koha Version: 17.05 Hardware: All OS: All Status: ASSIGNED Severity: enhancement Priority: P5 - low Component: OPAC Assignee: alexbuckley at catalyst.net.nz Reporter: alexbuckley at catalyst.net.nz QA Contact: testopia at bugs.koha-community.org At present the Koha OPAC does not have a recommendation system which recommends items to patrons based on what either patrons also viewed, in much the same way that the Amazon recommendation engine does. The patches that will be developed to provide this functionality will store recommendation data persistently so that previous issues information does not have to be kept in the local instance database which would violate the US Patriot Act and French Law. Additionally to have a greater sample size to generate the recommendations the recommendation system will integrate with the Mana database. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun May 21 17:03:13 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 21 May 2017 15:03:13 +0000 Subject: [Koha-bugs] [Bug 18647] New: Internal server error on moremember.pl Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18647 Bug ID: 18647 Summary: Internal server error on moremember.pl Change sponsored?: --- Product: Koha Version: unspecified Hardware: All OS: All Status: NEW Severity: critical Priority: P5 - low Component: Architecture, internals, and plumbing Assignee: gmcharlt at gmail.com Reporter: veron at veron.ch QA Contact: testopia at bugs.koha-community.org To reproduce: Go to the Details page of a member. Result: Internal server error Plack error log: Template process failed: undef error - The method category_code is not covered by tests! at (...)/koha/C4/Templates.pm line 121. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun May 21 17:03:46 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 21 May 2017 15:03:46 +0000 Subject: [Koha-bugs] [Bug 18647] Internal server error on moremember.pl In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18647 Marc V?ron changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|gmcharlt at gmail.com |veron at veron.ch -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun May 21 17:05:20 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 21 May 2017 15:05:20 +0000 Subject: [Koha-bugs] [Bug 18647] Internal server error on moremember.pl In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18647 Marc V?ron changed: What |Removed |Added ---------------------------------------------------------------------------- Version|unspecified |master -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun May 21 17:07:12 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 21 May 2017 15:07:12 +0000 Subject: [Koha-bugs] [Bug 18647] Internal server error on moremember.pl In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18647 --- Comment #1 from Marc V?ron --- Created attachment 63590 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=63590&action=edit Bug 18647: Internal server error on moremember.pl To reproduce: Go to the Details page of a member. Result: Internal server error Plack error log: Template process failed: undef error - The method category_code is not covered by tests! at (...)/koha/C4/Templates.pm line 121. To test: Apply patch Try to reproduce - patron's detail page should now display without error -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun May 21 17:07:48 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 21 May 2017 15:07:48 +0000 Subject: [Koha-bugs] [Bug 18647] Internal server error on moremember.pl In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18647 Marc V?ron changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff Patch complexity|--- |Trivial patch -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun May 21 18:27:31 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 21 May 2017 16:27:31 +0000 Subject: [Koha-bugs] [Bug 16711] OPAC Password recovery: Handling if multiple accounts have the same mail address In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16711 Marc V?ron changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|oleonard at myacpl.org |veron at veron.ch -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun May 21 18:40:05 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 21 May 2017 16:40:05 +0000 Subject: [Koha-bugs] [Bug 16711] OPAC Password recovery: Handling if multiple accounts have the same mail address In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16711 --- Comment #8 from Marc V?ron --- Created attachment 63591 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=63591&action=edit Bug 16711: OPAC Password recovery: Handling if multiple accounts have the same mail address To reproduce: - Create 3 Accounts, login names are test01, test02, test03, Email is the same for all. - Go to OPAC -> Password recovery and indicate E-Mail only - You will get an email for only one of the accounts above. To test: - Apply patch, restart memcached and plack - Go to db, delete from borrower_password_recovery; - Try steps above to reproduce. You will get an error message: Account identification with this email address only is ambiguous. Please use the field 'Login' as well. - Verify that other cases work as before (provide valid / invalid login only, provide valid email for an existing account, provide unknown email, provide both login and email with all combinations of valid / invalid) -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun May 21 18:40:51 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 21 May 2017 16:40:51 +0000 Subject: [Koha-bugs] [Bug 16711] OPAC Password recovery: Handling if multiple accounts have the same mail address In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16711 Marc V?ron changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff Patch complexity|--- |Trivial patch -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun May 21 19:43:27 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 21 May 2017 17:43:27 +0000 Subject: [Koha-bugs] [Bug 18648] New: Get rid of tt directives in translation for macles.tt Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18648 Bug ID: 18648 Summary: Get rid of tt directives in translation for macles.tt Change sponsored?: --- Product: Koha Version: unspecified Hardware: All OS: All Status: NEW Severity: trivial Priority: P5 - low Component: I18N/L10N Assignee: koha-bugs at lists.koha-community.org Reporter: veron at veron.ch QA Contact: testopia at bugs.koha-community.org CC: frederic at tamil.fr koha-tmpl/intranet-tmpl/prog/en/modules/cataloguing/value_builder/macles.tt contains template directives inside a div tag: This is exposed in translation tool. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Sun May 21 19:44:27 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 21 May 2017 17:44:27 +0000 Subject: [Koha-bugs] [Bug 18648] Translatability: Get rid of tt directives in translation for macles.tt In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18648 Marc V?ron changed: What |Removed |Added ---------------------------------------------------------------------------- Summary|Get rid of tt directives in |Translatability: Get rid of |translation for macles.tt |tt directives in | |translation for macles.tt -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun May 21 19:50:16 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 21 May 2017 17:50:16 +0000 Subject: [Koha-bugs] [Bug 18648] Translatability: Get rid of tt directives in translation for macles.tt In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18648 --- Comment #1 from Marc V?ron --- Created attachment 63592 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=63592&action=edit Bug 18648 - Translatability: Get rid of tt directives in translation for macles.tt koha-tmpl/intranet-tmpl/prog/en/modules/cataloguing/value_builder/macles.tt contains template directives inside a div tag: This is exposed in translation tool. To test: - Carefully examine code changes - Apply patch, verify that the directive is no longer exposed (picked for po files) - If you know where / how this macles is used, verify that it behaves as before -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Sun May 21 19:50:57 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 21 May 2017 17:50:57 +0000 Subject: [Koha-bugs] [Bug 18648] Translatability: Get rid of tt directives in translation for macles.tt In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18648 Marc V?ron changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Sun May 21 19:52:18 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 21 May 2017 17:52:18 +0000 Subject: [Koha-bugs] [Bug 18644] Get rid of template directives when translating memberentrygen.tt In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18644 Marc V?ron changed: What |Removed |Added ---------------------------------------------------------------------------- Severity|enhancement |trivial -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun May 21 19:54:24 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 21 May 2017 17:54:24 +0000 Subject: [Koha-bugs] [Bug 18644] Translatability: Get rid of template directives in translation for memberentrygen.tt In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18644 Marc V?ron changed: What |Removed |Added ---------------------------------------------------------------------------- Summary|Get rid of template |Translatability: Get rid of |directives when translating |template directives in |memberentrygen.tt |translation for | |memberentrygen.tt -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun May 21 20:01:00 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 21 May 2017 18:01:00 +0000 Subject: [Koha-bugs] [Bug 18512] GetAuthorisedValues.GetByCode Template plugin should return code ( not empty string) if value not found In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18512 Mason James changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |mtj at kohaaloha.com -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun May 21 20:12:11 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 21 May 2017 18:12:11 +0000 Subject: [Koha-bugs] [Bug 16908] Koha::Patrons - Remove GetSortDetails In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16908 Mason James changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |mtj at kohaaloha.com -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun May 21 20:57:05 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 21 May 2017 18:57:05 +0000 Subject: [Koha-bugs] [Bug 18180] Sort Field 2 Blank on Patron Details Page In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18180 Mason James changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |mtj at kohaaloha.com -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun May 21 22:39:26 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 21 May 2017 20:39:26 +0000 Subject: [Koha-bugs] [Bug 18554] Adjust a few typos including responsability In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18554 --- Comment #8 from Katrin Fischer --- This is a candidate for 16.11.09 as we are already in string freeze for 16.11.08. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun May 21 22:48:51 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 21 May 2017 20:48:51 +0000 Subject: [Koha-bugs] [Bug 14399] Fix inventory.pl part two (following 12913) In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14399 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |katrin.fischer at bsz-bw.de --- Comment #31 from Katrin Fischer --- This is a candidate for 16.11.09 as we are in string freeze for 16.11.08. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun May 21 22:53:16 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 21 May 2017 20:53:16 +0000 Subject: [Koha-bugs] [Bug 18571] koha-conf.xml should include ES entry In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18571 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to Master |Pushed to Stable CC| |katrin.fischer at bsz-bw.de --- Comment #5 from Katrin Fischer --- This patch has been pushed to 16.11.x and will be in 16.11.08. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun May 21 22:55:24 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 21 May 2017 20:55:24 +0000 Subject: [Koha-bugs] [Bug 18627] Items created via MarcItemFieldsToOrder are not linked to orders In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18627 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |katrin.fischer at bsz-bw.de Status|Pushed to Master |RESOLVED Resolution|--- |FIXED Depends on| |15503 --- Comment #6 from Katrin Fischer --- Depends on the system preference added by bug 15503 which is not in 16.11.x. Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15503 [Bug 15503] Grab Item Information from Order Files -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun May 21 22:55:24 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 21 May 2017 20:55:24 +0000 Subject: [Koha-bugs] [Bug 15503] Grab Item Information from Order Files In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15503 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |18627 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18627 [Bug 18627] Items created via MarcItemFieldsToOrder are not linked to orders -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun May 21 22:56:15 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 21 May 2017 20:56:15 +0000 Subject: [Koha-bugs] [Bug 14625] LDAP: mapped ExtendedPatronAttributes cause error when updated on authentication In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14625 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to Master |Pushed to Stable --- Comment #18 from Katrin Fischer --- This patch has been pushed to 16.11.x and will be in 16.11.08. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun May 21 22:58:15 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 21 May 2017 20:58:15 +0000 Subject: [Koha-bugs] [Bug 18376] authority framework creation fails under Plack In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18376 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to Master |Pushed to Stable --- Comment #11 from Katrin Fischer --- These patches have been pushed to 16.11.x and will be in 16.11.08. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun May 21 23:12:11 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 21 May 2017 21:12:11 +0000 Subject: [Koha-bugs] [Bug 18438] Check in: Modal about holds hides important check in messages In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18438 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to Master |Pushed to Stable CC| |katrin.fischer at bsz-bw.de --- Comment #30 from Katrin Fischer --- This patch has been pushed to 16.11.x and will be in 16.11.08. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun May 21 23:13:38 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 21 May 2017 21:13:38 +0000 Subject: [Koha-bugs] [Bug 16568] Talking Tech generates phone notifications for all overdue actions In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16568 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |katrin.fischer at bsz-bw.de Status|Pushed to Master |Pushed to Stable --- Comment #7 from Katrin Fischer --- This patch has been pushed to 16.11.x and will be in 16.11.08. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun May 21 23:18:15 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 21 May 2017 21:18:15 +0000 Subject: [Koha-bugs] [Bug 17665] SIP2 Item Information Response returns incorrect circulation status of ' 08' ( waiting on hold shelf ) if record has any holds In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17665 --- Comment #8 from Katrin Fischer --- I am not sure, but was wondering if some 'self returns' might use that to recognize items on hold for sorting them accordingly. Is this something to worry about? -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun May 21 23:19:51 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 21 May 2017 21:19:51 +0000 Subject: [Koha-bugs] [Bug 18534] When IndependentBranches is enabled the pickup location displayed incorrectly on request.pl In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18534 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |katrin.fischer at bsz-bw.de Status|Pushed to Master |Pushed to Stable --- Comment #6 from Katrin Fischer --- This patch has been pushed to 16.11.x and will be in 16.11.08. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun May 21 23:21:17 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 21 May 2017 21:21:17 +0000 Subject: [Koha-bugs] [Bug 18552] Borrower debarments do not show on member detail page In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18552 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Summary|Borrower debarments do not |Borrower debarments do not |show on member detail page. |show on member detail page CC| |katrin.fischer at bsz-bw.de -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun May 21 23:23:00 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 21 May 2017 21:23:00 +0000 Subject: [Koha-bugs] [Bug 18552] Borrower debarments do not show on member detail page In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18552 --- Comment #6 from Katrin Fischer --- Patch doesn't apply cleanly to 16.11.x - please rebase! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun May 21 23:24:50 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 21 May 2017 21:24:50 +0000 Subject: [Koha-bugs] [Bug 18597] Quick add form does not transfer patron attributes values when switching forms /saving In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18597 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |katrin.fischer at bsz-bw.de Status|Pushed to Master |Pushed to Stable --- Comment #8 from Katrin Fischer --- This patch has been pushed to 16.11.x and will be in 16.11.08. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun May 21 23:26:35 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 21 May 2017 21:26:35 +0000 Subject: [Koha-bugs] [Bug 18536] Generating CSV using profile in serials late issues doesn' t work as described In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18536 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |katrin.fischer at bsz-bw.de Status|Pushed to Master |Pushed to Stable --- Comment #7 from Katrin Fischer --- These patches have been pushed to 16.11.x and will be in 16.11.08. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun May 21 23:42:13 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 21 May 2017 21:42:13 +0000 Subject: [Koha-bugs] [Bug 18578] Use subdirectory in / tmp for session storage during installation In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18578 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |katrin.fischer at bsz-bw.de Status|Pushed to Master |Pushed to Stable --- Comment #6 from Katrin Fischer --- This patch has been pushed to 16.11.x and will be in 16.11.08. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun May 21 23:46:05 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 21 May 2017 21:46:05 +0000 Subject: [Koha-bugs] [Bug 18551] Hide with CSS dynamic elements in member search In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18551 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |katrin.fischer at bsz-bw.de Status|Pushed to Master |Pushed to Stable --- Comment #21 from Katrin Fischer --- These patches have been pushed to 16.11.x and will be in 16.11.08. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun May 21 23:47:14 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 21 May 2017 21:47:14 +0000 Subject: [Koha-bugs] [Bug 17898] Add a way to automatically convert SQL reports In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17898 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |katrin.fischer at bsz-bw.de --- Comment #11 from Katrin Fischer --- Looks like this is in master now? -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun May 21 23:52:55 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 21 May 2017 21:52:55 +0000 Subject: [Koha-bugs] [Bug 12026] Shibboleth auto-provisioning - Create In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12026 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Text to go in the|This patch was only ever |This feature allows it to release notes|intended to 'add new' user |add new patron records from |record from Shibboleth into |Shibboleth into Koha |Koha ('provision') and not |('provision'). It is |to 'sync' Shibboleth with |possible to map |an existing Koha user. It |Sbibboleth's attributes |is possible to map |with Koha fields, the |Sbibboleth's attributes |configuration is done in |with Koha fields, the |koha-conf.xml. Syncing |configuration is done in |existing Koha users with |koha-conf.xml |Shibboleth is not | |implemented yet. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon May 22 00:59:56 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 21 May 2017 22:59:56 +0000 Subject: [Koha-bugs] [Bug 18484] opac-advsearch.tt missing closing div tag for .container-fluid In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18484 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Severity|enhancement |trivial -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon May 22 01:00:19 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 21 May 2017 23:00:19 +0000 Subject: [Koha-bugs] [Bug 18494] Fix Letters.t (follow-up of 15702) In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18494 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Severity|enhancement |normal -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon May 22 01:00:54 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 21 May 2017 23:00:54 +0000 Subject: [Koha-bugs] [Bug 18233] t/db_dependent/00-strict.t has non-existant resetversion.pl In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18233 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Severity|enhancement |trivial -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon May 22 01:01:50 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 21 May 2017 23:01:50 +0000 Subject: [Koha-bugs] [Bug 18505] OPAC Search History page does not respect OpacPublic syspref In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18505 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Severity|enhancement |normal -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon May 22 01:02:31 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 21 May 2017 23:02:31 +0000 Subject: [Koha-bugs] [Bug 14608] HEA : add possibility of sharing usage statistics in Administration page In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14608 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Component|Architecture, internals, |System Administration |and plumbing | CC| |gmcharlt at gmail.com -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon May 22 07:30:14 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 22 May 2017 05:30:14 +0000 Subject: [Koha-bugs] [Bug 18066] Hea - Version 2 In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18066 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Severity|new feature |enhancement -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon May 22 07:35:22 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 22 May 2017 05:35:22 +0000 Subject: [Koha-bugs] [Bug 18066] Hea - Version 2 In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18066 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Severity|enhancement |new feature -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon May 22 07:43:29 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 22 May 2017 05:43:29 +0000 Subject: [Koha-bugs] [Bug 18586] Create module to mint RDF subject URIs In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18586 --- Comment #1 from David Cook --- I've been thinking that it might be worthwhile to mint a URI and then store it in a database table. Even if we moved all the metadata for a bibliographic record into a triplestore, we'd still be storing transactional information in the relational database. So we're still going to have a biblionumber in the relational database. If we store the RDF URI in the RDBMS, we gain a certain robustness in the event that someone changes a system preference containing the URI syntax used for minting. I mean... if they changed the syntax, it could break the ability to dereference those old URIs, but it's still valid RDF even if you can't dereference it. Plus hopefully they'd fix it so that you could still dereference it (ideally through a redirect I reckon). -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon May 22 07:46:59 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 22 May 2017 05:46:59 +0000 Subject: [Koha-bugs] [Bug 18586] Create module to mint RDF subject URIs In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18586 David Cook changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on| |18585 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18585 [Bug 18585] Connect to RDF triplestore -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon May 22 07:46:59 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 22 May 2017 05:46:59 +0000 Subject: [Koha-bugs] [Bug 18585] Connect to RDF triplestore In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18585 David Cook changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |18586 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18586 [Bug 18586] Create module to mint RDF subject URIs -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon May 22 08:15:52 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 22 May 2017 06:15:52 +0000 Subject: [Koha-bugs] [Bug 18586] Create module to mint RDF subject URIs In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18586 David Cook changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on|18585 | Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18585 [Bug 18585] Connect to RDF triplestore -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon May 22 08:15:52 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 22 May 2017 06:15:52 +0000 Subject: [Koha-bugs] [Bug 18585] Connect to RDF triplestore In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18585 David Cook changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks|18586 | Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18586 [Bug 18586] Create module to mint RDF subject URIs -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon May 22 08:50:43 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 22 May 2017 06:50:43 +0000 Subject: [Koha-bugs] [Bug 17898] Add a way to automatically convert SQL reports In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17898 --- Comment #12 from Marc V?ron --- (In reply to Katrin Fischer from comment #11) > Looks like this is in master now? Yes, and leads to Bug 18642 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon May 22 08:54:09 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 22 May 2017 06:54:09 +0000 Subject: [Koha-bugs] [Bug 14778] DBIC should create/own the DB handler In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14778 David Cook changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |dcook at prosentient.com.au --- Comment #102 from David Cook --- I'm using the following: use t::lib::Mocks; BEGIN { t::lib::Mocks::mock_dbh; } However, I'm still getting the warning: DBIx::Class::Storage::DBI::_warn_undetermined_driver(): This version of DBIC does not yet seem to supply a driver for your particular RDBMS and/or connection method ('Mock'). While we will attempt to continue anyway, the results are likely to be underwhelming. Please upgrade DBIC, and if this message does not go away, file a bugreport including the following info: I'm using the newest DBIx::Class, so I don't think it's a case of upgrading DBIC. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon May 22 09:04:51 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 22 May 2017 07:04:51 +0000 Subject: [Koha-bugs] [Bug 18586] Create module to mint RDF subject URIs In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18586 --- Comment #2 from David Cook --- I've created a Koha::RDF module and a mint_uri() method. It just creates and returns the URI string using the URI module. I've also added some tests for it. I think saving it to the database will be part of AddBiblio and/or ModBiblio. Some thinking to do about how best to optimally add the URI to the database. Off the top of my head, I'd want to save it at AddBiblio time, but you'd want to be able to update existing biblios... so if you do ModBiblio, you could just run touch_all_biblios.pl. Anyway, it's 5:04pm, so that's another day. I'll post the code tomorrow morning. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon May 22 09:10:23 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 22 May 2017 07:10:23 +0000 Subject: [Koha-bugs] [Bug 11999] Add two checks in CanBookBeReserved and CanItemBeReserved In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11999 Julian Maurice changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #58741|0 |1 is obsolete| | --- Comment #49 from Julian Maurice --- Created attachment 63593 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=63593&action=edit Bug 11999: Add two checks in CanBookBeReserved and CanItemBeReserved - Check if borrower already has reserved the same biblio (or item). - Check if borrower has reached the maximum number of holds allowed (syspref maxreserves) The goal of this patch is to do these checks also when using ILS-DI services HoldTitle and HoldItem Test plan: ---------- Before patch: 1/ Set syspref maxreserves to 1 2/ Place some holds through ILS-DI and note that you can place more than 1 hold for a borrower 3/ Try to hold the same biblio/item with the same borrower through ILS-DI and note that you can Apply the patch 4/ Place some holds through ILS-DI, you shouldn't be able to place more than 1 hold for a borrower 5/ Try to hold the same biblio/item with the same borrower through ILS-DI. You shouldn't be able to do that. 6/ Try to place holds on staff interface and OPAC. The behaviour must be identical than before the patch. Maxreserves and alreadyreserved works on ILSDI Maxreserves works also on staff and opac Already reserves works also on staff and opac tests on t/db_dependent/Reserves.t and t/db_dependent/Holds.t passe (using koha_ut db) Signed-off-by: Alex Sassmannshausen Signed-off-by: Alex Arnaud -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon May 22 09:10:33 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 22 May 2017 07:10:33 +0000 Subject: [Koha-bugs] [Bug 11999] Add two checks in CanBookBeReserved and CanItemBeReserved In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11999 Julian Maurice changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #58743|0 |1 is obsolete| | --- Comment #51 from Julian Maurice --- Created attachment 63595 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=63595&action=edit Bug 11999: Remove 'alreadyReserved' check in CanBookBeReserved Since bug 14695 it is possible to reserve more than one item per biblio Also fix bad use of $item -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon May 22 09:10:28 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 22 May 2017 07:10:28 +0000 Subject: [Koha-bugs] [Bug 11999] Add two checks in CanBookBeReserved and CanItemBeReserved In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11999 Julian Maurice changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #58742|0 |1 is obsolete| | --- Comment #50 from Julian Maurice --- Created attachment 63594 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=63594&action=edit Bug 11999: Check for age restriction in CanBookBeReserved + improve t/db_dependent/Reserves.t to make tests pass on UNIMARC installation Maxreserves and alreadyreserved works on ILSDI Maxreserves works also on staff and opac Already reserves works also on staff and opac tests on t/db_dependent/Reserves.t and t/db_dependent/Holds.t passe (using koha_ut db) Signed-off-by: Alex Arnaud -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon May 22 09:11:16 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 22 May 2017 07:11:16 +0000 Subject: [Koha-bugs] [Bug 11999] Add two checks in CanBookBeReserved and CanItemBeReserved In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11999 Julian Maurice changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Patch doesn't apply |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon May 22 09:26:13 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 22 May 2017 07:26:13 +0000 Subject: [Koha-bugs] [Bug 18552] Borrower debarments do not show on member detail page In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18552 --- Comment #7 from Marcel de Rooy --- (In reply to Kyle M Hall from comment #5) > Pushed to master for 17.05, thanks Marcel! Don't forget Aleisha :) -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon May 22 09:38:12 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 22 May 2017 07:38:12 +0000 Subject: [Koha-bugs] [Bug 18647] Internal server error on moremember.pl In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18647 Josef Moravec changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon May 22 09:38:14 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 22 May 2017 07:38:14 +0000 Subject: [Koha-bugs] [Bug 18647] Internal server error on moremember.pl In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18647 Josef Moravec changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #63590|0 |1 is obsolete| | --- Comment #2 from Josef Moravec --- Created attachment 63596 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=63596&action=edit [SIGNED-OFF] Bug 18647: Internal server error on moremember.pl To reproduce: Go to the Details page of a member. Result: Internal server error Plack error log: Template process failed: undef error - The method category_code is not covered by tests! at (...)/koha/C4/Templates.pm line 121. To test: Apply patch Try to reproduce - patron's detail page should now display without error Signed-off-by: Josef Moravec -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon May 22 09:45:31 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 22 May 2017 07:45:31 +0000 Subject: [Koha-bugs] [Bug 17665] SIP2 Item Information Response returns incorrect circulation status of ' 08' ( waiting on hold shelf ) if record has any holds In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17665 --- Comment #9 from Colin Campbell --- (In reply to Katrin Fischer from comment #8) > I am not sure, but was wondering if some 'self returns' might use that to > recognize items on hold for sorting them accordingly. Is this something to > worry about? Most I'm familiar with use the checkin response to govern sorting so (hopefully) this should not affect the workflow -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon May 22 09:54:09 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 22 May 2017 07:54:09 +0000 Subject: [Koha-bugs] [Bug 18619] MARC modification templates does not delete In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18619 Jens Weber changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |jens.weber at phsh.ch Status|NEW |RESOLVED Resolution|--- |DUPLICATE --- Comment #2 from Jens Weber --- *** This bug has been marked as a duplicate of bug 17916 *** -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon May 22 09:54:09 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 22 May 2017 07:54:09 +0000 Subject: [Koha-bugs] [Bug 17916] "Delete MARC modification template" fails to actually delete it In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17916 Jens Weber changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |mishravk79 at gmail.com --- Comment #7 from Jens Weber --- *** Bug 18619 has been marked as a duplicate of this bug. *** -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon May 22 09:54:49 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 22 May 2017 07:54:49 +0000 Subject: [Koha-bugs] [Bug 18552] Borrower debarments do not show on member detail page In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18552 --- Comment #8 from Marcel de Rooy --- Created attachment 63597 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=63597&action=edit Bug 18552: [16.11.X] Borrower debarments not showing on member detail page To test: 1) Go to a borrowers details page and create a manual restriction 2) Notice the restriction shows at the top of the page but the restriction tab says the member is currently unrestricted 3) Apply patch and refresh page 4) Restrictions tab should now correctly show debarments and correct number is shown 5) Confirming deleting and adding restrictions still works as expected Sponsored-by: Catalyst IT Followed test plan, works as expected Signed-off-by: Marc V?ron Signed-off-by: Marcel de Rooy -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon May 22 09:54:53 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 22 May 2017 07:54:53 +0000 Subject: [Koha-bugs] [Bug 18552] Borrower debarments do not show on member detail page In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18552 --- Comment #9 from Marcel de Rooy --- Created attachment 63598 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=63598&action=edit Bug 18552: [16.11.X] [QA Follow-up] Resolve warnings Like: Problem = a value of AutoResumeSuspendedHolds has been passed to param without key at /usr/share/koha/masterclone/C4/Templates.pm line 137. Problem = a value of relatives_borrowernumbers has been passed to param without key at /usr/share/koha/masterclone/C4/Templates.pm line 137. Problem is functions returning undef in list context (in this case housebound_role). No need to call Patrons::find a second time. Note: The call of GetDebarments in the first patch suffered from this too. It is in a fine place now too. But strictly speaking, should not have been moved. Signed-off-by: Marcel de Rooy -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon May 22 10:07:29 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 22 May 2017 08:07:29 +0000 Subject: [Koha-bugs] [Bug 11999] Add two checks in CanBookBeReserved and CanItemBeReserved In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11999 Josef Moravec changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Failed QA CC| |josef.moravec at gmail.com --- Comment #52 from Josef Moravec --- Test t/db_dependent/Holds.t is failing: # Failed test 'Patron cannot reserve item with hold limit of 1, 1 bib level hold placed' # at t/db_dependent/Holds.t line 472. # got: 'alreadyReserved' # expected: 'tooManyReserves' -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon May 22 10:14:09 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 22 May 2017 08:14:09 +0000 Subject: [Koha-bugs] [Bug 18376] authority framework creation fails under Plack In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18376 Julian Maurice changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |julian.maurice at biblibre.com --- Comment #12 from Julian Maurice --- Pushed to 3.22.x for 3.22.21 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon May 22 10:20:35 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 22 May 2017 08:20:35 +0000 Subject: [Koha-bugs] [Bug 18648] Translatability: Get rid of tt directives in translation for macles.tt In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18648 Josef Moravec changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon May 22 10:20:38 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 22 May 2017 08:20:38 +0000 Subject: [Koha-bugs] [Bug 18648] Translatability: Get rid of tt directives in translation for macles.tt In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18648 Josef Moravec changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #63592|0 |1 is obsolete| | --- Comment #2 from Josef Moravec --- Created attachment 63599 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=63599&action=edit [SIGNED-OFF] Bug 18648 - Translatability: Get rid of tt directives in translation for macles.tt koha-tmpl/intranet-tmpl/prog/en/modules/cataloguing/value_builder/macles.tt contains template directives inside a div tag: This is exposed in translation tool. To test: - Carefully examine code changes - Apply patch, verify that the directive is no longer exposed (picked for po files) - If you know where / how this macles is used, verify that it behaves as before Signed-off-by: Josef Moravec -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Mon May 22 10:24:32 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 22 May 2017 08:24:32 +0000 Subject: [Koha-bugs] [Bug 18648] Translatability: Get rid of tt directives in translation for macles.tt In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18648 Josef Moravec changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |josef.moravec at gmail.com Version|unspecified |master -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Mon May 22 10:35:13 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 22 May 2017 08:35:13 +0000 Subject: [Koha-bugs] [Bug 16711] OPAC Password recovery: Handling if multiple accounts have the same mail address In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16711 Josef Moravec changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon May 22 10:35:17 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 22 May 2017 08:35:17 +0000 Subject: [Koha-bugs] [Bug 16711] OPAC Password recovery: Handling if multiple accounts have the same mail address In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16711 Josef Moravec changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #63591|0 |1 is obsolete| | --- Comment #9 from Josef Moravec --- Created attachment 63600 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=63600&action=edit [SIGNED-OFF] Bug 16711: OPAC Password recovery: Handling if multiple accounts have the same mail address To reproduce: - Create 3 Accounts, login names are test01, test02, test03, Email is the same for all. - Go to OPAC -> Password recovery and indicate E-Mail only - You will get an email for only one of the accounts above. To test: - Apply patch, restart memcached and plack - Go to db, delete from borrower_password_recovery; - Try steps above to reproduce. You will get an error message: Account identification with this email address only is ambiguous. Please use the field 'Login' as well. - Verify that other cases work as before (provide valid / invalid login only, provide valid email for an existing account, provide unknown email, provide both login and email with all combinations of valid / invalid) Signed-off-by: Josef Moravec -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon May 22 10:42:06 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 22 May 2017 08:42:06 +0000 Subject: [Koha-bugs] [Bug 17047] Mana Knowledge Base : share data In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17047 --- Comment #72 from Baptiste --- Created attachment 63601 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=63601&action=edit Bug 17047: Correct encoding issues Modify the function manaRequest in order to set the right encoding format (UTF-8). -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon May 22 10:43:48 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 22 May 2017 08:43:48 +0000 Subject: [Koha-bugs] [Bug 16330] REST API: add routes to add, update and delete patrons In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16330 --- Comment #45 from Lari Taskula --- Hi! Sorry for the late response. My view for the todo: 1. "Move validation logic from controller to Koha::Patron" patch; obsolete validate() method - validations should occur in Koha::Patron->store(). 2. REST tests for this endpoint at t/db_dependent/api/v1/patrons.t is a big mess and should be rewritten to enhance readability and clearly separate tests of different operations, a good example is in cities.t. 3. Consider dependency to Bug 18137. Code-wise not a big change and required sooner or later as Swagger2 plugin is deprecated. 4. We discussed parameter naming convention in koha-devel (borrowernumber vs patron_id). Not sure if this was also discussed in a meeting, but I was left with the feeling that this is wanted by the community. However, could this be handled in another Bug to get this one moving? I have worked on 1. and 2. and have a patch for that, however the work was paused by discussion on 4. I will re-test the patch and attach it here. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon May 22 10:58:03 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 22 May 2017 08:58:03 +0000 Subject: [Koha-bugs] [Bug 17108] Automatic debian/control updates (stable) In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17108 --- Comment #2 from Mirko Tietgen --- Created attachment 63602 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=63602&action=edit Update debian/control Last changes in debian/control as added to 16.11.08 Signed-off-by: Mirko Tietgen -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon May 22 10:59:33 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 22 May 2017 08:59:33 +0000 Subject: [Koha-bugs] [Bug 17108] Automatic debian/control updates (stable) In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17108 Mirko Tietgen changed: What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon May 22 10:59:41 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 22 May 2017 08:59:41 +0000 Subject: [Koha-bugs] [Bug 17108] Automatic debian/control updates (stable) In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17108 Mirko Tietgen changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon May 22 10:59:47 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 22 May 2017 08:59:47 +0000 Subject: [Koha-bugs] [Bug 17108] Automatic debian/control updates (stable) In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17108 Mirko Tietgen changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon May 22 11:04:14 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 22 May 2017 09:04:14 +0000 Subject: [Koha-bugs] [Bug 18330] REST API: Date-time handling In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18330 --- Comment #1 from Lari Taskula --- Created attachment 63603 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=63603&action=edit Bug 18330: Add RFC3339 to Koha::DateUtils To test: 1. prove t/DateUtils.t -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon May 22 11:04:28 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 22 May 2017 09:04:28 +0000 Subject: [Koha-bugs] [Bug 18330] REST API: Date-time handling In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18330 --- Comment #2 from Lari Taskula --- Created attachment 63604 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=63604&action=edit Bug 18330: Handle date-time in Koha::Object->TO_JSON This patch formats timestamps and datetimes to meet date-time definition in RFC3339, as required by Swagger documentation. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Mon May 22 11:04:38 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 22 May 2017 09:04:38 +0000 Subject: [Koha-bugs] [Bug 18330] REST API: Date-time handling In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18330 --- Comment #3 from Lari Taskula --- Created attachment 63605 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=63605&action=edit Bug 18330: (follow-up) Add note to update tests when upgrading Mojolicious I noticed this test file is broken with Mojolicious 7. It is because they have replaced Mojo::JSON::_Bool with JSON::PP::Boolean. This patch adds TODO comment to easily identify the issue when updating. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Mon May 22 11:25:00 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 22 May 2017 09:25:00 +0000 Subject: [Koha-bugs] [Bug 18484] opac-advsearch.tt missing closing div tag for .container-fluid In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18484 Julian Maurice changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |julian.maurice at biblibre.com --- Comment #6 from Julian Maurice --- Pushed to 3.22.x for 3.22.21 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon May 22 11:29:32 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 22 May 2017 09:29:32 +0000 Subject: [Koha-bugs] [Bug 18442] Permission error when logging into staff interface as db user In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18442 Julian Maurice changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |julian.maurice at biblibre.com --- Comment #27 from Julian Maurice --- Pushed to 3.22.x for 3.22.21 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon May 22 11:30:11 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 22 May 2017 09:30:11 +0000 Subject: [Koha-bugs] [Bug 18643] Remove dead code in reports/statistics 'Till reconciliation' In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18643 Josef Moravec changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #63585|0 |1 is obsolete| | --- Comment #2 from Josef Moravec --- Created attachment 63606 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=63606&action=edit [SIGNED-OFF] Bug 18643: Remove dead code in reports/statistics 'Till reconciliation' File koha-tmpl/intranet-tmpl/prog/en/modules/reports/reports-home.tt contains a link to /cgi-bin/koha/reports/stats.screen.pl with label 'Till reconciliation' that is commented out since years. Remove this link and the related files: cgi-bin/koha/reports/stats.screen.pl koha-tmpl/intranet-tmpl/prog/en/modules/reports/stats_screen.tt To test: - Apply patch - Verify that Koha > Reports still display the same - Verify that two files stats.screen.pl and stats_screen.tt are gone and thet they are not used anywhere in the Koha codebase Signed-off-by: Josef Moravec -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon May 22 11:30:08 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 22 May 2017 09:30:08 +0000 Subject: [Koha-bugs] [Bug 18643] Remove dead code in reports/statistics 'Till reconciliation' In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18643 Josef Moravec changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon May 22 11:30:40 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 22 May 2017 09:30:40 +0000 Subject: [Koha-bugs] [Bug 18152] UNIMARC bib records imported with invalid 'a' char in label pos.9 In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18152 Julian Maurice changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |julian.maurice at biblibre.com --- Comment #27 from Julian Maurice --- Pushed to 3.22.x for 3.22.21 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon May 22 11:53:02 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 22 May 2017 09:53:02 +0000 Subject: [Koha-bugs] [Bug 18642] Internal Server Error in Guided reports wizard In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18642 Josef Moravec changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon May 22 11:53:05 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 22 May 2017 09:53:05 +0000 Subject: [Koha-bugs] [Bug 18642] Internal Server Error in Guided reports wizard In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18642 --- Comment #2 from Josef Moravec --- Created attachment 63607 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=63607&action=edit Bug 18642: Add missing dependency for Data::Printer module Test plan: 1) Go to About page -- without patch you can't see Data::Printer listed -- with patch you'll see it 2) uninstall Data::Printer - apt-get remove libdata-printer-perl 3) go to Reports -> Use saved - you'll see ISE 4) install the module again - apt-get install libdata-printer-perl 5) go to Reports -> Use saved - everything should work fine -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon May 22 11:53:54 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 22 May 2017 09:53:54 +0000 Subject: [Koha-bugs] [Bug 18642] Internal Server Error in Guided reports wizard In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18642 Josef Moravec changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|koha-bugs at lists.koha-commun |josef.moravec at gmail.com |ity.org | Version|unspecified |master CC| |josef.moravec at gmail.com -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon May 22 12:03:08 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 22 May 2017 10:03:08 +0000 Subject: [Koha-bugs] [Bug 18230] Generate Koha::Patron::Modification verification_token in -> new In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18230 Lari Taskula changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon May 22 12:04:06 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 22 May 2017 10:04:06 +0000 Subject: [Koha-bugs] [Bug 18641] Translatability: Get rid of template directives in translations for *reserves.tt files In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18641 Josef Moravec changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon May 22 12:04:09 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 22 May 2017 10:04:09 +0000 Subject: [Koha-bugs] [Bug 18641] Translatability: Get rid of template directives in translations for *reserves.tt files In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18641 Josef Moravec changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #63584|0 |1 is obsolete| | --- Comment #3 from Josef Moravec --- Created attachment 63608 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=63608&action=edit [SIGNED-OFF] Bug 18641 - Translatability: Get rid of template directives in translations for *reserves.tt files Template directives should not be exposed in translation, but lines like the following pop up in the translation tool: Cancel [% IF TransferWhenCancelAllWaitingHolds %]and Transfer [% END %] All This patch fixes it. To test: - Apply patch - Verify that code changes make sense - Verify that submit buttons of pendingreserves.tt and waitingreserves.tt still work and display the same string as before Signed-off-by: Josef Moravec -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon May 22 12:09:04 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 22 May 2017 10:09:04 +0000 Subject: [Koha-bugs] [Bug 17665] SIP2 Item Information Response returns incorrect circulation status of ' 08' ( waiting on hold shelf ) if record has any holds In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17665 --- Comment #10 from Katrin Fischer --- Hi Colin, thx for commenting. Because I've been trying to figure this out - which is the marker in the return response? -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon May 22 12:11:25 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 22 May 2017 10:11:25 +0000 Subject: [Koha-bugs] [Bug 18634] Missing empty line at end of opac.pref In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18634 Josef Moravec changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |josef.moravec at gmail.com --- Comment #7 from Josef Moravec --- (In reply to Marc V?ron from comment #6) > Hi Blou > I just did a git pull and then wanted to apply and sign off your patch. > But now it seems that already without your patch the last line 826 has > vanished. > Maybe it was fixed by another patch? The same for me, but opac.pref was touch last time about 3 month ago -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon May 22 12:16:44 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 22 May 2017 10:16:44 +0000 Subject: [Koha-bugs] [Bug 18233] t/db_dependent/00-strict.t has non-existant resetversion.pl In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18233 Julian Maurice changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |julian.maurice at biblibre.com --- Comment #6 from Julian Maurice --- Pushed to 3.22.x for 3.22.21 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon May 22 12:21:37 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 22 May 2017 10:21:37 +0000 Subject: [Koha-bugs] [Bug 18642] Internal Server Error in Guided reports wizard In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18642 Tom?s Cohen Arazi changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |tomascohen at gmail.com --- Comment #3 from Tom?s Cohen Arazi --- When rebasing the original patches, I introduced the dep for debugging purposes only. We should just remove the code that uses Data::Printer instead! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon May 22 12:21:48 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 22 May 2017 10:21:48 +0000 Subject: [Koha-bugs] [Bug 18505] OPAC Search History page does not respect OpacPublic syspref In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18505 Julian Maurice changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |julian.maurice at biblibre.com --- Comment #12 from Julian Maurice --- Pushed to 3.22.x for 3.22.21 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon May 22 12:26:28 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 22 May 2017 10:26:28 +0000 Subject: [Koha-bugs] [Bug 16748] Batch checkout needs set due date In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16748 Rob Corp changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |robcorp169 at gmail.com --- Comment #2 from Rob Corp --- Yes, as it happens all our batch issues require a specific date. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Mon May 22 12:39:56 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 22 May 2017 10:39:56 +0000 Subject: [Koha-bugs] [Bug 4460] Amazon' s AssociateID tag not used in links so referred revenue lost In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=4460 Julian Maurice changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |julian.maurice at biblibre.com --- Comment #40 from Julian Maurice --- Pushed to 3.22.x for 3.22.21 -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon May 22 12:41:10 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 22 May 2017 10:41:10 +0000 Subject: [Koha-bugs] [Bug 18642] Internal Server Error in Guided reports wizard In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18642 Josef Moravec changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #63607|0 |1 is obsolete| | --- Comment #4 from Josef Moravec --- Created attachment 63609 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=63609&action=edit Bug 18642: Remove debug messages Test plan: 0) Apply the patch 1) git grep Data::Printer -> should return no results 2) Go to Reports -> Use saved - should work fine -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon May 22 12:41:52 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 22 May 2017 10:41:52 +0000 Subject: [Koha-bugs] [Bug 18642] Internal Server Error in Guided reports wizard In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18642 --- Comment #5 from Josef Moravec --- (In reply to Tom?s Cohen Arazi from comment #3) > When rebasing the original patches, I introduced the dep for debugging > purposes only. We should just remove the code that uses Data::Printer > instead! Ok, I've attached new patch. Thanks! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon May 22 12:42:44 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 22 May 2017 10:42:44 +0000 Subject: [Koha-bugs] [Bug 18535] Clicking 'edit printer profile' in label creator causes software error In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18535 Julian Maurice changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |julian.maurice at biblibre.com --- Comment #6 from Julian Maurice --- Pushed to 3.22.x for 3.22.21 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon May 22 12:43:25 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 22 May 2017 10:43:25 +0000 Subject: [Koha-bugs] [Bug 17665] SIP2 Item Information Response returns incorrect circulation status of ' 08' ( waiting on hold shelf ) if record has any holds In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17665 --- Comment #11 from Colin Campbell --- (In reply to Katrin Fischer from comment #10) > Hi Colin, thx for commenting. Because I've been trying to figure this out - > which is the marker in the return response? 3M added a number of hold related fields CY id of the user with the hold, CT location to route to DA Hold Patron name and CV Alert Type which is 01 if a hold is found 02 if a hold is found requiring transit. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon May 22 12:47:06 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 22 May 2017 10:47:06 +0000 Subject: [Koha-bugs] [Bug 18340] Progress bar length is wrong In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18340 Julian Maurice changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |julian.maurice at biblibre.com --- Comment #6 from Julian Maurice --- Pushed to 3.22.x for 3.22.21 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon May 22 12:48:02 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 22 May 2017 10:48:02 +0000 Subject: [Koha-bugs] [Bug 17282] Ability to create charts for SQL reports In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17282 Josef Moravec changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |josef.moravec at gmail.com Status|Needs Signoff |Patch doesn't apply --- Comment #31 from Josef Moravec --- Could you please rebase? I am getting fatal: sha1 information is lacking or useless (koha-tmpl/intranet-tmpl/prog/en/modules/reports/guided_reports_start.tt). on the last patch. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon May 22 12:49:34 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 22 May 2017 10:49:34 +0000 Subject: [Koha-bugs] [Bug 18370] Columns settings patrons>id=memberresultst : display bug In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18370 --- Comment #16 from Julian Maurice --- Pushed to 3.22.x for 3.22.21 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon May 22 12:53:48 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 22 May 2017 10:53:48 +0000 Subject: [Koha-bugs] [Bug 18444] Add TalkingTechItivaPhoneNotification to sysprefs.sql In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18444 Julian Maurice changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |julian.maurice at biblibre.com --- Comment #9 from Julian Maurice --- Pushed to 3.22.x for 3.22.21 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon May 22 12:55:10 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 22 May 2017 10:55:10 +0000 Subject: [Koha-bugs] [Bug 18630] Translatability (Clubs): 'Cancel' is ambiguous and leads to mistakes In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18630 Josef Moravec changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Failed QA CC| |josef.moravec at gmail.com --- Comment #4 from Josef Moravec --- Just tested 1) I think the word "enrollement" should be "enrollment" 2) The patch fixes only OPAC, in staff client remains "Cancel" -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon May 22 12:56:27 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 22 May 2017 10:56:27 +0000 Subject: [Koha-bugs] [Bug 17257] Cannot create a patron under MySQL 5.7 In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17257 --- Comment #13 from Julian Maurice --- Pushed to 3.22.x for 3.22.21 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon May 22 13:08:33 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 22 May 2017 11:08:33 +0000 Subject: [Koha-bugs] [Bug 18632] CGI::param called in list context flooding erro logs In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18632 Josef Moravec changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon May 22 13:08:37 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 22 May 2017 11:08:37 +0000 Subject: [Koha-bugs] [Bug 18632] CGI::param called in list context flooding erro logs In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18632 Josef Moravec changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #63548|0 |1 is obsolete| | --- Comment #2 from Josef Moravec --- Created attachment 63610 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=63610&action=edit [SIGNED-OFF] Bug 18632: Remove 'CGI::param called in list context' warnings Once again, after bug 16154 and bug 16259 we need to remove more occurrence of CGi->param called in list context. Refer to bug 15809 for more information. Test plan: Make sure you do not see the error on the modified scripts. Signed-off-by: Josef Moravec -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon May 22 13:27:01 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 22 May 2017 11:27:01 +0000 Subject: [Koha-bugs] [Bug 17381] Add system preference SCOMainUserBlock In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17381 Josef Moravec changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon May 22 13:27:05 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 22 May 2017 11:27:05 +0000 Subject: [Koha-bugs] [Bug 17381] Add system preference SCOMainUserBlock In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17381 Josef Moravec changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #62295|0 |1 is obsolete| | --- Comment #6 from Josef Moravec --- Created attachment 63611 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=63611&action=edit [SIGNED-OFF] Bug 17381: Add system preference SCOMainUserBlock This patch adds a system preference SCOMainUserBlock to display custom HTML on the self checkout page. To test: - Set up self checkout (see section Self Checkout in Circulaton sysprefs ) - Apply patch - Update db - Add some HTML system preference SCOMainUserBlock - Go to sco page - Verify that HTML displays on page (logged in and not logged in) Signed-off-by: Josef Moravec -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon May 22 13:29:22 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 22 May 2017 11:29:22 +0000 Subject: [Koha-bugs] [Bug 16515] Did you mean? links don't wrap on smaller screens In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16515 Julian Maurice changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |julian.maurice at biblibre.com --- Comment #14 from Julian Maurice --- Pushed to 3.22.x for 3.22.21 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon May 22 13:31:06 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 22 May 2017 11:31:06 +0000 Subject: [Koha-bugs] [Bug 18504] Amount owed on fines tab should be formatted as price if < 10 or credit In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18504 --- Comment #6 from Julian Maurice --- Pushed to 3.22.x for 3.22.21 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon May 22 13:32:02 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 22 May 2017 11:32:02 +0000 Subject: [Koha-bugs] [Bug 17047] Mana Knowledge Base : share data In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17047 Josef Moravec changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Patch doesn't apply CC| |josef.moravec at gmail.com --- Comment #73 from Josef Moravec --- Could you rebase please? I am getting: fatal: sha1 information is lacking or useless (installer/data/mysql/sysprefs.sql). Repository lacks necessary blobs to fall back on 3-way merge. Cannot fall back to three-way merge. Patch failed at 0001 Bug 17047 SQL reports management with Mana-KB -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon May 22 13:33:08 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 22 May 2017 11:33:08 +0000 Subject: [Koha-bugs] [Bug 17936] Search bar not aligned on right in small screen sizes In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17936 Julian Maurice changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |julian.maurice at biblibre.com --- Comment #9 from Julian Maurice --- Pushed to 3.22.x for 3.22.21 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon May 22 13:38:58 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 22 May 2017 11:38:58 +0000 Subject: [Koha-bugs] [Bug 17618] perl-modules Debian package name change In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17618 Julian Maurice changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |julian.maurice at biblibre.com --- Comment #11 from Julian Maurice --- Pushed to 3.22.x for 3.22.21 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon May 22 14:42:44 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 22 May 2017 12:42:44 +0000 Subject: [Koha-bugs] [Bug 14625] LDAP: mapped ExtendedPatronAttributes cause error when updated on authentication In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14625 Julian Maurice changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |julian.maurice at biblibre.com --- Comment #19 from Julian Maurice --- Pushed to 3.22.x for 3.22.21 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon May 22 14:43:43 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 22 May 2017 12:43:43 +0000 Subject: [Koha-bugs] [Bug 18642] Internal Server Error in Guided reports wizard In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18642 Marc V?ron changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #63609|0 |1 is obsolete| | --- Comment #6 from Marc V?ron --- Created attachment 63612 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=63612&action=edit Bug 18642: Remove debug messages Test plan: 0) Apply the patch 1) git grep Data::Printer -> should return no results 2) Go to Reports -> Use saved - should work fine Signed-off-by: Marc V?ron -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon May 22 14:44:06 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 22 May 2017 12:44:06 +0000 Subject: [Koha-bugs] [Bug 18642] Internal Server Error in Guided reports wizard In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18642 Marc V?ron changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off Patch complexity|--- |Trivial patch -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon May 22 14:48:31 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 22 May 2017 12:48:31 +0000 Subject: [Koha-bugs] [Bug 18647] Internal server error on moremember.pl In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18647 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Failed QA CC| |jonathan.druart at bugs.koha-c | |ommunity.org --- Comment #3 from Jonathan Druart --- No, it is definitely not the way to fix it, the borrower variable comes from GetMember most of the time (from other script of members/) -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon May 22 14:52:14 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 22 May 2017 12:52:14 +0000 Subject: [Koha-bugs] [Bug 18647] Internal server error on moremember.pl In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18647 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on| |12461 Assignee|veron at veron.ch |kyle at bywatersolutions.com --- Comment #4 from Jonathan Druart --- This is caused by bug 12461. The borrower variable should NOT be a Koha::Patron object. Everything is cleared on bug 17829, but we will need to wait for the next release to see it in. Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12461 [Bug 12461] Add patron clubs feature -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon May 22 14:52:14 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 22 May 2017 12:52:14 +0000 Subject: [Koha-bugs] [Bug 12461] Add patron clubs feature In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12461 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |18647 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18647 [Bug 18647] Internal server error on moremember.pl -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon May 22 14:52:27 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 22 May 2017 12:52:27 +0000 Subject: [Koha-bugs] [Bug 18647] Internal server error on moremember.pl In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18647 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Severity|critical |blocker -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon May 22 14:52:45 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 22 May 2017 12:52:45 +0000 Subject: [Koha-bugs] [Bug 18066] Hea - Version 2 In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18066 Paul Poulain changed: What |Removed |Added ---------------------------------------------------------------------------- Text to go in the|Hea is a website to collect |Hea is a service to collect release notes|usage data from libraries |usage data from libraries |using Koha. With this |using Koha. |development Hea can collect |With this |the geolocations of the |development Hea can collect |libraries in your |the geolocations of the |installation create a map. |libraries in your |A new configuration page |installation and create a |allows to configure easily |map. A new configuration |what information is shared |page allows to configure |with the Koha community. |easily what information is | |shared with the Koha | |community. | |Hea statistics | |can been seen on | |https://hea.koha-community. | |org/ -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon May 22 14:57:04 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 22 May 2017 12:57:04 +0000 Subject: [Koha-bugs] [Bug 17898] Add a way to automatically convert SQL reports In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17898 Kyle M Hall changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon May 22 14:57:07 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 22 May 2017 12:57:07 +0000 Subject: [Koha-bugs] [Bug 17898] Add a way to automatically convert SQL reports In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17898 Kyle M Hall changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #63582|0 |1 is obsolete| | Attachment #63583|0 |1 is obsolete| | --- Comment #13 from Kyle M Hall --- Created attachment 63613 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=63613&action=edit Bug 17898: Automagically convert SQL reports Bug 17196 move the marcxml out of the biblioitems table. That will break SQL reports using it. It would be handy to propose an automagically way to convert the SQL reports. We do not want to update the reports automatically without user inputs, it will be too hasardous. However we can lead the user to convert them. In this patchset I suggest to warn the user if a report is subject to be updated. TODO: Add a way to mark this job done (using a pref?) to remove the check and not to display false positives. Test plan: - Create some SQL reports (see https://wiki.koha-community.org/wiki/SQL_Reports_Library) - Go on the report list page (/reports/guided_reports.pl?phase=Use saved) - For the reports using biblioitems.marcxml you will see a new column warning you that it is obsolete - Click on update link => that will open a modal with the converted SQL query - Click on the update button => you will be informed that the query has been updated If all the reports are updated, the new column "Update" will no longer be displayed. Signed-off-by: Tomas Cohen Arazi Signed-off-by: Kyle M Hall -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon May 22 14:57:15 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 22 May 2017 12:57:15 +0000 Subject: [Koha-bugs] [Bug 17898] Add a way to automatically convert SQL reports In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17898 --- Comment #14 from Kyle M Hall --- Created attachment 63614 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=63614&action=edit Bug 17898: Followup - udpate templates for bootstrap 3 Signed-off-by: Tomas Cohen Arazi Signed-off-by: Kyle M Hall -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon May 22 14:57:47 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 22 May 2017 12:57:47 +0000 Subject: [Koha-bugs] [Bug 17898] Add a way to automatically convert SQL reports In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17898 Kyle M Hall changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to Master CC| |kyle at bywatersolutions.com --- Comment #15 from Kyle M Hall --- Pushed to master for 17.05, thanks Jonathan, Josef! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon May 22 15:01:13 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 22 May 2017 13:01:13 +0000 Subject: [Koha-bugs] [Bug 18642] Internal Server Error in Guided reports wizard In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18642 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon May 22 15:01:18 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 22 May 2017 13:01:18 +0000 Subject: [Koha-bugs] [Bug 18642] Internal Server Error in Guided reports wizard In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18642 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #63612|0 |1 is obsolete| | --- Comment #7 from Jonathan Druart --- Created attachment 63615 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=63615&action=edit Bug 18642: Remove debug messages Test plan: 0) Apply the patch 1) git grep Data::Printer -> should return no results 2) Go to Reports -> Use saved - should work fine Signed-off-by: Marc V?ron Signed-off-by: Jonathan Druart -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon May 22 15:15:46 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 22 May 2017 13:15:46 +0000 Subject: [Koha-bugs] [Bug 18647] Internal server error on moremember.pl In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18647 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |kyle at bywatersolutions.com, | |m.de.rooy at rijksmuseum.nl --- Comment #5 from Jonathan Druart --- I'd say the patch should be: diff --git a/members/moremember.pl b/members/moremember.pl index 0e18d2234f..0649dcfd76 100755 --- a/members/moremember.pl +++ b/members/moremember.pl @@ -343,7 +343,6 @@ my $translated_language = C4::Languages::language_get_description( $subtag, $sub $template->param( patron => $patron, - borrower => $patron, # TODO Still needed by includes, translated_language => $translated_language, detailview => 1, borrowernumber => $borrowernumber, The borrower variable should not be a Koha::Patron, because the include file expects an hashref. Marcel, do you know why you add the TODO comment? I do not find where it is used. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon May 22 15:36:25 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 22 May 2017 13:36:25 +0000 Subject: [Koha-bugs] [Bug 18642] Internal Server Error in Guided reports wizard caused by debug messages In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18642 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |jonathan.druart at bugs.koha-c | |ommunity.org Summary|Internal Server Error in |Internal Server Error in |Guided reports wizard |Guided reports wizard | |caused by debug messages -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon May 22 15:42:36 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 22 May 2017 13:42:36 +0000 Subject: [Koha-bugs] [Bug 18596] Quick add form duplicating password confirm In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18596 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon May 22 15:42:41 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 22 May 2017 13:42:41 +0000 Subject: [Koha-bugs] [Bug 18596] Quick add form duplicating password confirm In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18596 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #63449|0 |1 is obsolete| | Attachment #63555|0 |1 is obsolete| | --- Comment #7 from Jonathan Druart --- Created attachment 63616 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=63616&action=edit Bug 18596 - Quick add form duplicating password confirm To test: 1 - Add password to BorrowerMandatoryField 2 - View quick add form 3 - See confirm password twice 4 - Apply patch 5 - See confirm password once 6 - Add password to QuickAddFields 7 - Confirm one confirm field 8 - Remove password form BorrowerMandatory field 9 - Confirm there is one confirm field and password fields are not required Signed-off-by: Jonathan Druart -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon May 22 15:53:07 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 22 May 2017 13:53:07 +0000 Subject: [Koha-bugs] [Bug 18635] Koha::Patron->guarantees() should return results alphabetically In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18635 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |jonathan.druart at bugs.koha-c | |ommunity.org Status|Signed Off |Failed QA --- Comment #5 from Jonathan Druart --- Nick, tests for Koha::Patrons are in t/db_dependent/Koha/Patrons.t -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon May 22 16:10:22 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 22 May 2017 14:10:22 +0000 Subject: [Koha-bugs] [Bug 16568] Talking Tech generates phone notifications for all overdue actions In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16568 Julian Maurice changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |julian.maurice at biblibre.com --- Comment #8 from Julian Maurice --- Pushed to 3.22.x for 3.22.21 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon May 22 16:17:40 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 22 May 2017 14:17:40 +0000 Subject: [Koha-bugs] [Bug 18536] Generating CSV using profile in serials late issues doesn' t work as described In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18536 Julian Maurice changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |julian.maurice at biblibre.com --- Comment #8 from Julian Maurice --- Pushed to 3.22.x for 3.22.21 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon May 22 16:18:55 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 22 May 2017 14:18:55 +0000 Subject: [Koha-bugs] [Bug 17665] SIP2 Item Information Response returns incorrect circulation status of ' 08' ( waiting on hold shelf ) if record has any holds In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17665 --- Comment #12 from Katrin Fischer --- Ok, will take me a bit to decipher this :) But this is what Koha does now or just how the standard describes it? -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon May 22 16:28:26 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 22 May 2017 14:28:26 +0000 Subject: [Koha-bugs] [Bug 18578] Use subdirectory in / tmp for session storage during installation In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18578 Julian Maurice changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |julian.maurice at biblibre.com --- Comment #7 from Julian Maurice --- Pushed to 3.22.x for 3.22.21 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon May 22 16:50:33 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 22 May 2017 14:50:33 +0000 Subject: [Koha-bugs] [Bug 18635] Koha::Patron->guarantees() should return results alphabetically In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18635 Nick Clemens changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |Signed Off -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon May 22 16:50:38 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 22 May 2017 14:50:38 +0000 Subject: [Koha-bugs] [Bug 18635] Koha::Patron->guarantees() should return results alphabetically In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18635 --- Comment #6 from Nick Clemens --- Created attachment 63617 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=63617&action=edit Bug 18635 - (QA followup) move tests -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon May 22 16:56:59 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 22 May 2017 14:56:59 +0000 Subject: [Koha-bugs] [Bug 17047] Mana Knowledge Base : share data In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17047 Baptiste changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #62603|0 |1 is obsolete| | --- Comment #74 from Baptiste --- Created attachment 63618 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=63618&action=edit Bug 17047 add Mana-KB syspref Add the system preference to enable or disable Mana-KB webservice on koha. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon May 22 16:57:10 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 22 May 2017 14:57:10 +0000 Subject: [Koha-bugs] [Bug 17047] Mana Knowledge Base : share data In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17047 Baptiste changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #62604|0 |1 is obsolete| | --- Comment #75 from Baptiste --- Created attachment 63619 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=63619&action=edit Bug 17047 subscriptions management with Mana-KB - add a class SharedContent.pm to communicate with Mana-KB server - add a link in serials-menu.inc to serials_search.pl to open a mana-subscription research form - modify the research form in serials-search.tt to show the right fields for Mana-KB - create datatable in mana-subscription-search-result.inc to show results from a research on Mana-KB - modify serials-search.pl to manage research on Mana-KB - add a mana_id to subscription table - add a share button on serials-toolbar.inc and a modal to ask the language of the share and to alert if the subscription is already link to a Mana-KB subscription model - add function in C4/Serials to get all the info for a subscription sharing - modify subscription-detail.pl to manage sharing to Mana-KB - modify subscription-add.tt and subscription.pl to manage a import from Mana-KB during a subscription creation - add 2 script in svc for ajax calling from subscription-add.tt to communicate with Mana-KB server during a asubscription creation - add a function in Subscription.pm to have all the info for a Mana-KB research from a biblionumber - modify functions used by subscription-add.pl in C4/Serials to manage a frequency which came from Mana-KB server and not already created on the koha database, and modify the tests of the said functions -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon May 22 16:57:21 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 22 May 2017 14:57:21 +0000 Subject: [Koha-bugs] [Bug 17047] Mana Knowledge Base : share data In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17047 Baptiste changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #62605|0 |1 is obsolete| | --- Comment #76 from Baptiste --- Created attachment 63620 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=63620&action=edit Bug 17047 Mana-KB, Add unit tests -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon May 22 16:57:31 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 22 May 2017 14:57:31 +0000 Subject: [Koha-bugs] [Bug 17047] Mana Knowledge Base : share data In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17047 Baptiste changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #62606|0 |1 is obsolete| | --- Comment #77 from Baptiste --- Created attachment 63621 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=63621&action=edit Bug 17047 SQL reports management with Mana-KB Includes: * code factorization Some code from subscription & Mana-KB has been factorized in order to speed-up next developments * SytemPreferences: Mana Activation: - add a value "no, let me think about it", that is the default value. - as long as this value is selected, messages ask if user want to activate it ( in Administration and Add-subscription(page 2) ) AutoShareWithMana - Add the syspref AutoShareWithMana: user can automatically share infos with Mana-KB (not set by default) * Interface : - On mana-search, rows are now sorted by date of last import, then by number of users - Windows redesigned to improve the user experience * New Feature : report a mistake. - people can now report an invalid data (wrong, obsolete,...) - if a data is reported as invalid many time, it will appear differently - Added few tooltip (to explain the fields last import, nb of users, to explain the new feature) - When reporting a data as invalid, a comment can also be added. Koha will then display comments related to data in result lists * API (svc/mana) - add svc/mana/addvaluetofield: allows to ask mana incrementing a field of a resource - no hardcoding for resources in the code of api (api needs to be called with a ressourcename) * New feature : SQL report sharing - Create Koha::Report.pm and Koha::Reports.pm, objects class for Reports - New feature: share reports with Mana-KB - New feature: search report in Mana-KB with keywords - New feature: load reports from Mana-KB ========= Test plan ========= (see BibLibre complete documentation, attached to this patch) 1 - Apply Patch + update database 2 - Copy the three lines about mana config in etc/koha-conf.xml in ../etc/koha-conf.xml 3 - Check Mana syspref and AutoShareWithMana syspref are not activated 4 - subscriptions - Try create a new subscription for a first serial => Koha shouldn't show you anything (except if the base hase been filled) - Share this serial on Mana-KB (on the subscription detail page there must be a Share button) - Try to create a new subscription for serial #1 => a message should appear when you click on "next", click on "use", the fields should automaticaly appear - Activate AutoShareWithMana => Subscriptions - Create a new subscription for a second serial - There shouldn't be any Share button - Create a second subscription => the message should appear, click again on use 5 - SQL Report - Create a new report, without notes. - On the table with all report (reports > use saved), there should be the action "Share" - If you click on share, you have an error message - Create a new report, with a title and notes longer than 20 characters - You can share it on Mana-KB => you will have a success message - On (report > use saved), there must be a message inviting you to search on mana-KB for more results, enter a few word from title, notes, type of the report you shared, it should appear. You can use it, it will load it into your report list. 6 - Comments. - On any table containing mana search results, you can report a mistake & comment why you report: click on report mistake. You only can chose "other" because there's no comment in Mana-KB [if there are comments, you'll get other values]. - If you click other, a new textbox appears. Enter a short comment. - Reload the whole page, the comment should appear in the menu and in the comment column. - If you select a comment and reload the whole page, there should be one more comment with this name - If you select a comment and click on cancel just after, there shouldn't be any change when you reload. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon May 22 16:57:41 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 22 May 2017 14:57:41 +0000 Subject: [Koha-bugs] [Bug 17047] Mana Knowledge Base : share data In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17047 Baptiste changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #63476|0 |1 is obsolete| | --- Comment #78 from Baptiste --- Created attachment 63622 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=63622&action=edit Bug 17047 security token agst flooding for Mana-KB Rework messages from Mana-KB. - Add A syspref contains an authentication token. The token will be used to prevent anaonymous flooding of Mana-KB - To get an Authentication token, you have to fill a form and validate your e-mail address - Messages return codes are now correctly displayed and there shouldn't be any crash when Mana-KB webservices return a wrong answer or doesn't answer Test plan: 1 - Apply Patch + update database 2 - Copy the three lines about mana config in etc/koha-conf.xml in ../etc/koha-conf.xml (after for example) https://mana-kb.koha-community.org 3 - Check Mana syspref and AutoShareWithMana syspref are not activated 4 - Search the syspref ManaToken and follow the instructions 5 - subscriptions - Try create a new subscription for a first serial => Mana-KB shouldn't show you anything (except if the base hase been filled) - Share this serial with Mana-KB (on the serial individual's page there must be a Share button) - Try to create a new subscription for serial nr1 => a message should appear when you click on "next", click on "use", the fields should automaticaly appear - Activate AutoShareWithMana => Subscriptions - Create a new subscription for a second serial - There shouldn't be any Share button - Create a second subscription => the message should appear, click again on use 6 - SQL Report - Create a new SQL report, without notes. - On the table with all report (reports > use saved), there should be the action "Share" - If you click on share, you have an error message - Create a new report, with a title and notes longer than 20 characters - You can share it with mana => you will have a success message - On (report > use saved), there must be a message inviting you to search on Mana-KB for more results, enter a few word from title, notes, type of the report you shared, it should appear. You can use it, it will load it into your report list. 7 - Report mistakes. - On any table containing Mana-KB search results, you can report a mistake and add a comment. 8 - For each previous test, try to send wrong data, to delete the security token, to send nothing: it should show a correct warning message. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon May 22 16:57:52 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 22 May 2017 14:57:52 +0000 Subject: [Koha-bugs] [Bug 17047] Mana Knowledge Base : share data In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17047 Baptiste changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #63601|0 |1 is obsolete| | --- Comment #79 from Baptiste --- Created attachment 63623 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=63623&action=edit Bug 17047: Correct encoding issues Modify the function manaRequest in order to set the right encoding format (UTF-8). -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon May 22 17:01:21 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 22 May 2017 15:01:21 +0000 Subject: [Koha-bugs] [Bug 17047] Mana Knowledge Base : share data In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17047 --- Comment #80 from Baptiste --- Hum.. it tried to rebase it but it applyied without any problem.. I just reuploadad it, could you please try again ? -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon May 22 17:14:13 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 22 May 2017 15:14:13 +0000 Subject: [Koha-bugs] [Bug 18647] Internal server error on moremember.pl In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18647 --- Comment #6 from Marc V?ron --- (In reply to Jonathan Druart from comment #3) > No, it is definitely not the way to fix it, the borrower variable comes from > GetMember most of the time (from other script of members/) Sorry then to have tried to fix it. Leaving it to others to fix the issue. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon May 22 17:40:35 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 22 May 2017 15:40:35 +0000 Subject: [Koha-bugs] [Bug 18630] Translatability (Clubs): 'Cancel' is ambiguous and leads to mistakes In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18630 Marc V?ron changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #63536|0 |1 is obsolete| | --- Comment #5 from Marc V?ron --- Created attachment 63624 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=63624&action=edit Bug 18630: Translatability (Clubs): 'Cancel' is ambiguous and leads to mistakes The button to cancel a club enrollement is labelled with 'Cancel'. That is ambiguous and translates e.g. in German to 'Abbrechen' which can lead to mistakes. To test: - Apply patch - Enroll a patron to a club - Enable public enrollment in OPAC - Verify that the button to cancel enrollment in both OPAC and staff client reads 'Cancel enrollement' (instead of 'Cancel' without patch) (The button appears on the patron's detail pages in OPAC and staff client) Amended for comment #4 / mv -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon May 22 17:40:54 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 22 May 2017 15:40:54 +0000 Subject: [Koha-bugs] [Bug 18630] Translatability (Clubs): 'Cancel' is ambiguous and leads to mistakes In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18630 Marc V?ron changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon May 22 17:56:11 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 22 May 2017 15:56:11 +0000 Subject: [Koha-bugs] [Bug 18649] New: Translatability: Get rid of tt directive in translation for admin/categories.tt Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18649 Bug ID: 18649 Summary: Translatability: Get rid of tt directive in translation for admin/categories.tt Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: trivial Priority: P5 - low Component: I18N/L10N Assignee: koha-bugs at lists.koha-community.org Reporter: veron at veron.ch QA Contact: testopia at bugs.koha-community.org CC: frederic at tamil.fr Translation tool shows [% IF category.enrolmentperiod %][% category.enrolmentperiod %][% END %] for en/modules/admin/categories.tt -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Mon May 22 18:01:23 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 22 May 2017 16:01:23 +0000 Subject: [Koha-bugs] [Bug 18649] Translatability: Get rid of tt directive in translation for admin/ categories.tt and onboardingstep2.tt In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18649 Marc V?ron changed: What |Removed |Added ---------------------------------------------------------------------------- Summary|Translatability: Get rid of |Translatability: Get rid of |tt directive in translation |tt directive in translation |for admin/categories.tt |for admin/categories.tt and | |onboardingstep2.tt -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Mon May 22 18:01:53 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 22 May 2017 16:01:53 +0000 Subject: [Koha-bugs] [Bug 18649] Translatability: Get rid of tt directive in translation for admin/ categories.tt and onboardingstep2.tt In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18649 --- Comment #1 from Marc V?ron --- Translation tool shows [% IF category.enrolmentperiod %][% category.enrolmentperiod %][% END %] for en/modules/admin/categories.tt and koha-tmpl/intranet-tmpl/prog/en/modules/onboarding/onboardingstep2.tt -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Mon May 22 18:07:40 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 22 May 2017 16:07:40 +0000 Subject: [Koha-bugs] [Bug 18641] Translatability: Get rid of template directives in translations for *reserves.tt files In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18641 --- Comment #4 from Marc V?ron --- Created attachment 63625 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=63625&action=edit Bug 18649: Translatability: Get rid of tt directive in translation for admin/categories.tt and onboardingstep2.tt Translation tool shows [% IF category.enrolmentperiod %][% category.enrolmentperiod %][% END %] for en/modules/admin/categories.tt and koha-tmpl/intranet-tmpl/prog/en/modules/onboarding/onboardingstep2.tt This patch fixes it. To test: - Apply patch - Verify that code changes make sense - Verify that template directive is no longer picked by translation -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon May 22 18:08:17 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 22 May 2017 16:08:17 +0000 Subject: [Koha-bugs] [Bug 18641] Translatability: Get rid of template directives in translations for *reserves.tt files In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18641 Marc V?ron changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #63625|0 |1 is obsolete| | --- Comment #5 from Marc V?ron --- Comment on attachment 63625 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=63625 Bug 18649: Translatability: Get rid of tt directive in translation for admin/categories.tt and onboardingstep2.tt Sorry for the noise, I mistaked in Bug number... -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon May 22 18:08:47 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 22 May 2017 16:08:47 +0000 Subject: [Koha-bugs] [Bug 18649] Translatability: Get rid of tt directive in translation for admin/ categories.tt and onboardingstep2.tt In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18649 --- Comment #2 from Marc V?ron --- Created attachment 63626 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=63626&action=edit Bug 18649: Translatability: Get rid of tt directive in translation for admin/categories.tt and onboardingstep2.tt Translation tool shows [% IF category.enrolmentperiod %][% category.enrolmentperiod %][% END %] for en/modules/admin/categories.tt and koha-tmpl/intranet-tmpl/prog/en/modules/onboarding/onboardingstep2.tt This patch fixes it. To test: - Apply patch - Verify that code changes make sense - Verify that template directive is no longer picked by translation https://bugs.koha-community.org/show_bug.cgi?id=18641 -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Mon May 22 18:25:45 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 22 May 2017 16:25:45 +0000 Subject: [Koha-bugs] [Bug 18650] New: Translatability: Get rid of tt directive in translation for cat-toolbar.inc Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18650 Bug ID: 18650 Summary: Translatability: Get rid of tt directive in translation for cat-toolbar.inc Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: trivial Priority: P5 - low Component: I18N/L10N Assignee: koha-bugs at lists.koha-community.org Reporter: veron at veron.ch QA Contact: testopia at bugs.koha-community.org CC: frederic at tamil.fr Translation tool shows [% count %] item(s) are... in translation for koha-tmpl/intranet-tmpl/prog/en/includes/cat-toolbar.inc -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon May 22 18:26:21 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 22 May 2017 16:26:21 +0000 Subject: [Koha-bugs] [Bug 18649] Translatability: Get rid of tt directive in translation for admin/ categories.tt and onboardingstep2.tt In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18649 Marc V?ron changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon May 22 18:30:16 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 22 May 2017 16:30:16 +0000 Subject: [Koha-bugs] [Bug 18650] Translatability: Get rid of tt directive in translation for cat-toolbar.inc In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18650 --- Comment #1 from Marc V?ron --- Created attachment 63627 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=63627&action=edit Bug 18650 - Translatability: Get rid of tt directive in translation for cat-toolbar.inc Translation tool shows [% count %] item(s) are... in translation for koha-tmpl/intranet-tmpl/prog/en/includes/cat-toolbar.inc This patch fixes it. To test: - Apply patch - Go to a biblio record with at least 1 item attached - Verify that tooltip for 'Edit > Delete record' shows same text as before (n item(s) are attached...) -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Mon May 22 18:31:00 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 22 May 2017 16:31:00 +0000 Subject: [Koha-bugs] [Bug 18650] Translatability: Get rid of tt directive in translation for cat-toolbar.inc In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18650 Marc V?ron changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|koha-bugs at lists.koha-commun |veron at veron.ch |ity.org | Status|NEW |Needs Signoff Patch complexity|--- |Trivial patch -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Mon May 22 19:04:02 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 22 May 2017 17:04:02 +0000 Subject: [Koha-bugs] [Bug 18647] Internal server error on moremember.pl In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18647 Tom?s Cohen Arazi changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |tomascohen at gmail.com --- Comment #7 from Tom?s Cohen Arazi --- (In reply to Marc V?ron from comment #6) > (In reply to Jonathan Druart from comment #3) > > No, it is definitely not the way to fix it, the borrower variable comes from > > GetMember most of the time (from other script of members/) > > Sorry then to have tried to fix it. Leaving it to others to fix the issue. Your patch clearly fixes the issue by making patron-title.inc aware of the fact that borrower is now a K::Patron object. The problem is that the rest of the code is written in terms of the hashref returned by GetMember and we could be missing some edge cases. So we better move it back to the previous behaviour, and let bug 17829 take care of the C4 > Koha shift. We still need Marcel's comment on why he put the TODO, because we might as well miss some other edge case Marcel noticed. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon May 22 19:33:34 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 22 May 2017 17:33:34 +0000 Subject: [Koha-bugs] [Bug 18242] Move of checkouts to old_issues is not handle correctly In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18242 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Summary|Remove primary key on |Move of checkouts to |old_issues.issue_id |old_issues is not handle | |correctly --- Comment #26 from Jonathan Druart --- Updating the bug report title, we did not remove the PK on old_issues. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon May 22 19:38:25 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 22 May 2017 17:38:25 +0000 Subject: [Koha-bugs] [Bug 18651] New: Move of checkouts is still not correctly handled Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18651 Bug ID: 18651 Summary: Move of checkouts is still not correctly handled Change sponsored?: --- Product: Koha Version: unspecified Hardware: All OS: All Status: ASSIGNED Severity: major Priority: P5 - low Component: Architecture, internals, and plumbing Assignee: jonathan.druart at bugs.koha-community.org Reporter: jonathan.druart at bugs.koha-community.org QA Contact: testopia at bugs.koha-community.org Depends on: 18242 Bug 18242 fixes a major: The move of a checkout from the issues table to the old_issues table was not done in a transaction, that leads to data lost. The issues row was deleted but not inserted to the old_issues table. Now that we have 18242, the move is done in a transaction but there are still several problems: 1. AddReturn returns a $issue hashref with the old issue_id value => At first glance it does not affect anything, but would be good to fix it for future uses. 2. If the move fails for whatever reason (see https://lists.katipo.co.nz/pipermail/koha/2017-May/048045.html for an example), fines can be charged. It should not 3. accountlines.issue_id are not updated! Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18242 [Bug 18242] Move of checkouts to old_issues is not handle correctly -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon May 22 19:38:25 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 22 May 2017 17:38:25 +0000 Subject: [Koha-bugs] [Bug 18242] Move of checkouts to old_issues is not handle correctly In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18242 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |18651 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18651 [Bug 18651] Move of checkouts is still not correctly handled -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon May 22 19:41:27 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 22 May 2017 17:41:27 +0000 Subject: [Koha-bugs] [Bug 18620] t/db_dependent/Letters.t failing on master In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18620 Tom?s Cohen Arazi changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon May 22 19:41:32 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 22 May 2017 17:41:32 +0000 Subject: [Koha-bugs] [Bug 18620] t/db_dependent/Letters.t failing on master In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18620 Tom?s Cohen Arazi changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #63507|0 |1 is obsolete| | --- Comment #7 from Tom?s Cohen Arazi --- Created attachment 63628 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=63628&action=edit Bug 18620 - t/db_dependent/Letters.t failing on master To test: 1 - Set SMSSenDriver to 'Email' 2 - prove t/db_dependent/Letters.t 3 - Tests fail 4 - Apply patch 5 - prove t/db_dependent/Letters.t 6 - Less tests fail (should be 2 sms test failures) 7 - Set SMSSendDriver to another value or blank 8 - prove t/db_dependent/Letters.t 9 - Tests pass Signed-off-by: Marc V?ron Signed-off-by: Tomas Cohen Arazi -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon May 22 19:44:17 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 22 May 2017 17:44:17 +0000 Subject: [Koha-bugs] [Bug 18651] Move of checkouts is still not correctly handled In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18651 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon May 22 19:44:27 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 22 May 2017 17:44:27 +0000 Subject: [Koha-bugs] [Bug 18651] Move of checkouts is still not correctly handled In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18651 --- Comment #2 from Jonathan Druart --- Created attachment 63630 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=63630&action=edit Bug 18651: Do not charge if the checkin failed 2. If the move fails for whatever reason (see https://lists.katipo.co.nz/pipermail/koha/2017-May/048045.html for an example), fines can be charged. It should not -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon May 22 19:44:31 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 22 May 2017 17:44:31 +0000 Subject: [Koha-bugs] [Bug 18651] Move of checkouts is still not correctly handled In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18651 --- Comment #3 from Jonathan Druart --- Created attachment 63631 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=63631&action=edit Bug 18651: Update accountlines.issue_id is the issue_id has been changed during the move -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon May 22 19:44:23 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 22 May 2017 17:44:23 +0000 Subject: [Koha-bugs] [Bug 18651] Move of checkouts is still not correctly handled In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18651 --- Comment #1 from Jonathan Druart --- Created attachment 63629 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=63629&action=edit Bug 18651: Update issue_id in AddReturn 1. AddReturn returns a $issue hashref with the old issue_id value => At first glance it does not affect anything, but would be good to fix it for future uses. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon May 22 19:44:36 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 22 May 2017 17:44:36 +0000 Subject: [Koha-bugs] [Bug 18651] Move of checkouts is still not correctly handled In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18651 --- Comment #4 from Jonathan Druart --- Created attachment 63632 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=63632&action=edit DEBUG patches: I'd like feedback Check what the debug statement returns: there are 4 accountlines entries, is that correct? -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon May 22 19:46:29 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 22 May 2017 17:46:29 +0000 Subject: [Koha-bugs] [Bug 18620] t/db_dependent/Letters.t failing on master In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18620 --- Comment #8 from Tom?s Cohen Arazi --- Adding my signoff here, I would wait for 18478 too, reverting to SO -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon May 22 19:46:35 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 22 May 2017 17:46:35 +0000 Subject: [Koha-bugs] [Bug 18620] t/db_dependent/Letters.t failing on master In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18620 Tom?s Cohen Arazi changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Signed Off -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon May 22 19:48:15 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 22 May 2017 17:48:15 +0000 Subject: [Koha-bugs] [Bug 18242] Move of checkouts to old_issues is not handle correctly In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18242 --- Comment #27 from Jonathan Druart --- (In reply to Jonathan Druart from comment #21) > In this solution the change is done at code level instead of DB > structure: If old_issues.issue_id already exists before moving from > the issues table, the issue_id is updated (not on cascade for > accountlines.issue_id, should it?) before the move. See bug 18651 for a follow-up -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon May 22 19:49:53 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 22 May 2017 17:49:53 +0000 Subject: [Koha-bugs] [Bug 18651] Move of checkouts is still not correctly handled In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18651 Nick Clemens changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |nick at bywatersolutions.com -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon May 22 20:04:49 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 22 May 2017 18:04:49 +0000 Subject: [Koha-bugs] [Bug 18651] Move of checkouts is still not correctly handled In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18651 Kyle M Hall changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon May 22 20:04:52 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 22 May 2017 18:04:52 +0000 Subject: [Koha-bugs] [Bug 18651] Move of checkouts is still not correctly handled In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18651 Kyle M Hall changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #63629|0 |1 is obsolete| | Attachment #63630|0 |1 is obsolete| | Attachment #63631|0 |1 is obsolete| | Attachment #63632|0 |1 is obsolete| | --- Comment #5 from Kyle M Hall --- Created attachment 63633 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=63633&action=edit Bug 18651: Update issue_id in AddReturn 1. AddReturn returns a $issue hashref with the old issue_id value => At first glance it does not affect anything, but would be good to fix it for future uses. Signed-off-by: Kyle M Hall -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon May 22 20:06:40 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 22 May 2017 18:06:40 +0000 Subject: [Koha-bugs] [Bug 18651] Move of checkouts is still not correctly handled In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18651 Kyle M Hall changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #63633|0 |1 is obsolete| | --- Comment #6 from Kyle M Hall --- Created attachment 63634 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=63634&action=edit Bug 18651: Update issue_id in AddReturn 1. AddReturn returns a $issue hashref with the old issue_id value => At first glance it does not affect anything, but would be good to fix it for future uses. Signed-off-by: Kyle M Hall -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon May 22 20:07:35 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 22 May 2017 18:07:35 +0000 Subject: [Koha-bugs] [Bug 18651] Move of checkouts is still not correctly handled In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18651 --- Comment #7 from Kyle M Hall --- Created attachment 63635 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=63635&action=edit Bug 18651: Do not charge if the checkin failed 2. If the move fails for whatever reason (see https://lists.katipo.co.nz/pipermail/koha/2017-May/048045.html for an example), fines can be charged. It should not Signed-off-by: Kyle M Hall -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon May 22 20:07:38 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 22 May 2017 18:07:38 +0000 Subject: [Koha-bugs] [Bug 18651] Move of checkouts is still not correctly handled In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18651 --- Comment #8 from Kyle M Hall --- Created attachment 63636 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=63636&action=edit Bug 18651: Update accountlines.issue_id is the issue_id has been changed during the move Signed-off-by: Kyle M Hall -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon May 22 20:07:41 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 22 May 2017 18:07:41 +0000 Subject: [Koha-bugs] [Bug 18651] Move of checkouts is still not correctly handled In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18651 --- Comment #9 from Kyle M Hall --- Created attachment 63637 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=63637&action=edit DEBUG patches: I'd like feedback Check what the debug statement returns: there are 4 accountlines entries, is that correct? https://bugs.koha-community.org/show_bug.cgi?id=18651 Signed-off-by: Kyle M Hall -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon May 22 20:18:23 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 22 May 2017 18:18:23 +0000 Subject: [Koha-bugs] [Bug 18651] Move of checkouts is still not correctly handled In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18651 Tom?s Cohen Arazi changed: What |Removed |Added ---------------------------------------------------------------------------- Version|unspecified |master CC| |tomascohen at gmail.com -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon May 22 21:08:30 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 22 May 2017 19:08:30 +0000 Subject: [Koha-bugs] [Bug 18652] New: Get rid of tt directive in translation for uncertainprice.tt Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18652 Bug ID: 18652 Summary: Get rid of tt directive in translation for uncertainprice.tt Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: minor Priority: P5 - low Component: I18N/L10N Assignee: koha-bugs at lists.koha-community.org Reporter: veron at veron.ch QA Contact: testopia at bugs.koha-community.org CC: frederic at tamil.fr Translation tool shows toe following for ncertainprice.tt 0; url=[% scriptname %]?booksellerid=[% booksellerid %] -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon May 22 21:14:56 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 22 May 2017 19:14:56 +0000 Subject: [Koha-bugs] [Bug 18598] Quick add form doesn't clear values when switching In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18598 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon May 22 21:15:01 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 22 May 2017 19:15:01 +0000 Subject: [Koha-bugs] [Bug 18598] Quick add form doesn't clear values when switching In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18598 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #63556|0 |1 is obsolete| | --- Comment #6 from Jonathan Druart --- Created attachment 63638 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=63638&action=edit Bug 18598 - Quick add form doesn't clear values when switching To test: 1 - Fill out some fields in quick add 2 - Switch to full form and clear fields 3 - Switch back and fields are still populated 4 - Fill a field in long form 5 - Switch to quick add and clear it 6 - Save 7 - Value set in 4 is saved 8 - Apply patch 9 - Repeat 1-6 - values should be cleared and not saved Signed-off-by: Marc V?ron Signed-off-by: Jonathan Druart -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon May 22 21:17:41 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 22 May 2017 19:17:41 +0000 Subject: [Koha-bugs] [Bug 18652] Get rid of tt directive in translation for uncertainprice.tt In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18652 --- Comment #1 from Marc V?ron --- Created attachment 63639 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=63639&action=edit Bug 18652: Get rid of tt directive in translation for uncertainprice.tt Translation tool shows toe following for ncertainprice.tt 0; url=[% scriptname %]?booksellerid=[% booksellerid %] This patch fixes it. To test: - Apply patch - Verify that code change makes sense - Verify that Home > Acquisitions > [vendor] > Uncertain prices for [vendor] works as before -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon May 22 21:18:23 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 22 May 2017 19:18:23 +0000 Subject: [Koha-bugs] [Bug 18652] Get rid of tt directive in translation for uncertainprice.tt In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18652 Marc V?ron changed: What |Removed |Added ---------------------------------------------------------------------------- Patch complexity|--- |Trivial patch Status|NEW |Needs Signoff Assignee|koha-bugs at lists.koha-commun |veron at veron.ch |ity.org | -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Mon May 22 21:19:01 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 22 May 2017 19:19:01 +0000 Subject: [Koha-bugs] [Bug 18635] Koha::Patron->guarantees() should return results alphabetically In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18635 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Failed QA --- Comment #7 from Jonathan Druart --- Sorry but it is t/db_dependent/Koha/Patrons.t, not t/db_dependent/Patrons.t -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon May 22 21:25:34 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 22 May 2017 19:25:34 +0000 Subject: [Koha-bugs] [Bug 18635] Koha::Patron->guarantees() should return results alphabetically In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18635 --- Comment #8 from Jonathan Druart --- Should not we override Koha::Patrons->search instead? -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon May 22 21:49:26 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 22 May 2017 19:49:26 +0000 Subject: [Koha-bugs] [Bug 17884] troubles with syspref AllowHoldPolicyOverride on return In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17884 Chris Slone changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |cslone at camdencountylibrary. | |org --- Comment #5 from Chris Slone --- I applied this patch and tested it as follows: 1 syspref: AllowHoldPolicyOverride - Allow. 2 created an item type with No holds Allowed defined in its Hold Policy 3 created a hold on an item with the above item type 4 checked in the item 5 the hold was found and was able to be confirmed The problem was that it if you have holdable and non-holdable item types on the same record (say a library use only copy of a book that is defined by its own item type), the item with the non-holdable item type will fulfill any biblio-level hold, which essentially negates the no-holds allowed property entirely. So it works, but nor quite as I expected it. Is it possible to specify that the hold should only be fulfilled if it is an item level request (perhaps this would best be split to a different bug...)? -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue May 23 00:52:03 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 22 May 2017 22:52:03 +0000 Subject: [Koha-bugs] [Bug 18651] Move of checkouts is still not correctly handled In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18651 Barton Chittenden changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |barton at bywatersolutions.com --- Comment #10 from Barton Chittenden --- We have a problem with the auto_increment on issues.issue_id -- the auto_increment is not kept if the database is stopped; it is simply calculated by mysql when the database starts. That caused problems if we re-start the database after we've moved issues to the old_issues table but before we've checked out enough items to increase auto_increment past max(old_issues.issue_id) + 1. As a concrete example, let's say that we check out 3 items. items.issue_id is now 3, and the auto_increment is set to 4. We then check in the items with issue_id = 2 and issue_id = 3. max(old_issues.issue_id) is now 3 max(issues.issue_id) is now 1. We restart mysql at this point, mysql reads max(issues.issue_id) and sets auto_increment to 2. We try to check in the item with issue_id=2. We can't insert into old_issues due to the duplicate key constraint. I suspect that the right thing to do might be to use the mysql --init-file option to run something like ALTER TABLE issues AUTO_INCREMENT= ### ( find the max of issues.issue_id and old_issues.issue_id ) + 1 ### -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue May 23 02:19:56 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 23 May 2017 00:19:56 +0000 Subject: [Koha-bugs] [Bug 17884] troubles with syspref AllowHoldPolicyOverride on return In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17884 Mason James changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |mtj at kohaaloha.com -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue May 23 02:21:35 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 23 May 2017 00:21:35 +0000 Subject: [Koha-bugs] [Bug 18651] Move of checkouts is still not correctly handled In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18651 Mason James changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |mtj at kohaaloha.com -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue May 23 04:31:41 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 23 May 2017 02:31:41 +0000 Subject: [Koha-bugs] [Bug 18586] Create module to mint RDF subject URIs In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18586 David Cook changed: What |Removed |Added ---------------------------------------------------------------------------- Patch complexity|--- |Small patch Status|NEW |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue May 23 04:31:45 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 23 May 2017 02:31:45 +0000 Subject: [Koha-bugs] [Bug 18586] Create module to mint RDF subject URIs In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18586 --- Comment #3 from David Cook --- Created attachment 63640 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=63640&action=edit Bug 18586 - Create module to mint RDF subject URIs Created the Koha::RDF module to mint URIs for RDF documents that represent Koha bibliographic records. _TEST PLAN_ To test the module, just run 'prove t/Koha/RDF.t'. You'll get some warnings about not being able to find koha-conf.xml, but you can safely ignore them or you can point to any koha-conf.xml file since it's not used by the test in actuality. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue May 23 06:17:58 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 23 May 2017 04:17:58 +0000 Subject: [Koha-bugs] [Bug 18630] Translatability (Clubs): 'Cancel' is ambiguous and leads to mistakes In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18630 Josef Moravec changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue May 23 06:18:03 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 23 May 2017 04:18:03 +0000 Subject: [Koha-bugs] [Bug 18630] Translatability (Clubs): 'Cancel' is ambiguous and leads to mistakes In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18630 Josef Moravec changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #63624|0 |1 is obsolete| | --- Comment #6 from Josef Moravec --- Created attachment 63641 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=63641&action=edit [SIGNED-OFF] Bug 18630: Translatability (Clubs): 'Cancel' is ambiguous and leads to mistakes The button to cancel a club enrollement is labelled with 'Cancel'. That is ambiguous and translates e.g. in German to 'Abbrechen' which can lead to mistakes. To test: - Apply patch - Enroll a patron to a club - Enable public enrollment in OPAC - Verify that the button to cancel enrollment in both OPAC and staff client reads 'Cancel enrollement' (instead of 'Cancel' without patch) (The button appears on the patron's detail pages in OPAC and staff client) Amended for comment #4 / mv Signed-off-by: Josef Moravec -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue May 23 06:40:59 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 23 May 2017 04:40:59 +0000 Subject: [Koha-bugs] [Bug 18570] Password recovery e-mail only sent after message queue is processed In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18570 Marc V?ron changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |veron at veron.ch -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue May 23 06:57:13 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 23 May 2017 04:57:13 +0000 Subject: [Koha-bugs] [Bug 17898] Add a way to automatically convert SQL reports In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17898 Zeno Tajoli changed: What |Removed |Added ---------------------------------------------------------------------------- Text to go in the| |Bug 17196 move the marcxml release notes| |out of the biblioitems | |table. | |That breaks SQL | |reports using it. When you | |go into report list page | |(/reports/guided_reports.pl | |?phase=Use saved), | |reports | |using biblioitems.marcxml | |have a new column | |warning | |you that it is obsolete. | |There is an update link | |that help you to modify the | |SQL query. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue May 23 07:30:10 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 23 May 2017 05:30:10 +0000 Subject: [Koha-bugs] [Bug 18649] Translatability: Get rid of tt directive in translation for admin/ categories.tt and onboardingstep2.tt In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18649 Marc V?ron changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|koha-bugs at lists.koha-commun |veron at veron.ch |ity.org | -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Tue May 23 07:45:15 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 23 May 2017 05:45:15 +0000 Subject: [Koha-bugs] [Bug 15775] User should know when they are blocked from checkouts on OPAC + Translatability fixes for OPAC Summary page In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15775 --- Comment #17 from Marc V?ron --- (In reply to Jonathan Druart from comment #15) > Who is the author of this patch? > The author commit is Marc, is it right? This Bug 15775 is related to Bug 15374 I abandoned 15374 in favour of 15775, and sigend off 15775 See https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15374#c35 No problem for me if authorship is changed to Aleisha. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue May 23 07:54:14 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 23 May 2017 05:54:14 +0000 Subject: [Koha-bugs] [Bug 17047] Mana Knowledge Base : share data In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17047 Josef Moravec changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Patch doesn't apply |Needs Signoff --- Comment #81 from Josef Moravec --- (In reply to Baptiste from comment #80) > Hum.. it tried to rebase it but it applyied without any problem.. > > I just reuploadad it, could you please try again ? Now it applies, I had to do something wrong... anyway, going to test it -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue May 23 09:02:35 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 23 May 2017 07:02:35 +0000 Subject: [Koha-bugs] [Bug 18654] New: Translatability: Get rid of tt directives starting with [ %% in translation for itemsearch.tt Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18654 Bug ID: 18654 Summary: Translatability: Get rid of tt directives starting with [%% in translation for itemsearch.tt Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: minor Priority: P5 - low Component: I18N/L10N Assignee: koha-bugs at lists.koha-community.org Reporter: veron at veron.ch QA Contact: testopia at bugs.koha-community.org CC: frederic at tamil.fr Translation for file itemsearch.tt exposes tt directifes like: %s %s %s %s %s %s %s %s %s [%% params = { f => f.$i q = q.$i op = op.$i } %%] %s %s %s %s %s %s %s %s %s %s %s or [%% INCLUDE form_field_select name="homebranch" options = branches empty_option = "All libraries" %%] [%% INCLUDE form_field_select name="holdingbranch" options = branches empty_option = "All libraries" %%] %s [%% INCLUDE form_field_select name="location" options = locations empty_option = "All locations" %%] %s -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Tue May 23 09:07:46 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 23 May 2017 07:07:46 +0000 Subject: [Koha-bugs] [Bug 18654] Translatability: Get rid of tt directives starting with [ %% in translation for itemsearch.tt In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18654 Marc V?ron changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|koha-bugs at lists.koha-commun |veron at veron.ch |ity.org | -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Tue May 23 09:08:06 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 23 May 2017 07:08:06 +0000 Subject: [Koha-bugs] [Bug 18654] Translatability: Get rid of tt directives starting with [ %% in translation for itemsearch.tt In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18654 --- Comment #1 from Marc V?ron --- Created attachment 63643 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=63643&action=edit Bug 18654: Translatability: Get rid of tt directives starting with [%% in translation for itemsearch.tt Translation for file itemsearch.tt exposes tt directifes like: %s %s %s %s %s %s %s %s %s [%% params = { f => f.$i q = q.$i op = op.$i } %%] %s %s %s %s %s %s %s %s %s %s %s or [%% INCLUDE form_field_select name="homebranch" options = branches empty_option = "All libraries" %%] [%% INCLUDE form_field_select name="holdingbranch" options = branches empty_option = "All libraries" %%] %s [%% INCLUDE form_field_select name="location" options = locations empty_option = "All locations" %%] %s This patch fixes it. To test: - Apply patch - Verify that itemsearch behaves as before - Verify that code changes make sense - Test a translatiion e.g. translator create aa-AA and verifiy that strings from itemsearch.tt starting with [%% no longer appear -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue May 23 09:08:33 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 23 May 2017 07:08:33 +0000 Subject: [Koha-bugs] [Bug 18654] Translatability: Get rid of tt directives starting with [ %% in translation for itemsearch.tt In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18654 Marc V?ron changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff Patch complexity|--- |Small patch -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue May 23 09:20:37 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 23 May 2017 07:20:37 +0000 Subject: [Koha-bugs] [Bug 18639] Separate replacement cost and retail price fields in acquisitions In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18639 Laurence Rault changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |laurence.rault at biblibre.com --- Comment #1 from Laurence Rault --- The trouble is that now the budgeted cost (ecost) is calculated based on Replacement cost (rrp) and not (not only in fact) from vendor price (listprice) anymore. And I think it may be bug : When you change rrp in an order, budgeted cost does not change in the form, but after validation, values in the table for budgeted cost are re-calculated against the modified rrp. Maybe we should consider alternatives : 1) make the budgeted cost only calculated from vendor price ; if rrp is modified, no effect on ecost (as it is still the case in Koha 3.22). And then make the rrp editable through the whole workflow. Would it be enough ? 2) I agree with your proposition, with some questions : - what would be the difference between Vendor price and Retail price ? - I am not at all familiar with EDI, but is the replacementprice sent or received to/by the vendor ? I think vendor price and/or actual cost should be (maybe the are already). -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue May 23 10:39:37 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 23 May 2017 08:39:37 +0000 Subject: [Koha-bugs] [Bug 18651] Move of checkouts is still not correctly handled In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18651 Colin Campbell changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |colin.campbell at ptfs-europe. | |com --- Comment #11 from Colin Campbell --- (In reply to Barton Chittenden from comment #10) > We have a problem with the auto_increment on issues.issue_id -- the > auto_increment is not kept if the database is stopped; it is simply > calculated by mysql when the database starts. > > That caused problems if we re-start the database after we've moved issues to > the old_issues table but before we've checked out enough items to increase > auto_increment past max(old_issues.issue_id) + 1. > > As a concrete example, let's say that we check out 3 items. items.issue_id > is now 3, and the auto_increment is set to 4. > > We then check in the items with issue_id = 2 and issue_id = 3. > > max(old_issues.issue_id) is now 3 > max(issues.issue_id) is now 1. > > We restart mysql at this point, mysql reads max(issues.issue_id) and sets > auto_increment to 2. We try to check in the item with issue_id=2. We can't > insert into old_issues due to the duplicate key constraint. > > I suspect that the right thing to do might be to use the mysql --init-file > option to run something like > > ALTER TABLE issues AUTO_INCREMENT= ### ( find the max of issues.issue_id and > old_issues.issue_id ) + 1 ### old_issues should not be auto_increment there is one id sequence and that comes from issues. If you try and maintain 2 sequences you have a race condition -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue May 23 10:52:33 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 23 May 2017 08:52:33 +0000 Subject: [Koha-bugs] [Bug 18655] New: Unimarc field 210c fails on importing fields with a simple quote Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18655 Bug ID: 18655 Summary: Unimarc field 210c fails on importing fields with a simple quote Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Cataloging Assignee: gmcharlt at gmail.com Reporter: baptiste.wojtkowski at biblibre.com QA Contact: testopia at bugs.koha-community.org CC: m.de.rooy at rijksmuseum.nl When you search for an editor with a simple quote in the name, the escaping fails and nothing happens. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue May 23 10:54:35 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 23 May 2017 08:54:35 +0000 Subject: [Koha-bugs] [Bug 18655] Unimarc field 210c fails on importing fields with a simple quote In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18655 --- Comment #1 from Baptiste --- Created attachment 63644 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=63644&action=edit Bug 18655: correct the escaping of ' and move code toward jquery part -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue May 23 11:48:13 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 23 May 2017 09:48:13 +0000 Subject: [Koha-bugs] [Bug 17779] Software error In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17779 Magnus Enger changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |magnus at libriotech.no Status|NEW |RESOLVED Resolution|--- |WONTFIX --- Comment #3 from Magnus Enger --- Closing this as there was no reponse. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue May 23 11:52:56 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 23 May 2017 09:52:56 +0000 Subject: [Koha-bugs] [Bug 18586] Create module to mint RDF subject URIs In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18586 Magnus Enger changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue May 23 11:52:59 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 23 May 2017 09:52:59 +0000 Subject: [Koha-bugs] [Bug 18586] Create module to mint RDF subject URIs In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18586 Magnus Enger changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #63640|0 |1 is obsolete| | --- Comment #4 from Magnus Enger --- Created attachment 63645 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=63645&action=edit Bug 18586 - Create module to mint RDF subject URIs Created the Koha::RDF module to mint URIs for RDF documents that represent Koha bibliographic records. _TEST PLAN_ To test the module, just run 'prove t/Koha/RDF.t'. You'll get some warnings about not being able to find koha-conf.xml, but you can safely ignore them or you can point to any koha-conf.xml file since it's not used by the test in actuality. Signed-off-by: Magnus Enger Works as expected. No warnings when run like: sudo koha-shell -c "prove t/Koha/RDF.t" kohadev -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue May 23 11:58:03 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 23 May 2017 09:58:03 +0000 Subject: [Koha-bugs] [Bug 18586] Create module to mint RDF subject URIs In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18586 Magnus Enger changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |10788 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10788 [Bug 10788] Add a Linked Data/RDF browser to the OPAC -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue May 23 11:58:03 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 23 May 2017 09:58:03 +0000 Subject: [Koha-bugs] [Bug 10788] Add a Linked Data/RDF browser to the OPAC In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10788 Magnus Enger changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on| |18586 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18586 [Bug 18586] Create module to mint RDF subject URIs -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue May 23 11:59:56 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 23 May 2017 09:59:56 +0000 Subject: [Koha-bugs] [Bug 14713] remaining_permissions permission under the "updatecharges" permission not working In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14713 Fridolin SOMERS changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |fridolin.somers at biblibre.co | |m --- Comment #5 from Fridolin SOMERS --- I see that pages : members/pay.pl members/paycollect.pl Need permissions from "updatecharges" but also full permissions from "borrowers" : flagsrequired => { borrowers => 1, updatecharges => $updatecharges_permissions }, -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Tue May 23 13:30:48 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 23 May 2017 11:30:48 +0000 Subject: [Koha-bugs] [Bug 18656] New: Dialog box, 'Are you sure you want to delete this file', on the borrower record Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18656 Bug ID: 18656 Summary: Dialog box, 'Are you sure you want to delete this file', on the borrower record Change sponsored?: --- Product: Koha Version: 16.05 Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Patrons Assignee: koha-bugs at lists.koha-community.org Reporter: baselibrary.consortium at nhs.net QA Contact: testopia at bugs.koha-community.org CC: gmcharlt at gmail.com, kyle.m.hall at gmail.com On the borrower record in Files, we store the patron registration form. If a member of staff accidentally hits the delete link, we would need to trace the originally scanned form at its' originating library to recover the file. To make user error more difficult, could Koha have a dialog box, 'Are you sure you want to delete this file', on the borrower record and file? -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Tue May 23 14:16:12 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 23 May 2017 12:16:12 +0000 Subject: [Koha-bugs] [Bug 18647] Internal server error on moremember.pl In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18647 --- Comment #8 from Marcel de Rooy --- (In reply to Tom?s Cohen Arazi from comment #7) > (In reply to Marc V?ron from comment #6) > > (In reply to Jonathan Druart from comment #3) > We still need Marcel's comment on why he put the TODO, because we might as > well miss some other edge case Marcel noticed. Looking here in a bit -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue May 23 14:16:32 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 23 May 2017 12:16:32 +0000 Subject: [Koha-bugs] [Bug 16330] REST API: add routes to add, update and delete patrons In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16330 --- Comment #46 from Lari Taskula --- (In reply to Lari Taskula from comment #45) > Hi! Sorry for the late response. My view for the todo: > > 1. "Move validation logic from controller to Koha::Patron" patch; obsolete > validate() method - validations should occur in Koha::Patron->store(). I'm starting to remember the issues with this and why I implemented a separate validate method. When patron makes a modification request to be verified by librarian, we have to validate the data provided by patron without storing the object and then create a new modification request if provided data is ok. (PUT /patrons/123 where 123 is his own borrowernumber, and they don't have borrowers flag. This functionality is not yet in these patches provided before this comment.) So what I did was in order to avoid validation logic duplication in Koha::Patron::Modification was: $patron->set($provided_data)->validate; # if are able to continue, store new Koha::Patron::Modification request Of course we can have both, a separate validate method and validations integrated in store(). Also my fear was to throw exceptions in widely used method like Koha::Patron->store which would probably break elsewhere in Koha where these exceptions are not yet caught. So this Bug is a lot more problematic to pass. I took a shortcut and excluded the validations from store(). However, as a long term solution, like Tomas suggested, store() is the right place but I think that is too much for the scope of this Bug. Unfortunately I can't work with Koha::Patron more now. Anyway, I have rewritten the tests as explained earlier, and added all of the patron parameteres to be queryable by GET /patrons. Also I added patron modification request to the PUT request. This is provided in the following patch. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue May 23 14:32:14 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 23 May 2017 12:32:14 +0000 Subject: [Koha-bugs] [Bug 18657] New: Inventory tool should display more Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18657 Bug ID: 18657 Summary: Inventory tool should display more Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Tools Assignee: gmcharlt at gmail.com Reporter: nick at bywatersolutions.com QA Contact: testopia at bugs.koha-community.org Currently the tool reports: Incorrect not-for-loan values Wrong place Checked out We should have: Optional display of items w/o problems Display of missing/lost items now marked found -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue May 23 14:32:26 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 23 May 2017 12:32:26 +0000 Subject: [Koha-bugs] [Bug 18657] Inventory tool should display more statuses/problems In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18657 Nick Clemens changed: What |Removed |Added ---------------------------------------------------------------------------- Summary|Inventory tool should |Inventory tool should |display more |display more | |statuses/problems -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue May 23 14:32:44 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 23 May 2017 12:32:44 +0000 Subject: [Koha-bugs] [Bug 18657] Inventory tool should display more statuses/problems In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18657 Nick Clemens changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |misilot at fit.edu -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue May 23 14:33:26 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 23 May 2017 12:33:26 +0000 Subject: [Koha-bugs] [Bug 18552] Borrower debarments do not show on member detail page In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18552 Marcel de Rooy changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |18647 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18647 [Bug 18647] Internal server error on moremember.pl -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue May 23 14:33:26 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 23 May 2017 12:33:26 +0000 Subject: [Koha-bugs] [Bug 18647] Internal server error on moremember.pl In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18647 Marcel de Rooy changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on| |18552 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18552 [Bug 18552] Borrower debarments do not show on member detail page -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue May 23 14:34:21 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 23 May 2017 12:34:21 +0000 Subject: [Koha-bugs] [Bug 18552] Borrower debarments do not show on member detail page In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18552 --- Comment #10 from Marcel de Rooy --- We resolved one bug here to reveal another one. See bug 18647. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue May 23 14:39:05 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 23 May 2017 12:39:05 +0000 Subject: [Koha-bugs] [Bug 16330] REST API: add routes to add, update and delete patrons In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16330 --- Comment #47 from Lari Taskula --- Created attachment 63646 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=63646&action=edit Bug 16330: REST API: add routes to add, update and delete patrons This patch adds support for add, edit and delete patrons via REST API. GET /api/v1/patrons Get patron list from params GET /api/v1/patrons/ Get single patron POST /api/v1/patrons Create a new patron PUT /api/v1/patrons/ Update data about patron DEL /api/v1/patrons/ Delete a patron Revised Test plan: 1) Apply this patch 2) Run tests perl t/db_dependent/api/v1/patrons.t 3) Add a user with proper rights to use the REST API 4) play with your favourite REST client (curl/httpie, etc.): Authenticate with the user created above and get a CGISESSION id. Use the CGISESSION to add, edit and delete patrons via the API. 5) Use PUT /patrons/ for a patron without borrowers flag. This should go into pending patron modification status and needs to be accepted by a librarian. Please note there is no validation of body input in PUT/POST other than branchcode,category,userid,cardnumber. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue May 23 14:39:29 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 23 May 2017 12:39:29 +0000 Subject: [Koha-bugs] [Bug 16330] REST API: add routes to add, update and delete patrons In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16330 --- Comment #48 from Lari Taskula --- Created attachment 63647 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=63647&action=edit Bug 16330: Spot unchanged modification-request in Koha::Patron::Modification Throw Koha::Exceptions::NoChanges if attempting to create a modification request without changing anything. This exception is caught in Patron REST API controller. Also, validate changes via Koha::Patron->_validate To test: 1. prove t/db_dependent/Koha/Patron/Modifications.t -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue May 23 14:40:53 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 23 May 2017 12:40:53 +0000 Subject: [Koha-bugs] [Bug 18230] Generate Koha::Patron::Modification verification_token in -> new In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18230 Lari Taskula changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |16330 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16330 [Bug 16330] REST API: add routes to add, update and delete patrons -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue May 23 14:40:53 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 23 May 2017 12:40:53 +0000 Subject: [Koha-bugs] [Bug 18330] REST API: Date-time handling In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18330 Lari Taskula changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |16330 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16330 [Bug 16330] REST API: add routes to add, update and delete patrons -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Tue May 23 14:40:53 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 23 May 2017 12:40:53 +0000 Subject: [Koha-bugs] [Bug 16330] REST API: add routes to add, update and delete patrons In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16330 Lari Taskula changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on| |18330, 18230 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18230 [Bug 18230] Generate Koha::Patron::Modification verification_token in ->new https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18330 [Bug 18330] REST API: Date-time handling -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue May 23 14:41:40 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 23 May 2017 12:41:40 +0000 Subject: [Koha-bugs] [Bug 18647] Internal server error on moremember.pl In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18647 Marcel de Rooy changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |Signed Off -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue May 23 14:41:43 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 23 May 2017 12:41:43 +0000 Subject: [Koha-bugs] [Bug 18647] Internal server error on moremember.pl In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18647 Marcel de Rooy changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #63596|0 |1 is obsolete| | --- Comment #9 from Marcel de Rooy --- Created attachment 63648 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=63648&action=edit Bug 18647: Resolve internal server error on category_type See bug 18552. When we resolved the housebound_role bug, the hash got filled correctly again. And this revealed that the (second) call to Koha::Patrons->find was not appropriate. We cannot yet remove the borrower template variable (reason for the TODO). So we should replace it by a call to GetMember. Note: Commit 95429af6855e8ed37945b681dc466bf360deffb added this call, but it was hidden until the template variable hash got fixed. Test plan: Restart Plack and go to patron details again. Signed-off-by: Marcel de Rooy -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue May 23 14:45:20 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 23 May 2017 12:45:20 +0000 Subject: [Koha-bugs] [Bug 16330] REST API: add routes to add, update and delete patrons In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16330 Lari Taskula changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #63646|0 |1 is obsolete| | --- Comment #49 from Lari Taskula --- Created attachment 63649 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=63649&action=edit Bug 16330: REST API: add routes to add, update and delete patrons This patch adds support for add, edit and delete patrons via REST API. GET /api/v1/patrons Get patron list from params GET /api/v1/patrons/ Get single patron POST /api/v1/patrons Create a new patron PUT /api/v1/patrons/ Update data about patron DEL /api/v1/patrons/ Delete a patron Revised Test plan: 1) Apply this patch 2) Run tests perl t/db_dependent/api/v1/patrons.t 3) Add a user with proper rights to use the REST API 4) play with your favourite REST client (curl/httpie, etc.): Authenticate with the user created above and get a CGISESSION id. Use the CGISESSION to add, edit and delete patrons via the API. 5) Use PUT /patrons/ for a patron without borrowers flag. This should go into pending patron modification status and needs to be accepted by a librarian. Please note there is no validation of body input in PUT/POST other than branchcode,category,userid,cardnumber. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue May 23 14:45:22 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 23 May 2017 12:45:22 +0000 Subject: [Koha-bugs] [Bug 18647] Internal server error on moremember.pl In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18647 --- Comment #10 from Marcel de Rooy --- (In reply to Jonathan Druart from comment #5) > I'd say the patch should be: > > diff --git a/members/moremember.pl b/members/moremember.pl > index 0e18d2234f..0649dcfd76 100755 > --- a/members/moremember.pl > +++ b/members/moremember.pl > @@ -343,7 +343,6 @@ my $translated_language = > C4::Languages::language_get_description( $subtag, $sub > > $template->param( > patron => $patron, > - borrower => $patron, # TODO Still needed by includes, > translated_language => $translated_language, > detailview => 1, > borrowernumber => $borrowernumber, > > > The borrower variable should not be a Koha::Patron, because the include file > expects an hashref. > > Marcel, do you know why you add the TODO comment? I do not find where it is > used. No, you cannot remove the borrower template var yet. The TODO was kind of trivial. Passing the same information twice needs further attention :) Probably by forgetting another Plack restart, I did not catch the internal server error.. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue May 23 14:45:33 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 23 May 2017 12:45:33 +0000 Subject: [Koha-bugs] [Bug 16330] REST API: add routes to add, update and delete patrons In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16330 Lari Taskula changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #63647|0 |1 is obsolete| | --- Comment #50 from Lari Taskula --- Created attachment 63650 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=63650&action=edit Bug 16330: Spot unchanged modification-request in Koha::Patron::Modification Throw Koha::Exceptions::NoChanges if attempting to create a modification request without changing anything. This exception is caught in Patron REST API controller. Also, validate changes via Koha::Patron->_validate To test: 1. prove t/db_dependent/Koha/Patron/Modifications.t -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue May 23 14:54:39 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 23 May 2017 12:54:39 +0000 Subject: [Koha-bugs] [Bug 18647] Internal server error on moremember.pl In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18647 --- Comment #11 from Marcel de Rooy --- (In reply to Marcel de Rooy from comment #10) > (In reply to Jonathan Druart from comment #5) > > I'd say the patch should be: > > > > diff --git a/members/moremember.pl b/members/moremember.pl > No, you cannot remove the borrower template var yet. Yes, we can remove it. Probably the same Plack problem.. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue May 23 14:56:08 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 23 May 2017 12:56:08 +0000 Subject: [Koha-bugs] [Bug 18655] Unimarc field 210c fails on importing fields with a simple quote In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18655 Fridolin SOMERS changed: What |Removed |Added ---------------------------------------------------------------------------- Patch complexity|--- |Trivial patch Severity|enhancement |minor CC| |fridolin.somers at biblibre.co | |m -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue May 23 14:56:14 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 23 May 2017 12:56:14 +0000 Subject: [Koha-bugs] [Bug 18647] Internal server error on moremember.pl In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18647 Marcel de Rooy changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #63648|0 |1 is obsolete| | --- Comment #12 from Marcel de Rooy --- Created attachment 63651 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=63651&action=edit Bug 18647: Resolve internal server error on category_type See bug 18552. When we resolved the housebound_role bug, the hash got filled correctly again. And this revealed that the (second) call to Koha::Patrons->find was not appropriate. It can be removed, as Jonathan explained on the report. Note: Commit 95429af6855e8ed37945b681dc466bf360deffb added this call, but it was hidden until the template variable hash got fixed. Test plan: Restart Plack and go to patron details again. Signed-off-by: Marcel de Rooy -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue May 23 14:57:01 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 23 May 2017 12:57:01 +0000 Subject: [Koha-bugs] [Bug 18655] Unimarc field 210c fails on importing fields with a simple quote In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18655 Fridolin SOMERS changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|gmcharlt at gmail.com |baptiste.wojtkowski at biblibr | |e.com Status|NEW |ASSIGNED -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue May 23 14:58:04 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 23 May 2017 12:58:04 +0000 Subject: [Koha-bugs] [Bug 18647] Internal server error on moremember.pl In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18647 --- Comment #13 from Marcel de Rooy --- >From IRC: Joubu marcelr: 290 $template->param(%$data); [14:51] Joubu patron-title.inc need patron's info, there are either picked from borrower.$field, or $field [14:51] Joubu in moremember we have $field, because of l.290 [14:51] Joubu we just need to reset the state to the one before the patron's club ft [14:51] Joubu and so delete the line -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue May 23 15:05:33 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 23 May 2017 13:05:33 +0000 Subject: [Koha-bugs] [Bug 18657] Inventory tool should display more statuses/problems In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18657 --- Comment #1 from Tom Misilo --- Is it possible #12913 removed some of the existing functionality? Like "Display of missing/lost items now marked found" -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue May 23 15:27:24 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 23 May 2017 13:27:24 +0000 Subject: [Koha-bugs] [Bug 18658] New: Prevent Modify action when reserved item is awaiting collection Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18658 Bug ID: 18658 Summary: Prevent Modify action when reserved item is awaiting collection Change sponsored?: --- Product: Koha Version: 16.05 Hardware: All OS: All Status: NEW Severity: trivial Priority: P5 - low Component: OPAC Assignee: oleonard at myacpl.org Reporter: r.delahunty at arts.ac.uk QA Contact: testopia at bugs.koha-community.org Modify opac-modrequest.pl to have it check to see if item has arrived for collection, and either suppress Modify option to prevent users cancelling the reservation (hold) when item is ready to collect, or warn the user the reservation (hold) cannot be cancelled as it is now too late. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue May 23 15:29:44 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 23 May 2017 13:29:44 +0000 Subject: [Koha-bugs] [Bug 18657] Inventory tool should display more statuses/problems In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18657 Marcel de Rooy changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |m.de.rooy at rijksmuseum.nl --- Comment #2 from Marcel de Rooy --- (In reply to Tom Misilo from comment #1) > Is it possible #12913 removed some of the existing functionality? Like > "Display of missing/lost items now marked found" Functionality was not the right word for the status of the code ;) -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue May 23 15:35:16 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 23 May 2017 13:35:16 +0000 Subject: [Koha-bugs] [Bug 18655] Unimarc field 210c fails on importing fields with a simple quote In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18655 --- Comment #2 from Fridolin SOMERS --- Created attachment 63652 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=63652&action=edit Bug 18655: Followup -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue May 23 15:37:45 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 23 May 2017 13:37:45 +0000 Subject: [Koha-bugs] [Bug 18634] Missing empty line at end of opac.pref In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18634 Marcel de Rooy changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |m.de.rooy at rijksmuseum.nl --- Comment #8 from Marcel de Rooy --- (In reply to Marc V?ron from comment #6) > Hi Blou > I just did a git pull and then wanted to apply and sign off your patch. > But now it seems that already without your patch the last line 826 has > vanished. > Maybe it was fixed by another patch? No this is about git and whitespace settings.. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue May 23 15:41:27 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 23 May 2017 13:41:27 +0000 Subject: [Koha-bugs] [Bug 18634] Missing empty line at end of opac.pref In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18634 --- Comment #9 from Marcel de Rooy --- (In reply to Blou from comment #5) > For me, I enter "paypal" in the system preferences search and get 6 entries > under Payment in English. I get nothing in French. > Adding the empty line fixes it. > > Now, is it useless and senseless? I agree. I looked at circulation.pref > for comfort before commiting, and saw the "semi-emtpy" line. > > I looked at fr-CA-pref.po for weirdness, could not find any. The # OPAC > > Payments where right in the middle, all happy and comfy. > > If ONE wouldn't show up, I'd get it. But all six? It really points to > opac.prefs, but I have no idea why (beside this dummy end line). > > :( Several other .pref files do not have this empty line at the end. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue May 23 15:42:33 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 23 May 2017 13:42:33 +0000 Subject: [Koha-bugs] [Bug 18655] Unimarc field 210c fails on importing fields with a simple quote In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18655 Baptiste changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #63644|0 |1 is obsolete| | Attachment #63652|0 |1 is obsolete| | --- Comment #3 from Baptiste --- Created attachment 63653 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=63653&action=edit Bug 18655: Correct the "chose" link - Link 'chose' is now a button. - It doesn't call directly javascript anymore (use of listener). - field to load stored in html on the page (less escaping needed). -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue May 23 15:44:05 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 23 May 2017 13:44:05 +0000 Subject: [Koha-bugs] [Bug 18655] Unimarc field 210c fails on importing fields with a simple quote In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18655 Fridolin SOMERS changed: What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue May 23 15:44:45 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 23 May 2017 13:44:45 +0000 Subject: [Koha-bugs] [Bug 18651] Move of checkouts is still not correctly handled In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18651 Kyle M Hall changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |kyle at bywatersolutions.com --- Comment #12 from Kyle M Hall --- No, but if the last return is the last issue, then max issue_id in old_issues will be higher than the max id in issues. Thus, the current auto_increment issue_id will match an existing old_issues issue_id and thus everything blows up. Barton is proposing that on startup, we set the auto_increment for issues.issue_id to GREATEST( MAX(issues.issue_id), MAX(old_issues.issue_id) ) + 1 > old_issues should not be auto_increment there is one id sequence and that > comes from issues. If you try and maintain 2 sequences you have a race > condition -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue May 23 15:48:45 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 23 May 2017 13:48:45 +0000 Subject: [Koha-bugs] [Bug 18651] Move of checkouts is still not correctly handled In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18651 --- Comment #13 from Jonathan Druart --- Created attachment 63654 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=63654&action=edit Bug 18651: Copy the row before modify the id If the "max(issue_id) from old_issue + 1" already exists in issues, the move fails. For instance we have 1, 2, 3, 4 in issues checkin 4 1, 2, 3 in issues (AI=5) 4 in old_issues Restart mysql => AI is reset to MAX(issue_id) => 4 checkout a new one 1, 2, 3, 4 in issues (AI=5) 4 in old_issues checkin 4 (will get id 5 in old_issues) 1, 2, 3 in issues (AI=5) 4, 5 in old_issues => This works with and without this patch Now we have 1, 2, 3 in issues (AI=5) 4, 5 in old_issues Restart mysql => AI is reset to MAX(issue_id) => 4 checkout a 2 new ones 1, 2, 3, 4, 5 in issues (AI=6) 4 in old_issues checkin 4 1, 2, 3, 5 in issues (AI=6) 4, 5 in old_issues => This did not work without with patch The update of the issue_id was made before the move (so in the issues table), the PK did not allow it -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue May 23 15:48:58 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 23 May 2017 13:48:58 +0000 Subject: [Koha-bugs] [Bug 18651] Move of checkouts is still not correctly handled In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18651 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue May 23 16:01:07 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 23 May 2017 14:01:07 +0000 Subject: [Koha-bugs] [Bug 18651] Move of checkouts is still not correctly handled In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18651 --- Comment #14 from Kyle M Hall --- I like the solution. Correct me if I'm wrong, but we still aren't correcting the auto_increment value for issue_id. This effectively *does* create a race condition if two checkins happen simultaneously where the issue_id's are already in old_issues. The only solution that comes to mind at the moment is lines 18651 through 2192 in a loop that ends when the query on line 2192 succeeds. Is that reasonable? Or do we just accept the small risk that an error condition will be triggered? As long as the failure doesn't introduce bad and inconsistent data I think it's worth the tiny risk of a librarian getting an error on checkin once in a blue moon, and have to check the item in a second time. (In reply to Jonathan Druart from comment #13) > Created attachment 63654 [details] [review] > Bug 18651: Copy the row before modify the id -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue May 23 16:30:57 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 23 May 2017 14:30:57 +0000 Subject: [Koha-bugs] [Bug 18651] Move of checkouts is still not correctly handled In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18651 Barton Chittenden changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |https://bugs.koha-community | |.org/bugzilla3/show_bug.cgi | |?id=18242 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue May 23 16:30:57 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 23 May 2017 14:30:57 +0000 Subject: [Koha-bugs] [Bug 18242] Move of checkouts to old_issues is not handle correctly In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18242 Barton Chittenden changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |https://bugs.koha-community | |.org/bugzilla3/show_bug.cgi | |?id=18651 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue May 23 16:36:36 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 23 May 2017 14:36:36 +0000 Subject: [Koha-bugs] [Bug 18634] Missing empty line at end of opac.pref In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18634 --- Comment #10 from Marcel de Rooy --- Just looked a bit deeper in the code: misc/translator uses YAML::Syck::LoadFile on a pref file admin/preferences first uses gettemplate on a pref file, runs template->output and feeds that into YAML::Syck::Load Seems your problem is related to the second route. In order to know what happens with your french prefs, please examine the output of $data=gettemplate(...) and then $data->output in a test script, making sure that gettemplate reads your french file. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue May 23 16:37:51 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 23 May 2017 14:37:51 +0000 Subject: [Koha-bugs] [Bug 18634] Missing empty line at end of opac.pref In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18634 --- Comment #11 from Marcel de Rooy --- Could you add your french pref file as an attachment here too? -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue May 23 16:45:28 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 23 May 2017 14:45:28 +0000 Subject: [Koha-bugs] [Bug 18634] Missing empty line at end of opac.pref In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18634 --- Comment #12 from Marcel de Rooy --- Created attachment 63655 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=63655&action=edit Sample test code -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue May 23 16:48:04 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 23 May 2017 14:48:04 +0000 Subject: [Koha-bugs] [Bug 18634] Missing empty line at end of opac.pref In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18634 --- Comment #13 from Blou --- Created attachment 63656 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=63656&action=edit File causing the problem -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue May 23 16:49:38 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 23 May 2017 14:49:38 +0000 Subject: [Koha-bugs] [Bug 18634] Missing empty line at end of opac.pref In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18634 --- Comment #14 from Blou --- Thanks Marcel, I joined the file I have on my laptop. I had moved from the problem to other issues, but I'll be happy to do your test as soon as I find 10 minutes, sooner rather than later. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue May 23 17:02:55 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 23 May 2017 15:02:55 +0000 Subject: [Koha-bugs] [Bug 18659] New: Barcode input filter not taken into consideration with batch Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18659 Bug ID: 18659 Summary: Barcode input filter not taken into consideration with batch Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: normal Priority: P5 - low Component: Circulation Assignee: koha-bugs at lists.koha-community.org Reporter: philippe.blouin at inlibro.com QA Contact: testopia at bugs.koha-community.org CC: gmcharlt at gmail.com, kyle.m.hall at gmail.com circulation.pl was modified to handle barcode batches, but the code modifying the barcode is isolated and does not modify the batch. for my $barcode ( @$barcodes ) { $barcode =~ s/^\s*|\s*$//g; # remove leading/trailing whitespace $barcode = barcodedecode($barcode) if( $barcode && C4::Context->preference('itemBarcodeInputFilter')); } The local $barcode is modified, but not the array content. The issuing code later on just start with @$barcodes again, not with $barcode, so the modif is not even considered when using one barcode. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Tue May 23 17:03:33 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 23 May 2017 15:03:33 +0000 Subject: [Koha-bugs] [Bug 18659] Barcode input filter not taken into consideration with batch In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18659 Blou changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|koha-bugs at lists.koha-commun |philippe.blouin at inlibro.com |ity.org | CC| |philippe.blouin at inlibro.com Patch complexity|--- |Small patch -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Tue May 23 17:05:49 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 23 May 2017 15:05:49 +0000 Subject: [Koha-bugs] [Bug 18634] Missing empty line at end of opac.pref In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18634 --- Comment #15 from Marcel de Rooy --- (In reply to Blou from comment #14) > Thanks Marcel, > I joined the file I have on my laptop. I had moved from the problem to > other issues, but I'll be happy to do your test as soon as I find 10 > minutes, sooner rather than later. Hi. Could you also attach the actual opac.pref ? -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue May 23 17:09:21 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 23 May 2017 15:09:21 +0000 Subject: [Koha-bugs] [Bug 18660] New: Translatability: Get rid of template directives [ %% in translation for patroncards-errors.inc Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18660 Bug ID: 18660 Summary: Translatability: Get rid of template directives [%% in translation for patroncards-errors.inc Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: trivial Priority: P5 - low Component: I18N/L10N Assignee: koha-bugs at lists.koha-community.org Reporter: veron at veron.ch QA Contact: testopia at bugs.koha-community.org CC: frederic at tamil.fr Translation for koha-tmpl/intranet-tmpl/prog/en/includes/patroncards-errors.inc contains a lot of (partial) template directives like %%]%s %sLayout: [%% -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue May 23 17:11:51 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 23 May 2017 15:11:51 +0000 Subject: [Koha-bugs] [Bug 18659] Barcode input filter not taken into consideration with batch In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18659 Blou changed: What |Removed |Added ---------------------------------------------------------------------------- Resolution|--- |INVALID Status|NEW |RESOLVED --- Comment #1 from Blou --- Ok, this is a code 18. In normal circumstances (code not modified), would not happen. Code is ok. I would close it if I could, but can't. So here, Resolved-Invalid. Hope it's ok. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue May 23 17:23:10 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 23 May 2017 15:23:10 +0000 Subject: [Koha-bugs] [Bug 18660] Translatability: Get rid of template directives [ %% in translation for patroncards-errors.inc In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18660 --- Comment #1 from Marc V?ron --- Created attachment 63658 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=63658&action=edit Bug 18660: Translatability: Get rid of template directives [%% in translation for patroncards-errors.inc Translation for koha-tmpl/intranet-tmpl/prog/en/includes/patroncards-errors.inc contains a lot of (partial) template directives like: %%]%s %sLayout: [%% This patch fixes it To test: - Verify that code changes make sense - Apply patch - Create a translation (cd misc/translator , then: perl translate create aa-AA - Verify that in po/aa-AA-staff-prog.po contains no fragments like %%] or [%% for patroncards-errors.inc - Try to get an error: Try a link like http://[YOUR SERVER]/cgi-bin/koha/patroncards/create-pdf.pl?batch_id=1&template_id=999&layout_id=999&start_card=1 ...where template_id and layout_id do not exist -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue May 23 17:24:01 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 23 May 2017 15:24:01 +0000 Subject: [Koha-bugs] [Bug 18660] Translatability: Get rid of template directives [ %% in translation for patroncards-errors.inc In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18660 Marc V?ron changed: What |Removed |Added ---------------------------------------------------------------------------- Patch complexity|--- |Small patch Assignee|koha-bugs at lists.koha-commun |veron at veron.ch |ity.org | Status|NEW |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Tue May 23 17:24:47 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 23 May 2017 15:24:47 +0000 Subject: [Koha-bugs] [Bug 18651] Move of checkouts is still not correctly handled In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18651 --- Comment #15 from Kyle M Hall --- Comment on attachment 63654 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=63654 Bug 18651: Copy the row before modify the id Review of attachment 63654: --> (https://bugs.koha-community.org/bugzilla3/page.cgi?id=splinter.html&bug=18651&attachment=63654) ----------------------------------------------------------------- ::: C4/Circulation.pm @@ +2180,4 @@ > > + # Create the old_issues entry > + my $old_checkout_data = $issue->unblessed; > + Start the loop here @@ +2193,3 @@ > > + # Update the fines > + $dbh->do(q|UPDATE accountlines SET issue_id = ? WHERE issue_id = ?|, undef, $old_checkout->issue_id, $issue->issue_id); If the dbh update files, go back to "Start the loop here", otherwise continue. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue May 23 17:25:24 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 23 May 2017 15:25:24 +0000 Subject: [Koha-bugs] [Bug 18651] Move of checkouts is still not correctly handled In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18651 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #63654|0 |1 is obsolete| | --- Comment #16 from Jonathan Druart --- Created attachment 63659 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=63659&action=edit Bug 18651: Copy the row before modify the id If the "max(issue_id) from old_issue + 1" already exists in issues, the move fails. For instance we have 1, 2, 3, 4 in issues checkin 4 1, 2, 3 in issues (AI=5) 4 in old_issues Restart mysql => AI is reset to MAX(issue_id) => 4 checkout a new one 1, 2, 3, 4 in issues (AI=5) 4 in old_issues checkin 4 (will get id 5 in old_issues) 1, 2, 3 in issues (AI=5) 4, 5 in old_issues => This works with and without this patch Now we have 1, 2, 3 in issues (AI=5) 4, 5 in old_issues Restart mysql => AI is reset to MAX(issue_id) => 4 checkout 2 new ones 1, 2, 3, 4, 5 in issues (AI=7) 4, 5 in old_issues checkin 4 (4 becomes 6 in old_issues) 1, 2, 3, 5 in issues (AI=6) 4, 5, 6 in old_issues => This did not work without with patch The update of the issue_id was made before the move (so in the issues table), the PK did not allow it -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue May 23 17:25:28 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 23 May 2017 15:25:28 +0000 Subject: [Koha-bugs] [Bug 18634] Missing empty line at end of opac.pref In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18634 --- Comment #16 from Blou --- Created attachment 63660 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=63660&action=edit Translated fr-CA opac.pref -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue May 23 17:26:28 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 23 May 2017 15:26:28 +0000 Subject: [Koha-bugs] [Bug 18651] Move of checkouts is still not correctly handled In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18651 --- Comment #17 from Jonathan Druart --- I have messed up the example. I reattached the patch amending the commit message. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue May 23 17:27:37 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 23 May 2017 15:27:37 +0000 Subject: [Koha-bugs] [Bug 18661] New: Make "Replace only included patron attributes" default on patron import Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18661 Bug ID: 18661 Summary: Make "Replace only included patron attributes" default on patron import Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Tools Assignee: gmcharlt at gmail.com Reporter: katrin.fischer at bsz-bw.de QA Contact: testopia at bugs.koha-community.org "Replace only included patron attributes" on the patron import page is the less dangerous option and should be the default. If you forget to switch from "Replace all patron attributes" any additional attributes will be silently deleted. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue May 23 17:45:51 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 23 May 2017 15:45:51 +0000 Subject: [Koha-bugs] [Bug 18662] New: Can not delete any curreny (used by Koha::Acquisition:: Booksellers=HASH(0xec48a4c) vendors) Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18662 Bug ID: 18662 Summary: Can not delete any curreny (used by Koha::Acquisition::Booksellers=HASH(0xec48a4c) vendors) Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: major Priority: P5 - low Component: System Administration Assignee: koha-bugs at lists.koha-community.org Reporter: veron at veron.ch QA Contact: testopia at bugs.koha-community.org CC: gmcharlt at gmail.com Trying to delete any currency leads to a message: "Cannot delete currency 'XYZ' This currency is used by Koha::Acquisition::Booksellers=HASH(0xec48a4c) vendors. Deletion not possible" To reproduce: - Go to Home > Administration > Currencies & Exchange rates - Add a new currency (to make sure that it is not used by any bookseller) - Try to delete currency (or any other) Result: Message above. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue May 23 17:55:20 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 23 May 2017 15:55:20 +0000 Subject: [Koha-bugs] [Bug 18662] Can not delete any curreny (used by Koha::Acquisition:: Booksellers=HASH(0xec48a4c) vendors) In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18662 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|koha-bugs at lists.koha-commun |jonathan.druart at bugs.koha-c |ity.org |ommunity.org CC| |jonathan.druart at bugs.koha-c | |ommunity.org -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Tue May 23 17:55:28 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 23 May 2017 15:55:28 +0000 Subject: [Koha-bugs] [Bug 18662] Can not delete any curreny (used by Koha::Acquisition:: Booksellers=HASH(0xec48a4c) vendors) In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18662 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |ASSIGNED -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue May 23 17:56:12 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 23 May 2017 15:56:12 +0000 Subject: [Koha-bugs] [Bug 18354] Adding item type attribute to cover image div In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18354 Michael Cabus changed: What |Removed |Added ---------------------------------------------------------------------------- Patch complexity|--- |Trivial patch Status|ASSIGNED |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue May 23 17:56:15 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 23 May 2017 15:56:15 +0000 Subject: [Koha-bugs] [Bug 18354] Adding item type attribute to cover image div In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18354 --- Comment #1 from Michael Cabus --- Created attachment 63661 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=63661&action=edit Bug 18354 Adding item type attribute to cover image div this adds item type so we can do things with javascript To Test 1.) Do a search on OPAC 2.) Inspect element to confirm item type is not present 3.) Apply patch 4.) Do a search on OPAC to confirm item -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue May 23 18:02:24 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 23 May 2017 16:02:24 +0000 Subject: [Koha-bugs] [Bug 18662] Can not delete currency if used by vendors In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18662 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Summary|Can not delete any curreny |Can not delete currency if |(used by |used by vendors |Koha::Acquisition::Booksell | |ers=HASH(0xec48a4c) | |vendors) | Depends on| |13726 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13726 [Bug 13726] Koha::Acquisition::Bookseller should use Koha::Object -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue May 23 18:02:24 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 23 May 2017 16:02:24 +0000 Subject: [Koha-bugs] [Bug 13726] Koha::Acquisition::Bookseller should use Koha::Object In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13726 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |18662 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18662 [Bug 18662] Can not delete currency if used by vendors -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue May 23 18:03:25 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 23 May 2017 16:03:25 +0000 Subject: [Koha-bugs] [Bug 18662] Can not delete currencies In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18662 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Summary|Can not delete currency if |Can not delete currencies |used by vendors | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue May 23 18:05:04 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 23 May 2017 16:05:04 +0000 Subject: [Koha-bugs] [Bug 18662] Can not delete currencies In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18662 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue May 23 18:05:08 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 23 May 2017 16:05:08 +0000 Subject: [Koha-bugs] [Bug 18662] Can not delete currencies In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18662 --- Comment #1 from Jonathan Druart --- Created attachment 63662 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=63662&action=edit Bug 18662: Fix currency deletion Sounds like it is caused by bug 13726. It is not possible to delete a currency, even if not used by any vendors Test plan: Try and delete currencies used or not by vendors. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue May 23 18:05:39 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 23 May 2017 16:05:39 +0000 Subject: [Koha-bugs] [Bug 18662] Can not delete currencies In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18662 Josef Moravec changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |josef.moravec at gmail.com -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue May 23 18:07:21 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 23 May 2017 16:07:21 +0000 Subject: [Koha-bugs] [Bug 18647] Internal server error on moremember.pl In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18647 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #63651|0 |1 is obsolete| | --- Comment #14 from Jonathan Druart --- Created attachment 63663 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=63663&action=edit Bug 18647: Resolve internal server error on category_type See bug 18552. When we resolved the housebound_role bug, the hash got filled correctly again. And this revealed that the (second) call to Koha::Patrons->find was not appropriate. It can be removed, as Jonathan explained on the report. Note: Commit 95429af6855e8ed37945b681dc466bf360deffb added this call, but it was hidden until the template variable hash got fixed. Test plan: Restart Plack and go to patron details again. Signed-off-by: Marcel de Rooy Signed-off-by: Jonathan Druart -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue May 23 18:07:43 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 23 May 2017 16:07:43 +0000 Subject: [Koha-bugs] [Bug 18647] Internal server error on moremember.pl In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18647 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|kyle at bywatersolutions.com |m.de.rooy at rijksmuseum.nl -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue May 23 18:57:25 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 23 May 2017 16:57:25 +0000 Subject: [Koha-bugs] [Bug 18662] Can not delete currencies In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18662 Marc V?ron changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #63662|0 |1 is obsolete| | --- Comment #2 from Marc V?ron --- Created attachment 63664 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=63664&action=edit Bug 18662: Fix currency deletion Sounds like it is caused by bug 13726. It is not possible to delete a currency, even if not used by any vendors Test plan: Try and delete currencies used or not by vendors. Signed-off-by: Marc V?ron -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue May 23 18:57:44 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 23 May 2017 16:57:44 +0000 Subject: [Koha-bugs] [Bug 18662] Can not delete currencies In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18662 Marc V?ron changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue May 23 18:58:12 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 23 May 2017 16:58:12 +0000 Subject: [Koha-bugs] [Bug 7663] batch add barcodes to a list In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7663 J Schmidt changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |jschmidt at switchinc.org -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue May 23 19:10:06 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 23 May 2017 17:10:06 +0000 Subject: [Koha-bugs] [Bug 16295] marc_modification_templates permission doesn' t allow access to modify template In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16295 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |jonathan.druart at bugs.koha-c | |ommunity.org Depends on| |8015 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8015 [Bug 8015] Add MARC Modifications Templates -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue May 23 19:10:06 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 23 May 2017 17:10:06 +0000 Subject: [Koha-bugs] [Bug 8015] Add MARC Modifications Templates In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8015 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |16295 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16295 [Bug 16295] marc_modification_templates permission doesn't allow access to modify template -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue May 23 19:10:16 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 23 May 2017 17:10:16 +0000 Subject: [Koha-bugs] [Bug 16295] marc_modification_templates permission doesn' t allow access to modify template In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16295 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |ASSIGNED Assignee|gmcharlt at gmail.com |jonathan.druart at bugs.koha-c | |ommunity.org -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue May 23 19:12:43 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 23 May 2017 17:12:43 +0000 Subject: [Koha-bugs] [Bug 16295] marc_modification_templates permission doesn' t allow access to modify template In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16295 --- Comment #3 from Jonathan Druart --- Created attachment 63665 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=63665&action=edit Bug 16295: Fix access to MMT admin page There was a typo in the permission code Test plan: Try to access the marc modification templates admin page with the marc_modification_templates permission (and not all tools permissions) -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue May 23 19:12:39 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 23 May 2017 17:12:39 +0000 Subject: [Koha-bugs] [Bug 16295] marc_modification_templates permission doesn' t allow access to modify template In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16295 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue May 23 19:18:35 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 23 May 2017 17:18:35 +0000 Subject: [Koha-bugs] [Bug 17717] process_message_queue.pl: Can't locate Authen/CAS/Client/ Response/Failure.pm In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17717 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |jonathan.druart at bugs.koha-c | |ommunity.org --- Comment #15 from Jonathan Druart --- So, what do we do? Do we release 17.05 as it or we propose a workaround? Is the `cd /tmp` trick added to the cron line acceptable? -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue May 23 19:22:08 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 23 May 2017 17:22:08 +0000 Subject: [Koha-bugs] [Bug 16332] calendar don't show new month In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16332 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Summary|calendar don't show the May |calendar don't show new |2016 |month CC| |jonathan.druart at bugs.koha-c | |ommunity.org -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue May 23 19:22:15 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 23 May 2017 17:22:15 +0000 Subject: [Koha-bugs] [Bug 16332] calendar don't show next month In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16332 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Summary|calendar don't show new |calendar don't show next |month |month -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue May 23 19:49:24 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 23 May 2017 17:49:24 +0000 Subject: [Koha-bugs] [Bug 13952] Import and export of authority types In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13952 Josef Moravec changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Failed QA --- Comment #30 from Josef Moravec --- Exporting does work as expected. But I don't think the importing should work this way: it does NOT matter, to which authtype you import, it imports everytime to the framework with the same typecode - I think step 6 in test plan is bad - biblio framework import does not need that, so it should be consistent. And please update your patch according to comment 29. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue May 23 20:11:54 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 23 May 2017 18:11:54 +0000 Subject: [Koha-bugs] [Bug 16295] marc_modification_templates permission doesn' t allow access to modify template In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16295 Josef Moravec changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue May 23 20:12:00 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 23 May 2017 18:12:00 +0000 Subject: [Koha-bugs] [Bug 16295] marc_modification_templates permission doesn' t allow access to modify template In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16295 Josef Moravec changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #63665|0 |1 is obsolete| | --- Comment #4 from Josef Moravec --- Created attachment 63666 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=63666&action=edit [SIGNED-OFF] Bug 16295: Fix access to MMT admin page There was a typo in the permission code Test plan: Try to access the marc modification templates admin page with the marc_modification_templates permission (and not all tools permissions) Signed-off-by: Josef Moravec -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue May 23 20:25:42 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 23 May 2017 18:25:42 +0000 Subject: [Koha-bugs] [Bug 18611] Create labels action fails in manage-marc-import.pl if an item has been deleted from the import batch. In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18611 Josef Moravec changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #63483|0 |1 is obsolete| | --- Comment #3 from Josef Moravec --- Created attachment 63667 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=63667&action=edit Bug 18611 - Create labels action fails in manage-marc-import.pl if an item has been deleted from the import batch. To test: 1 - Import a batch with some items 2 - Delete one of the imported items 3 - Browse to Tools->Staged MARC record management 4 - Click (Create label batch) for the batch you imported 5 - Recieve an error 6 - Apply patch 7 - Click (Create label batch) 8 - Batch is created with remaning items from the import Signed-off-by: Josef Moravec Signed-off-by: Josef Moravec -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue May 23 20:25:46 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 23 May 2017 18:25:46 +0000 Subject: [Koha-bugs] [Bug 18611] Create labels action fails in manage-marc-import.pl if an item has been deleted from the import batch. In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18611 --- Comment #4 from Josef Moravec --- Created attachment 63668 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=63668&action=edit [SIGNED-OFF] Bug 18611 - Followup, remove tabs to make qa tools happy Signed-off-by: Josef Moravec -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue May 23 20:25:38 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 23 May 2017 18:25:38 +0000 Subject: [Koha-bugs] [Bug 18611] Create labels action fails in manage-marc-import.pl if an item has been deleted from the import batch. In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18611 Josef Moravec changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue May 23 20:26:35 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 23 May 2017 18:26:35 +0000 Subject: [Koha-bugs] [Bug 18611] Create labels action fails in manage-marc-import.pl if an item has been deleted from the import batch. In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18611 Josef Moravec changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #63668|0 |1 is obsolete| | --- Comment #5 from Josef Moravec --- Created attachment 63669 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=63669&action=edit Bug 18611 - Followup, remove tabs to make qa tools happy Signed-off-by: Josef Moravec -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue May 23 20:35:38 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 23 May 2017 18:35:38 +0000 Subject: [Koha-bugs] [Bug 18601] OAI/Sets.t mangles data due to truncate in ModOAISetsBiblios In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18601 Josef Moravec changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue May 23 20:35:42 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 23 May 2017 18:35:42 +0000 Subject: [Koha-bugs] [Bug 18601] OAI/Sets.t mangles data due to truncate in ModOAISetsBiblios In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18601 Josef Moravec changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #63460|0 |1 is obsolete| | --- Comment #2 from Josef Moravec --- Created attachment 63670 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=63670&action=edit [SIGNED-OFF] Bug 18601: OAI/Sets.t mangles data due to truncate in ModOAISetsBiblios This patch replaces the TRUNCATE statement in ModOAISetsBiblios by a DELETE statement. A truncate will cause an implicit commit and will therefore commit the transaction started in the test script. Also simplifying the module load in the test script. Test plan: Do not apply this patch and observe that biblio records are added to your database by running t/db_dependent/OAI/Sets.t. Apply this patch, run the test again and verify that it does no longer add records to your biblio table. Signed-off-by: Marcel de Rooy Signed-off-by: Josef Moravec -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue May 23 20:44:47 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 23 May 2017 18:44:47 +0000 Subject: [Koha-bugs] [Bug 17717] process_message_queue.pl: Can't locate Authen/CAS/Client/ Response/Failure.pm In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17717 Josef Moravec changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |josef.moravec at gmail.com --- Comment #16 from Josef Moravec --- (In reply to Jonathan Druart from comment #15) > So, what do we do? > Do we release 17.05 as it or we propose a workaround? > Is the `cd /tmp` trick added to the cron line acceptable? I think we should make workaround now and create new bug report for long term solution immedietely... -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue May 23 20:57:01 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 23 May 2017 18:57:01 +0000 Subject: [Koha-bugs] [Bug 10371] Show item status in cart list In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10371 Josef Moravec changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |josef.moravec at gmail.com --- Comment #1 from Josef Moravec --- (In reply to Amit Gupta from comment #0) > Show item status in cart list Provide more details please... -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue May 23 21:11:12 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 23 May 2017 19:11:12 +0000 Subject: [Koha-bugs] [Bug 18663] New: ExportRemoveFields Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18663 Bug ID: 18663 Summary: ExportRemoveFields Change sponsored?: --- Product: Koha Version: unspecified Hardware: All OS: All Status: ASSIGNED Severity: major Priority: P5 - low Component: Architecture, internals, and plumbing Assignee: jonathan.druart at bugs.koha-community.org Reporter: jonathan.druart at bugs.koha-community.org QA Contact: testopia at bugs.koha-community.org Acc -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue May 23 21:11:38 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 23 May 2017 19:11:38 +0000 Subject: [Koha-bugs] [Bug 18663] Missing db update for ExportRemoveFields In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18663 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Summary|ExportRemoveFields |Missing db update for | |ExportRemoveFields -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue May 23 21:11:44 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 23 May 2017 19:11:44 +0000 Subject: [Koha-bugs] [Bug 18663] Missing db update for ExportRemoveFields In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18663 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |https://bugs.koha-community | |.org/bugzilla3/show_bug.cgi | |?id=18600 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue May 23 21:11:44 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 23 May 2017 19:11:44 +0000 Subject: [Koha-bugs] [Bug 18600] Missing db update for TalkingTechItivaPhoneNotification In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18600 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |https://bugs.koha-community | |.org/bugzilla3/show_bug.cgi | |?id=18663 -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue May 23 21:12:55 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 23 May 2017 19:12:55 +0000 Subject: [Koha-bugs] [Bug 18600] Missing db update for TalkingTechItivaPhoneNotification In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18600 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |ASSIGNED Assignee|koha-bugs at lists.koha-commun |jonathan.druart at bugs.koha-c |ity.org |ommunity.org CC| |jonathan.druart at bugs.koha-c | |ommunity.org --- Comment #1 from Jonathan Druart --- TalkingTechItivaPhoneNotification has been added by 3.05.00.022, but in sysprefs.sql with bug 18444. It may be missing for some installations. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Tue May 23 21:14:17 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 23 May 2017 19:14:17 +0000 Subject: [Koha-bugs] [Bug 18663] Missing db update for ExportRemoveFields In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18663 --- Comment #1 from Jonathan Druart --- ExportRemoveFields has been added by 3.09.00.041, but in sysprefs.sql with bug 15498. It may be missing for some installations. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue May 23 21:17:04 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 23 May 2017 19:17:04 +0000 Subject: [Koha-bugs] [Bug 18600] Missing db update for TalkingTechItivaPhoneNotification In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18600 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue May 23 21:17:07 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 23 May 2017 19:17:07 +0000 Subject: [Koha-bugs] [Bug 18600] Missing db update for TalkingTechItivaPhoneNotification In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18600 --- Comment #2 from Jonathan Druart --- Created attachment 63671 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=63671&action=edit Bug 18600: Add pref TalkingTechItivaPhoneNotification if missing -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue May 23 21:19:08 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 23 May 2017 19:19:08 +0000 Subject: [Koha-bugs] [Bug 18663] Missing db update for ExportRemoveFields In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18663 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue May 23 21:19:11 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 23 May 2017 19:19:11 +0000 Subject: [Koha-bugs] [Bug 18663] Missing db update for ExportRemoveFields In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18663 --- Comment #2 from Jonathan Druart --- Created attachment 63672 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=63672&action=edit Bug 18663: Add pref ExportRemoveFields if missing -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue May 23 21:33:10 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 23 May 2017 19:33:10 +0000 Subject: [Koha-bugs] [Bug 17762] Ability to translate notices In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17762 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |18664 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18664 [Bug 18664] IssueSlip.t is failing - IssueSlip should return if params are not valid -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue May 23 21:33:10 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 23 May 2017 19:33:10 +0000 Subject: [Koha-bugs] [Bug 18664] New: IssueSlip.t is failing - IssueSlip should return if params are not valid Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18664 Bug ID: 18664 Summary: IssueSlip.t is failing - IssueSlip should return if params are not valid Change sponsored?: --- Product: Koha Version: unspecified Hardware: All OS: All Status: ASSIGNED Severity: normal Priority: P5 - low Component: Architecture, internals, and plumbing Assignee: jonathan.druart at bugs.koha-community.org Reporter: jonathan.druart at bugs.koha-community.org QA Contact: testopia at bugs.koha-community.org Depends on: 17762 Problem raised by bug 17762: IssueSlip should return if the params are not valid. The tests contain 2 FIXME to highlight this problem already, it's time to fix them. Note that, theoretically, this change may produce software error. Indeed the caller expecting a hashref (letter) will access the "content" key. But that should not happen. Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17762 [Bug 17762] Ability to translate notices -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue May 23 21:34:17 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 23 May 2017 19:34:17 +0000 Subject: [Koha-bugs] [Bug 18664] IssueSlip.t is failing - IssueSlip should return if params are not valid In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18664 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue May 23 21:34:22 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 23 May 2017 19:34:22 +0000 Subject: [Koha-bugs] [Bug 18664] IssueSlip.t is failing - IssueSlip should return if params are not valid In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18664 --- Comment #1 from Jonathan Druart --- Created attachment 63673 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=63673&action=edit Bug 18664: Make IssueSlip returns if params are not valid Problem raised by bug 17762: IssueSlip should return if the params are not valid. The tests contain 2 FIXME to highlight this problem already, it's time to fix them. Note that, theoretically, this change may produce software error. Indeed the caller expecting a hashref (letter) will access the "content" key. But that should not happen. Test plan: Tests must return green -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue May 23 21:48:31 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 23 May 2017 19:48:31 +0000 Subject: [Koha-bugs] [Bug 12608] Replace use of DBI with DBIx::Class throughout Koha In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12608 Josef Moravec changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |josef.moravec at gmail.com Status|BLOCKED |CLOSED Resolution|--- |WONTFIX --- Comment #1 from Josef Moravec --- As we are using Koha::Object(s) now, this is not needed now. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue May 23 21:55:15 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 23 May 2017 19:55:15 +0000 Subject: [Koha-bugs] [Bug 11481] new reservation syspref HoldOnlyWhenAllItemsOnLoan In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11481 Josef Moravec changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |josef.moravec at gmail.com Resolution|--- |WORKSFORME Status|BLOCKED |CLOSED --- Comment #10 from Josef Moravec --- We have this functionality - it can be set up on circulation rules page -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue May 23 21:55:16 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 23 May 2017 19:55:16 +0000 Subject: [Koha-bugs] [Bug 11482] new reservation syspref PickupHoldOnlyFromItemBranches In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11482 Bug 11482 depends on bug 11481, which changed state. Bug 11481 Summary: new reservation syspref HoldOnlyWhenAllItemsOnLoan https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11481 What |Removed |Added ---------------------------------------------------------------------------- Status|BLOCKED |CLOSED Resolution|--- |WORKSFORME -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue May 23 22:05:18 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 23 May 2017 20:05:18 +0000 Subject: [Koha-bugs] [Bug 18226] Remove "use Test::DBIx::Class" instantiations' dangerous code duplication In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18226 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Failed QA --- Comment #18 from Jonathan Druart --- The comparaison $libCount = Koha::Libraries->search->count does not work when there is no libraries defined (0 vs undef) prove t/db_dependent/01-test_dbic.t t/db_dependent/01-test_dbic.t .. # Failed test ' When the libraries are counted' # at t/db_dependent/01-test_dbic.t line 41. # Looks like you failed 1 test of 19. t/db_dependent/01-test_dbic.t .. 1/? # Failed test 'Scenario: Show how caching prevents Test::DBIx::Class from working properly and how to circumvent it' # at t/db_dependent/01-test_dbic.t line 95. # Looks like you failed 1 test of 1. t/db_dependent/01-test_dbic.t .. Dubious, test returned 1 (wstat 256, 0x100) Failed 1/1 subtests Test Summary Report ------------------- t/db_dependent/01-test_dbic.t (Wstat: 256 Tests: 1 Failed: 1) Failed test: 1 Non-zero exit status: 1 Files=1, Tests=1, 3 wallclock secs ( 0.02 usr 0.02 sys + 2.09 cusr 0.88 csys = 3.01 CPU) Result: FAIL You should also use is instead of ok and follow the coding guidelines of the project (camel_case for instance), please... $verbose should be removed -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue May 23 22:06:15 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 23 May 2017 20:06:15 +0000 Subject: [Koha-bugs] [Bug 17717] process_message_queue.pl: Can't locate Authen/CAS/Client/ Response/Failure.pm In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17717 --- Comment #17 from Chris Cormack --- I am working on replacing this module with one that supports CAS 2.0 and doesnt have this problem. It won't obviously be ready in time though. So I will write a patch to add the cd /tmp && and attach it to here. Should be ready soon -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue May 23 22:06:25 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 23 May 2017 20:06:25 +0000 Subject: [Koha-bugs] [Bug 18289] Fix t/Prices.t having a Test::DBIx::Class cache issue In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18289 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |jonathan.druart at bugs.koha-c | |ommunity.org --- Comment #3 from Jonathan Druart --- I confirm that this fixes the tests on jenkins. diff --git a/Koha/Database.pm b/Koha/Database.pm index df259c5..f8a2fba 100644 --- a/Koha/Database.pm +++ b/Koha/Database.pm @@ -215,6 +215,11 @@ sub restore_schema { # return something, then this function should, too. } +sub flush_schema_cache { + delete $database->{schema}; + return 1; +} + =head2 EXPORT None by default. diff --git a/t/Prices.t b/t/Prices.t index f89c7f6..68dc788 100644 --- a/t/Prices.t +++ b/t/Prices.t @@ -29,6 +29,7 @@ use Test::DBIx::Class { my $db = Test::MockModule->new('Koha::Database'); $db->mock( _new_schema => sub { return Schema(); } ); +Koha::Database::flush_schema_cache(); fixtures_ok [ Currency => [ -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue May 23 22:11:54 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 23 May 2017 20:11:54 +0000 Subject: [Koha-bugs] [Bug 18478] Some notices sent via SMS gateway fail In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18478 Nick Clemens changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |Signed Off -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue May 23 22:11:56 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 23 May 2017 20:11:56 +0000 Subject: [Koha-bugs] [Bug 18478] Some notices sent via SMS gateway fail In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18478 --- Comment #11 from Nick Clemens --- Created attachment 63674 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=63674&action=edit Bug 18478 - QA Followup Make sure to build necessary letters -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue May 23 22:14:32 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 23 May 2017 20:14:32 +0000 Subject: [Koha-bugs] [Bug 18478] Some notices sent via SMS gateway fail In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18478 Nick Clemens changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #63674|0 |1 is obsolete| | --- Comment #12 from Nick Clemens --- Created attachment 63675 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=63675&action=edit Bug 18478 - QA Followup Make sure to build necessary letters Fix awkward construction -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue May 23 22:15:20 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 23 May 2017 20:15:20 +0000 Subject: [Koha-bugs] [Bug 18478] Some notices sent via SMS gateway fail In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18478 --- Comment #13 from Nick Clemens --- (In reply to Jonathan Druart from comment #10) > The call to _update_message_to_address just before _send_message_by_email > should not be needed, it is already called from _send_message_by_email. I think it is only called there is the address was blank, we are fixing it before that call so need to update -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue May 23 22:16:11 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 23 May 2017 20:16:11 +0000 Subject: [Koha-bugs] [Bug 17898] Add a way to automatically convert SQL reports In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17898 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Text to go in the|Bug 17196 move the marcxml |Bug 17196 moved the column release notes|out of the biblioitems |marcxml out of the |table. |biblioitems table and into |That breaks SQL |a separate one. |reports using it. When you |That will |go into report list page |break any SQL reports using |(/reports/guided_reports.pl |marcxml, but in order to |?phase=Use saved), |make it easy to fix them, a |reports |new column with a warning |using biblioitems.marcxml |has been added to the Saved |have a new column |reports page |warning |(/reports/guided_reports.pl |you that it is obsolete. |?phase=Use saved). There is |There is an update link |also an update link that |that help you to modify the |will help to modify the SQL |SQL query. |query. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue May 23 22:17:18 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 23 May 2017 20:17:18 +0000 Subject: [Koha-bugs] [Bug 17717] process_message_queue.pl: Can't locate Authen/CAS/Client/ Response/Failure.pm In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17717 --- Comment #18 from Chris Cormack --- (In reply to Larry Baerveldt from comment #14) > Just a FYI on this. I found that *not* using koha-foreach, and instead use > the actual koha instance user also works. > > For example, instead of: > root koha-foreach --enabled --email > /usr/share/koha/bin/cronjobs/process_message_queue.pl > > if you use: > INST-koha /usr/share/koha/bin/cronjobs/process_message_queue.pl > > it works. > > So taking a look at how koha-foreach switches to the user might provide some > clues. > > Can confirm this also happens on Debian 8.4. Yep thats because you are running the script as root then. Root has permission to write in that dir. With for-each you are running as the user, it doesn't. However the real problem is this module. Which we need to replace, the workaround should hold for then -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue May 23 22:29:05 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 23 May 2017 20:29:05 +0000 Subject: [Koha-bugs] [Bug 17717] process_message_queue.pl: Can't locate Authen/CAS/Client/ Response/Failure.pm In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17717 Chris Cormack changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue May 23 22:28:52 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 23 May 2017 20:28:52 +0000 Subject: [Koha-bugs] [Bug 18664] IssueSlip.t is failing - IssueSlip should return if params are not valid In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18664 Mason James changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |mtj at kohaaloha.com -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue May 23 22:29:10 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 23 May 2017 20:29:10 +0000 Subject: [Koha-bugs] [Bug 17717] process_message_queue.pl: Can't locate Authen/CAS/Client/ Response/Failure.pm In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17717 --- Comment #19 from Chris Cormack --- Created attachment 63676 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=63676&action=edit Bug 17717 : Work around for the permissions problem when running process_message_queue To test 1/ Make sure some things are in the message queue 2/ Run the cron jobs, notice nothing is sent 3/ Build and install a new package (or manually update the /etc/cron.d/koha-common file) 4/ Run the jobs again, notice mail is sent -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue May 23 22:29:24 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 23 May 2017 20:29:24 +0000 Subject: [Koha-bugs] [Bug 17717] process_message_queue.pl: Can't locate Authen/CAS/Client/ Response/Failure.pm In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17717 Mason James changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |mtj at kohaaloha.com -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue May 23 22:32:09 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 23 May 2017 20:32:09 +0000 Subject: [Koha-bugs] [Bug 18233] t/db_dependent/00-strict.t has non-existant resetversion.pl In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18233 Mason James changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |mtj at kohaaloha.com -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue May 23 22:32:17 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 23 May 2017 20:32:17 +0000 Subject: [Koha-bugs] [Bug 18494] Fix Letters.t (follow-up of 15702) In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18494 Mason James changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |mtj at kohaaloha.com -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue May 23 22:32:27 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 23 May 2017 20:32:27 +0000 Subject: [Koha-bugs] [Bug 17108] Automatic debian/control updates (stable) In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17108 Mason James changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |mtj at kohaaloha.com -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue May 23 22:32:45 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 23 May 2017 20:32:45 +0000 Subject: [Koha-bugs] [Bug 17665] SIP2 Item Information Response returns incorrect circulation status of ' 08' ( waiting on hold shelf ) if record has any holds In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17665 Mason James changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |mtj at kohaaloha.com -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue May 23 22:32:51 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 23 May 2017 20:32:51 +0000 Subject: [Koha-bugs] [Bug 16515] Did you mean? links don't wrap on smaller screens In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16515 Mason James changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |mtj at kohaaloha.com -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue May 23 22:33:21 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 23 May 2017 20:33:21 +0000 Subject: [Koha-bugs] [Bug 17257] Cannot create a patron under MySQL 5.7 In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17257 Mason James changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |mtj at kohaaloha.com -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue May 23 22:33:11 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 23 May 2017 20:33:11 +0000 Subject: [Koha-bugs] [Bug 18632] CGI::param called in list context flooding erro logs In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18632 Mason James changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |mtj at kohaaloha.com -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue May 23 22:33:53 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 23 May 2017 20:33:53 +0000 Subject: [Koha-bugs] [Bug 17898] Add a way to automatically convert SQL reports In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17898 Mason James changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |mtj at kohaaloha.com -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue May 23 22:33:36 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 23 May 2017 20:33:36 +0000 Subject: [Koha-bugs] [Bug 18647] Internal server error on moremember.pl In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18647 Mason James changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |mtj at kohaaloha.com -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue May 23 22:34:23 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 23 May 2017 20:34:23 +0000 Subject: [Koha-bugs] [Bug 18662] Can not delete currencies In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18662 Mason James changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |mtj at kohaaloha.com -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue May 23 22:59:15 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 23 May 2017 20:59:15 +0000 Subject: [Koha-bugs] [Bug 17717] process_message_queue.pl: Can't locate Authen/CAS/Client/ Response/Failure.pm In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17717 Josef Moravec changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue May 23 22:59:19 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 23 May 2017 20:59:19 +0000 Subject: [Koha-bugs] [Bug 17717] process_message_queue.pl: Can't locate Authen/CAS/Client/ Response/Failure.pm In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17717 Josef Moravec changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #63676|0 |1 is obsolete| | --- Comment #20 from Josef Moravec --- Created attachment 63677 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=63677&action=edit [SIGNED-OFF] Bug 17717 : Work around for the permissions problem when running process_message_queue To test 1/ Make sure some things are in the message queue 2/ Run the cron jobs, notice nothing is sent 3/ Build and install a new package (or manually update the /etc/cron.d/koha-common file) 4/ Run the jobs again, notice mail is sent Signed-off-by: Josef Moravec -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue May 23 23:04:46 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 23 May 2017 21:04:46 +0000 Subject: [Koha-bugs] [Bug 18663] Missing db update for ExportRemoveFields In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18663 Josef Moravec changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue May 23 23:04:49 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 23 May 2017 21:04:49 +0000 Subject: [Koha-bugs] [Bug 18663] Missing db update for ExportRemoveFields In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18663 Josef Moravec changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #63672|0 |1 is obsolete| | --- Comment #3 from Josef Moravec --- Created attachment 63678 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=63678&action=edit [SIGNED-OFF] Bug 18663: Add pref ExportRemoveFields if missing Signed-off-by: Josef Moravec -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed May 24 01:23:46 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 23 May 2017 23:23:46 +0000 Subject: [Koha-bugs] [Bug 18435] Message about Materials specified does not display when items are checked out and checked in In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18435 Mason James changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |mtj at kohaaloha.com --- Comment #6 from Mason James --- Blocked by Enhancement (bz15799), skipping for 16.05.x -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed May 24 01:28:44 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 23 May 2017 23:28:44 +0000 Subject: [Koha-bugs] [Bug 18466] No article requests breaks the opac-user-views block In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18466 Mason James changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |mtj at kohaaloha.com --- Comment #8 from Mason James --- Blocked by Enhancement (bz14610), skipping for 16.05.x -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed May 24 01:36:41 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 23 May 2017 23:36:41 +0000 Subject: [Koha-bugs] [Bug 17916] "Delete MARC modification template" fails to actually delete it In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17916 Mason James changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |mtj at kohaaloha.com --- Comment #8 from Mason James --- > As of 16.11.00 on Ubuntu 14.04, attempting to delete a MARC modification > template (Tools > MARC Modification templates) does not work. A change to > the MARC modification template interface was noted in the upgrade to 16.11.x > from 16.05.x, where the functionality did work correctly (as it had in any > release used since 3.18) skipping for 16.05.x series -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed May 24 02:15:44 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 24 May 2017 00:15:44 +0000 Subject: [Koha-bugs] [Bug 18471] Receiving order with unitprice greater than 1000 processing incorrectly In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18471 Mason James changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |mtj at kohaaloha.com --- Comment #15 from Mason James --- > Yes it is required for 16.11 - I'll rebase the patch hi Folks, does this problem exist in 16.05.x? -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed May 24 02:16:26 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 24 May 2017 00:16:26 +0000 Subject: [Koha-bugs] [Bug 18500] Price error display In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18500 Mason James changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |mtj at kohaaloha.com --- Comment #3 from Mason James --- (In reply to Carlos C?rdova from comment #0) > Hello > > I have installed koha 16.11.06 on a debian 8 server and the problem I have > is that on the invoice the amount is not correctly listed for example 10,000 > but only shows 10 > hi Folks, does this problem exist in 16.05.x? -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Wed May 24 02:30:37 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 24 May 2017 00:30:37 +0000 Subject: [Koha-bugs] [Bug 18623] Send notification on creation of manual invoice In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18623 Lisette changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |lisetteslatah at gmail.com -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed May 24 02:50:09 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 24 May 2017 00:50:09 +0000 Subject: [Koha-bugs] [Bug 11360] Disable barcode field and submit button when a hold is found In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11360 Mason James changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |mtj at kohaaloha.com --- Comment #64 from Mason James --- Enhancement, skipping for 16.05.x -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed May 24 02:57:08 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 24 May 2017 00:57:08 +0000 Subject: [Koha-bugs] [Bug 14757] Allow the use of Template Toolkit syntax for slips and notices In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14757 Mason James changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |mtj at kohaaloha.com --- Comment #63 from Mason James --- (In reply to Kyle M Hall from comment #55) > Pushed to master for 16.11! Enhancement, skipping for 16.05.x -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed May 24 02:58:08 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 24 May 2017 00:58:08 +0000 Subject: [Koha-bugs] [Bug 16942] Confirm hold results in ugly error In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16942 Mason James changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |mtj at kohaaloha.com --- Comment #20 from Mason James --- (In reply to Kyle M Hall from comment #18) > Pushed to master for Koha 16.11! Blocked by Enhancement (bz14757), skipping for 16.05.x -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed May 24 02:59:22 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 24 May 2017 00:59:22 +0000 Subject: [Koha-bugs] [Bug 18438] Check in: Modal about holds hides important check in messages In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18438 Mason James changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |mtj at kohaaloha.com --- Comment #31 from Mason James --- (In reply to Katrin Fischer from comment #30) > This patch has been pushed to 16.11.x and will be in 16.11.08. Blocked by Enhancement (bz11360), skipping for 16.05.x -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed May 24 03:17:50 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 24 May 2017 01:17:50 +0000 Subject: [Koha-bugs] [Bug 15758] Move the C4::Branch related code to Koha::Libraries - part 4 In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15758 --- Comment #132 from Mason James --- (In reply to Jonathan Druart from comment #131) > (In reply to Mason James from comment #130) > > (In reply to Kyle M Hall from comment #128) > > > Pushed to master for 16.11, thanks Jonathan, Marcel! > > > > hi there.. > > this patchset seems to cause the t/00-load.t test to fail? > > % prove t/00-load.t > .. > Result: PASS > thanks Jonathan, I confirm it's working now too (ps: I think I forgot to export my dev $PERL5LIB previously) -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed May 24 03:18:31 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 24 May 2017 01:18:31 +0000 Subject: [Koha-bugs] [Bug 15758] Move the C4::Branch related code to Koha::Libraries - part 4 In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15758 --- Comment #133 from Mason James --- (In reply to Kyle M Hall from comment #128) > Pushed to master for 16.11, thanks Jonathan, Marcel! Enhancement, skipping for 16.05.x -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed May 24 03:36:16 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 24 May 2017 01:36:16 +0000 Subject: [Koha-bugs] [Bug 18534] When IndependentBranches is enabled the pickup location displayed incorrectly on request.pl In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18534 Mason James changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |mtj at kohaaloha.com --- Comment #7 from Mason James --- Blocked by Enhancement, skipping for 16.05.x -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed May 24 04:02:45 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 24 May 2017 02:02:45 +0000 Subject: [Koha-bugs] [Bug 14608] HEA : add possibility of sharing usage statistics in Administration page In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14608 Mason James changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |mtj at kohaaloha.com --- Comment #61 from Mason James --- Pushed to 16.05.x, for 16.05.13 release -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed May 24 04:03:13 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 24 May 2017 02:03:13 +0000 Subject: [Koha-bugs] [Bug 18066] Hea - Version 2 In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18066 Mason James changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |mtj at kohaaloha.com --- Comment #55 from Mason James --- Pushed to 16.05.x, for 16.05.13 release -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed May 24 04:04:35 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 24 May 2017 02:04:35 +0000 Subject: [Koha-bugs] [Bug 18457] process_message_queue.pl will die if a patron has no sms_provider_id set but sms via email is enabled for that patron In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18457 Mason James changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |mtj at kohaaloha.com --- Comment #8 from Mason James --- Pushed to 16.05.x, for 16.05.13 release -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed May 24 04:05:04 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 24 May 2017 02:05:04 +0000 Subject: [Koha-bugs] [Bug 15702] Trim whitespace from patron details upon submission In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15702 Mason James changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |mtj at kohaaloha.com --- Comment #21 from Mason James --- Pushed to 16.05.x, for 16.05.13 release -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed May 24 04:07:12 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 24 May 2017 02:07:12 +0000 Subject: [Koha-bugs] [Bug 15815] Improve wording in popup warning when deleting patron from patron-batch In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15815 Mason James changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |mtj at kohaaloha.com --- Comment #7 from Mason James --- (In reply to Katrin Fischer from comment #6) > This patch has been pushed to 16.11.x and will be in 16.11.08. > > Wording change - tiny enough for backporting :) ditto ^ :0) Pushed to 16.05.x, for 16.05.13 release -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed May 24 04:07:45 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 24 May 2017 02:07:45 +0000 Subject: [Koha-bugs] [Bug 18452] Should say 'URL' instead of 'url' in catalog detail In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18452 Mason James changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |mtj at kohaaloha.com --- Comment #6 from Mason James --- Pushed to 16.05.x, for 16.05.13 release -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed May 24 04:08:04 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 24 May 2017 02:08:04 +0000 Subject: [Koha-bugs] [Bug 15738] Summary page says item has no fines, but Fines tab says otherwise In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15738 Mason James changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |mtj at kohaaloha.com --- Comment #15 from Mason James --- Pushed to 16.05.x, for 16.05.13 release -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed May 24 04:09:16 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 24 May 2017 02:09:16 +0000 Subject: [Koha-bugs] [Bug 18419] Broken patron-blank image in viewlog.tt In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18419 Mason James changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |mtj at kohaaloha.com --- Comment #9 from Mason James --- Pushed to 16.05.x, for 16.05.13 release -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed May 24 04:09:38 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 24 May 2017 02:09:38 +0000 Subject: [Koha-bugs] [Bug 13835] Popup with searches: results hidden by language menu in footer In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13835 Mason James changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |mtj at kohaaloha.com --- Comment #11 from Mason James --- Pushed to 16.05.x, for 16.05.13 release -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed May 24 04:10:03 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 24 May 2017 02:10:03 +0000 Subject: [Koha-bugs] [Bug 18484] opac-advsearch.tt missing closing div tag for .container-fluid In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18484 Mason James changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |mtj at kohaaloha.com --- Comment #7 from Mason James --- Pushed to 16.05.x, for 16.05.13 release -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed May 24 04:10:26 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 24 May 2017 02:10:26 +0000 Subject: [Koha-bugs] [Bug 18442] Permission error when logging into staff interface as db user In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18442 --- Comment #28 from Mason James --- Pushed to 16.05.x, for 16.05.13 release -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed May 24 04:10:49 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 24 May 2017 02:10:49 +0000 Subject: [Koha-bugs] [Bug 18152] UNIMARC bib records imported with invalid 'a' char in label pos.9 In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18152 Mason James changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |mtj at kohaaloha.com --- Comment #28 from Mason James --- Pushed to 16.05.x, for 16.05.13 release -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed May 24 04:12:15 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 24 May 2017 02:12:15 +0000 Subject: [Koha-bugs] [Bug 7550] Self checkout: limit display of patron image to logged-in patron In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7550 Mason James changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |mtj at kohaaloha.com --- Comment #31 from Mason James --- Pushed to 16.05.x, for 16.05.13 release -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed May 24 04:12:58 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 24 May 2017 02:12:58 +0000 Subject: [Koha-bugs] [Bug 17993] Do not use modal authentication with CAS In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17993 Mason James changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |mtj at kohaaloha.com --- Comment #15 from Mason James --- Pushed to 16.05.x, for 16.05.13 release -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed May 24 04:13:19 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 24 May 2017 02:13:19 +0000 Subject: [Koha-bugs] [Bug 18415] Advanced Editor - Rancor - return focus to editor after successful macro In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18415 Mason James changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |mtj at kohaaloha.com --- Comment #6 from Mason James --- Pushed to 16.05.x, for 16.05.13 release -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed May 24 04:16:33 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 24 May 2017 02:16:33 +0000 Subject: [Koha-bugs] [Bug 9021] Add SMS via email as an alternative to SMS services via SMS:: Send drivers In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9021 Mason James changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |mtj at kohaaloha.com --- Comment #117 from Mason James --- (In reply to Kyle M Hall from comment #116) > Pushed to Master - Should be in the May 2016 3.24 release! Enhancement, skipping for 16.05.x -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed May 24 04:19:41 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 24 May 2017 02:19:41 +0000 Subject: [Koha-bugs] [Bug 9021] Add SMS via email as an alternative to SMS services via SMS:: Send drivers In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9021 --- Comment #118 from Mason James --- (In reply to Mason James from comment #117) > (In reply to Kyle M Hall from comment #116) > > Pushed to Master - Should be in the May 2016 3.24 release! > > Enhancement, skipping for 16.05.x oups, patchset is already added to 16.5.x :0) -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed May 24 04:24:49 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 24 May 2017 02:24:49 +0000 Subject: [Koha-bugs] [Bug 17190] Mark REST API dependencies as mandatory in PerlDependencies.pm In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17190 Mason James changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |mtj at kohaaloha.com --- Comment #8 from Mason James --- Blocked by Enhancement, skipping for 16.05.x -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed May 24 04:27:58 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 24 May 2017 02:27:58 +0000 Subject: [Koha-bugs] [Bug 17812] Return focus to barcode field after toggling on-site checkouts In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17812 Mason James changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |mtj at kohaaloha.com --- Comment #11 from Mason James --- Pushed to 16.05.x, for 16.05.13 release -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed May 24 04:28:30 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 24 May 2017 02:28:30 +0000 Subject: [Koha-bugs] [Bug 18233] t/db_dependent/00-strict.t has non-existant resetversion.pl In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18233 --- Comment #7 from Mason James --- Pushed to 16.05.x, for 16.05.13 release -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed May 24 04:29:26 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 24 May 2017 02:29:26 +0000 Subject: [Koha-bugs] [Bug 18494] Fix Letters.t (follow-up of 15702) In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18494 --- Comment #18 from Mason James --- Pushed to 16.05.x, for 16.05.13 release -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed May 24 04:30:27 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 24 May 2017 02:30:27 +0000 Subject: [Koha-bugs] [Bug 18505] OPAC Search History page does not respect OpacPublic syspref In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18505 Mason James changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |mtj at kohaaloha.com --- Comment #13 from Mason James --- Pushed to 16.05.x, for 16.05.13 release -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed May 24 04:33:57 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 24 May 2017 02:33:57 +0000 Subject: [Koha-bugs] [Bug 16758] Caching issues in scripts running in daemon mode In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16758 Mason James changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |mtj at kohaaloha.com --- Comment #19 from Mason James --- Pushed to 16.05.x, for 16.05.13 release -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed May 24 04:34:57 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 24 May 2017 02:34:57 +0000 Subject: [Koha-bugs] [Bug 18525] Can't create order line from accepted suggestion In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18525 Mason James changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |mtj at kohaaloha.com --- Comment #7 from Mason James --- Pushed to 16.05.x, for 16.05.13 release -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed May 24 04:35:19 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 24 May 2017 02:35:19 +0000 Subject: [Koha-bugs] [Bug 4460] Amazon' s AssociateID tag not used in links so referred revenue lost In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=4460 --- Comment #41 from Mason James --- Pushed to 16.05.x, for 16.05.13 release -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed May 24 04:35:56 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 24 May 2017 02:35:56 +0000 Subject: [Koha-bugs] [Bug 18535] Clicking 'edit printer profile' in label creator causes software error In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18535 Mason James changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |mtj at kohaaloha.com --- Comment #7 from Mason James --- Pushed to 16.05.x, for 16.05.13 release -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed May 24 04:36:17 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 24 May 2017 02:36:17 +0000 Subject: [Koha-bugs] [Bug 18340] Progress bar length is wrong In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18340 Mason James changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |mtj at kohaaloha.com --- Comment #7 from Mason James --- Pushed to 16.05.x, for 16.05.13 release -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed May 24 04:36:54 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 24 May 2017 02:36:54 +0000 Subject: [Koha-bugs] [Bug 18370] Columns settings patrons>id=memberresultst : display bug In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18370 Mason James changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |mtj at kohaaloha.com --- Comment #17 from Mason James --- Pushed to 16.05.x, for 16.05.13 release -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed May 24 04:38:08 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 24 May 2017 02:38:08 +0000 Subject: [Koha-bugs] [Bug 18444] Add TalkingTechItivaPhoneNotification to sysprefs.sql In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18444 Mason James changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |mtj at kohaaloha.com --- Comment #10 from Mason James --- Pushed to 16.05.x, for 16.05.13 release -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed May 24 04:38:29 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 24 May 2017 02:38:29 +0000 Subject: [Koha-bugs] [Bug 17257] Cannot create a patron under MySQL 5.7 In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17257 --- Comment #14 from Mason James --- Pushed to 16.05.x, for 16.05.13 release -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed May 24 04:38:49 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 24 May 2017 02:38:49 +0000 Subject: [Koha-bugs] [Bug 18383] items.onloan schema comment seems to be incorrect. In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18383 Mason James changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |mtj at kohaaloha.com --- Comment #7 from Mason James --- Pushed to 16.05.x, for 16.05.13 release -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed May 24 04:39:16 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 24 May 2017 02:39:16 +0000 Subject: [Koha-bugs] [Bug 16515] Did you mean? links don't wrap on smaller screens In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16515 --- Comment #15 from Mason James --- Pushed to 16.05.x, for 16.05.13 release -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed May 24 04:39:36 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 24 May 2017 02:39:36 +0000 Subject: [Koha-bugs] [Bug 18504] Amount owed on fines tab should be formatted as price if < 10 or credit In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18504 Mason James changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |mtj at kohaaloha.com --- Comment #7 from Mason James --- Pushed to 16.05.x, for 16.05.13 release -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed May 24 04:40:15 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 24 May 2017 02:40:15 +0000 Subject: [Koha-bugs] [Bug 17936] Search bar not aligned on right in small screen sizes In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17936 Mason James changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |mtj at kohaaloha.com --- Comment #10 from Mason James --- Pushed to 16.05.x, for 16.05.13 release -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed May 24 04:39:57 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 24 May 2017 02:39:57 +0000 Subject: [Koha-bugs] [Bug 17925] Disable debugging in reports/bor_issues_top.pl In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17925 --- Comment #10 from Mason James --- Pushed to 16.05.x, for 16.05.13 release -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed May 24 04:40:50 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 24 May 2017 02:40:50 +0000 Subject: [Koha-bugs] [Bug 17618] perl-modules Debian package name change In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17618 Mason James changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |mtj at kohaaloha.com --- Comment #12 from Mason James --- Pushed to 16.05.x, for 16.05.13 release -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed May 24 05:06:12 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 24 May 2017 03:06:12 +0000 Subject: [Koha-bugs] [Bug 16733] More flexible paths in debian scripts (for dev installs) In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16733 --- Comment #47 from Mason James --- Enhancement, skipping for 16.05.x -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed May 24 05:06:39 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 24 May 2017 03:06:39 +0000 Subject: [Koha-bugs] [Bug 16749] Additional fixes for debian scripts In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16749 --- Comment #69 from Mason James --- Blocked by Enhancement, skipping for 16.05.x -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed May 24 05:06:56 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 24 May 2017 03:06:56 +0000 Subject: [Koha-bugs] [Bug 18502] koha-shell broken on dev installs In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18502 Mason James changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |mtj at kohaaloha.com --- Comment #8 from Mason James --- Blocked by Enhancement, skipping for 16.05.x -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed May 24 05:10:22 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 24 May 2017 03:10:22 +0000 Subject: [Koha-bugs] [Bug 14625] LDAP: mapped ExtendedPatronAttributes cause error when updated on authentication In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14625 --- Comment #20 from Mason James --- Pushed to 16.05.x, for 16.05.13 release -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed May 24 05:10:48 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 24 May 2017 03:10:48 +0000 Subject: [Koha-bugs] [Bug 18376] authority framework creation fails under Plack In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18376 --- Comment #13 from Mason James --- Pushed to 16.05.x, for 16.05.13 release -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed May 24 05:12:17 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 24 May 2017 03:12:17 +0000 Subject: [Koha-bugs] [Bug 16568] Talking Tech generates phone notifications for all overdue actions In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16568 Mason James changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |mtj at kohaaloha.com --- Comment #9 from Mason James --- Pushed to 16.05.x, for 16.05.13 release -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed May 24 05:14:01 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 24 May 2017 03:14:01 +0000 Subject: [Koha-bugs] [Bug 3534] Patron quick add form In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=3534 Mason James changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |mtj at kohaaloha.com --- Comment #65 from Mason James --- New feature, skipping for 16.05.x -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed May 24 05:14:15 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 24 May 2017 03:14:15 +0000 Subject: [Koha-bugs] [Bug 18597] Quick add form does not transfer patron attributes values when switching forms /saving In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18597 Mason James changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |mtj at kohaaloha.com --- Comment #9 from Mason James --- Blocked by new feature, skipping for 16.05.x -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed May 24 05:14:47 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 24 May 2017 03:14:47 +0000 Subject: [Koha-bugs] [Bug 18536] Generating CSV using profile in serials late issues doesn' t work as described In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18536 Mason James changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |mtj at kohaaloha.com --- Comment #9 from Mason James --- Pushed to 16.05.x, for 16.05.13 release -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed May 24 05:15:13 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 24 May 2017 03:15:13 +0000 Subject: [Koha-bugs] [Bug 18578] Use subdirectory in / tmp for session storage during installation In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18578 Mason James changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |mtj at kohaaloha.com --- Comment #8 from Mason James --- Pushed to 16.05.x, for 16.05.13 release -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed May 24 05:16:51 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 24 May 2017 03:16:51 +0000 Subject: [Koha-bugs] [Bug 18551] Hide with CSS dynamic elements in member search In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18551 Mason James changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |mtj at kohaaloha.com --- Comment #22 from Mason James --- Pushed to 16.05.x, for 16.05.13 release -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed May 24 06:18:47 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 24 May 2017 04:18:47 +0000 Subject: [Koha-bugs] [Bug 18629] Web installer 17.05 not properly translatable In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18629 Marc V?ron changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |ASSIGNED --- Comment #4 from Marc V?ron --- Found some more issues... -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed May 24 07:38:15 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 24 May 2017 05:38:15 +0000 Subject: [Koha-bugs] [Bug 5395] C4::Acquisition::SearchOrder POD inconsistent with function In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5395 M. Tompsett changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |mtompset at hotmail.com --- Comment #3 from M. Tompsett --- (In reply to Marc V?ron from comment #2) > Still valid? Yes. Function has notably changed, but there are still missing parameters in the perldoc. -- You are receiving this mail because: You are watching all bug changes. You are the QA Contact for the bug. From bugzilla-daemon at bugs.koha-community.org Wed May 24 07:40:17 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 24 May 2017 05:40:17 +0000 Subject: [Koha-bugs] [Bug 14537] Rename system preference 'OverdueNoticeBcc' to 'NoticeBcc' In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14537 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Text to go in the|The system preference |The system preference release notes|'OverdueNoticeBcc' seems, |'OverdueNoticeBcc' is |by its name, to imply that |renamed to 'NoticeBcc' as |a BCC will be added to all |it does not only apply to |overdue notices. The |overdue notices, but to |description says that the |notices in general. |address will be added to | |all notices. The behavior | |of the system follows the | |description, not the system | |preference name. The system | |preference is re-named to | |NoticeBcc. | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed May 24 07:42:55 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 24 May 2017 05:42:55 +0000 Subject: [Koha-bugs] [Bug 18242] Move of checkouts to old_issues is not handled correctly In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18242 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Summary|Move of checkouts to |Move of checkouts to |old_issues is not handle |old_issues is not handled |correctly |correctly -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed May 24 07:43:58 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 24 May 2017 05:43:58 +0000 Subject: [Koha-bugs] [Bug 18647] Internal server error on moremember.pl In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18647 Marcel de Rooy changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA --- Comment #15 from Marcel de Rooy --- (In reply to Jonathan Druart from comment #14) > Signed-off-by: Jonathan Druart Thanks. Changing status. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed May 24 07:50:05 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 24 May 2017 05:50:05 +0000 Subject: [Koha-bugs] [Bug 18629] Web installer 17.05 not properly translatable In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18629 Marc V?ron changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #63573|0 |1 is obsolete| | --- Comment #5 from Marc V?ron --- Created attachment 63679 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=63679&action=edit Bug 18629 - Web installer 17.05 not properly translatable Fix for step1.tt To test: - Create po files - Verify that title and button text are picked by translator and appear in po file - Verify that text in po files is not fragmented Work in progress. Comments welcome. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Wed May 24 07:50:42 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 24 May 2017 05:50:42 +0000 Subject: [Koha-bugs] [Bug 18600] Missing db update for TalkingTechItivaPhoneNotification In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18600 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Patch complexity|--- |Trivial patch Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed May 24 07:50:45 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 24 May 2017 05:50:45 +0000 Subject: [Koha-bugs] [Bug 18600] Missing db update for TalkingTechItivaPhoneNotification In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18600 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #63671|0 |1 is obsolete| | --- Comment #3 from Katrin Fischer --- Created attachment 63680 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=63680&action=edit [SIGNED-OFF] Bug 18600: Add pref TalkingTechItivaPhoneNotification if missing Signed-off-by: Katrin Fischer -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed May 24 07:51:01 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 24 May 2017 05:51:01 +0000 Subject: [Koha-bugs] [Bug 18600] Missing db update for TalkingTechItivaPhoneNotification In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18600 --- Comment #4 from Katrin Fischer --- Thx Jonathan! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed May 24 07:58:35 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 24 May 2017 05:58:35 +0000 Subject: [Koha-bugs] [Bug 5395] C4::Acquisition::SearchOrder POD inconsistent with function In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5395 M. Tompsett changed: What |Removed |Added ---------------------------------------------------------------------------- Patch complexity|--- |Small patch Status|ASSIGNED |Needs Signoff -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed May 24 07:58:37 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 24 May 2017 05:58:37 +0000 Subject: [Koha-bugs] [Bug 5395] C4::Acquisition::SearchOrder POD inconsistent with function In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5395 --- Comment #4 from M. Tompsett --- Created attachment 63681 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=63681&action=edit Bug 5395: Update C4::Acquisition::SearchOrders POD Comparing the perldoc to the function: - basketname - basketgroupname - budget_id Were missing. This adds them. Also, a description of ordernumber and search were added, as they are not self-evident by their name alone. There are no code changes, so all tests should pass or fail identically before and after patch. -- You are receiving this mail because: You are watching all bug changes. You are the QA Contact for the bug. From bugzilla-daemon at bugs.koha-community.org Wed May 24 07:59:46 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 24 May 2017 05:59:46 +0000 Subject: [Koha-bugs] [Bug 5395] C4::Acquisition::SearchOrder POD inconsistent with function In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5395 --- Comment #5 from M. Tompsett --- Comment on attachment 63681 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=63681 Bug 5395: Update C4::Acquisition::SearchOrders POD Review of attachment 63681: --> (https://bugs.koha-community.org/bugzilla3/page.cgi?id=splinter.html&bug=5395&attachment=63681) ----------------------------------------------------------------- ::: C4/Acquisition.pm @@ -1656,4 @@ > @results = &SearchOrders({ > ordernumber => $ordernumber, > search => $search, > - biblionumber => $biblionumber, Moved to match the code order of grabbing parameters, to make comparison easier. -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed May 24 07:59:55 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 24 May 2017 05:59:55 +0000 Subject: [Koha-bugs] [Bug 5395] C4::Acquisition::SearchOrder POD inconsistent with function In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5395 M. Tompsett changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|mjr at software.coop |mtompset at hotmail.com -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed May 24 08:01:01 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 24 May 2017 06:01:01 +0000 Subject: [Koha-bugs] [Bug 5395] C4::Acquisition::SearchOrder POD inconsistent with function In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5395 M. Tompsett changed: What |Removed |Added ---------------------------------------------------------------------------- Severity|enhancement |minor -- You are receiving this mail because: You are watching all bug changes. You are the QA Contact for the bug. From bugzilla-daemon at bugs.koha-community.org Wed May 24 08:02:12 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 24 May 2017 06:02:12 +0000 Subject: [Koha-bugs] [Bug 18664] IssueSlip.t is failing - IssueSlip should return if params are not valid In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18664 Josef Moravec changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed May 24 08:02:16 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 24 May 2017 06:02:16 +0000 Subject: [Koha-bugs] [Bug 18664] IssueSlip.t is failing - IssueSlip should return if params are not valid In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18664 Josef Moravec changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #63673|0 |1 is obsolete| | --- Comment #2 from Josef Moravec --- Created attachment 63682 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=63682&action=edit [SIGNED-OFF] Bug 18664: Make IssueSlip returns if params are not valid Problem raised by bug 17762: IssueSlip should return if the params are not valid. The tests contain 2 FIXME to highlight this problem already, it's time to fix them. Note that, theoretically, this change may produce software error. Indeed the caller expecting a hashref (letter) will access the "content" key. But that should not happen. Test plan: Tests must return green Signed-off-by: Josef Moravec -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed May 24 08:04:04 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 24 May 2017 06:04:04 +0000 Subject: [Koha-bugs] [Bug 17108] Automatic debian/control updates (stable) In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17108 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to Stable --- Comment #3 from Katrin Fischer --- This patch has been pushed to 16.11.x and will be in 16.11.09. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed May 24 08:04:14 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 24 May 2017 06:04:14 +0000 Subject: [Koha-bugs] [Bug 17108] Automatic debian/control updates (stable) In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17108 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to Stable |RESOLVED Resolution|--- |FIXED -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed May 24 09:26:43 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 24 May 2017 07:26:43 +0000 Subject: [Koha-bugs] [Bug 18072] Add Koha objects for Branch Transfer Limits In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18072 Josef Moravec changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed May 24 09:26:47 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 24 May 2017 07:26:47 +0000 Subject: [Koha-bugs] [Bug 18072] Add Koha objects for Branch Transfer Limits In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18072 Josef Moravec changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #60009|0 |1 is obsolete| | --- Comment #17 from Josef Moravec --- Created attachment 63683 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=63683&action=edit Bug 18072: Add Koha objects for Branch Transfer Limit This patch also fixes documentation in Koha/Item/Transfer.pm and Koha/Item/Transfers.pm. Signed-off-by: Josef Moravec -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed May 24 09:26:53 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 24 May 2017 07:26:53 +0000 Subject: [Koha-bugs] [Bug 18072] Add Koha objects for Branch Transfer Limits In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18072 Josef Moravec changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #60010|0 |1 is obsolete| | --- Comment #18 from Josef Moravec --- Created attachment 63684 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=63684&action=edit Bug 18072: Add deprecation warning to C4::Circulation Branch Transfer Limit functions Signed-off-by: Josef Moravec -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed May 24 09:26:58 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 24 May 2017 07:26:58 +0000 Subject: [Koha-bugs] [Bug 18072] Add Koha objects for Branch Transfer Limits In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18072 Josef Moravec changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #60782|0 |1 is obsolete| | --- Comment #19 from Josef Moravec --- Created attachment 63685 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=63685&action=edit Bug 18072: Add Koha::Item->can_be_transferred This patch adds a new method Koha::Item->can_be_transferred. Includes unit test. To test: 1. prove t/db_dependent/Koha/Items.t Signed-off-by: Josef Moravec -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed May 24 09:27:04 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 24 May 2017 07:27:04 +0000 Subject: [Koha-bugs] [Bug 18072] Add Koha objects for Branch Transfer Limits In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18072 Josef Moravec changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #60783|0 |1 is obsolete| | --- Comment #20 from Josef Moravec --- Created attachment 63686 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=63686&action=edit Bug 18072: (QA-follow-up) let Koha::Item->can_be_transferred take HASHref as param This patch changes Koha::Item->can_be_transferred to accept a HASHref as follows: $item->can_be_transferred({ to => $library, from => $library2 }) To test: 1. prove t/db_dependent/Koha/Items.t Signed-off-by: Josef Moravec -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed May 24 09:27:09 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 24 May 2017 07:27:09 +0000 Subject: [Koha-bugs] [Bug 18072] Add Koha objects for Branch Transfer Limits In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18072 Josef Moravec changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #60784|0 |1 is obsolete| | --- Comment #21 from Josef Moravec --- Created attachment 63687 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=63687&action=edit Bug 18072: Add Koha::Biblio->can_be_transferred This patch adds a new method Koha::Biblio->can_be_transferred. The method checks if at least one of the item of that biblio can be transferred to desired location. This method will be useful for building a smarter pickup location list for holds, because we will be able to hide those libraries to which none of the items of this biblio can be transferred to due to branch transfer limits (see Bug 7614). To test: 1. prove t/db_dependent/Koha/Biblios.t Signed-off-by: Josef Moravec -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed May 24 12:02:30 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 24 May 2017 10:02:30 +0000 Subject: [Koha-bugs] [Bug 1993] Task Scheduler Needs Re-write In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=1993 Lucy Vaux-Harvey changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |lucy.vaux-harvey at ptfs-europ | |e.com -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed May 24 12:28:16 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 24 May 2017 10:28:16 +0000 Subject: [Koha-bugs] [Bug 18471] Receiving order with unitprice greater than 1000 processing incorrectly In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18471 --- Comment #16 from Colin Campbell --- (In reply to Mason James from comment #15) > > Yes it is required for 16.11 - I'll rebase the patch > > hi Folks, does this problem exist in 16.05.x? I think not. 16.11 introduced some price formatting changes that caused a problem when amounts wth a comma were passed. I think 16.5 does the right thing -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed May 24 13:23:24 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 24 May 2017 11:23:24 +0000 Subject: [Koha-bugs] [Bug 18634] Missing empty line at end of opac.pref In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18634 --- Comment #17 from Marcel de Rooy --- (In reply to Blou from comment #16) > Created attachment 63660 [details] [review] > Translated fr-CA opac.pref Blou, When I am copying your opac.pref over my english opac.pref, and I am searching for paypal, I do find all paypal preferences, regardless of adding or removing an empty line to this file? -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed May 24 14:05:53 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 24 May 2017 12:05:53 +0000 Subject: [Koha-bugs] [Bug 18226] Remove "use Test::DBIx::Class" instantiations' dangerous code duplication In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18226 --- Comment #19 from Marcel de Rooy --- (In reply to Jonathan Druart from comment #18) > The comparaison > $libCount = Koha::Libraries->search->count > does not work when there is no libraries defined (0 vs undef) Hmm. I think it is an assignment, not an comparison. Both 0 and undef will be interpreted as false by ok. (Note that I am not the author.) -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed May 24 14:12:08 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 24 May 2017 12:12:08 +0000 Subject: [Koha-bugs] [Bug 18226] Remove "use Test::DBIx::Class" instantiations' dangerous code duplication In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18226 --- Comment #20 from Marcel de Rooy --- Created attachment 63688 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=63688&action=edit Bug 18226: [QA Follow-up] Remove further assumptions on branch count See also follow-up on bug 18286. Signed-off-by: Marcel de Rooy -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed May 24 14:18:17 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 24 May 2017 12:18:17 +0000 Subject: [Koha-bugs] [Bug 18226] Remove "use Test::DBIx::Class" instantiations' dangerous code duplication In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18226 --- Comment #21 from Marcel de Rooy --- Created attachment 63689 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=63689&action=edit Bug 18226: [QA Follow-up] Remove verbose Signed-off-by: Marcel de Rooy -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed May 24 14:21:24 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 24 May 2017 12:21:24 +0000 Subject: [Koha-bugs] [Bug 18226] Remove "use Test::DBIx::Class" instantiations' dangerous code duplication In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18226 Marcel de Rooy changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |Signed Off --- Comment #22 from Marcel de Rooy --- (In reply to Jonathan Druart from comment #18) > prove t/db_dependent/01-test_dbic.t Please try again with the follow-ups. > You should also use is instead of ok and follow the coding guidelines of the > project (camel_case for instance), please... Not sure what you exactly want here. The lines where ok now is called, are fine with me. I'd rather see ok than using 'is' for comparing with false. Please specify which names should be adjusted. > $verbose should be removed Fixed -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed May 24 14:22:11 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 24 May 2017 12:22:11 +0000 Subject: [Koha-bugs] [Bug 18634] Missing empty line at end of opac.pref In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18634 --- Comment #18 from Blou --- :( of course, I sent you the one "fixed" with the extra line before translation, so I guess the resulting one doesn't cause trouble. gimme a sec -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed May 24 14:24:00 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 24 May 2017 12:24:00 +0000 Subject: [Koha-bugs] [Bug 18634] Missing empty line at end of opac.pref In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18634 --- Comment #19 from Marcel de Rooy --- (In reply to Blou from comment #18) > :( of course, I sent you the one "fixed" with the extra line before > translation, so I guess the resulting one doesn't cause trouble. I always want the files with the problems :) -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed May 24 14:51:36 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 24 May 2017 12:51:36 +0000 Subject: [Koha-bugs] [Bug 18634] Missing empty line at end of opac.pref In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18634 Blou changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #63660|0 |1 is obsolete| | --- Comment #20 from Blou --- Created attachment 63690 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=63690&action=edit Translated fr-CA opac.pref Version that hide 'paypal' results. (I just tested again before submitting) -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed May 24 15:05:43 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 24 May 2017 13:05:43 +0000 Subject: [Koha-bugs] [Bug 18647] Internal server error on moremember.pl In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18647 --- Comment #16 from Jonathan Druart --- I was expecting someone else to QA it. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed May 24 15:11:42 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 24 May 2017 13:11:42 +0000 Subject: [Koha-bugs] [Bug 12904] Force browser to load new javascript files after upgrade In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12904 --- Comment #72 from Olli-Antti Kivilahti --- (In reply to Martin Renvoize from comment #71) > I came here to QA this, then realised I wrote a bunch of the original code > that was eventually rebased. > > This is still a great thing to have and we've been using it in production in > a few places so I'm happy it works. > > I'll try to find a friendly QAer. Just QA this plix? PM when you plan to do so. This is a big moving target and it is hard to keep it applying to master. We have a rebased version from two-three weeks ago I guess. No point in wasting time applying it here because it will just get stale. While doing that I can rebase our fork on top of master. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed May 24 15:16:43 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 24 May 2017 13:16:43 +0000 Subject: [Koha-bugs] [Bug 18647] Internal server error on moremember.pl In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18647 --- Comment #17 from Marcel de Rooy --- (In reply to Jonathan Druart from comment #16) > I was expecting someone else to QA it. Well, let Kyle have a last look now.. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed May 24 15:18:53 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 24 May 2017 13:18:53 +0000 Subject: [Koha-bugs] [Bug 18478] Some notices sent via SMS gateway fail In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18478 Jason Robb changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |jrobb at sekls.org -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed May 24 15:30:36 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 24 May 2017 13:30:36 +0000 Subject: [Koha-bugs] [Bug 18656] Require confirmation of deletion of files from patron record In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18656 Owen Leonard changed: What |Removed |Added ---------------------------------------------------------------------------- Component|Patrons |Templates Severity|enhancement |normal Assignee|koha-bugs at lists.koha-commun |oleonard at myacpl.org |ity.org | Version|16.05 |master Summary|Dialog box, 'Are you sure |Require confirmation of |you want to delete this |deletion of files from |file', on the borrower |patron record |record | -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed May 24 15:45:49 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 24 May 2017 13:45:49 +0000 Subject: [Koha-bugs] [Bug 15494] Block renewals by arbitrary item values In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15494 Nick Clemens changed: What |Removed |Added ---------------------------------------------------------------------------- Change sponsored?|Seeking cosponsors |Sponsored Summary|Make Longoverdue/Lost items |Block renewals by arbitrary |not renewable |item values CC| |nick at bywatersolutions.com Patch complexity|--- |Small patch Assignee|koha-bugs at lists.koha-commun |nick at bywatersolutions.com |ity.org | -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Wed May 24 15:52:22 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 24 May 2017 13:52:22 +0000 Subject: [Koha-bugs] [Bug 18656] Require confirmation of deletion of files from patron record In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18656 --- Comment #1 from Owen Leonard --- Created attachment 63691 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=63691&action=edit Bug 18656 - Require confirmation of deletion of files from patron record This patch adds a JavaScript confirm to the deletion of files. It also styles the file deletion link as a Bootstrap button. To test, apply the patch and open the "Files" page for a patron who has files attached. - Verify that clicking any "delete" link prompts for a confirmation. - Verify that confirming the dialog triggers the deletion of the correct file. - Verify that canceling the confirmation dialog aborts the deletion. - Confirm that the "Delete" button looks correct. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed May 24 15:52:19 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 24 May 2017 13:52:19 +0000 Subject: [Koha-bugs] [Bug 18656] Require confirmation of deletion of files from patron record In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18656 Owen Leonard changed: What |Removed |Added ---------------------------------------------------------------------------- Patch complexity|--- |Trivial patch Status|NEW |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed May 24 15:54:51 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 24 May 2017 13:54:51 +0000 Subject: [Koha-bugs] [Bug 18289] Fix t/Prices.t having a Test::DBIx::Class cache issue In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18289 Tom?s Cohen Arazi changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |tomascohen at gmail.com --- Comment #4 from Tom?s Cohen Arazi --- (In reply to Jonathan Druart from comment #3) > I confirm that this fixes the tests on jenkins. The way to reproduce this in kohadevbox (or the like) is to stop memcached before running the tests. And this patchset clearly fixes it! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed May 24 16:03:03 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 24 May 2017 14:03:03 +0000 Subject: [Koha-bugs] [Bug 18354] Adding item type attribute to cover image div In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18354 Owen Leonard changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|oleonard at myacpl.org |michael at bywatersolutions.co | |m -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed May 24 16:05:48 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 24 May 2017 14:05:48 +0000 Subject: [Koha-bugs] [Bug 18665] New: Translatability: Add tt filter to allow html tags inside tt directives Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18665 Bug ID: 18665 Summary: Translatability: Add tt filter to allow html tags inside tt directives Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: I18N/L10N Assignee: koha-bugs at lists.koha-community.org Reporter: veron at veron.ch QA Contact: testopia at bugs.koha-community.org CC: frederic at tamil.fr HTML tags inside template toolkit directives are not allowed because of translation issues. Instead of having many workaround in tt files it would be nice to have a filter that handles HTML tags. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Wed May 24 16:06:07 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 24 May 2017 14:06:07 +0000 Subject: [Koha-bugs] [Bug 18665] Translatability: Add tt filter to allow html tags inside tt directives In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18665 Marc V?ron changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|koha-bugs at lists.koha-commun |veron at veron.ch |ity.org | -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Wed May 24 16:07:10 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 24 May 2017 14:07:10 +0000 Subject: [Koha-bugs] [Bug 12904] Force browser to load new javascript files after upgrade In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12904 Kyle M Hall changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #60826|0 |1 is obsolete| | Attachment #60827|0 |1 is obsolete| | Attachment #60830|0 |1 is obsolete| | Attachment #60831|0 |1 is obsolete| | --- Comment #73 from Kyle M Hall --- Created attachment 63692 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=63692&action=edit Bug 12904 - Force browser to load new javascript files after upgrade A common issue with Koha seems to be that the web browsers continue to use cached js files after an upgrade. If we append the version as a parameter, we can force the browser to update the javascript files. 1) Apply this patch on a new branch based on master. 2) In a separate branch check out a previous version of Koha and go through the installation process on an empty database. 3) After logging into Koha, turn on Firebug's Net panel (or Chrome's Network panel) and turn on the filter for JavaScript files. 4) Clear the browser cache and navigate to a page, for instance Circulation. In Firebug the Net panel should show a status of "200 OK" for all files, indicating that the file was downloaded, not loaded from the cache. In Chrome the "size" column will show a file size if the file was downloaded. 5) Navigate to another page and confirm that scripts are being loaded from the cache: Scripts like jquery.js and jquery-ui.js which are loaded on every page should have a status in the Firebug Net panel of "304 Not Modified." In Chrome the "size" columns should show "from cache." 6) Check out the branch you created for testing this patch. 7) In order to preserve the state of your browser cache for accurate testing, open a different browser from the one you were previously testing with, load Koha, and run through the database update. 8) Return to your original testing browser and navigate to another Koha page. Firebug's Net panel should show that script files are now being downloaded with a "koha_version" query string. These files should have a status of "200 OK" indicating that they are being downloaded, not loaded from the cache. 9) Navigate to another page and conifrm that the new versions of the scripts are being loaded from the cache. To confirm that all affected JavaScripts links are working correctly, test these pages by checking the Firebug Net panel for errors: - Administration -> Currencies and exchange rates (jquery.dataTables.colvis.js) - Tools -> Stage MARC records for import (ajaxfileupload.js) or another page which performs a file upload. - Catalog -> Detail page -> MARC Preview (greybox JS) - Help -> Any help page - Any page which loads DataTables (Circulation in the staff client, for instance, and a title's detail page in the OPAC) - Bonus points if you check the various conditional JS includes controlled by the many OPAC feature preferences Signed-off-by: Nick Clemens Signed-off-by: Olli-Antti Kivilahti Signed-off-by: Kyle M Hall -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed May 24 16:07:30 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 24 May 2017 14:07:30 +0000 Subject: [Koha-bugs] [Bug 12904] Force browser to load new javascript files after upgrade In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12904 --- Comment #74 from Kyle M Hall --- Created attachment 63693 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=63693&action=edit Bug 12904 - Update template css and js file references Signed-off-by: Nick Clemens Signed-off-by: Olli-Antti Kivilahti Signed-off-by: Kyle M Hall -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed May 24 16:07:35 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 24 May 2017 14:07:35 +0000 Subject: [Koha-bugs] [Bug 12904] Force browser to load new javascript files after upgrade In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12904 --- Comment #75 from Kyle M Hall --- Created attachment 63694 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=63694&action=edit Bug 12904 [QA Followup] - Don't send 301 status Signed-off-by: Nick Clemens Signed-off-by: Olli-Antti Kivilahti Signed-off-by: Kyle M Hall -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed May 24 16:07:40 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 24 May 2017 14:07:40 +0000 Subject: [Koha-bugs] [Bug 12904] Force browser to load new javascript files after upgrade In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12904 --- Comment #76 from Kyle M Hall --- Created attachment 63695 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=63695&action=edit Bug 12904 - Add mod_expire to etc/koha-httpd.conf Signed-off-by: Kyle M Hall -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed May 24 16:07:46 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 24 May 2017 14:07:46 +0000 Subject: [Koha-bugs] [Bug 12904] Force browser to load new javascript files after upgrade In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12904 --- Comment #77 from Kyle M Hall --- Created attachment 63696 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=63696&action=edit Bug 12904 [QA Followup] - Look up the Koha version once Signed-off-by: Kyle M Hall -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed May 24 16:10:37 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 24 May 2017 14:10:37 +0000 Subject: [Koha-bugs] [Bug 12904] Force browser to load new javascript files after upgrade In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12904 Kyle M Hall changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed May 24 16:14:50 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 24 May 2017 14:14:50 +0000 Subject: [Koha-bugs] [Bug 12904] Force browser to load new javascript files after upgrade In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12904 Kyle M Hall changed: What |Removed |Added ---------------------------------------------------------------------------- Text to go in the| |For non-package release notes| |installations, the | |following rewrite rules | |will need to be added to | |the apache config file: | |RewriteRule ^(.*)_(.*).js$ | |$1.js [R=301,N,L] | |RewriteRule ^(.*)_(.*).css$ | |$1.css [R=301,N,L] Status|Passed QA |Signed Off -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed May 24 16:16:54 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 24 May 2017 14:16:54 +0000 Subject: [Koha-bugs] [Bug 18647] Internal server error on moremember.pl In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18647 Kyle M Hall changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to Master --- Comment #18 from Kyle M Hall --- Pushed to master for 17.05, thanks Marcel, Jonathan! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed May 24 16:21:33 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 24 May 2017 14:21:33 +0000 Subject: [Koha-bugs] [Bug 18596] Quick add form duplicating password confirm In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18596 Kyle M Hall changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to Master CC| |kyle at bywatersolutions.com --- Comment #8 from Kyle M Hall --- Pushed to master for 17.05, thanks Nick! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed May 24 16:22:44 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 24 May 2017 14:22:44 +0000 Subject: [Koha-bugs] [Bug 18598] Quick add form doesn't clear values when switching In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18598 Kyle M Hall changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |kyle at bywatersolutions.com Status|Passed QA |Pushed to Master --- Comment #7 from Kyle M Hall --- Pushed to master for 17.05, thanks Nick! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed May 24 16:22:44 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 24 May 2017 14:22:44 +0000 Subject: [Koha-bugs] [Bug 18665] Translatability: Add tt filter to allow html tags inside tt directives In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18665 --- Comment #1 from Marc V?ron --- Created attachment 63697 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=63697&action=edit Bug 18665 - Translatability: Add tt filter to allow html tags inside tt directives HTML tags inside template toolkit directives are not allowed because of translation issues. Add a filter that handles HTML tags. To test: - Apply patch - Add [% USE HtmlTags %] to the top of a tt file - Add something like [% My nice title | $HtmlTags tag="h1" %] to the tt file - Verify that in output 'My nice title' has h1 tags - Change template directive to something like [% My nice title | $HtmlTags tag="h1" attributes='title="This is a nice title attribute"' %] - Verify that title attribute displays in output (source code or tooltip on 'My nice title') Notes: - Tests are planned for a second patch - Update for Wiki coding guidelines -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed May 24 16:23:56 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 24 May 2017 14:23:56 +0000 Subject: [Koha-bugs] [Bug 18569] Quick add patron will not copy over details from cities and towns pull down into patron details In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18569 Kyle M Hall changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |kyle at bywatersolutions.com Status|Passed QA |Pushed to Master --- Comment #4 from Kyle M Hall --- Pushed to master for 17.05, thanks Nick! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed May 24 16:24:09 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 24 May 2017 14:24:09 +0000 Subject: [Koha-bugs] [Bug 18665] Translatability: Add tt filter to allow html tags inside tt directives In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18665 Marc V?ron changed: What |Removed |Added ---------------------------------------------------------------------------- Patch complexity|--- |Small patch Status|NEW |Needs Signoff --- Comment #2 from Marc V?ron --- Setting to NSO to get comments. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed May 24 16:25:14 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 24 May 2017 14:25:14 +0000 Subject: [Koha-bugs] [Bug 18548] running koha-create --request-db without an instance name should abort In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18548 Kyle M Hall changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to Master CC| |kyle at bywatersolutions.com --- Comment #14 from Kyle M Hall --- Pushed to master for 17.05, thanks Josef! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed May 24 16:26:44 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 24 May 2017 14:26:44 +0000 Subject: [Koha-bugs] [Bug 10371] Show item status in cart list In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10371 Owen Leonard changed: What |Removed |Added ---------------------------------------------------------------------------- Resolution|--- |FIXED Status|BLOCKED |RESOLVED --- Comment #2 from Owen Leonard --- This appears to be fixed: The OPAC cart shows whether something is checked out, whether it is marked lost, etc. If this isn't what the original reporter had in mind please re-open with more details. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed May 24 16:34:08 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 24 May 2017 14:34:08 +0000 Subject: [Koha-bugs] [Bug 12998] Option to exclude withdrawn items when exporting records In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12998 Joy Nelson changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |joy at bywatersolutions.com --- Comment #1 from Joy Nelson --- I would also add that it would be nice to exclude other non-available items from the export as well. Notforloan, itemlost,damaged,restricted... For sites that send bibliographic data to 'discovery' or 'ILL' services, excluding these items would be useful. joy (In reply to JaTara Barnes from comment #0) > It would be nice to have an option to exclude withdrawn items when exporting > bibliographic data. This option would be invaluable for libraries who export > their data for the purpose of collection analyses. Currently, the default in > Koha is to export withdrawn items when exporting records. > > Perhaps this option can be represented as a simple check mark to toggle with > the export of withdrawn items. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed May 24 16:36:04 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 24 May 2017 14:36:04 +0000 Subject: [Koha-bugs] [Bug 18201] Export data -Fix "Remove non-local items" option and add " Removes non-local records" option for existing functionality In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18201 --- Comment #7 from Marcel de Rooy --- Thanks Nick and Christopher. Just another perspective: I could imagine that the library selection in the top of the form would only affect item selection. (It would be good to move them to a separate box.) Selecting some libraries would result in items from these libraries only, possibly resulting in a biblio without items. Selecting all libraries would just mean all items. Selecting no libraries would result in no items. An additional check box "Exclude records without items" could be available as part of record selection (not item selection). Note that imo you cannot speak about biblio records from a branch within the current database setup. That would mean that we could do without the confusing "Do not export items" as well as "Remove non-local items". What do you think? -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed May 24 16:42:03 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 24 May 2017 14:42:03 +0000 Subject: [Koha-bugs] [Bug 18663] Missing db update for ExportRemoveFields In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18663 --- Comment #4 from Julian Maurice --- Created attachment 63698 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=63698&action=edit Bug 18663: Add pref ExportRemoveFields if missing Signed-off-by: Josef Moravec Signed-off-by: Julian Maurice -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed May 24 16:42:13 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 24 May 2017 14:42:13 +0000 Subject: [Koha-bugs] [Bug 18663] Missing db update for ExportRemoveFields In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18663 Julian Maurice changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA CC| |julian.maurice at biblibre.com -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed May 24 16:45:18 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 24 May 2017 14:45:18 +0000 Subject: [Koha-bugs] [Bug 18662] Can not delete currencies In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18662 Julian Maurice changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #63664|0 |1 is obsolete| | --- Comment #3 from Julian Maurice --- Created attachment 63699 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=63699&action=edit Bug 18662: Fix currency deletion Sounds like it is caused by bug 13726. It is not possible to delete a currency, even if not used by any vendors Test plan: Try and delete currencies used or not by vendors. Signed-off-by: Marc V?ron Signed-off-by: Julian Maurice -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed May 24 16:45:34 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 24 May 2017 14:45:34 +0000 Subject: [Koha-bugs] [Bug 18662] Can not delete currencies In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18662 Julian Maurice changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |julian.maurice at biblibre.com Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed May 24 16:46:14 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 24 May 2017 14:46:14 +0000 Subject: [Koha-bugs] [Bug 15494] Block renewals by arbitrary item values In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15494 Nick Clemens changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed May 24 16:46:16 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 24 May 2017 14:46:16 +0000 Subject: [Koha-bugs] [Bug 15494] Block renewals by arbitrary item values In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15494 --- Comment #1 from Nick Clemens --- Created attachment 63700 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=63700&action=edit Bug 15494 - Unit tests prove t/db_dependent/Circulation.t -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed May 24 16:46:19 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 24 May 2017 14:46:19 +0000 Subject: [Koha-bugs] [Bug 15494] Block renewals by arbitrary item values In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15494 --- Comment #2 from Nick Clemens --- Created attachment 63701 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=63701&action=edit Bug 15494 - Add _items_denied_renewal sub to C4:Circulation::CanBookBeRenewed -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed May 24 16:46:22 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 24 May 2017 14:46:22 +0000 Subject: [Koha-bugs] [Bug 15494] Block renewals by arbitrary item values In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15494 --- Comment #3 from Nick Clemens --- Created attachment 63702 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=63702&action=edit Bug 15494 - Update display of renewal errors To test: 1 - Define a rule to deny renewal 2 - Checkout an item meeting this rule 3 - Attempt renew an item via the OPAC 4 - Attempt renewal via SIP 5 - Attempt renewal via staff client 6 - Verify errors are reasonable -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed May 24 16:46:25 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 24 May 2017 14:46:25 +0000 Subject: [Koha-bugs] [Bug 15494] Block renewals by arbitrary item values In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15494 --- Comment #4 from Nick Clemens --- Created attachment 63703 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=63703&action=edit Bug 15494 - Add syspref -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed May 24 16:49:33 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 24 May 2017 14:49:33 +0000 Subject: [Koha-bugs] [Bug 16295] marc_modification_templates permission doesn' t allow access to modify template In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16295 Julian Maurice changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |julian.maurice at biblibre.com Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed May 24 16:49:22 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 24 May 2017 14:49:22 +0000 Subject: [Koha-bugs] [Bug 16295] marc_modification_templates permission doesn' t allow access to modify template In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16295 --- Comment #5 from Julian Maurice --- Created attachment 63704 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=63704&action=edit Bug 16295: Fix access to MMT admin page There was a typo in the permission code Test plan: Try to access the marc modification templates admin page with the marc_modification_templates permission (and not all tools permissions) Signed-off-by: Josef Moravec Signed-off-by: Julian Maurice -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed May 24 16:55:26 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 24 May 2017 14:55:26 +0000 Subject: [Koha-bugs] [Bug 10382] collection not returning to null when removed from course reserves In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10382 Marcel de Rooy changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |In Discussion --- Comment #32 from Marcel de Rooy --- Still have the impression that this is an ugly hack for a design problem in course reserves. And that we should not push it hastily just before release in its current form. Can't you add a status field or store an original state somewhere else instead of removing a PK and allowing UNCHANGED? -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed May 24 17:13:43 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 24 May 2017 15:13:43 +0000 Subject: [Koha-bugs] [Bug 18204] Authority searches are not saved in Search history In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18204 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |jonathan.druart at bugs.koha-c | |ommunity.org Attachment #63398|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed May 24 17:14:39 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 24 May 2017 15:14:39 +0000 Subject: [Koha-bugs] [Bug 18204] Authority searches are not saved in Search history In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18204 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Version|16.11 |master Depends on| |2735 --- Comment #8 from Jonathan Druart --- This certainly comes from bug 2735 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=2735 [Bug 2735] Authority search in OPAC stops at 15 pages -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed May 24 17:14:39 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 24 May 2017 15:14:39 +0000 Subject: [Koha-bugs] [Bug 2735] Authority search in OPAC stops at 15 pages In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=2735 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |18204 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18204 [Bug 18204] Authority searches are not saved in Search history -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed May 24 17:21:08 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 24 May 2017 15:21:08 +0000 Subject: [Koha-bugs] [Bug 18354] Adding item type attribute to cover image div In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18354 Owen Leonard changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed May 24 17:21:11 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 24 May 2017 15:21:11 +0000 Subject: [Koha-bugs] [Bug 18354] Adding item type attribute to cover image div In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18354 Owen Leonard changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #63661|0 |1 is obsolete| | --- Comment #2 from Owen Leonard --- Created attachment 63705 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=63705&action=edit [SIGNED-OFF] Bug 18354 Adding item type attribute to cover image div This adds item type so we can do things with javascript. To Test: 1.) Do a search on OPAC 2.) Inspect element to confirm item type is not present 3.) Apply patch 4.) Do a search on OPAC to confirm item type is present as a class Signed-off-by: Owen Leonard -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed May 24 17:25:51 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 24 May 2017 15:25:51 +0000 Subject: [Koha-bugs] [Bug 18651] Move of checkouts is still not correctly handled In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18651 --- Comment #18 from Jonathan Druart --- Created attachment 63706 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=63706&action=edit Bug 18651: Use a READ and WRITE LOCK For more info, see: commit be156d9ad9e5bcfadab34d44f90e04fd61e256ad Bug 15854: Use a READ and WRITE LOCK on message_queue and commit b40456f7dd4b8a988f9c6a5718452936101cb8ff Bug 18364: Do not LOCK/UNLOCK tables from tests -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed May 24 17:28:32 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 24 May 2017 15:28:32 +0000 Subject: [Koha-bugs] [Bug 16344] Add a circ rule to limit the auto renewals given a specific date In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16344 --- Comment #44 from Jonathan Druart --- Created attachment 63707 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=63707&action=edit Bug 16344: Fix test in GetHardDueDate.t -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed May 24 17:30:37 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 24 May 2017 15:30:37 +0000 Subject: [Koha-bugs] [Bug 16344] Add a circ rule to limit the auto renewals given a specific date In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16344 --- Comment #45 from Jonathan Druart --- (In reply to Jonathan Druart from comment #44) > Created attachment 63707 [details] [review] > Bug 16344: Fix test in GetHardDueDate.t Pushed to master -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed May 24 17:57:11 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 24 May 2017 15:57:11 +0000 Subject: [Koha-bugs] [Bug 17717] process_message_queue.pl: Can't locate Authen/CAS/Client/ Response/Failure.pm In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17717 Julian Maurice changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |julian.maurice at biblibre.com --- Comment #21 from Julian Maurice --- This bug really confuses me. (In reply to Chris Cormack from comment #18) > Yep thats because you are running the script as root then. Root has > permission to write in that dir. With for-each you are running as the user, > it doesn't. Why does Perl need write access to the current directory for loading a module ? > Can't locate Authen/CAS/Client/Response/Failure.pm: ./Authen/CAS/Client/Response/Failure.pm: Permission denied at /usr/share/perl/5.22/base.pm line 97. suggests that ./Authen/CAS/Client/Response/Failure.pm exists but is not readable. This file shouldn't exist as Authen::CAS::Client::Response::Failure is defined in Authen/CAS/Client/Response.pm. Why does it exist ? (In reply to Josef Moravec from comment #20) > To test > 1/ Make sure some things are in the message queue Why ? What could possibly happen during process_message_queue.pl that trigger an error related to a CAS module ? And why the solution to this problem is 'cd /tmp' ? :) -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed May 24 18:14:18 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 24 May 2017 16:14:18 +0000 Subject: [Koha-bugs] [Bug 18666] New: Update 16.06.00.028 failing because of missing no_auto_renewal_after Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18666 Bug ID: 18666 Summary: Update 16.06.00.028 failing because of missing no_auto_renewal_after Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: major Priority: P5 - low Component: Installation and upgrade (web-based installer) Assignee: koha-bugs at lists.koha-community.org Reporter: katrin.fischer at bsz-bw.de QA Contact: testopia at bugs.koha-community.org CC: gmcharlt at gmail.com The database update 16.06.00.028 fails with following error in an update from 3.22.19 to 16.11.08: Attempting upgrade to 16.06.00.028 (Bug 17135) ... DBD::mysql::st execute failed: Unknown column 'me.no_auto_renewal_after' in 'field list' [for Statement "SELECT `me`.`categorycode`, `me`.`itemtype`, `me`.`restrictedtype`, `me`.`rentaldiscount`, `me`.`reservecharge`, `me`.`fine`, `me`.`finedays`, `me`.`maxsuspensiondays`, `me`.`firstremind`, `me`.`chargeperiod`, `me`.`chargeperiod_charge_at`, `me`.`accountsent`, `me`.`chargename`, `me`.`maxissueqty`, `me`.`maxonsiteissueqty`, `me`.`issuelength`, `me`.`lengthunit`, `me`.`hardduedate`, `me`.`hardduedatecompare`, `me`.`renewalsallowed`, `me`.`renewalperiod`, `me`.`norenewalbefore`, `me`.`auto_renew`, `me`.`no_auto_renewal_after`, `me`.`reservesallowed`, `me`.`holds_per_record`, `me`.`branchcode`, `me`.`overduefinescap`, `me`.`cap_fine_to_replacement_price`, `me`.`onshelfholds`, `me`.`opacitemholds`, `me`.`article_requests` FROM `issuingrules` `me` WHERE ( ( `me`.`branchcode` = ? AND `me`.`categorycode` = ? AND `me`.`itemtype` = ? ) )" with ParamValues: 0='XXX', 1='STUDENT', 2='NORMAL'] at /usr/share/perl5/DBIx/Class/Storage/DBI.pm line 1832. It's missing the column no_auto_renewal_after which is not present at this time in the database. It's added later on with update 16.06.00.046. Could it be because the schema already has the column? -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Wed May 24 18:15:05 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 24 May 2017 16:15:05 +0000 Subject: [Koha-bugs] [Bug 18666] Update 16.06.00.028 failing because of missing no_auto_renewal_after In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18666 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |kyle at bywatersolutions.com, | |m.de.rooy at rijksmuseum.nl -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed May 24 18:19:18 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 24 May 2017 16:19:18 +0000 Subject: [Koha-bugs] [Bug 18666] Update 16.06.00.028 failing because of missing no_auto_renewal_after In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18666 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |jonathan.druart at bugs.koha-c | |ommunity.org --- Comment #1 from Jonathan Druart --- I'd suggest to remove the execution of this script from the updatedatabase.pl script and move it to the maintenance directory. The updatedatabase.pl script must not use C4 or Koha modules. The update entry could be replaced with a warning message to tell the admin they should execute the script. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed May 24 18:19:40 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 24 May 2017 16:19:40 +0000 Subject: [Koha-bugs] [Bug 18666] Update 16.06.00.028 failing because of missing no_auto_renewal_after In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18666 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on| |17135 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17135 [Bug 17135] Fine for the previous overdue may get overwritten by the next one -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed May 24 18:19:40 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 24 May 2017 16:19:40 +0000 Subject: [Koha-bugs] [Bug 17135] Fine for the previous overdue may get overwritten by the next one In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17135 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |18666 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18666 [Bug 18666] Update 16.06.00.028 failing because of missing no_auto_renewal_after -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed May 24 19:09:54 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 24 May 2017 17:09:54 +0000 Subject: [Koha-bugs] [Bug 18625] update borrower last seen from SIP In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18625 Lisette changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |lisetteslatah at gmail.com -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed May 24 19:28:40 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 24 May 2017 17:28:40 +0000 Subject: [Koha-bugs] [Bug 16758] Caching issues in scripts running in daemon mode In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16758 Mason James changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on| |17189 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17189 [Bug 17189] Add the ability to define several memcached namespaces -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed May 24 19:28:40 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 24 May 2017 17:28:40 +0000 Subject: [Koha-bugs] [Bug 17189] Add the ability to define several memcached namespaces In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17189 Mason James changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |16758 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16758 [Bug 16758] Caching issues in scripts running in daemon mode -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed May 24 19:29:15 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 24 May 2017 17:29:15 +0000 Subject: [Koha-bugs] [Bug 16758] Caching issues in scripts running in daemon mode In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16758 Mason James changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |17189 Depends on|17189 | Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17189 [Bug 17189] Add the ability to define several memcached namespaces -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed May 24 19:29:15 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 24 May 2017 17:29:15 +0000 Subject: [Koha-bugs] [Bug 17189] Add the ability to define several memcached namespaces In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17189 Mason James changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks|16758 | Depends on| |16758 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16758 [Bug 16758] Caching issues in scripts running in daemon mode -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed May 24 19:30:08 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 24 May 2017 17:30:08 +0000 Subject: [Koha-bugs] [Bug 16758] Caching issues in scripts running in daemon mode In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16758 Mason James changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks|17189 | Depends on| |17189 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17189 [Bug 17189] Add the ability to define several memcached namespaces -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed May 24 19:30:08 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 24 May 2017 17:30:08 +0000 Subject: [Koha-bugs] [Bug 17189] Add the ability to define several memcached namespaces In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17189 Mason James changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |16758 Depends on|16758 | Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16758 [Bug 16758] Caching issues in scripts running in daemon mode -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed May 24 19:48:44 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 24 May 2017 17:48:44 +0000 Subject: [Koha-bugs] [Bug 18667] New: Add a way to automatically convert SQL reports Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18667 Bug ID: 18667 Summary: Add a way to automatically convert SQL reports Change sponsored?: --- Product: Koha Version: unspecified Hardware: All OS: All Status: ASSIGNED Severity: enhancement Priority: P5 - low Component: Reports Assignee: oleonard at myacpl.org Reporter: oleonard at myacpl.org QA Contact: testopia at bugs.koha-community.org CC: abl at biblos.pk.edu.pl, jonathan.druart at bugs.koha-community.org, josef.moravec at gmail.com, katrin.fischer at bsz-bw.de, kyle at bywatersolutions.com, mtj at kohaaloha.com, paul.poulain at biblibre.com, testopia at bugs.koha-community.org, tomascohen at gmail.com, veron at veron.ch Depends on: 17898 I think it would be helpful to use the same diff JavaScript library to compare SQL versions. Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17898 [Bug 17898] Add a way to automatically convert SQL reports -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed May 24 19:48:44 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 24 May 2017 17:48:44 +0000 Subject: [Koha-bugs] [Bug 17898] Add a way to automatically convert SQL reports In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17898 Owen Leonard changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |18667 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18667 [Bug 18667] Add a way to automatically convert SQL reports -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed May 24 19:49:03 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 24 May 2017 17:49:03 +0000 Subject: [Koha-bugs] [Bug 18667] Add a way to automatically convert SQL reports In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18667 Owen Leonard changed: What |Removed |Added ---------------------------------------------------------------------------- Version|unspecified |master -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed May 24 19:52:49 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 24 May 2017 17:52:49 +0000 Subject: [Koha-bugs] [Bug 18667] Show a diff view of SQL reports when converting In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18667 Owen Leonard changed: What |Removed |Added ---------------------------------------------------------------------------- Summary|Add a way to automatically |Show a diff view of SQL |convert SQL reports |reports when converting -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed May 24 20:04:00 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 24 May 2017 18:04:00 +0000 Subject: [Koha-bugs] [Bug 18667] Show a diff view of SQL reports when converting In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18667 Owen Leonard changed: What |Removed |Added ---------------------------------------------------------------------------- Patch complexity|--- |Small patch Status|ASSIGNED |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed May 24 20:04:04 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 24 May 2017 18:04:04 +0000 Subject: [Koha-bugs] [Bug 18667] Show a diff view of SQL reports when converting In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18667 --- Comment #1 from Owen Leonard --- Created attachment 63708 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=63708&action=edit Bug 18667 - Show a diff view of SQL reports when converting This patch reformats the SQL conversion before-and-after view so that it shows a diff between the two, just as the Manage MARC Import interface does. This patch also makes a correction to the JavaScript which is triggered by the closing of the modal. In Bootstrap 3 "hidden.bs.modal" is the event name instead of "hidden." To test, apply the patch and find an SQL report in your reports library which requires updating. - Click the "Update SQL" button. - In the modal window, the "existing" and "updated" SQL should be shown side-by-side with colored highlighting of the differece. - Confirm that the "Update" button still works correctly. - Also confirm that if you open the preview of another report, the "Close" button hides the modal and updates the contents of the modal markup. Use your browser's DOM inspector to confirm that
    contains only
    and its contents. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed May 24 20:10:35 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 24 May 2017 18:10:35 +0000 Subject: [Koha-bugs] [Bug 11626] Cannot receive serial issues after subscription expiry date In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11626 Marjorie Barry-Vila changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |marjorie.barry-vila at ccsr.qc | |.ca -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed May 24 20:22:03 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 24 May 2017 18:22:03 +0000 Subject: [Koha-bugs] [Bug 18626] Add ability to track cardnumber changes for patrons In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18626 Lisette changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |lisetteslatah at gmail.com -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed May 24 21:36:51 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 24 May 2017 19:36:51 +0000 Subject: [Koha-bugs] [Bug 14591] book drop / drop box mode incorrectly decrements accrued overdue fines In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14591 Marjorie Barry-Vila changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |marjorie.barry-vila at ccsr.qc | |.ca -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed May 24 22:19:58 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 24 May 2017 20:19:58 +0000 Subject: [Koha-bugs] [Bug 11626] Cannot receive serial issues after subscription expiry date In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11626 Marcel de Rooy changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |m.de.rooy at rijksmuseum.nl -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed May 24 23:23:02 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 24 May 2017 21:23:02 +0000 Subject: [Koha-bugs] [Bug 18668] New: Add the column localuse to the items table Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18668 Bug ID: 18668 Summary: Add the column localuse to the items table Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Database Assignee: gmcharlt at gmail.com Reporter: jesse at bywatersolutions.com QA Contact: testopia at bugs.koha-community.org new feature: Add the column localuse to the items table. When a localuse is done, increment the localuse column for the item. That way the data is stored with the item like issues and renewals instead of having to do joins to the statistic tables. Thank you, -JesseM -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu May 25 00:25:24 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 24 May 2017 22:25:24 +0000 Subject: [Koha-bugs] [Bug 17096] [OMNIBUS] CSRF protections In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17096 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Product|Koha security |Koha Assignee|chris at bigballofwax.co.nz |gmcharlt at gmail.com QA Contact| |testopia at bugs.koha-communit | |y.org Group|Koha security | Component|Koha |Architecture, internals, | |and plumbing -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu May 25 00:33:58 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 24 May 2017 22:33:58 +0000 Subject: [Koha-bugs] [Bug 18625] update borrower last seen from SIP In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18625 jdemuth at roseville.ca.us changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |jdemuth at roseville.ca.us -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu May 25 04:59:19 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 25 May 2017 02:59:19 +0000 Subject: [Koha-bugs] [Bug 17780] When choose an author in authority results new window shows a blank screen In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17780 Marjorie Barry-Vila changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |marjorie.barry-vila at ccsr.qc | |.ca -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu May 25 06:17:41 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 25 May 2017 04:17:41 +0000 Subject: [Koha-bugs] [Bug 9683] Allow disable rewrite apache mod In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9683 David Cook changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |dcook at prosentient.com.au --- Comment #10 from David Cook --- Looks like we should've commented out the following as well: RewriteCond %{QUERY_STRING} (.*?)(?:[A-Za-z0-9_-]+)=&(.*) In the absence of RewriteRule (.+) $1?%1%2 [N,R,NE], it's being applied to RewriteRule ^/bib/([^\/]*)/?$ /cgi-bin/koha/opac-detail\.pl?bib=$1 [PT]. I'm opening a new bug for that though. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu May 25 06:22:58 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 25 May 2017 04:22:58 +0000 Subject: [Koha-bugs] [Bug 9683] Allow disable rewrite apache mod In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9683 --- Comment #11 from David Cook --- Also, this patch isn't implemented in the Debian Apache templates, although that doesn't apply to my current situation... -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu May 25 06:29:19 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 25 May 2017 04:29:19 +0000 Subject: [Koha-bugs] [Bug 18669] New: RewriteCond affecting wrong rule in koha-httpd.conf Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18669 Bug ID: 18669 Summary: RewriteCond affecting wrong rule in koha-httpd.conf Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: normal Priority: P5 - low Component: Architecture, internals, and plumbing Assignee: gmcharlt at gmail.com Reporter: dcook at prosentient.com.au QA Contact: testopia at bugs.koha-community.org With Bug 9683, we removed an unnecessary RewriteRule from the Apache configuration. However, by removing that RewriteRule directive, we accidentally made the preceding RewriteCond affect the following rule instead: RewriteRule ^/bib/([^\/]*)/?$ /cgi-bin/koha/opac-detail\.pl?bib=$1 [PT] So I'm just going to remove the RewriteCond from etc/koha-httpd.conf as it's causing problems with a rewrite rule which works with Debian packages and properly configured source installs. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu May 25 06:29:32 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 25 May 2017 04:29:32 +0000 Subject: [Koha-bugs] [Bug 18669] RewriteCond affecting wrong rule in koha-httpd.conf In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18669 David Cook changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |https://bugs.koha-community | |.org/bugzilla3/show_bug.cgi | |?id=9683 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu May 25 06:29:32 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 25 May 2017 04:29:32 +0000 Subject: [Koha-bugs] [Bug 9683] Allow disable rewrite apache mod In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9683 David Cook changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |https://bugs.koha-community | |.org/bugzilla3/show_bug.cgi | |?id=18669 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu May 25 06:29:42 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 25 May 2017 04:29:42 +0000 Subject: [Koha-bugs] [Bug 18669] RewriteCond affecting wrong rule in koha-httpd.conf In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18669 David Cook changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|gmcharlt at gmail.com |dcook at prosentient.com.au -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu May 25 06:37:03 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 25 May 2017 04:37:03 +0000 Subject: [Koha-bugs] [Bug 18670] New: RewriteLog and RewriteLogLevel unavailable in Apache 2.4 Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18670 Bug ID: 18670 Summary: RewriteLog and RewriteLogLevel unavailable in Apache 2.4 Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: trivial Priority: P5 - low Component: Architecture, internals, and plumbing Assignee: gmcharlt at gmail.com Reporter: dcook at prosentient.com.au QA Contact: testopia at bugs.koha-community.org We have a few commented out RewriteLog and RewriteLogLevel directives in various Apache configuration files and templates. These directives aren't used in Apache 2.4. They've been replaced with the LogLevel directive. Since they're commented out, I don't think it matters too much for production systems, but it could lead to confusion if people tried uncommenting them and they don't work (yep that was me). We could wrap the two different styles in IfVersion directives to make things easier for people. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu May 25 06:44:06 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 25 May 2017 04:44:06 +0000 Subject: [Koha-bugs] [Bug 18669] RewriteCond affecting wrong rule in koha-httpd.conf In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18669 David Cook changed: What |Removed |Added ---------------------------------------------------------------------------- Patch complexity|--- |Small patch Status|NEW |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu May 25 06:44:09 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 25 May 2017 04:44:09 +0000 Subject: [Koha-bugs] [Bug 18669] RewriteCond affecting wrong rule in koha-httpd.conf In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18669 --- Comment #1 from David Cook --- Created attachment 63709 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=63709&action=edit Bug 18669 - RewriteCond affecting wrong rule in koha-httpd.conf One of the RewriteCond directives in koha-httpd.conf was affecting the wrong RewriteRule after its original RewriteRule was commented out years ago. _TEST PLAN_ 0) Before applying patch, build Koha from source *) make *) make install (or make upgrade) *) Copy or symlink etc/koha-httpd.conf to your Apache vhost directory (and enable if you're on a Debian based system) *) Restart Apache 1) Make sure that you have at least 1 bibliographic record in Koha (URL like this http://server:port/cgi-bin/koha/opac-detail.pl?biblionumber=1) 2) Go to http://server:port/bib/1 3) Note that you get a 404 error 4) Apply the patch 5) Rebuild Koha from source as per step 0 6) Go to http://server:port/bib/1 7) Note that you now see the same page as you would if you went to http://server:port/cgi-bin/koha/opac-detail.pl?biblionumber=1 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu May 25 07:33:04 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 25 May 2017 05:33:04 +0000 Subject: [Koha-bugs] [Bug 14962] Temp Shelving Location In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14962 Josef Moravec changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |josef.moravec at gmail.com -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu May 25 07:38:54 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 25 May 2017 05:38:54 +0000 Subject: [Koha-bugs] [Bug 15775] User should know when they are blocked from checkouts on OPAC + Translatability fixes for OPAC Summary page In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15775 Aleisha Amohia changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu May 25 07:38:59 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 25 May 2017 05:38:59 +0000 Subject: [Koha-bugs] [Bug 15775] User should know when they are blocked from checkouts on OPAC + Translatability fixes for OPAC Summary page In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15775 --- Comment #18 from Aleisha Amohia --- Created attachment 63710 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=63710&action=edit Bug 15775: [FOLLOWUP] fixing merge conflicts and using Price plugin for formatting -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu May 25 07:48:33 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 25 May 2017 05:48:33 +0000 Subject: [Koha-bugs] [Bug 18669] RewriteCond affecting wrong rule in koha-httpd.conf In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18669 Josef Moravec changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu May 25 07:48:36 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 25 May 2017 05:48:36 +0000 Subject: [Koha-bugs] [Bug 18669] RewriteCond affecting wrong rule in koha-httpd.conf In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18669 Josef Moravec changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #63709|0 |1 is obsolete| | --- Comment #2 from Josef Moravec --- Created attachment 63711 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=63711&action=edit [SIGNED-OFF] Bug 18669 - RewriteCond affecting wrong rule in koha-httpd.conf One of the RewriteCond directives in koha-httpd.conf was affecting the wrong RewriteRule after its original RewriteRule was commented out years ago. _TEST PLAN_ 0) Before applying patch, build Koha from source *) make *) make install (or make upgrade) *) Copy or symlink etc/koha-httpd.conf to your Apache vhost directory (and enable if you're on a Debian based system) *) Restart Apache 1) Make sure that you have at least 1 bibliographic record in Koha (URL like this http://server:port/cgi-bin/koha/opac-detail.pl?biblionumber=1) 2) Go to http://server:port/bib/1 3) Note that you get a 404 error 4) Apply the patch 5) Rebuild Koha from source as per step 0 6) Go to http://server:port/bib/1 7) Note that you now see the same page as you would if you went to http://server:port/cgi-bin/koha/opac-detail.pl?biblionumber=1 Signed-off-by: Josef Moravec -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu May 25 07:50:19 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 25 May 2017 05:50:19 +0000 Subject: [Koha-bugs] [Bug 18669] RewriteCond affecting wrong rule in koha-httpd.conf In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18669 Josef Moravec changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |josef.moravec at gmail.com --- Comment #3 from Josef Moravec --- I just signed off, because it does work as described, but I am just curious if we should make the changes from bug 9683 and this bug to debian apache templates too... -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu May 25 08:02:42 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 25 May 2017 06:02:42 +0000 Subject: [Koha-bugs] [Bug 18667] Show a diff view of SQL reports when converting In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18667 --- Comment #2 from Josef Moravec --- Comment on attachment 63708 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=63708 Bug 18667 - Show a diff view of SQL reports when converting Review of attachment 63708: --> (https://bugs.koha-community.org/bugzilla3/page.cgi?id=splinter.html&bug=18667&attachment=63708) ----------------------------------------------------------------- ::: koha-tmpl/intranet-tmpl/prog/en/modules/reports/convert_report.tt @@ +7,4 @@ > [% IF msg == 'no_report' %] > There is no valid report for this id. > [% ELSIF msg == 'can_be_updated' %] > +
    It would be better to use class instead of style attribute @@ +11,5 @@ > +

    Existing SQL

    > + [% current_sql | html_entity %] > +
    > + > +
    And here too please -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu May 25 08:03:23 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 25 May 2017 06:03:23 +0000 Subject: [Koha-bugs] [Bug 18667] Show a diff view of SQL reports when converting In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18667 Josef Moravec changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Failed QA --- Comment #3 from Josef Moravec --- But otherwise it's working as expected -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu May 25 11:42:00 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 25 May 2017 09:42:00 +0000 Subject: [Koha-bugs] [Bug 17456] Cataloging plugins: change of behaviour at fileds driven by plugins In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17456 Josef Moravec changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |RESOLVED Resolution|--- |WONTFIX -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu May 25 11:54:22 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 25 May 2017 09:54:22 +0000 Subject: [Koha-bugs] [Bug 12904] Force browser to load new javascript files after upgrade In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12904 --- Comment #78 from Katrin Fischer --- >For non-package installations, the following rewrite rules will need to be >added to the apache config file: >RewriteRule ^(.*)_(.*).js$ $1.js [R=301,N,L] >RewriteRule ^(.*)_(.*).css$ $1.css [R=301,N,L] Wonder if this might not get lost - would there be a way to automate it? What happens if you don't? -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu May 25 11:57:48 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 25 May 2017 09:57:48 +0000 Subject: [Koha-bugs] [Bug 17456] Cataloging plugins: change of behaviour at fields driven by plugins In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17456 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |katrin.fischer at bsz-bw.de Summary|Cataloging plugins: change |Cataloging plugins: change |of behaviour at fileds |of behaviour at fields |driven by plugins |driven by plugins -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu May 25 13:25:25 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 25 May 2017 11:25:25 +0000 Subject: [Koha-bugs] [Bug 18666] Update 16.06.00.028 failing because of missing no_auto_renewal_after In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18666 Jacek Ablewicz changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |abl at biblos.pk.edu.pl --- Comment #2 from Jacek Ablewicz --- (In reply to Katrin Fischer from comment #0) > The database update 16.06.00.028 fails with following error in an update > from 3.22.19 to 16.11.08: > > Attempting upgrade to 16.06.00.028 (Bug 17135) ... > DBD::mysql::st execute failed: Unknown column 'me.no_auto_renewal_after' > in 'field list' [for Statement "SELECT `me`.`categorycode`, > `me`.`itemtype`, `me`.`restrictedtype`, `me`.`rentaldiscount`, > `me`.`reservecharge`, `me`.`fine`, `me`.`finedays`, > `me`.`maxsuspensiondays`, `me`.`firstremind`, `me`.`chargeperiod`, > `me`.`chargeperiod_charge_at`, `me`.`accountsent`, `me`.`chargename`, > `me`.`maxissueqty`, `me`.`maxonsiteissueqty`, `me`.`issuelength`, > `me`.`lengthunit`, `me`.`hardduedate`, `me`.`hardduedatecompare`, > `me`.`renewalsallowed`, `me`.`renewalperiod`, `me`.`norenewalbefore`, > `me`.`auto_renew`, `me`.`no_auto_renewal_after`, `me`.`reservesallowed`, > `me`.`holds_per_record`, `me`.`branchcode`, `me`.`overduefinescap`, > `me`.`cap_fine_to_replacement_price`, `me`.`onshelfholds`, > `me`.`opacitemholds`, `me`.`article_requests` FROM `issuingrules` `me` > WHERE ( ( `me`.`branchcode` = ? AND `me`.`categorycode` = ? AND > `me`.`itemtype` = ? ) )" with ParamValues: 0='XXX', 1='STUDENT', > 2='NORMAL'] at /usr/share/perl5/DBIx/Class/Storage/DBI.pm line 1832. > > It's missing the column no_auto_renewal_after which is not present at this > time in the database. It's added later on with update 16.06.00.046. > > Could it be because the schema already has the column? Yes, looks like it happens because during this particular upgrade step DBIx schema is out of sync with the actual database structure, and CalcFine (after Bug 17599 got pushed ?) is prone to fail because of that. During upgrades from 16.05.03+ to 16.11.* or 17.05.*, there will be an attempt to re-run the script from Bug 17135, and it will fail - but at least the non-accruing FU fine records got already closed in earlier 16.05.03 upgrade step, so this error should be (relatively) harmless. Upgrades to 16.11+ from versions earlier than 16.05.03 are affected to a larger extent by this issue - execution of the script will fail, some non-accruing FU fines will remain unclosed, and they may get overwritten later on. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Thu May 25 14:37:43 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 25 May 2017 12:37:43 +0000 Subject: [Koha-bugs] [Bug 18667] Show a diff view of SQL reports when converting In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18667 Owen Leonard changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu May 25 14:37:46 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 25 May 2017 12:37:46 +0000 Subject: [Koha-bugs] [Bug 18667] Show a diff view of SQL reports when converting In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18667 Owen Leonard changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #63708|0 |1 is obsolete| | --- Comment #4 from Owen Leonard --- Created attachment 63712 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=63712&action=edit Bug 18667 [Revised] Show a diff view of SQL reports when converting This patch reformats the SQL conversion before-and-after view so that it shows a diff between the two, just as the Manage MARC Import interface does. This patch also makes a correction to the JavaScript which is triggered by the closing of the modal. In Bootstrap 3 "hidden.bs.modal" is the event name instead of "hidden." To test, apply the patch and find an SQL report in your reports library which requires updating. - Click the "Update SQL" button. - In the modal window, the "existing" and "updated" SQL should be shown side-by-side with colored highlighting of the differece. - Confirm that the "Update" button still works correctly. - Also confirm that if you open the preview of another report, the "Close" button hides the modal and updates the contents of the modal markup. Use your browser's DOM inspector to confirm that
    contains only
    and its contents. Revision moves inline style attributes to CSS block. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu May 25 14:39:52 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 25 May 2017 12:39:52 +0000 Subject: [Koha-bugs] [Bug 12644] Add subtitles staff client cart In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12644 Owen Leonard changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |ASSIGNED Assignee|koha-bugs at lists.koha-commun |oleonard at myacpl.org |ity.org | -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu May 25 14:40:56 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 25 May 2017 12:40:56 +0000 Subject: [Koha-bugs] [Bug 12644] Add subtitles to staff client cart In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12644 Owen Leonard changed: What |Removed |Added ---------------------------------------------------------------------------- Summary|Add subtitles staff client |Add subtitles to staff |cart |client cart -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu May 25 14:56:34 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 25 May 2017 12:56:34 +0000 Subject: [Koha-bugs] [Bug 12644] Add subtitles to staff client cart In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12644 Owen Leonard changed: What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |Needs Signoff Patch complexity|--- |Trivial patch -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu May 25 14:56:37 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 25 May 2017 12:56:37 +0000 Subject: [Koha-bugs] [Bug 12644] Add subtitles to staff client cart In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12644 --- Comment #2 from Owen Leonard --- Created attachment 63713 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=63713&action=edit Bug 12644 - Add subtitles to staff client cart This patch adds display of subtitles to the staff client cart. To test you should have some values mapped to subtitle in Administration -> Keyword to MARC Mapping. 1. Apply the patch. 2. Add some records to the staff client cart which have subtitles. 3. Open the cart and onfirm that subtitles display correctly in both the brief and "More details" view. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu May 25 15:02:30 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 25 May 2017 13:02:30 +0000 Subject: [Koha-bugs] [Bug 18512] GetAuthorisedValues.GetByCode Template plugin should return code ( not empty string) if value not found In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18512 --- Comment #11 from Nick Clemens --- Created attachment 63714 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=63714&action=edit Bug 18512: Add tests 16.11.X version Remove use of build_object Signed-off-by: Jonathan Druart -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu May 25 15:03:26 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 25 May 2017 13:03:26 +0000 Subject: [Koha-bugs] [Bug 18512] GetAuthorisedValues.GetByCode Template plugin should return code ( not empty string) if value not found In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18512 --- Comment #12 from Nick Clemens --- (In reply to Katrin Fischer from comment #10) > Tests don't pass applied on 16.11.x - not pushing this, please check. > Test Summary Report > ------------------- > t/db_dependent/Template/Plugin/AuthorisedValues.t (Wstat: 65280 Tests: 1 > Failed: 1) > Failed test: 1 > Non-zero exit status: 255 Tests were using build_object which doesn't seem to be in 16.11.X New tests attached -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu May 25 16:01:42 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 25 May 2017 14:01:42 +0000 Subject: [Koha-bugs] [Bug 12566] Duplicate checks for Self Registered borrowers In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12566 Emma Perks changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |emma.perks at heartofengland.n | |hs.uk -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu May 25 16:01:53 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 25 May 2017 14:01:53 +0000 Subject: [Koha-bugs] [Bug 13901] sort1 and sort2 not on self registration form In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13901 Emma Perks changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |emma.perks at heartofengland.n | |hs.uk -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu May 25 16:09:50 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 25 May 2017 14:09:50 +0000 Subject: [Koha-bugs] [Bug 11813] Send 'Opac self registration verification' email from branch address if possible In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11813 Emma Perks changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |emma.perks at heartofengland.n | |hs.uk -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu May 25 16:10:58 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 25 May 2017 14:10:58 +0000 Subject: [Koha-bugs] [Bug 15343] Allow patrons to choose their own password on self registration. In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15343 Emma Perks changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |emma.perks at heartofengland.n | |hs.uk -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu May 25 16:52:59 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 25 May 2017 14:52:59 +0000 Subject: [Koha-bugs] [Bug 18514] Allow library to search their Koha and Overdrive collections using ElasticSearch In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18514 --- Comment #4 from Nick Clemens --- I think there are some updates on a git branch that need to be imported here, current code doesn't run -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu May 25 18:00:04 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 25 May 2017 16:00:04 +0000 Subject: [Koha-bugs] [Bug 18514] Allow library to search their Koha and Overdrive collections using ElasticSearch In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18514 --- Comment #5 from Chris Cormack --- Actually no there aren't. Have you not been seeing my updates in our WR system Nick? Basically there isn't missing code here, rebuilding elastic search indexes is busted in master. [Request] ** http://localhost:9200 -[400] [mapper_parsing_exception] Failed to parse mapping [data]: The [string] type is removed in 5.0 and automatic upgrade failed because parameters [index_analyzer] are not supported for automatic upgrades. You should now use either a [text] or [keyword] field instead for field [ff7-01-02] This is nothing to do with the overdrive code. As it dies for misc/search_tools/rebuild_elastic_search.pl too. Which is not touched by this. That dies for me on current master, with or without these patches. (As an aside we need to track down why you didnt see the updates) -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu May 25 18:04:21 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 25 May 2017 16:04:21 +0000 Subject: [Koha-bugs] [Bug 18514] Allow library to search their Koha and Overdrive collections using ElasticSearch In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18514 --- Comment #6 from Nick Clemens --- I will double check, I may have just missed those and jumped here. A few lines do need fixed though: Koha::ElasticSearch::Indexer; should be Koha::SearchEngine::Elasticsearch::Indexer; Do you have a bug for ES indexing broken? I haven't hit a problem, but maybe I need to refresh my mappings. -Nick -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu May 25 19:18:15 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 25 May 2017 17:18:15 +0000 Subject: [Koha-bugs] [Bug 18137] REST API: Migrate from Mojolicious::Plugin:: Swagger2 to Mojolicious::Plugin::OpenAPI In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18137 --- Comment #81 from Mirko Tietgen --- According to Tom?s, the newer versions break dev setups, so we are back to libmojolicious-perl 6.15 and libjson-validator-perl 0.67 for the time being. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu May 25 20:33:58 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 25 May 2017 18:33:58 +0000 Subject: [Koha-bugs] [Bug 18656] Require confirmation of deletion of files from patron record In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18656 PTFS Europe Sandboxes changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |sandboxes at ptfs-europe.com Status|Needs Signoff |Signed Off --- Comment #2 from PTFS Europe Sandboxes --- Patch tested with a sandbox, by David Roberts -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu May 25 20:34:11 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 25 May 2017 18:34:11 +0000 Subject: [Koha-bugs] [Bug 18656] Require confirmation of deletion of files from patron record In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18656 PTFS Europe Sandboxes changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #63691|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu May 25 20:34:19 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 25 May 2017 18:34:19 +0000 Subject: [Koha-bugs] [Bug 18656] Require confirmation of deletion of files from patron record In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18656 --- Comment #3 from PTFS Europe Sandboxes --- Created attachment 63715 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=63715&action=edit Bug 18571: Add default ES configuration to koha-conf-site.xml.in This patch adds a default configuration entry for elasticsearch. It will add localhost:9200 to the server subsection, and koha_instance (replacing instance for the corresponding instance name) for the namespace. To test: - Apply the patch - Copy the file to the /etc/koha dir: $ sudo cp kohaclone/debian/templates/koha-conf-site.xml.in /etc/koha - Create a new instance: $ sudo koha-create --create-db test => SUCCESS: /etc/koha/sites/test/koha-conf.xml includes the mentioned section: localhost:9200 koha_test - Sign off :-D Note: As the use of ES is syspref driven, this default entry doesn't have any use until ES is installed and SearchEngine set to Elasticsearch. So it doesn't hurt but will help end users test the ES integration. Advanced users will take care of this config entry manually (pointing to external servers/clusters, etc). Signed-off-by: Mirko Tietgen Signed-off-by: Nick Clemens Signed-off-by: Kyle M Hall Signed-off-by: David Roberts -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu May 25 20:34:58 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 25 May 2017 18:34:58 +0000 Subject: [Koha-bugs] [Bug 18656] Require confirmation of deletion of files from patron record In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18656 --- Comment #4 from PTFS Europe Sandboxes --- Patch tested with a sandbox, by David Roberts -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu May 25 20:35:12 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 25 May 2017 18:35:12 +0000 Subject: [Koha-bugs] [Bug 18656] Require confirmation of deletion of files from patron record In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18656 PTFS Europe Sandboxes changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #63715|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu May 25 20:35:20 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 25 May 2017 18:35:20 +0000 Subject: [Koha-bugs] [Bug 18656] Require confirmation of deletion of files from patron record In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18656 --- Comment #5 from PTFS Europe Sandboxes --- Created attachment 63716 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=63716&action=edit Bug 18571: Add default ES configuration to koha-conf-site.xml.in This patch adds a default configuration entry for elasticsearch. It will add localhost:9200 to the server subsection, and koha_instance (replacing instance for the corresponding instance name) for the namespace. To test: - Apply the patch - Copy the file to the /etc/koha dir: $ sudo cp kohaclone/debian/templates/koha-conf-site.xml.in /etc/koha - Create a new instance: $ sudo koha-create --create-db test => SUCCESS: /etc/koha/sites/test/koha-conf.xml includes the mentioned section: localhost:9200 koha_test - Sign off :-D Note: As the use of ES is syspref driven, this default entry doesn't have any use until ES is installed and SearchEngine set to Elasticsearch. So it doesn't hurt but will help end users test the ES integration. Advanced users will take care of this config entry manually (pointing to external servers/clusters, etc). Signed-off-by: Mirko Tietgen Signed-off-by: Nick Clemens Signed-off-by: Kyle M Hall Signed-off-by: David Roberts https://bugs.koha-community.org/show_bug.cgi?id=18656 Signed-off-by: David Roberts -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu May 25 20:35:45 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 25 May 2017 18:35:45 +0000 Subject: [Koha-bugs] [Bug 18656] Require confirmation of deletion of files from patron record In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18656 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |katrin.fischer at bsz-bw.de --- Comment #6 from Katrin Fischer --- Hi David, the wrong patch got attached, I am reverting this. Do you want to try again? -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu May 25 20:36:06 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 25 May 2017 18:36:06 +0000 Subject: [Koha-bugs] [Bug 18656] Require confirmation of deletion of files from patron record In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18656 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #63691|1 |0 is obsolete| | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu May 25 20:36:19 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 25 May 2017 18:36:19 +0000 Subject: [Koha-bugs] [Bug 18656] Require confirmation of deletion of files from patron record In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18656 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #63716|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu May 25 20:36:38 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 25 May 2017 18:36:38 +0000 Subject: [Koha-bugs] [Bug 18656] Require confirmation of deletion of files from patron record In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18656 --- Comment #7 from Katrin Fischer --- If it's not working from the sandboxes I can attach a patch with your sign-off line, just let me know. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu May 25 20:44:09 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 25 May 2017 18:44:09 +0000 Subject: [Koha-bugs] [Bug 5395] C4::Acquisition::SearchOrder POD inconsistent with function In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5395 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu May 25 20:44:12 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 25 May 2017 18:44:12 +0000 Subject: [Koha-bugs] [Bug 5395] C4::Acquisition::SearchOrder POD inconsistent with function In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5395 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #63681|0 |1 is obsolete| | --- Comment #6 from Katrin Fischer --- Created attachment 63717 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=63717&action=edit [SIGNED OFF] Bug 5395: Update C4::Acquisition::SearchOrders POD Comparing the perldoc to the function: - basketname - basketgroupname - budget_id Were missing. This adds them. Also, a description of ordernumber and search were added, as they are not self-evident by their name alone. There are no code changes, so all tests should pass or fail identically before and after patch. Signed-off-by: Katrin Fischer Fixed typo basetgroupname -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu May 25 20:56:06 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 25 May 2017 18:56:06 +0000 Subject: [Koha-bugs] [Bug 18671] New: Calendar.t failing exception holiday test Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18671 Bug ID: 18671 Summary: Calendar.t failing exception holiday test Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: normal Priority: P5 - low Component: Circulation Assignee: koha-bugs at lists.koha-community.org Reporter: katrin.fischer at bsz-bw.de QA Contact: testopia at bugs.koha-community.org CC: gmcharlt at gmail.com, kyle.m.hall at gmail.com Test is failing on master - I haven't verified yet if that points to a real problem, so just setting to 'normal' for now. prove t/Calendar.t t/Calendar.t .. 1/38 # Failed test 'Exception holiday is not a closed day test' # at t/Calendar.t line 164. # got: '1' # expected: '0' # Looks like you failed 1 test of 38. t/Calendar.t .. Dubious, test returned 1 (wstat 256, 0x100) Failed 1/38 subtests -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu May 25 20:56:33 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 25 May 2017 18:56:33 +0000 Subject: [Koha-bugs] [Bug 5395] C4::Acquisition::SearchOrder POD inconsistent with function In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5395 --- Comment #7 from M. Tompsett --- (In reply to Katrin Fischer from comment #6) > Fixed typo basetgroupname Thanks. How embarrassing. -- You are receiving this mail because: You are watching all bug changes. You are the QA Contact for the bug. From bugzilla-daemon at bugs.koha-community.org Thu May 25 20:58:57 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 25 May 2017 18:58:57 +0000 Subject: [Koha-bugs] [Bug 9031] Overdue items crossing DST boundary throw invalid local time exception In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9031 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |https://bugs.koha-community | |.org/bugzilla3/show_bug.cgi | |?id=18671 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu May 25 20:58:57 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 25 May 2017 18:58:57 +0000 Subject: [Koha-bugs] [Bug 18671] Calendar.t failing exception holiday test In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18671 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |https://bugs.koha-community | |.org/bugzilla3/show_bug.cgi | |?id=9031 -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Thu May 25 21:07:28 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 25 May 2017 19:07:28 +0000 Subject: [Koha-bugs] [Bug 9031] Overdue items crossing DST boundary throw invalid local time exception In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9031 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu May 25 21:07:31 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 25 May 2017 19:07:31 +0000 Subject: [Koha-bugs] [Bug 9031] Overdue items crossing DST boundary throw invalid local time exception In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9031 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #61089|0 |1 is obsolete| | --- Comment #11 from Katrin Fischer --- Created attachment 63718 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=63718&action=edit [SIGNED OFF] Bug 9031 - Overdue items crossing DST boundary throw invalid local time exception To test: 1 - Set TZ to America/New York 2 - Checkout item and set due date to '2016-03-09 02:29:00" 3 - Make sure fines are set for the item type, fine mode production, calculate fines on return 4 - Check in item - invalid date time warning in logs 5 - Apply patch 6 - Check in item - no error 7 - prove t/Calendar.t Signed-off-by: Katrin Fischer -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu May 25 21:21:50 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 25 May 2017 19:21:50 +0000 Subject: [Koha-bugs] [Bug 11317] Add a way to access files from the intranet In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11317 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Failed QA --- Comment #76 from Katrin Fischer --- Ok, trying to get this tested :) First: QA tools: FAIL koha-tmpl/intranet-tmpl/prog/en/modules/reports/report_files.tt FAIL git manipulation The file has been added and deleted in the same patchset FAIL koha-tmpl/intranet-tmpl/prog/en/modules/reports/reports-home.tt FAIL forbidden patterns forbidden pattern: tab char (line 55) forbidden pattern: tab char (line 68) forbidden pattern: tab char (line 63) forbidden pattern: tab char (line 61) forbidden pattern: tab char (line 64) forbidden pattern: tab char (line 58) forbidden pattern: tab char (line 65) forbidden pattern: tab char (line 73) forbidden pattern: tab char (line 59) forbidden pattern: tab char (line 57) forbidden pattern: tab char (line 60) FAIL reports/report_files.pl FAIL git manipulation The file has been added and deleted in the same patchset Easy to fix - as we got no sign-off yet, we'd just need to fix the tabs and squash the patches. Second: Some code review 1) I think as the permission is under Tools and the files live there too, it should also be shown as a tool on the tools page instead of under reports. I'd put it under "Additional tools", maybe under the log viewer.
  • Report/log files
    • 2) When I click on the link under Reports, I get a 'not found' error. What am I missing? 3) Looking at the history of this bug, are we missing 2 patches? Bug 11317 - Allow sorting on date column in file access tool. (1.29 KB, patch) Bug 11317 - Remove datatables-strings.inc from .tt (959 bytes, patch) 4) +use strict; +use warnings; Shoudl be: use Modern::Perl; Sorry, can't test further because of 2)! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu May 25 21:23:43 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 25 May 2017 19:23:43 +0000 Subject: [Koha-bugs] [Bug 13952] Import and export of authority types In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13952 Marc V?ron changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |veron at veron.ch -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu May 25 21:27:00 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 25 May 2017 19:27:00 +0000 Subject: [Koha-bugs] [Bug 12644] Add subtitles to staff client cart In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12644 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu May 25 21:27:03 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 25 May 2017 19:27:03 +0000 Subject: [Koha-bugs] [Bug 12644] Add subtitles to staff client cart In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12644 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #63713|0 |1 is obsolete| | --- Comment #3 from Katrin Fischer --- Created attachment 63719 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=63719&action=edit [SIGNED OFF] Bug 12644 - Add subtitles to staff client cart This patch adds display of subtitles to the staff client cart. To test you should have some values mapped to subtitle in Administration -> Keyword to MARC Mapping. 1. Apply the patch. 2. Add some records to the staff client cart which have subtitles. 3. Open the cart and onfirm that subtitles display correctly in both the brief and "More details" view. Signed-off-by: Katrin Fischer -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu May 25 21:35:16 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 25 May 2017 19:35:16 +0000 Subject: [Koha-bugs] [Bug 12836] Add a script to regenerate Explain files from configs In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12836 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |katrin.fischer at bsz-bw.de --- Comment #11 from Katrin Fischer --- There is a lot of output running this from inside the koha-shell as 'perl misc/maintanence/generate_explain.pl' Looking at /etc/koha/sites/kohadev/koha-conf.xml Use of uninitialized value $publicserver in split at misc/maintenance/generate_explain.pl line 216. Use of uninitialized value $host in concatenation (.) or string at misc/maintenance/generate_explain.pl line 217. Use of uninitialized value $port in concatenation (.) or string at misc/maintenance/generate_explain.pl line 217. SRU is listening on host and port Use of uninitialized value $pqf_properties_file in concatenation (.) or string at misc/maintenance/generate_explain.pl line 221. Looking at Use of uninitialized value $file_name in -e at /usr/share/perl5/File/Slurp.pm line 116. Use of uninitialized value $file_name in sysopen at /usr/share/perl5/File/Slurp.pm line 193. Use of uninitialized value $file_name in concatenation (.) or string at /usr/share/perl5/File/Slurp.pm line 194. read_file '' - sysopen: No such file or directory at misc/maintenance/generate_explain.pl line 225. Am I missing something? -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu May 25 21:44:45 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 25 May 2017 19:44:45 +0000 Subject: [Koha-bugs] [Bug 18672] New: Creation Date and Modification Date are the same for a list in the Lists Module Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18672 Bug ID: 18672 Summary: Creation Date and Modification Date are the same for a list in the Lists Module Change sponsored?: --- Product: Koha Version: 16.11 Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Lists Assignee: gmcharlt at gmail.com Reporter: karen at bywatersolutions.com QA Contact: testopia at bugs.koha-community.org CC: m.de.rooy at rijksmuseum.nl Created attachment 63720 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=63720&action=edit Creation Date and Modification Date are the same for a list in the Lists Module In the Lists Module the creation date and the modification date show the same date for each list. The expected behavior is that the creation date would be the date that the list was created and the modification date would be the last date that any changes were made. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu May 25 21:56:12 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 25 May 2017 19:56:12 +0000 Subject: [Koha-bugs] [Bug 18665] Translatability: Add tt filter to allow html tags inside tt directives In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18665 --- Comment #3 from Marc V?ron --- Created attachment 63721 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=63721&action=edit Bug 18665: Add test for HtmlTags.pm This patch adds tests for the tt filter HtmlTags.pm To test: prove -v t/HtmlTags.t should pass -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu May 25 22:11:10 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 25 May 2017 20:11:10 +0000 Subject: [Koha-bugs] [Bug 18666] Update 16.06.00.028 failing because of missing no_auto_renewal_after In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18666 Mason James changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |mtj at kohaaloha.com -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu May 25 23:03:09 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 25 May 2017 21:03:09 +0000 Subject: [Koha-bugs] [Bug 18673] New: News author does not display on staff client home page Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18673 Bug ID: 18673 Summary: News author does not display on staff client home page Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Staff Client Assignee: koha-bugs at lists.koha-community.org Reporter: veron at veron.ch QA Contact: testopia at bugs.koha-community.org CC: gmcharlt at gmail.com News authors do not display on staff client homepage, independently of syspref 'NewsAuthorDisplay' To verify: - Create news with display location 'All' - Set syspref NewsAuthorDisplay to 'Staff client only' or 'Both OPAC and staff client' - Go to staff client - Verify that news author does not appear (but it should) -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Thu May 25 23:06:30 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 25 May 2017 21:06:30 +0000 Subject: [Koha-bugs] [Bug 18673] News author does not display on staff client home page In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18673 --- Comment #1 from Marc V?ron --- Created attachment 63722 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=63722&action=edit Bug 18673: News author does not display on staff client home page News authors do not display on staff client homepage, independently of syspref 'NewsAuthorDisplay'. This patch fixes the issue. To verify: - Create news with display location 'All' - Set syspref NewsAuthorDisplay to 'Staff client only' or 'Both OPAC and staff client' - Go to staff client - Verify that news author does not appear (but it should) To test: - Applly patch - Verify that news author is displayed as expected -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Thu May 25 23:07:22 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 25 May 2017 21:07:22 +0000 Subject: [Koha-bugs] [Bug 18673] News author does not display on staff client home page In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18673 Marc V?ron changed: What |Removed |Added ---------------------------------------------------------------------------- Patch complexity|--- |Trivial patch Severity|enhancement |trivial Status|NEW |Needs Signoff Assignee|koha-bugs at lists.koha-commun |veron at veron.ch |ity.org | -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu May 25 23:10:30 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 25 May 2017 21:10:30 +0000 Subject: [Koha-bugs] [Bug 9031] Overdue items crossing DST boundary throw invalid local time exception In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9031 Mason James changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |mtj at kohaaloha.com -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu May 25 23:14:38 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 25 May 2017 21:14:38 +0000 Subject: [Koha-bugs] [Bug 18671] Calendar.t failing exception holiday test In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18671 Mason James changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |mtj at kohaaloha.com -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu May 25 23:15:24 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 25 May 2017 21:15:24 +0000 Subject: [Koha-bugs] [Bug 18137] REST API: Migrate from Mojolicious::Plugin:: Swagger2 to Mojolicious::Plugin::OpenAPI In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18137 Mason James changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |mtj at kohaaloha.com -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu May 25 23:16:37 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 25 May 2017 21:16:37 +0000 Subject: [Koha-bugs] [Bug 18548] running koha-create --request-db without an instance name should abort In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18548 Mason James changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |mtj at kohaaloha.com -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu May 25 23:17:44 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 25 May 2017 21:17:44 +0000 Subject: [Koha-bugs] [Bug 18665] Translatability: Add tt filter to allow html tags inside tt directives In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18665 Mason James changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |mtj at kohaaloha.com -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu May 25 23:18:29 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 25 May 2017 21:18:29 +0000 Subject: [Koha-bugs] [Bug 18289] Fix t/Prices.t having a Test::DBIx::Class cache issue In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18289 Mason James changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |mtj at kohaaloha.com -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu May 25 23:21:05 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 25 May 2017 21:21:05 +0000 Subject: [Koha-bugs] [Bug 18600] Missing db update for TalkingTechItivaPhoneNotification In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18600 Mason James changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |mtj at kohaaloha.com -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri May 26 00:11:04 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 25 May 2017 22:11:04 +0000 Subject: [Koha-bugs] [Bug 15253] Add Koha::Logger based logging for SIP2 In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15253 Brendan Gallagher changed: What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |Needs Signoff CC| |brendan at bywatersolutions.co | |m -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri May 26 00:18:59 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 25 May 2017 22:18:59 +0000 Subject: [Koha-bugs] [Bug 18656] Require confirmation of deletion of files from patron record In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18656 --- Comment #8 from PTFS Europe Sandboxes --- Patch tested with a sandbox, by David Roberts -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri May 26 00:19:13 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 25 May 2017 22:19:13 +0000 Subject: [Koha-bugs] [Bug 18656] Require confirmation of deletion of files from patron record In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18656 PTFS Europe Sandboxes changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #63691|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri May 26 00:19:20 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 25 May 2017 22:19:20 +0000 Subject: [Koha-bugs] [Bug 18656] Require confirmation of deletion of files from patron record In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18656 --- Comment #9 from PTFS Europe Sandboxes --- Created attachment 63723 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=63723&action=edit Bug 18656 - Require confirmation of deletion of files from patron record This patch adds a JavaScript confirm to the deletion of files. It also styles the file deletion link as a Bootstrap button. To test, apply the patch and open the "Files" page for a patron who has files attached. - Verify that clicking any "delete" link prompts for a confirmation. - Verify that confirming the dialog triggers the deletion of the correct file. - Verify that canceling the confirmation dialog aborts the deletion. - Confirm that the "Delete" button looks correct. Signed-off-by: David Roberts -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri May 26 00:20:43 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 25 May 2017 22:20:43 +0000 Subject: [Koha-bugs] [Bug 18656] Require confirmation of deletion of files from patron record In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18656 David Roberts changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |david.roberts at ptfs-europe.c | |om --- Comment #10 from David Roberts --- Katrin, I hope that's working better now. No idea what went wrong last time. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri May 26 02:15:30 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 26 May 2017 00:15:30 +0000 Subject: [Koha-bugs] [Bug 11317] Add a way to access files from the intranet In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11317 M. Tompsett changed: What |Removed |Added ---------------------------------------------------------------------------- CC|mtompset at hotmail.com | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri May 26 05:31:57 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 26 May 2017 03:31:57 +0000 Subject: [Koha-bugs] [Bug 18645] Creation of Koha feature release change tool displayed after running Koha update In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18645 Alex Buckley changed: What |Removed |Added ---------------------------------------------------------------------------- Summary|Creation of informational |Creation of Koha feature |tool displayed after |release change tool |running Koha update |displayed after running | |Koha update -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri May 26 05:51:53 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 26 May 2017 03:51:53 +0000 Subject: [Koha-bugs] [Bug 18260] Koha::Biblio - Remove GetBiblio In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18260 Aleisha Amohia changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Patch doesn't apply CC| |aleisha at catalyst.net.nz --- Comment #2 from Aleisha Amohia --- Patch was unable to apply: Applying: Bug 18260: Koha::Biblio - Remove GetBiblio Using index info to reconstruct a base tree... M C4/Acquisition.pm M C4/Biblio.pm M C4/ILSDI/Services.pm M C4/ImportBatch.pm M C4/Serials.pm M Koha/REST/V1/Hold.pm M catalogue/imageviewer.pl M catalogue/itemsearch.pl M t/db_dependent/Acquisition.t M tools/batch_delete_records.pl Falling back to patching base and 3-way merge... Auto-merging tools/batch_delete_records.pl CONFLICT (content): Merge conflict in tools/batch_delete_records.pl Auto-merging t/db_dependent/Acquisition.t Auto-merging catalogue/itemsearch.pl Auto-merging catalogue/imageviewer.pl Auto-merging Koha/REST/V1/Hold.pm Auto-merging C4/Serials.pm Auto-merging C4/ImportBatch.pm Auto-merging C4/ILSDI/Services.pm Auto-merging C4/Biblio.pm Auto-merging C4/Acquisition.pm Failed to merge in the changes. Patch failed at 0001 Bug 18260: Koha::Biblio - Remove GetBiblio -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri May 26 05:52:01 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 26 May 2017 03:52:01 +0000 Subject: [Koha-bugs] [Bug 18669] RewriteCond affecting wrong rule in koha-httpd.conf In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18669 --- Comment #4 from David Cook --- (In reply to Josef Moravec from comment #3) > I just signed off, because it does work as described, but I am just curious > if we should make the changes from bug 9683 and this bug to debian apache > templates too... Thanks, Josef. I figure it's probably a good idea to update the Debian templates as well, but I imagine that should be a separate bug. Soon, I'm going to set up a Debian virtual machine to test Debian-specific patches so maybe at that point I'll post some patches (or be able to test someone else's). -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri May 26 05:55:07 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 26 May 2017 03:55:07 +0000 Subject: [Koha-bugs] [Bug 18299] Removal of admin/env_tz_test.pl script In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18299 --- Comment #17 from David Cook --- (In reply to Kyle M Hall from comment #15) > (In reply to David Cook from comment #13) > > (In reply to Jonathan Druart from comment #8) > > > I was not aware of this script and I think it does not make sense to have it. > > > I'd prefer to remove it than adding more code to the codebase to maintain it. > > > > > > Opinions? > > > > I was not aware of this script until recently, but I have been using it to > > double-check that I've set up the timezone for Koha correctly in Apache. > > > > I'm OK with removing the script overall, but could we add timezone > > information to the About page in the "Server information" tab? > > Can you file an enhancement bug for that? I imagine we should be able to > make that happen pretty easily. Sounds good. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri May 26 05:56:35 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 26 May 2017 03:56:35 +0000 Subject: [Koha-bugs] [Bug 18674] Show timezone for Perl and MySQL on the About Koha page In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18674 David Cook changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |https://bugs.koha-community | |.org/bugzilla3/show_bug.cgi | |?id=18299 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri May 26 05:56:35 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 26 May 2017 03:56:35 +0000 Subject: [Koha-bugs] [Bug 18299] Removal of admin/env_tz_test.pl script In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18299 David Cook changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |https://bugs.koha-community | |.org/bugzilla3/show_bug.cgi | |?id=18674 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri May 26 05:56:29 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 26 May 2017 03:56:29 +0000 Subject: [Koha-bugs] [Bug 18674] New: Show timezone for Perl and MySQL on the About Koha page Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18674 Bug ID: 18674 Summary: Show timezone for Perl and MySQL on the About Koha page Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: About Assignee: nengard at gmail.com Reporter: dcook at prosentient.com.au QA Contact: testopia at bugs.koha-community.org With the pushing of Bug 18299, we no longer have a quick way of checking the timezone of the Perl and MySQL connection. We should add some code to the About Koha page to show this info. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri May 26 06:07:51 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 26 May 2017 04:07:51 +0000 Subject: [Koha-bugs] [Bug 18649] Translatability: Get rid of tt directive in translation for admin/ categories.tt and onboardingstep2.tt In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18649 Aleisha Amohia changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #63626|0 |1 is obsolete| | --- Comment #3 from Aleisha Amohia --- Created attachment 63724 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=63724&action=edit Bug 18649: Translatability: Get rid of tt directive in translation for admin/categories.tt and onboardingstep2.tt Translation tool shows [% IF category.enrolmentperiod %][% category.enrolmentperiod %][% END %] for en/modules/admin/categories.tt and koha-tmpl/intranet-tmpl/prog/en/modules/onboarding/onboardingstep2.tt This patch fixes it. To test: - Apply patch - Verify that code changes make sense - Verify that template directive is no longer picked by translation https://bugs.koha-community.org/show_bug.cgi?id=18641 Patch works as expected for me - also this is a really great way to do this kind of fix! We should have this all over Koha. Signed-off-by: Aleisha Amohia -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri May 26 06:07:47 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 26 May 2017 04:07:47 +0000 Subject: [Koha-bugs] [Bug 18649] Translatability: Get rid of tt directive in translation for admin/ categories.tt and onboardingstep2.tt In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18649 Aleisha Amohia changed: What |Removed |Added ---------------------------------------------------------------------------- Patch complexity|--- |Small patch Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri May 26 07:59:49 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 26 May 2017 05:59:49 +0000 Subject: [Koha-bugs] [Bug 18600] Missing db update for TalkingTechItivaPhoneNotification In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18600 Marcel de Rooy changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri May 26 07:59:52 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 26 May 2017 05:59:52 +0000 Subject: [Koha-bugs] [Bug 18600] Missing db update for TalkingTechItivaPhoneNotification In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18600 Marcel de Rooy changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #63680|0 |1 is obsolete| | --- Comment #5 from Marcel de Rooy --- Created attachment 63725 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=63725&action=edit Bug 18600: Add pref TalkingTechItivaPhoneNotification if missing Signed-off-by: Katrin Fischer Signed-off-by: Marcel de Rooy -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri May 26 08:00:13 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 26 May 2017 06:00:13 +0000 Subject: [Koha-bugs] [Bug 18600] Missing db update for TalkingTechItivaPhoneNotification In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18600 Marcel de Rooy changed: What |Removed |Added ---------------------------------------------------------------------------- QA Contact|testopia at bugs.koha-communit |m.de.rooy at rijksmuseum.nl |y.org | CC| |m.de.rooy at rijksmuseum.nl -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri May 26 08:11:26 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 26 May 2017 06:11:26 +0000 Subject: [Koha-bugs] [Bug 18664] IssueSlip.t is failing - IssueSlip should return if params are not valid In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18664 Marcel de Rooy changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri May 26 08:11:46 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 26 May 2017 06:11:46 +0000 Subject: [Koha-bugs] [Bug 18664] IssueSlip.t is failing - IssueSlip should return if params are not valid In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18664 Marcel de Rooy changed: What |Removed |Added ---------------------------------------------------------------------------- QA Contact|testopia at bugs.koha-communit |m.de.rooy at rijksmuseum.nl |y.org | Patch complexity|--- |Small patch CC| |m.de.rooy at rijksmuseum.nl -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri May 26 08:11:29 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 26 May 2017 06:11:29 +0000 Subject: [Koha-bugs] [Bug 18664] IssueSlip.t is failing - IssueSlip should return if params are not valid In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18664 Marcel de Rooy changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #63682|0 |1 is obsolete| | --- Comment #3 from Marcel de Rooy --- Created attachment 63726 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=63726&action=edit Bug 18664: Make IssueSlip returns if params are not valid Problem raised by bug 17762: IssueSlip should return if the params are not valid. The tests contain 2 FIXME to highlight this problem already, it's time to fix them. Note that, theoretically, this change may produce software error. Indeed the caller expecting a hashref (letter) will access the "content" key. But that should not happen. Test plan: Tests must return green Signed-off-by: Josef Moravec Signed-off-by: Josef Moravec Signed-off-by: Marcel de Rooy -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri May 26 08:19:48 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 26 May 2017 06:19:48 +0000 Subject: [Koha-bugs] [Bug 18632] CGI::param called in list context flooding erro logs In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18632 Marcel de Rooy changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA Patch complexity|--- |Small patch -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri May 26 08:19:50 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 26 May 2017 06:19:50 +0000 Subject: [Koha-bugs] [Bug 18632] CGI::param called in list context flooding erro logs In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18632 Marcel de Rooy changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #63610|0 |1 is obsolete| | --- Comment #3 from Marcel de Rooy --- Created attachment 63727 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=63727&action=edit Bug 18632: Remove 'CGI::param called in list context' warnings Once again, after bug 16154 and bug 16259 we need to remove more occurrence of CGi->param called in list context. Refer to bug 15809 for more information. Test plan: Make sure you do not see the error on the modified scripts. Signed-off-by: Josef Moravec Signed-off-by: Marcel de Rooy -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri May 26 08:20:14 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 26 May 2017 06:20:14 +0000 Subject: [Koha-bugs] [Bug 18632] CGI::param called in list context flooding erro logs In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18632 Marcel de Rooy changed: What |Removed |Added ---------------------------------------------------------------------------- QA Contact|testopia at bugs.koha-communit |m.de.rooy at rijksmuseum.nl |y.org | CC| |m.de.rooy at rijksmuseum.nl -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri May 26 09:41:15 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 26 May 2017 07:41:15 +0000 Subject: [Koha-bugs] [Bug 18649] Translatability: Get rid of tt directive in translation for admin/ categories.tt and onboardingstep2.tt In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18649 --- Comment #4 from Marc V?ron --- (In reply to Aleisha Amohia from comment #3) (...) > > Patch works as expected for me - also this is a really great way to do > this kind of fix! We should have this all over Koha. > Signed-off-by: Aleisha Amohia Hi Aleisha Thanks for testing and for your comment :-) Some of the translatability issues (not with this bug though) are related to html tags inside of tt directives. I filed an enhancement for that (Bug 18665 - Needs SO). Marc -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri May 26 09:52:29 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 26 May 2017 07:52:29 +0000 Subject: [Koha-bugs] [Bug 3005] Record deletion successful In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=3005 Josef Moravec changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |josef.moravec at gmail.com -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri May 26 10:12:14 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 26 May 2017 08:12:14 +0000 Subject: [Koha-bugs] [Bug 18625] update borrower last seen from SIP In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18625 Benjamin Rokseth changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |benjamin.rokseth at kul.oslo.k | |ommune.no --- Comment #2 from Benjamin Rokseth --- Very nice. I totally agree with the proposal, as our patrons mainly operate self-serviced, and we currently have no option to register who's active or not. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri May 26 10:27:24 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 26 May 2017 08:27:24 +0000 Subject: [Koha-bugs] [Bug 18611] Create labels action fails in manage-marc-import.pl if an item has been deleted from the import batch. In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18611 Marcel de Rooy changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA Patch complexity|Trivial patch |Small patch -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri May 26 10:27:27 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 26 May 2017 08:27:27 +0000 Subject: [Koha-bugs] [Bug 18611] Create labels action fails in manage-marc-import.pl if an item has been deleted from the import batch. In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18611 Marcel de Rooy changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #63667|0 |1 is obsolete| | --- Comment #6 from Marcel de Rooy --- Created attachment 63728 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=63728&action=edit Bug 18611 - Create labels action fails in manage-marc-import.pl if an item has been deleted from the import batch. To test: 1 - Import a batch with some items 2 - Delete one of the imported items 3 - Browse to Tools->Staged MARC record management 4 - Click (Create label batch) for the batch you imported 5 - Recieve an error 6 - Apply patch 7 - Click (Create label batch) 8 - Batch is created with remaning items from the import Signed-off-by: Josef Moravec Signed-off-by: Josef Moravec Signed-off-by: Marcel de Rooy -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri May 26 10:27:32 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 26 May 2017 08:27:32 +0000 Subject: [Koha-bugs] [Bug 18611] Create labels action fails in manage-marc-import.pl if an item has been deleted from the import batch. In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18611 Marcel de Rooy changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #63669|0 |1 is obsolete| | --- Comment #7 from Marcel de Rooy --- Created attachment 63729 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=63729&action=edit Bug 18611 - Followup, remove tabs to make qa tools happy Signed-off-by: Josef Moravec Signed-off-by: Marcel de Rooy -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri May 26 10:27:36 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 26 May 2017 08:27:36 +0000 Subject: [Koha-bugs] [Bug 18611] Create labels action fails in manage-marc-import.pl if an item has been deleted from the import batch. In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18611 --- Comment #8 from Marcel de Rooy --- Created attachment 63730 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=63730&action=edit Bug 18611: [QA Follow-up] Make SQL query more readable Make it more explicit by adding join statements. Test plan: See next patch for adding a unit test. Signed-off-by: Marcel de Rooy -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri May 26 10:27:40 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 26 May 2017 08:27:40 +0000 Subject: [Koha-bugs] [Bug 18611] Create labels action fails in manage-marc-import.pl if an item has been deleted from the import batch. In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18611 --- Comment #9 from Marcel de Rooy --- Created attachment 63731 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=63731&action=edit Bug 18611: [QA Follow-up] Add unit test for GetItemNumbersFromImportBatch Test plan: Run t/db_dependent/ImportBatch.t Signed-off-by: Marcel de Rooy -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri May 26 10:28:13 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 26 May 2017 08:28:13 +0000 Subject: [Koha-bugs] [Bug 18611] Create labels action fails in manage-marc-import.pl if an item has been deleted from the import batch. In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18611 Marcel de Rooy changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|cnighswonger at foundations.ed |nick at bywatersolutions.com |u | CC| |m.de.rooy at rijksmuseum.nl QA Contact|testopia at bugs.koha-communit |m.de.rooy at rijksmuseum.nl |y.org | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri May 26 10:59:53 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 26 May 2017 08:59:53 +0000 Subject: [Koha-bugs] [Bug 18478] Some notices sent via SMS gateway fail In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18478 Marcel de Rooy changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |m.de.rooy at rijksmuseum.nl --- Comment #14 from Marcel de Rooy --- (In reply to Nick Clemens from comment #13) > (In reply to Jonathan Druart from comment #10) > > The call to _update_message_to_address just before _send_message_by_email > > should not be needed, it is already called from _send_message_by_email. > > I think it is only called there is the address was blank, we are fixing it > before that call so need to update Yes, thats what I understand too. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri May 26 11:06:29 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 26 May 2017 09:06:29 +0000 Subject: [Koha-bugs] [Bug 18675] New: Translatability: Get rid of [ %% in translation for csv-profiles.tt Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18675 Bug ID: 18675 Summary: Translatability: Get rid of [%% in translation for csv-profiles.tt Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: trivial Priority: P5 - low Component: I18N/L10N Assignee: koha-bugs at lists.koha-community.org Reporter: veron at veron.ch QA Contact: testopia at bugs.koha-community.org CC: frederic at tamil.fr Translation tool for file csv-profiles.tt picks following line: %s [%% IF csv_profile.encoding == encoding OR NOT csv_profile AND encoding == 'utf8' %%] This is due to a line break inside a template directive. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri May 26 11:08:20 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 26 May 2017 09:08:20 +0000 Subject: [Koha-bugs] [Bug 18675] Translatability: Get rid of [ %% in translation for csv-profiles.tt In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18675 Marc V?ron changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|koha-bugs at lists.koha-commun |veron at veron.ch |ity.org | -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Fri May 26 11:11:14 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 26 May 2017 09:11:14 +0000 Subject: [Koha-bugs] [Bug 18675] Translatability: Get rid of [ %% in translation for csv-profiles.tt In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18675 --- Comment #1 from Marc V?ron --- Created attachment 63732 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=63732&action=edit Bug 18675: Translatability: Get rid of [%% in translation for csv-profiles.tt Translation tool for file csv-profiles.tt picks following line: %s [%% IF csv_profile.encoding == encoding OR NOT csv_profile AND encoding == 'utf8' %%] It is is due to a line break inside a template directive. This patch removes it. To test: - Verify that code change makes sense - Apply patch - Verify that csv exports behave as before -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri May 26 11:12:03 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 26 May 2017 09:12:03 +0000 Subject: [Koha-bugs] [Bug 18675] Translatability: Get rid of [ %% in translation for csv-profiles.tt In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18675 Marc V?ron changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff Patch complexity|--- |String patch -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri May 26 11:32:50 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 26 May 2017 09:32:50 +0000 Subject: [Koha-bugs] [Bug 18620] t/db_dependent/Letters.t failing on master In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18620 Marcel de Rooy changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri May 26 11:32:53 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 26 May 2017 09:32:53 +0000 Subject: [Koha-bugs] [Bug 18620] t/db_dependent/Letters.t failing on master In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18620 Marcel de Rooy changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #63628|0 |1 is obsolete| | --- Comment #9 from Marcel de Rooy --- Created attachment 63733 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=63733&action=edit Bug 18620 - t/db_dependent/Letters.t failing on master To test: 1 - Set SMSSenDriver to 'Email' 2 - prove t/db_dependent/Letters.t 3 - Tests fail 4 - Apply patch 5 - prove t/db_dependent/Letters.t 6 - Less tests fail (should be 2 sms test failures) 7 - Set SMSSendDriver to another value or blank 8 - prove t/db_dependent/Letters.t 9 - Tests pass Signed-off-by: Marc V?ron Signed-off-by: Tomas Cohen Arazi Signed-off-by: Marcel de Rooy -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri May 26 11:34:11 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 26 May 2017 09:34:11 +0000 Subject: [Koha-bugs] [Bug 18478] Some notices sent via SMS gateway fail In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18478 Marcel de Rooy changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #63504|0 |1 is obsolete| | --- Comment #15 from Marcel de Rooy --- Created attachment 63734 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=63734&action=edit Bug 18478 - Some notices sent via SMS gateway fail It seems that for HOLD and DUE (and maybe more) notices we rely on C4::Letters::SendQueuedMessages to populate the correct address. This patch adjust that subroutine to correctly populate the field and/or fail messages if no SMS provider available To test: 1 - Define a messaging prefs for a patron to recieve hold notices via SMS 2 - Ensure you have defined an SMS message for 'HOLD' letter 3 - Set an SMS alert number for patron 4 - Set the SMS::Send driver to 'Email' 5 - Fill a hold for the patron 6 - Check the db and note the address is null 7 - run process_message_queue.pl 8 - Check db - address is null and message pending 9 - Apply patch 10 - run process_message_queue 11 - Message to_address should be populated and message sent Signed-off-by: Marcel de Rooy -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri May 26 11:34:20 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 26 May 2017 09:34:20 +0000 Subject: [Koha-bugs] [Bug 18478] Some notices sent via SMS gateway fail In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18478 Marcel de Rooy changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #63506|0 |1 is obsolete| | --- Comment #17 from Marcel de Rooy --- Created attachment 63736 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=63736&action=edit Bug 18478 - Additional unit tests This method was not previously covered, we don't change it , but no reason to throw away these tests to ensure messages are created as expected To test: 1 - Apply this patch first 2 - Prove t/db_dependent/Reserves.t 3 - Last tests fail 4 - Apply other patch 5 - All tests should pass Signed-off-by: Marcel de Rooy -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri May 26 11:34:24 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 26 May 2017 09:34:24 +0000 Subject: [Koha-bugs] [Bug 18478] Some notices sent via SMS gateway fail In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18478 Marcel de Rooy changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #63675|0 |1 is obsolete| | --- Comment #18 from Marcel de Rooy --- Created attachment 63737 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=63737&action=edit Bug 18478 - QA Followup Make sure to build necessary letters Fix awkward construction Signed-off-by: Marcel de Rooy -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri May 26 11:34:28 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 26 May 2017 09:34:28 +0000 Subject: [Koha-bugs] [Bug 18478] Some notices sent via SMS gateway fail In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18478 --- Comment #19 from Marcel de Rooy --- Created attachment 63738 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=63738&action=edit Bug 18620: [QA Follow-up] Move the final rollback to the very end The new subtest in Reserves.t does not need its own transaction. Move the original rollback to the very end of the test. Signed-off-by: Marcel de Rooy -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri May 26 11:34:16 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 26 May 2017 09:34:16 +0000 Subject: [Koha-bugs] [Bug 18478] Some notices sent via SMS gateway fail In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18478 Marcel de Rooy changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #63505|0 |1 is obsolete| | --- Comment #16 from Marcel de Rooy --- Created attachment 63735 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=63735&action=edit Bug 18478 - Unit tests Signed-off-by: Marcel de Rooy -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri May 26 11:34:52 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 26 May 2017 09:34:52 +0000 Subject: [Koha-bugs] [Bug 18478] Some notices sent via SMS gateway fail In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18478 Marcel de Rooy changed: What |Removed |Added ---------------------------------------------------------------------------- QA Contact|testopia at bugs.koha-communit |m.de.rooy at rijksmuseum.nl |y.org | Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri May 26 11:35:48 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 26 May 2017 09:35:48 +0000 Subject: [Koha-bugs] [Bug 18676] New: Optionally delete fast add items and records on return Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18676 Bug ID: 18676 Summary: Optionally delete fast add items and records on return Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Circulation Assignee: koha-bugs at lists.koha-community.org Reporter: katrin.fischer at bsz-bw.de QA Contact: testopia at bugs.koha-community.org CC: gmcharlt at gmail.com, kyle.m.hall at gmail.com In some libraries fast adds are used for ILL or other material that's not supposed to stay in the catalog after circulation was completed. It would be nice if there as an option to automatically delete fast add items and records (if it was the last item) when the item is checked-in. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri May 26 11:41:40 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 26 May 2017 09:41:40 +0000 Subject: [Koha-bugs] [Bug 5395] C4::Acquisition::SearchOrder POD inconsistent with function In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5395 Marcel de Rooy changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. You are the QA Contact for the bug. From bugzilla-daemon at bugs.koha-community.org Fri May 26 11:41:43 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 26 May 2017 09:41:43 +0000 Subject: [Koha-bugs] [Bug 5395] C4::Acquisition::SearchOrder POD inconsistent with function In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5395 Marcel de Rooy changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #63717|0 |1 is obsolete| | --- Comment #8 from Marcel de Rooy --- Created attachment 63739 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=63739&action=edit Bug 5395: Update C4::Acquisition::SearchOrders POD Comparing the perldoc to the function: - basketname - basketgroupname - budget_id Were missing. This adds them. Also, a description of ordernumber and search were added, as they are not self-evident by their name alone. There are no code changes, so all tests should pass or fail identically before and after patch. Signed-off-by: Katrin Fischer Fixed typo basetgroupname Signed-off-by: Marcel de Rooy -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri May 26 11:42:02 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 26 May 2017 09:42:02 +0000 Subject: [Koha-bugs] [Bug 5395] C4::Acquisition::SearchOrder POD inconsistent with function In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5395 Marcel de Rooy changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |m.de.rooy at rijksmuseum.nl QA Contact|koha-bugs at lists.koha-commun |m.de.rooy at rijksmuseum.nl |ity.org | -- You are receiving this mail because: You are watching all bug changes. You are the QA Contact for the bug. From bugzilla-daemon at bugs.koha-community.org Fri May 26 11:48:48 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 26 May 2017 09:48:48 +0000 Subject: [Koha-bugs] [Bug 9031] Overdue items crossing DST boundary throw invalid local time exception In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9031 Marcel de Rooy changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Failed QA CC| |m.de.rooy at rijksmuseum.nl --- Comment #12 from Marcel de Rooy --- Not sure if this is the right way to fix it. Note that we also use time_zone floating. See for instance is_holiday. Please convince me that we really need UTC here. Also it would be helpful to add unit tests that make the error visible and show that you resolve it. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri May 26 11:50:22 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 26 May 2017 09:50:22 +0000 Subject: [Koha-bugs] [Bug 18656] Require confirmation of deletion of files from patron record In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18656 Marcel de Rooy changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |m.de.rooy at rijksmuseum.nl --- Comment #11 from Marcel de Rooy --- String changes. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri May 26 12:05:14 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 26 May 2017 10:05:14 +0000 Subject: [Koha-bugs] [Bug 18669] RewriteCond affecting wrong rule in koha-httpd.conf In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18669 Marcel de Rooy changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #63711|0 |1 is obsolete| | --- Comment #5 from Marcel de Rooy --- Created attachment 63740 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=63740&action=edit Bug 18669 - RewriteCond affecting wrong rule in koha-httpd.conf One of the RewriteCond directives in koha-httpd.conf was affecting the wrong RewriteRule after its original RewriteRule was commented out years ago. _TEST PLAN_ 0) Before applying patch, build Koha from source *) make *) make install (or make upgrade) *) Copy or symlink etc/koha-httpd.conf to your Apache vhost directory (and enable if you're on a Debian based system) *) Restart Apache 1) Make sure that you have at least 1 bibliographic record in Koha (URL like this http://server:port/cgi-bin/koha/opac-detail.pl?biblionumber=1) 2) Go to http://server:port/bib/1 3) Note that you get a 404 error 4) Apply the patch 5) Rebuild Koha from source as per step 0 6) Go to http://server:port/bib/1 7) Note that you now see the same page as you would if you went to http://server:port/cgi-bin/koha/opac-detail.pl?biblionumber=1 Signed-off-by: Josef Moravec Signed-off-by: Marcel de Rooy -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri May 26 12:05:23 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 26 May 2017 10:05:23 +0000 Subject: [Koha-bugs] [Bug 18669] RewriteCond affecting wrong rule in koha-httpd.conf In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18669 Marcel de Rooy changed: What |Removed |Added ---------------------------------------------------------------------------- QA Contact|testopia at bugs.koha-communit |m.de.rooy at rijksmuseum.nl |y.org | CC| |m.de.rooy at rijksmuseum.nl -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri May 26 12:05:11 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 26 May 2017 10:05:11 +0000 Subject: [Koha-bugs] [Bug 18669] RewriteCond affecting wrong rule in koha-httpd.conf In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18669 Marcel de Rooy changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri May 26 12:05:38 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 26 May 2017 10:05:38 +0000 Subject: [Koha-bugs] [Bug 9031] Overdue items crossing DST boundary throw invalid local time exception In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9031 Marcel de Rooy changed: What |Removed |Added ---------------------------------------------------------------------------- QA Contact| |m.de.rooy at rijksmuseum.nl -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri May 26 12:26:24 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 26 May 2017 10:26:24 +0000 Subject: [Koha-bugs] [Bug 18649] Translatability: Get rid of tt directive in translation for admin/ categories.tt and onboardingstep2.tt In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18649 Marcel de Rooy changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |m.de.rooy at rijksmuseum.nl --- Comment #5 from Marcel de Rooy --- Hi Marc, What is the advantage of value="[%- category.enrolmentperiod IF category.enrolmentperiod -%]" above e.g. value="[% category.enrolmentperiod %]" ? I guess that if period == 0, the first one will leave the field empty? Null and empty string will probably respond the same. Note that the trailing IF does not increase readability. Before making this kind of changes everywhere, is there a consensus to do so? Also noting that you add chomps here (%-). Do we need them here? -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri May 26 12:39:38 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 26 May 2017 10:39:38 +0000 Subject: [Koha-bugs] [Bug 18677] New: issue_id is not added to accountlines for lost item fees Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18677 Bug ID: 18677 Summary: issue_id is not added to accountlines for lost item fees Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: normal Priority: P5 - low Component: Architecture, internals, and plumbing Assignee: gmcharlt at gmail.com Reporter: nick at bywatersolutions.com QA Contact: testopia at bugs.koha-community.org -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri May 26 12:39:55 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 26 May 2017 10:39:55 +0000 Subject: [Koha-bugs] [Bug 18677] issue_id is not added to accountlines for lost item fees In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18677 Nick Clemens changed: What |Removed |Added ---------------------------------------------------------------------------- Component|Architecture, internals, |Database |and plumbing | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri May 26 12:40:22 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 26 May 2017 10:40:22 +0000 Subject: [Koha-bugs] [Bug 18677] issue_id is not added to accountlines for lost item fees In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18677 Nick Clemens changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|gmcharlt at gmail.com |kyle at bywatersolutions.com -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri May 26 13:13:24 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 26 May 2017 11:13:24 +0000 Subject: [Koha-bugs] [Bug 18678] New: Bester SupporT@!!(( 1~*844~*836~*6100++@@APPLE phone number, APPLE support phone number Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18678 Bug ID: 18678 Summary: Bester SupporT@!!((1~*844~*836~*6100++@@APPLE phone number, APPLE support phone number Change sponsored?: --- Product: Koha Version: unspecified Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Browser compatibility Assignee: oleonard at myacpl.org Reporter: yocex at refurhost.com QA Contact: testopia at bugs.koha-community.org Bester SupporT@!!((1~*844~*836~*6100++@@APPLE phone number, APPLE support phone number Bester SupporT@!!((1~*844~*836~*6100++@@APPLE phone number, APPLE support phone number Bester SupporT@!!((1~*844~*836~*6100++@@Popular Tech Support Phone Number"""18448366100"""" APPLE support phone number Popular Tech Support Phone Number"""18448366100"""" APPLE support phone number Popular Tech Support Phone Number"""18448366100"""" APPLE support phone number Popular Tech Support Phone Number"""18448366100"""" APPLE support phone number v Popular Tech Support Phone Number"""18448366100"""" APPLE support phone number Popular Tech Support Phone Number"""18448366100"""" APPLE support phone number anY+tIme+SecUrity 4 APPLE..@@1844~836~6100**APPLE support phone number APPLE email support phone number APPLE tech support phone number APPLE mail contact number APPLE helpline customer care toll free phone number acTivate OR Reset APPLE PasswoRD +1*844*836*6100 APPLE (Technical)Support (Phone number) Toll Free (Helpline Number) acTivate OR Reset APPLE PasswoRD +1*844*836*6100 APPLE (Technical)Support (Phone number) Toll Free (Helpline Number) acTivate OR Reset APPLE PasswoRD +1*844*836*6100 APPLE (Technical)Support (Phone number) Toll Free (Helpline Number) USA~1-844-836-6100 APPLE Support phone number APPLE Technical Support phone number Helpline Number++ USA~1-844-836-6100 APPLE Support phone number APPLE Technical Support phone number Helpline Number USA~1-844-836-6100 APPLE Support phone number APPLE Technical Support phone number Helpline Number USA~1-844-836-6100 APPLE Support phone number APPLE Technical Support phone number Helpline Number USA~1-844-836-6100 APPLE Support phone number APPLE Technical Support phone number Helpline Number USA~1-844-836-6100 APPLE Support phone number APPLE Technical Support phone number Helpline Number USA~1-844-836-6100 APPLE Support phone number APPLE Technical Support phone number Helpline Number USA~1-844-836-6100 APPLE Support phone number APPLE Technical Support phone number Helpline Number USA~1-844-836-6100 APPLE Support phone number APPLE Technical Support phone number Helpline Number USA~1-844-836-6100 APPLE Support phone number APPLE Technical Support phone number Helpline Number USA~1-844-836-6100 APPLE Support phone number APPLE Technical Support phone number Helpline Number USA~1-844-836-6100 APPLE Support phone number APPLE Technical Support phone number Helpline Number USA~1-844-836-6100 APPLE Support phone number APPLE Technical Support phone number Helpline Number USA~1-844-836-6100 APPLE Support phone number APPLE Technical Support phone number Helpline Number USA~1-844-836-6100 APPLE Support phone number APPLE Technical Support phone number Helpline Number USA~1-844-836-6100 APPLE Support phone number APPLE Technical Support phone number Helpline Number USA~1-844-836-6100 APPLE Support phone number APPLE Technical Support phone number Helpline Number USA~1-844-836-6100 APPLE Support phone number APPLE Technical Support phone number Helpline Number USA~1-844-836-6100 APPLE Support phone number APPLE Technical Support phone number Helpline Number !!@@@@!USA**CANADA+@@@@((1-844-836-6100)) APPLE Support phone number APPLE phone number++ Asked by dfgdgdfgdf 55 seconds ago @@!USA**CANADA+@@@@1~844~836~6100 APPLE Support phone number APPLE phone number Dec 26, 20026 views0 Likes0 CommentsShare on LinkedInShare on APPLEShare on Twitter !USA**CANADA+@@@@1~844~836~6100 APPLE Support phone number APPLE phone number Oct 21, 20161 view0 Likes0 CommentsShare on LinkedInShare on APPLEShare on Twitter Hlp desk @@((1~*844~*836~*6100)) APPLE phone number APPLE tech support phone number ConTAct@%1~*844~*836~*6100@% APPLE phone number APPLE tech support phone number all APPLE ? +1~*(844~836~6100) Customer Service Phone Number Bester SupporT@!!((1~*844~*836~*6100++@@APPLE phone number, APPLE support phone number APPLE phone support number APPLE support contact number APPLE support email address APPLE support phone number APPLE support telephone number APPLE tech support number APPLE tech support phone number APPLE tech support phone number free APPLE technical support phone number APPLE technologies phone number APPLE telephone support number APPLE support telephone number usa APPLE customer service number APPLE plus tech support APPLE technical support phone number APPLE technical support number APPLE technical support help desk phone number APPLE technical support number toll free numberrrrrrrrrrrrrrrrrrrrrrrrrrrrrrrrrrrrrrrrr APPLE technical support phone number APPLE customer support phone number APPLE customer service phone number APPLE customer support phone number APPLE customer service phone number phone number for APPLE customer serviceeeeeeeeeeeeeeeeeeeeeeeeeeeeeeeeeeeeeeeeeeeeeeeeeee contact APPLE customer service phone number APPLE customer service phone number phone number for APPLE customer service APPLE security support phone number APPLE internet security support phone number phone number for APPLE security APPLE internet security phone number in usa APPLE contact phone number in usa APPLE security contact phone number APPLE help desk phone number in usa APPLE tech support phone number free in usa APPLE support phone number APPLE phone number support for technical issue in usaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaa phone number for APPLE technical support APPLE customer service telephone number APPLE toll free customer care number APPLE technical support number APPLE tech support phone number APPLE support phone number APPLE customer support phone number APPLE technical support phone number APPLE technical support phone number usa phone number for APPLE technical supporttttttttttttttttttttttttttttttttttttttttttttttttttt APPLE customer service phone number usa APPLE customer service number APPLE technical support number usa APPLE customer support number APPLE tech support number phone number for APPLE support APPLE support phone number usa APPLE phone number customer serviceeeeeeeeeeeeeeeeeeeeeeeeeeeeeeeeeeeeeeeeeeeeeeeeeeee APPLE phone number tech support APPLE contact phone number usa APPLE contact phone number what is the phone number for APPLE customer service APPLE gold support phone number APPLE phone number support APPLE security phone number APPLE customer service number usa APPLE contact number usa APPLE usa phone number APPLE support number usa APPLE tech support number usa FrEE Calling call@@++((1.844-836-6100==++APPLE tech support phone number, APPLE techncial support phone number DADU's call&&=1 844 836 6100@@ APPLE customer service phone number, APPLE customer support phone number GAliB Wha! @@1 - 844 ~836~ 6100///APPLE phone number APPLE toll free number Freekly Call AT 1 844 836 6100 APPLE tech support phone number ContAct@%1* - 844* ~836~ *6100@% APPLE tech support number APPLE tech support phone number APPLE customer care number. Contact@%1~*844~*836~*6100@% APPLE tech support number APPLE tech support phone number APPLE customer service phone number. APPLE customer service number APPLE customer service phone number APPLE technical support number ContactAPPLE support APPLE phone number APPLE online support APPLE customer service number APPLE tech support center APPLE customer service APPLE customer care number usa APPLE customer number APPLE customer support number APPLE customer care number APPLE customer care toll free number APPLE tech support APPLE technical support APPLE support APPLE tech support APPLE support center APPLE .com customer service APPLE customer care number APPLE customer care APPLE phone number phone number for APPLE customer service APPLE phone support APPLE phone number tech support APPLE support phone number contact APPLE by phone APPLE contact phone number APPLE helpline phone number APPLE phone APPLE for phone APPLE contact number APPLE contact support contact APPLE APPLE contact number usa APPLE toll free number APPLE telephone number APPLE toll free number usa APPLE support services technical support for APPLE APPLE customer service phone number usa APPLE customer care number usa APPLE customer care number APPLE customer care center APPLE customer support APPLE customer support phone APPLE customer help APPLE anitivirus phone number, APPLE phone number, APPLE support phone number, APPLE tech support phone number, APPLE customer support phone number, APPLE tech support phone number, APPLE helpline number, APPLE helpdesk phone number, APPLE toll free number, APPLE contact number, APPLE telephone number. APPLE phone number, APPLE support phone number, APPLE techncal support phone number. APPLE technical support number APPLE tech support number APPLE customer support number APPLE customer service phone number APPLE helpline number APPLE contact number APPLE telephone number APPLE customer & technical support APPLE customer portal APPLE customer care phone number usa APPLE customer care email APPLE helpline APPLE tech support contact APPLE customer care toll free APPLE customer service number APPLE protection APPLE customer service number APPLE software customer service number APPLE customer service phone number us how to contact APPLE by email APPLE free phone support APPLE technical support phone number APPLE technical support number APPLE technical support help desk phone number APPLE technical support number toll free number APPLE technical support phone number APPLE customer support phone number APPLE customer service phone number APPLE technical support number APPLE technical support phone number APPLE tech support number APPLE customer support APPLE customer service phone number APPLE technical support reviews telephone APPLE APPLE tech support phone number APPLE tech support phone number APPLE customer service billing APPLE customer service email address APPLE customer service reviews contact APPLE customer service APPLE tech support number usa APPLE contact number APPLE customer service phone number APPLE tech support phone APPLE tech support number APPLE customer service telephone number APPLE customer support number APPLE customer support phone number APPLE customer service phone number contact APPLE customer service phone number APPLE security support phone number APPLE internet security phone number in usa APPLE contact phone number in usa APPLE tech support phone number free in usa APPLE phone number support for technical issue in usa phone number for APPLE technical support APPLE customer service telephone number APPLE toll free customer care number APPLE customer service telephone number APPLE support telephone number APPLE support telephone number APPLE technical support phone number APPLE customer service phone number APPLE phone number customer service APPLE customer support phone number APPLE security phone number customer service phone number for APPLE customer service APPLE customer support phone number APPLE help desk support phone number free in usa phone number for APPLE technical support APPLE technical support number free in usa APPLE technical support cutomer phone number APPLE internet security technical support APPLE customer support number APPLE customer service number APPLE customer service billing APPLE customer service email address APPLE phone number customer service us APPLE phone number support APPLE support phone number APPLE tech support phone number APPLE technical support number APPLE telephone number APPLE customer care phone number APPLE support phone number phone number for APPLE APPLE phone number support APPLE phone support number phone number for APPLE support APPLE phone support APPLE technical support phone number APPLE technical support number APPLE technical support APPLE technical support number APPLE technical support APPLE internet security technical support APPLE customer support number APPLE customer service phone APPLE customer service telephone number APPLE customer services email APPLE customer support email address APPLE customer support phone number APPLE internet security contact phone number APPLE internet security customer service phone number APPLE phone number customer service APPLE phone numbers customer support APPLE Email Toll Free Phone Number 1844 836 6100 APPLE Customer Service Number APPLE password recovery phone number reset APPLE email password APPLE Email Toll Free Phone Number 1844 836 6100 APPLE Customer Service Number APPLE, Customer Service USA-CANADA APPLE Mail support APPLE was founded by - Bill von Meister. Customer service: +1 844-836-6100 Founded: May 24, 1985, United States of America APPLE is an American multinational mass media. APPLE is based on New York. APPLE is a mail that is specially used for News, Weather, Entertainment, Finance, Lifestyle and many more thing. APPLE Support keywords such as APPLE customer service, APPLE customer support, APPLE support Number , APPLE tech support Number etc. We have experienced APPLE support team, our team able to find out APPLE issue and provide best solution as soon as possible. Our APPLE support Number (Toll-Free)-18448366100. APPLE is most important for News, Weather, Entertainment, Finance. APPLE user face many different problems arises specially in mail account so APPLE Mail Sign UP Error - APPLE Customer Service APPLE user mainly search these(below) keywords- APPLE support Number APPLE customer service APPLE customer support APPLE support APPLE Support Number APPLE Mail Tech Support Number APPLE tech support Number APPLE support Number APPLE mail support Number APPLE mail recover password APPLE helpline Number APPLE mail account APPLE customer service phone Number APPLE Mail Mail technical support Number APPLE Contact Mail support APPLE Mail phone Number APPLE Mail online support APPLE customer service Number APPLE tech support center APPLE customer service APPLE customer care Number USA APPLE customer Number APPLE customer support Number APPLE customer care Number APPLE customer care toll free Number APPLE tech support APPLE technical support APPLE Mail support APPLE Mail tech support APPLE support center APPLE.com customer service APPLE Mail customer care Number APPLE customer care APPLE phone Number APPLE phone support APPLE phone Number tech support APPLE support phone Number contact APPLE by phone APPLE contact phone Number APPLE helpline phone Number APPLE Mail phone APPLE Mail for phone APPLE Mail Sign UP Error - APPLE Customer Service WiFi APPLE Mail customer service Number APPLE Mail tech support Number ,APPLE Mail customer service Number ,APPLE wireless Mail tech support Number NORTH CAROLINA APPLE tech support Number , APPLE Mail customer service Number ,APPLE wireless Mail tech support Number USA & Canada. APPLE Mail Technical Support Number , APPLE Mail support phone Number . APPLE Mail Support Phone Number APPLE tech support Number . APPLE Mail customer service phone Number APPLE technical support Number 18448366100. APPLE Mail customer Care phone Number APPLE tech support Number . APPLE help desk support phone Number APPLE Customer support phone Number APPLE tech support Number , APPLE tech support phone Number , APPLE customer support phone Number here. APPLE tech support Number . APPLE Technical support Number . APPLE support phone Number . APPLE customer service phone Number APPLE customer care Number APPLE help desk phone Number APPLE helpline phone Number . APPLE contact phone Number 18448366100 APPLE tech support Number , APPLE tech support phone Number , APPLE customer support phone Number here. APPLE tech support Number . APPLE Technical support Number @@ APPLE support phone Number . APPLE customer service phone Number APPLE Mail Sign UP Error - APPLE Customer Service APPLE customer care Number APPLE help desk phone Number APPLE helpline phone Number . APPLE contact phone Number APPLE help APPLE tech support number +1844 836 6100 APPLE 24/7 toll free number APPLE customer service number+%1844 836 6100 APPLE support phone n ".")::::APPLE tech support number +1844 836 6100 APPLE 24/7 toll free number APPLE customer service number+%1844 836 6100 APPLE support phone numner APPLE support phone number APPLE customer service number ("?") APPLE customer Customer service number 1844 836 6100 APPLE phone number 18448366100 APPLE Customer Care Phone Number 18448366100 APPLE Customer service18448366100 APPLE Customer Care Phone Number 18448366100 APPLE Customer service APPLE Support Number , APPLE Customer service Number , APPLE Tech Support Number , APPLE Tech Customer service Number , APPLE Technical Support Number , APPLE Technical Customer service Number , APPLE Customer Support Number , APPLE Customer Customer service Number , APPLE Customer service Number , APPLE Customer service Phone Number Always 1844-836-6100 APPLE phone number APPLE Customer service number Always 1844-836-6100 APPLE phone number APPLE Customer service number 18448366100 APPLE Customer Care Phone Number 18448366100 APPLE Customer service Helloooooooooooooooooooooooooooooooooootechnical assistance phone number usa 1844 836 6100 at APPLE tech Customer service number APPLE tech support number, APPLE Customer service number,APPLE customer care Always 1844-836-6100 APPLE phone number APPLE Customer service number number,and APPLE technical Customer service number for password recovery to manaLivee all data 1844 836 6100 at APPLE tech Customer service number and APPLE technical Customer service number for password recovery to manaLivee all data1844 836 6100 at APPLE tech Customer service number and APPLE technical Customer service number for password recovery to manaLivee all data1844 836 6100 at APPLE tech Customer service number and 18448366100 APPLE Customer Care Phone Number 18448366100 APPLE Customer service APPLE technical Customer service number for password recovery to manaLivee all data 1844 836 6100 at APPLE tech Customer service number and APPLE technical Customer service number for password recovery to manaLivee all data1844 836 6100 at APPLE tech Customer service number and APPLE technical Customer service number for password recovery to manaLivee all data | 0:0 | 1:0 | | -Call, @(1-844-836-6100)@-: APPLE password recovery support phone number.APPLE technical assistance number APPLE technical assistance phone number It is very popular toll free number which vide by APPLE technical support, APPLE Customer service Phone Number, APPLE Customer service Number, APPLE Customer Customer service Number, APPLE Customer Support Number, APPLE Customer service Helpline Number, APPLE Customer Care Number, APPLE support team phone number. APPLE password recovery Customer service number. Call,@(1-844-836-6100)@-: APPLE help number-APPLE Helpline Number; APPLE help phone number, APPLE Helpline Number, APPLE Tech Support Toll free Number, 18448366100 APPLE Customer Care Phone Number 18448366100 APPLE Customer service APPLE Support Telephone Number, APPLE Tech Support Telephone number, APPLE Tech Support contact number, APPLE support contact number, APPLE technical support contact number, APPLE Customer service number, APPLE Customer service number. APPLE customer Customer service number.. APPLE password reset Customer service number. | -- | | 0:2 | 1:2 | Customer service APPLE technical support number usa APPLE customer care number usa, APPLE help desk number usa APPLE technical Customer service number us APPLE Customer service number APPLE contact phone number APPLE toll free phone number APPLE password recovery reset APPLE customer service phone number usa APPLE technician Customer service number for any issues treated not able to loLivein and various this type of problem such as APPLE help line number for the APPLE supper Customer service number 18448366100 APPLE Customer Care Phone Number 18448366100 APPLE Customer service usaDial APPLE tech support number usa 1844.836.6100APPLE customer care number usa, APPLE help desk number usa APPLE technical Customer service number us APPLE Customer service number APPLE contact phone Always 1844-836-6100 APPLE phone number APPLE Customer service number Always 1844-836-6100 APPLE phone number APPLE Customer service number Always 1844-836-6100 APPLE phone number APPLE Customer service number Always 1844-836-6100 APPLE phone number APPLE Customer service number Always 1844-836-6100 APPLE phone number APPLE Customer service number Always 1844-836-6100 APPLE phone number APPLE Customer service number Always 1844-836-6100 APPLE phone number APPLE Customer service number number APPLE toll free phone number APPLE password recovery reset APPLE Customer service phone number usa APPLE technician Customer service number for any issues treated not able to loLivein and various this type of https://www.agingcare.com/questions/APPLE-technical-support-1-844-836-6100-APPLE-customer-support-number-APPLE-customer-service-number1844-836-420080.htm problem such as APPLE help line number for the APPLE supper Customer service number usaDial APPLE tech NY..GK..CA..(USA)~1-844-836-6100 APPLE phone number for password reset APPLE Support phone number How to recover a lost APPLE password USA~1-844-836-6100 APPLE Support phone number APPLE Technical Support phone number Helpline Number++ USA~1-844-836-6100 APPLE Support phone number APPLE Technical Support phone number Helpline Number USA~1-844-836-6100 APPLE Support phone number APPLE Technical Support phone number Helpline Number USA~1-844-836-6100 APPLE Support phone number APPLE Technical Support phone number Helpline Number USA~1-844-836-6100 APPLE Support phone number APPLE Technical Support phone number Helpline Number USA~1-844-836-6100 APPLE Support phone number APPLE Technical Support phone number Helpline Number USA~1-844-836-6100 APPLE Support phone number APPLE Technical Support phone number Helpline Number USA~1-844-836-6100 APPLE Support phone number APPLE Technical Support phone number Helpline Number USA~1-844-836-6100 APPLE Support phone number APPLE Technical Support phone number Helpline Number USA~1-844-836-6100 APPLE Support phone number APPLE Technical Support phone number Helpline Number USA~1-844-836-6100 APPLE Support phone number APPLE Technical Support phone number Helpline Number USA~1-844-836-6100 APPLE Support phone number APPLE Technical Support phone number Helpline Number USA~1-844-836-6100 APPLE Support phone number APPLE Technical Support phone number Helpline Number USA~1-844-836-6100 APPLE Support phone number APPLE Technical Support phone number Helpline Number USA~1-844-836-6100 APPLE Support phone number APPLE Technical Support phone number Helpline Number USA~1-844-836-6100 APPLE Support phone number APPLE Technical Support phone number Helpline Number USA~1-844-836-6100 APPLE Support phone number APPLE Technical Support phone number Helpline Number USA~1-844-836-6100 APPLE Support phone number APPLE Technical Support phone number Helpline Number USA~1-844-836-6100 APPLE Support phone number APPLE Technical Support phone number Helpline Number !!@@@@!USA**CANADA+@@@@((1-844-836-6100)) APPLE Support phone number APPLE phone number++ Asked by dfgdgdfgdf 55 seconds ago @@!USA**CANADA+@@@@1~844~836~6100 APPLE Support phone number APPLE phone number Dec 26, 20026 views0 Likes0 CommentsShare on LinkedInShare on APPLEShare on Twitter !USA**CANADA+@@@@1~844~836~6100 APPLE Support phone number APPLE phone number Oct 21, 20161 view0 Likes0 CommentsShare on LinkedInShare on APPLEShare on Twitter Hlp desk @@((1~*844~*836~*6100)) APPLE phone number APPLE tech support phone number ConTAct@%1~*844~*836~*6100@% APPLE phone number APPLE tech support phone number all APPLE ? +1~*(844~836~6100) Customer Service Phone Number Bester SupporT@!!((1~*844~*836~*6100++@@APPLE phone number, APPLE support phone number APPLE phone support number APPLE support contact number APPLE support email address APPLE support phone number APPLE support telephone number APPLE tech support number APPLE tech support phone number APPLE tech support phone number free APPLE technical support phone number APPLE technologies phone number APPLE telephone support number APPLE support telephone number usa APPLE customer service number APPLE plus tech support APPLE technical support phone number APPLE technical support number APPLE technical support help desk phone number APPLE technical support number toll free numberrrrrrrrrrrrrrrrrrrrrrrrrrrrrrrrrrrrrrrrr APPLE technical support phone number APPLE customer support phone number APPLE customer service phone number APPLE customer support phone number APPLE customer service phone number phone number for APPLE customer serviceeeeeeeeeeeeeeeeeeeeeeeeeeeeeeeeeeeeeeeeeeeeeeeeeee contact APPLE customer service phone number APPLE customer service phone number phone number for APPLE customer service APPLE security support phone number APPLE internet security support phone number phone number for APPLE security APPLE internet security phone number in usa APPLE contact phone number in usa APPLE security contact phone number APPLE help desk phone number in usa APPLE tech support phone number free in usa APPLE support phone number APPLE phone number support for technical issue in usaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaa phone number for APPLE technical support APPLE customer service telephone number APPLE toll free customer care number APPLE technical support number APPLE tech support phone number APPLE support phone number APPLE customer support phone number APPLE technical support phone number APPLE technical support phone number usa phone number for APPLE technical supporttttttttttttttttttttttttttttttttttttttttttttttttttt APPLE customer service phone number usa APPLE customer service number APPLE technical support number usa APPLE customer support number APPLE tech support number phone number for APPLE support APPLE support phone number usa APPLE phone number customer serviceeeeeeeeeeeeeeeeeeeeeeeeeeeeeeeeeeeeeeeeeeeeeeeeeeee APPLE phone number tech support APPLE contact phone number usa APPLE contact phone number what is the phone number for APPLE customer service APPLE gold support phone number APPLE phone number support APPLE security phone number APPLE customer service number usa APPLE contact number usa APPLE usa phone number APPLE support number usa APPLE tech support number usa FrEE Calling call@@++((1.844-836-6100==++APPLE tech support phone number, APPLE techncial support phone number DADU's call&&=1 844 836 6100@@ APPLE customer service phone number, APPLE customer support phone number GAliB Wha! @@1 - 844 ~836~ 6100///APPLE phone number APPLE toll free number Freekly Call AT 1 844 836 6100 APPLE tech support phone number ContAct@%1* - 844* ~836~ *6100@% APPLE tech support number APPLE tech support phone number APPLE customer care number. Contact@%1~*844~*836~*6100@% APPLE tech support number APPLE tech support phone number APPLE customer service phone number. APPLE customer service number APPLE customer service phone number APPLE technical support number ContactAPPLE support APPLE phone number APPLE online support APPLE customer service number APPLE tech support center APPLE customer service APPLE customer care number usa APPLE customer number APPLE customer support number APPLE customer care number APPLE customer care toll free number APPLE tech support APPLE technical support APPLE support APPLE tech support APPLE support center APPLE .com customer service APPLE customer care number APPLE customer care APPLE phone number phone number for APPLE customer service APPLE phone support APPLE phone number tech support APPLE support phone number contact APPLE by phone APPLE contact phone number APPLE helpline phone number APPLE phone APPLE for phone APPLE contact number APPLE contact support contact APPLE APPLE contact number usa APPLE toll free number APPLE telephone number APPLE toll free number usa APPLE support services technical support for APPLE APPLE customer service phone number usa APPLE customer care number usa APPLE customer care number APPLE customer care center APPLE customer support APPLE customer support phone APPLE customer help APPLE anitivirus phone number, APPLE phone number, APPLE support phone number, APPLE tech support phone number, APPLE customer support phone number, APPLE tech support phone number, APPLE helpline number, APPLE helpdesk phone number, APPLE toll free number, APPLE contact number, APPLE telephone number. APPLE phone number, APPLE support phone number, APPLE techncal support phone number. APPLE technical support number APPLE tech support number APPLE customer support number APPLE customer service phone number APPLE helpline number APPLE contact number APPLE telephone number APPLE customer & technical support APPLE customer portal APPLE customer care phone number usa APPLE customer care email APPLE helpline APPLE tech support contact APPLE customer care toll free APPLE customer service number APPLE protection APPLE customer service number APPLE software customer service number APPLE customer service phone number us how to contact APPLE by email APPLE free phone support APPLE technical support phone number APPLE technical support number APPLE technical support help desk phone number APPLE technical support number toll free number APPLE technical support phone number APPLE customer support phone number APPLE customer service phone number APPLE technical support number APPLE technical support phone number APPLE tech support number APPLE customer support APPLE customer service phone number APPLE technical support reviews telephone APPLE APPLE tech support phone number APPLE tech support phone number APPLE customer service billing APPLE customer service email address APPLE customer service reviews contact APPLE customer service APPLE tech support number usa APPLE contact number APPLE customer service phone number APPLE tech support phone APPLE tech support number APPLE customer service telephone number APPLE customer support number APPLE customer support phone number APPLE customer service phone number contact APPLE customer service phone number APPLE security support phone number APPLE internet security phone number in usa APPLE contact phone number in usa APPLE tech support phone number free in usa APPLE phone number support for technical issue in usa phone number for APPLE technical support APPLE customer service telephone number APPLE toll free customer care number APPLE customer service telephone number APPLE support telephone number APPLE support telephone number APPLE technical support phone number APPLE customer service phone number APPLE phone number customer service APPLE customer support phone number APPLE security phone number customer service phone number for APPLE customer service APPLE customer support phone number APPLE help desk support phone number free in usa phone number for APPLE technical support APPLE technical support number free in usa APPLE technical support cutomer phone number APPLE internet security technical support APPLE customer support number APPLE customer service number APPLE customer service billing APPLE customer service email address APPLE phone number customer service us APPLE phone number support APPLE support phone number APPLE tech support phone number APPLE technical support number APPLE telephone number APPLE customer care phone number APPLE support phone number phone number for APPLE APPLE phone number support APPLE phone support number phone number for APPLE support APPLE phone support APPLE technical support phone number APPLE technical support number APPLE technical support APPLE technical support number APPLE technical support APPLE internet security technical support APPLE customer support number APPLE customer service phone APPLE customer service telephone number APPLE customer services email APPLE customer support email address APPLE customer support phone number APPLE internet security contact phone number APPLE internet security customer service phone number APPLE phone number customer service APPLE phone numbers customer support APPLE phone number, APPLE support phone number -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri May 26 13:16:21 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 26 May 2017 11:16:21 +0000 Subject: [Koha-bugs] [Bug 18629] Web installer 17.05 not properly translatable In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18629 Marc V?ron changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #63679|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Fri May 26 13:20:50 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 26 May 2017 11:20:50 +0000 Subject: [Koha-bugs] [Bug 18629] Translatability: Fix problems with web installer 17.05 In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18629 Marc V?ron changed: What |Removed |Added ---------------------------------------------------------------------------- Summary|Web installer 17.05 not |Translatability: Fix |properly translatable |problems with web installer | |17.05 Assignee|koha-bugs at lists.koha-commun |veron at veron.ch |ity.org | -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri May 26 13:21:44 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 26 May 2017 11:21:44 +0000 Subject: [Koha-bugs] [Bug 18629] Translatability: Fix problems with web installer 17.05 In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18629 Marc V?ron changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on| |18665 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18665 [Bug 18665] Translatability: Add tt filter to allow html tags inside tt directives -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri May 26 13:21:44 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 26 May 2017 11:21:44 +0000 Subject: [Koha-bugs] [Bug 18665] Translatability: Add tt filter to allow html tags inside tt directives In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18665 Marc V?ron changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |18629 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18629 [Bug 18629] Translatability: Fix problems with web installer 17.05 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri May 26 13:30:44 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 26 May 2017 11:30:44 +0000 Subject: [Koha-bugs] [Bug 18629] Translatability: Fix problems with web installer 17.05 In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18629 Marc V?ron changed: What |Removed |Added ---------------------------------------------------------------------------- Severity|major |normal --- Comment #6 from Marc V?ron --- The new web installer for 17.05 has a great new design - but it has a lot of translatability issues. Some strings are not picked for translations, some expose the content of tt directives, and others are splitted by html tags, resulting in small text fragments that are not easy to translate. The result in translations is much less than ideal, and it makes a bad impression not only for new Koha users or for libraries interested in Koha. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri May 26 13:49:48 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 26 May 2017 11:49:48 +0000 Subject: [Koha-bugs] [Bug 18629] Translatability: Fix problems with web installer 17.05 In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18629 --- Comment #7 from Marc V?ron --- Created attachment 63741 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=63741&action=edit Bug 18629 - Translatability: Fix problems with web installer 17.05 The new web installer for 17.05 has a great new design - but it has a lot of translatability issues. Some strings are not picked for translations, some expose the content of tt directives, and others are splitted by html tags, resulting in small text fragments that are not easy to translate. This patch weeds out such translation problems for step1.tt, step2.tt and step3.tt To test: - Apply patch (on top of Bug 18665 because of html tags inside of tt directives in step2.tt) - Prepare a fresh install (drop database, create database) - Walk through the installation process and verify that it works as before - Verify that string changes (in English) make sense - Create a translation( cd misc/translator, then perl translate create aa-AA) then: vim po/aa-AA-staff-prog.po and search for: /installer\/step Verify that strings for step1.tt, step2.tt, step3.tt are not fragmented, do not contain [%%, and are easily translatable (make sense without having to search in source files for context). -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri May 26 14:30:03 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 26 May 2017 12:30:03 +0000 Subject: [Koha-bugs] [Bug 18629] Translatability: Fix problems with web installer 17.05 In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18629 Marc V?ron changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #63741|0 |1 is obsolete| | --- Comment #8 from Marc V?ron --- Created attachment 63742 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=63742&action=edit Bug 18629 - Translatability: Fix problems with web installer 17.05 The new web installer for 17.05 has a great new design - but it has a lot of translatability issues. Some strings are not picked for translations, some expose the content of tt directives, and others are splitted by html tags, resulting in small text fragments that are not easy to translate. This patch weeds out such translation problems for step1.tt, step2.tt and step3.tt To test: - Apply patch (on top of Bug 18665 because of html tags inside of tt directives in step2.tt) - Prepare a fresh install (drop database, create database) - Walk through the installation process and verify that it works as before - Verify that string changes (in English) make sense - Create a translation( cd misc/translator, then perl translate create aa-AA) then: vim po/aa-AA-staff-prog.po and search for: /installer\/step Verify that strings for step1.tt, step2.tt, step3.tt are not fragmented, do not contain [%%, and are easily translatable (make sense without having to search in source files for context). -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri May 26 14:32:41 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 26 May 2017 12:32:41 +0000 Subject: [Koha-bugs] [Bug 18629] Translatability: Fix problems with web installer 17.05 In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18629 Marc V?ron changed: What |Removed |Added ---------------------------------------------------------------------------- Text to go in the| |Fix translatability issues release notes| |with web installer. Status|ASSIGNED |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri May 26 14:39:16 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 26 May 2017 12:39:16 +0000 Subject: [Koha-bugs] [Bug 18629] Translatability: Fix problems with web installer 17.05 In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18629 Marc V?ron changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |https://bugs.koha-community | |.org/bugzilla3/show_bug.cgi | |?id=17942 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri May 26 14:39:16 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 26 May 2017 12:39:16 +0000 Subject: [Koha-bugs] [Bug 17942] Update style of the web installer with Bootstrap 3 In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17942 Marc V?ron changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |https://bugs.koha-community | |.org/bugzilla3/show_bug.cgi | |?id=18629 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri May 26 15:08:32 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 26 May 2017 13:08:32 +0000 Subject: [Koha-bugs] [Bug 18678] SPAM In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18678 Owen Leonard changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |RESOLVED Summary|Bester |SPAM |SupporT@!!((1~*844~*836~*61 | |00++@@APPLE phone number, | |APPLE support phone number | Resolution|--- |INVALID -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri May 26 15:09:55 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 26 May 2017 13:09:55 +0000 Subject: [Koha-bugs] [Bug 18649] Translatability: Get rid of tt directive in translation for admin/ categories.tt and onboardingstep2.tt In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18649 --- Comment #6 from Marc V?ron --- (In reply to Marcel de Rooy from comment #5) > Hi Marc, > > What is the advantage of > value="[%- category.enrolmentperiod IF category.enrolmentperiod -%]" > above e.g. > value="[% category.enrolmentperiod %]" ? > I guess that if period == 0, the first one will leave the field empty? > Null and empty string will probably respond the same. > > Note that the trailing IF does not increase readability. Before making this > kind of changes everywhere, is there a consensus to do so? > > Also noting that you add chomps here (%-). Do we need them here? Hi Marcel - This bug is about translatability, and does not contain a change in behavior. I might be wrong, but the functionality is precisely the same. - At the moment, the translation tool picks the following line for translation: [% IF category.enrolmentperiod %][% category.enrolmentperiod %][% END %] That makes no sense for translators, confuses them, and can lead to errors. Translators should not have to care about code internals. To verify, search for that string for any language on translate.koha-community.org for version 17.05 Or create a translation e.g. for a 'language' aa-AA and then search in aa-AA-staff-prog.po for #. INPUT type=text name=enrolmentperiod #: intranet-tmpl/prog/en/modules/admin/categories.tt:92 #: intranet-tmpl/prog/en/modules/onboarding/onboardingstep2.tt:104 msgid "" "[% IF category.enrolmentperiod %][% category.enrolmentperiod %][% END %]" msgstr "" Then apply patch, translate aa-AA again and verify that the line [% IF category.enrolmentperiod %][% category.enrolmentperiod %][% END %] no longer appears. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri May 26 15:32:43 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 26 May 2017 13:32:43 +0000 Subject: [Koha-bugs] [Bug 18678] SPAM In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18678 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |jonathan.druart at bugs.koha-c | |ommunity.org -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri May 26 15:45:52 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 26 May 2017 13:45:52 +0000 Subject: [Koha-bugs] [Bug 18260] Koha::Biblio - Remove GetBiblio In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18260 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Patch doesn't apply |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri May 26 15:45:55 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 26 May 2017 13:45:55 +0000 Subject: [Koha-bugs] [Bug 18260] Koha::Biblio - Remove GetBiblio In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18260 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #61053|0 |1 is obsolete| | --- Comment #3 from Jonathan Druart --- Created attachment 63743 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=63743&action=edit Bug 18260: Koha::Biblio - Remove GetBiblio C4::Biblio::GetBiblio can be replaced with Koha Biblio->find Test plan: Import batch, view issue history, search for items, see the image of a bibliographic record, modify and delete records in a batch -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri May 26 16:45:40 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 26 May 2017 14:45:40 +0000 Subject: [Koha-bugs] [Bug 18679] New: Patron Attributed in Self Registration Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18679 Bug ID: 18679 Summary: Patron Attributed in Self Registration Change sponsored?: --- Product: Koha Version: 16.11 Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: OPAC Assignee: oleonard at myacpl.org Reporter: apurbajyoti at gmail.com QA Contact: testopia at bugs.koha-community.org The patron attribute options are not visible or editable in OPAC Patron Self Registration page.The attributed can to be updated by Library Staffs only under staff portal by editing patron details. May be added so that users can themselves update. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri May 26 16:46:26 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 26 May 2017 14:46:26 +0000 Subject: [Koha-bugs] [Bug 15465] README for github In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15465 --- Comment #14 from Jonathan Druart --- Created attachment 63744 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=63744&action=edit Bug 15465: Fix typo in bugs.k-c.org -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri May 26 16:46:44 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 26 May 2017 14:46:44 +0000 Subject: [Koha-bugs] [Bug 15465] README for github In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15465 --- Comment #15 from Jonathan Druart --- (In reply to Jonathan Druart from comment #14) > Created attachment 63744 [details] [review] > Bug 15465: Fix typo in bugs.k-c.org Pushed to master. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri May 26 17:05:06 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 26 May 2017 15:05:06 +0000 Subject: [Koha-bugs] [Bug 18675] Translatability: Get rid of [ %% in translation for csv-profiles.tt In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18675 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |jonathan.druart at bugs.koha-c | |ommunity.org --- Comment #2 from Jonathan Druart --- I have added a check to our QA script: commit 594843834db69745d4bd0debc1dfb71433542500 TT tags should not be defined on several lines That breaks our translate script See bug 18675. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri May 26 17:22:04 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 26 May 2017 15:22:04 +0000 Subject: [Koha-bugs] [Bug 18650] Translatability: Get rid of tt directive in translation for cat-toolbar.inc In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18650 Indranil Das Gupta changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |indradg at l2c2.co.in -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri May 26 17:23:12 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 26 May 2017 15:23:12 +0000 Subject: [Koha-bugs] [Bug 18680] New: sort1 dropdown (when mapped to authorized value) forces you to choose an option Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18680 Bug ID: 18680 Summary: sort1 dropdown (when mapped to authorized value) forces you to choose an option Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: normal Priority: P5 - low Component: Patrons Assignee: koha-bugs at lists.koha-community.org Reporter: nick at bywatersolutions.com QA Contact: testopia at bugs.koha-community.org CC: gmcharlt at gmail.com, kyle.m.hall at gmail.com -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri May 26 17:25:20 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 26 May 2017 15:25:20 +0000 Subject: [Koha-bugs] [Bug 18680] sort1 dropdown (when mapped to authorized value) forces you to choose an option In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18680 --- Comment #1 from Nick Clemens --- To recreate: 1 - Define values for bsort1 2 - Edit a patron 3 - note that you must select a value (cannot leave blank) You can workaround this by instering a blank value into the authorized value list, but it seems we should not force selection. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri May 26 17:25:36 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 26 May 2017 15:25:36 +0000 Subject: [Koha-bugs] [Bug 18680] sort1 dropdown (when mapped to authorized value) forces you to choose an option In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18680 Nick Clemens changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |rocio at bywatersolutions.com -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri May 26 17:44:52 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 26 May 2017 15:44:52 +0000 Subject: [Koha-bugs] [Bug 18570] Password recovery e-mail only sent after message queue is processed In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18570 Sally Healey changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |sally.healey at cheshireshared | |services.gov.uk --- Comment #1 from Sally Healey --- Yes, we would really like to see this as well. Bug 17648 remarks on how the ACCTDETAILS notice bypasses message_queue, and is sent directly to the linux mail queue (consequently, the message isn't logged in notices.pl). It would be good if the password recovery e-mail behaved in the same way. An instant e-mail is the response the patron is looking for, and staff do not need to see how many times a password reset has been requested by the patron; it is unnecessary clutter in the notices.pl -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri May 26 17:55:50 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 26 May 2017 15:55:50 +0000 Subject: [Koha-bugs] [Bug 18675] Translatability: Get rid of [ %% in translation for csv-profiles.tt In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18675 --- Comment #3 from Marc V?ron --- (In reply to Jonathan Druart from comment #2) > I have added a check to our QA script: > > commit 594843834db69745d4bd0debc1dfb71433542500 > TT tags should not be defined on several lines > That breaks our translate script > See bug 18675. Great! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri May 26 19:11:08 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 26 May 2017 17:11:08 +0000 Subject: [Koha-bugs] [Bug 18681] New: Translatability: Get rid of [ %% in translation for about.tt Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18681 Bug ID: 18681 Summary: Translatability: Get rid of [%% in translation for about.tt Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: trivial Priority: P5 - low Component: I18N/L10N Assignee: koha-bugs at lists.koha-community.org Reporter: veron at veron.ch QA Contact: testopia at bugs.koha-community.org CC: frederic at tamil.fr Translation tool picks a line %s [%% IF warnPrefBiblioAddsAuthorities || warnPrefEasyAnalyticalRecords || ...due to a line break inside a template directive. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri May 26 19:18:11 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 26 May 2017 17:18:11 +0000 Subject: [Koha-bugs] [Bug 18681] Translatability: Get rid of [%% in translation for about.tt In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18681 --- Comment #1 from Marc V?ron --- Created attachment 63745 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=63745&action=edit Bug 18681: Translatability: Get rid of [%% in translation for about.tt Translation tool picks a line %s [%% IF warnPrefBiblioAddsAuthorities || warnPrefEasyAnalyticalRecords || ...due to a line break inside a template directive. This patch fixes it. To test: - Update QA tools (see https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18675#c2) - Verify that code change makes sense - Apply patch - Run QA tools -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Fri May 26 19:18:38 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 26 May 2017 17:18:38 +0000 Subject: [Koha-bugs] [Bug 18681] Translatability: Get rid of [%% in translation for about.tt In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18681 Marc V?ron changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |https://bugs.koha-community | |.org/bugzilla3/show_bug.cgi | |?id=18675 -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Fri May 26 19:18:38 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 26 May 2017 17:18:38 +0000 Subject: [Koha-bugs] [Bug 18675] Translatability: Get rid of [ %% in translation for csv-profiles.tt In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18675 Marc V?ron changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |https://bugs.koha-community | |.org/bugzilla3/show_bug.cgi | |?id=18681 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri May 26 19:19:16 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 26 May 2017 17:19:16 +0000 Subject: [Koha-bugs] [Bug 18681] Translatability: Get rid of [%% in translation for about.tt In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18681 Marc V?ron changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff Assignee|koha-bugs at lists.koha-commun |veron at veron.ch |ity.org | Patch complexity|--- |String patch -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Fri May 26 19:50:49 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 26 May 2017 17:50:49 +0000 Subject: [Koha-bugs] [Bug 1985] Email notification of new OPAC comments In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=1985 --- Comment #49 from M. Tompsett --- Created attachment 63746 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=63746&action=edit Bug 1985: Fix whitespace in opac/opac-review.pl $ git diff -w origin/master -- should have no differences -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri May 26 19:51:07 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 26 May 2017 17:51:07 +0000 Subject: [Koha-bugs] [Bug 1985] Email notification of new OPAC comments In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=1985 M. Tompsett changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #38908|0 |1 is obsolete| | Attachment #38909|0 |1 is obsolete| | --- Comment #50 from M. Tompsett --- Created attachment 63747 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=63747&action=edit Bug 1985: Introduction of review alerts In comment #11, it was mentioned that title and biblionumber from the biblio table were not available as variables in the letter. This corrects this by converting the parameter list to a hashref, and adding the missing biblio number. It also cleans up the license on C4/Review.pm to be in line with the current coding guidelines license. Also strict and warning have been changed to the 'Use Modern::Perl;' now. Additionally, <> is now usable in the letter, as is <>. These were required additions, because comment #1 expressly says there should be a direct link to approve or delete. I also included a review everything link, since there could be multiple comments outstanding. The default letter was tweaked as well to reflect these changes. Fixed bad URLs as noted in comment #26. TEST PLAN --------- 1) Create test branch and apply patch 2) run installer/data/mysql/updatedatabase.pl -- this will add the required default letter. 3) In the staff client: a) set the CommentModeratorsEmail system preference. -- not setting it will mean you won't get any queued letters. a) set the staffClientBaseURL system preference. -- not setting it will mean your email links won't be valid (i.e http:///...). b) modify the COMMENT_CREATED default letter as desired. -- feel free to add other things. 4) In the OPAC: a) Log in b) Find something c) Click on the 'Comments' tab -- Holdings/Title notes/Comments (#) is at the bottom d) Click 'Post or edit your comments on this item' e) In the window that pops up, type your comment. f) Click 'Submit and close this window'. g) Click 'Edit' and repeat steps e and f again. 5) In a mysql client: a) Open the koha database b) SELECT * FROM message_queue WHERE letter_code='COMMENT_CREATED'; -- There should be at least two. -- They should be able to contain the borrower number, biblio title, and other borrower and biblio related things. -- Comments are at a biblio level, so items, and issues don't make sense as variables for the letter. -- Confirm the URLs are valid by pasting into a browser. 6) prove -v t/db_dependent/Koha/Reviews.t -- six new tests should run. 7) Run the koha qa test tool. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri May 26 19:51:21 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 26 May 2017 17:51:21 +0000 Subject: [Koha-bugs] [Bug 1985] Email notification of new OPAC comments In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=1985 M. Tompsett changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #39062|0 |1 is obsolete| | --- Comment #51 from M. Tompsett --- Created attachment 63748 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=63748&action=edit Bug 1985: Follow up - Add sample letter to other languages As per comment #36, the letter COMMENT_CREATED has been added to the other languages. TEST PLAN --------- 0) Back up your letters table 1) In your mysql client after selected your Koha database, Run this: SET foreign_key_checks = 0; truncate letter; source installer/data/mysql/de-DE/mandatory/sample_notices.sql SELECT COUNT(*) FROM letter where code='COMMENT_CREATED'; truncate letter; source installer/data/mysql/es-ES/mandatory/sample_notices.sql SELECT COUNT(*) FROM letter where code='COMMENT_CREATED'; truncate letter; source installer/data/mysql/fr-FR/1-Obligatoire/sample_notices.sql SELECT COUNT(*) FROM letter where code='COMMENT_CREATED'; truncate letter; source installer/data/mysql/it-IT/necessari/notices.sql SELECT COUNT(*) FROM letter where code='COMMENT_CREATED'; truncate letter; source installer/data/mysql/nb-NO/1-Obligatorisk/sample_notices.sql SELECT COUNT(*) FROM letter where code='COMMENT_CREATED'; truncate letter; source installer/data/mysql/pl-PL/mandatory/sample_notices.sql SELECT COUNT(*) FROM letter where code='COMMENT_CREATED'; truncate letter; source installer/data/mysql/ru-RU/mandatory/sample_notices.sql SELECT COUNT(*) FROM letter where code='COMMENT_CREATED'; truncate letter; source installer/data/mysql/uk-UA/mandatory/sample_notices.sql SELECT COUNT(*) FROM letter where code='COMMENT_CREATED'; truncate letter; source installer/data/mysql/en/mandatory/sample_notices.sql SELECT COUNT(*) FROM letter where code='COMMENT_CREATED'; -- there should be 9 counts of 1. 2) Restore your letters table. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri May 26 19:51:31 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 26 May 2017 17:51:31 +0000 Subject: [Koha-bugs] [Bug 1985] Email notification of new OPAC comments In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=1985 --- Comment #52 from M. Tompsett --- Created attachment 63749 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=63749&action=edit Bug 1985: perlcritic After the patch is applied: Code is not tidy at line 1, column 1. See page 33 of PBP. (Severity: 1) Main code has high complexity score (27) at line 1, column 1. Consider refactoring. (Severity: 3) No package-scoped "$VERSION" variable found at line 1, column 1. See page 404 of PBP. (Severity: 2) Regular expression without "/s" flag at line 77, column 30. See pages 240,241 of PBP. (Severity: 2) Regular expression without "/m" flag at line 77, column 30. See page 237 of PBP. (Severity: 2) -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri May 26 19:51:40 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 26 May 2017 17:51:40 +0000 Subject: [Koha-bugs] [Bug 1985] Email notification of new OPAC comments In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=1985 --- Comment #53 from M. Tompsett --- Created attachment 63750 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=63750&action=edit Bug 1985: perltidy opac/opac-review.pl -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri May 26 19:51:51 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 26 May 2017 17:51:51 +0000 Subject: [Koha-bugs] [Bug 1985] Email notification of new OPAC comments In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=1985 --- Comment #54 from M. Tompsett --- Created attachment 63751 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=63751&action=edit Bug 1985: perlcritic -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri May 26 19:51:59 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 26 May 2017 17:51:59 +0000 Subject: [Koha-bugs] [Bug 1985] Email notification of new OPAC comments In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=1985 --- Comment #55 from M. Tompsett --- Created attachment 63752 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=63752&action=edit Bug 1985: perltidy Koha/Review.pm -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri May 26 19:53:21 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 26 May 2017 17:53:21 +0000 Subject: [Koha-bugs] [Bug 1985] Email notification of new OPAC comments In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=1985 M. Tompsett changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Patch doesn't apply |Needs Signoff --- Comment #56 from M. Tompsett --- If you apply everything and run the test plans in comment #50 and comment #51, then it should suffice. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri May 26 19:56:08 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 26 May 2017 17:56:08 +0000 Subject: [Koha-bugs] [Bug 1985] Email notification of new OPAC comments In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=1985 --- Comment #57 from M. Tompsett --- (In reply to M. Tompsett from comment #56) > If you apply everything and run the test plans in comment #50 and comment > #51, then it should suffice. Generally running perlcritic -1 {file}, and ignoring some things, with the default perlcritic. This puts the code at a higher perlcritic level than just -5 as used by the koha qa test tools. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri May 26 20:28:18 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 26 May 2017 18:28:18 +0000 Subject: [Koha-bugs] [Bug 18679] Patron Attributes in Self Registration In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18679 Indranil Das Gupta changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |indradg at l2c2.co.in Summary|Patron Attributed in Self |Patron Attributes in Self |Registration |Registration -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri May 26 20:29:26 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 26 May 2017 18:29:26 +0000 Subject: [Koha-bugs] [Bug 18679] Patron Attributes in Self Registration In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18679 Indranil Das Gupta changed: What |Removed |Added ---------------------------------------------------------------------------- Version|16.11 |master -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri May 26 20:36:03 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 26 May 2017 18:36:03 +0000 Subject: [Koha-bugs] [Bug 18682] New: Translatability: Get rid of [ %% in translation for av-build-dropbox.inc Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18682 Bug ID: 18682 Summary: Translatability: Get rid of [%% in translation for av-build-dropbox.inc Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: trivial Priority: P5 - low Component: I18N/L10N Assignee: koha-bugs at lists.koha-community.org Reporter: veron at veron.ch QA Contact: testopia at bugs.koha-community.org CC: frederic at tamil.fr File av-build-dropbox.inc has linebreaks inside template directives. This exposes the following intrenals (comments and tt code) to translations: %s [%%# Parameters: name: the name of the select element category: the authorised value category default: the default authorised value to select class: the CSS class of the select element size: the size to use for the input (generated if the authorised value category does not exist). all: add a "All" entry %%] %s [%% DEFAULT class = '' size = 20 %%] %s -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Fri May 26 20:56:13 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 26 May 2017 18:56:13 +0000 Subject: [Koha-bugs] [Bug 18683] New: biblioitems.marcxml does not match MARC21slim.xsd Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18683 Bug ID: 18683 Summary: biblioitems.marcxml does not match MARC21slim.xsd Change sponsored?: --- Product: Koha Version: 17.05 Hardware: All OS: Linux Status: NEW Severity: normal Priority: P5 - low Component: Database Assignee: gmcharlt at gmail.com Reporter: mail at casi.pw QA Contact: testopia at bugs.koha-community.org I found the following record in a Koha installation that I manage, running on a Debian server. ---- [...] [...] [...] [...] [...] ---- This does not comply with the MARC21slim.xsd Schema definition, which says: These malformed xml strings were created by Koha over the time. To localize the errors, I ran a SQL query on the database. > select timestamp from biblioitems where marcxml like "% select timestamp from biblioitems where marcxml like "% https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18684 Bug ID: 18684 Summary: Get rid of %%] in translation for currency.tt Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: I18N/L10N Assignee: koha-bugs at lists.koha-community.org Reporter: veron at veron.ch QA Contact: testopia at bugs.koha-community.org CC: frederic at tamil.fr File add koha-tmpl/intranet-tmpl/prog/en/modules/admin/currency.tt exposes parts of template directives due to html tags inide directives. Fix it using the HtmlTags filter. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Fri May 26 21:16:50 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 26 May 2017 19:16:50 +0000 Subject: [Koha-bugs] [Bug 18684] Get rid of %%] in translation for currency.tt In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18684 --- Comment #1 from Marc V?ron --- Created attachment 63753 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=63753&action=edit Bug 18684 - Get rid of %%] in translation for currency.tt File add koha-tmpl/intranet-tmpl/prog/en/modules/admin/currency.tt exposes parts of template directives due to html tags inide directives. Fix it using the HtmlTags filter. To verify: - Create a translation for a language 'aa-AA - po file aa-AA-staff-prog.po / translate.koha-community.org for 17.05 contains a line '%%]'%sCurrencies %s To test: - Apply patch on top of Bug 18665 - Recreate translation - Verify that line above is gone - Verify that in staff client currencies administration wors as before -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Fri May 26 21:18:01 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 26 May 2017 19:18:01 +0000 Subject: [Koha-bugs] [Bug 18684] Get rid of %%] in translation for currency.tt In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18684 Marc V?ron changed: What |Removed |Added ---------------------------------------------------------------------------- Patch complexity|--- |Trivial patch Depends on| |18665 Assignee|koha-bugs at lists.koha-commun |veron at veron.ch |ity.org | Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18665 [Bug 18665] Translatability: Add tt filter to allow html tags inside tt directives -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri May 26 21:18:01 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 26 May 2017 19:18:01 +0000 Subject: [Koha-bugs] [Bug 18665] Translatability: Add tt filter to allow html tags inside tt directives In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18665 Marc V?ron changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |18684 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18684 [Bug 18684] Get rid of %%] in translation for currency.tt -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri May 26 21:18:33 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 26 May 2017 19:18:33 +0000 Subject: [Koha-bugs] [Bug 18665] Translatability: Add tt filter to allow html tags inside tt directives In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18665 --- Comment #4 from Marc V?ron --- Created attachment 63754 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=63754&action=edit Bug 15465: Fix typo in bugs.k-c.org -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri May 26 21:19:37 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 26 May 2017 19:19:37 +0000 Subject: [Koha-bugs] [Bug 18665] Translatability: Add tt filter to allow html tags inside tt directives In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18665 Marc V?ron changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #63754|0 |1 is obsolete| | --- Comment #5 from Marc V?ron --- Comment on attachment 63754 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=63754 Bug 15465: Fix typo in bugs.k-c.org Hmm, mistaked... -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri May 26 21:29:30 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 26 May 2017 19:29:30 +0000 Subject: [Koha-bugs] [Bug 18684] Get rid of %%] in translation for currency.tt In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18684 Marc V?ron changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on| |18662 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18662 [Bug 18662] Can not delete currencies -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri May 26 21:29:30 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 26 May 2017 19:29:30 +0000 Subject: [Koha-bugs] [Bug 18662] Can not delete currencies In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18662 Marc V?ron changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |18684 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18684 [Bug 18684] Get rid of %%] in translation for currency.tt -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri May 26 21:30:06 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 26 May 2017 19:30:06 +0000 Subject: [Koha-bugs] [Bug 18685] New: Patron edit/cancel floating toolbar out of place Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18685 Bug ID: 18685 Summary: Patron edit/cancel floating toolbar out of place Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: major Priority: P5 - low Component: Patrons Assignee: koha-bugs at lists.koha-community.org Reporter: katrin.fischer at bsz-bw.de QA Contact: testopia at bugs.koha-community.org CC: gmcharlt at gmail.com, kyle.m.hall at gmail.com When editing a patron, the floating toolbar with the save/cancel buttons is out of place on top of the page before scrolling (see attached screenshot) -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri May 26 21:31:39 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 26 May 2017 19:31:39 +0000 Subject: [Koha-bugs] [Bug 18685] Patron edit/cancel floating toolbar out of place In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18685 --- Comment #1 from Katrin Fischer --- Created attachment 63755 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=63755&action=edit screenshot of toolbar Verified behaviour on 16.11.08 and master. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Fri May 26 21:33:07 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 26 May 2017 19:33:07 +0000 Subject: [Koha-bugs] [Bug 18684] Get rid of %%] in translation for currency.tt In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18684 Marc V?ron changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri May 26 21:37:19 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 26 May 2017 19:37:19 +0000 Subject: [Koha-bugs] [Bug 18684] Translatability: Get rid of %%] in translation for currency.tt In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18684 Marc V?ron changed: What |Removed |Added ---------------------------------------------------------------------------- Summary|Get rid of %%] in |Translatability: Get rid of |translation for currency.tt |%%] in translation for | |currency.tt -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri May 26 22:25:51 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 26 May 2017 20:25:51 +0000 Subject: [Koha-bugs] [Bug 1985] Email notification of new OPAC comments In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=1985 --- Comment #58 from Jonathan Druart --- (In reply to M. Tompsett from comment #57) > (In reply to M. Tompsett from comment #56) > > If you apply everything and run the test plans in comment #50 and comment > > #51, then it should suffice. > > Generally running perlcritic -1 {file}, and ignoring some things, with the > default perlcritic. This puts the code at a higher perlcritic level than > just -5 as used by the koha qa test tools. We are not following perlcritic -1, this patch is out of the scope of this bug report. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri May 26 23:44:27 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 26 May 2017 21:44:27 +0000 Subject: [Koha-bugs] [Bug 1985] Email notification of new OPAC comments In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=1985 --- Comment #59 from M. Tompsett --- (In reply to Jonathan Druart from comment #58) > We are not following perlcritic -1, this patch is out of the scope of this > bug report. While you are correct about scope creep for the last 4 patches, I do believe the first 3 are fine and should not creep it as far as I recall. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat May 27 00:06:42 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 26 May 2017 22:06:42 +0000 Subject: [Koha-bugs] [Bug 1985] Email notification of new OPAC comments In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=1985 M. Tompsett changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #63749|0 |1 is obsolete| | --- Comment #60 from M. Tompsett --- Comment on attachment 63749 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=63749 Bug 1985: perlcritic Obsoleting because beyond enhancement scope, so as to not distract people who might sign off. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat May 27 00:06:58 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 26 May 2017 22:06:58 +0000 Subject: [Koha-bugs] [Bug 1985] Email notification of new OPAC comments In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=1985 M. Tompsett changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #63750|0 |1 is obsolete| | --- Comment #61 from M. Tompsett --- Comment on attachment 63750 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=63750 Bug 1985: perltidy opac/opac-review.pl Obsoleting because beyond enhancement scope, so as to not distract people who might sign off. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat May 27 00:07:13 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 26 May 2017 22:07:13 +0000 Subject: [Koha-bugs] [Bug 1985] Email notification of new OPAC comments In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=1985 M. Tompsett changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #63751|0 |1 is obsolete| | --- Comment #62 from M. Tompsett --- Comment on attachment 63751 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=63751 Bug 1985: perlcritic Obsoleting because beyond enhancement scope, so as to not distract people who might sign off. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat May 27 00:07:24 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 26 May 2017 22:07:24 +0000 Subject: [Koha-bugs] [Bug 1985] Email notification of new OPAC comments In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=1985 M. Tompsett changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #63752|0 |1 is obsolete| | --- Comment #63 from M. Tompsett --- Comment on attachment 63752 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=63752 Bug 1985: perltidy Koha/Review.pm Obsoleting because beyond enhancement scope, so as to not distract people who might sign off. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat May 27 00:20:23 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 26 May 2017 22:20:23 +0000 Subject: [Koha-bugs] [Bug 18686] New: TalkingTech_itiva_outbound.pl fails with Illegal mix of collations Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18686 Bug ID: 18686 Summary: TalkingTech_itiva_outbound.pl fails with Illegal mix of collations Change sponsored?: --- Product: Koha Version: unspecified Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Database Assignee: gmcharlt at gmail.com Reporter: larry at bywatersolutions.com QA Contact: testopia at bugs.koha-community.org In the big bug fix to clean up UTF8 (bug 11944), the default collation was set to utf8_unicode_ci. However on sites that predate that change, the overduerules table may still use utf8_general_ci. This leads to the following error when running the cronjob TalkingTech_itiva_outbound.pl: DBD::mysql::st execute failed: Illegal mix of collations (utf8_general_ci,IMPLICIT) and (utf8_unicode_ci,IMPLICIT) for operation '=' [for Statement "SELECT borrowers.borrowernumber, borrowers.cardnumber, borrowers.title as patron_title, borrowers.firstname, borrowers.surname, .... [snip] .... "] at /usr/share/koha/bin/cronjobs/thirdparty/TalkingTech_itiva_outbound.pl line 230. The problem is fixed manually by altering table overduerules and changing its collate setting. However, perhaps there should be a fix in updatedatabase.pl to change the collate if the table is still using the old value. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat May 27 00:26:26 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 26 May 2017 22:26:26 +0000 Subject: [Koha-bugs] [Bug 18686] TalkingTech_itiva_outbound.pl fails with Illegal mix of collations In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18686 --- Comment #1 from Larry Baerveldt --- Here is the full error message: DBD::mysql::st execute failed: Illegal mix of collations (utf8_general_ci,IMPLICIT) and (utf8_unicode_ci,IMPLICIT) for operation '=' [for Statement "SELECT borrowers.borrowernumber, borrowers.cardnumber, borrowers.title as patron_title, borrowers.firstname, borrowers.surname, borrowers.phone, borrowers.email, borrowers.branchcode, biblio.biblionumber, biblio.title, items.barcode, issues.date_due, max(overduerules.branchcode) as rulebranch, TO_DAYS(NOW())-TO_DAYS(date_due) as daysoverdue, delay1, delay2, delay3, issues.branchcode as site, branches.branchname as site_name FROM borrowers JOIN issues USING (borrowernumber) JOIN items USING (itemnumber) JOIN biblio USING (biblionumber) JOIN branches ON (issues.branchcode = branches.branchcode) JOIN overduerules USING (categorycode) WHERE ( overduerules.branchcode = borrowers.branchcode or overduerules.branchcode = '') AND ( (TO_DAYS(NOW())-TO_DAYS(date_due) ) = delay1 OR (TO_DAYS(NOW())-TO_DAYS(date_due) ) = delay2 OR (TO_DAYS(NOW())-TO_DAYS(date_due) ) = delay3 ) GROUP BY items.itemnumber "] at /usr/share/koha/bin/cronjobs/thirdparty/TalkingTech_itiva_outbound.pl line 230. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat May 27 02:16:36 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 27 May 2017 00:16:36 +0000 Subject: [Koha-bugs] [Bug 18679] Patron Attributes in Self Registration In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18679 Indranil Das Gupta changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|oleonard at myacpl.org |koha-bugs at lists.koha-commun | |ity.org -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat May 27 04:55:45 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 27 May 2017 02:55:45 +0000 Subject: [Koha-bugs] [Bug 4437] acq.js uses XMLHttpRequest() directly; should use jQuery In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=4437 --- Comment #10 from M. Tompsett --- (In reply to Marc V?ron from comment #9) > Sill valid? Yes. $ git grep -l XMLHttpRequest | grep acq -- You are receiving this mail because: You are watching all bug changes. You are the QA Contact for the bug. From bugzilla-daemon at bugs.koha-community.org Sat May 27 05:00:57 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 27 May 2017 03:00:57 +0000 Subject: [Koha-bugs] [Bug 4437] acq.js uses XMLHttpRequest() directly; should use jQuery In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=4437 --- Comment #11 from M. Tompsett --- Doesn't apply because fetchSortDropbox no longer exists. The other three functional changes should still be possible. Attempting resurrection. -- You are receiving this mail because: You are watching all bug changes. You are the QA Contact for the bug. From bugzilla-daemon at bugs.koha-community.org Sat May 27 05:27:24 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 27 May 2017 03:27:24 +0000 Subject: [Koha-bugs] [Bug 4437] acq.js uses XMLHttpRequest() directly; should use jQuery In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=4437 M. Tompsett changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #14649|0 |1 is obsolete| | --- Comment #12 from M. Tompsett --- Created attachment 63756 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=63756&action=edit Bug 4437: acq.js uses XMLHttpRequest() directly; should use jQuery The acq.js file used a few calls to XMLHttpRequest, which have been changed to use jQuery.ajax instead. The fetchSortDropbox no longer exists, which is why this patch did not apply. However, the other three functions still had direct XMLHttpRequest calls: - totalExceedsBudget - budgetExceedsParent - checkBudgetParent A test plan would require triggering these three javascript functions. -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat May 27 05:37:42 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 27 May 2017 03:37:42 +0000 Subject: [Koha-bugs] [Bug 4437] acq.js uses XMLHttpRequest() directly; should use jQuery In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=4437 M. Tompsett changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Patch doesn't apply |Needs Signoff --- Comment #13 from M. Tompsett --- The totalExceedsBudget is triggered by Check in koha-tmpl/intranet-tmpl/prog/en/modules/acqui/neworderempty.tt The budgetExceedsParent is triggered by Check in koha-tmpl/intranet-tmpl/prog/en/modules/admin/aqbudgets.tt The checkBudgetParent is triggered by Check in koha-tmpl/intranet-tmpl/prog/en/modules/admin/aqbudgets.tt NOTE: I have not checked this myself, but should someone write a test plan for novice libarian techies, I will check. -- You are receiving this mail because: You are watching all bug changes. You are the QA Contact for the bug. From bugzilla-daemon at bugs.koha-community.org Sat May 27 07:02:22 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 27 May 2017 05:02:22 +0000 Subject: [Koha-bugs] [Bug 18649] Translatability: Get rid of tt directive in translation for admin/ categories.tt and onboardingstep2.tt In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18649 --- Comment #7 from Marc V?ron --- Created attachment 63757 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=63757&action=edit Bug 18649: [QA followup] Remove chomps in admin/categories.tt As of comment #3, the chomps are not needed because the directive has no surrounding white space that should be removed. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat May 27 07:09:44 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 27 May 2017 05:09:44 +0000 Subject: [Koha-bugs] [Bug 18650] Translatability: Get rid of tt directive in translation for cat-toolbar.inc In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18650 Marc V?ron changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #63627|0 |1 is obsolete| | --- Comment #2 from Marc V?ron --- Created attachment 63758 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=63758&action=edit Bug 18650 - Translatability: Get rid of tt directive in translation for cat-toolbar.inc Translation tool shows [% count %] item(s) are... in translation for koha-tmpl/intranet-tmpl/prog/en/includes/cat-toolbar.inc This patch fixes it. To test: - Apply patch - Go to a biblio record with at least 1 item attached - Verify that tooltip for 'Edit > Delete record' shows same text as before (n item(s) are attached...) (Amended to remove superfluous chomps 2017-05-27 mv) -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat May 27 07:23:21 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 27 May 2017 05:23:21 +0000 Subject: [Koha-bugs] [Bug 18629] Translatability: Fix problems with web installer 17.05 In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18629 Marc V?ron changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #63742|0 |1 is obsolete| | --- Comment #9 from Marc V?ron --- Created attachment 63759 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=63759&action=edit Bug 18629 - Translatability: Fix problems with web installer 17.05 The new web installer for 17.05 has a great new design - but it has a lot of translatability issues. Some strings are not picked for translations, some expose the content of tt directives, and others are splitted by html tags, resulting in small text fragments that are not easy to translate. This patch weeds out such translation problems for step1.tt, step2.tt and step3.tt To test: - Apply patch (on top of Bug 18665 because of html tags inside of tt directives in step2.tt) - Prepare a fresh install (drop database, create database) - Walk through the installation process and verify that it works as before - Verify that string changes (in English) make sense - Create a translation( cd misc/translator, then perl translate create aa-AA) then: vim po/aa-AA-staff-prog.po and search for: /installer\/step Verify that strings for step1.tt, step2.tt, step3.tt are not fragmented, do not contain [%%, and are easily translatable (make sense without having to search in source files for context). (Amended to remove some superfluous chomps 2017-06-27 mv) -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat May 27 07:52:57 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 27 May 2017 05:52:57 +0000 Subject: [Koha-bugs] [Bug 18260] Koha::Biblio - Remove GetBiblio In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18260 Marc V?ron changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #63743|0 |1 is obsolete| | --- Comment #4 from Marc V?ron --- Created attachment 63760 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=63760&action=edit Bug 18260: Koha::Biblio - Remove GetBiblio C4::Biblio::GetBiblio can be replaced with Koha Biblio->find Test plan: Import batch, view issue history, search for items, see the image of a bibliographic record, modify and delete records in a batch Followed test plan, works as expected. Signed-off-by: Marc V?ron -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat May 27 07:53:38 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 27 May 2017 05:53:38 +0000 Subject: [Koha-bugs] [Bug 18260] Koha::Biblio - Remove GetBiblio In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18260 Marc V?ron changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |veron at veron.ch Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat May 27 08:23:16 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 27 May 2017 06:23:16 +0000 Subject: [Koha-bugs] [Bug 1985] Email notification of new OPAC comments In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=1985 --- Comment #64 from Marc V?ron --- Tested all patches together, followed test plan from comment #50, works as expected. Will sign off. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat May 27 08:25:54 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 27 May 2017 06:25:54 +0000 Subject: [Koha-bugs] [Bug 1985] Email notification of new OPAC comments In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=1985 Marc V?ron changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #63746|0 |1 is obsolete| | --- Comment #65 from Marc V?ron --- Created attachment 63761 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=63761&action=edit Bug 1985: Fix whitespace in opac/opac-review.pl $ git diff -w origin/master -- should have no differences Signed-off-by: Marc V?ron -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat May 27 08:27:16 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 27 May 2017 06:27:16 +0000 Subject: [Koha-bugs] [Bug 1985] Email notification of new OPAC comments In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=1985 Marc V?ron changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #63747|0 |1 is obsolete| | --- Comment #66 from Marc V?ron --- Created attachment 63762 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=63762&action=edit Bug 1985: Introduction of review alerts In comment #11, it was mentioned that title and biblionumber from the biblio table were not available as variables in the letter. This corrects this by converting the parameter list to a hashref, and adding the missing biblio number. It also cleans up the license on C4/Review.pm to be in line with the current coding guidelines license. Also strict and warning have been changed to the 'Use Modern::Perl;' now. Additionally, <> is now usable in the letter, as is <>. These were required additions, because comment #1 expressly says there should be a direct link to approve or delete. I also included a review everything link, since there could be multiple comments outstanding. The default letter was tweaked as well to reflect these changes. Fixed bad URLs as noted in comment #26. TEST PLAN --------- 1) Create test branch and apply patch 2) run installer/data/mysql/updatedatabase.pl -- this will add the required default letter. 3) In the staff client: a) set the CommentModeratorsEmail system preference. -- not setting it will mean you won't get any queued letters. a) set the staffClientBaseURL system preference. -- not setting it will mean your email links won't be valid (i.e http:///...). b) modify the COMMENT_CREATED default letter as desired. -- feel free to add other things. 4) In the OPAC: a) Log in b) Find something c) Click on the 'Comments' tab -- Holdings/Title notes/Comments (#) is at the bottom d) Click 'Post or edit your comments on this item' e) In the window that pops up, type your comment. f) Click 'Submit and close this window'. g) Click 'Edit' and repeat steps e and f again. 5) In a mysql client: a) Open the koha database b) SELECT * FROM message_queue WHERE letter_code='COMMENT_CREATED'; -- There should be at least two. -- They should be able to contain the borrower number, biblio title, and other borrower and biblio related things. -- Comments are at a biblio level, so items, and issues don't make sense as variables for the letter. -- Confirm the URLs are valid by pasting into a browser. 6) prove -v t/db_dependent/Koha/Reviews.t -- six new tests should run. 7) Run the koha qa test tool. Signed-off-by: Marc V?ron -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat May 27 08:38:41 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 27 May 2017 06:38:41 +0000 Subject: [Koha-bugs] [Bug 1985] Email notification of new OPAC comments In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=1985 Marc V?ron changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #63748|0 |1 is obsolete| | --- Comment #67 from Marc V?ron --- Created attachment 63763 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=63763&action=edit Bug 1985: Follow up - Add sample letter to other languages As per comment #36, the letter COMMENT_CREATED has been added to the other languages. TEST PLAN --------- 0) Back up your letters table 1) In your mysql client after selected your Koha database, Run this: SET foreign_key_checks = 0; truncate letter; source installer/data/mysql/de-DE/mandatory/sample_notices.sql SELECT COUNT(*) FROM letter where code='COMMENT_CREATED'; truncate letter; source installer/data/mysql/es-ES/mandatory/sample_notices.sql SELECT COUNT(*) FROM letter where code='COMMENT_CREATED'; truncate letter; source installer/data/mysql/fr-FR/1-Obligatoire/sample_notices.sql SELECT COUNT(*) FROM letter where code='COMMENT_CREATED'; truncate letter; source installer/data/mysql/it-IT/necessari/notices.sql SELECT COUNT(*) FROM letter where code='COMMENT_CREATED'; truncate letter; source installer/data/mysql/nb-NO/1-Obligatorisk/sample_notices.sql SELECT COUNT(*) FROM letter where code='COMMENT_CREATED'; truncate letter; source installer/data/mysql/pl-PL/mandatory/sample_notices.sql SELECT COUNT(*) FROM letter where code='COMMENT_CREATED'; truncate letter; source installer/data/mysql/ru-RU/mandatory/sample_notices.sql SELECT COUNT(*) FROM letter where code='COMMENT_CREATED'; truncate letter; source installer/data/mysql/uk-UA/mandatory/sample_notices.sql SELECT COUNT(*) FROM letter where code='COMMENT_CREATED'; truncate letter; source installer/data/mysql/en/mandatory/sample_notices.sql SELECT COUNT(*) FROM letter where code='COMMENT_CREATED'; -- there should be 9 counts of 1. 2) Restore your letters table. Signed-off-by: Marc V?ron -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat May 27 08:38:57 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 27 May 2017 06:38:57 +0000 Subject: [Koha-bugs] [Bug 1985] Email notification of new OPAC comments In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=1985 Marc V?ron changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat May 27 10:23:43 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 27 May 2017 08:23:43 +0000 Subject: [Koha-bugs] [Bug 4437] acq.js uses XMLHttpRequest() directly; should use jQuery In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=4437 Marc V?ron changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Failed QA --- Comment #14 from Marc V?ron --- > The budgetExceedsParent is triggered by Check in > koha-tmpl/intranet-tmpl/prog/en/modules/admin/aqbudgets.tt Testing budgetExceedsParent (without patch): 1) Go to Home > Administration > Budgets administration 2) Create a Budget 'Testbudget', give it a value of 100, make it active 3) Add a fund 'Testfund 1', give it a value of 90, save 4) Add a fund 'Testfund 2', give it a value of 20 (exceeds budget), save Result OK: Message box ------------------------------------------------------- Form not submitted because of the following problem(s) ------------------------------------------------------- - Fund amount exceeds period allocation ------------------------------------------------------- Testing budgetExceedsParent (with patch): a) Clear browser cache, restart memcached, plack b) Make sure page is reloaded, repeat step 4) above Result: Not OK, no message box, form saves, period allocated is 100, total available is 110 (should not) (Other functions not yet tested) -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat May 27 21:02:08 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 27 May 2017 19:02:08 +0000 Subject: [Koha-bugs] [Bug 18551] Hide with CSS dynamic elements in member search In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18551 Marc V?ron changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |18685 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18685 [Bug 18685] Patron edit/cancel floating toolbar out of place -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat May 27 21:02:08 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 27 May 2017 19:02:08 +0000 Subject: [Koha-bugs] [Bug 18685] Patron edit/cancel floating toolbar out of place In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18685 Marc V?ron changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |veron at veron.ch Depends on| |18551 --- Comment #2 from Marc V?ron --- The original position seems to be defined in memberentrygen.tt, line 15: var additional_height = $("#filters").height(); Not sure, but I guess that this is a side effect of Bug 18551, because filters now are collapsed. Setting this bug as dependent of Bug 18551. Please remove dependency if I'm wrong. Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18551 [Bug 18551] Hide with CSS dynamic elements in member search -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat May 27 23:15:20 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 27 May 2017 21:15:20 +0000 Subject: [Koha-bugs] [Bug 18685] Patron edit/cancel floating toolbar out of place In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18685 Lisette changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |lisetteslatah at gmail.com -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun May 28 07:25:56 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 28 May 2017 05:25:56 +0000 Subject: [Koha-bugs] [Bug 18450] Renew in header bypasses hold block and renewal limits In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18450 Alex Buckley changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #63377|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun May 28 07:32:19 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 28 May 2017 05:32:19 +0000 Subject: [Koha-bugs] [Bug 18450] Renew in header bypasses hold block and renewal limits In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18450 --- Comment #15 from Alex Buckley --- Created attachment 63764 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=63764&action=edit Bug 18450 - Implemented check in renew.tt for block and renewal limits Test plan: 1. In More->Administration->Global system preferences ensure that both the AllowRenewalLimitOverride and AllowRenewalIfOtherItemsAvaliable preferences are both set to 'Dont allow'. 2. Place a hold on an item from a patron 3. Checkout the item out to a different patron 4. Renew the item and notice the 'Cannot renew: The item is on hold for another patron' warning 5. Click the 'Override and renew' button and notice that you can bypass the hold 6. Apply patch 7. Renew the item again and notice that the message does not have a 'Override and renew' button it just has the 'Ignore and continue' button 8. Go back to More->Administration->Global system preferences and set AllowRenewalLimitOverride to 'Allow' 9. Try renewing the same item again and notice that the 'Override and renew' button is displayed 10. In systems preferences now set the AllowRenewalIfOtherItemsAvailable syspref to 'Allow' and AllowRenewalLimitOverride to 'Dont allow' and notice the 'Override and renew' button is displayed 11. Now set both these sysprefs to 'Allow' and notice the 'Override and renew' button is displayed because you will not be violating these preferences. Note: Checking if the renewal exceeds the renewal level, if auto renew is set up, or if renewal is to soon is checked earlier in this conditional if statement earlier and so the check in this patch does not need to check the renewal level, auto renewal, if renewal is too soon. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun May 28 07:32:38 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 28 May 2017 05:32:38 +0000 Subject: [Koha-bugs] [Bug 18450] Renew in header bypasses hold block and renewal limits In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18450 Alex Buckley changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun May 28 07:34:10 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 28 May 2017 05:34:10 +0000 Subject: [Koha-bugs] [Bug 18450] Renew in header bypasses hold block and renewal limits In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18450 --- Comment #16 from Alex Buckley --- Hi Jonathan I have done what you asked in comment 14. Were you happy with the if statement logic in the renew.tt file being this: IF A AND B: Do the stuffs ELSIF ( NOT A AND B ) OR ( A AND NOT B ): Do the same stuffs -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun May 28 08:28:38 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 28 May 2017 06:28:38 +0000 Subject: [Koha-bugs] [Bug 17139] Translation process should not pick class value inside span tags In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17139 --- Comment #2 from Marc V?ron --- (In reply to Marc V?ron from comment #0) > Example: > > koha-tmpl/intranet-tmpl/prog/en/includes/authorities-search-results.inc > line 14: > > > BT is picked for translation Tested in current translation, it is not picked from span tag. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Sun May 28 08:38:54 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 28 May 2017 06:38:54 +0000 Subject: [Koha-bugs] [Bug 18665] Translatability: Add tt filter to allow html tags inside tt directives In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18665 Alex Buckley changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #63697|0 |1 is obsolete| | --- Comment #6 from Alex Buckley --- Created attachment 63765 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=63765&action=edit Bug 18665 - Translatability: Add tt filter to allow html tags inside tt directives HTML tags inside template toolkit directives are not allowed because of translation issues. Add a filter that handles HTML tags. Note you need to write quotes ' around the text you want displayed as a heading To test: - Apply patch - Add [% USE HtmlTags %] to the top of a tt file - Add something like [% 'My nice title' | $HtmlTags tag="h1" %] to the tt file - Verify that in output 'My nice title' has h1 tags - Change template directive to something like [% 'My nice title' | $HtmlTags tag="h1" attributes='title="This is a nice title attribute"' %] - Verify that title attribute displays in output (source code or tooltip on 'My nice title') Notes: - Tests are planned for a second patch - Update for Wiki coding guidelines Signed-off-by: Alex Buckley -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun May 28 08:39:22 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 28 May 2017 06:39:22 +0000 Subject: [Koha-bugs] [Bug 18665] Translatability: Add tt filter to allow html tags inside tt directives In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18665 Alex Buckley changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #63721|0 |1 is obsolete| | --- Comment #7 from Alex Buckley --- Created attachment 63766 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=63766&action=edit Bug 18665: Add test for HtmlTags.pm This patch adds tests for the tt filter HtmlTags.pm To test: prove -v t/HtmlTags.t should pass Signed-off-by: Alex Buckley -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun May 28 08:41:29 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 28 May 2017 06:41:29 +0000 Subject: [Koha-bugs] [Bug 18665] Translatability: Add tt filter to allow html tags inside tt directives In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18665 Alex Buckley changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off CC| |alexbuckley at catalyst.net.nz --- Comment #8 from Alex Buckley --- Hi Marc I tested and found that the patches work nicely and all tests pass but your test plan is missing that you need to write quote marks ' around the text My nice title in order for it to be displayed correctly with this patch applied. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun May 28 08:50:31 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 28 May 2017 06:50:31 +0000 Subject: [Koha-bugs] [Bug 17139] Translation process should not pick class value inside span tags In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17139 --- Comment #3 from Marc V?ron --- (In reply to Marc V?ron from comment #1) > ...but we have: > > > Inside abbr tag, "Used For" should be translatable (is picked by translation > process). Tested in current translation. The text is picked and is properly translated. Example for manage-marc-import.tt English: Diff German: Diff Minor issue: The lang tag remains "en", here it should be "de" for German. IMO the lang tag could be removed because the language is declared at the top of the page: -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun May 28 08:54:19 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 28 May 2017 06:54:19 +0000 Subject: [Koha-bugs] [Bug 18665] Translatability: Add tt filter to allow html tags inside tt directives In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18665 --- Comment #9 from Marc V?ron --- (In reply to Alex Buckley from comment #8) > Hi Marc > > I tested and found that the patches work nicely and all tests pass but your > test plan is missing that you need to write quote marks ' around the text My > nice title in order for it to be displayed correctly with this patch applied. Thanks for testing, Alex, and thanks for fixing my test plan! Marc -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun May 28 09:29:51 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 28 May 2017 07:29:51 +0000 Subject: [Koha-bugs] [Bug 18687] New: Translatability: abbr tag should not contain lang attribute Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18687 Bug ID: 18687 Summary: Translatability: abbr tag should not contain lang attribute Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: I18N/L10N Assignee: koha-bugs at lists.koha-community.org Reporter: veron at veron.ch QA Contact: testopia at bugs.koha-community.org CC: frederic at tamil.fr In manage-marc-import.tt, we have an abbreviation: Diff In translations (e.g. German), the line appears as follows: Diff The lang attribute is wrong here, it is still "en". The text language is the same as defined at the top of the page - or with other words, the lang tag is superfluous. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun May 28 09:31:19 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 28 May 2017 07:31:19 +0000 Subject: [Koha-bugs] [Bug 17139] Translation process should not pick class value inside span tags In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17139 Marc V?ron changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |RESOLVED Resolution|--- |INVALID --- Comment #4 from Marc V?ron --- Setting to RESOLVED INVALID for comments #2 and #3 Issue with lang attribute in abbr tag goes to new bug 18687 -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun May 28 09:37:48 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 28 May 2017 07:37:48 +0000 Subject: [Koha-bugs] [Bug 18687] Translatability: abbr tag should not contain lang attribute In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18687 --- Comment #1 from Marc V?ron --- Created attachment 63767 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=63767&action=edit Bug 18687: Translatability: abbr tag should not contain lang attribute In manage-marc-import.tt, we have an abbreviation: Diff In translations (e.g. German), the line appears as follows: Diff The lang attribute is wrong here, it is still "en". The text language is the same as defined at the top of the page - or with other words, the lang tag is superfluous. This patch removes it. To test: Verify that code change makes sense. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Sun May 28 09:38:20 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 28 May 2017 07:38:20 +0000 Subject: [Koha-bugs] [Bug 18687] Translatability: abbr tag should not contain lang attribute In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18687 Marc V?ron changed: What |Removed |Added ---------------------------------------------------------------------------- Patch complexity|--- |Trivial patch Status|NEW |Needs Signoff Assignee|koha-bugs at lists.koha-commun |veron at veron.ch |ity.org | -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun May 28 09:54:10 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 28 May 2017 07:54:10 +0000 Subject: [Koha-bugs] [Bug 18629] Translatability: Fix problems with web installer 17.05 In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18629 Alex Buckley changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |alexbuckley at catalyst.net.nz --- Comment #10 from Alex Buckley --- Hi Marc When running perl translate create aa-AA I keep getting: >Warning: Can't determine original templates' charset, defaulting to UTF-8 >Warning: Charset Out defaulting to UTF-8 >Removing empty file /home/vagrant/kohaclone/misc/translator/po/aa-AA-staff-prog.po >I UTF-8 O UTF-8 at /home/vagrant/kohaclone/misc/translator/tmpl_process3.pl line 345. >msgmerge: error while opening "/home/vagrant/kohaclone/misc/translator/po/aa-AA-staff-prog.po" for reading: No such file or directory The equivalent output happens for all of the other aa-AA files. Do you have any ideas as to why this may be happening? as I cannot find any useful answers online -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun May 28 10:15:49 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 28 May 2017 08:15:49 +0000 Subject: [Koha-bugs] [Bug 18629] Translatability: Fix problems with web installer 17.05 In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18629 --- Comment #11 from Marc V?ron --- (In reply to Alex Buckley from comment #10) > Hi Marc > > When running > perl translate create aa-AA I keep getting: > > >Warning: Can't determine original templates' charset, defaulting to UTF-8 > >Warning: Charset Out defaulting to UTF-8 > >Removing empty file /home/vagrant/kohaclone/misc/translator/po/aa-AA-staff-prog.po > >I UTF-8 O UTF-8 at /home/vagrant/kohaclone/misc/translator/tmpl_process3.pl line 345. > >msgmerge: error while opening "/home/vagrant/kohaclone/misc/translator/po/aa-AA-staff-prog.po" for reading: No such file or directory > > The equivalent output happens for all of the other aa-AA files. > > Do you have any ideas as to why this may be happening? as I cannot find any > useful answers online On my vm, I do: marc at debian8vm:~/koha/misc/translator$ perl translate create aa-AA I get the same warnings about the charset and the message about revoming an emty file However I do not get the error about opening a file. Does the folder /home/vagrant/kohaclone/misc/translator/po exist? -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun May 28 10:17:20 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 28 May 2017 08:17:20 +0000 Subject: [Koha-bugs] [Bug 18629] Translatability: Fix problems with web installer 17.05 In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18629 --- Comment #12 from Alex Buckley --- yes the folder /home/vagrant/kohaclone/misc/translator/po does exist -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun May 28 10:21:21 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 28 May 2017 08:21:21 +0000 Subject: [Koha-bugs] [Bug 18629] Translatability: Fix problems with web installer 17.05 In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18629 --- Comment #13 from Marc V?ron --- (In reply to Alex Buckley from comment #12) > yes the folder /home/vagrant/kohaclone/misc/translator/po does exist Maybe an issue with permissions? -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun May 28 10:37:06 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 28 May 2017 08:37:06 +0000 Subject: [Koha-bugs] [Bug 18629] Translatability: Fix problems with web installer 17.05 In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18629 --- Comment #14 from Marc V?ron --- Or maybe an issue with devbox? Can you install other (existing) languages? See: https://wiki.koha-community.org/wiki/Installation_of_additional_languages_for_OPAC_and_INTRANET_staff_client#Installing_additional_languages_before_Koha_installation_in_the_kohadevbox_development_environment -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun May 28 10:45:52 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 28 May 2017 08:45:52 +0000 Subject: [Koha-bugs] [Bug 18629] Translatability: Fix problems with web installer 17.05 In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18629 --- Comment #15 from Alex Buckley --- Hi Marc Thanks for the suggestions. So the permissions are fine with the po directory having the following correct permissions: drwxr-xr-x Whilst I can install existing languages using the command: sudo env KOHA_CONF=/etc/koha/sites/kohadev/koha-conf.xml PERL5LIB=/home/vagrant/kohaclone perl translate install fr-FR To install French for example, which worked successfully -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun May 28 10:57:29 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 28 May 2017 08:57:29 +0000 Subject: [Koha-bugs] [Bug 18629] Translatability: Fix problems with web installer 17.05 In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18629 --- Comment #16 from Marc V?ron --- What happens if you do the following? sudo env KOHA_CONF=/etc/koha/sites/kohadev/koha-conf.xml PERL5LIB=/home/vagrant/kohaclone perl translate create aa-AA -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun May 28 11:02:20 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 28 May 2017 09:02:20 +0000 Subject: [Koha-bugs] [Bug 18629] Translatability: Fix problems with web installer 17.05 In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18629 --- Comment #17 from Alex Buckley --- Ah brilliant thanks Marc Although it is displaying the same output as before (see below) the files have actually been created this time. Thanks very much I will test your patches now >Warning: Can't determine original templates' charset, defaulting to UTF-8 >Warning: Charset Out defaulting to UTF-8 >Removing empty file /home/vagrant/kohaclone/misc/translator/po/aa-AA-staff-prog.po >I UTF-8 O UTF-8 at /home/vagrant/kohaclone/misc/translator/tmpl_process3.pl line 345. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun May 28 11:19:06 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 28 May 2017 09:19:06 +0000 Subject: [Koha-bugs] [Bug 18629] Translatability: Fix problems with web installer 17.05 In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18629 Alex Buckley changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #63759|0 |1 is obsolete| | --- Comment #18 from Alex Buckley --- Created attachment 63768 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=63768&action=edit Bug 18629 - Translatability: Fix problems with web installer 17.05 The new web installer for 17.05 has a great new design - but it has a lot of translatability issues. Some strings are not picked for translations, some expose the content of tt directives, and others are splitted by html tags, resulting in small text fragments that are not easy to translate. This patch weeds out such translation problems for step1.tt, step2.tt and step3.tt To test: - Apply patch (on top of Bug 18665 because of html tags inside of tt directives in step2.tt) - Prepare a fresh install (drop database, create database) - Walk through the installation process and verify that it works as before - Verify that string changes (in English) make sense - Create a translation( cd misc/translator, then perl translate create aa-AA) then: vim po/aa-AA-staff-prog.po and search for: /installer\/step Verify that strings for step1.tt, step2.tt, step3.tt are not fragmented, do not contain [%%, and are easily translatable (make sense without having to search in source files for context). (Amended to remove some superfluous chomps 2017-06-27 mv) Followed test plan worked as intended Signed-off-by: Alex Buckley -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun May 28 11:19:03 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 28 May 2017 09:19:03 +0000 Subject: [Koha-bugs] [Bug 18629] Translatability: Fix problems with web installer 17.05 In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18629 Alex Buckley changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun May 28 11:30:29 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 28 May 2017 09:30:29 +0000 Subject: [Koha-bugs] [Bug 18684] Translatability: Get rid of %%] in translation for currency.tt In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18684 Alex Buckley changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #63753|0 |1 is obsolete| | --- Comment #2 from Alex Buckley --- Created attachment 63769 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=63769&action=edit Bug 18684 - Get rid of %%] in translation for currency.tt File add koha-tmpl/intranet-tmpl/prog/en/modules/admin/currency.tt exposes parts of template directives due to html tags inide directives. Fix it using the HtmlTags filter. To verify: - Create a translation for a language 'aa-AA - po file aa-AA-staff-prog.po / translate.koha-community.org for 17.05 contains a line '%%]'%sCurrencies %s To test: - Apply patch on top of Bug 18665 - Recreate translation - Verify that line above is gone - Verify that in staff client currencies administration wors as before Followed test plan and it worked as intended Signed-off-by: Alex Buckley -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun May 28 11:30:26 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 28 May 2017 09:30:26 +0000 Subject: [Koha-bugs] [Bug 18684] Translatability: Get rid of %%] in translation for currency.tt In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18684 Alex Buckley changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun May 28 11:40:11 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 28 May 2017 09:40:11 +0000 Subject: [Koha-bugs] [Bug 18537] Update Ukrainian installer sample files for 17.05 In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18537 Alex Buckley changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Sun May 28 11:40:23 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 28 May 2017 09:40:23 +0000 Subject: [Koha-bugs] [Bug 18537] Update Ukrainian installer sample files for 17.05 In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18537 Alex Buckley changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #63100|0 |1 is obsolete| | --- Comment #4 from Alex Buckley --- Created attachment 63770 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=63770&action=edit Update Ukrainian installer sample files for 17.05 Update and translate sample SQL file of the Ukrainian installer. To test: - Start with an empty database - Install uk-UA - Run the web installer in uk-UA/Ukrainian - Verify all files load without any problems. Signed-off-by: Serhij Dubyk {?????? ?????} https://bugs.koha-community.org/show_bug.cgi?id=18537 Followed test plan and the patch works with all files loading without problems Signed-off-by: Alex Buckley -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun May 28 11:51:52 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 28 May 2017 09:51:52 +0000 Subject: [Koha-bugs] [Bug 17710] C4::Matcher::get_matches and C4::ImportBatch:: GetBestRecordMatch should use same logic In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17710 Alex Buckley changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun May 28 11:51:56 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 28 May 2017 09:51:56 +0000 Subject: [Koha-bugs] [Bug 17710] C4::Matcher::get_matches and C4::ImportBatch:: GetBestRecordMatch should use same logic In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17710 Alex Buckley changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #58859|0 |1 is obsolete| | --- Comment #4 from Alex Buckley --- Created attachment 63771 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=63771&action=edit Bug 17710 - C4::Matcher::get_matches and C4::ImportBatch::GetBestRecordMatch should use same logic C4::ImportBatch::GetBestRecordMatch uses SQL to sort by score descending then candidate_match_id descending. With C4::Matcher::get_matches, I implement the same sort but use Perl code to do it, since we're sorting search results. It's a simple change, but it's in a big block of code, so I don't have unit tests. Signed-off-by: Alex Buckley -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun May 28 12:07:27 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 28 May 2017 10:07:27 +0000 Subject: [Koha-bugs] [Bug 18652] Get rid of tt directive in translation for uncertainprice.tt In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18652 Alex Buckley changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun May 28 12:07:30 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 28 May 2017 10:07:30 +0000 Subject: [Koha-bugs] [Bug 18652] Get rid of tt directive in translation for uncertainprice.tt In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18652 Alex Buckley changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #63639|0 |1 is obsolete| | --- Comment #2 from Alex Buckley --- Created attachment 63772 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=63772&action=edit Bug 18652: Get rid of tt directive in translation for uncertainprice.tt Translation tool shows toe following for ncertainprice.tt 0; url=[% scriptname %]?booksellerid=[% booksellerid %] This patch fixes it. To test: - Apply patch - Verify that code change makes sense - Verify that Home > Acquisitions > [vendor] > Uncertain prices for [vendor] works as before Followed test plan and patch worked as intended Signed-off-by: Alex Buckley -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun May 28 12:34:46 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 28 May 2017 10:34:46 +0000 Subject: [Koha-bugs] [Bug 18654] Translatability: Get rid of tt directives starting with [ %% in translation for itemsearch.tt In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18654 Alex Buckley changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun May 28 12:34:49 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 28 May 2017 10:34:49 +0000 Subject: [Koha-bugs] [Bug 18654] Translatability: Get rid of tt directives starting with [ %% in translation for itemsearch.tt In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18654 Alex Buckley changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #63643|0 |1 is obsolete| | --- Comment #2 from Alex Buckley --- Created attachment 63773 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=63773&action=edit Bug 18654: Translatability: Get rid of tt directives starting with [%% in translation for itemsearch.tt Translation for file itemsearch.tt exposes tt directifes like: %s %s %s %s %s %s %s %s %s [%% params = { f => f.$i q = q.$i op = op.$i } %%] %s %s %s %s %s %s %s %s %s %s %s or [%% INCLUDE form_field_select name="homebranch" options = branches empty_option = "All libraries" %%] [%% INCLUDE form_field_select name="holdingbranch" options = branches empty_option = "All libraries" %%] %s [%% INCLUDE form_field_select name="location" options = locations empty_option = "All locations" %%] %s This patch fixes it. To test: - Apply patch - Verify that itemsearch behaves as before - Verify that code changes make sense - Test a translatiion e.g. translator create aa-AA and verifiy that strings from itemsearch.tt starting with [%% no longer appear Followed test plan and patch worked as intended Signed-off-by: Alex Buckley -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun May 28 12:51:36 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 28 May 2017 10:51:36 +0000 Subject: [Koha-bugs] [Bug 18681] Translatability: Get rid of [%% in translation for about.tt In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18681 Alex Buckley changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #63745|0 |1 is obsolete| | --- Comment #2 from Alex Buckley --- Created attachment 63774 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=63774&action=edit Bug 18681: Translatability: Get rid of [%% in translation for about.tt Translation tool picks a line %s [%% IF warnPrefBiblioAddsAuthorities || warnPrefEasyAnalyticalRecords || ...due to a line break inside a template directive. This patch fixes it. To test: - Update QA tools (see https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18675#c2) - Verify that code change makes sense - Apply patch - Run QA tools Followed test plan and everything was as intended Signed-off-by: Alex Buckley -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun May 28 12:51:31 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 28 May 2017 10:51:31 +0000 Subject: [Koha-bugs] [Bug 18681] Translatability: Get rid of [%% in translation for about.tt In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18681 Alex Buckley changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun May 28 13:01:55 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 28 May 2017 11:01:55 +0000 Subject: [Koha-bugs] [Bug 18673] News author does not display on staff client home page In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18673 Alex Buckley changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun May 28 13:01:59 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 28 May 2017 11:01:59 +0000 Subject: [Koha-bugs] [Bug 18673] News author does not display on staff client home page In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18673 Alex Buckley changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #63722|0 |1 is obsolete| | --- Comment #2 from Alex Buckley --- Created attachment 63775 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=63775&action=edit Bug 18673: News author does not display on staff client home page News authors do not display on staff client homepage, independently of syspref 'NewsAuthorDisplay'. This patch fixes the issue. To verify: - Create news with display location 'All' - Set syspref NewsAuthorDisplay to 'Staff client only' or 'Both OPAC and staff client' - Go to staff client - Verify that news author does not appear (but it should) To test: - Applly patch - Verify that news author is displayed as expected Followed test plan works as intended Signed-off-by: Alex Buckley -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun May 28 13:08:51 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 28 May 2017 11:08:51 +0000 Subject: [Koha-bugs] [Bug 18650] Translatability: Get rid of tt directive in translation for cat-toolbar.inc In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18650 Alex Buckley changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun May 28 13:08:56 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 28 May 2017 11:08:56 +0000 Subject: [Koha-bugs] [Bug 18650] Translatability: Get rid of tt directive in translation for cat-toolbar.inc In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18650 Alex Buckley changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #63758|0 |1 is obsolete| | --- Comment #3 from Alex Buckley --- Created attachment 63776 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=63776&action=edit Bug 18650 - Translatability: Get rid of tt directive in translation for cat-toolbar.inc Translation tool shows [% count %] item(s) are... in translation for koha-tmpl/intranet-tmpl/prog/en/includes/cat-toolbar.inc This patch fixes it. To test: - Apply patch - Go to a biblio record with at least 1 item attached - Verify that tooltip for 'Edit > Delete record' shows same text as before (n item(s) are attached...) (Amended to remove superfluous chomps 2017-05-27 mv) Followed test plan and everything worked as intended Signed-off-by: Alex Buckley -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun May 28 15:09:36 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 28 May 2017 13:09:36 +0000 Subject: [Koha-bugs] [Bug 18537] Update Ukrainian installer sample files for 17.05 In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18537 --- Comment #5 from Serhij Dubyk --- Revised all changes. Thanks for corrections! -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun May 28 15:10:30 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 28 May 2017 13:10:30 +0000 Subject: [Koha-bugs] [Bug 18688] New: Warnings about UTF-8 charset when creating a new language Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18688 Bug ID: 18688 Summary: Warnings about UTF-8 charset when creating a new language Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: minor Priority: P5 - low Component: I18N/L10N Assignee: koha-bugs at lists.koha-community.org Reporter: veron at veron.ch QA Contact: testopia at bugs.koha-community.org CC: frederic at tamil.fr Creatinng a new language produces several warnings. To reproduce: cd /koha/misc/translator$ perl translate create aa-AA Or, if env vars are not set (change path as appropriate): sudo env KOHA_CONF=/etc/koha/sites/kohadev/koha-conf.xml PERL5LIB=/home/vagrant/kohaclone perl translate create aa-AA Result: >Warning: Can't determine original templates' charset, defaulting to UTF-8 >Warning: Charset Out defaulting to UTF-8 >Removing empty file /home/vagrant/kohaclone/misc/translator/po/aa-AA-staff-prog.po >I UTF-8 O UTF-8 at /home/vagrant/kohaclone/misc/translator/tmpl_process3.pl line 345. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Sun May 28 15:11:03 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 28 May 2017 13:11:03 +0000 Subject: [Koha-bugs] [Bug 18688] Warnings about UTF-8 charset when creating a new language In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18688 Marc V?ron changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on| |18629 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18629 [Bug 18629] Translatability: Fix problems with web installer 17.05 -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun May 28 15:11:03 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 28 May 2017 13:11:03 +0000 Subject: [Koha-bugs] [Bug 18629] Translatability: Fix problems with web installer 17.05 In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18629 Marc V?ron changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |18688 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18688 [Bug 18688] Warnings about UTF-8 charset when creating a new language -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun May 28 15:11:56 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 28 May 2017 13:11:56 +0000 Subject: [Koha-bugs] [Bug 18629] Translatability: Fix problems with web installer 17.05 In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18629 Marc V?ron changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks|18688 | See Also| |https://bugs.koha-community | |.org/bugzilla3/show_bug.cgi | |?id=18688 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18688 [Bug 18688] Warnings about UTF-8 charset when creating a new language -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun May 28 15:11:56 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 28 May 2017 13:11:56 +0000 Subject: [Koha-bugs] [Bug 18688] Warnings about UTF-8 charset when creating a new language In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18688 Marc V?ron changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on|18629 | See Also| |https://bugs.koha-community | |.org/bugzilla3/show_bug.cgi | |?id=18629 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18629 [Bug 18629] Translatability: Fix problems with web installer 17.05 -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun May 28 18:44:58 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 28 May 2017 16:44:58 +0000 Subject: [Koha-bugs] [Bug 18546] Unhide the 'Hide window' link in OPAC cart In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18546 --- Comment #2 from Marc V?ron --- Created attachment 63777 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=63777&action=edit Bug 18546 - Unhide the 'Hide window' link in OPAC cart In OPAC cart, the link 'Hide window' is hidden because of a conflict with bootstrap css. This patch replaces the sprites for the toolbar with Fafamfam icons to make the 'Hide window' link visible. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun May 28 18:51:34 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 28 May 2017 16:51:34 +0000 Subject: [Koha-bugs] [Bug 18546] Unhide the 'Hide window' link in OPAC cart In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18546 --- Comment #3 from Marc V?ron --- Note: I did not touch the second toolbar (Select all, Clear all etc.) It has a problem as well: On a small screen, it is hidden (with and without this patch. Maybe the whole cart window needs a rewrite - but that is out of my scope. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun May 28 18:53:13 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 28 May 2017 16:53:13 +0000 Subject: [Koha-bugs] [Bug 18546] Unhide the 'Hide window' link in OPAC cart In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18546 Marc V?ron changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff --- Comment #4 from Marc V?ron --- Setting to NSO. If there is a better solution, I'll be happy to sign off on an alternative patch. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon May 29 02:02:39 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 29 May 2017 00:02:39 +0000 Subject: [Koha-bugs] [Bug 18674] Show timezone for Perl and MySQL on the About Koha page In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18674 Tom?s Cohen Arazi changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |tomascohen at gmail.com -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon May 29 03:31:06 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 29 May 2017 01:31:06 +0000 Subject: [Koha-bugs] [Bug 17602] Integrate support for ONeclickDigital/Recorded Books API In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17602 Srdjan Jankovic changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #63392|0 |1 is obsolete| | --- Comment #17 from Srdjan Jankovic --- Created attachment 63778 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=63778&action=edit Bug 17602 Add Oneclickdigital integration to Koha Add OneClickdigital to the users page in the public interface To Test: 1/ Apply all 3 patches 2/ Set the sysprefs to valid values (you will need a test account with Oneclickdigital) 3/ Try a search 4/ Login to the OPAC, try to place a hold, or check an item out 5/ Check the opac-user page, see if your items are showing on the oneclickdigital tab -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon May 29 04:02:43 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 29 May 2017 02:02:43 +0000 Subject: [Koha-bugs] [Bug 18663] Missing db update for ExportRemoveFields In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18663 Kyle M Hall changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |kyle at bywatersolutions.com Attachment #63678|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon May 29 04:06:33 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 29 May 2017 02:06:33 +0000 Subject: [Koha-bugs] [Bug 18663] Missing db update for ExportRemoveFields In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18663 Kyle M Hall changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to Master --- Comment #5 from Kyle M Hall --- Pushed to master for 17.05, thanks Jonathan! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon May 29 04:07:13 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 29 May 2017 02:07:13 +0000 Subject: [Koha-bugs] [Bug 18410] Koha should use cool URIs In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18410 --- Comment #2 from Pablo AB --- This could be done with some URI rewrite (Apache mod_rewrite) directives. Someone give an example on wiki: https://wiki.koha-community.org/wiki/Linked_Data_RFC#Canonical_URL.2FURI_for_records -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon May 29 04:07:24 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 29 May 2017 02:07:24 +0000 Subject: [Koha-bugs] [Bug 18662] Can not delete currencies In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18662 Kyle M Hall changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |kyle at bywatersolutions.com Status|Passed QA |Pushed to Master --- Comment #4 from Kyle M Hall --- Pushed to master for 17.05, thanks Jonathan! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon May 29 04:07:55 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 29 May 2017 02:07:55 +0000 Subject: [Koha-bugs] [Bug 16295] marc_modification_templates permission doesn' t allow access to modify template In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16295 Kyle M Hall changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |kyle at bywatersolutions.com Attachment #63666|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon May 29 04:11:20 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 29 May 2017 02:11:20 +0000 Subject: [Koha-bugs] [Bug 16295] marc_modification_templates permission doesn' t allow access to modify template In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16295 Kyle M Hall changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to Master --- Comment #6 from Kyle M Hall --- Pushed to master for 17.05, thanks Jonathan! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon May 29 04:12:32 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 29 May 2017 02:12:32 +0000 Subject: [Koha-bugs] [Bug 18204] Authority searches are not saved in Search history In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18204 Kyle M Hall changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to Master CC| |kyle at bywatersolutions.com --- Comment #9 from Kyle M Hall --- Pushed to master for 17.05, thanks Leire! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon May 29 04:15:31 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 29 May 2017 02:15:31 +0000 Subject: [Koha-bugs] [Bug 18642] Internal Server Error in Guided reports wizard caused by debug messages In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18642 Kyle M Hall changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |kyle at bywatersolutions.com Status|Passed QA |Pushed to Master --- Comment #8 from Kyle M Hall --- Pushed to master for 17.05, thanks Josef! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon May 29 04:16:38 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 29 May 2017 02:16:38 +0000 Subject: [Koha-bugs] [Bug 18620] t/db_dependent/Letters.t failing on master In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18620 Kyle M Hall changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |kyle at bywatersolutions.com Status|Passed QA |Pushed to Master --- Comment #10 from Kyle M Hall --- Pushed to master for 17.05, thanks Nick! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon May 29 04:18:03 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 29 May 2017 02:18:03 +0000 Subject: [Koha-bugs] [Bug 18478] Some notices sent via SMS gateway fail In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18478 Kyle M Hall changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to Master --- Comment #20 from Kyle M Hall --- Pushed to master for 17.05, thanks Nick, Marcel! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon May 29 04:22:30 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 29 May 2017 02:22:30 +0000 Subject: [Koha-bugs] [Bug 18600] Missing db update for TalkingTechItivaPhoneNotification In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18600 Kyle M Hall changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to Master CC| |kyle at bywatersolutions.com --- Comment #6 from Kyle M Hall --- Pushed to master for 17.05, thanks Jonathan! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon May 29 04:24:14 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 29 May 2017 02:24:14 +0000 Subject: [Koha-bugs] [Bug 18611] Create labels action fails in manage-marc-import.pl if an item has been deleted from the import batch. In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18611 Kyle M Hall changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to Master CC| |kyle at bywatersolutions.com --- Comment #10 from Kyle M Hall --- Pushed to master for 17.05, thanks Nick, Josef, Marcel! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon May 29 04:25:42 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 29 May 2017 02:25:42 +0000 Subject: [Koha-bugs] [Bug 18632] CGI::param called in list context flooding erro logs In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18632 Kyle M Hall changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to Master CC| |kyle at bywatersolutions.com --- Comment #4 from Kyle M Hall --- Pushed to master for 17.05, thanks Jonathan! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon May 29 04:26:48 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 29 May 2017 02:26:48 +0000 Subject: [Koha-bugs] [Bug 18664] IssueSlip.t is failing - IssueSlip should return if params are not valid In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18664 Kyle M Hall changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to Master CC| |kyle at bywatersolutions.com --- Comment #4 from Kyle M Hall --- Pushed to master for 17.05, thanks Jonathan! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon May 29 04:30:12 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 29 May 2017 02:30:12 +0000 Subject: [Koha-bugs] [Bug 18689] New: adding a holiday in holidays.pl with double-quotes in title or description breaks calendar. Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18689 Bug ID: 18689 Summary: adding a holiday in holidays.pl with double-quotes in title or description breaks calendar. Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Tools Assignee: gmcharlt at gmail.com Reporter: barton at bywatersolutions.com QA Contact: testopia at bugs.koha-community.org To replicate: 1/ Go to Tools > Calendar 2/ Click on a date 3/ Enter a title with text enclosed in double quotes "like this". 4/ Click Save This will cause a JavaScript error that prevents the calendar from displaying: holidays.pl?branch=CPL&calendardate=2017-05-01:382 Uncaught SyntaxError: Unexpected identifier Here's an example of the code that's erroring out: holidays["2017/5/1"] = {title:"This will cause "failure". ", description:"asdf"}; The problem is that the quotes are not escaped. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon May 29 04:30:34 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 29 May 2017 02:30:34 +0000 Subject: [Koha-bugs] [Bug 18669] RewriteCond affecting wrong rule in koha-httpd.conf In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18669 Kyle M Hall changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |kyle at bywatersolutions.com Status|Passed QA |Pushed to Master --- Comment #6 from Kyle M Hall --- Pushed to master for 17.05, thanks David! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon May 29 04:31:38 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 29 May 2017 02:31:38 +0000 Subject: [Koha-bugs] [Bug 5395] C4::Acquisition::SearchOrder POD inconsistent with function In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5395 Kyle M Hall changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to Master CC| |kyle at bywatersolutions.com --- Comment #9 from Kyle M Hall --- Pushed to master for 17.05, thanks Mark! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon May 29 04:35:44 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 29 May 2017 02:35:44 +0000 Subject: [Koha-bugs] [Bug 18689] adding a holiday in holidays.pl with double-quotes in title or description breaks calendar. In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18689 Barton Chittenden changed: What |Removed |Added ---------------------------------------------------------------------------- Severity|enhancement |major --- Comment #1 from Barton Chittenden --- Marking importance as major, because the bug creates an error that the user can't recover from. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon May 29 05:11:48 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 29 May 2017 03:11:48 +0000 Subject: [Koha-bugs] [Bug 17602] Integrate support for ONeclickDigital/Recorded Books API In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17602 Srdjan Jankovic changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #62248|0 |1 is obsolete| | Attachment #62249|0 |1 is obsolete| | --- Comment #18 from Srdjan Jankovic --- Created attachment 63779 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=63779&action=edit Bug 17602 Add OneClickDigital Integration to Koha Koha::ExternalContent::OneClickDigital - a wrapper around WebService::ILS::OneClickDigital::PartnerPatron OneClickDigital* sysprefs Nothing functional to test with this patch yet. But you can run the tests that come with it t/db_dependent/Koha_ExternalContent_OneClickDigital.t -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon May 29 05:12:40 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 29 May 2017 03:12:40 +0000 Subject: [Koha-bugs] [Bug 17602] Integrate support for ONeclickDigital/Recorded Books API In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17602 Srdjan Jankovic changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon May 29 05:12:43 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 29 May 2017 03:12:43 +0000 Subject: [Koha-bugs] [Bug 17602] Integrate support for ONeclickDigital/Recorded Books API In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17602 Srdjan Jankovic changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #63778|0 |1 is obsolete| | --- Comment #19 from Srdjan Jankovic --- Created attachment 63780 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=63780&action=edit Bug 17602 Add Oneclickdigital integration to Koha Add OneClickdigital to the users page in the public interface To Test: 1/ Apply all 3 patches 2/ Set the sysprefs to valid values (you will need a test account with Oneclickdigital) 3/ Try a search 4/ Login to the OPAC, try to place a hold, or check an item out 5/ Check the opac-user page, see if your items are showing on the oneclickdigital tab -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon May 29 07:14:03 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 29 May 2017 05:14:03 +0000 Subject: [Koha-bugs] [Bug 15271] Calendar breaks on double quotes in title or description of holiday In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15271 Marc V?ron changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |https://bugs.koha-community | |.org/bugzilla3/show_bug.cgi | |?id=18689 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon May 29 07:14:03 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 29 May 2017 05:14:03 +0000 Subject: [Koha-bugs] [Bug 18689] adding a holiday in holidays.pl with double-quotes in title or description breaks calendar. In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18689 Marc V?ron changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |https://bugs.koha-community | |.org/bugzilla3/show_bug.cgi | |?id=15271 CC| |veron at veron.ch -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon May 29 07:16:11 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 29 May 2017 05:16:11 +0000 Subject: [Koha-bugs] [Bug 18616] The "Add forgot password link to OPAC" should allow patrons to use their library card number in addition to username In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18616 Marc V?ron changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |veron at veron.ch -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon May 29 07:18:22 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 29 May 2017 05:18:22 +0000 Subject: [Koha-bugs] [Bug 11235] Names for reports cut off when quotes are used In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11235 Marc V?ron changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |https://bugs.koha-community | |.org/bugzilla3/show_bug.cgi | |?id=18689 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon May 29 07:18:22 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 29 May 2017 05:18:22 +0000 Subject: [Koha-bugs] [Bug 18689] adding a holiday in holidays.pl with double-quotes in title or description breaks calendar. In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18689 Marc V?ron changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |https://bugs.koha-community | |.org/bugzilla3/show_bug.cgi | |?id=11235 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon May 29 07:19:43 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 29 May 2017 05:19:43 +0000 Subject: [Koha-bugs] [Bug 18689] adding a holiday in holidays.pl with double-quotes in title or description breaks calendar. In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18689 Marc V?ron changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |https://bugs.koha-community | |.org/bugzilla3/show_bug.cgi | |?id=13747 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon May 29 07:19:43 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 29 May 2017 05:19:43 +0000 Subject: [Koha-bugs] [Bug 13747] Frequency description doesn' t work well with strings containing quotes In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13747 Marc V?ron changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |https://bugs.koha-community | |.org/bugzilla3/show_bug.cgi | |?id=18689 -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Mon May 29 07:21:14 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 29 May 2017 05:21:14 +0000 Subject: [Koha-bugs] [Bug 18689] adding a holiday in holidays.pl with double-quotes in title or description breaks calendar. In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18689 Marc V?ron changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |https://bugs.koha-community | |.org/bugzilla3/show_bug.cgi | |?id=5471 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon May 29 07:21:14 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 29 May 2017 05:21:14 +0000 Subject: [Koha-bugs] [Bug 5471] Quotes in tags cause moderation approval/rejection to fail In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5471 Marc V?ron changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |https://bugs.koha-community | |.org/bugzilla3/show_bug.cgi | |?id=18689 -- You are receiving this mail because: You are watching all bug changes. You are the QA Contact for the bug. From bugzilla-daemon at bugs.koha-community.org Mon May 29 07:22:02 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 29 May 2017 05:22:02 +0000 Subject: [Koha-bugs] [Bug 18689] adding a holiday in holidays.pl with double-quotes in title or description breaks calendar. In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18689 Marc V?ron changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |https://bugs.koha-community | |.org/bugzilla3/show_bug.cgi | |?id=9814 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon May 29 07:22:02 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 29 May 2017 05:22:02 +0000 Subject: [Koha-bugs] [Bug 9814] KohaAdminEmailAddress syspref webpage field doesn' t handle double quotes In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9814 Marc V?ron changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |https://bugs.koha-community | |.org/bugzilla3/show_bug.cgi | |?id=18689 -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Mon May 29 07:30:30 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 29 May 2017 05:30:30 +0000 Subject: [Koha-bugs] [Bug 16976] Authorities searches with double quotes gives ZOOM error 20003 In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16976 Marc V?ron changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |veron at veron.ch Version|16.05 |master --- Comment #1 from Marc V?ron --- Confirmed on current master. Steps to reproduce: Go to Home > Authorities Search "test" (including double quotes Result: Internal server error, plack error log says: ZOOM error 20003 "can't set prefix query" (addinfo: "@or @attr 7=1 @attr 1=Heading 0 @attr 1=Heading-Main @attr 5=1 @attr 4=6 "\\"test\\""") from diag-set 'ZOOM' Same with search after "test (one qoute only -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon May 29 07:30:44 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 29 May 2017 05:30:44 +0000 Subject: [Koha-bugs] [Bug 18689] adding a holiday in holidays.pl with double-quotes in title or description breaks calendar. In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18689 Marc V?ron changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |https://bugs.koha-community | |.org/bugzilla3/show_bug.cgi | |?id=16976 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon May 29 07:30:44 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 29 May 2017 05:30:44 +0000 Subject: [Koha-bugs] [Bug 16976] Authorities searches with double quotes gives ZOOM error 20003 In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16976 Marc V?ron changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |https://bugs.koha-community | |.org/bugzilla3/show_bug.cgi | |?id=18689 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon May 29 07:34:06 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 29 May 2017 05:34:06 +0000 Subject: [Koha-bugs] [Bug 16863] Quotes around search term cause search failure if QueryAutoTruncate is not enabled. In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16863 Marc V?ron changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |https://bugs.koha-community | |.org/bugzilla3/show_bug.cgi | |?id=18689 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon May 29 07:34:06 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 29 May 2017 05:34:06 +0000 Subject: [Koha-bugs] [Bug 18689] adding a holiday in holidays.pl with double-quotes in title or description breaks calendar. In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18689 Marc V?ron changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |https://bugs.koha-community | |.org/bugzilla3/show_bug.cgi | |?id=16863 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon May 29 07:34:21 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 29 May 2017 05:34:21 +0000 Subject: [Koha-bugs] [Bug 17151] Extended patron attributes not importing when using double quotes In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17151 Marc V?ron changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |https://bugs.koha-community | |.org/bugzilla3/show_bug.cgi | |?id=18689 -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon May 29 07:34:21 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 29 May 2017 05:34:21 +0000 Subject: [Koha-bugs] [Bug 18689] adding a holiday in holidays.pl with double-quotes in title or description breaks calendar. In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18689 Marc V?ron changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |https://bugs.koha-community | |.org/bugzilla3/show_bug.cgi | |?id=17151 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon May 29 07:38:09 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 29 May 2017 05:38:09 +0000 Subject: [Koha-bugs] [Bug 18294] Keyword searches surrounded by double quotes fail on staff client and OPAC In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18294 Marc V?ron changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |veron at veron.ch -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon May 29 07:45:32 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 29 May 2017 05:45:32 +0000 Subject: [Koha-bugs] [Bug 18410] Koha should use cool URIs In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18410 Marc V?ron changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |veron at veron.ch -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon May 29 07:46:12 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 29 May 2017 05:46:12 +0000 Subject: [Koha-bugs] [Bug 18674] Show timezone for Perl and MySQL on the About Koha page In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18674 Marc V?ron changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |veron at veron.ch -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon May 29 07:51:22 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 29 May 2017 05:51:22 +0000 Subject: [Koha-bugs] [Bug 18679] Patron Attributes in Self Registration In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18679 Marc V?ron changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |veron at veron.ch --- Comment #1 from Marc V?ron --- It seems that it depends on system preference PatronSelfRegistrationVerifyByEmail See in staff client: Home > Administration > Patron attribute types > Modify patron attribute type Display in OPAC: Check to display this attribute on a patron's details page in the OPAC. Editable in OPAC: Check to allow patrons to edit this attribute from their details page in the OPAC. (Requires above, does not work with PatronSelfRegistrationVerifyByEmail.) -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon May 29 08:04:05 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 29 May 2017 06:04:05 +0000 Subject: [Koha-bugs] [Bug 18671] Calendar.t failing exception holiday test In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18671 Marc V?ron changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |veron at veron.ch --- Comment #1 from Marc V?ron --- It depends on syspref 'CalendarFirstDayOfWeek' prove -v t/Calendar.t If CalendarFirstDayOfWeek is set to Sunday, test passes OK If CalendarFirstDayOfWeekset is set to Monday, test fails with: not ok 13 - Exception holiday is not a closed day test # Failed test 'Exception holiday is not a closed day test' # at t/Calendar.t line 164. # got: '1' # expected: '0' -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Mon May 29 08:08:39 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 29 May 2017 06:08:39 +0000 Subject: [Koha-bugs] [Bug 11813] Send 'Opac self registration verification' email from branch address if possible In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11813 Marc V?ron changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |veron at veron.ch -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon May 29 08:33:14 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 29 May 2017 06:33:14 +0000 Subject: [Koha-bugs] [Bug 18672] Creation Date and Modification Date are the same for a list in the Lists Module In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18672 Marc V?ron changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |veron at veron.ch Version|16.11 |master --- Comment #1 from Marc V?ron --- Confirmed on current master. The error occurs when a list is edited. To reproduce: - In staff client, create a new list (if you have not already one) - In db, update virtualshelves and set field created_on to an earlier date, something like: update virtualshelves set created_on = '2017-04-01 02:09:12' where shelfnumber = 1; - Go to Home > Lists > Your lists - Verify that the modified creation date for this list appears in staff client - Edit list in staff client, save - Verify that creation date is overwritten by modification date (wrong) -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon May 29 09:00:35 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 29 May 2017 07:00:35 +0000 Subject: [Koha-bugs] [Bug 18672] Creation Date and Modification Date are the same for a list in the Lists Module In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18672 --- Comment #2 from Marc V?ron --- Created attachment 63781 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=63781&action=edit Bug 18672 - Fix overwriting creation date with modification date when editing list To reproduce: - In staff client, create a new list (if you have not already one) - In db, update virtualshelves and set field created_on to an earlier date, something like: update virtualshelves set created_on = '2017-04-01 02:09:12' where shelfnumber = 1; - Go to Home > Lists > Your lists - Verify that the modified creation date for this list appears in staff client - Edit list in staff client, save - Verify that creation date is overwritten by modification date (wrong) To test: - Apply patch - Repeat steps above, verify that creation date no longer is overwritten by modification date -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon May 29 09:01:21 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 29 May 2017 07:01:21 +0000 Subject: [Koha-bugs] [Bug 18672] Creation Date and Modification Date are the same for a list in the Lists Module In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18672 Marc V?ron changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|gmcharlt at gmail.com |veron at veron.ch Patch complexity|--- |Trivial patch Status|NEW |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon May 29 09:04:31 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 29 May 2017 07:04:31 +0000 Subject: [Koha-bugs] [Bug 12566] Duplicate checks for Self Registered borrowers In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12566 Marc V?ron changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |veron at veron.ch -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon May 29 09:07:41 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 29 May 2017 07:07:41 +0000 Subject: [Koha-bugs] [Bug 12566] Duplicate checks for Self Registered borrowers In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12566 Marc V?ron changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |https://bugs.koha-community | |.org/bugzilla3/show_bug.cgi | |?id=16711 -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Mon May 29 09:07:41 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 29 May 2017 07:07:41 +0000 Subject: [Koha-bugs] [Bug 16711] OPAC Password recovery: Handling if multiple accounts have the same mail address In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16711 Marc V?ron changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |https://bugs.koha-community | |.org/bugzilla3/show_bug.cgi | |?id=12566 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon May 29 09:10:05 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 29 May 2017 07:10:05 +0000 Subject: [Koha-bugs] [Bug 18677] issue_id is not added to accountlines for lost item fees In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18677 Marc V?ron changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |veron at veron.ch -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon May 29 09:10:47 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 29 May 2017 07:10:47 +0000 Subject: [Koha-bugs] [Bug 18676] Optionally delete fast add items and records on return In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18676 Marc V?ron changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |veron at veron.ch -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon May 29 09:11:28 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 29 May 2017 07:11:28 +0000 Subject: [Koha-bugs] [Bug 3005] Record deletion successful In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=3005 Marc V?ron changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |veron at veron.ch -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon May 29 09:18:18 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 29 May 2017 07:18:18 +0000 Subject: [Koha-bugs] [Bug 16332] calendar don't show next month In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16332 Marc V?ron changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |veron at veron.ch --- Comment #1 from Marc V?ron --- I can not reproduce the issue (calendar on https://koha-community.org/calendar/action~month/) -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon May 29 09:25:06 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 29 May 2017 07:25:06 +0000 Subject: [Koha-bugs] [Bug 18679] Patron Attributes in Self Registration In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18679 --- Comment #2 from Apurba Jyoti Majumder --- Editable in OPAC: Check to allow patrons to edit this attribute from their details page in the OPAC. This above option could not be found. snapshot required -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon May 29 10:21:46 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 29 May 2017 08:21:46 +0000 Subject: [Koha-bugs] [Bug 18672] Creation Date and Modification Date are the same for a list in the Lists Module In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18672 --- Comment #3 from Marc V?ron --- Created attachment 63782 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=63782&action=edit Bug 18672: Test for fixing overwriting creation date Use this test to highlight issue: prove -v t/db_dependent/Virtualshelves.t After applying patch for Koha/Virtualshelf.pm it should turn green -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon May 29 10:53:44 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 29 May 2017 08:53:44 +0000 Subject: [Koha-bugs] [Bug 18679] Patron Attributes in Self Registration In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18679 --- Comment #3 from Marc V?ron --- Created attachment 63783 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=63783&action=edit Make patron attribute type editable in OPAC Screenshot for comment #1 -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon May 29 11:54:23 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 29 May 2017 09:54:23 +0000 Subject: [Koha-bugs] [Bug 18356] Prediction pattern wrong, skips years, for some year based frequencies In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18356 Marcel de Rooy changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #63470|0 |1 is obsolete| | Attachment #63471|0 |1 is obsolete| | --- Comment #5 from Marcel de Rooy --- Created attachment 63784 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=63784&action=edit Bug 18356: Extend GetNextDate.t, add GetFictiveIssueNumber.t (unit=year) This patch deals with tests for yearly frequencies. Adjust/extend GetNextDate.t: [1] Adjust mixup of units/issues in a description. [2] Add testing +2 years on 29-2 of leap year for freq 1 issue/2 years. [3] Add tests for freq 9 issues/year. Add GetFictiveIssueNumber.t: [1] Two subtests are provided for irregular frequencies (very trivial) and for year frequencies (with four specific test cases). Test plan: [1] Run t/db_dependent/Serials/GetNextDate.t [2] Run t/db_dependent/Serials/GetFictiveIssueNumber.t Note: Without the second patch both tests should fail. This shows the need of the adjustments in the second patch. Signed-off-by: Marcel de Rooy -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon May 29 11:54:28 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 29 May 2017 09:54:28 +0000 Subject: [Koha-bugs] [Bug 18356] Prediction pattern wrong, skips years, for some year based frequencies In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18356 --- Comment #6 from Marcel de Rooy --- Created attachment 63785 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=63785&action=edit Bug 18356: Fix date calculations for yearly frequencies in Serials The problem as described on BZ 18356 is a combination of an error in GetFictiveIssueNumber and GetNextDate for unit==year. [1] In GetNextDate the Add_Delta_YM calculation should be applied only to frequencies based on years per unit. In the case of multiple units per year we calculate the number of days to add. And if we have reached the end of a cycle, we correct the rounding applied in the cycle. NOTE 1: We obsolete the idea here of rebasing dates on firstacqui. In case of manual adjustments, we probably do not want it. And otherwise we do not need it anymore due to the correction at the end of a cycle. NOTE 2: The calls to Add_Delta_YM are intentionally not corrected for leap years. Say you start at 2016-02-29. If you use 1/yr or 1/2yr, you will switch to the Feb 28th in the following years. In 2020 there will be no switch to Feb 29 again; if someone should need it, please use a manual adjustment. This is probably highly exceptional. [2] In GetFictiveIssueNumber the year should be decreased by one if you have more units per year and you did not yet reach firstacqui day and month. This affects calculations in GetNextDate with irregularities. NOTE: In case of manual adjustments this calculation does not really make sense. Another report should deal with improving irregularities. Test plan: [1] Verify that both GetNextDate.t as well as GetFictiveIssueNumber.t pass. [2] Look at the prediction pattern for a few frequencies. For example: 1 iss/y, 1 iss/2y, 5 iss/y. Signed-off-by: Marcel de Rooy -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon May 29 11:54:21 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 29 May 2017 09:54:21 +0000 Subject: [Koha-bugs] [Bug 18356] Prediction pattern wrong, skips years, for some year based frequencies In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18356 Marcel de Rooy changed: What |Removed |Added ---------------------------------------------------------------------------- Status|BLOCKED |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon May 29 11:55:45 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 29 May 2017 09:55:45 +0000 Subject: [Koha-bugs] [Bug 18356] Prediction pattern wrong, skips years, for some year based frequencies In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18356 --- Comment #7 from Marcel de Rooy --- Will add links to follow-up reports that handle the other frequencies. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon May 29 11:56:14 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 29 May 2017 09:56:14 +0000 Subject: [Koha-bugs] [Bug 17499] Koha objects for messaging preferences In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17499 Lari Taskula changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #63427|0 |1 is obsolete| | --- Comment #9 from Lari Taskula --- Created attachment 63786 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=63786&action=edit Bug 17499: Add Koha-objects for messaging preferences This patch adds Koha-objects for messaging preferences. This patch does not add any extra logic into these objects. Includes test coverage for basic usage. To test: 1. prove t/db_dependent/Koha/Patron/Message/* -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon May 29 11:56:25 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 29 May 2017 09:56:25 +0000 Subject: [Koha-bugs] [Bug 17499] Koha objects for messaging preferences In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17499 Lari Taskula changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #63428|0 |1 is obsolete| | --- Comment #10 from Lari Taskula --- Created attachment 63787 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=63787&action=edit Bug 17499: Add useful Koha::Exceptions This patch adds some basic Koha::Exceptions that will be useful. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon May 29 11:56:44 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 29 May 2017 09:56:44 +0000 Subject: [Koha-bugs] [Bug 17499] Koha objects for messaging preferences In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17499 Lari Taskula changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #63429|0 |1 is obsolete| | --- Comment #11 from Lari Taskula --- Created attachment 63788 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=63788&action=edit Bug 17499: Add basic validation for messaging preference This patch adds simple validation for messaging preferences. The validation includes - check that only either borrowernumber or categorycode is given, but not both - throw exception if patron for the given borrowernumber is not found - throw exception if category for the given categorycode is not found - throw exception if days in advance cannot be configured - throw exception if days in advance configuration is invalid (value between 0-30) - throw exception if digest is not available To test: 1. Run t/db_dependent/Koha/Patron/Message/Preferences.t -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon May 29 11:56:58 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 29 May 2017 09:56:58 +0000 Subject: [Koha-bugs] [Bug 17499] Koha objects for messaging preferences In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17499 Lari Taskula changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #63430|0 |1 is obsolete| | --- Comment #12 from Lari Taskula --- Created attachment 63789 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=63789&action=edit Bug 17499: Throw an exception on duplicate messaging preference When trying to add a duplicate messaging preference that has the same borrowernumber or category, and message_attribute_id as another preference, throw Koha::Exceptions::DuplicateObject. To test: 1. Run t/db_dependent/Koha/Patron/Message/Preferences.t -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon May 29 11:57:10 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 29 May 2017 09:57:10 +0000 Subject: [Koha-bugs] [Bug 17499] Koha objects for messaging preferences In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17499 Lari Taskula changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #63431|0 |1 is obsolete| | --- Comment #13 from Lari Taskula --- Created attachment 63790 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=63790&action=edit Bug 17499: Add a method for getting messaging options This patch adds a method for getting available messaging options. To test: 1. Run t/db_dependent/Koha/Patron/Message/Preferences.t -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon May 29 11:57:36 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 29 May 2017 09:57:36 +0000 Subject: [Koha-bugs] [Bug 17499] Koha objects for messaging preferences In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17499 Lari Taskula changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #63432|0 |1 is obsolete| | --- Comment #14 from Lari Taskula --- Created attachment 63791 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=63791&action=edit Bug 17499: Add a method for setting default messaging preferences This patch adds a method Koha::Patron::Message::Preference->new_from_default that can be used to add category's default messaging preferences to patron for a given message type. Example call: Koha::Patron::Message::Preference->new_from_default({ borrowernumber => 123, categorycode => "ABC", message_attribute_id => 1, }); Also adds a simple method for Koha::Patron, set_default_messaging_preferences. Usage: $patron->set_default_messaging_preferences() To test: 1. Run t/db_dependent/Koha/Patron/Message/Preferences.t -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon May 29 11:58:03 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 29 May 2017 09:58:03 +0000 Subject: [Koha-bugs] [Bug 17499] Koha objects for messaging preferences In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17499 Lari Taskula changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #63433|0 |1 is obsolete| | --- Comment #15 from Lari Taskula --- Created attachment 63792 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=63792&action=edit Bug 17499: Improve object usability by enabling direct access to transport preferences Since messaging preference is a feature that has multiple related database tables, usage via Koha-objects is sometimes frustrating. This patch adds a feature for Koha::Patron::Message::Preference which enables access to message transport preferences directly via this object. It allows us to skip calls to Koha::Patron::Message::Transport::Preference(s) because we can now get and set via K::P::M::Preference. Get: $preference->message_transport_types Returns a hashref, where each key is stored transport type and value for the key is letter code for the transport. Set: $preference->set({ message_transport_types => ['sms'] }) or $preference->message_transport_types('email', 'sms') or $preference->message_transport_types(['email', 'sms']) Returns $self (Koha::Patron::Message::Preference object) To test: 1. Run t/db_dependent/Koha/Patron/Message/Preferences.t -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon May 29 11:58:23 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 29 May 2017 09:58:23 +0000 Subject: [Koha-bugs] [Bug 17499] Koha objects for messaging preferences In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17499 Lari Taskula changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #63434|0 |1 is obsolete| | --- Comment #16 from Lari Taskula --- Created attachment 63793 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=63793&action=edit Bug 17499: Simplify searching by message_name This patch adds optional search & find parameter message_name for Koha::Patron::Message::Preferences->search and ->find. This simplifies object usage by allowing us to skip joins or finding the attribute id ourselves. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon May 29 12:42:06 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 29 May 2017 10:42:06 +0000 Subject: [Koha-bugs] [Bug 18690] New: Typos in Koha database description (Table "borrowers") Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18690 Bug ID: 18690 Summary: Typos in Koha database description (Table "borrowers") Change sponsored?: --- Product: Koha Version: 16.11 Hardware: All OS: All Status: NEW Severity: trivial Priority: P5 - low Component: Installation and upgrade (command-line installer) Assignee: gmcharlt at gmail.com Reporter: mik at adminkuhn.ch QA Contact: testopia at bugs.koha-community.org There are some typos in the SchemaSpy description of table "borrowers". * http://schema.koha-community.org/16_11/tables/borrowers.html 1. In the comment for field "debarred" (YYY-MM-DD) should by replaced by (YYYY-MM-DD) 2. In the comment for field "smsalertnumber" SNS should be replaced by SMS 3. In the comments of fields "contactname", "contacttitle", "guarantorid", "relationship" the term "guarentor" is used, but it should be "guarantor". 4. The comment for field "password" reads "patron/borrower's encrypted password". I think it could be more explicit by writing "patron/borrower's Bcrypt encrypted password". -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon May 29 12:53:41 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 29 May 2017 10:53:41 +0000 Subject: [Koha-bugs] [Bug 18690] Typos in Koha database description (Table "borrowers") In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18690 Marc V?ron changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |veron at veron.ch -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon May 29 13:15:47 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 29 May 2017 11:15:47 +0000 Subject: [Koha-bugs] [Bug 18595] Move C4::Members::Messaging to Koha namespace In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18595 Lari Taskula changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #63436|0 |1 is obsolete| | --- Comment #10 from Lari Taskula --- Created attachment 63795 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=63795&action=edit Bug 18595: Move C4::Members::Messaging::GetMessagingOptions This patch moves C4::Members::GetMessagingOptions to Koha::Patron::Message::Preferences->get_options. The patch makes a heavy touch on core messaging preference features, but should not introduce any visible changes for end user. Keep this in mind if testing. If you notice any changes in Koha, something is probably wrong! This patch also removes previously unused GetMessagingOptions in opac-messaging.pl To test: Make sure you have enabled the following system preferences: - opacuserlogin - EnhancedMessagingPreferences - EnhancedMessagingPreferencesOPAC ---- GENERAL ---- 1. Apply patch 2. Search Koha source code for references of "GetMessagingOptions" (grep -r 'GetMessagingOptions'). 3. Observe no results in source code. ---- OPAC ---- 1. Login to OPAC. 2. Go to "your messaging" (cgi-bin/koha/opac-messaging.pl). 3. Observe the preferences looking normal and as they should be. 4. Set any combination of messaging preferences. 5. Observe them apply as expected, repeat step 4-5 as much as you like. ---- INTRANET ---- 1. Login to intranet. 2. Go to edit patron's details and scroll down to their messaging preferences. 3. Observe the preferences looking normal and as they should be. 4. Set any combination of messaging preferences. 5. Observe them apply as expected, repeat step 4-5 as much as you like. 6. Go to Administration -> Patron categories -> Edit (for any category) 7. Scroll down to observe default messaging preferences for this patron category 8. Observe the preferences looking normal and as they should be. 9. Set any combination of messaging preferences. 10. Observe them apply as expected, repeat step 9-10 as much as you like. 11. Go to cgi-bin/koha/members/memberentry.pl?op=add&categorycode=XXX, replace XXX with the categorycode you were just editing. 12. Fill in required data, do not modify messaging preferences, click Save. 13. Observe a new patron with default messaging preferences. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon May 29 13:15:35 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 29 May 2017 11:15:35 +0000 Subject: [Koha-bugs] [Bug 18595] Move C4::Members::Messaging to Koha namespace In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18595 Lari Taskula changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #63435|0 |1 is obsolete| | --- Comment #9 from Lari Taskula --- Created attachment 63794 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=63794&action=edit Bug 18595: Unit tests for Koha::Patron::Categories->default_messaging This patch adds unit tests for Koha::Patron::Categories->default_messaging. Tests will help preparing for moving C4::Members::Messaging to Koha-objects. To test: 1. Run t/db_dependent/Koha/Patron/Categories.t -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon May 29 13:16:08 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 29 May 2017 11:16:08 +0000 Subject: [Koha-bugs] [Bug 18595] Move C4::Members::Messaging to Koha namespace In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18595 Lari Taskula changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #63438|0 |1 is obsolete| | --- Comment #12 from Lari Taskula --- Created attachment 63797 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=63797&action=edit Bug 18595: Unit tests preparing for GetMessagingPreferences move This patch prepares removing GetMessagingPreferences by adding some useful unit tests for subroutines that the move targets. Reserves.t already covers print notice, but this patch adds tests for a set transport type. To test: 1. Run t/db_dependent/Circulation.t 2. Run t/db_dependent/Reserves.t 3. Observe test pass -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon May 29 13:15:58 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 29 May 2017 11:15:58 +0000 Subject: [Koha-bugs] [Bug 18595] Move C4::Members::Messaging to Koha namespace In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18595 Lari Taskula changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #63437|0 |1 is obsolete| | --- Comment #11 from Lari Taskula --- Created attachment 63796 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=63796&action=edit Bug 18595: Move C4::Members::Messaging::SetMessagingPreferencesFromDefaults This patch moves C4::Members::SetMessagingPreferencesFromDefaults to Koha::Patron->set_default_messaging_preferences The patch makes a heavy touch on core messaging preference features, but should not introduce any visible changes for end user. Keep this in mind if testing. If you notice any changes in Koha, something is probably wrong! To test: Make sure you have enabled the following system preferences: - EnhancedMessagingPreferences ---- GENERAL ---- 1. Apply patch 2. Search Koha source code for references of "SetMessagingPreferencesFromDefaults" (grep -r 'SetMessagingPreferencesFromDefaults'). 3. Observe no results in source code. ---- INTRANET ---- 1. Login to intranet. 2. Go to Administration -> Patron categories -> Edit (for any category) 3. Scroll down to observe default messaging preferences for this patron category 4. Observe the preferences, remember them for the next step. 5. Go to cgi-bin/koha/members/memberentry.pl?op=add&categorycode=XXX, replace XXX with the categorycode you were just editing. 6. Look at messaging preferences. They should be same as in step 4. 7. Fill in required data, do not modify messaging preferences, click Save. 8. Observe a new patron with default messaging preferences. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon May 29 13:16:19 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 29 May 2017 11:16:19 +0000 Subject: [Koha-bugs] [Bug 18595] Move C4::Members::Messaging to Koha namespace In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18595 Lari Taskula changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #63439|0 |1 is obsolete| | --- Comment #13 from Lari Taskula --- Created attachment 63798 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=63798&action=edit Bug 18595: Move C4::Members::Messaging::GetMessagingPreferences This patch moves C4::Members::Messaging::GetMessagingPreferences to Koha::Patron::Message::Preference(s) The patch makes a heavy touch on core messaging preference features, but should not introduce any visible changes for end user. Keep this in mind if testing. If you notice any changes in Koha, something is probably wrong! To test: Make sure you have enabled the following system preferences: - EnhancedMessagingPreferences ---- GENERAL ---- 1. Apply patch 2. Search Koha source code for references of "GetMessagingPreferences" (grep -r 'GetMessagingPreferences'). 3. Observe no results in source code. ---- INTRANET ---- 1. todo ---- UNIT TESTS ---- 1. prove t/db_dependent/Circulation.t 2. prove t/db_dependent/Reserves.t 3. prove t/db_dependent/Koha/Patron/Categories.t -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon May 29 13:16:35 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 29 May 2017 11:16:35 +0000 Subject: [Koha-bugs] [Bug 18595] Move C4::Members::Messaging to Koha namespace In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18595 Lari Taskula changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon May 29 13:16:46 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 29 May 2017 11:16:46 +0000 Subject: [Koha-bugs] [Bug 18595] Move C4::Members::Messaging to Koha namespace In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18595 Lari Taskula changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|gmcharlt at gmail.com |lari.taskula at jns.fi -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon May 29 13:16:58 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 29 May 2017 11:16:58 +0000 Subject: [Koha-bugs] [Bug 17499] Koha objects for messaging preferences In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17499 Lari Taskula changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon May 29 13:17:51 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 29 May 2017 11:17:51 +0000 Subject: [Koha-bugs] [Bug 18595] Move C4::Members::Messaging to Koha namespace In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18595 Lari Taskula changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #63440|0 |1 is obsolete| | --- Comment #14 from Lari Taskula --- Created attachment 63799 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=63799&action=edit Bug 18595: Move C4::Members::Messaging::SetMessagingPreference This patch moves C4::Members::Messaging::SetMessagingPreference to Koha::Patron::Message::Preference The patch makes a heavy touch on core messaging preference features, but should not introduce any visible changes for end user. Keep this in mind if testing. If you notice any changes in Koha, something is probably wrong! To test: Make sure you have enabled the following system preferences: - EnhancedMessagingPreferences ---- GENERAL ---- 1. Apply patch 2. Search Koha source code for references of "SetMessagingPreference" (grep -r 'SetMessagingPreference'). 3. Observe no results in source code. ---- INTRANET ---- 1. todo ---- UNIT TESTS ---- 1. prove t/db_dependent/Circulation.t 2. prove t/db_dependent/Reserves.t 3. prove t/db_dependent/Koha/Patron/Categories.t -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon May 29 13:18:02 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 29 May 2017 11:18:02 +0000 Subject: [Koha-bugs] [Bug 18595] Move C4::Members::Messaging to Koha namespace In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18595 Lari Taskula changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #63441|0 |1 is obsolete| | --- Comment #15 from Lari Taskula --- Created attachment 63800 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=63800&action=edit Bug 18595: Remove references to C4::Members::Messaging $ grep -r 'C4::Members::Messaging' This command should not produce any results in Koha source code after this patch. To test: 1. Check the pages touched by this commit 2. Try setting and viewing patron and patron category messaging preferences Finally, run unit tests: 1. prove t/db_dependent/Circulation.t 2. prove t/db_dependent/Reserves.t 3. prove t/db_dependent/Koha/Patron/Categories.t -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon May 29 13:21:26 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 29 May 2017 11:21:26 +0000 Subject: [Koha-bugs] [Bug 18595] Move C4::Members::Messaging to Koha namespace In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18595 --- Comment #16 from Lari Taskula --- (In reply to Lari Taskula from comment #8) > I remember there was some bug related to category messaging > preference view and I'm not sure if that got fixed. Couldn't reproduce issues regarding patron category messaging preferences anymore. Switched status to Needs Signoff, but please see my thoughts in comment #8 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon May 29 13:53:56 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 29 May 2017 11:53:56 +0000 Subject: [Koha-bugs] [Bug 18595] Move C4::Members::Messaging to Koha namespace In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18595 Marc V?ron changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |veron at veron.ch -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon May 29 13:56:55 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 29 May 2017 11:56:55 +0000 Subject: [Koha-bugs] [Bug 17499] Koha objects for messaging preferences In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17499 Marc V?ron changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |veron at veron.ch -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon May 29 14:24:44 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 29 May 2017 12:24:44 +0000 Subject: [Koha-bugs] [Bug 17499] Koha objects for messaging preferences In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17499 --- Comment #17 from Marc V?ron --- Walking through 8 patches, following test plans... 1 OK 1-3 OK 1-4 OK 1-5 OK 1-6 OK 1-7 OK 1-8 OK - Test plan for 8 is the same: prove -v t/db_dependent/Koha/Patron/Message/Preferences.t -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon May 29 14:26:25 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 29 May 2017 12:26:25 +0000 Subject: [Koha-bugs] [Bug 17499] Koha objects for messaging preferences In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17499 Marc V?ron changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #63786|0 |1 is obsolete| | --- Comment #18 from Marc V?ron --- Created attachment 63801 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=63801&action=edit Bug 17499: Add Koha-objects for messaging preferences This patch adds Koha-objects for messaging preferences. This patch does not add any extra logic into these objects. Includes test coverage for basic usage. To test: 1. prove t/db_dependent/Koha/Patron/Message/* Signed-off-by: Marc V?ron -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon May 29 14:27:14 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 29 May 2017 12:27:14 +0000 Subject: [Koha-bugs] [Bug 17499] Koha objects for messaging preferences In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17499 Marc V?ron changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #63787|0 |1 is obsolete| | --- Comment #19 from Marc V?ron --- Created attachment 63802 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=63802&action=edit Bug 17499: Add useful Koha::Exceptions This patch adds some basic Koha::Exceptions that will be useful. Signed-off-by: Marc V?ron -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon May 29 14:28:08 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 29 May 2017 12:28:08 +0000 Subject: [Koha-bugs] [Bug 17499] Koha objects for messaging preferences In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17499 Marc V?ron changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #63788|0 |1 is obsolete| | --- Comment #20 from Marc V?ron --- Created attachment 63803 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=63803&action=edit Bug 17499: Add basic validation for messaging preference This patch adds simple validation for messaging preferences. The validation includes - check that only either borrowernumber or categorycode is given, but not both - throw exception if patron for the given borrowernumber is not found - throw exception if category for the given categorycode is not found - throw exception if days in advance cannot be configured - throw exception if days in advance configuration is invalid (value between 0-30) - throw exception if digest is not available To test: 1. Run t/db_dependent/Koha/Patron/Message/Preferences.t Signed-off-by: Marc V?ron -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon May 29 14:29:10 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 29 May 2017 12:29:10 +0000 Subject: [Koha-bugs] [Bug 17499] Koha objects for messaging preferences In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17499 Marc V?ron changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #63789|0 |1 is obsolete| | --- Comment #21 from Marc V?ron --- Created attachment 63804 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=63804&action=edit Bug 17499: Throw an exception on duplicate messaging preference When trying to add a duplicate messaging preference that has the same borrowernumber or category, and message_attribute_id as another preference, throw Koha::Exceptions::DuplicateObject. To test: 1. Run t/db_dependent/Koha/Patron/Message/Preferences.t Signed-off-by: Marc V?ron -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon May 29 14:30:49 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 29 May 2017 12:30:49 +0000 Subject: [Koha-bugs] [Bug 17499] Koha objects for messaging preferences In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17499 Marc V?ron changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #63790|0 |1 is obsolete| | --- Comment #22 from Marc V?ron --- Created attachment 63805 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=63805&action=edit Bug 17499: Add a method for getting messaging options This patch adds a method for getting available messaging options. To test: 1. Run t/db_dependent/Koha/Patron/Message/Preferences.t Signed-off-by: Marc V?ron -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon May 29 14:31:58 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 29 May 2017 12:31:58 +0000 Subject: [Koha-bugs] [Bug 17499] Koha objects for messaging preferences In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17499 Marc V?ron changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #63791|0 |1 is obsolete| | --- Comment #23 from Marc V?ron --- Created attachment 63806 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=63806&action=edit Bug 17499: Add a method for setting default messaging preferences This patch adds a method Koha::Patron::Message::Preference->new_from_default that can be used to add category's default messaging preferences to patron for a given message type. Example call: Koha::Patron::Message::Preference->new_from_default({ borrowernumber => 123, categorycode => "ABC", message_attribute_id => 1, }); Also adds a simple method for Koha::Patron, set_default_messaging_preferences. Usage: $patron->set_default_messaging_preferences() To test: 1. Run t/db_dependent/Koha/Patron/Message/Preferences.t Signed-off-by: Marc V?ron -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon May 29 14:32:00 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 29 May 2017 12:32:00 +0000 Subject: [Koha-bugs] [Bug 18691] New: When returning from detail page to result list in staff chosen sort order is lost Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18691 Bug ID: 18691 Summary: When returning from detail page to result list in staff chosen sort order is lost Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: normal Priority: P5 - low Component: Searching Assignee: gmcharlt at gmail.com Reporter: katrin.fischer at bsz-bw.de QA Contact: testopia at bugs.koha-community.org To test: - Search for something in staff - Change the sorting of the result list from the default value to something else - Go to a detail page from the result list - Return to the result list using the link above the tabs on the left side - Verify the sort option you chose is no longer selected. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon May 29 14:33:09 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 29 May 2017 12:33:09 +0000 Subject: [Koha-bugs] [Bug 17499] Koha objects for messaging preferences In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17499 Marc V?ron changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #63792|0 |1 is obsolete| | --- Comment #24 from Marc V?ron --- Created attachment 63807 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=63807&action=edit Bug 17499: Improve object usability by enabling direct access to transport preferences Since messaging preference is a feature that has multiple related database tables, usage via Koha-objects is sometimes frustrating. This patch adds a feature for Koha::Patron::Message::Preference which enables access to message transport preferences directly via this object. It allows us to skip calls to Koha::Patron::Message::Transport::Preference(s) because we can now get and set via K::P::M::Preference. Get: $preference->message_transport_types Returns a hashref, where each key is stored transport type and value for the key is letter code for the transport. Set: $preference->set({ message_transport_types => ['sms'] }) or $preference->message_transport_types('email', 'sms') or $preference->message_transport_types(['email', 'sms']) Returns $self (Koha::Patron::Message::Preference object) To test: 1. Run t/db_dependent/Koha/Patron/Message/Preferences.t Signed-off-by: Marc V?ron -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon May 29 14:34:40 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 29 May 2017 12:34:40 +0000 Subject: [Koha-bugs] [Bug 17499] Koha objects for messaging preferences In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17499 Marc V?ron changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #63793|0 |1 is obsolete| | --- Comment #25 from Marc V?ron --- Created attachment 63808 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=63808&action=edit Bug 17499: Simplify searching by message_name This patch adds optional search & find parameter message_name for Koha::Patron::Message::Preferences->search and ->find. This simplifies object usage by allowing us to skip joins or finding the attribute id ourselves. prove -v t/db_dependent/Koha/Patron/Message/Preferences.t turns green Signed-off-by: Marc V?ron -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon May 29 14:34:57 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 29 May 2017 12:34:57 +0000 Subject: [Koha-bugs] [Bug 17499] Koha objects for messaging preferences In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17499 --- Comment #26 from Lari Taskula --- Created attachment 63809 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=63809&action=edit Bug 17499: (follow-up) Bugfix for validation - Bugfix for days_in_advance and wants_digest validation. Have to check definedness of value instead the value itself. - Fixes broken tests caused by above update. - Adding a missing unit test for wants_digest validation - Minor edits to exception messages. - Throwing exception for invalid message_attribute_id. Incl. unit test -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon May 29 14:36:01 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 29 May 2017 12:36:01 +0000 Subject: [Koha-bugs] [Bug 18607] Fix date calculations for monthly frequencies in Serials In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18607 Marcel de Rooy changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|koha-bugs at lists.koha-commun |m.de.rooy at rijksmuseum.nl |ity.org | -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Mon May 29 14:39:51 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 29 May 2017 12:39:51 +0000 Subject: [Koha-bugs] [Bug 17499] Koha objects for messaging preferences In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17499 Marc V?ron changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #63809|0 |1 is obsolete| | --- Comment #27 from Marc V?ron --- Created attachment 63810 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=63810&action=edit Bug 17499: (follow-up) Bugfix for validation - Bugfix for days_in_advance and wants_digest validation. Have to check definedness of value instead the value itself. - Fixes broken tests caused by above update. - Adding a missing unit test for wants_digest validation - Minor edits to exception messages. - Throwing exception for invalid message_attribute_id. Incl. unit test Unit test turns green. Signed-off-by: Marc V?ron -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon May 29 14:40:24 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 29 May 2017 12:40:24 +0000 Subject: [Koha-bugs] [Bug 17499] Koha objects for messaging preferences In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17499 Lari Taskula changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #63810|0 |1 is obsolete| | --- Comment #28 from Lari Taskula --- Created attachment 63811 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=63811&action=edit Bug 17499: (follow-up) Bugfix for validation - Bugfix for days_in_advance and wants_digest validation. Have to check definedness of value instead the value itself. - Fixes broken tests caused by above update. - Adding a missing unit test for wants_digest validation - Minor edits to exception messages. - Throwing exception for invalid message_attribute_id. Incl. unit test -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon May 29 15:03:28 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 29 May 2017 13:03:28 +0000 Subject: [Koha-bugs] [Bug 17499] Koha objects for messaging preferences In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17499 Marc V?ron changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #63811|0 |1 is obsolete| | --- Comment #29 from Marc V?ron --- Created attachment 63812 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=63812&action=edit Bug 17499: (follow-up) Bugfix for validation - Bugfix for days_in_advance and wants_digest validation. Have to check definedness of value instead the value itself. - Fixes broken tests caused by above update. - Adding a missing unit test for wants_digest validation - Minor edits to exception messages. - Throwing exception for invalid message_attribute_id. Incl. unit test Tested again, prove -v t/db_dependent/Koha/Patron/Message/Preferences.t turns green prove -v t/db_dependent/Koha/Patron/Message/* turns green Signed-off-by: Marc V?ron -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon May 29 15:05:40 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 29 May 2017 13:05:40 +0000 Subject: [Koha-bugs] [Bug 17499] Koha objects for messaging preferences In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17499 Marc V?ron changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off --- Comment #30 from Marc V?ron --- Tested - editing messaging preferences in staff client and opac - check out an item to have an email sent All OK. Signing off. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon May 29 15:21:01 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 29 May 2017 13:21:01 +0000 Subject: [Koha-bugs] [Bug 17499] Koha objects for messaging preferences In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17499 --- Comment #31 from Lari Taskula --- (In reply to Marc V?ron from comment #30) > Tested > - editing messaging preferences in staff client and opac > - check out an item to have an email sent > All OK. > > Signing off. Please note that the actual move from C4::Members::Messaging to these Koha-objects is in Bug 18595. This Bug just introduces new Koha-objects for messaging preferences. This Bug doesn't yet use them in action. I did it like this because personally I am just interested in deprecating the C4::Members::Messaging methods and instead having the Koha-objects to use with REST API. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon May 29 15:52:54 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 29 May 2017 13:52:54 +0000 Subject: [Koha-bugs] [Bug 18595] Move C4::Members::Messaging to Koha namespace In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18595 --- Comment #17 from Marc V?ron --- (In reply to Lari Taskula from comment #4) > Created attachment 63438 [details] [review] > Bug 18595: Unit tests preparing for GetMessagingPreferences move > > This patch prepares removing GetMessagingPreferences by adding some useful > unit > tests for subroutines that the move targets. > > Reserves.t already covers print notice, but this patch adds tests for a set > transport type. > > To test: > 1. Run t/db_dependent/Circulation.t > 2. Run t/db_dependent/Reserves.t > 3. Observe test pass prove -v t/db_dependent/Circulation.t does not pass I get: # Subtest: SendCirculationAlert test 1..4 # No tests run! not ok 96 - No tests run for subtest "SendCirculationAlert test" t/db_dependent/Reserves.t returns green -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon May 29 16:08:32 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 29 May 2017 14:08:32 +0000 Subject: [Koha-bugs] [Bug 18595] Move C4::Members::Messaging to Koha namespace In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18595 --- Comment #18 from Lari Taskula --- Created attachment 63813 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=63813&action=edit Bug 18595: (follow-up) Fix failing test in Circulation.t To test: 1. prove t/db_dependent/Circulation.t -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon May 29 16:14:45 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 29 May 2017 14:14:45 +0000 Subject: [Koha-bugs] [Bug 10746] Improving PDF printing of baskets - Omnibus In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10746 Mike changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |black23 at gmail.com -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon May 29 16:14:27 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 29 May 2017 14:14:27 +0000 Subject: [Koha-bugs] [Bug 10787] Linked Data/RDF Omnibus In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10787 Mike changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |black23 at gmail.com -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon May 29 16:15:46 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 29 May 2017 14:15:46 +0000 Subject: [Koha-bugs] [Bug 18595] Move C4::Members::Messaging to Koha namespace In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18595 --- Comment #19 from Marc V?ron --- (In reply to Lari Taskula from comment #18) > Created attachment 63813 [details] [review] > Bug 18595: (follow-up) Fix failing test in Circulation.t > > To test: > 1. prove t/db_dependent/Circulation.t Test passes now... -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon May 29 16:26:55 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 29 May 2017 14:26:55 +0000 Subject: [Koha-bugs] [Bug 18692] New: When SMS is enabled the OPAC messaging table is misaligned Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18692 Bug ID: 18692 Summary: When SMS is enabled the OPAC messaging table is misaligned Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: minor Priority: P5 - low Component: OPAC Assignee: oleonard at myacpl.org Reporter: fridolin.somers at biblibre.com QA Contact: testopia at bugs.koha-community.org Bug 6726 had corrected the fact that when SMS is enabled the messaging table is missing a column. Bug 6458 has broken this. I think the SMS column is missing an else case with cell containing only "-" like other columns. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon May 29 16:27:19 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 29 May 2017 14:27:19 +0000 Subject: [Koha-bugs] [Bug 18692] When SMS is enabled the OPAC messaging table is misaligned In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18692 Fridolin SOMERS changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|oleonard at myacpl.org |fridolin.somers at biblibre.co | |m -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon May 29 16:29:07 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 29 May 2017 14:29:07 +0000 Subject: [Koha-bugs] [Bug 18692] When SMS is enabled the OPAC messaging table is misaligned In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18692 Fridolin SOMERS changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on| |6458 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6458 [Bug 6458] incorrect parsing result in translation processing -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon May 29 16:29:07 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 29 May 2017 14:29:07 +0000 Subject: [Koha-bugs] [Bug 6458] incorrect parsing result in translation processing In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6458 Fridolin SOMERS changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |18692 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18692 [Bug 18692] When SMS is enabled the OPAC messaging table is misaligned -- You are receiving this mail because: You are watching all bug changes. You are the QA Contact for the bug. From bugzilla-daemon at bugs.koha-community.org Mon May 29 16:29:25 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 29 May 2017 14:29:25 +0000 Subject: [Koha-bugs] [Bug 18692] When SMS is enabled the OPAC messaging table is misaligned In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18692 Fridolin SOMERS changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on| |6726 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6726 [Bug 6726] When SMS is enabled the messaging table is misaligned -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon May 29 16:29:25 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 29 May 2017 14:29:25 +0000 Subject: [Koha-bugs] [Bug 6726] When SMS is enabled the messaging table is misaligned In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6726 Fridolin SOMERS changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |18692 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18692 [Bug 18692] When SMS is enabled the OPAC messaging table is misaligned -- You are receiving this mail because: You are watching all bug changes. You are the QA Contact for the bug. From bugzilla-daemon at bugs.koha-community.org Mon May 29 16:36:26 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 29 May 2017 14:36:26 +0000 Subject: [Koha-bugs] [Bug 18595] Move C4::Members::Messaging to Koha namespace In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18595 --- Comment #20 from Marc V?ron --- Went through all patches / test plans, no issues detected after the followup-fix Will sign off -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon May 29 16:38:57 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 29 May 2017 14:38:57 +0000 Subject: [Koha-bugs] [Bug 18692] When SMS is enabled the OPAC messaging table is misaligned In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18692 --- Comment #1 from Fridolin SOMERS --- Created attachment 63814 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=63814&action=edit Bug 18692 - When SMS is enabled the OPAC messaging table is misaligned Bug 6726 had corrected the fact that when SMS is enabled the messaging table is missing a column. Bug 6458 has broken this. The SMS column is missing an else case with cell containing only "-" like other columns. Test plan : - set SMSSendDriver preference empty - go to OPAC patron messaging - column SMS should not be visible - set SMSSendDriver preference not empty - go to OPAC patron messaging - column SMS appears with checkboxes -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon May 29 16:39:33 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 29 May 2017 14:39:33 +0000 Subject: [Koha-bugs] [Bug 18692] When SMS is enabled the OPAC messaging table is misaligned In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18692 Fridolin SOMERS changed: What |Removed |Added ---------------------------------------------------------------------------- Patch complexity|--- |Trivial patch -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon May 29 16:39:24 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 29 May 2017 14:39:24 +0000 Subject: [Koha-bugs] [Bug 18692] When SMS is enabled the OPAC messaging table is misaligned In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18692 Fridolin SOMERS changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon May 29 16:41:08 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 29 May 2017 14:41:08 +0000 Subject: [Koha-bugs] [Bug 18692] When SMS is enabled the OPAC messaging table is misaligned In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18692 Fridolin SOMERS changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |https://bugs.koha-community | |.org/bugzilla3/show_bug.cgi | |?id=11125 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon May 29 16:41:08 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 29 May 2017 14:41:08 +0000 Subject: [Koha-bugs] [Bug 11125] Remove Problematic Logic from Patron Messaging Preferences Form In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11125 Fridolin SOMERS changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |https://bugs.koha-community | |.org/bugzilla3/show_bug.cgi | |?id=18692 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon May 29 16:51:54 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 29 May 2017 14:51:54 +0000 Subject: [Koha-bugs] [Bug 18595] Move C4::Members::Messaging to Koha namespace In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18595 Marc V?ron changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #63794|0 |1 is obsolete| | --- Comment #21 from Marc V?ron --- Created attachment 63815 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=63815&action=edit Bug 18595: Unit tests for Koha::Patron::Categories->default_messaging This patch adds unit tests for Koha::Patron::Categories->default_messaging. Tests will help preparing for moving C4::Members::Messaging to Koha-objects. To test: 1. Run t/db_dependent/Koha/Patron/Categories.t Signed-off-by: Marc V?ron -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon May 29 16:53:12 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 29 May 2017 14:53:12 +0000 Subject: [Koha-bugs] [Bug 18595] Move C4::Members::Messaging to Koha namespace In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18595 Marc V?ron changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #63795|0 |1 is obsolete| | --- Comment #22 from Marc V?ron --- Created attachment 63816 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=63816&action=edit Bug 18595: Move C4::Members::Messaging::GetMessagingOptions This patch moves C4::Members::GetMessagingOptions to Koha::Patron::Message::Preferences->get_options. The patch makes a heavy touch on core messaging preference features, but should not introduce any visible changes for end user. Keep this in mind if testing. If you notice any changes in Koha, something is probably wrong! This patch also removes previously unused GetMessagingOptions in opac-messaging.pl To test: Make sure you have enabled the following system preferences: - opacuserlogin - EnhancedMessagingPreferences - EnhancedMessagingPreferencesOPAC ---- GENERAL ---- 1. Apply patch 2. Search Koha source code for references of "GetMessagingOptions" (grep -r 'GetMessagingOptions'). 3. Observe no results in source code. ---- OPAC ---- 1. Login to OPAC. 2. Go to "your messaging" (cgi-bin/koha/opac-messaging.pl). 3. Observe the preferences looking normal and as they should be. 4. Set any combination of messaging preferences. 5. Observe them apply as expected, repeat step 4-5 as much as you like. ---- INTRANET ---- 1. Login to intranet. 2. Go to edit patron's details and scroll down to their messaging preferences. 3. Observe the preferences looking normal and as they should be. 4. Set any combination of messaging preferences. 5. Observe them apply as expected, repeat step 4-5 as much as you like. 6. Go to Administration -> Patron categories -> Edit (for any category) 7. Scroll down to observe default messaging preferences for this patron category 8. Observe the preferences looking normal and as they should be. 9. Set any combination of messaging preferences. 10. Observe them apply as expected, repeat step 9-10 as much as you like. 11. Go to cgi-bin/koha/members/memberentry.pl?op=add&categorycode=XXX, replace XXX with the categorycode you were just editing. 12. Fill in required data, do not modify messaging preferences, click Save. 13. Observe a new patron with default messaging preferences. Signed-off-by: Marc V?ron -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon May 29 16:54:21 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 29 May 2017 14:54:21 +0000 Subject: [Koha-bugs] [Bug 18595] Move C4::Members::Messaging to Koha namespace In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18595 Marc V?ron changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #63796|0 |1 is obsolete| | --- Comment #23 from Marc V?ron --- Created attachment 63817 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=63817&action=edit Bug 18595: Move C4::Members::Messaging::SetMessagingPreferencesFromDefaults This patch moves C4::Members::SetMessagingPreferencesFromDefaults to Koha::Patron->set_default_messaging_preferences The patch makes a heavy touch on core messaging preference features, but should not introduce any visible changes for end user. Keep this in mind if testing. If you notice any changes in Koha, something is probably wrong! To test: Make sure you have enabled the following system preferences: - EnhancedMessagingPreferences ---- GENERAL ---- 1. Apply patch 2. Search Koha source code for references of "SetMessagingPreferencesFromDefaults" (grep -r 'SetMessagingPreferencesFromDefaults'). 3. Observe no results in source code. ---- INTRANET ---- 1. Login to intranet. 2. Go to Administration -> Patron categories -> Edit (for any category) 3. Scroll down to observe default messaging preferences for this patron category 4. Observe the preferences, remember them for the next step. 5. Go to cgi-bin/koha/members/memberentry.pl?op=add&categorycode=XXX, replace XXX with the categorycode you were just editing. 6. Look at messaging preferences. They should be same as in step 4. 7. Fill in required data, do not modify messaging preferences, click Save. 8. Observe a new patron with default messaging preferences. Signed-off-by: Marc V?ron -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon May 29 16:55:40 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 29 May 2017 14:55:40 +0000 Subject: [Koha-bugs] [Bug 18595] Move C4::Members::Messaging to Koha namespace In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18595 Marc V?ron changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #63797|0 |1 is obsolete| | --- Comment #24 from Marc V?ron --- Created attachment 63818 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=63818&action=edit Bug 18595: Unit tests preparing for GetMessagingPreferences move This patch prepares removing GetMessagingPreferences by adding some useful unit tests for subroutines that the move targets. Reserves.t already covers print notice, but this patch adds tests for a set transport type. To test: 1. Run t/db_dependent/Circulation.t 2. Run t/db_dependent/Reserves.t 3. Observe test pass Works together with followup patch Signed-off-by: Marc V?ron -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon May 29 16:57:12 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 29 May 2017 14:57:12 +0000 Subject: [Koha-bugs] [Bug 18595] Move C4::Members::Messaging to Koha namespace In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18595 Marc V?ron changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #63798|0 |1 is obsolete| | --- Comment #25 from Marc V?ron --- Created attachment 63819 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=63819&action=edit Bug 18595: Move C4::Members::Messaging::GetMessagingPreferences This patch moves C4::Members::Messaging::GetMessagingPreferences to Koha::Patron::Message::Preference(s) The patch makes a heavy touch on core messaging preference features, but should not introduce any visible changes for end user. Keep this in mind if testing. If you notice any changes in Koha, something is probably wrong! To test: Make sure you have enabled the following system preferences: - EnhancedMessagingPreferences ---- GENERAL ---- 1. Apply patch 2. Search Koha source code for references of "GetMessagingPreferences" (grep -r 'GetMessagingPreferences'). 3. Observe no results in source code. ---- INTRANET ---- 1. todo ---- UNIT TESTS ---- 1. prove t/db_dependent/Circulation.t 2. prove t/db_dependent/Reserves.t 3. prove t/db_dependent/Koha/Patron/Categories.t Signed-off-by: Marc V?ron -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon May 29 17:00:47 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 29 May 2017 15:00:47 +0000 Subject: [Koha-bugs] [Bug 18595] Move C4::Members::Messaging to Koha namespace In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18595 Marc V?ron changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #63799|0 |1 is obsolete| | --- Comment #26 from Marc V?ron --- Created attachment 63820 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=63820&action=edit Bug 18595: Move C4::Members::Messaging::SetMessagingPreference This patch moves C4::Members::Messaging::SetMessagingPreference to Koha::Patron::Message::Preference The patch makes a heavy touch on core messaging preference features, but should not introduce any visible changes for end user. Keep this in mind if testing. If you notice any changes in Koha, something is probably wrong! To test: Make sure you have enabled the following system preferences: - EnhancedMessagingPreferences ---- GENERAL ---- 1. Apply patch 2. Search Koha source code for references of "SetMessagingPreference" (grep -r 'SetMessagingPreference'). 3. Observe no results in source code. ---- INTRANET ---- 1. todo ---- UNIT TESTS ---- 1. prove t/db_dependent/Circulation.t 2. prove t/db_dependent/Reserves.t 3. prove t/db_dependent/Koha/Patron/Categories.t Works as expected. QA tools fails with: FAIL C4/Members/Messaging.pm pod empty section in previous paragraph Can be fixed in a followup. Signed-off-by: Marc V?ron -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon May 29 17:02:46 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 29 May 2017 15:02:46 +0000 Subject: [Koha-bugs] [Bug 18595] Move C4::Members::Messaging to Koha namespace In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18595 Marc V?ron changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #63800|0 |1 is obsolete| | --- Comment #27 from Marc V?ron --- Created attachment 63821 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=63821&action=edit Bug 18595: Remove references to C4::Members::Messaging $ grep -r 'C4::Members::Messaging' This command should not produce any results in Koha source code after this patch. To test: 1. Check the pages touched by this commit 2. Try setting and viewing patron and patron category messaging preferences Finally, run unit tests: 1. prove t/db_dependent/Circulation.t 2. prove t/db_dependent/Reserves.t 3. prove t/db_dependent/Koha/Patron/Categories.t Signed-off-by: Marc V?ron -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon May 29 17:03:45 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 29 May 2017 15:03:45 +0000 Subject: [Koha-bugs] [Bug 18595] Move C4::Members::Messaging to Koha namespace In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18595 Marc V?ron changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #63813|0 |1 is obsolete| | --- Comment #28 from Marc V?ron --- Created attachment 63822 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=63822&action=edit Bug 18595: (follow-up) Fix failing test in Circulation.t To test: 1. prove t/db_dependent/Circulation.t Signed-off-by: Marc V?ron -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon May 29 17:21:08 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 29 May 2017 15:21:08 +0000 Subject: [Koha-bugs] [Bug 18595] Move C4::Members::Messaging to Koha namespace In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18595 Lari Taskula changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #63821|0 |1 is obsolete| | --- Comment #30 from Lari Taskula --- Created attachment 63824 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=63824&action=edit Bug 18595: Remove references to C4::Members::Messaging $ grep -r 'C4::Members::Messaging' This command should not produce any results in Koha source code after this patch. To test: 1. Check the pages touched by this commit 2. Try setting and viewing patron and patron category messaging preferences Finally, run unit tests: 1. prove t/db_dependent/Circulation.t 2. prove t/db_dependent/Reserves.t 3. prove t/db_dependent/Koha/Patron/Categories.t Signed-off-by: Marc V?ron -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon May 29 17:20:53 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 29 May 2017 15:20:53 +0000 Subject: [Koha-bugs] [Bug 18595] Move C4::Members::Messaging to Koha namespace In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18595 Lari Taskula changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #63820|0 |1 is obsolete| | --- Comment #29 from Lari Taskula --- Created attachment 63823 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=63823&action=edit Bug 18595: Move C4::Members::Messaging::SetMessagingPreference This patch moves C4::Members::Messaging::SetMessagingPreference to Koha::Patron::Message::Preference The patch makes a heavy touch on core messaging preference features, but should not introduce any visible changes for end user. Keep this in mind if testing. If you notice any changes in Koha, something is probably wrong! To test: Make sure you have enabled the following system preferences: - EnhancedMessagingPreferences ---- GENERAL ---- 1. Apply patch 2. Search Koha source code for references of "SetMessagingPreference" (grep -r 'SetMessagingPreference'). 3. Observe no results in source code. ---- INTRANET ---- 1. todo ---- UNIT TESTS ---- 1. prove t/db_dependent/Circulation.t 2. prove t/db_dependent/Reserves.t 3. prove t/db_dependent/Koha/Patron/Categories.t Works as expected. QA tools fails with: FAIL C4/Members/Messaging.pm pod empty section in previous paragraph Can be fixed in a followup. Signed-off-by: Marc V?ron -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon May 29 17:21:19 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 29 May 2017 15:21:19 +0000 Subject: [Koha-bugs] [Bug 18595] Move C4::Members::Messaging to Koha namespace In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18595 Lari Taskula changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #63822|0 |1 is obsolete| | --- Comment #31 from Lari Taskula --- Created attachment 63825 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=63825&action=edit Bug 18595: (follow-up) Fix failing test in Circulation.t To test: 1. prove t/db_dependent/Circulation.t Signed-off-by: Marc V?ron -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon May 29 17:28:53 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 29 May 2017 15:28:53 +0000 Subject: [Koha-bugs] [Bug 18595] Move C4::Members::Messaging to Koha namespace In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18595 Marc V?ron changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #63823|0 |1 is obsolete| | --- Comment #32 from Marc V?ron --- Created attachment 63826 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=63826&action=edit Bug 18595: Move C4::Members::Messaging::SetMessagingPreference This patch moves C4::Members::Messaging::SetMessagingPreference to Koha::Patron::Message::Preference The patch makes a heavy touch on core messaging preference features, but should not introduce any visible changes for end user. Keep this in mind if testing. If you notice any changes in Koha, something is probably wrong! To test: Make sure you have enabled the following system preferences: - EnhancedMessagingPreferences ---- GENERAL ---- 1. Apply patch 2. Search Koha source code for references of "SetMessagingPreference" (grep -r 'SetMessagingPreference'). 3. Observe no results in source code. ---- INTRANET ---- 1. todo ---- UNIT TESTS ---- 1. prove t/db_dependent/Circulation.t 2. prove t/db_dependent/Reserves.t 3. prove t/db_dependent/Koha/Patron/Categories.t Works as expected. QA tools fails with: FAIL C4/Members/Messaging.pm pod empty section in previous paragraph Can be fixed in a followup. Signed-off-by: Marc V?ron QA tools pass now OK Signed-off-by: Marc V?ron -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon May 29 17:40:01 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 29 May 2017 15:40:01 +0000 Subject: [Koha-bugs] [Bug 18595] Move C4::Members::Messaging to Koha namespace In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18595 Marc V?ron changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #63826|0 |1 is obsolete| | --- Comment #33 from Marc V?ron --- Created attachment 63827 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=63827&action=edit Bug 18595: Move C4::Members::Messaging::SetMessagingPreference This patch moves C4::Members::Messaging::SetMessagingPreference to Koha::Patron::Message::Preference The patch makes a heavy touch on core messaging preference features, but should not introduce any visible changes for end user. Keep this in mind if testing. If you notice any changes in Koha, something is probably wrong! To test: Make sure you have enabled the following system preferences: - EnhancedMessagingPreferences ---- GENERAL ---- 1. Apply patch 2. Search Koha source code for references of "SetMessagingPreference" (grep -r 'SetMessagingPreference'). 3. Observe no results in source code. ---- INTRANET ---- 1. todo ---- UNIT TESTS ---- 1. prove t/db_dependent/Circulation.t 2. prove t/db_dependent/Reserves.t 3. prove t/db_dependent/Koha/Patron/Categories.t Works as expected. QA tools fails with: FAIL C4/Members/Messaging.pm pod empty section in previous paragraph Can be fixed in a followup. Signed-off-by: Marc V?ron QA tools pass now OK Signed-off-by: Marc V?ron -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon May 29 17:41:19 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 29 May 2017 15:41:19 +0000 Subject: [Koha-bugs] [Bug 18595] Move C4::Members::Messaging to Koha namespace In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18595 Marc V?ron changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #63824|0 |1 is obsolete| | --- Comment #34 from Marc V?ron --- Created attachment 63828 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=63828&action=edit Bug 18595: Remove references to C4::Members::Messaging $ grep -r 'C4::Members::Messaging' This command should not produce any results in Koha source code after this patch. To test: 1. Check the pages touched by this commit 2. Try setting and viewing patron and patron category messaging preferences Finally, run unit tests: 1. prove t/db_dependent/Circulation.t 2. prove t/db_dependent/Reserves.t 3. prove t/db_dependent/Koha/Patron/Categories.t Signed-off-by: Marc V?ron -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon May 29 17:42:14 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 29 May 2017 15:42:14 +0000 Subject: [Koha-bugs] [Bug 18595] Move C4::Members::Messaging to Koha namespace In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18595 Marc V?ron changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #63825|0 |1 is obsolete| | --- Comment #35 from Marc V?ron --- Created attachment 63829 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=63829&action=edit Bug 18595: (follow-up) Fix failing test in Circulation.t To test: 1. prove t/db_dependent/Circulation.t Signed-off-by: Marc V?ron -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon May 29 17:43:07 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 29 May 2017 15:43:07 +0000 Subject: [Koha-bugs] [Bug 18595] Move C4::Members::Messaging to Koha namespace In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18595 Marc V?ron changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off Patch complexity|--- |Medium patch -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon May 29 18:05:58 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 29 May 2017 16:05:58 +0000 Subject: [Koha-bugs] [Bug 18689] adding a holiday in holidays.pl with double-quotes in title or description breaks calendar. In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18689 Barton Chittenden changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |nick at bywatersolutions.com --- Comment #2 from Barton Chittenden --- *** Bug 15271 has been marked as a duplicate of this bug. *** -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon May 29 18:05:58 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 29 May 2017 16:05:58 +0000 Subject: [Koha-bugs] [Bug 15271] Calendar breaks on double quotes in title or description of holiday In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15271 Barton Chittenden changed: What |Removed |Added ---------------------------------------------------------------------------- Resolution|--- |DUPLICATE CC| |barton at bywatersolutions.com Status|NEW |RESOLVED --- Comment #2 from Barton Chittenden --- Closing as a duplicate of 18689 (which is newer, but Marc V?ron helpfully added a number of "See Also" links to that one). *** This bug has been marked as a duplicate of bug 18689 *** -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon May 29 18:11:21 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 29 May 2017 16:11:21 +0000 Subject: [Koha-bugs] [Bug 18692] When SMS is enabled the OPAC messaging table is misaligned In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18692 Marc V?ron changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |veron at veron.ch --- Comment #2 from Marc V?ron --- Created attachment 63830 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=63830&action=edit Email notifications can no longer be edited with patch Patch is applied, syspref SMSSendDriver is empty. Result: In column email we have a minus sign (-) instead of check boxes as without patch. See screenshot. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon May 29 19:47:52 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 29 May 2017 17:47:52 +0000 Subject: [Koha-bugs] [Bug 9433] Translatability: Too many comments in system preferences po file In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9433 Marc V?ron changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |veron at veron.ch Summary|Too many comments in system |Translatability: Too many |preferences po file |comments in system | |preferences po file -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Mon May 29 19:48:36 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 29 May 2017 17:48:36 +0000 Subject: [Koha-bugs] [Bug 9433] Translatability: Too many comments in system preferences po file In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9433 --- Comment #1 from Marc V?ron --- Verified on current master. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Mon May 29 19:55:05 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 29 May 2017 17:55:05 +0000 Subject: [Koha-bugs] [Bug 17717] process_message_queue.pl: Can't locate Authen/CAS/Client/ Response/Failure.pm In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17717 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|gmcharlt at gmail.com |chris at bigballofwax.co.nz --- Comment #22 from Jonathan Druart --- (In reply to Julian Maurice from comment #21) > This bug really confuses me. Same here :) Chris do you have the answers? -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon May 29 19:56:18 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 29 May 2017 17:56:18 +0000 Subject: [Koha-bugs] [Bug 9433] Translatability: Too many comments in system preferences po file In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9433 --- Comment #2 from Marc V?ron --- Created attachment 63831 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=63831&action=edit Bug 9433 - Translatability: Too many comments in system preferences po file This patch adds quotes to strings in web_services.pref to avoid lots of comments in preferences po file. To verify: See initial comment. (A lot of lines 'Web services > reporting and other similar lines) To test: - Apply patch - go to misc/translator, then perl translate create aa-AA for an 'language' aa-AA - Verify in po/aa-AA-pref.po that the issue from initial comment is gone -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Mon May 29 19:56:47 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 29 May 2017 17:56:47 +0000 Subject: [Koha-bugs] [Bug 9433] Translatability: Too many comments in system preferences po file In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9433 Marc V?ron changed: What |Removed |Added ---------------------------------------------------------------------------- Patch complexity|--- |String patch Status|NEW |Needs Signoff Assignee|koha-bugs at lists.koha-commun |veron at veron.ch |ity.org | -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Mon May 29 19:57:40 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 29 May 2017 17:57:40 +0000 Subject: [Koha-bugs] [Bug 8526] limit comments to specific patron category In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8526 Marc V?ron changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |veron at veron.ch -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon May 29 19:59:40 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 29 May 2017 17:59:40 +0000 Subject: [Koha-bugs] [Bug 18690] Typos in Koha database description (Table "borrowers") In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18690 Marc V?ron changed: What |Removed |Added ---------------------------------------------------------------------------- Component|Installation and upgrade |Database |(command-line installer) | Version|16.11 |master --- Comment #1 from Marc V?ron --- Verified for current master. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon May 29 20:02:21 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 29 May 2017 18:02:21 +0000 Subject: [Koha-bugs] [Bug 18179] Koha::Objects->find should not be called in list context In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18179 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #63108|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon May 29 20:02:50 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 29 May 2017 18:02:50 +0000 Subject: [Koha-bugs] [Bug 18179] Koha::Objects->find should not be called in list context In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18179 --- Comment #35 from Jonathan Druart --- (In reply to Jonathan Druart from comment #31) > Created attachment 63108 [details] [review] > Bug 18179: Update 1 occurrence in moremember.pl This patch is not longer needed, see bug 18647. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon May 29 20:08:32 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 29 May 2017 18:08:32 +0000 Subject: [Koha-bugs] [Bug 18179] Koha::Objects->find should not be called in list context In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18179 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #63109|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon May 29 20:08:51 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 29 May 2017 18:08:51 +0000 Subject: [Koha-bugs] [Bug 18179] Koha::Objects->find should not be called in list context In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18179 --- Comment #36 from Jonathan Druart --- (In reply to Jonathan Druart from comment #32) > Created attachment 63109 [details] [review] > Bug 18179: Use borrower.category_type in patron-title.inc Same as previous comment -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon May 29 20:10:04 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 29 May 2017 18:10:04 +0000 Subject: [Koha-bugs] [Bug 18179] Koha::Objects->find should not be called in list context In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18179 --- Comment #37 from Jonathan Druart --- Created attachment 63832 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=63832&action=edit [16.11.x] Bug 18179: Update existing calls This patch updates the existing occurrences of ->find called in a list context. There are certainly others that are not easy to catch with git grep. Test plan: Confirm that the 4 modified scripts still works as expected. We need this one ASAP in master to make sure we will not get other side-effects of this kind and to catch possible uncaught occurrences before the release. Tested scripts changed by this patch, they work as expected. Signed-off-by: Marc V?ron Signed-off-by: Nick Clemens Signed-off-by: Jonathan Druart -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon May 29 20:10:30 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 29 May 2017 18:10:30 +0000 Subject: [Koha-bugs] [Bug 18179] Koha::Objects->find should not be called in list context In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18179 --- Comment #38 from Jonathan Druart --- Only the first patch is needed for 16.11.x -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon May 29 20:16:20 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 29 May 2017 18:16:20 +0000 Subject: [Koha-bugs] [Bug 18690] Typos in Koha database description (Table "borrowers") In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18690 --- Comment #2 from Marc V?ron --- Created attachment 63833 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=63833&action=edit Bug 18690 - Typos in Koha database description (Table "borrowers") This string patch fixes typos in kohastructure.sql as described in initial comment. To test: - Carefully verify that string changes make sense -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon May 29 20:16:44 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 29 May 2017 18:16:44 +0000 Subject: [Koha-bugs] [Bug 18690] Typos in Koha database description (Table "borrowers") In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18690 Marc V?ron changed: What |Removed |Added ---------------------------------------------------------------------------- Patch complexity|--- |String patch Assignee|gmcharlt at gmail.com |veron at veron.ch Status|NEW |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon May 29 21:08:48 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 29 May 2017 19:08:48 +0000 Subject: [Koha-bugs] [Bug 17717] process_message_queue.pl: Can't locate Authen/CAS/Client/ Response/Failure.pm In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17717 --- Comment #23 from Chris Cormack --- Ok The original report of the error describes the problem, so I don't think i need to go proving it exists? I'll do a summary anyway. With perl 5.22 with latest ubuntu, debian testing and above, etc have. Something has changed in the way it deals with modules that have multiple packages in them. This is not unique to this module, if you search for Permission denied at /usr/share/perl/5.22/base.pm line 97 You will see others doing it too EG I've noticed that Object::InsideOut v3.98 fails when the current directory is not readable by the user running the Perl binary. Most Perl modules don't have this requirement, and so OIO creates a very cryptic error message when you run it in such circumstances. However Authen::CAS::Client is a module we use, that is loaded by one of the modules that process_message_queue.pl uses. By adding cd /tmp && to the cron we make sure we avoid the not readable part. Of course running as root gets round this too. This is not a fix, like I said, but a simple workaround so that notices get sent in Koha on perl 5.22. Until this module is replaced (which it is going to be) or another solution involving changing how koha-for-each works under cron (it works fine on the command line) is done. This does only occur on perl 5.22 and up, so something changed in that. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon May 29 22:15:39 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 29 May 2017 20:15:39 +0000 Subject: [Koha-bugs] [Bug 18690] Typos in Koha database description (Table "borrowers") In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18690 Michael Kuhn changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon May 29 22:16:49 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 29 May 2017 20:16:49 +0000 Subject: [Koha-bugs] [Bug 18690] Typos in Koha database description (Table "borrowers") In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18690 --- Comment #3 from Michael Kuhn --- Strings are now correct as expected. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon May 29 22:25:29 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 29 May 2017 20:25:29 +0000 Subject: [Koha-bugs] [Bug 18690] Typos in Koha database description (Table "borrowers") In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18690 Marc V?ron changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Needs Signoff --- Comment #4 from Marc V?ron --- Thanks, Michael, for testing and confirming that changes are OK. But sorry, to set a bug to Signed Off you have to apply the patch on your development environment, then sign off on the patch (that adds your sign off to the patch), and then attach the patch again. See https://wiki.koha-community.org/wiki/Sign_off_on_patches I use the git bz workflow mentioned there, see: https://wiki.koha-community.org/wiki/Git_bz_configuration Setting back to NSO -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue May 30 07:11:08 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 30 May 2017 05:11:08 +0000 Subject: [Koha-bugs] [Bug 18693] New: Translatability: Get rid of exposing a [ %% FOREACH loop in translation for branch-selector.inc Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18693 Bug ID: 18693 Summary: Translatability: Get rid of exposing a [%% FOREACH loop in translation for branch-selector.inc Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: trivial Priority: P5 - low Component: I18N/L10N Assignee: koha-bugs at lists.koha-community.org Reporter: veron at veron.ch QA Contact: testopia at bugs.koha-community.org CC: frederic at tamil.fr The file branch-selector.inc exposes the following line to translation (due to newlines insied a tt directive): %s %s [%% FOREACH branch IN branches; IF branch.selected; selectall = 0; END; END %%] -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Tue May 30 07:28:15 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 30 May 2017 05:28:15 +0000 Subject: [Koha-bugs] [Bug 18693] Translatability: Get rid of exposing a [ %% FOREACH loop in translation for branch-selector.inc In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18693 --- Comment #1 from Marc V?ron --- Additionally, export.tt exposes the following line to translation: [%% INCLUDE 'branch-selector.inc' branches = libraries %%] -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue May 30 07:32:03 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 30 May 2017 05:32:03 +0000 Subject: [Koha-bugs] [Bug 18693] Translatability: Get rid of exposing a [ %% FOREACH loop in translation for branch-selector.inc In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18693 --- Comment #2 from Marc V?ron --- Created attachment 63834 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=63834&action=edit Bug 18693: Translatability: Get rid of exposing a [%% FOREACH loop in translation for branch-selector.inc The file branch-selector.inc exposes the following line to translation (due to newlines insied a tt directive): %s %s [%% FOREACH branch IN branches; IF branch.selected; selectall = 0; END; END %%] Additionally, export.tt exposes the following line to translation: [%% INCLUDE 'branch-selector.inc' branches = libraries %%] To test: - Apply patch - In Staff client, go to Home > Tools > Export data - Verify that library selection behaves as before - Bonus test: Create a "language" aa-AA (perl translate create aa-AA from folder misc/translator, verify that lines mentioned above do no longer appear in aa-AA-staff-prog.po - Run QA tools (newest version with test for newlines in tt directives) -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue May 30 07:32:30 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 30 May 2017 05:32:30 +0000 Subject: [Koha-bugs] [Bug 18693] Translatability: Get rid of exposing a [ %% FOREACH loop in translation for branch-selector.inc In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18693 Marc V?ron changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue May 30 08:41:02 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 30 May 2017 06:41:02 +0000 Subject: [Koha-bugs] [Bug 18694] Translatability: Get rid of exposing [%% FOREACH in csv/ cash_register_stats.tt In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18694 Marc V?ron changed: What |Removed |Added ---------------------------------------------------------------------------- Severity|enhancement |trivial -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue May 30 08:40:47 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 30 May 2017 06:40:47 +0000 Subject: [Koha-bugs] [Bug 18694] New: Translatability: Get rid of exposing [%% FOREACH in csv/ cash_register_stats.tt Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18694 Bug ID: 18694 Summary: Translatability: Get rid of exposing [%% FOREACH in csv/cash_register_stats.tt Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: I18N/L10N Assignee: koha-bugs at lists.koha-community.org Reporter: veron at veron.ch QA Contact: testopia at bugs.koha-community.org CC: frederic at tamil.fr The file csv/cash_register_stats.tt exposes two FOREACH loops to translation. Translators should not be confronted with code internals. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Tue May 30 08:52:52 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 30 May 2017 06:52:52 +0000 Subject: [Koha-bugs] [Bug 18694] Translatability: Get rid of exposing [%% FOREACH in csv/ cash_register_stats.tt In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18694 --- Comment #1 from Marc V?ron --- Created attachment 63835 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=63835&action=edit Bug 18694: Translatability: Get rid of exposing [%% FOREACH in csv/cash_register_stats.tt Code exposed is: %s %s %s [%%- FOREACH field IN row; field IF !loop.last; ItemTypes.GetDescription(field) IF loop.last; sep IF !loop.last; END %%] %s TOTAL [%%- FOREACH field IN total; field; sep IF !loop.last; END %%] To test: - Apply patch - In staff client, verify that Cash register statistics work as before (Home > Reports > Cash register statistics) - Bonus test: Create a "language" aa-AA (perl translate create aa-AA from folder misc/translator, verify that lines mentioned above do no longer appear in aa-AA-staff-prog.po - Run QA tools (newest version with test for newlines in tt directives) -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue May 30 08:53:16 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 30 May 2017 06:53:16 +0000 Subject: [Koha-bugs] [Bug 18694] Translatability: Get rid of exposing [%% FOREACH in csv/ cash_register_stats.tt In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18694 Marc V?ron changed: What |Removed |Added ---------------------------------------------------------------------------- Patch complexity|--- |Trivial patch Status|NEW |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Tue May 30 09:13:57 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 30 May 2017 07:13:57 +0000 Subject: [Koha-bugs] [Bug 18694] Translatability: Get rid of exposing [%% FOREACH in csv/ cash_register_stats.tt In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18694 Marc V?ron changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #63835|0 |1 is obsolete| | --- Comment #2 from Marc V?ron --- Created attachment 63836 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=63836&action=edit Bug 18694: Translatability: Get rid of exposing [%% FOREACH in csv/cash_register_stats.tt Code exposed is: %s %s %s [%%- FOREACH field IN row; field IF !loop.last; ItemTypes.GetDescription(field) IF loop.last; sep IF !loop.last; END %%] %s TOTAL [%%- FOREACH field IN total; field; sep IF !loop.last; END %%] Similar for: csv/orders_by_budget.tt To test: - Apply patch - In staff client, verify that Cash register statistics work as before (Home > Reports > Cash register statistics) - Verify the same for Home > Reports > Orders by fund (triggers orders_by_budget.tt) - Bonus test: Create a "language" aa-AA (perl translate create aa-AA from folder misc/translator, verify that lines mentioned above do no longer appear in aa-AA-staff-prog.po ) - Run QA tools (newest version with test for newlines in tt directives) -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Tue May 30 09:19:35 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 30 May 2017 07:19:35 +0000 Subject: [Koha-bugs] [Bug 18585] Connect to RDF triplestore In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18585 --- Comment #6 from Magnus Enger --- At least the Fuseki triplestore has different endpoints for reading and writing data. With Fuseki as the triplestore, this bug only adds a read RDF::Trine::Model object. Would it be possible to do a followup that would aloow us to create both read and write objects? (As two separate objects.) -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue May 30 09:40:42 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 30 May 2017 07:40:42 +0000 Subject: [Koha-bugs] [Bug 18681] Translatability: Get rid of [%% in translation for about.tt In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18681 --- Comment #3 from Marc V?ron --- Created attachment 63837 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=63837&action=edit Bug 18681 - (followup) Remove on more [%% in translation for about.tt Test plan same as in previous patch Run QA tools in newest version (test for line breaks in tt directives) -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue May 30 09:41:37 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 30 May 2017 07:41:37 +0000 Subject: [Koha-bugs] [Bug 18681] Translatability: Get rid of [%% in translation for about.tt In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18681 Marc V?ron changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Needs Signoff --- Comment #4 from Marc V?ron --- Set back to NSO for the followup -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue May 30 10:24:36 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 30 May 2017 08:24:36 +0000 Subject: [Koha-bugs] [Bug 17717] process_message_queue.pl: Can't locate Authen/CAS/Client/ Response/Failure.pm In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17717 --- Comment #24 from Julian Maurice --- I've made a fresh install on Debian stretch (Perl 5.24) but I can't reproduce the problem. root at koha-stretch:~# sudo -u koha sh -c 'touch test' touch: cannot touch 'test': Permission denied root at koha-stretch:~# sudo -u koha sh -c 'ls' ls: cannot open directory '.': Permission denied As you can see I have no read nor write access to this directory, but when I execute root at koha-stretch:~# sudo -u koha sh -c 'PERL5LIB=/home/koha/koha KOHA_CONF=/home/koha/etc/koha-conf.xml perl /home/koha/koha/misc/cronjobs/process_message_queue.pl' I have no errors and the message queue is processed. Can you tell me what I'm doing wrong ? -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue May 30 10:31:09 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 30 May 2017 08:31:09 +0000 Subject: [Koha-bugs] [Bug 17717] process_message_queue.pl: Can't locate Authen/CAS/Client/ Response/Failure.pm In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17717 --- Comment #25 from Chris Cormack --- (In reply to Julian Maurice from comment #24) > > I have no errors and the message queue is processed. > > Can you tell me what I'm doing wrong ? You are not running it as cron, you are running it from the commandline. The error only manifests under cron. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue May 30 10:46:55 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 30 May 2017 08:46:55 +0000 Subject: [Koha-bugs] [Bug 18695] New: Translatability: Get rid of [ %% INCLUDE in translation for circulation.tt Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18695 Bug ID: 18695 Summary: Translatability: Get rid of [%% INCLUDE in translation for circulation.tt Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: trivial Priority: P5 - low Component: I18N/L10N Assignee: koha-bugs at lists.koha-community.org Reporter: veron at veron.ch QA Contact: testopia at bugs.koha-community.org CC: frederic at tamil.fr The file circ/circulation.tt exposes the following line to translation: %s %s [%% INCLUDE 'blocked-fines.inc' fines = chargesamount %%] %s %s Translators should not be confronted with code internals. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue May 30 10:51:27 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 30 May 2017 08:51:27 +0000 Subject: [Koha-bugs] [Bug 18695] Translatability: Get rid of [ %% INCLUDE in translation for circulation.tt In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18695 --- Comment #1 from Marc V?ron --- Created attachment 63838 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=63838&action=edit Bug 18695: Translatability: Get rid of [%% INCLUDE in translation for circulation.tt The file circ/circulation.tt exposes the following line to translation: %s %s [%% INCLUDE 'blocked-fines.inc' fines = chargesamount %%] %s %s Translators should not be confronted with code internals. This patch fixes it by removing a line break. To test: - Verify that code change makes sense - Run QA tools in newest version (check for line breaks in tt directives) - Bonus test: Create a "language" aa-AA (perl translate create aa-AA from folder misc/translator, verify that line mentioned above do no longer appear in aa-AA-staff-prog.po ) -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue May 30 10:52:07 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 30 May 2017 08:52:07 +0000 Subject: [Koha-bugs] [Bug 18695] Translatability: Get rid of [ %% INCLUDE in translation for circulation.tt In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18695 Marc V?ron changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|koha-bugs at lists.koha-commun |veron at veron.ch |ity.org | Patch complexity|--- |Trivial patch Status|NEW |Needs Signoff -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue May 30 10:53:40 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 30 May 2017 08:53:40 +0000 Subject: [Koha-bugs] [Bug 18693] Translatability: Get rid of exposing a [ %% FOREACH loop in translation for branch-selector.inc In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18693 Marc V?ron changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|koha-bugs at lists.koha-commun |veron at veron.ch |ity.org | -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Tue May 30 10:54:07 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 30 May 2017 08:54:07 +0000 Subject: [Koha-bugs] [Bug 18694] Translatability: Get rid of exposing [%% FOREACH in csv/ cash_register_stats.tt In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18694 Marc V?ron changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|koha-bugs at lists.koha-commun |veron at veron.ch |ity.org | -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Tue May 30 10:54:40 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 30 May 2017 08:54:40 +0000 Subject: [Koha-bugs] [Bug 18682] Translatability: Get rid of [ %% in translation for av-build-dropbox.inc In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18682 Marc V?ron changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|koha-bugs at lists.koha-commun |veron at veron.ch |ity.org | -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Tue May 30 10:55:13 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 30 May 2017 08:55:13 +0000 Subject: [Koha-bugs] [Bug 18648] Translatability: Get rid of tt directives in translation for macles.tt In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18648 Marc V?ron changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|koha-bugs at lists.koha-commun |veron at veron.ch |ity.org | -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue May 30 10:56:34 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 30 May 2017 08:56:34 +0000 Subject: [Koha-bugs] [Bug 16332] calendar don't show next month In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16332 Wolfram Schneider changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |RESOLVED Resolution|--- |FIXED --- Comment #2 from Wolfram Schneider --- I can confirm the issue is now fixed, and the calendar works. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue May 30 10:59:21 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 30 May 2017 08:59:21 +0000 Subject: [Koha-bugs] [Bug 18644] Translatability: Get rid of template directives in translation for memberentrygen.tt In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18644 Marc V?ron changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #63586|0 |1 is obsolete| | -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue May 30 11:13:43 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 30 May 2017 09:13:43 +0000 Subject: [Koha-bugs] [Bug 17717] process_message_queue.pl: Can't locate Authen/CAS/Client/ Response/Failure.pm In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17717 --- Comment #26 from Julian Maurice --- # cat /etc/cron.d/koha * * * * * root sudo -u koha sh -c 'PERL5LIB=/home/koha/koha KOHA_CONF=/home/koha/etc/koha-conf.xml perl /home/koha/koha/misc/cronjobs/process_message_queue.pl > /tmp/koha.log 2>&1' * * * * * root sudo -u koha sh -c 'pwd > /tmp/pwd.log 2>&1' /tmp/pwd.log contains "/root" /tmp/koha.log is empty, and the message queue is processed -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue May 30 11:19:12 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 30 May 2017 09:19:12 +0000 Subject: [Koha-bugs] [Bug 17717] process_message_queue.pl: Can't locate Authen/CAS/Client/ Response/Failure.pm In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17717 --- Comment #27 from Chris Cormack --- I feel like you are not reading the history of the bug, it is when using the cron job from the packages. You are not running that. Step 3 of the test plan says 3/ Build and install a new package (or manually update the /etc/cron.d/koha-common file) Not manually run some other cron job. I am going to bed now, and looks like it has missed the release, so you will have time to read up yourself. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue May 30 11:21:15 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 30 May 2017 09:21:15 +0000 Subject: [Koha-bugs] [Bug 18692] When SMS is enabled the OPAC messaging table is misaligned In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18692 Axelle Aix-Marseille Universit? changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |In Discussion CC| |axelle.clarisse at univ-amu.fr --- Comment #3 from Axelle Aix-Marseille Universit? --- Patch tested on sandbox 1 by Biblibre. I agree with Marc V?ron. When syspref SMSDriver is full filled (for example with email), columns are ok. When syspref SMSDriver is empty, it doesn't work because in column email we should see check boxes instead of "-". Check boxes should be in colunm email and in column not notify to allow our user to choose the messages they want to receive. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue May 30 11:24:43 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 30 May 2017 09:24:43 +0000 Subject: [Koha-bugs] [Bug 18644] Translatability: Get rid of pure template directives in translation for memberentrygen.tt In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18644 Marc V?ron changed: What |Removed |Added ---------------------------------------------------------------------------- Summary|Translatability: Get rid of |Translatability: Get rid of |template directives in |pure template directives in |translation for |translation for |memberentrygen.tt |memberentrygen.tt -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue May 30 11:31:51 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 30 May 2017 09:31:51 +0000 Subject: [Koha-bugs] [Bug 17717] process_message_queue.pl: Can't locate Authen/CAS/Client/ Response/Failure.pm In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17717 --- Comment #28 from Julian Maurice --- I've read the history of the bug, many times, and I understand that the problem is with the package install, which I'm trying to mimic to understand what's happening. If my command succeeds, why the one with koha-foreach should fail ? Anyway I'll try with a package install later when I have more time -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue May 30 11:32:54 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 30 May 2017 09:32:54 +0000 Subject: [Koha-bugs] [Bug 18644] Translatability: Get rid of pure template directives in translation for memberentrygen.tt In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18644 --- Comment #2 from Marc V?ron --- Created attachment 63839 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=63839&action=edit Bug 18644: Translatability: Get rid of pure template directives in translation for memberentrygen.tt Translation for memberentrygen.tt exposes a lot of template directives like the following: [% UNLESS opduplicate %][% othernames | html %][% END %] Translators should not be confronted with such code internals. To test: - Review code changes - Verify that creating / editing patrons works as before - Bonus test: Create a "language" aa-AA (perl translate create aa-AA from folder misc/translator, verify that lines like mentioned above do no longer appear in aa-AA-staff-prog.po -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Tue May 30 11:33:35 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 30 May 2017 09:33:35 +0000 Subject: [Koha-bugs] [Bug 18644] Translatability: Get rid of pure template directives in translation for memberentrygen.tt In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18644 Marc V?ron changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue May 30 11:34:32 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 30 May 2017 09:34:32 +0000 Subject: [Koha-bugs] [Bug 18644] Translatability: Get rid of pure template directives in translation for memberentrygen.tt In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18644 Marc V?ron changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|koha-bugs at lists.koha-commun |veron at veron.ch |ity.org | -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Tue May 30 12:23:52 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 30 May 2017 10:23:52 +0000 Subject: [Koha-bugs] [Bug 17717] process_message_queue.pl: Can't locate Authen/CAS/Client/ Response/Failure.pm In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17717 --- Comment #29 from Julian Maurice --- Just tried a package install following instructions on https://wiki.koha-community.org/wiki/Debian. Same result. The cron ran process_message_queue.pl and the message queue was processed. No errors. Should I have specific data in message_queue to trigger the error ? -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue May 30 12:24:49 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 30 May 2017 10:24:49 +0000 Subject: [Koha-bugs] [Bug 17717] process_message_queue.pl: Can't locate Authen/CAS/Client/ Response/Failure.pm In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17717 alfre69 changed: What |Removed |Added ---------------------------------------------------------------------------- CC|alfre at ibdinternet.com | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue May 30 12:25:37 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 30 May 2017 10:25:37 +0000 Subject: [Koha-bugs] [Bug 18696] Change debian/source/format to quilt In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18696 Mirko Tietgen changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |ASSIGNED Assignee|koha-bugs at lists.koha-commun |mirko at abunchofthings.net |ity.org | -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Tue May 30 12:25:22 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 30 May 2017 10:25:22 +0000 Subject: [Koha-bugs] [Bug 18696] New: Change debian/source/format to quilt Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18696 Bug ID: 18696 Summary: Change debian/source/format to quilt Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: trivial Priority: P5 - low Component: Packaging Assignee: koha-bugs at lists.koha-community.org Reporter: mirko at abunchofthings.net QA Contact: testopia at bugs.koha-community.org CC: mirko at abunchofthings.net debian/source/format uses 'native'. As Koha is not native Debian software, and to allow Debian revision numbers like -2 in 16.05.13-2, it should be changed to 'quilt'. This is only relevant to packaging and does not affect Koha itself. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue May 30 14:23:16 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 30 May 2017 12:23:16 +0000 Subject: [Koha-bugs] [Bug 16332] calendar don't show next month In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16332 --- Comment #3 from Jonathan Druart --- It did not work on May 23 but I cannot recreate now. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue May 30 14:28:33 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 30 May 2017 12:28:33 +0000 Subject: [Koha-bugs] [Bug 18682] Translatability: Get rid of [ %% in translation for 2 files av-build-dropbox.inc In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18682 Marc V?ron changed: What |Removed |Added ---------------------------------------------------------------------------- Summary|Translatability: Get rid of |Translatability: Get rid of |[%% in translation for |[%% in translation for 2 |av-build-dropbox.inc |files av-build-dropbox.inc -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue May 30 14:36:29 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 30 May 2017 12:36:29 +0000 Subject: [Koha-bugs] [Bug 18682] Translatability: Get rid of [ %% in translation for 2 files av-build-dropbox.inc In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18682 --- Comment #1 from Marc V?ron --- Created attachment 63840 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=63840&action=edit Bug 18682 - Translatability: Get rid of [%% in translation for 2 files av-build-dropbox.inc Two files av-build-dropbox.inc has linebreaks inside template directives, exposing internals (comments and tt code) to translations as mentioned in initial comment. Translators should not be confronted with such interal code. This patch fixes it. To test - Verify, that code changes make sense and have no more line breaks insied tt directives. - Run QA tools in newest version (checking for line breaks inside tt directives) - Bonus test: Create a "language" aa-AA (perl translate create aa-AA from folder misc/translator, verify that lines mentioned above do no longer appear in aa-AA-staff-prog.po and in aa-AA-opac-bootstrap.po -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue May 30 14:37:19 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 30 May 2017 12:37:19 +0000 Subject: [Koha-bugs] [Bug 18682] Translatability: Get rid of [ %% in translation for 2 files av-build-dropbox.inc In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18682 Marc V?ron changed: What |Removed |Added ---------------------------------------------------------------------------- Patch complexity|--- |Trivial patch Status|NEW |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue May 30 14:37:33 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 30 May 2017 12:37:33 +0000 Subject: [Koha-bugs] [Bug 18697] New: Fix date calculations for day/week frequencies in Serials Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18697 Bug ID: 18697 Summary: Fix date calculations for day/week frequencies in Serials Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Serials Assignee: koha-bugs at lists.koha-community.org Reporter: m.de.rooy at rijksmuseum.nl QA Contact: testopia at bugs.koha-community.org CC: colin.campbell at ptfs-europe.com See also bug 18356 and 18607. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Tue May 30 14:38:03 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 30 May 2017 12:38:03 +0000 Subject: [Koha-bugs] [Bug 18697] Fix date calculations for day/week frequencies in Serials In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18697 Marcel de Rooy changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |ASSIGNED Assignee|koha-bugs at lists.koha-commun |m.de.rooy at rijksmuseum.nl |ity.org | -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Tue May 30 14:39:39 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 30 May 2017 12:39:39 +0000 Subject: [Koha-bugs] [Bug 18607] Fix date calculations for monthly frequencies in Serials In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18607 --- Comment #1 from Marcel de Rooy --- Created attachment 63841 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=63841&action=edit Bug 18607: Fix date calculations for monthly frequencies in Serials Similarly to the solution of bug 18356, this patch fixes the date calculation for monthly frequencies. The calculation in GetFictiveIssueNumber was that similar that we could merge the algorithm for months and years. Note that we add a wrapper around Date::Calc::N_Delta_YMD in order to improve its results. The calculation in _get_next_date_month is also very similar to the one in _get_next_date_year. I do not merge them here, but this could still be considered later on. At least consistency is achieved now between both routines. The connection with firstacquidate has been cut thru just like for year units. Test plan: [1] Edit an subscription. Check some monthly prediction patterns. [2] The next patch adjusts related unit tests. Signed-off-by: Marcel de Rooy -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue May 30 14:39:42 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 30 May 2017 12:39:42 +0000 Subject: [Koha-bugs] [Bug 18607] Fix date calculations for monthly frequencies in Serials In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18607 --- Comment #2 from Marcel de Rooy --- Created attachment 63842 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=63842&action=edit Bug 18607: Adjusting unit tests for monthly serial frequencies The changes in the first patch require some corrections as well as additional test cases. GetNextDate.t: Since the calculation for multiple issues per unit has slightly changed, a few dates (day 15 or day 16) have been changed in the unit test; when we use 2/month, the algorithm now always adds 15 days. Added a few test descriptions in this regard too. GetFictiveIssueNumber.t: Add the monthly subtest with two test cases. In the first case we tests multiple units per issue, and in the second case we test multiple issues per unit (month). Test plan: [1] Run t/db_dependent/Serials/GetFictiveIssueNumber.t [2] Run t/db_dependent/Serials/GetNextDate.t Signed-off-by: Marcel de Rooy -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue May 30 14:49:05 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 30 May 2017 12:49:05 +0000 Subject: [Koha-bugs] [Bug 18698] New: Get rid of [%% in translation for shelves-result.tt Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18698 Bug ID: 18698 Summary: Get rid of [%% in translation for shelves-result.tt Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: minor Priority: P5 - low Component: I18N/L10N Assignee: koha-bugs at lists.koha-community.org Reporter: veron at veron.ch QA Contact: testopia at bugs.koha-community.org CC: frederic at tamil.fr The file koha-tmpl/intranet-tmpl/prog/en/modules/virtualshelves/tables/shelves_results.tt exposes parts of template directives to translation, for example: "\", \"dt_sortby\": %s\"Author\"%s\"Year\"%s\"Call number\"%s\"Title\"%s, " "\"dt_created_on\": \"%s\", \"dt_modification_time\": \"%s\", \"dt_action\": " "\"%s\" }%s,%s %s ] } %s %s %s %s [%%~ action_block = '" or ~%%] %s %s [%%~ action_block = action_block _ ' Such semi-internals make translation errorprone. Translators should not be confronted with tt internals. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue May 30 14:53:02 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 30 May 2017 12:53:02 +0000 Subject: [Koha-bugs] [Bug 18607] Fix date calculations for monthly frequencies in Serials In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18607 Marcel de Rooy changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #63841|0 |1 is obsolete| | --- Comment #3 from Marcel de Rooy --- Created attachment 63843 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=63843&action=edit Bug 18607: Fix date calculations for monthly frequencies in Serials Similarly to the solution of bug 18356, this patch fixes the date calculation for monthly frequencies. The calculation in GetFictiveIssueNumber was that similar that we could merge the algorithm for months and years. Note that we add a wrapper around Date::Calc::N_Delta_YMD in order to improve its results. The calculation in _get_next_date_month is also very similar to the one in _get_next_date_year. I do not merge them here, but this could still be considered later on. At least consistency is achieved now between both routines. The connection with firstacquidate has been cut thru just like for year units. Test plan: [1] Without this patch, look at the prediction pattern for a subscription with first issue on Feb 21 and 5 per month. The first issues will be 21, 22, 23, 24, 25. Then jumping to 21, 23, 25, etc. [2] Apply the patch. Look at the same prediction pattern. You will now see 6 day intervals and a new cycle starting on the 21st. So Feb 21, 27, Mar 5, 11, 17 and Mar 21, 27, etc. [3] Edit an subscription. Try a few other monthly frequencies. [4] The next patch adjusts related unit tests. Signed-off-by: Marcel de Rooy -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue May 30 14:53:05 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 30 May 2017 12:53:05 +0000 Subject: [Koha-bugs] [Bug 18607] Fix date calculations for monthly frequencies in Serials In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18607 Marcel de Rooy changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #63842|0 |1 is obsolete| | --- Comment #4 from Marcel de Rooy --- Created attachment 63844 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=63844&action=edit Bug 18607: Adjusting unit tests for monthly serial frequencies The changes in the first patch require some corrections as well as additional test cases. GetNextDate.t: Since the calculation for multiple issues per unit has slightly changed, a few dates (day 15 or day 16) have been changed in the unit test; when we use 2/month, the algorithm now always adds 15 days. Added a few test descriptions in this regard too. GetFictiveIssueNumber.t: Add the monthly subtest with two test cases. In the first case we tests multiple units per issue, and in the second case we test multiple issues per unit (month). Test plan: [1] Run t/db_dependent/Serials/GetFictiveIssueNumber.t [2] Run t/db_dependent/Serials/GetNextDate.t Signed-off-by: Marcel de Rooy -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue May 30 14:53:31 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 30 May 2017 12:53:31 +0000 Subject: [Koha-bugs] [Bug 18697] Fix date calculations for day/week frequencies in Serials In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18697 Marcel de Rooy changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on| |18607 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18607 [Bug 18607] Fix date calculations for monthly frequencies in Serials -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue May 30 14:53:31 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 30 May 2017 12:53:31 +0000 Subject: [Koha-bugs] [Bug 18607] Fix date calculations for monthly frequencies in Serials In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18607 Marcel de Rooy changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |18697 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18697 [Bug 18697] Fix date calculations for day/week frequencies in Serials -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue May 30 15:31:03 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 30 May 2017 13:31:03 +0000 Subject: [Koha-bugs] [Bug 18698] Get rid of [%% in translation for shelves-result.tt In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18698 --- Comment #1 from Marc V?ron --- Very complex. To resolve this translation issue the help of the original authors is needed. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue May 30 15:34:35 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 30 May 2017 13:34:35 +0000 Subject: [Koha-bugs] [Bug 18698] Get rid of [%% in translation for shelves-result.tt In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18698 Marc V?ron changed: What |Removed |Added ---------------------------------------------------------------------------- Component|I18N/L10N |Lists Assignee|koha-bugs at lists.koha-commun |gmcharlt at gmail.com |ity.org | CC| |m.de.rooy at rijksmuseum.nl -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue May 30 15:55:13 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 30 May 2017 13:55:13 +0000 Subject: [Koha-bugs] [Bug 18699] New: Get rid of %%] in translation for currency.tt Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18699 Bug ID: 18699 Summary: Get rid of %%] in translation for currency.tt Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: I18N/L10N Assignee: koha-bugs at lists.koha-community.org Reporter: veron at veron.ch QA Contact: testopia at bugs.koha-community.org CC: frederic at tamil.fr Translation for edi_accounts.tt exposes: [%% transport_types = [ 'FTP', 'SFTP', 'FILE' ] %%] Translators should not be confronted with such code internals. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue May 30 16:02:50 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 30 May 2017 14:02:50 +0000 Subject: [Koha-bugs] [Bug 18699] Get rid of %%] in translation for edi_accounts.tt In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18699 Marc V?ron changed: What |Removed |Added ---------------------------------------------------------------------------- Summary|Get rid of %%] in |Get rid of %%] in |translation for currency.tt |translation for | |edi_accounts.tt -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Tue May 30 16:13:29 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 30 May 2017 14:13:29 +0000 Subject: [Koha-bugs] [Bug 18699] Get rid of %%] in translation for edi_accounts.tt In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18699 --- Comment #1 from Marc V?ron --- Created attachment 63845 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=63845&action=edit Bug 18699: Get rid of %%] in translation for edi_accounts.tt Translation for edi_accounts.tt exposes: [%% transport_types = [ 'FTP', 'SFTP', 'FILE' ] %%] Translators should not be confronted with such code internals. To test: - Review code change (it removes line breaks) - Bonus test: Create a new translatin for "language" aa-AA and verify that the line no longer appears in aa-AA-staff-prog.po -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Tue May 30 16:14:17 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 30 May 2017 14:14:17 +0000 Subject: [Koha-bugs] [Bug 18699] Get rid of %%] in translation for edi_accounts.tt In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18699 Marc V?ron changed: What |Removed |Added ---------------------------------------------------------------------------- Patch complexity|--- |Trivial patch Status|NEW |Needs Signoff Assignee|koha-bugs at lists.koha-commun |veron at veron.ch |ity.org | -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue May 30 16:16:42 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 30 May 2017 14:16:42 +0000 Subject: [Koha-bugs] [Bug 9433] Translatability: Too many comments in system preferences po file In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9433 Marc V?ron changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |ASSIGNED --- Comment #3 from Marc V?ron --- More to come... -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue May 30 16:17:07 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 30 May 2017 14:17:07 +0000 Subject: [Koha-bugs] [Bug 18700] New: Fix ungrammatical sentence Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18700 Bug ID: 18700 Summary: Fix ungrammatical sentence Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: trivial Priority: P5 - low Component: System Administration Assignee: koha-bugs at lists.koha-community.org Reporter: colin.campbell at ptfs-europe.com QA Contact: testopia at bugs.koha-community.org CC: gmcharlt at gmail.com admin-home has an ungrammatical sentence referring to "datas". In English data can be treated as a plural (sing datum) or a mass noun but it is not a count noun. correct the grammar -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Tue May 30 16:21:18 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 30 May 2017 14:21:18 +0000 Subject: [Koha-bugs] [Bug 9433] Translatability: Too many comments in system preferences po file In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9433 --- Comment #4 from Jonathan Druart --- Marc, I do not recreate: % perl translate update es-ES % grep "Web services > Reporting" po/es-ES-pref.po|wc -l 3 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue May 30 16:25:26 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 30 May 2017 14:25:26 +0000 Subject: [Koha-bugs] [Bug 15646] koha qa test tools In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15646 --- Comment #4 from Jonathan Druart --- Could you convince me why we would need this patch? We do not have any occurrences of my $foo = print('bar') in the code. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue May 30 16:25:31 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 30 May 2017 14:25:31 +0000 Subject: [Koha-bugs] [Bug 18697] Fix date calculations for day/week frequencies in Serials In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18697 --- Comment #1 from Marcel de Rooy --- Created attachment 63846 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=63846&action=edit Bug 18697: Fix date calculations for weekly frequencies in Serials Same solution applied as in bug 18356/18607. Consistency++ The code in _get_next_date_week is again very similar to the code in _get_next_date_month or _get_next_date_year. I will not merge them here, but we could consider that in the future. Code in GetFictiveIssueNo has been adjusted similarly to month and year. It might be interesting to merge it with the code for unit 'day'. Test plan: [1] Do not apply this patch. Create a subscription for 3/week. When the first issue date is on a Saturday or Sunday, the intervals in the prediction pattern are 0,0,7,0,0,7,etc. Starting on Wed-Fri 1,1,5,etc. Starting on Mon-Tue 2,2,3,etc. [2] Apply this patch. Check again. The interval should be always 2,2,3 now and no longer depend on the day_of_week of first issue date. [3] Check another weekly frequency with multiple units per issue. Say 1 issue/3 weeks. Signed-off-by: Marcel de Rooy -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue May 30 16:25:33 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 30 May 2017 14:25:33 +0000 Subject: [Koha-bugs] [Bug 15646] koha qa test tools In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15646 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |In Discussion -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue May 30 16:25:34 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 30 May 2017 14:25:34 +0000 Subject: [Koha-bugs] [Bug 18697] Fix date calculations for day/week frequencies in Serials In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18697 --- Comment #2 from Marcel de Rooy --- Created attachment 63847 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=63847&action=edit Bug 18697: Adjusting unit tests for weekly serial frequencies Corrections and added unit tests following the changes of the first patch. GetFictiveIssueNumber.t: New subtest for weekly frequencies. GetNextDate.t: Correcting a few dates one day. If we use 2/week, we will calculate an interval of 3 days and correct with 4 days at the end of the cycle. The connection with firstacqui is not relevant anymore. Test plan: [1] Run t/db_dependent/Serials/GetFictiveIssueNumber.t [2] Run t/db_dependent/Serials/GetNextDate.t Signed-off-by: Marcel de Rooy -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue May 30 16:25:45 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 30 May 2017 14:25:45 +0000 Subject: [Koha-bugs] [Bug 18700] Fix ungrammatical sentence In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18700 Colin Campbell changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|koha-bugs at lists.koha-commun |colin.campbell at ptfs-europe. |ity.org |com Status|NEW |Needs Signoff --- Comment #1 from Colin Campbell --- Created attachment 63848 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=63848&action=edit Minor grammar correction Fix the grammar of the sentence removing the incorrect pluralization of data - switch those to these to improve flow - I expect to test find a pedantic grammarian and see if the still wince at the sentence after the patch is applied -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Tue May 30 16:27:11 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 30 May 2017 14:27:11 +0000 Subject: [Koha-bugs] [Bug 9433] Translatability: Too many comments in system preferences po file In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9433 --- Comment #5 from Marc V?ron --- (In reply to Jonathan Druart from comment #4) > Marc, I do not recreate: > > % perl translate update es-ES > % grep "Web services > Reporting" po/es-ES-pref.po|wc -l > 3 Try create (not update) perl translate create aa-AA Then open po/aa-AA-pref.po -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue May 30 16:35:00 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 30 May 2017 14:35:00 +0000 Subject: [Koha-bugs] [Bug 17896] BakerTaylorEnabled is not plack safe in reading history at the OPAC In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17896 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Failed QA CC| |jonathan.druart at bugs.koha-c | |ommunity.org Severity|enhancement |major Summary|Enabling syspref |BakerTaylorEnabled is not |'BakerTaylorEnabled' causes |plack safe in reading |software error |history at the OPAC --- Comment #2 from Jonathan Druart --- Aleisha, I agree that there is something wrong, but the test plan is not enough. There are several things wrong: - import must be done at the beginning of the module - import must not be dependent of syspref in begin blocks What's happen is that Plack run all BEGIN blocks and it starts, and that the only time they are evaluated. That means that if you start plack and your pref BakerTaylorEnabled is disabled, the require+import will not be done. If you then enable the pref (and not restart plack of course) and access the opac-readingrec view, it will explode. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue May 30 16:36:29 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 30 May 2017 14:36:29 +0000 Subject: [Koha-bugs] [Bug 17896] BakerTaylorEnabled is not plack safe in reading history at the OPAC In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17896 --- Comment #3 from Jonathan Druart --- Aleisha, I agree that there is something wrong, but the test plan is not enough. There are several things wrong: - import must be done at the beginning of the module - import must not be dependent of syspref in begin blocks What's happening is that Plack runs all BEGIN blocks when it starts, and that is the only time they are evaluated. That means that if you start plack with the pref BakerTaylorEnabled disabled, the require+import will not be done. Then if you enable the pref (and not restart plack of course) and access the opac-readingrec view, it will explode. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue May 30 16:49:42 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 30 May 2017 14:49:42 +0000 Subject: [Koha-bugs] [Bug 9433] Translatability: Too many comments in system preferences po file In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9433 --- Comment #6 from Marc V?ron --- When I tested I compared with the file downloaded from translate.koha-community.org Cait, can you have a look please? - Can you still reproduce? (BTW: The problem appears still in http://translate.koha-community.org/de/17.05/) -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue May 30 16:54:19 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 30 May 2017 14:54:19 +0000 Subject: [Koha-bugs] [Bug 18607] Fix date calculations for monthly frequencies in Serials In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18607 Marcel de Rooy changed: What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue May 30 17:07:50 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 30 May 2017 15:07:50 +0000 Subject: [Koha-bugs] [Bug 18224] Cleanup after Buug 14778 In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18224 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|koha-bugs at lists.koha-commun |olli-antti.kivilahti at jns.fi |ity.org | Severity|enhancement |minor CC| |jonathan.druart at bugs.koha-c | |ommunity.org -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue May 30 17:08:49 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 30 May 2017 15:08:49 +0000 Subject: [Koha-bugs] [Bug 18127] Add batch modified records to an existing list In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18127 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |jonathan.druart at bugs.koha-c | |ommunity.org Status|Needs Signoff |BLOCKED --- Comment #3 from Jonathan Druart --- Blocked by bug 12759. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue May 30 17:09:07 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 30 May 2017 15:09:07 +0000 Subject: [Koha-bugs] [Bug 18133] Batch record modification/ deletion is not optimised for authorities In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18133 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |jonathan.druart at bugs.koha-c | |ommunity.org Status|Needs Signoff |BLOCKED --- Comment #2 from Jonathan Druart --- Blocked by bug 18127. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue May 30 17:10:26 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 30 May 2017 15:10:26 +0000 Subject: [Koha-bugs] [Bug 18377] Add Plack/PSGI file for dev install In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18377 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |jonathan.druart at bugs.koha-c | |ommunity.org --- Comment #3 from Jonathan Druart --- Why do not you update misc/plack/koha.psgi? -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue May 30 17:10:39 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 30 May 2017 15:10:39 +0000 Subject: [Koha-bugs] [Bug 18318] Unicode support for Elasticsearch In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18318 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|gmcharlt at gmail.com |nick at bywatersolutions.com -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue May 30 17:13:34 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 30 May 2017 15:13:34 +0000 Subject: [Koha-bugs] [Bug 18389] bulkmarcimport.pl does not take notice of MARC modification templates In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18389 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Failed QA Assignee|gmcharlt at gmail.com |J.P.Knight at lboro.ac.uk CC| |jonathan.druart at bugs.koha-c | |ommunity.org --- Comment #7 from Jonathan Druart --- Hi Jon, Could you resubmit your patch following the requirements on the wiki page https://wiki.koha-community.org/wiki/Commit_messages -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue May 30 17:26:23 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 30 May 2017 15:26:23 +0000 Subject: [Koha-bugs] [Bug 18377] Add Plack/PSGI file for dev install In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18377 --- Comment #4 from Julian Maurice --- (In reply to Jonathan Druart from comment #3) > Why do not you update misc/plack/koha.psgi? I would have deleted it but I figured it may be used somewhere. Maybe we could add a deprecation warning in it before deleting it. As to why I think /app.psgi is a better place, it's because you can just cd to koha directory and run starman without any arguments (you don't have to look after the psgi file), and it will work. But I'm not strongly against updating misc/plack/koha.psgi if you still think it's better. I can make a new patch -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue May 30 17:27:52 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 30 May 2017 15:27:52 +0000 Subject: [Koha-bugs] [Bug 18377] Add Plack/PSGI file for dev install In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18377 --- Comment #5 from Julian Maurice --- s/look after/look for/ -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue May 30 17:28:11 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 30 May 2017 15:28:11 +0000 Subject: [Koha-bugs] [Bug 18683] biblioitems.marcxml does not match MARC21slim.xsd In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18683 Josef Moravec changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |josef.moravec at gmail.com -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue May 30 17:50:04 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 30 May 2017 15:50:04 +0000 Subject: [Koha-bugs] [Bug 18701] New: Translatability: Get rid of exposed tt directives in matching-rules.tt Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18701 Bug ID: 18701 Summary: Translatability: Get rid of exposed tt directives in matching-rules.tt Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: I18N/L10N Assignee: koha-bugs at lists.koha-community.org Reporter: veron at veron.ch QA Contact: testopia at bugs.koha-community.org CC: frederic at tamil.fr Translation for file matching-rules.tt exposes a lot of template directives. Translators should not be confronted with internal code like the following: [%% PROCESS norms_select selected_norm=\"none\" id=\"mc_1_src_c_1_n_1_norm\" "name=\"mc_1_src_c_1_n_1_norm\" %%] -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Tue May 30 17:50:30 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 30 May 2017 15:50:30 +0000 Subject: [Koha-bugs] [Bug 18701] Translatability: Get rid of exposed tt directives in matching-rules.tt In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18701 Marc V?ron changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|koha-bugs at lists.koha-commun |veron at veron.ch |ity.org | Severity|enhancement |trivial -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Tue May 30 17:56:03 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 30 May 2017 15:56:03 +0000 Subject: [Koha-bugs] [Bug 18701] Translatability: Get rid of exposed tt directives in matching-rules.tt In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18701 --- Comment #1 from Marc V?ron --- Created attachment 63849 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=63849&action=edit Bug 18701: Translatability: Get rid of exposed tt directives in matching-rules.tt Translation for file matching-rules.tt exposes a lot of template directives. Translators should not be confronted with internal code like the following: [%% PROCESS norms_select selected_norm=\"none\" id=\"mc_1_src_c_1_n_1_norm\" "name=\"mc_1_src_c_1_n_1_norm\" %%] To test: - Apply patch - Verify that code changes make sense (removes line breaks in directives) - Run QA tools in newset version (tests for line breaks in tt) - Bonus test: create a new translation e.g. fpr language 'aa-AA', verify that such lines no longer appear in po/aa-AA-staff-prog.po (for matching-rules.tt) -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue May 30 17:56:47 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 30 May 2017 15:56:47 +0000 Subject: [Koha-bugs] [Bug 18701] Translatability: Get rid of exposed tt directives in matching-rules.tt In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18701 Marc V?ron changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue May 30 18:04:34 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 30 May 2017 16:04:34 +0000 Subject: [Koha-bugs] [Bug 18389] bulkmarcimport.pl does not take notice of MARC modification templates In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18389 --- Comment #8 from Jon Knight --- OK. This may take some time as I'm new to git and I've not idea how to recommit something I've already committed. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue May 30 18:49:34 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 30 May 2017 16:49:34 +0000 Subject: [Koha-bugs] [Bug 18702] New: Translatability: Get rid of exposed if statement in tt translation for onboardingstep2.tt Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18702 Bug ID: 18702 Summary: Translatability: Get rid of exposed if statement in tt translation for onboardingstep2.tt Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Installation and upgrade (web-based installer) Assignee: koha-bugs at lists.koha-community.org Reporter: veron at veron.ch QA Contact: testopia at bugs.koha-community.org CC: gmcharlt at gmail.com The file onboardingstep2.tt exposes the following to translations: "[%% IF (categories && categories.count > 1 ) # This if statement checks if " "the categories variable handed to this template # by onboarding.pl has data " "in it. If the categories variable does have data # in it this means that the " "user has previously imported sample patron category # data and so we do not " "need to show them the create patron category screen 1, #instead we can " "display a screen with ubtton redirecting the user to step 3 %%] " Translators should not be confronted with such internals. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue May 30 18:49:58 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 30 May 2017 16:49:58 +0000 Subject: [Koha-bugs] [Bug 18702] Translatability: Get rid of exposed if statement in tt translation for onboardingstep2.tt In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18702 Marc V?ron changed: What |Removed |Added ---------------------------------------------------------------------------- Severity|enhancement |trivial Assignee|koha-bugs at lists.koha-commun |veron at veron.ch |ity.org | -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Tue May 30 18:52:08 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 30 May 2017 16:52:08 +0000 Subject: [Koha-bugs] [Bug 18702] Translatability: Translatability: Get rid of exposed if statement in tt for translated onboardingstep2.tt In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18702 Marc V?ron changed: What |Removed |Added ---------------------------------------------------------------------------- Summary|Translatability: Get rid of |Translatability: |exposed if statement in tt |Translatability: Get rid of |translation for |exposed if statement in tt |onboardingstep2.tt |for translated | |onboardingstep2.tt -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue May 30 18:54:18 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 30 May 2017 16:54:18 +0000 Subject: [Koha-bugs] [Bug 18702] Translatability: Translatability: Get rid of exposed if statement in tt for translated onboardingstep2.tt In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18702 --- Comment #1 from Marc V?ron --- Created attachment 63850 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=63850&action=edit Bug 18702: Translatability: Get rid of exposed if statement in tt for translated onboardingstep2.tt The file onboardingstep2.tt exposes the following to translations: "[%% IF (categories && categories.count > 1 ) # This if statement checks if " "the categories variable handed to this template # by onboarding.pl has data " "in it. If the categories variable does have data # in it this means that the " "user has previously imported sample patron category # data and so we do not " "need to show them the create patron category screen 1, #instead we can " "display a screen with ubtton redirecting the user to step 3 %%] " Translators should not be confronted with such internals. This patch removes it To test: - Verify that code change makes sense - Run QA tools - Bonus test: Create a new "language" aa-AA and verify that the lines above are no longer exposed. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue May 30 18:55:10 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 30 May 2017 16:55:10 +0000 Subject: [Koha-bugs] [Bug 18702] Translatability: Translatability: Get rid of exposed if statement in tt for translated onboardingstep2.tt In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18702 Marc V?ron changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff Patch complexity|--- |Trivial patch -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue May 30 19:44:55 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 30 May 2017 17:44:55 +0000 Subject: [Koha-bugs] [Bug 18546] Unhide the 'Hide window' link in OPAC cart In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18546 Owen Leonard changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Failed QA --- Comment #5 from Owen Leonard --- The "close" class on that link is what gives it its functionality. There's a globally-defined trigger for "windows.close()" on .close. Otherwise I think this is a good solution. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue May 30 20:05:51 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 30 May 2017 18:05:51 +0000 Subject: [Koha-bugs] [Bug 18389] bulkmarcimport.pl does not take notice of MARC modification templates In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18389 Jon Knight changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #63353|0 |1 is obsolete| | Attachment #63469|0 |1 is obsolete| | --- Comment #9 from Jon Knight --- Created attachment 63851 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=63851&action=edit Revised patch with commit information reformatted. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue May 30 20:36:18 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 30 May 2017 18:36:18 +0000 Subject: [Koha-bugs] [Bug 18648] Translatability: Get rid of tt directives in translation for macles.tt In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18648 Marc V?ron changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Failed QA --- Comment #3 from Marc V?ron --- Found an issue - needs some more workk... -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue May 30 20:43:44 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 30 May 2017 18:43:44 +0000 Subject: [Koha-bugs] [Bug 18703] New: Translatability: Resolve some remaining %%] problems for staff client in 6 Files Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18703 Bug ID: 18703 Summary: Translatability: Resolve some remaining %%] problems for staff client in 6 Files Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: I18N/L10N Assignee: koha-bugs at lists.koha-community.org Reporter: veron at veron.ch QA Contact: testopia at bugs.koha-community.org CC: frederic at tamil.fr There are some more files that expose parts of tt diretives to translations, mostly due to line breaks inside directives. Files covered with this Bug: koha-tmpl/intranet-tmpl/prog/en/includes/authorities-search-results.inc koha-tmpl/intranet-tmpl/prog/en/includes/circ-menu.inc koha-tmpl/intranet-tmpl/prog/en/includes/search_indexes.inc koha-tmpl/intranet-tmpl/prog/en/modules/catalogue/issuehistory.tt koha-tmpl/intranet-tmpl/prog/en/modules/intranet-main.tt koha-tmpl/intranet-tmpl/prog/en/modules/members/members-update.tt -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Tue May 30 20:47:40 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 30 May 2017 18:47:40 +0000 Subject: [Koha-bugs] [Bug 18703] Translatability: Resolve some remaining %%] problems for staff client in 6 Files In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18703 --- Comment #1 from Marc V?ron --- Created attachment 63852 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=63852&action=edit Bug 18703 - Translatability: Resolve some remaining %%] problems for staff client in 6 Files There are some more files that expose parts of tt diretives to translations, mostly due to line breaks inside directives. Files covered with this Bug: koha-tmpl/intranet-tmpl/prog/en/includes/authorities-search-results.inc koha-tmpl/intranet-tmpl/prog/en/includes/circ-menu.inc koha-tmpl/intranet-tmpl/prog/en/includes/search_indexes.inc koha-tmpl/intranet-tmpl/prog/en/modules/catalogue/issuehistory.tt koha-tmpl/intranet-tmpl/prog/en/modules/intranet-main.tt koha-tmpl/intranet-tmpl/prog/en/modules/members/members-update.tt To test: - Review code, verify that line breaks are removed - Run QA tools - Bonus test: Create a "language" aa-AA and verify that no fragments containign %%] are picked for the 6 files -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue May 30 20:48:31 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 30 May 2017 18:48:31 +0000 Subject: [Koha-bugs] [Bug 18703] Translatability: Resolve some remaining %%] problems for staff client in 6 Files In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18703 Marc V?ron changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff Patch complexity|--- |Trivial patch Assignee|koha-bugs at lists.koha-commun |veron at veron.ch |ity.org | -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue May 30 20:50:54 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 30 May 2017 18:50:54 +0000 Subject: [Koha-bugs] [Bug 18389] bulkmarcimport.pl does not take notice of MARC modification templates In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18389 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |Needs Signoff --- Comment #10 from Jonathan Druart --- Sounds good, thanks Jon! Do not forget to change the status accordingly :) -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue May 30 20:54:30 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 30 May 2017 18:54:30 +0000 Subject: [Koha-bugs] [Bug 18377] Add Plack/PSGI file for dev install In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18377 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |tomascohen at gmail.com -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue May 30 20:58:48 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 30 May 2017 18:58:48 +0000 Subject: [Koha-bugs] [Bug 18648] Translatability: Get rid of tt directives in translation for macles.tt In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18648 Marc V?ron changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #63599|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue May 30 21:01:31 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 30 May 2017 19:01:31 +0000 Subject: [Koha-bugs] [Bug 18616] The "Add forgot password link to OPAC" should allow patrons to use their library card number in addition to username In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18616 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |jonathan.druart at bugs.koha-c | |ommunity.org Depends on| |8753 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8753 [Bug 8753] Add forgot password link to OPAC -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue May 30 21:01:31 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 30 May 2017 19:01:31 +0000 Subject: [Koha-bugs] [Bug 8753] Add forgot password link to OPAC In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8753 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |18616 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18616 [Bug 18616] The "Add forgot password link to OPAC" should allow patrons to use their library card number in addition to username -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue May 30 21:13:39 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 30 May 2017 19:13:39 +0000 Subject: [Koha-bugs] [Bug 18648] Translatability: Get rid of tt directives in translation for macles.tt In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18648 --- Comment #4 from Marc V?ron --- Created attachment 63853 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=63853&action=edit Bug 18648: Translatability: Get rid of tt directives in translation for macles.tt koha-tmpl/intranet-tmpl/prog/en/modules/cataloguing/value_builder/macles.tt contains template directives inside a div tag: This is exposed in translation tool. To test: - Carefully examine code changes - Apply patch, verify that the directive is no longer exposed (picked for po files), e.g. by creating a new "language" aa-AA and examing aa-AA-staff-prog.po - If you know where / how this macles is used, verify that it behaves as before (Note: New patch, needs new sign off) -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue May 30 21:14:02 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 30 May 2017 19:14:02 +0000 Subject: [Koha-bugs] [Bug 18648] Translatability: Get rid of tt directives in translation for macles.tt In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18648 Marc V?ron changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue May 30 21:19:13 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 30 May 2017 19:19:13 +0000 Subject: [Koha-bugs] [Bug 18546] Unhide the 'Hide window' link in OPAC cart In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18546 Marc V?ron changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #63777|0 |1 is obsolete| | --- Comment #6 from Marc V?ron --- Created attachment 63854 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=63854&action=edit Bug 18546 - Unhide the 'Hide window' link in OPAC cart In OPAC cart, the link 'Hide window' is hidden because of a conflict with bootstrap css. This patch replaces the sprites for the toolbar with Fafamfam icons to make the 'Hide window' link visible. (Amended for comment #5 / 2017-05-30 mv) -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue May 30 21:19:33 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 30 May 2017 19:19:33 +0000 Subject: [Koha-bugs] [Bug 18546] Unhide the 'Hide window' link in OPAC cart In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18546 Marc V?ron changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue May 30 21:23:00 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 30 May 2017 19:23:00 +0000 Subject: [Koha-bugs] [Bug 18704] New: File types limit in tools/ export.pl is causing issues with csv files generated by MS/Excel Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18704 Bug ID: 18704 Summary: File types limit in tools/export.pl is causing issues with csv files generated by MS/Excel Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: normal Priority: P5 - low Component: Tools Assignee: gmcharlt at gmail.com Reporter: nick at bywatersolutions.com QA Contact: testopia at bugs.koha-community.org It seems that a file saved as csv from Excel sometimes has the mime type: application/vnd.ms-excel Bug 18087 limited the file types to: text/csv text/plain Users are complaining of a loss of functionality here. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue May 30 21:23:25 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 30 May 2017 19:23:25 +0000 Subject: [Koha-bugs] [Bug 18704] File types limit in tools/ export.pl is causing issues with csv files generated by MS/Excel In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18704 Nick Clemens changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|gmcharlt at gmail.com |jonathan.druart at bugs.koha-c | |ommunity.org CC| |joy at bywatersolutions.com, | |nick at bywatersolutions.com Depends on| |18087 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18087 [Bug 18087] Clarification on File type when using file of biblionumbers to export data -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue May 30 21:23:25 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 30 May 2017 19:23:25 +0000 Subject: [Koha-bugs] [Bug 18087] Clarification on File type when using file of biblionumbers to export data In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18087 Nick Clemens changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |18704 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18704 [Bug 18704] File types limit in tools/export.pl is causing issues with csv files generated by MS/Excel -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue May 30 21:36:58 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 30 May 2017 19:36:58 +0000 Subject: [Koha-bugs] [Bug 18616] The "Add forgot password link to OPAC" should allow patrons to use their library card number in addition to username In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18616 Nick Clemens changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |nick at bywatersolutions.com -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue May 30 21:56:40 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 30 May 2017 19:56:40 +0000 Subject: [Koha-bugs] [Bug 18696] Change debian/source/format to quilt In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18696 Mason James changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |mtj at kohaaloha.com -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue May 30 21:57:18 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 30 May 2017 19:57:18 +0000 Subject: [Koha-bugs] [Bug 18698] Get rid of [%% in translation for shelves-result.tt In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18698 Mason James changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |mtj at kohaaloha.com -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue May 30 21:57:46 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 30 May 2017 19:57:46 +0000 Subject: [Koha-bugs] [Bug 18683] biblioitems.marcxml does not match MARC21slim.xsd In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18683 Mason James changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |mtj at kohaaloha.com -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue May 30 21:58:03 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 30 May 2017 19:58:03 +0000 Subject: [Koha-bugs] [Bug 18377] Add Plack/PSGI file for dev install In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18377 Mason James changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |mtj at kohaaloha.com -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue May 30 21:57:57 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 30 May 2017 19:57:57 +0000 Subject: [Koha-bugs] [Bug 18704] File types limit in tools/ export.pl is causing issues with csv files generated by MS/Excel In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18704 Mason James changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |mtj at kohaaloha.com -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue May 30 22:33:07 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 30 May 2017 20:33:07 +0000 Subject: [Koha-bugs] [Bug 18616] The "Add forgot password link to OPAC" should allow patrons to use their library card number in addition to username In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18616 David Kuhn changed: What |Removed |Added ---------------------------------------------------------------------------- Patch complexity|--- |Trivial patch Status|NEW |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue May 30 22:33:10 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 30 May 2017 20:33:10 +0000 Subject: [Koha-bugs] [Bug 18616] The "Add forgot password link to OPAC" should allow patrons to use their library card number in addition to username In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18616 --- Comment #1 from David Kuhn --- Created attachment 63855 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=63855&action=edit Bug 18616 - The "Add forgot password link to OPAC" should allow patrons to use their library card number in addition to username Allow patrons to enter either their library card number or user name in the "Log in" box for password recovery. Most patrons at our library use their card number to log in and are unaware of what their userid is. However there are some who have set a customized userid and would prefer to use that. This patch would allow either to be entered for password recovery. To test: 1. Enable the password recovery feature. 2. In the OPAC, click on "Forgot you password?" link and enter a valid library card number. 3. The error message "No account found with the provided information" appears. 4. Apply the patch. 5. Repeat step 2. The recovery email is now sent. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue May 30 22:37:51 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 30 May 2017 20:37:51 +0000 Subject: [Koha-bugs] [Bug 18704] File types limit in tools/ export.pl is causing issues with csv files generated by MS/Excel In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18704 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|jonathan.druart at bugs.koha-c |gmcharlt at gmail.com |ommunity.org | --- Comment #1 from Jonathan Druart --- I guess the following patch would fixes the problem: - my @valid_mimetypes = qw( application/octet-stream text/csv text/plain ); + my @valid_mimetypes = qw( application/octet-stream text/csv text/plain application/vnd.ms-excel ); Are we going to create a patch for vendors that provide non-standard mimetype? (Yes I know, this one is certainly the most used). -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue May 30 22:47:52 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 30 May 2017 20:47:52 +0000 Subject: [Koha-bugs] [Bug 18616] The "Add forgot password link to OPAC" should allow patrons to use their library card number in addition to username In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18616 Marc V?ron changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |https://bugs.koha-community | |.org/bugzilla3/show_bug.cgi | |?id=18653 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue May 30 22:49:08 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 30 May 2017 20:49:08 +0000 Subject: [Koha-bugs] [Bug 8753] Add forgot password link to OPAC In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8753 Marc V?ron changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |18653 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue May 30 22:57:12 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 30 May 2017 20:57:12 +0000 Subject: [Koha-bugs] [Bug 18704] File types limit in tools/ export.pl is causing issues with csv files generated by MS/Excel In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18704 Nick Clemens changed: What |Removed |Added ---------------------------------------------------------------------------- Patch complexity|--- |Trivial patch Status|NEW |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue May 30 22:57:14 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 30 May 2017 20:57:14 +0000 Subject: [Koha-bugs] [Bug 18704] File types limit in tools/ export.pl is causing issues with csv files generated by MS/Excel In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18704 --- Comment #2 from Nick Clemens --- Created attachment 63856 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=63856&action=edit Bug 18704 - File types limit in tools/export.pl is causing issues with csv files generated by MS/Excel To test: 1 - Save a csv of biblionumber from MS/Excel 2 - Attempt to export records using this file 3 - It fails (mimetype is appliction/vnd.ms-excel) 4 - Apply patch 5 - Try again 6 - It succeeds! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue May 30 22:57:26 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 30 May 2017 20:57:26 +0000 Subject: [Koha-bugs] [Bug 18704] File types limit in tools/ export.pl is causing issues with csv files generated by MS/Excel In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18704 Nick Clemens changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|gmcharlt at gmail.com |nick at bywatersolutions.com -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed May 31 02:38:26 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 31 May 2017 00:38:26 +0000 Subject: [Koha-bugs] [Bug 17602] Integrate support for ONeclickDigital/Recorded Books API In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17602 Srdjan Jankovic changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #63780|0 |1 is obsolete| | --- Comment #20 from Srdjan Jankovic --- Created attachment 63857 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=63857&action=edit Bug 17602 Add Oneclickdigital integration to Koha Add OneClickdigital to the users page in the public interface To Test: 1/ Apply all 3 patches 2/ Set the sysprefs to valid values (you will need a test account with Oneclickdigital) 3/ Try a search 4/ Login to the OPAC, try to place a hold, or check an item out 5/ Check the opac-user page, see if your items are showing on the oneclickdigital tab -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed May 31 07:20:45 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 31 May 2017 05:20:45 +0000 Subject: [Koha-bugs] [Bug 18704] File types limit in tools/ export.pl is causing issues with csv files generated by MS/Excel In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18704 Marc V?ron changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |veron at veron.ch -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed May 31 07:22:45 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 31 May 2017 05:22:45 +0000 Subject: [Koha-bugs] [Bug 17717] process_message_queue.pl: Can't locate Authen/CAS/Client/ Response/Failure.pm In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17717 --- Comment #30 from Katrin Fischer --- Did you run it manually in your package installation or using the standard cron.d entry? */15 * * * * root koha-foreach --enabled --email /usr/share/koha/bin/cronjobs/process_message_queue.pl Looking at the history of the bug a lot of people have run into it by now - I think there must be a difference in how you test. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed May 31 07:45:47 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 31 May 2017 05:45:47 +0000 Subject: [Koha-bugs] [Bug 18616] The "Add forgot password link to OPAC" should allow patrons to use their library card number in addition to username In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18616 --- Comment #2 from Marc V?ron --- Tested - patch works as advertised. Tiny issue: Comment on line 59 reads: # Find the borrower by his userid or email Can you change the comment to reflect the code change (and make it gender neutral)? Maybe something like: # Find patron by cardnumber, userid or email -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed May 31 08:20:19 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 31 May 2017 06:20:19 +0000 Subject: [Koha-bugs] [Bug 18700] Fix ungrammatical sentence In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18700 Marc V?ron changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |veron at veron.ch --- Comment #2 from Marc V?ron --- Tiny proposal from a non native speaker: --- Define the mapping between keywords and MARC fields. The keywords are used to find some data independently of the framework. --- Splitting the message into two sentences (one for the fact, one for the explanation) would improve translatability a little bit. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed May 31 08:34:06 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 31 May 2017 06:34:06 +0000 Subject: [Koha-bugs] [Bug 18226] Remove "use Test::DBIx::Class" instantiations' dangerous code duplication In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18226 Marc V?ron changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |veron at veron.ch --- Comment #23 from Marc V?ron --- Wanted to apply for testing Bug 18287 on top of this bug, but fails with: Bug 18226: [QA Follow-up] Remove further assumptions on branch count fatal: sha1 information is lacking or useless (t/db_dependent/01-test_dbic.t). -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed May 31 09:15:47 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 31 May 2017 07:15:47 +0000 Subject: [Koha-bugs] [Bug 17717] process_message_queue.pl: Can't locate Authen/CAS/Client/ Response/Failure.pm In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17717 --- Comment #31 from Julian Maurice --- I let the cron do it, as Chris suggested in comment 25. The only thing I modified in the cron entry is '*/15' to get it launched every minute -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed May 31 10:32:14 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 31 May 2017 08:32:14 +0000 Subject: [Koha-bugs] [Bug 18700] Fix ungrammatical sentence In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18700 Colin Campbell changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #63848|0 |1 is obsolete| | --- Comment #3 from Colin Campbell --- Created attachment 63858 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=63858&action=edit Revised to incorporate Marc's suggestion Marc's suggestion improves the text -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed May 31 10:37:00 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 31 May 2017 08:37:00 +0000 Subject: [Koha-bugs] [Bug 14610] Add ability to place article requests in Koha In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14610 Michael Kuhn changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |mik at adminkuhn.ch --- Comment #267 from Michael Kuhn --- It actually got (after 16.11) again into the release notes for Koha 17.05 ( https://koha-community.org/koha-17-05-released/ ) even if it is not a new feature. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed May 31 10:54:48 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 31 May 2017 08:54:48 +0000 Subject: [Koha-bugs] [Bug 18705] New: collections_tracking-table is missing index/ foreign key to items Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18705 Bug ID: 18705 Summary: collections_tracking-table is missing index/foreign key to items Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Circulation Assignee: koha-bugs at lists.koha-community.org Reporter: olli-antti.kivilahti at jns.fi QA Contact: testopia at bugs.koha-community.org CC: gmcharlt at gmail.com, kyle.m.hall at gmail.com This makes searches such as circ/pendingreserves.pl rather slow and very noticeable on HDDs -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed May 31 11:09:18 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 31 May 2017 09:09:18 +0000 Subject: [Koha-bugs] [Bug 18705] collections_tracking-table is missing index/ foreign key to items In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18705 --- Comment #1 from Olli-Antti Kivilahti --- Created attachment 63859 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=63859&action=edit Bug 18705 - collections_tracking-table is missing index/foreign key to items This makes searches such as circ/pendingreserves.pl rather slow and very noticeable on HDDs -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed May 31 11:09:31 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 31 May 2017 09:09:31 +0000 Subject: [Koha-bugs] [Bug 18705] collections_tracking-table is missing index/ foreign key to items In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18705 Olli-Antti Kivilahti changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Wed May 31 11:16:43 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 31 May 2017 09:16:43 +0000 Subject: [Koha-bugs] [Bug 18700] Fix ungrammatical sentence In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18700 Marc V?ron changed: What |Removed |Added ---------------------------------------------------------------------------- Patch complexity|--- |String patch -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed May 31 11:16:58 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 31 May 2017 09:16:58 +0000 Subject: [Koha-bugs] [Bug 18700] Fix ungrammatical sentence In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18700 --- Comment #4 from Marc V?ron --- Created attachment 63860 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=63860&action=edit Bug 18700 Fix grammar (data cannot be pluralized) data is a mass noun or plural of datum - datas is ungrammatical and jarring for a native speaker. Split the awkward sounding sentence into two for more clarity, thanks to Marc V?ron for the suggestion. Signed-off-by: Marc V?ron -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed May 31 11:17:54 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 31 May 2017 09:17:54 +0000 Subject: [Koha-bugs] [Bug 18700] Fix ungrammatical sentence In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18700 Marc V?ron changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #63858|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed May 31 11:30:10 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 31 May 2017 09:30:10 +0000 Subject: [Koha-bugs] [Bug 18700] Fix ungrammatical sentence In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18700 Marc V?ron changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed May 31 11:35:28 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 31 May 2017 09:35:28 +0000 Subject: [Koha-bugs] [Bug 18705] collections_tracking-table is missing index/ foreign key to items In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18705 Olli-Antti Kivilahti changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #63859|0 |1 is obsolete| | --- Comment #2 from Olli-Antti Kivilahti --- Created attachment 63861 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=63861&action=edit Bug 18705 - collections_tracking-table is missing index/foreign key to items This makes searches such as circ/pendingreserves.pl rather slow and very noticeable on HDDs -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Wed May 31 12:44:08 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 31 May 2017 10:44:08 +0000 Subject: [Koha-bugs] [Bug 12904] Force browser to load new javascript files after upgrade In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12904 Fridolin SOMERS changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |fridolin.somers at biblibre.co | |m --- Comment #79 from Fridolin SOMERS --- > RewriteRule ^(.*)_(.*).js$ $1.js [R=301,N,L] This rewrite rules are quite large, what about files that already contain an underscore ? I think we should use a more explicit separator like "_kohav" with rewrite : RewriteRule ^(.*)_kohav(.*).js. > + The syspref "Version" contains a dot (ie 16.1200037) meaning that files will have 2 dots, ie : ../datatables_16.1200037.js This may be a problem for some web-browsers like IE ? -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed May 31 13:00:55 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 31 May 2017 11:00:55 +0000 Subject: [Koha-bugs] [Bug 17240] Allow processes that rely on background jobs run in Plack mode In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17240 Fridolin SOMERS changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #63459|0 |1 is obsolete| | --- Comment #16 from Fridolin SOMERS --- Created attachment 63862 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=63862&action=edit Bug 17240 - Allow processes that rely on background jobs run in Plack mode - followup 3 Followup 3 If not running in background mode, items are not displayed in result page in tools/batchMod.pl. Also the number of items and fields are missing in message. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed May 31 13:04:31 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 31 May 2017 11:04:31 +0000 Subject: [Koha-bugs] [Bug 18226] Remove "use Test::DBIx::Class" instantiations' dangerous code duplication In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18226 --- Comment #24 from Marcel de Rooy --- (In reply to Marc V?ron from comment #23) > Wanted to apply for testing Bug 18287 on top of this bug, but fails with: > > Bug 18226: [QA Follow-up] Remove further assumptions on branch count > fatal: sha1 information is lacking or useless > (t/db_dependent/01-test_dbic.t). Applies fine with me, no conflicts or so. Did you apply the dependencies? 18285 and 18286 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed May 31 13:10:19 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 31 May 2017 11:10:19 +0000 Subject: [Koha-bugs] [Bug 17717] process_message_queue.pl: Can't locate Authen/CAS/Client/ Response/Failure.pm In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17717 Marcel de Rooy changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |m.de.rooy at rijksmuseum.nl --- Comment #32 from Marcel de Rooy --- Is there a difference between the standard koha-foreach with a sudo koha user and the sudo you added in your cron job ? Are the permissions of your koha user identical ? -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed May 31 13:33:48 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 31 May 2017 11:33:48 +0000 Subject: [Koha-bugs] [Bug 17717] process_message_queue.pl: Can't locate Authen/CAS/Client/ Response/Failure.pm In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17717 --- Comment #33 from Julian Maurice --- (In reply to Marcel de Rooy from comment #32) > Is there a difference between the standard koha-foreach with a sudo koha > user and the sudo you added in your cron job ? > Are the permissions of your koha user identical ? I'm not sure what you are talking about. I used the /etc/cron.d/koha-common shipped with the debian package, and I didn't change the permissions of the 'koha1-koha' user created by koha-create. I didn't modify the sudoers file either (http://paste.koha-community.org/435) -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed May 31 13:38:04 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 31 May 2017 11:38:04 +0000 Subject: [Koha-bugs] [Bug 17717] process_message_queue.pl: Can't locate Authen/CAS/Client/ Response/Failure.pm In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17717 --- Comment #34 from Julian Maurice --- More info: $ pmvers Authen::CAS::Client 0.07 $ pmvers Authen::CAS::Client::Response 0.03 $ perl -v This is perl 5, version 24, subversion 1 (v5.24.1) built for x86_64-linux-gnu-thread-multi $ lsb_release -ds Debian GNU/Linux 9.0 (stretch) -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed May 31 13:46:21 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 31 May 2017 11:46:21 +0000 Subject: [Koha-bugs] [Bug 17717] process_message_queue.pl: Can't locate Authen/CAS/Client/ Response/Failure.pm In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17717 --- Comment #35 from Marcel de Rooy --- And what about the difference between perl 5.22 and 5.24 ? -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed May 31 14:08:34 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 31 May 2017 12:08:34 +0000 Subject: [Koha-bugs] [Bug 17717] process_message_queue.pl: Can't locate Authen/CAS/Client/ Response/Failure.pm In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17717 --- Comment #36 from Julian Maurice --- In comment 23, Chris says: > With perl 5.22 with latest ubuntu, debian testing and above, etc have. > Something has changed in the way it deals with modules that have multiple > packages in them. and > This does only occur on perl 5.22 and up, so something changed in that. Since Debian testing have Perl 5.24 I assumed I could reproduce the problem with this version. I will test with ubuntu 16.10 which has Perl 5.22. Let's hope I reproduce the problem this time :) -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed May 31 14:13:44 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 31 May 2017 12:13:44 +0000 Subject: [Koha-bugs] [Bug 18262] Koha::Biblios - Remove GetBiblioData - part 1 In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18262 Owen Leonard changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Patch doesn't apply --- Comment #4 from Owen Leonard --- Jonathan I'll prioritize testing of this patch if you can rebase it. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed May 31 14:36:11 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 31 May 2017 12:36:11 +0000 Subject: [Koha-bugs] [Bug 17717] process_message_queue.pl: Can't locate Authen/CAS/Client/ Response/Failure.pm In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17717 --- Comment #37 from Julian Maurice --- Same with Ubuntu 16.10/Perl 5.22/koha-common 16.11.08 I'm running out of ideas... Does any other QAer want to try ? :) -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed May 31 14:40:56 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 31 May 2017 12:40:56 +0000 Subject: [Koha-bugs] [Bug 18262] Koha::Biblios - Remove GetBiblioData - part 1 In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18262 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Patch doesn't apply |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed May 31 14:41:00 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 31 May 2017 12:41:00 +0000 Subject: [Koha-bugs] [Bug 18262] Koha::Biblios - Remove GetBiblioData - part 1 In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18262 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #61058|0 |1 is obsolete| | --- Comment #5 from Jonathan Druart --- Created attachment 63863 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=63863&action=edit Bug 18262: Koha::Biblio - Remove GetBiblioData - part 1 Most of the time C4::Biblio::GetBiblioData is used to retrieve the title and/or the author of a bibliographic record. This patch replaces the easy occurrences of GetBiblioData, the ones where the 2 joins are needed, but only data from biblio and biblioitems table are. Test plan: It will be hard to test everything, I'd suggest a QAer to review this patch and confirm that the difference occurrences of GetBiblioData have been correctly replaced by calling Koha::Biblios->find or $biblio->bibioitem -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed May 31 15:07:12 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 31 May 2017 13:07:12 +0000 Subject: [Koha-bugs] [Bug 17717] process_message_queue.pl: Can't locate Authen/CAS/Client/ Response/Failure.pm In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17717 --- Comment #38 from Julian Maurice --- I can reproduce a similar error with this command: root at koha-yakkety:~# sudo -u koha1-koha PERL5LIB=. perl -MAuthen::CAS::Client -E 'say "Hi"' Can't locate Authen/CAS/Client.pm: ./Authen/CAS/Client.pm: Permission denied. BEGIN failed--compilation aborted. root at koha-yakkety:~# cd /tmp/ root at koha-yakkety:/tmp# sudo -u koha1-koha PERL5LIB=. perl -MAuthen::CAS::Client -E 'say "Hi"' Hi So, people that can reproduce the problem, could you please paste the output of the following command (at least the @INC part): # As root sudo -u perl -V -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed May 31 15:28:42 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 31 May 2017 13:28:42 +0000 Subject: [Koha-bugs] [Bug 18356] Prediction pattern wrong, skips years, for some year based frequencies In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18356 Marcel de Rooy changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |BLOCKED -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed May 31 15:28:54 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 31 May 2017 13:28:54 +0000 Subject: [Koha-bugs] [Bug 18607] Fix date calculations for monthly frequencies in Serials In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18607 Marcel de Rooy changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |BLOCKED -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed May 31 15:58:46 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 31 May 2017 13:58:46 +0000 Subject: [Koha-bugs] [Bug 18706] New: subfields to delete not disabled anymore in batch item modification Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18706 Bug ID: 18706 Summary: subfields to delete not disabled anymore in batch item modification Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: minor Priority: P5 - low Component: Tools Assignee: gmcharlt at gmail.com Reporter: fridolin.somers at biblibre.com QA Contact: testopia at bugs.koha-community.org In Tools > Batch item modification, one can click a checkbox to delete a subfield. This click use to disable the input to change the field value. This comes from the patch : Bug 13501: Move "Required" and checkbox after input/select Because input is found using JQuery next(). -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed May 31 15:58:53 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 31 May 2017 13:58:53 +0000 Subject: [Koha-bugs] [Bug 18706] subfields to delete not disabled anymore in batch item modification In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18706 Fridolin SOMERS changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|gmcharlt at gmail.com |fridolin.somers at biblibre.co | |m -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed May 31 16:13:19 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 31 May 2017 14:13:19 +0000 Subject: [Koha-bugs] [Bug 17717] process_message_queue.pl: Can't locate Authen/CAS/Client/ Response/Failure.pm In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17717 Tom?s Cohen Arazi changed: What |Removed |Added ---------------------------------------------------------------------------- Resolution|--- |WORKSFORME Status|Signed Off |RESOLVED --- Comment #39 from Tom?s Cohen Arazi --- Ok, I managed to reproduce the conditions that trigger the bug. GOOD NEWS: It is fixed in master, 16.11 and 16.05 already, as a side effect from bug 16733. The problem was in koha-foreach code, that is not using koha-shell but crafting its own env instead. To reproduce the problem, as a root user run: root$ echo $PERL5LIB root$ . /usr/share/koha/bin/koha-functions.sh root$ adjust_paths_dev_install kohadev root$ echo $PERL5LIB /home/vagrant/kohaclone So, if adjust_paths_dev_install is not ran, and the command is run by root, PERL5LIB is empty, and perl uses the fallback for include (i.e. '.'). This are the conditions in which cron.d/koha-common runs process_message_queue.pl. This happened in koha-foreach code, before bug 16733. This is the relevant code in debian/scripts/koha-foreach: for name in $(koha-list $listopts) do # Optionally use alternative paths for a dev install adjust_paths_dev_install $name cmd=`echo "$@" | sed -e s/__instancename__/${name}/g` ( exec 3>&1 sudo -u "$name-koha" \ env PERL5LIB=$PERL5LIB \ KOHA_CONF="/etc/koha/sites/$name/koha-conf.xml" \ ${cmd} 2>&1 >&3 | sed -e "s/^/$name: /" >&2 3>&- exec 3>&- ) | sed -e "s/^/$name: /" done So before the 16733 backport, PERL5LIB was incorrectly set. This script should definitely run koha-shell -c "${cmd}" $name instead of crafting all the environment variables. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed May 31 16:14:14 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 31 May 2017 14:14:14 +0000 Subject: [Koha-bugs] [Bug 14385] Extend OpacHiddenItems to allow specifying exempt borrower categories In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14385 --- Comment #21 from M. Tompsett --- Is anyone going to try to resurrect this? If not, I'll take a stab at it, because this is the LAST set of patches, I need to free myself from the shackles of customized, unsupported code. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed May 31 16:14:45 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 31 May 2017 14:14:45 +0000 Subject: [Koha-bugs] [Bug 18706] subfields to delete not disabled anymore in batch item modification In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18706 Fridolin SOMERS changed: What |Removed |Added ---------------------------------------------------------------------------- Patch complexity|--- |Trivial patch Status|NEW |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed May 31 16:14:48 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 31 May 2017 14:14:48 +0000 Subject: [Koha-bugs] [Bug 18706] subfields to delete not disabled anymore in batch item modification In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18706 --- Comment #1 from Fridolin SOMERS --- Created attachment 63864 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=63864&action=edit Bug 18706 - subfields to delete not disabled anymore in batch item modification In Tools > Batch item modification, one can click a checkbox to delete a subfield. This click use to disable the input to change the field value. This comes from the patch : Bug 13501: Move "Required" and checkbox after input/select Because input is found using JQuery next(). This patch replaces with $(this).parent().find("[name='field_value']"). Test plan : - Go to Tools > Batch item modification - Enter a barcode and submit - Click on a checkbox on a non-mandatory subfield => Without patch the input or select is not disabled => With patch the input or select is disabled - Submit => Check that subfield is deleted -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed May 31 16:15:04 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 31 May 2017 14:15:04 +0000 Subject: [Koha-bugs] [Bug 18706] subfields to delete not disabled anymore in batch item modification In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18706 --- Comment #2 from Fridolin SOMERS --- Created attachment 63865 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=63865&action=edit Bug 18706 - Remove useless Javascript Whe checking a subfield to be deleted, the code $(this).val($(this).siblings("[name='subfield']").val()); is useless, the checkbox already contains the subfield code : -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed May 31 16:23:54 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 31 May 2017 14:23:54 +0000 Subject: [Koha-bugs] [Bug 18707] New: Background jobs post disabled inputs Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18707 Bug ID: 18707 Summary: Background jobs post disabled inputs Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: major Priority: P5 - low Component: Tools Assignee: gmcharlt at gmail.com Reporter: fridolin.somers at biblibre.com QA Contact: testopia at bugs.koha-community.org For example, in Tools > Batch item modification input of deleted subfields are disabled. This form is posted using background job via JS code. Looks like this JS code converts a POST form into a GET URL, including inputs that are disabled : koha-tmpl/intranet-tmpl/prog/js/background-job-progressbar.js function submitBackgroundJob(f) { ... $(':input', f).each(function() { ... -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed May 31 16:23:58 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 31 May 2017 14:23:58 +0000 Subject: [Koha-bugs] [Bug 18708] New: Show itemBarcodeFallbackSearch results in a modal window Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18708 Bug ID: 18708 Summary: Show itemBarcodeFallbackSearch results in a modal window Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: ASSIGNED Severity: enhancement Priority: P5 - low Component: Circulation Assignee: oleonard at myacpl.org Reporter: oleonard at myacpl.org QA Contact: testopia at bugs.koha-community.org CC: gmcharlt at gmail.com, kyle.m.hall at gmail.com I propose to modify the template's handling of itemBarcodeFallbackSearch results so that they are displayed in a modal window. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed May 31 16:24:13 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 31 May 2017 14:24:13 +0000 Subject: [Koha-bugs] [Bug 18707] Background jobs post disabled inputs In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18707 Fridolin SOMERS changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |https://bugs.koha-community | |.org/bugzilla3/show_bug.cgi | |?id=18706 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed May 31 16:24:13 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 31 May 2017 14:24:13 +0000 Subject: [Koha-bugs] [Bug 18706] subfields to delete not disabled anymore in batch item modification In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18706 Fridolin SOMERS changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |https://bugs.koha-community | |.org/bugzilla3/show_bug.cgi | |?id=18707 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed May 31 16:24:28 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 31 May 2017 14:24:28 +0000 Subject: [Koha-bugs] [Bug 18707] Background jobs post disabled inputs In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18707 Fridolin SOMERS changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|gmcharlt at gmail.com |fridolin.somers at biblibre.co | |m -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed May 31 16:29:58 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 31 May 2017 14:29:58 +0000 Subject: [Koha-bugs] [Bug 18707] Background jobs post disabled inputs In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18707 Fridolin SOMERS changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff Patch complexity|--- |Trivial patch -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed May 31 16:30:01 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 31 May 2017 14:30:01 +0000 Subject: [Koha-bugs] [Bug 18707] Background jobs post disabled inputs In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18707 --- Comment #1 from Fridolin SOMERS --- Created attachment 63866 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=63866&action=edit Bug 18707 - Background jobs post disabled inputs For example, in Tools > Batch item modification input of deleted subfields are disabled. This form is posted using background job via JS code. Looks like this JS code converts a POST form into a GET URL, including inputs that are disabled : koha-tmpl/intranet-tmpl/prog/js/background-job-progressbar.js function submitBackgroundJob(f) { ... $(':input', f).each(function() { ... This patch add a :enabled to selector Test plan : -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed May 31 16:31:31 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 31 May 2017 14:31:31 +0000 Subject: [Koha-bugs] [Bug 18692] When SMS is enabled the OPAC messaging table is misaligned In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18692 Lari Taskula changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |lari.taskula at jns.fi --- Comment #4 from Lari Taskula --- I'm not sure I understood the original problem, perhaps screenshots would help. Is message_transports / message_transport_types table properly configured? Anyway I actually wanted to comment that I also noticed "sms" is missing "-" in the messaging preferences table both in OPAC and staff when it has no sms transport configured in message_transports database table. The same for "phone". To my understanding, message_transports table defines availability of transport options for the messaging preferences table. sms and phone should not have checkboxes when they are removed from those options. This feature used to exist but for some reason the "-" got completely removed to fix misalignment issues. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed May 31 16:32:29 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 31 May 2017 14:32:29 +0000 Subject: [Koha-bugs] [Bug 18697] Fix date calculations for day/week frequencies in Serials In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18697 Marcel de Rooy changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #63846|0 |1 is obsolete| | --- Comment #3 from Marcel de Rooy --- Created attachment 63867 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=63867&action=edit Bug 18697: Fix date calculations for weekly frequencies in Serials Same solution applied as in bug 18356/18607. Consistency++ The code in _get_next_date_week is again very similar to the code in _get_next_date_month or _get_next_date_year. I will not merge them here, but we could consider that in the future. Code in GetFictiveIssueNo has been adjusted similarly to month and year. Test plan: [1] Do not apply this patch. Create a subscription for 3/week. When the first issue date is on a Saturday or Sunday, the intervals in the prediction pattern are 0,0,7,0,0,7,etc. Starting on Wed-Fri 1,1,5,etc. Starting on Mon-Tue 2,2,3,etc. [2] Apply this patch. Check again. The interval should be always 2,2,3 now and no longer depend on the day_of_week of first issue date. [3] Check another weekly frequency with multiple units per issue. Say 1 issue/3 weeks. Signed-off-by: Marcel de Rooy -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed May 31 16:32:33 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 31 May 2017 14:32:33 +0000 Subject: [Koha-bugs] [Bug 18697] Fix date calculations for day/week frequencies in Serials In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18697 Marcel de Rooy changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #63847|0 |1 is obsolete| | --- Comment #4 from Marcel de Rooy --- Created attachment 63868 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=63868&action=edit Bug 18697: Adjusting unit tests for weekly serial frequencies Corrections and added unit tests following the changes of the first patch. GetFictiveIssueNumber.t: New subtest for weekly frequencies. GetNextDate.t: Correcting a few dates one day. If we use 2/week, we will calculate an interval of 3 days and correct with 4 days at the end of the cycle. The connection with firstacqui is not relevant anymore. Test plan: [1] Run t/db_dependent/Serials/GetFictiveIssueNumber.t [2] Run t/db_dependent/Serials/GetNextDate.t Signed-off-by: Marcel de Rooy -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed May 31 16:32:37 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 31 May 2017 14:32:37 +0000 Subject: [Koha-bugs] [Bug 18697] Fix date calculations for day/week frequencies in Serials In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18697 --- Comment #5 from Marcel de Rooy --- Created attachment 63869 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=63869&action=edit Bug 18697: Fix date calculation for dayly frequencies in Serials The changes in _get_next_date_day are actually only cosmetic. The sub now reads exactly the same as its counterparts for other units, but the results are exactly the same as before. In GetFictiveIssueNumber we now call _delta_units for each type of unit. The two Delta_Days calls are moved to _delta_units. Note that this also is a cosmetic change; results should be exactly the same. Test plan: [1] Edit a subscription. Test predication pattern for some daily freq. [2] Run t/db_dependent/GetNextDate.t Signed-off-by: Marcel de Rooy -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed May 31 16:32:40 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 31 May 2017 14:32:40 +0000 Subject: [Koha-bugs] [Bug 18697] Fix date calculations for day/week frequencies in Serials In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18697 --- Comment #6 from Marcel de Rooy --- Created attachment 63870 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=63870&action=edit Bug 18697: Adjusting unit tests for dayly serial frequencies No changes were needed for GetNextDate.t. In GetFictiveIssueNumber.t we add a subtest for daily frequencies. Test plan: [1] Run t/db_dependent/Serials/GetFictiveIssueNumber.t Signed-off-by: Marcel de Rooy -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed May 31 16:32:44 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 31 May 2017 14:32:44 +0000 Subject: [Koha-bugs] [Bug 18697] Fix date calculations for day/week frequencies in Serials In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18697 --- Comment #7 from Marcel de Rooy --- Created attachment 63871 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=63871&action=edit Bug 18697: Final polishing GetFictiveIssueNumber: Returns undef instead of 0 for irregular frequencies. Also added to POD. Removed unused variable $wkno. Adding a return makes the if(unit) unneeded. Replaced (a+b)/b by 1+a/b. _delta_units: Added a comment about its parameters. GetFictiveIssueNumber.t: Adjusted the tests for irregular frequencies accordingly. Test plan: [1] Run t/db_dependent/Serials/GetFictiveIssueNumber.t [2] Run t/db_dependent/Serials/GetNextDate.t Signed-off-by: Marcel de Rooy -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed May 31 16:33:40 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 31 May 2017 14:33:40 +0000 Subject: [Koha-bugs] [Bug 18692] When SMS is enabled the OPAC messaging table is misaligned In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18692 --- Comment #5 from Lari Taskula --- Created attachment 63872 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=63872&action=edit Bug 18692: (follow-up) Fix misplaced columns and add this feature for phone as well Fixes misplaced columns introduced by previous patch and adds the "-" for phone transport type. To test: 1. Set SMSSendDriver system preference on 2. Go to intra and OPAC messaging preferences 3. By default you should see checkboxes for all messages for SMS 4. Ensure columns are not misplaced (pushing one column too much to the right) 5. Delete sms method from one of the messages in message_transports table 6. Observe that "-" is displayed instead of checkbox for that message for SMS 7. Repeat same for TalkingTechItivaPhoneNotification system preference. By default it may not have transports in message_transports, so make sure to assign some in order to have the checkboxes visible. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed May 31 16:33:55 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 31 May 2017 14:33:55 +0000 Subject: [Koha-bugs] [Bug 18707] Background jobs post disabled inputs In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18707 Fridolin SOMERS changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |ASSIGNED --- Comment #2 from Fridolin SOMERS --- submitBackgroundJob is used by : offline_circ/ process_koc.tt tools/ batch_record_modification.tt batchMod-del.tt batchMod-edit.tt manage-marc-import.tt stage-marc-import.tt Disabled input can exist in batchMod, what about the others ? -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed May 31 16:36:46 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 31 May 2017 14:36:46 +0000 Subject: [Koha-bugs] [Bug 18607] Fix date calculations for monthly frequencies in Serials In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18607 Marcel de Rooy changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #63843|0 |1 is obsolete| | --- Comment #5 from Marcel de Rooy --- Created attachment 63873 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=63873&action=edit Bug 18607: Fix date calculations for monthly frequencies in Serials Similarly to the solution of bug 18356, this patch fixes the date calculation for monthly frequencies. The calculation in GetFictiveIssueNumber now makes use of the new _delta_units sub introduced on bug 18356. The calculation in _get_next_date_month is also very similar to the one in _get_next_date_year. I do not merge them here, but this could still be considered later on. At least consistency is achieved now between both routines. The connection with firstacquidate has been cut thru just like for year units. Test plan: [1] Without this patch, look at the prediction pattern for a subscription with first issue on Feb 21 and 5 per month. The first issues will be 21, 22, 23, 24, 25. Then jumping to 21, 23, 25, etc. [2] Apply the patch. Look at the same prediction pattern. You will now see 6 day intervals and a new cycle starting on the 21st. So Feb 21, 27, Mar 5, 11, 17 and Mar 21, 27, etc. [3] Edit an subscription. Try a few other monthly frequencies. [4] The next patch adjusts related unit tests. Signed-off-by: Marcel de Rooy -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed May 31 16:36:47 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 31 May 2017 14:36:47 +0000 Subject: [Koha-bugs] [Bug 18709] New: koha-foreach should use koha-shell, internally Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18709 Bug ID: 18709 Summary: koha-foreach should use koha-shell, internally Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: normal Priority: P5 - low Component: Command-line Utilities Assignee: gmcharlt at gmail.com Reporter: tomascohen at gmail.com QA Contact: testopia at bugs.koha-community.org CC: robin at catalyst.net.nz Highlighted by bug 17717, koha-foreach is currently taking care of crafting all env variables and call sudo to run the required tasks. We should definitely call koha-shell in there, and have a single place in which to take care of this logic. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed May 31 16:36:50 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 31 May 2017 14:36:50 +0000 Subject: [Koha-bugs] [Bug 18607] Fix date calculations for monthly frequencies in Serials In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18607 Marcel de Rooy changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #63844|0 |1 is obsolete| | --- Comment #6 from Marcel de Rooy --- Created attachment 63874 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=63874&action=edit Bug 18607: Adjusting unit tests for monthly serial frequencies The changes in the first patch require some corrections as well as additional test cases. GetNextDate.t: Since the calculation for multiple issues per unit has slightly changed, a few dates (day 15 or day 16) have been changed in the unit test; when we use 2/month, the algorithm now always adds 15 days. Added a few test descriptions in this regard too. GetFictiveIssueNumber.t: Add the monthly subtest with two test cases. In the first case we tests multiple units per issue, and in the second case we test multiple issues per unit (month). Test plan: [1] Run t/db_dependent/Serials/GetFictiveIssueNumber.t [2] Run t/db_dependent/Serials/GetNextDate.t Signed-off-by: Marcel de Rooy -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed May 31 16:37:06 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 31 May 2017 14:37:06 +0000 Subject: [Koha-bugs] [Bug 18709] koha-foreach should use koha-shell, internally In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18709 Tom?s Cohen Arazi changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |https://bugs.koha-community | |.org/bugzilla3/show_bug.cgi | |?id=17717 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed May 31 16:37:06 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 31 May 2017 14:37:06 +0000 Subject: [Koha-bugs] [Bug 17717] process_message_queue.pl: Can't locate Authen/CAS/Client/ Response/Failure.pm In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17717 Tom?s Cohen Arazi changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |https://bugs.koha-community | |.org/bugzilla3/show_bug.cgi | |?id=18709 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed May 31 16:37:54 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 31 May 2017 14:37:54 +0000 Subject: [Koha-bugs] [Bug 18356] Prediction pattern wrong, skips years, for some year based frequencies In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18356 Marcel de Rooy changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #63784|0 |1 is obsolete| | --- Comment #8 from Marcel de Rooy --- Created attachment 63875 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=63875&action=edit Bug 18356: Extend GetNextDate.t, add GetFictiveIssueNumber.t (unit=year) This patch deals with tests for yearly frequencies. Adjust/extend GetNextDate.t: [1] Adjust mixup of units/issues in a description. [2] Add testing +2 years on 29-2 of leap year for freq 1 issue/2 years. [3] Add tests for freq 9 issues/year. Add GetFictiveIssueNumber.t: [1] Two subtests are provided for irregular frequencies (very trivial) and for year frequencies (with four specific test cases). Test plan: [1] Run t/db_dependent/Serials/GetNextDate.t [2] Run t/db_dependent/Serials/GetFictiveIssueNumber.t Note: Without the second patch both tests should fail. This shows the need of the adjustments in the second patch. Signed-off-by: Marcel de Rooy -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed May 31 16:37:59 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 31 May 2017 14:37:59 +0000 Subject: [Koha-bugs] [Bug 18356] Prediction pattern wrong, skips years, for some year based frequencies In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18356 Marcel de Rooy changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #63785|0 |1 is obsolete| | --- Comment #9 from Marcel de Rooy --- Created attachment 63876 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=63876&action=edit Bug 18356: Fix date calculations for yearly frequencies in Serials The problem as described on BZ 18356 is a combination of an error in GetFictiveIssueNumber and GetNextDate for unit==year. [1] In GetNextDate the Add_Delta_YM calculation should be applied only to frequencies based on years per unit. In the case of multiple units per year we calculate the number of days to add. And if we have reached the end of a cycle, we correct the rounding applied in the cycle. NOTE 1: We obsolete the idea here of rebasing dates on firstacqui. In case of manual adjustments, we probably do not want it. And otherwise we do not need it anymore due to the correction at the end of a cycle. NOTE 2: The calls to Add_Delta_YM are intentionally not corrected for leap years. Say you start at 2016-02-29. If you use 1/yr or 1/2yr, you will switch to the Feb 28th in the following years. In 2020 there will be no switch to Feb 29 again; if someone should need it, please use a manual adjustment. This is probably highly exceptional. [2] In GetFictiveIssueNumber the year should be decreased by one if you have more units per year and you did not yet reach firstacqui day and month. This affects calculations in GetNextDate with irregularities. NOTE 1: I added a wrapper around Date::Calc::N_Delta_YMD in order to improve its results; this will especially be needed when we use it later for month units. NOTE 2: In case of manual adjustments this calculation does not really make sense. Another report should deal with improving irregularities. Test plan: [1] Verify that both GetNextDate.t as well as GetFictiveIssueNumber.t pass. [2] Look at the prediction pattern for a few frequencies. For example: 1 iss/y, 1 iss/2y, 5 iss/y. Signed-off-by: Marcel de Rooy -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed May 31 16:40:11 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 31 May 2017 14:40:11 +0000 Subject: [Koha-bugs] [Bug 18356] Prediction pattern wrong, skips years, for some year based frequencies In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18356 Marcel de Rooy changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |https://bugs.koha-community | |.org/bugzilla3/show_bug.cgi | |?id=18607 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed May 31 16:40:11 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 31 May 2017 14:40:11 +0000 Subject: [Koha-bugs] [Bug 18607] Fix date calculations for monthly frequencies in Serials In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18607 Marcel de Rooy changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |https://bugs.koha-community | |.org/bugzilla3/show_bug.cgi | |?id=18356 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed May 31 16:40:21 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 31 May 2017 14:40:21 +0000 Subject: [Koha-bugs] [Bug 18356] Prediction pattern wrong, skips years, for some year based frequencies In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18356 Marcel de Rooy changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |https://bugs.koha-community | |.org/bugzilla3/show_bug.cgi | |?id=18697 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed May 31 16:40:21 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 31 May 2017 14:40:21 +0000 Subject: [Koha-bugs] [Bug 18697] Fix date calculations for day/week frequencies in Serials In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18697 Marcel de Rooy changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |https://bugs.koha-community | |.org/bugzilla3/show_bug.cgi | |?id=18356 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed May 31 16:40:44 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 31 May 2017 14:40:44 +0000 Subject: [Koha-bugs] [Bug 18356] Prediction pattern wrong, skips years, for some year based frequencies In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18356 Marcel de Rooy changed: What |Removed |Added ---------------------------------------------------------------------------- Status|BLOCKED |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed May 31 16:43:57 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 31 May 2017 14:43:57 +0000 Subject: [Koha-bugs] [Bug 18710] New: Wrong subfield modified in batch item modification Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18710 Bug ID: 18710 Summary: Wrong subfield modified in batch item modification Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: major Priority: P5 - low Component: Tools Assignee: gmcharlt at gmail.com Reporter: fridolin.somers at biblibre.com QA Contact: testopia at bugs.koha-community.org In Tools > Batch item modification, one can modify or delete a subfield. When deleting a subfield et modifying another, the wrong subfield gets modified. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed May 31 16:44:08 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 31 May 2017 14:44:08 +0000 Subject: [Koha-bugs] [Bug 18710] Wrong subfield modified in batch item modification In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18710 Fridolin SOMERS changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|gmcharlt at gmail.com |fridolin.somers at biblibre.co | |m -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed May 31 16:44:22 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 31 May 2017 14:44:22 +0000 Subject: [Koha-bugs] [Bug 18710] Wrong subfield modified in batch item modification In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18710 Fridolin SOMERS changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |baptiste.wojtkowski at biblibr | |e.com -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed May 31 16:44:28 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 31 May 2017 14:44:28 +0000 Subject: [Koha-bugs] [Bug 18607] Fix date calculations for monthly frequencies in Serials In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18607 Marcel de Rooy changed: What |Removed |Added ---------------------------------------------------------------------------- Status|BLOCKED |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed May 31 16:45:40 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 31 May 2017 14:45:40 +0000 Subject: [Koha-bugs] [Bug 18697] Fix date calculations for day/week frequencies in Serials In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18697 Marcel de Rooy changed: What |Removed |Added ---------------------------------------------------------------------------- Patch complexity|--- |Small patch -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed May 31 16:45:48 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 31 May 2017 14:45:48 +0000 Subject: [Koha-bugs] [Bug 18697] Fix date calculations for day/week frequencies in Serials In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18697 Marcel de Rooy changed: What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed May 31 16:47:49 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 31 May 2017 14:47:49 +0000 Subject: [Koha-bugs] [Bug 18697] Fix date calculations for day/week frequencies in Serials In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18697 --- Comment #8 from Marcel de Rooy --- Note for testers: As you can read in the commit messages, the fix mainly concerns weekly frequencies. The daily frequencies work fine; the code is only changed to make it more consistent with week/month/year. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed May 31 16:48:23 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 31 May 2017 14:48:23 +0000 Subject: [Koha-bugs] [Bug 18607] Fix date calculations for monthly frequencies in Serials In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18607 Marcel de Rooy changed: What |Removed |Added ---------------------------------------------------------------------------- Patch complexity|--- |Small patch -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed May 31 16:56:19 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 31 May 2017 14:56:19 +0000 Subject: [Koha-bugs] [Bug 18708] Show itemBarcodeFallbackSearch results in a modal window In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18708 --- Comment #1 from Owen Leonard --- Created attachment 63877 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=63877&action=edit Bug 18708 - Show itemBarcodeFallbackSearch results in a modal window This patch modifies the circulation template so that itemBarcodeFallbackSearch results show in a modal window. To test, enable the itemBarcodeFallbackSearch system preference and open a patron's account in circulation. - Submit a string which will return search results. When the page reloads a modal should display showing a table of title search results. - Test the "Check out" button and confirm that the correct item is submitted. - Test closing the modal and re-displaying it using the new "Show matching titles" button. - Confirm that the "Add record using fast cataloging" button still works correctly. - Submit a string which will return no results. No modal window should display, and only the "Add record" button should appear. - Confirm that normal checkout works correctly. - Test with itemBarcodeFallbackSearch disabled, and with a user who lacks Fast Cataloging permission. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed May 31 16:56:17 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 31 May 2017 14:56:17 +0000 Subject: [Koha-bugs] [Bug 18708] Show itemBarcodeFallbackSearch results in a modal window In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18708 Owen Leonard changed: What |Removed |Added ---------------------------------------------------------------------------- Patch complexity|--- |Small patch Status|ASSIGNED |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed May 31 16:57:28 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 31 May 2017 14:57:28 +0000 Subject: [Koha-bugs] [Bug 17499] Koha objects for messaging preferences In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17499 Lari Taskula changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed May 31 16:57:31 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 31 May 2017 14:57:31 +0000 Subject: [Koha-bugs] [Bug 17499] Koha objects for messaging preferences In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17499 --- Comment #32 from Lari Taskula --- Created attachment 63878 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=63878&action=edit Bug 17499: (follow-up) Bugfix for validation, 2 Remove duplicate validation for digest availability. This is already checked in $preference->validate(). Also prevents a crash when patron has messaging transport type selected for a message for which it should not be available. This patch logs it with as a warning, and only throws an exception when attempting to set it. To test: 1. prove t/db_dependent/Koha/Patron/Message/* -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed May 31 17:04:27 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 31 May 2017 15:04:27 +0000 Subject: [Koha-bugs] [Bug 18710] Wrong subfield modified in batch item modification In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18710 Fridolin SOMERS changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on| |18706, 18707 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18706 [Bug 18706] subfields to delete not disabled anymore in batch item modification https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18707 [Bug 18707] Background jobs post disabled inputs -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed May 31 17:04:27 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 31 May 2017 15:04:27 +0000 Subject: [Koha-bugs] [Bug 18706] subfields to delete not disabled anymore in batch item modification In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18706 Fridolin SOMERS changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |18710 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18710 [Bug 18710] Wrong subfield modified in batch item modification -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed May 31 17:04:27 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 31 May 2017 15:04:27 +0000 Subject: [Koha-bugs] [Bug 18707] Background jobs post disabled inputs In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18707 Fridolin SOMERS changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |18710 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18710 [Bug 18710] Wrong subfield modified in batch item modification -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed May 31 17:04:59 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 31 May 2017 15:04:59 +0000 Subject: [Koha-bugs] [Bug 18710] Wrong subfield modified in batch item modification In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18710 --- Comment #1 from Fridolin SOMERS --- Needs Bug 18706 and Bug 18707 to be tested. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed May 31 17:12:07 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 31 May 2017 15:12:07 +0000 Subject: [Koha-bugs] [Bug 18710] Wrong subfield modified in batch item modification In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18710 Fridolin SOMERS changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff Patch complexity|--- |Trivial patch -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed May 31 17:12:10 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 31 May 2017 15:12:10 +0000 Subject: [Koha-bugs] [Bug 18710] Wrong subfield modified in batch item modification In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18710 --- Comment #2 from Fridolin SOMERS --- Created attachment 63879 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=63879&action=edit Bug 18710 - Wrong subfield modified in batch item modification In Tools > Batch item modification, one can modify or delete a subfield. When deleting a subfield et modifying another, the wrong subfield gets modified. This is caused by the fact that disabled inputs are not posted in form. So for a subfield to delete : Input name=field_value is not posted. But input name=subfield is posted with subfield code. So these 2 arrays does not have the same size : my @subfields = $input->multi_param('subfield'); my @values = $input->multi_param('field_value'); For exemple, deleting $2, not changing $u and modidying $v will modify $u with value for $v o_O This patch correts but setting disabled all inputs of a deleted subfield : field_value, tag, subfield and mandatory. Like it was not present in the form. Test plan : - Go to Tools > Batch item modification - Enter a barcode and submit - Lets say there are subfields : $2 (not mandatory), $u and $v - Check the subfield $2 to be deleted => $2 input is disabled - Enter a text in $v - Submit the form => Without patch, the text for $v gets into $u => With patch, the text for $v gets into $v - Check the subfield $2 is well deleted -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed May 31 17:14:28 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 31 May 2017 15:14:28 +0000 Subject: [Koha-bugs] [Bug 18710] Wrong subfield modified in batch item modification In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18710 --- Comment #3 from Fridolin SOMERS --- This bug also appears with no background job Bug 17240. We use this for nginx + plack -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed May 31 17:20:48 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 31 May 2017 15:20:48 +0000 Subject: [Koha-bugs] [Bug 18710] Wrong subfield modified in batch item modification In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18710 --- Comment #4 from Fridolin SOMERS --- Created attachment 63880 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=63880&action=edit Bug 18710 - batchMod-edit.tt is missing form end tag -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed May 31 17:23:17 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 31 May 2017 15:23:17 +0000 Subject: [Koha-bugs] [Bug 18616] The "Add forgot password link to OPAC" should allow patrons to use their library card number in addition to username In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18616 --- Comment #3 from David Kuhn --- Created attachment 63881 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=63881&action=edit Updated comment in code to reflect the change (and make gender neutral). -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed May 31 17:27:22 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 31 May 2017 15:27:22 +0000 Subject: [Koha-bugs] [Bug 17499] Koha objects for messaging preferences In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17499 Lari Taskula changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |ASSIGNED --- Comment #33 from Lari Taskula --- Removing Needs Signoff status, I still noticed some bugs when using this together with REST API, will also attach tests for the latest patch. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed May 31 20:18:02 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 31 May 2017 18:18:02 +0000 Subject: [Koha-bugs] [Bug 18616] The "Add forgot password link to OPAC" should allow patrons to use their library card number in addition to username In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18616 Marc V?ron changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #63855|0 |1 is obsolete| | --- Comment #4 from Marc V?ron --- Created attachment 63882 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=63882&action=edit Bug 18616 - The "Add forgot password link to OPAC" should allow patrons to use their library card number in addition to username Allow patrons to enter either their library card number or user name in the "Log in" box for password recovery. Most patrons at our library use their card number to log in and are unaware of what their userid is. However there are some who have set a customized userid and would prefer to use that. This patch would allow either to be entered for password recovery. To test: 1. Enable the password recovery feature. 2. In the OPAC, click on "Forgot you password?" link and enter a valid library card number. 3. The error message "No account found with the provided information" appears. 4. Apply the patch. 5. Repeat step 2. The recovery email is now sent. Followed test plan, works as expected. Signed-off-by: Marc V?ron -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed May 31 20:19:10 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 31 May 2017 18:19:10 +0000 Subject: [Koha-bugs] [Bug 18616] The "Add forgot password link to OPAC" should allow patrons to use their library card number in addition to username In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18616 Marc V?ron changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #63881|0 |1 is obsolete| | --- Comment #5 from Marc V?ron --- Created attachment 63883 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=63883&action=edit Updated comment in code to reflect the change (and make gender neutral). https://bugs.koha-community.org/show_bug.cgi?id=18616 Signed-off-by: Marc V?ron -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed May 31 20:19:30 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 31 May 2017 18:19:30 +0000 Subject: [Koha-bugs] [Bug 18616] The "Add forgot password link to OPAC" should allow patrons to use their library card number in addition to username In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18616 Marc V?ron changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed May 31 20:29:20 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 31 May 2017 18:29:20 +0000 Subject: [Koha-bugs] [Bug 18546] Unhide the 'Hide window' link in OPAC cart In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18546 Marc V?ron changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #63854|0 |1 is obsolete| | --- Comment #7 from Marc V?ron --- Created attachment 63884 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=63884&action=edit Bug 18546 - Unhide the 'Hide window' link in OPAC cart In OPAC cart, the link 'Hide window' is hidden because of a conflict with bootstrap css. This patch replaces the sprites for the toolbar with Fafamfam icons to make the 'Hide window' link visible. (Amended for comment #5 / 2017-05-31 mv) -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed May 31 20:39:26 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 31 May 2017 18:39:26 +0000 Subject: [Koha-bugs] [Bug 18546] Unhide the 'Hide window' link in OPAC cart In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18546 Owen Leonard changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off Patch complexity|--- |Small patch -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed May 31 20:39:29 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 31 May 2017 18:39:29 +0000 Subject: [Koha-bugs] [Bug 18546] Unhide the 'Hide window' link in OPAC cart In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18546 Owen Leonard changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #63884|0 |1 is obsolete| | --- Comment #8 from Owen Leonard --- Created attachment 63885 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=63885&action=edit [SIGNED-OFF] Bug 18546 - Unhide the 'Hide window' link in OPAC cart In OPAC cart, the link 'Hide window' is hidden because of a conflict with bootstrap css. This patch replaces the sprites for the toolbar with Fafamfam icons to make the 'Hide window' link visible. (Amended for comment #5 / 2017-05-31 mv) Signed-off-by: Owen Leonard -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed May 31 20:45:33 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 31 May 2017 18:45:33 +0000 Subject: [Koha-bugs] [Bug 18295] C4::Items - Remove get_itemnumbers_of In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18295 --- Comment #5 from Josef Moravec --- you can probably remove import of C4::Items from labels/label-item-search.pl, the only one imported routine GetItemInfosOf was removed in refactored code... Otherwise everything looks OK -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed May 31 20:47:23 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 31 May 2017 18:47:23 +0000 Subject: [Koha-bugs] [Bug 18295] C4::Items - Remove get_itemnumbers_of In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18295 --- Comment #6 from Josef Moravec --- (In reply to Josef Moravec from comment #5) > you can probably remove import of C4::Items from > labels/label-item-search.pl, the only one imported routine GetItemInfosOf > was removed in refactored code... > Now looking to bug 18296, you are removing it here, so ok, I am signing of ;) -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed May 31 20:48:36 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 31 May 2017 18:48:36 +0000 Subject: [Koha-bugs] [Bug 18285] Koha::Database schema cache accessors In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18285 Josef Moravec changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #62967|0 |1 is obsolete| | --- Comment #4 from Josef Moravec --- Created attachment 63886 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=63886&action=edit [SIGNED-OFF] Bug 18295: C4::Items - get_itemnumbers_of The code from scripts and subroutines using this subroutine was not very elegant. Most of the time the code was unnecessarily complex. This patch removes this subroutine and adapt the code to use Koha::Items instead. 1. C4::Items::get_hostitemnumbers_of I did not understand why the code was so complicated, it seems that we only want to know if a given item has a given biblionumber 2. cataloguing/merge.pl We want to retrieve the itemnumber for a given biblio. We could also have done that with: Koha::Biblios->find( $biblionumber )->items; 3. labels/label-item-search.pl We want to loop over the items for a given biblio, no need to use get_itemnumbers_of and GetItemInfosOf. We just need to use: Koha::Items->search({ biblionumber => $biblionumber }) 4. reserve/request.pl We want to retrieve the itemnumbers of the biblio's items We could also have done that with: Koha::Biblios->find( $biblionumber )->items->get_column('itemnumber'); Test plan: 1.You need to create analytical record relationships ( EasyAnalyticalRecords needs to be set). Link an item to a biblio using the 'Edit > Link to host item' menu from the biblio detail page. >From the staff interface place a hold on the biblio. You should see the items from the biblio and the one you just linked 2. Merge two bibliographic records (with items), the resulting record should contain items from both original records 3. Create a new label batch, edit it. Add items to this batch ('Add items' button). Fill the input with a barcode. You should see all the items of a biblio. Signed-off-by: Josef Moravec -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed May 31 20:49:57 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 31 May 2017 18:49:57 +0000 Subject: [Koha-bugs] [Bug 18285] Koha::Database schema cache accessors In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18285 Josef Moravec changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |josef.moravec at gmail.com Attachment #63886|0 |1 is obsolete| | --- Comment #5 from Josef Moravec --- Comment on attachment 63886 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=63886 [SIGNED-OFF] Bug 18295: C4::Items - get_itemnumbers_of Sorry wrong bug number -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed May 31 20:50:19 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 31 May 2017 18:50:19 +0000 Subject: [Koha-bugs] [Bug 18285] Koha::Database schema cache accessors In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18285 Josef Moravec changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #62967|1 |0 is obsolete| | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed May 31 20:50:28 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 31 May 2017 18:50:28 +0000 Subject: [Koha-bugs] [Bug 18285] Koha::Database schema cache accessors In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18285 Josef Moravec changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed May 31 20:51:03 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 31 May 2017 18:51:03 +0000 Subject: [Koha-bugs] [Bug 18285] Koha::Database schema cache accessors In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18285 Josef Moravec changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed May 31 20:51:46 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 31 May 2017 18:51:46 +0000 Subject: [Koha-bugs] [Bug 18295] C4::Items - Remove get_itemnumbers_of In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18295 Josef Moravec changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #63111|0 |1 is obsolete| | --- Comment #7 from Josef Moravec --- Created attachment 63887 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=63887&action=edit [SIGNED-OFF] Bug 18295: C4::Items - get_itemnumbers_of The code from scripts and subroutines using this subroutine was not very elegant. Most of the time the code was unnecessarily complex. This patch removes this subroutine and adapt the code to use Koha::Items instead. 1. C4::Items::get_hostitemnumbers_of I did not understand why the code was so complicated, it seems that we only want to know if a given item has a given biblionumber 2. cataloguing/merge.pl We want to retrieve the itemnumber for a given biblio. We could also have done that with: Koha::Biblios->find( $biblionumber )->items; 3. labels/label-item-search.pl We want to loop over the items for a given biblio, no need to use get_itemnumbers_of and GetItemInfosOf. We just need to use: Koha::Items->search({ biblionumber => $biblionumber }) 4. reserve/request.pl We want to retrieve the itemnumbers of the biblio's items We could also have done that with: Koha::Biblios->find( $biblionumber )->items->get_column('itemnumber'); Test plan: 1.You need to create analytical record relationships ( EasyAnalyticalRecords needs to be set). Link an item to a biblio using the 'Edit > Link to host item' menu from the biblio detail page. >From the staff interface place a hold on the biblio. You should see the items from the biblio and the one you just linked 2. Merge two bibliographic records (with items), the resulting record should contain items from both original records 3. Create a new label batch, edit it. Add items to this batch ('Add items' button). Fill the input with a barcode. You should see all the items of a biblio. Signed-off-by: Josef Moravec https://bugs.koha-community.org/show_bug.cgi?id=18285 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed May 31 20:51:42 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 31 May 2017 18:51:42 +0000 Subject: [Koha-bugs] [Bug 18295] C4::Items - Remove get_itemnumbers_of In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18295 Josef Moravec changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed May 31 21:07:28 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 31 May 2017 19:07:28 +0000 Subject: [Koha-bugs] [Bug 18296] C4::Items - Remove GetItemInfosOf In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18296 Josef Moravec changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed May 31 21:07:31 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 31 May 2017 19:07:31 +0000 Subject: [Koha-bugs] [Bug 18296] C4::Items - Remove GetItemInfosOf In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18296 Josef Moravec changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #61226|0 |1 is obsolete| | --- Comment #3 from Josef Moravec --- Created attachment 63888 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=63888&action=edit [SIGNED-OFF] Bug 18296: C4::Items - Remove GetItemInfosOf At this point this subroutine is only used once, from reserve/request.pl. Since we already have the items, it's easy to populate the different hashes as the rest of the code is expecting it. Test plan: You need to create analytical record relationships ( EasyAnalyticalRecords needs to be set). Link an item to a biblio using the 'Edit > Link to host item' menu from the biblio detail page. >From the staff interface place a hold on the biblio. You should see the items from the biblio and the one you just linked Signed-off-by: Josef Moravec -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed May 31 21:23:08 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 31 May 2017 19:23:08 +0000 Subject: [Koha-bugs] [Bug 18259] Koha::Biblio - Remove GetSubscriptionsId In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18259 Josef Moravec changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed May 31 21:23:11 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 31 May 2017 19:23:11 +0000 Subject: [Koha-bugs] [Bug 18259] Koha::Biblio - Remove GetSubscriptionsId In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18259 Josef Moravec changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #61051|0 |1 is obsolete| | --- Comment #2 from Josef Moravec --- Created attachment 63889 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=63889&action=edit [SIGNED-OFF] Bug 18259: Koha::Biblio - Remove GetSubscriptionsId C4::Biblio::GetSubscriptionsId can be replaced using Koha::Biblio->subscriptions Test plan: Create a new order for a bibliographic record Create a new subscription on this biblio >From the basket (acquisition), confirm that you are not able to delete the order with the biblio ("Can't cancel order and delete catalog record 1 subscription(s) left") Receive the order On the parcel page, confirm that you are not able to delete the order with the biblio Signed-off-by: Josef Moravec -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed May 31 21:37:17 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 31 May 2017 19:37:17 +0000 Subject: [Koha-bugs] [Bug 14302] Remove GRS1 indexing related code In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14302 Josef Moravec changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |josef.moravec at gmail.com -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed May 31 21:57:56 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 31 May 2017 19:57:56 +0000 Subject: [Koha-bugs] [Bug 18706] subfields to delete not disabled anymore in batch item modification In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18706 Josef Moravec changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed May 31 21:58:00 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 31 May 2017 19:58:00 +0000 Subject: [Koha-bugs] [Bug 18706] subfields to delete not disabled anymore in batch item modification In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18706 Josef Moravec changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #63864|0 |1 is obsolete| | --- Comment #3 from Josef Moravec --- Created attachment 63890 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=63890&action=edit [SIGNED-OFF] Bug 18706 - subfields to delete not disabled anymore in batch item modification In Tools > Batch item modification, one can click a checkbox to delete a subfield. This click use to disable the input to change the field value. This comes from the patch : Bug 13501: Move "Required" and checkbox after input/select Because input is found using JQuery next(). This patch replaces with $(this).parent().find("[name='field_value']"). Test plan : - Go to Tools > Batch item modification - Enter a barcode and submit - Click on a checkbox on a non-mandatory subfield => Without patch the input or select is not disabled => With patch the input or select is disabled - Submit => Check that subfield is deleted Signed-off-by: Josef Moravec -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed May 31 21:58:04 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 31 May 2017 19:58:04 +0000 Subject: [Koha-bugs] [Bug 18706] subfields to delete not disabled anymore in batch item modification In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18706 --- Comment #4 from Josef Moravec --- Created attachment 63891 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=63891&action=edit [SIGNED-OFF] Bug 18706 - Remove useless Javascript Whe checking a subfield to be deleted, the code $(this).val($(this).siblings("[name='subfield']").val()); is useless, the checkbox already contains the subfield code : Signed-off-by: Josef Moravec -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed May 31 21:58:30 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 31 May 2017 19:58:30 +0000 Subject: [Koha-bugs] [Bug 18706] subfields to delete not disabled anymore in batch item modification In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18706 Josef Moravec changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |josef.moravec at gmail.com Attachment #63865|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed May 31 22:08:55 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 31 May 2017 20:08:55 +0000 Subject: [Koha-bugs] [Bug 18704] File types limit in tools/ export.pl is causing issues with csv files generated by MS/Excel In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18704 PTFS Europe Sandboxes changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |sandboxes at ptfs-europe.com Status|Needs Signoff |Signed Off --- Comment #3 from PTFS Europe Sandboxes --- Patch tested with a sandbox, by Jason Palmer -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed May 31 22:09:09 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 31 May 2017 20:09:09 +0000 Subject: [Koha-bugs] [Bug 18704] File types limit in tools/ export.pl is causing issues with csv files generated by MS/Excel In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18704 PTFS Europe Sandboxes changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #63856|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed May 31 22:09:06 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 31 May 2017 20:09:06 +0000 Subject: [Koha-bugs] [Bug 18704] File types limit in tools/ export.pl is causing issues with csv files generated by MS/Excel In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18704 Jason Palmer changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |jpalmer at switchinc.org -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed May 31 22:09:17 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 31 May 2017 20:09:17 +0000 Subject: [Koha-bugs] [Bug 18704] File types limit in tools/ export.pl is causing issues with csv files generated by MS/Excel In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18704 --- Comment #4 from PTFS Europe Sandboxes --- Created attachment 63892 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=63892&action=edit Bug 18704 - File types limit in tools/export.pl is causing issues with csv files generated by MS/Excel To test: 1 - Save a csv of biblionumber from MS/Excel 2 - Attempt to export records using this file 3 - It fails (mimetype is appliction/vnd.ms-excel) 4 - Apply patch 5 - Try again 6 - It succeeds! Signed-off-by: Jason Palmer -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed May 31 22:10:57 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 31 May 2017 20:10:57 +0000 Subject: [Koha-bugs] [Bug 18704] File types limit in tools/ export.pl is causing issues with csv files generated by MS/Excel In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18704 --- Comment #5 from Jason Palmer --- Executed plan in test environment. Works as desired. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed May 31 22:44:12 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 31 May 2017 20:44:12 +0000 Subject: [Koha-bugs] [Bug 18708] Show itemBarcodeFallbackSearch results in a modal window In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18708 Josef Moravec changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |josef.moravec at gmail.com --- Comment #2 from Josef Moravec --- There is remaining text "The following items were found by searching" under the dialog, when modal is dismissed, see: http://www.s3blog.org/screengrab/images.html?id=db33f62a858be5568abef965d5528356 but otherwise it is working nice and looks awesome ;) -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed May 31 23:48:33 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 31 May 2017 21:48:33 +0000 Subject: [Koha-bugs] [Bug 18711] New: No longer possible have a blank value for Classification Sources in the Administration Module Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18711 Bug ID: 18711 Summary: No longer possible have a blank value for Classification Sources in the Administration Module Change sponsored?: --- Product: Koha Version: 16.11 Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: System Administration Assignee: koha-bugs at lists.koha-community.org Reporter: karen at bywatersolutions.com QA Contact: testopia at bugs.koha-community.org CC: gmcharlt at gmail.com In Koha 3.22 it was possible to enter a blank value for Classification Sources in the Administration Module. In 16.11 it is no longer possible to enter a blank value. The expected behavior is that it would still be possible to enter a blank value. The SWITCH Library Consortium has requested the ability to keep the ability to add a blank value field. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
    TargetHostname/PortDatabaseUseridPasswordPreselectedRankSyntaxEncodingTimeoutRecord typeAttributesOPACOptions[% account.date |$KohaDates %][% account.timestamp |$KohaDates with_hours => 1 %]