[Koha-bugs] [Bug 18291] Remove SQL from preferences.pl administrative script

[bugzilla-daemon at bugs.koha-community.org]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18291

Alex Buckley <alexbuckley at catalyst.net.nz> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Failed QA                   |Needs Signoff

--- Comment #9 from Alex Buckley <alexbuckley at catalyst.net.nz> ---
Hi Jonathan

I think see what you mean about the use of Koha::Context->SysPref and
Koha::Context->SysPref.

I have chosen to use the C4::Context::preference() call rather than the call to
the Koha::Config::Sysprefs->find( $variable ) as both present a one line patch
and the use of retrieving cached values seems better from a performance point
of view.

In addition to this call I have had to change  $row->{'<value>'}; to
$piece->{'<value>'}; in several places to allow preferences.pl to run
successfully.

Could you please test my patch and let me know if I have fixed the issues that
previously existed?

Cheers
Alex

-- 
You are receiving this mail because:
You are watching all bug changes.