[Koha-bugs] [Bug 3311] Statistical reports should error if row and column aren' t selected

[bugzilla-daemon at bugs.koha-community.org]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=3311

--- Comment #48 from M. Tompsett <mtompset at hotmail.com> ---
(In reply to Katrin Fischer from comment #47)
> While testing this I noticed that the Acquisitions and Holds statistics have
> column and row preselected - could this be a more elegant way of solving
> this problem?

It is a "less is more" type solution. Though, someone would need to specify
what row and columns are picked by default. And since the original report says,

"When running Statistical Reports,  interface does not clearly specify that
both a column and a row must be selected.  User is able to generate a report
with selection of just row.  Koha should either error out, or add instructions
on-screen indicating both column and row are required."

It says nothing of defaults, hence this solution.


> What I don't like about this patch is the changes to the pull downs. Instead
> of empty for 'non-filtered' it shows a text now. Quickly scanning the form,
> this makes it much harder to see, what was actually filtered on (lots of
> text). This is not part of the problem description and should be dealt with
> and discussed separately.

True, I creeped the scope to include fixing the HTML.
The HTML as it is triggered validation errors. Owen had suggested his
preference would be some text describing what the actual blank value means.
I can provide another patch to reset those parts.


> Sorry, not signing off. Not sure which status to set - in Discussion?

I suppose.

-- 
You are receiving this mail because:
You are watching all bug changes.