[Koha-bugs] [Bug 8628] Add digital signs to the OPAC

[bugzilla-daemon at bugs.koha-community.org]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8628

Katrin Fischer <katrin.fischer at bsz-bw.de> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Needs Signoff               |Failed QA
                 CC|                            |katrin.fischer at bsz-bw.de

--- Comment #12 from Katrin Fischer <katrin.fischer at bsz-bw.de> ---
The QA scripts are pointing out some issues with these patches:

 FAIL   installer/data/mysql/atomicupdate/bug_8628-digital-signs-sysprefs.sql
   OK     git manipulation
   FAIL   semicolon
                simicolon found instead of comma at line 1
                simicolon found instead of comma at line 3
                simicolon found instead of comma at line 2
   OK     sysprefs_order

 FAIL   installer/data/mysql/kohastructure.sql
   FAIL   charset_collate
                The table sign_streams does not have the current charset
collate (see bug 11944)
                The table signs_to_streams does not have the current charset
collate (see bug 11944)
                The table signs does not have the current charset collate (see
bug 11944)
   OK     git manipulation

 OK     installer/data/mysql/sysprefs.sql
   OK     git manipulation
   OK     semicolon
   OK     sysprefs_order

 OK     koha-tmpl/intranet-tmpl/prog/en/includes/tools-menu.inc
   OK     forbidden patterns
   OK     git manipulation
   OK     spelling
   OK     tt_valid
   OK     valid_template

 FAIL   koha-tmpl/intranet-tmpl/prog/en/modules/tools/signs.tt
   FAIL   forbidden patterns
                forbidden pattern: Contains old bootstrap style for buttons
(see bug 16239) (line 407)
                forbidden pattern: Contains old bootstrap style for buttons
(see bug 16239) (line 441)
                forbidden pattern: Contains old bootstrap style for buttons
(see bug 16239) (line 227)
                forbidden pattern: Contains old bootstrap style for buttons
(see bug 16239) (line 86)
                forbidden pattern: Contains old bootstrap style for buttons
(see bug 16239) (line 87)
                forbidden pattern: Contains old bootstrap style for buttons
(see bug 16239) (line 226)
                forbidden pattern: Contains old bootstrap style for buttons
(see bug 16239) (line 442)
   OK     git manipulation
   OK     spelling
   OK     tt_valid
   OK     valid_template

 OK     koha-tmpl/intranet-tmpl/prog/en/modules/tools/tools-home.tt
   OK     forbidden patterns
   OK     git manipulation
   OK     spelling
   OK     tt_valid
   OK     valid_template

 FAIL   koha-tmpl/opac-tmpl/bootstrap/en/modules/opac-signs.tt
   FAIL   forbidden patterns
                forbidden pattern: simple-quote string (line 468)
                forbidden pattern: opac-tmpl should certainly replaced with [%
interface %] (line 561)
                forbidden pattern: opac-tmpl should certainly replaced with [%
interface %] (line 67)
                forbidden pattern: simple-quote string (line 464)
                forbidden pattern: simple-quote string (line 448)
                forbidden pattern: simple-quote string (line 450)
                forbidden pattern: simple-quote string (line 465)
                forbidden pattern: opac-tmpl should certainly replaced with [%
interface %] (line 462)
                forbidden pattern: opac-tmpl should certainly replaced with [%
interface %] (line 70)
                forbidden pattern: simple-quote string (line 478)
                forbidden pattern: opac-tmpl should certainly replaced with [%
interface %] (line 69)
   OK     git manipulation
   FAIL   spelling
                 initilize  ==> initialize
   OK     tt_valid
   OK     valid_template

 FAIL   opac/opac-signs.pl
   OK     critic
   FAIL   forbidden patterns
                forbidden pattern: Koha is now under the GPLv3 license (line 9)
   OK     git manipulation
   OK     pod
   OK     spelling
   OK     valid

 FAIL   tools/signs.pl
   OK     critic
   FAIL   forbidden patterns
                forbidden pattern: Koha is now under the GPLv3 license (line 9)
   OK     git manipulation
   OK     pod
   OK     spelling
   OK     valid

-- 
You are receiving this mail because:
You are watching all bug changes.