[Koha-bugs] [Bug 12063] Change date calculation for reserve expiration to skip all holidays

[bugzilla-daemon at bugs.koha-community.org]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12063

--- Comment #71 from Marcel de Rooy <m.de.rooy at rijksmuseum.nl> ---
(In reply to Alex Arnaud from comment #69)
> (In reply to Marcel de Rooy from comment #68)
> >  sub CancelExpiredReserves {
> > +    return unless C4::Context->preference("ExpireReservesMaxPickUpDelay");
> > This may have a unwanted side-effect. If we do not use the pickup delay, but
> > still want to cancel expired reserves. 
> 
> You mean: If ExpireReservesMaxPickUpDelay is set to don't allow ? If yes,
> this is because we don't want to cancel expired reserves right ? Or i don't
> understand the syspref.
The situation I described is independent of this pref. You could use the cron
job to remove expired reserves based on expiration dates entered by patrons.

> > sub set_waiting {
> > [...]
> > +    if ( C4::Context->preference("ExcludeHolidaysFromMaxPickUpDelay") ) {
> > +        $expirationdate = $calendar->days_forward(
> > dt_from_string($self->waitingdate), $max_pickup_delay );
> > +    }
> > This may cause something weird. If you do a second 
> 
> Is it possible that the code of set_waiting (after tranferToDo) should be
> called 2 times for the same reserve ?
As mentioned, this is exceptional. But it can be easily simulated. Check this
book in today and perhaps by accident tomorrow (it was still on the desk or
something like that). Two separate checkins, two calls.

-- 
You are receiving this mail because:
You are watching all bug changes.