[Koha-bugs] [Bug 12063] Change date calculation for reserve expiration to skip all holidays

[bugzilla-daemon at bugs.koha-community.org]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12063

Marcel de Rooy <m.de.rooy at rijksmuseum.nl> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Signed Off                  |Passed QA

--- Comment #86 from Marcel de Rooy <m.de.rooy at rijksmuseum.nl> ---
Final QA Comment:
After a longer process, we reached Passed QA now. Added two small follow-ups.
One serious problem in the db rev fixed.

Still wanting to mention two points without triggering discussion again:
[1] The construction around expirationdate still feels little bit unappropriate
to me personally, but after some discussion we found a compromize.
[2] The change in Letters.pm is still arguable. Previously, expirationdate was
calculated here and could be used on a notice. Now, we do no longer need to
calculate it theoretically. But take e.g. the hold slip; the notice is
generated before the expiration date is set and therefore still empty.
I recommend to have a look at this problem on a new report. I do not consider
it as a blocker.

Thanks, Alex.

-- 
You are receiving this mail because:
You are watching all bug changes.