[Koha-bugs] [Bug 12446] Enable an adult to have a guarantor

[bugzilla-daemon at bugs.koha-community.org]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12446

--- Comment #50 from Jonathan Druart <jonathan.druart at bugs.koha-community.org> ---
Comment on attachment 63214
  --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=63214
ID change for jQuery listener

Review of attachment 63214:
 --> (https://bugs.koha-community.org/bugzilla3/page.cgi?id=splinter.html&bug=12446&attachment=63214)
-----------------------------------------------------------------

Philippe,

Please do not add unnecessary changes to your patches:
blank lines, indentation changes, trailing spaces should only be fixed when you
are modifying these lines.

::: koha-tmpl/intranet-tmpl/prog/en/modules/common/patron_search.tt
@@ +112,4 @@
>      $("body").on("click",".select_user",function(e){
>          e.preventDefault();
>          var borrowernumber = $(this).data("borrowernumber");
> +        var borrower_data = $("#guarantor_data"+borrowernumber).val();

You should not modify existing code without thinking about side-effects.
Assume that existing code is useful and used by other scripts :)

For instance with this change you break admin/add_user_search.pl when called to
set the owner of a fund (from admin/aqbudgets.tt).

-- 
You are receiving this mail because:
You are watching all bug changes.