[Koha-bugs] [Bug 18389] bulkmarcimport.pl does not take notice of MARC modification templates

bugzilla-daemon at bugs.koha-community.org bugzilla-daemon at bugs.koha-community.org
Wed May 10 23:46:21 CEST 2017


https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18389

--- Comment #2 from Katrin Fischer <katrin.fischer at bsz-bw.de> ---
Comment on attachment 63353
  --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=63353
The same patch as above only generated within git and without touch existing
whitespace formatting oddities in the script.

Review of attachment 63353:
 --> (https://bugs.koha-community.org/bugzilla3/page.cgi?id=splinter.html&bug=18389&attachment=63353)
-----------------------------------------------------------------

Hi Jon,

the patch is looking good, thx for your contribution! Looking at the code, I am
missing documentation of the new option - could you add it please so it shows
up when bulkmarcimport is run without params or with -h?

Also noticed another small thing:

::: misc/migration_tools/bulkmarcimport.pl
@@ +3,4 @@
>  
>  use strict;
>  use warnings;
> +use Modern::Perl;

use Modern::Perl; replaces use strict; and use warnings; so the 2 lines above
should be deleted.

-- 
You are receiving this mail because:
You are watching all bug changes.


More information about the Koha-bugs mailing list