[Koha-bugs] [Bug 18587] New: LDAP: update_local is entirely untested!

bugzilla-daemon at bugs.koha-community.org bugzilla-daemon at bugs.koha-community.org
Fri May 12 10:02:55 CEST 2017


https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18587

            Bug ID: 18587
           Summary: LDAP: update_local is entirely untested!
 Change sponsored?: ---
           Product: Koha
           Version: master
          Hardware: All
                OS: All
            Status: NEW
          Severity: major
          Priority: P3
         Component: Authentication
          Assignee: gmcharlt at gmail.com
          Reporter: martin.renvoize at ptfs-europe.com
        QA Contact: testopia at bugs.koha-community.org
                CC: dpavlin at rot13.org, gmcharlt at gmail.com,
                    hblancoca at gmail.com, katrin.fischer at bsz-bw.de,
                    martin.renvoize at ptfs-europe.com, mtj at kohaaloha.com,
                    oliver.bock at aei.mpg.de, tomascohen at gmail.com
        Depends on: 14625

The update_local routine inside C4/Auth_with_ldap.pm is entirely untested :(.

Reading the code, there are assumptions within it that don't hold true either.
For instance, it is assumed that the routine always returns 'cardnumber', when
in fact, it can return 'undef' or an integer specifying the number of rows
updated by the procedure.. which should only ever be '1'.


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14625
[Bug 14625] LDAP: mapped ExtendedPatronAttributes cause error when updated on
authentication
-- 
You are receiving this mail because:
You are watching all bug changes.


More information about the Koha-bugs mailing list