[Koha-bugs] [Bug 18478] Hold Notices sent via SMS gateway fail

[bugzilla-daemon at bugs.koha-community.org]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18478

--- Comment #3 from Nick Clemens <nick at bywatersolutions.com> ---
Created attachment 63487
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=63487&action=edit
Bug 18478 - Hold Notices sent via SMS gateway fail

It seems that for HOLD notices we rely on
C4::Letters::SendQueuedMessages
to populate the correct address.

The sms code in this sub, however, assumed the smsalertnumebr is
populated.

Ths patch changes C4::Reserves::_koha_notify_reserve to use
C4::Message::enqueue
for SMS and email messages in order to ensure the correct addrress is
populated

To test:
 1 - Define a messaging prefs for a patron to recieve hold notices via
SMS
 2 - Ensure you have defined an SMS message for 'HOLD' letter
 3 - Set an SMS alert number for patron
 4 - Set the SMS::Send driver to 'Email'
 5 - Fill a hold for the patron
 6 - Check the db and note the address is null
 7 - Apply patch
 8 - Fill another hold
 9 - Check db and note address is populated
10 - Repeat for email notices and see the same change

-- 
You are receiving this mail because:
You are watching all bug changes.