[Koha-bugs] [Bug 16330] REST API: add routes to add, update and delete patrons

[bugzilla-daemon at bugs.koha-community.org]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16330

--- Comment #45 from Lari Taskula <lari.taskula at jns.fi> ---
Hi! Sorry for the late response. My view for the todo:

1. "Move validation logic from controller to Koha::Patron" patch; obsolete
validate() method - validations should occur in Koha::Patron->store().
2. REST tests for this endpoint at t/db_dependent/api/v1/patrons.t is a big
mess and should be rewritten to enhance readability and clearly separate tests
of different operations, a good example is in cities.t.
3. Consider dependency to Bug 18137. Code-wise not a big change and required
sooner or later as Swagger2 plugin is deprecated.
4. We discussed parameter naming convention in koha-devel (borrowernumber vs
patron_id). Not sure if this was also discussed in a meeting, but I was left
with the feeling that this is wanted by the community. However, could this be
handled in another Bug to get this one moving?

I have worked on 1. and 2. and have a patch for that, however the work was
paused by discussion on 4. I will re-test the patch and attach it here.

-- 
You are receiving this mail because:
You are watching all bug changes.