[Koha-bugs] [Bug 18647] Internal server error on moremember.pl

bugzilla-daemon at bugs.koha-community.org bugzilla-daemon at bugs.koha-community.org
Tue May 23 14:45:22 CEST 2017


https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18647

--- Comment #10 from Marcel de Rooy <m.de.rooy at rijksmuseum.nl> ---
(In reply to Jonathan Druart from comment #5)
> I'd say the patch should be:
> 
> diff --git a/members/moremember.pl b/members/moremember.pl
> index 0e18d2234f..0649dcfd76 100755
> --- a/members/moremember.pl
> +++ b/members/moremember.pl
> @@ -343,7 +343,6 @@ my $translated_language =
> C4::Languages::language_get_description( $subtag, $sub
> 
>  $template->param(
>      patron          => $patron,
> -    borrower        => $patron, # TODO Still needed by includes,
>      translated_language => $translated_language,
>      detailview      => 1,
>      borrowernumber  => $borrowernumber,
> 
> 
> The borrower variable should not be a Koha::Patron, because the include file
> expects an hashref.
> 
> Marcel, do you know why you add the TODO comment? I do not find where it is
> used.

No, you cannot remove the borrower template var yet.
The TODO was kind of trivial. Passing the same information twice needs further
attention :) Probably by forgetting another Plack restart, I did not catch the
internal server error..

-- 
You are receiving this mail because:
You are watching all bug changes.


More information about the Koha-bugs mailing list