[Koha-bugs] [Bug 18651] Move of checkouts is still not correctly handled

[bugzilla-daemon at bugs.koha-community.org]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18651

--- Comment #14 from Kyle M Hall <kyle at bywatersolutions.com> ---
I like the solution. Correct me if I'm wrong, but we still aren't correcting
the auto_increment value for issue_id. This effectively *does* create a race
condition if two checkins happen simultaneously where the issue_id's are
already in old_issues.

The only solution that comes to mind at the moment is lines 18651 through 2192
in a loop that ends when the query on line 2192 succeeds. Is that reasonable?
Or do we just accept the small risk that an error condition will be triggered?
As long as the failure doesn't introduce bad and inconsistent data I think it's
worth the tiny risk of a librarian getting an error on checkin once in a blue
moon, and have to check the item in a second time.

(In reply to Jonathan Druart from comment #13)
> Created attachment 63654 [details] [review]
> Bug 18651: Copy the row before modify the id

-- 
You are receiving this mail because:
You are watching all bug changes.