[Koha-bugs] [Bug 18226] Remove "use Test::DBIx::Class" instantiations' dangerous code duplication

[bugzilla-daemon at bugs.koha-community.org]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18226

Jonathan Druart <jonathan.druart at bugs.koha-community.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Signed Off                  |Failed QA

--- Comment #18 from Jonathan Druart <jonathan.druart at bugs.koha-community.org> ---
The comparaison
  $libCount = Koha::Libraries->search->count
does not work when there is no libraries defined (0 vs undef)

prove t/db_dependent/01-test_dbic.t
t/db_dependent/01-test_dbic.t .. 
    #   Failed test '  When the libraries are counted'
    #   at t/db_dependent/01-test_dbic.t line 41.
    # Looks like you failed 1 test of 19.
t/db_dependent/01-test_dbic.t .. 1/? 
#   Failed test 'Scenario: Show how caching prevents Test::DBIx::Class from
working properly and how to circumvent it'
#   at t/db_dependent/01-test_dbic.t line 95.
# Looks like you failed 1 test of 1.
t/db_dependent/01-test_dbic.t .. Dubious, test returned 1 (wstat 256, 0x100)
Failed 1/1 subtests 

Test Summary Report
-------------------
t/db_dependent/01-test_dbic.t (Wstat: 256 Tests: 1 Failed: 1)
  Failed test:  1
  Non-zero exit status: 1
Files=1, Tests=1,  3 wallclock secs ( 0.02 usr  0.02 sys +  2.09 cusr  0.88
csys =  3.01 CPU)
Result: FAIL

You should also use is instead of ok and follow the coding guidelines of the
project (camel_case for instance), please...

$verbose should be removed

-- 
You are receiving this mail because:
You are watching all bug changes.