[Koha-bugs] [Bug 18226] Remove "use Test::DBIx::Class" instantiations' dangerous code duplication

bugzilla-daemon at bugs.koha-community.org bugzilla-daemon at bugs.koha-community.org
Wed May 24 14:21:24 CEST 2017


https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18226

Marcel de Rooy <m.de.rooy at rijksmuseum.nl> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Failed QA                   |Signed Off

--- Comment #22 from Marcel de Rooy <m.de.rooy at rijksmuseum.nl> ---
(In reply to Jonathan Druart from comment #18)
> prove t/db_dependent/01-test_dbic.t
Please try again with the follow-ups.

> You should also use is instead of ok and follow the coding guidelines of the
> project (camel_case for instance), please...
Not sure what you exactly want here. The lines where ok now is called, are fine
with me. I'd rather see ok than using 'is' for comparing with false.
Please specify which names should be adjusted.

> $verbose should be removed
Fixed

-- 
You are receiving this mail because:
You are watching all bug changes.


More information about the Koha-bugs mailing list