[Koha-bugs] [Bug 18667] Show a diff view of SQL reports when converting

[bugzilla-daemon at bugs.koha-community.org]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18667

--- Comment #2 from Josef Moravec <josef.moravec at gmail.com> ---
Comment on attachment 63708
  --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=63708
Bug 18667 - Show a diff view of SQL reports when converting

Review of attachment 63708:
 --> (https://bugs.koha-community.org/bugzilla3/page.cgi?id=splinter.html&bug=18667&attachment=63708)
-----------------------------------------------------------------

::: koha-tmpl/intranet-tmpl/prog/en/modules/reports/convert_report.tt
@@ +7,4 @@
>              [% IF msg == 'no_report' %]
>                  There is no valid report for this id.
>              [% ELSIF msg == 'can_be_updated' %]
> +                <div id="col1" class="" style="width:45%;float:left;">

It would be better to use class instead of style attribute

@@ +11,5 @@
> +                    <h3>Existing SQL</h3>
> +                    <span class="show_sql">[% current_sql | html_entity %]</span>
> +                </div>
> +
> +                <div id="col2" class="" style="width:45%; float:left;">

And here too please

-- 
You are receiving this mail because:
You are watching all bug changes.