[Koha-bugs] [Bug 11317] Add a way to access files from the intranet
bugzilla-daemon at bugs.koha-community.org
bugzilla-daemon at bugs.koha-community.org
Thu May 25 21:21:50 CEST 2017
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11317
Katrin Fischer <katrin.fischer at bsz-bw.de> changed:
What |Removed |Added
----------------------------------------------------------------------------
Status|Needs Signoff |Failed QA
--- Comment #76 from Katrin Fischer <katrin.fischer at bsz-bw.de> ---
Ok, trying to get this tested :)
First: QA tools:
FAIL koha-tmpl/intranet-tmpl/prog/en/modules/reports/report_files.tt
FAIL git manipulation
The file has been added and deleted in the same patchset
FAIL koha-tmpl/intranet-tmpl/prog/en/modules/reports/reports-home.tt
FAIL forbidden patterns
forbidden pattern: tab char (line 55)
forbidden pattern: tab char (line 68)
forbidden pattern: tab char (line 63)
forbidden pattern: tab char (line 61)
forbidden pattern: tab char (line 64)
forbidden pattern: tab char (line 58)
forbidden pattern: tab char (line 65)
forbidden pattern: tab char (line 73)
forbidden pattern: tab char (line 59)
forbidden pattern: tab char (line 57)
forbidden pattern: tab char (line 60)
FAIL reports/report_files.pl
FAIL git manipulation
The file has been added and deleted in the same patchset
Easy to fix - as we got no sign-off yet, we'd just need to fix the tabs and
squash the patches.
Second: Some code review
1) I think as the permission is under Tools and the files live there too, it
should also be shown as a tool on the tools page instead of under reports. I'd
put it under "Additional tools", maybe under the log viewer.
<li><a href="/cgi-bin/koha/reports/report_files.pl">Report/log files</a></li>
2) When I click on the link under Reports, I get a 'not found' error. What am I
missing?
3) Looking at the history of this bug, are we missing 2 patches?
Bug 11317 - Allow sorting on date column in file access tool. (1.29 KB, patch)
Bug 11317 - Remove datatables-strings.inc from .tt (959 bytes, patch)
4)
+use strict;
+use warnings;
Shoudl be: use Modern::Perl;
Sorry, can't test further because of 2)!
--
You are receiving this mail because:
You are watching all bug changes.
More information about the Koha-bugs
mailing list