[Koha-bugs] [Bug 17896] BakerTaylorEnabled is not plack safe in reading history at the OPAC

[bugzilla-daemon at bugs.koha-community.org]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17896

--- Comment #3 from Jonathan Druart <jonathan.druart at bugs.koha-community.org> ---
Aleisha,

I agree that there is something wrong, but the test plan is not enough.

There are several things wrong:
- import must be done at the beginning of the module
- import must not be dependent of syspref in begin blocks

What's happening is that Plack runs all BEGIN blocks when it starts, and that
is the only time they are evaluated.
That means that if you start plack with the pref BakerTaylorEnabled disabled,
the require+import will not be done.
Then if you enable the pref (and not restart plack of course) and access the
opac-readingrec view, it will explode.

-- 
You are receiving this mail because:
You are watching all bug changes.