From bugzilla-daemon at bugs.koha-community.org  Wed Nov  1 03:52:06 2017
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 01 Nov 2017 02:52:06 +0000
Subject: [Koha-bugs] [Bug 19554] The inventory table should jump to detail
 instead of MARCdetail
In-Reply-To: <bug-19554-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-19554-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-19554-70-zEg0lTUDiC@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19554

M. Tompsett <mtompset at hotmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Needs Signoff               |Signed Off

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Nov  1 03:52:08 2017
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 01 Nov 2017 02:52:08 +0000
Subject: [Koha-bugs] [Bug 19554] The inventory table should jump to detail
 instead of MARCdetail
In-Reply-To: <bug-19554-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-19554-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-19554-70-a6x8mNZnmu@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19554

M. Tompsett <mtompset at hotmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #68865|0                           |1
        is obsolete|                            |

--- Comment #2 from M. Tompsett <mtompset at hotmail.com> ---
Created attachment 68875
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=68875&action=edit
Bug 19554: The inventory table should jump to detail instead of MARCdetail

This patch just replaces the link to detail.
Detail provides item information needed in case of inventory problems.

Test plan:
Go to Tools/Inventory.
Create an inventory list without barcode file.
Check if the link goes to detail now.

Signed-off-by: Marcel de Rooy <m.de.rooy at rijksmuseum.nl>

Signed-off-by: Mark Tompsett <mtompset at hotmail.com>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Nov  1 04:06:15 2017
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 01 Nov 2017 03:06:15 +0000
Subject: [Koha-bugs] [Bug 19551] Cash register report has bad erroneous
 results from wrong order of operations
In-Reply-To: <bug-19551-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-19551-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-19551-70-1PDUMbrip2@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19551

M. Tompsett <mtompset at hotmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #68857|0                           |1
        is obsolete|                            |

--- Comment #2 from M. Tompsett <mtompset at hotmail.com> ---
Created attachment 68876
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=68876&action=edit
Bug 19551 - Fix wrong order of operations in cash register report

To test:
1 - Find or create a fine for a patron
2 - Write it off
3 - Home -> Reports -> Cash register
4 - Fill in current date and transaction type 'Write off'
5 - Click Submit
-- see your write off
6 - Fill in previous dates and transaction type 'Write off'
7 - Click Submit
-- see your write off (bad)
8 - Apply patch
9 - Rerun steps 3-7
-- write only visible for current date.

Signed-off-by: Mark Tompsett <mtompset at hotmail.com>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Nov  1 04:06:13 2017
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 01 Nov 2017 03:06:13 +0000
Subject: [Koha-bugs] [Bug 19551] Cash register report has bad erroneous
 results from wrong order of operations
In-Reply-To: <bug-19551-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-19551-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-19551-70-d3a7DNir7S@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19551

M. Tompsett <mtompset at hotmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Needs Signoff               |Signed Off

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Nov  1 04:09:31 2017
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 01 Nov 2017 03:09:31 +0000
Subject: [Koha-bugs] [Bug 18645] Creation of Koha feature release change
 tool displayed after running Koha update
In-Reply-To: <bug-18645-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-18645-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-18645-70-yD8ta7eC9k@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18645

M. Tompsett <mtompset at hotmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |mtompset at hotmail.com

--- Comment #13 from M. Tompsett <mtompset at hotmail.com> ---
Please do not do whitespace changes in patches unless necessary for individual
changed lines. White space patches should be separated. Otherwise, it makes
eyeballing the bug more difficult.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Nov  1 11:53:14 2017
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 01 Nov 2017 10:53:14 +0000
Subject: [Koha-bugs] [Bug 7317] Add an Interlibrary Loan Module to
	Circulation and OPAC
In-Reply-To: <bug-7317-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-7317-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-7317-70-0KFB6zYtz7@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7317

Magnus Enger <magnus at libriotech.no> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #68858|0                           |1
        is obsolete|                            |

--- Comment #168 from Magnus Enger <magnus at libriotech.no> ---
Created attachment 68877
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=68877&action=edit
Bug 7317: QA followup

This fixes some of the issues reported by the QA script, but not all.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Nov  1 11:53:21 2017
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 01 Nov 2017 10:53:21 +0000
Subject: [Koha-bugs] [Bug 7317] Add an Interlibrary Loan Module to
	Circulation and OPAC
In-Reply-To: <bug-7317-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-7317-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-7317-70-GElhIpwDPK@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7317

Magnus Enger <magnus at libriotech.no> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #68874|0                           |1
        is obsolete|                            |

--- Comment #169 from Magnus Enger <magnus at libriotech.no> ---
Created attachment 68878
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=68878&action=edit
Bug 7317: Handle backend absense more gracefuly

5/ This patch is WIP, it makes Koha::Illrequest->load_backend raise an
exception
if the passed backend is invalid. This way we will catch more errors
introduced.

The patch also disables the 'New Ill request' when no backends are available.
Gets
rid of a related warning.

TODO: Should add a noticeable warning on the UI, or a tooltip on the button.
TODO: add a couple tests for the exception

4/ This patch fixes the path for the checkboxes jquery plugin, and removes the
include
for tablesorter, as this implementation uses Datatables. This is obviously code
for older
Koha, ported to master.

3/ I know it doesn't look right, but am not sure how to display. This is the
usual empty
datatable display we have everywhere in Koha.

2/ We could fix it with a proper IDE, I use Komodo and refactoring code is
pretty straigh-forward.
Worth a separate bug report.

1/ That TODO is misleading. It refers to their own migration from a different
design. I checked this
code and cannot find occurences of ->status with that annotation. I think this
relates to backends code.

Signed-off-by: Tomas Cohen Arazi <tomascohen at theke.io>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Nov  1 12:02:36 2017
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 01 Nov 2017 11:02:36 +0000
Subject: [Koha-bugs] [Bug 16865] Patron self registration: hiding branchcode
 hides email and breaks workflow
In-Reply-To: <bug-16865-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-16865-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-16865-70-zbab65Yn33@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16865

--- Comment #5 from Katrin Fischer <katrin.fischer at bsz-bw.de> ---
The primary email field in the form where you enter the patron data.

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.

From bugzilla-daemon at bugs.koha-community.org  Wed Nov  1 12:03:32 2017
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 01 Nov 2017 11:03:32 +0000
Subject: [Koha-bugs] [Bug 7317] Add an Interlibrary Loan Module to
	Circulation and OPAC
In-Reply-To: <bug-7317-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-7317-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-7317-70-oIcktjpOQf@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7317

--- Comment #170 from Magnus Enger <magnus at libriotech.no> ---
Trying to summarize the status of this bug now. 

*** QA script

** POD coverage

Some FAILS are "POD coverage was greater before, try perl
-MPod::Coverage=PackageName -e666". It sounds like these can be ignored. 

** Atomicupdate

 FAIL   installer/data/mysql/atomicupdate/ill_tables.sql
   FAIL   git manipulation
                The file has been added and deleted in the same patchset

Alex provided ill_tables.sql. Tomas rewrote it as bug_7317_ill.perl. Not sure
there is anything to fix here? 

** tt_valid

 FAIL   koha-tmpl/intranet-tmpl/prog/en/modules/ill/ill-requests.tt
   OK     forbidden patterns
   OK     git manipulation
   OK     spelling
   FAIL   tt_valid
                lines 665
   FAIL   valid_template
                : not found

TT is used to set some HTML attributes. Not sure if this can be fixed. Tomas? 

*** (In reply to Jonathan Druart from comment #164)

> 1/ 
> +TODO:
> +
> +- Anything invoking the ->status method; annotated with:
> +  + # Old use of ->status !
> 
> What do it mean?

OK, according to Tomas.

> 2/ I will not make you rewrite everything, but it would have been better to
> stay consistent and not mix snake_case and camelCase for method names.

OK

> First steps with the GUI:
> 3/ This is what I see when I enable the module:
> https://screenshots.firefox.com/z9dNoRL91NQ5F3cD/pro.kohadev.org
> Looks wrong.

Not sure if this can be fixed?

> 4/ Hit /cgi-bin/koha/ill/ill-requests.pl and got:
> Loading failed for the <script> with source
> ?http://pro.kohadev.org/intranet-tmpl/prog/en/lib/jquery/plugins/jquery.
> tablesorter.min.js?.  ill-requests.pl:151
> Loading failed for the <script> with source
> ?http://pro.kohadev.org/intranet-tmpl/prog/en/lib/jquery/plugins/jquery.
> checkboxes.min.js?.  ill-requests.pl:152

OK. Fixed by Tomas

> 5/ Clicked "New ILL request" button and got:
> Can't locate Koha/Illbackends//Base.pm

OK. Fixed by Tomas. But it sounds like Tomas will be working a bit more on
related things.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Nov  1 12:04:10 2017
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 01 Nov 2017 11:04:10 +0000
Subject: [Koha-bugs] [Bug 16865] Patron self registration: hiding branchcode
 hides email and breaks workflow
In-Reply-To: <bug-16865-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-16865-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-16865-70-kwBsj9Prhv@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16865

--- Comment #6 from Katrin Fischer <katrin.fischer at bsz-bw.de> ---
Sorry for all the typos in my previous comment. The system preference
*unwanted*  takes the database column names from the borrowers table. When you
enter 'branchcode' it will hide more fields, especially the primary email
(email) field, which doesn't make sense.

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Nov  1 12:05:48 2017
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 01 Nov 2017 11:05:48 +0000
Subject: [Koha-bugs] [Bug 18547] On shelf holds allowed > "If all
 unavailable" ignores default hold policy
In-Reply-To: <bug-18547-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-18547-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-18547-70-pZSW3K9qzZ@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18547

--- Comment #16 from Katrin Fischer <katrin.fischer at bsz-bw.de> ---
Glad to see this one moving, thx for taking the time to test!

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Nov  1 12:11:29 2017
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 01 Nov 2017 11:11:29 +0000
Subject: [Koha-bugs] [Bug 19123] Remove/fix reference to latest release
In-Reply-To: <bug-19123-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-19123-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-19123-70-b1wUaciFUM@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19123

--- Comment #3 from Katrin Fischer <katrin.fischer at bsz-bw.de> ---
I fixed it manually every time, it never generated right for me.

I don't think it adds valuable information. The easiest fix would be to remove
it.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Nov  1 12:14:00 2017
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 01 Nov 2017 11:14:00 +0000
Subject: [Koha-bugs] [Bug 19284] Correct version numbering by adding missing
	zeros
In-Reply-To: <bug-19284-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-19284-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-19284-70-okjJPFfgom@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19284

--- Comment #2 from Katrin Fischer <katrin.fischer at bsz-bw.de> ---
+1 :)

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Nov  1 12:14:05 2017
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 01 Nov 2017 11:14:05 +0000
Subject: [Koha-bugs] [Bug 17314] REST API: Add API route to create,
 list and delete a purchase suggestion
In-Reply-To: <bug-17314-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-17314-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-17314-70-JzSNdHZuUV@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17314

--- Comment #20 from Jon Knight <J.P.Knight at lboro.ac.uk> ---
I noticed that this doesn't apply cleanly to the latest master HEAD on my
kohadevbox.  I could help rebase if that would be useful to nudge this bug
along?  Unless of course Jiri is working on an updated version?

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Nov  1 12:16:17 2017
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 01 Nov 2017 11:16:17 +0000
Subject: [Koha-bugs] [Bug 19488] 5 digit, "Borrower Number" from details page
In-Reply-To: <bug-19488-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-19488-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-19488-70-o3AsbD5FCX@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19488

Katrin Fischer <katrin.fischer at bsz-bw.de> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |katrin.fischer at bsz-bw.de

--- Comment #1 from Katrin Fischer <katrin.fischer at bsz-bw.de> ---
Why 5 digit?

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Nov  1 12:26:39 2017
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 01 Nov 2017 11:26:39 +0000
Subject: [Koha-bugs] [Bug 19522] Label creator - some strings are not
	translatable
In-Reply-To: <bug-19522-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-19522-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-19522-70-TZm8wcyKHN@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19522

Katrin Fischer <katrin.fischer at bsz-bw.de> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |katrin.fischer at bsz-bw.de

--- Comment #23 from Katrin Fischer <katrin.fischer at bsz-bw.de> ---
Hm there could be. Owen, could you try from koha-shell with 
cd misc/translator
perl translate update fr-FR
?

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Nov  1 12:31:31 2017
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 01 Nov 2017 11:31:31 +0000
Subject: [Koha-bugs] [Bug 19554] The inventory table should jump to detail
 instead of MARCdetail
In-Reply-To: <bug-19554-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-19554-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-19554-70-M2aY95bcfq@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19554

Katrin Fischer <katrin.fischer at bsz-bw.de> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |katrin.fischer at bsz-bw.de

--- Comment #3 from Katrin Fischer <katrin.fischer at bsz-bw.de> ---
+1

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Nov  1 12:36:26 2017
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 01 Nov 2017 11:36:26 +0000
Subject: [Koha-bugs] [Bug 19555] Some changes to records are not reflected
	in OAI-PMH
In-Reply-To: <bug-19555-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-19555-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-19555-70-8p8AEe2GQJ@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19555

Katrin Fischer <katrin.fischer at bsz-bw.de> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |katrin.fischer at bsz-bw.de

--- Comment #2 from Katrin Fischer <katrin.fischer at bsz-bw.de> ---
Hm, when we add the timestamp to the new table, wouldn't looking at that not be
enough? I think that would be easiest. 
I think I saw on another bug that changes to items weren't reflected either.
 Is this already fixed or could be fixed in one go with this here?

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Nov  1 12:57:04 2017
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 01 Nov 2017 11:57:04 +0000
Subject: [Koha-bugs] [Bug 19555] Some changes to records are not reflected
	in OAI-PMH
In-Reply-To: <bug-19555-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-19555-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-19555-70-ysDjOUbL85@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19555

--- Comment #3 from Tom?s Cohen Arazi <tomascohen at gmail.com> ---
(In reply to Katrin Fischer from comment #2)
> Hm, when we add the timestamp to the new table, wouldn't looking at that not
> be enough? I think that would be easiest. 
> I think I saw on another bug that changes to items weren't reflected either.
>  Is this already fixed or could be fixed in one go with this here?

biblio and biblioitems are both the same table, just splitted. When a
bibliographic record is modified, the timestamp should be changed (no matter in
which of the tables is). The problem might be that we are relying on the DB
feature of updating the timestamp when the row is changed. Which doesn't happen
when no mapping triggers a row change.

Regarding items, the items timestamps should be checked if include_items is
set.

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Nov  1 13:02:50 2017
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 01 Nov 2017 12:02:50 +0000
Subject: [Koha-bugs] [Bug 19555] Some changes to records are not reflected
	in OAI-PMH
In-Reply-To: <bug-19555-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-19555-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-19555-70-863bgvyxl4@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19555

--- Comment #4 from Katrin Fischer <katrin.fischer at bsz-bw.de> ---
Yes, we are using the MySQL feature, I think for all of our timestamps
actually. That's why Magnus suggested to put one on the metadata table and use
that.

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.

From bugzilla-daemon at bugs.koha-community.org  Wed Nov  1 13:03:06 2017
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 01 Nov 2017 12:03:06 +0000
Subject: [Koha-bugs] [Bug 19554] The inventory table should jump to detail
 instead of MARCdetail
In-Reply-To: <bug-19554-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-19554-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-19554-70-1RBTAt7uwm@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19554

--- Comment #4 from Marcel de Rooy <m.de.rooy at rijksmuseum.nl> ---
(In reply to M. Tompsett from comment #2)
> Signed-off-by: Mark Tompsett <mtompset at hotmail.com>

Thanks Mark

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Nov  1 13:05:00 2017
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 01 Nov 2017 12:05:00 +0000
Subject: [Koha-bugs] [Bug 19555] Some changes to records are not reflected
	in OAI-PMH
In-Reply-To: <bug-19555-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-19555-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-19555-70-QMT9w542DT@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19555

--- Comment #5 from Tom?s Cohen Arazi <tomascohen at gmail.com> ---
(In reply to Katrin Fischer from comment #4)
> Yes, we are using the MySQL feature, I think for all of our timestamps
> actually. That's why Magnus suggested to put one on the metadata table and
> use that.

I don't oppose.

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Nov  1 15:01:15 2017
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 01 Nov 2017 14:01:15 +0000
Subject: [Koha-bugs] [Bug 14715] Results per page setting for catalog search
 in staff client and OPAC
In-Reply-To: <bug-14715-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-14715-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-14715-70-3MSzXAsULb@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14715

Marjorie Barry-Vila <marjorie.barry-vila at collecto.ca> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |marjorie.barry-vila at collect
                   |                            |o.ca

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Nov  1 15:45:49 2017
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 01 Nov 2017 14:45:49 +0000
Subject: [Koha-bugs] [Bug 19539] Editing rules that contain 'Unlimited'
 values produces invalid data
In-Reply-To: <bug-19539-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-19539-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-19539-70-afrEO67OFj@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19539

Kyle M Hall <kyle at bywatersolutions.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #68846|0                           |1
        is obsolete|                            |
  Attachment #68847|0                           |1
        is obsolete|                            |

--- Comment #5 from Kyle M Hall <kyle at bywatersolutions.com> ---
Created attachment 68879
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=68879&action=edit
Bug 19539: Fix column index shift in cirulation rules

This patch fixes an index shift introduced by bug 18857 when it introduced
a new column.

To test:
- On the Circulation and fine rules page
- Empty the value of 'Current on-site checkouts allowed' and save
- Notice 'Unlimited' shows on the saved rule.
- Click edit
=> FAIL: the 'Unlimited' string displays instead of the empty string on the
editing row.
- Apply this patch
- Re-open the circ rules page
- Click edit
=> SUCCESS: An empty string fills the 'Unlimited' fields
- Sign off :-D

Signed-off-by: David Bourgault <david.bourgault at inlibro.com>

Signed-off-by: Jonathan Druart <jonathan.druart at bugs.koha-community.org>

Signed-off-by: Kyle M Hall <kyle at bywatersolutions.com>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Nov  1 15:45:55 2017
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 01 Nov 2017 14:45:55 +0000
Subject: [Koha-bugs] [Bug 19539] Editing rules that contain 'Unlimited'
 values produces invalid data
In-Reply-To: <bug-19539-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-19539-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-19539-70-Gzro6pxsAB@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19539

--- Comment #6 from Kyle M Hall <kyle at bywatersolutions.com> ---
Created attachment 68880
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=68880&action=edit
Bug 19539: (follow-up) Fix column index shift in cirulation rules

Signed-off-by: Jonathan Druart <jonathan.druart at bugs.koha-community.org>

Signed-off-by: Kyle M Hall <kyle at bywatersolutions.com>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Nov  1 15:45:47 2017
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 01 Nov 2017 14:45:47 +0000
Subject: [Koha-bugs] [Bug 19539] Editing rules that contain 'Unlimited'
 values produces invalid data
In-Reply-To: <bug-19539-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-19539-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-19539-70-AhfXMjwke4@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19539

Kyle M Hall <kyle at bywatersolutions.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Signed Off                  |Passed QA

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Nov  1 16:46:47 2017
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 01 Nov 2017 15:46:47 +0000
Subject: [Koha-bugs] [Bug 19559] New: Elasticsearch QueryAutoTruncate
 truncate field names with hyphens if data is quoted
Message-ID: <bug-19559-70@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19559

            Bug ID: 19559
           Summary: Elasticsearch QueryAutoTruncate truncate field names
                    with hyphens if data is quoted
 Change sponsored?: ---
           Product: Koha
           Version: master
          Hardware: All
                OS: All
            Status: NEW
          Severity: major
          Priority: P5 - low
         Component: Searching - Elasticsearch
          Assignee: koha-bugs at lists.koha-community.org
          Reporter: nick at bywatersolutions.com

With QueryAutoTruncate enabled a search for:
Local-number:"4"
is truncated as:
Local-* number:"4"

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Nov  1 16:51:06 2017
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 01 Nov 2017 15:51:06 +0000
Subject: [Koha-bugs] [Bug 19559] Elasticsearch QueryAutoTruncate truncate
 field names with hyphens if data is quoted
In-Reply-To: <bug-19559-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-19559-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-19559-70-gGyenFEW3f@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19559

--- Comment #1 from Nick Clemens <nick at bywatersolutions.com> ---
Created attachment 68881
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=68881&action=edit
Bug 19559 - Unit tests

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.

From bugzilla-daemon at bugs.koha-community.org  Wed Nov  1 16:51:08 2017
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 01 Nov 2017 15:51:08 +0000
Subject: [Koha-bugs] [Bug 19559] Elasticsearch QueryAutoTruncate truncate
 field names with hyphens if data is quoted
In-Reply-To: <bug-19559-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-19559-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-19559-70-bfqJ811mwq@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19559

--- Comment #2 from Nick Clemens <nick at bywatersolutions.com> ---
Created attachment 68882
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=68882&action=edit
Bug 19559 - Add '-' to list of characters we don't split search terms on

Test plan assumes
QueryAutoTruncate = automatically
SearchEngine = Elasticsearch

To test:
0 - Apply Unit test patch only
1 - prove t/db_dependent/Koha_SearchEngine_Elasticsearch_Search.t
2 - Should fail
3 - Apply this patch
4 - prove t/db_dependent/Koha_SearchEngine_Elasticsearch_Search.t
5 - should pass
6 - search for 'Local-number:"4"' (or a vlid biblionumber)
7 - should get expected result

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Nov  1 16:51:04 2017
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 01 Nov 2017 15:51:04 +0000
Subject: [Koha-bugs] [Bug 19559] Elasticsearch QueryAutoTruncate truncate
 field names with hyphens if data is quoted
In-Reply-To: <bug-19559-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-19559-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-19559-70-jCNVYaHlmH@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19559

Nick Clemens <nick at bywatersolutions.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
   Patch complexity|---                         |Trivial patch
             Status|NEW                         |Needs Signoff

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.

From bugzilla-daemon at bugs.koha-community.org  Wed Nov  1 16:51:57 2017
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 01 Nov 2017 15:51:57 +0000
Subject: [Koha-bugs] [Bug 19559] Elasticsearch QueryAutoTruncate truncate
 field names with hyphens if data is quoted
In-Reply-To: <bug-19559-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-19559-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-19559-70-YzhGvkl3pW@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19559

Nick Clemens <nick at bywatersolutions.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |jonathan.druart at bugs.koha-c
                   |                            |ommunity.org,
                   |                            |julian.maurice at biblibre.com
                   |                            |, tomascohen at gmail.com
           Assignee|koha-bugs at lists.koha-commun |nick at bywatersolutions.com
                   |ity.org                     |
         Depends on|                            |18374


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18374
[Bug 18374] Respect QueryAutoTruncate syspref in Elasticsearch
-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Nov  1 16:51:57 2017
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 01 Nov 2017 15:51:57 +0000
Subject: [Koha-bugs] [Bug 18374] Respect QueryAutoTruncate syspref in
	Elasticsearch
In-Reply-To: <bug-18374-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-18374-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-18374-70-kVchvnJtQ9@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18374

Nick Clemens <nick at bywatersolutions.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Blocks|                            |19559


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19559
[Bug 19559] Elasticsearch QueryAutoTruncate truncate field names with hyphens
if data is quoted
-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Nov  1 16:59:23 2017
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 01 Nov 2017 15:59:23 +0000
Subject: [Koha-bugs] [Bug 19176] Dates comparison fails on slow server
In-Reply-To: <bug-19176-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-19176-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-19176-70-VDaa1dZWmZ@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19176

Jonathan Druart <jonathan.druart at bugs.koha-community.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Failed QA                   |Passed QA

--- Comment #24 from Jonathan Druart <jonathan.druart at bugs.koha-community.org> ---
Thanks Julian!

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Nov  1 17:00:14 2017
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 01 Nov 2017 16:00:14 +0000
Subject: [Koha-bugs] [Bug 18055] Speed up '00-strict.t' test
In-Reply-To: <bug-18055-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-18055-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-18055-70-RzS1LIiuHe@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18055

Jonathan Druart <jonathan.druart at bugs.koha-community.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Passed QA                   |BLOCKED

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Nov  1 17:09:13 2017
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 01 Nov 2017 16:09:13 +0000
Subject: [Koha-bugs] [Bug 16497] Add routes to list libraries
In-Reply-To: <bug-16497-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-16497-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-16497-70-sVKiFZr0KE@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16497

Jonathan Druart <jonathan.druart at bugs.koha-community.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Passed QA                   |Failed QA

--- Comment #29 from Jonathan Druart <jonathan.druart at bugs.koha-community.org> ---
Please check POD coverage.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Nov  1 17:11:16 2017
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 01 Nov 2017 16:11:16 +0000
Subject: [Koha-bugs] [Bug 19539] Editing rules that contain 'Unlimited'
 values produces invalid data
In-Reply-To: <bug-19539-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-19539-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-19539-70-AOaEwKBXTW@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19539

Jonathan Druart <jonathan.druart at bugs.koha-community.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #68880|0                           |1
        is obsolete|                            |

--- Comment #7 from Jonathan Druart <jonathan.druart at bugs.koha-community.org> ---
Created attachment 68883
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=68883&action=edit
Bug 19539: (follow-up) Fix column index shift in cirulation rules

Signed-off-by: Jonathan Druart <jonathan.druart at bugs.koha-community.org>

Signed-off-by: Kyle M Hall <kyle at bywatersolutions.com>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Nov  1 17:11:41 2017
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 01 Nov 2017 16:11:41 +0000
Subject: [Koha-bugs] [Bug 19539] Editing rules that contain 'Unlimited'
 values produces invalid data
In-Reply-To: <bug-19539-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-19539-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-19539-70-fR25QhLAot@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19539

Jonathan Druart <jonathan.druart at bugs.koha-community.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |jonathan.druart at bugs.koha-c
                   |                            |ommunity.org
           Severity|normal                      |major

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Nov  1 17:15:00 2017
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 01 Nov 2017 16:15:00 +0000
Subject: [Koha-bugs] [Bug 17989] Stricter control on source directory for
	html templates
In-Reply-To: <bug-17989-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-17989-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-17989-70-DU1KMNrRrL@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17989

Jonathan Druart <jonathan.druart at bugs.koha-community.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Passed QA                   |Pushed to Master

--- Comment #36 from Jonathan Druart <jonathan.druart at bugs.koha-community.org> ---
Pushed to master for 17.11, thanks to everybody involved!

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Nov  1 17:15:16 2017
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 01 Nov 2017 16:15:16 +0000
Subject: [Koha-bugs] [Bug 19176] Dates comparison fails on slow server
In-Reply-To: <bug-19176-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-19176-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-19176-70-W52e6OddLp@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19176

Jonathan Druart <jonathan.druart at bugs.koha-community.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Passed QA                   |Pushed to Master

--- Comment #25 from Jonathan Druart <jonathan.druart at bugs.koha-community.org> ---
Pushed to master for 17.11, thanks to everybody involved!

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Nov  1 17:15:31 2017
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 01 Nov 2017 16:15:31 +0000
Subject: [Koha-bugs] [Bug 19539] Editing rules that contain 'Unlimited'
 values produces invalid data
In-Reply-To: <bug-19539-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-19539-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-19539-70-XnFOctPPOY@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19539

Jonathan Druart <jonathan.druart at bugs.koha-community.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Passed QA                   |Pushed to Master

--- Comment #8 from Jonathan Druart <jonathan.druart at bugs.koha-community.org> ---
Pushed to master for 17.11, thanks to everybody involved!

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Nov  1 17:15:49 2017
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 01 Nov 2017 16:15:49 +0000
Subject: [Koha-bugs] [Bug 7143] Bug for tracking changes to the about page
In-Reply-To: <bug-7143-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-7143-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-7143-70-r92tMcNGMl@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7143

Jonathan Druart <jonathan.druart at bugs.koha-community.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Passed QA                   |Pushed to Master

--- Comment #377 from Jonathan Druart <jonathan.druart at bugs.koha-community.org> ---
Pushed to master for 17.11, thanks to everybody involved!

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Nov  1 17:20:45 2017
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 01 Nov 2017 16:20:45 +0000
Subject: [Koha-bugs] [Bug 19123] Remove/fix reference to latest release
In-Reply-To: <bug-19123-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-19123-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-19123-70-euX6PXkrfK@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19123

Jonathan Druart <jonathan.druart at bugs.koha-community.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
         Resolution|---                         |FIXED
             Status|NEW                         |RESOLVED

--- Comment #4 from Jonathan Druart <jonathan.druart at bugs.koha-community.org> ---
commit 6fb40783995ef1171ef784f79e6d077b0ae60aec
  Bug 19123: Remove reference to the last release

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Nov  1 17:23:19 2017
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 01 Nov 2017 16:23:19 +0000
Subject: [Koha-bugs] [Bug 18131] Matching staged records when using elastic
	search fails
In-Reply-To: <bug-18131-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-18131-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-18131-70-uPUZICateN@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18131

Nick Clemens <nick at bywatersolutions.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Failed QA                   |Signed Off

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Nov  1 17:23:22 2017
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 01 Nov 2017 16:23:22 +0000
Subject: [Koha-bugs] [Bug 18131] Matching staged records when using elastic
	search fails
In-Reply-To: <bug-18131-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-18131-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-18131-70-3s5nMpSBuO@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18131

--- Comment #12 from Nick Clemens <nick at bywatersolutions.com> ---
Created attachment 68884
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=68884&action=edit
Bug 18131: Followup - Use data if biblionumber_tag < 10

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Nov  1 17:23:45 2017
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 01 Nov 2017 16:23:45 +0000
Subject: [Koha-bugs] [Bug 18131] Matching staged records when using elastic
	search fails
In-Reply-To: <bug-18131-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-18131-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-18131-70-gQJjO89Y9Z@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18131

Nick Clemens <nick at bywatersolutions.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
         Depends on|                            |19559


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19559
[Bug 19559] Elasticsearch QueryAutoTruncate truncate field names with hyphens
if data is quoted
-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Nov  1 17:23:45 2017
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 01 Nov 2017 16:23:45 +0000
Subject: [Koha-bugs] [Bug 19559] Elasticsearch QueryAutoTruncate truncate
 field names with hyphens if data is quoted
In-Reply-To: <bug-19559-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-19559-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-19559-70-DOWyBvmWAq@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19559

Nick Clemens <nick at bywatersolutions.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Blocks|                            |18131


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18131
[Bug 18131] Matching staged records when using elastic search fails
-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Nov  1 17:26:08 2017
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 01 Nov 2017 16:26:08 +0000
Subject: [Koha-bugs] [Bug 18131] Matching staged records when using elastic
	search fails
In-Reply-To: <bug-18131-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-18131-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-18131-70-oXjFWBSSvO@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18131

--- Comment #13 from Nick Clemens <nick at bywatersolutions.com> ---
(In reply to Julian Maurice from comment #11)
> Also, this is weird that search_result_compat returns different result
> depending on the search engine. Shouldn't we fix one of
> Koha::SearchEngine::*::Search::search_result_compat ?

Agreed, it is odd, see the comment in the pod:
315 an arrayref of MARC::Records (note that this is different from the
316 L<C4::Search> version which will return plain XML, but too bad.)

I think beyond the scope here, let's get this fixed for now.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Nov  1 17:36:43 2017
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 01 Nov 2017 16:36:43 +0000
Subject: [Koha-bugs] [Bug 19415] FindDuplicateAuthority is searching on
 biblioserver since 16.05
In-Reply-To: <bug-19415-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-19415-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-19415-70-QADLINJaBQ@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19415

Nick Clemens <nick at bywatersolutions.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |juan.sieira at xercode.es

--- Comment #10 from Nick Clemens <nick at bywatersolutions.com> ---
*** Bug 16746 has been marked as a duplicate of this bug. ***

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Nov  1 17:36:43 2017
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 01 Nov 2017 16:36:43 +0000
Subject: [Koha-bugs] [Bug 16746] Can not find duplicated authorities
 cataloguing a new one
In-Reply-To: <bug-16746-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-16746-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-16746-70-LrEe8wu9Zv@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16746

Nick Clemens <nick at bywatersolutions.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |nick at bywatersolutions.com
             Status|In Discussion               |RESOLVED
         Resolution|---                         |DUPLICATE

--- Comment #8 from Nick Clemens <nick at bywatersolutions.com> ---


*** This bug has been marked as a duplicate of bug 19415 ***

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Nov  1 20:04:35 2017
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 01 Nov 2017 19:04:35 +0000
Subject: [Koha-bugs] [Bug 19560] New: Special characters & and # in
 branchcode - unable to delete branch
Message-ID: <bug-19560-70@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19560

            Bug ID: 19560
           Summary: Special characters & and # in branchcode - unable to
                    delete branch
 Change sponsored?: ---
           Product: Koha
           Version: 17.05
          Hardware: All
                OS: All
            Status: NEW
          Severity: enhancement
          Priority: P5 - low
         Component: System Administration
          Assignee: koha-bugs at lists.koha-community.org
          Reporter: joy at bywatersolutions.com
        QA Contact: testopia at bugs.koha-community.org
                CC: gmcharlt at gmail.com

Special Characters in Branchcode cause the user to be unable to delete the
branch.

Replicate:
1. Administration->Libraries and Groups
2. Click on New Library button
3. Create a new branch use the & or # character in the branchcode
4. Branch is created.
5. Click on Delete (under Actions) for that branch
6. Verify you wish to delete the branch.
7. Error message appears 
An error occurred when deleting this library. Check the logs. 

Can this field be validated when data is entered?  We should not allow users to
create branchcodes that use special characters.

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.

From bugzilla-daemon at bugs.koha-community.org  Wed Nov  1 20:31:41 2017
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 01 Nov 2017 19:31:41 +0000
Subject: [Koha-bugs] [Bug 7317] Add an Interlibrary Loan Module to
	Circulation and OPAC
In-Reply-To: <bug-7317-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-7317-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-7317-70-idR6hCC10X@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7317

Tom?s Cohen Arazi <tomascohen at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #68878|0                           |1
        is obsolete|                            |

--- Comment #171 from Tom?s Cohen Arazi <tomascohen at gmail.com> ---
Created attachment 68885
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=68885&action=edit
Bug 7317: Handle backend absense more gracefuly

5/ This patch is WIP, it makes Koha::Illrequest->load_backend raise an
exception
if the passed backend is invalid. This way we will catch more errors
introduced.

The patch also disables the 'New Ill request' when no backends are available.
Gets
rid of a related warning.

TODO: Should add a noticeable warning on the UI, or a tooltip on the button.
TODO: add a couple tests for the exception

4/ This patch fixes the path for the checkboxes jquery plugin, and removes the
include
for tablesorter, as this implementation uses Datatables. This is obviously code
for older
Koha, ported to master.

3/ I know it doesn't look right, but am not sure how to display. This is the
usual empty
datatable display we have everywhere in Koha.

2/ We could fix it with a proper IDE, I use Komodo and refactoring code is
pretty straigh-forward.
Worth a separate bug report.

1/ That TODO is misleading. It refers to their own migration from a different
design. I checked this
code and cannot find occurences of ->status with that annotation. I think this
relates to backends code.

Signed-off-by: Tomas Cohen Arazi <tomascohen at theke.io>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Nov  1 20:32:00 2017
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 01 Nov 2017 19:32:00 +0000
Subject: [Koha-bugs] [Bug 7317] Add an Interlibrary Loan Module to
	Circulation and OPAC
In-Reply-To: <bug-7317-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-7317-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-7317-70-CUGApuHtFp@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7317

--- Comment #172 from Tom?s Cohen Arazi <tomascohen at gmail.com> ---
Created attachment 68886
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=68886&action=edit
Bug 7317: (QA followup) Get rid of warnings from the tests

Signed-off-by: Tomas Cohen Arazi <tomascohen at theke.io>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Nov  1 23:33:12 2017
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 01 Nov 2017 22:33:12 +0000
Subject: [Koha-bugs] [Bug 19561] New: Add "preferred language" to OPAC
 Personal Details opac-memberentry.pl
Message-ID: <bug-19561-70@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19561

            Bug ID: 19561
           Summary: Add "preferred language" to OPAC Personal Details
                    opac-memberentry.pl
 Change sponsored?: ---
           Product: Koha
           Version: unspecified
          Hardware: All
                OS: All
            Status: NEW
          Severity: enhancement
          Priority: P5 - low
         Component: Notices
          Assignee: koha-bugs at lists.koha-community.org
          Reporter: jzairo at bywatersolutions.com
        QA Contact: testopia at bugs.koha-community.org

Bug 17762 adds the ability to translate notices. The new system preference for
translatenotices allows staff members to set a preferred language in the user
account, which controls which template will be used when generating notices.

It would be great to allow patrons to select their preferred language in the
OPAC Personal Details page on opac-memberentry.pl.

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.

From bugzilla-daemon at bugs.koha-community.org  Wed Nov  1 23:35:55 2017
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 01 Nov 2017 22:35:55 +0000
Subject: [Koha-bugs] [Bug 19561] Add "preferred language" to OPAC Personal
 Details opac-memberentry.pl
In-Reply-To: <bug-19561-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-19561-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-19561-70-AjlTIhl4Jq@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19561

Jessie Zairo <jzairo at bywatersolutions.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |jzairo at bywatersolutions.com
                   |                            |,
                   |                            |kelly at bywatersolutions.com

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Nov  1 23:36:15 2017
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 01 Nov 2017 22:36:15 +0000
Subject: [Koha-bugs] [Bug 19561] Add "preferred language" to OPAC Personal
 Details opac-memberentry.pl
In-Reply-To: <bug-19561-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-19561-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-19561-70-ymlvaHMDCL@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19561

Jessie Zairo <jzairo at bywatersolutions.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |eveal at mckinneytexas.org

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Nov  1 23:56:54 2017
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 01 Nov 2017 22:56:54 +0000
Subject: [Koha-bugs] [Bug 19561] Add "preferred language" to OPAC Personal
 Details opac-memberentry.pl
In-Reply-To: <bug-19561-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-19561-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-19561-70-LcifYPjYOf@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19561

--- Comment #1 from Ed Veal <eveal at mckinneytexas.org> ---
The ability to translate the notices is a great new feature. However, to have
it work well staff is placed in a position of asking patrons their preferred
language. If that could be added to the patron record on the
opac-memberentry.pl page then the patrons would be empowered to manage that
themselves. 

We have patrons use the online form to register for a card so that would be the
best point of contact for that choice. 

Ed

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.

From bugzilla-daemon at bugs.koha-community.org  Thu Nov  2 01:23:11 2017
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 02 Nov 2017 00:23:11 +0000
Subject: [Koha-bugs] [Bug 19547] Maria DB doesn't have a debian.cnf
In-Reply-To: <bug-19547-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-19547-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-19547-70-VmRJdzsyBQ@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19547

M. Tompsett <mtompset at hotmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
           Severity|enhancement                 |minor

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Nov  2 02:10:43 2017
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 02 Nov 2017 01:10:43 +0000
Subject: [Koha-bugs] [Bug 16690] Installing DB on remote server fails
 without *.* permissions
In-Reply-To: <bug-16690-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-16690-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-16690-70-XXsgzlX2CX@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16690

--- Comment #9 from M. Tompsett <mtompset at hotmail.com> ---
(In reply to Katrin Fischer from comment #8)
> Patches still apply. Mark, could you add a test plan please and say
> something about the requirements in order to test this?

This is about the koha-create --use-db method, if doing a manual install from
source. But I figure you can get the same result with a simple package install
and a couple tweaks.

As you can see in comment #1, I created a DB, but did not grant permissions for
'%'. This means when the web installer attempts to SHOW GRANTS it is going to
fail, because hostname on a regular install is the KohaApp VM, not the KohaDB
VM.

The 'Do an install' is a simple package installation.
'Hack the kohaconf...' is something like:
$ sudo vi /etc/koha/sites/library/koha-conf.xml
and making the appropriate adjustments to match the information used in the
GRANT ALL.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Nov  2 02:53:03 2017
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 02 Nov 2017 01:53:03 +0000
Subject: [Koha-bugs] [Bug 18894] Add ability to limit the number of messages
 sent by misc/ cronjobs/process_message_queue.pl at a time
In-Reply-To: <bug-18894-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-18894-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-18894-70-aF82s8TCkA@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18894

--- Comment #3 from M. Tompsett <mtompset at hotmail.com> ---
Comment on attachment 64804
  --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=64804
Bug 18894 - Add ability to limit the number of messages sent by
misc/cronjobs/process_message_queue.pl at a time

Review of attachment 64804:
 --> (https://bugs.koha-community.org/bugzilla3/page.cgi?id=splinter.html&bug=18894&attachment=64804)
-----------------------------------------------------------------

::: C4/Letters.pm
@@ +1272,5 @@
> +        SELECT mq.message_id, mq.borrowernumber, mq.subject, mq.content, mq.message_transport_type, mq.status, mq.time_queued, mq.from_address, mq.to_address, mq.content_type, b.branchcode, mq.letter_code
> +        FROM message_queue mq
> +        LEFT JOIN borrowers b ON b.borrowernumber = mq.borrowernumber
> +        WHERE status = ?
> +    };

I like the clean up, but technically not necessary.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Nov  2 03:09:03 2017
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 02 Nov 2017 02:09:03 +0000
Subject: [Koha-bugs] [Bug 18894] Add ability to limit the number of messages
 sent by misc/ cronjobs/process_message_queue.pl at a time
In-Reply-To: <bug-18894-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-18894-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-18894-70-cIwsk0BJ26@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18894

M. Tompsett <mtompset at hotmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Needs Signoff               |Signed Off

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Nov  2 03:09:05 2017
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 02 Nov 2017 02:09:05 +0000
Subject: [Koha-bugs] [Bug 18894] Add ability to limit the number of messages
 sent by misc/ cronjobs/process_message_queue.pl at a time
In-Reply-To: <bug-18894-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-18894-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-18894-70-4nChPg01KO@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18894

M. Tompsett <mtompset at hotmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #64804|0                           |1
        is obsolete|                            |

--- Comment #4 from M. Tompsett <mtompset at hotmail.com> ---
Created attachment 68887
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=68887&action=edit
Bug 18894 - Add ability to limit the number of messages sent by
misc/cronjobs/process_message_queue.pl at a time

Having the ability to limit the number of messages sent by
process_message_queue.pl on a single run would be very useful for controlling
home many messages are sent at a given time. This can help prevent too many
messages being sent out at once and getting flagged as a spammer.

Test Plan:
1) Apply this patch
2) Generate some number of messages in the message queue
3) Run process_message_queue.pl with the new --limit option,
   set limit to a number smaller than the number of pending messages
4) After the script has run, check the database and note that only
   a number of pending messages were sent, and that the remaining amount
   of pending messages is the original amount less the number specified
   as the limit

Signed-off-by: Mark Tompsett <mtompset at hotmail.com>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Nov  2 04:15:58 2017
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 02 Nov 2017 03:15:58 +0000
Subject: [Koha-bugs] [Bug 19181] Intranet and OPAC authentication selenium
	test
In-Reply-To: <bug-19181-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-19181-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-19181-70-UvnNrJT7gI@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19181

M. Tompsett <mtompset at hotmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Signed Off                  |BLOCKED
         Depends on|                            |19243

--- Comment #10 from M. Tompsett <mtompset at hotmail.com> ---
This and the other selenium tests all are blocked by bug 19243.


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19243
[Bug 19243] Selenium test for testing the administration module functionality
-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Nov  2 04:15:58 2017
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 02 Nov 2017 03:15:58 +0000
Subject: [Koha-bugs] [Bug 19243] Selenium test for testing the
 administration module functionality
In-Reply-To: <bug-19243-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-19243-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-19243-70-rXTEOAgDJa@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19243

M. Tompsett <mtompset at hotmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Blocks|                            |19181


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19181
[Bug 19181] Intranet and OPAC authentication selenium test
-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Nov  2 04:16:18 2017
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 02 Nov 2017 03:16:18 +0000
Subject: [Koha-bugs] [Bug 19182] Item search in intranet and OPAC selenium
	test
In-Reply-To: <bug-19182-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-19182-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-19182-70-i5ESOGwrOL@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19182

M. Tompsett <mtompset at hotmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
         Depends on|                            |19243


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19243
[Bug 19243] Selenium test for testing the administration module functionality
-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Nov  2 04:16:18 2017
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 02 Nov 2017 03:16:18 +0000
Subject: [Koha-bugs] [Bug 19243] Selenium test for testing the
 administration module functionality
In-Reply-To: <bug-19243-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-19243-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-19243-70-lRmio6SSiX@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19243

M. Tompsett <mtompset at hotmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Blocks|                            |19182


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19182
[Bug 19182] Item search in intranet and OPAC selenium test
-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Nov  2 04:16:32 2017
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 02 Nov 2017 03:16:32 +0000
Subject: [Koha-bugs] [Bug 19183] Acquisition module setup selenium test
In-Reply-To: <bug-19183-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-19183-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-19183-70-aIpLInz85S@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19183

M. Tompsett <mtompset at hotmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
         Depends on|                            |19243


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19243
[Bug 19243] Selenium test for testing the administration module functionality
-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Nov  2 04:16:32 2017
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 02 Nov 2017 03:16:32 +0000
Subject: [Koha-bugs] [Bug 19243] Selenium test for testing the
 administration module functionality
In-Reply-To: <bug-19243-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-19243-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-19243-70-AqCSVnyyvR@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19243

M. Tompsett <mtompset at hotmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Blocks|                            |19183


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19183
[Bug 19183] Acquisition module setup selenium test
-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Nov  2 04:16:45 2017
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 02 Nov 2017 03:16:45 +0000
Subject: [Koha-bugs] [Bug 19184] Purchase workflow selenium test
In-Reply-To: <bug-19184-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-19184-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-19184-70-BYOE78ny66@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19184

M. Tompsett <mtompset at hotmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
         Depends on|                            |19243


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19243
[Bug 19243] Selenium test for testing the administration module functionality
-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Nov  2 04:16:45 2017
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 02 Nov 2017 03:16:45 +0000
Subject: [Koha-bugs] [Bug 19243] Selenium test for testing the
 administration module functionality
In-Reply-To: <bug-19243-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-19243-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-19243-70-BQrjaP7sLD@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19243

M. Tompsett <mtompset at hotmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Blocks|                            |19184


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19184
[Bug 19184] Purchase workflow selenium test
-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Nov  2 04:16:58 2017
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 02 Nov 2017 03:16:58 +0000
Subject: [Koha-bugs] [Bug 19185] Web installer and onboarding tool selenium
	test
In-Reply-To: <bug-19185-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-19185-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-19185-70-uArxXNVhE2@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19185

M. Tompsett <mtompset at hotmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
         Depends on|                            |19243


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19243
[Bug 19243] Selenium test for testing the administration module functionality
-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Nov  2 04:16:58 2017
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 02 Nov 2017 03:16:58 +0000
Subject: [Koha-bugs] [Bug 19243] Selenium test for testing the
 administration module functionality
In-Reply-To: <bug-19243-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-19243-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-19243-70-6MWtAsNMCe@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19243

M. Tompsett <mtompset at hotmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Blocks|                            |19185


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19185
[Bug 19185] Web installer and onboarding tool selenium test
-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Nov  2 04:17:22 2017
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 02 Nov 2017 03:17:22 +0000
Subject: [Koha-bugs] [Bug 19189] Reserving and renewing item in OPAC
	selenium test
In-Reply-To: <bug-19189-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-19189-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-19189-70-FSaJ7Ajb8o@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19189

M. Tompsett <mtompset at hotmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
         Depends on|                            |19243


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19243
[Bug 19243] Selenium test for testing the administration module functionality
-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Nov  2 04:17:22 2017
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 02 Nov 2017 03:17:22 +0000
Subject: [Koha-bugs] [Bug 19243] Selenium test for testing the
 administration module functionality
In-Reply-To: <bug-19243-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-19243-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-19243-70-N760xTMzpB@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19243

M. Tompsett <mtompset at hotmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Blocks|                            |19189


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19189
[Bug 19189] Reserving and renewing item in OPAC selenium test
-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Nov  2 04:17:45 2017
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 02 Nov 2017 03:17:45 +0000
Subject: [Koha-bugs] [Bug 18974] Cataloging MARC21 record and adding item
	selenium test
In-Reply-To: <bug-18974-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-18974-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-18974-70-CfD9WH9zEE@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18974

M. Tompsett <mtompset at hotmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
         Depends on|                            |19243


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19243
[Bug 19243] Selenium test for testing the administration module functionality
-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Nov  2 04:17:45 2017
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 02 Nov 2017 03:17:45 +0000
Subject: [Koha-bugs] [Bug 19243] Selenium test for testing the
 administration module functionality
In-Reply-To: <bug-19243-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-19243-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-19243-70-xjoUfsJhhI@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19243

M. Tompsett <mtompset at hotmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Blocks|                            |18974


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18974
[Bug 18974] Cataloging MARC21 record and adding item selenium test
-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Nov  2 06:26:35 2017
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 02 Nov 2017 05:26:35 +0000
Subject: [Koha-bugs] [Bug 18979] Speed up 'valid-templates.t' tests
In-Reply-To: <bug-18979-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-18979-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-18979-70-nOuCMtZb8w@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18979

Mason James <mtj at kohaaloha.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |mtj at kohaaloha.com

--- Comment #9 from Mason James <mtj at kohaaloha.com> ---
(In reply to Marcel de Rooy from comment #7)
> About the "use threads;" line:
> 
> Do we really need it ?

hi Marcel, i think it's not needed :)
i must have forgotten to remove the line before sending, i'll fix that now...

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Nov  2 09:23:17 2017
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 02 Nov 2017 08:23:17 +0000
Subject: [Koha-bugs] [Bug 19176] Dates comparison fails on slow server
In-Reply-To: <bug-19176-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-19176-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-19176-70-bNfR9oLdqz@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19176

Marcel de Rooy <m.de.rooy at rijksmuseum.nl> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |m.de.rooy at rijksmuseum.nl

--- Comment #26 from Marcel de Rooy <m.de.rooy at rijksmuseum.nl> ---
Just a few (minor) comments from looking at t::lib::Dates

Test::More seems not to be used.
$description is not used either, and if I am not mistaken is never passed too.
POD says that date is truncated to minutes, but the code compares epoch times
(which are seconds) and than rather out of the blue ignores a difference of
less than 6 seconds (why 6) ? A comment in the code would be helpful too. The
POD is no longer true.

If I understood well, Julian asked to remove the floating timezones. It seems
to me that you'd better compare dates in floating however. (See similar problem
with DST boundaries on earlier pushed report.) And yes, you should clone the
dates when changing timezone and comparing.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Nov  2 10:15:19 2017
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 02 Nov 2017 09:15:19 +0000
Subject: [Koha-bugs] [Bug 19555] Some changes to records are not reflected
	in OAI-PMH
In-Reply-To: <bug-19555-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-19555-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-19555-70-3ocsqPTg2g@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19555

--- Comment #6 from Magnus Enger <magnus at libriotech.no> ---
Created attachment 68888
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=68888&action=edit
Bug 19555: Some changes to records are not reflected in OAI-PMH

When we moved biblioitems.marcxml to biblio_metadata.metadata, this
meant that biblioteitems.timestamp was only updated when there
were changes to MARC fields that have corresponding columns in
the biblioitems table, like ISBN. This patch adds a timestamp
column to biblio_metadata and makes OAI-PMH use that to decide
if a record should be included in a response or not. This should
mean that any change to the records are reflected in OAI-PMH.

To test:
- Before applying the patch:
- Look at at the data in biblioitems for a record, e.g.:
  SELECT * FROM biblioitems WHERE biblionumber = x\G
- Edit the record, and verify that a change to e.g. ISBN updates
  the timestamp, and a change to e.g. a subject does not
- Apply the patch and make sure the atomicupdate is run
- Look at the data in biblio_metadata for the record. e.g.:
  SELECT * FROM biblio_metadata WHERE biblionumber = x\G
- Verify that any change to the record results in a change to
  the timestamp
- Enable OAI-PMH with the OAI-PMH syspref
- Visit this URL in your browser:
 
<opac>/cgi-bin/koha/oai.pl?verb=ListRecords&metadataPrefix=marcxml&from=2017-10-26&until=2017-11-02
- Change the from and until dates as well as the
  biblio_metadata.timestamp value (e.g.: UPDATE biblio_metadata
  SET timestamp = '2017-10-24' WHERE biblionumber = x), and verify
  that the record is included or not included in the OAI-PMH
  response as expected
- Run the tests: prove t/db_dependent/OAI/*.t

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Nov  2 10:15:16 2017
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 02 Nov 2017 09:15:16 +0000
Subject: [Koha-bugs] [Bug 19555] Some changes to records are not reflected
	in OAI-PMH
In-Reply-To: <bug-19555-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-19555-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-19555-70-QH1lt6oK2C@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19555

Magnus Enger <magnus at libriotech.no> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
   Patch complexity|---                         |Small patch
             Status|NEW                         |Needs Signoff

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Nov  2 10:31:41 2017
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 02 Nov 2017 09:31:41 +0000
Subject: [Koha-bugs] [Bug 19562] New: Inventory: How can we skip convolutes
 marked as problematic with no_barcode?
Message-ID: <bug-19562-70@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19562

            Bug ID: 19562
           Summary: Inventory: How can we skip convolutes marked as
                    problematic with no_barcode?
 Change sponsored?: ---
           Product: Koha
           Version: master
          Hardware: All
                OS: All
            Status: NEW
          Severity: enhancement
          Priority: P5 - low
         Component: Tools
          Assignee: koha-bugs at lists.koha-community.org
          Reporter: m.de.rooy at rijksmuseum.nl
        QA Contact: testopia at bugs.koha-community.org

We have two biblio records, but one item. It is a convolute, a bound set of
actually two items. We added one item to each biblio, added Convolute in the
item notes and gave the bound set one barcode recorded in one of the items.
When doing inventory and comparing with a barcode file, you can imagine that
the item without the barcode (having the same callnumber as the item with the
barcode) is reported as a problem (no_barcode).

A simple custom solution is:
$item->{problems}->{no_barcode} = 1 unless $item->{itemnotes} =~ /convolute/i;

Do you have any suggestions or ideas to resolve similar problems with
convolutes, if you have them ? How do you record this situation ?

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.

From bugzilla-daemon at bugs.koha-community.org  Thu Nov  2 11:44:51 2017
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 02 Nov 2017 10:44:51 +0000
Subject: [Koha-bugs] [Bug 19555] Some changes to records are not reflected
	in OAI-PMH
In-Reply-To: <bug-19555-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-19555-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-19555-70-E4Z3YavkuQ@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19555

Jonathan Druart <jonathan.druart at bugs.koha-community.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
           Keywords|                            |rel_17_11_candidate
                 CC|                            |jonathan.druart at bugs.koha-c
                   |                            |ommunity.org

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.

From bugzilla-daemon at bugs.koha-community.org  Thu Nov  2 11:56:57 2017
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 02 Nov 2017 10:56:57 +0000
Subject: [Koha-bugs] [Bug 19555] Some changes to records are not reflected
	in OAI-PMH
In-Reply-To: <bug-19555-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-19555-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-19555-70-ZtMIdESM7S@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19555

--- Comment #7 from Magnus Enger <magnus at libriotech.no> ---
My patch just adds timestamp columns to biblio_metadata and
deletedbiblio_metadata. This means the timestamps in those columns will be
0000-00-00 00:00:00. 

Possible things to do:

1. One thing we could do is copy over data from biblioitems.timestamp to
biblio_metadata.timestamp. That would give us non-zero values, but those values
would still be as wrong as the values in biblioitems.timestamp are. 

2. One step further, at least for MARC21, would be to extract the date from 005
and put that in biblio_metadata.timestamp. That should give pretty accurate
timestamps, as long as the value in 005 makes sense. 

3. The problem with both 1 and 2 is that some biblio_metadata.timestamps will
be way back in time. If a client does a harvest like
verb=ListRecords&metadataPrefix=marcxchange&from=2017-10-26&until=2017-11-02 to
pick up the most recent changes, those records with old timestamps will still
not be picked up. So the best solution is perhaps to set
biblio_metadata.timestamp to the value of 005, BUT when that timestamp is more
recent than biblioitems.timestamp, set biblio_metadata.timestamp to NOW(), so
that a harvest of "recent updates" will catch all these old changes. 

Should we put this in the databaseupdate, or is it too complex? Is it better to
have a note in the databaseupdate pointing to a page on the wiki that details
these options and lets the user/admin choose which one they want?

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Nov  2 12:07:25 2017
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 02 Nov 2017 11:07:25 +0000
Subject: [Koha-bugs] [Bug 19543] Koha does not reserve an item if there is
 one available in another library.
In-Reply-To: <bug-19543-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-19543-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-19543-70-ylQZSKmquo@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19543

Jonathan Druart <jonathan.druart at bugs.koha-community.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |jonathan.druart at bugs.koha-c
                   |                            |ommunity.org

--- Comment #4 from Jonathan Druart <jonathan.druart at bugs.koha-community.org> ---
Cristian, can you confirm that this is a duplicate of bug 18547?

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.

From bugzilla-daemon at bugs.koha-community.org  Thu Nov  2 12:20:59 2017
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 02 Nov 2017 11:20:59 +0000
Subject: [Koha-bugs] [Bug 16865] Patron self registration: hiding branchcode
 hides email and breaks workflow
In-Reply-To: <bug-16865-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-16865-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-16865-70-PTpACyKKDa@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16865

--- Comment #7 from Jonathan Druart <jonathan.druart at bugs.koha-community.org> ---
I do not recreate, I have added "branchcode" to
PatronSelfRegistrationBorrowerUnwantedField, when I go to opac-memberentry.pl I
do not see the library entry and see "primary email" in the "contact
information" part.

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Nov  2 12:24:31 2017
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 02 Nov 2017 11:24:31 +0000
Subject: [Koha-bugs] [Bug 14039] Add patron title to checkout screen
In-Reply-To: <bug-14039-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-14039-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-14039-70-FQ2kM28zLA@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14039

Jonathan Druart <jonathan.druart at bugs.koha-community.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Blocks|                            |19456


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19456
[Bug 19456] Some pages title tag contains html
-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Nov  2 12:24:31 2017
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 02 Nov 2017 11:24:31 +0000
Subject: [Koha-bugs] [Bug 19456] Some pages title tag contains html
In-Reply-To: <bug-19456-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-19456-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-19456-70-phvsHEHTSJ@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19456

Jonathan Druart <jonathan.druart at bugs.koha-community.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
         Depends on|14919                       |14039


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14039
[Bug 14039] Add patron title to checkout screen
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14919
[Bug 14919] Holds history for patron
-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Nov  2 12:24:31 2017
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 02 Nov 2017 11:24:31 +0000
Subject: [Koha-bugs] [Bug 14919] Holds history for patron
In-Reply-To: <bug-14919-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-14919-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-14919-70-HPLZj7vxYC@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14919

Jonathan Druart <jonathan.druart at bugs.koha-community.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Blocks|19456                       |


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19456
[Bug 19456] Some pages title tag contains html
-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Nov  2 12:24:48 2017
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 02 Nov 2017 11:24:48 +0000
Subject: [Koha-bugs] [Bug 19553] Patron page: HTML span tag visible in page
 title when patron has a title
In-Reply-To: <bug-19553-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-19553-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-19553-70-txoDmg7c2d@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19553

Jonathan Druart <jonathan.druart at bugs.koha-community.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
         Resolution|---                         |DUPLICATE
             Status|NEW                         |RESOLVED
                 CC|                            |jonathan.druart at bugs.koha-c
                   |                            |ommunity.org

--- Comment #1 from Jonathan Druart <jonathan.druart at bugs.koha-community.org> ---


*** This bug has been marked as a duplicate of bug 19456 ***

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.

From bugzilla-daemon at bugs.koha-community.org  Thu Nov  2 12:24:48 2017
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 02 Nov 2017 11:24:48 +0000
Subject: [Koha-bugs] [Bug 19456] Some pages title tag contains html
In-Reply-To: <bug-19456-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-19456-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-19456-70-N9Bbf85utp@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19456

Jonathan Druart <jonathan.druart at bugs.koha-community.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |victor.grousset at biblibre.co
                   |                            |m

--- Comment #10 from Jonathan Druart <jonathan.druart at bugs.koha-community.org> ---
*** Bug 19553 has been marked as a duplicate of this bug. ***

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Nov  2 12:27:50 2017
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 02 Nov 2017 11:27:50 +0000
Subject: [Koha-bugs] [Bug 19543] Koha does not reserve an item if there is
 one available in another library.
In-Reply-To: <bug-19543-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-19543-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-19543-70-rEzA7rJE69@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19543

--- Comment #5 from Cristian <cristianbiblio at gmail.com> ---
(In reply to Katrin Fischer from comment #3)
> Hi Cristian, I think you might want to have a look at bug 18547.

Hi Katrin, thank you!

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.

From bugzilla-daemon at bugs.koha-community.org  Thu Nov  2 12:30:34 2017
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 02 Nov 2017 11:30:34 +0000
Subject: [Koha-bugs] [Bug 14224] patron notes about item shown at check in
In-Reply-To: <bug-14224-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-14224-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-14224-70-cTBtIibUsI@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14224

Jonathan Druart <jonathan.druart at bugs.koha-community.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Blocks|                            |19496


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19496
[Bug 19496] Patron notes about item does not get emailed as indicated
-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Nov  2 12:30:34 2017
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 02 Nov 2017 11:30:34 +0000
Subject: [Koha-bugs] [Bug 19496] Patron notes about item does not get
 emailed as indicated
In-Reply-To: <bug-19496-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-19496-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-19496-70-dHcIh3hUeG@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19496

Jonathan Druart <jonathan.druart at bugs.koha-community.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
         Depends on|                            |14224
                 CC|                            |jonathan.druart at bugs.koha-c
                   |                            |ommunity.org
           Assignee|oleonard at myacpl.org         |aleisha at catalyst.net.nz
           Keywords|                            |rel_17_11_candidate
             Status|NEW                         |ASSIGNED
            Version|17.05                       |master

--- Comment #1 from Jonathan Druart <jonathan.druart at bugs.koha-community.org> ---
Aleisha, can you take care of this one please?


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14224
[Bug 14224] patron notes about item shown at check in
-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Nov  2 12:30:55 2017
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 02 Nov 2017 11:30:55 +0000
Subject: [Koha-bugs] [Bug 18915] Creating a checkout note (patron note)
 sends an incomplete email message
In-Reply-To: <bug-18915-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-18915-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-18915-70-9itRs3L5p3@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18915

Jonathan Druart <jonathan.druart at bugs.koha-community.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
           Keywords|                            |rel_17_11_candidate
           Severity|enhancement                 |normal

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Nov  2 12:32:11 2017
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 02 Nov 2017 11:32:11 +0000
Subject: [Koha-bugs] [Bug 19543] Koha does not reserve an item if there is
 one available in another library.
In-Reply-To: <bug-19543-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-19543-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-19543-70-Q1DXJKeypB@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19543

--- Comment #6 from Cristian <cristianbiblio at gmail.com> ---
(In reply to Jonathan Druart from comment #4)
> Cristian, can you confirm that this is a duplicate of bug 18547?

Hi Jonathan, I'll confirm. It also appears to be a duplicate of bug 18366.

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.

From bugzilla-daemon at bugs.koha-community.org  Thu Nov  2 12:36:41 2017
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 02 Nov 2017 11:36:41 +0000
Subject: [Koha-bugs] [Bug 18547] On shelf holds allowed > "If all
 unavailable" ignores default hold policy
In-Reply-To: <bug-18547-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-18547-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-18547-70-TzLRK8Ffo9@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18547

Jonathan Druart <jonathan.druart at bugs.koha-community.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
           Keywords|                            |rel_17_11_candidate

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Nov  2 12:40:24 2017
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 02 Nov 2017 11:40:24 +0000
Subject: [Koha-bugs] [Bug 19456] Some pages title tag contains html
In-Reply-To: <bug-19456-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-19456-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-19456-70-m7nfnnXspD@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19456

--- Comment #11 from Jonathan Druart <jonathan.druart at bugs.koha-community.org> ---
(In reply to David Bourgault from comment #9)
> Worked as planned, QA tool green across the board.

Do not forget to add your 'signed-off-by' line to the patch.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Nov  2 12:46:48 2017
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 02 Nov 2017 11:46:48 +0000
Subject: [Koha-bugs] [Bug 19548] Search Result Second page not available
In-Reply-To: <bug-19548-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-19548-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-19548-70-2xp6Chjzgs@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19548

Jonathan Druart <jonathan.druart at bugs.koha-community.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |jonathan.druart at bugs.koha-c
                   |                            |ommunity.org

--- Comment #1 from Jonathan Druart <jonathan.druart at bugs.koha-community.org> ---
Which version of Koha are you using?
Can you give us an example of title with quotation mark to search for?

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.

From bugzilla-daemon at bugs.koha-community.org  Thu Nov  2 12:48:34 2017
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 02 Nov 2017 11:48:34 +0000
Subject: [Koha-bugs] [Bug 17015] New Koha Calendar
In-Reply-To: <bug-17015-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-17015-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-17015-70-zFW8Bplc6L@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17015

--- Comment #113 from Andreas Hedstr?m Mace <andreas.hedstrom.mace at sub.su.se> ---
Shouldn't this bug have status Signed off?

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Nov  2 12:54:07 2017
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 02 Nov 2017 11:54:07 +0000
Subject: [Koha-bugs] [Bug 19492] Field 'lowestPriority' doesn't have a
 default value (MariaDB)
In-Reply-To: <bug-19492-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-19492-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-19492-70-JDSsksV89q@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19492

Jonathan Druart <jonathan.druart at bugs.koha-community.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Blocks|                            |17258

--- Comment #3 from Jonathan Druart <jonathan.druart at bugs.koha-community.org> ---
The "doesn't have a default value" is related to the STRICT_TRANS_TABLES mode,
with NO_ENGINE_SUBSTITUTION you should not get this error.

Can you confirm you restarted the service and you still get this error?


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17258
[Bug 17258] [OMNIBUS] MySQL 5.7
-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.

From bugzilla-daemon at bugs.koha-community.org  Thu Nov  2 12:54:07 2017
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 02 Nov 2017 11:54:07 +0000
Subject: [Koha-bugs] [Bug 17258] [OMNIBUS] MySQL 5.7
In-Reply-To: <bug-17258-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-17258-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-17258-70-esExVP1kwO@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17258

Jonathan Druart <jonathan.druart at bugs.koha-community.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
         Depends on|                            |19492


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19492
[Bug 19492] Field 'lowestPriority' doesn't have a default value (MariaDB)
-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Nov  2 13:09:44 2017
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 02 Nov 2017 12:09:44 +0000
Subject: [Koha-bugs] [Bug 19562] Inventory: How can we skip convolutes
 marked as problematic with no_barcode?
In-Reply-To: <bug-19562-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-19562-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-19562-70-Zm5hOoMfOS@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19562

--- Comment #1 from Marcel de Rooy <m.de.rooy at rijksmuseum.nl> ---
(In reply to Marcel de Rooy from comment #0)
> A simple custom solution is:
> $item->{problems}->{no_barcode} = 1 unless $item->{itemnotes} =~
> /convolute/i;

This actually is too simple, since GetItemsForInventory does not return
itemnotes. But you get the point.

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.

From bugzilla-daemon at bugs.koha-community.org  Thu Nov  2 13:36:48 2017
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 02 Nov 2017 12:36:48 +0000
Subject: [Koha-bugs] [Bug 19563] New: Generation of sort_fields uses
	incorrect condition
Message-ID: <bug-19563-70@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19563

            Bug ID: 19563
           Summary: Generation of sort_fields uses incorrect condition
 Change sponsored?: ---
           Product: Koha
           Version: master
          Hardware: All
                OS: All
            Status: NEW
          Severity: major
          Priority: P5 - low
         Component: Searching - Elasticsearch
          Assignee: koha-bugs at lists.koha-community.org
          Reporter: glasklas at gmail.com

Incorrect condition for generation of sort field mappings etc, will post patch
shortly.

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Nov  2 13:36:58 2017
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 02 Nov 2017 12:36:58 +0000
Subject: [Koha-bugs] [Bug 17015] New Koha Calendar
In-Reply-To: <bug-17015-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-17015-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-17015-70-VMtMtS3Y2W@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17015

--- Comment #114 from David Bourgault <david.bourgault at inlibro.com> ---
The signoff was done before a rebase, so I figured I'd ask for another signoff
in case I screwed up my rebase.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Nov  2 13:42:53 2017
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 02 Nov 2017 12:42:53 +0000
Subject: [Koha-bugs] [Bug 18915] Creating a checkout note (patron note)
 sends an incomplete email message
In-Reply-To: <bug-18915-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-18915-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-18915-70-aZbqSoRVCy@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18915

--- Comment #8 from M. Tompsett <mtompset at hotmail.com> ---
Comment on attachment 66518
  --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=66518
Bug 18915: Fix checkout note email message

Review of attachment 66518:
 --> (https://bugs.koha-community.org/bugzilla3/page.cgi?id=splinter.html&bug=18915&attachment=66518)
-----------------------------------------------------------------

::: installer/data/mysql/updatedatabase.pl
@@ +14308,4 @@
>  
>      $dbh->do(q|
>          INSERT IGNORE INTO letter (`module`, `code`, `branchcode`, `name`, `is_html`, `title`, `content`, `message_transport_type`)
> +        VALUES ('circulation', 'CHECKOUT_NOTE', '', 'Checkout note on item set by patron', '0', 'Checkout note', '<<borrowers.firstname>> <<borrowers.surname>> has added a note to the item <<biblio.title>> - <<biblio.author>> (<<biblio.biblionumber>>).','email');

I don't think updatedatabase should be modified like this. This is already
done. You add a new DB update which tweaks PATRON_NOTE into CHECKOUT_NOTE, if
this is correct logic.

::: opac/svc/patron_notes
@@ +82,4 @@
>                  my $biblionumber = $issue->item->biblionumber;
>                  my $letter = C4::Letters::GetPreparedLetter (
>                      module => 'circulation',
> +                    letter_code => 'CHECKOUT_NOTE',

Why even change the letter code, given that you aren't changing the svc name?

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Nov  2 14:11:06 2017
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 02 Nov 2017 13:11:06 +0000
Subject: [Koha-bugs] [Bug 19563] Generation of sort_fields uses incorrect
	condition
In-Reply-To: <bug-19563-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-19563-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-19563-70-RPb8aD8hZD@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19563

--- Comment #1 from David Gustafsson <glasklas at gmail.com> ---
Created attachment 68889
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=68889&action=edit
Bug 19563: Generation of sort_fields uses incorrect condition

Fix incorrect condition for if clause for generating <field>__sort mappings
for Elasticsearch. Also remove redundant check for same condition when
generating fixer rules.

Test plan:
1. Inspect current mappings for example by viewing:
http://<elasticsearch_host>:9200/koha_<koha_instance_name>_biblios/_mapping.
2. If using the default configuraion only "author" has a sort field
(author__sort).
4. Appy patch.
5. Reindex using rebuild_elastic_search.pl.
6. All fields except those with sort sort set to "0" should now have sort
fields, which in the default configuration is all but "author".

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.

From bugzilla-daemon at bugs.koha-community.org  Thu Nov  2 14:22:06 2017
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 02 Nov 2017 13:22:06 +0000
Subject: [Koha-bugs] [Bug 18712] make test is failing with an empty DB -
	t/Matcher.t
In-Reply-To: <bug-18712-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-18712-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-18712-70-Ez5lBDXF4J@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18712

Jonathan Druart <jonathan.druart at bugs.koha-community.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
           Assignee|gmcharlt at gmail.com          |jonathan.druart at bugs.koha-c
                   |                            |ommunity.org
                 CC|                            |jonathan.druart at bugs.koha-c
                   |                            |ommunity.org
            Summary|Run database_dependent test |make test is failing with
                   |suite --No ignored          |an empty DB - t/Matcher.t
            Version|17.05                       |master
             Status|NEW                         |ASSIGNED

--- Comment #3 from Jonathan Druart <jonathan.druart at bugs.koha-community.org> ---
We have 2 problems here:
1/ t/Matcher.t is failing with an empty DB, the data are not mocked correctly
(Prices.t has been fixed earlier, maybe with bug 18289)
2/ We access DB during compilation time, which is quite bad.
>From C4::Auth, we retrieve system preference values in the BEGIN block:
  62     $cas       = C4::Context->preference('casAuthentication');
  64     $caslogout = C4::Context->preference('casLogout');
This should be rewritten and fixed, but it does not prevent the tests to pass,
but raises the "DBI connect failed" warning.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Nov  2 14:24:13 2017
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 02 Nov 2017 13:24:13 +0000
Subject: [Koha-bugs] [Bug 18712] make test is failing with an empty DB -
	t/Matcher.t
In-Reply-To: <bug-18712-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-18712-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-18712-70-eMTFESsHnJ@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18712

Jonathan Druart <jonathan.druart at bugs.koha-community.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|ASSIGNED                    |Needs Signoff

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Nov  2 14:24:16 2017
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 02 Nov 2017 13:24:16 +0000
Subject: [Koha-bugs] [Bug 18712] make test is failing with an empty DB -
	t/Matcher.t
In-Reply-To: <bug-18712-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-18712-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-18712-70-Lgaz3Q41Db@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18712

--- Comment #4 from Jonathan Druart <jonathan.druart at bugs.koha-community.org> ---
Created attachment 68890
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=68890&action=edit
Bug 18712: Fix t/Matcher.t if DB is empty

t/Matcher.t is failing with an empty DB, the data are not mocked
correctly

Test plan:
drop your DB and recreate it without any data and prove t/Matcher.t

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Nov  2 14:26:52 2017
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 02 Nov 2017 13:26:52 +0000
Subject: [Koha-bugs] [Bug 17015] New Koha Calendar
In-Reply-To: <bug-17015-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-17015-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-17015-70-hInyyeCnCD@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17015

--- Comment #115 from David Bourgault <david.bourgault at inlibro.com> ---
I've been told that isn't necessary.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Nov  2 14:27:17 2017
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 02 Nov 2017 13:27:17 +0000
Subject: [Koha-bugs] [Bug 17015] New Koha Calendar
In-Reply-To: <bug-17015-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-17015-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-17015-70-dH9Tl0eK4G@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17015

David Bourgault <david.bourgault at inlibro.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Needs Signoff               |Signed Off

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Nov  2 14:28:50 2017
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 02 Nov 2017 13:28:50 +0000
Subject: [Koha-bugs] [Bug 18712] make test is failing with an empty DB -
	t/Matcher.t
In-Reply-To: <bug-18712-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-18712-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-18712-70-K9n5xkRuEc@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18712

--- Comment #5 from Jonathan Druart <jonathan.druart at bugs.koha-community.org> ---
Created attachment 68891
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=68891&action=edit
Bug 18712: Remove unecessary fixtures

2 fixtures are in a subroutine that is never called, it can be removed

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Nov  2 14:41:37 2017
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 02 Nov 2017 13:41:37 +0000
Subject: [Koha-bugs] [Bug 19540] opac-reserve does not correctly warn of
 too_much reserves
In-Reply-To: <bug-19540-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-19540-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-19540-70-ZEHNHC4yxV@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19540

Jonathan Druart <jonathan.druart at bugs.koha-community.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |fridolin.somers at biblibre.co
                   |                            |m

--- Comment #2 from Jonathan Druart <jonathan.druart at bugs.koha-community.org> ---
*** Bug 11160 has been marked as a duplicate of this bug. ***

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Nov  2 14:41:37 2017
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 02 Nov 2017 13:41:37 +0000
Subject: [Koha-bugs] [Bug 11160] Better message when placing hold at OPAC is
	blocked
In-Reply-To: <bug-11160-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-11160-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-11160-70-2hvbGNAipO@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11160

Jonathan Druart <jonathan.druart at bugs.koha-community.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|NEW                         |RESOLVED
                 CC|                            |jonathan.druart at bugs.koha-c
                   |                            |ommunity.org
         Resolution|---                         |DUPLICATE

--- Comment #1 from Jonathan Druart <jonathan.druart at bugs.koha-community.org> ---


*** This bug has been marked as a duplicate of bug 19540 ***

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Nov  2 14:41:49 2017
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 02 Nov 2017 13:41:49 +0000
Subject: [Koha-bugs] [Bug 16787] 'Too many holds' message appears
 inappropriately and is missing data
In-Reply-To: <bug-16787-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-16787-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-16787-70-KxnSVIgF4E@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16787

Jonathan Druart <jonathan.druart at bugs.koha-community.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
           See Also|                            |https://bugs.koha-community
                   |                            |.org/bugzilla3/show_bug.cgi
                   |                            |?id=19540
                 CC|                            |jonathan.druart at bugs.koha-c
                   |                            |ommunity.org

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Nov  2 14:41:49 2017
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 02 Nov 2017 13:41:49 +0000
Subject: [Koha-bugs] [Bug 19540] opac-reserve does not correctly warn of
 too_much reserves
In-Reply-To: <bug-19540-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-19540-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-19540-70-ohbRPc0ViO@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19540

Jonathan Druart <jonathan.druart at bugs.koha-community.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
           See Also|                            |https://bugs.koha-community
                   |                            |.org/bugzilla3/show_bug.cgi
                   |                            |?id=16787

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.

From bugzilla-daemon at bugs.koha-community.org  Thu Nov  2 14:55:05 2017
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 02 Nov 2017 13:55:05 +0000
Subject: [Koha-bugs] [Bug 19564] New: Fix extraction of sort order from sort
 condition name
Message-ID: <bug-19564-70@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19564

            Bug ID: 19564
           Summary: Fix extraction of sort order from sort condition name
 Change sponsored?: ---
           Product: Koha
           Version: master
          Hardware: All
                OS: All
            Status: NEW
          Severity: normal
          Priority: P5 - low
         Component: Searching - Elasticsearch
          Assignee: koha-bugs at lists.koha-community.org
          Reporter: glasklas at gmail.com

Currently sort order is extracted from sort condition with "my ( $f, $d ) =
split /_/;"
So for example with the value "call_number_asc", you get $f (field) "call", and
$d (order) "number", when expecting to get "call_number" and "asc". This should
be changes using a regular expression instead.

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Nov  2 14:55:25 2017
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 02 Nov 2017 13:55:25 +0000
Subject: [Koha-bugs] [Bug 19564] Fix extraction of sort order from sort
	condition name
In-Reply-To: <bug-19564-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-19564-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-19564-70-BxYfVbUCTF@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19564

David Gustafsson <glasklas at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
           Assignee|koha-bugs at lists.koha-commun |glasklas at gmail.com
                   |ity.org                     |

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.

From bugzilla-daemon at bugs.koha-community.org  Thu Nov  2 15:07:05 2017
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 02 Nov 2017 14:07:05 +0000
Subject: [Koha-bugs] [Bug 19564] Fix extraction of sort order from sort
	condition name
In-Reply-To: <bug-19564-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-19564-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-19564-70-A7bdMupkWL@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19564

--- Comment #1 from David Gustafsson <glasklas at gmail.com> ---
Created attachment 68892
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=68892&action=edit
Bug 19564: Fix extraction of sort order from sort condition name

Currently sort order is extracted from sort condition by splitting the
field, instead use regular expression to extract the last part preceded
by underscore.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Nov  2 15:10:41 2017
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 02 Nov 2017 14:10:41 +0000
Subject: [Koha-bugs] [Bug 19564] Fix extraction of sort order from sort
	condition name
In-Reply-To: <bug-19564-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-19564-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-19564-70-QPupFctlzQ@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19564

--- Comment #2 from David Gustafsson <glasklas at gmail.com> ---
I did not add a test-case since sorting does currently work anyway because of
other unrelated bugs (which I can link to once having created issues and
submitted fixes f). But this Perl code can be executed to illustrate the issue
(and fix):

my ( $f, $d ) = "call_number_asc" =~ /(.+)_(.+)/;
print "$f $d\n";
( $f, $d ) = split /_/, "call_number_asc";
print "$f $d\n";

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Nov  2 15:33:52 2017
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 02 Nov 2017 14:33:52 +0000
Subject: [Koha-bugs] [Bug 19565] New: Fix regular expression in
 _truncate_terms so field names are not split up
Message-ID: <bug-19565-70@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19565

            Bug ID: 19565
           Summary: Fix regular expression in _truncate_terms so field
                    names are not split up
 Change sponsored?: ---
           Product: Koha
           Version: master
          Hardware: All
                OS: All
            Status: NEW
          Severity: normal
          Priority: P5 - low
         Component: Searching - Elasticsearch
          Assignee: koha-bugs at lists.koha-community.org
          Reporter: glasklas at gmail.com

The regular expression used for extraction search terms does not allow for
field names containing "." or "-". For example Control-number.raw:"123", would
be split up into: "Control-number." and "raw\"123\"". "Control-number:"123"
into "Control-", "number:\"123\"". The regular expression needs to be adjusted
to allow for certain valid characters ("." and "-" most importantly) in field
names.

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.

From bugzilla-daemon at bugs.koha-community.org  Thu Nov  2 15:34:15 2017
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 02 Nov 2017 14:34:15 +0000
Subject: [Koha-bugs] [Bug 19565] Fix regular expression in _truncate_terms
 so field names are not split up
In-Reply-To: <bug-19565-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-19565-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-19565-70-FzCXVqkKXu@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19565

David Gustafsson <glasklas at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
           Assignee|koha-bugs at lists.koha-commun |glasklas at gmail.com
                   |ity.org                     |

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Nov  2 15:53:23 2017
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 02 Nov 2017 14:53:23 +0000
Subject: [Koha-bugs] [Bug 19565] Fix regular expression in _truncate_terms
 so field names are not split up
In-Reply-To: <bug-19565-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-19565-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-19565-70-ncbnhKzdh7@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19565

--- Comment #1 from David Gustafsson <glasklas at gmail.com> ---
Created attachment 68893
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=68893&action=edit
Bug 19565: Fix regular expression in _truncate_terms so field names are not
split up

The regular expression used for tokenizing search string does not allow for
field names containing "." or "-". Fix regular expression to allow for field
names containing "." or "-".

Test plan:
1. Make sure Elasticsearch is used as default search engine.
2. Select "Search the catalog" in the staff client front page.
3. Search for Control-number.raw="<control number>" where <control
number> is an existing control number. (The quotes around are value are needed
to prevent
Koha from appending "*" to control number).
4. The search should not yield any results.
5. Apply patch.
6. Search again using the same condition.
7. The biblio with the control number used in the search should appear as a
match.
8. Search for Control-number="<control number>".
9. The biblio with the control number used in the search should appear as a
match.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Nov  2 15:55:11 2017
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 02 Nov 2017 14:55:11 +0000
Subject: [Koha-bugs] [Bug 19563] Generation of sort_fields uses incorrect
	condition
In-Reply-To: <bug-19563-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-19563-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-19563-70-jQ9aROY46N@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19563

David Gustafsson <glasklas at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
           Assignee|koha-bugs at lists.koha-commun |glasklas at gmail.com
                   |ity.org                     |

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Nov  2 15:59:38 2017
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 02 Nov 2017 14:59:38 +0000
Subject: [Koha-bugs] [Bug 19565] Fix regular expression in _truncate_terms
 so field names are not split up
In-Reply-To: <bug-19565-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-19565-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-19565-70-yFh9zRzC83@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19565

--- Comment #2 from David Gustafsson <glasklas at gmail.com> ---
Just saw this bug was recently reported in:
"https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19559", which also
contains a test case. Would be nice if "." could also be included as a valid
field name character though.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Nov  2 16:01:25 2017
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 02 Nov 2017 15:01:25 +0000
Subject: [Koha-bugs] [Bug 19559] Elasticsearch QueryAutoTruncate truncate
 field names with hyphens if data is quoted
In-Reply-To: <bug-19559-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-19559-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-19559-70-zbKiXqGh5G@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19559

David Gustafsson <glasklas at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |glasklas at gmail.com

--- Comment #3 from David Gustafsson <glasklas at gmail.com> ---
*** Bug 19565 has been marked as a duplicate of this bug. ***

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Nov  2 16:01:25 2017
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 02 Nov 2017 15:01:25 +0000
Subject: [Koha-bugs] [Bug 19565] Fix regular expression in _truncate_terms
 so field names are not split up
In-Reply-To: <bug-19565-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-19565-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-19565-70-bV2sVf2yB9@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19565

David Gustafsson <glasklas at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
         Resolution|---                         |DUPLICATE
             Status|NEW                         |RESOLVED

--- Comment #3 from David Gustafsson <glasklas at gmail.com> ---


*** This bug has been marked as a duplicate of bug 19559 ***

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Nov  2 16:03:26 2017
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 02 Nov 2017 15:03:26 +0000
Subject: [Koha-bugs] [Bug 19559] Elasticsearch QueryAutoTruncate truncate
 field names with hyphens if data is quoted
In-Reply-To: <bug-19559-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-19559-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-19559-70-ISTRYax8Rg@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19559

--- Comment #4 from David Gustafsson <glasklas at gmail.com> ---
Would be nice if "." could as be included as a valid field characters, since it
is used for subfields in Elasticsearch. ("Control-number.raw" for example).

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Nov  2 17:00:33 2017
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 02 Nov 2017 16:00:33 +0000
Subject: [Koha-bugs] [Bug 16787] 'Too many holds' message appears
 inappropriately and is missing data
In-Reply-To: <bug-16787-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-16787-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-16787-70-g1fZkLp2jG@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16787

Jonathan Druart <jonathan.druart at bugs.koha-community.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|NEW                         |Needs Signoff

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.

From bugzilla-daemon at bugs.koha-community.org  Thu Nov  2 17:00:37 2017
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 02 Nov 2017 16:00:37 +0000
Subject: [Koha-bugs] [Bug 16787] 'Too many holds' message appears
 inappropriately and is missing data
In-Reply-To: <bug-16787-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-16787-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-16787-70-0lL3wLYY2Z@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16787

Jonathan Druart <jonathan.druart at bugs.koha-community.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #52652|0                           |1
        is obsolete|                            |

--- Comment #5 from Jonathan Druart <jonathan.druart at bugs.koha-community.org> ---
Created attachment 68894
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=68894&action=edit
Bug 16787: 'Too many holds' message appears inappropriately and is missing data

This patch alters C4/Reserves.pm to pass back 'noReservesAllowed' when
allowedreserves=0. This allows passing to the user an appropriate
message about the availability of items for holds

To test:
1 - Set an item type to allow no holds
2 - Attempt to place a hold for a patron
3 - Message should be "No holds allowed: [Firstname Surname] cannot
place holds on any of these items"
4 - Try placing a multihold with the record above and a holdable record,
  message should end "...cannot place holds on some of these titles'
  items"

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Nov  2 17:00:40 2017
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 02 Nov 2017 16:00:40 +0000
Subject: [Koha-bugs] [Bug 16787] 'Too many holds' message appears
 inappropriately and is missing data
In-Reply-To: <bug-16787-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-16787-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-16787-70-PK2whpThnQ@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16787

--- Comment #6 from Jonathan Druart <jonathan.druart at bugs.koha-community.org> ---
Created attachment 68895
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=68895&action=edit
Bug 16787: Add tests

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.

From bugzilla-daemon at bugs.koha-community.org  Thu Nov  2 17:26:57 2017
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 02 Nov 2017 16:26:57 +0000
Subject: [Koha-bugs] [Bug 18357] On-site checkouts issues with 'Unlimited'
In-Reply-To: <bug-18357-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-18357-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-18357-70-X83iSDISri@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18357

Jonathan Druart <jonathan.druart at bugs.koha-community.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|NEW                         |Needs Signoff

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Nov  2 17:27:00 2017
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 02 Nov 2017 16:27:00 +0000
Subject: [Koha-bugs] [Bug 18357] On-site checkouts issues with 'Unlimited'
In-Reply-To: <bug-18357-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-18357-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-18357-70-VChxNudqaG@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18357

--- Comment #4 from Jonathan Druart <jonathan.druart at bugs.koha-community.org> ---
Created attachment 68896
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=68896&action=edit
Bug 18357: Handle unlimited on-site checkouts

If on-site checkouts are set to unlimited (i.e. NULL/undef), they are
currently blocked.

Test plan:
1/ Set All/All rule with Unlimited/unlimited for normal/onsite checkouts
2/ Will be able to perform onsite checkout
3/ Edit rule to be 15/Unlimited normal/onsite
4/ Will be able to perform onsite checkout
=> Without this patch it was blocked
5/ Set rule to 15/15
6/ Onsite checkouts work again

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.

From bugzilla-daemon at bugs.koha-community.org  Thu Nov  2 17:27:59 2017
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 02 Nov 2017 16:27:59 +0000
Subject: [Koha-bugs] [Bug 18357] On-site checkouts issues with 'Unlimited'
In-Reply-To: <bug-18357-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-18357-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-18357-70-YloRWMlfcr@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18357

Jonathan Druart <jonathan.druart at bugs.koha-community.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
         Depends on|                            |14045
         QA Contact|testopia at bugs.koha-communit |jonathan.druart at bugs.koha-c
                   |y.org                       |ommunity.org


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14045
[Bug 14045] Add specific quotas to on-site checkout
-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Nov  2 17:28:14 2017
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 02 Nov 2017 16:28:14 +0000
Subject: [Koha-bugs] [Bug 18357] On-site checkouts issues with 'Unlimited'
In-Reply-To: <bug-18357-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-18357-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-18357-70-5M4iChmi3N@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18357

Jonathan Druart <jonathan.druart at bugs.koha-community.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
           See Also|https://bugs.koha-community |
                   |.org/bugzilla3/show_bug.cgi |
                   |?id=18321                   |

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.

From bugzilla-daemon at bugs.koha-community.org  Thu Nov  2 17:28:14 2017
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 02 Nov 2017 16:28:14 +0000
Subject: [Koha-bugs] [Bug 18321] One more checkouts possible than allowed by
	rules
In-Reply-To: <bug-18321-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-18321-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-18321-70-HoaarLJLlj@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18321

Jonathan Druart <jonathan.druart at bugs.koha-community.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
           See Also|https://bugs.koha-community |
                   |.org/bugzilla3/show_bug.cgi |
                   |?id=18357                   |

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Nov  2 17:27:59 2017
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 02 Nov 2017 16:27:59 +0000
Subject: [Koha-bugs] [Bug 14045] Add specific quotas to on-site checkout
In-Reply-To: <bug-14045-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-14045-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-14045-70-y9vnX4ZCpU@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14045

Jonathan Druart <jonathan.druart at bugs.koha-community.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Blocks|                            |18357


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18357
[Bug 18357] On-site checkouts issues with 'Unlimited'
-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Nov  2 17:53:56 2017
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 02 Nov 2017 16:53:56 +0000
Subject: [Koha-bugs] [Bug 17661] Differences in whitespace cause duplicate
	facets
In-Reply-To: <bug-17661-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-17661-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-17661-70-FyWgGxcHXy@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17661

--- Comment #2 from Nick Clemens <nick at bywatersolutions.com> ---
Created attachment 68897
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=68897&action=edit
Bug 17661 - Ending punctuation causes duplicate facets

WIP

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Nov  2 17:54:27 2017
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 02 Nov 2017 16:54:27 +0000
Subject: [Koha-bugs] [Bug 17661] Differences in whitespace cause duplicate
	facets
In-Reply-To: <bug-17661-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-17661-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-17661-70-cJidubsP44@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17661

Nick Clemens <nick at bywatersolutions.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |nick at bywatersolutions.com

--- Comment #3 from Nick Clemens <nick at bywatersolutions.com> ---
Should expand this patch to cover whitespace, also need ES coverage, also
better bug title

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Nov  2 17:54:37 2017
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 02 Nov 2017 16:54:37 +0000
Subject: [Koha-bugs] [Bug 17661] Differences in whitespace cause duplicate
	facets
In-Reply-To: <bug-17661-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-17661-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-17661-70-RHr8u67uH6@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17661

Nick Clemens <nick at bywatersolutions.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
           Assignee|gmcharlt at gmail.com          |nick at bywatersolutions.com

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Nov  2 18:08:09 2017
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 02 Nov 2017 17:08:09 +0000
Subject: [Koha-bugs] [Bug 19566] New: Integrate multiple instance
 auto_increment fix from KohaAloha
Message-ID: <bug-19566-70@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19566

            Bug ID: 19566
           Summary: Integrate  multiple instance auto_increment fix from
                    KohaAloha
 Change sponsored?: ---
           Product: Koha
           Version: master
          Hardware: All
                OS: All
            Status: NEW
          Severity: enhancement
          Priority: P5 - low
         Component: Packaging
          Assignee: koha-bugs at lists.koha-community.org
          Reporter: pongtawat at punsarn.asia
        QA Contact: testopia at bugs.koha-community.org
                CC: mirko at abunchofthings.net

In the Wiki https://wiki.koha-community.org/wiki/DBMS_auto_increment_fix, there
is a link to a solution for auto_increment problem by KohaAloha:

https://github.com/KohaAloha/koha-mysql-init

This solution automatically work with multiple instances and if integrated into
Koha Debian package, does not require any work manual fix by the user at all.

So I would like to propose this solution to be integrate into Debian package by
default for all supported releases that target Debian 8/9 (with systemd).

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.

From bugzilla-daemon at bugs.koha-community.org  Thu Nov  2 18:15:01 2017
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 02 Nov 2017 17:15:01 +0000
Subject: [Koha-bugs] [Bug 6918] can't place holds on 'on order' items with
 AllowOnShelfHolds off
In-Reply-To: <bug-6918-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-6918-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-6918-70-ufkcPnNQ7n@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6918

Jonathan Druart <jonathan.druart at bugs.koha-community.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #19087|0                           |1
        is obsolete|                            |

--- Comment #26 from Jonathan Druart <jonathan.druart at bugs.koha-community.org> ---
Created attachment 68898
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=68898&action=edit
Bug 6918 - can't place holds on 'on order' items with AllowOnShelfHolds off

Test Plan:
1) Apply patch
2) Turn off AllowOnShelfHolds
3) Create a bib with one item, mark the item as 'on order'
4) Attempt to place a hold on the item, you should now be able to do so

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the QA Contact for the bug.

From bugzilla-daemon at bugs.koha-community.org  Thu Nov  2 18:14:56 2017
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 02 Nov 2017 17:14:56 +0000
Subject: [Koha-bugs] [Bug 6918] can't place holds on 'on order' items with
 AllowOnShelfHolds off
In-Reply-To: <bug-6918-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-6918-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-6918-70-I4UWR2Lxb5@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6918

Jonathan Druart <jonathan.druart at bugs.koha-community.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|In Discussion               |Needs Signoff

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the QA Contact for the bug.

From bugzilla-daemon at bugs.koha-community.org  Thu Nov  2 18:16:03 2017
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 02 Nov 2017 17:16:03 +0000
Subject: [Koha-bugs] [Bug 19567] New: Development
Message-ID: <bug-19567-70@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19567

            Bug ID: 19567
           Summary: Development
 Change sponsored?: ---
           Product: Koha
           Version: master
          Hardware: All
                OS: All
            Status: NEW
          Severity: enhancement
          Priority: P5 - low
         Component: Architecture, internals, and plumbing
          Assignee: jesse at bywatersolutions.com
          Reporter: kyle at bywatersolutions.com
        QA Contact: testopia at bugs.koha-community.org

1. Add new ?Merge selected? button to the patrons toolbar

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Nov  2 18:16:32 2017
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 02 Nov 2017 17:16:32 +0000
Subject: [Koha-bugs] [Bug 6918] can't place holds on 'on order' items with
 AllowOnShelfHolds off
In-Reply-To: <bug-6918-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-6918-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-6918-70-KhBRTcm9C9@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6918

--- Comment #27 from Jonathan Druart <jonathan.druart at bugs.koha-community.org> ---
Patch rebased and rewritten, please test.

Srdjan's concern is not valid IMO.

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the QA Contact for the bug.

From bugzilla-daemon at bugs.koha-community.org  Thu Nov  2 18:45:05 2017
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 02 Nov 2017 17:45:05 +0000
Subject: [Koha-bugs] [Bug 18821] TrackLastPatronActivity is a performance
	killer
In-Reply-To: <bug-18821-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-18821-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-18821-70-s0Tvun3Fui@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18821

Jonathan Druart <jonathan.druart at bugs.koha-community.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|In Discussion               |Failed QA
         Depends on|                            |16276
                 CC|                            |jonathan.druart at bugs.koha-c
                   |                            |ommunity.org


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16276
[Bug 16276] When automatically deleting expired borrowers, make sure they
didn't log in recently
-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Nov  2 18:45:05 2017
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 02 Nov 2017 17:45:05 +0000
Subject: [Koha-bugs] [Bug 16276] When automatically deleting expired
 borrowers, make sure they didn't log in recently
In-Reply-To: <bug-16276-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-16276-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-16276-70-bPEz5UX69L@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16276

Jonathan Druart <jonathan.druart at bugs.koha-community.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Blocks|                            |18821


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18821
[Bug 18821] TrackLastPatronActivity is a performance killer
-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Nov  2 20:50:00 2017
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 02 Nov 2017 19:50:00 +0000
Subject: [Koha-bugs] [Bug 16865] Patron self registration: hiding branchcode
 hides email and breaks workflow
In-Reply-To: <bug-16865-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-16865-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-16865-70-pkaJuZB80p@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16865

--- Comment #8 from Katrin Fischer <katrin.fischer at bsz-bw.de> ---
It's odd, I was testing in a 16.11.12. Will try to retest on master soon.

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Nov  2 20:59:26 2017
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 02 Nov 2017 19:59:26 +0000
Subject: [Koha-bugs] [Bug 17983] Add minutes loan to DiscreteCalendar
In-Reply-To: <bug-17983-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-17983-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-17983-70-rJt83voxdK@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17983

--- Comment #18 from J Schmidt <jschmidt at switchinc.org> ---
(In reply to Blou from comment #17)
> Hi Jen,
> 
> I'm curious, those things (calendar...) are put in with Bug 17015.  You've
> applied it first (I presume), have you tested it before applying 17983? 
> That could help us see where the issue is.

Hi,
I typically use ByWater's sandbox page and click "Apply" for a specific
sandbox. I think that action means it will apply any dependent patches
automatically.  Nick at ByWater relayed I should look into the syspref to set
it to SpecifyDueDate which I did not do. I'll test again and do that system
pref.  Thank you. jls.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Nov  2 21:30:06 2017
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 02 Nov 2017 20:30:06 +0000
Subject: [Koha-bugs] [Bug 19572] New: opac-result item avaibility not the
 same as opac-detail shows
Message-ID: <bug-19572-70@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19572

            Bug ID: 19572
           Summary: opac-result item avaibility not the same as
                    opac-detail shows
 Change sponsored?: ---
           Product: Koha
           Version: master
          Hardware: All
                OS: All
            Status: NEW
          Severity: minor
          Priority: P5 - low
         Component: OPAC
          Assignee: oleonard at myacpl.org
          Reporter: david.bourgault at inlibro.com
        QA Contact: testopia at bugs.koha-community.org

This is an issue two of our clients have encountered : the item avaibility in
the result page does not match the one in the detail page.

e.g.: The items have a notforloan value of -2, which is mapped through
Authorised_Values to "In Processing" (or equivalent) but on the OPAC result
page, it is displayed as "On Order". The detailed page show the correct value.

>From my analysis, this is because whereas the intranet results and the opac
details use the database to get items statuses, the opac result goes through
the XSLT processing, and doesn't have access to the Authorised_Values table.
This is worked around by some hardcoded values in the "item namespace" created
by XSLT.pm.

It's possible to fix this issue case-by-case for each client, but that's a very
ugly solution.

I don't plan to submit a patch to this bug, because I am not sure how to solve
the issue.

(If my explanations are unclear please tell me)

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Nov  2 21:45:06 2017
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 02 Nov 2017 20:45:06 +0000
Subject: [Koha-bugs] [Bug 19572] opac-result item avaibility not the same as
 opac-detail shows
In-Reply-To: <bug-19572-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-19572-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-19572-70-PPiuMi4fyk@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19572

Katrin Fischer <katrin.fischer at bsz-bw.de> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |katrin.fischer at bsz-bw.de

--- Comment #1 from Katrin Fischer <katrin.fischer at bsz-bw.de> ---
The result page groups the different values, lost, not-for-loan (negative
values = on order, positive = reference). Fixing this to show the value from
the authorised values has been discussed on a different bug (can't locate it
right now)

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Nov  2 22:25:22 2017
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 02 Nov 2017 21:25:22 +0000
Subject: [Koha-bugs] [Bug 19573] New: Link to make a new list in masthead in
 OPAC only appears / works if no other list already exists
Message-ID: <bug-19573-70@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19573

            Bug ID: 19573
           Summary: Link to make a new list in masthead in OPAC only
                    appears / works if no other list already exists
 Change sponsored?: ---
           Product: Koha
           Version: 17.05
          Hardware: All
                OS: All
            Status: NEW
          Severity: enhancement
          Priority: P5 - low
         Component: OPAC
          Assignee: oleonard at myacpl.org
          Reporter: kelly at bywatersolutions.com
        QA Contact: testopia at bugs.koha-community.org

The new enhancement from bug 17948 allows for a quick New List option in the
List function found in the masthead in OPAC.  This enhancement can only be seen
when the patron has no lists already created.  If a patron has a private list
created, the option for that New List will not appear.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Nov  2 22:25:32 2017
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 02 Nov 2017 21:25:32 +0000
Subject: [Koha-bugs] [Bug 19573] Link to make a new list in masthead in OPAC
 only appears / works if no other list already exists
In-Reply-To: <bug-19573-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-19573-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-19573-70-ZAAnd3yKmM@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19573

Kelly McElligott <kelly at bywatersolutions.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |kelly at bywatersolutions.com

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Nov  2 22:44:03 2017
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 02 Nov 2017 21:44:03 +0000
Subject: [Koha-bugs] [Bug 9302] Add ability to merge patron records
In-Reply-To: <bug-9302-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-9302-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-9302-70-tOFptXrK42@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9302

John DeLooper <jdelooper at hccc.edu> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |jdelooper at hccc.edu

--- Comment #12 from John DeLooper <jdelooper at hccc.edu> ---
I too would love to see this kind of feature added, and am glad to see patches
in progress. I think a process for merging creates a smoother experience than
the current looking up duplicates and choosing which one to delete.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Nov  3 02:54:15 2017
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 03 Nov 2017 01:54:15 +0000
Subject: [Koha-bugs] [Bug 15679] Reset item level hold back to record level
 hold without deleting and readding the hold
In-Reply-To: <bug-15679-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-15679-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-15679-70-VV56VALUAw@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15679

Hugh Rundle <hughr at brimbank.vic.gov.au> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |hughr at brimbank.vic.gov.au

--- Comment #1 from Hugh Rundle <hughr at brimbank.vic.gov.au> ---
I agree, this is a major problem if a hold goes missing after it is allocated.
There doesn't seem to be a simple way to 'de-allocate' a hold and return it to
it's original state (i.e. a bib-level hold at the front of the queue).

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Nov  3 07:48:16 2017
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 03 Nov 2017 06:48:16 +0000
Subject: [Koha-bugs] [Bug 17179] Advanced editor: Add keyboard shortcuts to
 repeat (duplicate) a field, and cut text
In-Reply-To: <bug-17179-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-17179-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-17179-70-Twtz3cWOxD@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17179

Marcel de Rooy <m.de.rooy at rijksmuseum.nl> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Signed Off                  |Failed QA

--- Comment #6 from Marcel de Rooy <m.de.rooy at rijksmuseum.nl> ---
Thanks for your follow-up, Nick.
But Ctrl+Shift+V does not work. Most other keys seem to work such as Ctrl+I.
Ctrl+C worked most of the time, but not always?

Tested with Firefox under Windows. (Since Ctrl+letter combinations are widely
used already, they seem bad candidates.)

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Nov  3 07:51:07 2017
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 03 Nov 2017 06:51:07 +0000
Subject: [Koha-bugs] [Bug 19538] Advanced editor - Rancor - Move syspref
 from labs to cataloging and remove experimental note
In-Reply-To: <bug-19538-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-19538-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-19538-70-3q5TwqRDh8@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19538

Marcel de Rooy <m.de.rooy at rijksmuseum.nl> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Signed Off                  |In Discussion

--- Comment #3 from Marcel de Rooy <m.de.rooy at rijksmuseum.nl> ---
The short experiences that I have with Rancor do not provide me enough evidence
that this is no longer experimental. Since we now are just adding authority
support e.g., I would say this needs more time.
And above all, we need community feedback.

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Nov  3 07:53:47 2017
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 03 Nov 2017 06:53:47 +0000
Subject: [Koha-bugs] [Bug 18904] Advanced editor - Rancor - Add authority
	support
In-Reply-To: <bug-18904-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-18904-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-18904-70-hOhgVl1n6X@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18904

Marcel de Rooy <m.de.rooy at rijksmuseum.nl> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Signed Off                  |Failed QA

--- Comment #20 from Marcel de Rooy <m.de.rooy at rijksmuseum.nl> ---
 FAIL   authorities/blinddetail-biblio-search.pl
   OK     critic
   OK     forbidden patterns
   OK     git manipulation
   OK     pod
   SKIP   spelling
   FAIL   valid
                Global symbol "%subfields" requires explicit package name
                authorities/blinddetail-biblio-search.pl had compilation
errors.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Nov  3 08:27:28 2017
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 03 Nov 2017 07:27:28 +0000
Subject: [Koha-bugs] [Bug 19537] Authorities search doesn' t correctly
 populate subfield $2 source of heading
In-Reply-To: <bug-19537-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-19537-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-19537-70-tzWngz7ZdH@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19537

Marcel de Rooy <m.de.rooy at rijksmuseum.nl> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #68809|0                           |1
        is obsolete|                            |

--- Comment #3 from Marcel de Rooy <m.de.rooy at rijksmuseum.nl> ---
Created attachment 68903
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=68903&action=edit
Bug 19537: Correct addition of source subfield from authorities

To test:
1 - Find or create a subject authority
2 - Define 008/11 as 's' or 'r'
3 - Add 2nd indicator '7' to main heading
4 - Open or create a bibliographic record
5 - Link to the authority created above
6 - Subfield $2 is not set
7 - Apply patch
8 - Repeat linking, subfield $2 should be set

Signed-off-by: Josef Moravec <josef.moravec at gmail.com>

Signed-off-by: Marcel de Rooy <m.de.rooy at rijksmuseum.nl>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Nov  3 08:27:32 2017
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 03 Nov 2017 07:27:32 +0000
Subject: [Koha-bugs] [Bug 19537] Authorities search doesn' t correctly
 populate subfield $2 source of heading
In-Reply-To: <bug-19537-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-19537-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-19537-70-RcWI0C49vq@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19537

--- Comment #4 from Marcel de Rooy <m.de.rooy at rijksmuseum.nl> ---
Created attachment 68904
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=68904&action=edit
Bug 19537: (QA Follow-up) Consistent structures

The subfield_loop structure should contain things like:
$VAR1 = {
          'marc_subfield' => 'v',
          'marc_values' => [
                             'form'
                           ]
        };

This patches replaces the list by an array ref to restore consistency,
although Template Toolkit does not really care. Both work.

Signed-off-by: Marcel de Rooy <m.de.rooy at rijksmuseum.nl>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Nov  3 08:27:26 2017
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 03 Nov 2017 07:27:26 +0000
Subject: [Koha-bugs] [Bug 19537] Authorities search doesn' t correctly
 populate subfield $2 source of heading
In-Reply-To: <bug-19537-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-19537-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-19537-70-mIJV7kcXEo@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19537

Marcel de Rooy <m.de.rooy at rijksmuseum.nl> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Signed Off                  |Passed QA

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Nov  3 08:28:41 2017
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 03 Nov 2017 07:28:41 +0000
Subject: [Koha-bugs] [Bug 19537] Authorities search doesn' t correctly
 populate subfield $2 source of heading
In-Reply-To: <bug-19537-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-19537-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-19537-70-SqgNtHnz1v@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19537

Marcel de Rooy <m.de.rooy at rijksmuseum.nl> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
           Severity|enhancement                 |normal
         QA Contact|testopia at bugs.koha-communit |m.de.rooy at rijksmuseum.nl
                   |y.org                       |

--- Comment #5 from Marcel de Rooy <m.de.rooy at rijksmuseum.nl> ---
Removing enh label. This is a bug.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Nov  3 08:30:19 2017
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 03 Nov 2017 07:30:19 +0000
Subject: [Koha-bugs] [Bug 19537] Authorities search doesn' t correctly
 populate subfield $2 source of heading
In-Reply-To: <bug-19537-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-19537-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-19537-70-5NE3sjeYrk@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19537

Marcel de Rooy <m.de.rooy at rijksmuseum.nl> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #68904|0                           |1
        is obsolete|                            |

--- Comment #6 from Marcel de Rooy <m.de.rooy at rijksmuseum.nl> ---
Created attachment 68905
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=68905&action=edit
Bug 19537: (QA Follow-up) Consistent structures

The subfield_loop structure should contain things like:
$VAR1 = {
          'marc_subfield' => 'v',
          'marc_values' => [
                             'form'
                           ]
        };

This patches replaces the list by an array ref to restore consistency,
although Template Toolkit does not really care. Both work.

Signed-off-by: Marcel de Rooy <m.de.rooy at rijksmuseum.nl>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Nov  3 08:52:05 2017
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 03 Nov 2017 07:52:05 +0000
Subject: [Koha-bugs] [Bug 18894] Add ability to limit the number of messages
 sent by misc/ cronjobs/process_message_queue.pl at a time
In-Reply-To: <bug-18894-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-18894-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-18894-70-Isekh1pZ4B@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18894

Marcel de Rooy <m.de.rooy at rijksmuseum.nl> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Signed Off                  |Passed QA
   Patch complexity|---                         |Small patch

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Nov  3 08:52:08 2017
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 03 Nov 2017 07:52:08 +0000
Subject: [Koha-bugs] [Bug 18894] Add ability to limit the number of messages
 sent by misc/ cronjobs/process_message_queue.pl at a time
In-Reply-To: <bug-18894-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-18894-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-18894-70-JxzMyVKhmj@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18894

Marcel de Rooy <m.de.rooy at rijksmuseum.nl> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #68887|0                           |1
        is obsolete|                            |

--- Comment #5 from Marcel de Rooy <m.de.rooy at rijksmuseum.nl> ---
Created attachment 68906
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=68906&action=edit
Bug 18894 - Add ability to limit the number of messages sent by
misc/cronjobs/process_message_queue.pl at a time

Having the ability to limit the number of messages sent by
process_message_queue.pl on a single run would be very useful for controlling
home many messages are sent at a given time. This can help prevent too many
messages being sent out at once and getting flagged as a spammer.

Test Plan:
1) Apply this patch
2) Generate some number of messages in the message queue
3) Run process_message_queue.pl with the new --limit option,
   set limit to a number smaller than the number of pending messages
4) After the script has run, check the database and note that only
   a number of pending messages were sent, and that the remaining amount
   of pending messages is the original amount less the number specified
   as the limit

Signed-off-by: Mark Tompsett <mtompset at hotmail.com>

Signed-off-by: Marcel de Rooy <m.de.rooy at rijksmuseum.nl>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Nov  3 08:52:12 2017
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 03 Nov 2017 07:52:12 +0000
Subject: [Koha-bugs] [Bug 18894] Add ability to limit the number of messages
 sent by misc/ cronjobs/process_message_queue.pl at a time
In-Reply-To: <bug-18894-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-18894-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-18894-70-ZiZUDZSvqn@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18894

--- Comment #6 from Marcel de Rooy <m.de.rooy at rijksmuseum.nl> ---
Created attachment 68907
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=68907&action=edit
Bug 18894: (QA Follow-up) POD changes

Add limit parameter to POD section.

Signed-off-by: Marcel de Rooy <m.de.rooy at rijksmuseum.nl>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Nov  3 08:52:37 2017
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 03 Nov 2017 07:52:37 +0000
Subject: [Koha-bugs] [Bug 18894] Add ability to limit the number of messages
 sent by misc/ cronjobs/process_message_queue.pl at a time
In-Reply-To: <bug-18894-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-18894-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-18894-70-g5nEENkcgM@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18894

Marcel de Rooy <m.de.rooy at rijksmuseum.nl> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
         QA Contact|testopia at bugs.koha-communit |m.de.rooy at rijksmuseum.nl
                   |y.org                       |
                 CC|                            |m.de.rooy at rijksmuseum.nl

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Nov  3 08:54:20 2017
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 03 Nov 2017 07:54:20 +0000
Subject: [Koha-bugs] [Bug 17610] [16.11.x] Allow the number of plack workers
 and max connections to be set in koha-conf.xml
In-Reply-To: <bug-17610-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-17610-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-17610-70-f2onKD2iy7@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17610

Marcel de Rooy <m.de.rooy at rijksmuseum.nl> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Signed Off                  |Passed QA

--- Comment #24 from Marcel de Rooy <m.de.rooy at rijksmuseum.nl> ---
Moving this one out of the SO queue

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Nov  3 08:54:32 2017
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 03 Nov 2017 07:54:32 +0000
Subject: [Koha-bugs] [Bug 17610] [16.11.x] Allow the number of plack workers
 and max connections to be set in koha-conf.xml
In-Reply-To: <bug-17610-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-17610-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-17610-70-hjnZyVn4qr@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17610

Marcel de Rooy <m.de.rooy at rijksmuseum.nl> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Passed QA                   |Pushed to Master

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Nov  3 08:54:40 2017
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 03 Nov 2017 07:54:40 +0000
Subject: [Koha-bugs] [Bug 17610] [16.11.x] Allow the number of plack workers
 and max connections to be set in koha-conf.xml
In-Reply-To: <bug-17610-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-17610-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-17610-70-hj4O9dTOBB@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17610

Marcel de Rooy <m.de.rooy at rijksmuseum.nl> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Pushed to Master            |Pushed to Stable

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Nov  3 09:27:32 2017
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 03 Nov 2017 08:27:32 +0000
Subject: [Koha-bugs] [Bug 19299] Replace C4::Reserves::GetReservesForBranch
 with Koha::Holds-> waiting
In-Reply-To: <bug-19299-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-19299-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-19299-70-n6K59vZiuT@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19299

Marcel de Rooy <m.de.rooy at rijksmuseum.nl> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |m.de.rooy at rijksmuseum.nl

--- Comment #4 from Marcel de Rooy <m.de.rooy at rijksmuseum.nl> ---
+# FIXME - Is priority => 0 useful? If yes it must be moved to waiting,
otherwise we need to remove it from here.

Since set_waiting sets priority to 0, we should not need to check priority
again. But the test has been used more often in that way:
return 'Waiting'  if $found eq 'W' and $priority == 0;

IF found is W or T, priority should be 0. Priority is no longer of importance
when an item has been set to Waiting.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Nov  3 09:28:21 2017
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 03 Nov 2017 08:28:21 +0000
Subject: [Koha-bugs] [Bug 19299] Replace C4::Reserves::GetReservesForBranch
 with Koha::Holds-> waiting
In-Reply-To: <bug-19299-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-19299-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-19299-70-bueBykcvpk@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19299

Marcel de Rooy <m.de.rooy at rijksmuseum.nl> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #68815|0                           |1
        is obsolete|                            |

--- Comment #5 from Marcel de Rooy <m.de.rooy at rijksmuseum.nl> ---
Created attachment 68908
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=68908&action=edit
Bug 19299: Replace C4::Reserves::GetReservesForBranch with Koha::Holds->waiting

GetReservesForBranch simply returns the waiting holds, for a specific
branch of not. This can easily be replaced with a call to
Koha::Holds->waiting

To avoid any regressions, I reuse the exact conditions (priority = 0),
but I do not think it is useful.

Test plan:
Make sure the holds information are correctly displayed on the waiting
holds screen.

Signed-off-by: Josef Moravec <josef.moravec at gmail.com>
Signed-off-by: Marcel de Rooy <m.de.rooy at rijksmuseum.nl>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Nov  3 09:28:19 2017
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 03 Nov 2017 08:28:19 +0000
Subject: [Koha-bugs] [Bug 19299] Replace C4::Reserves::GetReservesForBranch
 with Koha::Holds-> waiting
In-Reply-To: <bug-19299-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-19299-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-19299-70-8DbuUaKonr@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19299

Marcel de Rooy <m.de.rooy at rijksmuseum.nl> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
   Patch complexity|---                         |Small patch
             Status|Signed Off                  |Passed QA

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Nov  3 09:29:46 2017
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 03 Nov 2017 08:29:46 +0000
Subject: [Koha-bugs] [Bug 10021] Remove dead code related to notifys
In-Reply-To: <bug-10021-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-10021-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-10021-70-IPrxxeRCDW@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10021

Marcel de Rooy <m.de.rooy at rijksmuseum.nl> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |m.de.rooy at rijksmuseum.nl
           Severity|normal                      |enhancement

--- Comment #29 from Marcel de Rooy <m.de.rooy at rijksmuseum.nl> ---
Moving this to enh

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Nov  3 09:33:26 2017
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 03 Nov 2017 08:33:26 +0000
Subject: [Koha-bugs] [Bug 10021] Remove dead code related to notifys
In-Reply-To: <bug-10021-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-10021-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-10021-70-aAUdRMyzHG@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10021

--- Comment #30 from Marcel de Rooy <m.de.rooy at rijksmuseum.nl> ---
 FAIL   C4/Members.pm
   FAIL   pod coverage
                POD coverage was greater before, try perl
-MPod::Coverage=PackageName -e666

 FAIL   C4/Overdues.pm
   FAIL   pod coverage
                POD coverage was greater before, try perl
-MPod::Coverage=PackageName -e666

No reason to immediately move this to FQA !
When you remove a sub from a module without full coverage, this is the result.
Something for QA tools ?

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Nov  3 09:55:25 2017
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 03 Nov 2017 08:55:25 +0000
Subject: [Koha-bugs] [Bug 10021] Remove dead code related to notifys
In-Reply-To: <bug-10021-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-10021-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-10021-70-FchjB3htI1@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10021

--- Comment #31 from Marcel de Rooy <m.de.rooy at rijksmuseum.nl> ---
(In reply to Jonathan Druart from comment #8)
> Created attachment 68263 [details] [review]
> Bug 10021: Drop columns notify_id and notify_level from accountlines
> 
> It appears that has never worked.
> Could someone confirm?

Did you have any response whatsoever ?

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Nov  3 09:58:59 2017
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 03 Nov 2017 08:58:59 +0000
Subject: [Koha-bugs] [Bug 10021] Remove dead code related to notifys
In-Reply-To: <bug-10021-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-10021-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-10021-70-5Z7XSFMepR@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10021

Marcel de Rooy <m.de.rooy at rijksmuseum.nl> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Signed Off                  |Failed QA

--- Comment #32 from Marcel de Rooy <m.de.rooy at rijksmuseum.nl> ---
QA Comment:

GetOverduesForBranch
Please add a test. You make some fundamental changes here.

koha-tmpl/intranet-tmpl/prog/en/modules/members/pay.tt
-    <input type="hidden" name="totals[% line.accountlines_id %]" value="[%
line.totals %]" />
Not sure. Why do yo remove this line ?

New code:
+    my $accounts = Koha::Account::Lines->search({ borrowernumber =>
$borrowernumber, }, { order_by => ['accounttype'] });
+    my @accounts;
+    while ( my $account = $accounts->next ) {
This does not look very nice. Can we get more confusion on $account, @accounts
or $accounts ?
Renaming @accounts here might be the least we can do?
No blocker on itself.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Nov  3 10:02:41 2017
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 03 Nov 2017 09:02:41 +0000
Subject: [Koha-bugs] [Bug 19280] CanBookBeIssued must take a Koha::Patron in
	parameter
In-Reply-To: <bug-19280-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-19280-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-19280-70-66Wo8QbDIk@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19280

Marcel de Rooy <m.de.rooy at rijksmuseum.nl> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |m.de.rooy at rijksmuseum.nl
             Status|Signed Off                  |Patch doesn't apply

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Nov  3 10:04:54 2017
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 03 Nov 2017 09:04:54 +0000
Subject: [Koha-bugs] [Bug 19349] Allow to store biblio record' s creator and
 last modifier in MARC
In-Reply-To: <bug-19349-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-19349-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-19349-70-Nd8QEqaj4W@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19349

Marcel de Rooy <m.de.rooy at rijksmuseum.nl> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Signed Off                  |Failed QA

--- Comment #6 from Marcel de Rooy <m.de.rooy at rijksmuseum.nl> ---
Any feedback please ?

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Nov  3 10:07:22 2017
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 03 Nov 2017 09:07:22 +0000
Subject: [Koha-bugs] [Bug 19420] Improve display of errors from failure of
 uploading file during stage import
In-Reply-To: <bug-19420-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-19420-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-19420-70-GxXzlHCr31@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19420

Marcel de Rooy <m.de.rooy at rijksmuseum.nl> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |m.de.rooy at rijksmuseum.nl
           Assignee|koha-bugs at lists.koha-commun |nick at bywatersolutions.com
                   |ity.org                     |
         QA Contact|testopia at bugs.koha-communit |m.de.rooy at rijksmuseum.nl
                   |y.org                       |

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Nov  3 10:10:05 2017
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 03 Nov 2017 09:10:05 +0000
Subject: [Koha-bugs] [Bug 19420] Improve display of errors from failure of
 uploading file during stage import
In-Reply-To: <bug-19420-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-19420-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-19420-70-iwgjMoq2qX@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19420

--- Comment #6 from Marcel de Rooy <m.de.rooy at rijksmuseum.nl> ---
(In reply to Nick Clemens from comment #0)
> Currently error is always:
> Upload status: Failed
> Though there are four reasons it could fail, they are codes buried in
> Koha/Uploader.pm

Who wrote that ?! ;)

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Nov  3 10:13:17 2017
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 03 Nov 2017 09:13:17 +0000
Subject: [Koha-bugs] [Bug 19420] Improve display of errors from failure of
 uploading file during stage import
In-Reply-To: <bug-19420-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-19420-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-19420-70-Iuqk2NW2ST@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19420

Marcel de Rooy <m.de.rooy at rijksmuseum.nl> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Signed Off                  |Failed QA

--- Comment #7 from Marcel de Rooy <m.de.rooy at rijksmuseum.nl> ---
t/db_dependent/Upload.t

    not ok 3 - Errcode 1 [already exists] reported
    #   Failed test 'Errcode 1 [already exists] reported'
    #   at t/db_dependent/Upload.t line 148.
    #          got: 'HASH(0x7071fe8)'
    #     expected: '1'
    # Looks like you failed 1 test of 3.
not ok 6 - Add same file in same category
#   Failed test 'Add same file in same category'
#   at t/db_dependent/Upload.t line 149.

Will have a look now.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Nov  3 10:21:36 2017
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 03 Nov 2017 09:21:36 +0000
Subject: [Koha-bugs] [Bug 19420] Improve display of errors from failure of
 uploading file during stage import
In-Reply-To: <bug-19420-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-19420-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-19420-70-fC3lf1h01H@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19420

--- Comment #8 from Marcel de Rooy <m.de.rooy at rijksmuseum.nl> ---
Created attachment 68909
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=68909&action=edit
Bug 19420: (QA Follow-up) Fix test, correct POD

The test needs the code level in the error hash now.
And POD is adjusted accordingly.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Nov  3 10:29:34 2017
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 03 Nov 2017 09:29:34 +0000
Subject: [Koha-bugs] [Bug 19420] Improve display of errors from failure of
 uploading file during stage import
In-Reply-To: <bug-19420-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-19420-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-19420-70-62cXXHwg6r@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19420

--- Comment #9 from Marcel de Rooy <m.de.rooy at rijksmuseum.nl> ---
We need similar changes in other places:

git grep "file-upload.js"

koha-tmpl/intranet-tmpl/prog/en/modules/offline_circ/process_koc.tt:<script
type="text/javascript" src="[% interface %]/[% theme
%]/js/file-upload.js"></script>
koha-tmpl/intranet-tmpl/prog/en/modules/tools/stage-marc-import.tt:<script
type="text/javascript" src="[% interface %]/[% theme
%]/js/file-upload.js"></script>
koha-tmpl/intranet-tmpl/prog/en/modules/tools/upload-images.tt:<script
type="text/javascript" src="[% interface %]/[% theme
%]/js/file-upload.js"></script>
koha-tmpl/intranet-tmpl/prog/en/modules/tools/upload.tt:<script
type="text/javascript" src="[% interface %]/[% theme
%]/js/file-upload.js"></script>

Please adjust

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Nov  3 10:37:56 2017
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 03 Nov 2017 09:37:56 +0000
Subject: [Koha-bugs] [Bug 18382] action_logs entry for module HOLDS,
 action SUSPEND is spammy
In-Reply-To: <bug-18382-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-18382-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-18382-70-Hh0uPHXUY2@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18382

Marcel de Rooy <m.de.rooy at rijksmuseum.nl> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |m.de.rooy at rijksmuseum.nl
             Status|Signed Off                  |Failed QA

--- Comment #9 from Marcel de Rooy <m.de.rooy at rijksmuseum.nl> ---
Your solution is not limited to action_logs.
You truncate, so to speak, already at the holds level.
Please add your fix at the hold unblessed level when sending it to the logs.
Squash the patches too.
Thanks.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Nov  3 10:39:36 2017
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 03 Nov 2017 09:39:36 +0000
Subject: [Koha-bugs] [Bug 19574] New: Wrong itemtype can be chosen when
	placing holds
Message-ID: <bug-19574-70@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19574

            Bug ID: 19574
           Summary: Wrong itemtype can be chosen when placing holds
 Change sponsored?: ---
           Product: Koha
           Version: unspecified
          Hardware: All
                OS: All
            Status: NEW
          Severity: enhancement
          Priority: P5 - low
         Component: Circulation
          Assignee: koha-bugs at lists.koha-community.org
          Reporter: andreas.hedstrom.mace at sub.su.se
        QA Contact: testopia at bugs.koha-community.org
                CC: gmcharlt at gmail.com, kyle.m.hall at gmail.com

With the syspref AllowHoldItemTypeSelection set to Allow, it is possible to add
a hold for an itemtype that doesn?t actually exist at a specific branch. Say
that branch A has two itemtypes: books and map, while branch B has three:
books, map and audio book. It is possible to add a hold for branch A with
itemtype audio book although there is no item with such an itemtype at this
branch. This will cause an internal server error if you try to delete this
faulty hold.

To recreate:
1) Enable AllowHoldItemTypeSelection
2) Add, or find, a bibliographic record with at least two branches and at least
two items with two different itemtypes. Branch B should not have all itemtypes.
3) Add a hold for branch B, and choose an itemtype not available at this branch
(there are no such items)
4) Try deleting the hold, note the internal server error.

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.

From bugzilla-daemon at bugs.koha-community.org  Fri Nov  3 10:44:50 2017
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 03 Nov 2017 09:44:50 +0000
Subject: [Koha-bugs] [Bug 10748] Add option to block return of lost items
In-Reply-To: <bug-10748-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-10748-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-10748-70-0bhwTWLOn5@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10748

Marcel de Rooy <m.de.rooy at rijksmuseum.nl> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Signed Off                  |Failed QA
                 CC|                            |m.de.rooy at rijksmuseum.nl

--- Comment #7 from Marcel de Rooy <m.de.rooy at rijksmuseum.nl> ---
Please add a test case for AddReturn.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Nov  3 10:50:36 2017
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 03 Nov 2017 09:50:36 +0000
Subject: [Koha-bugs] [Bug 12027] Shibboleth authentication for staff client
In-Reply-To: <bug-12027-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-12027-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-12027-70-Szk3I96AqL@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12027

Marcel de Rooy <m.de.rooy at rijksmuseum.nl> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Signed Off                  |Patch doesn't apply

--- Comment #27 from Marcel de Rooy <m.de.rooy at rijksmuseum.nl> ---
Also please add feedback for comment 25.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Nov  3 10:52:19 2017
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 03 Nov 2017 09:52:19 +0000
Subject: [Koha-bugs] [Bug 19290] Add the ability to filter a result list on
	staff client
In-Reply-To: <bug-19290-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-19290-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-19290-70-Tum6nqOp1S@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19290

Marcel de Rooy <m.de.rooy at rijksmuseum.nl> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |m.de.rooy at rijksmuseum.nl
             Status|Signed Off                  |Patch doesn't apply

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Nov  3 11:00:32 2017
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 03 Nov 2017 10:00:32 +0000
Subject: [Koha-bugs] [Bug 15524] Set limit on maximum possible holds per
 patron by category
In-Reply-To: <bug-15524-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-15524-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-15524-70-QV0OsmlEo1@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15524

Marcel de Rooy <m.de.rooy at rijksmuseum.nl> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |m.de.rooy at rijksmuseum.nl

--- Comment #14 from Marcel de Rooy <m.de.rooy at rijksmuseum.nl> ---
QA: Looking here now

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Nov  3 11:02:55 2017
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 03 Nov 2017 10:02:55 +0000
Subject: [Koha-bugs] [Bug 18904] Advanced editor - Rancor - Add authority
	support
In-Reply-To: <bug-18904-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-18904-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-18904-70-RgiICYk6Zl@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18904

Nick Clemens <nick at bywatersolutions.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
         Depends on|                            |19537


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19537
[Bug 19537] Authorities search doesn't correctly populate subfield $2 source of
heading
-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Nov  3 11:02:55 2017
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 03 Nov 2017 10:02:55 +0000
Subject: [Koha-bugs] [Bug 19537] Authorities search doesn' t correctly
 populate subfield $2 source of heading
In-Reply-To: <bug-19537-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-19537-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-19537-70-KvZTC7umRa@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19537

Nick Clemens <nick at bywatersolutions.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Blocks|                            |18904


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18904
[Bug 18904] Advanced editor - Rancor - Add authority support
-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Nov  3 11:03:50 2017
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 03 Nov 2017 10:03:50 +0000
Subject: [Koha-bugs] [Bug 18904] Advanced editor - Rancor - Add authority
	support
In-Reply-To: <bug-18904-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-18904-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-18904-70-YnmvNNRkHT@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18904

Nick Clemens <nick at bywatersolutions.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Failed QA                   |Signed Off
         QA Contact|testopia at bugs.koha-communit |m.de.rooy at rijksmuseum.nl
                   |y.org                       |

--- Comment #21 from Nick Clemens <nick at bywatersolutions.com> ---
Missed adding dependency on 19537, that should clear up the error

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Nov  3 11:21:41 2017
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 03 Nov 2017 10:21:41 +0000
Subject: [Koha-bugs] [Bug 12027] Shibboleth authentication for staff client
In-Reply-To: <bug-12027-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-12027-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-12027-70-DVKN6alaIh@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12027

--- Comment #28 from Marcel de Rooy <m.de.rooy at rijksmuseum.nl> ---
Zeno asked me:
===
I think that Matthias on commen7 #26 is quite clear
It is not enough a rebase for this patch ?
===
Yeah I focused on a reply from Martin. So probably true.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Nov  3 11:36:13 2017
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 03 Nov 2017 10:36:13 +0000
Subject: [Koha-bugs] [Bug 14413] map internalnotes to MarcFieldsToOrder
In-Reply-To: <bug-14413-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-14413-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-14413-70-Q9NtE6gidj@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14413

Koha Team Lyon 3 <koha at univ-lyon3.fr> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |koha at univ-lyon3.fr

--- Comment #1 from Koha Team Lyon 3 <koha at univ-lyon3.fr> ---
I agree with Nicole, it would be usefull have the possibility to get
order_internalnote thanks to MarcFieldsToOrder syspref, while we download
iso2709 files for order.
Sonia

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Nov  3 11:41:21 2017
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 03 Nov 2017 10:41:21 +0000
Subject: [Koha-bugs] [Bug 19420] Improve display of errors from failure of
 uploading file during stage import
In-Reply-To: <bug-19420-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-19420-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-19420-70-kRv7WEbNSP@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19420

Nick Clemens <nick at bywatersolutions.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Failed QA                   |Signed Off

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Nov  3 11:41:23 2017
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 03 Nov 2017 10:41:23 +0000
Subject: [Koha-bugs] [Bug 19420] Improve display of errors from failure of
 uploading file during stage import
In-Reply-To: <bug-19420-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-19420-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-19420-70-4lQx5D6Soz@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19420

--- Comment #10 from Nick Clemens <nick at bywatersolutions.com> ---
Created attachment 68910
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=68910&action=edit
Bug 19420 - Add errors on other pages

Eventually these should all be using the same code in a js file

upload.tt already dealt with these errors, but has diff code, made it
work with new error syntax

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Nov  3 11:42:05 2017
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 03 Nov 2017 10:42:05 +0000
Subject: [Koha-bugs] [Bug 14413] map internalnotes to MarcFieldsToOrder
In-Reply-To: <bug-14413-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-14413-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-14413-70-l7wL7I44qb@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14413

--- Comment #2 from Koha Team Lyon 3 <koha at univ-lyon3.fr> ---
It's perhaps fixed bt BZ15503 but it seems that it needs follow-up ?

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.

From bugzilla-daemon at bugs.koha-community.org  Fri Nov  3 11:42:13 2017
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 03 Nov 2017 10:42:13 +0000
Subject: [Koha-bugs] [Bug 15503] Grab Item Information from Order Files
In-Reply-To: <bug-15503-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-15503-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-15503-70-XJcdibUcvN@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15503

Koha Team Lyon 3 <koha at univ-lyon3.fr> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |koha at univ-lyon3.fr

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Nov  3 11:43:11 2017
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 03 Nov 2017 10:43:11 +0000
Subject: [Koha-bugs] [Bug 15524] Set limit on maximum possible holds per
 patron by category
In-Reply-To: <bug-15524-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-15524-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-15524-70-FlouJuXDz1@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15524

Marcel de Rooy <m.de.rooy at rijksmuseum.nl> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Signed Off                  |In Discussion

--- Comment #15 from Marcel de Rooy <m.de.rooy at rijksmuseum.nl> ---
QA Comment
Interesting feature! Limited testing did not reveal problems.

Functionality issue:
In Administration, smart-rules, the section "Default checkout limit by patron
category" contains the item "Maximum total holds allowed (count)".
Not sure if the label should contain total and count btw.
But the section should be renamed. This does not pertain any longer to checkout
limits only.
Furthermore I would expect to have max_holds also under Default checkout, hold
and return policy. It seems consistent to add it also without a patron category
restriction.
Same as current checkouts etc.
Hard to move it to FQA for that reason. At least I want to have some additional
opinions. Setting to In Discussion. Please ask for feedback via IRC or ML.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Nov  3 11:48:30 2017
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 03 Nov 2017 10:48:30 +0000
Subject: [Koha-bugs] [Bug 18798] Use Koha.Preference in OPAC Reading Record
In-Reply-To: <bug-18798-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-18798-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-18798-70-E4IHqqNF4V@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18798

Marcel de Rooy <m.de.rooy at rijksmuseum.nl> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |m.de.rooy at rijksmuseum.nl
             Status|Signed Off                  |Failed QA

--- Comment #4 from Marcel de Rooy <m.de.rooy at rijksmuseum.nl> ---
[% IF GoogleJackets %]

Forgotten ?

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Nov  3 11:58:10 2017
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 03 Nov 2017 10:58:10 +0000
Subject: [Koha-bugs] [Bug 18882] Add location code to statistics table for
 checkouts and renewals
In-Reply-To: <bug-18882-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-18882-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-18882-70-eXmuYgHPAn@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18882

Marcel de Rooy <m.de.rooy at rijksmuseum.nl> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |m.de.rooy at rijksmuseum.nl

--- Comment #7 from Marcel de Rooy <m.de.rooy at rijksmuseum.nl> ---
(In reply to Kyle M Hall from comment #4)
> (In reply to M. Tompsett from comment #2)
> > The code puts '' if there is no location key. But if the location key is
> > NULL, because I hadn't set my shelving location, there is NULL. Do we want
> > NULL's? If so, I'll sign this off. If not, could you tweak that?
> 
> I think we should always use NULL is the location is not passed or is set to
> undef. It seems like odd behavior to convert undef values to empty strings.

What we are doing now however, is storing undef only for location. Which is
inconsistent. You change all lines in the second patch, only set undef for
location.
No blocker, but could be improved.
I think that empty string would have been better now.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Nov  3 11:59:01 2017
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 03 Nov 2017 10:59:01 +0000
Subject: [Koha-bugs] [Bug 18882] Add location code to statistics table for
 checkouts and renewals
In-Reply-To: <bug-18882-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-18882-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-18882-70-6CbEcSAQCv@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18882

Marcel de Rooy <m.de.rooy at rijksmuseum.nl> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Signed Off                  |Passed QA
   Patch complexity|---                         |Small patch

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Nov  3 11:59:04 2017
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 03 Nov 2017 10:59:04 +0000
Subject: [Koha-bugs] [Bug 18882] Add location code to statistics table for
 checkouts and renewals
In-Reply-To: <bug-18882-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-18882-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-18882-70-8M1PBPxN0G@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18882

Marcel de Rooy <m.de.rooy at rijksmuseum.nl> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #64758|0                           |1
        is obsolete|                            |

--- Comment #8 from Marcel de Rooy <m.de.rooy at rijksmuseum.nl> ---
Created attachment 68911
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=68911&action=edit
Bug 18882 - Add location code to statistics table for checkouts and renewals

Some libraries wish to track what the current location of items was at the time
they were checked out. This will help libraries track which physical locations
in the library patrons are more likely to check out a given book from.

Test Plan:
1) Apply this patch
2) Run updatedatabase.pl
3) Check out an item that has a location set
4) Renew that item
5) View the checkout and renewal in the statistics table,
   verify each has the location column populated correctly

Signed-off-by: Mark Tompsett <mtompset at hotmail.com>

Signed-off-by: Marcel de Rooy <m.de.rooy at rijksmuseum.nl>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Nov  3 11:59:08 2017
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 03 Nov 2017 10:59:08 +0000
Subject: [Koha-bugs] [Bug 18882] Add location code to statistics table for
 checkouts and renewals
In-Reply-To: <bug-18882-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-18882-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-18882-70-U2GdUhzveh@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18882

Marcel de Rooy <m.de.rooy at rijksmuseum.nl> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #64759|0                           |1
        is obsolete|                            |

--- Comment #9 from Marcel de Rooy <m.de.rooy at rijksmuseum.nl> ---
Created attachment 68912
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=68912&action=edit
Bug 18882 [QA Followup] - Ensure stats with no or undef location are set to
NULL in db

Confirm that only NULL or a string are in the location field of the
statistics table. Test with two items, one with shelving location set,
and one without it set.

Signed-off-by: Mark Tompsett <mtompset at hotmail.com>

Signed-off-by: Marcel de Rooy <m.de.rooy at rijksmuseum.nl>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Nov  3 11:59:29 2017
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 03 Nov 2017 10:59:29 +0000
Subject: [Koha-bugs] [Bug 18882] Add location code to statistics table for
 checkouts and renewals
In-Reply-To: <bug-18882-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-18882-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-18882-70-28pbETOnYQ@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18882

Marcel de Rooy <m.de.rooy at rijksmuseum.nl> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
         QA Contact|testopia at bugs.koha-communit |m.de.rooy at rijksmuseum.nl
                   |y.org                       |

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Nov  3 12:24:26 2017
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 03 Nov 2017 11:24:26 +0000
Subject: [Koha-bugs] [Bug 19420] Improve display of errors from failure of
 uploading file during stage import
In-Reply-To: <bug-19420-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-19420-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-19420-70-688TMIP0oX@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19420

Marcel de Rooy <m.de.rooy at rijksmuseum.nl> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Signed Off                  |Failed QA

--- Comment #11 from Marcel de Rooy <m.de.rooy at rijksmuseum.nl> ---
Upload local cover image
Upload status: Failed - (2) Root directory for uploads not defined
No, the directory was not writable.
This went wrong since the errcode is 2, but you forgot to add a zero entry in
you errMsgs array. So they are one position out of sync.
Please add a leading entry here (see also upload.tt)
var errMsgs = [ _("File already exists"), _("Directory is not writeable"),
_("Root directory for uploads not defined"), _("Temporary directory for uploads
not defined") ];
Adjust same thing in two other places ?

 //Next three errors have no code path to trigger that I see
I am very confident that I tested all codes when I wrote this. They may be hard
to simulate, but I did. Please remove this comment.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Nov  3 12:25:53 2017
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 03 Nov 2017 11:25:53 +0000
Subject: [Koha-bugs] [Bug 19494] Add reservedate to Holds awaiting pickup
In-Reply-To: <bug-19494-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-19494-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-19494-70-YG51tek1EP@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19494

Simon Pouchol <simon.pouchol at biblibre.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #68291|0                           |1
        is obsolete|                            |

--- Comment #2 from Simon Pouchol <simon.pouchol at biblibre.com> ---
Created attachment 68913
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=68913&action=edit
Bug 19494: Add reservedate to Holds awaiting pickup

Add reservedate to report.
Change label "Available since" to "Waiting since".

Note: The table (already) crosses the boundaries of its container. Also
the vertical spacing for the first column (already) is not the same as the
others. (Adding the second date only makes it more visible.) These minor
design issues should be solved on another report.

Test plan:
[1] Go to Circulation, Holds awaiting pickup
[2] Note the additional column for reservedate.

Signed-off-by: Marcel de Rooy <m.de.rooy at rijksmuseum.nl>
Signed-off-by: Simon Pouchol <simon.pouchol at biblibre.com>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Nov  3 12:26:17 2017
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 03 Nov 2017 11:26:17 +0000
Subject: [Koha-bugs] [Bug 19494] Add reservedate to Holds awaiting pickup
In-Reply-To: <bug-19494-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-19494-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-19494-70-cVSqfQMHDY@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19494

Simon Pouchol <simon.pouchol at biblibre.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |simon.pouchol at biblibre.com
             Status|Needs Signoff               |Signed Off

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Nov  3 13:05:58 2017
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 03 Nov 2017 12:05:58 +0000
Subject: [Koha-bugs] [Bug 19575] New: Use canonical field names and resolve
 aliased fields
Message-ID: <bug-19575-70@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19575

            Bug ID: 19575
           Summary: Use canonical field names and resolve aliased fields
 Change sponsored?: ---
           Product: Koha
           Version: master
          Hardware: All
                OS: All
            Status: NEW
          Severity: major
          Priority: P5 - low
         Component: Searching - Elasticsearch
          Assignee: koha-bugs at lists.koha-community.org
          Reporter: glasklas at gmail.com

The current elastic search fields seems to be a mix between zebra aliases,
field names, some duplicates and new fields. This causes issues with sorting in
UI and hard-coded search-links in XSL-templates for example. I have attempted
to clean things up a bit, which resolves many of these issues. I might not have
the time to do so today, but will attempt to find and mark all current issues
resolved by this fix.

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Nov  3 13:28:33 2017
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 03 Nov 2017 12:28:33 +0000
Subject: [Koha-bugs] [Bug 19575] Use canonical field names and resolve
	aliased fields
In-Reply-To: <bug-19575-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-19575-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-19575-70-WYrUZs6vo4@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19575

--- Comment #1 from David Gustafsson <glasklas at gmail.com> ---
Created attachment 68914
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=68914&action=edit
Bug 19575: Use canonical field names and resolve aliased fields

Adjust elastic search mappings to more closely match Zebra equivalents
resolving serveral issues with coded Zebra searches in templates, and
sorting of search results in UI.

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.

From bugzilla-daemon at bugs.koha-community.org  Fri Nov  3 14:12:36 2017
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 03 Nov 2017 13:12:36 +0000
Subject: [Koha-bugs] [Bug 19548] Search Result Second page not available
In-Reply-To: <bug-19548-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-19548-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-19548-70-u2jkzAooi8@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19548

--- Comment #2 from rainer.stowasser at zamg.ac.at ---
Version tested:

Our operational System
16.05.02.000  Linux vbib 3.16.0-4-amd64 #1 SMP Debian 3.16.7-ckt11-1
(2015-05-24) x86_64

Our test System
17.05.04.000 Linux vbib-dev 3.16.0-4-amd64 #1 SMP Debian 3.16.7-ckt11-1
(2015-05-24) x86_64

The search string does not matter (tested for space in the brackets)
it works for all quotations

simply try "test" :-)

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Nov  3 14:35:35 2017
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 03 Nov 2017 13:35:35 +0000
Subject: [Koha-bugs] [Bug 19522] Label creator - some strings are not
	translatable
In-Reply-To: <bug-19522-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-19522-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-19522-70-slhA807XCa@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19522

--- Comment #24 from Victor Grousset/tuxayo <victor.grousset at biblibre.com> ---
@Owen it seems that koha-translate doesn't work on a dev install.
http://irc.koha-community.org/koha/2017-11-03#i_1985535

@Dominic how did you installed the language?
https://wiki.koha-community.org/wiki/Installation_of_additional_languages_for_OPAC_and_INTRANET_staff_client#Installing_translations

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Nov  3 14:56:55 2017
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 03 Nov 2017 13:56:55 +0000
Subject: [Koha-bugs] [Bug 19576] New: opac-detail has multiple Koha::Biblios
Message-ID: <bug-19576-70@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19576

            Bug ID: 19576
           Summary: opac-detail has multiple Koha::Biblios
 Change sponsored?: ---
           Product: Koha
           Version: master
          Hardware: All
                OS: All
            Status: NEW
          Severity: enhancement
          Priority: P5 - low
         Component: OPAC
          Assignee: oleonard at myacpl.org
          Reporter: mtompset at hotmail.com
        QA Contact: testopia at bugs.koha-community.org

Marcel noticed this while QA'ing another bug.
Simply remove the duplicate line. Confirm the page loads and works as expected.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Nov  3 14:57:26 2017
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 03 Nov 2017 13:57:26 +0000
Subject: [Koha-bugs] [Bug 19576] opac-detail has multiple Koha::Biblios
In-Reply-To: <bug-19576-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-19576-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-19576-70-hfIeBdrf1x@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19576

M. Tompsett <mtompset at hotmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
           Severity|enhancement                 |trivial
           Assignee|oleonard at myacpl.org         |mtompset at hotmail.com
             Status|NEW                         |ASSIGNED
                 CC|                            |m.de.rooy at rijksmuseum.nl

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Nov  3 14:57:48 2017
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 03 Nov 2017 13:57:48 +0000
Subject: [Koha-bugs] [Bug 19576] opac-detail has multiple Koha::Biblios
In-Reply-To: <bug-19576-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-19576-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-19576-70-3AscttPAFA@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19576

M. Tompsett <mtompset at hotmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |jonathan.druart at bugs.koha-c
                   |                            |ommunity.org

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Nov  3 15:00:17 2017
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 03 Nov 2017 14:00:17 +0000
Subject: [Koha-bugs] [Bug 19576] opac-detail has multiple Koha::Biblios
In-Reply-To: <bug-19576-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-19576-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-19576-70-bDExAklNnX@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19576

M. Tompsett <mtompset at hotmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
   Patch complexity|---                         |Trivial patch

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Nov  3 15:00:19 2017
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 03 Nov 2017 14:00:19 +0000
Subject: [Koha-bugs] [Bug 19576] opac-detail has multiple Koha::Biblios
In-Reply-To: <bug-19576-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-19576-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-19576-70-bwdsx4KdXj@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19576

--- Comment #1 from M. Tompsett <mtompset at hotmail.com> ---
Created attachment 68915
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=68915&action=edit
Bug 19576: Remove extra Koha::Biblios

Marcel noticed this while QA'ing another bug.

TEST PLAN
---------
Apply patch and confirm the page still loads and works as expected.
Run Koha QA Test tools

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Nov  3 15:00:58 2017
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 03 Nov 2017 14:00:58 +0000
Subject: [Koha-bugs] [Bug 13640] Holds To Pull List includes items
	unreserveable items
In-Reply-To: <bug-13640-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-13640-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-13640-70-USBeD74PyT@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13640

Marjorie Barry-Vila <marjorie.barry-vila at collecto.ca> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |marjorie.barry-vila at collect
                   |                            |o.ca

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Nov  3 15:06:21 2017
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 03 Nov 2017 14:06:21 +0000
Subject: [Koha-bugs] [Bug 19576] opac-detail has multiple Koha::Biblios
In-Reply-To: <bug-19576-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-19576-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-19576-70-EbSHKqKcfd@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19576

M. Tompsett <mtompset at hotmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|ASSIGNED                    |Needs Signoff

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Nov  3 15:16:05 2017
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 03 Nov 2017 14:16:05 +0000
Subject: [Koha-bugs] [Bug 19576] opac-detail has duplicate 'use
	Koha::Biblios; '
In-Reply-To: <bug-19576-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-19576-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-19576-70-8joWTFxQ6x@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19576

M. Tompsett <mtompset at hotmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
            Summary|opac-detail has multiple    |opac-detail has duplicate
                   |Koha::Biblios               |'use Koha::Biblios;'

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Nov  3 16:12:52 2017
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 03 Nov 2017 15:12:52 +0000
Subject: [Koha-bugs] [Bug 6918] can't place holds on 'on order' items with
 AllowOnShelfHolds off
In-Reply-To: <bug-6918-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-6918-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-6918-70-PG0bqjfFwH@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6918

Simon Pouchol <simon.pouchol at biblibre.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Needs Signoff               |Patch doesn't apply
                 CC|                            |simon.pouchol at biblibre.com

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the QA Contact for the bug.

From bugzilla-daemon at bugs.koha-community.org  Fri Nov  3 16:35:06 2017
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 03 Nov 2017 15:35:06 +0000
Subject: [Koha-bugs] [Bug 19280] CanBookBeIssued must take a Koha::Patron in
	parameter
In-Reply-To: <bug-19280-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-19280-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-19280-70-8V30N7BrFe@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19280

Jonathan Druart <jonathan.druart at bugs.koha-community.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #68534|0                           |1
        is obsolete|                            |

--- Comment #5 from Jonathan Druart <jonathan.druart at bugs.koha-community.org> ---
Created attachment 68916
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=68916&action=edit
Bug 19280: Pass a Koha::Patron to CanBookBeIssued

We need to make subroutine from C4 use more Koha::Object objects
Seeing bug 19276, starting here is a good start.

Test plan:
The tests should still pass.

Signed-off-by: Jon Knight <J.P.Knight at lboro.ac.uk>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Nov  3 16:35:00 2017
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 03 Nov 2017 15:35:00 +0000
Subject: [Koha-bugs] [Bug 19280] CanBookBeIssued must take a Koha::Patron in
	parameter
In-Reply-To: <bug-19280-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-19280-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-19280-70-weHIgsEad5@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19280

Jonathan Druart <jonathan.druart at bugs.koha-community.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Patch doesn't apply         |Signed Off

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Nov  3 16:39:58 2017
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 03 Nov 2017 15:39:58 +0000
Subject: [Koha-bugs] [Bug 6918] can't place holds on 'on order' items with
 AllowOnShelfHolds off
In-Reply-To: <bug-6918-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-6918-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-6918-70-PkOUOZONVU@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6918

Jonathan Druart <jonathan.druart at bugs.koha-community.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Patch doesn't apply         |Needs Signoff

-- 
You are receiving this mail because:
You are the QA Contact for the bug.
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Nov  3 16:59:49 2017
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 03 Nov 2017 15:59:49 +0000
Subject: [Koha-bugs] [Bug 19576] opac-detail has duplicate 'use
	Koha::Biblios; '
In-Reply-To: <bug-19576-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-19576-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-19576-70-mX00PCLmD5@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19576

Jonathan Druart <jonathan.druart at bugs.koha-community.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Needs Signoff               |Signed Off

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Nov  3 16:59:54 2017
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 03 Nov 2017 15:59:54 +0000
Subject: [Koha-bugs] [Bug 19576] opac-detail has duplicate 'use
	Koha::Biblios; '
In-Reply-To: <bug-19576-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-19576-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-19576-70-zmI5Wu7IAX@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19576

Jonathan Druart <jonathan.druart at bugs.koha-community.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #68915|0                           |1
        is obsolete|                            |

--- Comment #2 from Jonathan Druart <jonathan.druart at bugs.koha-community.org> ---
Created attachment 68917
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=68917&action=edit
Bug 19576: Remove extra 'use Koha::Biblios' statement

Marcel noticed this while QA'ing another bug.

TEST PLAN
---------
Apply patch and confirm the page still loads and works as expected.
Run Koha QA Test tools

Signed-off-by: Jonathan Druart <jonathan.druart at bugs.koha-community.org>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Nov  3 17:00:36 2017
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 03 Nov 2017 16:00:36 +0000
Subject: [Koha-bugs] [Bug 19576] opac-detail has duplicate 'use
	Koha::Biblios; '
In-Reply-To: <bug-19576-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-19576-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-19576-70-y763c7Ci8f@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19576

Jonathan Druart <jonathan.druart at bugs.koha-community.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
         Depends on|                            |18262
             Status|Signed Off                  |Passed QA

--- Comment #3 from Jonathan Druart <jonathan.druart at bugs.koha-community.org> ---
Introduced by bug 18262.
Trivial, skipping QA.


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18262
[Bug 18262] Koha::Biblios - Remove GetBiblioData - part 1
-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Nov  3 17:00:36 2017
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 03 Nov 2017 16:00:36 +0000
Subject: [Koha-bugs] [Bug 18262] Koha::Biblios - Remove GetBiblioData - part
	1
In-Reply-To: <bug-18262-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-18262-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-18262-70-tnUHVoa5Vt@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18262

Jonathan Druart <jonathan.druart at bugs.koha-community.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Blocks|                            |19576


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19576
[Bug 19576] opac-detail has duplicate 'use Koha::Biblios;'
-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Nov  3 17:11:11 2017
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 03 Nov 2017 16:11:11 +0000
Subject: [Koha-bugs] [Bug 19290] Add the ability to filter a result list on
	staff client
In-Reply-To: <bug-19290-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-19290-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-19290-70-ChVWHIg3mp@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19290

Jonathan Druart <jonathan.druart at bugs.koha-community.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Patch doesn't apply         |Signed Off

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Nov  3 17:11:16 2017
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 03 Nov 2017 16:11:16 +0000
Subject: [Koha-bugs] [Bug 19290] Add the ability to filter a result list on
	staff client
In-Reply-To: <bug-19290-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-19290-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-19290-70-EK1nnNLovr@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19290

Jonathan Druart <jonathan.druart at bugs.koha-community.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #68204|0                           |1
        is obsolete|                            |

--- Comment #6 from Jonathan Druart <jonathan.druart at bugs.koha-community.org> ---
Created attachment 68918
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=68918&action=edit
Bug 19290: Browse selected bibliographic records - Staff interface

This patch adds the same feature as bug 10858 for the OPAC interface:
after a search, librarians will be able to browse selected results.
The results can be selected from several pages.
By extension it is possible to add results from several pages to a list
or the cart.

When at least one result is selected, a new "Browse selected records" button
becomes usable and change the behaviour of the existing browser.

The whole feature can be turned off with the pref BrowseResultSelection.

Test plan:
- Launch a search (on the staff interface)
- Check some biblios
- Go on another page
- Check some biblios
- Come back to a page you already check results and confirm that they are
still checked
- Click on the "Browse selected records" button
- Check that you are able to browse results you had checked.

You can also:
- add them to the cart
- add them to a list

QA note: the browsers at the OPAC and the one at the staff interface are
completely different
That's why the code is not mimicking what has been done on bug 10858.
The behaviour must stay the same anyway.

Signed-off-by: S?verine QUEUNE <severine.queune at bulac.fr>
Signed-off-by: S?verine QUEUNE <severine.queune at bulac.fr>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Nov  3 17:13:36 2017
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 03 Nov 2017 16:13:36 +0000
Subject: [Koha-bugs] [Bug 6918] can't place holds on 'on order' items with
 AllowOnShelfHolds off
In-Reply-To: <bug-6918-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-6918-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-6918-70-kaLbJbDyYw@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6918

--- Comment #28 from Simon Pouchol <simon.pouchol at biblibre.com> ---
Hey Jonathan,
It seems to me the patch isn't applying :
Applying: Bug 6918 - can't place holds on 'on order' items with
AllowOnShelfHolds off
fatal: sha1 information is lacking or useless (C4/Biblio.pm).
error: could not build fake ancestor
Patch failed at 0001 Bug 6918 - can't place holds on 'on order' items with
AllowOnShelfHolds off

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the QA Contact for the bug.

From bugzilla-daemon at bugs.koha-community.org  Fri Nov  3 17:27:42 2017
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 03 Nov 2017 16:27:42 +0000
Subject: [Koha-bugs] [Bug 10748] Add option to block return of lost items
In-Reply-To: <bug-10748-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-10748-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-10748-70-nW2EMiLCRO@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10748

--- Comment #8 from Jonathan Druart <jonathan.druart at bugs.koha-community.org> ---
Created attachment 68919
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=68919&action=edit
Bug 10748: Add tests

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Nov  3 17:27:38 2017
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 03 Nov 2017 16:27:38 +0000
Subject: [Koha-bugs] [Bug 10748] Add option to block return of lost items
In-Reply-To: <bug-10748-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-10748-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-10748-70-KwTwMHZaO9@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10748

Jonathan Druart <jonathan.druart at bugs.koha-community.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Failed QA                   |Signed Off

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Nov  3 17:39:12 2017
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 03 Nov 2017 16:39:12 +0000
Subject: [Koha-bugs] [Bug 10021] Remove dead code related to notifys
In-Reply-To: <bug-10021-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-10021-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-10021-70-onYVJxuCsl@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10021

--- Comment #33 from Jonathan Druart <jonathan.druart at bugs.koha-community.org> ---
(In reply to Marcel de Rooy from comment #30)
> When you remove a sub from a module without full coverage, this is the
> result. Something for QA tools ?

Yes, could be improved. POD failures must be considered as warnings.

(In reply to Marcel de Rooy from comment #31)
> (In reply to Jonathan Druart from comment #8)
> > It appears that has never worked.
> > Could someone confirm?
> 
> Did you have any response whatsoever ?

I think we discussed it on IRC, but I do not find the logs.

(In reply to Marcel de Rooy from comment #32)
> QA Comment:
> 
> GetOverduesForBranch
> Please add a test. You make some fundamental changes here.

Fundamental? I do not understand what you want me to test.

> koha-tmpl/intranet-tmpl/prog/en/modules/members/pay.tt
> -    <input type="hidden" name="totals[% line.accountlines_id %]" value="[%
> line.totals %]" />
> Not sure. Why do yo remove this line ?

Yes it could have been done somewhere else, it's not directly related to these
changes. There is no "totals*" variables retrieved from the pl script.

> New code:
> +    my $accounts = Koha::Account::Lines->search({ borrowernumber =>
> $borrowernumber, }, { order_by => ['accounttype'] });
> +    my @accounts;
> +    while ( my $account = $accounts->next ) {
> This does not look very nice. Can we get more confusion on $account,
> @accounts or $accounts ?
> Renaming @accounts here might be the least we can do?
> No blocker on itself.

Will fix.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Nov  3 17:41:44 2017
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 03 Nov 2017 16:41:44 +0000
Subject: [Koha-bugs] [Bug 10021] Remove dead code related to notifys
In-Reply-To: <bug-10021-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-10021-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-10021-70-5hHMHT5uYq@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10021

--- Comment #34 from Jonathan Druart <jonathan.druart at bugs.koha-community.org> ---
Created attachment 68920
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=68920&action=edit
Bug 10021: (QA follow-up) Rename variables

To avoid $account, $accounts and @accounts variables in the same scope

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Nov  3 17:45:21 2017
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 03 Nov 2017 16:45:21 +0000
Subject: [Koha-bugs] [Bug 6918] can't place holds on 'on order' items with
 AllowOnShelfHolds off
In-Reply-To: <bug-6918-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-6918-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-6918-70-vveKySsVJ7@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6918

--- Comment #29 from Jonathan Druart <jonathan.druart at bugs.koha-community.org> ---
Simon, make sure your branch is up-to-date with origin/master

-- 
You are receiving this mail because:
You are the QA Contact for the bug.
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Nov  3 17:50:09 2017
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 03 Nov 2017 16:50:09 +0000
Subject: [Koha-bugs] [Bug 7317] Add an Interlibrary Loan Module to
	Circulation and OPAC
In-Reply-To: <bug-7317-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-7317-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-7317-70-iqNvlxFuZl@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7317

Tom?s Cohen Arazi <tomascohen at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #68885|0                           |1
        is obsolete|                            |

--- Comment #173 from Tom?s Cohen Arazi <tomascohen at gmail.com> ---
Created attachment 68921
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=68921&action=edit
Bug 7317: Handle backend absense more gracefuly

5/ This patch makes Koha::Illrequest->load_backend raise an exception
if the passed backend is invalid. This way we will catch more errors
introduced.

The patch also disables the 'New Ill request' when no backends are available.
Gets
rid of a related warnings.

Both OPAC and Intranet now display a warning message when no backends
are available.

Tests are added for the load_backend changes.

4/ This patch fixes the path for the checkboxes jquery plugin, and removes the
include
for tablesorter, as this implementation uses Datatables. This is obviously code
for older
Koha, ported to master.

TODO: There's something wrong on the styling. My idea is to get rid
of the custom column visualization tool, and have it display as regular
DataTables. We can then introduce the use of colvis on a separate bug
report.

Note: POD coverage for the exceptions file is wrongly tested. It is a false
positive.

Signed-off-by: Tomas Cohen Arazi <tomascohen at theke.io>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Nov  3 17:50:22 2017
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 03 Nov 2017 16:50:22 +0000
Subject: [Koha-bugs] [Bug 7317] Add an Interlibrary Loan Module to
	Circulation and OPAC
In-Reply-To: <bug-7317-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-7317-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-7317-70-tFUn5cNlDu@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7317

Tom?s Cohen Arazi <tomascohen at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #68886|0                           |1
        is obsolete|                            |

--- Comment #174 from Tom?s Cohen Arazi <tomascohen at gmail.com> ---
Created attachment 68922
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=68922&action=edit
Bug 7317: (QA followup) Get rid of warnings from the tests

Signed-off-by: Tomas Cohen Arazi <tomascohen at theke.io>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Nov  3 17:50:48 2017
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 03 Nov 2017 16:50:48 +0000
Subject: [Koha-bugs] [Bug 7317] Add an Interlibrary Loan Module to
	Circulation and OPAC
In-Reply-To: <bug-7317-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-7317-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-7317-70-iQ0hQ4SsjY@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7317

Tom?s Cohen Arazi <tomascohen at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Failed QA                   |Passed QA

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Nov  3 17:52:22 2017
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 03 Nov 2017 16:52:22 +0000
Subject: [Koha-bugs] [Bug 19176] Dates comparison fails on slow server
In-Reply-To: <bug-19176-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-19176-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-19176-70-MNLii1UwNx@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19176

--- Comment #27 from Jonathan Druart <jonathan.druart at bugs.koha-community.org> ---
Created attachment 68923
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=68923&action=edit
Bug 19176: (QA follow-up) few cosmetic changes

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Nov  3 17:53:18 2017
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 03 Nov 2017 16:53:18 +0000
Subject: [Koha-bugs] [Bug 19176] Dates comparison fails on slow server
In-Reply-To: <bug-19176-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-19176-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-19176-70-VwVqGjdMoH@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19176

--- Comment #28 from Jonathan Druart <jonathan.druart at bugs.koha-community.org> ---
Last patch pushed to master

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Nov  3 17:54:51 2017
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 03 Nov 2017 16:54:51 +0000
Subject: [Koha-bugs] [Bug 19576] opac-detail has duplicate 'use
	Koha::Biblios; '
In-Reply-To: <bug-19576-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-19576-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-19576-70-SxAzi2plCp@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19576

Jonathan Druart <jonathan.druart at bugs.koha-community.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Passed QA                   |Pushed to Master

--- Comment #4 from Jonathan Druart <jonathan.druart at bugs.koha-community.org> ---
Pushed to master for 17.11, thanks Mark!

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Nov  3 18:00:05 2017
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 03 Nov 2017 17:00:05 +0000
Subject: [Koha-bugs] [Bug 11213] GetItemsInfo() called twice
In-Reply-To: <bug-11213-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-11213-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-11213-70-jbbCP147jN@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11213

Josef Moravec <josef.moravec at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Needs Signoff               |Failed QA

--- Comment #128 from Josef Moravec <josef.moravec at gmail.com> ---
Hi Srdjan,
I did test these patches now, but I am sorry:

The test Search.t is failing after this patchset...

 #   Failed test 'Warning is raised correctly for invalid tags in MARC::Record'
 #   at t/db_dependent/Search.t line 681.

there are also so many warnings about preferences missing in mock


virtualshelves on intranet and opac goes to ISE:

DBIx::Class::ResultSet::_construct_results(): Unable to properly collapse
has_many results in iterator mode due to order criteria - performed an eager
cursor slurp underneath. Consider using ->all() instead at
/home/vagrant/kohaclone/Koha/Objects.pm line 209
Can't use string ("1") as an ARRAY ref while "strict refs" in use at
/home/vagrant/kohaclone/C4/XSLT.pm line 290.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Nov  3 18:29:04 2017
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 03 Nov 2017 17:29:04 +0000
Subject: [Koha-bugs] [Bug 18625] update borrower last seen from SIP
In-Reply-To: <bug-18625-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-18625-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-18625-70-eeB9XFE0WI@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18625

Jessie Zairo <jzairo at bywatersolutions.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |jzairo at bywatersolutions.com

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Nov  3 18:48:37 2017
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 03 Nov 2017 17:48:37 +0000
Subject: [Koha-bugs] [Bug 19577] New: Secondary email is unable to receive
	notices
Message-ID: <bug-19577-70@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19577

            Bug ID: 19577
           Summary: Secondary email is unable to receive notices
 Change sponsored?: ---
           Product: Koha
           Version: 16.11
          Hardware: All
                OS: All
            Status: NEW
          Severity: enhancement
          Priority: P5 - low
         Component: Notices
          Assignee: koha-bugs at lists.koha-community.org
          Reporter: nick.weingardt at valorchristian.com
        QA Contact: testopia at bugs.koha-community.org

Overview: Patrons are able to have multiple email addresses in Koha, but
notices can only be sent to the primary email. The purpose of this bug is to
develop an enhancement that would allow a notice be sent to both emails.

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Nov  3 18:57:47 2017
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 03 Nov 2017 17:57:47 +0000
Subject: [Koha-bugs] [Bug 19559] Elasticsearch QueryAutoTruncate truncate
 field names with hyphens if data is quoted
In-Reply-To: <bug-19559-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-19559-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-19559-70-f3GEO2IXQy@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19559

David Bourgault <david.bourgault at inlibro.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #68881|0                           |1
        is obsolete|                            |

--- Comment #5 from David Bourgault <david.bourgault at inlibro.com> ---
Created attachment 68924
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=68924&action=edit
Bug 19559 - Unit tests

Signed-off-by: David Bourgault <david.bourgault at inlibro.com>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Nov  3 18:57:49 2017
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 03 Nov 2017 17:57:49 +0000
Subject: [Koha-bugs] [Bug 19559] Elasticsearch QueryAutoTruncate truncate
 field names with hyphens if data is quoted
In-Reply-To: <bug-19559-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-19559-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-19559-70-OPZYqC2Tkx@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19559

David Bourgault <david.bourgault at inlibro.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #68882|0                           |1
        is obsolete|                            |

--- Comment #6 from David Bourgault <david.bourgault at inlibro.com> ---
Created attachment 68925
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=68925&action=edit
Bug 19559 - Add '-' to list of characters we don't split search terms on

Test plan assumes
QueryAutoTruncate = automatically
SearchEngine = Elasticsearch

To test:
0 - Apply Unit test patch only
1 - prove t/db_dependent/Koha_SearchEngine_Elasticsearch_Search.t
2 - Should fail
3 - Apply this patch
4 - prove t/db_dependent/Koha_SearchEngine_Elasticsearch_Search.t
5 - should pass
6 - search for 'Local-number:"4"' (or a vlid biblionumber)
7 - should get expected result

Signed-off-by: David Bourgault <david.bourgault at inlibro.com>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Nov  3 18:58:21 2017
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 03 Nov 2017 17:58:21 +0000
Subject: [Koha-bugs] [Bug 19559] Elasticsearch QueryAutoTruncate truncate
 field names with hyphens if data is quoted
In-Reply-To: <bug-19559-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-19559-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-19559-70-yyhK5ghjRR@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19559

David Bourgault <david.bourgault at inlibro.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Needs Signoff               |Signed Off
                 CC|                            |david.bourgault at inlibro.com

--- Comment #7 from David Bourgault <david.bourgault at inlibro.com> ---
Works as described in test plan.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Nov  3 19:09:16 2017
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 03 Nov 2017 18:09:16 +0000
Subject: [Koha-bugs] [Bug 18725] Process_message_queue sends duplicate
 emails if message_queue is not writable.
In-Reply-To: <bug-18725-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-18725-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-18725-70-ngndZJUnRH@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18725

David Bourgault <david.bourgault at inlibro.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |david.bourgault at inlibro.com

--- Comment #8 from David Bourgault <david.bourgault at inlibro.com> ---
It would be easier if you could provide maybe a hint on how to block access to
the message_queue table? Not sure how to test this otherwise.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Nov  3 19:24:51 2017
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 03 Nov 2017 18:24:51 +0000
Subject: [Koha-bugs] [Bug 7317] Add an Interlibrary Loan Module to
	Circulation and OPAC
In-Reply-To: <bug-7317-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-7317-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-7317-70-83enJscosB@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7317

Tom?s Cohen Arazi <tomascohen at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #68561|0                           |1
        is obsolete|                            |

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Nov  3 19:29:22 2017
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 03 Nov 2017 18:29:22 +0000
Subject: [Koha-bugs] [Bug 7317] Add an Interlibrary Loan Module to
	Circulation and OPAC
In-Reply-To: <bug-7317-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-7317-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-7317-70-GPRwrjg3h7@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7317

--- Comment #175 from Tom?s Cohen Arazi <tomascohen at gmail.com> ---
Created attachment 68926
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=68926&action=edit
Bug 7317: opac.css update

Signed-off-by: Tomas Cohen Arazi <tomascohen at theke.io>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Nov  3 19:29:26 2017
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 03 Nov 2017 18:29:26 +0000
Subject: [Koha-bugs] [Bug 18915] Creating a checkout note (patron note)
 sends an incomplete email message
In-Reply-To: <bug-18915-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-18915-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-18915-70-cD07qEVeGI@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18915

Caroline Cyr La Rose <caroline.cyr-la-rose at inlibro.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |caroline.cyr-la-rose at inlibr
                   |                            |o.com

--- Comment #9 from Caroline Cyr La Rose <caroline.cyr-la-rose at inlibro.com> ---
The test plan works. 

However, is it normal that if I add <<issues.note>> in the notice it comes back
as blank in the message_queue table?

I checked and my notes are in the issues table.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Nov  3 19:34:01 2017
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 03 Nov 2017 18:34:01 +0000
Subject: [Koha-bugs] [Bug 17656] Irregularities in serial prediction pattern
 are planned only for current subscription
In-Reply-To: <bug-17656-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-17656-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-17656-70-910sIl9gvK@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17656

David Bourgault <david.bourgault at inlibro.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |david.bourgault at inlibro.com
             Status|Needs Signoff               |Failed QA

--- Comment #20 from David Bourgault <david.bourgault at inlibro.com> ---
Test plan works as described, but QA tools warns of forbidden patterns.

koha-tmpl/intranet-tmpl/prog/en/includes/serials/subscription_daily_choice.inc
   FAIL   forbidden patterns
                forbidden pattern: Do not use line breaks inside template tags
(bug 18675) (line 5)

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Nov  3 19:40:33 2017
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 03 Nov 2017 18:40:33 +0000
Subject: [Koha-bugs] [Bug 19578] New: TT syntax for notices - There is no
 way to pre-process DB fields
Message-ID: <bug-19578-70@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19578

            Bug ID: 19578
           Summary: TT syntax for notices - There is no way to pre-process
                    DB fields
 Change sponsored?: ---
           Product: Koha
           Version: unspecified
          Hardware: All
                OS: All
            Status: NEW
          Severity: normal
          Priority: P5 - low
         Component: Notices
          Assignee: koha-bugs at lists.koha-community.org
          Reporter: jonathan.druart at bugs.koha-community.org
        QA Contact: testopia at bugs.koha-community.org

Jenkins fails (run 287) on a test in t/db_dependent/Letters/TemplateToolkit.t:

With the historical syntax:
        # Your request for an article from tQYRS (c3Av58O0P5xkkIGu) has been
canceled for the following reason:

With the TT syntax:
        # Your request for an article from tQYRS_ (c3Av58O0P5xkkIGu) has been
canceled for the following reason:

The last character of the biblio's title has been removed because it's a
punctuation character.
It comes from: C4::Letters::_parseletter
 893         $val =~ s/\p{P}$// if $val && $table=~/biblio/;

The same replacement is done for patron's attributes too.

With the TT syntax we retrieve the objects and send them to the template,
without fetching the attributes.
To restore this behaviour we could apply this regex on all the fields of the
biblio objects, but it could be perf killer (we will process fields that we
will certainly not used in the template).
I thought about the TT filter we could apply on all the variables we display,
but we will not know where come from the data, and we need to apply this change
only for the biblio table.

Any other ideas?

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Nov  3 19:41:05 2017
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 03 Nov 2017 18:41:05 +0000
Subject: [Koha-bugs] [Bug 19578] TT syntax for notices - There is no way to
 pre-process DB fields
In-Reply-To: <bug-19578-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-19578-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-19578-70-sfsCFfHfDw@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19578

Jonathan Druart <jonathan.druart at bugs.koha-community.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |kyle at bywatersolutions.com,
                   |                            |tomascohen at gmail.com
             Status|NEW                         |In Discussion

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Nov  3 19:46:07 2017
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 03 Nov 2017 18:46:07 +0000
Subject: [Koha-bugs] [Bug 19578] TT syntax for notices - There is no way to
 pre-process DB fields
In-Reply-To: <bug-19578-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-19578-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-19578-70-TyadFvSmnB@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19578

Jonathan Druart <jonathan.druart at bugs.koha-community.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |m.de.rooy at rijksmuseum.nl

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Nov  3 19:55:32 2017
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 03 Nov 2017 18:55:32 +0000
Subject: [Koha-bugs] [Bug 6918] can't place holds on 'on order' items with
 AllowOnShelfHolds off
In-Reply-To: <bug-6918-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-6918-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-6918-70-IENsozmEH5@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6918

Dominic Pichette <dominic.pichette at inlibro.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |dominic.pichette at inlibro.co
                   |                            |m

--- Comment #30 from Dominic Pichette <dominic.pichette at inlibro.com> ---
I did a reset --hard on origin/master and still have the same error than
Simon..

-- 
You are receiving this mail because:
You are the QA Contact for the bug.
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Nov  3 20:06:49 2017
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 03 Nov 2017 19:06:49 +0000
Subject: [Koha-bugs] [Bug 7317] Add an Interlibrary Loan Module to
	Circulation and OPAC
In-Reply-To: <bug-7317-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-7317-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-7317-70-N7X9wUL890@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7317

Tom?s Cohen Arazi <tomascohen at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #68921|0                           |1
        is obsolete|                            |

--- Comment #176 from Tom?s Cohen Arazi <tomascohen at gmail.com> ---
Created attachment 68927
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=68927&action=edit
Bug 7317: Handle backend absense more gracefuly

5/ This patch makes Koha::Illrequest->load_backend raise an exception
if the passed backend is invalid. This way we will catch more errors
introduced.

The patch also disables the 'New Ill request' when no backends are available.
Gets
rid of a related warnings.

Both OPAC and Intranet now display a warning message when no backends
are available.

Tests are added for the load_backend changes.

4/ This patch fixes the path for the checkboxes jquery plugin, and removes the
include
for tablesorter, as this implementation uses Datatables. This is obviously code
for older
Koha, ported to master.

TODO: There's something wrong on the styling. My idea is to get rid
of the custom column visualization tool, and have it display as regular
DataTables. We can then introduce the use of colvis on a separate bug
report.

Note: POD coverage for the exceptions file is wrongly tested. It is a false
positive.

Signed-off-by: Tomas Cohen Arazi <tomascohen at theke.io>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Nov  3 20:07:01 2017
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 03 Nov 2017 19:07:01 +0000
Subject: [Koha-bugs] [Bug 7317] Add an Interlibrary Loan Module to
	Circulation and OPAC
In-Reply-To: <bug-7317-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-7317-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-7317-70-Ml0l5S8R9h@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7317

Tom?s Cohen Arazi <tomascohen at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #68922|0                           |1
        is obsolete|                            |

--- Comment #177 from Tom?s Cohen Arazi <tomascohen at gmail.com> ---
Created attachment 68928
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=68928&action=edit
Bug 7317: (QA followup) Get rid of warnings from the tests

Signed-off-by: Tomas Cohen Arazi <tomascohen at theke.io>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Nov  3 20:07:12 2017
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 03 Nov 2017 19:07:12 +0000
Subject: [Koha-bugs] [Bug 7317] Add an Interlibrary Loan Module to
	Circulation and OPAC
In-Reply-To: <bug-7317-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-7317-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-7317-70-2lPA6ls1KB@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7317

Tom?s Cohen Arazi <tomascohen at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #68926|0                           |1
        is obsolete|                            |

--- Comment #178 from Tom?s Cohen Arazi <tomascohen at gmail.com> ---
Created attachment 68929
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=68929&action=edit
Bug 7317: opac.css update

Signed-off-by: Tomas Cohen Arazi <tomascohen at theke.io>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Nov  3 20:09:06 2017
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 03 Nov 2017 19:09:06 +0000
Subject: [Koha-bugs] [Bug 19014] Patrons should not get a on_reserve
 notification if the checkout is due in the future
In-Reply-To: <bug-19014-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-19014-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-19014-70-uOohhmt4Yf@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19014

Caroline Cyr La Rose <caroline.cyr-la-rose at inlibro.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |caroline.cyr-la-rose at inlibr
                   |                            |o.com
             Status|Needs Signoff               |Failed QA

--- Comment #5 from Caroline Cyr La Rose <caroline.cyr-la-rose at inlibro.com> ---
Hi Jonathan,

I'm having trouble testing this. Which cron job are we supposed to run? Is it
automatic_renewals.pl --send-notices?

Furthermore, I had an item due in the future (in december) and I still received
a notice saying the auto renewal failed because I had fines (which was true).
But why would it try to renew something due in december?

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Nov  3 20:10:17 2017
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 03 Nov 2017 19:10:17 +0000
Subject: [Koha-bugs] [Bug 18357] On-site checkouts issues with 'Unlimited'
In-Reply-To: <bug-18357-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-18357-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-18357-70-ivcYq6ZQyj@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18357

David Bourgault <david.bourgault at inlibro.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Needs Signoff               |Signed Off

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.

From bugzilla-daemon at bugs.koha-community.org  Fri Nov  3 20:10:20 2017
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 03 Nov 2017 19:10:20 +0000
Subject: [Koha-bugs] [Bug 18357] On-site checkouts issues with 'Unlimited'
In-Reply-To: <bug-18357-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-18357-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-18357-70-qQB2oNa9AS@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18357

David Bourgault <david.bourgault at inlibro.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #68896|0                           |1
        is obsolete|                            |

--- Comment #5 from David Bourgault <david.bourgault at inlibro.com> ---
Created attachment 68930
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=68930&action=edit
Bug 18357: Handle unlimited on-site checkouts

If on-site checkouts are set to unlimited (i.e. NULL/undef), they are
currently blocked.

Test plan:
1/ Set All/All rule with Unlimited/unlimited for normal/onsite checkouts
2/ Will be able to perform onsite checkout
3/ Edit rule to be 15/Unlimited normal/onsite
4/ Will be able to perform onsite checkout
=> Without this patch it was blocked
5/ Set rule to 15/15
6/ Onsite checkouts work again

Signed-off-by: David Bourgault <david.bourgault at inlibro.com>

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.

From bugzilla-daemon at bugs.koha-community.org  Fri Nov  3 20:12:10 2017
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 03 Nov 2017 19:12:10 +0000
Subject: [Koha-bugs] [Bug 7317] Add an Interlibrary Loan Module to
	Circulation and OPAC
In-Reply-To: <bug-7317-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-7317-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-7317-70-lLThauRlSQ@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7317

Tom?s Cohen Arazi <tomascohen at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #68927|0                           |1
        is obsolete|                            |

--- Comment #179 from Tom?s Cohen Arazi <tomascohen at gmail.com> ---
Created attachment 68931
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=68931&action=edit
Bug 7317: Handle backend absense more gracefuly

5/ This patch makes Koha::Illrequest->load_backend raise an exception
if the passed backend is invalid. This way we will catch more errors
introduced.

The patch also disables the 'New Ill request' when no backends are available.
Gets
rid of a related warnings.

Both OPAC and Intranet now display a warning message when no backends
are available.

Tests are added for the load_backend changes.

4/ This patch fixes the path for the checkboxes jquery plugin, and removes the
include
for tablesorter, as this implementation uses Datatables. This is obviously code
for older
Koha, ported to master.

TODO: There's something wrong on the styling. My idea is to get rid
of the custom column visualization tool, and have it display as regular
DataTables. We can then introduce the use of colvis on a separate bug
report.

Note: POD coverage for the exceptions file is wrongly tested. It is a false
positive.

Signed-off-by: Tomas Cohen Arazi <tomascohen at theke.io>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Nov  3 20:12:23 2017
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 03 Nov 2017 19:12:23 +0000
Subject: [Koha-bugs] [Bug 7317] Add an Interlibrary Loan Module to
	Circulation and OPAC
In-Reply-To: <bug-7317-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-7317-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-7317-70-ScTB8I2ZuJ@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7317

Tom?s Cohen Arazi <tomascohen at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #68928|0                           |1
        is obsolete|                            |

--- Comment #180 from Tom?s Cohen Arazi <tomascohen at gmail.com> ---
Created attachment 68932
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=68932&action=edit
Bug 7317: (QA followup) Get rid of warnings from the tests

Signed-off-by: Tomas Cohen Arazi <tomascohen at theke.io>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Nov  3 20:12:35 2017
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 03 Nov 2017 19:12:35 +0000
Subject: [Koha-bugs] [Bug 7317] Add an Interlibrary Loan Module to
	Circulation and OPAC
In-Reply-To: <bug-7317-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-7317-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-7317-70-XSg6jrINZT@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7317

Tom?s Cohen Arazi <tomascohen at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #68929|0                           |1
        is obsolete|                            |

--- Comment #181 from Tom?s Cohen Arazi <tomascohen at gmail.com> ---
Created attachment 68933
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=68933&action=edit
Bug 7317: opac.css update

Signed-off-by: Tomas Cohen Arazi <tomascohen at theke.io>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Nov  3 20:22:24 2017
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 03 Nov 2017 19:22:24 +0000
Subject: [Koha-bugs] [Bug 16787] 'Too many holds' message appears
 inappropriately and is missing data
In-Reply-To: <bug-16787-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-16787-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-16787-70-TXQr7mhgF6@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16787

David Bourgault <david.bourgault at inlibro.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Needs Signoff               |Failed QA
                 CC|                            |david.bourgault at inlibro.com

--- Comment #7 from David Bourgault <david.bourgault at inlibro.com> ---
Is there a step missing form the test plan? I applied the patch, change my
Circulation rules to set no holds for All/All (I have no other rules for my
test patron's category) and tried to place a hold but got the message "No
available items.", but I can see it as available on the OPAC detail page.

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Nov  3 20:26:22 2017
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 03 Nov 2017 19:26:22 +0000
Subject: [Koha-bugs] [Bug 6918] can't place holds on 'on order' items with
 AllowOnShelfHolds off
In-Reply-To: <bug-6918-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-6918-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-6918-70-tQsufCOsyW@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6918

Jonathan Druart <jonathan.druart at bugs.koha-community.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #68898|0                           |1
        is obsolete|                            |

--- Comment #31 from Jonathan Druart <jonathan.druart at bugs.koha-community.org> ---
Created attachment 68934
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=68934&action=edit
Bug 6918 - can't place holds on 'on order' items with AllowOnShelfHolds off

Test Plan:
1) Apply patch
2) Turn off AllowOnShelfHolds
3) Create a bib with one item, mark the item as 'on order'
4) Attempt to place a hold on the item, you should now be able to do so

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the QA Contact for the bug.

From bugzilla-daemon at bugs.koha-community.org  Fri Nov  3 20:45:25 2017
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 03 Nov 2017 19:45:25 +0000
Subject: [Koha-bugs] [Bug 19444] Automatic renewal script should not
 auto-renew if a patron' s record has expired
In-Reply-To: <bug-19444-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-19444-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-19444-70-xFMFWs7tAL@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19444

Dominic Pichette <dominic.pichette at inlibro.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |dominic.pichette at inlibro.co
                   |                            |m

--- Comment #10 from Dominic Pichette <dominic.pichette at inlibro.com> ---
I tried it, I started by setting BlockExpiredPatronOpacActions to set, checked
out an item for a particular patron, change the expiration date of that patron
so he is now expired and then executed automatic_renewals.pl. The patch didn't
seem to make a difference, it passed in both cases..

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Nov  3 20:54:37 2017
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 03 Nov 2017 19:54:37 +0000
Subject: [Koha-bugs] [Bug 19485] Limiting by title-series (se) broken on ES
In-Reply-To: <bug-19485-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-19485-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-19485-70-9dTr35Hia9@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19485

--- Comment #3 from David Bourgault <david.bourgault at inlibro.com> ---
The mappings are supposed to be located in
admin/searchengine/elasticsearch/mappings.yaml

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Nov  3 20:55:12 2017
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 03 Nov 2017 19:55:12 +0000
Subject: [Koha-bugs] [Bug 7317] Add an Interlibrary Loan Module to
	Circulation and OPAC
In-Reply-To: <bug-7317-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-7317-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-7317-70-t9eTuoKaWI@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7317

--- Comment #182 from Jonathan Druart <jonathan.druart at bugs.koha-community.org> ---
1/ Error handling on borrowernumber when creating or updating a request
(backend issue?)
2/ Capitalization problems, deprecated words (Branch, borrowers), etc
3/ Use dateformat to display dates
4/ ill/ill-requests.pl?method=generic_confirm&illrequest_id=3
click "send email"
Software error to handle correctly:
No target email addresses found. Either select at least one partner or check
your ILL partner library records. at /home/vagrant/kohaclone/Koha/Illrequest.pm
line 896.

5/ Same for "Your branch has no email address. Please set it. at
/home/vagrant/kohaclone/Koha/Illrequest.pm line 901."

6/ Should not we use message_queue instead of sendmail directly?

7/ Maybe we should add a warning to the about page if the partner_code defined
in the config does not match a category_code (?)

(not finished)

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Nov  3 20:56:17 2017
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 03 Nov 2017 19:56:17 +0000
Subject: [Koha-bugs] [Bug 19444] Automatic renewal script should not
 auto-renew if a patron' s record has expired
In-Reply-To: <bug-19444-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-19444-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-19444-70-GC5oSEm0R5@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19444

--- Comment #11 from Dominic Pichette <dominic.pichette at inlibro.com> ---
I tried it, I started by setting BlockExpiredPatronOpacActions to set, checked
out an item for a particular patron, change the expiration date of that patron
so he is now expired and then executed automatic_renewals.pl. The patch didn't
seem to make a difference, it passed in both cases..

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Nov  3 21:03:43 2017
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 03 Nov 2017 20:03:43 +0000
Subject: [Koha-bugs] [Bug 19542] Koha should display Elasticsearch
 information in the about page
In-Reply-To: <bug-19542-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-19542-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-19542-70-4KwnYnuhTw@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19542

David Bourgault <david.bourgault at inlibro.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Needs Signoff               |Signed Off

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Nov  3 21:03:45 2017
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 03 Nov 2017 20:03:45 +0000
Subject: [Koha-bugs] [Bug 19542] Koha should display Elasticsearch
 information in the about page
In-Reply-To: <bug-19542-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-19542-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-19542-70-hmQtL7cFJJ@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19542

David Bourgault <david.bourgault at inlibro.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #68861|0                           |1
        is obsolete|                            |

--- Comment #5 from David Bourgault <david.bourgault at inlibro.com> ---
Created attachment 68935
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=68935&action=edit
Bug 19542: Add a check for ES configuration health

This patch adds a new statuc function to Koha::SearchEngine::ElasticSearch
which is instended to replace most of get_elasticsearch_params. This function
reads the configuration from C4::Context->config('elasticsearch') and raises
relevant exceptions when mandatory entries are missing.

Its behaviour is covered by tests.

To test:
- Run:
  $ kshell
 k$ prove t/Koha/SearchEngine/Elasticsearch.t
=> SUCCESS: Tests pass!
- Sign off :-D

Signed-off-by: David Bourgault <david.bourgault at inlibro.com>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Nov  3 21:03:59 2017
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 03 Nov 2017 20:03:59 +0000
Subject: [Koha-bugs] [Bug 19542] Koha should display Elasticsearch
 information in the about page
In-Reply-To: <bug-19542-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-19542-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-19542-70-xqbVzeeX2U@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19542

David Bourgault <david.bourgault at inlibro.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #68862|0                           |1
        is obsolete|                            |

--- Comment #6 from David Bourgault <david.bourgault at inlibro.com> ---
Created attachment 68936
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=68936&action=edit
Bug 19542: Add Elasticsearch information in the 'About' page

This patch adds Elasticsearch related information to the 'About' page.

The information is gathered and displayed only when the 'SearchEngine' syspref
is set to 'Elasticsearch'. It displays configured nodes, and the status:
- Running
- Not running

In case it is running, it displays the defined indices and the document count
on each.
If there are configuration problems, exceptions are catch and a convenient
warning
message is displayed.

To test:
- Apply this patches
- Run:
  $ kshell
 k$ prove t/Koha/SearchEngine/Elasticsearch.t
=> SUCCESS: Tests pass!
- Have ES configured in your koha-conf.xml file (by default in kohadevbox)
- Set the 'SearchEngine' syspref to 'Elasticsearch'
- Comment out pieces of the elasticsearch-specific entries (server, index_name,
  the whole elasticsearch block). Reload on each change.
=> SUCCESS: Warning messages are displayed and make sense in the context of
your changes.
----> the rest of the tests require having ES running on the dev env. This can
be easily
      achieved by creating the kohadevbox using:
        $ KOHA_ELASTICSEARCH=1 vagrant up
- Stop the 'elasticsearch' service:
  $ sudo service elasticsearch stop
- Reload about.pl
=> SUCCESS: The configured nodes are displayed, and the status is 'not running'
- Start the 'elasticsearch' service:
  $ sudo service elasticsearch start
- Reload about.pl
=> SUCCESS: The configured nodes are displayed, the status is 'running' and
            created indices info is displayed, along with the document count
            on each index.
- Sign off :-D

Signed-off-by: David Bourgault <david.bourgault at inlibro.com>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Nov  3 21:07:47 2017
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 03 Nov 2017 20:07:47 +0000
Subject: [Koha-bugs] [Bug 19482] Elasticsearch - prevent removal / editing
 of required indexes
In-Reply-To: <bug-19482-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-19482-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-19482-70-nTb2sz9dit@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19482

David Bourgault <david.bourgault at inlibro.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Needs Signoff               |Patch doesn't apply
                 CC|                            |david.bourgault at inlibro.com

--- Comment #4 from David Bourgault <david.bourgault at inlibro.com> ---
The 2nd patch does not apply on current master. (Lacking or useless SHA1)

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Nov  3 21:14:14 2017
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 03 Nov 2017 20:14:14 +0000
Subject: [Koha-bugs] [Bug 19066] Add branchcode to accountlines
In-Reply-To: <bug-19066-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-19066-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-19066-70-l3eLuYzWRl@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19066

David Bourgault <david.bourgault at inlibro.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Needs Signoff               |Patch doesn't apply
                 CC|                            |david.bourgault at inlibro.com

--- Comment #10 from David Bourgault <david.bourgault at inlibro.com> ---
Patch doesnt apply for me on master.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Nov  3 21:17:15 2017
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 03 Nov 2017 20:17:15 +0000
Subject: [Koha-bugs] [Bug 17672] Items table should have a damaged_on column
In-Reply-To: <bug-17672-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-17672-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-17672-70-VIJcFNcggq@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17672

Charles Farmer <charles.farmer at inlibro.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |charles.farmer at inlibro.com

--- Comment #7 from Charles Farmer <charles.farmer at inlibro.com> ---
Since we see the date at which the item was damaged on the moredetail.pl,
should we also see this information in the header table of the additem.pl page
along the status? Just pitching the idea out there.

Everything worked fine, though I had to bump up the number of tests from 12 to
13 in order to make it work on the current master.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Nov  3 21:21:18 2017
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 03 Nov 2017 20:21:18 +0000
Subject: [Koha-bugs] [Bug 19522] Label creator - some strings are not
	translatable
In-Reply-To: <bug-19522-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-19522-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-19522-70-SAtBYw04Fv@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19522

--- Comment #25 from Dominic Pichette <dominic.pichette at inlibro.com> ---
i translated using misc/translator/translate fr-CA

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Nov  3 21:24:08 2017
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 03 Nov 2017 20:24:08 +0000
Subject: [Koha-bugs] [Bug 18948] Reindexing should use aliases to avoid down
	time
In-Reply-To: <bug-18948-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-18948-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-18948-70-yNfmTikJ63@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18948

David Bourgault <david.bourgault at inlibro.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |david.bourgault at inlibro.com
             Status|Needs Signoff               |Patch doesn't apply

--- Comment #6 from David Bourgault <david.bourgault at inlibro.com> ---
Patch does not apply, SHA1 error for Indexer.pm

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Nov  3 21:25:30 2017
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 03 Nov 2017 20:25:30 +0000
Subject: [Koha-bugs] [Bug 17672] Items table should have a damaged_on column
In-Reply-To: <bug-17672-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-17672-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-17672-70-JZCt5WXcXq@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17672

Charles Farmer <charles.farmer at inlibro.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #65551|0                           |1
        is obsolete|                            |
  Attachment #65552|0                           |1
        is obsolete|                            |

--- Comment #9 from Charles Farmer <charles.farmer at inlibro.com> ---
Created attachment 68938
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=68938&action=edit
Bug 17672 - Schema updates

Signed-off-by: Owen Leonard <oleonard at myacpl.org>

Signed-off-by: Charles Farmer <charles.farmer at inLibro.com>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Nov  3 21:25:15 2017
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 03 Nov 2017 20:25:15 +0000
Subject: [Koha-bugs] [Bug 17672] Items table should have a damaged_on column
In-Reply-To: <bug-17672-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-17672-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-17672-70-xsrD1Wenv5@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17672

--- Comment #8 from Charles Farmer <charles.farmer at inlibro.com> ---
Created attachment 68937
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=68937&action=edit
Bug 17672 - Items table should have a damaged_on column

This patchset adds a 'damaged_on' column to store the date an item is
marked damaged, analogous to withdrawn_on and itemlost_on

To test:
1 - Apply patch
2 - Mark an item damaged via moredetail.pl (Items tab on left in
        details)
3 - Note the damaged on date apears below
4 - Unmark the item, the date is removed
5 - Go to the edit items screen (from top bar 'Edit->edit items')
6 - Mark item damaged - check db or moredetails.pl to see damaged_on
date
7 - Unmark item damaged - confirm date is removed
8 - prove t/db_dependent/Items.t

Signed-off-by: Owen Leonard <oleonard at myacpl.org>

Signed-off-by: Charles Farmer <charles.farmer at inLibro.com>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Nov  3 21:25:36 2017
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 03 Nov 2017 20:25:36 +0000
Subject: [Koha-bugs] [Bug 17672] Items table should have a damaged_on column
In-Reply-To: <bug-17672-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-17672-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-17672-70-CWI1hKjs8b@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17672

--- Comment #10 from Charles Farmer <charles.farmer at inlibro.com> ---
Created attachment 68939
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=68939&action=edit
Bug 17672 - Dumping Items.t expected tests from 12 to 13

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Nov  3 21:29:44 2017
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 03 Nov 2017 20:29:44 +0000
Subject: [Koha-bugs] [Bug 18950] Elasticsearch - Add password access for
	admin functions
In-Reply-To: <bug-18950-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-18950-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-18950-70-NGFZ3s4WGd@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18950

David Bourgault <david.bourgault at inlibro.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Needs Signoff               |Failed QA
                 CC|                            |david.bourgault at inlibro.com

--- Comment #3 from David Bourgault <david.bourgault at inlibro.com> ---
Patch applies, and basic functionality is there, however:

- "Reindex" checked for password correctly but failed since 18948 does not
apply for me (not an issue, just a note)

- The password input field is of type=text but should be of type=password
- The error message when you enter a wrong password should probably more
obvious (like being red, or using the standard koha warning boxes)
- I'd suggest moving the <elasticsearch_admin_password> XML node inside the
<elasticsearch> group, seems cleaner to me.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Nov  3 21:30:21 2017
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 03 Nov 2017 20:30:21 +0000
Subject: [Koha-bugs] [Bug 18936] Convert issuingrules fields to
	circulation_rules
In-Reply-To: <bug-18936-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-18936-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-18936-70-1b30ra3UsX@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18936

David Bourgault <david.bourgault at inlibro.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |david.bourgault at inlibro.com

--- Comment #8 from David Bourgault <david.bourgault at inlibro.com> ---
No test plan?

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Nov  3 21:38:33 2017
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 03 Nov 2017 20:38:33 +0000
Subject: [Koha-bugs] [Bug 18213] Add language facets to Elasticsearch
In-Reply-To: <bug-18213-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-18213-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-18213-70-J64dv3okgW@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18213

David Bourgault <david.bourgault at inlibro.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Needs Signoff               |Patch doesn't apply
                 CC|                            |david.bourgault at inlibro.com

--- Comment #5 from David Bourgault <david.bourgault at inlibro.com> ---
Does not apply.
fatal: sha1 information is lacking or useless
(Koha/SearchEngine/Elasticsearch.pm).

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Nov  3 21:39:21 2017
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 03 Nov 2017 20:39:21 +0000
Subject: [Koha-bugs] [Bug 19166] Add the ability to add adjustments to an
	invoice
In-Reply-To: <bug-19166-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-19166-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-19166-70-eXdiXq5pB5@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19166

Caroline Cyr La Rose <caroline.cyr-la-rose at inlibro.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Needs Signoff               |Failed QA
                 CC|                            |caroline.cyr-la-rose at inlibr
                   |                            |o.com

--- Comment #16 from Caroline Cyr La Rose <caroline.cyr-la-rose at inlibro.com> ---
I want this so much to work! I've been asked for this many many times!

But I got a software error.

BIx::Class::Storage::DBI::_dbh_execute(): Table
'koha_master_dev_inlibro.invoice_adjustments' doesn't exist at
/inlibro/git/koha-master-dev-inlibro/Koha/Object.pm line 121

Plus the prove -v ... returned red.

DBD::mysql::st execute failed: Table
'koha_master_dev_inlibro.invoice_adjustments' doesn't exist [for Statement
"SELECT `me`.`adjustment_id`, `me`.`invoiceid`, `me`.`adjustment`,
`me`.`reason`, `me`.`note`, `me`.`budget_id`, `me`.`encumber_open`,
`me`.`timestamp` FROM `invoice_adjustments` `me`  JOIN `aqinvoices` `invoiceid`
ON `invoiceid`.`invoiceid` = `me`.`invoiceid` WHERE ( ( `budget_id` = ? AND
`closedate` IS NOT NULL ) )" with ParamValues: 0='6'] at
/usr/share/perl5/DBIx/Class/Storage/DBI.pm line 1765.
DBIx::Class::Storage::DBI::_dbh_execute(): Table
'koha_master_dev_inlibro.invoice_adjustments' doesn't exist at
/inlibro/git/koha-master-dev-inlibro/Koha/Objects.pm line 209
# Looks like your test exited with 255 just after 60.
Dubious, test returned 255 (wstat 65280, 0xff00)
Failed 85/145 subtests 

Test Summary Report
-------------------
t/db_dependent/Budgets.t (Wstat: 65280 Tests: 60 Failed: 0)
  Non-zero exit status: 255
  Parse errors: Bad plan.  You planned 145 tests but ran 60.
Files=1, Tests=60,  1 wallclock secs ( 0.02 usr  0.00 sys +  1.49 cusr  0.08
csys =  1.59 CPU)
Result: FAIL

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Nov  3 21:40:55 2017
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 03 Nov 2017 20:40:55 +0000
Subject: [Koha-bugs] [Bug 13188] Mandatory fields are wrong in patron
 personal details page
In-Reply-To: <bug-13188-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-13188-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-13188-70-HITbUPrk08@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13188

Ola Andersson <ola.andersson at ltu.se> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |ola.andersson at ltu.se

--- Comment #3 from Ola Andersson <ola.andersson at ltu.se> ---
It is not possible with Koha 17.05.05 to configure a set of mandatory fields in
SelfRegistration and at the same time configure another set of mandatory fields
in SelfModification. This seems to be a design flaw.

E.g. we would like to have Address2 field mandatory in SelfRegistration but
optional in SelfModification.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Nov  3 21:49:33 2017
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 03 Nov 2017 20:49:33 +0000
Subject: [Koha-bugs] [Bug 19454] Script
 borrowers-force-messaging-defaults.pl should be able to filter on patron
 category
In-Reply-To: <bug-19454-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-19454-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-19454-70-dehGmVaijP@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19454

Charles Farmer <charles.farmer at inlibro.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |charles.farmer at inlibro.com

--- Comment #6 from Charles Farmer <charles.farmer at inlibro.com> ---
Can't really say if the problem is on my end or not, but I couldn't apply your
patches:
> fatal: sha1 information is lacking or useless (misc/maintenance/borrowers-force-messaging-defaults.pl)

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Nov  3 21:54:21 2017
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 03 Nov 2017 20:54:21 +0000
Subject: [Koha-bugs] [Bug 16461] Add some information (branch and barcode)
 in fine description for overdue
In-Reply-To: <bug-16461-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-16461-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-16461-70-Ti3Fv8XXKp@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16461

David Bourgault <david.bourgault at inlibro.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |david.bourgault at inlibro.com

--- Comment #8 from David Bourgault <david.bourgault at inlibro.com> ---
Missing a test plan

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Nov  3 21:55:27 2017
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 03 Nov 2017 20:55:27 +0000
Subject: [Koha-bugs] [Bug 18602] SPAM
In-Reply-To: <bug-18602-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-18602-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-18602-70-MNmWNn1ifl@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18602

Katrin Fischer <katrin.fischer at bsz-bw.de> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
            Summary|intuitI8OO3672164           |SPAM
                   |Quickbooks Payroll Tech     |
                   |Support Phone Number        |
                 CC|                            |katrin.fischer at bsz-bw.de

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Nov  3 22:00:23 2017
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 03 Nov 2017 21:00:23 +0000
Subject: [Koha-bugs] [Bug 19452] The -truncate option in
 borrowers-force-messaging-defaults.pl should not remove category
 preferences
In-Reply-To: <bug-19452-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-19452-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-19452-70-9YSA6bi3ZR@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19452

Charles Farmer <charles.farmer at inlibro.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |charles.farmer at inlibro.com

--- Comment #6 from Charles Farmer <charles.farmer at inlibro.com> ---
Can't really say where the problem lies, but I couldn't apply your patches:
> fatal: sha1 information is lacking or useless (misc/maintenance/borrowers-force-messaging-defaults.pl).

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Nov  3 22:05:26 2017
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 03 Nov 2017 21:05:26 +0000
Subject: [Koha-bugs] [Bug 19471] Show creation date in patron restrictions
	list
In-Reply-To: <bug-19471-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-19471-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-19471-70-vNgv7ZdBlh@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19471

Charles Farmer <charles.farmer at inlibro.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #68180|0                           |1
        is obsolete|                            |

--- Comment #3 from Charles Farmer <charles.farmer at inlibro.com> ---
Created attachment 68940
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=68940&action=edit
Bug 19471: Show creation date in patron restrictions list

Test plan:
1. Go to the "Details" vertical tab of a patron.
2. Click the "Restriction" tab in the bottom and add a manual restriction.
3. Verify a creation date is visible.

4. Edit the same patron.
5. Under "Patron restrictions" verify the creation date of the listed
   restiction is visible.

Signed-off-by: Owen Leonard <oleonard at myacpl.org>

Signed-off-by: Charles Farmer <charles.farmer at inLibro.com>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Nov  3 22:08:40 2017
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 03 Nov 2017 21:08:40 +0000
Subject: [Koha-bugs] [Bug 19549] Reserve Slip prints first found hold when
 patron has multiple holds on a biblio
In-Reply-To: <bug-19549-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-19549-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-19549-70-HZMG0wArSh@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19549

Caroline Cyr La Rose <caroline.cyr-la-rose at inlibro.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |caroline.cyr-la-rose at inlibr
                   |                            |o.com

--- Comment #2 from Caroline Cyr La Rose <caroline.cyr-la-rose at inlibro.com> ---
Is this for multiple holds on the same biblio?

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Nov  3 22:13:37 2017
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 03 Nov 2017 21:13:37 +0000
Subject: [Koha-bugs] [Bug 19549] Reserve Slip prints first found hold when
 patron has multiple holds on a biblio
In-Reply-To: <bug-19549-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-19549-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-19549-70-ZTI6XUi2nC@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19549

--- Comment #3 from Jason Palmer <jpalmer at switchinc.org> ---
(In reply to Caroline Cyr La Rose from comment #2)
> Is this for multiple holds on the same biblio?

Yes.  Multiple holds for same bib.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Nov  3 22:54:53 2017
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 03 Nov 2017 21:54:53 +0000
Subject: [Koha-bugs] [Bug 19579] New:
 PatronSelfRegistrationEmailMustBeUnique does not prevent duplicates when
 using PatronSelfRegistrationVerifyByEmail
Message-ID: <bug-19579-70@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19579

            Bug ID: 19579
           Summary: PatronSelfRegistrationEmailMustBeUnique does not
                    prevent duplicates when using
                    PatronSelfRegistrationVerifyByEmail
 Change sponsored?: ---
           Product: Koha
           Version: 16.05
          Hardware: All
                OS: All
            Status: NEW
          Severity: normal
          Priority: P5 - low
         Component: OPAC
          Assignee: oleonard at myacpl.org
          Reporter: baselibrary.consortium at nhs.net
        QA Contact: testopia at bugs.koha-community.org

With PatronSelfRegistrationVerifyByEmail set to Require and
PatronSelfRegistrationEmailMustBeUnique set to Consider a patron can still self
register many times using the same email address.

Test case
1. Patron submits self registration form using the same email address 3 times
2. Patron receives 3 verification emails
3. Patron clicks on 3 verify token URLs
4. Staff client now shows the 3 patrons
5. Patron logs into 3 accounts on OPAC
6. Patron cannot change personal details because email address already exists

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Nov  3 22:55:47 2017
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 03 Nov 2017 21:55:47 +0000
Subject: [Koha-bugs] [Bug 19579] PatronSelfRegistrationEmailMustBeUnique
 does not prevent duplicates when using PatronSelfRegistrationVerifyByEmail
In-Reply-To: <bug-19579-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-19579-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-19579-70-2YaWTn3GJA@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19579

BASE Library Consortium <baselibrary.consortium at nhs.net> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |baselibrary.consortium at nhs.
                   |                            |net

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Sat Nov  4 01:19:39 2017
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Sat, 04 Nov 2017 00:19:39 +0000
Subject: [Koha-bugs] [Bug 19420] Improve display of errors from failure of
 uploading file during stage import
In-Reply-To: <bug-19420-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-19420-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-19420-70-U1ScY7pFbQ@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19420

Nick Clemens <nick at bywatersolutions.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Failed QA                   |Signed Off

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Sat Nov  4 01:19:41 2017
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Sat, 04 Nov 2017 00:19:41 +0000
Subject: [Koha-bugs] [Bug 19420] Improve display of errors from failure of
 uploading file during stage import
In-Reply-To: <bug-19420-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-19420-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-19420-70-b9grrDTe57@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19420

Nick Clemens <nick at bywatersolutions.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #68910|0                           |1
        is obsolete|                            |

--- Comment #12 from Nick Clemens <nick at bywatersolutions.com> ---
Created attachment 68941
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=68941&action=edit
Bug 19420 - Add errors on other pages

Fix error array (add '0' value)
Update errors on other places using upload.js

Eventually these should all be using the same code in a js file

upload.tt already dealt with these errors, but has diff code, made it
work with new error syntax

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Sat Nov  4 01:21:44 2017
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Sat, 04 Nov 2017 00:21:44 +0000
Subject: [Koha-bugs] [Bug 19420] Improve display of errors from failure of
 uploading file during stage import
In-Reply-To: <bug-19420-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-19420-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-19420-70-ZlTeveO9Q0@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19420

--- Comment #13 from Nick Clemens <nick at bywatersolutions.com> ---
(In reply to Marcel de Rooy from comment #11)
> Upload local cover image
> Upload status: Failed - (2) Root directory for uploads not defined
> No, the directory was not writable.
> This went wrong since the errcode is 2, but you forgot to add a zero entry
> in you errMsgs array. So they are one position out of sync.
> Please add a leading entry here (see also upload.tt)
> var errMsgs = [ _("File already exists"), _("Directory is not writeable"),
> _("Root directory for uploads not defined"), _("Temporary directory for
> uploads not defined") ];
> Adjust same thing in two other places ?
Adjusted :-)

> 
>  //Next three errors have no code path to trigger that I see
> I am very confident that I tested all codes when I wrote this. They may be
> hard to simulate, but I did. Please remove this comment.

Removed, I though we only passed 1-4 back in the pm file, my apologies

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Sat Nov  4 02:27:22 2017
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Sat, 04 Nov 2017 01:27:22 +0000
Subject: [Koha-bugs] [Bug 19580] New: Elasticsearch: QueryAutoTruncate
 exclude period as splitting character in autotruncation
Message-ID: <bug-19580-70@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19580

            Bug ID: 19580
           Summary: Elasticsearch: QueryAutoTruncate exclude period as
                    splitting character in autotruncation
 Change sponsored?: ---
           Product: Koha
           Version: master
          Hardware: All
                OS: All
            Status: NEW
          Severity: normal
          Priority: P5 - low
         Component: Searching - Elasticsearch
          Assignee: koha-bugs at lists.koha-community.org
          Reporter: nick at bywatersolutions.com

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.

From bugzilla-daemon at bugs.koha-community.org  Sat Nov  4 02:31:45 2017
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Sat, 04 Nov 2017 01:31:45 +0000
Subject: [Koha-bugs] [Bug 19580] Elasticsearch: QueryAutoTruncate exclude
 period as splitting character in autotruncation
In-Reply-To: <bug-19580-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-19580-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-19580-70-Ux6klMHpr9@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19580

--- Comment #1 from Nick Clemens <nick at bywatersolutions.com> ---
Created attachment 68942
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=68942&action=edit
Bug 19580: Unit tests

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.

From bugzilla-daemon at bugs.koha-community.org  Sat Nov  4 02:31:47 2017
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Sat, 04 Nov 2017 01:31:47 +0000
Subject: [Koha-bugs] [Bug 19580] Elasticsearch: QueryAutoTruncate exclude
 period as splitting character in autotruncation
In-Reply-To: <bug-19580-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-19580-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-19580-70-PPWLAa6Q2Z@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19580

--- Comment #2 from Nick Clemens <nick at bywatersolutions.com> ---
Created attachment 68943
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=68943&action=edit
Bug 19580: Exclude period as splitting character for autotrunction

To test:
0 - Apply Unit test patch only
1 - prove t/db_dependent/Koha_SearchEngine_Elasticsearch_Search.t
2 - Should fail
3 - Apply this patch
4 - prove t/db_dependent/Koha_SearchEngine_Elasticsearch_Search.t
5 - should pass
6 - search for 'Local-number.raw:"4"' (or a vlid biblionumber)
7 - should get expected result

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Sat Nov  4 02:31:43 2017
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Sat, 04 Nov 2017 01:31:43 +0000
Subject: [Koha-bugs] [Bug 19580] Elasticsearch: QueryAutoTruncate exclude
 period as splitting character in autotruncation
In-Reply-To: <bug-19580-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-19580-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-19580-70-LM4klow36h@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19580

Nick Clemens <nick at bywatersolutions.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
   Patch complexity|---                         |Trivial patch
             Status|NEW                         |Needs Signoff

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.

From bugzilla-daemon at bugs.koha-community.org  Sat Nov  4 02:32:36 2017
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Sat, 04 Nov 2017 01:32:36 +0000
Subject: [Koha-bugs] [Bug 19580] Elasticsearch: QueryAutoTruncate exclude
 period as splitting character in autotruncation
In-Reply-To: <bug-19580-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-19580-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-19580-70-LbF0S1FEHq@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19580

Nick Clemens <nick at bywatersolutions.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
           Assignee|koha-bugs at lists.koha-commun |nick at bywatersolutions.com
                   |ity.org                     |
         Depends on|                            |19559


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19559
[Bug 19559] Elasticsearch QueryAutoTruncate truncate field names with hyphens
if data is quoted
-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.

From bugzilla-daemon at bugs.koha-community.org  Sat Nov  4 02:32:36 2017
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Sat, 04 Nov 2017 01:32:36 +0000
Subject: [Koha-bugs] [Bug 19559] Elasticsearch QueryAutoTruncate truncate
 field names with hyphens if data is quoted
In-Reply-To: <bug-19559-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-19559-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-19559-70-UnIVJFbIKh@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19559

Nick Clemens <nick at bywatersolutions.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Blocks|                            |19580


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19580
[Bug 19580] Elasticsearch: QueryAutoTruncate exclude period as splitting
character in autotruncation
-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Sat Nov  4 02:33:35 2017
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Sat, 04 Nov 2017 01:33:35 +0000
Subject: [Koha-bugs] [Bug 19559] Elasticsearch QueryAutoTruncate truncate
 field names with hyphens if data is quoted
In-Reply-To: <bug-19559-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-19559-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-19559-70-HXWBlDY2eA@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19559

--- Comment #8 from Nick Clemens <nick at bywatersolutions.com> ---
(In reply to David Gustafsson from comment #4)
> Would be nice if "." could as be included as a valid field characters, since
> it is used for subfields in Elasticsearch. ("Control-number.raw" for
> example).

This could be done, opening a new bug 19580

We may need more adjustments to when we do and do not truncate/split

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Sat Nov  4 02:42:40 2017
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Sat, 04 Nov 2017 01:42:40 +0000
Subject: [Koha-bugs] [Bug 16787] 'Too many holds' message appears
 inappropriately and is missing data
In-Reply-To: <bug-16787-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-16787-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-16787-70-23auaHgG6O@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16787

--- Comment #8 from Nick Clemens <nick at bywatersolutions.com> ---
(In reply to David Bourgault from comment #7)
> Is there a step missing form the test plan? I applied the patch, change my
> Circulation rules to set no holds for All/All (I have no other rules for my
> test patron's category) and tried to place a hold but got the message "No
> available items.", but I can see it as available on the OPAC detail page.

Sorry, I did miss a detail, this patch only affects the staff side, not the
OPAC

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Sat Nov  4 02:42:50 2017
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Sat, 04 Nov 2017 01:42:50 +0000
Subject: [Koha-bugs] [Bug 16787] 'Too many holds' message appears
 inappropriately and is missing data
In-Reply-To: <bug-16787-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-16787-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-16787-70-c69MB1SS8P@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16787

Nick Clemens <nick at bywatersolutions.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Failed QA                   |Needs Signoff

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.

From bugzilla-daemon at bugs.koha-community.org  Sat Nov  4 03:01:03 2017
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Sat, 04 Nov 2017 02:01:03 +0000
Subject: [Koha-bugs] [Bug 19166] Add the ability to add adjustments to an
	invoice
In-Reply-To: <bug-19166-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-19166-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-19166-70-OsUKabvWgD@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19166

Nick Clemens <nick at bywatersolutions.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Failed QA                   |Needs Signoff

--- Comment #17 from Nick Clemens <nick at bywatersolutions.com> ---
(In reply to Caroline Cyr La Rose from comment #16)
> I want this so much to work! I've been asked for this many many times!
> 
> But I got a software error.
> 
> BIx::Class::Storage::DBI::_dbh_execute(): Table
> 'koha_master_dev_inlibro.invoice_adjustments' doesn't exist at
> /inlibro/git/koha-master-dev-inlibro/Koha/Object.pm line 121
> 
> Plus the prove -v ... returned red.

HI Caroline, Did you run the database updates? It looks like the tables
introduced in this patchset have not been created.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Sat Nov  4 03:10:42 2017
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Sat, 04 Nov 2017 02:10:42 +0000
Subject: [Koha-bugs] [Bug 18213] Add language facets to Elasticsearch
In-Reply-To: <bug-18213-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-18213-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-18213-70-AVJ4AYFW35@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18213

Nick Clemens <nick at bywatersolutions.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #64798|0                           |1
        is obsolete|                            |
  Attachment #64841|0                           |1
        is obsolete|                            |
  Attachment #64905|0                           |1
        is obsolete|                            |

--- Comment #6 from Nick Clemens <nick at bywatersolutions.com> ---
Created attachment 68944
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=68944&action=edit
Bug 18213 - Add language facets to Elasticsearch

This patch add language as a facet to ES results - it adds
a new template plugin for languages to get the appropriate
description given an iso 639-2 code

To test:
1 - Make sure you have records with differing languages (in the MARC21 008
        field characters 35-37 or UNIMARC 101a)
2 - Apply patch
3 - Reload Elasticsearch settings:
http://localhost:8081/cgi-bin/koha/admin/searchengine/elasticsearch/mappings.pl?op=reset&i_know_what_i_am_doing=1
4 - Reindex your records
5 - Search for a phrase that will return results in several languages
6 - Verify you see factes correctly labelled for 'Language'
7 - Verify the facets work
8 - Verify both opac and staff results
9 - prove t/db_dependent/Languages.t

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Sat Nov  4 03:10:45 2017
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Sat, 04 Nov 2017 02:10:45 +0000
Subject: [Koha-bugs] [Bug 18213] Add language facets to Elasticsearch
In-Reply-To: <bug-18213-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-18213-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-18213-70-eau72QXH0f@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18213

--- Comment #7 from Nick Clemens <nick at bywatersolutions.com> ---
Created attachment 68945
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=68945&action=edit
Bug 18213 - DB Update (facet order)

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Sat Nov  4 03:10:48 2017
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Sat, 04 Nov 2017 02:10:48 +0000
Subject: [Koha-bugs] [Bug 18213] Add language facets to Elasticsearch
In-Reply-To: <bug-18213-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-18213-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-18213-70-bUF1JWMO2c@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18213

--- Comment #8 from Nick Clemens <nick at bywatersolutions.com> ---
Created attachment 68946
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=68946&action=edit
Bug 18213 - Add Template plugin and fix for C4/Languages

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Sat Nov  4 03:10:40 2017
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Sat, 04 Nov 2017 02:10:40 +0000
Subject: [Koha-bugs] [Bug 18213] Add language facets to Elasticsearch
In-Reply-To: <bug-18213-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-18213-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-18213-70-Zst85y0c15@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18213

Nick Clemens <nick at bywatersolutions.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Patch doesn't apply         |Needs Signoff

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Sat Nov  4 10:27:58 2017
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Sat, 04 Nov 2017 09:27:58 +0000
Subject: [Koha-bugs] [Bug 10708] make fine receipt customizable
In-Reply-To: <bug-10708-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-10708-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-10708-70-cVDVMcuPoz@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10708

Jamsheer N P <jamsheer.np at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |jamsheer.np at gmail.com

--- Comment #7 from Jamsheer N P <jamsheer.np at gmail.com> ---
There shall be an option for receipt number in the payment slip which can be
reset at beginning of the financial year. So that one need not have to depend
on a manual receipt writing/printing. With the help of a unique receipt number,
payment can be verified later (especially where financial auditing in library
is mandatory).

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Sat Nov  4 21:27:34 2017
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Sat, 04 Nov 2017 20:27:34 +0000
Subject: [Koha-bugs] [Bug 17314] REST API: Add API route to create,
 list and delete a purchase suggestion
In-Reply-To: <bug-17314-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-17314-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-17314-70-ihMSh2vtjz@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17314

--- Comment #21 from Jiri Kozlovsky <mail at jkozlovsky.cz> ---
(In reply to Jon Knight from comment #20)
> I noticed that this doesn't apply cleanly to the latest master HEAD on my
> kohadevbox.  I could help rebase if that would be useful to nudge this bug
> along?  Unless of course Jiri is working on an updated version?

Well, I've been working on rebasing on top of master HEAD for a little time
already and I'm near completion. 

Right now I'm actually solving a really strange bug when GET on an item
(/suggestions/{id}) works perfectly fine, but GET on a list of items
(/suggestions) fails on "Method not implemented" although I've basically copy &
pasted the /patrons implementation.

As soon as I'll solve this strange behaviour, I'll post my work here ;) But
thank you for your effort.(In reply to Jon Knight from comment #19)

> Is development of this patch still ongoing?  Also PUT appears to actually be
> a PATCH operation as it doesn't require the whole object data to be
> specified - should the HTTP method be changed to reflect that?

I'm going to fix this too in my next patch.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Sat Nov  4 21:37:00 2017
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Sat, 04 Nov 2017 20:37:00 +0000
Subject: [Koha-bugs] [Bug 19538] Advanced editor - Rancor - Move syspref
 from labs to cataloging and remove experimental note
In-Reply-To: <bug-19538-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-19538-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-19538-70-gvroAulHGn@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19538

Katrin Fischer <katrin.fischer at bsz-bw.de> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |katrin.fischer at bsz-bw.de
             Status|In Discussion               |Signed Off

--- Comment #4 from Katrin Fischer <katrin.fischer at bsz-bw.de> ---
We discussed this at the last meeting and agreed to move it out of labs. There
are no open bug reports, just ongoing enhancements. I think it's ripe to leave
the labs.

https://wiki.koha-community.org/wiki/Development_IRC_meeting_11_October_2017

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Sat Nov  4 21:41:40 2017
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Sat, 04 Nov 2017 20:41:40 +0000
Subject: [Koha-bugs] [Bug 19538] Advanced editor - Rancor - Move syspref
 from labs to cataloging and remove experimental note
In-Reply-To: <bug-19538-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-19538-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-19538-70-2xoyFeOt7h@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19538

Katrin Fischer <katrin.fischer at bsz-bw.de> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Signed Off                  |In Discussion

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Sat Nov  4 22:51:23 2017
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Sat, 04 Nov 2017 21:51:23 +0000
Subject: [Koha-bugs] [Bug 19580] Elasticsearch: QueryAutoTruncate exclude
 period as splitting character in autotruncation
In-Reply-To: <bug-19580-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-19580-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-19580-70-D2fBA9guuK@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19580

David Gustafsson <glasklas at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |glasklas at gmail.com

--- Comment #3 from David Gustafsson <glasklas at gmail.com> ---
I think you need to escape that hyphen unless its the last character within the
character class brackets (like this: my @tokens = split
/((?:[\w\-.]+:)?"[^"]+"|\s+)/, $query;)

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Sun Nov  5 01:29:43 2017
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Sun, 05 Nov 2017 00:29:43 +0000
Subject: [Koha-bugs] [Bug 19481] Elasticsearch - Set default fields for
 sorting in mappings.yaml
In-Reply-To: <bug-19481-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-19481-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-19481-70-uHxyy8joJt@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19481

Nick Clemens <nick at bywatersolutions.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Blocks|                            |19482


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19482
[Bug 19482] Elasticsearch - prevent removal / editing of required indexes
-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Sun Nov  5 01:29:43 2017
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Sun, 05 Nov 2017 00:29:43 +0000
Subject: [Koha-bugs] [Bug 19482] Elasticsearch - prevent removal / editing
 of required indexes
In-Reply-To: <bug-19482-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-19482-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-19482-70-QkGPPmBiYq@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19482

Nick Clemens <nick at bywatersolutions.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
         Depends on|                            |19481
             Status|Patch doesn't apply         |Needs Signoff


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19481
[Bug 19481] Elasticsearch - Set default fields for sorting in mappings.yaml
-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Sun Nov  5 02:50:03 2017
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Sun, 05 Nov 2017 01:50:03 +0000
Subject: [Koha-bugs] [Bug 19581] New: Elasticsearch - Catmandu split option
 adds extra null fields to indexes
Message-ID: <bug-19581-70@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19581

            Bug ID: 19581
           Summary: Elasticsearch - Catmandu split option adds extra null
                    fields to indexes
 Change sponsored?: ---
           Product: Koha
           Version: master
          Hardware: All
                OS: All
            Status: NEW
          Severity: normal
          Priority: P5 - low
         Component: Searching - Elasticsearch
          Assignee: nick at bywatersolutions.com
          Reporter: nick at bywatersolutions.com

This affects sorting, when encountering a null field the title in question will
sort out of place.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Sun Nov  5 03:03:15 2017
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Sun, 05 Nov 2017 02:03:15 +0000
Subject: [Koha-bugs] [Bug 19581] Elasticsearch - Catmandu split option adds
 extra null fields to indexes
In-Reply-To: <bug-19581-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-19581-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-19581-70-ffhvotBjbL@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19581

Nick Clemens <nick at bywatersolutions.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|NEW                         |Needs Signoff
   Patch complexity|---                         |Small patch

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Sun Nov  5 03:03:16 2017
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Sun, 05 Nov 2017 02:03:16 +0000
Subject: [Koha-bugs] [Bug 19581] Elasticsearch - Catmandu split option adds
 extra null fields to indexes
In-Reply-To: <bug-19581-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-19581-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-19581-70-lkixvYq854@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19581

--- Comment #1 from Nick Clemens <nick at bywatersolutions.com> ---
Created attachment 68947
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=68947&action=edit
Bug 19581: Unit tests

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Sun Nov  5 03:03:19 2017
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Sun, 05 Nov 2017 02:03:19 +0000
Subject: [Koha-bugs] [Bug 19581] Elasticsearch - Catmandu split option adds
 extra null fields to indexes
In-Reply-To: <bug-19581-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-19581-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-19581-70-oeDxRRBEcI@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19581

--- Comment #2 from Nick Clemens <nick at bywatersolutions.com> ---
Created attachment 68948
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=68948&action=edit
Bug 19581: Remove 'split' option from Catmandu fixes for marc

This option in combination with append seems to add null entries in the indexes
for fields that don't exist. These fields then affect sorting. Removing it
solves
the issue

To test:
1 - Have an ES setup
2 - Catalog and index some records
3 - View a record in ES:
    curl 'localhost:9200/koha_kohadev_biblios/data/4?pretty=yes'
4 - Note there are 'null' entries in the indexes, save this result for
comparison
5 - Apply patch
6 - Reindex, amking sure to delete existing indexes
    perl misc/search_tools/rebuild_elastic_search.pl -d
7 - View the record again
8 - Note the null entries are removed
9 - Note indices are otherwise intact

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Sun Nov  5 03:04:36 2017
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Sun, 05 Nov 2017 02:04:36 +0000
Subject: [Koha-bugs] [Bug 19481] Elasticsearch - Set default fields for
 sorting in mappings.yaml
In-Reply-To: <bug-19481-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-19481-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-19481-70-ZsUkfsi1by@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19481

--- Comment #5 from Nick Clemens <nick at bywatersolutions.com> ---
(In reply to David Bourgault from comment #4)
> Test worked as planned, however sorting by title and author seemed strange.
> I assume the issue wasn't introduced by this bug, but looking at the results
> list, it did not seem alphabetical to me.

See bug 19581 and bug 18827 for ordering issues

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Sun Nov  5 03:14:02 2017
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Sun, 05 Nov 2017 02:14:02 +0000
Subject: [Koha-bugs] [Bug 19581] Elasticsearch - Catmandu split option adds
 extra null fields to indexes
In-Reply-To: <bug-19581-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-19581-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-19581-70-v4Ykse9qsU@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19581

Nick Clemens <nick at bywatersolutions.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #68947|0                           |1
        is obsolete|                            |

--- Comment #3 from Nick Clemens <nick at bywatersolutions.com> ---
Created attachment 68949
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=68949&action=edit
Bug 19581: Unit tests

This patch makes a few changes to the tests to take into account the
change to indexing.

To test:
prove t/db_dependent/Koha_Elasticsearch_Indexer.t
Should return green

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Sun Nov  5 06:31:20 2017
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Sun, 05 Nov 2017 05:31:20 +0000
Subject: [Koha-bugs] [Bug 19514] No Password restrictions in onboarding tool
 patron creation
In-Reply-To: <bug-19514-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-19514-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-19514-70-ggHwo5mruV@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19514

Alex Buckley <alexbuckley at catalyst.net.nz> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Failed QA                   |In Discussion

--- Comment #6 from Alex Buckley <alexbuckley at catalyst.net.nz> ---
Hi Jonathan

I have tried implemented the client side validation by doing the following:

1. Adding the following pragma at the start of onboardingstep3.tt:
[% USE Koha %]  

2. Adding the following to the bottom of the same file:
[% PROCESS 'password_check.inc' %] 
[% PROCESS 'add_password_check' new_password => 'newpassword' %]


3. Added the following to the validation in the ../../../js/onboarding.js
            password: 
                required: true,
                password_strong: true
                password_no_spaces: true
            },?
            password2: {
                required: true,
                password_match: true
            }
. 
I notice that I get the JS error 'TypeError: _(...).format is not a function.
This error is not thrown by the memberentrygen.tt file which uses the same
client side validation.

Can you give me any suggestions as to how to fix this issue

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Sun Nov  5 08:03:59 2017
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Sun, 05 Nov 2017 07:03:59 +0000
Subject: [Koha-bugs] [Bug 6918] can't place holds on 'on order' items with
 AllowOnShelfHolds off
In-Reply-To: <bug-6918-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-6918-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-6918-70-WbDRX5UbCm@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6918

Alex Buckley <alexbuckley at catalyst.net.nz> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |alexbuckley at catalyst.net.nz
             Status|Needs Signoff               |Failed QA

--- Comment #32 from Alex Buckley <alexbuckley at catalyst.net.nz> ---
There's a unnecessary bracket in line 677 of opac-search.pl:

syntax error at /home/vagrant/kohaclone/opac/opac-search.pl line 677, near ")
)"

-- 
You are receiving this mail because:
You are the QA Contact for the bug.
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Sun Nov  5 16:41:38 2017
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Sun, 05 Nov 2017 15:41:38 +0000
Subject: [Koha-bugs] [Bug 18947] Unexpected Active Directory LDAP
 authentication failure mode
In-Reply-To: <bug-18947-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-18947-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-18947-70-V0Ulqgkcli@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18947

Nick Clemens <nick at bywatersolutions.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |nick at bywatersolutions.com
           Severity|normal                      |major

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.

From bugzilla-daemon at bugs.koha-community.org  Sun Nov  5 16:43:00 2017
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Sun, 05 Nov 2017 15:43:00 +0000
Subject: [Koha-bugs] [Bug 18992] LDAP fallback behaviour not consistent
In-Reply-To: <bug-18992-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-18992-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-18992-70-xhd58touLS@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18992

Nick Clemens <nick at bywatersolutions.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
           Assignee|koha-bugs at lists.koha-commun |nick at bywatersolutions.com
                   |ity.org                     |
                 CC|                            |nick at bywatersolutions.com

--- Comment #1 from Nick Clemens <nick at bywatersolutions.com> ---
Bumping severity here, this broke our ldap config after upgrade to 17.05, will
try to provide patch next week

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Sun Nov  5 22:56:54 2017
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Sun, 05 Nov 2017 21:56:54 +0000
Subject: [Koha-bugs] [Bug 15265] Instagram and pintrest
In-Reply-To: <bug-15265-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-15265-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-15265-70-EsV62tjbzm@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15265

--- Comment #3 from Ed Veal <eveal at mckinneytexas.org> ---
I agree with Owen, this should be a setting of some kind.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Sun Nov  5 23:10:22 2017
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Sun, 05 Nov 2017 22:10:22 +0000
Subject: [Koha-bugs] [Bug 18975] Wrong CSRF token when emailing cart contents
In-Reply-To: <bug-18975-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-18975-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-18975-70-Rc7yUtZDDn@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18975

Liz Rea <liz at catalyst.net.nz> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |liz at catalyst.net.nz

--- Comment #1 from Liz Rea <liz at catalyst.net.nz> ---
I confirm this bug in 16.11.05.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Nov  6 08:34:26 2017
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 06 Nov 2017 07:34:26 +0000
Subject: [Koha-bugs] [Bug 19578] TT syntax for notices - There is no way to
 pre-process DB fields
In-Reply-To: <bug-19578-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-19578-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-19578-70-2W0hwgrVkv@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19578

--- Comment #1 from Marcel de Rooy <m.de.rooy at rijksmuseum.nl> ---
Should we identify the few fields this really is about? Like at least
biblio.title. And then run the same substitutions in parseletter and the
template?

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Nov  6 08:36:58 2017
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 06 Nov 2017 07:36:58 +0000
Subject: [Koha-bugs] [Bug 19494] Add reservedate to Holds awaiting pickup
In-Reply-To: <bug-19494-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-19494-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-19494-70-l7HmeEOtat@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19494

--- Comment #3 from Marcel de Rooy <m.de.rooy at rijksmuseum.nl> ---
(In reply to Simon Pouchol from comment #2)
> Signed-off-by: Simon Pouchol <simon.pouchol at biblibre.com>

Merci beaucoup, Simon.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Nov  6 08:45:37 2017
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 06 Nov 2017 07:45:37 +0000
Subject: [Koha-bugs] [Bug 19452] The -truncate option in
 borrowers-force-messaging-defaults.pl should not remove category
 preferences
In-Reply-To: <bug-19452-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-19452-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-19452-70-GVNzK3TYzB@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19452

--- Comment #7 from Marcel de Rooy <m.de.rooy at rijksmuseum.nl> ---
(In reply to Charles Farmer from comment #6)
> Can't really say where the problem lies, but I couldn't apply your patches:
> > fatal: sha1 information is lacking or useless (misc/maintenance/borrowers-force-messaging-defaults.pl).

Thx for trying.
You need the dependency. First git apply 19451.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Nov  6 08:46:18 2017
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 06 Nov 2017 07:46:18 +0000
Subject: [Koha-bugs] [Bug 19454] Script
 borrowers-force-messaging-defaults.pl should be able to filter on patron
 category
In-Reply-To: <bug-19454-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-19454-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-19454-70-SxcaRQauwl@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19454

--- Comment #7 from Marcel de Rooy <m.de.rooy at rijksmuseum.nl> ---
(In reply to Charles Farmer from comment #6)
> Can't really say if the problem is on my end or not, but I couldn't apply
> your patches:
> > fatal: sha1 information is lacking or useless (misc/maintenance/borrowers-force-messaging-defaults.pl)

You need two dependencies. 19451 and 19452

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Nov  6 09:48:42 2017
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 06 Nov 2017 08:48:42 +0000
Subject: [Koha-bugs] [Bug 10748] Add option to block return of lost items
In-Reply-To: <bug-10748-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-10748-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-10748-70-E4bfzPIgjL@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10748

--- Comment #9 from Marcel de Rooy <m.de.rooy at rijksmuseum.nl> ---
There is a difference with the Withdrawn case.
If the item is Lost, checking it in will remove the lost status. So the second
checkin will not be blocked anymore although you set the pref.
If the item is withdrawn, the status remains the same. So a second try will be
blocked again.
No 'blocker' for me.

Tested it with SIP too.
Got a failed checkin. So that is OK.
The message "Checkin failed" is not very informative though.
You need to inspect syslog (staff member ;) to see this warning:
Checkin failed: probably for Wrongbranch or withdrawn
This warn comes from SIP/ILS.pm line 237.
It could be 'enriched' with the blocked lost-case, but it is more a comment for
developers than something useful. Adding a comment in a follow-up.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Nov  6 09:49:08 2017
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 06 Nov 2017 08:49:08 +0000
Subject: [Koha-bugs] [Bug 10748] Add option to block return of lost items
In-Reply-To: <bug-10748-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-10748-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-10748-70-AKDSTpTdN8@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10748

Marcel de Rooy <m.de.rooy at rijksmuseum.nl> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #68112|0                           |1
        is obsolete|                            |

--- Comment #10 from Marcel de Rooy <m.de.rooy at rijksmuseum.nl> ---
Created attachment 68950
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=68950&action=edit
Bug 10748: Add the ability to block return of lost items

Mimicking what does BlockReturnOfWithdrawnItems we can easily add a new
syspref to block return of lost items.
This patch adds BlockReturnOfLostItems, if set to 'Block' a item marked
as lost cannot be checked in.

Test plan:
1/ Set BlockReturnOfLostItems to 'Do not block'
2/ Check an item out to a patron
3/ Edit the item and mark it as lost (*)
4/ Check the item in
=> The item is checked in
5/ Edit the item and remove the lost status
6/ Check the item out again
7/ Edit the item and mark it as lost (*)
8/ Check the item in
=> The item is not checked in

(*) There are 2 ways to mark an item lost:
- From the item list view (/catalogue/moredetail.pl?biblionumber=42)
If you set the lost status from this form, the issue will be returned
Maybe this should be optional (?)

- From the edit items form (/cataloguing/additem.pl?biblionumber=42)
It is the form you must use to not mark the issue returned.

Signed-off-by: Dominic Pichette <dominic at inlibro.com>

Signed-off-by: Marcel de Rooy <m.de.rooy at rijksmuseum.nl>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Nov  6 09:49:12 2017
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 06 Nov 2017 08:49:12 +0000
Subject: [Koha-bugs] [Bug 10748] Add option to block return of lost items
In-Reply-To: <bug-10748-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-10748-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-10748-70-TptL2vdp2q@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10748

Marcel de Rooy <m.de.rooy at rijksmuseum.nl> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #68919|0                           |1
        is obsolete|                            |

--- Comment #11 from Marcel de Rooy <m.de.rooy at rijksmuseum.nl> ---
Created attachment 68951
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=68951&action=edit
Bug 10748: Add tests

Signed-off-by: Marcel de Rooy <m.de.rooy at rijksmuseum.nl>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Nov  6 09:49:16 2017
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 06 Nov 2017 08:49:16 +0000
Subject: [Koha-bugs] [Bug 10748] Add option to block return of lost items
In-Reply-To: <bug-10748-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-10748-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-10748-70-7s6V5a0AeN@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10748

--- Comment #12 from Marcel de Rooy <m.de.rooy at rijksmuseum.nl> ---
Created attachment 68952
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=68952&action=edit
Bug 10748: (QA follow-up) Add comment in SIP's do_checkin

Signed-off-by: Marcel de Rooy <m.de.rooy at rijksmuseum.nl>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Nov  6 09:50:16 2017
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 06 Nov 2017 08:50:16 +0000
Subject: [Koha-bugs] [Bug 10748] Add option to block return of lost items
In-Reply-To: <bug-10748-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-10748-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-10748-70-FxWJU8ZW1B@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10748

Marcel de Rooy <m.de.rooy at rijksmuseum.nl> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Signed Off                  |Passed QA
   Patch complexity|---                         |Small patch
         QA Contact|testopia at bugs.koha-communit |m.de.rooy at rijksmuseum.nl
                   |y.org                       |

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Nov  6 09:54:14 2017
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 06 Nov 2017 08:54:14 +0000
Subject: [Koha-bugs] [Bug 10021] Remove dead code related to notifys
In-Reply-To: <bug-10021-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-10021-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-10021-70-PK2BYY8pnv@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10021

--- Comment #35 from Marcel de Rooy <m.de.rooy at rijksmuseum.nl> ---
(In reply to Jonathan Druart from comment #33)
> (In reply to Marcel de Rooy from comment #32)
> > QA Comment:
> > 
> > GetOverduesForBranch
> > Please add a test. You make some fundamental changes here.
> 
> Fundamental? I do not understand what you want me to test.

Maybe non-trivial would have been a better word ?

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Nov  6 10:14:23 2017
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 06 Nov 2017 09:14:23 +0000
Subject: [Koha-bugs] [Bug 18821] TrackLastPatronActivity is a performance
	killer
In-Reply-To: <bug-18821-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-18821-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-18821-70-SmV28s8RJ9@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18821

Nicolas Legrand <nicolas.legrand at bulac.fr> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |nicolas.legrand at bulac.fr

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Nov  6 10:16:09 2017
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 06 Nov 2017 09:16:09 +0000
Subject: [Koha-bugs] [Bug 10021] Remove dead code related to notifys
In-Reply-To: <bug-10021-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-10021-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-10021-70-6cmEQs6lNC@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10021

Marcel de Rooy <m.de.rooy at rijksmuseum.nl> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Failed QA                   |Signed Off

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Nov  6 10:16:12 2017
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 06 Nov 2017 09:16:12 +0000
Subject: [Koha-bugs] [Bug 10021] Remove dead code related to notifys
In-Reply-To: <bug-10021-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-10021-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-10021-70-BU7LkbejVE@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10021

Marcel de Rooy <m.de.rooy at rijksmuseum.nl> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #68793|0                           |1
        is obsolete|                            |

--- Comment #36 from Marcel de Rooy <m.de.rooy at rijksmuseum.nl> ---
Created attachment 68953
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=68953&action=edit
Bug 10021: Drop table notifys and related code

This patch drops the notifys table and its related code in C4::Overdues.
A second patch should remove the 2 columns notify_id and notify_level
from the accountlines table.

Signed-off-by: Josef Moravec <josef.moravec at gmail.com>

Signed-off-by: Marcel de Rooy <m.de.rooy at rijksmuseum.nl>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Nov  6 10:16:16 2017
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 06 Nov 2017 09:16:16 +0000
Subject: [Koha-bugs] [Bug 10021] Remove dead code related to notifys
In-Reply-To: <bug-10021-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-10021-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-10021-70-94JqKhL6vv@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10021

Marcel de Rooy <m.de.rooy at rijksmuseum.nl> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #68794|0                           |1
        is obsolete|                            |

--- Comment #37 from Marcel de Rooy <m.de.rooy at rijksmuseum.nl> ---
Created attachment 68954
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=68954&action=edit
Bug 10021: Drop columns notify_id and notify_level from accountlines

It appears that has never worked.
Could someone confirm?

Signed-off-by: Josef Moravec <josef.moravec at gmail.com>

Signed-off-by: Marcel de Rooy <m.de.rooy at rijksmuseum.nl>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Nov  6 10:16:20 2017
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 06 Nov 2017 09:16:20 +0000
Subject: [Koha-bugs] [Bug 10021] Remove dead code related to notifys
In-Reply-To: <bug-10021-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-10021-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-10021-70-X8TVbnaM6S@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10021

Marcel de Rooy <m.de.rooy at rijksmuseum.nl> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #68795|0                           |1
        is obsolete|                            |

--- Comment #38 from Marcel de Rooy <m.de.rooy at rijksmuseum.nl> ---
Created attachment 68955
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=68955&action=edit
Bug 10021: Update DB changes

Signed-off-by: Josef Moravec <josef.moravec at gmail.com>

Signed-off-by: Marcel de Rooy <m.de.rooy at rijksmuseum.nl>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Nov  6 10:16:25 2017
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 06 Nov 2017 09:16:25 +0000
Subject: [Koha-bugs] [Bug 10021] Remove dead code related to notifys
In-Reply-To: <bug-10021-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-10021-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-10021-70-OBPV0WSH9Y@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10021

Marcel de Rooy <m.de.rooy at rijksmuseum.nl> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #68796|0                           |1
        is obsolete|                            |

--- Comment #39 from Marcel de Rooy <m.de.rooy at rijksmuseum.nl> ---
Created attachment 68956
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=68956&action=edit
Bug 10021: Remove accountlines columns - DBIC Schema changes

Signed-off-by: Josef Moravec <josef.moravec at gmail.com>

Signed-off-by: Marcel de Rooy <m.de.rooy at rijksmuseum.nl>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Nov  6 10:16:29 2017
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 06 Nov 2017 09:16:29 +0000
Subject: [Koha-bugs] [Bug 10021] Remove dead code related to notifys
In-Reply-To: <bug-10021-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-10021-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-10021-70-d2QaDN4iXn@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10021

Marcel de Rooy <m.de.rooy at rijksmuseum.nl> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #68797|0                           |1
        is obsolete|                            |

--- Comment #40 from Marcel de Rooy <m.de.rooy at rijksmuseum.nl> ---
Created attachment 68957
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=68957&action=edit
Bug 10021: Remove notify columns in circ/branchoverdues.tt

Signed-off-by: Josef Moravec <josef.moravec at gmail.com>

Signed-off-by: Marcel de Rooy <m.de.rooy at rijksmuseum.nl>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Nov  6 10:16:34 2017
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 06 Nov 2017 09:16:34 +0000
Subject: [Koha-bugs] [Bug 10021] Remove dead code related to notifys
In-Reply-To: <bug-10021-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-10021-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-10021-70-c2qSm0lGcg@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10021

Marcel de Rooy <m.de.rooy at rijksmuseum.nl> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #68798|0                           |1
        is obsolete|                            |

--- Comment #41 from Marcel de Rooy <m.de.rooy at rijksmuseum.nl> ---
Created attachment 68958
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=68958&action=edit
Bug 10021: Restore "Pay fines" list

Previous changes were wrong, the notify_id was always equal to 1 and
GetBorNotifyAcctRecord was used to retrieved the account lines to pay

Signed-off-by: Josef Moravec <josef.moravec at gmail.com>

Signed-off-by: Marcel de Rooy <m.de.rooy at rijksmuseum.nl>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Nov  6 10:16:38 2017
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 06 Nov 2017 09:16:38 +0000
Subject: [Koha-bugs] [Bug 10021] Remove dead code related to notifys
In-Reply-To: <bug-10021-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-10021-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-10021-70-5Kh9OcA2gp@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10021

Marcel de Rooy <m.de.rooy at rijksmuseum.nl> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #68920|0                           |1
        is obsolete|                            |

--- Comment #42 from Marcel de Rooy <m.de.rooy at rijksmuseum.nl> ---
Created attachment 68959
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=68959&action=edit
Bug 10021: (QA follow-up) Rename variables

To avoid $account, $accounts and @accounts variables in the same scope

Signed-off-by: Marcel de Rooy <m.de.rooy at rijksmuseum.nl>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Nov  6 10:17:18 2017
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 06 Nov 2017 09:17:18 +0000
Subject: [Koha-bugs] [Bug 10021] Remove dead code related to notifys
In-Reply-To: <bug-10021-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-10021-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-10021-70-G4M3sCtzL0@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10021

Marcel de Rooy <m.de.rooy at rijksmuseum.nl> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
   Patch complexity|---                         |Small patch
         QA Contact|                            |m.de.rooy at rijksmuseum.nl

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Nov  6 10:22:35 2017
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 06 Nov 2017 09:22:35 +0000
Subject: [Koha-bugs] [Bug 10021] Remove dead code related to notifys
In-Reply-To: <bug-10021-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-10021-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-10021-70-QawY8NJcll@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10021

Marcel de Rooy <m.de.rooy at rijksmuseum.nl> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Signed Off                  |Passed QA

--- Comment #43 from Marcel de Rooy <m.de.rooy at rijksmuseum.nl> ---
Would have preferred to see a test for GetOverduesForBranch, but it is not a
blocker for me.
A rename of this sub would be nice too (see FIXME). Something like
GetOverduesWithFines ?
Similarly, it is weird that the script branchoverdues.pl (whats in a name) does
not list Overdues with fines in the header but just Overdues.
Apart from these observations, it is wonderful to see dead code moving out !

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Nov  6 10:39:24 2017
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 06 Nov 2017 09:39:24 +0000
Subject: [Koha-bugs] [Bug 17656] Irregularities in serial prediction pattern
 are planned only for current subscription
In-Reply-To: <bug-17656-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-17656-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-17656-70-DyDGNEnbA0@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17656

--- Comment #21 from Alex Arnaud <alex.arnaud at biblibre.com> ---
(In reply to David Bourgault from comment #20)
> Test plan works as described, but QA tools warns of forbidden patterns.
> 
> koha-tmpl/intranet-tmpl/prog/en/includes/serials/subscription_daily_choice.
> inc
>    FAIL	  forbidden patterns
> 		forbidden pattern: Do not use line breaks inside template tags (bug 18675)
> (line 5)

Hello David,

I have no warning when launching the qa script (koha-qa.pl -v 3 -c 1)
For the file subscription_daily_choice file i got:

 OK    
koha-tmpl/intranet-tmpl/prog/en/includes/serials/subscription_daily_choice.inc
   OK     forbidden patterns
   OK     git manipulation
   OK     spelling
   OK     tt_valid
   OK     valid_template

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Nov  6 10:45:02 2017
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 06 Nov 2017 09:45:02 +0000
Subject: [Koha-bugs] [Bug 19287] Add ability to mark an item 'Lost' from
 'Holds awaiting pickup ' list
In-Reply-To: <bug-19287-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-19287-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-19287-70-MHknBvL2Qt@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19287

--- Comment #25 from Nicolas Legrand <nicolas.legrand at bulac.fr> ---
Hey Katrin,

we use on shelf holds to pick documents from our stacks. Sometimes, the
document which is in the catalogue is no more in stacks. When we cancel the
hold, it is cancelled silently. Our patrons don't understand why it disappeared
and may ask it again.

So, we want our patrons to be informed, and we want to mark the item as lost so
it cannot be asked again and again. Those who fetch the books are not always
those who edit the catalogue, we would like them to modify the item without
having to open the cataloguing module.

Is it more clear? Best regards,

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Nov  6 10:48:16 2017
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 06 Nov 2017 09:48:16 +0000
Subject: [Koha-bugs] [Bug 19420] Improve display of errors from failure of
 uploading file during stage import
In-Reply-To: <bug-19420-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-19420-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-19420-70-BjtK0Xf3uf@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19420

Marcel de Rooy <m.de.rooy at rijksmuseum.nl> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Signed Off                  |BLOCKED

--- Comment #14 from Marcel de Rooy <m.de.rooy at rijksmuseum.nl> ---
Looking here again. I still found an issue. Please wait..

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Nov  6 10:55:11 2017
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 06 Nov 2017 09:55:11 +0000
Subject: [Koha-bugs] [Bug 17656] Irregularities in serial prediction pattern
 are planned only for current subscription
In-Reply-To: <bug-17656-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-17656-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-17656-70-EAGcUOEBEK@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17656

--- Comment #22 from Alex Arnaud <alex.arnaud at biblibre.com> ---
(In reply to Alex Arnaud from comment #21)
> (In reply to David Bourgault from comment #20)
> > Test plan works as described, but QA tools warns of forbidden patterns.
> > 
> > koha-tmpl/intranet-tmpl/prog/en/includes/serials/subscription_daily_choice.
> > inc
> >    FAIL	  forbidden patterns
> > 		forbidden pattern: Do not use line breaks inside template tags (bug 18675)
> > (line 5)
> 
> Hello David,
> 
> I have no warning when launching the qa script (koha-qa.pl -v 3 -c 1)
> For the file subscription_daily_choice file i got:
> 
>  OK    
> koha-tmpl/intranet-tmpl/prog/en/includes/serials/subscription_daily_choice.
> inc
>    OK     forbidden patterns
>    OK     git manipulation
>    OK     spelling
>    OK     tt_valid
>    OK     valid_template

Sorry you are right. My QA tools was not up to date

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Nov  6 11:14:17 2017
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 06 Nov 2017 10:14:17 +0000
Subject: [Koha-bugs] [Bug 15814] Templates for MARC modification: Edit
 action does not work when Description contains '
In-Reply-To: <bug-15814-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-15814-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-15814-70-4XYnN1ZWlP@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15814

Victor Grousset/tuxayo <victor.grousset at biblibre.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |victor.grousset at biblibre.co
                   |                            |m

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Nov  6 11:22:33 2017
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 06 Nov 2017 10:22:33 +0000
Subject: [Koha-bugs] [Bug 19287] Add ability to mark an item 'Lost' from
 'Holds awaiting pickup ' list
In-Reply-To: <bug-19287-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-19287-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-19287-70-u984Zwl4nJ@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19287

--- Comment #26 from S?verine Queune <severine.queune at bulac.fr> ---
(In reply to Jonathan Druart from comment #23)
> Suggestion 1:
> Bug 11629 adds UpdateNotForLoanStatusOnCheckin and bug 14576 adds
> UpdateitemLocationOnCheckin.
> Both have the same behaviour: it will update the NotForLoan or Location
> value of the checked in item following the rules defined in the sysprefs.
> For instance: 
>    NEW: FIC
>    FIC: GEN
> will modified the value of location to FIC if was NEW, and to GEN if was FIC.
>
> I am not sure it makes sense for us here, but we could imagine a new pref
> UpdateItemWhenLost which could be filled with:
>   itemlost: 1
>   notforloan: 2
> which will work for any fields of the items table.
> 
> Suggestion 2:
> We already have a DefaultLongOverdueLostValue, would it make sense to use it
> here too?
> 
> Suggestion 3:
> We add 2 other sysprefs: UpdateNotForLoanStatusWhenLost and
> UpdateItemLostWhenLost (weird name)
> 
> Suggestion 4:
> We display the different LOST authorised values on the "Holds awaiting
> pickup" page, like it is on the "Items details" page for Lost, Damaged and
> Withdrawn.
> 
> Vote by text message, send 1, 2, 3 or 4 to 0424242


Sorry for the delay...
We vote suggestion 1.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Nov  6 11:31:42 2017
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 06 Nov 2017 10:31:42 +0000
Subject: [Koha-bugs] [Bug 19287] Add ability to mark an item 'Lost' from
 'Holds awaiting pickup ' list
In-Reply-To: <bug-19287-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-19287-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-19287-70-LKzJQfRro9@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19287

--- Comment #27 from S?verine Queune <severine.queune at bulac.fr> ---
(In reply to Katrin Fischer from comment #24)
> Hi all, trying to understand this bug a bit better. Could you explain the
> use case for your library a bit? What is the additional not-for-loan used
> for? Why is it needed in addition to the lost setting?

Hi Katrin,

Some libraries interested with this enhancement may prefer using 'notforloan'
instead of the 'itemlost' field (the one we'll use), so we asked for these 2
options to feet the different local usages.
We understand it adds a difficulty for this development.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Nov  6 11:32:40 2017
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 06 Nov 2017 10:32:40 +0000
Subject: [Koha-bugs] [Bug 15814] Templates for MARC modification: Edit
 action does not work when Description contains '
In-Reply-To: <bug-15814-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-15814-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-15814-70-iDjtloD1Xo@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15814

Victor Grousset/tuxayo <victor.grousset at biblibre.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
           Severity|normal                      |major

--- Comment #2 from Victor Grousset/tuxayo <victor.grousset at biblibre.com> ---
Still happens on master as of today.
Also, as a consequence, it's vulnerable to XSS. Putting
"<script>alert(123)</script>" in the description works.


Idea to fix: escape in the template with replace()

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Nov  6 11:39:27 2017
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 06 Nov 2017 10:39:27 +0000
Subject: [Koha-bugs] [Bug 19420] Improve display of errors from failure of
 uploading file during stage import
In-Reply-To: <bug-19420-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-19420-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-19420-70-xGKxVdDTS9@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19420

--- Comment #15 from Marcel de Rooy <m.de.rooy at rijksmuseum.nl> ---
(In reply to Nick Clemens from comment #13)
> Removed, I though we only passed 1-4 back in the pm file, my apologies

Ah. See the last follow-up. upload.pl passed these codes.
As you already said, this still needs some improvement. I crossed a TODO also.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Nov  6 11:40:39 2017
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 06 Nov 2017 10:40:39 +0000
Subject: [Koha-bugs] [Bug 19420] Improve display of errors from failure of
 uploading file during stage import
In-Reply-To: <bug-19420-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-19420-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-19420-70-h8ANwba4TW@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19420

Marcel de Rooy <m.de.rooy at rijksmuseum.nl> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|BLOCKED                     |Signed Off

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Nov  6 11:40:41 2017
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 06 Nov 2017 10:40:41 +0000
Subject: [Koha-bugs] [Bug 19420] Improve display of errors from failure of
 uploading file during stage import
In-Reply-To: <bug-19420-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-19420-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-19420-70-YfmxaRH7Et@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19420

--- Comment #16 from Marcel de Rooy <m.de.rooy at rijksmuseum.nl> ---
Created attachment 68960
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=68960&action=edit
Bug 19420: Improve display of errors from failure of uploading file during
stage import

To test:
1 - sudo chown www-data:www-data /tmp/koha_kohadev_upload/ (or your
                relevant dir and user)
2 - Attempt to stage a file
3 - Error message is: Upload status: Failed
4 - Apply patch
5 - Repeat upload
6 - Error is now: Failed - Directory is not writeable:
/tmp/koha_kohadev_upload
7 - Trigger the other errors if you can and note better responses

Signed-off-by: Katrin Fischer <katrin.fischer.83 at web.de>

Signed-off-by: Marcel de Rooy <m.de.rooy at rijksmuseum.nl>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Nov  6 11:40:46 2017
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 06 Nov 2017 10:40:46 +0000
Subject: [Koha-bugs] [Bug 19420] Improve display of errors from failure of
 uploading file during stage import
In-Reply-To: <bug-19420-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-19420-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-19420-70-Jdkv6kMNVj@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19420

Marcel de Rooy <m.de.rooy at rijksmuseum.nl> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #68909|0                           |1
        is obsolete|                            |

--- Comment #17 from Marcel de Rooy <m.de.rooy at rijksmuseum.nl> ---
Created attachment 68961
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=68961&action=edit
Bug 19420: (QA Follow-up) Fix test, correct POD

The test needs the code level in the error hash now.
And POD is adjusted accordingly.

Signed-off-by: Marcel de Rooy <m.de.rooy at rijksmuseum.nl>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Nov  6 11:40:49 2017
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 06 Nov 2017 10:40:49 +0000
Subject: [Koha-bugs] [Bug 19420] Improve display of errors from failure of
 uploading file during stage import
In-Reply-To: <bug-19420-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-19420-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-19420-70-DmhvgayDDK@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19420

--- Comment #18 from Marcel de Rooy <m.de.rooy at rijksmuseum.nl> ---
Created attachment 68962
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=68962&action=edit
Bug 19420: (Follow-up) Add errors on other pages

Fix error array (add '0' value)
Update errors on other places using upload.js

Eventually these should all be using the same code in a js file

upload.tt already dealt with these errors, but has diff code, made it
work with new error syntax

Signed-off-by: Marcel de Rooy <m.de.rooy at rijksmuseum.nl>
Amended: Removed the added js comment in upload.tt

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Nov  6 11:40:58 2017
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 06 Nov 2017 10:40:58 +0000
Subject: [Koha-bugs] [Bug 19420] Improve display of errors from failure of
 uploading file during stage import
In-Reply-To: <bug-19420-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-19420-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-19420-70-p0EkTRm9Q4@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19420

--- Comment #19 from Marcel de Rooy <m.de.rooy at rijksmuseum.nl> ---
Created attachment 68963
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=68963&action=edit
Bug 19420: (QA Follow-up) Change in error reporting affects upload.pl

The change from the first patch requires a similar change in upload.pl
when a few error codes are passed to the template.

Signed-off-by: Marcel de Rooy <m.de.rooy at rijksmuseum.nl>
Tested by deleting a temporary file manually and downloading or deleting
the file from the upload search results.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Nov  6 11:42:01 2017
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 06 Nov 2017 10:42:01 +0000
Subject: [Koha-bugs] [Bug 19420] Improve display of errors from failure of
 uploading file during stage import
In-Reply-To: <bug-19420-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-19420-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-19420-70-DDNPe6vzte@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19420

Marcel de Rooy <m.de.rooy at rijksmuseum.nl> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #68365|0                           |1
        is obsolete|                            |

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Nov  6 11:42:03 2017
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 06 Nov 2017 10:42:03 +0000
Subject: [Koha-bugs] [Bug 19420] Improve display of errors from failure of
 uploading file during stage import
In-Reply-To: <bug-19420-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-19420-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-19420-70-hrF5hAacW9@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19420

Marcel de Rooy <m.de.rooy at rijksmuseum.nl> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #68941|0                           |1
        is obsolete|                            |

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Nov  6 11:42:36 2017
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 06 Nov 2017 10:42:36 +0000
Subject: [Koha-bugs] [Bug 19420] Improve display of errors from failure of
 uploading file during stage import
In-Reply-To: <bug-19420-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-19420-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-19420-70-ZJOVav0TTZ@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19420

--- Comment #20 from Marcel de Rooy <m.de.rooy at rijksmuseum.nl> ---
(In reply to Nick Clemens from comment #13)
> (In reply to Marcel de Rooy from comment #11)
> > Upload local cover image
> > Upload status: Failed - (2) Root directory for uploads not defined
> > No, the directory was not writable.
> > This went wrong since the errcode is 2, but you forgot to add a zero entry
> > in you errMsgs array. So they are one position out of sync.
> > Please add a leading entry here (see also upload.tt)
> > var errMsgs = [ _("File already exists"), _("Directory is not writeable"),
> > _("Root directory for uploads not defined"), _("Temporary directory for
> > uploads not defined") ];
> > Adjust same thing in two other places ?
> Adjusted :-)

Works now. Thanks

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Nov  6 11:43:10 2017
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 06 Nov 2017 10:43:10 +0000
Subject: [Koha-bugs] [Bug 19420] Improve display of errors from failure of
 uploading file during stage import
In-Reply-To: <bug-19420-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-19420-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-19420-70-dPLeA19k5d@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19420

Marcel de Rooy <m.de.rooy at rijksmuseum.nl> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Signed Off                  |Passed QA

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Nov  6 12:11:07 2017
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 06 Nov 2017 11:11:07 +0000
Subject: [Koha-bugs] [Bug 17661] Differences in field ending (whitespace,
 punctuation)   cause duplicate facets
In-Reply-To: <bug-17661-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-17661-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-17661-70-tB0DVo6vWw@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17661

Nick Clemens <nick at bywatersolutions.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
            Summary|Differences in whitespace   |Differences in field ending
                   |cause duplicate facets      |(whitespace, punctuation)
                   |                            |cause duplicate facets

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Nov  6 12:18:19 2017
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 06 Nov 2017 11:18:19 +0000
Subject: [Koha-bugs] [Bug 19522] Label creator - some strings are not
	translatable
In-Reply-To: <bug-19522-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-19522-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-19522-70-nGRXeKhOX9@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19522

Simon Pouchol <simon.pouchol at biblibre.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #68740|0                           |1
        is obsolete|                            |

--- Comment #26 from Simon Pouchol <simon.pouchol at biblibre.com> ---
Created attachment 68964
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=68964&action=edit
Bug 19522: Label creator: edit batch: make "Export label" translatable

Test plan:
1. install the fr_FR locale
2. go to /cgi-bin/koha/labels/label-manage.pl?label_element=batch
3. create a batch if there is none
4. edit that batch
5. Switch the language to French if you haven't done it yet
6. click on "Exporter le lot entier"
7. then you should see "Export labels"
8. apply this patch
9. install the language
10. replay steps 2 to 6
11. then you should see "Exporter des ?tiquettes"

Signed-off-by: Simon Pouchol <simon.pouchol at biblibre.com>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Nov  6 12:18:35 2017
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 06 Nov 2017 11:18:35 +0000
Subject: [Koha-bugs] [Bug 19522] Label creator - some strings are not
	translatable
In-Reply-To: <bug-19522-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-19522-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-19522-70-qFvmcY12ty@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19522

Simon Pouchol <simon.pouchol at biblibre.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Needs Signoff               |Signed Off

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Nov  6 12:21:55 2017
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 06 Nov 2017 11:21:55 +0000
Subject: [Koha-bugs] [Bug 13560] need an add option in marc modification
	templates
In-Reply-To: <bug-13560-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-13560-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-13560-70-hJECGfuL9G@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13560

Victor Grousset/tuxayo <victor.grousset at biblibre.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Needs Signoff               |Patch doesn't apply
                 CC|                            |victor.grousset at biblibre.co
                   |                            |m

--- Comment #7 from Victor Grousset/tuxayo <victor.grousset at biblibre.com> ---
Conflict when applying the patch.
In t/db_dependent/MarcModificationTemplates.t

<<<<<<< ff82c9aadc441f9ca18dcad2e58783e733cdd839 (from November 3 on master)
use Test::More tests => 96;

||||||| merged common ancestors
use Test::More tests => 95;

=======
use Test::More tests => 114;
>>>>>>> Bug 13560 - need an add option in marc modification templates
 (this patch's version)

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Nov  6 12:31:49 2017
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 06 Nov 2017 11:31:49 +0000
Subject: [Koha-bugs] [Bug 19578] TT syntax for notices - There is no way to
 pre-process DB fields
In-Reply-To: <bug-19578-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-19578-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-19578-70-hhqcBJRLLY@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19578

--- Comment #2 from Kyle M Hall <kyle at bywatersolutions.com> ---
(In reply to Jonathan Druart from comment #0)
> Jenkins fails (run 287) on a test in
> t/db_dependent/Letters/TemplateToolkit.t:
> 
> With the historical syntax:
>         # Your request for an article from tQYRS (c3Av58O0P5xkkIGu) has been
> canceled for the following reason:
> 
> With the TT syntax:
>         # Your request for an article from tQYRS_ (c3Av58O0P5xkkIGu) has
> been canceled for the following reason:
> 
> The last character of the biblio's title has been removed because it's a
> punctuation character.
> It comes from: C4::Letters::_parseletter
>  893         $val =~ s/\p{P}$// if $val && $table=~/biblio/;
> 
> The same replacement is done for patron's attributes too.
> 
> With the TT syntax we retrieve the objects and send them to the template,
> without fetching the attributes.
> To restore this behaviour we could apply this regex on all the fields of the
> biblio objects, but it could be perf killer (we will process fields that we
> will certainly not used in the template).
> I thought about the TT filter we could apply on all the variables we
> display, but we will not know where come from the data, and we need to apply
> this change only for the biblio table.
> 
> Any other ideas?

I think there are two valid options:
1) Remove line 893 ( what is it's purpose? )
2) Add a TT filter like you suggest. I think if we just apply it to any TT
syntax that contains ".biblio" within TT tags ( something like
/^\[%.*biblio\..*%\]$/ ) it would be safe.

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Nov  6 12:37:10 2017
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 06 Nov 2017 11:37:10 +0000
Subject: [Koha-bugs] [Bug 19578] TT syntax for notices - There is no way to
 pre-process DB fields
In-Reply-To: <bug-19578-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-19578-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-19578-70-rEYXwYwC6K@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19578

--- Comment #3 from Marcel de Rooy <m.de.rooy at rijksmuseum.nl> ---
(In reply to Kyle M Hall from comment #2)
> 1) Remove line 893 ( what is it's purpose? )
Remove MARC punctuation that seems to end the sentence. too early :)

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Nov  6 13:25:02 2017
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 06 Nov 2017 12:25:02 +0000
Subject: [Koha-bugs] [Bug 13915] Inventory tool no longer hides items with
 date last seen greater than the inventory date
In-Reply-To: <bug-13915-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-13915-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-13915-70-R8iFvHdQBs@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13915

Marcel de Rooy <m.de.rooy at rijksmuseum.nl> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |m.de.rooy at rijksmuseum.nl
             Status|Failed QA                   |RESOLVED
         Resolution|---                         |FIXED

--- Comment #6 from Marcel de Rooy <m.de.rooy at rijksmuseum.nl> ---
Seems this could be closed in favor of bugs 12913/14399.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Nov  6 13:49:51 2017
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 06 Nov 2017 12:49:51 +0000
Subject: [Koha-bugs] [Bug 19522] Label creator - some strings are not
	translatable
In-Reply-To: <bug-19522-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-19522-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-19522-70-ImwpHy9KWI@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19522

Simon Pouchol <simon.pouchol at biblibre.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #68612|0                           |1
        is obsolete|                            |
  Attachment #68614|0                           |1
        is obsolete|                            |

--- Comment #27 from Simon Pouchol <simon.pouchol at biblibre.com> ---
Created attachment 68965
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=68965&action=edit
Bug 19522: Label creator - some strings are not translatable

Add missing case to make "Fields to print" translatable

Test plan:
1. install the fr_FR locale
2. go to /cgi-bin/koha/labels/label-manage.pl?label_element=layout
3. ensure that the list isn't empty
4. then you should see "Fields to print" in the table header
5. apply this patch
6. update the language
7. open misc/translator/po/fr-FR-staff-prog.po
8. translate the new string with something like "foobar"
   and remove the fuzzy flag
9. install the language
10. refresh the page
11. then you should see "foobar" instead of "Fields to print"

Signed-off-by: Your Name <you at example.org>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Nov  6 13:49:59 2017
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 06 Nov 2017 12:49:59 +0000
Subject: [Koha-bugs] [Bug 19522] Label creator - some strings are not
	translatable
In-Reply-To: <bug-19522-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-19522-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-19522-70-TJGukhwt2V@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19522

--- Comment #29 from Simon Pouchol <simon.pouchol at biblibre.com> ---
Created attachment 68967
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=68967&action=edit
Bug 19522: Label creator - some strings are not translatable

Templates: new form:
Add hardcoded unit names to make them translatable.

Test plan:
1. install the fr_FR locale
2. go to /cgi-bin/koha/labels/label-edit-template.pl?op=new
3. then you should see the "Unit?s" dropdown with english units
4. apply this patch
5. install the language
6. refresh the page
7. then you should see the "Unit?s" dropdown with french units

Signed-off-by: Your Name <you at example.org>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Nov  6 13:49:55 2017
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 06 Nov 2017 12:49:55 +0000
Subject: [Koha-bugs] [Bug 19522] Label creator - some strings are not
	translatable
In-Reply-To: <bug-19522-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-19522-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-19522-70-vA3KeZ3oaH@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19522

Simon Pouchol <simon.pouchol at biblibre.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #68613|0                           |1
        is obsolete|                            |

--- Comment #28 from Simon Pouchol <simon.pouchol at biblibre.com> ---
Created attachment 68966
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=68966&action=edit
Bug 19522: Coding style: Fix alignement after previous patch

Signed-off-by: Your Name <you at example.org>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Nov  6 13:50:02 2017
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 06 Nov 2017 12:50:02 +0000
Subject: [Koha-bugs] [Bug 19522] Label creator - some strings are not
	translatable
In-Reply-To: <bug-19522-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-19522-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-19522-70-e6D97LKifH@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19522

Simon Pouchol <simon.pouchol at biblibre.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #68615|0                           |1
        is obsolete|                            |

--- Comment #30 from Simon Pouchol <simon.pouchol at biblibre.com> ---
Created attachment 68968
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=68968&action=edit
Bug 19522: Coding style: Replace tabs with spaces

In Label creator: Templates: new/edit form

Signed-off-by: Your Name <you at example.org>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Nov  6 13:50:06 2017
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 06 Nov 2017 12:50:06 +0000
Subject: [Koha-bugs] [Bug 19522] Label creator - some strings are not
	translatable
In-Reply-To: <bug-19522-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-19522-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-19522-70-Kqmlly0oK5@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19522

Simon Pouchol <simon.pouchol at biblibre.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #68616|0                           |1
        is obsolete|                            |

--- Comment #31 from Simon Pouchol <simon.pouchol at biblibre.com> ---
Created attachment 68969
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=68969&action=edit
Bug 19522: Label creator: translate empty list message

The name of the element wasn't translated in the message.

Test plan:
1. install the fr_FR locale
2. go to /cgi-bin/koha/labels/label-manage.pl?label_element=batch
3. ensure that the list is empty
4. then you should see "pas de Batches actuellement"
5. then you should see "cr?er un nouveau batch."
6. apply this patch
7. install the language
8. refresh the page
9. then you should see "pas de Lots actuellement"
10. then you should see "cr?er un nouveau lot ."

Signed-off-by: Your Name <you at example.org>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Nov  6 13:50:09 2017
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 06 Nov 2017 12:50:09 +0000
Subject: [Koha-bugs] [Bug 19522] Label creator - some strings are not
	translatable
In-Reply-To: <bug-19522-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-19522-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-19522-70-JNFVXxtSKA@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19522

Simon Pouchol <simon.pouchol at biblibre.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #68739|0                           |1
        is obsolete|                            |

--- Comment #32 from Simon Pouchol <simon.pouchol at biblibre.com> ---
Created attachment 68970
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=68970&action=edit
Bug 19522: Label creator: edit batch: make Call number translatable

Test plan:
1. install the fr_FR locale
2. go to /cgi-bin/koha/labels/label-manage.pl?label_element=batch
3. create a batch if there is none
4. edit that batch
5. then you should see "Call number" in the column names
6. apply this patch
7. install the fr_FR locale
8. refresh the page
9. then you should see "Cote" in the column names

Signed-off-by: Your Name <you at example.org>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Nov  6 13:50:12 2017
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 06 Nov 2017 12:50:12 +0000
Subject: [Koha-bugs] [Bug 19522] Label creator - some strings are not
	translatable
In-Reply-To: <bug-19522-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-19522-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-19522-70-aV370cYFTi@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19522

Simon Pouchol <simon.pouchol at biblibre.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #68964|0                           |1
        is obsolete|                            |

--- Comment #33 from Simon Pouchol <simon.pouchol at biblibre.com> ---
Created attachment 68971
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=68971&action=edit
Bug 19522: Label creator: edit batch: make "Export label" translatable

Test plan:
1. install the fr_FR locale
2. go to /cgi-bin/koha/labels/label-manage.pl?label_element=batch
3. create a batch if there is none
4. edit that batch
5. Switch the language to French if you haven't done it yet
6. click on "Exporter le lot entier"
7. then you should see "Export labels"
8. apply this patch
9. install the language
10. replay steps 2 to 6
11. then you should see "Exporter des ?tiquettes"

Signed-off-by: Simon Pouchol <simon.pouchol at biblibre.com>

Signed-off-by: Your Name <you at example.org>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Nov  6 14:17:11 2017
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 06 Nov 2017 13:17:11 +0000
Subject: [Koha-bugs] [Bug 19479] Price diplay on a basketgroup
In-Reply-To: <bug-19479-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-19479-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-19479-70-zrjUYRrQub@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19479

sandboxes at biblibre.com <sandboxes at biblibre.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |sandboxes at biblibre.com

--- Comment #6 from sandboxes at biblibre.com <sandboxes at biblibre.com> ---
Patch tested with a sandbox, by S?verine QUEUNE <severine.queune at bulac.fr>

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Nov  6 14:17:24 2017
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 06 Nov 2017 13:17:24 +0000
Subject: [Koha-bugs] [Bug 19479] Price diplay on a basketgroup
In-Reply-To: <bug-19479-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-19479-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-19479-70-OTyJMzSegd@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19479

sandboxes at biblibre.com <sandboxes at biblibre.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #68849|0                           |1
        is obsolete|                            |

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.

From bugzilla-daemon at bugs.koha-community.org  Mon Nov  6 14:17:31 2017
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 06 Nov 2017 13:17:31 +0000
Subject: [Koha-bugs] [Bug 19479] Price diplay on a basketgroup
In-Reply-To: <bug-19479-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-19479-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-19479-70-lVT2gsOpaR@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19479

--- Comment #7 from sandboxes at biblibre.com <sandboxes at biblibre.com> ---
Created attachment 68972
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=68972&action=edit
Bug 19479: Patch to format totals according to the CurrencyFormat syspref.

On the page acqui/basketgroup.pl the prices of baskets should be shown
according to the selected CurrencyFormat syspref.

Test plan:

1) Create some baskets with items in them.
2) Go to acqui/basketgroup.pl page and check that the price format matches
   the current CurrencyFormat syspref.
3) Go to Administration and change CurrencyFormat syspref to one of the other
   available options and recheck step 2.

https://bugs.koha-community.org/show_bug.cgi?id=19479

Signed-off-by: S?verine QUEUNE <severine.queune at bulac.fr>
Signed-off-by: S?verine QUEUNE <severine.queune at bulac.fr>

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.

From bugzilla-daemon at bugs.koha-community.org  Mon Nov  6 14:27:37 2017
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 06 Nov 2017 13:27:37 +0000
Subject: [Koha-bugs] [Bug 19522] Label creator - some strings are not
	translatable
In-Reply-To: <bug-19522-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-19522-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-19522-70-GEDrM7Ltxx@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19522

Simon Pouchol <simon.pouchol at biblibre.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #68965|0                           |1
        is obsolete|                            |
  Attachment #68967|0                           |1
        is obsolete|                            |

--- Comment #34 from Simon Pouchol <simon.pouchol at biblibre.com> ---
Created attachment 68973
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=68973&action=edit
Bug 19522: Label creator - some strings are not translatable

Add missing case to make "Fields to print" translatable

Test plan:
1. install the fr_FR locale
2. go to /cgi-bin/koha/labels/label-manage.pl?label_element=layout
3. ensure that the list isn't empty
4. then you should see "Fields to print" in the table header
5. apply this patch
6. update the language
7. open misc/translator/po/fr-FR-staff-prog.po
8. translate the new string with something like "foobar"
   and remove the fuzzy flag
9. install the language
10. refresh the page
11. then you should see "foobar" instead of "Fields to print"

Signed-off-by: Simon Pouchol <simon.pouchol at biblibre.com>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Nov  6 14:27:45 2017
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 06 Nov 2017 13:27:45 +0000
Subject: [Koha-bugs] [Bug 19522] Label creator - some strings are not
	translatable
In-Reply-To: <bug-19522-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-19522-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-19522-70-I1Ytg4edZs@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19522

Simon Pouchol <simon.pouchol at biblibre.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #68966|0                           |1
        is obsolete|                            |

--- Comment #35 from Simon Pouchol <simon.pouchol at biblibre.com> ---
Created attachment 68974
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=68974&action=edit
Bug 19522: Coding style: Fix alignement after previous patch

Signed-off-by: Simon Pouchol <simon.pouchol at biblibre.com>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Nov  6 14:27:53 2017
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 06 Nov 2017 13:27:53 +0000
Subject: [Koha-bugs] [Bug 19522] Label creator - some strings are not
	translatable
In-Reply-To: <bug-19522-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-19522-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-19522-70-vSNho2jK35@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19522

--- Comment #36 from Simon Pouchol <simon.pouchol at biblibre.com> ---
Created attachment 68975
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=68975&action=edit
Bug 19522: Label creator - some strings are not translatable

Templates: new form:
Add hardcoded unit names to make them translatable.

Test plan:
1. install the fr_FR locale
2. go to /cgi-bin/koha/labels/label-edit-template.pl?op=new
3. then you should see the "Unit?s" dropdown with english units
4. apply this patch
5. install the language
6. refresh the page
7. then you should see the "Unit?s" dropdown with french units

Signed-off-by: Simon Pouchol <simon.pouchol at biblibre.com>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Nov  6 14:28:01 2017
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 06 Nov 2017 13:28:01 +0000
Subject: [Koha-bugs] [Bug 19522] Label creator - some strings are not
	translatable
In-Reply-To: <bug-19522-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-19522-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-19522-70-qcF86jOgZt@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19522

Simon Pouchol <simon.pouchol at biblibre.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #68968|0                           |1
        is obsolete|                            |

--- Comment #37 from Simon Pouchol <simon.pouchol at biblibre.com> ---
Created attachment 68976
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=68976&action=edit
Bug 19522: Coding style: Replace tabs with spaces

In Label creator: Templates: new/edit form

Signed-off-by: Simon Pouchol <simon.pouchol at biblibre.com>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Nov  6 14:28:07 2017
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 06 Nov 2017 13:28:07 +0000
Subject: [Koha-bugs] [Bug 19522] Label creator - some strings are not
	translatable
In-Reply-To: <bug-19522-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-19522-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-19522-70-dK7RKVvZVA@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19522

Simon Pouchol <simon.pouchol at biblibre.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #68969|0                           |1
        is obsolete|                            |

--- Comment #38 from Simon Pouchol <simon.pouchol at biblibre.com> ---
Created attachment 68977
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=68977&action=edit
Bug 19522: Label creator: translate empty list message

The name of the element wasn't translated in the message.

Test plan:
1. install the fr_FR locale
2. go to /cgi-bin/koha/labels/label-manage.pl?label_element=batch
3. ensure that the list is empty
4. then you should see "pas de Batches actuellement"
5. then you should see "cr?er un nouveau batch."
6. apply this patch
7. install the language
8. refresh the page
9. then you should see "pas de Lots actuellement"
10. then you should see "cr?er un nouveau lot ."

Signed-off-by: Simon Pouchol <simon.pouchol at biblibre.com>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Nov  6 14:28:12 2017
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 06 Nov 2017 13:28:12 +0000
Subject: [Koha-bugs] [Bug 19522] Label creator - some strings are not
	translatable
In-Reply-To: <bug-19522-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-19522-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-19522-70-2TaoSl49z4@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19522

Simon Pouchol <simon.pouchol at biblibre.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #68970|0                           |1
        is obsolete|                            |

--- Comment #39 from Simon Pouchol <simon.pouchol at biblibre.com> ---
Created attachment 68978
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=68978&action=edit
Bug 19522: Label creator: edit batch: make Call number translatable

Test plan:
1. install the fr_FR locale
2. go to /cgi-bin/koha/labels/label-manage.pl?label_element=batch
3. create a batch if there is none
4. edit that batch
5. then you should see "Call number" in the column names
6. apply this patch
7. install the fr_FR locale
8. refresh the page
9. then you should see "Cote" in the column names

Signed-off-by: Simon Pouchol <simon.pouchol at biblibre.com>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Nov  6 14:28:16 2017
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 06 Nov 2017 13:28:16 +0000
Subject: [Koha-bugs] [Bug 19522] Label creator - some strings are not
	translatable
In-Reply-To: <bug-19522-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-19522-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-19522-70-dQHIoJB8ER@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19522

Simon Pouchol <simon.pouchol at biblibre.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #68971|0                           |1
        is obsolete|                            |

--- Comment #40 from Simon Pouchol <simon.pouchol at biblibre.com> ---
Created attachment 68979
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=68979&action=edit
Bug 19522: Label creator: edit batch: make "Export label" translatable

Test plan:
1. install the fr_FR locale
2. go to /cgi-bin/koha/labels/label-manage.pl?label_element=batch
3. create a batch if there is none
4. edit that batch
5. Switch the language to French if you haven't done it yet
6. click on "Exporter le lot entier"
7. then you should see "Export labels"
8. apply this patch
9. install the language
10. replay steps 2 to 6
11. then you should see "Exporter des ?tiquettes"

Signed-off-by: Simon Pouchol <simon.pouchol at biblibre.com>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Nov  6 14:55:59 2017
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 06 Nov 2017 13:55:59 +0000
Subject: [Koha-bugs] [Bug 10748] Add option to block return of lost items
In-Reply-To: <bug-10748-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-10748-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-10748-70-kGanOUfZ7F@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10748

--- Comment #13 from Jonathan Druart <jonathan.druart at bugs.koha-community.org> ---
(In reply to Marcel de Rooy from comment #9)
> Adding a comment in a follow-up.

Thanks a lot Marcel!

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Nov  6 14:59:13 2017
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 06 Nov 2017 13:59:13 +0000
Subject: [Koha-bugs] [Bug 18880] Regression breaks local authentication
 fallback for all external authentications
In-Reply-To: <bug-18880-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-18880-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-18880-70-B2uT8vWjkQ@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18880

Jonathan Druart <jonathan.druart at bugs.koha-community.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
           See Also|https://bugs.koha-community |
                   |.org/bugzilla3/show_bug.cgi |
                   |?id=18314                   |
         Depends on|                            |18314


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18314
[Bug 18314] Account lockout
-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Nov  6 14:59:13 2017
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 06 Nov 2017 13:59:13 +0000
Subject: [Koha-bugs] [Bug 18314] Account lockout
In-Reply-To: <bug-18314-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-18314-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-18314-70-750MBWEcKM@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18314

Jonathan Druart <jonathan.druart at bugs.koha-community.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Blocks|                            |18880
           See Also|https://bugs.koha-community |
                   |.org/bugzilla3/show_bug.cgi |
                   |?id=18880                   |


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18880
[Bug 18880] Regression breaks local authentication fallback for all external
authentications
-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Nov  6 14:59:27 2017
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 06 Nov 2017 13:59:27 +0000
Subject: [Koha-bugs] [Bug 18992] LDAP fallback behaviour not consistent
In-Reply-To: <bug-18992-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-18992-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-18992-70-kFdSJ5uFwE@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18992

--- Comment #2 from Jonathan Druart <jonathan.druart at bugs.koha-community.org> ---
Is this related to bug 18880?

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Nov  6 15:02:47 2017
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 06 Nov 2017 14:02:47 +0000
Subject: [Koha-bugs] [Bug 19358] Purchase suggestions - enhancements to
	linking to orders
In-Reply-To: <bug-19358-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-19358-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-19358-70-N3rFfzOJLC@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19358

S?verine Queune <severine.queune at bulac.fr> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |severine.queune at bulac.fr

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Nov  6 15:08:32 2017
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 06 Nov 2017 14:08:32 +0000
Subject: [Koha-bugs] [Bug 7882] Add ability to move and reorder fields in
	MARC editor
In-Reply-To: <bug-7882-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-7882-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-7882-70-e22Xiet412@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7882

--- Comment #43 from Marjorie Barry-Vila <marjorie.barry-vila at collecto.ca> ---
(In reply to Kyle M Hall from comment #38)
> Created attachment 24228 [details] [review]
> Bug 7882: Inputs should be editable
> 
> disableSelection is deprecated and cause an issue on editing an input
> (input, select, textarea, etc.)
> see http://api.jqueryui.com/disableselection/
> 
> Signed-off-by: Kyle M Hall <kyle at bywatersolutions.com>

Hi Kyle,

Do you think you can rebase the patch for the master version?

Regards,
Marjorie

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Nov  6 15:13:31 2017
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 06 Nov 2017 14:13:31 +0000
Subject: [Koha-bugs] [Bug 15723] Add preview marc in authority results
 authorities-home.pl
In-Reply-To: <bug-15723-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-15723-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-15723-70-00zBS8dHqw@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15723

Patrick Robitaille <patrick.robitaille at collecto.ca> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |patrick.robitaille at collecto
                   |                            |.ca

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Nov  6 15:19:06 2017
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 06 Nov 2017 14:19:06 +0000
Subject: [Koha-bugs] [Bug 15522] New interface for revamped circulation rules
In-Reply-To: <bug-15522-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-15522-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-15522-70-JFc1rQ9Yof@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15522

Patrick Robitaille <patrick.robitaille at collecto.ca> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |patrick.robitaille at collecto
                   |                            |.ca

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Nov  6 15:19:11 2017
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 06 Nov 2017 14:19:11 +0000
Subject: [Koha-bugs] [Bug 19548] Search Result Second page not available
In-Reply-To: <bug-19548-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-19548-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-19548-70-hdTnfX7wlI@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19548

--- Comment #3 from Jonathan Druart <jonathan.druart at bugs.koha-community.org> ---
If I search for "test" (with quotation marks), I do not get any results at all.
Could you give us more details to recreation the issue?

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.

From bugzilla-daemon at bugs.koha-community.org  Mon Nov  6 15:32:59 2017
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 06 Nov 2017 14:32:59 +0000
Subject: [Koha-bugs] [Bug 18992] LDAP fallback behaviour not consistent
In-Reply-To: <bug-18992-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-18992-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-18992-70-ljxbGb886b@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18992

--- Comment #3 from Nick Clemens <nick at bywatersolutions.com> ---
(In reply to Jonathan Druart from comment #2)
> Is this related to bug 18880?

I commented on wrong bug, meant for 18947

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Nov  6 15:34:03 2017
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 06 Nov 2017 14:34:03 +0000
Subject: [Koha-bugs] [Bug 18947] Unexpected Active Directory LDAP
 authentication failure mode
In-Reply-To: <bug-18947-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-18947-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-18947-70-VtYjrq0lDB@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18947

Nick Clemens <nick at bywatersolutions.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
           Assignee|koha-bugs at lists.koha-commun |nick at bywatersolutions.com
                   |ity.org                     |

--- Comment #1 from Nick Clemens <nick at bywatersolutions.com> ---
This broke LDAP configuration after upgrade to 17.05, will tyr to provide a
patch shortly

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Nov  6 15:34:31 2017
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 06 Nov 2017 14:34:31 +0000
Subject: [Koha-bugs] [Bug 19444] Automatic renewal script should not
 auto-renew if a patron' s record has expired
In-Reply-To: <bug-19444-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-19444-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-19444-70-dFyrHXDaH6@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19444

--- Comment #12 from Jonathan Druart <jonathan.druart at bugs.koha-community.org> ---
(In reply to Dominic Pichette from comment #11)
> I tried it, I started by setting BlockExpiredPatronOpacActions to set,
> checked out an item for a particular patron, change the expiration date of
> that patron so he is now expired and then executed automatic_renewals.pl.
> The patch didn't seem to make a difference, it passed in both cases..

Dominic, you need to know how automatic renewals work if you want to test this
patch. You should enable it in the issuing rule and then tick the "Automatic
renewal" on the checkout screen. Is it what you tried?

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Nov  6 15:40:21 2017
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 06 Nov 2017 14:40:21 +0000
Subject: [Koha-bugs] [Bug 18992] LDAP fallback behaviour not consistent
In-Reply-To: <bug-18992-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-18992-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-18992-70-kMcjZdxb3L@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18992

--- Comment #4 from Nick Clemens <nick at bywatersolutions.com> ---
(In reply to Jonathan Druart from comment #2)
> Is this related to bug 18880?

And no, I think this exists separate from the work there - the decision is
whether we should fallback if the user exists in ldap but password is wrong ( 
I think we should)

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Nov  6 16:01:11 2017
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 06 Nov 2017 15:01:11 +0000
Subject: [Koha-bugs] [Bug 19548] Search Result Second page not available
In-Reply-To: <bug-19548-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-19548-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-19548-70-BLKepoOYds@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19548

--- Comment #4 from rainer.stowasser at zamg.ac.at ---
Then I have to enlarge the bug ;-)

Library of Congress SRU gives NOTHING
(you are right, but is this intended ?)

Deutsche Natiional Bibliothek SRU services.dnb.de:80 
gives the result Ive described

Search Terms:
meteorology
"meteorology"

Ive looked at /usr/share/koha/intranet/cgi-bin/cataloguing/z3950_search.pl
and as I understands it its the same for z39.50 and SRU

so if I want to fiddle its the right place to look right ?

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Nov  6 16:05:43 2017
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 06 Nov 2017 15:05:43 +0000
Subject: [Koha-bugs] [Bug 19538] Advanced editor - Rancor - Move syspref
 from labs to cataloging and remove experimental note
In-Reply-To: <bug-19538-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-19538-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-19538-70-RwU8uAOiVC@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19538

Jessie Zairo <jzairo at bywatersolutions.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |jzairo at bywatersolutions.com

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Nov  6 16:06:50 2017
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 06 Nov 2017 15:06:50 +0000
Subject: [Koha-bugs] [Bug 16339] Add search "start with" in z39.50 authority
	search
In-Reply-To: <bug-16339-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-16339-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-16339-70-OoGbX3c8Vd@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16339

Patrick Robitaille <patrick.robitaille at collecto.ca> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |patrick.robitaille at collecto
                   |                            |.ca

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Nov  6 16:23:23 2017
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 06 Nov 2017 15:23:23 +0000
Subject: [Koha-bugs] [Bug 19514] No Password restrictions in onboarding tool
 patron creation
In-Reply-To: <bug-19514-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-19514-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-19514-70-ZlzIRm2OTg@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19514

--- Comment #7 from Jonathan Druart <jonathan.druart at bugs.koha-community.org> ---
Created attachment 68982
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=68982&action=edit
Bug 19514: Add client-side check

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Nov  6 16:23:57 2017
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 06 Nov 2017 15:23:57 +0000
Subject: [Koha-bugs] [Bug 19514] No Password restrictions in onboarding tool
 patron creation
In-Reply-To: <bug-19514-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-19514-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-19514-70-VkAePU0XeY@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19514

Jonathan Druart <jonathan.druart at bugs.koha-community.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|In Discussion               |Needs Signoff

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Nov  6 16:44:24 2017
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 06 Nov 2017 15:44:24 +0000
Subject: [Koha-bugs] [Bug 19342] Show name private list on biblio when user
	is logged
In-Reply-To: <bug-19342-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-19342-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-19342-70-VTUS6qoGsw@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19342

Marjorie Barry-Vila <marjorie.barry-vila at collecto.ca> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
            Version|unspecified                 |master

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Nov  6 16:45:41 2017
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 06 Nov 2017 15:45:41 +0000
Subject: [Koha-bugs] [Bug 19547] Maria DB doesn't have a debian.cnf
In-Reply-To: <bug-19547-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-19547-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-19547-70-cQdUXiutEw@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19547

--- Comment #6 from M. Tompsett <mtompset at hotmail.com> ---
(In reply to M. Tompsett from comment #4)
> TEST PLAN
> -----------
...
> 10) git checkout -b bug_19547 origin/master
-- 10.5 git bz apply 19547
> 11) git checkout master

Oops... forgot the obvious line.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Nov  6 17:03:15 2017
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 06 Nov 2017 16:03:15 +0000
Subject: [Koha-bugs] [Bug 19548] Search Result Second page not available
In-Reply-To: <bug-19548-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-19548-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-19548-70-AnWi2t8xYJ@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19548

--- Comment #5 from Jonathan Druart <jonathan.druart at bugs.koha-community.org> ---
Can you paste the complete configuration of the SRU server you configured?

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Nov  6 18:16:46 2017
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 06 Nov 2017 17:16:46 +0000
Subject: [Koha-bugs] [Bug 19582] New: Elasticsearch: Auth-finder.pl must use
 search_auth_compat
Message-ID: <bug-19582-70@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19582

            Bug ID: 19582
           Summary: Elasticsearch: Auth-finder.pl must use
                    search_auth_compat
 Change sponsored?: ---
           Product: Koha
           Version: master
          Hardware: All
                OS: All
            Status: NEW
          Severity: enhancement
          Priority: P5 - low
         Component: Searching - Elasticsearch
          Assignee: koha-bugs at lists.koha-community.org
          Reporter: nick at bywatersolutions.com

When Elasticsearch is enable the authorities search from cataloging is using
Zebra, we need to use the compat functions to select the correct engine

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Nov  6 18:19:17 2017
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 06 Nov 2017 17:19:17 +0000
Subject: [Koha-bugs] [Bug 19582] Elasticsearch: Auth-finder.pl must use
 search_auth_compat
In-Reply-To: <bug-19582-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-19582-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-19582-70-wex0wcqVdw@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19582

Nick Clemens <nick at bywatersolutions.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|NEW                         |Needs Signoff

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.

From bugzilla-daemon at bugs.koha-community.org  Mon Nov  6 18:19:19 2017
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 06 Nov 2017 17:19:19 +0000
Subject: [Koha-bugs] [Bug 19582] Elasticsearch: Auth-finder.pl must use
 search_auth_compat
In-Reply-To: <bug-19582-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-19582-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-19582-70-JRRmb9np4C@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19582

--- Comment #1 from Nick Clemens <nick at bywatersolutions.com> ---
Created attachment 68984
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=68984&action=edit
Bug 19582 - Use compat routines for searching authorities in auth_finder.pl

To test:
1 - Enable Zebra
2 - Perform an auth search
3 - note results
4 - Enable ES
5 - Repeat search, note (likely) diff results
6 - Open a record in cataloging and use the button to launch auth search
7 - Perform same search as above, note results match for eiher engine
selected
8 - NOTE: Disbale sorting for ES search - this will be dealt with in
another report

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.

From bugzilla-daemon at bugs.koha-community.org  Mon Nov  6 18:19:54 2017
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 06 Nov 2017 17:19:54 +0000
Subject: [Koha-bugs] [Bug 19582] Elasticsearch: Auth-finder.pl must use
 search_auth_compat
In-Reply-To: <bug-19582-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-19582-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-19582-70-6G6pa3Vq3X@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19582

Nick Clemens <nick at bywatersolutions.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |david.bourgault at inlibro.com
                   |                            |,
                   |                            |jonathan.druart at bugs.koha-c
                   |                            |ommunity.org,
                   |                            |tomascohen at gmail.com
           Assignee|koha-bugs at lists.koha-commun |nick at bywatersolutions.com
                   |ity.org                     |

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.

From bugzilla-daemon at bugs.koha-community.org  Mon Nov  6 18:27:00 2017
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 06 Nov 2017 17:27:00 +0000
Subject: [Koha-bugs] [Bug 18712] make test is failing with an empty DB -
	t/Matcher.t
In-Reply-To: <bug-18712-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-18712-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-18712-70-Vf1TinoRoG@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18712

M. Tompsett <mtompset at hotmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #68890|0                           |1
        is obsolete|                            |

--- Comment #6 from M. Tompsett <mtompset at hotmail.com> ---
Created attachment 68985
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=68985&action=edit
Bug 18712: Fix t/Matcher.t if DB is empty

t/Matcher.t is failing with an empty DB, the data are not mocked
correctly

Test plan:
drop your DB and recreate it without any data and prove t/Matcher.t

Signed-off-by: Mark Tompsett <mtompset at hotmail.com>

Signed-off-by: Mark Tompsett <mtompset at hotmail.com>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Nov  6 18:27:03 2017
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 06 Nov 2017 17:27:03 +0000
Subject: [Koha-bugs] [Bug 18712] make test is failing with an empty DB -
	t/Matcher.t
In-Reply-To: <bug-18712-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-18712-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-18712-70-4VkZWtdF6V@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18712

M. Tompsett <mtompset at hotmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #68891|0                           |1
        is obsolete|                            |

--- Comment #7 from M. Tompsett <mtompset at hotmail.com> ---
Created attachment 68986
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=68986&action=edit
Bug 18712: Remove unecessary fixtures

2 fixtures are in a subroutine that is never called, it can be removed

Signed-off-by: Mark Tompsett <mtompset at hotmail.com>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Nov  6 18:27:06 2017
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 06 Nov 2017 17:27:06 +0000
Subject: [Koha-bugs] [Bug 18712] make test is failing with an empty DB -
	t/Matcher.t
In-Reply-To: <bug-18712-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-18712-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-18712-70-MMBwcAoGtd@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18712

--- Comment #8 from M. Tompsett <mtompset at hotmail.com> ---
Created attachment 68987
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=68987&action=edit
Bug 18712: Added missing done_testing

Signed-off-by: Mark Tompsett <mtompset at hotmail.com>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Nov  6 18:27:56 2017
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 06 Nov 2017 17:27:56 +0000
Subject: [Koha-bugs] [Bug 18712] make test is failing with an empty DB -
	t/Matcher.t
In-Reply-To: <bug-18712-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-18712-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-18712-70-lpp54LeRDg@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18712

M. Tompsett <mtompset at hotmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |mtompset at hotmail.com
             Status|Needs Signoff               |Signed Off

--- Comment #9 from M. Tompsett <mtompset at hotmail.com> ---
Though, I think the last two patches probable belong on their own bug.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Nov  6 18:29:14 2017
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 06 Nov 2017 17:29:14 +0000
Subject: [Koha-bugs] [Bug 19289] Allow configuration of the fields on the
 'Catalog details' form in the acquisition baskets
In-Reply-To: <bug-19289-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-19289-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-19289-70-y9oKXlmrZD@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19289

--- Comment #5 from S?verine Queune <severine.queune at bulac.fr> ---
I wanted to test this patch even thought it's signed off but I couldn't apply
it on Biblibre's sandbox.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Nov  6 18:34:27 2017
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 06 Nov 2017 17:34:27 +0000
Subject: [Koha-bugs] [Bug 7317] Add an Interlibrary Loan Module to
	Circulation and OPAC
In-Reply-To: <bug-7317-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-7317-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-7317-70-wm60UlZ3TG@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7317

--- Comment #183 from Tom?s Cohen Arazi <tomascohen at gmail.com> ---
Created attachment 68988
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=68988&action=edit
Bug 7317: Add partner_code checks to abot page

This patch adds checks to the configured (or fallback) partner_code.
It produces two different warnings:

- Configured partner_code doesn't match an existing patron category
code.
- partner_code is not defined, a fallback to ILLLIBS is done

Signed-off-by: Tomas Cohen Arazi <tomascohen at theke.io>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Nov  6 18:34:45 2017
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 06 Nov 2017 17:34:45 +0000
Subject: [Koha-bugs] [Bug 7317] Add an Interlibrary Loan Module to
	Circulation and OPAC
In-Reply-To: <bug-7317-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-7317-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-7317-70-cnuUiUjAOt@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7317

--- Comment #184 from Tom?s Cohen Arazi <tomascohen at gmail.com> ---
Created attachment 68989
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=68989&action=edit
Bug 7317: (followup) Make tests independent of data on the DB

Signed-off-by: Tomas Cohen Arazi <tomascohen at theke.io>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Nov  6 18:37:46 2017
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 06 Nov 2017 17:37:46 +0000
Subject: [Koha-bugs] [Bug 7317] Add an Interlibrary Loan Module to
	Circulation and OPAC
In-Reply-To: <bug-7317-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-7317-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-7317-70-lOw06YhHT1@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7317

--- Comment #185 from Tom?s Cohen Arazi <tomascohen at gmail.com> ---
(In reply to Jonathan Druart from comment #182)
> 1/ Error handling on borrowernumber when creating or updating a request
> (backend issue?)

This is definitely a backend issue. The Dummy backend does no check, it just
passes the borrowernumber from the UI to the Koha::Illrequest->store method
with no error catching. The FreeForm plugin does some checks before the
->store, though. Out of the scope of the bug anyway.

> 6/ Should not we use message_queue instead of sendmail directly?

There's a bug filed for this: bug 18588.

> 7/ Maybe we should add a warning to the about page if the partner_code
> defined in the config does not match a category_code (?)

Done in one of the recent followups.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Nov  6 18:42:39 2017
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 06 Nov 2017 17:42:39 +0000
Subject: [Koha-bugs] [Bug 14180] Make "Always show checkouts immediately" a
 global setting
In-Reply-To: <bug-14180-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-14180-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-14180-70-WLK1RhMnZK@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14180

S?verine Queune <severine.queune at bulac.fr> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |severine.queune at bulac.fr

--- Comment #10 from S?verine Queune <severine.queune at bulac.fr> ---
We added this code on 'IntranetUserJS' syspref and it works perfectly for us :)
(Found on Biblibre's documentation)


$(document).ready(function() {

if ( typeof script !== 'undefined' && !
$.cookie("issues-table-load-immediately-" + script) ) {
    $.cookie("issues-table-load-immediately-" + script, true, { expires: 365
});
}

});

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.

From bugzilla-daemon at bugs.koha-community.org  Mon Nov  6 18:54:20 2017
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 06 Nov 2017 17:54:20 +0000
Subject: [Koha-bugs] [Bug 13990] ILS-DI LookupPatron Requries ID Type
In-Reply-To: <bug-13990-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-13990-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-13990-70-gEh4VsOaYV@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13990

Jon Knight <J.P.Knight at lboro.ac.uk> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|NEW                         |In Discussion
                 CC|                            |J.P.Knight at lboro.ac.uk

--- Comment #2 from Jon Knight <J.P.Knight at lboro.ac.uk> ---
I assume the obvious fix to this is to say that the id_type is required rather
than optional in the POD?  Alternative there could be a set of well defined
id_types that are cycled through to find matches (that would be a pretty easy
bit of code).

On a similar note, we've noticed that "email" also appears to be a valid
id_type but isn't in the POD list. A quick look in the code (hoorah for open
source!) shows that any field in the borrower table can be looked up with this
call.  For example "phone", "phonepro" or "mobile" let me find myself using my
primary, secondary and "other" phone number. 

This begs the question: should Koha be constraining the list of id_type's that
can be passed into this routine from the client? Or is being able to search on
any column in the borrowers table regarded as a useful feature (we've found
"email" to be handy for sure).

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.

From bugzilla-daemon at bugs.koha-community.org  Mon Nov  6 19:36:13 2017
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 06 Nov 2017 18:36:13 +0000
Subject: [Koha-bugs] [Bug 19578] TT syntax for notices - There is no way to
 pre-process DB fields
In-Reply-To: <bug-19578-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-19578-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-19578-70-ofWBDYEWak@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19578

--- Comment #4 from Jonathan Druart <jonathan.druart at bugs.koha-community.org> ---
Created attachment 68990
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=68990&action=edit
Bug 19578: Remove MARC punctuation in notices (TT syntax)

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Nov  6 19:41:43 2017
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 06 Nov 2017 18:41:43 +0000
Subject: [Koha-bugs] [Bug 19578] TT syntax for notices - There is no way to
 pre-process DB fields
In-Reply-To: <bug-19578-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-19578-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-19578-70-H4Em4c82tf@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19578

Jonathan Druart <jonathan.druart at bugs.koha-community.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #68990|0                           |1
        is obsolete|                            |

--- Comment #5 from Jonathan Druart <jonathan.druart at bugs.koha-community.org> ---
Created attachment 68991
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=68991&action=edit
Bug 19578: Remove MARC punctuation in notices (TT syntax)

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.

From bugzilla-daemon at bugs.koha-community.org  Mon Nov  6 19:43:30 2017
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 06 Nov 2017 18:43:30 +0000
Subject: [Koha-bugs] [Bug 19578] TT syntax for notices - There is no way to
 pre-process DB fields
In-Reply-To: <bug-19578-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-19578-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-19578-70-endLiAfPtN@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19578

Jonathan Druart <jonathan.druart at bugs.koha-community.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
           Assignee|koha-bugs at lists.koha-commun |jonathan.druart at bugs.koha-c
                   |ity.org                     |ommunity.org

--- Comment #6 from Jonathan Druart <jonathan.druart at bugs.koha-community.org> ---
Marcel, what do you think about this approach?

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.

From bugzilla-daemon at bugs.koha-community.org  Mon Nov  6 19:47:36 2017
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 06 Nov 2017 18:47:36 +0000
Subject: [Koha-bugs] [Bug 19289] Allow configuration of the fields on the
 'Catalog details' form in the acquisition baskets
In-Reply-To: <bug-19289-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-19289-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-19289-70-Amo1naRUCr@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19289

--- Comment #6 from Jonathan Druart <jonathan.druart at bugs.koha-community.org> ---
(In reply to S?verine Queune from comment #5)
> I wanted to test this patch even thought it's signed off but I couldn't
> apply it on Biblibre's sandbox.

It applies correctly for me on top of bug 3841, did you apply the dependency
patches before?

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Nov  6 19:55:07 2017
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 06 Nov 2017 18:55:07 +0000
Subject: [Koha-bugs] [Bug 19287] Add ability to mark an item 'Lost' from
 'Holds awaiting pickup ' list
In-Reply-To: <bug-19287-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-19287-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-19287-70-1dGOse9XhA@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19287

--- Comment #28 from Jonathan Druart <jonathan.druart at bugs.koha-community.org> ---
(In reply to S?verine Queune from comment #26)
> We vote suggestion 1.

Sally and Katrin, would you also agree with a new "UpdateItemWhenLost" pref?

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Nov  6 20:35:14 2017
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 06 Nov 2017 19:35:14 +0000
Subject: [Koha-bugs] [Bug 17602] Integrate support for
	OneClickdigital/Recorded Books API
In-Reply-To: <bug-17602-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-17602-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-17602-70-g00I7Jy5is@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17602

--- Comment #46 from Jonathan Druart <jonathan.druart at bugs.koha-community.org> ---
Quick note: use String.format() when needed.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Nov  6 23:45:33 2017
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 06 Nov 2017 22:45:33 +0000
Subject: [Koha-bugs] [Bug 19583] New: Report updater triggers on
	auth_header.marcxml
Message-ID: <bug-19583-70@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19583

            Bug ID: 19583
           Summary: Report updater triggers on auth_header.marcxml
 Change sponsored?: ---
           Product: Koha
           Version: 17.05
          Hardware: All
                OS: All
            Status: NEW
          Severity: enhancement
          Priority: P5 - low
         Component: Reports
          Assignee: koha-bugs at lists.koha-community.org
          Reporter: barton at bywatersolutions.com
        QA Contact: testopia at bugs.koha-community.org

In Home ? Reports ? Guided reports wizard ? Saved reports,

Any reports that use auth_header.marcxml will display

"This report seems obsolete, it uses biblioitems.marcxml field" with an "Update
SQL" button.

auth_header.marcxml still exists in the schema however.

This is bound to be confusing to users.

--Barton

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.

From bugzilla-daemon at bugs.koha-community.org  Tue Nov  7 02:31:38 2017
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 07 Nov 2017 01:31:38 +0000
Subject: [Koha-bugs] [Bug 19582] Elasticsearch: Auth-finder.pl must use
 search_auth_compat
In-Reply-To: <bug-19582-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-19582-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-19582-70-yK39m8T20G@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19582

Nick Clemens <nick at bywatersolutions.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #68984|0                           |1
        is obsolete|                            |

--- Comment #2 from Nick Clemens <nick at bywatersolutions.com> ---
Created attachment 68992
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=68992&action=edit
Bug 19582 - Use compat routines for searching authorities in auth_finder.pl

To test:
1 - Enable Zebra
2 - Perform an auth search
3 - note results
4 - Enable ES
5 - Repeat search, note (likely) diff results
6 - Open a record in cataloging and use the button to launch auth search
7 - Perform same search as above, note results match for eiher engine
selected
8 - NOTE: Disable sorting for ES search - this will be dealt with in
another report

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Nov  7 02:31:41 2017
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 07 Nov 2017 01:31:41 +0000
Subject: [Koha-bugs] [Bug 19582] Elasticsearch: Auth-finder.pl must use
 search_auth_compat
In-Reply-To: <bug-19582-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-19582-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-19582-70-uLIa7aX9Qb@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19582

--- Comment #3 from Nick Clemens <nick at bywatersolutions.com> ---
Created attachment 68993
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=68993&action=edit
Bug 19582: Unit tests

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Nov  7 02:43:27 2017
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 07 Nov 2017 01:43:27 +0000
Subject: [Koha-bugs] [Bug 11213] GetItemsInfo() called twice
In-Reply-To: <bug-11213-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-11213-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-11213-70-MZcKr5Mbi3@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11213

Srdjan Jankovic <srdjan at catalyst.net.nz> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #68820|0                           |1
        is obsolete|                            |

--- Comment #129 from Srdjan Jankovic <srdjan at catalyst.net.nz> ---
Comment on attachment 68820
  --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=68820
bug_11213: Include XSLT processing for searchResults() test

Not required

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Nov  7 02:48:47 2017
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 07 Nov 2017 01:48:47 +0000
Subject: [Koha-bugs] [Bug 11213] GetItemsInfo() called twice
In-Reply-To: <bug-11213-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-11213-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-11213-70-9XjFyNSE8r@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11213

--- Comment #130 from Srdjan Jankovic <srdjan at catalyst.net.nz> ---
(In reply to Josef Moravec from comment #128)
> Hi Srdjan,
> I did test these patches now, but I am sorry:
> 
> The test Search.t is failing after this patchset...

Don't be sorry, thanks for testing.
I've decided that Search.t is broken, and there's no use changing it at this
stage, so I dropped that patch.


> virtualshelves on intranet and opac goes to ISE:
> 
> DBIx::Class::ResultSet::_construct_results(): Unable to properly collapse
> has_many results in iterator mode due to order criteria - performed an eager
> cursor slurp underneath. Consider using ->all() instead at
> /home/vagrant/kohaclone/Koha/Objects.pm line 209
> Can't use string ("1") as an ARRAY ref while "strict refs" in use at
> /home/vagrant/kohaclone/C4/XSLT.pm line 290.

Can you please tell me the steps to get that. Thanks.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Nov  7 03:06:33 2017
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 07 Nov 2017 02:06:33 +0000
Subject: [Koha-bugs] [Bug 17602] Integrate support for
	OneClickdigital/Recorded Books API
In-Reply-To: <bug-17602-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-17602-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-17602-70-lwxVElGaLE@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17602

--- Comment #47 from Srdjan Jankovic <srdjan at catalyst.net.nz> ---
(In reply to Jonathan Druart from comment #46)
> Quick note: use String.format() when needed.

Money or somewhere else?

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Nov  7 04:27:09 2017
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 07 Nov 2017 03:27:09 +0000
Subject: [Koha-bugs] [Bug 17770] t/db_dependent/ Sitemapper.t fails when
 date changes during test run
In-Reply-To: <bug-17770-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-17770-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-17770-70-GawD1eRjmp@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17770

--- Comment #1 from M. Tompsett <mtompset at hotmail.com> ---
Created attachment 68994
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=68994&action=edit
Bug 17770: Sitemapper.t fails if date changes during test run

To compensate, DateTime->now is mocked to the current date.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Nov  7 04:27:12 2017
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 07 Nov 2017 03:27:12 +0000
Subject: [Koha-bugs] [Bug 17770] t/db_dependent/ Sitemapper.t fails when
 date changes during test run
In-Reply-To: <bug-17770-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-17770-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-17770-70-R0MAcptCkT@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17770

--- Comment #2 from M. Tompsett <mtompset at hotmail.com> ---
Created attachment 68995
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=68995&action=edit
Bug 17770: Improve perlcritic level

before patch: perlcritic -4 noisy
after patch: perlcritic -4 ok

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Nov  7 04:27:14 2017
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 07 Nov 2017 03:27:14 +0000
Subject: [Koha-bugs] [Bug 17770] t/db_dependent/ Sitemapper.t fails when
 date changes during test run
In-Reply-To: <bug-17770-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-17770-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-17770-70-hIJig7utov@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17770

--- Comment #3 from M. Tompsett <mtompset at hotmail.com> ---
Created attachment 68996
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=68996&action=edit
Bug 17770: Perltidy

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Nov  7 04:27:06 2017
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 07 Nov 2017 03:27:06 +0000
Subject: [Koha-bugs] [Bug 17770] t/db_dependent/ Sitemapper.t fails when
 date changes during test run
In-Reply-To: <bug-17770-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-17770-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-17770-70-bXKu2yDEgG@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17770

M. Tompsett <mtompset at hotmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|NEW                         |Needs Signoff

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Nov  7 09:53:30 2017
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 07 Nov 2017 08:53:30 +0000
Subject: [Koha-bugs] [Bug 18588] Integrate ILL generic_emails in notices
	system.
In-Reply-To: <bug-18588-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-18588-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-18588-70-ECl1SyTZ3l@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18588

Magnus Enger <magnus at libriotech.no> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |magnus at libriotech.no

--- Comment #1 from Magnus Enger <magnus at libriotech.no> ---
I'm getting paid to work on ILL for Swedish libraries, and this is definitely
one of the things they want, so I will be working on this in the near future,
if noone beats me to it. Probably not in time for 17.11, though.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Nov  7 11:14:55 2017
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 07 Nov 2017 10:14:55 +0000
Subject: [Koha-bugs] [Bug 18096] BnF Authorities Z39.50 search and access
In-Reply-To: <bug-18096-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-18096-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-18096-70-zIjaQ4lZqr@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18096

Gaetan Boisson <gaetan.boisson at biblibre.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |gaetan.boisson at biblibre.com
         Depends on|                            |19436

--- Comment #5 from Gaetan Boisson <gaetan.boisson at biblibre.com> ---
This could be solved by BZ 19436, since BNF is now providing authorities
through SRU.

I am not sure it is worth investing more time in z3950.


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19436
[Bug 19436] Add SRU support for authorities
-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Nov  7 11:14:55 2017
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 07 Nov 2017 10:14:55 +0000
Subject: [Koha-bugs] [Bug 19436] Add SRU support for authorities
In-Reply-To: <bug-19436-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-19436-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-19436-70-oZicBk998F@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19436

Gaetan Boisson <gaetan.boisson at biblibre.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Blocks|                            |18096


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18096
[Bug 18096] BnF Authorities Z39.50 search and access
-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.

From bugzilla-daemon at bugs.koha-community.org  Tue Nov  7 11:16:56 2017
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 07 Nov 2017 10:16:56 +0000
Subject: [Koha-bugs] [Bug 19436] Add SRU support for authorities
In-Reply-To: <bug-19436-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-19436-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-19436-70-XYBszuakx3@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19436

Gaetan Boisson <gaetan.boisson at biblibre.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Blocks|18096                       |
                 CC|                            |gaetan.boisson at biblibre.com

--- Comment #1 from Gaetan Boisson <gaetan.boisson at biblibre.com> ---
This would indeed be great. The French national library is also offering SRU
for authorities  now : http://catalogue.bnf.fr/api/test.do

See and example here :
http://catalogue.bnf.fr/api/SRU?version=1.2&operation=searchRetrieve&query=(aut.type%20any%20%22pep%20org%22)%20%20and%20(aut.accesspoint%20all%20%22victor%20hugo%22)


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18096
[Bug 18096] BnF Authorities Z39.50 search and access
-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Nov  7 11:16:56 2017
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 07 Nov 2017 10:16:56 +0000
Subject: [Koha-bugs] [Bug 18096] BnF Authorities Z39.50 search and access
In-Reply-To: <bug-18096-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-18096-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-18096-70-tbbQRv70g1@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18096

Gaetan Boisson <gaetan.boisson at biblibre.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
         Depends on|19436                       |


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19436
[Bug 19436] Add SRU support for authorities
-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Nov  7 14:10:05 2017
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 07 Nov 2017 13:10:05 +0000
Subject: [Koha-bugs] [Bug 19578] TT syntax for notices - There is no way to
 pre-process DB fields
In-Reply-To: <bug-19578-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-19578-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-19578-70-7j3JktPRBx@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19578

--- Comment #7 from Marcel de Rooy <m.de.rooy at rijksmuseum.nl> ---
(In reply to Jonathan Druart from comment #6)
> Marcel, what do you think about this approach?

Looks quite good. Is it possible to further reduce the number of fields in
biblio and biblioitems to run this Remove_MARC_punctuation on in some pragmatic
way?

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Nov  7 14:11:14 2017
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 07 Nov 2017 13:11:14 +0000
Subject: [Koha-bugs] [Bug 19575] Use canonical field names and resolve
	aliased fields
In-Reply-To: <bug-19575-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-19575-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-19575-70-o12yTopr4I@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19575

--- Comment #2 from David Gustafsson <glasklas at gmail.com> ---
The following issue should be resolved with this patch applied:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19485

But in addition to title-series, most of the other broken search links should
also work.

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Nov  7 14:33:23 2017
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 07 Nov 2017 13:33:23 +0000
Subject: [Koha-bugs] [Bug 19578] TT syntax for notices - There is no way to
 pre-process DB fields
In-Reply-To: <bug-19578-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-19578-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-19578-70-KJT4eQ3Kkd@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19578

--- Comment #8 from Jonathan Druart <jonathan.druart at bugs.koha-community.org> ---
(In reply to Marcel de Rooy from comment #7)
> (In reply to Jonathan Druart from comment #6)
> > Marcel, what do you think about this approach?
> 
> Looks quite good. Is it possible to further reduce the number of fields in
> biblio and biblioitems to run this Remove_MARC_punctuation on in some
> pragmatic way?

Yes, we could apply the regex only with a list of fields. But then the 2
syntaxes will no give the same results.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Nov  7 14:37:23 2017
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 07 Nov 2017 13:37:23 +0000
Subject: [Koha-bugs] [Bug 19578] TT syntax for notices - There is no way to
 pre-process DB fields
In-Reply-To: <bug-19578-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-19578-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-19578-70-HACUk0MApl@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19578

--- Comment #9 from Marcel de Rooy <m.de.rooy at rijksmuseum.nl> ---
(In reply to Jonathan Druart from comment #8)
> (In reply to Marcel de Rooy from comment #7)
> > (In reply to Jonathan Druart from comment #6)
> > > Marcel, what do you think about this approach?
> > 
> > Looks quite good. Is it possible to further reduce the number of fields in
> > biblio and biblioitems to run this Remove_MARC_punctuation on in some
> > pragmatic way?
> 
> Yes, we could apply the regex only with a list of fields. But then the 2
> syntaxes will no give the same results.

Which can be solved too ?

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Nov  7 14:55:33 2017
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 07 Nov 2017 13:55:33 +0000
Subject: [Koha-bugs] [Bug 14769] Authorities merge: Set correct indicators
 in biblio field
In-Reply-To: <bug-14769-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-14769-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-14769-70-5lmImOzE9Q@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14769

Marcel de Rooy <m.de.rooy at rijksmuseum.nl> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
           Assignee|julian.maurice at biblibre.com |m.de.rooy at rijksmuseum.nl

--- Comment #9 from Marcel de Rooy <m.de.rooy at rijksmuseum.nl> ---
This would still be great to have..

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Nov  7 15:08:18 2017
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 07 Nov 2017 14:08:18 +0000
Subject: [Koha-bugs] [Bug 19584] New: Inventory: working title
Message-ID: <bug-19584-70@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19584

            Bug ID: 19584
           Summary: Inventory: working title
 Change sponsored?: ---
           Product: Koha
           Version: master
          Hardware: All
                OS: All
            Status: NEW
          Severity: enhancement
          Priority: P5 - low
         Component: Tools
          Assignee: koha-bugs at lists.koha-community.org
          Reporter: m.de.rooy at rijksmuseum.nl
        QA Contact: testopia at bugs.koha-community.org

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.

From bugzilla-daemon at bugs.koha-community.org  Tue Nov  7 15:09:27 2017
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 07 Nov 2017 14:09:27 +0000
Subject: [Koha-bugs] [Bug 19584] Inventory: working title
In-Reply-To: <bug-19584-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-19584-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-19584-70-OcfLBN9nhn@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19584

Marcel de Rooy <m.de.rooy at rijksmuseum.nl> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|NEW                         |ASSIGNED
           Assignee|koha-bugs at lists.koha-commun |m.de.rooy at rijksmuseum.nl
                   |ity.org                     |

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Nov  7 15:10:51 2017
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 07 Nov 2017 14:10:51 +0000
Subject: [Koha-bugs] [Bug 19584] Inventory: working title
In-Reply-To: <bug-19584-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-19584-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-19584-70-jQQTe5yOAm@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19584

--- Comment #1 from Marcel de Rooy <m.de.rooy at rijksmuseum.nl> ---
Created attachment 68997
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=68997&action=edit
Bug 19584: Replace label Status by Not for loan

Status does not tell me that this is the Not for loan column.
Trivial edit.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Nov  7 15:15:52 2017
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 07 Nov 2017 14:15:52 +0000
Subject: [Koha-bugs] [Bug 19578] TT syntax for notices - There is no way to
 pre-process DB fields
In-Reply-To: <bug-19578-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-19578-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-19578-70-qXo5Dw5L0y@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19578

--- Comment #10 from Jonathan Druart <jonathan.druart at bugs.koha-community.org> ---
I would not recommend to make them diverge and I would not recommend to keep
maintaining the 2 syntaxes...
So let's keep behaviour as it for now :)

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Nov  7 15:29:27 2017
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 07 Nov 2017 14:29:27 +0000
Subject: [Koha-bugs] [Bug 17602] Integrate support for
	OneClickdigital/Recorded Books API
In-Reply-To: <bug-17602-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-17602-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-17602-70-o8ypwf3NH8@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17602

--- Comment #48 from Jonathan Druart <jonathan.druart at bugs.koha-community.org> ---
(In reply to Srdjan Jankovic from comment #47)
> (In reply to Jonathan Druart from comment #46)
> > Quick note: use String.format() when needed.
> 
> Money or somewhere else?

Hum? Money?
I am talking about that kind of generated strings:
$( '#recordedbooks-status' ).html( '<strong>' + _("Found") + ' ' + data.total +
' ' + _("results in the library's RecordedBooks collection.") + '</strong>' );

should be

_("Found %s results in the library's RecordedBooks
collection.").format(data.total)

But it was a not for myself.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Nov  7 15:30:23 2017
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 07 Nov 2017 14:30:23 +0000
Subject: [Koha-bugs] [Bug 17602] Integrate support for
	OneClickdigital/Recorded Books API
In-Reply-To: <bug-17602-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-17602-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-17602-70-WsWj8qyb87@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17602

--- Comment #49 from Jonathan Druart <jonathan.druart at bugs.koha-community.org> ---
(In reply to Srdjan Jankovic from comment #43)
> Created attachment 67860 [details] [review]
> t/Koha_ExternalContent_OverDrive.t correction

Why this change?
See commit c1185533c61e8266f9d89136e8e0debddf71d497
    Bug 18851: Make OverDrive.T pass if dbms is not running

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Nov  7 15:41:57 2017
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 07 Nov 2017 14:41:57 +0000
Subject: [Koha-bugs] [Bug 19564] Fix extraction of sort order from sort
	condition name
In-Reply-To: <bug-19564-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-19564-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-19564-70-xsfWrvYZl9@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19564

--- Comment #3 from David Gustafsson <glasklas at gmail.com> ---
Replaced the wrong line in previous patch, will fix.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Nov  7 15:42:49 2017
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 07 Nov 2017 14:42:49 +0000
Subject: [Koha-bugs] [Bug 19564] Fix extraction of sort order from sort
	condition name
In-Reply-To: <bug-19564-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-19564-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-19564-70-3d2f5XKbcB@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19564

David Gustafsson <glasklas at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #68892|0                           |1
        is obsolete|                            |

--- Comment #4 from David Gustafsson <glasklas at gmail.com> ---
Created attachment 68998
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=68998&action=edit
Bug 19564: Fix extraction of sort order from sort condition name

Currently sort order is extracted from sort condition by splitting the
field, instead use regular expression to extract the last part preceded
by underscore.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Nov  7 15:44:54 2017
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 07 Nov 2017 14:44:54 +0000
Subject: [Koha-bugs] [Bug 8676] show vendor name in source of acquisition
In-Reply-To: <bug-8676-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-8676-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-8676-70-2flCth1MLj@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8676

Patrick Robitaille <patrick.robitaille at collecto.ca> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |patrick.robitaille at collecto
                   |                            |.ca

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Nov  7 15:47:40 2017
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 07 Nov 2017 14:47:40 +0000
Subject: [Koha-bugs] [Bug 18827] Elasticsearch mappings - not displayed or
 retrieved in saved order
In-Reply-To: <bug-18827-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-18827-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-18827-70-UZiAWq7yPm@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18827

Frank Hansen <frank.hansen at ub.lu.se> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |frank.hansen at ub.lu.se

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Nov  7 16:02:02 2017
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 07 Nov 2017 15:02:02 +0000
Subject: [Koha-bugs] [Bug 19585] New: Inventory: working title 2
Message-ID: <bug-19585-70@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19585

            Bug ID: 19585
           Summary: Inventory: working title 2
 Change sponsored?: ---
           Product: Koha
           Version: master
          Hardware: All
                OS: All
            Status: NEW
          Severity: enhancement
          Priority: P5 - low
         Component: Tools
          Assignee: koha-bugs at lists.koha-community.org
          Reporter: m.de.rooy at rijksmuseum.nl
        QA Contact: testopia at bugs.koha-community.org

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Nov  7 16:02:16 2017
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 07 Nov 2017 15:02:16 +0000
Subject: [Koha-bugs] [Bug 19585] Inventory: working title 2
In-Reply-To: <bug-19585-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-19585-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-19585-70-NFNHROk6TF@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19585

Marcel de Rooy <m.de.rooy at rijksmuseum.nl> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
           Assignee|koha-bugs at lists.koha-commun |m.de.rooy at rijksmuseum.nl
                   |ity.org                     |
             Status|NEW                         |ASSIGNED

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.

From bugzilla-daemon at bugs.koha-community.org  Tue Nov  7 16:06:08 2017
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 07 Nov 2017 15:06:08 +0000
Subject: [Koha-bugs] [Bug 7317] Add an Interlibrary Loan Module to
	Circulation and OPAC
In-Reply-To: <bug-7317-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-7317-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-7317-70-Ct6zJrmUvw@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7317

--- Comment #186 from Tom?s Cohen Arazi <tomascohen at gmail.com> ---
Created attachment 68999
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=68999&action=edit
Bug 7317: (QA followup) ILL sysprefs belong to circulation section

Signed-off-by: Tomas Cohen Arazi <tomascohen at theke.io>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Nov  7 16:06:15 2017
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 07 Nov 2017 15:06:15 +0000
Subject: [Koha-bugs] [Bug 7317] Add an Interlibrary Loan Module to
	Circulation and OPAC
In-Reply-To: <bug-7317-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-7317-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-7317-70-VPfmSzxN2u@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7317

--- Comment #187 from Tom?s Cohen Arazi <tomascohen at gmail.com> ---
Created attachment 69000
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=69000&action=edit
Bug 7317: Handle missing email addresses gracefuly

Signed-off-by: Tomas Cohen Arazi <tomascohen at theke.io>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Nov  7 16:34:04 2017
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 07 Nov 2017 15:34:04 +0000
Subject: [Koha-bugs] [Bug 19555] Some changes to records are not reflected
	in OAI-PMH
In-Reply-To: <bug-19555-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-19555-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-19555-70-xTxgSnB7PV@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19555

Tom?s Cohen Arazi <tomascohen at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
         QA Contact|testopia at bugs.koha-communit |tomascohen at gmail.com
                   |y.org                       |
           Assignee|koha-bugs at lists.koha-commun |magnus at libriotech.no
                   |ity.org                     |

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Nov  7 16:43:29 2017
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 07 Nov 2017 15:43:29 +0000
Subject: [Koha-bugs] [Bug 19289] Allow configuration of the fields on the
 'Catalog details' form in the acquisition baskets
In-Reply-To: <bug-19289-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-19289-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-19289-70-HOPhpNHBIl@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19289

--- Comment #7 from S?verine Queune <severine.queune at bulac.fr> ---
(In reply to Jonathan Druart from comment #6)
> (In reply to S?verine Queune from comment #5)
> > I wanted to test this patch even thought it's signed off but I couldn't
> > apply it on Biblibre's sandbox.
> 
> It applies correctly for me on top of bug 3841, did you apply the dependency
> patches before?
My bad, I didn't see the dependency...

It seems to work quite good.
I tested with new empty records and existing records and all fields are
diplayed as expected.

I just wonder about these fields in the 'Catalog details' framework that I
didn't found on the MARC framework structure :
9 (RLIN) (6489)
9 (RLIN) (6549)
9 (RLIN) (6559)
9 (RLIN) (6569)
9 (RLIN) (6579)
9 (RLIN) (6589)
9 (RLIN) (6629)
I don't know where they come from and i can't mask them.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Nov  7 17:05:06 2017
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 07 Nov 2017 16:05:06 +0000
Subject: [Koha-bugs] [Bug 16461] Add some information (branch and barcode)
 in fine description for overdue
In-Reply-To: <bug-16461-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-16461-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-16461-70-5YcOdhWMui@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16461

Simon Pouchol <simon.pouchol at biblibre.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |simon.pouchol at biblibre.com
             Status|Needs Signoff               |Patch doesn't apply

--- Comment #9 from Simon Pouchol <simon.pouchol at biblibre.com> ---
Looks like this patch doesn't apply :
Applying: Bug 16461 - Add branch and barcode in accountline table for overdues
Using index info to reconstruct a base tree...
M       C4/Overdues.pm
M       installer/data/mysql/kohastructure.sql
M       koha-tmpl/intranet-tmpl/prog/en/modules/members/pay.tt
M       t/db_dependent/Circulation.t
Falling back to patching base and 3-way merge...
Auto-merging t/db_dependent/Circulation.t
CONFLICT (content): Merge conflict in t/db_dependent/Circulation.t
Auto-merging koha-tmpl/intranet-tmpl/prog/en/modules/members/pay.tt
Auto-merging installer/data/mysql/kohastructure.sql
Auto-merging C4/Overdues.pm
error: Failed to merge in the changes.
Patch failed at 0001 Bug 16461 - Add branch and barcode in accountline table
for overdues

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Nov  7 17:34:17 2017
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 07 Nov 2017 16:34:17 +0000
Subject: [Koha-bugs] [Bug 11210] Allow partial writeoff
In-Reply-To: <bug-11210-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-11210-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-11210-70-UKk7WHK0Lg@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11210

David Bourgault <david.bourgault at inlibro.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Failed QA                   |Needs Signoff

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Nov  7 17:34:20 2017
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 07 Nov 2017 16:34:20 +0000
Subject: [Koha-bugs] [Bug 11210] Allow partial writeoff
In-Reply-To: <bug-11210-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-11210-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-11210-70-xad56gyv0O@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11210

David Bourgault <david.bourgault at inlibro.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #68754|0                           |1
        is obsolete|                            |

--- Comment #7 from David Bourgault <david.bourgault at inlibro.com> ---
Created attachment 69001
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=69001&action=edit
Bug 11210 - Writeoff partial amounts

Minor changes to pay.pl and paycollect.tt to allow writing off a partial amount
of a fine.

Test plan:
0) Go to the Fines tab of a test patron's profile
1) Create a fine if there are none (under the Manual invoice tab)
2) Go to the "Pay fines" tab
3) Press the write off button on the corresponding account line

Without patch, you'll be asked to confirm, but will not be able to edit the
amount
With patch, you'll be able to edit the amount.

Followed test plan, patch worked as described. Also ran QA test tool and
modified files passed

Signed-off-by: Alex Buckley <alexbuckley at catalyst.net.nz>

Signed-off-by: Kyle M Hall <kyle at bywatersolutions.com>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Nov  7 17:35:40 2017
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 07 Nov 2017 16:35:40 +0000
Subject: [Koha-bugs] [Bug 11210] Allow partial writeoff
In-Reply-To: <bug-11210-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-11210-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-11210-70-o4UTWyMUDi@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11210

--- Comment #8 from David Bourgault <david.bourgault at inlibro.com> ---
Removed the formatting on inputs.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Nov  7 17:49:23 2017
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 07 Nov 2017 16:49:23 +0000
Subject: [Koha-bugs] [Bug 5620] Capture Mode of payment
In-Reply-To: <bug-5620-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-5620-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-5620-70-UrMPL0PAow@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5620

David Bourgault <david.bourgault at inlibro.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #67661|0                           |1
        is obsolete|                            |

--- Comment #35 from David Bourgault <david.bourgault at inlibro.com> ---
Created attachment 69002
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=69002&action=edit
Bug 5620 - (Rebase) - Collect payment mode in staff interface

Followed test plan, patch worked as described. Also ran QA test tool
everything passed

Signed-off-by: Alex Buckley <alexbuckley at catalyst.net.nz>

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the QA Contact for the bug.

From bugzilla-daemon at bugs.koha-community.org  Tue Nov  7 17:50:48 2017
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 07 Nov 2017 16:50:48 +0000
Subject: [Koha-bugs] [Bug 5620] Capture Mode of payment
In-Reply-To: <bug-5620-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-5620-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-5620-70-yHNSnYlZNy@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5620

--- Comment #36 from David Bourgault <david.bourgault at inlibro.com> ---
Rebased on master, since patch did not apply. The corrections were trivial so I
will not change the status.

-- 
You are receiving this mail because:
You are the QA Contact for the bug.
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Nov  7 18:07:45 2017
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 07 Nov 2017 17:07:45 +0000
Subject: [Koha-bugs] [Bug 17770] t/db_dependent/ Sitemapper.t fails when
 date changes during test run
In-Reply-To: <bug-17770-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-17770-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-17770-70-1ROMBSfRlZ@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17770

M. Tompsett <mtompset at hotmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |mtompset at hotmail.com
           Assignee|chris at bigballofwax.co.nz    |mtompset at hotmail.com

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Nov  7 18:21:42 2017
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 07 Nov 2017 17:21:42 +0000
Subject: [Koha-bugs] [Bug 19289] Allow configuration of the fields on the
 'Catalog details' form in the acquisition baskets
In-Reply-To: <bug-19289-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-19289-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-19289-70-KLwlKAn9Cs@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19289

--- Comment #8 from Jonathan Druart <jonathan.druart at bugs.koha-community.org> ---
Can you detail please?
This is what I see when I install using "en"/MARC21:
https://screenshots.firefox.com/cJdFOY6Lk1Ves2KK/pro.kohadev.org

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Nov  7 19:18:49 2017
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 07 Nov 2017 18:18:49 +0000
Subject: [Koha-bugs] [Bug 11976] show issue date instead of received date
 for serials in opac
In-Reply-To: <bug-11976-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-11976-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-11976-70-QJNaJCWhRF@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11976

David Bourgault <david.bourgault at inlibro.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Failed QA                   |Signed Off

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Nov  7 19:18:52 2017
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 07 Nov 2017 18:18:52 +0000
Subject: [Koha-bugs] [Bug 11976] show issue date instead of received date
 for serials in opac
In-Reply-To: <bug-11976-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-11976-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-11976-70-bOnuKVrvJO@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11976

David Bourgault <david.bourgault at inlibro.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #68610|0                           |1
        is obsolete|                            |
  Attachment #68611|0                           |1
        is obsolete|                            |
  Attachment #68632|0                           |1
        is obsolete|                            |

--- Comment #20 from David Bourgault <david.bourgault at inlibro.com> ---
Created attachment 69003
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=69003&action=edit
Bug 11976: Counter patch using Column Settings

As per Nick Clemen's suggestion from comment #6,
system preferences may not be the best way.

Using Home->Administration->Column Settings->OPAC->subscriptionst
the fields visibility can be toggled.

TEST PLAN
---------
1) Have a subscription where you have received at least once.
2) Look for it in OPAC and note the date is the received date, not the
publication date
3) Apply patch
4) Log in to staff client
5) Home->Administration->Column Settings->OPAC->subscriptionst
6) Set visibility as desired.
7) Refresh OPAC page
   -- everything should be as expected.
8) run koha qa test tools.

Signed-off-by: David Bourgault <david.bourgault at inlibro.com>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Nov  7 19:18:58 2017
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 07 Nov 2017 18:18:58 +0000
Subject: [Koha-bugs] [Bug 5620] Capture Mode of payment
In-Reply-To: <bug-5620-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-5620-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-5620-70-PvkreLGunx@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5620

Eric B?gin <eric.begin at inLibro.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|remi.mayrand-provencher at inL |
                   |ibro.com                    |

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Nov  7 19:20:28 2017
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 07 Nov 2017 18:20:28 +0000
Subject: [Koha-bugs] [Bug 13990] ILS-DI LookupPatron Requries ID Type
In-Reply-To: <bug-13990-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-13990-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-13990-70-Q2PVyfQArX@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13990

--- Comment #3 from Jon Knight <J.P.Knight at lboro.ac.uk> ---
Created attachment 69004
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=69004&action=edit
Bug 13990 - ILS-DI LookupPatron Requries ID Type

Patch provides a constrained set of borrower attributes to try in turn if the
ID type is not specified.  Also added "email" to the POD documented list of
id types seeing as its quite a useful one for integration developers.

Test plan:

1) without the patch applied, turn on ils-di interface in your admin sysprefs
   and then try accessing the URL:

   https://your-server/cgi-bin/koha/ilsdi.pl?service=LookupPatron&id=Mabel

   replacing "your-server" your Koha dev test domain name (localhost:8080 if
   you're using a kohadevbox VM) and "Mabel" with the first name of a patron
   (Mabel is in the test database already if you're using that).

   You should get back an error message in the XML.

2) Apply the patch and repeat. This time you should get an <id> element in
   the XML with Mabel's patron ID in it.

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Nov  7 19:20:58 2017
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 07 Nov 2017 18:20:58 +0000
Subject: [Koha-bugs] [Bug 11976] show issue date instead of received date
 for serials in opac
In-Reply-To: <bug-11976-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-11976-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-11976-70-TPgg8ihOJ2@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11976

--- Comment #21 from David Bourgault <david.bourgault at inlibro.com> ---
I did not know that was an option.

I modified Mark's patch slightly: the subscriptionst yaml entry did wasn't
under OPAC for me, so I simply moved it down.

Worked as described in test plan otherwise.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Nov  7 19:21:29 2017
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 07 Nov 2017 18:21:29 +0000
Subject: [Koha-bugs] [Bug 13990] ILS-DI LookupPatron Requries ID Type
In-Reply-To: <bug-13990-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-13990-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-13990-70-E0Zqz8Ue12@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13990

Jon Knight <J.P.Knight at lboro.ac.uk> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|In Discussion               |Needs Signoff

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.

From bugzilla-daemon at bugs.koha-community.org  Tue Nov  7 19:29:18 2017
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 07 Nov 2017 18:29:18 +0000
Subject: [Koha-bugs] [Bug 19586] New: Improve budget display
Message-ID: <bug-19586-70@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19586

            Bug ID: 19586
           Summary: Improve budget display
 Change sponsored?: ---
           Product: Koha
           Version: master
          Hardware: All
                OS: All
            Status: NEW
          Severity: enhancement
          Priority: P5 - low
         Component: Acquisitions
          Assignee: koha-bugs at lists.koha-community.org
          Reporter: philippe.blouin at inlibro.com
        QA Contact: testopia at bugs.koha-community.org

Currently, the display of a "huge" (100s of lines) budget can slow down the
process extensively.  It is caused by redundant and recursive calls to build
the budget tree.

I used the followup patch with CCSR to cut the DB calls from 30000 to 5. 
Display idle time went from 30+ seconds to 1.

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.

From bugzilla-daemon at bugs.koha-community.org  Tue Nov  7 19:30:53 2017
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 07 Nov 2017 18:30:53 +0000
Subject: [Koha-bugs] [Bug 19586] Improve budget display
In-Reply-To: <bug-19586-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-19586-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-19586-70-dcm4mGCwnU@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19586

Blou <philippe.blouin at inlibro.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Change sponsored?|---                         |Sponsored
   Patch complexity|---                         |Small patch
             Status|NEW                         |ASSIGNED
           Assignee|koha-bugs at lists.koha-commun |philippe.blouin at inlibro.com
                   |ity.org                     |

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Nov  7 19:33:24 2017
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 07 Nov 2017 18:33:24 +0000
Subject: [Koha-bugs] [Bug 19368] Add syspref to ignore words when sorting
	serials
In-Reply-To: <bug-19368-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-19368-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-19368-70-1NzBbc2Jlc@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19368

David Bourgault <david.bourgault at inlibro.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #67612|0                           |1
        is obsolete|                            |

--- Comment #11 from David Bourgault <david.bourgault at inlibro.com> ---
Created attachment 69005
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=69005&action=edit
Bug 19368 - Syspref now "SortIgnoreArticles", used in datatables.inc

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Nov  7 19:33:22 2017
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 07 Nov 2017 18:33:22 +0000
Subject: [Koha-bugs] [Bug 19368] Add syspref to ignore words when sorting
	serials
In-Reply-To: <bug-19368-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-19368-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-19368-70-HduCLiXrBL@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19368

David Bourgault <david.bourgault at inlibro.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Failed QA                   |Needs Signoff

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Nov  7 19:34:01 2017
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 07 Nov 2017 18:34:01 +0000
Subject: [Koha-bugs] [Bug 19368] Add syspref to ignore words when sorting
	serials
In-Reply-To: <bug-19368-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-19368-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-19368-70-dsHiokkH6u@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19368

--- Comment #12 from David Bourgault <david.bourgault at inlibro.com> ---
Updated incorrect YAML preference file

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Nov  7 20:13:12 2017
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 07 Nov 2017 19:13:12 +0000
Subject: [Koha-bugs] [Bug 7317] Add an Interlibrary Loan Module to
	Circulation and OPAC
In-Reply-To: <bug-7317-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-7317-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-7317-70-eH1cuoC38E@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7317

--- Comment #188 from Tom?s Cohen Arazi <tomascohen at gmail.com> ---
Created attachment 69006
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=69006&action=edit
Bug 7317: (QA followup) Fix capitalization and terminology issues

This patch fixed terminology issues on the UI, and removes CSS-based
case forcing for column names.

Signed-off-by: Tomas Cohen Arazi <tomascohen at theke.io>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Nov  7 20:55:31 2017
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 07 Nov 2017 19:55:31 +0000
Subject: [Koha-bugs] [Bug 19587] New: "Place request with partners" button
 must be hidden if no partern defined
Message-ID: <bug-19587-70@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19587

            Bug ID: 19587
           Summary: "Place request with partners" button must be hidden if
                    no partern defined
 Change sponsored?: ---
           Product: Koha
           Version: unspecified
          Hardware: All
                OS: All
            Status: NEW
          Severity: normal
          Priority: P5 - low
         Component: Architecture, internals, and plumbing
          Assignee: koha-bugs at lists.koha-community.org
          Reporter: jonathan.druart at bugs.koha-community.org
        QA Contact: testopia at bugs.koha-community.org
        Depends on: 7317

This button leads to
/ill/ill-requests.pl?method=generic_confirm&illrequest_id=1

If there are no partners defined this link should not be displayed and the page
not accessible (with friendly message what's happening).


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7317
[Bug 7317] Add an Interlibrary Loan Module to Circulation and OPAC
-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.

From bugzilla-daemon at bugs.koha-community.org  Tue Nov  7 20:55:31 2017
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 07 Nov 2017 19:55:31 +0000
Subject: [Koha-bugs] [Bug 7317] Add an Interlibrary Loan Module to
	Circulation and OPAC
In-Reply-To: <bug-7317-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-7317-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-7317-70-yfgf0hx6s0@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7317

Jonathan Druart <jonathan.druart at bugs.koha-community.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Blocks|                            |19587


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19587
[Bug 19587] "Place request with partners" button must be hidden if no partern
defined
-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Nov  7 20:55:42 2017
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 07 Nov 2017 19:55:42 +0000
Subject: [Koha-bugs] [Bug 19587] "Place request with partners" button must
 be hidden if no partners defined
In-Reply-To: <bug-19587-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-19587-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-19587-70-QjfcGsyeXF@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19587

Jonathan Druart <jonathan.druart at bugs.koha-community.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
            Summary|"Place request with         |"Place request with
                   |partners" button must be    |partners" button must be
                   |hidden if no partern        |hidden if no partners
                   |defined                     |defined

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.

From bugzilla-daemon at bugs.koha-community.org  Tue Nov  7 20:57:51 2017
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 07 Nov 2017 19:57:51 +0000
Subject: [Koha-bugs] [Bug 19588] New: There is no ILL requests history
Message-ID: <bug-19588-70@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19588

            Bug ID: 19588
           Summary: There is no ILL requests history
 Change sponsored?: ---
           Product: Koha
           Version: unspecified
          Hardware: All
                OS: All
            Status: In Discussion
          Severity: normal
          Priority: P5 - low
         Component: Architecture, internals, and plumbing
          Assignee: koha-bugs at lists.koha-community.org
          Reporter: jonathan.druart at bugs.koha-community.org
        QA Contact: testopia at bugs.koha-community.org
            Blocks: 7317

When a request is deleted, the row is removed from illrequests. Is that
expected?


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7317
[Bug 7317] Add an Interlibrary Loan Module to Circulation and OPAC
-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.

From bugzilla-daemon at bugs.koha-community.org  Tue Nov  7 20:57:51 2017
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 07 Nov 2017 19:57:51 +0000
Subject: [Koha-bugs] [Bug 7317] Add an Interlibrary Loan Module to
	Circulation and OPAC
In-Reply-To: <bug-7317-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-7317-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-7317-70-ISygGMzEIo@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7317

Jonathan Druart <jonathan.druart at bugs.koha-community.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
         Depends on|                            |19588


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19588
[Bug 19588] There is no ILL requests history
-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Nov  7 21:00:46 2017
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 07 Nov 2017 20:00:46 +0000
Subject: [Koha-bugs] [Bug 17674] Allow UI to delete serials in batch
In-Reply-To: <bug-17674-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-17674-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-17674-70-aAUukpt3wN@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17674

David Bourgault <david.bourgault at inlibro.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Patch doesn't apply         |Needs Signoff

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Nov  7 21:00:49 2017
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 07 Nov 2017 20:00:49 +0000
Subject: [Koha-bugs] [Bug 17674] Allow UI to delete serials in batch
In-Reply-To: <bug-17674-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-17674-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-17674-70-QWOBNy6jHS@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17674

David Bourgault <david.bourgault at inlibro.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #61314|0                           |1
        is obsolete|                            |

--- Comment #16 from David Bourgault <david.bourgault at inlibro.com> ---
Created attachment 69007
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=69007&action=edit
Bug 17674 - Allow UI to delete serials in batch

This new feature allows for batch deletion of serials through the UI.  The
current usage is a one-by-one long game.

Testing
- Have at least three serials, with items
- check the box to select two of them
- Press the Remove selected issues button
- Decide to delete their items as well or not
- Validate.

Sponsored by : CCSR

Signed-off-by: Sonia BOUIS <sonia.bouis at univ-lyon3.fr>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Nov  7 21:00:50 2017
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 07 Nov 2017 20:00:50 +0000
Subject: [Koha-bugs] [Bug 7317] Add an Interlibrary Loan Module to
	Circulation and OPAC
In-Reply-To: <bug-7317-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-7317-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-7317-70-c3XS8BZXvH@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7317

--- Comment #189 from Jonathan Druart <jonathan.druart at bugs.koha-community.org> ---
Created attachment 69008
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=69008&action=edit
Bug 7317: Add missing 'use Encode' statement

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Nov  7 21:00:58 2017
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 07 Nov 2017 20:00:58 +0000
Subject: [Koha-bugs] [Bug 7317] Add an Interlibrary Loan Module to
	Circulation and OPAC
In-Reply-To: <bug-7317-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-7317-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-7317-70-xITpUqZ1ec@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7317

--- Comment #190 from Jonathan Druart <jonathan.druart at bugs.koha-community.org> ---
Created attachment 69009
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=69009&action=edit
Bug 7317: (QA followup 2) Fix capitalization and terminology issues

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Nov  7 21:00:59 2017
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 07 Nov 2017 20:00:59 +0000
Subject: [Koha-bugs] [Bug 17674] Allow UI to delete serials in batch
In-Reply-To: <bug-17674-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-17674-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-17674-70-unmd9qPym0@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17674

David Bourgault <david.bourgault at inlibro.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #61315|0                           |1
        is obsolete|                            |

--- Comment #17 from David Bourgault <david.bourgault at inlibro.com> ---
Created attachment 69010
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=69010&action=edit
Bug 17674 - Fix problem tabs

Signed-off-by: Sonia BOUIS <sonia.bouis at univ-lyon3.fr>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Nov  7 21:01:04 2017
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 07 Nov 2017 20:01:04 +0000
Subject: [Koha-bugs] [Bug 17674] Allow UI to delete serials in batch
In-Reply-To: <bug-17674-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-17674-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-17674-70-lvKrh2SZRu@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17674

David Bourgault <david.bourgault at inlibro.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #61316|0                           |1
        is obsolete|                            |

--- Comment #18 from David Bourgault <david.bourgault at inlibro.com> ---
Created attachment 69011
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=69011&action=edit
Bug 17674 - Add unit tests

https://bugs.koha-community.org/show_bug.cgi?id=17674

Signed-off-by: Sonia BOUIS <sonia.bouis at univ-lyon3.fr>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Nov  7 21:01:05 2017
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 07 Nov 2017 20:01:05 +0000
Subject: [Koha-bugs] [Bug 7317] Add an Interlibrary Loan Module to
	Circulation and OPAC
In-Reply-To: <bug-7317-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-7317-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-7317-70-jeB8ycSceD@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7317

--- Comment #191 from Jonathan Druart <jonathan.druart at bugs.koha-community.org> ---
Created attachment 69012
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=69012&action=edit
Bug 7317: use preventDefault to prevent the scrollbar to move to the top

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Nov  7 21:01:09 2017
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 07 Nov 2017 20:01:09 +0000
Subject: [Koha-bugs] [Bug 17674] Allow UI to delete serials in batch
In-Reply-To: <bug-17674-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-17674-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-17674-70-3ZIR8stmJk@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17674

David Bourgault <david.bourgault at inlibro.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #66565|0                           |1
        is obsolete|                            |

--- Comment #19 from David Bourgault <david.bourgault at inlibro.com> ---
Created attachment 69013
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=69013&action=edit
Bug 17674 - Move subroutine GetSerialItemsInformations to Koha/Serials.pm

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Nov  7 21:44:19 2017
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 07 Nov 2017 20:44:19 +0000
Subject: [Koha-bugs] [Bug 7317] Add an Interlibrary Loan Module to
	Circulation and OPAC
In-Reply-To: <bug-7317-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-7317-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-7317-70-8SoHUbPCVP@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7317

--- Comment #192 from Jonathan Druart <jonathan.druart at bugs.koha-community.org> ---
Created attachment 69014
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=69014&action=edit
Bug 7317: Fix more translation issues

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Nov  7 21:45:28 2017
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 07 Nov 2017 20:45:28 +0000
Subject: [Koha-bugs] [Bug 7317] Add an Interlibrary Loan Module to
	Circulation and OPAC
In-Reply-To: <bug-7317-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-7317-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-7317-70-AqF3JoAIo0@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7317

--- Comment #193 from Jonathan Druart <jonathan.druart at bugs.koha-community.org> ---
Some more:

1. This looks wrong
260     here_link  => "/cgi-bin/koha/ill/ill-requests.pl"

url should be in template I'd say

2. This is not used, you are using an ajax call
219     } elsif ( $op eq 'illlist') {
220         # Display all current ILLs                                          
221         my $requests = $illRequests->search();
222     
223         $template->param(                                                   
224             requests => $requests                                           
225         );

3. 257     media      => [ "Book", "Article", "Journal" ],
Is this used?

4.
Config.pm
312     die "No DEFAULT_FORMATS has been defined in koha-conf.xml, but
UNMEDIATEDILL is active."
313         if ( $unmediated && !$configuration->{default_formats}->{default}
);

Not used yet, please remove

5. 794                 \"YEAR(placed) = YEAR(NOW())"
This looks like a mysqlism

6. The branchcode is displayed instead of the branchname in the list of ILL
requests. Sounds easy to fix as we embed "branch" (must be library?)

7. api/v1/swagger/paths/*.json
  "name": "branchcode"
vs
  "name": "branch_id"
same with
  borrowernumber vs borrower_id
and
  biblionumber vs biblio_id

(to be continued...)

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Nov  7 21:45:40 2017
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 07 Nov 2017 20:45:40 +0000
Subject: [Koha-bugs] [Bug 7317] Add an Interlibrary Loan Module to
	Circulation and OPAC
In-Reply-To: <bug-7317-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-7317-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-7317-70-jD8rMcVLQW@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7317

Jonathan Druart <jonathan.druart at bugs.koha-community.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Passed QA                   |Failed QA

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Nov  8 00:45:54 2017
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 07 Nov 2017 23:45:54 +0000
Subject: [Koha-bugs] [Bug 19589] New: DESTDIR environment variable ignored
 on "make install"
Message-ID: <bug-19589-70@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19589

            Bug ID: 19589
           Summary: DESTDIR environment variable ignored on "make install"
 Change sponsored?: ---
           Product: Koha
           Version: 17.05
          Hardware: All
                OS: All
            Status: NEW
          Severity: minor
          Priority: P5 - low
         Component: Installation and upgrade (command-line installer)
          Assignee: koha-bugs at lists.koha-community.org
          Reporter: int at arcor.de
        QA Contact: testopia at bugs.koha-community.org

(In koha-17.05.03/) when calling 
> DESTDIR=fancydir make install
the DESTDIR from the command-line is ignored and 
the empty one from Makefile is used. 
In Makefile the following line can be found
> DESTDIR = 
If this line is deleted, the DESTDIR from the command-line is used as expected.
(But I don't know if this is a good idea to do, beside that Makefile is
generated.)

This behaviour is bad for package-building of koha.


Steps to reproduce:

Just follow the normal install procedure (as normal user):
> perl Makefile.PL --install_base /usr/share/koha --install_mode standard ...
> make
> DESTDIR=fancydir make install
The following error should occur:
> ERROR: Can't create '/etc/koha'
> mkdir /etc/koha: Permission denied at ...
Expected is that everything is installed below $DESTDIR/, 
e.g. $DESTDIR/etc/koha, and not root.

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.

From bugzilla-daemon at bugs.koha-community.org  Wed Nov  8 00:50:36 2017
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 07 Nov 2017 23:50:36 +0000
Subject: [Koha-bugs] [Bug 17602] Integrate support for
	OneClickdigital/Recorded Books API
In-Reply-To: <bug-17602-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-17602-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-17602-70-sawud4X2Th@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17602

Srdjan Jankovic <srdjan at catalyst.net.nz> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #67860|0                           |1
        is obsolete|                            |

--- Comment #50 from Srdjan Jankovic <srdjan at catalyst.net.nz> ---
Comment on attachment 67860
  --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=67860
t/Koha_ExternalContent_OverDrive.t correction

Obsoleted by 18851

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Nov  8 00:53:16 2017
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 07 Nov 2017 23:53:16 +0000
Subject: [Koha-bugs] [Bug 17602] Integrate support for
	OneClickdigital/Recorded Books API
In-Reply-To: <bug-17602-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-17602-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-17602-70-NQRJyWQlEQ@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17602

--- Comment #51 from Srdjan Jankovic <srdjan at catalyst.net.nz> ---
(In reply to Jonathan Druart from comment #48)

> _("Found %s results in the library's RecordedBooks
> collection.").format(data.total)
> 
> But it was a not for myself.

Did not know how we store translatables. Want me to change it?

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Nov  8 08:47:25 2017
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 08 Nov 2017 07:47:25 +0000
Subject: [Koha-bugs] [Bug 10662] Build OAI-PMH Harvesting Client
In-Reply-To: <bug-10662-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-10662-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-10662-70-zNz7uieKBN@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10662

Ola Andersson <ola.andersson at ltu.se> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |ola.andersson at ltu.se

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Nov  8 09:10:20 2017
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 08 Nov 2017 08:10:20 +0000
Subject: [Koha-bugs] [Bug 18096] BnF Authorities Z39.50 search and access
In-Reply-To: <bug-18096-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-18096-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-18096-70-uumK3v3Sur@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18096

Fridolin SOMERS <fridolin.somers at biblibre.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
           See Also|                            |https://bugs.koha-community
                   |                            |.org/bugzilla3/show_bug.cgi
                   |                            |?id=19436

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Nov  8 09:10:20 2017
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 08 Nov 2017 08:10:20 +0000
Subject: [Koha-bugs] [Bug 19436] Add SRU support for authorities
In-Reply-To: <bug-19436-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-19436-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-19436-70-VYeACs2eWb@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19436

Fridolin SOMERS <fridolin.somers at biblibre.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
           See Also|                            |https://bugs.koha-community
                   |                            |.org/bugzilla3/show_bug.cgi
                   |                            |?id=18096

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.

From bugzilla-daemon at bugs.koha-community.org  Wed Nov  8 09:22:00 2017
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 08 Nov 2017 08:22:00 +0000
Subject: [Koha-bugs] [Bug 18956] Possible privacy breach with OPAC password
	recovery
In-Reply-To: <bug-18956-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-18956-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-18956-70-XFWaaT1HTU@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18956

Fridolin SOMERS <fridolin.somers at biblibre.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Pushed to Master            |Pushed to Stable

--- Comment #27 from Fridolin SOMERS <fridolin.somers at biblibre.com> ---
These patches have been pushed to 17.05.x and are in 17.05.05.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Nov  8 09:22:10 2017
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 08 Nov 2017 08:22:10 +0000
Subject: [Koha-bugs] [Bug 19117] paycollect.pl is vulnerable for CSRF attacks
In-Reply-To: <bug-19117-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-19117-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-19117-70-Oiq5uSmGWg@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19117

Fridolin SOMERS <fridolin.somers at biblibre.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |fridolin.somers at biblibre.co
                   |                            |m
             Status|Pushed to Master            |Pushed to Stable

--- Comment #11 from Fridolin SOMERS <fridolin.somers at biblibre.com> ---
These patches have been pushed to 17.05.x and are in 17.05.05.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Nov  8 09:22:14 2017
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 08 Nov 2017 08:22:14 +0000
Subject: [Koha-bugs] [Bug 19333] XSS vulnerability in opac-shelves
In-Reply-To: <bug-19333-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-19333-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-19333-70-f4RVyDiKAW@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19333

Fridolin SOMERS <fridolin.somers at biblibre.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Pushed to Master            |Pushed to Stable
                 CC|                            |fridolin.somers at biblibre.co
                   |                            |m

--- Comment #10 from Fridolin SOMERS <fridolin.somers at biblibre.com> ---
These patches have been pushed to 17.05.x and are in 17.05.05.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Nov  8 10:18:55 2017
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 08 Nov 2017 09:18:55 +0000
Subject: [Koha-bugs] [Bug 19289] Allow configuration of the fields on the
 'Catalog details' form in the acquisition baskets
In-Reply-To: <bug-19289-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-19289-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-19289-70-rr71wNncvj@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19289

--- Comment #9 from S?verine Queune <severine.queune at bulac.fr> ---
Created attachment 69015
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=69015&action=edit
Add to basket from new empty recvord

I worked on Biblibre's sandbox #2 and modified the ACQ framework to get the
structure we want to use, but I couldn?t found where the "9 (RLIN)" fields that
I see when I add an order from a new empty record come from.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Nov  8 10:21:54 2017
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 08 Nov 2017 09:21:54 +0000
Subject: [Koha-bugs] [Bug 19289] Allow configuration of the fields on the
 'Catalog details' form in the acquisition baskets
In-Reply-To: <bug-19289-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-19289-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-19289-70-7flD0eTiRX@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19289

--- Comment #10 from S?verine Queune <severine.queune at bulac.fr> ---
Created attachment 69016
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=69016&action=edit
ACQ framework -  Display only used tags/subfields

Here is the ACQ framework structure with only the used subfields and as you can
see, there is no informations about "9 (RLIN)" fields.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Nov  8 10:22:29 2017
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 08 Nov 2017 09:22:29 +0000
Subject: [Koha-bugs] [Bug 19590] New: doc of Clean Patron Records tool wrong
 about deletion scope + anonymization syspref
Message-ID: <bug-19590-70@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19590

            Bug ID: 19590
           Summary: doc of Clean Patron Records tool wrong about deletion
                    scope + anonymization syspref
 Change sponsored?: ---
           Product: Koha
           Version: master
          Hardware: All
                OS: All
            Status: NEW
          Severity: enhancement
          Priority: P5 - low
         Component: Documentation
          Assignee: koha-bugs at lists.koha-community.org
          Reporter: victor.grousset at biblibre.com
        QA Contact: testopia at bugs.koha-community.org

Hi, I think I've found a documentation issue in the "Clean Patron Records"
tool. 

Both the in-app + online doc [1] mention that:

?patrons with outstanding fines or items checked out not saved? (the rest of
the doc confirms that we are talking about removal) ? wrong, see [2][3]

?The anonymization will fail quietly if AnonymousPatron preference does not
contain a valid value.? ? wrong, according to the UI itself ?The
AnonymousPatron system preference is not  defined. You can use this feature
anyway but NULL will be used to  update the checkout history.?

Are these two findings correct?

[1]
https://koha-community.org/manual/17.05/html/03_tools.html#patrons-anonymize-bulk-delete
[2] excludes patrons with checked out item
https://github.com/Koha-Community/Koha/blob/master/C4/Members.pm#L1040
[3] excludes patrons with unpaid fines
https://github.com/Koha-Community/Koha/blob/master/tools/cleanborrowers.pl#L142

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Nov  8 10:29:32 2017
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 08 Nov 2017 09:29:32 +0000
Subject: [Koha-bugs] [Bug 19591] New: Saving a system preference jumps to
	main page
Message-ID: <bug-19591-70@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19591

            Bug ID: 19591
           Summary: Saving a system preference jumps to main page
 Change sponsored?: ---
           Product: Koha
           Version: 16.11
          Hardware: All
                OS: All
            Status: NEW
          Severity: enhancement
          Priority: P5 - low
         Component: System Administration
          Assignee: koha-bugs at lists.koha-community.org
          Reporter: christian.stelzenmueller at bsz-bw.de
        QA Contact: testopia at bugs.koha-community.org
                CC: gmcharlt at gmail.com

I don't know if this was intended or not.

When saving a system preference, it jumps to the main page of the category,
instead of staying on the searched system preference, like in 3.22.

Test:
1. Search a system preference, i. e. Opaccredits.
2. Change something.
3. Save it.
4. It jumps to the "category subpage" on the left side.

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.

From bugzilla-daemon at bugs.koha-community.org  Wed Nov  8 10:38:05 2017
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 08 Nov 2017 09:38:05 +0000
Subject: [Koha-bugs] [Bug 15142] Titles facet does not work in UNIMARC
In-Reply-To: <bug-15142-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-15142-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-15142-70-MPNVUmc9c8@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15142

Andreas Roussos <arouss1980 at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |arouss1980 at gmail.com

--- Comment #3 from Andreas Roussos <arouss1980 at gmail.com> ---
The Titles facet still doesn't work for UNIMARC installations (I've tested
versions 16.05.16 and 17.05.05).

We fixed this by changing the zebra index name to 'Subject,Subject:p'.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Nov  8 11:55:36 2017
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 08 Nov 2017 10:55:36 +0000
Subject: [Koha-bugs] [Bug 18316] Add weighting/relevancy options to
	ElasticSearch
In-Reply-To: <bug-18316-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-18316-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-18316-70-H57vgT60kF@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18316

S?verine Queune <severine.queune at bulac.fr> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |severine.queune at bulac.fr

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Nov  8 12:35:12 2017
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 08 Nov 2017 11:35:12 +0000
Subject: [Koha-bugs] [Bug 11999] Add two checks in CanBookBeReserved and
 CanItemBeReserved
In-Reply-To: <bug-11999-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-11999-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-11999-70-KaL3m0l6hn@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11999

--- Comment #59 from Fridolin SOMERS <fridolin.somers at biblibre.com> ---
Looks like CanBookBeReserved may be called with undef biblionumber : when at
intranet clicking on holds tab of a record.
This generates error :
  Can't call method "holds" on an undefined value

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Nov  8 13:04:14 2017
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 08 Nov 2017 12:04:14 +0000
Subject: [Koha-bugs] [Bug 11999] Add two checks in CanBookBeReserved and
 CanItemBeReserved
In-Reply-To: <bug-11999-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-11999-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-11999-70-ye5cdwpV0I@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11999

Fridolin SOMERS <fridolin.somers at biblibre.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
         Depends on|                            |17740


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17740
[Bug 17740] Add the Koha::Patron->holds method
-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Nov  8 13:04:14 2017
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 08 Nov 2017 12:04:14 +0000
Subject: [Koha-bugs] [Bug 17740] Add the Koha::Patron->holds method
In-Reply-To: <bug-17740-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-17740-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-17740-70-bvWPPY3qUS@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17740

Fridolin SOMERS <fridolin.somers at biblibre.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Blocks|                            |11999


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11999
[Bug 11999] Add two checks in CanBookBeReserved and CanItemBeReserved
-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Nov  8 13:32:31 2017
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 08 Nov 2017 12:32:31 +0000
Subject: [Koha-bugs] [Bug 19289] Allow configuration of the fields on the
 'Catalog details' form in the acquisition baskets
In-Reply-To: <bug-19289-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-19289-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-19289-70-uOPZmNLtSm@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19289

--- Comment #11 from Jonathan Druart <jonathan.druart at bugs.koha-community.org> ---
Hi S?verine, I have created the correct ACQ framework only for:

en/marcflavour/marc21/mandatory/marc21_framework_DEFAULT.sql
fr-FR/marcflavour/unimarc_complet/Obligatoire/framework_DEFAULT.sql

When you setup the sandbox, tick "No database (run webinstaller)" to use the
files used from the Koha codebase and not the database created for the sandbox.

Otherwise you can remove the subfield (@) from 009.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Nov  8 13:39:37 2017
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 08 Nov 2017 12:39:37 +0000
Subject: [Koha-bugs] [Bug 11999] Add two checks in CanBookBeReserved and
 CanItemBeReserved
In-Reply-To: <bug-11999-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-11999-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-11999-70-D3WVBMytvl@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11999

--- Comment #60 from Fridolin SOMERS <fridolin.somers at biblibre.com> ---
(In reply to Fridolin SOMERS from comment #59)
> Looks like CanBookBeReserved may be called with undef biblionumber : when at
> intranet clicking on holds tab of a record.
> This generates error :
>   Can't call method "holds" on an undefined value

Ok in master, CanBookBeReserved is not called if no borrower.
Sorry

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Nov  8 14:12:27 2017
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 08 Nov 2017 13:12:27 +0000
Subject: [Koha-bugs] [Bug 19584] Inventory: working title
In-Reply-To: <bug-19584-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-19584-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-19584-70-m2GWYMDYkz@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19584

Marcel de Rooy <m.de.rooy at rijksmuseum.nl> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
   Patch complexity|---                         |Trivial patch
             Status|ASSIGNED                    |Needs Signoff

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Nov  8 14:12:29 2017
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 08 Nov 2017 13:12:29 +0000
Subject: [Koha-bugs] [Bug 19584] Inventory: working title
In-Reply-To: <bug-19584-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-19584-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-19584-70-gSoWemdOxR@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19584

Marcel de Rooy <m.de.rooy at rijksmuseum.nl> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #68997|0                           |1
        is obsolete|                            |

--- Comment #2 from Marcel de Rooy <m.de.rooy at rijksmuseum.nl> ---
Created attachment 69017
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=69017&action=edit
Bug 19584: Replace label Status by Not for loan

Status does not tell me that this is the Not for loan column.
Trivial edit.

Signed-off-by: Marcel de Rooy <m.de.rooy at rijksmuseum.nl>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Nov  8 14:12:33 2017
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 08 Nov 2017 13:12:33 +0000
Subject: [Koha-bugs] [Bug 19584] Inventory: working title
In-Reply-To: <bug-19584-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-19584-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-19584-70-EpkNf3RIWM@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19584

--- Comment #3 from Marcel de Rooy <m.de.rooy at rijksmuseum.nl> ---
Created attachment 69018
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=69018&action=edit
Bug 19584: Check compare barcodes box when uploading barcodes

This patch makes two trivial changes in the inventory interface:

[1] If you have uploaded a barcode file, the compare barcodes checkbox is
automatically checked. In most cases this will be the option the user wants.
The compare will report missed items on the shelf.
[2] If the compare barcodes checkbox is checked, the Skip items on loan-
checkbox is automatically checked. This again is often desirable. If you
compare, you normally are not interested in seeing items reported missing
while they are checked out.

Test plan:
[1] Upload a barcode file on inventory. Is the compare checked?
[2] Toggle compare. Does 'skip items on loan' change accordingly?

Signed-off-by: Marcel de Rooy <m.de.rooy at rijksmuseum.nl>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Nov  8 14:13:39 2017
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 08 Nov 2017 13:13:39 +0000
Subject: [Koha-bugs] [Bug 19584] Inventory: Trivial interface improvements
In-Reply-To: <bug-19584-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-19584-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-19584-70-oCL6hIOOrA@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19584

Marcel de Rooy <m.de.rooy at rijksmuseum.nl> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
            Summary|Inventory: working title    |Inventory: Trivial
                   |                            |interface improvements

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Nov  8 14:22:21 2017
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 08 Nov 2017 13:22:21 +0000
Subject: [Koha-bugs] [Bug 17602] Integrate support for
	OneClickdigital/Recorded Books API
In-Reply-To: <bug-17602-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-17602-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-17602-70-oJUCDSU8FR@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17602

--- Comment #53 from Jonathan Druart <jonathan.druart at bugs.koha-community.org> ---
Created attachment 69020
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=69020&action=edit
Bug 17602: RecordedBooks Integration to Koha

This patch introduces the required sysprefs and
Koha::ExternalContent::RecordedBooks

Koha::ExternalContent::RecordedBooks - a wrapper around
WebService::ILS::RecordedBooks::PartnerPatron

RecordedBooks* sysprefs

Nothing functional to test with this patch yet.
But you can run the tests that come with it

 t/db_dependent/Koha_ExternalContent_RecordedBooks.t

Signed-off-by: Nick Clemens <nick at bywatersolutions.com>
Signed-off-by: Tomas Cohen Arazi <tomascohen at theke.io>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Nov  8 14:22:26 2017
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 08 Nov 2017 13:22:26 +0000
Subject: [Koha-bugs] [Bug 17602] Integrate support for
	OneClickdigital/Recorded Books API
In-Reply-To: <bug-17602-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-17602-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-17602-70-qUPsvuzMaM@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17602

--- Comment #54 from Jonathan Druart <jonathan.druart at bugs.koha-community.org> ---
Created attachment 69021
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=69021&action=edit
Bug 17602: OPAC integration of RecordedBooks

Add RecordedBooks to the users page in the public interface

To Test:
1/ Apply all 3 patches
2/ Set the sysprefs to valid values (you will need a test account with
RecordedBooks)
3/ Try a search
4/ Login to the OPAC, try to place a hold, or check an item out
5/ Check the opac-user page, see if your items are showing on the
oneclickdigital tab

Signed-off-by: Nick Clemens <nick at bywatersolutions.com>
Signed-off-by: Tomas Cohen Arazi <tomascohen at theke.io>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Nov  8 14:22:15 2017
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 08 Nov 2017 13:22:15 +0000
Subject: [Koha-bugs] [Bug 17602] Integrate support for
	OneClickdigital/Recorded Books API
In-Reply-To: <bug-17602-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-17602-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-17602-70-4X1iUaAxba@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17602

Jonathan Druart <jonathan.druart at bugs.koha-community.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #67237|0                           |1
        is obsolete|                            |
  Attachment #67238|0                           |1
        is obsolete|                            |
  Attachment #67240|0                           |1
        is obsolete|                            |
  Attachment #67859|0                           |1
        is obsolete|                            |

--- Comment #52 from Jonathan Druart <jonathan.druart at bugs.koha-community.org> ---
Created attachment 69019
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=69019&action=edit
Bug 17602: Koha::ExternalContent->koha_patron() will retutn undef rather than
die if user not logged in

Signed-off-by: Nick Clemens <nick at bywatersolutions.com>
Signed-off-by: Tomas Cohen Arazi <tomascohen at theke.io>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Nov  8 14:22:29 2017
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 08 Nov 2017 13:22:29 +0000
Subject: [Koha-bugs] [Bug 17602] Integrate support for
	OneClickdigital/Recorded Books API
In-Reply-To: <bug-17602-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-17602-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-17602-70-TUjVWlNnzq@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17602

--- Comment #55 from Jonathan Druart <jonathan.druart at bugs.koha-community.org> ---
Created attachment 69022
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=69022&action=edit
Bug 17602 follow-up: t/Koha_ExternalContent_RecordedBooks.t

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Nov  8 14:22:35 2017
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 08 Nov 2017 13:22:35 +0000
Subject: [Koha-bugs] [Bug 17602] Integrate support for
	OneClickdigital/Recorded Books API
In-Reply-To: <bug-17602-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-17602-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-17602-70-CsBnZLXzPf@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17602

--- Comment #56 from Jonathan Druart <jonathan.druart at bugs.koha-community.org> ---
Created attachment 69023
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=69023&action=edit
Bug 17602: Update opac.css

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Nov  8 14:22:39 2017
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 08 Nov 2017 13:22:39 +0000
Subject: [Koha-bugs] [Bug 17602] Integrate support for
	OneClickdigital/Recorded Books API
In-Reply-To: <bug-17602-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-17602-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-17602-70-pIrTqack4O@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17602

--- Comment #57 from Jonathan Druart <jonathan.druart at bugs.koha-community.org> ---
Created attachment 69024
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=69024&action=edit
Bug 17602: Ease translation

Use String.format() to make translation easier

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Nov  8 14:22:42 2017
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 08 Nov 2017 13:22:42 +0000
Subject: [Koha-bugs] [Bug 17602] Integrate support for
	OneClickdigital/Recorded Books API
In-Reply-To: <bug-17602-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-17602-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-17602-70-6TtGab7Hpx@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17602

--- Comment #58 from Jonathan Druart <jonathan.druart at bugs.koha-community.org> ---
Created attachment 69025
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=69025&action=edit
Bug 17602: Handle '60+' if there are more than 60 results

The service returns "60+" if there are more than 60 results.
Without this patch the "Found %s results in RecordedBooks collection"
line is removed.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Nov  8 14:22:46 2017
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 08 Nov 2017 13:22:46 +0000
Subject: [Koha-bugs] [Bug 17602] Integrate support for
	OneClickdigital/Recorded Books API
In-Reply-To: <bug-17602-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-17602-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-17602-70-t8QVDMYlal@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17602

--- Comment #59 from Jonathan Druart <jonathan.druart at bugs.koha-community.org> ---
Created attachment 69026
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=69026&action=edit
Bug 17602: Adapt test plan to make the tests pass

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Nov  8 14:22:50 2017
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 08 Nov 2017 13:22:50 +0000
Subject: [Koha-bugs] [Bug 17602] Integrate support for
	OneClickdigital/Recorded Books API
In-Reply-To: <bug-17602-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-17602-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-17602-70-2zKEg8wExw@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17602

--- Comment #60 from Jonathan Druart <jonathan.druart at bugs.koha-community.org> ---
Created attachment 69027
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=69027&action=edit
Bug 17602: Fix few minor QA issues

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Nov  8 14:23:07 2017
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 08 Nov 2017 13:23:07 +0000
Subject: [Koha-bugs] [Bug 19585] working title
In-Reply-To: <bug-19585-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-19585-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-19585-70-Eiwarddng5@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19585

Marcel de Rooy <m.de.rooy at rijksmuseum.nl> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
            Summary|Inventory: working title 2  |working title

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Nov  8 14:47:11 2017
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 08 Nov 2017 13:47:11 +0000
Subject: [Koha-bugs] [Bug 17602] Integrate support for
	OneClickdigital/Recorded Books API
In-Reply-To: <bug-17602-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-17602-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-17602-70-7LLpUkLryx@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17602

Jonathan Druart <jonathan.druart at bugs.koha-community.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Passed QA                   |Failed QA

--- Comment #61 from Jonathan Druart <jonathan.druart at bugs.koha-community.org> ---
Some additional remarks:
1. At some point I got the following error:
{"error":"Checkout item already exists"}Status: 200 OK
Pragma: no-cache
X-frame-options: SAMEORIGIN
Cache-control: no-cache
Content-Type: application/json; charset=UTF-8

{"action":null,"is_identified":true,"error":"ARRAY(0xbb2fe50)"}

When I clicked several time on the "checkout" button.
I think we should hide them or add a spinner to tell the user something is
going on.

2. Strings from .js files are not translatable, `git grep MSG_` to know how to
make them translatable.

3. I see code related to pagination, but I do not see the previous/next
buttons. I only see the OPACnumSearchResults first results.

And a question:
Koha/ExternalContent/RecordedBooks.pm
 76                 user_agent_params => { agent => $class->agent_string }
Where is this used?

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Nov  8 14:55:31 2017
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 08 Nov 2017 13:55:31 +0000
Subject: [Koha-bugs] [Bug 14830] anonymous purchase suggestions are
 invisible/ inaccessible in staff interface
In-Reply-To: <bug-14830-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-14830-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-14830-70-XrvDnHRYic@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14830

Marjorie Barry-Vila <marjorie.barry-vila at collecto.ca> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |marjorie.barry-vila at collect
                   |                            |o.ca

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Nov  8 14:58:35 2017
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 08 Nov 2017 13:58:35 +0000
Subject: [Koha-bugs] [Bug 14839] 'anonymous' purchase suggestions are
 created with 'Anon' user' s branchcode ignored, (NULL branchcode)
In-Reply-To: <bug-14839-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-14839-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-14839-70-UQbk4zCFyH@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14839

Marjorie Barry-Vila <marjorie.barry-vila at collecto.ca> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |marjorie.barry-vila at collect
                   |                            |o.ca

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Nov  8 14:59:14 2017
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 08 Nov 2017 13:59:14 +0000
Subject: [Koha-bugs] [Bug 11526] search word hilighting does not handle
 multi-word phrases well
In-Reply-To: <bug-11526-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-11526-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-11526-70-4R8TP5Wfdt@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11526

Gaetan Boisson <gaetan.boisson at biblibre.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
         Resolution|---                         |DUPLICATE
             Status|NEW                         |RESOLVED
                 CC|                            |gaetan.boisson at biblibre.com

--- Comment #1 from Gaetan Boisson <gaetan.boisson at biblibre.com> ---


*** This bug has been marked as a duplicate of bug 10779 ***

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Nov  8 14:59:14 2017
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 08 Nov 2017 13:59:14 +0000
Subject: [Koha-bugs] [Bug 10779] Keyword Highlighting highlights partial
	words
In-Reply-To: <bug-10779-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-10779-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-10779-70-9FaZSyCi7J@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10779

Gaetan Boisson <gaetan.boisson at biblibre.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |pasi.kallinen at pttk.fi

--- Comment #1 from Gaetan Boisson <gaetan.boisson at biblibre.com> ---
*** Bug 11526 has been marked as a duplicate of this bug. ***

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Nov  8 15:28:40 2017
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 08 Nov 2017 14:28:40 +0000
Subject: [Koha-bugs] [Bug 11879] Add a new borrower field : main contact
	method.
In-Reply-To: <bug-11879-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-11879-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-11879-70-HTwHZvuqj9@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11879

David Bourgault <david.bourgault at inlibro.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #65811|0                           |1
        is obsolete|                            |

--- Comment #92 from David Bourgault <david.bourgault at inlibro.com> ---
Created attachment 69028
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=69028&action=edit
Bug 11879: Add the "Main contact method" field in borrower informations.

This patch adds the "Main Contact Method" field in the borrower modification
form.

This field is useful for reporting purposes, or to know which contact method to
use first when trying to contact a borrower.

Following Nicolas' fix, removed a $branch variable from patch, since it has
been suppressed in Bug 17284.

Test case :
* Edit a borrower's informations. The "Main Contact Method" selectbox should
appear in the form and its value should be saved correctly.

Sponsored-by: CCSR <http://www.ccsr.qc.ca>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Nov  8 15:29:00 2017
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 08 Nov 2017 14:29:00 +0000
Subject: [Koha-bugs] [Bug 11879] Add a new borrower field : main contact
	method.
In-Reply-To: <bug-11879-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-11879-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-11879-70-FPc9dR4gyZ@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11879

David Bourgault <david.bourgault at inlibro.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #65812|0                           |1
        is obsolete|                            |

--- Comment #93 from David Bourgault <david.bourgault at inlibro.com> ---
Created attachment 69029
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=69029&action=edit
Bug 11879: Changes to Koha's schemas

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Nov  8 15:32:29 2017
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 08 Nov 2017 14:32:29 +0000
Subject: [Koha-bugs] [Bug 11879] Add a new borrower field : main contact
	method.
In-Reply-To: <bug-11879-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-11879-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-11879-70-lRM84UKuCC@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11879

David Bourgault <david.bourgault at inlibro.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |david.bourgault at inlibro.com
             Status|Patch doesn't apply         |Needs Signoff

--- Comment #94 from David Bourgault <david.bourgault at inlibro.com> ---
Rebased patches.

Test plan is same as before:
0) Apply patch
1) updatedatabase.pl
2) In the staff client, edit a patron's contact info. There should be a new
dropdown select to choose the main contact method
3) Save the form. The selected field should appear in the patron's detail page.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Nov  8 15:49:21 2017
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 08 Nov 2017 14:49:21 +0000
Subject: [Koha-bugs] [Bug 18645] Creation of Koha feature release change
 tool displayed after running Koha update
In-Reply-To: <bug-18645-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-18645-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-18645-70-99vEIyQhCJ@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18645

Marjorie Barry-Vila <marjorie.barry-vila at collecto.ca> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |marjorie.barry-vila at collect
                   |                            |o.ca

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Nov  8 16:18:43 2017
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 08 Nov 2017 15:18:43 +0000
Subject: [Koha-bugs] [Bug 19592] New: Move admin templates JavaScript to the
 footer: Acquisitions
Message-ID: <bug-19592-70@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19592

            Bug ID: 19592
           Summary: Move admin templates JavaScript to the footer:
                    Acquisitions
 Change sponsored?: ---
           Product: Koha
           Version: master
          Hardware: All
                OS: All
            Status: ASSIGNED
          Severity: enhancement
          Priority: P5 - low
         Component: Templates
          Assignee: oleonard at myacpl.org
          Reporter: oleonard at myacpl.org
        QA Contact: testopia at bugs.koha-community.org
                CC: jonathan.druart at bugs.koha-community.org,
                    nick at bywatersolutions.com,
                    testopia at bugs.koha-community.org
            Blocks: 17858

In order to conform to best practices for performance staff client template
javascript should be in the footer instead of the header. This patch will do so
for the acquisitions-related administration templates.


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17858
[Bug 17858] Omnibus: Move staff client JavaScript to the footer
-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Nov  8 16:18:43 2017
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 08 Nov 2017 15:18:43 +0000
Subject: [Koha-bugs] [Bug 17858] Omnibus: Move staff client JavaScript to
	the footer
In-Reply-To: <bug-17858-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-17858-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-17858-70-64pYlcDCph@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17858

Owen Leonard <oleonard at myacpl.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
         Depends on|                            |19592


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19592
[Bug 19592] Move admin templates JavaScript to the footer: Acquisitions
-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Nov  8 16:19:43 2017
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 08 Nov 2017 15:19:43 +0000
Subject: [Koha-bugs] [Bug 19562] Inventory: How can we skip convolutes
 marked as problematic with no_barcode?
In-Reply-To: <bug-19562-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-19562-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-19562-70-P9Db19JB9j@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19562

Marcel de Rooy <m.de.rooy at rijksmuseum.nl> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
   Patch complexity|---                         |Trivial patch
             Status|NEW                         |Needs Signoff

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Nov  8 16:19:45 2017
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 08 Nov 2017 15:19:45 +0000
Subject: [Koha-bugs] [Bug 19562] Inventory: How can we skip convolutes
 marked as problematic with no_barcode?
In-Reply-To: <bug-19562-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-19562-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-19562-70-mNGoGWfMEq@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19562

--- Comment #2 from Marcel de Rooy <m.de.rooy at rijksmuseum.nl> ---
Created attachment 69030
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=69030&action=edit
Bug 19562: Do not mark convolute items without barcode as problematic

Convolute items are bound together (belong to different biblio records)
and only one item has a barcode. All items are marked with a phrase like
Convolute (see regex below) in itemnotes.

This patch skips the convolute items without barcode and does not mark
them as problematic during inventory when the item notes contain the phrase.
The regex used is:
    $item->{itemnotes} =~ /convoluu?t/i;

This regex will cover at least the following languages:
Danish, Dutch, English, Finnish, French, Italian, Norwegian,
Portuguese, Spanish, Swedish and probably other languages too. And can
be easily extended if needed.

Note: Since the item hash does not contain itemnotes, we need to call
Koha::Items->find. We will only do so when the item does not have a
barcode.

Test plan:
[1] Update an item so that it has no barcode, callnumber is X and item
    notes contain Convolute.
[2] Upload a barcode file (contents may even be empty), filter on
    callnumber X. Compare should not report the updated convolute.
[3] Remove the Convolute note. Repeat step 2. Inventory should report
    the item now.

Signed-off-by: Marcel de Rooy <m.de.rooy at rijksmuseum.nl>

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Nov  8 16:21:42 2017
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 08 Nov 2017 15:21:42 +0000
Subject: [Koha-bugs] [Bug 19562] Inventory: How can we skip convolutes
 marked as problematic with no_barcode?
In-Reply-To: <bug-19562-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-19562-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-19562-70-8jR1zs9WTo@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19562

Marcel de Rooy <m.de.rooy at rijksmuseum.nl> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
           Assignee|koha-bugs at lists.koha-commun |m.de.rooy at rijksmuseum.nl
                   |ity.org                     |

--- Comment #3 from Marcel de Rooy <m.de.rooy at rijksmuseum.nl> ---
The solution marked before as 'custom' might on second thought be generalized
enough to be selected for inclusion.
So my proposal submitted.
Feedback welcome.

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Nov  8 16:26:56 2017
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 08 Nov 2017 15:26:56 +0000
Subject: [Koha-bugs] [Bug 19289] Allow configuration of the fields on the
 'Catalog details' form in the acquisition baskets
In-Reply-To: <bug-19289-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-19289-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-19289-70-J1xnS8fZVt@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19289

--- Comment #12 from S?verine Queune <severine.queune at bulac.fr> ---
(In reply to Jonathan Druart from comment #11)
> Hi S?verine, I have created the correct ACQ framework only for:
> 
> en/marcflavour/marc21/mandatory/marc21_framework_DEFAULT.sql
> fr-FR/marcflavour/unimarc_complet/Obligatoire/framework_DEFAULT.sql
> 
> When you setup the sandbox, tick "No database (run webinstaller)" to use the
> files used from the Koha codebase and not the database created for the
> sandbox.
> 
> Otherwise you can remove the subfield (@) from 009.

Thanks Jonathan !

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Nov  8 16:31:40 2017
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 08 Nov 2017 15:31:40 +0000
Subject: [Koha-bugs] [Bug 19289] Allow configuration of the fields on the
 'Catalog details' form in the acquisition baskets
In-Reply-To: <bug-19289-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-19289-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-19289-70-yL2C7WEC2C@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19289

--- Comment #13 from S?verine Queune <severine.queune at bulac.fr> ---
I can't sign it from Biblibre's sandbox because of the dependency, but ok for
me !

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Nov  8 16:55:42 2017
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 08 Nov 2017 15:55:42 +0000
Subject: [Koha-bugs] [Bug 19582] Elasticsearch: Auth-finder.pl must use
 search_auth_compat
In-Reply-To: <bug-19582-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-19582-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-19582-70-nFhYz2Afe3@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19582

David Bourgault <david.bourgault at inlibro.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #68992|0                           |1
        is obsolete|                            |

--- Comment #4 from David Bourgault <david.bourgault at inlibro.com> ---
Created attachment 69031
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=69031&action=edit
Bug 19582 - Use compat routines for searching authorities in auth_finder.pl

To test:
1 - Enable Zebra
2 - Perform an auth search
3 - note results
4 - Enable ES
5 - Repeat search, note (likely) diff results
6 - Open a record in cataloging and use the button to launch auth search
7 - Perform same search as above, note results match for eiher engine
selected
8 - NOTE: Disbale sorting for ES search - this will be dealt with in
another report

Signed-off-by: David Bourgault <david.bourgault at inlibro.com>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Nov  8 16:55:45 2017
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 08 Nov 2017 15:55:45 +0000
Subject: [Koha-bugs] [Bug 19582] Elasticsearch: Auth-finder.pl must use
 search_auth_compat
In-Reply-To: <bug-19582-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-19582-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-19582-70-4k5l69J1Nv@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19582

David Bourgault <david.bourgault at inlibro.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #68993|0                           |1
        is obsolete|                            |

--- Comment #5 from David Bourgault <david.bourgault at inlibro.com> ---
Created attachment 69032
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=69032&action=edit
Bug 19582: Unit tests

Signed-off-by: David Bourgault <david.bourgault at inlibro.com>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Nov  8 16:57:24 2017
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 08 Nov 2017 15:57:24 +0000
Subject: [Koha-bugs] [Bug 13990] ILS-DI LookupPatron Requries ID Type
In-Reply-To: <bug-13990-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-13990-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-13990-70-ugOqjdy2kK@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13990

Jon Knight <J.P.Knight at lboro.ac.uk> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
           Assignee|koha-bugs at lists.koha-commun |J.P.Knight at lboro.ac.uk
                   |ity.org                     |

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Nov  8 16:57:46 2017
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 08 Nov 2017 15:57:46 +0000
Subject: [Koha-bugs] [Bug 19582] Elasticsearch: Auth-finder.pl must use
 search_auth_compat
In-Reply-To: <bug-19582-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-19582-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-19582-70-s8pe5AJRUW@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19582

David Bourgault <david.bourgault at inlibro.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Needs Signoff               |Signed Off

--- Comment #6 from David Bourgault <david.bourgault at inlibro.com> ---
Followed test plan, but it took me a long time you meant the auth search in the
record editor...

Before patch the search would actually straight-up fail for me, with patch I
got the same results as a normal auth search.

QA tools and test passed green.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Nov  8 16:58:42 2017
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 08 Nov 2017 15:58:42 +0000
Subject: [Koha-bugs] [Bug 19593] New: "Delete vendor" button is always set
Message-ID: <bug-19593-70@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19593

            Bug ID: 19593
           Summary: "Delete vendor" button is always set
 Change sponsored?: ---
           Product: Koha
           Version: 16.11
          Hardware: All
                OS: All
            Status: NEW
          Severity: normal
          Priority: P5 - low
         Component: Acquisitions
          Assignee: koha-bugs at lists.koha-community.org
          Reporter: gwendal.joncour at univ-rennes2.fr
        QA Contact: testopia at bugs.koha-community.org

On our freshly updated 16.11 instance, we noticed that on pages
/cgi-bin/koha/acqui/booksellers.pl and /cgi-bin/koha/acqui/supplier.pl, the
acquisition toolbar always shows the "Delete vendor" button instead of the
"Receive shipments", no matter the number of baskets attached to the vendor.

When I looking on conditions on
koha-tmpl/intranet-tmpl/prog/en/include/acquisitions-toolbar.inc, I saw that
basketcount variable is not set. acqui/booksellers.pl and acqui/supplier.pl
calling $suppliers[0]->{'basketcount'} and $supplier->{'basketcount'} from
Koha::Acquisition::Bookseller while Bookseller.pm has a basket_count method to
return it, explaining why the "Delete vendor" button is always shown. 

The problem is mainly cosmetic but with it, the test on vendor deletion in
supplier.pl line 95...
if ( $supplier->{'basketcount'} == 0 ) {
...always returns true so the only thing preventing deletion of vendor with
baskets attached on is the database foreign key contraint.

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Nov  8 16:59:32 2017
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 08 Nov 2017 15:59:32 +0000
Subject: [Koha-bugs] [Bug 19588] There is no ILL requests history
In-Reply-To: <bug-19588-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-19588-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-19588-70-Xl7fKEpLw0@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19588

Jon Knight <J.P.Knight at lboro.ac.uk> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |J.P.Knight at lboro.ac.uk

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Nov  8 17:05:32 2017
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 08 Nov 2017 16:05:32 +0000
Subject: [Koha-bugs] [Bug 19592] Move admin templates JavaScript to the
 footer: Acquisitions
In-Reply-To: <bug-19592-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-19592-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-19592-70-6gRsv3fW3I@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19592

Owen Leonard <oleonard at myacpl.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|ASSIGNED                    |Needs Signoff
   Patch complexity|---                         |Small patch

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Nov  8 17:05:34 2017
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 08 Nov 2017 16:05:34 +0000
Subject: [Koha-bugs] [Bug 19592] Move admin templates JavaScript to the
 footer: Acquisitions
In-Reply-To: <bug-19592-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-19592-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-19592-70-MiV3JzG46T@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19592

--- Comment #1 from Owen Leonard <oleonard at myacpl.org> ---
Created attachment 69033
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=69033&action=edit
Bug 19592: Move admin templates JavaScript to the footer: Acquisitions

This patch modifies the staff client acquisitions-related adminisration
templates so that JavaScript is included in the footer instead of the
header.

To test, apply the patch and test the JavaScript-driven features of the
cart: All button controls, DataTables functionality, tabs, etc.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Nov  8 17:11:47 2017
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 08 Nov 2017 16:11:47 +0000
Subject: [Koha-bugs] [Bug 17047] Mana Knowledge Base : share data
In-Reply-To: <bug-17047-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-17047-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-17047-70-XB6ygj3nRC@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17047

Alex Arnaud <alex.arnaud at biblibre.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #67009|0                           |1
        is obsolete|                            |
  Attachment #67010|0                           |1
        is obsolete|                            |
  Attachment #67011|0                           |1
        is obsolete|                            |
  Attachment #67012|0                           |1
        is obsolete|                            |
  Attachment #67013|0                           |1
        is obsolete|                            |
  Attachment #67014|0                           |1
        is obsolete|                            |
  Attachment #67015|0                           |1
        is obsolete|                            |
  Attachment #67016|0                           |1
        is obsolete|                            |
  Attachment #67017|0                           |1
        is obsolete|                            |
  Attachment #67018|0                           |1
        is obsolete|                            |
  Attachment #67019|0                           |1
        is obsolete|                            |
  Attachment #67020|0                           |1
        is obsolete|                            |
  Attachment #67021|0                           |1
        is obsolete|                            |
  Attachment #67022|0                           |1
        is obsolete|                            |
  Attachment #67023|0                           |1
        is obsolete|                            |

--- Comment #165 from Alex Arnaud <alex.arnaud at biblibre.com> ---
Created attachment 69034
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=69034&action=edit
Bug 17047 add Mana-KB syspref

Add the system preference to enable or disable Mana-KB webservice on koha.

Signed-off-by: Brendan A Gallagher <brendan at bywatersolutions.com>

Signed-off-by: Kyle M Hall <kyle at bywatersolutions.com>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Nov  8 17:11:58 2017
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 08 Nov 2017 16:11:58 +0000
Subject: [Koha-bugs] [Bug 17047] Mana Knowledge Base : share data
In-Reply-To: <bug-17047-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-17047-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-17047-70-fXPqdpvgDD@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17047

--- Comment #166 from Alex Arnaud <alex.arnaud at biblibre.com> ---
Created attachment 69035
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=69035&action=edit
Bug 17047 subscriptions management with Mana-KB

- add a class SharedContent.pm to communicate with Mana-KB server
- add a link in serials-menu.inc to serials_search.pl to open
a mana-subscription research form
- modify the research form in serials-search.tt to show the right fields
for Mana-KB
- create datatable in mana-subscription-search-result.inc to show
results from a research on Mana-KB
- modify serials-search.pl to manage research on Mana-KB

- add a mana_id to subscription table
- add a share button on serials-toolbar.inc and a modal to ask
the language of the share and to alert if the subscription is
already link to a Mana-KB subscription model
- add function in C4/Serials to get all the info for a subscription
sharing
- modify subscription-detail.pl to manage sharing to Mana-KB

- modify subscription-add.tt and subscription.pl to manage a
import from Mana-KB during a subscription creation
- add 2 script in svc for ajax calling from subscription-add.tt
to communicate with Mana-KB server during a asubscription creation
- add a function in Subscription.pm to have all the info for a Mana-KB research
from a biblionumber
- modify functions used by subscription-add.pl in C4/Serials to manage a
frequency which came from Mana-KB server and not already created on the
koha database, and modify the tests of the said functions

Signed-off-by: Brendan A Gallagher <brendan at bywatersolutions.com>

Signed-off-by: Kyle M Hall <kyle at bywatersolutions.com>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Nov  8 17:12:09 2017
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 08 Nov 2017 16:12:09 +0000
Subject: [Koha-bugs] [Bug 17047] Mana Knowledge Base : share data
In-Reply-To: <bug-17047-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-17047-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-17047-70-1vMVLKA0T1@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17047

--- Comment #167 from Alex Arnaud <alex.arnaud at biblibre.com> ---
Created attachment 69036
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=69036&action=edit
Bug 17047 SQL reports management with Mana-KB

Includes:

* code factorization
Some code from subscription & Mana-KB has been factorized in order to speed-up
next developments

* SytemPreferences:
Mana Activation:
    - add a value "no, let me think about it", that is the default value.
    - as long as this value is selected, messages ask if user want to activate
it ( in Administration and Add-subscription(page 2) )
AutoShareWithMana
    - Add the syspref AutoShareWithMana: user can automatically share infos
with Mana-KB (not set by default)

* Interface :
    - On mana-search, rows are now sorted by date of last import, then by
number of users
    - Windows redesigned to improve the user experience

* New Feature : report a mistake.
    - people can now report an invalid data (wrong, obsolete,...)
    - if a data is reported as invalid many time, it will appear differently
    - Added few tooltip (to explain the fields last import, nb of users, to
explain the new feature)
    - When reporting a data as invalid, a comment can also be added. Koha will
then display comments related to data in result lists

* API (svc/mana)
    - add svc/mana/addvaluetofield: allows to ask mana incrementing a field of
a resource
    - no hardcoding for resources in the code of api (api needs to be called
with a ressourcename)

* New feature : SQL report sharing
    - Create Koha::Report.pm and Koha::Reports.pm, objects class for Reports
    - New feature: share reports with Mana-KB
    - New feature: search report in Mana-KB with keywords
    - New feature: load reports from Mana-KB

=========
Test plan
=========
(see BibLibre complete documentation, attached to this patch)
1 - Apply Patch + update database
2 - Copy the three lines about mana config in etc/koha-conf.xml in
../etc/koha-conf.xml
3 - Check Mana syspref and AutoShareWithMana syspref are not activated

4 - subscriptions
- Try create a new subscription for a first serial  => Koha shouldn't show you
anything (except if the base hase been filled)
- Share this serial on Mana-KB (on the subscription detail page there must be a
Share button)
- Try to create a new subscription for serial #1 => a message should appear
when you click on "next", click on "use", the fields should automaticaly appear
- Activate AutoShareWithMana => Subscriptions
- Create a new subscription for a second serial
- There shouldn't be any Share button
- Create a second subscription => the message should appear, click again on use

5 - SQL Report
- Create a new report, without notes.
- On the table with all report (reports > use saved), there should be the
action "Share"
- If you click on share, you have an error message
- Create a new report, with a title and notes longer than 20 characters
- You can share it on Mana-KB => you will have a success message
- On (report > use saved), there must be a message inviting you to search on
mana-KB for more results, enter a few word from title, notes, type of the
report you shared, it should appear. You can use it, it will load it into your
report list.

6 - Comments.
- On any table containing mana search results, you can report a mistake &
comment why you report: click on report mistake. You only can chose "other"
because there's no comment in Mana-KB [if there are comments, you'll get other
values].
- If you click other, a new textbox appears. Enter a short comment.
- Reload the whole page, the comment should appear in the menu and in the
comment column.
- If you select a comment and reload the whole page, there should be one more
comment with this name
- If you select a comment and click on cancel just after, there shouldn't be
any change when you reload.

Signed-off-by: Brendan A Gallagher <brendan at bywatersolutions.com>

Signed-off-by: Kyle M Hall <kyle at bywatersolutions.com>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Nov  8 17:12:17 2017
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 08 Nov 2017 16:12:17 +0000
Subject: [Koha-bugs] [Bug 17047] Mana Knowledge Base : share data
In-Reply-To: <bug-17047-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-17047-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-17047-70-tJvxWGvEpw@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17047

--- Comment #168 from Alex Arnaud <alex.arnaud at biblibre.com> ---
Created attachment 69037
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=69037&action=edit
Bug 17047 security token agst flooding for Mana-KB

Rework messages from Mana-KB.

- Add A syspref contains an authentication token. The token will be used to
prevent anaonymous flooding of Mana-KB
- To get an Authentication token, you have to fill a form and validate your
e-mail address
- Messages return codes are now correctly displayed and there shouldn't be any
crash when Mana-KB webservices return a wrong answer or doesn't answer

Test plan:
    1 - Apply Patch + update database
    2 - Copy the three lines about mana config in etc/koha-conf.xml in
../etc/koha-conf.xml (after <backupdir> for example)
        <!-- URL of the mana KB server -->
        <!-- alternative value http://mana-test.koha-community.org to query the
test server -->
        <mana_config>https://mana-kb.koha-community.org</mana_config>
    3 - Check Mana syspref and AutoShareWithMana syspref are not activated
    4 - Search the syspref ManaToken and follow the instructions
    5 - subscriptions
      - Try create a new subscription for a first serial  => Mana-KB shouldn't
show you anything (except if the base hase been filled)
      - Share this serial with Mana-KB (on the serial individual's page there
must be a Share button)
      - Try to create a new subscription for serial nr1 => a message should
appear when you click on "next", click on "use", the fields should automaticaly
appear
      - Activate AutoShareWithMana => Subscriptions
      - Create a new subscription for a second serial
      - There shouldn't be any Share button
      - Create a second subscription => the message should appear, click again
on use

    6 - SQL Report
      - Create a new SQL report, without notes.
      - On the table with all report (reports > use saved), there should be the
action "Share"
      - If you click on share, you have an error message
      - Create a new report, with a title and notes longer than 20 characters
      - You  can share it with mana => you will have a success message
      - On (report > use saved), there must be a message inviting you to search
on Mana-KB for more results, enter a few word from title, notes, type of  the
report you shared, it should appear. You can use it, it will load it into your
report list.

    7 - Report mistakes.
      - On any table containing Mana-KB search results, you can report a
mistake and add a comment.

    8 - For each previous test, try to send wrong data, to delete the security
token, to send nothing: it should show a correct warning message.

Signed-off-by: Brendan A Gallagher <brendan at bywatersolutions.com>

Signed-off-by: Kyle M Hall <kyle at bywatersolutions.com>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Nov  8 17:12:26 2017
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 08 Nov 2017 16:12:26 +0000
Subject: [Koha-bugs] [Bug 17047] Mana Knowledge Base : share data
In-Reply-To: <bug-17047-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-17047-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-17047-70-TuS6zDCLp1@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17047

--- Comment #169 from Alex Arnaud <alex.arnaud at biblibre.com> ---
Created attachment 69038
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=69038&action=edit
Bug 17047: Minor changes

- search on reports module is now also validated by pressing enter.
- AutoShare now initialized with nothing autmaticaly shared.
- To create a report you now have to click on New report => New report from
Mana.
- Error messages are displayed in case of fail
- Correct the display of sql reports containing "'"
- Importing a report from Mana now opens the edit page
- You don't get message after a successful import from mana (you simply get
redirected)
- Fix an error when cretaing subscription
- Fix mana search
- Correct encoding issues

Signed-off-by: Brendan A Gallagher <brendan at bywatersolutions.com>

Signed-off-by: Kyle M Hall <kyle at bywatersolutions.com>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Nov  8 17:12:34 2017
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 08 Nov 2017 16:12:34 +0000
Subject: [Koha-bugs] [Bug 17047] Mana Knowledge Base : share data
In-Reply-To: <bug-17047-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-17047-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-17047-70-bJHBZVPEwC@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17047

--- Comment #170 from Alex Arnaud <alex.arnaud at biblibre.com> ---
Created attachment 69039
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=69039&action=edit
Bug 17047 [QA Followup]   - Fix misc koha-qa.pl failures   - Fix up database
schema change, add to kohastructure.sql   - Update schema files   - Remove
javascript debugger call

Signed-off-by: Kyle M Hall <kyle at bywatersolutions.com>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Nov  8 17:12:43 2017
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 08 Nov 2017 16:12:43 +0000
Subject: [Koha-bugs] [Bug 17047] Mana Knowledge Base : share data
In-Reply-To: <bug-17047-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-17047-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-17047-70-Uger0kgpI6@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17047

--- Comment #171 from Alex Arnaud <alex.arnaud at biblibre.com> ---
Created attachment 69040
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=69040&action=edit
Bug 17047 - [QA Followup]   - Fix untranslatable strings   - Remove onclick
html attribute   - Remove useless passing of mana_id variable in
serials-toolbar.inc   - Remove using CGI::param in list context   - remove new
subs from serials/subscription-add.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Nov  8 17:18:28 2017
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 08 Nov 2017 16:18:28 +0000
Subject: [Koha-bugs] [Bug 19420] Improve display of errors from failure of
 uploading file during stage import
In-Reply-To: <bug-19420-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-19420-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-19420-70-KcvlcS9UKw@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19420

Jonathan Druart <jonathan.druart at bugs.koha-community.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |jonathan.druart at bugs.koha-c
                   |                            |ommunity.org

--- Comment #21 from Jonathan Druart <jonathan.druart at bugs.koha-community.org> ---
errcode should be "already_exists", "no_tmp_dir", etc. No 0, 1, 2, ...
This is a terrible and error prone pattern.
Not blocker as it existed before this patch set.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Nov  8 17:18:55 2017
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 08 Nov 2017 16:18:55 +0000
Subject: [Koha-bugs] [Bug 17047] Mana Knowledge Base : share data
In-Reply-To: <bug-17047-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-17047-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-17047-70-Uf78NrmjMA@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17047

Alex Arnaud <alex.arnaud at biblibre.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #69040|0                           |1
        is obsolete|                            |

--- Comment #172 from Alex Arnaud <alex.arnaud at biblibre.com> ---
Created attachment 69041
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=69041&action=edit
Bug 17047 - [QA Followup]   - Fix untranslatable strings   - Remove onclick
html attribute   - Remove useless passing of mana_id variable in
serials-toolbar.inc   - Remove using CGI::param in list context   - remove new
subs from serials/subscription-add.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Nov  8 17:40:00 2017
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 08 Nov 2017 16:40:00 +0000
Subject: [Koha-bugs] [Bug 19482] Elasticsearch - prevent removal / editing
 of required indexes
In-Reply-To: <bug-19482-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-19482-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-19482-70-3g3XcATJ0T@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19482

David Bourgault <david.bourgault at inlibro.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Needs Signoff               |Failed QA

--- Comment #5 from David Bourgault <david.bourgault at inlibro.com> ---
Correction, patch does apply; I had simply overlooked the dependency.

I applied the patch and update the database (updatedatabase.pl) however, even
after reset-ing the mappings I could not get issues to show up as readonly. I
tried reset-ing again (twice) to no avail. 

Looking into the database I saw the the mandatory flag wasn't being set
properly. After switching it manually it did show up as readonly, as expected.

However I'd suggest displaying the type as a <label> instead of a readonly text
input.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Nov  8 17:47:50 2017
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 08 Nov 2017 16:47:50 +0000
Subject: [Koha-bugs] [Bug 17858] Omnibus: Move staff client JavaScript to
	the footer
In-Reply-To: <bug-17858-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-17858-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-17858-70-4TRg2FgpPo@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17858

Owen Leonard <oleonard at myacpl.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
         Depends on|                            |19594


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19594
[Bug 19594] Move admin templates JavaScript to the footer: MARC-related
-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Nov  8 17:47:50 2017
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 08 Nov 2017 16:47:50 +0000
Subject: [Koha-bugs] [Bug 19594] New: Move admin templates JavaScript to the
 footer: MARC-related
Message-ID: <bug-19594-70@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19594

            Bug ID: 19594
           Summary: Move admin templates JavaScript to the footer:
                    MARC-related
 Change sponsored?: ---
           Product: Koha
           Version: master
          Hardware: All
                OS: All
            Status: ASSIGNED
          Severity: enhancement
          Priority: P5 - low
         Component: Templates
          Assignee: oleonard at myacpl.org
          Reporter: oleonard at myacpl.org
        QA Contact: testopia at bugs.koha-community.org
                CC: jonathan.druart at bugs.koha-community.org,
                    nick at bywatersolutions.com,
                    testopia at bugs.koha-community.org
            Blocks: 17858

In order to conform to best practices for performance staff client template
javascript should be in the footer instead of the header. This patch will do so
for the MARC-related administration templates.


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17858
[Bug 17858] Omnibus: Move staff client JavaScript to the footer
-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Nov  8 17:50:15 2017
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 08 Nov 2017 16:50:15 +0000
Subject: [Koha-bugs] [Bug 10748] Add option to block return of lost items
In-Reply-To: <bug-10748-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-10748-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-10748-70-5XOT3dAwMX@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10748

Jonathan Druart <jonathan.druart at bugs.koha-community.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Passed QA                   |Pushed to Master

--- Comment #14 from Jonathan Druart <jonathan.druart at bugs.koha-community.org> ---
Pushed to master for 17.11, thanks to everybody involved!

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Nov  8 17:50:30 2017
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 08 Nov 2017 16:50:30 +0000
Subject: [Koha-bugs] [Bug 18882] Add location code to statistics table for
 checkouts and renewals
In-Reply-To: <bug-18882-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-18882-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-18882-70-SILnoJ2Y17@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18882

Jonathan Druart <jonathan.druart at bugs.koha-community.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Passed QA                   |Pushed to Master

--- Comment #10 from Jonathan Druart <jonathan.druart at bugs.koha-community.org> ---
Pushed to master for 17.11, thanks to everybody involved!

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Nov  8 17:50:45 2017
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 08 Nov 2017 16:50:45 +0000
Subject: [Koha-bugs] [Bug 18894] Add ability to limit the number of messages
 sent by misc/ cronjobs/process_message_queue.pl at a time
In-Reply-To: <bug-18894-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-18894-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-18894-70-u8lKXy1Yk2@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18894

Jonathan Druart <jonathan.druart at bugs.koha-community.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Passed QA                   |Pushed to Master

--- Comment #7 from Jonathan Druart <jonathan.druart at bugs.koha-community.org> ---
Pushed to master for 17.11, thanks to everybody involved!

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Nov  8 17:51:01 2017
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 08 Nov 2017 16:51:01 +0000
Subject: [Koha-bugs] [Bug 19420] Improve display of errors from failure of
 uploading file during stage import
In-Reply-To: <bug-19420-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-19420-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-19420-70-7Cg8HPf96u@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19420

Jonathan Druart <jonathan.druart at bugs.koha-community.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Passed QA                   |Pushed to Master

--- Comment #22 from Jonathan Druart <jonathan.druart at bugs.koha-community.org> ---
Pushed to master for 17.11, thanks to everybody involved!

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Nov  8 17:51:19 2017
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 08 Nov 2017 16:51:19 +0000
Subject: [Koha-bugs] [Bug 19537] Authorities search doesn' t correctly
 populate subfield $2 source of heading
In-Reply-To: <bug-19537-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-19537-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-19537-70-4PppdOnST6@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19537

Jonathan Druart <jonathan.druart at bugs.koha-community.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Passed QA                   |Pushed to Master

--- Comment #7 from Jonathan Druart <jonathan.druart at bugs.koha-community.org> ---
Pushed to master for 17.11, thanks to everybody involved!

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Nov  8 18:02:30 2017
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 08 Nov 2017 17:02:30 +0000
Subject: [Koha-bugs] [Bug 11897] Stock Rotation for Koha
In-Reply-To: <bug-11897-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-11897-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-11897-70-aMRPtwExWq@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11897

Lisette <lisetteslatah at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |lisetteslatah at gmail.com

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Nov  8 18:02:43 2017
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 08 Nov 2017 17:02:43 +0000
Subject: [Koha-bugs] [Bug 17978] Circ rules will not limit holds
In-Reply-To: <bug-17978-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-17978-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-17978-70-XUlZS2FyPQ@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17978

Lisette <lisetteslatah at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |lisetteslatah at gmail.com

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Nov  8 18:02:55 2017
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 08 Nov 2017 17:02:55 +0000
Subject: [Koha-bugs] [Bug 5463] limit to available shows on hold items
In-Reply-To: <bug-5463-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-5463-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-5463-70-TOuSpb0nPx@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5463

Lisette <lisetteslatah at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |lisetteslatah at gmail.com

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Nov  8 18:03:03 2017
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 08 Nov 2017 17:03:03 +0000
Subject: [Koha-bugs] [Bug 13617] Change wording on suspend
In-Reply-To: <bug-13617-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-13617-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-13617-70-GOIJWL047g@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13617

Lisette <lisetteslatah at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |lisetteslatah at gmail.com

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Nov  8 18:03:13 2017
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 08 Nov 2017 17:03:13 +0000
Subject: [Koha-bugs] [Bug 17624] Add Staff Collection status for items in
	C4::XSLT
In-Reply-To: <bug-17624-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-17624-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-17624-70-6eLizHUzJV@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17624

Lisette <lisetteslatah at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |lisetteslatah at gmail.com

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Nov  8 18:03:30 2017
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 08 Nov 2017 17:03:30 +0000
Subject: [Koha-bugs] [Bug 15516] Allow to reserve first available item from
 a group of titles
In-Reply-To: <bug-15516-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-15516-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-15516-70-FEurn3oUJm@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15516

Lisette <lisetteslatah at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |lisetteslatah at gmail.com

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Nov  8 18:13:12 2017
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 08 Nov 2017 17:13:12 +0000
Subject: [Koha-bugs] [Bug 7317] Add an Interlibrary Loan Module to
	Circulation and OPAC
In-Reply-To: <bug-7317-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-7317-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-7317-70-pmUSPDVLsn@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7317

Tom?s Cohen Arazi <tomascohen at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #69009|0                           |1
        is obsolete|                            |

--- Comment #194 from Tom?s Cohen Arazi <tomascohen at gmail.com> ---
Comment on attachment 69009
  --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=69009
Bug 7317: (QA followup 2) Fix capitalization and terminology issues

This patch doesn't apply because the attached patches already fix this. Not
sure how it happened.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Nov  8 18:23:54 2017
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 08 Nov 2017 17:23:54 +0000
Subject: [Koha-bugs] [Bug 19595] New: Clicking plugin link does not fill
 item' s date acquired field
Message-ID: <bug-19595-70@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19595

            Bug ID: 19595
           Summary: Clicking plugin link does not fill item's date
                    acquired field
 Change sponsored?: ---
           Product: Koha
           Version: master
          Hardware: All
                OS: All
            Status: NEW
          Severity: normal
          Priority: P5 - low
         Component: Cataloging
          Assignee: koha-bugs at lists.koha-community.org
          Reporter: oleonard at myacpl.org
        QA Contact: testopia at bugs.koha-community.org
                CC: jonathan.druart at bugs.koha-community.org,
                    josef.moravec at gmail.com, katrin.fischer at bsz-bw.de,
                    kyle at bywatersolutions.com, m.de.rooy at rijksmuseum.nl,
                    testopia at bugs.koha-community.org
        Depends on: 16203

Before Bug 16203, clicking the "..." plugin link on the item add form's date
acquired field would insert today's date, overwriting an existing date if
present.

Now clicking the "..." link does nothing.


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16203
[Bug 16203] Convert item plugins to new style (see bug 10480)
-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Nov  8 18:23:54 2017
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 08 Nov 2017 17:23:54 +0000
Subject: [Koha-bugs] [Bug 16203] Convert item plugins to new style (see bug
	10480)
In-Reply-To: <bug-16203-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-16203-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-16203-70-bw5UTHuHDo@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16203

Owen Leonard <oleonard at myacpl.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Blocks|                            |19595


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19595
[Bug 19595] Clicking plugin link does not fill item's date acquired field
-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Nov  8 18:38:14 2017
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 08 Nov 2017 17:38:14 +0000
Subject: [Koha-bugs] [Bug 19595] Clicking plugin link does not fill item's
 date acquired field
In-Reply-To: <bug-19595-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-19595-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-19595-70-9lYGKdG5yh@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19595

Jonathan Druart <jonathan.druart at bugs.koha-community.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
           Keywords|                            |rel_17_11_candidate
           Severity|normal                      |major

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Nov  8 18:44:22 2017
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 08 Nov 2017 17:44:22 +0000
Subject: [Koha-bugs] [Bug 19594] Move admin templates JavaScript to the
 footer: MARC-related
In-Reply-To: <bug-19594-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-19594-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-19594-70-Li7urU6dDc@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19594

Owen Leonard <oleonard at myacpl.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|ASSIGNED                    |Needs Signoff
   Patch complexity|---                         |Small patch

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Nov  8 18:44:25 2017
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 08 Nov 2017 17:44:25 +0000
Subject: [Koha-bugs] [Bug 19594] Move admin templates JavaScript to the
 footer: MARC-related
In-Reply-To: <bug-19594-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-19594-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-19594-70-V3dR72reKp@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19594

--- Comment #1 from Owen Leonard <oleonard at myacpl.org> ---
Created attachment 69042
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=69042&action=edit
Bug 19594: Move admin templates JavaScript to the footer: MARC-related

This patch modifies the staff client MARC-related administration
templates so that JavaScript is included in the footer instead of the
header.

To test, apply the patch and test the JavaScript-driven features of the
cart: All button controls, DataTables functionality, tabs, etc.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Nov  8 18:48:39 2017
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 08 Nov 2017 17:48:39 +0000
Subject: [Koha-bugs] [Bug 17047] Mana Knowledge Base : share data
In-Reply-To: <bug-17047-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-17047-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-17047-70-FaHUR1bar2@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17047

--- Comment #173 from Brendan Gallagher <brendan at bywatersolutions.com> ---
Alex should this be set back to "signed qa" or even "passed qa"?

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Nov  8 18:53:39 2017
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 08 Nov 2017 17:53:39 +0000
Subject: [Koha-bugs] [Bug 19596] New: Internal server error if open order
 with deleted biblio / null biblionumber
Message-ID: <bug-19596-70@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19596

            Bug ID: 19596
           Summary: Internal server error if open order with deleted
                    biblio / null biblionumber
 Change sponsored?: ---
           Product: Koha
           Version: master
          Hardware: All
                OS: All
            Status: NEW
          Severity: normal
          Priority: P5 - low
         Component: Acquisitions
          Assignee: koha-bugs at lists.koha-community.org
          Reporter: nick at bywatersolutions.com
        QA Contact: testopia at bugs.koha-community.org

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Nov  8 18:56:58 2017
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 08 Nov 2017 17:56:58 +0000
Subject: [Koha-bugs] [Bug 19596] Internal server error if open order with
 deleted biblio / null biblionumber
In-Reply-To: <bug-19596-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-19596-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-19596-70-gscOr8wRW7@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19596

--- Comment #1 from Nick Clemens <nick at bywatersolutions.com> ---
Created attachment 69043
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=69043&action=edit
Bug 19596 - Don't try to get hold or items count for non-existent biblios

To test:
1 - Create some orders
2 - Delete the bibs (or NULL biblionumber from DB)
3 - Try to recieve some orders
4 - Internal server error
5 - Apply patch
6 - Things should work

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Nov  8 18:56:56 2017
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 08 Nov 2017 17:56:56 +0000
Subject: [Koha-bugs] [Bug 19596] Internal server error if open order with
 deleted biblio / null biblionumber
In-Reply-To: <bug-19596-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-19596-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-19596-70-tGSQeepcvK@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19596

Nick Clemens <nick at bywatersolutions.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|NEW                         |Needs Signoff

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.

From bugzilla-daemon at bugs.koha-community.org  Wed Nov  8 19:14:57 2017
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 08 Nov 2017 18:14:57 +0000
Subject: [Koha-bugs] [Bug 17631] Koha::Biblio - Remove GetHolds
In-Reply-To: <bug-17631-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-17631-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-17631-70-mjUZtFcsk3@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17631

Nick Clemens <nick at bywatersolutions.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Blocks|                            |19596


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19596
[Bug 19596] Internal server error if open order with deleted biblio / null
biblionumber
-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Nov  8 19:14:57 2017
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 08 Nov 2017 18:14:57 +0000
Subject: [Koha-bugs] [Bug 19596] Internal server error if open order with
 deleted biblio / null biblionumber
In-Reply-To: <bug-19596-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-19596-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-19596-70-bMRmxyIeFb@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19596

Nick Clemens <nick at bywatersolutions.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
           Severity|normal                      |major
           Assignee|koha-bugs at lists.koha-commun |nick at bywatersolutions.com
                   |ity.org                     |
         Depends on|                            |18256, 17631


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17631
[Bug 17631] Koha::Biblio - Remove GetHolds
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18256
[Bug 18256] Koha::Biblio - Remove GetItemsCount
-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Nov  8 19:14:57 2017
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 08 Nov 2017 18:14:57 +0000
Subject: [Koha-bugs] [Bug 18256] Koha::Biblio - Remove GetItemsCount
In-Reply-To: <bug-18256-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-18256-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-18256-70-3Gg7tM9kaZ@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18256

Nick Clemens <nick at bywatersolutions.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Blocks|                            |19596


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19596
[Bug 19596] Internal server error if open order with deleted biblio / null
biblionumber
-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Nov  8 19:26:30 2017
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 08 Nov 2017 18:26:30 +0000
Subject: [Koha-bugs] [Bug 19596] Internal server error if open order with
 deleted biblio / null biblionumber
In-Reply-To: <bug-19596-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-19596-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-19596-70-qoSkvf4eGi@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19596

Jonathan Druart <jonathan.druart at bugs.koha-community.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |jonathan.druart at bugs.koha-c
                   |                            |ommunity.org

--- Comment #2 from Jonathan Druart <jonathan.druart at bugs.koha-community.org> ---
Reading the changes, there is this line 2 lines before:
    my $cnt_subscriptions = $biblio->subscriptions->count;
I guess it will explode as well

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Nov  8 19:32:24 2017
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 08 Nov 2017 18:32:24 +0000
Subject: [Koha-bugs] [Bug 17675] Broken links to Koha documentation
In-Reply-To: <bug-17675-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-17675-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-17675-70-XF4I6uZipy@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17675

Jon Knight <J.P.Knight at lboro.ac.uk> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |J.P.Knight at lboro.ac.uk

--- Comment #4 from Jon Knight <J.P.Knight at lboro.ac.uk> ---
I've just run the w3c link checker over
https://koha-community.org/documentation/ and it seems to come out OK now
(including the URLs that it couldn't check because of robot exclusion - I
retrieved all those myself OK).  If anyone wants to double check the link
checker URL is:

https://validator.w3.org/checklink?uri=https%3A%2F%2Fkoha-community.org%2Fdocumentation%2F&hide_type=all&depth=&check=Check

Can this bug can now be marked as fixed? Nobody has touched it for nearly a
year and I know the documentation folk have been busily updating all the Koha
docs.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Nov  8 20:24:56 2017
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 08 Nov 2017 19:24:56 +0000
Subject: [Koha-bugs] [Bug 7317] Add an Interlibrary Loan Module to
	Circulation and OPAC
In-Reply-To: <bug-7317-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-7317-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-7317-70-mpx3IMNYye@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7317

--- Comment #195 from Tom?s Cohen Arazi <tomascohen at gmail.com> ---
(In reply to Jonathan Druart from comment #193)
> Some more:
> 
> 1. This looks wrong
> 260     here_link  => "/cgi-bin/koha/ill/ill-requests.pl"
> 
> url should be in template I'd say

The path shouldn't need to be added manually, I'd say any option is wrong,
fixed anyway in an upcoming patch.

> 2. This is not used, you are using an ajax call
> 219     } elsif ( $op eq 'illlist') {
> 220         # Display all current ILLs                                      
> 
> 221         my $requests = $illRequests->search();
> 222     
> 223         $template->param(                                               
> 
> 224             requests => $requests                                       
> 
> 225         );

This is not used and is removed on an upcoming patch.

> 3. 257     media      => [ "Book", "Article", "Journal" ],
> Is this used?

This is used as a fallback in case the backends don't implement their own list.
Needs to be kept (e.g. for the Dummy backend to work).

> 4.
> Config.pm
> 312     die "No DEFAULT_FORMATS has been defined in koha-conf.xml, but
> UNMEDIATEDILL is active."
> 313         if ( $unmediated &&
> !$configuration->{default_formats}->{default} );
> 
> Not used yet, please remove

Yup, removed in an upcoming patch.

> 5. 794                 \"YEAR(placed) = YEAR(NOW())"
> This looks like a mysqlism

True. But I cannot find any option to specify the same behaviour in
SQL::Abstract or the DBIC docs. The very same line of code can be found on the
DBIC docs as an example.

> 6. The branchcode is displayed instead of the branchname in the list of ILL
> requests. Sounds easy to fix as we embed "branch" (must be library?)

Fixed in an upcoming patch.

> 7. api/v1/swagger/paths/*.json
>   "name": "branchcode"
> vs
>   "name": "branch_id"
> same with
>   borrowernumber vs borrower_id
> and
>   biblionumber vs biblio_id

I can work on this tomorrow. Today's been enough!

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Nov  8 20:33:40 2017
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 08 Nov 2017 19:33:40 +0000
Subject: [Koha-bugs] [Bug 7317] Add an Interlibrary Loan Module to
	Circulation and OPAC
In-Reply-To: <bug-7317-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-7317-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-7317-70-LuTIaZ7myp@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7317

--- Comment #196 from Tom?s Cohen Arazi <tomascohen at gmail.com> ---
Created attachment 69044
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=69044&action=edit
Bug 7317: (QA followup) Rename 'branch' for 'library'

Signed-off-by: Tomas Cohen Arazi <tomascohen at theke.io>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Nov  8 20:33:52 2017
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 08 Nov 2017 19:33:52 +0000
Subject: [Koha-bugs] [Bug 7317] Add an Interlibrary Loan Module to
	Circulation and OPAC
In-Reply-To: <bug-7317-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-7317-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-7317-70-LuaqldJ2kv@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7317

--- Comment #197 from Tom?s Cohen Arazi <tomascohen at gmail.com> ---
Created attachment 69045
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=69045&action=edit
Bug 7317: (followup) Remove extra columns from backends on the main list

This patch removes the extra columns functionality, simplifying the code.
It removes redundant code (in both Perl and JS), unused vars.

It removes the use of here_link and hardcodes the script path on the template.

It also adjusts the AJAX call so it uses the 'library' param instead of
'branch'.

The library column now displays the library name instead of the ID.

Signed-off-by: Tomas Cohen Arazi <tomascohen at theke.io>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Nov  8 20:39:16 2017
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 08 Nov 2017 19:39:16 +0000
Subject: [Koha-bugs] [Bug 7317] Add an Interlibrary Loan Module to
	Circulation and OPAC
In-Reply-To: <bug-7317-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-7317-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-7317-70-Q74j22tKC3@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7317

--- Comment #198 from Tom?s Cohen Arazi <tomascohen at gmail.com> ---
Created attachment 69046
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=69046&action=edit
Bug 7317: Remove traces of UnmediatedILL

This patch removes references to UnmediatedILL. This feature is introduced on
a separate bug.

Signed-off-by: Tomas Cohen Arazi <tomascohen at theke.io>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Nov  8 20:40:27 2017
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 08 Nov 2017 19:40:27 +0000
Subject: [Koha-bugs] [Bug 7317] Add an Interlibrary Loan Module to
	Circulation and OPAC
In-Reply-To: <bug-7317-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-7317-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-7317-70-6keFocSY3o@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7317

Tom?s Cohen Arazi <tomascohen at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
         QA Contact|kyle at bywatersolutions.com   |tomascohen at gmail.com

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Nov  8 20:47:20 2017
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 08 Nov 2017 19:47:20 +0000
Subject: [Koha-bugs] [Bug 17675] Broken links to Koha documentation
In-Reply-To: <bug-17675-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-17675-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-17675-70-qdGrfrZ7Rd@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17675

Liz Rea <liz at catalyst.net.nz> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|REOPENED                    |RESOLVED
         Resolution|---                         |FIXED

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Nov  8 20:58:19 2017
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 08 Nov 2017 19:58:19 +0000
Subject: [Koha-bugs] [Bug 12342] Patron registration datepicker dropdown
 shows only 10 years
In-Reply-To: <bug-12342-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-12342-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-12342-70-jfHIbXu3C9@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12342

Jon Knight <J.P.Knight at lboro.ac.uk> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |J.P.Knight at lboro.ac.uk

--- Comment #20 from Jon Knight <J.P.Knight at lboro.ac.uk> ---
Been doing some detective work on this one.  It seems Bug 15692 moved the
datepicker jquery javascript into
/koha-tmpl/intranet-tmpl/prog/en/js/members.js, with the patch from this bug
still intact.

Then Bug 16242 moved the staff client javascript out of the language directory,
so /koha-tmpl/intranet-tmpl/prog/en/js/members.js became
/koha-tmpl/intranet-tmpl/prog/js/members.js

Looking at the log history of this moved file, it appears that the code was
then changed in bug 18477, which references this bug.  That's been pushed to
master more recently than this bug has last been updated, so can we assume that
this bug can now be closed again?

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Nov  8 21:14:32 2017
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 08 Nov 2017 20:14:32 +0000
Subject: [Koha-bugs] [Bug 19544] Add manual contributors to the release notes
In-Reply-To: <bug-19544-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-19544-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-19544-70-piAKfhNzsf@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19544

Jonathan Druart <jonathan.druart at bugs.koha-community.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
         Resolution|---                         |FIXED
             Status|NEW                         |RESOLVED

--- Comment #1 from Jonathan Druart <jonathan.druart at bugs.koha-community.org> ---
See commit 9004e69f958489ccdac106e56acb9a561ca6f0c2
    Add manual contributors

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Nov  8 22:42:22 2017
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 08 Nov 2017 21:42:22 +0000
Subject: [Koha-bugs] [Bug 19596] Internal server error if open order with
 deleted biblio / null biblionumber
In-Reply-To: <bug-19596-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-19596-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-19596-70-SgCSfu8dKZ@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19596

Nick Clemens <nick at bywatersolutions.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #69043|0                           |1
        is obsolete|                            |

--- Comment #3 from Nick Clemens <nick at bywatersolutions.com> ---
Created attachment 69047
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=69047&action=edit
Bug 19596 - Don't try to get hold or items count for non-existent biblios

To test:
1 - Create some orders
2 - Delete the bibs (or NULL biblionumber from DB)
3 - Try to recieve some orders
4 - Internal server error
5 - Apply patch
6 - Things should work


Current status: Needs Signoff

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Nov  8 22:43:07 2017
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 08 Nov 2017 21:43:07 +0000
Subject: [Koha-bugs] [Bug 19596] Internal server error if open order with
 deleted biblio / null biblionumber
In-Reply-To: <bug-19596-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-19596-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-19596-70-o7lvAzBGPj@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19596

--- Comment #4 from Nick Clemens <nick at bywatersolutions.com> ---
(In reply to Jonathan Druart from comment #2)
> Reading the changes, there is this line 2 lines before:
>     my $cnt_subscriptions = $biblio->subscriptions->count;
> I guess it will explode as well

Good call, I was debugging from 17.05 - the first patch without the added line
will be needed there.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Nov  8 23:58:09 2017
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 08 Nov 2017 22:58:09 +0000
Subject: [Koha-bugs] [Bug 19597] New: Cannot add patrons to list if they do
 not have a cardnumber
Message-ID: <bug-19597-70@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19597

            Bug ID: 19597
           Summary: Cannot add patrons to list if they do not have a
                    cardnumber
 Change sponsored?: ---
           Product: Koha
           Version: master
          Hardware: All
                OS: All
            Status: NEW
          Severity: normal
          Priority: P5 - low
         Component: Patrons
          Assignee: koha-bugs at lists.koha-community.org
          Reporter: liz at catalyst.net.nz
        QA Contact: testopia at bugs.koha-community.org
                CC: gmcharlt at gmail.com, kyle.m.hall at gmail.com

To replicate:

Create a borrower with no cardnumber (you may have to un-require the cardnumber
in your database)

Create a patron list

Add a borrower with a cardnumber, notice it works
Try to add your borrower that has no cardnumber, notice that it doesn't work

It looks like we can handle either borrowernumbers or cardnumbers in the back
end, but the front end here is sending only half useful ID's.

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Nov  9 08:52:21 2017
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 09 Nov 2017 07:52:21 +0000
Subject: [Koha-bugs] [Bug 17047] Mana Knowledge Base : share data
In-Reply-To: <bug-17047-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-17047-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-17047-70-IDpj8pvvLK@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17047

--- Comment #174 from Alex Arnaud <alex.arnaud at biblibre.com> ---
(In reply to Brendan Gallagher from comment #173)
> Alex should this be set back to "signed qa" or even "passed qa"?

Hello Brendan.

Sorry no. Here is a QA fix. I have to do some code refacto and fonctional
changes (moving the comment feature from the mana results table)

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Nov  9 08:56:47 2017
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 09 Nov 2017 07:56:47 +0000
Subject: [Koha-bugs] [Bug 17047] Mana Knowledge Base : share data
In-Reply-To: <bug-17047-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-17047-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-17047-70-uzqxfYs9Gz@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17047

--- Comment #175 from Alex Arnaud <alex.arnaud at biblibre.com> ---
Also, unit tests are missing for
Koha::Subscription::Numberpatterns::new_or_existing

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Nov  9 09:03:32 2017
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 09 Nov 2017 08:03:32 +0000
Subject: [Koha-bugs] [Bug 19595] Clicking plugin link does not fill item's
 date acquired field
In-Reply-To: <bug-19595-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-19595-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-19595-70-qNXz7CCntP@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19595

--- Comment #1 from Marcel de Rooy <m.de.rooy at rijksmuseum.nl> ---
I think this is not a bug but a change in behavior. We have cataloging plugins
with additional popups and those without such popups. The plugin for date
acquired is in the last category. More technically, it has no launcher in its
perl script. If you hover your mouse over the "plugin link", you will see "No
popup". Iirc another report already mentioned the need for a clearer division.

Imo no bug and no rel 17.11 candidate, but something to improve in style for
18.05.

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Nov  9 10:39:27 2017
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 09 Nov 2017 09:39:27 +0000
Subject: [Koha-bugs] [Bug 18194] Elasticsearch should be able to add new
	indexes
In-Reply-To: <bug-18194-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-18194-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-18194-70-RxEMyL8qLe@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18194

S?verine Queune <severine.queune at bulac.fr> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |severine.queune at bulac.fr

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Nov  9 10:57:25 2017
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 09 Nov 2017 09:57:25 +0000
Subject: [Koha-bugs] [Bug 19592] Move admin templates JavaScript to the
 footer: Acquisitions
In-Reply-To: <bug-19592-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-19592-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-19592-70-L77uLfzoEP@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19592

Simon Pouchol <simon.pouchol at biblibre.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #69033|0                           |1
        is obsolete|                            |

--- Comment #2 from Simon Pouchol <simon.pouchol at biblibre.com> ---
Created attachment 69048
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=69048&action=edit
Bug 19592: Move admin templates JavaScript to the footer: Acquisitions

This patch modifies the staff client acquisitions-related adminisration
templates so that JavaScript is included in the footer instead of the
header.

To test, apply the patch and test the JavaScript-driven features of the
cart: All button controls, DataTables functionality, tabs, etc.

Signed-off-by: Simon Pouchol <simon.pouchol at biblibre.com>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Nov  9 10:57:40 2017
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 09 Nov 2017 09:57:40 +0000
Subject: [Koha-bugs] [Bug 19592] Move admin templates JavaScript to the
 footer: Acquisitions
In-Reply-To: <bug-19592-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-19592-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-19592-70-GY2crmOk8a@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19592

Simon Pouchol <simon.pouchol at biblibre.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |simon.pouchol at biblibre.com
             Status|Needs Signoff               |Signed Off

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Nov  9 12:13:02 2017
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 09 Nov 2017 11:13:02 +0000
Subject: [Koha-bugs] [Bug 19598] New: ES configuration - Make the columns
 sortable/searchable
Message-ID: <bug-19598-70@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19598

            Bug ID: 19598
           Summary: ES configuration - Make the columns
                    sortable/searchable
 Change sponsored?: ---
           Product: Koha
           Version: master
          Hardware: All
                OS: All
            Status: NEW
          Severity: enhancement
          Priority: P5 - low
         Component: Searching - Elasticsearch
          Assignee: koha-bugs at lists.koha-community.org
          Reporter: severine.queune at bulac.fr

It would be great if we could sort (even search ?) the columns of the 3 tabs of
Elastic search configuration (page
koha/admin/searchengine/elasticsearch/mappings.pl).

That would make the configuration easier.
I would also be very useful to use different sorts/searches to check which
fields are facetable / which subfields of XXX marc block are mapped / etc. to
make the configuration more trustworthy.

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Nov  9 12:21:00 2017
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 09 Nov 2017 11:21:00 +0000
Subject: [Koha-bugs] [Bug 19594] Move admin templates JavaScript to the
 footer: MARC-related
In-Reply-To: <bug-19594-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-19594-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-19594-70-qJxYmxTXpb@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19594

Simon Pouchol <simon.pouchol at biblibre.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #69042|0                           |1
        is obsolete|                            |

--- Comment #2 from Simon Pouchol <simon.pouchol at biblibre.com> ---
Created attachment 69049
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=69049&action=edit
Bug 19594: Move admin templates JavaScript to the footer: MARC-related

This patch modifies the staff client MARC-related administration
templates so that JavaScript is included in the footer instead of the
header.

To test, apply the patch and test the JavaScript-driven features of the
cart: All button controls, DataTables functionality, tabs, etc.

Signed-off-by: Simon Pouchol <simon.pouchol at biblibre.com>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Nov  9 12:21:15 2017
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 09 Nov 2017 11:21:15 +0000
Subject: [Koha-bugs] [Bug 19594] Move admin templates JavaScript to the
 footer: MARC-related
In-Reply-To: <bug-19594-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-19594-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-19594-70-g7EqL6C4Ks@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19594

Simon Pouchol <simon.pouchol at biblibre.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |simon.pouchol at biblibre.com
             Status|Needs Signoff               |Signed Off

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Nov  9 12:54:50 2017
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 09 Nov 2017 11:54:50 +0000
Subject: [Koha-bugs] [Bug 19599] New: anonymise_issue_history can be very
 slow on large systems
Message-ID: <bug-19599-70@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19599

            Bug ID: 19599
           Summary: anonymise_issue_history can be very slow on large
                    systems
 Change sponsored?: ---
           Product: Koha
           Version: master
          Hardware: All
                OS: All
            Status: NEW
          Severity: major
          Priority: P5 - low
         Component: Architecture, internals, and plumbing
          Assignee: koha-bugs at lists.koha-community.org
          Reporter: nick at bywatersolutions.com
        QA Contact: testopia at bugs.koha-community.org

When running anonymise_issue_history we now call it on a set of patrons from
search_patrons_to_anonymise, however, this generates a slow SQL query that can
take hours to run.

UPDATE `old_issues` SET `old_issues`.`borrowernumber` = '9807' WHERE ( 
`issue_id` IN ( 
    SELECT * FROM ( 
        SELECT `old_issues`.`issue_id` FROM (
            SELECT `me`.`borrowernumber`, `me`.`cardnumber`, `me`.`surname`,
`me`.`firstname`, `me`.`title`, `me`.`othernames`, `me`.`initials`,
`me`.`streetnumber`, `me`.`streettype`, `me`.`address`, `me`.`address2`,
`me`.`city`, `me`.`state`, `me`.`zipcode`, `me`.`country`, `me`.`email`,
`me`.`phone`, `me`.`mobile`, `me`.`fax`, `me`.`emailpro`, `me`.`phonepro`,
`me`.`B_streetnumber`, `me`.`B_streettype`, `me`.`B_address`,
`me`.`B_address2`, `me`.`B_city`, `me`.`B_state`, `me`.`B_zipcode`,
`me`.`B_country`, `me`.`B_email`, `me`.`B_phone`, `me`.`dateofbirth`,
`me`.`branchcode`, `me`.`categorycode`, `me`.`dateenrolled`, `me`.`dateexpiry`,
`me`.`gonenoaddress`, `me`.`lost`, `me`.`debarred`, `me`.`debarredcomment`,
`me`.`contactname`, `me`.`contactfirstname`, `me`.`contacttitle`,
`me`.`guarantorid`, `me`.`borrowernotes`, `me`.`relationship`, `me`.`sex`,
`me`.`password`, `me`.`flags`, `me`.`userid`, `me`.`opacnote`,
`me`.`contactnote`, `me`.`sort1`, `me`.`sort2`, `me`.`altcontactfirstname`,
`me`.`altcontactsurname`, `me`.`altcontactaddress1`, `me`.`altcontactaddress2`,
`me`.`altcontactaddress3`, `me`.`altcontactstate`, `me`.`altcontactzipcode`,
`me`.`altcontactcountry`, `me`.`altcontactphone`, `me`.`smsalertnumber`,
`me`.`sms_provider_id`, `me`.`privacy`, `me`.`privacy_guarantor_checkouts`,
`me`.`checkprevcheckout`, `me`.`updated_on`, `me`.`lastseen`, `me`.`lang`,
`me`.`login_attempts`, `me`.`overdrive_auth_token` 
            FROM `borrowers` `me` 
            LEFT JOIN `old_issues` `old_issues` ON
`old_issues`.`borrowernumber` = `me`.`borrowernumber` 
            WHERE ( ( `old_issues`.`borrowernumber` IS NOT NULL AND `privacy`
<> '0' AND `returndate` < '2017-05-13 00:00:00' ) ) 
            GROUP BY `borrowernumber`) `me`  
         JOIN `old_issues` `old_issues` ON `old_issues`.`borrowernumber` =
`me`.`borrowernumber` 
         WHERE ( `returndate` < '2017-05-13 00:00:00' ) )
`_forced_double_subquery` )  
     )

I think anonymise_issue_history should be a standalone function taking the same
params as search_patrons_to_anonymise to eliminate nesting of queries

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Nov  9 12:55:12 2017
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 09 Nov 2017 11:55:12 +0000
Subject: [Koha-bugs] [Bug 19599] anonymise_issue_history can be very slow on
 large systems
In-Reply-To: <bug-19599-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-19599-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-19599-70-hreiBCn6kL@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19599

Nick Clemens <nick at bywatersolutions.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
         Depends on|                            |16966


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16966
[Bug 16966] Koha::Patrons - Move GetBorrowersWithIssuesHistoryOlderThan to
search_patrons_to_anonymise
-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Nov  9 12:55:12 2017
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 09 Nov 2017 11:55:12 +0000
Subject: [Koha-bugs] [Bug 16966] Koha:: Patrons - Move
 GetBorrowersWithIssuesHistoryOlderThan to search_patrons_to_anonymise
In-Reply-To: <bug-16966-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-16966-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-16966-70-a9eAn8jxjb@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16966

Nick Clemens <nick at bywatersolutions.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Blocks|                            |19599


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19599
[Bug 19599] anonymise_issue_history can be very slow on large systems
-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Nov  9 13:08:01 2017
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 09 Nov 2017 12:08:01 +0000
Subject: [Koha-bugs] [Bug 19397] Release team 17.11
In-Reply-To: <bug-19397-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-19397-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-19397-70-b73hIseCXv@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19397

Tom?s Cohen Arazi <tomascohen at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |tomascohen at gmail.com
           Severity|enhancement                 |minor

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Nov  9 13:10:46 2017
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 09 Nov 2017 12:10:46 +0000
Subject: [Koha-bugs] [Bug 14826] Store account offsets
In-Reply-To: <bug-14826-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-14826-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-14826-70-Bgv5U0cj2K@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14826

Tom?s Cohen Arazi <tomascohen at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
           Severity|enhancement                 |new feature
            Summary|Resurrect account offsets   |Store account offsets
                   |table                       |

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Nov  9 13:11:45 2017
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 09 Nov 2017 12:11:45 +0000
Subject: [Koha-bugs] [Bug 18684] Translatability: Get rid of %%] in
 translation for currency.tt
In-Reply-To: <bug-18684-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-18684-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-18684-70-5mYA1pKfMn@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18684

Tom?s Cohen Arazi <tomascohen at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
           Severity|enhancement                 |minor
                 CC|                            |tomascohen at gmail.com

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Nov  9 13:32:49 2017
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 09 Nov 2017 12:32:49 +0000
Subject: [Koha-bugs] [Bug 19595] Clicking plugin link does not fill item's
 date acquired field
In-Reply-To: <bug-19595-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-19595-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-19595-70-xPuG2vNc3O@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19595

Jonathan Druart <jonathan.druart at bugs.koha-community.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
           Severity|major                       |normal
           Keywords|rel_17_11_candidate         |

--- Comment #2 from Jonathan Druart <jonathan.druart at bugs.koha-community.org> ---
Thanks for the clarification Marcel.

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.

From bugzilla-daemon at bugs.koha-community.org  Thu Nov  9 13:53:45 2017
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 09 Nov 2017 12:53:45 +0000
Subject: [Koha-bugs] [Bug 11879] Add a new borrower field : main contact
	method.
In-Reply-To: <bug-11879-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-11879-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-11879-70-HtT37RBmE2@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11879

--- Comment #95 from Owen Leonard <oleonard at myacpl.org> ---
Created attachment 69050
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=69050&action=edit
Bug 11879: Follow-up - Streamline markup and make label corrections

This patch makes minor markup corrections to the patron detail page
template:

- Simplify the SWITCH markup
- Add "primary" to primary phone label
- Correct case on label
- Add IF statement to hide label if there is no primary contact
  method

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Nov  9 14:14:31 2017
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 09 Nov 2017 13:14:31 +0000
Subject: [Koha-bugs] [Bug 19548] Search Result Second page not available
In-Reply-To: <bug-19548-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-19548-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-19548-70-ienA5W9K9Q@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19548

--- Comment #6 from rainer.stowasser at zamg.ac.at ---
You need an account (its free but you have to register)
the ip-range of my institution can access (so no username and password)

Hostname services.dnb.de
Port 80
database sru/dnb
Syntax MARC21/USMARC
Coding UTF8
Options sru=get,sru_version=1.1, schema=MARC21-xml

and the mapping of the Fields


Titel: dnb.tit
ISBN:  dnb.num
Controlnumber: dnb.idn
free Text: dnb.woe
Author: dnb.atr
ISSN:  dnb.num
Keyword: dnb.sw
Dewey: dnb.ddc
Standard-ID: dnb.idn

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Nov  9 14:22:11 2017
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 09 Nov 2017 13:22:11 +0000
Subject: [Koha-bugs] [Bug 19600] New: Move admin templates JavaScript to the
 footer: Other catalog pages
Message-ID: <bug-19600-70@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19600

            Bug ID: 19600
           Summary: Move admin templates JavaScript to the footer: Other
                    catalog pages
 Change sponsored?: ---
           Product: Koha
           Version: master
          Hardware: All
                OS: All
            Status: ASSIGNED
          Severity: enhancement
          Priority: P5 - low
         Component: Templates
          Assignee: oleonard at myacpl.org
          Reporter: oleonard at myacpl.org
        QA Contact: testopia at bugs.koha-community.org
                CC: jonathan.druart at bugs.koha-community.org,
                    nick at bywatersolutions.com, simon.pouchol at biblibre.com,
                    testopia at bugs.koha-community.org
        Depends on: 19594
            Blocks: 17858

In order to conform to best practices for performance staff client template
javascript should be in the footer instead of the header.

This patch will do so for the other catalog-related administration templates
not covered in Bug 19594.


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17858
[Bug 17858] Omnibus: Move staff client JavaScript to the footer
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19594
[Bug 19594] Move admin templates JavaScript to the footer: MARC-related
-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Nov  9 14:22:11 2017
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 09 Nov 2017 13:22:11 +0000
Subject: [Koha-bugs] [Bug 19594] Move admin templates JavaScript to the
 footer: MARC-related
In-Reply-To: <bug-19594-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-19594-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-19594-70-srO310EX8w@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19594

Owen Leonard <oleonard at myacpl.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Blocks|                            |19600


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19600
[Bug 19600] Move admin templates JavaScript to the footer: Other catalog pages
-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Nov  9 14:22:11 2017
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 09 Nov 2017 13:22:11 +0000
Subject: [Koha-bugs] [Bug 17858] Omnibus: Move staff client JavaScript to
	the footer
In-Reply-To: <bug-17858-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-17858-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-17858-70-5gN473c9Dq@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17858

Owen Leonard <oleonard at myacpl.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
         Depends on|                            |19600


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19600
[Bug 19600] Move admin templates JavaScript to the footer: Other catalog pages
-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Nov  9 14:29:00 2017
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 09 Nov 2017 13:29:00 +0000
Subject: [Koha-bugs] [Bug 19600] Move admin templates JavaScript to the
 footer: Other catalog pages
In-Reply-To: <bug-19600-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-19600-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-19600-70-K9WwVOPHGJ@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19600

--- Comment #1 from Owen Leonard <oleonard at myacpl.org> ---
Created attachment 69051
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=69051&action=edit
Bug 19600: Move admin templates JavaScript to the footer: Other catalog pages

This patch modifies the staff client catalog-related administration
templates so that JavaScript is included in the footer instead of the
header.

To test, apply the patch and test the JavaScript-driven features of the
cart: All button controls, DataTables functionality, tabs, etc.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Nov  9 14:28:57 2017
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 09 Nov 2017 13:28:57 +0000
Subject: [Koha-bugs] [Bug 19600] Move admin templates JavaScript to the
 footer: Other catalog pages
In-Reply-To: <bug-19600-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-19600-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-19600-70-X4wo7HvX0M@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19600

Owen Leonard <oleonard at myacpl.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|ASSIGNED                    |Needs Signoff
   Patch complexity|---                         |Small patch

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Nov  9 14:31:37 2017
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 09 Nov 2017 13:31:37 +0000
Subject: [Koha-bugs] [Bug 19601] New: Move admin templates JavaScript to the
 footer: Additional parameters
Message-ID: <bug-19601-70@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19601

            Bug ID: 19601
           Summary: Move admin templates JavaScript to the footer:
                    Additional parameters
 Change sponsored?: ---
           Product: Koha
           Version: master
          Hardware: All
                OS: All
            Status: ASSIGNED
          Severity: enhancement
          Priority: P5 - low
         Component: Templates
          Assignee: oleonard at myacpl.org
          Reporter: oleonard at myacpl.org
        QA Contact: testopia at bugs.koha-community.org
                CC: jonathan.druart at bugs.koha-community.org,
                    nick at bywatersolutions.com, simon.pouchol at biblibre.com,
                    testopia at bugs.koha-community.org
        Depends on: 19594
            Blocks: 17858

In order to conform to best practices for performance staff client template
javascript should be in the footer instead of the header.

This patch will do so for the "Additional parameters" administration templates.


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17858
[Bug 17858] Omnibus: Move staff client JavaScript to the footer
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19594
[Bug 19594] Move admin templates JavaScript to the footer: MARC-related
-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Nov  9 14:31:37 2017
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 09 Nov 2017 13:31:37 +0000
Subject: [Koha-bugs] [Bug 17858] Omnibus: Move staff client JavaScript to
	the footer
In-Reply-To: <bug-17858-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-17858-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-17858-70-uDtsxF9A8t@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17858

Owen Leonard <oleonard at myacpl.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
         Depends on|                            |19601


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19601
[Bug 19601] Move admin templates JavaScript to the footer: Additional
parameters
-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Nov  9 14:31:37 2017
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 09 Nov 2017 13:31:37 +0000
Subject: [Koha-bugs] [Bug 19594] Move admin templates JavaScript to the
 footer: MARC-related
In-Reply-To: <bug-19594-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-19594-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-19594-70-VMvfIZsndW@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19594

Owen Leonard <oleonard at myacpl.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Blocks|                            |19601


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19601
[Bug 19601] Move admin templates JavaScript to the footer: Additional
parameters
-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Nov  9 14:50:56 2017
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 09 Nov 2017 13:50:56 +0000
Subject: [Koha-bugs] [Bug 19602] New: Add usage statistics link to
 administration sidebar menu
Message-ID: <bug-19602-70@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19602

            Bug ID: 19602
           Summary: Add usage statistics link to administration sidebar
                    menu
 Change sponsored?: ---
           Product: Koha
           Version: master
          Hardware: All
                OS: All
            Status: NEW
          Severity: normal
          Priority: P5 - low
         Component: Templates
          Assignee: oleonard at myacpl.org
          Reporter: oleonard at myacpl.org
        QA Contact: testopia at bugs.koha-community.org

admin-menu.inc doesn't have a link to usage_statistics.pl

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Nov  9 14:55:29 2017
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 09 Nov 2017 13:55:29 +0000
Subject: [Koha-bugs] [Bug 19599] anonymise_issue_history can be very slow on
 large systems
In-Reply-To: <bug-19599-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-19599-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-19599-70-o49RIvhDWp@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19599

--- Comment #1 from Jonathan Druart <jonathan.druart at bugs.koha-community.org> ---
Created attachment 69052
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=69052&action=edit
Bug 19599: Execute 1 query per patron

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Nov  9 14:55:38 2017
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 09 Nov 2017 13:55:38 +0000
Subject: [Koha-bugs] [Bug 19600] Move admin templates JavaScript to the
 footer: Other catalog pages
In-Reply-To: <bug-19600-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-19600-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-19600-70-ybv0Qy6B1E@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19600

Owen Leonard <oleonard at myacpl.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #69051|0                           |1
        is obsolete|                            |

--- Comment #2 from Owen Leonard <oleonard at myacpl.org> ---
Created attachment 69053
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=69053&action=edit
Bug 19600: Move admin templates JavaScript to the footer: Other catalog pages

This patch modifies the staff client catalog-related administration
templates so that JavaScript is included in the footer instead of the
header.

To test, apply the patch and test the JavaScript-driven features of
each modified template: All button controls, DataTables functionality,
tabs, etc.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Nov  9 14:56:37 2017
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 09 Nov 2017 13:56:37 +0000
Subject: [Koha-bugs] [Bug 19599] anonymise_issue_history can be very slow on
 large systems
In-Reply-To: <bug-19599-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-19599-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-19599-70-1TCJEXf7n5@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19599

--- Comment #2 from Jonathan Druart <jonathan.druart at bugs.koha-community.org> ---
Created attachment 69054
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=69054&action=edit
Bug 19599: Simplify the query

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.

From bugzilla-daemon at bugs.koha-community.org  Thu Nov  9 14:58:13 2017
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 09 Nov 2017 13:58:13 +0000
Subject: [Koha-bugs] [Bug 19599] anonymise_issue_history can be very slow on
 large systems
In-Reply-To: <bug-19599-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-19599-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-19599-70-JcqoZ7UkKv@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19599

Jonathan Druart <jonathan.druart at bugs.koha-community.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |jonathan.druart at bugs.koha-c
                   |                            |ommunity.org

--- Comment #3 from Jonathan Druart <jonathan.druart at bugs.koha-community.org> ---
Nick, can you compare these 2 approaches please?
They are not dependent on each others.

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Nov  9 14:58:12 2017
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 09 Nov 2017 13:58:12 +0000
Subject: [Koha-bugs] [Bug 19601] Move admin templates JavaScript to the
 footer: Additional parameters
In-Reply-To: <bug-19601-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-19601-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-19601-70-IcIKKUTezB@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19601

Owen Leonard <oleonard at myacpl.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|ASSIGNED                    |Needs Signoff
   Patch complexity|---                         |Small patch

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Nov  9 14:58:15 2017
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 09 Nov 2017 13:58:15 +0000
Subject: [Koha-bugs] [Bug 19601] Move admin templates JavaScript to the
 footer: Additional parameters
In-Reply-To: <bug-19601-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-19601-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-19601-70-uJ37JXoUuK@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19601

--- Comment #1 from Owen Leonard <oleonard at myacpl.org> ---
Created attachment 69055
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=69055&action=edit
Bug 19601: Move admin templates JavaScript to the footer: Additional parameters

This patch modifies the staff client "additional parameters"
administration templates so that JavaScript is included in the footer
instead of the header.

To test, apply the patch and test the JavaScript-driven features of
each page: All button controls, DataTables functionality, tabs, etc.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Nov  9 14:58:23 2017
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 09 Nov 2017 13:58:23 +0000
Subject: [Koha-bugs] [Bug 19599] anonymise_issue_history can be very slow on
 large systems
In-Reply-To: <bug-19599-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-19599-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-19599-70-aeByPMxCsO@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19599

Jonathan Druart <jonathan.druart at bugs.koha-community.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|NEW                         |In Discussion

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.

From bugzilla-daemon at bugs.koha-community.org  Thu Nov  9 15:03:30 2017
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 09 Nov 2017 14:03:30 +0000
Subject: [Koha-bugs] [Bug 7317] Add an Interlibrary Loan Module to
	Circulation and OPAC
In-Reply-To: <bug-7317-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-7317-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-7317-70-vPHPgMfpPY@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7317

Tom?s Cohen Arazi <tomascohen at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Failed QA                   |Passed QA

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Nov  9 15:03:49 2017
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 09 Nov 2017 14:03:49 +0000
Subject: [Koha-bugs] [Bug 7317] Add an Interlibrary Loan Module to
	Circulation and OPAC
In-Reply-To: <bug-7317-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-7317-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-7317-70-QH4X0TLTmH@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7317

--- Comment #199 from Tom?s Cohen Arazi <tomascohen at gmail.com> ---
Created attachment 69056
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=69056&action=edit
Bug 7317: (QA followup) Make query parameters consistent with other endpoints

Signed-off-by: Tomas Cohen Arazi <tomascohen at theke.io>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Nov  9 15:29:16 2017
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 09 Nov 2017 14:29:16 +0000
Subject: [Koha-bugs] [Bug 19594] Move admin templates JavaScript to the
 footer: MARC-related
In-Reply-To: <bug-19594-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-19594-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-19594-70-yfytKdO4dN@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19594

Owen Leonard <oleonard at myacpl.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Blocks|                            |19603


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19603
[Bug 19603] Move admin templates JavaScript to the footer: Patrons and
circulation
-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Nov  9 15:29:16 2017
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 09 Nov 2017 14:29:16 +0000
Subject: [Koha-bugs] [Bug 19603] New: Move admin templates JavaScript to the
 footer: Patrons and circulation
Message-ID: <bug-19603-70@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19603

            Bug ID: 19603
           Summary: Move admin templates JavaScript to the footer: Patrons
                    and circulation
 Change sponsored?: ---
           Product: Koha
           Version: master
          Hardware: All
                OS: All
            Status: ASSIGNED
          Severity: enhancement
          Priority: P5 - low
         Component: Templates
          Assignee: oleonard at myacpl.org
          Reporter: oleonard at myacpl.org
        QA Contact: testopia at bugs.koha-community.org
                CC: jonathan.druart at bugs.koha-community.org,
                    nick at bywatersolutions.com, simon.pouchol at biblibre.com,
                    testopia at bugs.koha-community.org
        Depends on: 19594
            Blocks: 17858

In order to conform to best practices for performance staff client template
javascript should be in the footer instead of the header.

This patch will do so for the patrons and circulation administration templates.


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17858
[Bug 17858] Omnibus: Move staff client JavaScript to the footer
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19594
[Bug 19594] Move admin templates JavaScript to the footer: MARC-related
-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Nov  9 15:29:16 2017
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 09 Nov 2017 14:29:16 +0000
Subject: [Koha-bugs] [Bug 17858] Omnibus: Move staff client JavaScript to
	the footer
In-Reply-To: <bug-17858-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-17858-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-17858-70-EMaEBIWNzJ@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17858

Owen Leonard <oleonard at myacpl.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
         Depends on|                            |19603


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19603
[Bug 19603] Move admin templates JavaScript to the footer: Patrons and
circulation
-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Nov  9 15:30:45 2017
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 09 Nov 2017 14:30:45 +0000
Subject: [Koha-bugs] [Bug 3841] Add a Default ACQ framework
In-Reply-To: <bug-3841-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-3841-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-3841-70-cJ1G5uAkRu@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=3841

Nicolas Legrand <nicolas.legrand at bulac.fr> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #68806|0                           |1
        is obsolete|                            |

--- Comment #10 from Nicolas Legrand <nicolas.legrand at bulac.fr> ---
Created attachment 69057
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=69057&action=edit
Bug 3841: Add the ACQ framework for new installations

This patch adds the acquisition frameworks (frameworkcode=ACQ) for new
installations.
It copies the 952 (MARC21) or 995 (UNIMARC) fields from the default
framework (frameworkcode='')

Test plan:
Create a new installation and make sure the ACQ framework exists.

Signed-off-by: Josef Moravec <josef.moravec at gmail.com>
Signed-off-by: Nicolas Legrand <nicolas.legrand at bulac.fr>

-- 
You are receiving this mail because:
You are the QA Contact for the bug.
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Nov  9 15:32:08 2017
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 09 Nov 2017 14:32:08 +0000
Subject: [Koha-bugs] [Bug 19603] Move admin templates JavaScript to the
 footer: Patrons and circulation
In-Reply-To: <bug-19603-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-19603-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-19603-70-hCdym8nRlT@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19603

Owen Leonard <oleonard at myacpl.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|ASSIGNED                    |Needs Signoff
   Patch complexity|---                         |Small patch

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Nov  9 15:32:11 2017
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 09 Nov 2017 14:32:11 +0000
Subject: [Koha-bugs] [Bug 19603] Move admin templates JavaScript to the
 footer: Patrons and circulation
In-Reply-To: <bug-19603-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-19603-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-19603-70-Z7RsMT1E5F@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19603

--- Comment #1 from Owen Leonard <oleonard at myacpl.org> ---
Created attachment 69058
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=69058&action=edit
Bug 19603: Move admin templates JavaScript to the footer: Patrons and
circulation

This patch modifies the staff client patrons and circulation-related
administration templates so that JavaScript is included in the footer
instead of the header.

To test, apply the patch and test the JavaScript-driven features of
each modified template: All button controls, DataTables functionality,
tabs, etc.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Nov  9 15:35:02 2017
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 09 Nov 2017 14:35:02 +0000
Subject: [Koha-bugs] [Bug 16828] Item Overlay does not respect Bibliographic
	Record Match
In-Reply-To: <bug-16828-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-16828-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-16828-70-EYhwckV8zV@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16828

Marjorie Barry-Vila <marjorie.barry-vila at collecto.ca> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |marjorie.barry-vila at collect
                   |                            |o.ca

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Nov  9 15:49:48 2017
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 09 Nov 2017 14:49:48 +0000
Subject: [Koha-bugs] [Bug 19560] Special characters & and # in branchcode -
 unable to delete branch
In-Reply-To: <bug-19560-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-19560-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-19560-70-CHxKEucgtF@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19560

Owen Leonard <oleonard at myacpl.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
           Assignee|koha-bugs at lists.koha-commun |oleonard at myacpl.org
                   |ity.org                     |
            Version|17.05                       |master
           Severity|enhancement                 |normal
             Status|NEW                         |ASSIGNED

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Nov  9 15:50:10 2017
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 09 Nov 2017 14:50:10 +0000
Subject: [Koha-bugs] [Bug 7317] Add an Interlibrary Loan Module to
	Circulation and OPAC
In-Reply-To: <bug-7317-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-7317-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-7317-70-1m9B2CtKx3@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7317

Tom?s Cohen Arazi <tomascohen at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #69056|0                           |1
        is obsolete|                            |

--- Comment #200 from Tom?s Cohen Arazi <tomascohen at gmail.com> ---
Created attachment 69059
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=69059&action=edit
Bug 7317: (QA followup) Make query parameters consistent with other endpoints

Signed-off-by: Tomas Cohen Arazi <tomascohen at theke.io>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Nov  9 15:50:25 2017
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 09 Nov 2017 14:50:25 +0000
Subject: [Koha-bugs] [Bug 7317] Add an Interlibrary Loan Module to
	Circulation and OPAC
In-Reply-To: <bug-7317-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-7317-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-7317-70-yfP6SPiZR0@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7317

--- Comment #201 from Tom?s Cohen Arazi <tomascohen at gmail.com> ---
Created attachment 69060
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=69060&action=edit
Bug 7317: Fix infinite loop in OPAC

Signed-off-by: Tomas Cohen Arazi <tomascohen at theke.io>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Nov  9 15:55:25 2017
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 09 Nov 2017 14:55:25 +0000
Subject: [Koha-bugs] [Bug 7317] Add an Interlibrary Loan Module to
	Circulation and OPAC
In-Reply-To: <bug-7317-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-7317-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-7317-70-PbjZep2iIl@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7317

--- Comment #202 from Tom?s Cohen Arazi <tomascohen at gmail.com> ---
Created attachment 69061
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=69061&action=edit
Bug 7317: (QA followup) Remove MySQL-ism from Koha::Illrequest::_limit_counter

This trivial fix changes the query syntax to avoid MySQL-isms.

To test:
- Run:
  $ kshell
 k$ prove t/db_dependent/Illrequests.t
=> SUCCESS: Tests pass!
- Apply this patch
- Run:
 k$ prove t/db_dependent/Illrequests.t
=> SUCCESS: Tests still pass!

Signed-off-by: Tomas Cohen Arazi <tomascohen at theke.io>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Nov  9 16:13:29 2017
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 09 Nov 2017 15:13:29 +0000
Subject: [Koha-bugs] [Bug 19560] Unable to delete branch when branchcode
 contains special characters
In-Reply-To: <bug-19560-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-19560-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-19560-70-91QCemqycv@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19560

Owen Leonard <oleonard at myacpl.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
            Summary|Special characters & and #  |Unable to delete branch
                   |in branchcode - unable to   |when branchcode contains
                   |delete branch               |special characters

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Nov  9 16:16:34 2017
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 09 Nov 2017 15:16:34 +0000
Subject: [Koha-bugs] [Bug 19560] Unable to delete library when branchcode
 contains special characters
In-Reply-To: <bug-19560-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-19560-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-19560-70-TLwe4ASZyn@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19560

Owen Leonard <oleonard at myacpl.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
            Summary|Unable to delete branch     |Unable to delete library
                   |when branchcode contains    |when branchcode contains
                   |special characters          |special characters

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Nov  9 16:21:41 2017
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 09 Nov 2017 15:21:41 +0000
Subject: [Koha-bugs] [Bug 19560] Unable to delete library when branchcode
 contains special characters
In-Reply-To: <bug-19560-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-19560-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-19560-70-NtQXL8hfNN@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19560

Owen Leonard <oleonard at myacpl.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
   Patch complexity|---                         |Small patch
             Status|ASSIGNED                    |Needs Signoff

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Nov  9 16:21:44 2017
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 09 Nov 2017 15:21:44 +0000
Subject: [Koha-bugs] [Bug 19560] Unable to delete library when branchcode
 contains special characters
In-Reply-To: <bug-19560-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-19560-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-19560-70-oR5NbsRx12@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19560

--- Comment #1 from Owen Leonard <oleonard at myacpl.org> ---
Created attachment 69062
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=69062&action=edit
Bug 19560: Unable to delete library when branchcode contains special characters

This patch modifies the library administration page so that the library
delete button submits a form using POST rather than linking to the
delete operation with GET variables.

This patch also adds validation to the library entry form so that it
will only accept letters, numbers, hyphen, and underscore.

The validation method for this already existed in categories.js, so it
has been moved to staff-global.js and the validator warning message has
been moved to validator-strings.inc so it is included globally.

To test:
  - Add a library with a branchcode containing characters like & or
    #.
  - Apply the patch and clear your browser cache if necessary.
  - Try to delete the new library. It should delete successfully.
  - Add a library again and try to include spaces and/or special
    characters in the branchcode. The form validation script should
    prevent you from submitting the form.
  - Go do Administration -> Patron categories and add a new patron
    category. The category code field should prevent you from entering a
    code with spaces or special characters.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Nov  9 16:22:32 2017
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 09 Nov 2017 15:22:32 +0000
Subject: [Koha-bugs] [Bug 7317] Add an Interlibrary Loan Module to
	Circulation and OPAC
In-Reply-To: <bug-7317-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-7317-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-7317-70-98ue6dNE8O@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7317

--- Comment #203 from Jonathan Druart <jonathan.druart at bugs.koha-community.org> ---
Created attachment 69063
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=69063&action=edit
Bug 7317: Help translators removing TT tags from po files

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Nov  9 16:25:56 2017
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 09 Nov 2017 15:25:56 +0000
Subject: [Koha-bugs] [Bug 7317] Add an Interlibrary Loan Module to
	Circulation and OPAC
In-Reply-To: <bug-7317-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-7317-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-7317-70-mLAW6H59Qy@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7317

Jonathan Druart <jonathan.druart at bugs.koha-community.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #69063|0                           |1
        is obsolete|                            |

--- Comment #204 from Jonathan Druart <jonathan.druart at bugs.koha-community.org> ---
Created attachment 69064
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=69064&action=edit
Bug 7317: Help translators removing TT tags from po files

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Nov  9 16:36:45 2017
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 09 Nov 2017 15:36:45 +0000
Subject: [Koha-bugs] [Bug 7317] Add an Interlibrary Loan Module to
	Circulation and OPAC
In-Reply-To: <bug-7317-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-7317-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-7317-70-stEkkEr5bn@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7317

Jonathan Druart <jonathan.druart at bugs.koha-community.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #69064|0                           |1
        is obsolete|                            |

--- Comment #205 from Jonathan Druart <jonathan.druart at bugs.koha-community.org> ---
Created attachment 69065
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=69065&action=edit
Bug 7317: Simplify column headers

It will help translators (remove TT tags from po files) and simplify the
code. We do not need this translate_column that is used only once.
It also removes sorting option on the last column (actions)

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Nov  9 16:43:30 2017
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 09 Nov 2017 15:43:30 +0000
Subject: [Koha-bugs] [Bug 19573] Link to make a new list in masthead in OPAC
 only appears / works if no other list already exists
In-Reply-To: <bug-19573-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-19573-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-19573-70-J6oKIrWl4J@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19573

Owen Leonard <oleonard at myacpl.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
            Version|17.05                       |master
             Status|NEW                         |ASSIGNED

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Nov  9 16:51:41 2017
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 09 Nov 2017 15:51:41 +0000
Subject: [Koha-bugs] [Bug 7317] Add an Interlibrary Loan Module to
	Circulation and OPAC
In-Reply-To: <bug-7317-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-7317-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-7317-70-tM6Px3CF7B@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7317

--- Comment #206 from Jonathan Druart <jonathan.druart at bugs.koha-community.org> ---
Created attachment 69066
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=69066&action=edit
Bug 7317: Do not use GET for deletion requests

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Nov  9 16:58:31 2017
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 09 Nov 2017 15:58:31 +0000
Subject: [Koha-bugs] [Bug 19573] Link to make a new list in masthead in OPAC
 only appears / works if no other list already exists
In-Reply-To: <bug-19573-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-19573-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-19573-70-2iYPo79QyV@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19573

Owen Leonard <oleonard at myacpl.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
   Patch complexity|---                         |Trivial patch
             Status|ASSIGNED                    |Needs Signoff

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Nov  9 16:58:33 2017
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 09 Nov 2017 15:58:33 +0000
Subject: [Koha-bugs] [Bug 19573] Link to make a new list in masthead in OPAC
 only appears / works if no other list already exists
In-Reply-To: <bug-19573-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-19573-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-19573-70-iD8jbICPls@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19573

--- Comment #1 from Owen Leonard <oleonard at myacpl.org> ---
Created attachment 69067
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=69067&action=edit
Bug 19573: Link to make a new list in masthead in OPAC only appears / works if
no other list already exists

This patch corrects the OPAC masthead include file so that the "New
list" link will appear whether or not the logged-in user has existing
private lists.

To test, apply the patch and log into the OPAC as both a user with
private lists and a user without private lists. The header's "Lists"
dropdown menu should include a "New list" link in both cases.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Nov  9 17:11:37 2017
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 09 Nov 2017 16:11:37 +0000
Subject: [Koha-bugs] [Bug 9302] Add ability to merge patron records
In-Reply-To: <bug-9302-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-9302-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-9302-70-rqc2zNTrNp@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9302

--- Comment #13 from Owen Leonard <oleonard at myacpl.org> ---
This doesn't work for me at all. When I select the patron record to keep and
submit the form, I'm redirected to a page which says "Patron records merged
into ()" and the records have not been merged.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Nov  9 17:12:26 2017
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 09 Nov 2017 16:12:26 +0000
Subject: [Koha-bugs] [Bug 19600] Move admin templates JavaScript to the
 footer: Other catalog pages
In-Reply-To: <bug-19600-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-19600-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-19600-70-6NwMV3w31a@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19600

Simon Pouchol <simon.pouchol at biblibre.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Needs Signoff               |Signed Off

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Nov  9 17:12:13 2017
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 09 Nov 2017 16:12:13 +0000
Subject: [Koha-bugs] [Bug 19600] Move admin templates JavaScript to the
 footer: Other catalog pages
In-Reply-To: <bug-19600-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-19600-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-19600-70-LMf8jpdbUl@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19600

Simon Pouchol <simon.pouchol at biblibre.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #69053|0                           |1
        is obsolete|                            |

--- Comment #3 from Simon Pouchol <simon.pouchol at biblibre.com> ---
Created attachment 69068
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=69068&action=edit
Bug 19600: Move admin templates JavaScript to the footer: Other catalog pages

This patch modifies the staff client catalog-related administration
templates so that JavaScript is included in the footer instead of the
header.

To test, apply the patch and test the JavaScript-driven features of
each modified template: All button controls, DataTables functionality,
tabs, etc.

Signed-off-by: Simon Pouchol <simon.pouchol at biblibre.com>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Nov  9 17:22:04 2017
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 09 Nov 2017 16:22:04 +0000
Subject: [Koha-bugs] [Bug 15814] Templates for MARC modification: Edit
 action does not work when Description contains '
In-Reply-To: <bug-15814-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-15814-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-15814-70-oTYjQFDuNo@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15814

--- Comment #3 from Owen Leonard <oleonard at myacpl.org> ---
I'd really like to see this template overhauled to eliminate all the onclicks.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Nov  9 17:23:43 2017
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 09 Nov 2017 16:23:43 +0000
Subject: [Koha-bugs] [Bug 19604] New: Elasticsearch Fixes for
 build_authorities_query for auth searching
Message-ID: <bug-19604-70@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19604

            Bug ID: 19604
           Summary: Elasticsearch Fixes for build_authorities_query for
                    auth searching
 Change sponsored?: ---
           Product: Koha
           Version: master
          Hardware: All
                OS: All
            Status: NEW
          Severity: enhancement
          Priority: P5 - low
         Component: Searching - Elasticsearch
          Assignee: koha-bugs at lists.koha-community.org
          Reporter: nick at bywatersolutions.com

Some of the searches here were based on older syntax and caused errors

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Nov  9 17:27:33 2017
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 09 Nov 2017 16:27:33 +0000
Subject: [Koha-bugs] [Bug 7317] Add an Interlibrary Loan Module to
	Circulation and OPAC
In-Reply-To: <bug-7317-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-7317-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-7317-70-LgDCJivsim@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7317

--- Comment #207 from Jonathan Druart <jonathan.druart at bugs.koha-community.org> ---
Created attachment 69069
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=69069&action=edit
Bug 7317: Make fields mandatory when sending emails

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Nov  9 17:27:41 2017
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 09 Nov 2017 16:27:41 +0000
Subject: [Koha-bugs] [Bug 7317] Add an Interlibrary Loan Module to
	Circulation and OPAC
In-Reply-To: <bug-7317-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-7317-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-7317-70-ir3TsDJwsr@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7317

--- Comment #208 from Jonathan Druart <jonathan.druart at bugs.koha-community.org> ---
Created attachment 69070
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=69070&action=edit
Bug 7317: Display all the libraries, not only one

Before this patch only the first library defined in the system where
displayed.
TODO: Make sure we want to display all the libraries and not a
"filtered" list
see `git grep PROCESS options_for_libraries libraries|grep unfiltered`

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Nov  9 17:28:57 2017
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 09 Nov 2017 16:28:57 +0000
Subject: [Koha-bugs] [Bug 19591] Saving a system preference jumps to main
	page
In-Reply-To: <bug-19591-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-19591-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-19591-70-SDObtOt0ue@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19591

--- Comment #1 from Owen Leonard <oleonard at myacpl.org> ---
When you save a system preference the page shouldn't refresh at all. The change
happens behind the scenes and a message should pop up briefly indicating
success.

If you find that clicking the save button redirects the page, you might have a
JavaScript error somewhere. Do you have something in the IntranetUserJS system
preference?

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.

From bugzilla-daemon at bugs.koha-community.org  Thu Nov  9 17:29:16 2017
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 09 Nov 2017 16:29:16 +0000
Subject: [Koha-bugs] [Bug 7317] Add an Interlibrary Loan Module to
	Circulation and OPAC
In-Reply-To: <bug-7317-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-7317-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-7317-70-QVAxNhO8dD@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7317

Jonathan Druart <jonathan.druart at bugs.koha-community.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #69070|0                           |1
        is obsolete|                            |

--- Comment #209 from Jonathan Druart <jonathan.druart at bugs.koha-community.org> ---
Created attachment 69071
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=69071&action=edit
Bug 7317: Display all the libraries, not only one

Before this patch only the first library defined in the system where
displayed.
TODO: Make sure we want to display all the libraries and not a
"filtered" list
see `git grep PROCESS options_for_libraries libraries|grep unfiltered`

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Nov  9 17:31:40 2017
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 09 Nov 2017 16:31:40 +0000
Subject: [Koha-bugs] [Bug 19604] Elasticsearch Fixes for
 build_authorities_query for auth searching
In-Reply-To: <bug-19604-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-19604-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-19604-70-m6Mmz89Qct@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19604

Nick Clemens <nick at bywatersolutions.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|NEW                         |Needs Signoff
         Depends on|                            |19582


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19582
[Bug 19582] Elasticsearch: Auth-finder.pl must use search_auth_compat
-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.

From bugzilla-daemon at bugs.koha-community.org  Thu Nov  9 17:31:40 2017
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 09 Nov 2017 16:31:40 +0000
Subject: [Koha-bugs] [Bug 19582] Elasticsearch: Auth-finder.pl must use
 search_auth_compat
In-Reply-To: <bug-19582-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-19582-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-19582-70-1av3mc16No@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19582

Nick Clemens <nick at bywatersolutions.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Blocks|                            |19604


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19604
[Bug 19604] Elasticsearch Fixes for build_authorities_query for auth searching
-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Nov  9 17:31:43 2017
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 09 Nov 2017 16:31:43 +0000
Subject: [Koha-bugs] [Bug 19604] Elasticsearch Fixes for
 build_authorities_query for auth searching
In-Reply-To: <bug-19604-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-19604-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-19604-70-9YHBTmzx0N@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19604

--- Comment #1 from Nick Clemens <nick at bywatersolutions.com> ---
Created attachment 69072
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=69072&action=edit
Bug 19604: Elasticsearch Fixes for build_authorities_query for auth searching

To test:
1 - Do some authority searches in Zebra
2 - Switch to ES and repeat, results will vary and some may fail
3 - Apply patch and dependencies
4 - Reindex ES
5 - Repeat searches, they should suceed and results should be similar to
Zebra
6 - Slight differences are okay, but results should (mostly) meet
expectations

A few notes:
We add a 'normalizer' to ensure we get a single token from the heading
indexes, this makes 'starts with' work as expcted
We switch to 'AND' for fields searched from cataloging editor - this
matches Zebra results
We force the '__sort' fields for sorting - if sorting looks wrong try
reducing the heading field to a single subfield - this will need to be
addressed on a future bug (multiple subfields create an array, ES sorts
        those randomly)

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Nov  9 17:32:00 2017
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 09 Nov 2017 16:32:00 +0000
Subject: [Koha-bugs] [Bug 7317] Add an Interlibrary Loan Module to
	Circulation and OPAC
In-Reply-To: <bug-7317-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-7317-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-7317-70-mxkbqZFsHT@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7317

Jonathan Druart <jonathan.druart at bugs.koha-community.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
           Keywords|                            |release-notes-needed

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Nov  9 17:33:32 2017
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 09 Nov 2017 16:33:32 +0000
Subject: [Koha-bugs] [Bug 7317] Add an Interlibrary Loan Module to
	Circulation and OPAC
In-Reply-To: <bug-7317-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-7317-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-7317-70-7HzX9IxCJT@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7317

Jonathan Druart <jonathan.druart at bugs.koha-community.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Passed QA                   |Pushed to Master

--- Comment #210 from Jonathan Druart <jonathan.druart at bugs.koha-community.org> ---
Pushed to master for 17.11, thanks to everybody involved!

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Nov  9 17:39:28 2017
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 09 Nov 2017 16:39:28 +0000
Subject: [Koha-bugs] [Bug 13412] Allow configuration of auto-created
	authorities
In-Reply-To: <bug-13412-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-13412-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-13412-70-QzuzCzf4jp@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13412

Patrick Robitaille <patrick.robitaille at collecto.ca> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |patrick.robitaille at collecto
                   |                            |.ca

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Nov  9 17:42:18 2017
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 09 Nov 2017 16:42:18 +0000
Subject: [Koha-bugs] [Bug 19595] Clicking plugin link does not fill item's
 date acquired field
In-Reply-To: <bug-19595-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-19595-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-19595-70-WCzyOczHFw@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19595

--- Comment #3 from Owen Leonard <oleonard at myacpl.org> ---
I consider this a bug BECAUSE it is a change in behavior. Functionality which
my catalogers used daily has been removed, making their work more difficult.

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.

From bugzilla-daemon at bugs.koha-community.org  Thu Nov  9 17:48:10 2017
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 09 Nov 2017 16:48:10 +0000
Subject: [Koha-bugs] [Bug 19602] Add usage statistics link to administration
	sidebar menu
In-Reply-To: <bug-19602-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-19602-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-19602-70-ogANz0hFeq@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19602

Owen Leonard <oleonard at myacpl.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|NEW                         |ASSIGNED

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Nov  9 17:52:12 2017
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 09 Nov 2017 16:52:12 +0000
Subject: [Koha-bugs] [Bug 19602] Add usage statistics link to administration
	sidebar menu
In-Reply-To: <bug-19602-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-19602-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-19602-70-KlJe4oBJPr@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19602

Owen Leonard <oleonard at myacpl.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
   Patch complexity|---                         |Trivial patch
             Status|ASSIGNED                    |Needs Signoff

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Nov  9 17:52:15 2017
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 09 Nov 2017 16:52:15 +0000
Subject: [Koha-bugs] [Bug 19602] Add usage statistics link to administration
	sidebar menu
In-Reply-To: <bug-19602-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-19602-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-19602-70-OBdAchEibO@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19602

--- Comment #1 from Owen Leonard <oleonard at myacpl.org> ---
Created attachment 69073
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=69073&action=edit
Bug 19602 - Add usage statistics link to administration sidebar menu

This patch adds a like to the new usage statistics page in the
administration sidebar menu.

To test, apply the patch and view an administration page which includes
the admin sidebar. Confirm that the link to usage statistics is there.

Visit the usage statistics page and confirm that the usage statistics
link in the sidebar is display in bold.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Nov  9 17:54:04 2017
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 09 Nov 2017 16:54:04 +0000
Subject: [Koha-bugs] [Bug 19605] New: ILL backends should be pluggable
 through regular Koha plugins
Message-ID: <bug-19605-70@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19605

            Bug ID: 19605
           Summary: ILL backends should be pluggable through regular Koha
                    plugins
 Change sponsored?: ---
           Product: Koha
           Version: master
          Hardware: All
                OS: All
            Status: NEW
          Severity: enhancement
          Priority: P5 - low
         Component: Architecture, internals, and plumbing
          Assignee: koha-bugs at lists.koha-community.org
          Reporter: tomascohen at gmail.com
        QA Contact: testopia at bugs.koha-community.org

Right now, the ILL module requires a configuration entry for a path in which to
look for the backend implementations. This should be implemented in a more
simple way for end-users.

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Nov  9 18:00:05 2017
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 09 Nov 2017 17:00:05 +0000
Subject: [Koha-bugs] [Bug 11360] Disable barcode field and submit button
 when a hold is found
In-Reply-To: <bug-11360-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-11360-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-11360-70-5RV43nZ8xv@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11360

--- Comment #65 from Owen Leonard <oleonard at myacpl.org> ---
*** Bug 11899 has been marked as a duplicate of this bug. ***

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Nov  9 18:00:05 2017
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 09 Nov 2017 17:00:05 +0000
Subject: [Koha-bugs] [Bug 11899] Force staff to choose option for filling a
	hold
In-Reply-To: <bug-11899-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-11899-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-11899-70-dNpJW40oBh@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11899

Owen Leonard <oleonard at myacpl.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
         Resolution|---                         |DUPLICATE
             Status|NEW                         |RESOLVED

--- Comment #1 from Owen Leonard <oleonard at myacpl.org> ---


*** This bug has been marked as a duplicate of bug 11360 ***

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.

From bugzilla-daemon at bugs.koha-community.org  Thu Nov  9 18:09:26 2017
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 09 Nov 2017 17:09:26 +0000
Subject: [Koha-bugs] [Bug 19595] Clicking plugin link does not fill item's
 date acquired field
In-Reply-To: <bug-19595-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-19595-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-19595-70-CSzd3Zj8fu@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19595

--- Comment #4 from Jonathan Druart <jonathan.druart at bugs.koha-community.org> ---
(In reply to Marcel de Rooy from comment #1)
> If you hover your mouse over the "plugin link", you will see "No popup".

I see "Tag editor"

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.

From bugzilla-daemon at bugs.koha-community.org  Thu Nov  9 18:23:39 2017
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 09 Nov 2017 17:23:39 +0000
Subject: [Koha-bugs] [Bug 7317] Add an Interlibrary Loan Module to
	Circulation and OPAC
In-Reply-To: <bug-7317-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-7317-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-7317-70-2sDO1GOcTa@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7317

--- Comment #211 from Jonathan Druart <jonathan.druart at bugs.koha-community.org> ---
Created attachment 69074
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=69074&action=edit
Bug 7317: Fix translatable-templates.t failure

Failed with
 /tmp/Lqv0BH2xC9:7979:13: invalid multibyte sequence
 msgmerge: found 1 fatal error

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Nov  9 19:21:44 2017
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 09 Nov 2017 18:21:44 +0000
Subject: [Koha-bugs] [Bug 18499] catalog 'Call Number Browser' on edit items
 screen does not sort on items.cn_sort
In-Reply-To: <bug-18499-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-18499-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-18499-70-1SjMptf1RR@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18499

Marjorie Barry-Vila <marjorie.barry-vila at collecto.ca> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |marjorie.barry-vila at collect
                   |                            |o.ca

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Nov  9 21:47:48 2017
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 09 Nov 2017 20:47:48 +0000
Subject: [Koha-bugs] [Bug 15161] Sorting by Title does not include volume/
 part information from $p and $n
In-Reply-To: <bug-15161-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-15161-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-15161-70-ULdrby4NmV@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15161

Marjorie Barry-Vila <marjorie.barry-vila at collecto.ca> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |marjorie.barry-vila at collect
                   |                            |o.ca

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Nov 10 07:49:11 2017
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 10 Nov 2017 06:49:11 +0000
Subject: [Koha-bugs] [Bug 19348] Title column in item search is too narrow
In-Reply-To: <bug-19348-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-19348-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-19348-70-9cYe9YdcMl@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19348

--- Comment #6 from Katrin Fischer <katrin.fischer at bsz-bw.de> ---
This might be interesting for backporting (almost a bug).

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Nov 10 07:49:36 2017
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 10 Nov 2017 06:49:36 +0000
Subject: [Koha-bugs] [Bug 18292] Tests do not need to return 1;
In-Reply-To: <bug-18292-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-18292-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-18292-70-kapuP0h9Qb@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18292

Katrin Fischer <katrin.fischer at bsz-bw.de> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
          Component|Circulation                 |Test Suite

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Nov 10 07:53:33 2017
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 10 Nov 2017 06:53:33 +0000
Subject: [Koha-bugs] [Bug 19258] Fix warns when paying or writing off a fine
	or charge
In-Reply-To: <bug-19258-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-19258-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-19258-70-ZoMJvPje54@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19258

Katrin Fischer <katrin.fischer at bsz-bw.de> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
           Severity|enhancement                 |minor
            Summary|Warn when paying or writing |Fix warns when paying or
                   |off a fine or charge        |writing off a fine or
                   |                            |charge

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Nov 10 10:29:20 2017
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 10 Nov 2017 09:29:20 +0000
Subject: [Koha-bugs] [Bug 19606] New: 773$g is not showing if 773$0 -
 MARC21slim2OPACDetail.xsl
Message-ID: <bug-19606-70@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19606

            Bug ID: 19606
           Summary: 773$g is not showing if 773$0 -
                    MARC21slim2OPACDetail.xsl
 Change sponsored?: ---
           Product: Koha
           Version: unspecified
          Hardware: All
                OS: All
            Status: NEW
          Severity: enhancement
          Priority: P5 - low
         Component: OPAC
          Assignee: oleonard at myacpl.org
          Reporter: hagud at orex.es
        QA Contact: testopia at bugs.koha-community.org

we have seen a possible bug in MARC21slim2OPACDetail.xsl

We have identified for those bibliographic records that have 773$t and 773$g
and 773$0, Koha only show 773$t, because 773$g is not declare when 773$0, it is
declared in all other cases.


It is-->
<xsl:when test="marc:subfield[@code='0']">
 <a><xsl:attribute
name="href">/cgi-bin/koha/opac-detail.pl?biblionumber=<xsl:value-of
select="marc:subfield[@code='0']"/></xsl:attribute>
 <xsl:value-of select="$f773"/>
 </a>

It is -->
 <xsl:when test="marc:subfield[@code='0']">
 <a><xsl:attribute
name="href">/cgi-bin/koha/opac-detail.pl?biblionumber=<xsl:value-of
select="marc:subfield[@code='0']"/></xsl:attribute>
 <xsl:value-of select="$f773"/>
 </a>

<xsl:if test="marc:subfield[@code='g']"><xsl:text>; </xsl:text><xsl:value-of
select="marc:subfield[@code='g']"/></xsl:if>
 </xsl:when>

do you agree?

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Nov 10 10:37:18 2017
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 10 Nov 2017 09:37:18 +0000
Subject: [Koha-bugs] [Bug 19559] Elasticsearch QueryAutoTruncate truncate
 field names with hyphens if data is quoted
In-Reply-To: <bug-19559-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-19559-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-19559-70-wenpvFU4FY@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19559

Julian Maurice <julian.maurice at biblibre.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
         QA Contact|                            |julian.maurice at biblibre.com

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Nov 10 10:42:50 2017
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 10 Nov 2017 09:42:50 +0000
Subject: [Koha-bugs] [Bug 19559] Elasticsearch QueryAutoTruncate truncate
 field names with hyphens if data is quoted
In-Reply-To: <bug-19559-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-19559-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-19559-70-5JpDD0bUES@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19559

Julian Maurice <julian.maurice at biblibre.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #68924|0                           |1
        is obsolete|                            |

--- Comment #9 from Julian Maurice <julian.maurice at biblibre.com> ---
Created attachment 69075
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=69075&action=edit
Bug 19559 - Unit tests

Signed-off-by: David Bourgault <david.bourgault at inlibro.com>
Signed-off-by: Julian Maurice <julian.maurice at biblibre.com>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Nov 10 10:43:04 2017
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 10 Nov 2017 09:43:04 +0000
Subject: [Koha-bugs] [Bug 19559] Elasticsearch QueryAutoTruncate truncate
 field names with hyphens if data is quoted
In-Reply-To: <bug-19559-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-19559-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-19559-70-TeDOoxDDZw@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19559

Julian Maurice <julian.maurice at biblibre.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Signed Off                  |Passed QA

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Nov 10 10:42:54 2017
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 10 Nov 2017 09:42:54 +0000
Subject: [Koha-bugs] [Bug 19559] Elasticsearch QueryAutoTruncate truncate
 field names with hyphens if data is quoted
In-Reply-To: <bug-19559-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-19559-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-19559-70-vLc9MRmhpR@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19559

Julian Maurice <julian.maurice at biblibre.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #68925|0                           |1
        is obsolete|                            |

--- Comment #10 from Julian Maurice <julian.maurice at biblibre.com> ---
Created attachment 69076
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=69076&action=edit
Bug 19559 - Add '-' to list of characters we don't split search terms on

Test plan assumes
QueryAutoTruncate = automatically
SearchEngine = Elasticsearch

To test:
0 - Apply Unit test patch only
1 - prove t/db_dependent/Koha_SearchEngine_Elasticsearch_Search.t
2 - Should fail
3 - Apply this patch
4 - prove t/db_dependent/Koha_SearchEngine_Elasticsearch_Search.t
5 - should pass
6 - search for 'Local-number:"4"' (or a vlid biblionumber)
7 - should get expected result

Signed-off-by: David Bourgault <david.bourgault at inlibro.com>
Signed-off-by: Julian Maurice <julian.maurice at biblibre.com>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Nov 10 10:53:31 2017
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 10 Nov 2017 09:53:31 +0000
Subject: [Koha-bugs] [Bug 19036] Number payment receipts / payment slips
In-Reply-To: <bug-19036-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-19036-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-19036-70-MAhTul6byR@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19036

Katrin Fischer <katrin.fischer at bsz-bw.de> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
            Summary|Numer payment receipts /    |Number payment receipts /
                   |payment slips               |payment slips

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.

From bugzilla-daemon at bugs.koha-community.org  Fri Nov 10 10:59:19 2017
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 10 Nov 2017 09:59:19 +0000
Subject: [Koha-bugs] [Bug 16820] Add possibility to edit fines
In-Reply-To: <bug-16820-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-16820-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-16820-70-etyWQUG2sP@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16820

--- Comment #4 from Katrin Fischer <katrin.fischer at bsz-bw.de> ---
Please also consider to add a separate permission for this, some libraries
might consider it dangerous or not want everyone to be able to do this.

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.

From bugzilla-daemon at bugs.koha-community.org  Fri Nov 10 11:06:50 2017
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 10 Nov 2017 10:06:50 +0000
Subject: [Koha-bugs] [Bug 19481] Elasticsearch - Set default fields for
 sorting in mappings.yaml
In-Reply-To: <bug-19481-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-19481-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-19481-70-VAmdUUwH5r@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19481

Julian Maurice <julian.maurice at biblibre.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |julian.maurice at biblibre.com
         QA Contact|                            |julian.maurice at biblibre.com

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Nov 10 11:34:11 2017
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 10 Nov 2017 10:34:11 +0000
Subject: [Koha-bugs] [Bug 19481] Elasticsearch - Set default fields for
 sorting in mappings.yaml
In-Reply-To: <bug-19481-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-19481-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-19481-70-ZxUr5062lo@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19481

--- Comment #6 from Julian Maurice <julian.maurice at biblibre.com> ---
Patch works as described (except for popularity when in UNIMARC, since the
field is not defined).
But I wonder about 6th step in test plan. Shouldn't it be done in an
updatedatabase script ?

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Nov 10 12:01:35 2017
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 10 Nov 2017 11:01:35 +0000
Subject: [Koha-bugs] [Bug 19439] Some error responses from opac/unapi get
	lost in eval
In-Reply-To: <bug-19439-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-19439-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-19439-70-GL51MyTSxt@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19439

Marcel de Rooy <m.de.rooy at rijksmuseum.nl> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |jonathan.druart at bugs.koha-c
                   |                            |ommunity.org

--- Comment #6 from Marcel de Rooy <m.de.rooy at rijksmuseum.nl> ---
Jonathan: Would you consider this one as a bugfix too ?

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Nov 10 12:21:52 2017
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 10 Nov 2017 11:21:52 +0000
Subject: [Koha-bugs] [Bug 18856] Cancel Waiting Hold in OPAC does not give
	useful message
In-Reply-To: <bug-18856-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-18856-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-18856-70-Bv3hQLAeju@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18856

Marcel de Rooy <m.de.rooy at rijksmuseum.nl> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |m.de.rooy at rijksmuseum.nl

--- Comment #6 from Marcel de Rooy <m.de.rooy at rijksmuseum.nl> ---
Just confirming the above by doublechecking the code:
Cancel button calls opac-modrequest.pl (once called only in opac-user)
opac-modrequest.pl checks with CanReserveBeCanceledFromOpac. This sub returns
false for waiting or transit.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Nov 10 12:22:46 2017
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 10 Nov 2017 11:22:46 +0000
Subject: [Koha-bugs] [Bug 18856] Cancel Waiting Hold in OPAC does not give
	useful message
In-Reply-To: <bug-18856-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-18856-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-18856-70-B6hKS5pCWQ@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18856

Marcel de Rooy <m.de.rooy at rijksmuseum.nl> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #67520|0                           |1
        is obsolete|                            |

--- Comment #7 from Marcel de Rooy <m.de.rooy at rijksmuseum.nl> ---
Created attachment 69077
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=69077&action=edit
Bug 18856 - Cancel Waiting Hold in OPAC does not give useful message

If a hold is 'waiting' for the patron to collect then the patron should be
prevented from cancelling the hold via their account in the opac.
If a patron tries to cancel the hold, Koha will give an 'are you sure' alert
and when you click Yes the page just refreshes and the hold remains.
Staff can cancel the hold from the staff interface but they can then action the
waiting hold.
I think therefore that it is correct behaviour that a patron cannot cancel a
hold when it reaches waiting state via the opac but it would be useful to
either have a warning to prevent the cancellation or a useful message when they
attempt to do so.

The template was using a method that tells Koha if *staff* can cancel a hold,
instead of patron.

Test Plan:
1) Set up a waiting hold
2) Try to cancel it from the opac
3) Note you cannot
4) Apply this patch
5) Reload the page
6) Note the cancel button has disappeared for found holds

Signed-off-by: Kyle M Hall <kyle at bywatersolutions.com>
Signed-off-by: Caroline Cyr La Rose <caroline.cyr-la-rose at inlibro.com>

Signed-off-by: Marcel de Rooy <m.de.rooy at rijksmuseum.nl>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Nov 10 12:22:57 2017
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 10 Nov 2017 11:22:57 +0000
Subject: [Koha-bugs] [Bug 18856] Cancel Waiting Hold in OPAC does not give
	useful message
In-Reply-To: <bug-18856-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-18856-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-18856-70-BN14sxJel3@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18856

Marcel de Rooy <m.de.rooy at rijksmuseum.nl> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
         QA Contact|testopia at bugs.koha-communit |m.de.rooy at rijksmuseum.nl
                   |y.org                       |

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Nov 10 12:22:43 2017
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 10 Nov 2017 11:22:43 +0000
Subject: [Koha-bugs] [Bug 18856] Cancel Waiting Hold in OPAC does not give
	useful message
In-Reply-To: <bug-18856-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-18856-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-18856-70-Z9myk4QbbY@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18856

Marcel de Rooy <m.de.rooy at rijksmuseum.nl> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Signed Off                  |Passed QA
   Patch complexity|---                         |Trivial patch

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Nov 10 12:29:54 2017
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 10 Nov 2017 11:29:54 +0000
Subject: [Koha-bugs] [Bug 18856] Cancel Waiting Hold in OPAC does not give
	useful message
In-Reply-To: <bug-18856-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-18856-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-18856-70-6puEGxqhwi@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18856

Marcel de Rooy <m.de.rooy at rijksmuseum.nl> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
            Version|16.11                       |master

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Nov 10 13:23:58 2017
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 10 Nov 2017 12:23:58 +0000
Subject: [Koha-bugs] [Bug 19601] Move admin templates JavaScript to the
 footer: Additional parameters
In-Reply-To: <bug-19601-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-19601-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-19601-70-0KAEuhJs9x@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19601

Simon Pouchol <simon.pouchol at biblibre.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #69055|0                           |1
        is obsolete|                            |

--- Comment #2 from Simon Pouchol <simon.pouchol at biblibre.com> ---
Created attachment 69078
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=69078&action=edit
Bug 19601: Move admin templates JavaScript to the footer: Additional parameters

This patch modifies the staff client "additional parameters"
administration templates so that JavaScript is included in the footer
instead of the header.

To test, apply the patch and test the JavaScript-driven features of
each page: All button controls, DataTables functionality, tabs, etc.

Signed-off-by: Simon Pouchol <simon.pouchol at biblibre.com>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Nov 10 13:24:09 2017
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 10 Nov 2017 12:24:09 +0000
Subject: [Koha-bugs] [Bug 19601] Move admin templates JavaScript to the
 footer: Additional parameters
In-Reply-To: <bug-19601-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-19601-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-19601-70-rsuZduI6LL@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19601

Simon Pouchol <simon.pouchol at biblibre.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Needs Signoff               |Signed Off

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Nov 10 13:26:50 2017
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 10 Nov 2017 12:26:50 +0000
Subject: [Koha-bugs] [Bug 19603] Move admin templates JavaScript to the
 footer: Patrons and circulation
In-Reply-To: <bug-19603-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-19603-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-19603-70-pYVnkfrAVv@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19603

--- Comment #2 from Simon Pouchol <simon.pouchol at biblibre.com> ---
Hi Owen,
I was unable to apply this patch :
fatal: sha1 information is lacking or useless
(koha-tmpl/intranet-tmpl/prog/en/modules/admin/smart-rules.tt).

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Nov 10 13:39:38 2017
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 10 Nov 2017 12:39:38 +0000
Subject: [Koha-bugs] [Bug 19602] Add usage statistics link to administration
	sidebar menu
In-Reply-To: <bug-19602-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-19602-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-19602-70-gubJx1srtu@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19602

Simon Pouchol <simon.pouchol at biblibre.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #69073|0                           |1
        is obsolete|                            |

--- Comment #2 from Simon Pouchol <simon.pouchol at biblibre.com> ---
Created attachment 69079
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=69079&action=edit
Bug 19602 - Add usage statistics link to administration sidebar menu

This patch adds a link to the new usage statistics page in the
administration sidebar menu.

To test, apply the patch and view an administration page which includes
the admin sidebar. Confirm that the link to usage statistics is there.

Visit the usage statistics page and confirm that the usage statistics
link in the sidebar is display in bold.

Signed-off-by: Simon Pouchol <simon.pouchol at biblibre.com>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Nov 10 13:39:53 2017
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 10 Nov 2017 12:39:53 +0000
Subject: [Koha-bugs] [Bug 19602] Add usage statistics link to administration
	sidebar menu
In-Reply-To: <bug-19602-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-19602-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-19602-70-YcqbgMdPdD@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19602

Simon Pouchol <simon.pouchol at biblibre.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Needs Signoff               |Signed Off
                 CC|                            |simon.pouchol at biblibre.com

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Nov 10 13:45:12 2017
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 10 Nov 2017 12:45:12 +0000
Subject: [Koha-bugs] [Bug 18990] Overdue Notices are not sending through SMS
	correctly
In-Reply-To: <bug-18990-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-18990-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-18990-70-jMzv5NIWsX@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18990

Marcel de Rooy <m.de.rooy at rijksmuseum.nl> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
   Patch complexity|---                         |Small patch
             Status|Signed Off                  |Passed QA

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Nov 10 13:45:32 2017
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 10 Nov 2017 12:45:32 +0000
Subject: [Koha-bugs] [Bug 18990] Overdue Notices are not sending through SMS
	correctly
In-Reply-To: <bug-18990-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-18990-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-18990-70-qznDlrL3US@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18990

Marcel de Rooy <m.de.rooy at rijksmuseum.nl> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
            Version|16.11                       |master
         QA Contact|testopia at bugs.koha-communit |m.de.rooy at rijksmuseum.nl
                   |y.org                       |

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Nov 10 13:45:15 2017
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 10 Nov 2017 12:45:15 +0000
Subject: [Koha-bugs] [Bug 18990] Overdue Notices are not sending through SMS
	correctly
In-Reply-To: <bug-18990-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-18990-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-18990-70-sssSwCwsAk@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18990

Marcel de Rooy <m.de.rooy at rijksmuseum.nl> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #67686|0                           |1
        is obsolete|                            |

--- Comment #4 from Marcel de Rooy <m.de.rooy at rijksmuseum.nl> ---
Created attachment 69080
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=69080&action=edit
Bug 18990 - Overdue Notices are not sending through SMS correctly

Bug 18478 fixed sms via email problems under the assumption that
to_address was either smsalertnumber or blank.

It seems overdues set the to_address to email. This patch changes the
code to enforce that an sms sent with emial driver will use the
smsalertnumebr and provider defined for the borrower, regardless of what
is set in the queue

To test:
 1 - Define a messaging prefs for a patron to recieve hold notices via
  SMS
 2 - Ensure you have defined an SMS message for an overdue letter
 3 - Set an SMS alert number for patron
 4 - Set the SMS::Send driver to 'Email'
 5 - Checkout an item as overdue to trigger notice above
 6 - Run overdue_notices.pl
 6 - Check the db and note the address is email
 7 - run process_message_queue.pl
 8 - Check db - address is email followed by service provider
 9 - Apply patch
 10 - repeat
 11 - Message to_address should be populated with smsalertnumber

Signed-off-by: Josef Moravec <josef.moravec at gmail.com>

Signed-off-by: Marcel de Rooy <m.de.rooy at rijksmuseum.nl>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Nov 10 13:46:36 2017
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 10 Nov 2017 12:46:36 +0000
Subject: [Koha-bugs] [Bug 19573] Link to make a new list in masthead in OPAC
 only appears / works if no other list already exists
In-Reply-To: <bug-19573-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-19573-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-19573-70-ITWtLyL5im@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19573

Simon Pouchol <simon.pouchol at biblibre.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #69067|0                           |1
        is obsolete|                            |

--- Comment #2 from Simon Pouchol <simon.pouchol at biblibre.com> ---
Created attachment 69081
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=69081&action=edit
Bug 19573: Link to make a new list in masthead in OPAC only appears / works if
no other list already exists

This patch corrects the OPAC masthead include file so that the "New
list" link will appear whether or not the logged-in user has existing
private lists.

To test, apply the patch and log into the OPAC as both a user with
private lists and a user without private lists. The header's "Lists"
dropdown menu should include a "New list" link in both cases.

Signed-off-by: Simon Pouchol <simon.pouchol at biblibre.com>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Nov 10 13:46:50 2017
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 10 Nov 2017 12:46:50 +0000
Subject: [Koha-bugs] [Bug 19573] Link to make a new list in masthead in OPAC
 only appears / works if no other list already exists
In-Reply-To: <bug-19573-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-19573-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-19573-70-B8IQXK7aF5@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19573

Simon Pouchol <simon.pouchol at biblibre.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |simon.pouchol at biblibre.com
             Status|Needs Signoff               |Signed Off

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Nov 10 13:48:16 2017
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 10 Nov 2017 12:48:16 +0000
Subject: [Koha-bugs] [Bug 19603] Move admin templates JavaScript to the
 footer: Patrons and circulation
In-Reply-To: <bug-19603-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-19603-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-19603-70-HLbK7zpXt8@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19603

--- Comment #3 from Owen Leonard <oleonard at myacpl.org> ---
Did you apply the patch for Bug 19594 first?

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Nov 10 13:50:55 2017
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 10 Nov 2017 12:50:55 +0000
Subject: [Koha-bugs] [Bug 19595] Clicking plugin link does not fill item's
 date acquired field
In-Reply-To: <bug-19595-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-19595-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-19595-70-6EEGV0bFCT@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19595

Owen Leonard <oleonard at myacpl.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
           Assignee|koha-bugs at lists.koha-commun |oleonard at myacpl.org
                   |ity.org                     |
             Status|NEW                         |ASSIGNED

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Nov 10 13:52:17 2017
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 10 Nov 2017 12:52:17 +0000
Subject: [Koha-bugs] [Bug 19603] Move admin templates JavaScript to the
 footer: Patrons and circulation
In-Reply-To: <bug-19603-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-19603-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-19603-70-rfj6AQsH7v@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19603

--- Comment #4 from Simon Pouchol <simon.pouchol at biblibre.com> ---
Yes I did, followed the same steps as for signing off bug 19601.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Nov 10 14:04:57 2017
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 10 Nov 2017 13:04:57 +0000
Subject: [Koha-bugs] [Bug 19595] Clicking plugin link does not fill item's
 date acquired field
In-Reply-To: <bug-19595-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-19595-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-19595-70-o0sH94BSnL@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19595

--- Comment #5 from Owen Leonard <oleonard at myacpl.org> ---
Created attachment 69082
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=69082&action=edit
Bug 19595: Clicking plugin link does not fill item's date acquired field

This patch updates the dateaccessioned plugin for the item edit form to
return functionality which was removed in a previous patch.

To test, apply the patch and open an item for editing. Clicking the
"..." link next to the "Date acquired" field should insert the current
date, overwriting the existing date.

Open a blank item add form. Putting the cursor in the "Date acquired"
field should automatically insert the current date.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Nov 10 14:04:55 2017
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 10 Nov 2017 13:04:55 +0000
Subject: [Koha-bugs] [Bug 19595] Clicking plugin link does not fill item's
 date acquired field
In-Reply-To: <bug-19595-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-19595-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-19595-70-Cz2ctIDf3z@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19595

Owen Leonard <oleonard at myacpl.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
   Patch complexity|---                         |Trivial patch
             Status|ASSIGNED                    |Needs Signoff

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Nov 10 14:19:13 2017
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 10 Nov 2017 13:19:13 +0000
Subject: [Koha-bugs] [Bug 19607] New: Move admin templates JavaScript to the
 footer: Basic parameters
Message-ID: <bug-19607-70@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19607

            Bug ID: 19607
           Summary: Move admin templates JavaScript to the footer: Basic
                    parameters
 Change sponsored?: ---
           Product: Koha
           Version: master
          Hardware: All
                OS: All
            Status: ASSIGNED
          Severity: enhancement
          Priority: P5 - low
         Component: Templates
          Assignee: oleonard at myacpl.org
          Reporter: oleonard at myacpl.org
        QA Contact: testopia at bugs.koha-community.org
                CC: jonathan.druart at bugs.koha-community.org,
                    nick at bywatersolutions.com, simon.pouchol at biblibre.com,
                    testopia at bugs.koha-community.org
        Depends on: 19560, 19594
            Blocks: 17858

In order to conform to best practices for performance staff client template
javascript should be in the footer instead of the header.

This patch will do so for the "basic parameters" administration templates.


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17858
[Bug 17858] Omnibus: Move staff client JavaScript to the footer
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19560
[Bug 19560] Unable to delete library when branchcode contains special
characters
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19594
[Bug 19594] Move admin templates JavaScript to the footer: MARC-related
-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Nov 10 14:19:13 2017
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 10 Nov 2017 13:19:13 +0000
Subject: [Koha-bugs] [Bug 19560] Unable to delete library when branchcode
 contains special characters
In-Reply-To: <bug-19560-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-19560-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-19560-70-zfi5OYMcld@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19560

Owen Leonard <oleonard at myacpl.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Blocks|                            |19607


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19607
[Bug 19607] Move admin templates JavaScript to the footer: Basic parameters
-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Nov 10 14:19:13 2017
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 10 Nov 2017 13:19:13 +0000
Subject: [Koha-bugs] [Bug 19594] Move admin templates JavaScript to the
 footer: MARC-related
In-Reply-To: <bug-19594-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-19594-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-19594-70-J3G9AZdka8@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19594

Owen Leonard <oleonard at myacpl.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Blocks|                            |19607


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19607
[Bug 19607] Move admin templates JavaScript to the footer: Basic parameters
-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Nov 10 14:19:13 2017
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 10 Nov 2017 13:19:13 +0000
Subject: [Koha-bugs] [Bug 17858] Omnibus: Move staff client JavaScript to
	the footer
In-Reply-To: <bug-17858-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-17858-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-17858-70-ttxHimMZYe@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17858

Owen Leonard <oleonard at myacpl.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
         Depends on|                            |19607


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19607
[Bug 19607] Move admin templates JavaScript to the footer: Basic parameters
-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Nov 10 14:26:35 2017
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 10 Nov 2017 13:26:35 +0000
Subject: [Koha-bugs] [Bug 7317] Add an Interlibrary Loan Module to
	Circulation and OPAC
In-Reply-To: <bug-7317-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-7317-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-7317-70-7dhARbihqF@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7317

Josef Moravec <josef.moravec at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |josef.moravec at gmail.com

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Nov 10 14:26:37 2017
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 10 Nov 2017 13:26:37 +0000
Subject: [Koha-bugs] [Bug 19607] Move admin templates JavaScript to the
 footer: Basic parameters
In-Reply-To: <bug-19607-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-19607-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-19607-70-93aq5l2VWj@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19607

Owen Leonard <oleonard at myacpl.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|ASSIGNED                    |Needs Signoff
   Patch complexity|---                         |Small patch

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Nov 10 14:26:39 2017
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 10 Nov 2017 13:26:39 +0000
Subject: [Koha-bugs] [Bug 19607] Move admin templates JavaScript to the
 footer: Basic parameters
In-Reply-To: <bug-19607-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-19607-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-19607-70-fuLtzk7SyJ@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19607

--- Comment #1 from Owen Leonard <oleonard at myacpl.org> ---
Created attachment 69083
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=69083&action=edit
Bug 19607: Move admin templates JavaScript to the footer: Basic parameters

This patch modifies the staff client catalog-related administration
templates so that JavaScript is included in the footer instead of the
header.

To test, apply the patch and test the JavaScript-driven features of
each modified template: All button controls, DataTables functionality,
tabs, etc.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Nov 10 14:36:49 2017
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 10 Nov 2017 13:36:49 +0000
Subject: [Koha-bugs] [Bug 19607] Move admin templates JavaScript to the
 footer: Basic parameters
In-Reply-To: <bug-19607-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-19607-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-19607-70-AecCvdbze0@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19607

Simon Pouchol <simon.pouchol at biblibre.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #69083|0                           |1
        is obsolete|                            |

--- Comment #2 from Simon Pouchol <simon.pouchol at biblibre.com> ---
Created attachment 69084
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=69084&action=edit
Bug 19607: Move admin templates JavaScript to the footer: Basic parameters

This patch modifies the staff client catalog-related administration
templates so that JavaScript is included in the footer instead of the
header.

To test, apply the patch and test the JavaScript-driven features of
each modified template: All button controls, DataTables functionality,
tabs, etc.

Signed-off-by: Simon Pouchol <simon.pouchol at biblibre.com>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Nov 10 14:36:58 2017
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 10 Nov 2017 13:36:58 +0000
Subject: [Koha-bugs] [Bug 19595] Clicking plugin link does not fill item's
 date acquired field
In-Reply-To: <bug-19595-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-19595-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-19595-70-PBWFPmSqKU@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19595

Marcel de Rooy <m.de.rooy at rijksmuseum.nl> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Needs Signoff               |Signed Off

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Nov 10 14:37:01 2017
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 10 Nov 2017 13:37:01 +0000
Subject: [Koha-bugs] [Bug 19595] Clicking plugin link does not fill item's
 date acquired field
In-Reply-To: <bug-19595-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-19595-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-19595-70-gB2Ccsnudb@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19595

Marcel de Rooy <m.de.rooy at rijksmuseum.nl> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #69082|0                           |1
        is obsolete|                            |

--- Comment #6 from Marcel de Rooy <m.de.rooy at rijksmuseum.nl> ---
Created attachment 69085
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=69085&action=edit
Bug 19595: Clicking plugin link does not fill item's date acquired field

This patch updates the dateaccessioned plugin for the item edit form to
return functionality which was removed in a previous patch.

To test, apply the patch and open an item for editing. Clicking the
"..." link next to the "Date acquired" field should insert the current
date, overwriting the existing date.

Open a blank item add form. Putting the cursor in the "Date acquired"
field should automatically insert the current date.

Signed-off-by: Marcel de Rooy <m.de.rooy at rijksmuseum.nl>
Added a comment line in set_to_today.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Nov 10 14:37:00 2017
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 10 Nov 2017 13:37:00 +0000
Subject: [Koha-bugs] [Bug 19607] Move admin templates JavaScript to the
 footer: Basic parameters
In-Reply-To: <bug-19607-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-19607-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-19607-70-Kt6RGlyg5Q@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19607

Simon Pouchol <simon.pouchol at biblibre.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Needs Signoff               |Signed Off

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Nov 10 14:37:53 2017
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 10 Nov 2017 13:37:53 +0000
Subject: [Koha-bugs] [Bug 19595] Clicking plugin link does not fill item's
 date acquired field
In-Reply-To: <bug-19595-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-19595-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-19595-70-MlXR78Hh0t@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19595

--- Comment #7 from Marcel de Rooy <m.de.rooy at rijksmuseum.nl> ---
(In reply to Jonathan Druart from comment #4)
> (In reply to Marcel de Rooy from comment #1)
> > If you hover your mouse over the "plugin link", you will see "No popup".
> 
> I see "Tag editor"

Caused by the presence of a Click event

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Nov 10 14:39:18 2017
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 10 Nov 2017 13:39:18 +0000
Subject: [Koha-bugs] [Bug 19595] Clicking plugin link does not fill item's
 date acquired field
In-Reply-To: <bug-19595-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-19595-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-19595-70-1qPQ46qL3O@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19595

--- Comment #8 from Marcel de Rooy <m.de.rooy at rijksmuseum.nl> ---
(In reply to Owen Leonard from comment #3)
> I consider this a bug BECAUSE it is a change in behavior. Functionality
> which my catalogers used daily has been removed, making their work more
> difficult.

There is difficult and difficult :) Clicking in the field would have triggered
the Focus event, but indeed it would not overwrite. But overwriting date
acquired might not be a good idea most of the time ..

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Nov 10 14:40:33 2017
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 10 Nov 2017 13:40:33 +0000
Subject: [Koha-bugs] [Bug 19595] Clicking plugin link does not fill item's
 date acquired field
In-Reply-To: <bug-19595-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-19595-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-19595-70-JojH9jgwVp@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19595

Marcel de Rooy <m.de.rooy at rijksmuseum.nl> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Signed Off                  |Passed QA

--- Comment #9 from Marcel de Rooy <m.de.rooy at rijksmuseum.nl> ---
In view of its rather trivial nature, passing QA in one run.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Nov 10 14:40:45 2017
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 10 Nov 2017 13:40:45 +0000
Subject: [Koha-bugs] [Bug 19595] Clicking plugin link does not fill item's
 date acquired field
In-Reply-To: <bug-19595-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-19595-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-19595-70-ayKu83gro5@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19595

Marcel de Rooy <m.de.rooy at rijksmuseum.nl> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
         QA Contact|testopia at bugs.koha-communit |m.de.rooy at rijksmuseum.nl
                   |y.org                       |

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Nov 10 14:41:52 2017
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 10 Nov 2017 13:41:52 +0000
Subject: [Koha-bugs] [Bug 19580] Elasticsearch: QueryAutoTruncate exclude
 period as splitting character in autotruncation
In-Reply-To: <bug-19580-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-19580-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-19580-70-FgFtrPADUd@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19580

--- Comment #4 from David Gustafsson <glasklas at gmail.com> ---
Tried making this change myself but got "'fatal: sha1 information is lacking or
useless? when apply a patch" when running git bz apply. Perhaps best to wait
until https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19559 has been
commited and then reroll this patch on master.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Nov 10 14:47:11 2017
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 10 Nov 2017 13:47:11 +0000
Subject: [Koha-bugs] [Bug 19575] Use canonical field names and resolve
	aliased fields
In-Reply-To: <bug-19575-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-19575-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-19575-70-KxJtHZUCjx@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19575

--- Comment #3 from David Gustafsson <glasklas at gmail.com> ---
Think I have missed a few places (facets for example) where field names are
hard coded and needs to be changes. So no point in trying out patch in it's
current state until these things are fixed.

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.

From bugzilla-daemon at bugs.koha-community.org  Fri Nov 10 14:58:17 2017
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 10 Nov 2017 13:58:17 +0000
Subject: [Koha-bugs] [Bug 19516] can't save changes on notices if letter is
 already created
In-Reply-To: <bug-19516-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-19516-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-19516-70-mdjlHiYOdk@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19516

Stefan Berndtsson <stefan.berndtsson at ub.gu.se> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |stefan.berndtsson at ub.gu.se

--- Comment #1 from Stefan Berndtsson <stefan.berndtsson at ub.gu.se> ---
Created attachment 69086
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=69086&action=edit
Fix condition when updating an existing letter with language support turned on

There is a missing condition for "lang" in the UPDATE line in letter.pl.

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Nov 10 15:00:43 2017
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 10 Nov 2017 14:00:43 +0000
Subject: [Koha-bugs] [Bug 18131] Matching staged records when using elastic
	search fails
In-Reply-To: <bug-18131-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-18131-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-18131-70-Z7WMF0EubK@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18131

Julian Maurice <julian.maurice at biblibre.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #62087|0                           |1
        is obsolete|                            |

--- Comment #14 from Julian Maurice <julian.maurice at biblibre.com> ---
Created attachment 69087
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=69087&action=edit
Bug 18131: ES - Fix matching staged records

The code in C4::Matches::get_matches is terrible and a bug has been introduced
by bug 12478 because of its way to handle uniqueness.

If search engine is elastic, simple_search_compat returns array ref of
MARC::Record,
used as a string for the key of the matches hashref we get things like
"MARC::Record=HASH(0x8f76ab0)".
Yes, terrible...

The file is never staged and we get an internal server error:
    stage-marc-import.pl: Can't locate object method "fields" via package
"MARC::Record=HASH(0x8f76ab0)" (perhaps you forgot to load
"MARC::Record=HASH(0x8f76ab0)"?) at /home/vagrant/kohaclone/C4/Biblio.pm line
2691

To recreate the issue:
- Set SearchEngine == Elastic
- Create a matching rule on 999$c (you need to edit the existing one and
specify
'Local-number' as search index, not 'local-number')
- Import a file with bibliographic records and use the matching rule you
defined.

Test plan:
Import authority and bibliographic records with Zebra and Elastic using a
matching rule.
Everything should work correctly.

Note: I found a bug when importing authorities using Elastic, see bug 17255
comment 38.

Signed-off-by: Nick Clemens <nick at bywatersolutions.com>
Signed-off-by: Julian Maurice <julian.maurice at biblibre.com>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Nov 10 15:00:48 2017
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 10 Nov 2017 14:00:48 +0000
Subject: [Koha-bugs] [Bug 18131] Matching staged records when using elastic
	search fails
In-Reply-To: <bug-18131-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-18131-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-18131-70-ORsgV0cL0J@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18131

Julian Maurice <julian.maurice at biblibre.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #62088|0                           |1
        is obsolete|                            |

--- Comment #15 from Julian Maurice <julian.maurice at biblibre.com> ---
Created attachment 69088
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=69088&action=edit
Bug 18131: ES - Fix matching staged records - Authority

Occurrences of C4::AuthoritiesMarc::SearchAuthorities must be replaced
by search_auth_compat.

You need to define the search index of matching rule with one of the
values defined in %koha_to_index_name (from
Koha::SearchEngine::Elasticsearch::QueryBuilder::build_authorities_query_compat)

Signed-off-by: Nick Clemens <nick at bywatersolutions.com>
Signed-off-by: Julian Maurice <julian.maurice at biblibre.com>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Nov 10 15:00:52 2017
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 10 Nov 2017 14:00:52 +0000
Subject: [Koha-bugs] [Bug 18131] Matching staged records when using elastic
	search fails
In-Reply-To: <bug-18131-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-18131-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-18131-70-9BRyigy8e6@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18131

Julian Maurice <julian.maurice at biblibre.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #68884|0                           |1
        is obsolete|                            |

--- Comment #16 from Julian Maurice <julian.maurice at biblibre.com> ---
Created attachment 69089
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=69089&action=edit
Bug 18131: Followup - Use data if biblionumber_tag < 10

Signed-off-by: Julian Maurice <julian.maurice at biblibre.com>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Nov 10 15:02:05 2017
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 10 Nov 2017 14:02:05 +0000
Subject: [Koha-bugs] [Bug 18131] Matching staged records when using elastic
	search fails
In-Reply-To: <bug-18131-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-18131-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-18131-70-VmkZlz0FUs@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18131

Julian Maurice <julian.maurice at biblibre.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Signed Off                  |Passed QA

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Nov 10 15:28:06 2017
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 10 Nov 2017 14:28:06 +0000
Subject: [Koha-bugs] [Bug 11210] Allow partial writeoff
In-Reply-To: <bug-11210-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-11210-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-11210-70-KIUGu9wmki@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11210

Simon Pouchol <simon.pouchol at biblibre.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #69001|0                           |1
        is obsolete|                            |

--- Comment #9 from Simon Pouchol <simon.pouchol at biblibre.com> ---
Created attachment 69090
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=69090&action=edit
Bug 11210 - Writeoff partial amounts

Minor changes to pay.pl and paycollect.tt to allow writing off a partial amount
of a fine.

Test plan:
0) Go to the Fines tab of a test patron's profile
1) Create a fine if there are none (under the Manual invoice tab)
2) Go to the "Pay fines" tab
3) Press the write off button on the corresponding account line

Without patch, you'll be asked to confirm, but will not be able to edit the
amount
With patch, you'll be able to edit the amount.

Followed test plan, patch worked as described. Also ran QA test tool and
modified files passed

Signed-off-by: Simon Pouchol <simon.pouchol at biblibre.com>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Nov 10 15:28:24 2017
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 10 Nov 2017 14:28:24 +0000
Subject: [Koha-bugs] [Bug 11210] Allow partial writeoff
In-Reply-To: <bug-11210-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-11210-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-11210-70-G9zqtMsIjf@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11210

Simon Pouchol <simon.pouchol at biblibre.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Needs Signoff               |Signed Off
                 CC|                            |simon.pouchol at biblibre.com

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Nov 10 15:47:30 2017
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 10 Nov 2017 14:47:30 +0000
Subject: [Koha-bugs] [Bug 17047] Mana Knowledge Base : share data
In-Reply-To: <bug-17047-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-17047-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-17047-70-QwF8lRQf1R@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17047

--- Comment #176 from Alex Arnaud <alex.arnaud at biblibre.com> ---
Created attachment 69091
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=69091&action=edit
Bug 17047 - Move ability to comment mana entities from search results table to
report/subscription detail page

+ code refactoring

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Nov 10 15:49:52 2017
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 10 Nov 2017 14:49:52 +0000
Subject: [Koha-bugs] [Bug 17047] Mana Knowledge Base : share data
In-Reply-To: <bug-17047-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-17047-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-17047-70-P3GrW1pRx6@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17047

Alex Arnaud <alex.arnaud at biblibre.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Failed QA                   |Needs Signoff

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Nov 10 15:50:26 2017
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 10 Nov 2017 14:50:26 +0000
Subject: [Koha-bugs] [Bug 19608] New: Move admin templates JavaScript to the
 footer: The rest
Message-ID: <bug-19608-70@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19608

            Bug ID: 19608
           Summary: Move admin templates JavaScript to the footer: The
                    rest
 Change sponsored?: ---
           Product: Koha
           Version: master
          Hardware: All
                OS: All
            Status: ASSIGNED
          Severity: enhancement
          Priority: P5 - low
         Component: Templates
          Assignee: oleonard at myacpl.org
          Reporter: oleonard at myacpl.org
        QA Contact: testopia at bugs.koha-community.org
                CC: jonathan.druart at bugs.koha-community.org,
                    nick at bywatersolutions.com, simon.pouchol at biblibre.com,
                    testopia at bugs.koha-community.org
        Depends on: 19594
            Blocks: 17858

In order to conform to best practices for performance staff client template
javascript should be in the footer instead of the header.

This patch will do so for administration templates not already converted in
other patches.


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17858
[Bug 17858] Omnibus: Move staff client JavaScript to the footer
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19594
[Bug 19594] Move admin templates JavaScript to the footer: MARC-related
-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Nov 10 15:50:26 2017
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 10 Nov 2017 14:50:26 +0000
Subject: [Koha-bugs] [Bug 19594] Move admin templates JavaScript to the
 footer: MARC-related
In-Reply-To: <bug-19594-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-19594-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-19594-70-xbhyTbk6kl@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19594

Owen Leonard <oleonard at myacpl.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Blocks|                            |19608


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19608
[Bug 19608] Move admin templates JavaScript to the footer: The rest
-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Nov 10 15:50:26 2017
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 10 Nov 2017 14:50:26 +0000
Subject: [Koha-bugs] [Bug 17858] Omnibus: Move staff client JavaScript to
	the footer
In-Reply-To: <bug-17858-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-17858-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-17858-70-aBSXI3uV7X@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17858

Owen Leonard <oleonard at myacpl.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
         Depends on|                            |19608


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19608
[Bug 19608] Move admin templates JavaScript to the footer: The rest
-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Nov 10 17:12:50 2017
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 10 Nov 2017 16:12:50 +0000
Subject: [Koha-bugs] [Bug 19591] Saving a system preference jumps to main
	page
In-Reply-To: <bug-19591-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-19591-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-19591-70-27txRkb8PD@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19591

--- Comment #2 from Christian Stelzenm?ller <christian.stelzenmueller at bsz-bw.de> ---
(In reply to Owen Leonard from comment #1)
> When you save a system preference the page shouldn't refresh at all. The
> change happens behind the scenes and a message should pop up briefly
> indicating success.
> 
> If you find that clicking the save button redirects the page, you might have
> a JavaScript error somewhere. Do you have something in the IntranetUserJS
> system preference?

There is indeed a js error:
"Error: Syntax error, unrecognized expression: .transl."

Maybe it's that. I'll ask Katrin on Monday, thanks :-)

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.

From bugzilla-daemon at bugs.koha-community.org  Fri Nov 10 17:20:24 2017
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 10 Nov 2017 16:20:24 +0000
Subject: [Koha-bugs] [Bug 11983] code to select patrons to purge needs to be
	centralized
In-Reply-To: <bug-11983-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-11983-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-11983-70-u1h06PhIB2@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11983

Victor Grousset/tuxayo <victor.grousset at biblibre.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |victor.grousset at biblibre.co
                   |                            |m

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Nov 10 17:24:10 2017
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 10 Nov 2017 16:24:10 +0000
Subject: [Koha-bugs] [Bug 10213] UniqueItemFields should be implemented for
 creating items in cataloguing and serials
In-Reply-To: <bug-10213-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-10213-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-10213-70-rPwPwijTq2@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10213

Patrick Robitaille <patrick.robitaille at collecto.ca> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |patrick.robitaille at collecto
                   |                            |.ca

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Nov 10 17:31:29 2017
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 10 Nov 2017 16:31:29 +0000
Subject: [Koha-bugs] [Bug 14769] Authorities merge: Set correct indicators
 in biblio field
In-Reply-To: <bug-14769-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-14769-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-14769-70-CdQVSzqh6v@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14769

Marjorie Barry-Vila <marjorie.barry-vila at collecto.ca> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |marjorie.barry-vila at collect
                   |                            |o.ca

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Nov 10 17:40:58 2017
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 10 Nov 2017 16:40:58 +0000
Subject: [Koha-bugs] [Bug 8976] Default sequence of subfields in cataloguing
	editor
In-Reply-To: <bug-8976-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-8976-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-8976-70-9cycnGn8xo@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8976

Marjorie Barry-Vila <marjorie.barry-vila at collecto.ca> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |marjorie.barry-vila at collect
                   |                            |o.ca

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Nov 10 17:41:27 2017
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 10 Nov 2017 16:41:27 +0000
Subject: [Koha-bugs] [Bug 18458] Merging authority record incorrectly orders
	subfields
In-Reply-To: <bug-18458-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-18458-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-18458-70-ZhGEEvrxx2@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18458

Patrick Robitaille <patrick.robitaille at collecto.ca> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |patrick.robitaille at collecto
                   |                            |.ca

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Nov 10 18:39:41 2017
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 10 Nov 2017 17:39:41 +0000
Subject: [Koha-bugs] [Bug 13895] Add routes for checkouts retrieval and
	renewal
In-Reply-To: <bug-13895-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-13895-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-13895-70-c6f8JOwDnG@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13895

Tom?s Cohen Arazi <tomascohen at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
            Summary|REST API: Add API routes    |Add routes for checkouts
                   |for checkouts retrieval and |retrieval and renewal
                   |renewal                     |
                 CC|                            |tomascohen at gmail.com

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Nov 10 19:41:34 2017
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 10 Nov 2017 18:41:34 +0000
Subject: [Koha-bugs] [Bug 13895] Add routes for checkouts retrieval and
	renewal
In-Reply-To: <bug-13895-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-13895-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-13895-70-JAQsIpxfkX@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13895

--- Comment #52 from Tom?s Cohen Arazi <tomascohen at gmail.com> ---
(In reply to Katrin Fischer from comment #36)
> functionality. Maybe too paranoid?

Yes :-D

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Nov 10 19:48:57 2017
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 10 Nov 2017 18:48:57 +0000
Subject: [Koha-bugs] [Bug 13895] Add routes for checkouts retrieval and
	renewal
In-Reply-To: <bug-13895-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-13895-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-13895-70-tcqfgGb5q0@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13895

--- Comment #53 from Tom?s Cohen Arazi <tomascohen at gmail.com> ---
(In reply to David Cook from comment #51)
> What does "issues retrieval" mean?

That was renamed 'checkouts retrieval'. It is related to checkout informations
:-P

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Nov 10 21:32:26 2017
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 10 Nov 2017 20:32:26 +0000
Subject: [Koha-bugs] [Bug 19581] Elasticsearch - Catmandu split option adds
 extra null fields to indexes
In-Reply-To: <bug-19581-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-19581-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-19581-70-EmqBTcSDcU@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19581

David Bourgault <david.bourgault at inlibro.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #68949|0                           |1
        is obsolete|                            |

--- Comment #5 from David Bourgault <david.bourgault at inlibro.com> ---
Created attachment 69093
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=69093&action=edit
Bug 19581: Unit tests

This patch makes a few changes to the tests to take into account the
change to indexing.

To test:
prove t/db_dependent/Koha_Elasticsearch_Indexer.t
Should return green

Signed-off-by: David Bourgault <david.bourgault at inlibro.com>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Nov 10 21:32:24 2017
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 10 Nov 2017 20:32:24 +0000
Subject: [Koha-bugs] [Bug 19581] Elasticsearch - Catmandu split option adds
 extra null fields to indexes
In-Reply-To: <bug-19581-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-19581-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-19581-70-jW9R46aftL@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19581

David Bourgault <david.bourgault at inlibro.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #68948|0                           |1
        is obsolete|                            |

--- Comment #4 from David Bourgault <david.bourgault at inlibro.com> ---
Created attachment 69092
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=69092&action=edit
Bug 19581: Remove 'split' option from Catmandu fixes for marc

This option in combination with append seems to add null entries in the indexes
for fields that don't exist. These fields then affect sorting. Removing it
solves
the issue

To test:
1 - Have an ES setup
2 - Catalog and index some records
3 - View a record in ES:
    curl 'localhost:9200/koha_kohadev_biblios/data/4?pretty=yes'
4 - Note there are 'null' entries in the indexes, save this result for
comparison
5 - Apply patch
6 - Reindex, amking sure to delete existing indexes
    perl misc/search_tools/rebuild_elastic_search.pl -d
7 - View the record again
8 - Note the null entries are removed
9 - Note indices are otherwise intact

Signed-off-by: David Bourgault <david.bourgault at inlibro.com>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Nov 10 21:34:12 2017
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 10 Nov 2017 20:34:12 +0000
Subject: [Koha-bugs] [Bug 19581] Elasticsearch - Catmandu split option adds
 extra null fields to indexes
In-Reply-To: <bug-19581-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-19581-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-19581-70-B3n0mJ6BjA@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19581

David Bourgault <david.bourgault at inlibro.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Needs Signoff               |Signed Off
                 CC|                            |david.bourgault at inlibro.com

--- Comment #6 from David Bourgault <david.bourgault at inlibro.com> ---
QA tools green
Tests passed
Work as described. 

I could still values being set to null, but only as indicators of 00X fields,
which I assume is on purpose.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Nov 10 22:06:27 2017
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 10 Nov 2017 21:06:27 +0000
Subject: [Koha-bugs] [Bug 19580] Elasticsearch: QueryAutoTruncate exclude
 period as splitting character in autotruncation
In-Reply-To: <bug-19580-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-19580-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-19580-70-WNSCMN7ATl@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19580

David Bourgault <david.bourgault at inlibro.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #68942|0                           |1
        is obsolete|                            |

--- Comment #5 from David Bourgault <david.bourgault at inlibro.com> ---
Created attachment 69094
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=69094&action=edit
Bug 19580: Unit tests

Signed-off-by: David Bourgault <david.bourgault at inlibro.com>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Nov 10 22:06:29 2017
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 10 Nov 2017 21:06:29 +0000
Subject: [Koha-bugs] [Bug 19580] Elasticsearch: QueryAutoTruncate exclude
 period as splitting character in autotruncation
In-Reply-To: <bug-19580-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-19580-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-19580-70-caMVr5vxzc@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19580

David Bourgault <david.bourgault at inlibro.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #68943|0                           |1
        is obsolete|                            |

--- Comment #6 from David Bourgault <david.bourgault at inlibro.com> ---
Created attachment 69095
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=69095&action=edit
Bug 19580: Exclude period as splitting character for autotrunction

To test:
0 - Apply Unit test patch only
1 - prove t/db_dependent/Koha_SearchEngine_Elasticsearch_Search.t
2 - Should fail
3 - Apply this patch
4 - prove t/db_dependent/Koha_SearchEngine_Elasticsearch_Search.t
5 - should pass
6 - search for 'Local-number.raw:"4"' (or a vlid biblionumber)
7 - should get expected result

Signed-off-by: David Bourgault <david.bourgault at inlibro.com>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Nov 10 22:07:48 2017
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 10 Nov 2017 21:07:48 +0000
Subject: [Koha-bugs] [Bug 19580] Elasticsearch: QueryAutoTruncate exclude
 period as splitting character in autotruncation
In-Reply-To: <bug-19580-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-19580-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-19580-70-ygJUeP4HlH@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19580

David Bourgault <david.bourgault at inlibro.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Needs Signoff               |Signed Off
                 CC|                            |david.bourgault at inlibro.com

--- Comment #7 from David Bourgault <david.bourgault at inlibro.com> ---
Tests passed
Works as described

QA tools threw errors, as David Gustafsson said. I corrected and amend the
patch accordingly.

QA tools passed green

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Nov 10 22:26:58 2017
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 10 Nov 2017 21:26:58 +0000
Subject: [Koha-bugs] [Bug 19604] Elasticsearch Fixes for
 build_authorities_query for auth searching
In-Reply-To: <bug-19604-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-19604-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-19604-70-2wLuesHeLS@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19604

David Bourgault <david.bourgault at inlibro.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |david.bourgault at inlibro.com
             Status|Needs Signoff               |Failed QA

--- Comment #2 from David Bourgault <david.bourgault at inlibro.com> ---
I did a search for 'me' from the OPAC's Auth search.

With Zebra I got 1411 results (some, but not all, matching on 'm?')
With ES I got a single result, in which the word 'Me' was found as-is

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.

From bugzilla-daemon at bugs.koha-community.org  Fri Nov 10 22:39:16 2017
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 10 Nov 2017 21:39:16 +0000
Subject: [Koha-bugs] [Bug 11300] Add a new authority linker which searches
 for authority links on a Z39.50 server.
In-Reply-To: <bug-11300-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-11300-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-11300-70-hBlO3GzktN@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11300

Bouzid <bouzid.fergani at inlibro.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #67165|0                           |1
        is obsolete|                            |

--- Comment #21 from Bouzid <bouzid.fergani at inlibro.com> ---
Created attachment 69096
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=69096&action=edit
Bug 11300 - Add a new authority linker which searches for authority links on a
Z39.50 server.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Nov 10 22:50:48 2017
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 10 Nov 2017 21:50:48 +0000
Subject: [Koha-bugs] [Bug 18235] Elastic search - Configurable facets
In-Reply-To: <bug-18235-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-18235-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-18235-70-jxkmb9gxOS@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18235

David Bourgault <david.bourgault at inlibro.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |david.bourgault at inlibro.com

--- Comment #14 from David Bourgault <david.bourgault at inlibro.com> ---
Also patch does not apply.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Nov 10 23:04:56 2017
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 10 Nov 2017 22:04:56 +0000
Subject: [Koha-bugs] [Bug 19560] Unable to delete library when branchcode
 contains special characters
In-Reply-To: <bug-19560-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-19560-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-19560-70-CPanmHoedd@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19560

David Bourgault <david.bourgault at inlibro.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #69062|0                           |1
        is obsolete|                            |

--- Comment #2 from David Bourgault <david.bourgault at inlibro.com> ---
Created attachment 69097
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=69097&action=edit
Bug 19560: Unable to delete library when branchcode contains special characters

This patch modifies the library administration page so that the library
delete button submits a form using POST rather than linking to the
delete operation with GET variables.

This patch also adds validation to the library entry form so that it
will only accept letters, numbers, hyphen, and underscore.

The validation method for this already existed in categories.js, so it
has been moved to staff-global.js and the validator warning message has
been moved to validator-strings.inc so it is included globally.

To test:
  - Add a library with a branchcode containing characters like & or
    #.
  - Apply the patch and clear your browser cache if necessary.
  - Try to delete the new library. It should delete successfully.
  - Add a library again and try to include spaces and/or special
    characters in the branchcode. The form validation script should
    prevent you from submitting the form.
  - Go do Administration -> Patron categories and add a new patron
    category. The category code field should prevent you from entering a
    code with spaces or special characters.

Signed-off-by: David Bourgault <david.bourgault at inlibro.com>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Nov 10 23:06:45 2017
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 10 Nov 2017 22:06:45 +0000
Subject: [Koha-bugs] [Bug 19560] Unable to delete library when branchcode
 contains special characters
In-Reply-To: <bug-19560-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-19560-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-19560-70-6DwBmDkZTT@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19560

David Bourgault <david.bourgault at inlibro.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Needs Signoff               |Signed Off
                 CC|                            |david.bourgault at inlibro.com

--- Comment #3 from David Bourgault <david.bourgault at inlibro.com> ---
QA tool passed
Works as described, but also prevents accentuated characters like ? or ?. For
category codes I think this is acceptable/preferable.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Sat Nov 11 05:06:12 2017
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Sat, 11 Nov 2017 04:06:12 +0000
Subject: [Koha-bugs] [Bug 19609] New: BARCODING
Message-ID: <bug-19609-70@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19609

            Bug ID: 19609
           Summary: BARCODING
 Change sponsored?: ---
           Product: Koha
           Version: unspecified
          Hardware: All
                OS: Linux
            Status: NEW
          Severity: critical
          Priority: P5 - low
         Component: Label/patron card printing
          Assignee: cnighswonger at foundations.edu
          Reporter: jabbarelayadam at gmail.com
        QA Contact: testopia at bugs.koha-community.org

HOW CAN I PRINT BARCODES THROUGH KOHA

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Sat Nov 11 10:04:29 2017
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Sat, 11 Nov 2017 09:04:29 +0000
Subject: [Koha-bugs] [Bug 19609] BARCODING
In-Reply-To: <bug-19609-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-19609-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-19609-70-gHllGfNGan@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19609

Josef Moravec <josef.moravec at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |josef.moravec at gmail.com
         Resolution|---                         |INVALID
             Status|NEW                         |RESOLVED

--- Comment #1 from Josef Moravec <josef.moravec at gmail.com> ---
(In reply to jabbar from comment #0)
> HOW CAN I PRINT BARCODES THROUGH KOHA

Use Label creator in Tools.

And for next time, use please mailing list for this kind of questions and
please do not shout at us. Thanks.

Josef

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Sat Nov 11 10:26:50 2017
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Sat, 11 Nov 2017 09:26:50 +0000
Subject: [Koha-bugs] [Bug 19591] Saving a system preference jumps to main
	page
In-Reply-To: <bug-19591-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-19591-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-19591-70-wLhvQSBBwe@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19591

Josef Moravec <josef.moravec at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |josef.moravec at gmail.com

--- Comment #3 from Josef Moravec <josef.moravec at gmail.com> ---
I tried on master and it works for me. Do you use some other language then
english? Or do you have something in intranetuserjs preference?

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.

From bugzilla-daemon at bugs.koha-community.org  Sat Nov 11 10:29:06 2017
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Sat, 11 Nov 2017 09:29:06 +0000
Subject: [Koha-bugs] [Bug 19586] Improve budget display
In-Reply-To: <bug-19586-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-19586-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-19586-70-2eMaESnxdl@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19586

Josef Moravec <josef.moravec at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |josef.moravec at gmail.com

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Sat Nov 11 10:38:00 2017
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Sat, 11 Nov 2017 09:38:00 +0000
Subject: [Koha-bugs] [Bug 19584] Inventory: Trivial interface improvements
In-Reply-To: <bug-19584-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-19584-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-19584-70-7mweCgTVPo@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19584

Josef Moravec <josef.moravec at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |josef.moravec at gmail.com

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Sat Nov 11 13:23:42 2017
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Sat, 11 Nov 2017 12:23:42 +0000
Subject: [Koha-bugs] [Bug 18591] Allow an arbitrary number of comments on
	ILLs
In-Reply-To: <bug-18591-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-18591-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-18591-70-j17wIEB1eV@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18591

Magnus Enger <magnus at libriotech.no> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
           Assignee|koha-bugs at lists.koha-commun |magnus at libriotech.no
                   |ity.org                     |

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Sat Nov 11 14:04:41 2017
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Sat, 11 Nov 2017 13:04:41 +0000
Subject: [Koha-bugs] [Bug 18591] Allow an arbitrary number of comments on
	ILLs
In-Reply-To: <bug-18591-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-18591-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-18591-70-uqIUuISRyK@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18591

--- Comment #1 from Magnus Enger <magnus at libriotech.no> ---
Two important things to decide on here: 
- Should it be possible to edit comments? 
- Should it be possible to delete comments? 

I lean towards "no" for both questions, because it makes the code simpler and
it means the comments are historically correct.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Sun Nov 12 03:44:24 2017
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Sun, 12 Nov 2017 02:44:24 +0000
Subject: [Koha-bugs] [Bug 2454] Improve display of credits on pay fines tab
In-Reply-To: <bug-2454-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-2454-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-2454-70-4gP82efUzp@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=2454

--- Comment #17 from Alex Buckley <alexbuckley at catalyst.net.nz> ---
Created attachment 69098
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=69098&action=edit
Bug 2454 - Removed the display of NotifyID and Level values on Pay fines page

Based on tester feedback this patch has been redone so as to remove
changes of indentation to lines not added or modified by this patch.

Test plan:
1. From the Koha staff interface go the Patron area and select a patron
page

2. Create a fine of $10 for the patron by clicking on the 'Fines' tab
and creating a fine in the 'Create manual invoice' tab

3. Create a credit of $5 for the patron in the 'Create manual credit'
page

4. Then go to the 'Pay fines' tab and notice there is a row for both the
fine and credit both with values in the account type, Notify ID, and level
boxes
of the table

5. Select "write off all" and 'OK' in the confirmation box

6. Youre redirected to Account tab, return to 'pay fines' tab and notice
no fines or credits are displayed

7. Repeat steps 2, 3, 4 and then click "Pay amount", confirm it, then
navigate back to the 'Pay fines' tab and notice although the fine and credit
are
displayed the 'total due' value is 0.00

8. Apply the patch attached to this bug report

9. Repeat steps 2, and 3.

10. Navigate to 'Pay fines' tab and notice the fine has values
in account type, Notify ID, and level and the credit does not.
Additionally credit has the description value of 'Credit'

11. Repeat steps 5 and 6 and as with before this patch was applied
notice the 'Pay fines' tab does not show any fines or credits

12. Repeat step 7 and again notice the 'Total due' value is 0.00

Sponsored-By: Catalyst IT

-- 
You are receiving this mail because:
You are the QA Contact for the bug.
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Sun Nov 12 03:44:59 2017
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Sun, 12 Nov 2017 02:44:59 +0000
Subject: [Koha-bugs] [Bug 2454] Improve display of credits on pay fines tab
In-Reply-To: <bug-2454-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-2454-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-2454-70-9viJeQ07GJ@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=2454

Alex Buckley <alexbuckley at catalyst.net.nz> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Failed QA                   |Needs Signoff

-- 
You are receiving this mail because:
You are the QA Contact for the bug.
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Sun Nov 12 04:44:20 2017
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Sun, 12 Nov 2017 03:44:20 +0000
Subject: [Koha-bugs] [Bug 19610] New: koha-common.logrotate should use
	copytruncate
Message-ID: <bug-19610-70@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19610

            Bug ID: 19610
           Summary: koha-common.logrotate should use copytruncate
 Change sponsored?: ---
           Product: Koha
           Version: master
          Hardware: All
                OS: All
            Status: NEW
          Severity: normal
          Priority: P5 - low
         Component: Packaging
          Assignee: koha-bugs at lists.koha-community.org
          Reporter: tomascohen at gmail.com
        QA Contact: testopia at bugs.koha-community.org
                CC: mirko at abunchofthings.net

Both bug 15713 and bug 16138 introduce service restarts when log rotation
happens. This is done:
- Stop services (plack and zebra)
- Rotate the log file
- Start services (plack and zebra)

This can be avoided by using the 'copytruncate' directive in the logrotate
configuration [1]

[1] Search for 'copytruncate' here https://linux.die.net/man/8/logrotate

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Sun Nov 12 14:31:03 2017
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Sun, 12 Nov 2017 13:31:03 +0000
Subject: [Koha-bugs] [Bug 19611] New: XSS Flaws in supplier.pl
Message-ID: <bug-19611-70@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19611

            Bug ID: 19611
           Summary: XSS Flaws in supplier.pl
 Change sponsored?: ---
           Product: Koha
           Version: master
          Hardware: All
                OS: All
            Status: NEW
          Severity: enhancement
          Priority: P5 - low
         Component: Acquisitions
          Assignee: koha-bugs at lists.koha-community.org
          Reporter: amitddng135 at gmail.com
        QA Contact: testopia at bugs.koha-community.org

XSS Flaws in supplier.pl

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Sun Nov 12 14:33:10 2017
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Sun, 12 Nov 2017 13:33:10 +0000
Subject: [Koha-bugs] [Bug 19611] XSS Flaws in supplier.pl
In-Reply-To: <bug-19611-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-19611-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-19611-70-NG3FbmB9rf@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19611

Amit Gupta <amitddng135 at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
           Assignee|koha-bugs at lists.koha-commun |amitddng135 at gmail.com
                   |ity.org                     |
             Status|NEW                         |ASSIGNED
  Change sponsored?|---                         |Sponsored
                 CC|                            |amit.gupta at informaticsgloba
                   |                            |l.com,
                   |                            |chris at bigballofwax.co.nz,
                   |                            |katrin.fischer at bsz-bw.de

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.

From bugzilla-daemon at bugs.koha-community.org  Sun Nov 12 14:53:49 2017
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Sun, 12 Nov 2017 13:53:49 +0000
Subject: [Koha-bugs] [Bug 2454] Improve display of credits on pay fines tab
In-Reply-To: <bug-2454-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-2454-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-2454-70-8Gd2ekba0B@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=2454

M. Tompsett <mtompset at hotmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Needs Signoff               |Failed QA

--- Comment #18 from M. Tompsett <mtompset at hotmail.com> ---
(In reply to M. Tompsett from comment #16)
> > -          [% CASE 'PF' %]Processing fee
> 
> This is why you put white space changes in a different file. I believe this
> line got removed incorrectly.

You still cut Processing Fee.

-- 
You are receiving this mail because:
You are the QA Contact for the bug.
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Sun Nov 12 16:47:28 2017
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Sun, 12 Nov 2017 15:47:28 +0000
Subject: [Koha-bugs] [Bug 19611] XSS Flaws in supplier.pl
In-Reply-To: <bug-19611-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-19611-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-19611-70-kXOc8bVOmH@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19611

Amit Gupta <amitddng135 at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|ASSIGNED                    |Needs Signoff

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Sun Nov 12 16:47:16 2017
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Sun, 12 Nov 2017 15:47:16 +0000
Subject: [Koha-bugs] [Bug 19611] XSS Flaws in supplier.pl
In-Reply-To: <bug-19611-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-19611-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-19611-70-tYoIGkNUU6@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19611

Amit Gupta <amitddng135 at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |amitddng135 at gmail.com

--- Comment #1 from Amit Gupta <amitddng135 at gmail.com> ---
Created attachment 69099
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=69099&action=edit
Bug 19611 - XSS Flaws in supplier.pl

Test
1. Hit the page /cgi-bin/koha/acqui/supplier.pl?op=enter
2. Add a text in the field Name that contains java script
3. Save the page.
4. Notice js is execute
5. Apply patch and reload the js is escaped

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Nov 13 02:26:12 2017
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 13 Nov 2017 01:26:12 +0000
Subject: [Koha-bugs] [Bug 19532] Recalls for Koha
In-Reply-To: <bug-19532-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-19532-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-19532-70-WQ1kDViiCj@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19532

--- Comment #11 from Aleisha Amohia <aleisha at catalyst.net.nz> ---
Created attachment 69100
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=69100&action=edit
Bug 19532: Recall an item in OPAC

This patch:
  - adds the 'Recall' button to the item on it's detail page
  - adds ability to place a recall
  - the recall is stored in the recalls table
  - the due date for the checkout is updated to whatever has been set in
  the issuing rule under recall_due_date_interval
  - error messages for if the user isn't logged in, the user tries to
  place a recall on an item they have already recalled, or if storing
  the recall in the db fails for any reason

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Nov 13 02:49:40 2017
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 13 Nov 2017 01:49:40 +0000
Subject: [Koha-bugs] [Bug 17602] Integrate support for
	OneClickdigital/Recorded Books API
In-Reply-To: <bug-17602-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-17602-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-17602-70-PxHL2e2ehf@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17602

Srdjan Jankovic <srdjan at catalyst.net.nz> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Failed QA                   |Needs Signoff

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Nov 13 02:49:43 2017
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 13 Nov 2017 01:49:43 +0000
Subject: [Koha-bugs] [Bug 17602] Integrate support for
	OneClickdigital/Recorded Books API
In-Reply-To: <bug-17602-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-17602-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-17602-70-dCU33u5w8C@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17602

--- Comment #62 from Srdjan Jankovic <srdjan at catalyst.net.nz> ---
Created attachment 69101
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=69101&action=edit
Bug 17602: Translations rework

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Nov 13 02:59:57 2017
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 13 Nov 2017 01:59:57 +0000
Subject: [Koha-bugs] [Bug 17602] Integrate support for
	OneClickdigital/Recorded Books API
In-Reply-To: <bug-17602-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-17602-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-17602-70-7hZSGZhggc@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17602

--- Comment #63 from Srdjan Jankovic <srdjan at catalyst.net.nz> ---
(In reply to Jonathan Druart from comment #61)
> Some additional remarks:
> 1. At some point I got the following error:
> {"error":"Checkout item already exists"}Status: 200 OK

I have to let Nick decide on that one

> 2. Strings from .js files are not translatable, `git grep MSG_` to know how
> to make them translatable.

Done. Please let me know if it's not what you had in mind.

> 3. I see code related to pagination, but I do not see the previous/next
> buttons. I only see the OPACnumSearchResults first results.

Yes, at some stage the idea was to integrate all external searches into the
main results page, so I stopped short of implementing paging - will be thrown
away. Is it acceptable to leave as is?

> 
> And a question:
> Koha/ExternalContent/RecordedBooks.pm
>  76                 user_agent_params => { agent => $class->agent_string }
> Where is this used?

It is a param for WebService::ILS. Cannot remember any more, possibly was a
requirement for a provider that even did not get implemented.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Nov 13 03:36:39 2017
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 13 Nov 2017 02:36:39 +0000
Subject: [Koha-bugs] [Bug 19532] Recalls for Koha
In-Reply-To: <bug-19532-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-19532-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-19532-70-HVgyN9WBu6@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19532

--- Comment #12 from Aleisha Amohia <aleisha at catalyst.net.nz> ---
Created attachment 69102
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=69102&action=edit
Bug 19532: Cancel recall and see recalls in OPAC

This patch adds ability for user to cancel a recall
They can also see their recalls in the user summary

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Nov 13 11:28:53 2017
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 13 Nov 2017 10:28:53 +0000
Subject: [Koha-bugs] [Bug 19289] Allow configuration of the fields on the
 'Catalog details' form in the acquisition baskets
In-Reply-To: <bug-19289-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-19289-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-19289-70-CtpPtL9jJ5@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19289

Nicolas Legrand <nicolas.legrand at bulac.fr> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #68810|0                           |1
        is obsolete|                            |

--- Comment #14 from Nicolas Legrand <nicolas.legrand at bulac.fr> ---
Created attachment 69114
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=69114&action=edit
Bug 19289: Add existing fields to the ACQ framework

When ordering, the bibliographic details contain the title, author,
publisher code, publication year, isbn and series info.
To avoid regression to provide the same behaviour, we will add these
fields to the ACQ framework

NOTE: This patch makes the change only for
  - en
  - fr / unimarc complet

Other frameworks will be updated before to be pushed, to avoid
unecessary rebases

Signed-off-by: Josef Moravec <josef.moravec at gmail.com>

Signed-off-by: Nicolas Legrand <nicolas.legrand at bulac.fr>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Nov 13 11:28:58 2017
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 13 Nov 2017 10:28:58 +0000
Subject: [Koha-bugs] [Bug 19289] Allow configuration of the fields on the
 'Catalog details' form in the acquisition baskets
In-Reply-To: <bug-19289-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-19289-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-19289-70-exutAqoBMh@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19289

Nicolas Legrand <nicolas.legrand at bulac.fr> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #68811|0                           |1
        is obsolete|                            |

--- Comment #15 from Nicolas Legrand <nicolas.legrand at bulac.fr> ---
Created attachment 69115
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=69115&action=edit
Bug 19289: Use the ACQ framework to display bibliographic details

The ACQ MARC framework is only used for the ?Item? block.
This patch add the ability to define biblio fields (!= 995 or 952) to
customize the display of the bibliographic details when ordering.

This new feature is controlled by a new pref:
UseACQFrameworkForBiblioRecords

Test plan:
- Create a new installation to populate the ACQ framework correctly
- Set the pref UseACQFrameworkForBiblioRecords to "Use"
- Create a new order
=> You will see the lib from the ACQ framework
- Add/remove/update biblio subfields in the ACQ framework
- Create a new order
=> You should see the new subfields displayed

Note for QA: I though I would be able to refactor existing code to make
it more flexible, but it is a bit messy and lost a lot of time. I
finally decided to copy/paste the existing code. I simplified it as, I
think, we do not want the plugin, etc. like in the full biblio editor.

Signed-off-by: Josef Moravec <josef.moravec at gmail.com>

Signed-off-by: Nicolas Legrand <nicolas.legrand at bulac.fr>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Nov 13 12:03:41 2017
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 13 Nov 2017 11:03:41 +0000
Subject: [Koha-bugs] [Bug 19585] working title
In-Reply-To: <bug-19585-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-19585-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-19585-70-hPidK9yL2D@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19585

Marcel de Rooy <m.de.rooy at rijksmuseum.nl> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
   Patch complexity|---                         |Trivial patch
             Status|ASSIGNED                    |Needs Signoff

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Nov 13 12:03:43 2017
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 13 Nov 2017 11:03:43 +0000
Subject: [Koha-bugs] [Bug 19585] working title
In-Reply-To: <bug-19585-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-19585-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-19585-70-jDdbrVMw5b@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19585

--- Comment #1 from Marcel de Rooy <m.de.rooy at rijksmuseum.nl> ---
Created attachment 69116
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=69116&action=edit
Bug 19585: Inventory: Allow additional separators in a barcode file

This patch makes \n, \r, |, comma and semicolon all valid separators
between barcodes passed to inventory.
An additional grep removes empty barcodes.

Test plan:
Upload a barcode file that contains various allowed separators.

Signed-off-by: Marcel de Rooy <m.de.rooy at rijksmuseum.nl>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Nov 13 12:04:32 2017
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 13 Nov 2017 11:04:32 +0000
Subject: [Koha-bugs] [Bug 19585] Inventory: Allow additional separators in a
	barcode file
In-Reply-To: <bug-19585-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-19585-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-19585-70-mTa1PKnxBq@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19585

Marcel de Rooy <m.de.rooy at rijksmuseum.nl> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
            Summary|working title               |Inventory: Allow additional
                   |                            |separators in a barcode
                   |                            |file

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Nov 13 12:11:04 2017
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 13 Nov 2017 11:11:04 +0000
Subject: [Koha-bugs] [Bug 19585] Inventory: Allow additional separators in a
	barcode file
In-Reply-To: <bug-19585-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-19585-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-19585-70-bSMEC9xTaG@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19585

Marcel de Rooy <m.de.rooy at rijksmuseum.nl> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #69116|0                           |1
        is obsolete|                            |

--- Comment #2 from Marcel de Rooy <m.de.rooy at rijksmuseum.nl> ---
Created attachment 69117
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=69117&action=edit
Bug 19585: Inventory: Allow additional separators in a barcode file

This patch makes \n, \r, |, comma and semicolon all valid separators
between barcodes passed to inventory.
An additional grep removes empty barcodes. (Note: The grep looks for at
least one non-whitespace character. We could be more specific, but this
allows for more flexibility like testing with alphanumeric barcodes etc.)

Test plan:
Upload a barcode file that contains various allowed separators.

Signed-off-by: Marcel de Rooy <m.de.rooy at rijksmuseum.nl>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Nov 13 12:13:27 2017
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 13 Nov 2017 11:13:27 +0000
Subject: [Koha-bugs] [Bug 19585] Inventory: Allow additional separators in a
	barcode file
In-Reply-To: <bug-19585-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-19585-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-19585-70-PzFUajLM6x@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19585

Marcel de Rooy <m.de.rooy at rijksmuseum.nl> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #69117|0                           |1
        is obsolete|                            |

--- Comment #3 from Marcel de Rooy <m.de.rooy at rijksmuseum.nl> ---
Created attachment 69118
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=69118&action=edit
Bug 19585: Inventory: Allow additional separators in a barcode file

This patch makes \n, \r, |, comma and semicolon all valid separators
between barcodes passed to inventory.
An additional grep removes empty barcodes. (Note: The grep looks for at
least one non-whitespace character. We could be more specific, but this
allows for more flexibility like testing with alphanumeric barcodes etc.)

Test plan:
Upload a barcode file that contains various allowed separators.

Signed-off-by: Marcel de Rooy <m.de.rooy at rijksmuseum.nl>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Nov 13 13:00:09 2017
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 13 Nov 2017 12:00:09 +0000
Subject: [Koha-bugs] [Bug 16872] You should not be allowed to delete a
 record with open orders attached
In-Reply-To: <bug-16872-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-16872-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-16872-70-c6MsnJtoZS@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16872

--- Comment #4 from Kyle M Hall <kyle at bywatersolutions.com> ---
I don't think a warning is enough. We should block users from deleting records
with open orders attached because it creates a situation where manual changes
to the database must be done to repair orders where the record has been
deleted.

Consider that a library may have multiple divisions, where one librarian is
"cleaning up" records by deleting them, and the other is ordering items and
keeps finding his or her on order records are suddenly deleted. Depending on
the size of the library system, it could take the librarian quite a while to
find out why those records are suddenly gone.

(In reply to Jonathan Druart from comment #1)
> Nick,
> There is already a big warning when you try to delete a record used in
> orders.
> I do not understand why we should block the user to do it.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Nov 13 13:01:23 2017
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 13 Nov 2017 12:01:23 +0000
Subject: [Koha-bugs] [Bug 16872] You should not be allowed to delete a
 record with open orders attached
In-Reply-To: <bug-16872-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-16872-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-16872-70-QPL6gYqtc8@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16872

--- Comment #5 from Kyle M Hall <kyle at bywatersolutions.com> ---
Perhaps we need a new user permission or system preference to prevent deletion
of records with open orders on them.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Nov 13 14:06:16 2017
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 13 Nov 2017 13:06:16 +0000
Subject: [Koha-bugs] [Bug 19543] Koha does not reserve an item if there is
 one available in another library.
In-Reply-To: <bug-19543-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-19543-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-19543-70-EVwcp8qaup@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19543

Nick Clemens <nick at bywatersolutions.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|NEW                         |RESOLVED
                 CC|                            |nick at bywatersolutions.com
         Resolution|---                         |DUPLICATE

--- Comment #7 from Nick Clemens <nick at bywatersolutions.com> ---


*** This bug has been marked as a duplicate of bug 18547 ***

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Nov 13 14:06:16 2017
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 13 Nov 2017 13:06:16 +0000
Subject: [Koha-bugs] [Bug 18547] On shelf holds allowed > "If all
 unavailable" ignores default hold policy
In-Reply-To: <bug-18547-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-18547-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-18547-70-WZWPvljWKe@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18547

Nick Clemens <nick at bywatersolutions.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |cristianbiblio at gmail.com

--- Comment #17 from Nick Clemens <nick at bywatersolutions.com> ---
*** Bug 19543 has been marked as a duplicate of this bug. ***

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Nov 13 14:37:48 2017
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 13 Nov 2017 13:37:48 +0000
Subject: [Koha-bugs] [Bug 18712] make test is failing with an empty DB -
	t/Matcher.t
In-Reply-To: <bug-18712-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-18712-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-18712-70-WNle2pAj3W@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18712

Nick Clemens <nick at bywatersolutions.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Signed Off                  |Passed QA

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Nov 13 14:37:51 2017
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 13 Nov 2017 13:37:51 +0000
Subject: [Koha-bugs] [Bug 18712] make test is failing with an empty DB -
	t/Matcher.t
In-Reply-To: <bug-18712-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-18712-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-18712-70-gBev594cLc@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18712

Nick Clemens <nick at bywatersolutions.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #68985|0                           |1
        is obsolete|                            |
  Attachment #68986|0                           |1
        is obsolete|                            |

--- Comment #10 from Nick Clemens <nick at bywatersolutions.com> ---
Created attachment 69119
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=69119&action=edit
Bug 18712: Fix t/Matcher.t if DB is empty

t/Matcher.t is failing with an empty DB, the data are not mocked
correctly

Test plan:
drop your DB and recreate it without any data and prove t/Matcher.t

Signed-off-by: Mark Tompsett <mtompset at hotmail.com>

Signed-off-by: Mark Tompsett <mtompset at hotmail.com>

Signed-off-by: Nick Clemens <nick at bywatersolutions.com>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Nov 13 14:37:54 2017
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 13 Nov 2017 13:37:54 +0000
Subject: [Koha-bugs] [Bug 18712] make test is failing with an empty DB -
	t/Matcher.t
In-Reply-To: <bug-18712-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-18712-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-18712-70-foBkrBJXlf@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18712

--- Comment #11 from Nick Clemens <nick at bywatersolutions.com> ---
Created attachment 69120
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=69120&action=edit
Bug 18712: Remove unecessary fixtures

2 fixtures are in a subroutine that is never called, it can be removed

Signed-off-by: Mark Tompsett <mtompset at hotmail.com>

Signed-off-by: Nick Clemens <nick at bywatersolutions.com>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Nov 13 14:44:15 2017
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 13 Nov 2017 13:44:15 +0000
Subject: [Koha-bugs] [Bug 18712] make test is failing with an empty DB -
	t/Matcher.t
In-Reply-To: <bug-18712-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-18712-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-18712-70-jbPECFCHqp@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18712

Nick Clemens <nick at bywatersolutions.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #68987|0                           |1
        is obsolete|                            |

--- Comment #12 from Nick Clemens <nick at bywatersolutions.com> ---
Created attachment 69121
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=69121&action=edit
Bug 18712: QA Followup - Add count of tests

Before patches we did 47 tests or none, we should plan the same number
of tests now

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Nov 13 14:44:56 2017
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 13 Nov 2017 13:44:56 +0000
Subject: [Koha-bugs] [Bug 18712] make test is failing with an empty DB -
	t/Matcher.t
In-Reply-To: <bug-18712-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-18712-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-18712-70-PXslDeqgd6@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18712

Nick Clemens <nick at bywatersolutions.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |nick at bywatersolutions.com

--- Comment #13 from Nick Clemens <nick at bywatersolutions.com> ---
(In reply to M. Tompsett from comment #8)
> Created attachment 68987 [details] [review]
> Bug 18712: Added missing done_testing
> 
> Signed-off-by: Mark Tompsett <mtompset at hotmail.com>

Added followup, we can count these tests so should have a planned number

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Nov 13 14:54:05 2017
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 13 Nov 2017 13:54:05 +0000
Subject: [Koha-bugs] [Bug 19292] Add MARC code column on libraries list
In-Reply-To: <bug-19292-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-19292-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-19292-70-G3pHmOE0Fx@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19292

Tom?s Cohen Arazi <tomascohen at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
   Patch complexity|---                         |Trivial patch
             Status|Signed Off                  |Passed QA

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Nov 13 14:54:09 2017
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 13 Nov 2017 13:54:09 +0000
Subject: [Koha-bugs] [Bug 19292] Add MARC code column on libraries list
In-Reply-To: <bug-19292-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-19292-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-19292-70-EKKar1EN0u@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19292

Tom?s Cohen Arazi <tomascohen at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #67796|0                           |1
        is obsolete|                            |

--- Comment #3 from Tom?s Cohen Arazi <tomascohen at gmail.com> ---
Created attachment 69122
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=69122&action=edit
Bug 19292: Add MARC code column on libraries list

Test plan:
0) Apply the patch
1) Go to admin/branches.pl
2) In the list of libraries, you should see new column "MARC Organization Code"
3) Insert some codes to some libraries
4) Confirm they are shown in new column

Signed-off-by: Katrin Fischer <katrin.fischer.83 at web.de>
Fixed capitalization.
Signed-off-by: Tomas Cohen Arazi <tomascohen at theke.io>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Nov 13 15:16:06 2017
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 13 Nov 2017 14:16:06 +0000
Subject: [Koha-bugs] [Bug 13895] Add routes for checkouts retrieval and
	renewal
In-Reply-To: <bug-13895-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-13895-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-13895-70-cLFliFkFrQ@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13895

--- Comment #54 from Tom?s Cohen Arazi <tomascohen at gmail.com> ---
Created attachment 69123
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=69123&action=edit
Bug 13895: (QA followup) Adjust OpenAPI definitions for checkouts

Signed-off-by: Tomas Cohen Arazi <tomascohen at theke.io>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Nov 13 15:21:41 2017
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 13 Nov 2017 14:21:41 +0000
Subject: [Koha-bugs] [Bug 13895] Add routes for checkouts retrieval and
	renewal
In-Reply-To: <bug-13895-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-13895-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-13895-70-6SAQtOxJsI@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13895

--- Comment #55 from Tom?s Cohen Arazi <tomascohen at gmail.com> ---
I've added a followup fixing the spec (adding types, etc) and annotating the
boolean columns so the returned types are correct.

This still needs to be migrated to the OpenAPI plugin.
POD missing too.

I'm not convinced by the idea of making PUT default to renewal. Please consider
the 'checkin' scenario and how it could fit too. Right now the Issues and
OldIssues schemas are separated, but conceptually, we should be updating a
checkout when returning (setting returndate, etc).

So, it looks like a good starting point, but more work is needed, specially
thinking about PUT. I can help next week.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Nov 13 15:28:04 2017
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 13 Nov 2017 14:28:04 +0000
Subject: [Koha-bugs] [Bug 17656] Irregularities in serial prediction pattern
 are planned only for current subscription
In-Reply-To: <bug-17656-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-17656-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-17656-70-S2o7EJ10Cc@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17656

Alex Arnaud <alex.arnaud at biblibre.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #68665|0                           |1
        is obsolete|                            |

--- Comment #23 from Alex Arnaud <alex.arnaud at biblibre.com> ---
Created attachment 69124
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=69124&action=edit
Bug 17656 - Keep irregularities during subscription renewals

When renewing a subscription, irregularities are lost. This patch
allows to keep them for monthly, daily or weekly serials ( 1 unit per issue
only).

Test plan:
  - Apply this patch,
  - Launch installer/data/mysql/updatedatabase.pl
  - Launch misc/devel/update_dbix_class_files.pl

  - Create a daily subscription. i.e:
    - From: 2017-10-09, To: 2017-10-15,
    - Frequency: 1/day,
    - 7 issues,
    - test prediction pattern
    - check Wednesday and Thursday as irregularity,
    - save
  - Edit subscription,
  - Check that Wednesday and Thursday are still checked
  - Renew subscription from 2017-10-16
  - Edit subscription,
  - Make sure that Wednesday and Thursday are still checked
    with corresponding serials

  - Do the same for a monthly and weekly subscription

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Nov 13 15:28:31 2017
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 13 Nov 2017 14:28:31 +0000
Subject: [Koha-bugs] [Bug 17656] Irregularities in serial prediction pattern
 are planned only for current subscription
In-Reply-To: <bug-17656-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-17656-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-17656-70-r24ScrcUxB@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17656

Alex Arnaud <alex.arnaud at biblibre.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Failed QA                   |Needs Signoff

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Nov 13 15:32:39 2017
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 13 Nov 2017 14:32:39 +0000
Subject: [Koha-bugs] [Bug 18712] make test is failing with an empty DB -
	t/Matcher.t
In-Reply-To: <bug-18712-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-18712-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-18712-70-vQOjbvAgum@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18712

Tom?s Cohen Arazi <tomascohen at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |tomascohen at gmail.com
         QA Contact|testopia at bugs.koha-communit |nick at bywatersolutions.com
                   |y.org                       |

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Nov 13 15:51:51 2017
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 13 Nov 2017 14:51:51 +0000
Subject: [Koha-bugs] [Bug 19616] New: Formatted Contents Note (Marc 21 505),
 subfield g isn'  t visible in the OPAC
Message-ID: <bug-19616-70@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19616

            Bug ID: 19616
           Summary: Formatted Contents Note (Marc 21 505), subfield g
                    isn't visible in the OPAC
 Change sponsored?: ---
           Product: Koha
           Version: 16.05
          Hardware: All
                OS: All
            Status: NEW
          Severity: enhancement
          Priority: P5 - low
         Component: OPAC
          Assignee: oleonard at myacpl.org
          Reporter: verolencinas at yahoo.com.ar
        QA Contact: testopia at bugs.koha-community.org

The 505 field in Marc 21, Formatted Contents Note, includes subfield g
"Miscellaneous information". According to the Marc 21 format for bibliographic
data, it is used to record "volume, part, page numbering or other extent
information such as dates". If you use it in Koha, this information isn't
visible in the OPAC.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Nov 13 16:05:53 2017
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 13 Nov 2017 15:05:53 +0000
Subject: [Koha-bugs] [Bug 17674] Allow UI to delete serials in batch
In-Reply-To: <bug-17674-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-17674-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-17674-70-8c2k1XmqwR@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17674

--- Comment #20 from Marjorie Barry-Vila <marjorie.barry-vila at collecto.ca> ---
*** Bug 12575 has been marked as a duplicate of this bug. ***

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Nov 13 16:05:53 2017
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 13 Nov 2017 15:05:53 +0000
Subject: [Koha-bugs] [Bug 12575] Add option to delete several issues on page
 Serial collection
In-Reply-To: <bug-12575-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-12575-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-12575-70-ZJkMGJpoUd@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12575

Marjorie Barry-Vila <marjorie.barry-vila at collecto.ca> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
         Resolution|---                         |DUPLICATE
             Status|NEW                         |RESOLVED

--- Comment #1 from Marjorie Barry-Vila <marjorie.barry-vila at collecto.ca> ---


*** This bug has been marked as a duplicate of bug 17674 ***

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.

From bugzilla-daemon at bugs.koha-community.org  Mon Nov 13 16:26:25 2017
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 13 Nov 2017 15:26:25 +0000
Subject: [Koha-bugs] [Bug 18712] make test is failing with an empty DB -
	t/Matcher.t
In-Reply-To: <bug-18712-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-18712-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-18712-70-GXhKLxZUKP@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18712

--- Comment #14 from M. Tompsett <mtompset at hotmail.com> ---
(In reply to Nick Clemens from comment #13)
> (In reply to M. Tompsett from comment #8)
> > Created attachment 68987 [details] [review] [review]
> > Bug 18712: Added missing done_testing
> > 
> > Signed-off-by: Mark Tompsett <mtompset at hotmail.com>
> 
> Added followup, we can count these tests so should have a planned number

Not that I'll challenge this, but using done_testing is better, in my opinion,
in that it prevents test conflicts when multiple bugs add tests to the same
test file. I've encountered this a couple times when working on bugs related to
tests.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Nov 13 16:32:46 2017
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 13 Nov 2017 15:32:46 +0000
Subject: [Koha-bugs] [Bug 11067] Rename 'Advanced search' on serial home
 page to ' Filters on search results'
In-Reply-To: <bug-11067-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-11067-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-11067-70-bS8lO4Xpx7@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11067

--- Comment #4 from Marjorie Barry-Vila <marjorie.barry-vila at collecto.ca> ---
In 16.11 and 17.05, the form "Search subscriptions" displayed after a search
(simple or advanced) allows to redo a search on all subscriptions. It's not
just a filter form anymore.
For me this request is solved.

Regards,
Marjorie

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Nov 13 16:34:20 2017
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 13 Nov 2017 15:34:20 +0000
Subject: [Koha-bugs] [Bug 18547] On shelf holds allowed > "If all
 unavailable" ignores default hold policy
In-Reply-To: <bug-18547-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-18547-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-18547-70-uyioBsgraY@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18547

Nick Clemens <nick at bywatersolutions.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
         QA Contact|testopia at bugs.koha-communit |nick at bywatersolutions.com
                   |y.org                       |

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Nov 13 16:38:34 2017
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 13 Nov 2017 15:38:34 +0000
Subject: [Koha-bugs] [Bug 18547] On shelf holds allowed > "If all
 unavailable" ignores default hold policy
In-Reply-To: <bug-18547-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-18547-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-18547-70-q2ar8jwlJ9@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18547

Nick Clemens <nick at bywatersolutions.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Signed Off                  |Passed QA

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Nov 13 16:38:37 2017
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 13 Nov 2017 15:38:37 +0000
Subject: [Koha-bugs] [Bug 18547] On shelf holds allowed > "If all
 unavailable" ignores default hold policy
In-Reply-To: <bug-18547-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-18547-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-18547-70-cUUqgV1Fas@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18547

Nick Clemens <nick at bywatersolutions.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #66675|0                           |1
        is obsolete|                            |
  Attachment #68854|0                           |1
        is obsolete|                            |

--- Comment #18 from Nick Clemens <nick at bywatersolutions.com> ---
Created attachment 69125
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=69125&action=edit
Add tests

https://bugs.koha-community.org/show_bug.cgi?id=18547

Signed-off-by: Nick Clemens <nick at bywatersolutions.com>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Nov 13 16:38:40 2017
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 13 Nov 2017 15:38:40 +0000
Subject: [Koha-bugs] [Bug 18547] On shelf holds allowed > "If all
 unavailable" ignores default hold policy
In-Reply-To: <bug-18547-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-18547-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-18547-70-qvAhDm4bg1@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18547

--- Comment #19 from Nick Clemens <nick at bywatersolutions.com> ---
Created attachment 69126
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=69126&action=edit
Bug 18547 - On shelf holds allowed > "If all unavailable" ignores default hold
policy

If in the circ rules matrix you set "On shelf holds allowed" to "If all
unavailable",
default hold policy "From home library" is ignored.

Test plan:

- Have a test user from one branch (eg Centerville)

- Set "On shelf holds allowed" to "If all unavailable" for your patron and item
  category (or everyone and everything)
- For "Default checkout, hold and return policy", set hold policy to "From home
library"
  -> make sure there is no "Default holds policy by item type" to override the
setting

- Have two items for a record.
  1. An item with home branch same as test user (eg Centerville)
  -> check this item out to somebody else
  2. an item with a different home branch (eg Fairfield)
  -> available, not checked out
- Try to place a hold for your test user. Does not work.

- Apply the patch
- Try to place a hold. Should work now.

Followed test plan, worked as intended
Signed-off-by: Alex Buckley <alexbuckley at catalyst.net.nz>

Followed test plan in the intranet and OPAC, worked as intended.
With few assumptions made:
- when the hold works, should be on the item 1 (Centerville)
  item 2 is only there to trigger the bug
- the circ rules were identically setup on each branch and in "Standard rules
for all libraries"
Signed-off-by: Victor Grousset <victor.grousset at biblibre.com>

Signed-off-by: Nick Clemens <nick at bywatersolutions.com>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Nov 13 16:38:43 2017
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 13 Nov 2017 15:38:43 +0000
Subject: [Koha-bugs] [Bug 18547] On shelf holds allowed > "If all
 unavailable" ignores default hold policy
In-Reply-To: <bug-18547-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-18547-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-18547-70-AiuPOlZ897@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18547

--- Comment #20 from Nick Clemens <nick at bywatersolutions.com> ---
Created attachment 69127
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=69127&action=edit
Bug 18547: QA Followup

Added comments to make clearer

Tests had some confusion with names and results, though they do seem to
cover the changes here.

I believe the tests highlight that ReserveControlBranch has no effect,
and possibly it should? Beyond the scope here but left those tests
for future work to be done

Signed-off-by: Nick Clemens <nick at bywatersolutions.com>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Nov 13 16:54:26 2017
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 13 Nov 2017 15:54:26 +0000
Subject: [Koha-bugs] [Bug 18712] make test is failing with an empty DB -
	t/Matcher.t
In-Reply-To: <bug-18712-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-18712-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-18712-70-bAMFJ9v5FN@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18712

--- Comment #15 from Tom?s Cohen Arazi <tomascohen at gmail.com> ---
(In reply to M. Tompsett from comment #14)
> (In reply to Nick Clemens from comment #13)
> > (In reply to M. Tompsett from comment #8)
> > > Created attachment 68987 [details] [review] [review] [review]
> > > Bug 18712: Added missing done_testing
> > > 
> > > Signed-off-by: Mark Tompsett <mtompset at hotmail.com>
> > 
> > Added followup, we can count these tests so should have a planned number
> 
> Not that I'll challenge this, but using done_testing is better, in my
> opinion, in that it prevents test conflicts when multiple bugs add tests to
> the same test file. I've encountered this a couple times when working on
> bugs related to tests.

Maybe koha-devel is a good place to discuss such a change.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Nov 13 16:57:25 2017
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 13 Nov 2017 15:57:25 +0000
Subject: [Koha-bugs] [Bug 16688] RenewSerialAddsSuggestion - suggestions not
 showing up, note not saved
In-Reply-To: <bug-16688-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-16688-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-16688-70-KevsZoB1Fg@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16688

Marjorie Barry-Vila <marjorie.barry-vila at collecto.ca> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |marjorie.barry-vila at collect
                   |                            |o.ca

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Nov 13 16:58:51 2017
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 13 Nov 2017 15:58:51 +0000
Subject: [Koha-bugs] [Bug 19617] New: Development - Allow partial writeoff
Message-ID: <bug-19617-70@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19617

            Bug ID: 19617
           Summary: Development - Allow partial writeoff
 Change sponsored?: ---
           Product: Koha
           Version: master
          Hardware: All
                OS: All
            Status: NEW
          Severity: enhancement
          Priority: P5 - low
         Component: Architecture, internals, and plumbing
          Assignee: jesse at bywatersolutions.com
          Reporter: kyle at bywatersolutions.com
        QA Contact: testopia at bugs.koha-community.org

Add ?Write off selected? button

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Nov 13 17:00:03 2017
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 13 Nov 2017 16:00:03 +0000
Subject: [Koha-bugs] [Bug 19536] Odd number of elements in anonymous hash in
	svc/bib
In-Reply-To: <bug-19536-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-19536-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-19536-70-pis7jkRT0p@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19536

Nick Clemens <nick at bywatersolutions.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #68800|0                           |1
        is obsolete|                            |

--- Comment #3 from Nick Clemens <nick at bywatersolutions.com> ---
Created attachment 69128
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=69128&action=edit
Bug 19536: Odd number of elements in anonymous hash in svc/bib

Resolve:
Odd number of elements in anonymous hash at svc/bib line 69.
Odd number of elements in anonymous hash at svc/bib line 118.

You can see such warnings when testing the Rancor editor.

Replacing url_param by param in fetch_bib since it is a GET call.
Not sure about doing the same in update_bib since that is a POST.
The scalar context will resolve the odd number warns.

Adding a scalar in svc/new_bib too.

Test plan:
Try URL /cgi-bin/koha/svc/bib/[number] with and without the patch.

Signed-off-by: Katrin Fischer <katrin.fischer.83 at web.de>

Signed-off-by: Nick Clemens <nick at bywatersolutions.com>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Nov 13 17:00:11 2017
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 13 Nov 2017 16:00:11 +0000
Subject: [Koha-bugs] [Bug 19536] Odd number of elements in anonymous hash in
	svc/bib
In-Reply-To: <bug-19536-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-19536-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-19536-70-h6sgs42Q1s@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19536

Nick Clemens <nick at bywatersolutions.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
         QA Contact|testopia at bugs.koha-communit |nick at bywatersolutions.com
                   |y.org                       |
                 CC|                            |nick at bywatersolutions.com

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Nov 13 17:00:00 2017
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 13 Nov 2017 16:00:00 +0000
Subject: [Koha-bugs] [Bug 19536] Odd number of elements in anonymous hash in
	svc/bib
In-Reply-To: <bug-19536-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-19536-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-19536-70-9eljwQp3Tk@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19536

Nick Clemens <nick at bywatersolutions.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Signed Off                  |Passed QA

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Nov 13 17:03:36 2017
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 13 Nov 2017 16:03:36 +0000
Subject: [Koha-bugs] [Bug 19618] New: Automatic/standing holds
Message-ID: <bug-19618-70@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19618

            Bug ID: 19618
           Summary: Automatic/standing holds
 Change sponsored?: ---
           Product: Koha
           Version: master
          Hardware: All
                OS: All
            Status: NEW
          Severity: enhancement
          Priority: P5 - low
         Component: Architecture, internals, and plumbing
          Assignee: jesse at bywatersolutions.com
          Reporter: kyle at bywatersolutions.com
        QA Contact: testopia at bugs.koha-community.org

1) Add a pulldown and button labeled "Add randomized holds" to the holds page
for each bib

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Nov 13 17:09:58 2017
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 13 Nov 2017 16:09:58 +0000
Subject: [Koha-bugs] [Bug 19619] New: Add support for SIP2 field CM ( Hold
 Pickup Date ) to Koha
Message-ID: <bug-19619-70@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19619

            Bug ID: 19619
           Summary: Add support for SIP2 field CM ( Hold Pickup Date ) to
                    Koha
 Change sponsored?: ---
           Product: Koha
           Version: master
          Hardware: All
                OS: All
            Status: NEW
          Severity: enhancement
          Priority: P5 - low
         Component: Architecture, internals, and plumbing
          Assignee: jesse at bywatersolutions.com
          Reporter: kyle at bywatersolutions.com
        QA Contact: testopia at bugs.koha-community.org

Add support for SIP2 field CM ( Hold Pickup Date ) to Koha

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Nov 13 17:11:21 2017
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 13 Nov 2017 16:11:21 +0000
Subject: [Koha-bugs] [Bug 18357] On-site checkouts issues with 'Unlimited'
In-Reply-To: <bug-18357-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-18357-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-18357-70-kiawvKaBhY@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18357

Nick Clemens <nick at bywatersolutions.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Signed Off                  |Passed QA

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.

From bugzilla-daemon at bugs.koha-community.org  Mon Nov 13 17:11:40 2017
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 13 Nov 2017 16:11:40 +0000
Subject: [Koha-bugs] [Bug 18357] On-site checkouts issues with 'Unlimited'
In-Reply-To: <bug-18357-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-18357-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-18357-70-bNqxXaRFkG@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18357

Nick Clemens <nick at bywatersolutions.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
         QA Contact|jonathan.druart at bugs.koha-c |nick at bywatersolutions.com
                   |ommunity.org                |
           Assignee|koha-bugs at lists.koha-commun |jonathan.druart at bugs.koha-c
                   |ity.org                     |ommunity.org

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Nov 13 17:11:23 2017
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 13 Nov 2017 16:11:23 +0000
Subject: [Koha-bugs] [Bug 18357] On-site checkouts issues with 'Unlimited'
In-Reply-To: <bug-18357-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-18357-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-18357-70-HEdWe8ArOH@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18357

Nick Clemens <nick at bywatersolutions.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #68930|0                           |1
        is obsolete|                            |

--- Comment #6 from Nick Clemens <nick at bywatersolutions.com> ---
Created attachment 69129
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=69129&action=edit
Bug 18357: Handle unlimited on-site checkouts

If on-site checkouts are set to unlimited (i.e. NULL/undef), they are
currently blocked.

Test plan:
1/ Set All/All rule with Unlimited/unlimited for normal/onsite checkouts
2/ Will be able to perform onsite checkout
3/ Edit rule to be 15/Unlimited normal/onsite
4/ Will be able to perform onsite checkout
=> Without this patch it was blocked
5/ Set rule to 15/15
6/ Onsite checkouts work again

Signed-off-by: David Bourgault <david.bourgault at inlibro.com>

Signed-off-by: Nick Clemens <nick at bywatersolutions.com>

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.

From bugzilla-daemon at bugs.koha-community.org  Mon Nov 13 17:23:59 2017
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 13 Nov 2017 16:23:59 +0000
Subject: [Koha-bugs] [Bug 19560] Unable to delete library when branchcode
 contains special characters
In-Reply-To: <bug-19560-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-19560-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-19560-70-02NuPVhebo@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19560

Nick Clemens <nick at bywatersolutions.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Signed Off                  |Passed QA

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Nov 13 17:24:02 2017
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 13 Nov 2017 16:24:02 +0000
Subject: [Koha-bugs] [Bug 19560] Unable to delete library when branchcode
 contains special characters
In-Reply-To: <bug-19560-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-19560-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-19560-70-eJjTsODXTc@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19560

Nick Clemens <nick at bywatersolutions.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #69097|0                           |1
        is obsolete|                            |

--- Comment #4 from Nick Clemens <nick at bywatersolutions.com> ---
Created attachment 69130
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=69130&action=edit
Bug 19560: Unable to delete library when branchcode contains special characters

This patch modifies the library administration page so that the library
delete button submits a form using POST rather than linking to the
delete operation with GET variables.

This patch also adds validation to the library entry form so that it
will only accept letters, numbers, hyphen, and underscore.

The validation method for this already existed in categories.js, so it
has been moved to staff-global.js and the validator warning message has
been moved to validator-strings.inc so it is included globally.

To test:
  - Add a library with a branchcode containing characters like & or
    #.
  - Apply the patch and clear your browser cache if necessary.
  - Try to delete the new library. It should delete successfully.
  - Add a library again and try to include spaces and/or special
    characters in the branchcode. The form validation script should
    prevent you from submitting the form.
  - Go do Administration -> Patron categories and add a new patron
    category. The category code field should prevent you from entering a
    code with spaces or special characters.

Signed-off-by: David Bourgault <david.bourgault at inlibro.com>

Signed-off-by: Nick Clemens <nick at bywatersolutions.com>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Nov 13 17:25:26 2017
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 13 Nov 2017 16:25:26 +0000
Subject: [Koha-bugs] [Bug 19620] New: Allow skipping of patrons with valid
 emails for Talking Tech
Message-ID: <bug-19620-70@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19620

            Bug ID: 19620
           Summary: Allow skipping of patrons with valid emails for
                    Talking Tech
 Change sponsored?: ---
           Product: Koha
           Version: master
          Hardware: All
                OS: All
            Status: NEW
          Severity: enhancement
          Priority: P5 - low
         Component: Architecture, internals, and plumbing
          Assignee: jesse at bywatersolutions.com
          Reporter: kyle at bywatersolutions.com
        QA Contact: testopia at bugs.koha-community.org

1) Modify the TT outbound script

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Nov 13 17:26:13 2017
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 13 Nov 2017 16:26:13 +0000
Subject: [Koha-bugs] [Bug 19560] Unable to delete library when branchcode
 contains special characters
In-Reply-To: <bug-19560-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-19560-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-19560-70-MFr0R27ZpH@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19560

Nick Clemens <nick at bywatersolutions.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |nick at bywatersolutions.com

--- Comment #5 from Nick Clemens <nick at bywatersolutions.com> ---
I think this is a good start. We probably want these restrictions on authorised
values too.

We will also need a warning on the about page for pre-existing values

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Nov 13 17:27:17 2017
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 13 Nov 2017 16:27:17 +0000
Subject: [Koha-bugs] [Bug 19620] Allow skipping of patrons with valid emails
 for Talking Tech
In-Reply-To: <bug-19620-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-19620-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-19620-70-6rzAO0XJ6i@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19620

--- Comment #1 from Kyle M Hall <kyle at bywatersolutions.com> ---
Some libraries want to be able to skip patrons with valid email addresses when
generated outbound files for Talking Tech.

Course of action:
1) Modify the TT outbound script
  a) Add new '--skip-patrons-with-email' flag
  b) Modify the script to only return overdues where
C4::Members::GetFirstValidEmailAddress comes back false
  c) Modify C4::Members::GetFirstValidEmailAddress to accept an optional
hashref of patron data to avoid the cost of a double lookup

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Nov 13 17:28:33 2017
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 13 Nov 2017 16:28:33 +0000
Subject: [Koha-bugs] [Bug 18993] Bump libtest-simple-perl to 1.302075
In-Reply-To: <bug-18993-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-18993-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-18993-70-hXRDSc4ciS@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18993

Nick Clemens <nick at bywatersolutions.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Signed Off                  |Failed QA
                 CC|                            |nick at bywatersolutions.com

--- Comment #17 from Nick Clemens <nick at bywatersolutions.com> ---
Failing for comment 16

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Nov 13 17:53:59 2017
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 13 Nov 2017 16:53:59 +0000
Subject: [Koha-bugs] [Bug 19456] Some pages title tag contains html
In-Reply-To: <bug-19456-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-19456-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-19456-70-eRdqbfCAah@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19456

Nick Clemens <nick at bywatersolutions.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Signed Off                  |Passed QA

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Nov 13 17:54:02 2017
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 13 Nov 2017 16:54:02 +0000
Subject: [Koha-bugs] [Bug 19456] Some pages title tag contains html
In-Reply-To: <bug-19456-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-19456-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-19456-70-DXTZ988x16@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19456

Nick Clemens <nick at bywatersolutions.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #68790|0                           |1
        is obsolete|                            |

--- Comment #12 from Nick Clemens <nick at bywatersolutions.com> ---
Created attachment 69131
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=69131&action=edit
Bug 19456: Make patron-title ability to be generated with or without html tags

Modified pages:
circ/circulation.pl
circ/circulation_batch_checkouts.pl
members/boraccount.pl
members/files.pl
members/holdshistory.pl
members/housebound.pl
members/moremember.pl
members/notices.pl
members/purchase-suggestions.pl
members/readingrec.pl
members/routing-lists.pl
members/statistics.pl

Test plan:
0) Do not apply the patch
1) Have a patron with title/salution filled in
2) Confirm bug, go for example to circ/circulation page and see there is
html in <title> tag (you can see it in your browser page/window title)
3) Apply the patch
4) Go through circulation/patron pages (see modified page above) and
confirm there is no html in <title> tag, but on the page itself the
salutation should be in <span class="patron-title">

Signed-off-by: David Bourgalt <david.bourgault at inlibro.com>

Signed-off-by: Nick Clemens <nick at bywatersolutions.com>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Nov 13 18:18:35 2017
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 13 Nov 2017 17:18:35 +0000
Subject: [Koha-bugs] [Bug 19621] New: Routing lists tab not present when
 viewing 'Holds history ' tab for a patron
Message-ID: <bug-19621-70@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19621

            Bug ID: 19621
           Summary: Routing lists tab not present when viewing 'Holds
                    history' tab for a patron
 Change sponsored?: ---
           Product: Koha
           Version: master
          Hardware: All
                OS: All
            Status: NEW
          Severity: minor
          Priority: P5 - low
         Component: Patrons
          Assignee: koha-bugs at lists.koha-community.org
          Reporter: nick at bywatersolutions.com
        QA Contact: testopia at bugs.koha-community.org
                CC: gmcharlt at gmail.com, kyle.m.hall at gmail.com

To recreate:
1 - Enable RoutingSerials syspref
2 - Open a patron record
3 - Click through the tabs on the left side of the screen
4 - Note that 'Routing lists' is visible on all screens except 'Holds history'

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Nov 13 18:20:58 2017
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 13 Nov 2017 17:20:58 +0000
Subject: [Koha-bugs] [Bug 19621] Routing lists tab not present when viewing
 'Holds history' tab for a patron
In-Reply-To: <bug-19621-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-19621-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-19621-70-04P9ANd0XR@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19621

Nick Clemens <nick at bywatersolutions.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
   Patch complexity|---                         |Trivial patch
             Status|NEW                         |Needs Signoff

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.

From bugzilla-daemon at bugs.koha-community.org  Mon Nov 13 18:21:00 2017
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 13 Nov 2017 17:21:00 +0000
Subject: [Koha-bugs] [Bug 19621] Routing lists tab not present when viewing
 'Holds history' tab for a patron
In-Reply-To: <bug-19621-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-19621-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-19621-70-xlzYJXbEOj@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19621

--- Comment #1 from Nick Clemens <nick at bywatersolutions.com> ---
Created attachment 69132
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=69132&action=edit
Bug 19621 - Use preference check on template side to display/not display
Routing lists tab

Currently we pass a param to control display - the param is a just a
check of syspref so can be done directly form template

To test:
1 - Enable RoutingSerials syspref
2 - Open a patron record
3 - Click through the tabs on the left side of the screen
4 - Note that 'Routing lists' is visible on all screens except 'Holds
history'
5 - Apply patch
6 - 'Routing lists' should now be visible in all tabs.

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Nov 13 18:21:12 2017
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 13 Nov 2017 17:21:12 +0000
Subject: [Koha-bugs] [Bug 19621] Routing lists tab not present when viewing
 'Holds history' tab for a patron
In-Reply-To: <bug-19621-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-19621-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-19621-70-RwObQiEZzD@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19621

Nick Clemens <nick at bywatersolutions.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
           Assignee|koha-bugs at lists.koha-commun |nick at bywatersolutions.com
                   |ity.org                     |

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Nov 13 18:33:48 2017
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 13 Nov 2017 17:33:48 +0000
Subject: [Koha-bugs] [Bug 10222] Error when saving Demco label templates
In-Reply-To: <bug-10222-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-10222-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-10222-70-g0DeaBnC7D@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10222

Nick Clemens <nick at bywatersolutions.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Signed Off                  |Passed QA

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Nov 13 18:33:51 2017
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 13 Nov 2017 17:33:51 +0000
Subject: [Koha-bugs] [Bug 10222] Error when saving Demco label templates
In-Reply-To: <bug-10222-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-10222-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-10222-70-rZApeeA0ID@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10222

Nick Clemens <nick at bywatersolutions.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #68801|0                           |1
        is obsolete|                            |
  Attachment #68802|0                           |1
        is obsolete|                            |

--- Comment #14 from Nick Clemens <nick at bywatersolutions.com> ---
Created attachment 69133
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=69133&action=edit
Bug 10222 - Error when saving Demco label templates

This patch fixes a bug whereby if you open either of the
Demco label templates (loaded by the sample data) and
click "save" without making any changes you will get an
error:

Can't bless non-reference value at C4/Creators/Profile.pm
line 92.

It also fixes another minor bug in the creator sample data.

To test:

1. Install all sample data in a clean database.
2. In the label tool, edit either of the Demco label templates.
3. Save the template and observe the error mentioned above.
4. Drop and recreate the database.
5. Apply the patch.
6. Repeate steps 1-3 and note the successful save.

Signed-off-by: Mark Tompsett <mtompset at hotmail.com>

Signed-off-by: Katrin Fischer <katrin.fischer.83 at web.de>

Signed-off-by: Nick Clemens <nick at bywatersolutions.com>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Nov 13 18:33:54 2017
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 13 Nov 2017 17:33:54 +0000
Subject: [Koha-bugs] [Bug 10222] Error when saving Demco label templates
In-Reply-To: <bug-10222-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-10222-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-10222-70-8SK3hUPLbq@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10222

--- Comment #15 from Nick Clemens <nick at bywatersolutions.com> ---
Created attachment 69134
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=69134&action=edit
Bug 10222: Correct and expand to other languages

This added column names, and reformated to be a bit more readable.
This also adds this change to de-DE, es-ES, fr-CA, and nb-NO.
While there was printer_profiles for it-IT, the Italian file seems
to not use the same numbers, and does not visibly look like it needs
these changes.

Signed-off-by: Mark Tompsett <mtompset at hotmail.com>

Signed-off-by: Katrin Fischer <katrin.fischer.83 at web.de>

Signed-off-by: Nick Clemens <nick at bywatersolutions.com>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Nov 13 18:37:50 2017
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 13 Nov 2017 17:37:50 +0000
Subject: [Koha-bugs] [Bug 10222] Error when saving Demco label templates
In-Reply-To: <bug-10222-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-10222-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-10222-70-OTaZDvPctx@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10222

Chris Nighswonger <cnighswonger at foundations.edu> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
           Assignee|cnighswonger at foundations.ed |mtompset at hotmail.com
                   |u                           |

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Nov 13 18:39:31 2017
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 13 Nov 2017 17:39:31 +0000
Subject: [Koha-bugs] [Bug 10222] Error when saving Demco label templates
In-Reply-To: <bug-10222-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-10222-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-10222-70-gZxIjUatr7@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10222

Chris Nighswonger <cnighswonger at foundations.edu> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
         QA Contact|                            |nick at bywatersolutions.com

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Nov 13 19:13:01 2017
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 13 Nov 2017 18:13:01 +0000
Subject: [Koha-bugs] [Bug 19560] Unable to delete library when branchcode
 contains special characters
In-Reply-To: <bug-19560-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-19560-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-19560-70-R3YUGUfLAq@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19560

Katrin Fischer <katrin.fischer at bsz-bw.de> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |katrin.fischer at bsz-bw.de

--- Comment #6 from Katrin Fischer <katrin.fischer at bsz-bw.de> ---
(In reply to Nick Clemens from comment #5)
> I think this is a good start. We probably want these restrictions on
> authorised values too.
> 
> We will also need a warning on the about page for pre-existing values

We didn't do this on authorised values because of things like MAN_INV - this
has the display text in the field for the code :(

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Nov 13 19:21:34 2017
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 13 Nov 2017 18:21:34 +0000
Subject: [Koha-bugs] [Bug 19602] Add usage statistics link to administration
	sidebar menu
In-Reply-To: <bug-19602-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-19602-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-19602-70-PyZXszLW13@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19602

Nick Clemens <nick at bywatersolutions.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #69079|0                           |1
        is obsolete|                            |

--- Comment #3 from Nick Clemens <nick at bywatersolutions.com> ---
Created attachment 69135
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=69135&action=edit
Bug 19602 - Add usage statistics link to administration sidebar menu

This patch adds a link to the new usage statistics page in the
administration sidebar menu.

To test, apply the patch and view an administration page which includes
the admin sidebar. Confirm that the link to usage statistics is there.

Visit the usage statistics page and confirm that the usage statistics
link in the sidebar is display in bold.

Signed-off-by: Simon Pouchol <simon.pouchol at biblibre.com>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Nov 13 19:21:31 2017
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 13 Nov 2017 18:21:31 +0000
Subject: [Koha-bugs] [Bug 19602] Add usage statistics link to administration
	sidebar menu
In-Reply-To: <bug-19602-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-19602-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-19602-70-m94XECxns6@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19602

Nick Clemens <nick at bywatersolutions.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Signed Off                  |Passed QA

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Nov 13 19:26:03 2017
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 13 Nov 2017 18:26:03 +0000
Subject: [Koha-bugs] [Bug 19602] Add usage statistics link to administration
	sidebar menu
In-Reply-To: <bug-19602-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-19602-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-19602-70-Tlc2c2KXmj@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19602

Nick Clemens <nick at bywatersolutions.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #69135|0                           |1
        is obsolete|                            |

--- Comment #4 from Nick Clemens <nick at bywatersolutions.com> ---
Created attachment 69136
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=69136&action=edit
Bug 19602 - Add usage statistics link to administration sidebar menu

This patch adds a link to the new usage statistics page in the
administration sidebar menu.

To test, apply the patch and view an administration page which includes
the admin sidebar. Confirm that the link to usage statistics is there.

Visit the usage statistics page and confirm that the usage statistics
link in the sidebar is display in bold.

Signed-off-by: Simon Pouchol <simon.pouchol at biblibre.com>

Signed-off-by: Nick Clemens <nick at bywatersolutions.com>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Nov 13 22:47:44 2017
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 13 Nov 2017 21:47:44 +0000
Subject: [Koha-bugs] [Bug 19549] Reserve Slip prints first found hold when
 patron has multiple holds on a biblio
In-Reply-To: <bug-19549-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-19549-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-19549-70-Ynz70lhYlz@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19549

Jason Palmer <jpalmer at switchinc.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |jschmidt at switchinc.org

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Nov 14 03:11:20 2017
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 14 Nov 2017 02:11:20 +0000
Subject: [Koha-bugs] [Bug 19622] New: Stage MARC records pagination
Message-ID: <bug-19622-70@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19622

            Bug ID: 19622
           Summary: Stage MARC records pagination
 Change sponsored?: ---
           Product: Koha
           Version: 17.05
          Hardware: All
                OS: All
            Status: NEW
          Severity: enhancement
          Priority: P5 - low
         Component: Cataloging
          Assignee: koha-bugs at lists.koha-community.org
          Reporter: michael at bywatersolutions.com
        QA Contact: testopia at bugs.koha-community.org
                CC: m.de.rooy at rijksmuseum.nl

Created attachment 69137
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=69137&action=edit
Pagination manges staged MARC records

In version 17.05, it seems the pagination when on Manage Staged MARC records
screen is not displaying in a row (rather, in a column).  Also, when there are
many pages, it seems the typical pagination layout is not being applied (the
arrows that appear).

See attached screenshot.

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Nov 14 09:19:06 2017
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 14 Nov 2017 08:19:06 +0000
Subject: [Koha-bugs] [Bug 11067] Rename 'Advanced search' on serial home
 page to ' Filters on search results'
In-Reply-To: <bug-11067-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-11067-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-11067-70-0kgUDdCPO8@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11067

Zeno Tajoli <z.tajoli at cineca.it> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
         Resolution|---                         |FIXED
             Status|NEW                         |RESOLVED

--- Comment #5 from Zeno Tajoli <z.tajoli at cineca.it> ---
I confirm that now the problem is over.
In fact the bug is resolved by bug 10855 [pushed into master at Fri, 2 Oct
2015]

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.

From bugzilla-daemon at bugs.koha-community.org  Tue Nov 14 09:19:50 2017
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 14 Nov 2017 08:19:50 +0000
Subject: [Koha-bugs] [Bug 11067] Rename 'Advanced search' on serial home
 page to ' Filters on search results'
In-Reply-To: <bug-11067-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-11067-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-11067-70-mkeIB1lekx@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11067

Zeno Tajoli <z.tajoli at cineca.it> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
           See Also|                            |https://bugs.koha-community
                   |                            |.org/bugzilla3/show_bug.cgi
                   |                            |?id=10855

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.

From bugzilla-daemon at bugs.koha-community.org  Tue Nov 14 09:19:50 2017
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 14 Nov 2017 08:19:50 +0000
Subject: [Koha-bugs] [Bug 10855] Custom fields for subscriptions
In-Reply-To: <bug-10855-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-10855-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-10855-70-wutlWnn6vc@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10855

Zeno Tajoli <z.tajoli at cineca.it> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
           See Also|                            |https://bugs.koha-community
                   |                            |.org/bugzilla3/show_bug.cgi
                   |                            |?id=11067

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Nov 14 10:16:52 2017
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 14 Nov 2017 09:16:52 +0000
Subject: [Koha-bugs] [Bug 18799] XSLTresultsdisplay hides the icons
In-Reply-To: <bug-18799-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-18799-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-18799-70-OCykrPVoEK@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18799

Fridolin SOMERS <fridolin.somers at biblibre.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
           Assignee|baptiste.wojtkowski at biblibr |fridolin.somers at biblibre.co
                   |e.com                       |m

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Nov 14 12:01:59 2017
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 14 Nov 2017 11:01:59 +0000
Subject: [Koha-bugs] [Bug 3841] Add a Default ACQ framework
In-Reply-To: <bug-3841-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-3841-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-3841-70-6FMBll09kE@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=3841

Nick Clemens <nick at bywatersolutions.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Signed Off                  |Passed QA

-- 
You are receiving this mail because:
You are the QA Contact for the bug.
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Nov 14 12:02:02 2017
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 14 Nov 2017 11:02:02 +0000
Subject: [Koha-bugs] [Bug 3841] Add a Default ACQ framework
In-Reply-To: <bug-3841-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-3841-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-3841-70-QNyL8IDMtj@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=3841

Nick Clemens <nick at bywatersolutions.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #69057|0                           |1
        is obsolete|                            |

--- Comment #11 from Nick Clemens <nick at bywatersolutions.com> ---
Created attachment 69138
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=69138&action=edit
Bug 3841: Add the ACQ framework for new installations

This patch adds the acquisition frameworks (frameworkcode=ACQ) for new
installations.
It copies the 952 (MARC21) or 995 (UNIMARC) fields from the default
framework (frameworkcode='')

Test plan:
Create a new installation and make sure the ACQ framework exists.

Signed-off-by: Josef Moravec <josef.moravec at gmail.com>
Signed-off-by: Nicolas Legrand <nicolas.legrand at bulac.fr>

Signed-off-by: Nick Clemens <nick at bywatersolutions.com>

-- 
You are receiving this mail because:
You are the QA Contact for the bug.
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Nov 14 13:30:42 2017
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 14 Nov 2017 12:30:42 +0000
Subject: [Koha-bugs] [Bug 13937] Add a Z39.50 daemon that can inject item
 status MARC subfields
In-Reply-To: <bug-13937-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-13937-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-13937-70-PIYcRA9e5D@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13937

--- Comment #40 from Nick Clemens <nick at bywatersolutions.com> ---
Created attachment 69139
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=69139&action=edit
Bug 13937: Followup - pass through yaz switches and don't ignore case

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Nov 14 14:46:00 2017
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 14 Nov 2017 13:46:00 +0000
Subject: [Koha-bugs] [Bug 19485] Limiting by title-series (se) broken on ES
In-Reply-To: <bug-19485-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-19485-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-19485-70-YIJvzO0yLj@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19485

S?verine Queune <severine.queune at bulac.fr> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |severine.queune at bulac.fr

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Nov 14 14:46:58 2017
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 14 Nov 2017 13:46:58 +0000
Subject: [Koha-bugs] [Bug 18213] Add language facets to Elasticsearch
In-Reply-To: <bug-18213-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-18213-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-18213-70-QcaszOYW2w@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18213

S?verine Queune <severine.queune at bulac.fr> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |severine.queune at bulac.fr

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Nov 14 14:58:57 2017
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 14 Nov 2017 13:58:57 +0000
Subject: [Koha-bugs] [Bug 19591] Saving a system preference jumps to main
	page
In-Reply-To: <bug-19591-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-19591-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-19591-70-Pj9jOfLzys@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19591

--- Comment #4 from Christian Stelzenm?ller <christian.stelzenmueller at bsz-bw.de> ---
Yes, it's Intranetuserjs.

It must be something in these parts:

var currlang = $('html').attr('lang');
$(".transl").hide();
$(".transl." + currlang).show();

if (currlang == 'en' || currlang == 'en-GB') {
$("span.results_summary span.de-DE").hide();
} else {
$("span.results_summary span.en").hide();
}

Thanks for the help!

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.

From bugzilla-daemon at bugs.koha-community.org  Tue Nov 14 15:19:13 2017
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 14 Nov 2017 14:19:13 +0000
Subject: [Koha-bugs] [Bug 19591] Saving a system preference jumps to main
	page
In-Reply-To: <bug-19591-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-19591-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-19591-70-LQESppOS8w@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19591

--- Comment #5 from Christian Stelzenm?ller <christian.stelzenmueller at bsz-bw.de> ---
It's the second dot in ".transl."

In 16.11 it's causing that error

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.

From bugzilla-daemon at bugs.koha-community.org  Tue Nov 14 15:22:34 2017
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 14 Nov 2017 14:22:34 +0000
Subject: [Koha-bugs] [Bug 19591] Saving a system preference jumps to main
	page
In-Reply-To: <bug-19591-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-19591-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-19591-70-eDH9HNefmF@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19591

Josef Moravec <josef.moravec at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
         Resolution|---                         |INVALID
             Status|NEW                         |RESOLVED

--- Comment #6 from Josef Moravec <josef.moravec at gmail.com> ---
(In reply to Christian Stelzenm?ller from comment #4)
> Yes, it's Intranetuserjs.
> 
> It must be something in these parts:
> 
> var currlang = $('html').attr('lang');
> $(".transl").hide();
> $(".transl." + currlang).show();
> 
> if (currlang == 'en' || currlang == 'en-GB') {
> $("span.results_summary span.de-DE").hide();
> } else {
> $("span.results_summary span.en").hide();
> }
> 
> Thanks for the help!


So I am closing this bug.

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.

From bugzilla-daemon at bugs.koha-community.org  Tue Nov 14 16:12:32 2017
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 14 Nov 2017 15:12:32 +0000
Subject: [Koha-bugs] [Bug 19575] Use canonical field names and resolve
	aliased fields
In-Reply-To: <bug-19575-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-19575-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-19575-70-fhfOofnW3s@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19575

David Gustafsson <glasklas at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #68914|0                           |1
        is obsolete|                            |

--- Comment #4 from David Gustafsson <glasklas at gmail.com> ---
Created attachment 69140
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=69140&action=edit
Bug 19575: Use canonical field names and resolve aliased fields

Adjust elastic search mappings to more closely match Zebra equivalents
resolving serveral issues with coded Zebra searches in templates, and
sorting of search results in UI.

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.

From bugzilla-daemon at bugs.koha-community.org  Tue Nov 14 16:47:44 2017
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 14 Nov 2017 15:47:44 +0000
Subject: [Koha-bugs] [Bug 16764] Update printers administration page
In-Reply-To: <bug-16764-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-16764-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-16764-70-T1bmGq6a3c@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16764

Owen Leonard <oleonard at myacpl.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|In Discussion               |Needs Signoff

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Nov 14 16:47:47 2017
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 14 Nov 2017 15:47:47 +0000
Subject: [Koha-bugs] [Bug 16764] Update printers administration page
In-Reply-To: <bug-16764-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-16764-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-16764-70-yTQrFRoaTF@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16764

Owen Leonard <oleonard at myacpl.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #52511|0                           |1
        is obsolete|                            |

--- Comment #7 from Owen Leonard <oleonard at myacpl.org> ---
Created attachment 69141
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=69141&action=edit
Bug 16764 - Update printers administration page

This patch updates the template for printers administration according to
current interface guidelines.

- Custom JavaScript form validation is removed in favor of the built-in
  form validation plugin.
- Printer-specific header search form is removed, along with server-side
  pagination code. The functionality of both is now taken care of the
  adding DataTables sorting and pagination to the table.
- Edit and delete links are styled as Boostrap buttons with Font Awesome
  icons.
- Confirmation dialogs are updated to use Font Awesome icons.

To test properly you will need to add multiple printers.

- Apply the patch and open /cgi-bin/koha/admin/printers.pl (there is no
  menu link for the page).
- When no printers exist you should see a message dialog saying so.
- Add a new printer. Confirm that printer name and queue are required
  fields.
- After adding multiple printers, confirm that the table of printers is
  correctly sorted and searched by the DataTables plugin.
- Delete a printer and verify that the confirmation dialog is correctly
  styled.

Signed-off-by: Marc V?ron <veron at veron.ch>

Update: rebased and updated Bootstrap 3 classes

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Nov 14 16:49:39 2017
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 14 Nov 2017 15:49:39 +0000
Subject: [Koha-bugs] [Bug 16764] Update printers administration page
In-Reply-To: <bug-16764-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-16764-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-16764-70-olAynE7sF0@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16764

Owen Leonard <oleonard at myacpl.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Needs Signoff               |Signed Off

--- Comment #8 from Owen Leonard <oleonard at myacpl.org> ---
I'd like to put this back in the queue since Bug 8352 has been idle for so
long.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Nov 14 17:29:14 2017
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 14 Nov 2017 16:29:14 +0000
Subject: [Koha-bugs] [Bug 13287] Add a system preference to define the
 number of days used in purge_suggestions.pl
In-Reply-To: <bug-13287-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-13287-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-13287-70-WCCCg0WMRF@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13287

David Bourgault <david.bourgault at inlibro.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #60569|0                           |1
        is obsolete|                            |

--- Comment #34 from David Bourgault <david.bourgault at inlibro.com> ---
Created attachment 69142
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=69142&action=edit
Bug13287 - Add a system preference to define the number of days used in
purge_suggestions.pl

    The system preferences value is used whenever purge_suggestions.pl is
called without the 'days' parameter.
    This patch uses the preference description suggested by comment #9.
    This version should now be cleanly applicable.

    I Apply the patch
    II Run updatedatabase.pl

    a) Run purge_suggestions.pl without the days parameter
       - validate that there is an error message
    b) Run purge_suggestions.pl with the days parameter
       - validate that there is no error message
    c) Insert a number of days in the system variable PurgeSuggestionsOlderThan
    d) Run purge_suggestions.pl without the days parameter
       - validate that there is no error message

Signed-off-by: Liz Rea <liz at catalyst.net.nz>
Tested per plan, all tests pass.

Signed-off-by: Marc V?ron <veron at veron.ch>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Nov 14 17:29:19 2017
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 14 Nov 2017 16:29:19 +0000
Subject: [Koha-bugs] [Bug 13287] Add a system preference to define the
 number of days used in purge_suggestions.pl
In-Reply-To: <bug-13287-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-13287-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-13287-70-ACKA2ugPp6@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13287

David Bourgault <david.bourgault at inlibro.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #68187|0                           |1
        is obsolete|                            |

--- Comment #35 from David Bourgault <david.bourgault at inlibro.com> ---
Created attachment 69143
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=69143&action=edit
Bug 13287: QA Follow up

Added missing upgrade SQL system preference.
Corrected system preference screen message
Fixes on purge_suggestions.pl
- perlcritic friendlier
- address $PERL5LIB comment by using $PROGRAM_NAME (comment #10)
- used STDERR (comment #10)
- perltidy

TEST PLAN
---------
$ ./installer/data/mysql/updatedatabase.pl
-- should run upgrade and generate new systempreference in table
$ ./misc/cronjobs/purge_suggestions.pl --help
-- should give help with a real path used instead of $PERL5LIB.
$ ./misc/cronjobs/purge_suggestions.pl -days -1
-- should give error message as expected
$ ./misc/cronjobs/purge_suggestions.pl -days 0
-- should give error message as expected

Go to OPAC system preferences tab and check the
PurgeSuggestionsOlderThan system preference
-- message should be as expected (see comment #9)

run koha qa test tools
-- all should pass

Signed-off-by: Marc V?ron <veron at veron.ch>
Signed-off-by: Jon Knight <J.P.Knight at lboro.ac.uk>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Nov 14 17:29:44 2017
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 14 Nov 2017 16:29:44 +0000
Subject: [Koha-bugs] [Bug 13287] Add a system preference to define the
 number of days used in purge_suggestions.pl
In-Reply-To: <bug-13287-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-13287-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-13287-70-mRDZ2xrhLa@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13287

David Bourgault <david.bourgault at inlibro.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |david.bourgault at inlibro.com

--- Comment #36 from David Bourgault <david.bourgault at inlibro.com> ---
Rebased.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Nov 14 18:13:09 2017
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 14 Nov 2017 17:13:09 +0000
Subject: [Koha-bugs] [Bug 19608] Move admin templates JavaScript to the
	footer: The rest
In-Reply-To: <bug-19608-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-19608-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-19608-70-NhwKyVDo7k@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19608

Owen Leonard <oleonard at myacpl.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
         Depends on|                            |19607, 19560


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19560
[Bug 19560] Unable to delete library when branchcode contains special
characters
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19607
[Bug 19607] Move admin templates JavaScript to the footer: Basic parameters
-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Nov 14 18:13:09 2017
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 14 Nov 2017 17:13:09 +0000
Subject: [Koha-bugs] [Bug 19560] Unable to delete library when branchcode
 contains special characters
In-Reply-To: <bug-19560-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-19560-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-19560-70-ReQI5s042S@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19560

Owen Leonard <oleonard at myacpl.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Blocks|                            |19608


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19608
[Bug 19608] Move admin templates JavaScript to the footer: The rest
-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Nov 14 18:13:09 2017
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 14 Nov 2017 17:13:09 +0000
Subject: [Koha-bugs] [Bug 19607] Move admin templates JavaScript to the
 footer: Basic parameters
In-Reply-To: <bug-19607-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-19607-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-19607-70-QWFSGtvJvE@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19607

Owen Leonard <oleonard at myacpl.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Blocks|                            |19608


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19608
[Bug 19608] Move admin templates JavaScript to the footer: The rest
-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Nov 14 18:13:44 2017
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 14 Nov 2017 17:13:44 +0000
Subject: [Koha-bugs] [Bug 19608] Move admin templates JavaScript to the
	footer: The rest
In-Reply-To: <bug-19608-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-19608-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-19608-70-EOudlLH9Sk@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19608

--- Comment #1 from Owen Leonard <oleonard at myacpl.org> ---
Created attachment 69144
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=69144&action=edit
Bug 19608 - Move admin templates JavaScript to the footer: The rest

This patch modifies the staff client administration templates so that
JavaScript is included in the footer instead of the header.

To test, apply the patch and test the JavaScript-driven features of the
modified templates: All button controls, DataTables functionality, tabs,
etc.

To test the changes to localization.tt you must have more than one
translation installed. Go to admin/itemtypes.pl, edit an itemtype, and
click the 'Translate into other languages' link.

To test the changes to sur_modmapping.tt, go to admin/z3950servers.pl
and create a new SRU server. Click the 'Modify' button next to 'SRU
Search fields mapping'

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Nov 14 18:13:42 2017
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 14 Nov 2017 17:13:42 +0000
Subject: [Koha-bugs] [Bug 19608] Move admin templates JavaScript to the
	footer: The rest
In-Reply-To: <bug-19608-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-19608-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-19608-70-zjncN0ngyj@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19608

Owen Leonard <oleonard at myacpl.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|ASSIGNED                    |Needs Signoff
   Patch complexity|---                         |Small patch

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Nov 14 19:21:34 2017
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 14 Nov 2017 18:21:34 +0000
Subject: [Koha-bugs] [Bug 19623] New: Move admin templates JavaScript to the
 footer: Cataloging
Message-ID: <bug-19623-70@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19623

            Bug ID: 19623
           Summary: Move admin templates JavaScript to the footer:
                    Cataloging
 Change sponsored?: ---
           Product: Koha
           Version: master
          Hardware: All
                OS: All
            Status: ASSIGNED
          Severity: enhancement
          Priority: P5 - low
         Component: Templates
          Assignee: oleonard at myacpl.org
          Reporter: oleonard at myacpl.org
        QA Contact: testopia at bugs.koha-community.org
                CC: jonathan.druart at bugs.koha-community.org,
                    nick at bywatersolutions.com, simon.pouchol at biblibre.com,
                    testopia at bugs.koha-community.org
        Depends on: 19608
            Blocks: 17858

In order to conform to best practices for performance staff client template
javascript should be in the footer instead of the header.

This patch will do so for some cataloging templates: addbooks.tt, linkitem.tt,
merge.tt, z3950_auth_search.tt, z3950_search.tt


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17858
[Bug 17858] Omnibus: Move staff client JavaScript to the footer
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19608
[Bug 19608] Move admin templates JavaScript to the footer: The rest
-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Nov 14 19:21:34 2017
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 14 Nov 2017 18:21:34 +0000
Subject: [Koha-bugs] [Bug 17858] Omnibus: Move staff client JavaScript to
	the footer
In-Reply-To: <bug-17858-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-17858-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-17858-70-Sxg04P00f3@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17858

Owen Leonard <oleonard at myacpl.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
         Depends on|                            |19623


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19623
[Bug 19623] Move admin templates JavaScript to the footer: Cataloging
-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Nov 14 19:21:34 2017
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 14 Nov 2017 18:21:34 +0000
Subject: [Koha-bugs] [Bug 19608] Move admin templates JavaScript to the
	footer: The rest
In-Reply-To: <bug-19608-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-19608-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-19608-70-whED878qRO@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19608

Owen Leonard <oleonard at myacpl.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Blocks|                            |19623


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19623
[Bug 19623] Move admin templates JavaScript to the footer: Cataloging
-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Nov 14 19:25:35 2017
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 14 Nov 2017 18:25:35 +0000
Subject: [Koha-bugs] [Bug 19623] Move template JavaScript to the footer:
	Cataloging
In-Reply-To: <bug-19623-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-19623-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-19623-70-UzGf5loGVS@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19623

Owen Leonard <oleonard at myacpl.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
            Summary|Move admin templates        |Move template JavaScript to
                   |JavaScript to the footer:   |the footer: Cataloging
                   |Cataloging                  |

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Nov 14 20:37:43 2017
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 14 Nov 2017 19:37:43 +0000
Subject: [Koha-bugs] [Bug 19623] Move template JavaScript to the footer:
	Cataloging
In-Reply-To: <bug-19623-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-19623-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-19623-70-AoGR9qC1iL@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19623

Owen Leonard <oleonard at myacpl.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|ASSIGNED                    |Needs Signoff
   Patch complexity|---                         |Small patch

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Nov 14 20:37:46 2017
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 14 Nov 2017 19:37:46 +0000
Subject: [Koha-bugs] [Bug 19623] Move template JavaScript to the footer:
	Cataloging
In-Reply-To: <bug-19623-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-19623-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-19623-70-DB6TnuY4W8@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19623

--- Comment #1 from Owen Leonard <oleonard at myacpl.org> ---
Created attachment 69145
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=69145&action=edit
Bug 19623 - Move template JavaScript to the footer: Cataloging

This patch modifies some staff client cataloging templates so that
JavaScript is included in the footer instead of the header.

Several cataloging templates are excluded because they require
significant structural changes: addbiblio.tt, additem.tt, and editor.tt

To test, apply the patch and test the JavaScript-driven features of the
modified templates: All button controls, DataTables functionality, tabs,
etc.

Note that z350_auth_search.tt is tested by performing a Z39.50 search
from the Authorities module.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Nov 14 22:11:49 2017
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 14 Nov 2017 21:11:49 +0000
Subject: [Koha-bugs] [Bug 19624] New: MARC Preview pop-up
Message-ID: <bug-19624-70@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19624

            Bug ID: 19624
           Summary: MARC Preview pop-up
 Change sponsored?: ---
           Product: Koha
           Version: 17.05
          Hardware: PC
                OS: Windows
            Status: NEW
          Severity: normal
          Priority: P5 - low
         Component: Cataloging
          Assignee: koha-bugs at lists.koha-community.org
          Reporter: sbush at sasaki.com
        QA Contact: testopia at bugs.koha-community.org
                CC: m.de.rooy at rijksmuseum.nl

Created attachment 69146
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=69146&action=edit
Screen capture and example file

All catalog records have a MARC preview pop-up that will not close. The pop-up
says it's loading, but it never changes. A second pane below the MARC preview
will download a file with a name like "bib-17936.dublin-core.xml" if I click
export or cancel. I can still work around the pop-up, but it's extremely
frustrating.

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Nov 14 22:56:42 2017
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 14 Nov 2017 21:56:42 +0000
Subject: [Koha-bugs] [Bug 19532] Recalls for Koha
In-Reply-To: <bug-19532-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-19532-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-19532-70-GeOOP98HMW@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19532

--- Comment #13 from Aleisha Amohia <aleisha at catalyst.net.nz> ---
Created attachment 69147
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=69147&action=edit
Bug 19532: Show recalls on intranet side

This patch
- adds Recall tab to the Check out section of member account, and to the
Details section of member account
- Functionality to cancel recalls on staff side
- Fixing cancel on OPAC side (before I was deleting the whole recall
instead of cancelling)
- Fixing validation when checking whether a recall can be placed on an
item that has been recalled by this borrower before. If the old recall
is expired or cancelled then they can make a recall again.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Nov 14 23:01:21 2017
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 14 Nov 2017 22:01:21 +0000
Subject: [Koha-bugs] [Bug 19532] Recalls for Koha
In-Reply-To: <bug-19532-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-19532-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-19532-70-QStOCSu7W2@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19532

--- Comment #14 from Aleisha Amohia <aleisha at catalyst.net.nz> ---
Created attachment 69148
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=69148&action=edit
Bug 19532: Fixing broken OPAC recalls table

Forgot to add <tr>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Nov 15 02:16:09 2017
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 15 Nov 2017 01:16:09 +0000
Subject: [Koha-bugs] [Bug 19532] Recalls for Koha
In-Reply-To: <bug-19532-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-19532-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-19532-70-CpJNttqcJ3@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19532

--- Comment #15 from Aleisha Amohia <aleisha at catalyst.net.nz> ---
Created attachment 69149
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=69149&action=edit
Bug 19532: recalls history

this patch
- adds recalls history (similar to holds history) to OPAC and intranet
- edits the tables in opac-user.pl (OPAC), moremember.pl and
circulation.pl (staff) so that it only shows active recalls (recalls
that have been requested or are waiting)
- some extra datatables fixes

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Nov 15 08:12:33 2017
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 15 Nov 2017 07:12:33 +0000
Subject: [Koha-bugs] [Bug 18979] Speed up 'valid-templates.t' tests
In-Reply-To: <bug-18979-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-18979-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-18979-70-ngAEcIQWuF@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18979

--- Comment #10 from Mason James <mtj at kohaaloha.com> ---
a little update here...
it turns out that the 'use threads' line was needed for patch to succeed, after
all

the 'use threads' line seems to handle a known bug where Test::Simple generates
the TAP tests out of order, and causes the tests to fail


the good news is that there are some options...

1/ use the Test2::Suite module, which handles parallel tests well...
   https://metacpan.org/pod/Test2::Suite

   the only catch here is that it's new-ish, so we'll need to backport the
module to deb8/jessie too

2/ just allow the 'use threads' line. 
        Because no threads are ever actually created, it should be pretty safe


fyi: i did try using forks.pm too, but sadly got lots of random fails

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Nov 15 09:03:34 2017
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 15 Nov 2017 08:03:34 +0000
Subject: [Koha-bugs] [Bug 18979] Speed up 'valid-templates.t' tests
In-Reply-To: <bug-18979-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-18979-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-18979-70-KxuFrhz8XW@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18979

--- Comment #11 from Mason James <mtj at kohaaloha.com> ---
Created attachment 69150
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=69150&action=edit
Bug 18979: Swap threads for Test2::Suite

this patch swaps threads for the Test2::Suite module

to test...

1/ apply patch

2/ install Test2::Suite
    $ sudo apt-get install libtest2-suite-perl , or...

    $ cpanm Test2::Suite

3/ run test

    $ sudo koha-shell -c  " export PERL5LIB=/home/mason/git/koha/master;  
prove -v xt/author/valid-templates.t" kmaster
    ok 1 - Testing opac bootstrap templates {
        ...
    }
    ok 2 - Testing staff prog templates {
        ...
    }
    1..2
    ok
    All tests successful.
    Result: PASS

4. note test passes
    Result: PASS

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Nov 15 10:13:11 2017
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 15 Nov 2017 09:13:11 +0000
Subject: [Koha-bugs] [Bug 10412] The ability to update Acquisitions with
 credit notes, with the option to link to an existing invoice
In-Reply-To: <bug-10412-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-10412-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-10412-70-bh8W1nTVVp@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10412

Maura Stephens <maura.stephens at gmit.ie> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |maura.stephens at gmit.ie

--- Comment #17 from Maura Stephens <maura.stephens at gmit.ie> ---
Comment on attachment 22539
  --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=22539
Bug 10412 - Adding new table aqcreditnotes.

This is critical for our library, please ensure it is implemented.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Nov 15 10:14:39 2017
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 15 Nov 2017 09:14:39 +0000
Subject: [Koha-bugs] [Bug 10412] The ability to update Acquisitions with
 credit notes, with the option to link to an existing invoice
In-Reply-To: <bug-10412-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-10412-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-10412-70-GhNrJ9NCD3@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10412

--- Comment #18 from Maura Stephens <maura.stephens at gmit.ie> ---
Comment on attachment 22538
  --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=22538
Bug 10412 - The ability to update Acquisitions with

Please ensure this enhancement is implemented in the next version of Koha

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Nov 15 10:55:07 2017
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 15 Nov 2017 09:55:07 +0000
Subject: [Koha-bugs] [Bug 19591] Saving a system preference jumps to main
	page
In-Reply-To: <bug-19591-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-19591-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-19591-70-Re5JNkIkpi@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19591

--- Comment #7 from Christian Stelzenm?ller <christian.stelzenmueller at bsz-bw.de> ---
Now we found the exact cause:

The language in the html from the system preference page ist missing:

<html lang="">

Therefore the js regarding the language caused this error.

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.

From bugzilla-daemon at bugs.koha-community.org  Wed Nov 15 11:47:56 2017
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 15 Nov 2017 10:47:56 +0000
Subject: [Koha-bugs] [Bug 19625] New: Shibboleth auto-provisioning is broken
	in plack
Message-ID: <bug-19625-70@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19625

            Bug ID: 19625
           Summary: Shibboleth auto-provisioning is broken in plack
 Change sponsored?: ---
           Product: Koha
           Version: master
          Hardware: All
                OS: All
            Status: NEW
          Severity: enhancement
          Priority: P5 - low
         Component: Authentication
          Assignee: koha-bugs at lists.koha-community.org
          Reporter: matthias.meusburger at biblibre.com
        QA Contact: testopia at bugs.koha-community.org
                CC: dpavlin at rot13.org

Like shibboleth authentication, shibboleth auto-provisioning is broken in
plack.

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Nov 15 11:47:56 2017
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 15 Nov 2017 10:47:56 +0000
Subject: [Koha-bugs] [Bug 17776] Shibboleth Authentication is broken in plack
In-Reply-To: <bug-17776-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-17776-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-17776-70-soQp6wEBhc@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17776

Matthias Meusburger <matthias.meusburger at biblibre.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
           See Also|                            |https://bugs.koha-community
                   |                            |.org/bugzilla3/show_bug.cgi
                   |                            |?id=19625

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Nov 15 11:47:56 2017
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 15 Nov 2017 10:47:56 +0000
Subject: [Koha-bugs] [Bug 12026] Shibboleth auto-provisioning - Create
In-Reply-To: <bug-12026-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-12026-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-12026-70-WtQ7ftcNpj@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12026

Matthias Meusburger <matthias.meusburger at biblibre.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
           See Also|                            |https://bugs.koha-community
                   |                            |.org/bugzilla3/show_bug.cgi
                   |                            |?id=19625

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Nov 15 11:51:44 2017
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 15 Nov 2017 10:51:44 +0000
Subject: [Koha-bugs] [Bug 19625] Shibboleth auto-provisioning is broken in
	plack
In-Reply-To: <bug-19625-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-19625-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-19625-70-qnBan0xY09@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19625

--- Comment #1 from Matthias Meusburger <matthias.meusburger at biblibre.com> ---
Created attachment 69151
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=69151&action=edit
Enable Shibboleth auto-provisioning for Plack

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.

From bugzilla-daemon at bugs.koha-community.org  Wed Nov 15 11:52:24 2017
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 15 Nov 2017 10:52:24 +0000
Subject: [Koha-bugs] [Bug 19625] Shibboleth auto-provisioning is broken in
	plack
In-Reply-To: <bug-19625-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-19625-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-19625-70-y3715tROA9@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19625

Matthias Meusburger <matthias.meusburger at biblibre.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|NEW                         |Needs Signoff

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Nov 15 13:07:02 2017
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 15 Nov 2017 12:07:02 +0000
Subject: [Koha-bugs] [Bug 18979] Speed up 'valid-templates.t' tests
In-Reply-To: <bug-18979-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-18979-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-18979-70-ChhL3oGeCg@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18979

--- Comment #12 from Marcel de Rooy <m.de.rooy at rijksmuseum.nl> ---
(In reply to Mason James from comment #10)
> a little update here...
> it turns out that the 'use threads' line was needed for patch to succeed,
> after all
> 
> the 'use threads' line seems to handle a known bug where Test::Simple
> generates the TAP tests out of order, and causes the tests to fail
> 
> 
> the good news is that there are some options...
> 
> 1/ use the Test2::Suite module, which handles parallel tests well...
>    https://metacpan.org/pod/Test2::Suite
> 
>    the only catch here is that it's new-ish, so we'll need to backport the
> module to deb8/jessie too
> 
> 2/ just allow the 'use threads' line. 
> 	Because no threads are ever actually created, it should be pretty safe
>    
> 
> fyi: i did try using forks.pm too, but sadly got lots of random fails

Mason,
Which option has your preference ?

Marcel

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Nov 15 13:42:57 2017
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 15 Nov 2017 12:42:57 +0000
Subject: [Koha-bugs] [Bug 19624] MARC Preview pop-up
In-Reply-To: <bug-19624-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-19624-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-19624-70-RFDlOwmLnF@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19624

--- Comment #1 from Owen Leonard <oleonard at myacpl.org> ---
This sounds like something which frequently happens right after an upgrade,
when the browser cache needs to be cleared. Have you tried that?

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.

From bugzilla-daemon at bugs.koha-community.org  Wed Nov 15 13:57:03 2017
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 15 Nov 2017 12:57:03 +0000
Subject: [Koha-bugs] [Bug 19626] Database update for bug 12063 incorrectly
 calculates expirationdate for holds
In-Reply-To: <bug-19626-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-19626-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-19626-70-mr6FBh8IXH@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19626

Nick Clemens <nick at bywatersolutions.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
         Depends on|                            |12063


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12063
[Bug 12063] Change date calculation for reserve expiration to skip all holidays
-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.

From bugzilla-daemon at bugs.koha-community.org  Wed Nov 15 13:57:03 2017
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 15 Nov 2017 12:57:03 +0000
Subject: [Koha-bugs] [Bug 12063] Change date calculation for reserve
 expiration to skip all holidays
In-Reply-To: <bug-12063-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-12063-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-12063-70-kDlECHNZRv@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12063

Nick Clemens <nick at bywatersolutions.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Blocks|                            |19626


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19626
[Bug 19626] Database update for bug 12063 incorrectly calculates expirationdate
for holds
-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Nov 15 13:56:58 2017
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 15 Nov 2017 12:56:58 +0000
Subject: [Koha-bugs] [Bug 19626] New: Database update for bug 12063
 incorrectly calculates expirationdate for holds
Message-ID: <bug-19626-70@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19626

            Bug ID: 19626
           Summary: Database update for bug 12063 incorrectly calculates
                    expirationdate for holds
 Change sponsored?: ---
           Product: Koha
           Version: master
          Hardware: All
                OS: All
            Status: NEW
          Severity: major
          Priority: P5 - low
         Component: Hold requests
          Assignee: koha-bugs at lists.koha-community.org
          Reporter: nick at bywatersolutions.com
        QA Contact: testopia at bugs.koha-community.org
                CC: gmcharlt at gmail.com

Logic in short seems to be:
1 - Does hold already have an expirationdate?
    a- Keep it if before calculated expirationdate
2 - If not 1 then calculate expiration as curdate + delay (+ holidays if pref)

The problem is, before 12063 waiting holds didn't have an expirationdate, so a
hold that has been waiting for 2 months will now get a waiting date after the
upgrade.

I think line 14374 should be:
my $expirationdate = dt_from_string($hold->waitingdate);

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Nov 15 14:14:09 2017
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 15 Nov 2017 13:14:09 +0000
Subject: [Koha-bugs] [Bug 19626] Database update for bug 12063 incorrectly
 calculates expirationdate for holds
In-Reply-To: <bug-19626-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-19626-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-19626-70-iWbCnJQnpY@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19626

--- Comment #1 from Nick Clemens <nick at bywatersolutions.com> ---
Created attachment 69152
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=69152&action=edit
Bug 19626 - Calculate expiration date for existing holds based on waitingdate

To test:
1 - Have/create a 16.11 instance with some waiting holds
2 - Those holds should not have an expirationdate
3 - Make sure some of the holds are waiting longer than
ReservesMaxPickupDelay
BACKUP THE DB
4 - Upgrade to 17.05 (or later)
5 - Check the expirationdate for the holds
6 - The date wil be in the future (curdate + delay)
7 - Restore DB
8 - Apply patch
9 - Run the upgrade again
10 - expirationdate should now be based on waitingdate

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.

From bugzilla-daemon at bugs.koha-community.org  Wed Nov 15 14:14:23 2017
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 15 Nov 2017 13:14:23 +0000
Subject: [Koha-bugs] [Bug 19626] Database update for bug 12063 incorrectly
 calculates expirationdate for holds
In-Reply-To: <bug-19626-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-19626-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-19626-70-9kds36rGKT@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19626

Nick Clemens <nick at bywatersolutions.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
           Assignee|koha-bugs at lists.koha-commun |nick at bywatersolutions.com
                   |ity.org                     |

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.

From bugzilla-daemon at bugs.koha-community.org  Wed Nov 15 14:14:07 2017
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 15 Nov 2017 13:14:07 +0000
Subject: [Koha-bugs] [Bug 19626] Database update for bug 12063 incorrectly
 calculates expirationdate for holds
In-Reply-To: <bug-19626-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-19626-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-19626-70-3p4tUOUH3t@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19626

Nick Clemens <nick at bywatersolutions.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|NEW                         |Needs Signoff
   Patch complexity|---                         |Trivial patch

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Nov 15 14:39:52 2017
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 15 Nov 2017 13:39:52 +0000
Subject: [Koha-bugs] [Bug 19624] MARC Preview pop-up
In-Reply-To: <bug-19624-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-19624-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-19624-70-M8VxsQjl2D@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19624

--- Comment #2 from sbush at sasaki.com ---
Such a simple fix! Thanks so so much!

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Nov 15 14:40:32 2017
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 15 Nov 2017 13:40:32 +0000
Subject: [Koha-bugs] [Bug 19624] MARC Preview pop-up
In-Reply-To: <bug-19624-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-19624-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-19624-70-Et32VA5SeP@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19624

sbush at sasaki.com changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|NEW                         |RESOLVED
         Resolution|---                         |WORKSFORME

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Nov 15 14:43:52 2017
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 15 Nov 2017 13:43:52 +0000
Subject: [Koha-bugs] [Bug 19575] Use canonical field names and resolve
	aliased fields
In-Reply-To: <bug-19575-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-19575-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-19575-70-LAK07ui1CO@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19575

David Gustafsson <glasklas at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #69140|0                           |1
        is obsolete|                            |

--- Comment #5 from David Gustafsson <glasklas at gmail.com> ---
Created attachment 69153
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=69153&action=edit
Bug 19575: Use canonical field names and resolve aliased fields

Adjust elastic search mappings to more closely match Zebra equivalents
resolving serveral issues with coded Zebra searches in templates, and
sorting of search results in UI.

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.

From bugzilla-daemon at bugs.koha-community.org  Wed Nov 15 14:45:15 2017
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 15 Nov 2017 13:45:15 +0000
Subject: [Koha-bugs] [Bug 19575] Use canonical field names and resolve
	aliased fields
In-Reply-To: <bug-19575-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-19575-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-19575-70-K3H5qxHx4l@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19575

--- Comment #6 from David Gustafsson <glasklas at gmail.com> ---
Now most (hopefully all) issues (primarily with facets) should be sorted out.

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.

From bugzilla-daemon at bugs.koha-community.org  Wed Nov 15 14:47:05 2017
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 15 Nov 2017 13:47:05 +0000
Subject: [Koha-bugs] [Bug 19585] Inventory: Allow additional separators in a
	barcode file
In-Reply-To: <bug-19585-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-19585-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-19585-70-wVzAIN9Fce@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19585

Marcel de Rooy <m.de.rooy at rijksmuseum.nl> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #69118|0                           |1
        is obsolete|                            |

--- Comment #4 from Marcel de Rooy <m.de.rooy at rijksmuseum.nl> ---
Created attachment 69154
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=69154&action=edit
Bug 19585: Inventory: Allow additional separators in a barcode file

This patch makes \n, \r, |, comma, semicolon and hyphen ('-') all valid
separators between barcodes passed to inventory.
An additional grep removes empty barcodes. (Note: The grep looks for at
least one non-whitespace character. We could be more specific, but this
allows for more flexibility like testing with alphanumeric barcodes etc.)

Test plan:
Upload a barcode file that contains various allowed separators.

Signed-off-by: Marcel de Rooy <m.de.rooy at rijksmuseum.nl>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Nov 15 14:49:21 2017
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 15 Nov 2017 13:49:21 +0000
Subject: [Koha-bugs] [Bug 19585] Inventory: Allow additional separators in a
	barcode file
In-Reply-To: <bug-19585-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-19585-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-19585-70-gT3TWHtNFc@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19585

--- Comment #5 from Marcel de Rooy <m.de.rooy at rijksmuseum.nl> ---
Decided to add the hyphen ('-') too as a separator. We need him also.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Nov 15 15:09:54 2017
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 15 Nov 2017 14:09:54 +0000
Subject: [Koha-bugs] [Bug 19627] New: Move template patron clubs templates
 JS to the footer
Message-ID: <bug-19627-70@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19627

            Bug ID: 19627
           Summary: Move template patron clubs templates JS to the footer
 Change sponsored?: ---
           Product: Koha
           Version: master
          Hardware: All
                OS: All
            Status: ASSIGNED
          Severity: enhancement
          Priority: P5 - low
         Component: Templates
          Assignee: oleonard at myacpl.org
          Reporter: oleonard at myacpl.org
        QA Contact: testopia at bugs.koha-community.org
                CC: jonathan.druart at bugs.koha-community.org,
                    nick at bywatersolutions.com, simon.pouchol at biblibre.com,
                    testopia at bugs.koha-community.org
            Blocks: 17858

In order to conform to best practices for performance, staff client template
JavaScript should be in the footer instead of the header.

This patch will do so for the patron clubs templates.


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17858
[Bug 17858] Omnibus: Move staff client JavaScript to the footer
-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Nov 15 15:09:54 2017
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 15 Nov 2017 14:09:54 +0000
Subject: [Koha-bugs] [Bug 17858] Omnibus: Move staff client JavaScript to
	the footer
In-Reply-To: <bug-17858-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-17858-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-17858-70-3AEvE3F9kc@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17858

Owen Leonard <oleonard at myacpl.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
         Depends on|                            |19627


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19627
[Bug 19627] Move template patron clubs templates JS to the footer
-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Nov 15 15:12:30 2017
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 15 Nov 2017 14:12:30 +0000
Subject: [Koha-bugs] [Bug 18786] Add ability to create custom payment types
In-Reply-To: <bug-18786-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-18786-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-18786-70-7j9VQRfiwn@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18786

Kyle M Hall <kyle at bywatersolutions.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #67477|0                           |1
        is obsolete|                            |

--- Comment #14 from Kyle M Hall <kyle at bywatersolutions.com> ---
Created attachment 69155
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=69155&action=edit
Bug 18786 - Add ability to create custom payment types

Some libraries would like to be able to specify more specific payment types
such as cash, check, credit card, or even canned food ( for food drives ). This
feature will allow a library to specify payment types as authorised values of
the type PAYMENT_TYPE.

Test Plan:
1) Apply patches
2) Update database
3) Add authorised value PAYMENT_TYPE with values 'Cash', 'Check', 'Credit card'
4) Go to the fines section of a patron who has several fines
5) Tab 'Fines'
6) Click on 'Pay' for an individual fine
7) Verify that in the form a 'Pay an individual fine' dropdown appears with
payment types
8) Select a payment type, confirm payment
9) Verify that payment type appears in "Description of charges" in tab
'Account'

Signed-off-by: Marc V?ron <veron at veron.ch>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Nov 15 15:12:55 2017
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 15 Nov 2017 14:12:55 +0000
Subject: [Koha-bugs] [Bug 18786] Add ability to create custom payment types
In-Reply-To: <bug-18786-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-18786-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-18786-70-xKlMUnXfAX@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18786

Kyle M Hall <kyle at bywatersolutions.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #67476|0                           |1
        is obsolete|                            |
  Attachment #69155|0                           |1
        is obsolete|                            |

--- Comment #15 from Kyle M Hall <kyle at bywatersolutions.com> ---
Created attachment 69156
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=69156&action=edit
Bug 18786 - Update database

Signed-off-by: Marc V?ron <veron at veron.ch>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Nov 15 15:13:06 2017
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 15 Nov 2017 14:13:06 +0000
Subject: [Koha-bugs] [Bug 18786] Add ability to create custom payment types
In-Reply-To: <bug-18786-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-18786-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-18786-70-G5V9VRHLFz@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18786

--- Comment #16 from Kyle M Hall <kyle at bywatersolutions.com> ---
Created attachment 69157
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=69157&action=edit
Bug 18786 - Add ability to create custom payment types

Some libraries would like to be able to specify more specific payment types
such as cash, check, credit card, or even canned food ( for food drives ). This
feature will allow a library to specify payment types as authorised values of
the type PAYMENT_TYPE.

Test Plan:
1) Apply patches
2) Update database
3) Add authorised value PAYMENT_TYPE with values 'Cash', 'Check', 'Credit card'
4) Go to the fines section of a patron who has several fines
5) Tab 'Fines'
6) Click on 'Pay' for an individual fine
7) Verify that in the form a 'Pay an individual fine' dropdown appears with
payment types
8) Select a payment type, confirm payment
9) Verify that payment type appears in "Description of charges" in tab
'Account'

Signed-off-by: Marc V?ron <veron at veron.ch>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Nov 15 15:16:21 2017
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 15 Nov 2017 14:16:21 +0000
Subject: [Koha-bugs] [Bug 18790] Add ability to void payments
In-Reply-To: <bug-18790-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-18790-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-18790-70-7SQ0qmSWAC@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18790

Kyle M Hall <kyle at bywatersolutions.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #67478|0                           |1
        is obsolete|                            |

--- Comment #9 from Kyle M Hall <kyle at bywatersolutions.com> ---
Created attachment 69158
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=69158&action=edit
Bug 18790 - Add ability to void payments

We've had the ability to 'reverse' a payment for a long time, but it
would be much better if we had a true void payment function that
replaces the paid amounts into the fee so that it appears as if the
payment was never made.

Test Plan:
1) Apply this patch and dependent patches
2) Run updatedatabase.pl
3) Create some fines
4) Pay those fines
5) Use the new 'void' button to void the payments
6) Note the fines were restored to their pre-payment amounts

Signed-off-by: Koha-us conference <koha-us at koha-us.net>
Signed-off-by: BWS Sandboxes <ByWaterSandboxes at gmail.com>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Nov 15 15:16:31 2017
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 15 Nov 2017 14:16:31 +0000
Subject: [Koha-bugs] [Bug 19627] Move patron clubs templates JS to the footer
In-Reply-To: <bug-19627-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-19627-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-19627-70-5RqBq9hPOv@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19627

Owen Leonard <oleonard at myacpl.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
            Summary|Move template patron clubs  |Move patron clubs templates
                   |templates JS to the footer  |JS to the footer

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Nov 15 15:16:30 2017
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 15 Nov 2017 14:16:30 +0000
Subject: [Koha-bugs] [Bug 18790] Add ability to void payments
In-Reply-To: <bug-18790-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-18790-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-18790-70-0XR2LkOmmc@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18790

--- Comment #10 from Kyle M Hall <kyle at bywatersolutions.com> ---
Created attachment 69159
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=69159&action=edit
Bug 18790 [QA Followup] - Store the new offset for the void

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Nov 15 15:22:30 2017
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 15 Nov 2017 14:22:30 +0000
Subject: [Koha-bugs] [Bug 19627] Move patron clubs templates JS to the footer
In-Reply-To: <bug-19627-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-19627-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-19627-70-Ihyf0q2oGo@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19627

Owen Leonard <oleonard at myacpl.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
   Patch complexity|---                         |Small patch
             Status|ASSIGNED                    |Needs Signoff

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Nov 15 15:22:32 2017
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 15 Nov 2017 14:22:32 +0000
Subject: [Koha-bugs] [Bug 19627] Move patron clubs templates JS to the footer
In-Reply-To: <bug-19627-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-19627-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-19627-70-SRedSiPRHt@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19627

--- Comment #1 from Owen Leonard <oleonard at myacpl.org> ---
Created attachment 69160
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=69160&action=edit
Bug 19627: Move patron clubs templates JS to the footer

This patch modifies the staff client's patron clubs templates so that
JavaScript is included in the footer instead of the header.

To test, apply the patch and test the JavaScript-driven features of
each page: All button controls, DataTables functionality, tabs, etc.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Nov 15 15:27:00 2017
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 15 Nov 2017 14:27:00 +0000
Subject: [Koha-bugs] [Bug 18790] Add ability to void payments
In-Reply-To: <bug-18790-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-18790-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-18790-70-geB1iEXkiO@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18790

Kyle M Hall <kyle at bywatersolutions.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #69158|0                           |1
        is obsolete|                            |
  Attachment #69159|0                           |1
        is obsolete|                            |

--- Comment #11 from Kyle M Hall <kyle at bywatersolutions.com> ---
Created attachment 69161
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=69161&action=edit
Bug 18790 - Add ability to void payments

We've had the ability to 'reverse' a payment for a long time, but it
would be much better if we had a true void payment function that
replaces the paid amounts into the fee so that it appears as if the
payment was never made.

Test Plan:
1) Apply this patch and dependent patches
2) Run updatedatabase.pl
3) Create some fines
4) Pay those fines
5) Use the new 'void' button to void the payments
6) Note the fines were restored to their pre-payment amounts

Signed-off-by: Koha-us conference <koha-us at koha-us.net>
Signed-off-by: BWS Sandboxes <ByWaterSandboxes at gmail.com>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Nov 15 15:35:44 2017
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 15 Nov 2017 14:35:44 +0000
Subject: [Koha-bugs] [Bug 19627] Move patron clubs templates JS to the footer
In-Reply-To: <bug-19627-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-19627-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-19627-70-i5zsM15RHc@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19627

Simon Pouchol <simon.pouchol at biblibre.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #69160|0                           |1
        is obsolete|                            |

--- Comment #2 from Simon Pouchol <simon.pouchol at biblibre.com> ---
Created attachment 69162
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=69162&action=edit
Bug 19627: Move patron clubs templates JS to the footer

This patch modifies the staff client's patron clubs templates so that
JavaScript is included in the footer instead of the header.

To test, apply the patch and test the JavaScript-driven features of
each page: All button controls, DataTables functionality, tabs, etc.

Signed-off-by: Simon Pouchol <simon.pouchol at biblibre.com>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Nov 15 15:36:10 2017
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 15 Nov 2017 14:36:10 +0000
Subject: [Koha-bugs] [Bug 19627] Move patron clubs templates JS to the footer
In-Reply-To: <bug-19627-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-19627-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-19627-70-3P2OiRIvzm@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19627

Simon Pouchol <simon.pouchol at biblibre.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Needs Signoff               |Signed Off

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Nov 15 16:27:44 2017
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 15 Nov 2017 15:27:44 +0000
Subject: [Koha-bugs] [Bug 19623] Move template JavaScript to the footer:
	Cataloging
In-Reply-To: <bug-19623-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-19623-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-19623-70-wwVRVHXJYO@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19623

Claire Gravely <claire_gravely at hotmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Needs Signoff               |Signed Off

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Nov 15 16:27:47 2017
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 15 Nov 2017 15:27:47 +0000
Subject: [Koha-bugs] [Bug 19623] Move template JavaScript to the footer:
	Cataloging
In-Reply-To: <bug-19623-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-19623-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-19623-70-vzByS7MhLO@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19623

Claire Gravely <claire_gravely at hotmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #69145|0                           |1
        is obsolete|                            |

--- Comment #2 from Claire Gravely <claire_gravely at hotmail.com> ---
Created attachment 69163
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=69163&action=edit
Bug 19623 - Move template JavaScript to the footer: Cataloging

This patch modifies some staff client cataloging templates so that
JavaScript is included in the footer instead of the header.

Several cataloging templates are excluded because they require
significant structural changes: addbiblio.tt, additem.tt, and editor.tt

To test, apply the patch and test the JavaScript-driven features of the
modified templates: All button controls, DataTables functionality, tabs,
etc.

Note that z350_auth_search.tt is tested by performing a Z39.50 search
from the Authorities module.

Signed-off-by: Claire Gravely <claire.gravely at bsz-bw.de>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Nov 15 16:58:35 2017
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 15 Nov 2017 15:58:35 +0000
Subject: [Koha-bugs] [Bug 19626] Database update for bug 12063 incorrectly
 calculates expirationdate for holds
In-Reply-To: <bug-19626-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-19626-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-19626-70-2F4J5fDJLT@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19626

Marcel de Rooy <m.de.rooy at rijksmuseum.nl> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |m.de.rooy at rijksmuseum.nl

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Nov 15 17:03:43 2017
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 15 Nov 2017 16:03:43 +0000
Subject: [Koha-bugs] [Bug 17858] Omnibus: Move staff client JavaScript to
	the footer
In-Reply-To: <bug-17858-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-17858-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-17858-70-k9A6Ik1Hm3@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17858

Owen Leonard <oleonard at myacpl.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
         Depends on|                            |19628


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19628
[Bug 19628] Move course reserves templates JS to the footer
-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Nov 15 17:03:43 2017
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 15 Nov 2017 16:03:43 +0000
Subject: [Koha-bugs] [Bug 19628] New: Move course reserves templates JS to
	the footer
Message-ID: <bug-19628-70@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19628

            Bug ID: 19628
           Summary: Move course reserves templates JS to the footer
 Change sponsored?: ---
           Product: Koha
           Version: master
          Hardware: All
                OS: All
            Status: ASSIGNED
          Severity: enhancement
          Priority: P5 - low
         Component: Templates
          Assignee: oleonard at myacpl.org
          Reporter: oleonard at myacpl.org
        QA Contact: testopia at bugs.koha-community.org
                CC: testopia at bugs.koha-community.org
            Blocks: 17858

In order to conform to best practices for performance, staff client template
JavaScript should be in the footer instead of the header.

This patch will do so for the course reserves templates.


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17858
[Bug 17858] Omnibus: Move staff client JavaScript to the footer
-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Nov 15 17:04:31 2017
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 15 Nov 2017 16:04:31 +0000
Subject: [Koha-bugs] [Bug 19626] Database update for bug 12063 incorrectly
 calculates expirationdate for holds
In-Reply-To: <bug-19626-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-19626-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-19626-70-3eJV4hsX1a@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19626

Marcel de Rooy <m.de.rooy at rijksmuseum.nl> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Needs Signoff               |Failed QA

--- Comment #2 from Marcel de Rooy <m.de.rooy at rijksmuseum.nl> ---
You dont catch:

        if ( C4::Context->preference("ExcludeHolidaysFromMaxPickUpDelay") ) {
            $expirationdate = $calendar->days_forward( dt_from_string(),
$max_pickup_delay );
        }

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Nov 15 17:10:54 2017
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 15 Nov 2017 16:10:54 +0000
Subject: [Koha-bugs] [Bug 19628] Move course reserves templates JS to the
	footer
In-Reply-To: <bug-19628-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-19628-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-19628-70-uAVV2ilfP0@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19628

Owen Leonard <oleonard at myacpl.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
   Patch complexity|---                         |Small patch
             Status|ASSIGNED                    |Needs Signoff

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Nov 15 17:10:56 2017
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 15 Nov 2017 16:10:56 +0000
Subject: [Koha-bugs] [Bug 19628] Move course reserves templates JS to the
	footer
In-Reply-To: <bug-19628-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-19628-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-19628-70-P1tv3vsRqL@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19628

--- Comment #1 from Owen Leonard <oleonard at myacpl.org> ---
Created attachment 69164
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=69164&action=edit
Bug 19628: Move course reserves templates JS to the footer

This patch modifies the staff client course reserves templates so that
JavaScript is included in the footer instead of the header.

To test, apply the patch and test the JavaScript-driven features of
each page: All button controls, DataTables, autocomplete, etc.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Nov 15 17:29:57 2017
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 15 Nov 2017 16:29:57 +0000
Subject: [Koha-bugs] [Bug 19629] New: No translatable notification in
	overdue notices
Message-ID: <bug-19629-70@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19629

            Bug ID: 19629
           Summary: No translatable notification in overdue notices
 Change sponsored?: ---
           Product: Koha
           Version: master
          Hardware: All
                OS: All
            Status: NEW
          Severity: normal
          Priority: P5 - low
         Component: Tools
          Assignee: koha-bugs at lists.koha-community.org
          Reporter: sophie.meynieux at biblibre.com
        QA Contact: testopia at bugs.koha-community.org

If  PrintNoticesMaxLines is set and the number of overdue items is greater than
this limit, then the phrase "List too long for form; please check your account
online for a complete list of your overdue items." is added at the end of the
letter.

But this is not translatable, and not necessarily at the right place.

Maybe it could be possible to use a placeholder (like <<items.content>>) to
tell where to add this notification, and then make it translatable.

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Nov 15 17:43:46 2017
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 15 Nov 2017 16:43:46 +0000
Subject: [Koha-bugs] [Bug 19481] Elasticsearch - Set default fields for
 sorting in mappings.yaml
In-Reply-To: <bug-19481-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-19481-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-19481-70-iWXOT4PXLY@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19481

S?verine Queune <severine.queune at bulac.fr> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |severine.queune at bulac.fr

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Nov 15 17:43:58 2017
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 15 Nov 2017 16:43:58 +0000
Subject: [Koha-bugs] [Bug 18827] Elasticsearch mappings - not displayed or
 retrieved in saved order
In-Reply-To: <bug-18827-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-18827-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-18827-70-HBlQcd6hqe@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18827

S?verine Queune <severine.queune at bulac.fr> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |severine.queune at bulac.fr

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Nov 15 17:44:56 2017
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 15 Nov 2017 16:44:56 +0000
Subject: [Koha-bugs] [Bug 19581] Elasticsearch - Catmandu split option adds
 extra null fields to indexes
In-Reply-To: <bug-19581-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-19581-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-19581-70-2RPSYkmtom@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19581

S?verine Queune <severine.queune at bulac.fr> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |severine.queune at bulac.fr

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Nov 15 17:45:21 2017
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 15 Nov 2017 16:45:21 +0000
Subject: [Koha-bugs] [Bug 19580] Elasticsearch: QueryAutoTruncate exclude
 period as splitting character in autotruncation
In-Reply-To: <bug-19580-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-19580-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-19580-70-igBEK9lmwW@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19580

S?verine Queune <severine.queune at bulac.fr> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |severine.queune at bulac.fr

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Nov 15 17:49:35 2017
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 15 Nov 2017 16:49:35 +0000
Subject: [Koha-bugs] [Bug 13414] Enable right truncation with search by
	relevance
In-Reply-To: <bug-13414-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-13414-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-13414-70-qaLVrADFB7@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13414

S?verine Queune <severine.queune at bulac.fr> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |severine.queune at bulac.fr

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Nov 15 17:50:17 2017
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 15 Nov 2017 16:50:17 +0000
Subject: [Koha-bugs] [Bug 18319] Elasticsearch Advanced search breadcrumbs
	broken
In-Reply-To: <bug-18319-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-18319-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-18319-70-rbECXywPWm@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18319

S?verine Queune <severine.queune at bulac.fr> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |severine.queune at bulac.fr

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Nov 15 17:51:12 2017
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 15 Nov 2017 16:51:12 +0000
Subject: [Koha-bugs] [Bug 19502] Elasticsearch - result sets limited to 10000
In-Reply-To: <bug-19502-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-19502-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-19502-70-QljRrwzm0X@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19502

S?verine Queune <severine.queune at bulac.fr> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |severine.queune at bulac.fr

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Nov 15 17:51:37 2017
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 15 Nov 2017 16:51:37 +0000
Subject: [Koha-bugs] [Bug 18825] Elasticsearch - Update default authority
	mappings
In-Reply-To: <bug-18825-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-18825-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-18825-70-peGiQR5umc@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18825

S?verine Queune <severine.queune at bulac.fr> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |severine.queune at bulac.fr

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Nov 15 17:51:52 2017
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 15 Nov 2017 16:51:52 +0000
Subject: [Koha-bugs] [Bug 17500] Use Elasticsearch to search for patrons
In-Reply-To: <bug-17500-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-17500-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-17500-70-qBo6wwwDPk@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17500

S?verine Queune <severine.queune at bulac.fr> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |severine.queune at bulac.fr

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Nov 15 17:56:26 2017
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 15 Nov 2017 16:56:26 +0000
Subject: [Koha-bugs] [Bug 17382] Elasticsearch - provide a method to
 identify records not indexed
In-Reply-To: <bug-17382-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-17382-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-17382-70-QM9tuur7i9@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17382

S?verine Queune <severine.queune at bulac.fr> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |severine.queune at bulac.fr

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Nov 15 18:46:49 2017
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 15 Nov 2017 17:46:49 +0000
Subject: [Koha-bugs] [Bug 15492] Self-Check module stand alone check-in
In-Reply-To: <bug-15492-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-15492-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-15492-70-qhWaQ0349l@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15492

Tom?s Cohen Arazi <tomascohen at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Change sponsored?|Seeking cosponsors          |Sponsored
           Assignee|koha-bugs at lists.koha-commun |tomascohen at gmail.com
                   |ity.org                     |
                 CC|                            |oleonard at myacpl.org,
                   |                            |tomascohen at gmail.com

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.

From bugzilla-daemon at bugs.koha-community.org  Wed Nov 15 18:46:55 2017
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 15 Nov 2017 17:46:55 +0000
Subject: [Koha-bugs] [Bug 15492] Self-Check module stand alone check-in
In-Reply-To: <bug-15492-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-15492-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-15492-70-DWlZq4L1Hc@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15492

Tom?s Cohen Arazi <tomascohen at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
           Severity|enhancement                 |new feature

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Nov 15 18:47:30 2017
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 15 Nov 2017 17:47:30 +0000
Subject: [Koha-bugs] [Bug 15492] Self-Check module stand alone check-in
In-Reply-To: <bug-15492-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-15492-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-15492-70-zxtPX42LKq@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15492

--- Comment #3 from Tom?s Cohen Arazi <tomascohen at gmail.com> ---
Created attachment 69166
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=69166&action=edit
Bug 15492: Add SCI module

This patch adds the SCI module, and adapts C4::Auth to know about it.

The current behaviour is:
- Requires admin user initialization/login
- Uses the logged users' library
- A form allows to scan multiple barcodes
- A button sends the barcode list to the controller
  to batch perform the checkins
- Successful and failed checkins are sent to the template
- Results are displayed
- Logout link

To test:
- Apply this patches
- Make sure you upgrade:
  $ kshell
 k$ perl installer/data/mysql/updatedatabase.pl
- Have 'SelfCheckInModule' disabled
- Go to http://kohadev.myDNSname.org:8080/cgi-bin/koha/sci/sci-main.pl [1]
=> SUCCESS: You are rejected because the feature is disabled
- Enable 'SelfCheckInModule'
- Go to the previous URL
=> SUCCESS: You are required to login
- Login with a user WITHOUT self_checkout permissions
=> SUCCESS: You are not allowed to log into the Self check-in module.
- Login with a user WITH self_checkour permissions
=> SUCCESS: You gain access, and are presented the UI
- Go through the several options
=> SUCCESS: All works as it should
- Sign off :-D

- Bonus points:
  $ kshell
 k$ qa -c 2 -v 2
=> SUCCESS: All tests green

[1] Adjust to your dev's OPAC setup

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Nov 15 18:47:23 2017
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 15 Nov 2017 17:47:23 +0000
Subject: [Koha-bugs] [Bug 15492] Self-Check module stand alone check-in
In-Reply-To: <bug-15492-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-15492-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-15492-70-QBhYlKdzPA@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15492

--- Comment #2 from Tom?s Cohen Arazi <tomascohen at gmail.com> ---
Created attachment 69165
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=69165&action=edit
Bug 15492: Add the SelfCheckInModule syspref

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Nov 15 18:47:53 2017
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 15 Nov 2017 17:47:53 +0000
Subject: [Koha-bugs] [Bug 15492] Self-Check module stand alone check-in
In-Reply-To: <bug-15492-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-15492-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-15492-70-qn0XF3noNu@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15492

Tom?s Cohen Arazi <tomascohen at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|NEW                         |Needs Signoff

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Nov 15 19:54:55 2017
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 15 Nov 2017 18:54:55 +0000
Subject: [Koha-bugs] [Bug 15492] Self-Check module stand alone check-in
In-Reply-To: <bug-15492-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-15492-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-15492-70-VJTjobCHuH@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15492

--- Comment #4 from Owen Leonard <oleonard at myacpl.org> ---
This is missing from sci-main.tt:

<script type="text/javascript">
    function _(s) { return s } // dummy function for gettext
</script>

(see sco-main.tt for comparison)

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Nov 15 20:39:34 2017
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 15 Nov 2017 19:39:34 +0000
Subject: [Koha-bugs] [Bug 15492] Self-Check module stand alone check-in
In-Reply-To: <bug-15492-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-15492-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-15492-70-YAhj1kFYCO@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15492

Tom?s Cohen Arazi <tomascohen at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #69166|0                           |1
        is obsolete|                            |

--- Comment #5 from Tom?s Cohen Arazi <tomascohen at gmail.com> ---
Created attachment 69167
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=69167&action=edit
Bug 15492: Add SCI module

This patch adds the SCI module, and adapts C4::Auth to know about it.

The current behaviour is:
- Requires admin user initialization/login
- Uses the logged users' library
- A form allows to scan multiple barcodes
- A button sends the barcode list to the controller
  to batch perform the checkins
- Successful and failed checkins are sent to the template
- Results are displayed
- Logout link

To test:
- Apply this patches
- Make sure you upgrade:
  $ kshell
 k$ perl installer/data/mysql/updatedatabase.pl
- Have 'SelfCheckInModule' disabled
- Go to http://kohadev.myDNSname.org:8080/cgi-bin/koha/sci/sci-main.pl [1]
=> SUCCESS: You are rejected because the feature is disabled
- Enable 'SelfCheckInModule'
- Go to the previous URL
=> SUCCESS: You are required to login
- Login with a user WITHOUT self_checkout permissions
=> SUCCESS: You are not allowed to log into the Self check-in module.
- Login with a user WITH self_checkour permissions
=> SUCCESS: You gain access, and are presented the UI
- Go through the several options
=> SUCCESS: All works as it should
- Click the 'Help' link
=> SUCCESS: A help text is displayed on a modal
- Sign off :-D

- Bonus points:
  $ kshell
 k$ qa -c 2 -v 2
=> SUCCESS: All tests green

[1] Adjust to your dev's OPAC setup

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Nov 15 20:52:34 2017
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 15 Nov 2017 19:52:34 +0000
Subject: [Koha-bugs] [Bug 18790] Add ability to void payments
In-Reply-To: <bug-18790-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-18790-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-18790-70-IU6Bz9teUx@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18790

Katrin Fischer <katrin.fischer at bsz-bw.de> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |katrin.fischer at bsz-bw.de

--- Comment #12 from Katrin Fischer <katrin.fischer at bsz-bw.de> ---
Should we consider logging reversing or voiding payments somewhere? We have
talked to libraries that have to report regularly on money collected and
changing payments later on could cause confusing results if not used very
carefully.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Nov 15 20:53:00 2017
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 15 Nov 2017 19:53:00 +0000
Subject: [Koha-bugs] [Bug 15492] Self-Check module stand alone check-in
In-Reply-To: <bug-15492-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-15492-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-15492-70-NSBd2gukBb@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15492

Tom?s Cohen Arazi <tomascohen at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #69167|0                           |1
        is obsolete|                            |

--- Comment #6 from Tom?s Cohen Arazi <tomascohen at gmail.com> ---
Created attachment 69168
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=69168&action=edit
Bug 15492: Add SCI module

This patch adds the SCI module, and adapts C4::Auth to know about it.

The current behaviour is:
- Requires admin user initialization/login
- Uses the logged users' library
- A form allows to scan multiple barcodes
- A button sends the barcode list to the controller
  to batch perform the checkins
- Successful and failed checkins are sent to the template
- Results are displayed
- Logout link

To test:
- Apply this patches
- Make sure you upgrade:
  $ kshell
 k$ perl installer/data/mysql/updatedatabase.pl
- Have 'SelfCheckInModule' disabled
- Go to http://kohadev.myDNSname.org:8080/cgi-bin/koha/sci/sci-main.pl [1]
=> SUCCESS: You are rejected because the feature is disabled
- Enable 'SelfCheckInModule'
- Go to the previous URL
=> SUCCESS: You are required to login
- Login with a user WITHOUT self_checkout permissions
=> SUCCESS: You are not allowed to log into the Self check-in module.
- Login with a user WITH self_checkour permissions
=> SUCCESS: You gain access, and are presented the UI
- Go through the several options
=> SUCCESS: All works as it should
- Click the 'Help' link
=> SUCCESS: A help text is displayed on a modal
- Sign off :-D

- Bonus points:
  $ kshell
 k$ qa -c 2 -v 2
=> SUCCESS: All tests green

[1] Adjust to your dev's OPAC setup

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Nov 15 21:00:06 2017
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 15 Nov 2017 20:00:06 +0000
Subject: [Koha-bugs] [Bug 18786] Add ability to create custom payment types
In-Reply-To: <bug-18786-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-18786-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-18786-70-lAvvb0Juj2@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18786

Katrin Fischer <katrin.fischer at bsz-bw.de> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |katrin.fischer at bsz-bw.de

--- Comment #17 from Katrin Fischer <katrin.fischer at bsz-bw.de> ---
I think this is a duplicate of the older bug 5630 which is also signed off at
the moment.

There was some discussion about using an authorised value there and because we
already have a list of payment types used by SIP and translatability some
hardcoded values were added. Maybe we could make it so that the list can be
extended by an authorised value? (... and make authorised values translatable
for display one day...)

Can we pick one implementation?

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Nov 15 21:00:38 2017
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 15 Nov 2017 20:00:38 +0000
Subject: [Koha-bugs] [Bug 5620] Capture Mode of payment
In-Reply-To: <bug-5620-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-5620-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-5620-70-1UpDiiYbEM@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5620

--- Comment #37 from Katrin Fischer <katrin.fischer at bsz-bw.de> ---
Bug 18786 seems to be a duplicate development

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the QA Contact for the bug.

From bugzilla-daemon at bugs.koha-community.org  Wed Nov 15 21:12:56 2017
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 15 Nov 2017 20:12:56 +0000
Subject: [Koha-bugs] [Bug 10412] The ability to update Acquisitions with
 credit notes, with the option to link to an existing invoice
In-Reply-To: <bug-10412-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-10412-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-10412-70-tTy8PUawal@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10412

--- Comment #19 from Katrin Fischer <katrin.fischer at bsz-bw.de> ---
Hi Maura, I agree that there is some missing functionality in acquisitions that
is much needed. But there is no way we can guarantee for this or bug 10412 to
make it into a specific version. The best way to help things along is to help
with testing or even funding features/developers (see
https://wiki.koha-community.org/wiki/Development_workflow for some info on the
process).

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Nov 15 21:24:52 2017
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 15 Nov 2017 20:24:52 +0000
Subject: [Koha-bugs] [Bug 17292] Use of DBIx in updatedatabase.pl broke
 upgrade (from bug 12375 )
In-Reply-To: <bug-17292-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-17292-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-17292-70-GTf3HwBMzs@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17292

Katrin Fischer <katrin.fischer at bsz-bw.de> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |katrin.fischer at bsz-bw.de

--- Comment #17 from Katrin Fischer <katrin.fischer at bsz-bw.de> ---
We just updated a greater number of installations from 3.22.18 to 16.11.13
without any issues. This appears to be fixed.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Nov 15 21:26:00 2017
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 15 Nov 2017 20:26:00 +0000
Subject: [Koha-bugs] [Bug 17610] [16.11.x] Allow the number of plack workers
 and max connections to be set in koha-conf.xml
In-Reply-To: <bug-17610-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-17610-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-17610-70-CSwAR79y7u@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17610

--- Comment #25 from Katrin Fischer <katrin.fischer at bsz-bw.de> ---
This has been pushed to 16.11.x and will be in 16.11.14.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Nov 15 21:26:40 2017
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 15 Nov 2017 20:26:40 +0000
Subject: [Koha-bugs] [Bug 18654] Translatability: Get rid of tt directives
 starting with [ %% in translation for itemsearch.tt
In-Reply-To: <bug-18654-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-18654-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-18654-70-GSQFH1FEMT@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18654
Bug 18654 depends on bug 18633, which changed state.

Bug 18633 Summary: Logs are full of CGI::param called in list context - itemsearch.pl
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18633

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Pushed to Stable            |RESOLVED
         Resolution|---                         |FIXED

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Nov 15 21:26:39 2017
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 15 Nov 2017 20:26:39 +0000
Subject: [Koha-bugs] [Bug 18633] Logs are full of CGI:: param called in list
 context - itemsearch.pl
In-Reply-To: <bug-18633-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-18633-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-18633-70-bRbbDNltbQ@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18633

Katrin Fischer <katrin.fischer at bsz-bw.de> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
         Resolution|---                         |FIXED
             Status|Pushed to Stable            |RESOLVED

--- Comment #22 from Katrin Fischer <katrin.fischer at bsz-bw.de> ---
Closing.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Nov 15 21:27:10 2017
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 15 Nov 2017 20:27:10 +0000
Subject: [Koha-bugs] [Bug 18477] AR_PENDING notice does not populate values
 from article_requests table
In-Reply-To: <bug-18477-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-18477-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-18477-70-J9zn04e7Vq@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18477

Katrin Fischer <katrin.fischer at bsz-bw.de> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
            Summary|AR_PENDING notice does not  |AR_PENDING notice does not
                   |populate values from        |populate values from
                   |article_requests table.     |article_requests table

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Nov 15 21:28:35 2017
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 15 Nov 2017 20:28:35 +0000
Subject: [Koha-bugs] [Bug 18624] Software error when searching authorities
 in Elasticsearch - incorrect parameter "any" should be "all"
In-Reply-To: <bug-18624-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-18624-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-18624-70-6HG8vO0fAU@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18624

Katrin Fischer <katrin.fischer at bsz-bw.de> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Pushed to Stable            |RESOLVED
         Resolution|---                         |FIXED

--- Comment #21 from Katrin Fischer <katrin.fischer at bsz-bw.de> ---
There are too many ElasticSearch patches missing from 16.11.x - better to focus
on the more current vesions. Closing.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Nov 15 21:29:27 2017
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 15 Nov 2017 20:29:27 +0000
Subject: [Koha-bugs] [Bug 18616] The "Add forgot password link to OPAC"
 should allow patrons to use their library card number in addition to
 username
In-Reply-To: <bug-18616-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-18616-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-18616-70-x2wYVs8Vxs@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18616

--- Comment #20 from Katrin Fischer <katrin.fischer at bsz-bw.de> ---
(In reply to Fridolin SOMERS from comment #19)
> (In reply to Katrin Fischer from comment #18)
> > Fridolin, now that bug 18653 is resolved, would you reconsider?
> 
> Depends now on Bug 18956

Bug 18956 is now pushed into stable releases... Now? ;)

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Nov 15 21:30:23 2017
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 15 Nov 2017 20:30:23 +0000
Subject: [Koha-bugs] [Bug 18802] Circulation.t fails if finesMode != "Do not
	calculate"
In-Reply-To: <bug-18802-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-18802-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-18802-70-6iyK8DKO1I@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18802

Katrin Fischer <katrin.fischer at bsz-bw.de> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
         Resolution|---                         |FIXED
             Status|Pushed to Stable            |RESOLVED

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Nov 15 21:30:24 2017
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 15 Nov 2017 20:30:24 +0000
Subject: [Koha-bugs] [Bug 19009] Circulation.t is still failing randomly
In-Reply-To: <bug-19009-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-19009-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-19009-70-ORmsVHZoDM@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19009
Bug 19009 depends on bug 18802, which changed state.

Bug 18802 Summary: Circulation.t fails if finesMode != "Do not calculate"
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18802

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Pushed to Stable            |RESOLVED
         Resolution|---                         |FIXED

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Nov 15 21:30:46 2017
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 15 Nov 2017 20:30:46 +0000
Subject: [Koha-bugs] [Bug 5471] Quotes in tags cause moderation
 approval/rejection to fail
In-Reply-To: <bug-5471-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-5471-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-5471-70-qXwdDd2k0h@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5471

Katrin Fischer <katrin.fischer at bsz-bw.de> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Pushed to Stable            |RESOLVED
         Resolution|---                         |FIXED

-- 
You are receiving this mail because:
You are the QA Contact for the bug.
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Nov 15 21:31:11 2017
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 15 Nov 2017 20:31:11 +0000
Subject: [Koha-bugs] [Bug 18292] Tests do not need to return 1;
In-Reply-To: <bug-18292-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-18292-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-18292-70-IWCOzcGXVF@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18292

Katrin Fischer <katrin.fischer at bsz-bw.de> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
         Resolution|---                         |FIXED
             Status|Pushed to Stable            |RESOLVED

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Nov 15 21:33:57 2017
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 15 Nov 2017 20:33:57 +0000
Subject: [Koha-bugs] [Bug 19129] Clean up templates for organisation patrons
	in staff
In-Reply-To: <bug-19129-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-19129-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-19129-70-iDsK7nXEMV@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19129

Katrin Fischer <katrin.fischer at bsz-bw.de> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
         Resolution|---                         |FIXED
             Status|Pushed to Stable            |RESOLVED

--- Comment #13 from Katrin Fischer <katrin.fischer at bsz-bw.de> ---
I don't have the time to rebase patches for 16.11.x. Closing.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Nov 15 21:38:06 2017
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 15 Nov 2017 20:38:06 +0000
Subject: [Koha-bugs] [Bug 19180] Vendor name is missing from breadcrumbs
 when closing an order
In-Reply-To: <bug-19180-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-19180-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-19180-70-eTgU0Dfa5O@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19180

--- Comment #18 from Katrin Fischer <katrin.fischer at bsz-bw.de> ---
I checked - the bug exists in 16.11.x.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Nov 15 22:53:39 2017
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 15 Nov 2017 21:53:39 +0000
Subject: [Koha-bugs] [Bug 19593] "Delete vendor" button is always set
In-Reply-To: <bug-19593-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-19593-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-19593-70-uInJ6hIRIX@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19593

Katrin Fischer <katrin.fischer at bsz-bw.de> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |katrin.fischer at bsz-bw.de

--- Comment #1 from Katrin Fischer <katrin.fischer at bsz-bw.de> ---
I verified the problem in 16.11.x, but might need some help in order to fix it.


The template expects a variable basketcount to contain the number of linked
baskets. It's undefined in 16.11.x.

The problem is in the API rewrite:

Bug 12896: Move the bookseller-related code into Koha::Acquisition::Bookseller

Changed the code from using GetBookSellerFromId which returned the count, to
use  the new API:

$supplier = Koha::Acquisition::Bookseller->fetch({ id => $booksellerid });
This doesn't return the counts.

The problem doesn't appear in 17.05, because in December after 16.11.x was
released, another heavy change was made that fixed things in the 17.05 branch:

Bug 13726 - Koha::Acquisition::Bookseller should use Koha::Object

It added Koha::Acquisition::Booksellers and fixed the count variables for
baskets and subscriptions.

How to fix?

GetBookSellerFromId is no longer there, but I am also missing the newer methods
used in 17.05:
+    $supplier = Koha::Acquisition::Booksellers->find( $booksellerid );
basketcount   => $supplier->baskets->count,

Dependency trees from that far back are hard to unravel and trying to do so
might cause new bad side effects. I think a 16.11.x specific fix for this
problem only would be preferrable at this point in time.

Can someone help?

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Nov 15 22:58:51 2017
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 15 Nov 2017 21:58:51 +0000
Subject: [Koha-bugs] [Bug 19593] [16.11.x] "Delete vendor" button is always
	set
In-Reply-To: <bug-19593-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-19593-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-19593-70-JHLmbdmOti@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19593

Katrin Fischer <katrin.fischer at bsz-bw.de> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
            Summary|"Delete vendor" button is   |[16.11.x] "Delete vendor"
                   |always set                  |button is always set
           Severity|normal                      |major

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.

From bugzilla-daemon at bugs.koha-community.org  Wed Nov 15 23:12:08 2017
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 15 Nov 2017 22:12:08 +0000
Subject: [Koha-bugs] [Bug 19630] New: "Hold is suspended" message appears in
 barcode field in holds table
Message-ID: <bug-19630-70@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19630

            Bug ID: 19630
           Summary: "Hold is suspended" message appears in barcode field
                    in holds table
 Change sponsored?: ---
           Product: Koha
           Version: master
          Hardware: All
                OS: All
            Status: NEW
          Severity: trivial
          Priority: P5 - low
         Component: Hold requests
          Assignee: koha-bugs at lists.koha-community.org
          Reporter: caroline.cyr-la-rose at inlibro.com
        QA Contact: testopia at bugs.koha-community.org
                CC: gmcharlt at gmail.com

Created attachment 69169
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=69169&action=edit
Suspended hold message appears in barcode field

In Intranet, when we suspend a hold, the message "hold is suspended" appears in
a column titled "barcode". Even when the hold is not suspended, that column
doesn't show the barcode. I'm guessing it's just a wording problem...

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.

From bugzilla-daemon at bugs.koha-community.org  Wed Nov 15 23:27:20 2017
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 15 Nov 2017 22:27:20 +0000
Subject: [Koha-bugs] [Bug 19532] Recalls for Koha
In-Reply-To: <bug-19532-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-19532-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-19532-70-PpRECWL2Np@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19532

--- Comment #16 from Aleisha Amohia <aleisha at catalyst.net.nz> ---
Created attachment 69170
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=69170&action=edit
Bug 19532: Recalls queue

This patch adds a recalls queue page to the circulation reports

You can see all recalls made in the system, who requested them, their
status and other relevant info. you can cancel individual or multiple
recalls.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Nov 15 23:31:52 2017
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 15 Nov 2017 22:31:52 +0000
Subject: [Koha-bugs] [Bug 19631] New: Fix label sample data for ru-RU and
 uk-UA web installers
Message-ID: <bug-19631-70@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19631

            Bug ID: 19631
           Summary: Fix label sample data for ru-RU and uk-UA web
                    installers
 Change sponsored?: ---
           Product: Koha
           Version: master
          Hardware: All
                OS: All
            Status: NEW
          Severity: minor
          Priority: P5 - low
         Component: Label/patron card printing
          Assignee: cnighswonger at foundations.edu
          Reporter: katrin.fischer at bsz-bw.de
        QA Contact: testopia at bugs.koha-community.org

See bug 10222 for more information.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Nov 15 23:32:05 2017
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 15 Nov 2017 22:32:05 +0000
Subject: [Koha-bugs] [Bug 19631] Fix label sample data for ru-RU and uk-UA
	web installers
In-Reply-To: <bug-19631-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-19631-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-19631-70-PdnPueU1B2@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19631

Katrin Fischer <katrin.fischer at bsz-bw.de> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
           See Also|                            |https://bugs.koha-community
                   |                            |.org/bugzilla3/show_bug.cgi
                   |                            |?id=10222

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Nov 15 23:32:05 2017
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 15 Nov 2017 22:32:05 +0000
Subject: [Koha-bugs] [Bug 10222] Error when saving Demco label templates
In-Reply-To: <bug-10222-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-10222-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-10222-70-eCbGOwY8Je@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10222

Katrin Fischer <katrin.fischer at bsz-bw.de> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
           See Also|                            |https://bugs.koha-community
                   |                            |.org/bugzilla3/show_bug.cgi
                   |                            |?id=19631

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Nov 15 23:34:54 2017
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 15 Nov 2017 22:34:54 +0000
Subject: [Koha-bugs] [Bug 2454] Improve display of credits on pay fines tab
In-Reply-To: <bug-2454-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-2454-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-2454-70-yeJkdrh2nm@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=2454

Alex Buckley <alexbuckley at catalyst.net.nz> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #68470|0                           |1
        is obsolete|                            |

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the QA Contact for the bug.

From bugzilla-daemon at bugs.koha-community.org  Wed Nov 15 23:36:15 2017
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 15 Nov 2017 22:36:15 +0000
Subject: [Koha-bugs] [Bug 2454] Improve display of credits on pay fines tab
In-Reply-To: <bug-2454-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-2454-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-2454-70-Ey8t3513cz@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=2454

Alex Buckley <alexbuckley at catalyst.net.nz> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Failed QA                   |Needs Signoff

--- Comment #19 from Alex Buckley <alexbuckley at catalyst.net.nz> ---
Sorry I should have obsoleted the first patch which removed the 'processing
fee'. I have done so now.

-- 
You are receiving this mail because:
You are the QA Contact for the bug.
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Nov 16 00:58:35 2017
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 15 Nov 2017 23:58:35 +0000
Subject: [Koha-bugs] [Bug 10708] make fine receipt customizable
In-Reply-To: <bug-10708-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-10708-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-10708-70-3Psd007DsY@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10708

Katrin Fischer <katrin.fischer at bsz-bw.de> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
           See Also|                            |https://bugs.koha-community
                   |                            |.org/bugzilla3/show_bug.cgi
                   |                            |?id=19036
                 CC|                            |katrin.fischer at bsz-bw.de

--- Comment #8 from Katrin Fischer <katrin.fischer at bsz-bw.de> ---
Hi Jamsheer, I have filed a separate bug report for this - bug 19036. I am
linking it here in the see also.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Nov 16 00:58:35 2017
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 15 Nov 2017 23:58:35 +0000
Subject: [Koha-bugs] [Bug 19036] Number payment receipts / payment slips
In-Reply-To: <bug-19036-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-19036-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-19036-70-fnTKhFiAEf@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19036

Katrin Fischer <katrin.fischer at bsz-bw.de> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
           See Also|                            |https://bugs.koha-community
                   |                            |.org/bugzilla3/show_bug.cgi
                   |                            |?id=10708

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Nov 16 00:58:41 2017
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 15 Nov 2017 23:58:41 +0000
Subject: [Koha-bugs] [Bug 10708] Make fine receipt customizable
In-Reply-To: <bug-10708-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-10708-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-10708-70-jhcufvKqL3@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10708

Katrin Fischer <katrin.fischer at bsz-bw.de> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
            Summary|make fine receipt           |Make fine receipt
                   |customizable                |customizable

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Nov 16 01:03:28 2017
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 16 Nov 2017 00:03:28 +0000
Subject: [Koha-bugs] [Bug 13188] Mandatory fields are wrong in patron
 personal details page
In-Reply-To: <bug-13188-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-13188-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-13188-70-t8jrVYF4kn@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13188

--- Comment #4 from Katrin Fischer <katrin.fischer at bsz-bw.de> ---
Hi Ola, have you seen PatronSelfModificationBorrowerUnwantedField?

I think this bug might be resolved with the newer preference.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Nov 16 01:06:40 2017
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 16 Nov 2017 00:06:40 +0000
Subject: [Koha-bugs] [Bug 19621] Routing lists tab not present when viewing
 'Holds history' tab for a patron
In-Reply-To: <bug-19621-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-19621-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-19621-70-vUTD1g8uoC@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19621

Dilan Johnpull? <dilan at calyx.net.au> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Needs Signoff               |Signed Off

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Nov 16 01:06:44 2017
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 16 Nov 2017 00:06:44 +0000
Subject: [Koha-bugs] [Bug 19621] Routing lists tab not present when viewing
 'Holds history' tab for a patron
In-Reply-To: <bug-19621-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-19621-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-19621-70-yFLAnxZVMU@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19621

Dilan Johnpull? <dilan at calyx.net.au> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #69132|0                           |1
        is obsolete|                            |

--- Comment #2 from Dilan Johnpull? <dilan at calyx.net.au> ---
Created attachment 69171
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=69171&action=edit
Bug 19621 - Use preference check on template side to display/not display
Routing lists tab

Patch applies without issue and functions as described.

Signed-off-by: Dilan Johnpull? <dilan at calyx.net.au>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Nov 16 01:56:25 2017
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 16 Nov 2017 00:56:25 +0000
Subject: [Koha-bugs] [Bug 19532] Recalls for Koha
In-Reply-To: <bug-19532-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-19532-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-19532-70-9wh4qY8dub@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19532

--- Comment #17 from Aleisha Amohia <aleisha at catalyst.net.nz> ---
Created attachment 69172
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=69172&action=edit
Bug 19532: Overdue recalls report

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Nov 16 07:48:09 2017
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 16 Nov 2017 06:48:09 +0000
Subject: [Koha-bugs] [Bug 18979] Speed up 'valid-templates.t' tests
In-Reply-To: <bug-18979-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-18979-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-18979-70-Agox5DESh1@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18979

--- Comment #13 from Mason James <mtj at kohaaloha.com> ---
(In reply to Marcel de Rooy from comment #12)
> (In reply to Mason James from comment #10)
> > a little update here...
> > it turns out that the 'use threads' line was needed for patch to succeed,
> > after all
> > 
> > the 'use threads' line seems to handle a known bug where Test::Simple
> > generates the TAP tests out of order, and causes the tests to fail
> > 
> > 
> > the good news is that there are some options...
> > 
> > 1/ use the Test2::Suite module, which handles parallel tests well...
> >    https://metacpan.org/pod/Test2::Suite
> > 
> >    the only catch here is that it's new-ish, so we'll need to backport the
> > module to deb8/jessie too
> > 
> > 2/ just allow the 'use threads' line. 
> > 	Because no threads are ever actually created, it should be pretty safe
> >    
> > 
> > fyi: i did try using forks.pm too, but sadly got lots of random fails
> 
> Mason,
> Which option has your preference ?
> 
> Marcel

hiya, i'd vote for option 1/ as quick fix, and then a separate bug for a
leisurely switch to Test2::Suite

anyone else have an opinion?

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Nov 16 08:30:49 2017
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 16 Nov 2017 07:30:49 +0000
Subject: [Koha-bugs] [Bug 17468] Remove koha-*-zebra scripts in favor of
	koha-zebra
In-Reply-To: <bug-17468-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-17468-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-17468-70-E9pGMVRPu5@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17468

--- Comment #10 from Katrin Fischer <katrin.fischer at bsz-bw.de> ---
(In reply to Tom?s Cohen Arazi from comment #9)
> (In reply to Katrin Fischer from comment #8)
> > Hi Tomas, can you pleas add a test plan and instructions on how to test with
> > kohadevbox? I seem to remember I need to copy the files somewhere.
> 
> You need to have the dependency bug, run reset _all, delete the koha-*-zebra
> (excluding rebuild) scripts, and create links to koha-zebra, named as the
> deleted commands.

That's the problem - I don't remember what to copy from where to where. Can you
add a bit more detailed instructions or an example? I can try to find a place
on the wiki for it.

> Then test the 'legacy' commands still work. The dep bug, implementing
> koha-zebra is the juicy one. 

That one is in now :)

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Nov 16 08:33:47 2017
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 16 Nov 2017 07:33:47 +0000
Subject: [Koha-bugs] [Bug 13188] Mandatory fields are wrong in patron
 personal details page
In-Reply-To: <bug-13188-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-13188-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-13188-70-uPwVvylsZx@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13188

--- Comment #5 from Ola Andersson <ola.andersson at ltu.se> ---
Hi Katrin! Yes I have seen PatronSelfModificationBorrowerUnwantedField. The
problem is if you like us would like to keep Address2 field in both
SelfRegistration and SelfModification but have it as an optional fields in
SelfModification and a compulsory field in SelfRegistration. This configuration
seems impossible with Koha settings.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Nov 16 08:41:30 2017
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 16 Nov 2017 07:41:30 +0000
Subject: [Koha-bugs] [Bug 18993] Bump libtest-simple-perl to 1.302075
In-Reply-To: <bug-18993-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-18993-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-18993-70-r7VW2tuDrV@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18993

--- Comment #18 from Mason James <mtj at kohaaloha.com> ---
(In reply to Julian Maurice from comment #16)
> (In reply to Mirko Tietgen from comment #6)
> > > > v5.25.8    1.302073
> > 
> > Obviously the version is lower ? my bad.
> 
> The patch still references perl-modules-5.26 as an alternative to
> libtest-simple-perl. Shouldn't it be removed ?
> If 1.302073 is ok I think we should use that version in PerlDependencies.pm
> and debian/control

good news.. the tests PASS with 1.302073

i'll add a patch with the correction

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Nov 16 08:49:32 2017
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 16 Nov 2017 07:49:32 +0000
Subject: [Koha-bugs] [Bug 18993] Bump libtest-simple-perl to 1.302075
In-Reply-To: <bug-18993-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-18993-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-18993-70-zdg0RuOZtn@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18993

--- Comment #19 from Mason James <mtj at kohaaloha.com> ---
Created attachment 69173
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=69173&action=edit
Bug 18993: Allow Test::More version 1.302073

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Nov 16 08:55:00 2017
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 16 Nov 2017 07:55:00 +0000
Subject: [Koha-bugs] [Bug 18993] Bump libtest-simple-perl to 1.302075
In-Reply-To: <bug-18993-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-18993-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-18993-70-6PdTIfAZa4@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18993

Mason James <mtj at kohaaloha.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Failed QA                   |Signed Off

--- Comment #20 from Mason James <mtj at kohaaloha.com> ---
setting to status back to SO?

good spotting Julian!

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Nov 16 09:08:01 2017
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 16 Nov 2017 08:08:01 +0000
Subject: [Koha-bugs] [Bug 18979] Speed up 'valid-templates.t' tests
In-Reply-To: <bug-18979-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-18979-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-18979-70-QJDjglMPdy@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18979

--- Comment #14 from Mason James <mtj at kohaaloha.com> ---

> hiya, i'd vote for option 1/ as quick fix, and then a separate bug for a
> leisurely switch to Test2::Suite

oops, i meant option 2, then a follow-up for option 1 :)

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Nov 16 09:17:46 2017
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 16 Nov 2017 08:17:46 +0000
Subject: [Koha-bugs] [Bug 17717] process_message_queue.pl: Can't locate
 Authen/CAS/Client/ Response/Failure.pm
In-Reply-To: <bug-17717-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-17717-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-17717-70-rhbxLKh4Ik@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17717

Magnus Enger <magnus at libriotech.no> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |magnus at libriotech.no

--- Comment #44 from Magnus Enger <magnus at libriotech.no> ---
I ran into this problem after upgrading from

Koha 3.22, Ubuntu 14.04, Perl ?

to 

Koha 17.05.05, Ubuntu 16.04.3 LTS, Perl v5.22.1

gather_print_notices.pl run from cron (sudo crontab -e) would fail with this
error:

Can't locate Koha/Exceptions/Exception.pm: ./Koha/Exceptions/Exception.pm:
Permission denied at /usr/share/perl/5.22/base.pm line 97.
...propagated at /usr/share/perl/5.22/base.pm line 106.
BEGIN failed--compilation aborted at (eval 14) line 3.
BEGIN failed--compilation aborted at /usr/share/koha/lib/Koha/Exceptions.pm
line 56.
Compilation failed in require at /usr/share/koha/lib/Koha/DateUtils.pm line 22.
BEGIN failed--compilation aborted at /usr/share/koha/lib/Koha/DateUtils.pm line
22.
Compilation failed in require at /usr/share/koha/lib/C4/Log.pm line 30.
BEGIN failed--compilation aborted at /usr/share/koha/lib/C4/Log.pm line 30.
Compilation failed in require at /usr/share/koha/lib/Koha/Config/SysPref.pm
line 26.
BEGIN failed--compilation aborted at /usr/share/koha/lib/Koha/Config/SysPref.pm
line 26.
Compilation failed in require at /usr/share/koha/lib/C4/Context.pm line 105.
BEGIN failed--compilation aborted at /usr/share/koha/lib/C4/Context.pm line
105.
Compilation failed in require at
/usr/share/koha/bin/cronjobs/gather_print_notices.pl line 13.
BEGIN failed--compilation aborted at
/usr/share/koha/bin/cronjobs/gather_print_notices.pl line 13.

Running the command in the crontab on the command line would succeed, no
errors. 

Adding the "cd /tmp &&" trick in front of the commands in the crontab makes the
errors go away.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Nov 16 09:18:31 2017
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 16 Nov 2017 08:18:31 +0000
Subject: [Koha-bugs] [Bug 17282] Ability to create charts for SQL reports
In-Reply-To: <bug-17282-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-17282-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-17282-70-qNw3eU6I08@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17282

--- Comment #40 from Alex Arnaud <alex.arnaud at biblibre.com> ---
Created attachment 69174
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=69174&action=edit
Bug 17282 - Add information about the new Javascript libraries in the about
page  - fix a QA warning  - Move chart settings on top and make them hidden by
default  - Add options to get all results

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Nov 16 09:19:26 2017
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 16 Nov 2017 08:19:26 +0000
Subject: [Koha-bugs] [Bug 19632] New: String reappears as fuzzy with every
 translation update
Message-ID: <bug-19632-70@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19632

            Bug ID: 19632
           Summary: String reappears as fuzzy with every translation
                    update
 Change sponsored?: ---
           Product: Koha
           Version: master
          Hardware: All
                OS: All
            Status: NEW
          Severity: minor
          Priority: P5 - low
         Component: I18N/L10N
          Assignee: koha-bugs at lists.koha-community.org
          Reporter: katrin.fischer at bsz-bw.de
        QA Contact: testopia at bugs.koha-community.org
                CC: frederic at tamil.fr

This string has been haunting me for a while, it never changes, but asks for
translation after every update of the po files:


Finally, if you charge a rental fee for the item type and want to give a
specific patron category a discount on that fee, enter the percentage discount
(without the %% symbol) in the 'Rental Discount' field

Maybe a problem with the percentage sign?

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Nov 16 09:19:31 2017
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 16 Nov 2017 08:19:31 +0000
Subject: [Koha-bugs] [Bug 17282] Ability to create charts for SQL reports
In-Reply-To: <bug-17282-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-17282-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-17282-70-bY50xMLMrl@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17282

Alex Arnaud <alex.arnaud at biblibre.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Failed QA                   |Needs Signoff

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Nov 16 09:42:30 2017
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 16 Nov 2017 08:42:30 +0000
Subject: [Koha-bugs] [Bug 18993] Bump libtest-simple-perl to 1.302075
In-Reply-To: <bug-18993-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-18993-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-18993-70-okPex6ni7o@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18993

--- Comment #21 from Julian Maurice <julian.maurice at biblibre.com> ---
libtest-simple-perl is listed twice in Build-Depends (debian/control), the
first without version constraint (comes from __AUTODEPENDS__).
This is probably nothing but maybe lintian will complain about that.

But it's already like that in master, so this will not prevent QA.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Nov 16 09:43:31 2017
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 16 Nov 2017 08:43:31 +0000
Subject: [Koha-bugs] [Bug 18993] Bump libtest-simple-perl to 1.302075
In-Reply-To: <bug-18993-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-18993-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-18993-70-mEoY7lpksM@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18993

Julian Maurice <julian.maurice at biblibre.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #67563|0                           |1
        is obsolete|                            |

--- Comment #23 from Julian Maurice <julian.maurice at biblibre.com> ---
Created attachment 69176
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=69176&action=edit
Bug 18993: Bump Test::More to 1.302075

Signed-off-by: Julian Maurice <julian.maurice at biblibre.com>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Nov 16 09:43:35 2017
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 16 Nov 2017 08:43:35 +0000
Subject: [Koha-bugs] [Bug 18993] Bump libtest-simple-perl to 1.302075
In-Reply-To: <bug-18993-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-18993-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-18993-70-4nPPIjrdHl@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18993

Julian Maurice <julian.maurice at biblibre.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #69173|0                           |1
        is obsolete|                            |

--- Comment #24 from Julian Maurice <julian.maurice at biblibre.com> ---
Created attachment 69177
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=69177&action=edit
Bug 18993: Allow Test::More version 1.302073

Signed-off-by: Julian Maurice <julian.maurice at biblibre.com>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Nov 16 09:43:27 2017
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 16 Nov 2017 08:43:27 +0000
Subject: [Koha-bugs] [Bug 18993] Bump libtest-simple-perl to 1.302075
In-Reply-To: <bug-18993-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-18993-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-18993-70-obG8W4F7uc@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18993

Julian Maurice <julian.maurice at biblibre.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #65333|0                           |1
        is obsolete|                            |

--- Comment #22 from Julian Maurice <julian.maurice at biblibre.com> ---
Created attachment 69175
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=69175&action=edit
Bug 18993 - Bump libtest-simple-perl to 1.302075

Signed-off-by: Mason James <mtj at kohaaloha.com>
Signed-off-by: Julian Maurice <julian.maurice at biblibre.com>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Nov 16 09:43:47 2017
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 16 Nov 2017 08:43:47 +0000
Subject: [Koha-bugs] [Bug 18993] Bump libtest-simple-perl to 1.302073
In-Reply-To: <bug-18993-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-18993-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-18993-70-bJVEHNAWmD@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18993

Julian Maurice <julian.maurice at biblibre.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
            Summary|Bump libtest-simple-perl to |Bump libtest-simple-perl to
                   |1.302075                    |1.302073

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Nov 16 10:30:42 2017
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 16 Nov 2017 09:30:42 +0000
Subject: [Koha-bugs] [Bug 19593] [16.11.x] "Delete vendor" button is always
	set
In-Reply-To: <bug-19593-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-19593-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-19593-70-CZwkjSo7jQ@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19593

--- Comment #2 from Gwendal JONCOUR <gwendal.joncour at univ-rennes2.fr> ---
Created attachment 69178
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=69178&action=edit
Rennes 2 local correction for basketcount and subscriptioncount calls

Here's my local correction. A little bit nasty but it make its job and works on
each calls of basketcount and subscriptioncount.

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Nov 16 11:11:03 2017
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 16 Nov 2017 10:11:03 +0000
Subject: [Koha-bugs] [Bug 17278] Limit to available items returns 0 results
In-Reply-To: <bug-17278-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-17278-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-17278-70-YpvPs0giQZ@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17278

--- Comment #27 from Mason James <mtj at kohaaloha.com> ---

On 16/11/17 21:26, Andreas Roussos wrote:
> Dear Devs,
>
> Re: Bug 17278 - Limit to available items returns 0 results
>
> We're running Koha 16.05.16 on Debian and are affected by this bug.
>
> AFAICT there were a couple of patches written for this, which were
> pushed to the master/16.05.x/3.22.x branches.
>
> However, the commits for 16.05.x were later reverted:
> http://git.koha-community.org/gitweb/?p=koha.git;a=commit;h=aed6d17ffd3aa6de49deb9dab9436ba979c35f6e
> http://git.koha-community.org/gitweb/?p=koha.git;a=commit;h=4f761bb6904b127990b8d1e993ea67098f8cdb7c

hi Andreas
hmm, i think this revert might have been an accident :/

i'll aim to add the patchset to the next 16.05.x release (due in the
next few days)
thanks for spotting this

cheers, Mason

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Nov 16 11:42:58 2017
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 16 Nov 2017 10:42:58 +0000
Subject: [Koha-bugs] [Bug 19633] New: Uploader.pm / upload.pl -- Use
 alphanumeric error codes
Message-ID: <bug-19633-70@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19633

            Bug ID: 19633
           Summary: Uploader.pm / upload.pl -- Use alphanumeric error
                    codes
 Change sponsored?: ---
           Product: Koha
           Version: master
          Hardware: All
                OS: All
            Status: NEW
          Severity: enhancement
          Priority: P5 - low
         Component: Architecture, internals, and plumbing
          Assignee: koha-bugs at lists.koha-community.org
          Reporter: m.de.rooy at rijksmuseum.nl
        QA Contact: testopia at bugs.koha-community.org

See comment 21 on bug 19420

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Nov 16 11:43:18 2017
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 16 Nov 2017 10:43:18 +0000
Subject: [Koha-bugs] [Bug 19633] Uploader.pm / upload.pl -- Use alphanumeric
	error codes
In-Reply-To: <bug-19633-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-19633-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-19633-70-JkfZkJpdEF@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19633

Marcel de Rooy <m.de.rooy at rijksmuseum.nl> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
   Patch complexity|---                         |Small patch
             Status|NEW                         |ASSIGNED
           Assignee|koha-bugs at lists.koha-commun |m.de.rooy at rijksmuseum.nl
                   |ity.org                     |

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Nov 16 11:43:43 2017
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 16 Nov 2017 10:43:43 +0000
Subject: [Koha-bugs] [Bug 19633] Uploader.pm / upload.pl -- Use alphanumeric
	error codes
In-Reply-To: <bug-19633-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-19633-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-19633-70-669Mqrd4Kt@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19633

Marcel de Rooy <m.de.rooy at rijksmuseum.nl> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
           See Also|                            |https://bugs.koha-community
                   |                            |.org/bugzilla3/show_bug.cgi
                   |                            |?id=19420

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Nov 16 11:43:43 2017
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 16 Nov 2017 10:43:43 +0000
Subject: [Koha-bugs] [Bug 19420] Improve display of errors from failure of
 uploading file during stage import
In-Reply-To: <bug-19420-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-19420-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-19420-70-oPtd6BYE0K@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19420

Marcel de Rooy <m.de.rooy at rijksmuseum.nl> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
           See Also|                            |https://bugs.koha-community
                   |                            |.org/bugzilla3/show_bug.cgi
                   |                            |?id=19633

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Nov 16 11:49:22 2017
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 16 Nov 2017 10:49:22 +0000
Subject: [Koha-bugs] [Bug 19633] Uploader.pm / upload.pl -- Use alphanumeric
	error codes
In-Reply-To: <bug-19633-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-19633-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-19633-70-ngY5UHbOlj@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19633

Marcel de Rooy <m.de.rooy at rijksmuseum.nl> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
           See Also|                            |https://bugs.koha-community
                   |                            |.org/bugzilla3/show_bug.cgi
                   |                            |?id=14294

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Nov 16 11:49:22 2017
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 16 Nov 2017 10:49:22 +0000
Subject: [Koha-bugs] [Bug 14294] Umbrella report for tracking improvements
 to File upload feature ( see also 6874)
In-Reply-To: <bug-14294-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-14294-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-14294-70-SsMWqtG31h@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14294

Marcel de Rooy <m.de.rooy at rijksmuseum.nl> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
           See Also|                            |https://bugs.koha-community
                   |                            |.org/bugzilla3/show_bug.cgi
                   |                            |?id=19633

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Nov 16 11:57:58 2017
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 16 Nov 2017 10:57:58 +0000
Subject: [Koha-bugs] [Bug 19634] New: Advanced editor - Rancor - error in
 display of macro editor in firefox
Message-ID: <bug-19634-70@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19634

            Bug ID: 19634
           Summary: Advanced editor - Rancor - error in display of macro
                    editor in firefox
 Change sponsored?: ---
           Product: Koha
           Version: master
          Hardware: All
                OS: All
            Status: NEW
          Severity: enhancement
          Priority: P5 - low
         Component: Cataloging
          Assignee: koha-bugs at lists.koha-community.org
          Reporter: nick at bywatersolutions.com
        QA Contact: testopia at bugs.koha-community.org
                CC: m.de.rooy at rijksmuseum.nl

To recreate:
0 - Use firefox
1 - Open the advanced editor
2 - Click 'new macro'
3 - name it
4 - the editor window has only one line

This js is a workaround for the moment:
$(document).ready(function(){
$("#macro-editor").closest("div.row").css("height","100%");
});

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Nov 16 13:00:45 2017
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 16 Nov 2017 12:00:45 +0000
Subject: [Koha-bugs] [Bug 19635] New: OAI-PMH deleted records are now
 default and are listed first
Message-ID: <bug-19635-70@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19635

            Bug ID: 19635
           Summary: OAI-PMH deleted records are now default and are listed
                    first
 Change sponsored?: ---
           Product: Koha
           Version: master
          Hardware: All
                OS: All
            Status: NEW
          Severity: normal
          Priority: P5 - low
         Component: Searching
          Assignee: koha-bugs at lists.koha-community.org
          Reporter: nick at bywatersolutions.com
        QA Contact: testopia at bugs.koha-community.org

It seems bug 15108 made some changes to which records are served up first by
the OAI server.

When making a basic request with no token, i.e.:
http://localhost:8080/cgi-bin/koha/oai.pl?verb=ListRecords&metadataPrefix=marcxml

You get any deleted records first.

When continuing if you have more than 50 deleted records the resumptionToken
also includes deleted records

We have services harvesting the entire catalog that don't expect deleted
records first.

I am not seeing a way to prevent them, and wonder if they should not be served
first.

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Nov 16 13:01:13 2017
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 16 Nov 2017 12:01:13 +0000
Subject: [Koha-bugs] [Bug 19635] OAI-PMH deleted records are now default and
 are listed first
In-Reply-To: <bug-19635-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-19635-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-19635-70-QbpTaM9BK7@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19635

Nick Clemens <nick at bywatersolutions.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |ere.maijala at helsinki.fi,
                   |                            |olli-antti.kivilahti at jns.fi
                   |                            |, tomascohen at gmail.com

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Nov 16 13:06:10 2017
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 16 Nov 2017 12:06:10 +0000
Subject: [Koha-bugs] [Bug 14759] Replacement for Text::Unaccent
In-Reply-To: <bug-14759-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-14759-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-14759-70-umWDx3WfkV@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14759

Colin Campbell <colin.campbell at ptfs-europe.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |colin.campbell at ptfs-europe.
                   |                            |com

--- Comment #25 from Colin Campbell <colin.campbell at ptfs-europe.com> ---
Text::Unaccent does not build on 64bit systems, the tests fail because of
errors in the ccode. There has been a patch for that for four years but it
looks like the upstream code is moribund. If you look at the test results it
now fails on all linux test builds. The module has not been kept up to date to
handle modern perl strings. I think the debian version may be patched to fix
the bug in 64bit tests but it is buggy and should not be relied on. Suggest
moving to Text::Unaccent::PurPerl be prioritized

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Nov 16 13:20:02 2017
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 16 Nov 2017 12:20:02 +0000
Subject: [Koha-bugs] [Bug 15492] Self-Check module stand alone check-in
In-Reply-To: <bug-15492-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-15492-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-15492-70-vCYqgzqw4T@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15492

Tom?s Cohen Arazi <tomascohen at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #69168|0                           |1
        is obsolete|                            |

--- Comment #7 from Tom?s Cohen Arazi <tomascohen at gmail.com> ---
Created attachment 69179
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=69179&action=edit
Bug 15492: Add SCI module

This patch adds the SCI module, and adapts C4::Auth to know about it.

The current behaviour is:
- Requires admin user initialization/login
- Uses the logged users' library
- A form allows to scan multiple barcodes
- A button sends the barcode list to the controller
  to batch perform the checkins
- Successful and failed checkins are sent to the template
- Results are displayed
- Logout link

To test:
- Apply this patches
- Make sure you upgrade:
  $ kshell
 k$ perl installer/data/mysql/updatedatabase.pl
- Have 'SelfCheckInModule' disabled
- Go to http://kohadev.myDNSname.org:8080/cgi-bin/koha/sci/sci-main.pl [1]
=> SUCCESS: You are rejected because the feature is disabled
- Enable 'SelfCheckInModule'
- Go to the previous URL
=> SUCCESS: You are required to login
- Login with a user WITHOUT self_checkout permissions
=> SUCCESS: You are not allowed to log into the Self check-in module.
- Login with a user WITH self_checkour permissions
=> SUCCESS: You gain access, and are presented the UI
- Go through the several options
=> SUCCESS: All works as it should
- Click the 'Help' link
=> SUCCESS: A help text is displayed on a modal
- Sign off :-D

- Bonus points:
  $ kshell
 k$ qa -c 2 -v 2
=> SUCCESS: All tests green

[1] Adjust to your dev's OPAC setup

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Nov 16 13:21:45 2017
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 16 Nov 2017 12:21:45 +0000
Subject: [Koha-bugs] [Bug 15492] Self-Check module stand alone check-in
In-Reply-To: <bug-15492-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-15492-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-15492-70-d31QBtX07g@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15492

--- Comment #8 from Tom?s Cohen Arazi <tomascohen at gmail.com> ---
(In reply to Owen Leonard from comment #4)
> This is missing from sci-main.tt:
> 
> <script type="text/javascript">
>     function _(s) { return s } // dummy function for gettext
> </script>
> 
> (see sco-main.tt for comparison)

I've re-introduced it, along with several other tiny fixes/changes, including
the help modal.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Nov 16 13:34:20 2017
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 16 Nov 2017 12:34:20 +0000
Subject: [Koha-bugs] [Bug 19636] New: Hold priority changes incorrectly via
 dropdown select
Message-ID: <bug-19636-70@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19636

            Bug ID: 19636
           Summary: Hold priority changes incorrectly via dropdown select
 Change sponsored?: ---
           Product: Koha
           Version: unspecified
          Hardware: All
                OS: All
            Status: NEW
          Severity: enhancement
          Priority: P5 - low
         Component: Staff Client
          Assignee: koha-bugs at lists.koha-community.org
          Reporter: lari.taskula at jns.fi
        QA Contact: testopia at bugs.koha-community.org
                CC: gmcharlt at gmail.com

To reproduce:

1. Place 3 holds on a record
2. See existing holds (cgi-bin/koha/reserve/request.pl?biblionumber=XXX)
3. By using the dropdown menu under "Priority" column, change the first hold's
   priority to last (3). Do not touch other priorities.
4. Click Update hold(s)
5. Observe the hold did not get your selected priority 3, but 2 instead.

I believe this happens when the form is posted and each row is individually
processed one by one - and due to conflict in priority value, the latter row
always gets the chosen value.

This could be solved by sorting the hold table by priority before updating the
holds.

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.

From bugzilla-daemon at bugs.koha-community.org  Thu Nov 16 13:34:30 2017
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 16 Nov 2017 12:34:30 +0000
Subject: [Koha-bugs] [Bug 19636] Hold priority changes incorrectly via
	dropdown select
In-Reply-To: <bug-19636-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-19636-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-19636-70-BCreBZamvf@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19636

Lari Taskula <lari.taskula at jns.fi> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
           Assignee|koha-bugs at lists.koha-commun |lari.taskula at jns.fi
                   |ity.org                     |

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.

From bugzilla-daemon at bugs.koha-community.org  Thu Nov 16 13:37:48 2017
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 16 Nov 2017 12:37:48 +0000
Subject: [Koha-bugs] [Bug 19637] New: jsPrintSetup not supported in Firefox
	Quantum
Message-ID: <bug-19637-70@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19637

            Bug ID: 19637
           Summary: jsPrintSetup not supported in Firefox Quantum
 Change sponsored?: ---
           Product: Koha
           Version: unspecified
          Hardware: All
                OS: All
            Status: NEW
          Severity: enhancement
          Priority: P5 - low
         Component: Circulation
          Assignee: koha-bugs at lists.koha-community.org
          Reporter: stefan.berndtsson at ub.gu.se
        QA Contact: testopia at bugs.koha-community.org
                CC: gmcharlt at gmail.com, kyle.m.hall at gmail.com

This is mainly a heads-up. As of Firefox v57 (Quantum), the addon jsPrintSetup
is no longer supported. From what I've been able to tell in the bug reports
this is due to missing functionality in the WebExtensions API.

Relevant bug reports:

Mozilla: https://bugzilla.mozilla.org/show_bug.cgi?id=1385827

Addon: https://github.com/edabg/jsprintsetup/issues/39

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Nov 16 13:41:35 2017
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 16 Nov 2017 12:41:35 +0000
Subject: [Koha-bugs] [Bug 19636] Hold priority changes incorrectly via
	dropdown select
In-Reply-To: <bug-19636-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-19636-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-19636-70-U7PjOiJYdq@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19636

Lari Taskula <lari.taskula at jns.fi> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|NEW                         |Needs Signoff

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Nov 16 13:41:37 2017
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 16 Nov 2017 12:41:37 +0000
Subject: [Koha-bugs] [Bug 19636] Hold priority changes incorrectly via
	dropdown select
In-Reply-To: <bug-19636-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-19636-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-19636-70-zIlR1HtFP3@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19636

--- Comment #1 from Lari Taskula <lari.taskula at jns.fi> ---
Created attachment 69180
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=69180&action=edit
Bug 19636: Hold priority changes incorrectly via dropdown select

This patch sorts holds in UI after priority is changed via "Priority" dropdown.

It fixes confusion where the form is posted and each row is individually
processed
one by one - and due to conflict in priority value, the latter row always gets
the chosen value instead of what the user actually might have wanted to change.

To reproduce:
1. Place 3 holds on a record
2. See existing holds (cgi-bin/koha/reserve/request.pl?biblionumber=XXX)
3. By using the dropdown menu under "Priority" column, change the first hold's
   priority to last (3). Do not touch other priorities.
4. Click Update hold(s)
5. Observe the hold did not get your selected priority 3, but 2 instead.

To test:
1. Apply patch
2. Place 3 holds on a record
3. See existing holds (cgi-bin/koha/reserve/request.pl?biblionumber=XXX)
4. By using the dropdown menu under "Priority" column, change the first hold's
   priority to last (3). Do not touch other priorities.
5. Observe this hold was automatically moved to the last row in the user
   interface.
6. Click Update hold(s)
7. Observe the hold has your selected priority 3.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Nov 16 13:51:37 2017
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 16 Nov 2017 12:51:37 +0000
Subject: [Koha-bugs] [Bug 15492] Stand alone self check-in tool
In-Reply-To: <bug-15492-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-15492-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-15492-70-n3sSKnpajV@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15492

Tom?s Cohen Arazi <tomascohen at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
            Summary|Self-Check module stand     |Stand alone self check-in
                   |alone check-in              |tool

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Nov 16 13:51:45 2017
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 16 Nov 2017 12:51:45 +0000
Subject: [Koha-bugs] [Bug 19635] OAI-PMH deleted records are now default and
 are listed first
In-Reply-To: <bug-19635-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-19635-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-19635-70-IZKoO0ZaRM@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19635

--- Comment #1 from Ere Maijala <ere.maijala at helsinki.fi> ---
As far as I know there's definitely nothing wrong in returning the deleted
records first. Can you explain in a bit more detail why that is an issue? A
harvester should just harvest until a resumptionToken is not returned, and
there's no promise in the protocol that the records are returned in any
particular order.

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.

From bugzilla-daemon at bugs.koha-community.org  Thu Nov 16 14:11:54 2017
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 16 Nov 2017 13:11:54 +0000
Subject: [Koha-bugs] [Bug 18963] Some checkins have been moved to old_issues
 without a returndate
In-Reply-To: <bug-18963-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-18963-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-18963-70-rwDBYBf1VS@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18963

Colin Campbell <colin.campbell at ptfs-europe.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |colin.campbell at ptfs-europe.
                   |                            |com

--- Comment #3 from Colin Campbell <colin.campbell at ptfs-europe.com> ---
I've had it reported by two sites in the last few days they are running
16.11.08 and 17.05.01 looking at the latter case there are thousands of
old_issues with a returndate set to NULL

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Nov 16 14:18:50 2017
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 16 Nov 2017 13:18:50 +0000
Subject: [Koha-bugs] [Bug 19638] New: False positives for 'Update SQL' button
Message-ID: <bug-19638-70@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19638

            Bug ID: 19638
           Summary: False positives for 'Update SQL' button
 Change sponsored?: ---
           Product: Koha
           Version: master
          Hardware: All
                OS: All
            Status: NEW
          Severity: normal
          Priority: P5 - low
         Component: Reports
          Assignee: koha-bugs at lists.koha-community.org
          Reporter: nick at bywatersolutions.com
        QA Contact: testopia at bugs.koha-community.org

bug 17898 tries to help users identify reports affected by the move of marcxml
to the biblio_metadata table, however, the auth_header table still uses the
column name 'marcxml' and so reports as needing updated though it doesn't

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.

From bugzilla-daemon at bugs.koha-community.org  Thu Nov 16 14:19:08 2017
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 16 Nov 2017 13:19:08 +0000
Subject: [Koha-bugs] [Bug 19638] False positives for 'Update SQL' button
In-Reply-To: <bug-19638-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-19638-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-19638-70-BoeLoRpIi0@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19638

Nick Clemens <nick at bywatersolutions.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
         Depends on|                            |17898


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17898
[Bug 17898] Add a way to automatically convert SQL reports
-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Nov 16 14:19:08 2017
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 16 Nov 2017 13:19:08 +0000
Subject: [Koha-bugs] [Bug 17898] Add a way to automatically convert SQL
	reports
In-Reply-To: <bug-17898-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-17898-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-17898-70-VOysIC1h52@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17898

Nick Clemens <nick at bywatersolutions.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Blocks|                            |19638


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19638
[Bug 19638] False positives for 'Update SQL' button
-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Nov 16 14:24:49 2017
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 16 Nov 2017 13:24:49 +0000
Subject: [Koha-bugs] [Bug 19635] OAI-PMH deleted records are now default and
 are listed first
In-Reply-To: <bug-19635-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-19635-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-19635-70-zcqZQ9Axba@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19635

--- Comment #2 from Nick Clemens <nick at bywatersolutions.com> ---
(In reply to Ere Maijala from comment #1)
> As far as I know there's definitely nothing wrong in returning the deleted
> records first. Can you explain in a bit more detail why that is an issue? A
> harvester should just harvest until a resumptionToken is not returned, and
> there's no promise in the protocol that the records are returned in any
> particular order.

I think this came up because we have a site with more deleted than existing
records, this slowed the harvest and they thought something was wrong because
all records were returning deleted.

It may not be 'wrong' but I think it is a change - is there any benefit to
returning deleted first? should/could it be a syspref?

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Nov 16 14:27:27 2017
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 16 Nov 2017 13:27:27 +0000
Subject: [Koha-bugs] [Bug 19234] Add query parameters handling helpers
In-Reply-To: <bug-19234-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-19234-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-19234-70-XaUAl5HmyR@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19234

Julian Maurice <julian.maurice at biblibre.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |julian.maurice at biblibre.com

--- Comment #27 from Julian Maurice <julian.maurice at biblibre.com> ---
Maybe I'm missing the big picture here, but I don't understand why this plugin
is needed.
All it does is separate query parameters so one can pass 'reserved' parameters
to others mojo helpers (at least that's how it's used in bug 19410), but
helpers already have access to those parameters through their first parameter
($c), right ?
And not all helpers will have a use for all reserved parameters, so passing all
those parameters to all helpers is useless, they can retrieve what they need on
their own.

Please explain :)

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Nov 16 14:28:39 2017
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 16 Nov 2017 13:28:39 +0000
Subject: [Koha-bugs] [Bug 19635] OAI-PMH deleted records are now default and
 are listed first
In-Reply-To: <bug-19635-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-19635-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-19635-70-p4eB5wkRNw@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19635

--- Comment #3 from Ere Maijala <ere.maijala at helsinki.fi> ---
(In reply to Nick Clemens from comment #2)
> I think this came up because we have a site with more deleted than existing
> records, this slowed the harvest and they thought something was wrong
> because all records were returning deleted.
> 
> It may not be 'wrong' but I think it is a change - is there any benefit to
> returning deleted first? should/could it be a syspref?

There's no real benefit but there's no downside either as far as I can see.
Since the harvester needs to harvest everything, it doesn't matter if the
deleted records come first or last or interleaved with non-deleted records. I'd
be fine with it being a syspref, but I still can't see a real reason for that.

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.

From bugzilla-daemon at bugs.koha-community.org  Thu Nov 16 14:37:05 2017
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 16 Nov 2017 13:37:05 +0000
Subject: [Koha-bugs] [Bug 19639] New: Are temporary CGI uploads removed too
 late under Plack?
Message-ID: <bug-19639-70@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19639

            Bug ID: 19639
           Summary: Are temporary CGI uploads removed too late under
                    Plack?
 Change sponsored?: ---
           Product: Koha
           Version: master
          Hardware: All
                OS: All
            Status: NEW
          Severity: enhancement
          Priority: P5 - low
         Component: Architecture, internals, and plumbing
          Assignee: koha-bugs at lists.koha-community.org
          Reporter: m.de.rooy at rijksmuseum.nl
        QA Contact: testopia at bugs.koha-community.org

Scripts that run under Plack like tools/inventory that use larger file uploads,
create temporary files that are removed when CGI closes. This may take longer
when we run this under Plack. Is it too long? Could they fill up your tmp
partition?

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.

From bugzilla-daemon at bugs.koha-community.org  Thu Nov 16 14:39:01 2017
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 16 Nov 2017 13:39:01 +0000
Subject: [Koha-bugs] [Bug 19234] Add query parameters handling helpers
In-Reply-To: <bug-19234-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-19234-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-19234-70-gou1yyFydp@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19234

--- Comment #28 from Tom?s Cohen Arazi <tomascohen at gmail.com> ---
(In reply to Julian Maurice from comment #27)
> Maybe I'm missing the big picture here, but I don't understand why this
> plugin is needed.
> All it does is separate query parameters so one can pass 'reserved'
> parameters to others mojo helpers (at least that's how it's used in bug
> 19410), but helpers already have access to those parameters through their
> first parameter ($c), right ?
> And not all helpers will have a use for all reserved parameters, so passing
> all those parameters to all helpers is useless, they can retrieve what they
> need on their own.
> 
> Please explain :)

The idea behind this was:
- To make sure some things are reserved and make it explicit. Have the list in
a single place, make it grow if needed.
- Make parameters extraction algorithm testable, so no need to add thousands of
tests for each endpoint... and ...
- Code less: we don't need to write useless repeating loops extracting
parameters and separating the reserved ones on each controller method.

Koha::Objects->search_for_api is a clear example of how this would improve
productivity when writing endpoints. If you look at how a controller looks like
using it when it is just a wrapper or Koha::Objects-derived classes, it becomes
clear:

sub list {

    my $c = ...

    my $objects = Koha::Blah->search_for_api($c);
    return $c->render( openapi => $objects, status => 200 );

}

In this tiny example, pagination, sorting and query building choice are solved
already using this helpers.


And those who require more flexibility (business endpoints, that are not just
wrappers to Koha::Object(s) derived classes) can just skip using them and do
more interesting stuff.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Nov 16 14:40:51 2017
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 16 Nov 2017 13:40:51 +0000
Subject: [Koha-bugs] [Bug 19575] Use canonical field names and resolve
	aliased fields
In-Reply-To: <bug-19575-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-19575-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-19575-70-Y7odRS0j6V@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19575

David Gustafsson <glasklas at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
           Assignee|koha-bugs at lists.koha-commun |glasklas at gmail.com
                   |ity.org                     |

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Nov 16 14:59:04 2017
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 16 Nov 2017 13:59:04 +0000
Subject: [Koha-bugs] [Bug 18963] Some checkins have been moved to old_issues
 without a returndate
In-Reply-To: <bug-18963-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-18963-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-18963-70-Z28eHbbUQG@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18963

Lucy Vaux-Harvey <lucy.vaux-harvey at ptfs-europe.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |lucy.vaux-harvey at ptfs-europ
                   |                            |e.com

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Nov 16 15:21:58 2017
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 16 Nov 2017 14:21:58 +0000
Subject: [Koha-bugs] [Bug 19640] New: IdRef webservice display is broken
Message-ID: <bug-19640-70@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19640

            Bug ID: 19640
           Summary: IdRef webservice display is broken
 Change sponsored?: ---
           Product: Koha
           Version: master
          Hardware: All
                OS: All
            Status: NEW
          Severity: minor
          Priority: P5 - low
         Component: OPAC
          Assignee: oleonard at myacpl.org
          Reporter: fridolin.somers at biblibre.com
        QA Contact: testopia at bugs.koha-community.org

The OPAC webservice IdRef display is broken.
The call returns results but citations are empty.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Nov 16 15:22:09 2017
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 16 Nov 2017 14:22:09 +0000
Subject: [Koha-bugs] [Bug 19640] IdRef webservice display is broken
In-Reply-To: <bug-19640-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-19640-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-19640-70-rCkjZHXTKU@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19640

Fridolin SOMERS <fridolin.somers at biblibre.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
           Assignee|oleonard at myacpl.org         |fridolin.somers at biblibre.co
                   |                            |m

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Nov 16 15:22:20 2017
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 16 Nov 2017 14:22:20 +0000
Subject: [Koha-bugs] [Bug 19640] IdRef webservice display is broken
In-Reply-To: <bug-19640-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-19640-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-19640-70-Ok3LSmLbXH@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19640

Fridolin SOMERS <fridolin.somers at biblibre.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
         Depends on|                            |8992


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8992
[Bug 8992] Add an interfacing with the idref webservice
-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Nov 16 15:22:20 2017
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 16 Nov 2017 14:22:20 +0000
Subject: [Koha-bugs] [Bug 8992] Add an interfacing with the idref webservice
In-Reply-To: <bug-8992-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-8992-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-8992-70-SVkaCAvTRa@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8992

Fridolin SOMERS <fridolin.somers at biblibre.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Blocks|                            |19640


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19640
[Bug 19640] IdRef webservice display is broken
-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Nov 16 15:22:33 2017
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 16 Nov 2017 14:22:33 +0000
Subject: [Koha-bugs] [Bug 19640] IdRef webservice display is broken
In-Reply-To: <bug-19640-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-19640-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-19640-70-JTdhgdQd34@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19640

Fridolin SOMERS <fridolin.somers at biblibre.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|NEW                         |ASSIGNED

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Nov 16 15:27:10 2017
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 16 Nov 2017 14:27:10 +0000
Subject: [Koha-bugs] [Bug 19410] Koha::Objects needs a ->search_for_api
	method
In-Reply-To: <bug-19410-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-19410-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-19410-70-J9pQ46X8d0@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19410

Julian Maurice <julian.maurice at biblibre.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |julian.maurice at biblibre.com

--- Comment #8 from Julian Maurice <julian.maurice at biblibre.com> ---
It feels like search_for_api would fit better as a Mojo helper, given that it
mostly call other helpers :

    $vendors = $c->search('Koha::Acquisition::Booksellers');

What do you think ?

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Nov 16 15:28:52 2017
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 16 Nov 2017 14:28:52 +0000
Subject: [Koha-bugs] [Bug 19640] IdRef webservice display is broken
In-Reply-To: <bug-19640-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-19640-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-19640-70-AfQTEDJ70U@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19640

--- Comment #1 from Fridolin SOMERS <fridolin.somers at biblibre.com> ---
Created attachment 69181
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=69181&action=edit
Display of IdRef broken

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Nov 16 15:58:55 2017
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 16 Nov 2017 14:58:55 +0000
Subject: [Koha-bugs] [Bug 19640] IdRef webservice display is broken
In-Reply-To: <bug-19640-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-19640-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-19640-70-eyfJNvK4aN@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19640

Fridolin SOMERS <fridolin.somers at biblibre.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|ASSIGNED                    |Needs Signoff
   Patch complexity|---                         |Small patch

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Nov 16 15:58:58 2017
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 16 Nov 2017 14:58:58 +0000
Subject: [Koha-bugs] [Bug 19640] IdRef webservice display is broken
In-Reply-To: <bug-19640-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-19640-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-19640-70-9K2RezzJLN@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19640

--- Comment #2 from Fridolin SOMERS <fridolin.somers at biblibre.com> ---
Created attachment 69182
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=69182&action=edit
Bug 19640: fix OPAC IdRef webservice display

The OPAC webservice IdRef display was broken.
The call returns results but citations where empty.
Maybe the webservice has changed.

This patch corrects the fetch of datas in result.
Also fixes a small HTML missing tag tr.
Also adds a comment with link to official doc :
http://documentation.abes.fr/aideidrefdeveloppeur/index.html#MicroWebBiblio

Test plan :
1) Enable system preference IdRef
2) Choose an existing PPN like 032581270
3) Look result on : https://www.idref.fr/services/biblio/032581270.json
4) Call in OPAC website : /cgi-bin/koha/opac-idref.pl?unimarc3=032581270
5) Without patch you see only one role containing empty rows
6) With patch you see all roles with correct rows

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Nov 16 16:21:20 2017
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 16 Nov 2017 15:21:20 +0000
Subject: [Koha-bugs] [Bug 19634] Advanced editor - Rancor - error in display
 of macro editor in firefox
In-Reply-To: <bug-19634-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-19634-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-19634-70-NINnxV8FOC@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19634

Ed Veal <eveal at mckinneytexas.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |eveal at mckinneytexas.org

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Nov 16 16:45:12 2017
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 16 Nov 2017 15:45:12 +0000
Subject: [Koha-bugs] [Bug 19575] Use canonical field names and resolve
	aliased fields
In-Reply-To: <bug-19575-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-19575-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-19575-70-MwGdc9iOr3@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19575

--- Comment #7 from David Gustafsson <glasklas at gmail.com> ---
Think I have been looking at the Zebra-mapping configuration in the wrong place
(this old config, not biblio-koha-indexdefs.xml). I will go through the mapping
changes one more time using this as reference instead.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Nov 16 17:11:58 2017
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 16 Nov 2017 16:11:58 +0000
Subject: [Koha-bugs] [Bug 19521] Partial fine payment is not working with
 comma decimal separator
In-Reply-To: <bug-19521-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-19521-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-19521-70-LLl5Spn005@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19521

--- Comment #7 from Fridolin SOMERS <fridolin.somers at biblibre.com> ---
(In reply to S?verine Queune from comment #6)
> (In reply to Fridolin SOMERS from comment #3)
> > Duplicate of Bug 18723 ?
> 
> It is!
> We don't use the fee feature so I didn't notice it occurred in an other
> module than Acquisitions.

Koha Team Lyon 3 are you ok ?
If yes mark as Duplicate.

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Nov 16 17:59:33 2017
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 16 Nov 2017 16:59:33 +0000
Subject: [Koha-bugs] [Bug 19603] Move admin templates JavaScript to the
 footer: Patrons and circulation
In-Reply-To: <bug-19603-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-19603-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-19603-70-Jmuc628FdI@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19603

Owen Leonard <oleonard at myacpl.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Blocks|                            |19641


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19641
[Bug 19641] Move patron templates to the footer
-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Nov 16 17:59:33 2017
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 16 Nov 2017 16:59:33 +0000
Subject: [Koha-bugs] [Bug 19641] New: Move patron templates to the footer
Message-ID: <bug-19641-70@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19641

            Bug ID: 19641
           Summary: Move patron templates to the footer
 Change sponsored?: ---
           Product: Koha
           Version: master
          Hardware: All
                OS: All
            Status: ASSIGNED
          Severity: enhancement
          Priority: P5 - low
         Component: Templates
          Assignee: oleonard at myacpl.org
          Reporter: oleonard at myacpl.org
        QA Contact: testopia at bugs.koha-community.org
                CC: jonathan.druart at bugs.koha-community.org,
                    nick at bywatersolutions.com, simon.pouchol at biblibre.com,
                    testopia at bugs.koha-community.org
        Depends on: 19603, 19608
            Blocks: 17858

In order to conform to best practices for performance staff client template
javascript should be in the footer instead of the header.

This patch will do so for patron module templates.


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17858
[Bug 17858] Omnibus: Move staff client JavaScript to the footer
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19603
[Bug 19603] Move admin templates JavaScript to the footer: Patrons and
circulation
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19608
[Bug 19608] Move admin templates JavaScript to the footer: The rest
-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Nov 16 17:59:33 2017
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 16 Nov 2017 16:59:33 +0000
Subject: [Koha-bugs] [Bug 19608] Move admin templates JavaScript to the
	footer: The rest
In-Reply-To: <bug-19608-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-19608-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-19608-70-ZBa9trRPNu@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19608

Owen Leonard <oleonard at myacpl.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Blocks|                            |19641


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19641
[Bug 19641] Move patron templates to the footer
-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Nov 16 17:59:33 2017
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 16 Nov 2017 16:59:33 +0000
Subject: [Koha-bugs] [Bug 17858] Omnibus: Move staff client JavaScript to
	the footer
In-Reply-To: <bug-17858-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-17858-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-17858-70-mHDQYzy4pL@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17858

Owen Leonard <oleonard at myacpl.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
         Depends on|                            |19641


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19641
[Bug 19641] Move patron templates to the footer
-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Nov 16 18:08:42 2017
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 16 Nov 2017 17:08:42 +0000
Subject: [Koha-bugs] [Bug 19642] New: If autoMemberNum is enabled,
 we should just ignore cardnumber entry in BorrowerMandatoryField
Message-ID: <bug-19642-70@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19642

            Bug ID: 19642
           Summary: If autoMemberNum is enabled, we should just ignore
                    cardnumber entry in BorrowerMandatoryField
 Change sponsored?: ---
           Product: Koha
           Version: master
          Hardware: All
                OS: All
            Status: NEW
          Severity: normal
          Priority: P5 - low
         Component: Patrons
          Assignee: koha-bugs at lists.koha-community.org
          Reporter: nick at bywatersolutions.com
        QA Contact: testopia at bugs.koha-community.org
                CC: gmcharlt at gmail.com, kyle.m.hall at gmail.com

Bug 19225 proposes a warning for users that the config is wrong.

I propose instead, we should just ignore that field if automembernum is enabled
(since it autocalculates and becomes mandatory

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Nov 16 18:09:22 2017
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 16 Nov 2017 17:09:22 +0000
Subject: [Koha-bugs] [Bug 19642] If autoMemberNum is enabled,
 we should just ignore cardnumber entry in BorrowerMandatoryField
In-Reply-To: <bug-19642-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-19642-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-19642-70-cNmC79fsH9@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19642

Nick Clemens <nick at bywatersolutions.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
           See Also|                            |https://bugs.koha-community
                   |                            |.org/bugzilla3/show_bug.cgi
                   |                            |?id=19225

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Nov 16 18:09:22 2017
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 16 Nov 2017 17:09:22 +0000
Subject: [Koha-bugs] [Bug 19225] Warn on About page regarding sysprefs
 autoMemberNum and BorrowerMandatoryField
In-Reply-To: <bug-19225-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-19225-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-19225-70-CmNkOncWwk@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19225

Nick Clemens <nick at bywatersolutions.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
           See Also|                            |https://bugs.koha-community
                   |                            |.org/bugzilla3/show_bug.cgi
                   |                            |?id=19642

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.

From bugzilla-daemon at bugs.koha-community.org  Thu Nov 16 18:43:09 2017
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 16 Nov 2017 17:43:09 +0000
Subject: [Koha-bugs] [Bug 19622] Stage MARC records pagination
In-Reply-To: <bug-19622-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-19622-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-19622-70-tsMb9lYgbP@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19622

Ed Veal <eveal at mckinneytexas.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |eveal at mckinneytexas.org

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Nov 16 18:53:10 2017
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 16 Nov 2017 17:53:10 +0000
Subject: [Koha-bugs] [Bug 19643] New: Pagination buttons on staged marc
 management are stacking instead of inline
Message-ID: <bug-19643-70@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19643

            Bug ID: 19643
           Summary: Pagination buttons on staged marc management are
                    stacking instead of inline
 Change sponsored?: ---
           Product: Koha
           Version: master
          Hardware: All
                OS: All
            Status: NEW
          Severity: enhancement
          Priority: P5 - low
         Component: Tools
          Assignee: koha-bugs at lists.koha-community.org
          Reporter: nick at bywatersolutions.com
        QA Contact: testopia at bugs.koha-community.org

To recreate:

1 - Stage 25+ files for import
2 - View staged marc management
3 - Note button display is incorrect

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Nov 16 18:54:01 2017
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 16 Nov 2017 17:54:01 +0000
Subject: [Koha-bugs] [Bug 19643] Pagination buttons on staged marc
 management are stacking instead of inline
In-Reply-To: <bug-19643-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-19643-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-19643-70-kZQG1fFkdl@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19643

Nick Clemens <nick at bywatersolutions.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |michael at bywatersolutions.co
                   |                            |m, oleonard at myacpl.org

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Nov 16 19:01:31 2017
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 16 Nov 2017 18:01:31 +0000
Subject: [Koha-bugs] [Bug 19643] Pagination buttons on staged marc
 management are stacking instead of inline
In-Reply-To: <bug-19643-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-19643-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-19643-70-RrxUoJDPLV@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19643

--- Comment #1 from Michael Cabus <michael at bywatersolutions.com> ---
This CSS can help

div.pages {
    margin: .5em 0;
    display: flex;
    flex-wrap: wrap;
}

.pages .nav {
    margin-bottom: 10px;
}

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Nov 16 19:02:10 2017
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 16 Nov 2017 18:02:10 +0000
Subject: [Koha-bugs] [Bug 19626] Database update for bug 12063 incorrectly
 calculates expirationdate for holds
In-Reply-To: <bug-19626-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-19626-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-19626-70-ymo0nCEcLJ@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19626

Nick Clemens <nick at bywatersolutions.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Failed QA                   |Needs Signoff

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Nov 16 19:02:13 2017
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 16 Nov 2017 18:02:13 +0000
Subject: [Koha-bugs] [Bug 19626] Database update for bug 12063 incorrectly
 calculates expirationdate for holds
In-Reply-To: <bug-19626-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-19626-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-19626-70-hFzgbVadET@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19626

Nick Clemens <nick at bywatersolutions.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #69152|0                           |1
        is obsolete|                            |

--- Comment #3 from Nick Clemens <nick at bywatersolutions.com> ---
Created attachment 69183
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=69183&action=edit
Bug 19626 - Calculate expiration date for existing holds based on waitingdate

To test:
1 - Have/create a 16.11 instance with some waiting holds
2 - Those holds should not have an expirationdate
3 - Make sure some of the holds are waiting longer than
ReservesMaxPickupDelay
BACKUP THE DB
4 - Upgrade to 17.05 (or later)
5 - Check the expirationdate for the holds
6 - The date wil be in the future (curdate + delay)
7 - Restore DB
8 - Apply patch
9 - Run the upgrade again
10 - expirationdate should now be based on waitingdate

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Nov 16 19:23:00 2017
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 16 Nov 2017 18:23:00 +0000
Subject: [Koha-bugs] [Bug 19644] New: When editing items Tag editor
 [ellipses (...)] by date accessioned is non functional
Message-ID: <bug-19644-70@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19644

            Bug ID: 19644
           Summary: When editing items Tag editor [ellipses (...)] by date
                    accessioned is non functional
 Change sponsored?: ---
           Product: Koha
           Version: 17.05
          Hardware: All
                OS: All
            Status: NEW
          Severity: normal
          Priority: P5 - low
         Component: Cataloging
          Assignee: koha-bugs at lists.koha-community.org
          Reporter: joy at bywatersolutions.com
        QA Contact: testopia at bugs.koha-community.org
                CC: m.de.rooy at rijksmuseum.nl

When editing an item that contains a value in 952$d Date accessioned
(items.dateaccessioned), the 'tag editor' or ... button is non functional.  in
16.11 this button would update the date in the field to today's date. 
Currently it does nothing.

When adding a new item, clicking the ... will populate the dateaccessioned
field with today's date.

1. Edit Items
2. if item has value in 'd' subfield, click the ellipses ...
3. nothing will happen (Note: the field can still be manually edited)
4. if the item has no value in 'd' subfield click the ellipses ...
5. field will autopopulate with today's date.

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.

From bugzilla-daemon at bugs.koha-community.org  Thu Nov 16 19:34:59 2017
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 16 Nov 2017 18:34:59 +0000
Subject: [Koha-bugs] [Bug 19644] When editing items Tag editor [ellipses
 (...)] by date accessioned is non functional
In-Reply-To: <bug-19644-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-19644-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-19644-70-xriPwkGpNV@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19644

Owen Leonard <oleonard at myacpl.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|NEW                         |RESOLVED
         Resolution|---                         |DUPLICATE

--- Comment #1 from Owen Leonard <oleonard at myacpl.org> ---


*** This bug has been marked as a duplicate of bug 19595 ***

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Nov 16 19:34:59 2017
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 16 Nov 2017 18:34:59 +0000
Subject: [Koha-bugs] [Bug 19595] Clicking plugin link does not fill item's
 date acquired field
In-Reply-To: <bug-19595-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-19595-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-19595-70-xsnx9CRSRC@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19595

Owen Leonard <oleonard at myacpl.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |joy at bywatersolutions.com

--- Comment #10 from Owen Leonard <oleonard at myacpl.org> ---
*** Bug 19644 has been marked as a duplicate of this bug. ***

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Nov 16 19:52:56 2017
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 16 Nov 2017 18:52:56 +0000
Subject: [Koha-bugs] [Bug 18731] CRUD for acquisition orders
In-Reply-To: <bug-18731-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-18731-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-18731-70-9pJTU1UlZM@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18731

--- Comment #3 from Tom?s Cohen Arazi <tomascohen at gmail.com> ---
Created attachment 69185
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=69185&action=edit
Bug 18731: OpenAPI definitions

This patch introduces the OpenAPI definitions required for the orders
endpoint. It adds query parameters definitions for the reserved params:

- _match
- _order_by
- _page
- _per_page

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Nov 16 19:52:52 2017
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 16 Nov 2017 18:52:52 +0000
Subject: [Koha-bugs] [Bug 18731] CRUD for acquisition orders
In-Reply-To: <bug-18731-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-18731-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-18731-70-MrLnFSuVSo@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18731

--- Comment #2 from Tom?s Cohen Arazi <tomascohen at gmail.com> ---
Created attachment 69184
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=69184&action=edit
Bug 18731: WIP /acquisitions/orders endpoint

This patches implement the /acquisitions/orders endpoint.
It uses the new pagination and query parsing plugins.

Sponsored-by: Camden County

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Nov 16 20:16:38 2017
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 16 Nov 2017 19:16:38 +0000
Subject: [Koha-bugs] [Bug 19643] Pagination buttons on staged marc
 management are stacking instead of inline
In-Reply-To: <bug-19643-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-19643-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-19643-70-Q0QPcMSDgg@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19643

Owen Leonard <oleonard at myacpl.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
           Assignee|koha-bugs at lists.koha-commun |oleonard at myacpl.org
                   |ity.org                     |
             Status|NEW                         |ASSIGNED

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.

From bugzilla-daemon at bugs.koha-community.org  Thu Nov 16 20:17:01 2017
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 16 Nov 2017 19:17:01 +0000
Subject: [Koha-bugs] [Bug 19643] Pagination buttons on staged marc
 management are stacking instead of inline
In-Reply-To: <bug-19643-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-19643-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-19643-70-6Qj4t5QABy@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19643

Owen Leonard <oleonard at myacpl.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
           Severity|enhancement                 |normal

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Nov 16 20:27:52 2017
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 16 Nov 2017 19:27:52 +0000
Subject: [Koha-bugs] [Bug 19643] Pagination buttons on staged marc
 management are stacking instead of inline
In-Reply-To: <bug-19643-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-19643-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-19643-70-4AVRUPBfHX@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19643

Owen Leonard <oleonard at myacpl.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
   Patch complexity|---                         |Trivial patch
             Status|ASSIGNED                    |Needs Signoff

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Nov 16 20:27:54 2017
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 16 Nov 2017 19:27:54 +0000
Subject: [Koha-bugs] [Bug 19643] Pagination buttons on staged marc
 management are stacking instead of inline
In-Reply-To: <bug-19643-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-19643-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-19643-70-CzRPKrFWkp@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19643

--- Comment #2 from Owen Leonard <oleonard at myacpl.org> ---
Created attachment 69186
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=69186&action=edit
Bug 19643: Pagination buttons on staged marc management are stacking instead of
inline

This patch modifies the template for staged MARC import management to
correct a problem with the style of pagination links.

To test you must have more than 25 staged imports. Go to Tools -> Staged
MARC management. The pagination links, both at the top and the bottom,
should look correct (use multi-page SQL report results for reference).

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Nov 17 00:28:35 2017
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 16 Nov 2017 23:28:35 +0000
Subject: [Koha-bugs] [Bug 19593] [16.11.x] "Delete vendor" button is always
	set
In-Reply-To: <bug-19593-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-19593-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-19593-70-igDia7AGHI@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19593

Katrin Fischer <katrin.fischer at bsz-bw.de> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|NEW                         |Needs Signoff

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Nov 17 02:10:00 2017
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 17 Nov 2017 01:10:00 +0000
Subject: [Koha-bugs] [Bug 19643] Pagination buttons on staged marc
 management are stacking instead of inline
In-Reply-To: <bug-19643-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-19643-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-19643-70-m7OW5ncZ4O@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19643

Nick Clemens <nick at bywatersolutions.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Needs Signoff               |Signed Off

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Nov 17 02:10:02 2017
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 17 Nov 2017 01:10:02 +0000
Subject: [Koha-bugs] [Bug 19643] Pagination buttons on staged marc
 management are stacking instead of inline
In-Reply-To: <bug-19643-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-19643-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-19643-70-17AkSL7ZyG@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19643

Nick Clemens <nick at bywatersolutions.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #69186|0                           |1
        is obsolete|                            |

--- Comment #3 from Nick Clemens <nick at bywatersolutions.com> ---
Created attachment 69187
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=69187&action=edit
Bug 19643: Pagination buttons on staged marc management are stacking instead of
inline

This patch modifies the template for staged MARC import management to
correct a problem with the style of pagination links.

To test you must have more than 25 staged imports. Go to Tools -> Staged
MARC management. The pagination links, both at the top and the bottom,
should look correct (use multi-page SQL report results for reference).

Signed-off-by: Nick Clemens <nick at bywatersolutions.com>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Nov 17 05:43:06 2017
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 17 Nov 2017 04:43:06 +0000
Subject: [Koha-bugs] [Bug 14759] Replacement for Text::Unaccent
In-Reply-To: <bug-14759-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-14759-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-14759-70-36FrqOgsSY@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14759

--- Comment #26 from David Cook <dcook at prosentient.com.au> ---
(In reply to Colin Campbell from comment #25)
> Text::Unaccent does not build on 64bit systems, the tests fail because of
> errors in the ccode. There has been a patch for that for four years but it
> looks like the upstream code is moribund. If you look at the test results it
> now fails on all linux test builds. The module has not been kept up to date
> to handle modern perl strings. I think the debian version may be patched to
> fix the bug in 64bit tests but it is buggy and should not be relied on.
> Suggest moving to Text::Unaccent::PurPerl be prioritized

Where are we using Text::Unaccent? Is it still just in userid strings?

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Nov 17 09:20:29 2017
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 17 Nov 2017 08:20:29 +0000
Subject: [Koha-bugs] [Bug 19637] jsPrintSetup not supported in Firefox
	Quantum
In-Reply-To: <bug-19637-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-19637-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-19637-70-vELt6tN1vs@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19637

Josef Moravec <josef.moravec at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |black23 at gmail.com,
                   |                            |josef.moravec at gmail.com,
                   |                            |rbit at rbit.cz

--- Comment #1 from Josef Moravec <josef.moravec at gmail.com> ---
And it looks like the needed api will not be implemented by Mozilla...

But there are some possible solutions which could replace the jsPrintSetup in
Koha:

https://github.com/Tecdiary/ppp
https://github.com/shantanubhadoria/perl-Printer-ESCPOS
https://github.com/WICG/webusb (Chrome 61+)
http://usbip.sourceforge.net/
https://github.com/mike42/escpos-php
https://www.savapage.org/
https://qz.io/

I think it could be nice to have a solution working in Firefox and
Chrome/Chromium, at least...

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.

From bugzilla-daemon at bugs.koha-community.org  Fri Nov 17 09:29:22 2017
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 17 Nov 2017 08:29:22 +0000
Subject: [Koha-bugs] [Bug 19626] Database update for bug 12063 incorrectly
 calculates expirationdate for holds
In-Reply-To: <bug-19626-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-19626-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-19626-70-yoX9nWiznO@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19626

Marcel de Rooy <m.de.rooy at rijksmuseum.nl> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Needs Signoff               |Signed Off

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Nov 17 09:29:25 2017
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 17 Nov 2017 08:29:25 +0000
Subject: [Koha-bugs] [Bug 19626] Database update for bug 12063 incorrectly
 calculates expirationdate for holds
In-Reply-To: <bug-19626-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-19626-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-19626-70-awScGJtaIy@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19626

Marcel de Rooy <m.de.rooy at rijksmuseum.nl> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #69183|0                           |1
        is obsolete|                            |

--- Comment #4 from Marcel de Rooy <m.de.rooy at rijksmuseum.nl> ---
Created attachment 69188
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=69188&action=edit
Bug 19626 - Calculate expiration date for existing holds based on waitingdate

To test:
1 - Have/create a 16.11 instance with some waiting holds
2 - Those holds should not have an expirationdate
3 - Make sure some of the holds are waiting longer than
ReservesMaxPickupDelay
BACKUP THE DB
4 - Upgrade to 17.05 (or later)
5 - Check the expirationdate for the holds
6 - The date wil be in the future (curdate + delay)
7 - Restore DB
8 - Apply patch
9 - Run the upgrade again
10 - expirationdate should now be based on waitingdate

Signed-off-by: Marcel de Rooy <m.de.rooy at rijksmuseum.nl>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Nov 17 09:29:29 2017
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 17 Nov 2017 08:29:29 +0000
Subject: [Koha-bugs] [Bug 19626] Database update for bug 12063 incorrectly
 calculates expirationdate for holds
In-Reply-To: <bug-19626-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-19626-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-19626-70-4LfhbL1i3D@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19626

--- Comment #5 from Marcel de Rooy <m.de.rooy at rijksmuseum.nl> ---
Created attachment 69189
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=69189&action=edit
Bug 19626: (QA follow-up) Small optimization

We are only using $calendar when the pref is set.
Date calculation can be moved in if-else structure.

Signed-off-by: Marcel de Rooy <m.de.rooy at rijksmuseum.nl>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Nov 17 09:30:22 2017
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 17 Nov 2017 08:30:22 +0000
Subject: [Koha-bugs] [Bug 19626] Database update for bug 12063 incorrectly
 calculates expirationdate for holds
In-Reply-To: <bug-19626-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-19626-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-19626-70-Qbqd7V3u3i@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19626

Marcel de Rooy <m.de.rooy at rijksmuseum.nl> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Signed Off                  |Passed QA

--- Comment #6 from Marcel de Rooy <m.de.rooy at rijksmuseum.nl> ---
Not sure if this really is a major btw.
Combining SO and QA in one step.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Nov 17 10:00:15 2017
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 17 Nov 2017 09:00:15 +0000
Subject: [Koha-bugs] [Bug 18833] plugin unimarc_field_210c pagination error
In-Reply-To: <bug-18833-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-18833-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-18833-70-xOWpCCXgYr@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18833

Marcel de Rooy <m.de.rooy at rijksmuseum.nl> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Signed Off                  |Passed QA

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Nov 17 10:00:17 2017
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 17 Nov 2017 09:00:17 +0000
Subject: [Koha-bugs] [Bug 18833] plugin unimarc_field_210c pagination error
In-Reply-To: <bug-18833-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-18833-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-18833-70-VeBDwiwTZb@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18833

Marcel de Rooy <m.de.rooy at rijksmuseum.nl> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #68295|0                           |1
        is obsolete|                            |

--- Comment #3 from Marcel de Rooy <m.de.rooy at rijksmuseum.nl> ---
Created attachment 69190
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=69190&action=edit
Bug 18833 - plugin unimarc_field_210c pagination error

In plugin unimarc_field_210c, the editors search results have pagination.
First page works but not other pages.

The main problem whas mainly because $startfrom var was missused. It is defined
in C4::Output::pagination_bar as page number.
This patch corrects by using a $offset var.
Also removes dead code, obsoleted by using C4::Output::pagination_bar.
Also changes hardcoded results per page from 19 to 20.

Test plan :
- Use UNIMARC catalogue
- Define in framework value builder unimarc_field_210c on 210$c
- Create autority type EDITORS with heading 200$b
- Create 22 authorities of that type
- Index those new authorities
- Create a new biblio record
- Click on 210$c plugin
- Click on "Search"
- You see 20 results
- Click on page 2
=> Without patch you get empty table
=> With patch you get 2 results
- Check that you see "Results 21 to 22 of 22"
- Delete 2 autorities and retest

Works as intended.

Signed-off-by: Simon Pouchol <simon.pouchol at biblibre.com>

Signed-off-by: Marcel de Rooy <m.de.rooy at rijksmuseum.nl>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Nov 17 10:02:07 2017
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 17 Nov 2017 09:02:07 +0000
Subject: [Koha-bugs] [Bug 18833] plugin unimarc_field_210c pagination error
In-Reply-To: <bug-18833-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-18833-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-18833-70-8Os6TT1iJr@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18833

Marcel de Rooy <m.de.rooy at rijksmuseum.nl> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
         QA Contact|testopia at bugs.koha-communit |m.de.rooy at rijksmuseum.nl
                   |y.org                       |
   Patch complexity|Trivial patch               |Small patch

--- Comment #4 from Marcel de Rooy <m.de.rooy at rijksmuseum.nl> ---
Code looks good to me. Not tested; two UNIMARC users already confirm it works.
No string changes.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Nov 17 10:02:52 2017
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 17 Nov 2017 09:02:52 +0000
Subject: [Koha-bugs] [Bug 19626] Database update for bug 12063 incorrectly
 calculates expirationdate for holds
In-Reply-To: <bug-19626-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-19626-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-19626-70-DWohv5xTYg@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19626

Marcel de Rooy <m.de.rooy at rijksmuseum.nl> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
         QA Contact|testopia at bugs.koha-communit |m.de.rooy at rijksmuseum.nl
                   |y.org                       |

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Nov 17 12:13:46 2017
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 17 Nov 2017 11:13:46 +0000
Subject: [Koha-bugs] [Bug 18017] [Unimarc] Importing biblios from Z39.50
 servers duplicates related authorities
In-Reply-To: <bug-18017-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-18017-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-18017-70-r6RgwEeM9c@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18017

Alex Arnaud <alex.arnaud at biblibre.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Failed QA                   |Needs Signoff

--- Comment #4 from Alex Arnaud <alex.arnaud at biblibre.com> ---
Full test plan is:

BiblioAddsAuthorities ON
AutoCreateAuthorities ON

1) replace
/koha_conf_dir/etc/zebradb/marc_defs/unimarc/authorities/authority-koha-indexdefs.xml
   with
/koha_clone/etc/zebradb/marc_defs/unimarc/authorities/authority-koha-indexdefs.xml
2) replace
/koha_conf_dir/etc/zebradb/marc_defs/unimarc/authorities/authority-zebra-indexdefs.xsl
   with
/koha_clone/etc/zebradb/marc_defs/unimarc/authorities/authority-zebra-indexdefs.xsl
3) reindex authorities,
4) Import Z3950 record and save it : authorities are created
5) Import the same record again, when saving say it is not a duplicate : 
Without the patch : new authorities (duplicates) are created for the same
values
With the patch : new record should be linked with existing authorities

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Nov 17 12:17:06 2017
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 17 Nov 2017 11:17:06 +0000
Subject: [Koha-bugs] [Bug 18963] Some checkins have been moved to old_issues
 without a returndate
In-Reply-To: <bug-18963-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-18963-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-18963-70-neeLCf8odl@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18963

Ray Delahunty <r.delahunty at arts.ac.uk> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |r.delahunty at arts.ac.uk

--- Comment #4 from Ray Delahunty <r.delahunty at arts.ac.uk> ---
Not sure if these comments help but?

This problem is a very serious one for us as from Wednesday 1 November
absolutely zero lines in the old_issues table have the returndate field
populated. And overall, we now have upwards of 20,000 items showing up in the
Circulation History (both OPAC and Koha intranet) as ?issued? when in reality
they have long since been returned (including a period when we were on 16.05).
This is very confusing for both staff and students. The problem appears to have
got gradually worse over many months. I ran the simple query SELECT itemnumber,
timestamp, returndate FROM old_issues WHERE timestamp > '2015-08-30%' ORDER BY
timestamp ASC and browsed down for empty returndate fields. (UAL migrated 3
million lines of historic loans from out old LMS and want to review the problem
from Day 1 of Koha only, hence the August 2015 limit).

At first I see a small number of problems appearing after the end of many of
the day?s opening hours. Even back on 16.05 in June of this year we have
transactions occurring in the middle of the night when the library is closed. I
have no idea where these are coming from- the building is locked so users don?t
have access even to the 3M returns chute (use of which would remove the item
from the account). Oddly a lot of the lines are all timestamped in the 23:xx
range and all are without a returndate.  

The problem gets steadily worse as the weeks go by, and my take on it is that
the problem explodes in 17.05.01 (8/2017 for us) where the count of the lines
rockets. By the 4th October we are seeing upwards of 100 lines appearing, all
timestamped in the 22:xx range, and all with no returndate. The library is
closed at that time. And by 30th we have 1,205 lines with a timestamp (all now
in *both* the 22:xx and 23:xx ranges) but no returndate, again at a time when
the building is locked up for the night. The last line in the table with a
returndate in is Tuesday 31 October at 21:55 when the library physically
closed. Lines in the table are timestamped all through the (now 24 hour a day)
opening time, but there are no return dates. We have currently 15,000
sequential lines without the returndate and this is making Circulation History
a mess. 

Would a crude fix be to copy the timestamp over the returndate where the return
date is empty? I can of course add the 737,000 line spreadsheet containing the
data I have reviewed if necessary.

Ray Delahunty
University of the Arts London

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.

From bugzilla-daemon at bugs.koha-community.org  Fri Nov 17 12:59:36 2017
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 17 Nov 2017 11:59:36 +0000
Subject: [Koha-bugs] [Bug 18958] If patron has multiple record level holds
 on one record transferring first hold causes next hold to become item level
In-Reply-To: <bug-18958-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-18958-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-18958-70-iWTUtWWE16@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18958

Marcel de Rooy <m.de.rooy at rijksmuseum.nl> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |m.de.rooy at rijksmuseum.nl
             Status|Signed Off                  |Patch doesn't apply

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Nov 17 13:01:33 2017
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 17 Nov 2017 12:01:33 +0000
Subject: [Koha-bugs] [Bug 14784] Missing checkin message for debarred
 patrons when issuing rules ' fine days = 0'
In-Reply-To: <bug-14784-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-14784-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-14784-70-HUxuoZ7XHC@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14784

Marcel de Rooy <m.de.rooy at rijksmuseum.nl> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |m.de.rooy at rijksmuseum.nl

--- Comment #24 from Marcel de Rooy <m.de.rooy at rijksmuseum.nl> ---
QA: Looking here now

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Nov 17 13:20:10 2017
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 17 Nov 2017 12:20:10 +0000
Subject: [Koha-bugs] [Bug 19563] Generation of sort_fields uses incorrect
	condition
In-Reply-To: <bug-19563-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-19563-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-19563-70-uALdxp82Hc@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19563

Nick Clemens <nick at bywatersolutions.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|NEW                         |Needs Signoff

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Nov 17 13:20:12 2017
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 17 Nov 2017 12:20:12 +0000
Subject: [Koha-bugs] [Bug 19563] Generation of sort_fields uses incorrect
	condition
In-Reply-To: <bug-19563-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-19563-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-19563-70-Us0MNlnX4E@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19563

--- Comment #2 from Nick Clemens <nick at bywatersolutions.com> ---
Created attachment 69191
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=69191&action=edit
Bug 19563: Unit tests

To test:
1 - Apply first patch and this patch
2 - prove -v t/db_dependent/Koha_Elasticsearch.t
3 - New tests will fail
4 - Apply followup patch
5 - Tests shuld pass

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Nov 17 13:20:15 2017
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 17 Nov 2017 12:20:15 +0000
Subject: [Koha-bugs] [Bug 19563] Generation of sort_fields uses incorrect
	condition
In-Reply-To: <bug-19563-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-19563-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-19563-70-unXcirojrP@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19563

--- Comment #3 from Nick Clemens <nick at bywatersolutions.com> ---
Created attachment 69192
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=69192&action=edit
Bug 19563: Followup - Restore checking sort variable

This code seems a bit odd, $self->sort_fields()->{$name} is checking if
there is any mapping in ES for a field, so if one marc field in an index
is marked as sortable this will exists. We need to check the individual
marc field to see if it should be added to the sort index here.

If you apply the first patch, reindex, and view a record in es:
curl -XGET 'localhost:9200/koha_kohadev_biblios/data/19/?pretty' | grep
-A 10 author__sort

You will see that 245$c is included in the record without that
additional check

Apply this, reindex again, and that field should not be included

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Nov 17 13:22:33 2017
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 17 Nov 2017 12:22:33 +0000
Subject: [Koha-bugs] [Bug 19563] Generation of sort_fields uses incorrect
	condition
In-Reply-To: <bug-19563-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-19563-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-19563-70-wz9vS2ql0k@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19563

Nick Clemens <nick at bywatersolutions.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |nick at bywatersolutions.com

--- Comment #4 from Nick Clemens <nick at bywatersolutions.com> ---
Hi David,

I added tests and found a problem, I restored the check on the field and that
seems to make things work as expected.

-Nick

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Nov 17 13:30:26 2017
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 17 Nov 2017 12:30:26 +0000
Subject: [Koha-bugs] [Bug 19637] jsPrintSetup not supported in Firefox
	Quantum
In-Reply-To: <bug-19637-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-19637-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-19637-70-H6DsesSJU4@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19637

Marc V?ron <veron at veron.ch> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |veron at veron.ch

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Nov 17 13:32:50 2017
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 17 Nov 2017 12:32:50 +0000
Subject: [Koha-bugs] [Bug 18963] Some checkins have been moved to old_issues
 without a returndate
In-Reply-To: <bug-18963-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-18963-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-18963-70-t4lIpG08nQ@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18963

--- Comment #5 from Jonathan Druart <jonathan.druart at bugs.koha-community.org> ---
As notes on this page:
https://wiki.koha-community.org/wiki/DBMS_auto_increment_fix and annonced for
months now, the only safe versions are :

After 17.05.02, 16.11.10, 16.05.15 (included)

You should upgrade ASAP

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Nov 17 13:32:53 2017
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 17 Nov 2017 12:32:53 +0000
Subject: [Koha-bugs] [Bug 19637] jsPrintSetup not supported in Firefox
	Quantum
In-Reply-To: <bug-19637-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-19637-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-19637-70-oDtWsp9ck7@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19637

--- Comment #2 from Marc V?ron <veron at veron.ch> ---
As a temporary solution see the following from:
https://bugzilla.mozilla.org/show_bug.cgi?id=1385827
(Bug was filed by the author of JSPrintSetup afaik)

---Snip---
For all that need the functionality NOW: its better to install the current ESR
version ( https://www.mozilla.org/en-US/firefox/organizations/faq/ ) instead of
going back to version 56 and turning off updates:
https://www.mozilla.org/en-US/firefox/organizations/faq/
---End snip---

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.

From bugzilla-daemon at bugs.koha-community.org  Fri Nov 17 13:54:32 2017
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 17 Nov 2017 12:54:32 +0000
Subject: [Koha-bugs] [Bug 19646] New: value_builder marc21_linking_section
 template is broken
Message-ID: <bug-19646-70@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19646

            Bug ID: 19646
           Summary: value_builder marc21_linking_section template is
                    broken
 Change sponsored?: ---
           Product: Koha
           Version: master
          Hardware: All
                OS: All
            Status: NEW
          Severity: normal
          Priority: P5 - low
         Component: Cataloging
          Assignee: koha-bugs at lists.koha-community.org
          Reporter: fridolin.somers at biblibre.com
        QA Contact: testopia at bugs.koha-community.org
                CC: m.de.rooy at rijksmuseum.nl

When using marc21_linking_section cataloging plugin, you get the error :
Template process failed: undef error - The method selected is not covered by
tests! at /home/koha/src/C4/Templates.pm line 122.

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.

From bugzilla-daemon at bugs.koha-community.org  Fri Nov 17 13:56:45 2017
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 17 Nov 2017 12:56:45 +0000
Subject: [Koha-bugs] [Bug 19646] value_builder marc21_linking_section
	template is broken
In-Reply-To: <bug-19646-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-19646-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-19646-70-XkJM7kmuuU@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19646

Fridolin SOMERS <fridolin.somers at biblibre.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
           Assignee|koha-bugs at lists.koha-commun |fridolin.somers at biblibre.co
                   |ity.org                     |m
             Status|NEW                         |ASSIGNED

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Nov 17 14:07:46 2017
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 17 Nov 2017 13:07:46 +0000
Subject: [Koha-bugs] [Bug 19646] value_builder marc21_linking_section
	template is broken
In-Reply-To: <bug-19646-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-19646-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-19646-70-EE3tm74Ub3@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19646

Fridolin SOMERS <fridolin.somers at biblibre.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
   Patch complexity|---                         |Trivial patch
             Status|ASSIGNED                    |Needs Signoff

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Nov 17 14:07:49 2017
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 17 Nov 2017 13:07:49 +0000
Subject: [Koha-bugs] [Bug 19646] value_builder marc21_linking_section
	template is broken
In-Reply-To: <bug-19646-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-19646-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-19646-70-0b86IAJQ0B@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19646

--- Comment #1 from Fridolin SOMERS <fridolin.somers at biblibre.com> ---
Created attachment 69193
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=69193&action=edit
Bug 19646: fix value_builder marc21_linking_section template

When using marc21_linking_section cataloging plugin, you get the error :
Template process failed: undef error - The method selected is not covered by
tests! at /home/koha/src/C4/Templates.pm line 122.

It commes from [% IF ( itypeloo.selected ) %], selected is not defined in
itypeloo.

This patch removes this condition because all item types are fetched from
database, there is not one selected.
It sets "All item types" as selected.
Also correctes two errors in HTML : ending form and div, "<a_class=" instead of
"<a class="

Test plan :
1) Use a MARC21 database
2) Define marc21_linking_section cataloging plugin in framework, on 773$t for
example
3) Create a new biblio record
4) Click on icon in 773$t
5) Check plugin works fine

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Nov 17 14:18:19 2017
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 17 Nov 2017 13:18:19 +0000
Subject: [Koha-bugs] [Bug 13867] change input in 245$a and 245$c for textarea
In-Reply-To: <bug-13867-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-13867-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-13867-70-OLUdC4YVry@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13867

Patrick Robitaille <patrick.robitaille at collecto.ca> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |patrick.robitaille at collecto
                   |                            |.ca

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Nov 17 14:18:29 2017
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 17 Nov 2017 13:18:29 +0000
Subject: [Koha-bugs] [Bug 14784] Missing checkin message for debarred
 patrons when issuing rules ' fine days = 0'
In-Reply-To: <bug-14784-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-14784-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-14784-70-ISrAPZPLID@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14784

Marcel de Rooy <m.de.rooy at rijksmuseum.nl> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Signed Off                  |BLOCKED

--- Comment #25 from Marcel de Rooy <m.de.rooy at rijksmuseum.nl> ---
Changing status. Comment follows.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Nov 17 14:22:11 2017
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 17 Nov 2017 13:22:11 +0000
Subject: [Koha-bugs] [Bug 19646] value_builder marc21_linking_section
	template is broken
In-Reply-To: <bug-19646-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-19646-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-19646-70-k5bBHpgQhg@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19646

Owen Leonard <oleonard at myacpl.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Needs Signoff               |Signed Off

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Nov 17 14:22:13 2017
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 17 Nov 2017 13:22:13 +0000
Subject: [Koha-bugs] [Bug 19646] value_builder marc21_linking_section
	template is broken
In-Reply-To: <bug-19646-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-19646-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-19646-70-KP6dCKR3hL@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19646

Owen Leonard <oleonard at myacpl.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #69193|0                           |1
        is obsolete|                            |

--- Comment #2 from Owen Leonard <oleonard at myacpl.org> ---
Created attachment 69194
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=69194&action=edit
Bug 19646: fix value_builder marc21_linking_section template

When using marc21_linking_section cataloging plugin, you get the error :
Template process failed: undef error - The method selected is not
covered by tests! at /home/koha/src/C4/Templates.pm line 122.

It commes from [% IF ( itypeloo.selected ) %], selected is not defined
in itypeloo.

This patch removes this condition because all item types are fetched
from database, there is not one selected. It sets "All item types" as
selected. Also correctes two errors in HTML : ending form and div,
"<a_class=" instead of "<a class="

Test plan :
1) Use a MARC21 database
2) Define marc21_linking_section cataloging plugin in framework, on
   773$t for example
3) Create a new biblio record
4) Click on icon in 773$t
5) Check plugin works fine

Signed-off-by: Owen Leonard <oleonard at myacpl.org>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Nov 17 14:31:07 2017
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 17 Nov 2017 13:31:07 +0000
Subject: [Koha-bugs] [Bug 19636] Hold priority changes incorrectly via
	dropdown select
In-Reply-To: <bug-19636-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-19636-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-19636-70-jIDtvRmTzS@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19636

Owen Leonard <oleonard at myacpl.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Needs Signoff               |Signed Off
   Patch complexity|---                         |Small patch

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Nov 17 14:31:09 2017
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 17 Nov 2017 13:31:09 +0000
Subject: [Koha-bugs] [Bug 19636] Hold priority changes incorrectly via
	dropdown select
In-Reply-To: <bug-19636-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-19636-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-19636-70-p7BLDY9Glf@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19636

Owen Leonard <oleonard at myacpl.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #69180|0                           |1
        is obsolete|                            |

--- Comment #2 from Owen Leonard <oleonard at myacpl.org> ---
Created attachment 69195
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=69195&action=edit
Bug 19636: Hold priority changes incorrectly via dropdown select

This patch sorts holds in UI after priority is changed via "Priority"
dropdown.

It fixes confusion where the form is posted and each row is individually
processed one by one - and due to conflict in priority value, the latter
row always gets the chosen value instead of what the user actually might
have wanted to change.

To reproduce:
1. Place 3 holds on a record
2. See existing holds (cgi-bin/koha/reserve/request.pl?biblionumber=XXX)
3. By using the dropdown menu under "Priority" column, change the first
   hold's priority to last (3). Do not touch other priorities.
4. Click Update hold(s)
5. Observe the hold did not get your selected priority 3, but 2 instead.

To test:
1. Apply patch
2. Place 3 holds on a record
3. See existing holds (cgi-bin/koha/reserve/request.pl?biblionumber=XXX)
4. By using the dropdown menu under "Priority" column, change the first
   hold's priority to last (3). Do not touch other priorities.
5. Observe this hold was automatically moved to the last row in the user
   interface.
6. Click Update hold(s)
7. Observe the hold has your selected priority 3.

Signed-off-by: Owen Leonard <oleonard at myacpl.org>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Nov 17 14:33:53 2017
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 17 Nov 2017 13:33:53 +0000
Subject: [Koha-bugs] [Bug 14784] Missing checkin message for debarred
 patrons when issuing rules ' fine days = 0'
In-Reply-To: <bug-14784-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-14784-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-14784-70-0AQWlR0Gvs@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14784

Marcel de Rooy <m.de.rooy at rijksmuseum.nl> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|BLOCKED                     |Failed QA

--- Comment #26 from Marcel de Rooy <m.de.rooy at rijksmuseum.nl> ---
QA Comment:
Thx David for your brave changes. Looks good, still asking some attention.

-        } elsif ( $issue->date_due and $patron->debarred ) {
+        if ( $new_debar == 0 and $patron->debarred ) {
Why do you remove the test on date_due (might be just theoretical)?
Since you change the program flow by changing an elsif into an if, the game may
change here. 
The comment on top is no longer valid at least ("There is no overdue...");
seems ok for the rest.

Variable $is_a_reminder is no longer used.
# if borrower was already debarred but does not get an extra debarment
Your changes make this comment look bad.
Since _debar_user_on_return now seems to return new or extended debarment dates
only, please adjust POD.
In AddReturn adjust varname accordingly (like newdebardate or so )?
You do not need $debardate and $new_debar now; $newdebardate would be enough to
test.

See Comment11 too. We still need additional unit testing.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Nov 17 14:58:05 2017
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 17 Nov 2017 13:58:05 +0000
Subject: [Koha-bugs] [Bug 19640] IdRef webservice display is broken
In-Reply-To: <bug-19640-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-19640-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-19640-70-fqz2D25tbK@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19640

Simon Pouchol <simon.pouchol at biblibre.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #69182|0                           |1
        is obsolete|                            |

--- Comment #3 from Simon Pouchol <simon.pouchol at biblibre.com> ---
Created attachment 69196
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=69196&action=edit
Bug 19640: fix OPAC IdRef webservice display

The OPAC webservice IdRef display was broken.
The call returns results but citations where empty.
Maybe the webservice has changed.

This patch corrects the fetch of datas in result.
Also fixes a small HTML missing tag tr.
Also adds a comment with link to official doc :
http://documentation.abes.fr/aideidrefdeveloppeur/index.html#MicroWebBiblio

Test plan :
1) Enable system preference IdRef
2) Choose an existing PPN like 032581270
3) Look result on : https://www.idref.fr/services/biblio/032581270.json
4) Call in OPAC website : /cgi-bin/koha/opac-idref.pl?unimarc3=032581270
5) Without patch you see only one role containing empty rows
6) With patch you see all roles with correct rows

Signed-off-by: Simon Pouchol <simon.pouchol at biblibre.com>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Nov 17 14:58:50 2017
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 17 Nov 2017 13:58:50 +0000
Subject: [Koha-bugs] [Bug 19640] IdRef webservice display is broken
In-Reply-To: <bug-19640-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-19640-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-19640-70-WtaxNI473f@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19640

Simon Pouchol <simon.pouchol at biblibre.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |simon.pouchol at biblibre.com
             Status|Needs Signoff               |Signed Off

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Nov 17 15:06:33 2017
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 17 Nov 2017 14:06:33 +0000
Subject: [Koha-bugs] [Bug 17005] REST API: add routes to list checkouts
	history
In-Reply-To: <bug-17005-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-17005-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-17005-70-egK7F8rkkD@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17005

Tom?s Cohen Arazi <tomascohen at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Patch doesn't apply         |In Discussion
                 CC|                            |tomascohen at gmail.com

--- Comment #20 from Tom?s Cohen Arazi <tomascohen at gmail.com> ---
This bug reproduces a design issue with our DB structure.

Checkouts and OldCheckouts are the same thing, they've just been splitted for
some reason (which leads to several problems). That said, I think this
functionality should be implemented in /checkouts. And there should be a
checked_in boolean for 'OldCheckouts'.

Once this is actually implemented on the DB, it will be simpler. In the
meantime, we can do it on the controller.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Nov 17 15:07:11 2017
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 17 Nov 2017 14:07:11 +0000
Subject: [Koha-bugs] [Bug 19474] Convert staff client CSS to SCSS
In-Reply-To: <bug-19474-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-19474-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-19474-70-4VPE6CWhG3@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19474

--- Comment #7 from Owen Leonard <oleonard at myacpl.org> ---
Created attachment 69197
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=69197&action=edit
Bug 19474 [follow-up] Convert staff client CSS to SCSS

This patch brings staff-global.scss up to date with changes which have
been recently committed to staff-global.css, specifically ILL module
styles.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Nov 17 15:10:46 2017
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 17 Nov 2017 14:10:46 +0000
Subject: [Koha-bugs] [Bug 19604] Elasticsearch Fixes for
 build_authorities_query for auth searching
In-Reply-To: <bug-19604-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-19604-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-19604-70-YvECm4Jqlg@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19604

Nick Clemens <nick at bywatersolutions.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Failed QA                   |Needs Signoff

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Nov 17 15:10:48 2017
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 17 Nov 2017 14:10:48 +0000
Subject: [Koha-bugs] [Bug 19604] Elasticsearch Fixes for
 build_authorities_query for auth searching
In-Reply-To: <bug-19604-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-19604-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-19604-70-Z22xGOqIQU@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19604

Nick Clemens <nick at bywatersolutions.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #69072|0                           |1
        is obsolete|                            |

--- Comment #3 from Nick Clemens <nick at bywatersolutions.com> ---
Created attachment 69198
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=69198&action=edit
Bug 19604: Elasticsearch Fixes for build_authorities_query for auth searching

To test:
1 - Do some authority searches in Zebra
2 - Switch to ES and repeat, results will vary and some may fail
3 - Apply patch and dependencies
4 - Reindex ES
5 - Repeat searches, they should suceed and results should be similar to
Zebra
6 - Slight differences are okay, but results should (mostly) meet
expectations

A few notes:
We add a 'normalizer' to ensure we get a single token from the heading
indexes, this makes 'starts with' work as expcted
We switch to 'AND' for fields searched from cataloging editor - this
matches Zebra results
We force the '__sort' fields for sorting - if sorting looks wrong try
reducing the heading field to a single subfield - this will need to be
addressed on a future bug (multiple subfields create an array, ES sorts
        those randomly)

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Nov 17 15:10:51 2017
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 17 Nov 2017 14:10:51 +0000
Subject: [Koha-bugs] [Bug 19604] Elasticsearch Fixes for
 build_authorities_query for auth searching
In-Reply-To: <bug-19604-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-19604-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-19604-70-RIyCgtpKCv@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19604

--- Comment #4 from Nick Clemens <nick at bywatersolutions.com> ---
Created attachment 69199
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=69199&action=edit
Bug 19604: Unit tests

1 - Apply previous patches
2 - prove t/db_dependent/Koha/SearchEngine/Elasticsearch/QueryBuilder.t
3 - Should be green
4 - high fives!

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.

From bugzilla-daemon at bugs.koha-community.org  Fri Nov 17 15:13:45 2017
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 17 Nov 2017 14:13:45 +0000
Subject: [Koha-bugs] [Bug 19604] Elasticsearch Fixes for
 build_authorities_query for auth searching
In-Reply-To: <bug-19604-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-19604-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-19604-70-NZf2zQOEcW@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19604

--- Comment #5 from Nick Clemens <nick at bywatersolutions.com> ---
(In reply to David Bourgault from comment #2)
> I did a search for 'me' from the OPAC's Auth search.
> 
> With Zebra I got 1411 results (some, but not all, matching on 'm?')
> With ES I got a single result, in which the word 'Me' was found as-is

I altered the 'contains' search to be a wildcard and break terms - it should be
closer now but won't mirror exactly zebra

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Nov 17 16:00:15 2017
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 17 Nov 2017 15:00:15 +0000
Subject: [Koha-bugs] [Bug 19485] Limiting by title-series (se) broken on ES
In-Reply-To: <bug-19485-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-19485-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-19485-70-Oo7WZoKlaW@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19485

Nick Clemens <nick at bywatersolutions.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Needs Signoff               |In Discussion
                 CC|                            |nick at bywatersolutions.com

--- Comment #4 from Nick Clemens <nick at bywatersolutions.com> ---
This works, but I am not sure it is the best solution - bug 19575 fixes things
the other way, providing a friendlier name to the index - can you think of
benefits to ths approach over the other?

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Nov 17 16:02:30 2017
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 17 Nov 2017 15:02:30 +0000
Subject: [Koha-bugs] [Bug 19166] Add the ability to add adjustments to an
	invoice
In-Reply-To: <bug-19166-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-19166-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-19166-70-07k54cHkrX@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19166

Koha Team Lyon 3 <koha at univ-lyon3.fr> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |koha at univ-lyon3.fr

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Nov 17 16:18:32 2017
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 17 Nov 2017 15:18:32 +0000
Subject: [Koha-bugs] [Bug 19564] Fix extraction of sort order from sort
	condition name
In-Reply-To: <bug-19564-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-19564-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-19564-70-26B8OOR3l7@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19564

Nick Clemens <nick at bywatersolutions.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |nick at bywatersolutions.com

--- Comment #5 from Nick Clemens <nick at bywatersolutions.com> ---
This works, I mean we need a callnum index, but it changes form not having a
sort to having a sort on an undefined index :-) let me know what other bugs you
are working on

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Nov 17 16:18:47 2017
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 17 Nov 2017 15:18:47 +0000
Subject: [Koha-bugs] [Bug 18723] Dot not recognized as decimal separator
In-Reply-To: <bug-18723-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-18723-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-18723-70-sCVTVolYGT@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18723

--- Comment #2 from Fridolin SOMERS <fridolin.somers at biblibre.com> ---
You answered in Bug 19521 is it a mistake ?

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Nov 17 16:19:24 2017
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 17 Nov 2017 15:19:24 +0000
Subject: [Koha-bugs] [Bug 19641] Move patron templates to the footer
In-Reply-To: <bug-19641-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-19641-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-19641-70-omMV2tO2Bk@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19641

Owen Leonard <oleonard at myacpl.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|ASSIGNED                    |Needs Signoff
   Patch complexity|---                         |Large patch

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Nov 17 16:19:27 2017
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 17 Nov 2017 15:19:27 +0000
Subject: [Koha-bugs] [Bug 19641] Move patron templates to the footer
In-Reply-To: <bug-19641-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-19641-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-19641-70-xBnpLjcZWe@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19641

--- Comment #1 from Owen Leonard <oleonard at myacpl.org> ---
Created attachment 69200
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=69200&action=edit
Bug 19641: Move patron templates to the footer

This patch modifies the staff client patron module templates so that
JavaScript is included in the footer instead of the header.

This patch touches a lot of files because the changes are all
interdependent, affecting a couple of module-wide include files.

To test, apply the patch and test the JavaScript-driven features of the
modified templates: All button controls, DataTables functionality, tabs,
etc.

Patrons -> Patrons home, patron search results
  -> Manage pending modification requests
  -> Patron detail page
    -> Edit patron
      -> Set guarantor
    -> Fines
       -> Account, Pay fines, Create manual invoice, Create manual
          credit
       -> Print receipts for different kinds of charges
    -> Routing lists
    -> Circulation history
    -> Holds history
    -> Notices
    -> Statistics
    -> Files
    -> Purchase suggestions
    -> Discharges
    -> Housebound
    -> Set permissions
    -> Change password
    -> Print summary, slips, and overdues
    -> Update child to adult patron type

Patron toolbar and patron search bar operations should work correctly on
all pages.

This patch also updates the template for searching the Norwegian
national patron database, but it has NOT been tested.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Nov 17 16:23:28 2017
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 17 Nov 2017 15:23:28 +0000
Subject: [Koha-bugs] [Bug 19594] Move admin templates JavaScript to the
 footer: MARC-related
In-Reply-To: <bug-19594-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-19594-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-19594-70-DlXvYLbXv7@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19594

Owen Leonard <oleonard at myacpl.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Blocks|19608                       |


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19608
[Bug 19608] Move admin templates JavaScript to the footer: The rest
-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Nov 17 16:23:28 2017
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 17 Nov 2017 15:23:28 +0000
Subject: [Koha-bugs] [Bug 19608] Move admin templates JavaScript to the
	footer: The rest
In-Reply-To: <bug-19608-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-19608-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-19608-70-1b992BlmFK@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19608

Owen Leonard <oleonard at myacpl.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
         Depends on|19594                       |


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19594
[Bug 19594] Move admin templates JavaScript to the footer: MARC-related
-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Nov 17 16:24:12 2017
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 17 Nov 2017 15:24:12 +0000
Subject: [Koha-bugs] [Bug 19608] Move admin templates JavaScript to the
	footer: The rest
In-Reply-To: <bug-19608-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-19608-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-19608-70-p3oSSgSqoZ@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19608

Owen Leonard <oleonard at myacpl.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
         Depends on|19560                       |


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19560
[Bug 19560] Unable to delete library when branchcode contains special
characters
-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Nov 17 16:24:12 2017
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 17 Nov 2017 15:24:12 +0000
Subject: [Koha-bugs] [Bug 19560] Unable to delete library when branchcode
 contains special characters
In-Reply-To: <bug-19560-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-19560-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-19560-70-pA8k1vXNla@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19560

Owen Leonard <oleonard at myacpl.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Blocks|19608                       |


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19608
[Bug 19608] Move admin templates JavaScript to the footer: The rest
-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Nov 17 16:40:50 2017
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 17 Nov 2017 15:40:50 +0000
Subject: [Koha-bugs] [Bug 19603] Move admin templates JavaScript to the
 footer: Patrons and circulation
In-Reply-To: <bug-19603-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-19603-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-19603-70-qqGjQ549w4@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19603

Owen Leonard <oleonard at myacpl.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
         Depends on|19594                       |19608


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19594
[Bug 19594] Move admin templates JavaScript to the footer: MARC-related
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19608
[Bug 19608] Move admin templates JavaScript to the footer: The rest
-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Nov 17 16:40:50 2017
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 17 Nov 2017 15:40:50 +0000
Subject: [Koha-bugs] [Bug 19594] Move admin templates JavaScript to the
 footer: MARC-related
In-Reply-To: <bug-19594-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-19594-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-19594-70-WRvImIXnQw@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19594

Owen Leonard <oleonard at myacpl.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Blocks|19603                       |


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19603
[Bug 19603] Move admin templates JavaScript to the footer: Patrons and
circulation
-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Nov 17 16:40:50 2017
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 17 Nov 2017 15:40:50 +0000
Subject: [Koha-bugs] [Bug 19608] Move admin templates JavaScript to the
	footer: The rest
In-Reply-To: <bug-19608-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-19608-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-19608-70-43JTdiQPZd@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19608

Owen Leonard <oleonard at myacpl.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Blocks|                            |19603


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19603
[Bug 19603] Move admin templates JavaScript to the footer: Patrons and
circulation
-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Nov 17 16:41:11 2017
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 17 Nov 2017 15:41:11 +0000
Subject: [Koha-bugs] [Bug 19641] Move patron templates to the footer
In-Reply-To: <bug-19641-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-19641-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-19641-70-tojSH77APX@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19641

Owen Leonard <oleonard at myacpl.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
         Depends on|19608                       |


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19608
[Bug 19608] Move admin templates JavaScript to the footer: The rest
-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Nov 17 16:41:11 2017
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 17 Nov 2017 15:41:11 +0000
Subject: [Koha-bugs] [Bug 19608] Move admin templates JavaScript to the
	footer: The rest
In-Reply-To: <bug-19608-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-19608-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-19608-70-QtdTKiNZB8@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19608

Owen Leonard <oleonard at myacpl.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Blocks|19641                       |


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19641
[Bug 19641] Move patron templates to the footer
-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Nov 17 16:50:29 2017
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 17 Nov 2017 15:50:29 +0000
Subject: [Koha-bugs] [Bug 19603] Move admin templates JavaScript to the
 footer: Patrons and circulation
In-Reply-To: <bug-19603-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-19603-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-19603-70-0uUF8LjZ0f@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19603

Owen Leonard <oleonard at myacpl.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #69058|0                           |1
        is obsolete|                            |

--- Comment #5 from Owen Leonard <oleonard at myacpl.org> ---
Created attachment 69201
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=69201&action=edit
Bug 19603: Move admin templates JavaScript to the footer: Patrons and
circulation

This patch modifies the staff client patrons and circulation-related
administration templates so that JavaScript is included in the footer
instead of the header.

To test, apply the patch and test the JavaScript-driven features of
each modified template: All button controls, DataTables functionality,
tabs, etc.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Nov 17 17:11:36 2017
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 17 Nov 2017 16:11:36 +0000
Subject: [Koha-bugs] [Bug 19637] jsPrintSetup not supported in Firefox
	Quantum
In-Reply-To: <bug-19637-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-19637-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-19637-70-mQKn8ggyJ9@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19637

jdemuth at roseville.ca.us <jdemuth at roseville.ca.us> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |jdemuth at roseville.ca.us

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Nov 17 17:30:19 2017
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 17 Nov 2017 16:30:19 +0000
Subject: [Koha-bugs] [Bug 9081] Opac news not output on check in and check
	out notices
In-Reply-To: <bug-9081-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-9081-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-9081-70-7QWy55PDj6@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9081

Lisette <lisetteslatah at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |lisetteslatah at gmail.com

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Nov 17 17:44:49 2017
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 17 Nov 2017 16:44:49 +0000
Subject: [Koha-bugs] [Bug 19647] New: Move patron lists templates JS to the
	footer
Message-ID: <bug-19647-70@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19647

            Bug ID: 19647
           Summary: Move patron lists templates JS to the footer
 Change sponsored?: ---
           Product: Koha
           Version: master
          Hardware: All
                OS: All
            Status: ASSIGNED
          Severity: enhancement
          Priority: P5 - low
         Component: Templates
          Assignee: oleonard at myacpl.org
          Reporter: oleonard at myacpl.org
        QA Contact: testopia at bugs.koha-community.org
                CC: testopia at bugs.koha-community.org
            Blocks: 17858

In order to conform to best practices for performance, staff client template
JavaScript should be in the footer instead of the header.

This patch will do so for the patron lists templates.


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17858
[Bug 17858] Omnibus: Move staff client JavaScript to the footer
-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Nov 17 17:44:49 2017
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 17 Nov 2017 16:44:49 +0000
Subject: [Koha-bugs] [Bug 17858] Omnibus: Move staff client JavaScript to
	the footer
In-Reply-To: <bug-17858-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-17858-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-17858-70-unv1eOXoqL@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17858

Owen Leonard <oleonard at myacpl.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
         Depends on|                            |19647


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19647
[Bug 19647] Move patron lists templates JS to the footer
-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Nov 17 17:55:58 2017
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 17 Nov 2017 16:55:58 +0000
Subject: [Koha-bugs] [Bug 19647] Move patron lists templates JS to the footer
In-Reply-To: <bug-19647-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-19647-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-19647-70-BjnNKOKg8o@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19647

Owen Leonard <oleonard at myacpl.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|ASSIGNED                    |Needs Signoff
   Patch complexity|---                         |Small patch

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Nov 17 17:56:00 2017
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 17 Nov 2017 16:56:00 +0000
Subject: [Koha-bugs] [Bug 19647] Move patron lists templates JS to the footer
In-Reply-To: <bug-19647-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-19647-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-19647-70-GXuLduG9nL@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19647

--- Comment #1 from Owen Leonard <oleonard at myacpl.org> ---
Created attachment 69202
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=69202&action=edit
Bug 19647: Move patron lists templates JS to the footer

This patch modifies the staff client patron lists templates so that
JavaScript is included in the footer instead of the header.

This patch adds a new JS file, tools-menu.js, which will be added to
each template which has the Tools sidebar menu. Highlighting of the
current page in the sidebar menu will be broken for pages which have not
been modified to use this file.

To test, apply the patch and test the JavaScript-driven features of
each modified template: All button controls, DataTables functionality,
form validation, etc.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Nov 17 18:05:14 2017
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 17 Nov 2017 17:05:14 +0000
Subject: [Koha-bugs] [Bug 18309] UNIMARC update from IFLA
In-Reply-To: <bug-18309-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-18309-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-18309-70-P97p4a1oJs@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18309

Fr?d?ric Demians <frederic at tamil.fr> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |frederic at tamil.fr

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Nov 17 18:27:46 2017
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 17 Nov 2017 17:27:46 +0000
Subject: [Koha-bugs] [Bug 19481] Elasticsearch - Set default fields for
 sorting in mappings.yaml
In-Reply-To: <bug-19481-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-19481-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-19481-70-MjpkxovgiC@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19481

--- Comment #7 from Nick Clemens <nick at bywatersolutions.com> ---
(In reply to Julian Maurice from comment #6)
> Patch works as described (except for popularity when in UNIMARC, since the
> field is not defined).
> But I wonder about 6th step in test plan. Shouldn't it be done in an
> updatedatabase script ?

I am not sure - if someone has custom mappings setup for some reasonn I don't
think we want to alter them.

I think i would prefer to follow up on 19542 and add a warning if standard sort
fields are not defined. Does that sound reasonable?

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Nov 17 18:52:31 2017
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 17 Nov 2017 17:52:31 +0000
Subject: [Koha-bugs] [Bug 17424] REST API: Preference to control access to
 own objects without permission
In-Reply-To: <bug-17424-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-17424-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-17424-70-ZKG80ky4b5@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17424

Tom?s Cohen Arazi <tomascohen at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |tomascohen at gmail.com
             Status|Patch doesn't apply         |In Discussion

--- Comment #8 from Tom?s Cohen Arazi <tomascohen at gmail.com> ---
(In reply to Lari Taskula from comment #1)
> One problem with preference-approach is that it will create a mismatch
> between Swagger documentation and value of the preference if disabled. If
> the preference is being used to disable OPAC-like API operations, Swagger
> spec says they should still be possible. In this case, maybe it is enough to
> simply return an error message?

I think we need a more flexible approach: we need a configuration page in which
users can select if they allow (or not) access to own (and relative's) objects,
FOR EACH resource.

The OpenAPI docs can be adjusted to say it will depend on local configurations.
And API consumers will notice anyway.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Nov 17 18:52:57 2017
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 17 Nov 2017 17:52:57 +0000
Subject: [Koha-bugs] [Bug 17424] System preference to control access to own
 objects without permission
In-Reply-To: <bug-17424-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-17424-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-17424-70-yfpp5mOdyA@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17424

Tom?s Cohen Arazi <tomascohen at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
            Summary|REST API: Preference to     |System preference to
                   |control access to own       |control access to own
                   |objects without permission  |objects without permission

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Nov 17 20:25:50 2017
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 17 Nov 2017 19:25:50 +0000
Subject: [Koha-bugs] [Bug 19575] Use canonical field names and resolve
	aliased fields
In-Reply-To: <bug-19575-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-19575-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-19575-70-2REeCHxSyY@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19575

David Bourgault <david.bourgault at inlibro.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |david.bourgault at inlibro.com

--- Comment #8 from David Bourgault <david.bourgault at inlibro.com> ---
*** Bug 19485 has been marked as a duplicate of this bug. ***

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Nov 17 20:25:50 2017
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 17 Nov 2017 19:25:50 +0000
Subject: [Koha-bugs] [Bug 19485] Limiting by title-series (se) broken on ES
In-Reply-To: <bug-19485-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-19485-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-19485-70-BGD10dhw0d@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19485

David Bourgault <david.bourgault at inlibro.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|In Discussion               |RESOLVED
         Resolution|---                         |DUPLICATE

--- Comment #5 from David Bourgault <david.bourgault at inlibro.com> ---
>can you think of benefits to ths approach over the other?

No I can't. David Gustafsson's approach is much better. I used my solution only
because I wasn't confident enough with ES to make big changes. 

I'm not sure what the correct status is, I'll set it to RESOLVED DUPLICATE.

*** This bug has been marked as a duplicate of bug 19575 ***

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Nov 17 20:56:23 2017
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 17 Nov 2017 19:56:23 +0000
Subject: [Koha-bugs] [Bug 19452] The -truncate option in
 borrowers-force-messaging-defaults.pl should not remove category
 preferences
In-Reply-To: <bug-19452-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-19452-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-19452-70-IlwfSc08dH@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19452

--- Comment #8 from Charles Farmer <charles.farmer at inlibro.com> ---
You're completely right, I thought I was looking at a "Pushed to master"
dependency.

I could easily follow the test plan, and saw no issue after qa1.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Nov 17 21:01:34 2017
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 17 Nov 2017 20:01:34 +0000
Subject: [Koha-bugs] [Bug 19647] Move patron lists templates JS to the footer
In-Reply-To: <bug-19647-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-19647-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-19647-70-IqO6YCjimk@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19647

Dominic Pichette <dominic.pichette at inlibro.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |dominic.pichette at inlibro.co
                   |                            |m

--- Comment #2 from Dominic Pichette <dominic.pichette at inlibro.com> ---
Looks good to me! I'm having trouble signing it off though:
Failed to attach patch to bug 19647, status=200

Maybe if someone else could attach it...

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Nov 17 21:02:14 2017
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 17 Nov 2017 20:02:14 +0000
Subject: [Koha-bugs] [Bug 19452] The -truncate option in
 borrowers-force-messaging-defaults.pl should not remove category
 preferences
In-Reply-To: <bug-19452-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-19452-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-19452-70-dHnnJnDEsB@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19452

Charles Farmer <charles.farmer at inlibro.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Needs Signoff               |Signed Off

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Nov 17 21:02:16 2017
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 17 Nov 2017 20:02:16 +0000
Subject: [Koha-bugs] [Bug 19452] The -truncate option in
 borrowers-force-messaging-defaults.pl should not remove category
 preferences
In-Reply-To: <bug-19452-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-19452-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-19452-70-ddqrtWE7aA@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19452

Charles Farmer <charles.farmer at inlibro.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #68201|0                           |1
        is obsolete|                            |

--- Comment #9 from Charles Farmer <charles.farmer at inlibro.com> ---
Created attachment 69203
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=69203&action=edit
Bug 19452: Remove the truncate option

The truncate option is not really useful. Its result is probably not what
most users of this script expect or need.
It truncates both tables borrower_message_preferences and
borrower_message_transport_preferences. This (unfortunately) includes
deleting messaging preferences for patron categories. After that, adding
preferences again will not add categories again, but only borrower
preferences which are all disabled.

Furthermore, we do not need to disable the foreign key check. Neither
do we actually need to truncate, deleting records seems sufficient.
Also deleting transport preferences is not needed, since it will be
done by a cascade from messaging preferences. Note that the subsequent
call of SetMessagingPreferencesFromDefaults will already delete the
records.

This makes it possible to remove the truncate option altogether.

Test plan:
[1] Select a patron category (say ST) and change days_in_advance to x.
[2] Select a ST patron and set days_advance to y in his msg prefs.
[3] Run borrowers-force-messaging-defaults.pl -doit
[4] Verify that the patron has been reset to the default prefs (incl.
    value x in days_in_advance).
[5] Verify that the patron category prefs are still intact.

Signed-off-by: Marcel de Rooy <m.de.rooy at rijksmuseum.nl>
Signed-off-by: Charles Farmer <charles.farmer at inLibro.com>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Nov 17 21:14:55 2017
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 17 Nov 2017 20:14:55 +0000
Subject: [Koha-bugs] [Bug 19604] Elasticsearch Fixes for
 build_authorities_query for auth searching
In-Reply-To: <bug-19604-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-19604-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-19604-70-owioWagbUN@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19604

David Bourgault <david.bourgault at inlibro.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Needs Signoff               |Failed QA

--- Comment #6 from David Bourgault <david.bourgault at inlibro.com> ---
Tests passed, QA tools green.

However, whereas I had 1 exact 1, I now have 0 search results.

I tried reseting the mappings, I reindexed -d -a -v twice but I can't get it to
find results.

Testing in Kibana with the query `Heading:*me*`, I got multiple results
(including both 'me' and 'm?') so I don't think it's a problem specific to my
index/database.

Failed QA :(

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.

From bugzilla-daemon at bugs.koha-community.org  Fri Nov 17 21:24:15 2017
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 17 Nov 2017 20:24:15 +0000
Subject: [Koha-bugs] [Bug 11300] Add a new authority linker which searches
 for authority links on a Z39.50 server.
In-Reply-To: <bug-11300-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-11300-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-11300-70-UhdaH7ODcn@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11300

Bouzid <bouzid.fergani at inlibro.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #69096|0                           |1
        is obsolete|                            |

--- Comment #22 from Bouzid <bouzid.fergani at inlibro.com> ---
Created attachment 69204
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=69204&action=edit
Bug 11300 - Add a new authority linker which searches for authority links on a
Z39.50 server.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Nov 17 21:29:24 2017
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 17 Nov 2017 20:29:24 +0000
Subject: [Koha-bugs] [Bug 19603] Move admin templates JavaScript to the
 footer: Patrons and circulation
In-Reply-To: <bug-19603-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-19603-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-19603-70-3eoRyDfLDs@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19603

Dominic Pichette <dominic.pichette at inlibro.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |dominic.pichette at inlibro.co
                   |                            |m

--- Comment #6 from Dominic Pichette <dominic.pichette at inlibro.com> ---
can't apply the patch, I tried a git reset --hard origin/master without
success:

fatal: sha1 information is lacking or useless
(koha-tmpl/intranet-tmpl/prog/en/modules/admin/categories.tt).
error: could not build fake ancestor
Patch failed at 0001 Bug 19603: Move admin templates JavaScript to the footer:
Patrons and circulation

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Nov 17 21:35:20 2017
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 17 Nov 2017 20:35:20 +0000
Subject: [Koha-bugs] [Bug 11300] Add a new authority linker which searches
 for authority links on a Z39.50 server.
In-Reply-To: <bug-11300-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-11300-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-11300-70-9Ia99btFLE@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11300

Bouzid <bouzid.fergani at inlibro.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Failed QA                   |Needs Signoff

--- Comment #23 from Bouzid <bouzid.fergani at inlibro.com> ---
Hi Katrin,
I fixed :
     - adding atomicupdate
     - cleaninig sysprefs.sql
     - Some problem of QA tools
     - Use Modern::Perl
     - internal error server
But, I do not know how to add tests for new linker, because it uses z3950
server?, any idea.

 Thanks

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Nov 17 21:36:07 2017
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 17 Nov 2017 20:36:07 +0000
Subject: [Koha-bugs] [Bug 19454] Script
 borrowers-force-messaging-defaults.pl should be able to filter on patron
 category
In-Reply-To: <bug-19454-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-19454-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-19454-70-98AjAHBl2g@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19454

Charles Farmer <charles.farmer at inlibro.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Needs Signoff               |Signed Off

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Nov 17 21:36:11 2017
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 17 Nov 2017 20:36:11 +0000
Subject: [Koha-bugs] [Bug 19454] Script
 borrowers-force-messaging-defaults.pl should be able to filter on patron
 category
In-Reply-To: <bug-19454-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-19454-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-19454-70-cl8kg1tfTR@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19454

Charles Farmer <charles.farmer at inlibro.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #68202|0                           |1
        is obsolete|                            |

--- Comment #8 from Charles Farmer <charles.farmer at inlibro.com> ---
Created attachment 69205
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=69205&action=edit
Bug 19454: Add -category parameter to borrowers-force-messaging-defaults.pl

Instead of updating patrons over all patron categories, it would be
helpful if we could filter on a specified category.

Test plan:
[1] Select two patrons A and B in say categories C1 and C2.
[2] Change the msg prefs for A and B away from defaults.
[3] Run borrowers-force-messaging-defaults.pl -doit -cat C1
    Verify that patron A changed and patron B did not.

Signed-off-by: Marcel de Rooy <m.de.rooy at rijksmuseum.nl>
Signed-off-by: Charles Farmer <charles.farmer at inLibro.com>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Nov 17 21:36:14 2017
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 17 Nov 2017 20:36:14 +0000
Subject: [Koha-bugs] [Bug 19454] Script
 borrowers-force-messaging-defaults.pl should be able to filter on patron
 category
In-Reply-To: <bug-19454-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-19454-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-19454-70-N2tjdl3HcN@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19454

Charles Farmer <charles.farmer at inlibro.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #68203|0                           |1
        is obsolete|                            |

--- Comment #9 from Charles Farmer <charles.farmer at inlibro.com> ---
Created attachment 69206
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=69206&action=edit
Bug 19454: (Follow-up) Add a total line when updating

Test plan:
[1] Run the script with -doit and -cat [some_category] and verify that
    the printed total is correct.

Signed-off-by: Marcel de Rooy <m.de.rooy at rijksmuseum.nl>
Signed-off-by: Charles Farmer <charles.farmer at inLibro.com>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Nov 17 21:38:15 2017
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 17 Nov 2017 20:38:15 +0000
Subject: [Koha-bugs] [Bug 17656] Irregularities in serial prediction pattern
 are planned only for current subscription
In-Reply-To: <bug-17656-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-17656-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-17656-70-6xY8WRI9i9@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17656

David Bourgault <david.bourgault at inlibro.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Needs Signoff               |Signed Off

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Nov 17 21:38:18 2017
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 17 Nov 2017 20:38:18 +0000
Subject: [Koha-bugs] [Bug 17656] Irregularities in serial prediction pattern
 are planned only for current subscription
In-Reply-To: <bug-17656-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-17656-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-17656-70-Qdxk372mua@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17656

David Bourgault <david.bourgault at inlibro.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #69124|0                           |1
        is obsolete|                            |

--- Comment #24 from David Bourgault <david.bourgault at inlibro.com> ---
Created attachment 69207
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=69207&action=edit
Bug 17656 - Keep irregularities during subscription renewals

When renewing a subscription, irregularities are lost. This patch
allows to keep them for monthly, daily or weekly serials ( 1 unit per issue
only).

Test plan:
  - Apply this patch,
  - Launch installer/data/mysql/updatedatabase.pl
  - Launch misc/devel/update_dbix_class_files.pl

  - Create a daily subscription. i.e:
    - From: 2017-10-09, To: 2017-10-15,
    - Frequency: 1/day,
    - 7 issues,
    - test prediction pattern
    - check Wednesday and Thursday as irregularity,
    - save
  - Edit subscription,
  - Check that Wednesday and Thursday are still checked
  - Renew subscription from 2017-10-16
  - Edit subscription,
  - Make sure that Wednesday and Thursday are still checked
    with corresponding serials

  - Do the same for a monthly and weekly subscription

Signed-off-by: David Bourgault <david.bourgault at inlibro.com>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Nov 17 21:40:31 2017
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 17 Nov 2017 20:40:31 +0000
Subject: [Koha-bugs] [Bug 17656] Irregularities in serial prediction pattern
 are planned only for current subscription
In-Reply-To: <bug-17656-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-17656-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-17656-70-d2YiQFzge9@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17656

--- Comment #25 from David Bourgault <david.bourgault at inlibro.com> ---
Test plan worked.

QA tool all green except for C4/Serials.pm which warned that "POD coverage was
greater before". Inspecting the file manually, this doesnt seem to be the case. 
I suspect that it is triggered because you remove a function and its pod, which
it shouldn't warn about.

Signed off.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Nov 17 22:02:57 2017
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 17 Nov 2017 21:02:57 +0000
Subject: [Koha-bugs] [Bug 19648] New: Repeated positions in field 007 for
 sound recording ( XML file)
Message-ID: <bug-19648-70@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19648

            Bug ID: 19648
           Summary: Repeated positions in field 007 for sound recording
                    (XML file)
 Change sponsored?: ---
           Product: Koha
           Version: master
          Hardware: All
                OS: All
            Status: NEW
          Severity: trivial
          Priority: P5 - low
         Component: MARC Bibliographic data support
          Assignee: koha-bugs at lists.koha-community.org
          Reporter: hector.hecaxmmx at gmail.com
        QA Contact: testopia at bugs.koha-community.org

Found when translating. Some positions are repeated or duplicated from position
03 to 06 for sound recording in field 007 in XML file starting in line 997 to
1000.

<https://github.com/Koha-Community/Koha/blob/master/koha-tmpl/intranet-tmpl/prog/en/data/marc21_field_007.xml>

      <Value code="s"><description>2 3/4 x 4 in.</description></Value>
      <Value code="u"><description>Unknown</description></Value>
      <Value code="z"><description>Other</description></Value>
      <Value code="|"><description>No attempt to code</description></Value>
=>    <Value code="r"><description>30 ips (tape)</description></Value>
=>    <Value code="u"><description>Unknown</description></Value>
=>    <Value code="z"><description>Other</description></Value>
=>    <Value code="|"><description>No attempt to code</description></Value>

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.

From bugzilla-daemon at bugs.koha-community.org  Fri Nov 17 22:21:27 2017
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 17 Nov 2017 21:21:27 +0000
Subject: [Koha-bugs] [Bug 19514] No Password restrictions in onboarding tool
 patron creation
In-Reply-To: <bug-19514-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-19514-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-19514-70-ZVucitU6SG@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19514

David Bourgault <david.bourgault at inlibro.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #68387|0                           |1
        is obsolete|                            |

--- Comment #8 from David Bourgault <david.bourgault at inlibro.com> ---
Created attachment 69208
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=69208&action=edit
Bug 19514 - Password restrictions implemented into onboarding tool

Test plan:
1. Drop and recreate your database
2. Restart memcached
3. Go through the web installer
4. In the onboarding tool create a patron with a password of only 2 characters
in length
5. Notice the patron is successfully created and no warning message is
displayed
6. Repeat step 1,2,3 and create a patron with a password of 3 characters
none of which are a uppercase letter or number and notice the patron is
successfully created and no warning message is displayed
7. Apply patch
8. Repeat steps 1,2,3 and create a patron with a password consisting of
2 characters, notice that after submitting the form the same form is
loaded again and there is a warning message at the top of the page
informing you the patron wasn't created
9. Repeat steps 1,2,3 and create a patron with a password consisting of
3 characters (all lower case) and submit the form, notice the same form
is reloaded and a warning message at the top of the page informs you
that the patron wasn't created because the password was weak
10. Repeat steps 1,2,3 and create a patron with a password consisting of
3 characters (one lower case letter, one upper case letter and one
number) and submit the form and notice this time the next form in the
onboarding is displayed with the message at the top of the screen informing you
that the patron was successfully created

Sponsored-By: Catalyst IT

Signed-off-by: Marcel de Rooy <m.de.rooy at rijksmuseum.nl>

Signed-off-by: David Bourgault <david.bourgault at inlibro.com>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Nov 17 22:21:33 2017
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 17 Nov 2017 21:21:33 +0000
Subject: [Koha-bugs] [Bug 19514] No Password restrictions in onboarding tool
 patron creation
In-Reply-To: <bug-19514-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-19514-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-19514-70-eJus9WH9sS@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19514

David Bourgault <david.bourgault at inlibro.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #68982|0                           |1
        is obsolete|                            |

--- Comment #9 from David Bourgault <david.bourgault at inlibro.com> ---
Created attachment 69209
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=69209&action=edit
Bug 19514: Add client-side check

Signed-off-by: David Bourgault <david.bourgault at inlibro.com>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Nov 17 22:22:31 2017
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 17 Nov 2017 21:22:31 +0000
Subject: [Koha-bugs] [Bug 19648] Repeated positions in field 007 for sound
 recording (XML file)
In-Reply-To: <bug-19648-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-19648-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-19648-70-11ieTFoxXs@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19648

--- Comment #1 from H?ctor Eduardo Castro Avalos <hector.hecaxmmx at gmail.com> ---
All XML file needs to be revised, more repeated lines are found:

Line 489 need to be deleted
489  <Value code="Used for microopaques."><description>No attempt to code
</description></Value>

Motion pictures (Pos 13)
746   <Value code="u"><description>Unknown</description></Value>
747   <Value code="v"><description>Hand colored</description></Value>
748   <Value code="z"><description>Other</description></Value>
749   <Value code="|"><description>No attempt to code </description></Value>
750   <Value code="u"><description>Unknown</description></Value>
751   <Value code="z"><description>Other</description></Value>
752   <Value code="|"><description>No attempt to code</description></Value>

Sound recording (Pos 09)
1035  <Value code="z"><description>Other</description></Value>
1036  <Value code="|"><description>No attempt to code</description></Value>
1037  <Value code="z"><description>Other</description></Value>
1038  <Value code="|"><description>No attempt to code</description></Value>

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.

From bugzilla-daemon at bugs.koha-community.org  Fri Nov 17 22:24:29 2017
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 17 Nov 2017 21:24:29 +0000
Subject: [Koha-bugs] [Bug 19514] No Password restrictions in onboarding tool
 patron creation
In-Reply-To: <bug-19514-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-19514-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-19514-70-cLXjJYDowS@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19514

David Bourgault <david.bourgault at inlibro.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Needs Signoff               |Signed Off
                 CC|                            |david.bourgault at inlibro.com

--- Comment #10 from David Bourgault <david.bourgault at inlibro.com> ---
Tested working on Firefox 57, Chrome 62 and Opera 49.

Did not work on Firefox 58 from the mozillateam/firefox-next PPA (ubuntu).

Marking as signed-off anyway since Firefox 58 is considered beta, and this
provides both server-side and client-side validation.

QA tool green.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Nov 17 22:26:19 2017
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 17 Nov 2017 21:26:19 +0000
Subject: [Koha-bugs] [Bug 19648] Repeated positions in field 007 for sound
 recording (XML file)
In-Reply-To: <bug-19648-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-19648-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-19648-70-KWKfkueYyF@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19648

H?ctor Eduardo Castro Avalos <hector.hecaxmmx at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                URL|                            |koha-tmpl/intranet-tmpl/pro
                   |                            |g/en/data/marc21_field_007.
                   |                            |xml
   Patch complexity|---                         |String patch

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.

From bugzilla-daemon at bugs.koha-community.org  Fri Nov 17 22:31:37 2017
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 17 Nov 2017 21:31:37 +0000
Subject: [Koha-bugs] [Bug 2454] Improve display of credits on pay fines tab
In-Reply-To: <bug-2454-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-2454-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-2454-70-fbfimGJRm3@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=2454

Dominic Pichette <dominic.pichette at inlibro.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |dominic.pichette at inlibro.co
                   |                            |m
             Status|Needs Signoff               |Signed Off

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the QA Contact for the bug.

From bugzilla-daemon at bugs.koha-community.org  Fri Nov 17 22:33:22 2017
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 17 Nov 2017 21:33:22 +0000
Subject: [Koha-bugs] [Bug 2454] Improve display of credits on pay fines tab
In-Reply-To: <bug-2454-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-2454-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-2454-70-wxGyzK7KNu@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=2454

Dominic Pichette <dominic.pichette at inlibro.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #69098|0                           |1
        is obsolete|                            |

--- Comment #20 from Dominic Pichette <dominic.pichette at inlibro.com> ---
Created attachment 69210
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=69210&action=edit
Bug 2454 - Removed the display of NotifyID and Level values on Pay fines page

Based on tester feedback this patch has been redone so as to remove
changes of indentation to lines not added or modified by this patch.

Test plan:
1. From the Koha staff interface go the Patron area and select a patron
page

2. Create a fine of $10 for the patron by clicking on the 'Fines' tab
and creating a fine in the 'Create manual invoice' tab

3. Create a credit of $5 for the patron in the 'Create manual credit'
page

4. Then go to the 'Pay fines' tab and notice there is a row for both the
fine and credit both with values in the account type, Notify ID, and level
boxes
of the table

5. Select "write off all" and 'OK' in the confirmation box

6. Youre redirected to Account tab, return to 'pay fines' tab and notice
no fines or credits are displayed

7. Repeat steps 2, 3, 4 and then click "Pay amount", confirm it, then
navigate back to the 'Pay fines' tab and notice although the fine and credit
are
displayed the 'total due' value is 0.00

8. Apply the patch attached to this bug report

9. Repeat steps 2, and 3.

10. Navigate to 'Pay fines' tab and notice the fine has values
in account type, Notify ID, and level and the credit does not.
Additionally credit has the description value of 'Credit'

11. Repeat steps 5 and 6 and as with before this patch was applied
notice the 'Pay fines' tab does not show any fines or credits

12. Repeat step 7 and again notice the 'Total due' value is 0.00

Sponsored-By: Catalyst IT
Signed-off-by: Dominic Pichette <dominic at inlibro.com>

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the QA Contact for the bug.

From bugzilla-daemon at bugs.koha-community.org  Fri Nov 17 22:37:18 2017
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 17 Nov 2017 21:37:18 +0000
Subject: [Koha-bugs] [Bug 19647] Move patron lists templates JS to the footer
In-Reply-To: <bug-19647-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-19647-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-19647-70-UNEV3qf1Qm@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19647

Dominic Pichette <dominic.pichette at inlibro.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #69202|0                           |1
        is obsolete|                            |

--- Comment #3 from Dominic Pichette <dominic.pichette at inlibro.com> ---
Created attachment 69211
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=69211&action=edit
Bug 19647: Move patron lists templates JS to the footer

This patch modifies the staff client patron lists templates so that
JavaScript is included in the footer instead of the header.

This patch adds a new JS file, tools-menu.js, which will be added to
each template which has the Tools sidebar menu. Highlighting of the
current page in the sidebar menu will be broken for pages which have not
been modified to use this file.

To test, apply the patch and test the JavaScript-driven features of
each modified template: All button controls, DataTables functionality,
form validation, etc.
resolved the issue, sorry about that, everything is working fine!Signed-off-by:
Dominic Pichette <dominic at inlibro.com>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Nov 17 22:38:20 2017
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 17 Nov 2017 21:38:20 +0000
Subject: [Koha-bugs] [Bug 19647] Move patron lists templates JS to the footer
In-Reply-To: <bug-19647-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-19647-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-19647-70-EoMkGEOGsO@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19647

Dominic Pichette <dominic.pichette at inlibro.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Needs Signoff               |Signed Off

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Nov 17 22:52:30 2017
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 17 Nov 2017 21:52:30 +0000
Subject: [Koha-bugs] [Bug 18645] Creation of Koha feature release change
 tool displayed after running Koha update
In-Reply-To: <bug-18645-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-18645-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-18645-70-wdn8pVTmt1@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18645

David Bourgault <david.bourgault at inlibro.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Needs Signoff               |Failed QA

--- Comment #14 from David Bourgault <david.bourgault at inlibro.com> ---
When applying the patch I got a conflict with staff-global.css (trivial, I
fixed it)

Following test plan I saw the buttons as predicted, but when login-in-out with
admin and then login with superlibrarian I did not get redirected to the
installer login page.

When through step plan again, clicked the "Continue to feature release tool"
button and got redirected correctly. However no system pref showed up (I had 1
release note, for 17.05).

QA tool shows multiple (minor) errors (including a spelling error in a
surname?)

Failed QA

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Nov 17 23:17:47 2017
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 17 Nov 2017 22:17:47 +0000
Subject: [Koha-bugs] [Bug 19563] Generation of sort_fields uses incorrect
	condition
In-Reply-To: <bug-19563-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-19563-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-19563-70-60EEg4VTJS@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19563

David Bourgault <david.bourgault at inlibro.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #68889|0                           |1
        is obsolete|                            |

--- Comment #5 from David Bourgault <david.bourgault at inlibro.com> ---
Created attachment 69212
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=69212&action=edit
Bug 19563: Generation of sort_fields uses incorrect condition

Fix incorrect condition for if clause for generating <field>__sort mappings
for Elasticsearch. Also remove redundant check for same condition when
generating fixer rules.

Test plan:
1. Inspect current mappings for example by viewing:
http://<elasticsearch_host>:9200/koha_<koha_instance_name>_biblios/_mapping.
2. If using the default configuraion only "author" has a sort field
(author__sort).
4. Appy patch.
5. Reindex using rebuild_elastic_search.pl.
6. All fields except those with sort sort set to "0" should now have sort
fields, which in the default configuration is all but "author".

Signed-off-by: David Bourgault <david.bourgault at inlibro.com>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Nov 17 23:17:50 2017
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 17 Nov 2017 22:17:50 +0000
Subject: [Koha-bugs] [Bug 19563] Generation of sort_fields uses incorrect
	condition
In-Reply-To: <bug-19563-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-19563-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-19563-70-TgkOB6PRzS@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19563

David Bourgault <david.bourgault at inlibro.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #69191|0                           |1
        is obsolete|                            |

--- Comment #6 from David Bourgault <david.bourgault at inlibro.com> ---
Created attachment 69213
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=69213&action=edit
Bug 19563: Unit tests

To test:
1 - Apply first patch and this patch
2 - prove -v t/db_dependent/Koha_Elasticsearch.t
3 - New tests will fail
4 - Apply followup patch
5 - Tests shuld pass

Signed-off-by: David Bourgault <david.bourgault at inlibro.com>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Nov 17 23:17:52 2017
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 17 Nov 2017 22:17:52 +0000
Subject: [Koha-bugs] [Bug 19563] Generation of sort_fields uses incorrect
	condition
In-Reply-To: <bug-19563-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-19563-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-19563-70-0WPOYuzHMG@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19563

David Bourgault <david.bourgault at inlibro.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #69192|0                           |1
        is obsolete|                            |

--- Comment #7 from David Bourgault <david.bourgault at inlibro.com> ---
Created attachment 69214
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=69214&action=edit
Bug 19563: Followup - Restore checking sort variable

This code seems a bit odd, $self->sort_fields()->{$name} is checking if
there is any mapping in ES for a field, so if one marc field in an index
is marked as sortable this will exists. We need to check the individual
marc field to see if it should be added to the sort index here.

If you apply the first patch, reindex, and view a record in es:
curl -XGET 'localhost:9200/koha_kohadev_biblios/data/19/?pretty' | grep
-A 10 author__sort

You will see that 245$c is included in the record without that
additional check

Apply this, reindex again, and that field should not be included

Signed-off-by: David Bourgault <david.bourgault at inlibro.com>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Sat Nov 18 12:05:43 2017
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Sat, 18 Nov 2017 11:05:43 +0000
Subject: [Koha-bugs] [Bug 19649] New: jaga
Message-ID: <bug-19649-70@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19649

            Bug ID: 19649
           Summary: jaga
 Change sponsored?: ---
           Product: Koha
           Version: 17.05
          Hardware: All
                OS: All
            Status: NEW
          Severity: enhancement
          Priority: P5 - low
         Component: bugs.koha-community.org
          Assignee: koha-bugs at lists.koha-community.org
          Reporter: Atmaganteng69 at gmail.com
        QA Contact: testopia at bugs.koha-community.org

Created attachment 69215
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=69215&action=edit
JHJ

aajajajaj

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Sun Nov 19 11:25:32 2017
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Sun, 19 Nov 2017 10:25:32 +0000
Subject: [Koha-bugs] [Bug 19649] SPAM
In-Reply-To: <bug-19649-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-19649-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-19649-70-UnQnrKwf3T@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19649

Katrin Fischer <katrin.fischer at bsz-bw.de> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |katrin.fischer at bsz-bw.de
            Summary|jaga                        |SPAM

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Sun Nov 19 11:25:54 2017
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Sun, 19 Nov 2017 10:25:54 +0000
Subject: [Koha-bugs] [Bug 19649] SPAM
In-Reply-To: <bug-19649-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-19649-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-19649-70-ScjC2yhCC6@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19649

Katrin Fischer <katrin.fischer at bsz-bw.de> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
         Resolution|---                         |INVALID
             Status|NEW                         |RESOLVED

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Sun Nov 19 12:08:42 2017
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Sun, 19 Nov 2017 11:08:42 +0000
Subject: [Koha-bugs] [Bug 7317] Add an Interlibrary Loan Module to
	Circulation and OPAC
In-Reply-To: <bug-7317-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-7317-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-7317-70-sSXOG90Zpc@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7317

Jonathan Druart <jonathan.druart at bugs.koha-community.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Text to go in the|                            |Adds the ability to place
      release notes|                            |interlibrary loan requests
                   |                            |in Koha.
                   |                            |
                   |                            |Interlibrary
                   |                            |loan requests are common
                   |                            |especially in academic or
                   |                            |special libraries where the
                   |                            |enduser or librarian may be
                   |                            |entitled to request a book
                   |                            |or article from an external
                   |                            |library such as the British
                   |                            |Library (BLDSS) using their
                   |                            |interlibrary loan service.
                   |                            |
                   |                            |This patch set comes with
                   |                            |3 configured backends -
                   |                            |BLDSS, Freeform and a Dummy
                   |                            |account which is the
                   |                            |default for testing.  The
                   |                            |BLDSS backend allows users
                   |                            |to search stock held by the
                   |                            |British Library using their
                   |                            |api, and allows requests to
                   |                            |be placed against it. The
                   |                            |Freeform backend allows the
                   |                            |creation of Interlibrary
                   |                            |loan requests using a
                   |                            |manual form.
                   |                            |
                   |                            |Interlibrary loan requests
                   |                            |can be made from the OPAC
                   |                            |or from the staff client.
                   |                            |The enduser can query the
                   |                            |backend database and place
                   |                            |requests. Alternatively
                   |                            |they can create requests
                   |                            |using the manual form.
                   |                            |From
                   |                            |the OPAC interface endusers
                   |                            |can view and comment on
                   |                            |their requests if enabled.
                   |                            |In the staff client
                   |                            |librarians can manage
                   |                            |requests placed on the
                   |                            |OPAC, processing them
                   |                            |against a backend (e.g.
                   |                            |British Library).
                   |                            |Alternatively the system
                   |                            |allows requests to be
                   |                            |placed with peer libraries.
                   |                            |Peer libraries can be
                   |                            |identified by an
                   |                            |Organizational patron
                   |                            |category type and requests
                   |                            |can be sent to the peer
                   |                            |library by email.
                   |                            |Core
                   |                            |request information such as
                   |                            |links to borrowers, branch,
                   |                            |request status, staff and
                   |                            |customer notes, unique
                   |                            |identifiers are stored in
                   |                            |the database and can be
                   |                            |displayed and reported on.
           Keywords|release-notes-needed        |

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Sun Nov 19 23:24:32 2017
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Sun, 19 Nov 2017 22:24:32 +0000
Subject: [Koha-bugs] [Bug 19532] Recalls for Koha
In-Reply-To: <bug-19532-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-19532-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-19532-70-tG1WWezJ9g@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19532

--- Comment #18 from Aleisha Amohia <aleisha at catalyst.net.nz> ---
Created attachment 69221
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=69221&action=edit
Bug 19532: Recalls awaiting pickup report

this patch adds reports for all recalls awaiting pickup, and recalls
that have been waiting more than X days. a syspref,
RecallsMaxPickUpDelay, is added to give a general max shelf time for
recalls

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Nov 20 00:20:30 2017
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Sun, 19 Nov 2017 23:20:30 +0000
Subject: [Koha-bugs] [Bug 19544] Add manual contributors to the release notes
In-Reply-To: <bug-19544-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-19544-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-19544-70-8BMug7Uk5y@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19544

--- Comment #2 from Katrin Fischer <katrin.fischer at bsz-bw.de> ---
Thx Jonathan!

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Nov 20 01:51:51 2017
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 20 Nov 2017 00:51:51 +0000
Subject: [Koha-bugs] [Bug 19532] Recalls for Koha
In-Reply-To: <bug-19532-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-19532-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-19532-70-E06Hod8bkq@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19532

--- Comment #19 from Aleisha Amohia <aleisha at catalyst.net.nz> ---
Created attachment 69222
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=69222&action=edit
Bug 19532: Only recall items checked out by other users

... shouldn't be able to recall items that are currently checked out by
yourself.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Nov 20 03:35:12 2017
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 20 Nov 2017 02:35:12 +0000
Subject: [Koha-bugs] [Bug 19532] Recalls for Koha
In-Reply-To: <bug-19532-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-19532-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-19532-70-e4CG9ZqUI1@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19532

--- Comment #20 from Aleisha Amohia <aleisha at catalyst.net.nz> ---
Created attachment 69223
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=69223&action=edit
Bug 19532: UseRecalls syspref

This patch adds a syspref to control the usability of the recalls
feature

Test the following:

Staff side
/includes/circ-menu.inc
/includes/circ-nav.inc
/includes/members-menu.inc
/admin/preferences/circulation.pref
/circ/circulation-home.tt
/circ/circulation.tt
/circ/recalls_overdue.tt
/circ/recalls_queue.tt
/circ/recalls_waiting.tt
/members/moremember.tt
/members/recallshistory.tt

OPAC
/includes/usermenu.inc
/opac-recall.tt
/opac-recalls.tt
/opac-user.tt
/members/recallshistory.pl
/opac/opac-detail.pl

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Nov 20 08:06:07 2017
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 20 Nov 2017 07:06:07 +0000
Subject: [Koha-bugs] [Bug 19454] Script
 borrowers-force-messaging-defaults.pl should be able to filter on patron
 category
In-Reply-To: <bug-19454-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-19454-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-19454-70-eAjWK9dzHW@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19454

--- Comment #10 from Marcel de Rooy <m.de.rooy at rijksmuseum.nl> ---
(In reply to Charles Farmer from comment #9)
> Signed-off-by: Charles Farmer <charles.farmer at inLibro.com>

Thx Charles

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Nov 20 09:07:48 2017
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 20 Nov 2017 08:07:48 +0000
Subject: [Koha-bugs] [Bug 19481] Elasticsearch - Set default fields for
 sorting in mappings.yaml
In-Reply-To: <bug-19481-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-19481-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-19481-70-0JA3NBkK5k@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19481

--- Comment #8 from Julian Maurice <julian.maurice at biblibre.com> ---
(In reply to Nick Clemens from comment #7)
> I am not sure - if someone has custom mappings setup for some reasonn I
> don't think we want to alter them.
> 
> I think i would prefer to follow up on 19542 and add a warning if standard
> sort fields are not defined. Does that sound reasonable?
Ok

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Nov 20 09:08:01 2017
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 20 Nov 2017 08:08:01 +0000
Subject: [Koha-bugs] [Bug 19481] Elasticsearch - Set default fields for
 sorting in mappings.yaml
In-Reply-To: <bug-19481-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-19481-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-19481-70-HdL8NGH5Oq@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19481

Julian Maurice <julian.maurice at biblibre.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #68788|0                           |1
        is obsolete|                            |

--- Comment #9 from Julian Maurice <julian.maurice at biblibre.com> ---
Created attachment 69224
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=69224&action=edit
Bug 19481 - Set default sort options as sortable in ES default mappings

To test:
1 - Setup Koha with ES
2 - perform a search
3 - try sorting by pubdate, acqdate, popularity, or title
4 - Search fails!
5 - Apply patch
6 - visit:
/cgi-bin/koha/admin/searchengine/elasticsearch/mappings.pl?op=reset&i_know_what_i_am_doing=1
7 - Re-index ES
8 - Perform search
9 - All sorting options should work

Signed-off-by: David Bourgault <david.bourgault at inlibro.com>
Signed-off-by: Julian Maurice <julian.maurice at biblibre.com>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Nov 20 09:08:10 2017
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 20 Nov 2017 08:08:10 +0000
Subject: [Koha-bugs] [Bug 19481] Elasticsearch - Set default fields for
 sorting in mappings.yaml
In-Reply-To: <bug-19481-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-19481-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-19481-70-x8bs8u8Ixt@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19481

Julian Maurice <julian.maurice at biblibre.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Signed Off                  |Passed QA

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Nov 20 10:20:45 2017
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 20 Nov 2017 09:20:45 +0000
Subject: [Koha-bugs] [Bug 19650] New: Make note fields in items textarea by
	default
Message-ID: <bug-19650-70@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19650

            Bug ID: 19650
           Summary: Make note fields in items textarea by default
 Change sponsored?: ---
           Product: Koha
           Version: master
          Hardware: All
                OS: All
            Status: NEW
          Severity: enhancement
          Priority: P5 - low
         Component: Cataloging
          Assignee: koha-bugs at lists.koha-community.org
          Reporter: katrin.fischer at bsz-bw.de
        QA Contact: testopia at bugs.koha-community.org
                CC: m.de.rooy at rijksmuseum.nl

In the edit item form all fields are presented as input fields when adding a
new item. If you want to enter a longer text, this is a bit hard to work with.
Once the data is saved, from a certain text length on, the input will be
changed to a textarea when editing the item again.

It would be nice if it was possible to have the internal and public note fields
as textarea by default, allowing to enter longer text more easily.

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.

From bugzilla-daemon at bugs.koha-community.org  Mon Nov 20 11:36:03 2017
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 20 Nov 2017 10:36:03 +0000
Subject: [Koha-bugs] [Bug 19563] Generation of sort_fields uses incorrect
	condition
In-Reply-To: <bug-19563-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-19563-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-19563-70-zAQWYgIgzC@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19563

--- Comment #8 from David Gustafsson <glasklas at gmail.com> ---
Yes, my mistake! Did not realize that there can of course be multiple marc
field mappings for one search field, and need to check each one.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Nov 20 11:43:18 2017
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 20 Nov 2017 10:43:18 +0000
Subject: [Koha-bugs] [Bug 19564] Fix extraction of sort order from sort
	condition name
In-Reply-To: <bug-19564-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-19564-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-19564-70-142ZdSFJXK@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19564

--- Comment #6 from David Gustafsson <glasklas at gmail.com> ---
Yes, although I think it's a good idea to fix the code even though it does not
solve the issue with the current code base, I think that sorting should work
with this fix together with
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19563

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Nov 20 12:18:48 2017
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 20 Nov 2017 11:18:48 +0000
Subject: [Koha-bugs] [Bug 18655] Unimarc field 210c fails on importing
 fields with a simple quote
In-Reply-To: <bug-18655-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-18655-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-18655-70-CBIz90SbZu@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18655

Fridolin SOMERS <fridolin.somers at biblibre.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
           Assignee|baptiste.wojtkowski at biblibr |fridolin.somers at biblibre.co
                   |e.com                       |m

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Nov 20 12:21:45 2017
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 20 Nov 2017 11:21:45 +0000
Subject: [Koha-bugs] [Bug 18655] Unimarc field 210c fails on importing
 fields with a simple quote
In-Reply-To: <bug-18655-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-18655-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-18655-70-Ogf2xZ65Ij@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18655

--- Comment #6 from Fridolin SOMERS <fridolin.somers at biblibre.com> ---
(In reply to Simon Pouchol from comment #5)
> Hi Baptiste,
> I was looking to test this patch, could you provide a Test Plan ?
> I can't seem to able to reproduce the bug within the unimarc plugin 210c,
> with or without the patch I can search for an authority with a ' in the name.
> The choose button doesn't seem appear for me at all (can't find it hidden in
> dev tools either).

I continue Baptiste's job.

You need an existing authority with a ' in its name, like "L'histoire".

When trying to choose this authority it fails.

Btw I think that writing JS inside HTML tags is now prohibited.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Nov 20 12:47:46 2017
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 20 Nov 2017 11:47:46 +0000
Subject: [Koha-bugs] [Bug 19651] New: SIP/ILS/Item missing title
Message-ID: <bug-19651-70@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19651

            Bug ID: 19651
           Summary: SIP/ILS/Item missing title
 Change sponsored?: ---
           Product: Koha
           Version: master
          Hardware: All
                OS: All
            Status: NEW
          Severity: major
          Priority: P5 - low
         Component: SIP2
          Assignee: koha-bugs at lists.koha-community.org
          Reporter: stefan.berndtsson at ub.gu.se
        QA Contact: testopia at bugs.koha-community.org
                CC: colin.campbell at ptfs-europe.com

In 17.05 of C4/SIP/ILS/Item.pm (sub new) $item is fetched via
GetBiblioFromItemNumber(). I assume this means that "title" was available as a
property on the $item object.

In master however, $item is fetched using Koha::Item->find() which means it is
a pure Item object, and does not contain biblio data. $item->{title} is
therefor lost.

The "title" property has to be reinserted from $biblio explicitly. Looking at
the %fields hash in the same file, "author" is probably another field that
needs fixing too.

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.

From bugzilla-daemon at bugs.koha-community.org  Mon Nov 20 12:59:22 2017
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 20 Nov 2017 11:59:22 +0000
Subject: [Koha-bugs] [Bug 19652] New: Debug-level logging for response JSON
Message-ID: <bug-19652-70@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19652

            Bug ID: 19652
           Summary: Debug-level logging for response JSON
 Change sponsored?: ---
           Product: Koha
           Version: unspecified
          Hardware: All
                OS: All
            Status: NEW
          Severity: enhancement
          Priority: P5 - low
         Component: REST api
          Assignee: koha-bugs at lists.koha-community.org
          Reporter: lari.taskula at jns.fi

Log response JSON in REST API log.

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Nov 20 12:59:58 2017
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 20 Nov 2017 11:59:58 +0000
Subject: [Koha-bugs] [Bug 19652] Debug-level logging for response JSON
In-Reply-To: <bug-19652-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-19652-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-19652-70-ly1JsTQhF1@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19652

--- Comment #1 from Lari Taskula <lari.taskula at jns.fi> ---
Created attachment 69225
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=69225&action=edit
Bug 19652: Debug-level logging for response JSON

This patch adds debug-level logging for response JSON. This is useful for
viewing
responses via REST API log file.

To test:
1. prove t/db_dependent/api/v1.t
2. Configure log4perl configuration file for REST API and set log level to
DEBUG
3. Make any request to existing REST API endpoint
4. Observe response JSON in your log file

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.

From bugzilla-daemon at bugs.koha-community.org  Mon Nov 20 13:00:08 2017
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 20 Nov 2017 12:00:08 +0000
Subject: [Koha-bugs] [Bug 19652] Debug-level logging for response JSON
In-Reply-To: <bug-19652-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-19652-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-19652-70-dgLN1HekAO@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19652

Lari Taskula <lari.taskula at jns.fi> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
           Assignee|koha-bugs at lists.koha-commun |lari.taskula at jns.fi
                   |ity.org                     |

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.

From bugzilla-daemon at bugs.koha-community.org  Mon Nov 20 13:00:26 2017
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 20 Nov 2017 12:00:26 +0000
Subject: [Koha-bugs] [Bug 19652] Debug-level logging for response JSON
In-Reply-To: <bug-19652-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-19652-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-19652-70-OcIj2vcm5X@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19652

Lari Taskula <lari.taskula at jns.fi> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
         Depends on|                            |18206


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18206
[Bug 18206] REST API: Default exception handling
-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Nov 20 13:00:26 2017
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 20 Nov 2017 12:00:26 +0000
Subject: [Koha-bugs] [Bug 18206] REST API: Default exception handling
In-Reply-To: <bug-18206-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-18206-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-18206-70-0cJHw8CdKO@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18206

Lari Taskula <lari.taskula at jns.fi> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Blocks|                            |19652


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19652
[Bug 19652] Debug-level logging for response JSON
-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Nov 20 13:10:02 2017
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 20 Nov 2017 12:10:02 +0000
Subject: [Koha-bugs] [Bug 18205] REST interface to Koha::Logger
In-Reply-To: <bug-18205-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-18205-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-18205-70-hFYLVFP2FY@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18205

Lari Taskula <lari.taskula at jns.fi> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #60848|0                           |1
        is obsolete|                            |

--- Comment #5 from Lari Taskula <lari.taskula at jns.fi> ---
Created attachment 69226
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=69226&action=edit
Bug 18205: Add interface 'rest' for Koha::Logger

This patch adds an interface 'rest' for Koha::Logger.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Nov 20 13:10:14 2017
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 20 Nov 2017 12:10:14 +0000
Subject: [Koha-bugs] [Bug 18205] REST interface to Koha::Logger
In-Reply-To: <bug-18205-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-18205-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-18205-70-LVH8enEDWK@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18205

Lari Taskula <lari.taskula at jns.fi> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #60849|0                           |1
        is obsolete|                            |

--- Comment #6 from Lari Taskula <lari.taskula at jns.fi> ---
Created attachment 69227
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=69227&action=edit
Bug 18205: Unit tests

To test:
1. prove t/db_dependent/Log.t

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Nov 20 13:10:26 2017
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 20 Nov 2017 12:10:26 +0000
Subject: [Koha-bugs] [Bug 18205] REST interface to Koha::Logger
In-Reply-To: <bug-18205-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-18205-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-18205-70-YiMkUiU3WS@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18205

Lari Taskula <lari.taskula at jns.fi> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #60850|0                           |1
        is obsolete|                            |

--- Comment #7 from Lari Taskula <lari.taskula at jns.fi> ---
Created attachment 69228
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=69228&action=edit
Bug 18205: Mojo::Log with Koha::Logger::Mojo

This patch adds a new module, Koha::Logger::Mojo, based on
MojoX::Log::Log4perl.
This module allows us to use log4perl configurations with Mojolicious on the
freshly introduced 'rest' interface in log4perl.conf.

$c->app->log->warn will then use Log4perl as the underlying log mechanism and
those log events will point to the appropriate log file.

To test:
1. Install Perl dependency MojoX::Log::Log4perl
2. prove t/Koha/Logger/Mojo.t

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Nov 20 13:11:50 2017
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 20 Nov 2017 12:11:50 +0000
Subject: [Koha-bugs] [Bug 18205] REST interface to Koha::Logger
In-Reply-To: <bug-18205-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-18205-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-18205-70-5ZHS280Qa0@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18205

Lari Taskula <lari.taskula at jns.fi> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Patch doesn't apply         |Needs Signoff

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Nov 20 13:12:10 2017
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 20 Nov 2017 12:12:10 +0000
Subject: [Koha-bugs] [Bug 18206] REST API: Default exception handling
In-Reply-To: <bug-18206-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-18206-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-18206-70-1p2i1plh9M@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18206

Lari Taskula <lari.taskula at jns.fi> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #61170|0                           |1
        is obsolete|                            |

--- Comment #11 from Lari Taskula <lari.taskula at jns.fi> ---
Created attachment 69229
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=69229&action=edit
Bug 18206: Default exception handling for REST API

Many of our operations in REST API controllers now use try-catch blocks to
catch
exceptions and handle them appropriately. This is great, but we should
introduce
a centralized way of handling default HTTP 500 errors. Currently they are
checked
over and over again in each operation. As an example this same lovely poem, in
many cases, is currently replicated for each operation:

sub list {
  ...
  try {
    blabla
  } catch {
    # This should stay here, custom error handling for this particular
operation
    if ($_->isa('Koha::Exceptions::Patron::Something')) {
       return $c->render(status => 400, openapi => { error => $_->error });
    }
    # But the checks below can be centralized!
    elsif ($_->isa('DBIx::Class::Exception')) {
       return $c->render(status => 500, openapi => { error => $_->{msg} });
    }
    elsif ($_->isa('Koha::Exceptions::Exception')) {
       return $c->render(status => 500, openapi => { error => $_->error });
    }
    else {
       return $c->render(status => 500, openapi => { error =>
         "Something went wrong, check the logs." });
    }
  };
}

Instead, my proposal for a more centralized solution is to use a before_render
hook to catch all of the default exceptions before rendering that are expected
to return a 500, logging the error and displaying an appropriate error message
in response body. After this patch, the above example would then look like
this:

sub list {
  ...
  try {
    blabla
  } catch {
    # This should stay here, custom error handling for this particular
operation
    if ($_->isa('Koha::Exceptions::Patron::Something')) {
       return $c->render(status => 400, openapi => { error => $_->error });
    }
    # Simply rethrow the exception with the help of below function - it will
then
    # be handled in before_render hook
    Koha::Exceptions::rethrow_exception($_);
  };
}

What does this patch actually do?

After this patch, in case of an exception, we will normally visit the
catch-block.
If none of the specified Koha::Exceptions match the thrown $_, we will now
rethrow
the exception. This does not crash the whole app, but forwards the exception
eventually into our before_render hook at
Koha::REST::V1::handle_default_exceptions.
There, we are able to customize our way of handling these exceptions. In this
patch
I have added an error logging there. We should also discuss whether we want to
display a detailed error message, or simply "Something went wrong, check the
logs."
for all of the default exceptions. Perhaps this could be controlled by some
sort
of configuration for development/production (e.g. MOJO_MODE) ?

To test:
1. prove t/db_dependent/api
2. prove t/Koha/Exceptions.t

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Nov 20 13:12:23 2017
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 20 Nov 2017 12:12:23 +0000
Subject: [Koha-bugs] [Bug 18206] REST API: Default exception handling
In-Reply-To: <bug-18206-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-18206-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-18206-70-cw1aud5WpJ@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18206

Lari Taskula <lari.taskula at jns.fi> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #61171|0                           |1
        is obsolete|                            |

--- Comment #12 from Lari Taskula <lari.taskula at jns.fi> ---
Created attachment 69230
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=69230&action=edit
Bug 18206: Use this feature for cities

To test:
1. prove t/db_dependent/api/v1/cities.t

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Nov 20 13:12:37 2017
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 20 Nov 2017 12:12:37 +0000
Subject: [Koha-bugs] [Bug 18206] REST API: Default exception handling
In-Reply-To: <bug-18206-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-18206-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-18206-70-hyrFcKsjwd@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18206

Lari Taskula <lari.taskula at jns.fi> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|BLOCKED                     |Needs Signoff

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Nov 20 13:12:39 2017
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 20 Nov 2017 12:12:39 +0000
Subject: [Koha-bugs] [Bug 18206] REST API: Default exception handling
In-Reply-To: <bug-18206-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-18206-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-18206-70-dQg4PvOTkm@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18206

Lari Taskula <lari.taskula at jns.fi> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #68243|0                           |1
        is obsolete|                            |

--- Comment #13 from Lari Taskula <lari.taskula at jns.fi> ---
Created attachment 69231
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=69231&action=edit
Bug 18206 - REST API: Default exception handling - Squashable, fix regexp

t/db_dependent/api/v1.t .. Unescaped left brace in regex is deprecated, passed
through in regex; marked by <-- HERE in m/ERROR - Unknown::Exception::OhNo => {
<-- HERE "what":"test unknown exception"}/ at t/db_dependent/api/v1.t line 100.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Nov 20 13:18:11 2017
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 20 Nov 2017 12:18:11 +0000
Subject: [Koha-bugs] [Bug 18205] REST interface to Koha::Logger
In-Reply-To: <bug-18205-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-18205-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-18205-70-h09dTLuniT@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18205

Lari Taskula <lari.taskula at jns.fi> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #69228|0                           |1
        is obsolete|                            |

--- Comment #8 from Lari Taskula <lari.taskula at jns.fi> ---
Created attachment 69232
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=69232&action=edit
Bug 18205: Mojo::Log with Koha::Logger::Mojo

This patch adds a new module, Koha::Logger::Mojo, based on
MojoX::Log::Log4perl.
This module allows us to use log4perl configurations with Mojolicious on the
freshly introduced 'rest' interface in log4perl.conf.

$c->app->log->warn will then use Log4perl as the underlying log mechanism and
those log events will point to the appropriate log file.

To test:
1. Install Perl dependency MojoX::Log::Log4perl
2. prove t/Koha/Logger/Mojo.t

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Nov 20 13:18:47 2017
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 20 Nov 2017 12:18:47 +0000
Subject: [Koha-bugs] [Bug 19652] Debug-level logging for response JSON
In-Reply-To: <bug-19652-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-19652-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-19652-70-iV3750BXVw@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19652

Lari Taskula <lari.taskula at jns.fi> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #69225|0                           |1
        is obsolete|                            |

--- Comment #2 from Lari Taskula <lari.taskula at jns.fi> ---
Created attachment 69233
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=69233&action=edit
Bug 19652: Debug-level logging for response JSON

This patch adds debug-level logging for response JSON. This is useful for
viewing
responses via REST API log file.

To test:
1. prove t/db_dependent/api/v1.t
2. Configure log4perl configuration file for REST API and set log level to
DEBUG
3. Make any request to existing REST API endpoint
4. Observe response JSON in your log file

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Nov 20 13:18:45 2017
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 20 Nov 2017 12:18:45 +0000
Subject: [Koha-bugs] [Bug 19652] Debug-level logging for response JSON
In-Reply-To: <bug-19652-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-19652-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-19652-70-xEfHmAlMDw@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19652

Lari Taskula <lari.taskula at jns.fi> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|NEW                         |Needs Signoff

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Nov 20 13:22:29 2017
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 20 Nov 2017 12:22:29 +0000
Subject: [Koha-bugs] [Bug 19652] Debug-level logging for response JSON
In-Reply-To: <bug-19652-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-19652-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-19652-70-McuMlaTsxh@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19652

--- Comment #3 from Lari Taskula <lari.taskula at jns.fi> ---
Test plan step 2 example conf (in your log4perl.conf file):

log4perl.logger.rest = DEBUG, REST
log4perl.appender.REST=Log::Log4perl::Appender::File
log4perl.appender.REST.filename=/home/koha/koha-dev/var/log/rest.log
log4perl.appender.REST.create_at_logtime=true
log4perl.appender.REST.syswrite=true
log4perl.appender.REST.recreate=true
log4perl.appender.REST.mode=append
log4perl.appender.REST.layout=PatternLayout
log4perl.appender.REST.layout.ConversionPattern=[%d] [%p] %m %l %n
log4perl.appender.REST.utf8=1

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Nov 20 13:57:07 2017
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 20 Nov 2017 12:57:07 +0000
Subject: [Koha-bugs] [Bug 18616] The "Add forgot password link to OPAC"
 should allow patrons to use their library card number in addition to
 username
In-Reply-To: <bug-18616-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-18616-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-18616-70-GQjIC4Z8cD@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18616

Fridolin SOMERS <fridolin.somers at biblibre.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Pushed to Master            |Pushed to Stable

--- Comment #21 from Fridolin SOMERS <fridolin.somers at biblibre.com> ---
Pushed to 17.05.x, will be in 17.05.06.

No problem now ;)

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Nov 20 14:05:06 2017
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 20 Nov 2017 13:05:06 +0000
Subject: [Koha-bugs] [Bug 19495] Automatic report conversion needs to do
 global replace on ' biblioitems' and 'marcxml'
In-Reply-To: <bug-19495-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-19495-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-19495-70-3dfjk6xPK3@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19495

Fridolin SOMERS <fridolin.somers at biblibre.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |fridolin.somers at biblibre.co
                   |                            |m
             Status|Pushed to Master            |Pushed to Stable

--- Comment #8 from Fridolin SOMERS <fridolin.somers at biblibre.com> ---
Pushed to 17.05.x, will be in 17.05.06

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Nov 20 14:10:04 2017
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 20 Nov 2017 13:10:04 +0000
Subject: [Koha-bugs] [Bug 19487] Internal server error when writing off lost
 fine for item not checked out
In-Reply-To: <bug-19487-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-19487-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-19487-70-8e28OGqgxa@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19487

Fridolin SOMERS <fridolin.somers at biblibre.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Pushed to Master            |Pushed to Stable
                 CC|                            |fridolin.somers at biblibre.co
                   |                            |m

--- Comment #14 from Fridolin SOMERS <fridolin.somers at biblibre.com> ---
Pushed to 17.05.x, will be in 17.05.06

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Nov 20 14:10:28 2017
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 20 Nov 2017 13:10:28 +0000
Subject: [Koha-bugs] [Bug 19513] More changes to MarkIssueReturned.t (after
	bug 19487)
In-Reply-To: <bug-19513-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-19513-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-19513-70-bt3QdTzg3Q@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19513

Fridolin SOMERS <fridolin.somers at biblibre.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
         Resolution|---                         |FIXED
                 CC|                            |fridolin.somers at biblibre.co
                   |                            |m
             Status|Pushed to Master            |RESOLVED

--- Comment #6 from Fridolin SOMERS <fridolin.somers at biblibre.com> ---
Enhancement not pushed to 17.05.x

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Nov 20 14:21:31 2017
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 20 Nov 2017 13:21:31 +0000
Subject: [Koha-bugs] [Bug 19431] Error when trying to checkout an unknown
	barcode
In-Reply-To: <bug-19431-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-19431-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-19431-70-GGYFwTofkv@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19431

Fridolin SOMERS <fridolin.somers at biblibre.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
         Resolution|---                         |FIXED
                 CC|                            |fridolin.somers at biblibre.co
                   |                            |m
             Status|Pushed to Master            |RESOLVED

--- Comment #19 from Fridolin SOMERS <fridolin.somers at biblibre.com> ---
Does not appear in 17.05.x

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Nov 20 14:25:13 2017
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 20 Nov 2017 13:25:13 +0000
Subject: [Koha-bugs] [Bug 18884] Advanced search on staff client,
 Availability limit not properly limiting
In-Reply-To: <bug-18884-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-18884-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-18884-70-1m35c9RAIK@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18884

Fridolin SOMERS <fridolin.somers at biblibre.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |fridolin.somers at biblibre.co
                   |                            |m
             Status|Pushed to Master            |Pushed to Stable

--- Comment #10 from Fridolin SOMERS <fridolin.somers at biblibre.com> ---
Pushed to 17.05.x, will be in 17.05.06

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Nov 20 14:32:38 2017
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 20 Nov 2017 13:32:38 +0000
Subject: [Koha-bugs] [Bug 19503] Duplicating a dropdown menu subfield yields
 an empty subfield tag
In-Reply-To: <bug-19503-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-19503-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-19503-70-5A8WpfS5R7@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19503

Fridolin SOMERS <fridolin.somers at biblibre.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Pushed to Master            |Pushed to Stable
                 CC|                            |fridolin.somers at biblibre.co
                   |                            |m

--- Comment #5 from Fridolin SOMERS <fridolin.somers at biblibre.com> ---
Pushed to 17.05.x, will be in 17.05.06

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Nov 20 14:36:07 2017
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 20 Nov 2017 13:36:07 +0000
Subject: [Koha-bugs] [Bug 19539] Editing rules that contain 'Unlimited'
 values produces invalid data
In-Reply-To: <bug-19539-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-19539-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-19539-70-axu67MPtpC@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19539

Fridolin SOMERS <fridolin.somers at biblibre.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |fridolin.somers at biblibre.co
                   |                            |m
         Resolution|---                         |FIXED
             Status|Pushed to Master            |RESOLVED

--- Comment #9 from Fridolin SOMERS <fridolin.somers at biblibre.com> ---
Bug 18857 not in 17.05.x

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Nov 20 14:36:08 2017
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 20 Nov 2017 13:36:08 +0000
Subject: [Koha-bugs] [Bug 15486] Restrict number of holds placed by day
In-Reply-To: <bug-15486-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-15486-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-15486-70-1wcCHD7aX6@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15486
Bug 15486 depends on bug 19539, which changed state.

Bug 19539 Summary: Editing rules that contain 'Unlimited' values produces invalid data
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19539

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Pushed to Master            |RESOLVED
         Resolution|---                         |FIXED

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Nov 20 15:29:55 2017
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 20 Nov 2017 14:29:55 +0000
Subject: [Koha-bugs] [Bug 18591] Allow an arbitrary number of comments on
	ILLs
In-Reply-To: <bug-18591-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-18591-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-18591-70-6L7v8fKwaw@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18591

Magnus Enger <magnus at libriotech.no> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|NEW                         |Needs Signoff
   Patch complexity|---                         |Small patch

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Nov 20 15:29:58 2017
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 20 Nov 2017 14:29:58 +0000
Subject: [Koha-bugs] [Bug 18591] Allow an arbitrary number of comments on
	ILLs
In-Reply-To: <bug-18591-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-18591-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-18591-70-r8rX7How2E@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18591

--- Comment #2 from Magnus Enger <magnus at libriotech.no> ---
Created attachment 69234
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=69234&action=edit
Bug 18591 - Allow any number of comments on ILLs

This patch makes it possible to add arbitrary comments to ILL
requests. Comments are read only and displayed in chronological
order. Comments can be added by librarians, but also added automatically
based on comments in the different protocols, so that comments from the
lending library can also be added.

To test:
- Enable the ILL module ("ILLModule" syspref + config in koha-conf.xml)
- Install the Dummy backend from here:
  https://github.com/PTFS-Europe/Dummy
- Create a Dummy ILL request
- Add comments to the request, checking that the name and borrowernumber
  of the person that added the comment is displayed ok
- Check that the displayed date and time the comment was submitted follows
  the "dateformat" syspref
- On the "List requests" page, check that the correct number of comments
  is displayed in the "Comments" column
- Check that the tests pass:
  prove t/db_dependent/Illcomments.t

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Nov 20 15:50:12 2017
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 20 Nov 2017 14:50:12 +0000
Subject: [Koha-bugs] [Bug 19653] New: Move tools templates JavaScript to the
 footer: Additional tools
Message-ID: <bug-19653-70@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19653

            Bug ID: 19653
           Summary: Move tools templates JavaScript to the footer:
                    Additional tools
 Change sponsored?: ---
           Product: Koha
           Version: master
          Hardware: All
                OS: All
            Status: ASSIGNED
          Severity: enhancement
          Priority: P5 - low
         Component: Templates
          Assignee: oleonard at myacpl.org
          Reporter: oleonard at myacpl.org
        QA Contact: testopia at bugs.koha-community.org
                CC: dominic.pichette at inlibro.com,
                    jonathan.druart at bugs.koha-community.org,
                    nick at bywatersolutions.com, simon.pouchol at biblibre.com,
                    testopia at bugs.koha-community.org
        Depends on: 19647
            Blocks: 17858

In order to conform to best practices for performance staff client template
javascript should be in the footer instead of the header.

This patch will do so for the templates in the "Additional tools" section.


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17858
[Bug 17858] Omnibus: Move staff client JavaScript to the footer
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19647
[Bug 19647] Move patron lists templates JS to the footer
-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Nov 20 15:50:12 2017
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 20 Nov 2017 14:50:12 +0000
Subject: [Koha-bugs] [Bug 19647] Move patron lists templates JS to the footer
In-Reply-To: <bug-19647-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-19647-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-19647-70-yV7QbUcBph@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19647

Owen Leonard <oleonard at myacpl.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Blocks|                            |19653


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19653
[Bug 19653] Move tools templates JavaScript to the footer: Additional tools
-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Nov 20 15:50:12 2017
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 20 Nov 2017 14:50:12 +0000
Subject: [Koha-bugs] [Bug 17858] Omnibus: Move staff client JavaScript to
	the footer
In-Reply-To: <bug-17858-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-17858-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-17858-70-1jMXOLu0NZ@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17858

Owen Leonard <oleonard at myacpl.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
         Depends on|                            |19653


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19653
[Bug 19653] Move tools templates JavaScript to the footer: Additional tools
-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Nov 20 16:00:52 2017
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 20 Nov 2017 15:00:52 +0000
Subject: [Koha-bugs] [Bug 14697] Extend and enhance "Claims returned" lost
	status
In-Reply-To: <bug-14697-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-14697-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-14697-70-5sVjTvT9TR@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14697

Jessie Zairo <jzairo at bywatersolutions.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |jzairo at bywatersolutions.com

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Nov 20 17:02:31 2017
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 20 Nov 2017 16:02:31 +0000
Subject: [Koha-bugs] [Bug 19654] New: Move tools templates JavaScript to the
 footer: Batch MARC tools
Message-ID: <bug-19654-70@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19654

            Bug ID: 19654
           Summary: Move tools templates JavaScript to the footer: Batch
                    MARC tools
 Change sponsored?: ---
           Product: Koha
           Version: master
          Hardware: All
                OS: All
            Status: ASSIGNED
          Severity: enhancement
          Priority: P5 - low
         Component: Templates
          Assignee: oleonard at myacpl.org
          Reporter: oleonard at myacpl.org
        QA Contact: testopia at bugs.koha-community.org
                CC: dominic.pichette at inlibro.com,
                    jonathan.druart at bugs.koha-community.org,
                    nick at bywatersolutions.com, simon.pouchol at biblibre.com,
                    testopia at bugs.koha-community.org
        Depends on: 19647
            Blocks: 17858

In order to conform to best practices for performance staff client template
javascript should be in the footer instead of the header.

This patch will do so for the batch MARC tools templates.


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17858
[Bug 17858] Omnibus: Move staff client JavaScript to the footer
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19647
[Bug 19647] Move patron lists templates JS to the footer
-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Nov 20 17:02:31 2017
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 20 Nov 2017 16:02:31 +0000
Subject: [Koha-bugs] [Bug 19647] Move patron lists templates JS to the footer
In-Reply-To: <bug-19647-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-19647-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-19647-70-cpUai7D2KU@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19647

Owen Leonard <oleonard at myacpl.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Blocks|                            |19654


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19654
[Bug 19654] Move tools templates JavaScript to the footer: Batch MARC tools
-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Nov 20 17:02:31 2017
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 20 Nov 2017 16:02:31 +0000
Subject: [Koha-bugs] [Bug 17858] Omnibus: Move staff client JavaScript to
	the footer
In-Reply-To: <bug-17858-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-17858-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-17858-70-y47yUyJLmI@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17858

Owen Leonard <oleonard at myacpl.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
         Depends on|                            |19654


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19654
[Bug 19654] Move tools templates JavaScript to the footer: Batch MARC tools
-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Nov 20 17:04:42 2017
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 20 Nov 2017 16:04:42 +0000
Subject: [Koha-bugs] [Bug 19655] New: To.json doesn' t escape newlines which
 can create invalid JSON
Message-ID: <bug-19655-70@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19655

            Bug ID: 19655
           Summary: To.json doesn't escape newlines which can create
                    invalid JSON
 Change sponsored?: ---
           Product: Koha
           Version: master
          Hardware: All
                OS: All
            Status: NEW
          Severity: enhancement
          Priority: P5 - low
         Component: Architecture, internals, and plumbing
          Assignee: koha-bugs at lists.koha-community.org
          Reporter: kyle at bywatersolutions.com
        QA Contact: testopia at bugs.koha-community.org

JSON does not allow real line-breaks. If a field contains them and they are not
escaped, a JSON parser will be unable to convert the stringified JSON back into
an object.

This is clearly exemplified by the guarantor search, where a multi-line note on
the guarantor's record will break the ability to select that guarantor.

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Nov 20 17:05:55 2017
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 20 Nov 2017 16:05:55 +0000
Subject: [Koha-bugs] [Bug 19655] To.json doesn't escape newlines which can
 create invalid JSON
In-Reply-To: <bug-19655-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-19655-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-19655-70-BWJK2DOW6w@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19655

Kyle M Hall <kyle at bywatersolutions.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
           Severity|enhancement                 |critical
           Assignee|koha-bugs at lists.koha-commun |kyle at bywatersolutions.com
                   |ity.org                     |

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.

From bugzilla-daemon at bugs.koha-community.org  Mon Nov 20 17:08:03 2017
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 20 Nov 2017 16:08:03 +0000
Subject: [Koha-bugs] [Bug 19655] To.json doesn't escape newlines which can
 create invalid JSON
In-Reply-To: <bug-19655-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-19655-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-19655-70-eUkXr4OT4z@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19655

Kyle M Hall <kyle at bywatersolutions.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|NEW                         |Needs Signoff

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Nov 20 17:08:05 2017
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 20 Nov 2017 16:08:05 +0000
Subject: [Koha-bugs] [Bug 19655] To.json doesn't escape newlines which can
 create invalid JSON
In-Reply-To: <bug-19655-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-19655-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-19655-70-FOCSF1Cw7x@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19655

--- Comment #1 from Kyle M Hall <kyle at bywatersolutions.com> ---
Created attachment 69235
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=69235&action=edit
Bug 19655 - To.json doesn't escape newlines which can create invalid JSON

JSON does not allow real line-breaks. If a field contains them and they are not
escaped, a JSON parser will be unable to convert the stringified JSON back into
an object.

This is clearly exemplified by the guarantor search, where a multi-line note on
the guarantor's record will break the ability to select that guarantor.

Test Plan:
1) Create Patron A with a "Circulation note" that has multiple lines in it
2) Create Patron B
3) Attempt to set Patron A to be the guarantor for Patron B
4) Note selecting the patron does nothing
5) Apply this patch
6) Repeat step 3
7) Selecting the guarantor now works!

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Nov 20 17:12:33 2017
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 20 Nov 2017 16:12:33 +0000
Subject: [Koha-bugs] [Bug 19654] Move tools templates JavaScript to the
 footer: Batch MARC tools
In-Reply-To: <bug-19654-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-19654-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-19654-70-I8Ew4dP13a@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19654

Owen Leonard <oleonard at myacpl.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|ASSIGNED                    |Needs Signoff
   Patch complexity|---                         |Small patch

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Nov 20 17:12:35 2017
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 20 Nov 2017 16:12:35 +0000
Subject: [Koha-bugs] [Bug 19654] Move tools templates JavaScript to the
 footer: Batch MARC tools
In-Reply-To: <bug-19654-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-19654-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-19654-70-mOdBSxxUSQ@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19654

--- Comment #1 from Owen Leonard <oleonard at myacpl.org> ---
Created attachment 69236
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=69236&action=edit
Bug 19654: Move tools templates JavaScript to the footer: Batch MARC tools

This patch modifies the staff client patron lists templates so that
JavaScript is included in the footer instead of the header.

To test, apply the patch and test the JavaScript-driven features of
each modified template: All button controls, DataTables functionality,
form validation, etc.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Nov 20 17:34:06 2017
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 20 Nov 2017 16:34:06 +0000
Subject: [Koha-bugs] [Bug 19656] New: Move rotating collections templates JS
 to the footer
Message-ID: <bug-19656-70@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19656

            Bug ID: 19656
           Summary: Move rotating collections templates JS to the footer
 Change sponsored?: ---
           Product: Koha
           Version: master
          Hardware: All
                OS: All
            Status: ASSIGNED
          Severity: enhancement
          Priority: P5 - low
         Component: Templates
          Assignee: oleonard at myacpl.org
          Reporter: oleonard at myacpl.org
        QA Contact: testopia at bugs.koha-community.org
                CC: jonathan.druart at bugs.koha-community.org,
                    nick at bywatersolutions.com, simon.pouchol at biblibre.com,
                    testopia at bugs.koha-community.org
        Depends on: 19627
            Blocks: 17858

In order to conform to best practices for performance, staff client template
JavaScript should be in the footer instead of the header.

This patch will do so for rotating collections templates.


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17858
[Bug 17858] Omnibus: Move staff client JavaScript to the footer
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19627
[Bug 19627] Move patron clubs templates JS to the footer
-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Nov 20 17:34:06 2017
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 20 Nov 2017 16:34:06 +0000
Subject: [Koha-bugs] [Bug 17858] Omnibus: Move staff client JavaScript to
	the footer
In-Reply-To: <bug-17858-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-17858-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-17858-70-On1KKEjdHw@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17858

Owen Leonard <oleonard at myacpl.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
         Depends on|                            |19656


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19656
[Bug 19656] Move rotating collections templates JS to the footer
-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Nov 20 17:34:20 2017
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 20 Nov 2017 16:34:20 +0000
Subject: [Koha-bugs] [Bug 14759] Replacement for Text::Unaccent
In-Reply-To: <bug-14759-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-14759-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-14759-70-18DXLFT3fj@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14759

--- Comment #27 from Colin Campbell <colin.campbell at ptfs-europe.com> ---
(In reply to David Cook from comment #26)
> (In reply to Colin Campbell from comment #25)
> > Text::Unaccent does not build on 64bit systems, the tests fail because of
> > errors in the ccode. There has been a patch for that for four years but it
> > looks like the upstream code is moribund. If you look at the test results it
> > now fails on all linux test builds. The module has not been kept up to date
> > to handle modern perl strings. I think the debian version may be patched to
> > fix the bug in 64bit tests but it is buggy and should not be relied on.
> > Suggest moving to Text::Unaccent::PurPerl be prioritized
> 
> Where are we using Text::Unaccent? Is it still just in userid strings?

I think that is the only location

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Nov 20 17:34:06 2017
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 20 Nov 2017 16:34:06 +0000
Subject: [Koha-bugs] [Bug 19627] Move patron clubs templates JS to the footer
In-Reply-To: <bug-19627-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-19627-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-19627-70-sGfUXInkKO@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19627

Owen Leonard <oleonard at myacpl.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Blocks|                            |19656


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19656
[Bug 19656] Move rotating collections templates JS to the footer
-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Nov 20 17:43:02 2017
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 20 Nov 2017 16:43:02 +0000
Subject: [Koha-bugs] [Bug 19656] Move rotating collections templates JS to
	the footer
In-Reply-To: <bug-19656-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-19656-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-19656-70-JC6EaPGUlX@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19656

Owen Leonard <oleonard at myacpl.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|ASSIGNED                    |Needs Signoff
   Patch complexity|---                         |Small patch

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Nov 20 17:43:04 2017
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 20 Nov 2017 16:43:04 +0000
Subject: [Koha-bugs] [Bug 19656] Move rotating collections templates JS to
	the footer
In-Reply-To: <bug-19656-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-19656-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-19656-70-5DLS2C9Ryx@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19656

--- Comment #1 from Owen Leonard <oleonard at myacpl.org> ---
Created attachment 69237
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=69237&action=edit
Bug 19656: Move rotating collections templates JS to the footer

This patch modifies the staff client's rotating collections templates so
that JavaScript is included in the footer instead of the header.

The patch moves JavaScript from each template and the rotating
collections toolbar into a single external JavaScript file.

To test, apply the patch and test the JavaScript-driven features of
each page: All button controls, DataTables functionality, form
validation, etc.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Nov 20 17:47:40 2017
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 20 Nov 2017 16:47:40 +0000
Subject: [Koha-bugs] [Bug 19657] New: Move lists templates JS to the footer
Message-ID: <bug-19657-70@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19657

            Bug ID: 19657
           Summary: Move lists templates JS to the footer
 Change sponsored?: ---
           Product: Koha
           Version: master
          Hardware: All
                OS: All
            Status: ASSIGNED
          Severity: enhancement
          Priority: P5 - low
         Component: Templates
          Assignee: oleonard at myacpl.org
          Reporter: oleonard at myacpl.org
        QA Contact: testopia at bugs.koha-community.org
                CC: jonathan.druart at bugs.koha-community.org,
                    nick at bywatersolutions.com, simon.pouchol at biblibre.com,
                    testopia at bugs.koha-community.org
            Blocks: 17858

In order to conform to best practices for performance, staff client template
JavaScript should be in the footer instead of the header.

This patch will do so for lists templates.


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17858
[Bug 17858] Omnibus: Move staff client JavaScript to the footer
-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Nov 20 17:47:40 2017
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 20 Nov 2017 16:47:40 +0000
Subject: [Koha-bugs] [Bug 17858] Omnibus: Move staff client JavaScript to
	the footer
In-Reply-To: <bug-17858-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-17858-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-17858-70-z253x7k1Ai@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17858

Owen Leonard <oleonard at myacpl.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
         Depends on|                            |19657


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19657
[Bug 19657] Move lists templates JS to the footer
-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Nov 20 17:49:29 2017
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 20 Nov 2017 16:49:29 +0000
Subject: [Koha-bugs] [Bug 19637] jsPrintSetup not supported in Firefox
	Quantum
In-Reply-To: <bug-19637-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-19637-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-19637-70-Ru5IRpsyGW@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19637

--- Comment #3 from Mike <black23 at gmail.com> ---
Hello,
Firefox stop print without customer permission. It's look like end of silent
printing in Firefox.

---Snip---
"Just to be clear, the goal of WebExtensions is an API in a web browser to
improve users interaction with web content. Supporting POS systems is not part
of the goal for WebExtensions. Every feature we add has a cost on Mozilla in
terms of development and maintenance so we evaluate each API. There are some
improvements that around printing that have landed and perhaps there's a couple
of APIs that could be split out from that bug.

If you want to provide more sophisticated printing solutions or support POS
systems, you might need to find a different solution other than Firefox. You
can pass data through the nativeMessaging API which can do the printing for
you, as an example.

For the moment, we'll close the comments on this bug as it's currently not
being productive."
Source: https://bugzilla.mozilla.org/show_bug.cgi?id=1385827
---End snip---

So, now we can start debate about long time solution. Maybe outside Firefox or
based on Firefox about:config setiings for smooth printing from Koha with
printing dialog.

WebUSB API can be solution, for many USB POS printers, but it's partially
implemented in Chrome not in Firefox.
https://wicg.github.io/webusb/#introduction

But it brings too much questions about security how describe this article
https://wicg.github.io/webusb/#security-and-privacy. Firefox decide cut off JS
driven printing due security reasons.

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.

From bugzilla-daemon at bugs.koha-community.org  Mon Nov 20 18:08:04 2017
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 20 Nov 2017 17:08:04 +0000
Subject: [Koha-bugs] [Bug 19657] Move lists templates JS to the footer
In-Reply-To: <bug-19657-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-19657-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-19657-70-EwgzVzMDfv@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19657

Owen Leonard <oleonard at myacpl.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|ASSIGNED                    |Needs Signoff
   Patch complexity|---                         |Small patch

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Nov 20 18:08:06 2017
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 20 Nov 2017 17:08:06 +0000
Subject: [Koha-bugs] [Bug 19657] Move lists templates JS to the footer
In-Reply-To: <bug-19657-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-19657-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-19657-70-wmM4ez7AzB@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19657

--- Comment #1 from Owen Leonard <oleonard at myacpl.org> ---
Created attachment 69238
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=69238&action=edit
Bug 19657: Move lists templates JS to the footer

This patch modifies the staff client's lists templates so that
JavaScript is included in the footer instead of the header.

To test, apply the patch and test the JavaScript-driven features of the
lists page: All button controls, DataTables functionality, form
validation, etc.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Nov 20 18:25:40 2017
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 20 Nov 2017 17:25:40 +0000
Subject: [Koha-bugs] [Bug 19658] New: Style fix for staff client lists page
Message-ID: <bug-19658-70@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19658

            Bug ID: 19658
           Summary: Style fix for staff client lists page
 Change sponsored?: ---
           Product: Koha
           Version: master
          Hardware: All
                OS: All
            Status: ASSIGNED
          Severity: enhancement
          Priority: P5 - low
         Component: Lists
          Assignee: koha-bugs at lists.koha-community.org
          Reporter: oleonard at myacpl.org
        QA Contact: testopia at bugs.koha-community.org
                CC: m.de.rooy at rijksmuseum.nl

The add barcode/biblionumber textareas in the sidebar look sloppy because they
overflow their containers. Also, the markup of the sidebar could be made to
more closely match similar forms.

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.

From bugzilla-daemon at bugs.koha-community.org  Mon Nov 20 18:31:43 2017
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 20 Nov 2017 17:31:43 +0000
Subject: [Koha-bugs] [Bug 19658] Style fix for staff client lists page
In-Reply-To: <bug-19658-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-19658-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-19658-70-Q1KSNDTzzc@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19658

Owen Leonard <oleonard at myacpl.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
   Patch complexity|---                         |Trivial patch
             Status|ASSIGNED                    |Needs Signoff

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.

From bugzilla-daemon at bugs.koha-community.org  Mon Nov 20 18:31:45 2017
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 20 Nov 2017 17:31:45 +0000
Subject: [Koha-bugs] [Bug 19658] Style fix for staff client lists page
In-Reply-To: <bug-19658-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-19658-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-19658-70-xLAqdYUkGX@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19658

--- Comment #1 from Owen Leonard <oleonard at myacpl.org> ---
Created attachment 69239
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=69239&action=edit
Bug 19658: Style fix for staff client lists page

This patch makes a small style change so that the add
barcode/biblionumber textareas don't overflow their container.

<legend> is changed to <h4> in order to make this sidebar match similar
sidebars.

To test, apply the patch and open a list which you have permission to
add items to. The "add items" form in the sidebar should look good.

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.

From bugzilla-daemon at bugs.koha-community.org  Mon Nov 20 19:04:20 2017
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 20 Nov 2017 18:04:20 +0000
Subject: [Koha-bugs] [Bug 19659] New: Move JS to the footer: Suggestions and
	tags
Message-ID: <bug-19659-70@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19659

            Bug ID: 19659
           Summary: Move JS to the footer: Suggestions and tags
 Change sponsored?: ---
           Product: Koha
           Version: master
          Hardware: All
                OS: All
            Status: ASSIGNED
          Severity: enhancement
          Priority: P5 - low
         Component: Templates
          Assignee: oleonard at myacpl.org
          Reporter: oleonard at myacpl.org
        QA Contact: testopia at bugs.koha-community.org
                CC: jonathan.druart at bugs.koha-community.org,
                    nick at bywatersolutions.com, simon.pouchol at biblibre.com,
                    testopia at bugs.koha-community.org
            Blocks: 17858

In order to conform to best practices for performance, staff client template
JavaScript should be in the footer instead of the header.

This patch will do so for suggestions and tags templates.


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17858
[Bug 17858] Omnibus: Move staff client JavaScript to the footer
-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Nov 20 19:04:20 2017
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 20 Nov 2017 18:04:20 +0000
Subject: [Koha-bugs] [Bug 17858] Omnibus: Move staff client JavaScript to
	the footer
In-Reply-To: <bug-17858-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-17858-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-17858-70-fOhpkzzIMd@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17858

Owen Leonard <oleonard at myacpl.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
         Depends on|                            |19659


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19659
[Bug 19659] Move JS to the footer: Suggestions and tags
-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Nov 20 19:29:32 2017
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 20 Nov 2017 18:29:32 +0000
Subject: [Koha-bugs] [Bug 19659] Move JS to the footer: Suggestions and tags
In-Reply-To: <bug-19659-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-19659-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-19659-70-CHQft3TGAJ@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19659

Owen Leonard <oleonard at myacpl.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
   Patch complexity|---                         |Small patch
             Status|ASSIGNED                    |Needs Signoff

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Nov 20 19:29:35 2017
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 20 Nov 2017 18:29:35 +0000
Subject: [Koha-bugs] [Bug 19659] Move JS to the footer: Suggestions and tags
In-Reply-To: <bug-19659-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-19659-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-19659-70-AwC8TBSgO2@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19659

--- Comment #1 from Owen Leonard <oleonard at myacpl.org> ---
Created attachment 69240
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=69240&action=edit
Bug 19659: Move JS to the footer: Suggestions and tags

This patch modifies the staff client's suggestions and tags templates so
that JavaScript is included in the footer instead of the header.

To test, apply the patch and test the JavaScript-driven features of
suggestions and tags pages: All button controls, DataTables
functionality, form validation, etc.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Nov 20 22:22:52 2017
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 20 Nov 2017 21:22:52 +0000
Subject: [Koha-bugs] [Bug 18616] The "Add forgot password link to OPAC"
 should allow patrons to use their library card number in addition to
 username
In-Reply-To: <bug-18616-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-18616-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-18616-70-Gn9yqqyIwF@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18616

--- Comment #22 from Katrin Fischer <katrin.fischer at bsz-bw.de> ---
This patch has been pushed to 16.11.x and will be in 16.11.14.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Nov 20 22:24:04 2017
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 20 Nov 2017 21:24:04 +0000
Subject: [Koha-bugs] [Bug 19495] Automatic report conversion needs to do
 global replace on ' biblioitems' and 'marcxml'
In-Reply-To: <bug-19495-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-19495-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-19495-70-yXABKQkuH7@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19495

Katrin Fischer <katrin.fischer at bsz-bw.de> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |katrin.fischer at bsz-bw.de
         Resolution|---                         |FIXED
             Status|Pushed to Stable            |RESOLVED

--- Comment #9 from Katrin Fischer <katrin.fischer at bsz-bw.de> ---
Dependency is not in 16.11.x - patch is not needed.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Nov 20 22:31:25 2017
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 20 Nov 2017 21:31:25 +0000
Subject: [Koha-bugs] [Bug 19487] Internal server error when writing off lost
 fine for item not checked out
In-Reply-To: <bug-19487-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-19487-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-19487-70-b5cT1JHcA2@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19487

Katrin Fischer <katrin.fischer at bsz-bw.de> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |katrin.fischer at bsz-bw.de

--- Comment #15 from Katrin Fischer <katrin.fischer at bsz-bw.de> ---
These patches have been pushed to 16.11.x and will be in 16.11.14.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Nov 20 22:38:05 2017
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 20 Nov 2017 21:38:05 +0000
Subject: [Koha-bugs] [Bug 18884] Advanced search on staff client,
 Availability limit not properly limiting
In-Reply-To: <bug-18884-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-18884-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-18884-70-w8vv6lNMaX@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18884

Katrin Fischer <katrin.fischer at bsz-bw.de> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |katrin.fischer at bsz-bw.de

--- Comment #11 from Katrin Fischer <katrin.fischer at bsz-bw.de> ---
Patch was pushed to 16.11.x, will be in 16.11.14

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Nov 21 00:43:30 2017
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 20 Nov 2017 23:43:30 +0000
Subject: [Koha-bugs] [Bug 19658] Style fix for staff client lists page
In-Reply-To: <bug-19658-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-19658-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-19658-70-irum4eRrAk@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19658

Dilan Johnpull? <dilan at calyx.net.au> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Needs Signoff               |Signed Off

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.

From bugzilla-daemon at bugs.koha-community.org  Tue Nov 21 00:43:34 2017
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 20 Nov 2017 23:43:34 +0000
Subject: [Koha-bugs] [Bug 19658] Style fix for staff client lists page
In-Reply-To: <bug-19658-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-19658-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-19658-70-DQ7wLQQhPQ@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19658

Dilan Johnpull? <dilan at calyx.net.au> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #69239|0                           |1
        is obsolete|                            |

--- Comment #2 from Dilan Johnpull? <dilan at calyx.net.au> ---
Created attachment 69241
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=69241&action=edit
Bug 19658: Style fix for staff client lists page

Patch applies with no issues and works as described.

Signed-off-by: Dilan Johnpull? <dilan at calyx.net.au>

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Nov 21 04:27:45 2017
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 21 Nov 2017 03:27:45 +0000
Subject: [Koha-bugs] [Bug 19660] New: Set borrower password on first login
 from self registration
Message-ID: <bug-19660-70@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19660

            Bug ID: 19660
           Summary: Set borrower password on first login from self
                    registration
 Change sponsored?: ---
           Product: Koha
           Version: master
          Hardware: All
                OS: All
            Status: NEW
          Severity: enhancement
          Priority: P5 - low
         Component: OPAC
          Assignee: oleonard at myacpl.org
          Reporter: liz at catalyst.net.nz
        QA Contact: testopia at bugs.koha-community.org

Currently when a borrower has confirmed their account, we show them their
username and password after confirmation. I propose instead of doing this, we
allow the user to set their own password after they have confirmed their
account. 

We could use parts of the forgot-my-password code to do this, for example
pre-populating the username/email bits of the form, and asking the user to fill
in their new password twice.

We really shouldn't be showing the password on the screen, ever. Let's not do
that anymore.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Nov 21 06:07:46 2017
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 21 Nov 2017 05:07:46 +0000
Subject: [Koha-bugs] [Bug 19596] Internal server error if open order with
 deleted biblio / null biblionumber
In-Reply-To: <bug-19596-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-19596-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-19596-70-jXm0VMoQXz@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19596

Dilan Johnpull? <dilan at calyx.net.au> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Needs Signoff               |Signed Off

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Nov 21 06:07:52 2017
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 21 Nov 2017 05:07:52 +0000
Subject: [Koha-bugs] [Bug 19596] Internal server error if open order with
 deleted biblio / null biblionumber
In-Reply-To: <bug-19596-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-19596-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-19596-70-K0ShNMWrwS@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19596

Dilan Johnpull? <dilan at calyx.net.au> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #69047|0                           |1
        is obsolete|                            |

--- Comment #5 from Dilan Johnpull? <dilan at calyx.net.au> ---
Created attachment 69242
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=69242&action=edit
Bug 19596 - Don't try to get hold or items count for non-existent biblios

Patch applies and works as expected.
Signed-off-by: Dilan Johnpull? <dilan at calyx.net.au>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Nov 21 08:52:11 2017
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 21 Nov 2017 07:52:11 +0000
Subject: [Koha-bugs] [Bug 19661] New: Funds endpoint
Message-ID: <bug-19661-70@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19661

            Bug ID: 19661
           Summary: Funds endpoint
 Change sponsored?: ---
           Product: Koha
           Version: master
          Hardware: All
                OS: All
            Status: NEW
          Severity: enhancement
          Priority: P5 - low
         Component: REST api
          Assignee: koha-bugs at lists.koha-community.org
          Reporter: matthias.meusburger at biblibre.com

This patch adds a new route to the REST api:

api/v1/acquisitions/funds/

It allows to retrieve funds informations, possibly using filters.

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Nov 21 08:53:08 2017
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 21 Nov 2017 07:53:08 +0000
Subject: [Koha-bugs] [Bug 19661] Funds endpoint
In-Reply-To: <bug-19661-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-19661-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-19661-70-bdJu0SIbY9@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19661

--- Comment #1 from Matthias Meusburger <matthias.meusburger at biblibre.com> ---
Created attachment 69243
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=69243&action=edit
REST API: Funds Endpoint

This patch adds a new route to the REST api:

api/v1/acquisitions/funds/

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.

From bugzilla-daemon at bugs.koha-community.org  Tue Nov 21 08:53:22 2017
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 21 Nov 2017 07:53:22 +0000
Subject: [Koha-bugs] [Bug 19661] Funds endpoint
In-Reply-To: <bug-19661-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-19661-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-19661-70-BTAzc0AVnE@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19661

Matthias Meusburger <matthias.meusburger at biblibre.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|NEW                         |Needs Signoff

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.

From bugzilla-daemon at bugs.koha-community.org  Tue Nov 21 11:12:13 2017
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 21 Nov 2017 10:12:13 +0000
Subject: [Koha-bugs] [Bug 19249] Date picker broken in "Quick add new
	patron" form
In-Reply-To: <bug-19249-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-19249-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-19249-70-MhJslGh64K@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19249

Fridolin SOMERS <fridolin.somers at biblibre.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
           Assignee|nick at bywatersolutions.com   |fridolin.somers at biblibre.co
                   |                            |m

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Nov 21 14:18:39 2017
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 21 Nov 2017 13:18:39 +0000
Subject: [Koha-bugs] [Bug 19655] To.json doesn't escape newlines which can
 create invalid JSON
In-Reply-To: <bug-19655-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-19655-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-19655-70-yAbrI8nU3B@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19655

Simon Pouchol <simon.pouchol at biblibre.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #69235|0                           |1
        is obsolete|                            |

--- Comment #2 from Simon Pouchol <simon.pouchol at biblibre.com> ---
Created attachment 69244
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=69244&action=edit
Bug 19655 - To.json doesn't escape newlines which can create invalid JSON

JSON does not allow real line-breaks. If a field contains them and they are not
escaped, a JSON parser will be unable to convert the stringified JSON back into
an object.

This is clearly exemplified by the guarantor search, where a multi-line note on
the guarantor's record will break the ability to select that guarantor.

Test Plan:
1) Create Patron A with a "Circulation note" that has multiple lines in it
2) Create Patron B
3) Attempt to set Patron A to be the guarantor for Patron B
4) Note selecting the patron does nothing
5) Apply this patch
6) Repeat step 3
7) Selecting the guarantor now works!

Signed-off-by: Simon Pouchol <simon.pouchol at biblibre.com>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Nov 21 14:18:56 2017
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 21 Nov 2017 13:18:56 +0000
Subject: [Koha-bugs] [Bug 19655] To.json doesn't escape newlines which can
 create invalid JSON
In-Reply-To: <bug-19655-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-19655-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-19655-70-y1bwoGWcJY@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19655

Simon Pouchol <simon.pouchol at biblibre.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |simon.pouchol at biblibre.com
             Status|Needs Signoff               |Signed Off

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Nov 21 14:20:49 2017
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 21 Nov 2017 13:20:49 +0000
Subject: [Koha-bugs] [Bug 17858] Omnibus: Move staff client JavaScript to
	the footer
In-Reply-To: <bug-17858-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-17858-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-17858-70-OfDJHkdIPX@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17858

Owen Leonard <oleonard at myacpl.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
         Depends on|                            |19663


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19663
[Bug 19663] Move JS to the footer: Reports
-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Nov 21 14:20:49 2017
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 21 Nov 2017 13:20:49 +0000
Subject: [Koha-bugs] [Bug 19663] New: Move JS to the footer: Reports
Message-ID: <bug-19663-70@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19663

            Bug ID: 19663
           Summary: Move JS to the footer: Reports
 Change sponsored?: ---
           Product: Koha
           Version: master
          Hardware: All
                OS: All
            Status: ASSIGNED
          Severity: enhancement
          Priority: P5 - low
         Component: Templates
          Assignee: oleonard at myacpl.org
          Reporter: oleonard at myacpl.org
        QA Contact: testopia at bugs.koha-community.org
                CC: jonathan.druart at bugs.koha-community.org,
                    nick at bywatersolutions.com, simon.pouchol at biblibre.com,
                    testopia at bugs.koha-community.org
            Blocks: 17858

In order to conform to best practices for performance, staff client template
JavaScript should be in the footer instead of the header.

This patch will do so for reports templates.


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17858
[Bug 17858] Omnibus: Move staff client JavaScript to the footer
-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Nov 21 14:23:37 2017
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 21 Nov 2017 13:23:37 +0000
Subject: [Koha-bugs] [Bug 19410] Koha::Objects needs a ->search_for_api
	method
In-Reply-To: <bug-19410-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-19410-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-19410-70-4usLX3cltb@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19410

--- Comment #9 from Tom?s Cohen Arazi <tomascohen at gmail.com> ---
(In reply to Julian Maurice from comment #8)
> It feels like search_for_api would fit better as a Mojo helper, given that
> it mostly call other helpers :
> 
>     $vendors = $c->search('Koha::Acquisition::Booksellers');
> 
> What do you think ?

my $plural_object = Koha::Acquisition::Booksellers->new;
my $vendors = $c->object_search( $plural_object );

?

I'm not sure how to call $plural_object :-P

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Nov 21 14:30:30 2017
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 21 Nov 2017 13:30:30 +0000
Subject: [Koha-bugs] [Bug 19664] New: Reports sidebar menu should match list
 of reports on reports home page
Message-ID: <bug-19664-70@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19664

            Bug ID: 19664
           Summary: Reports sidebar menu should match list of reports on
                    reports home page
 Change sponsored?: ---
           Product: Koha
           Version: master
          Hardware: All
                OS: All
            Status: ASSIGNED
          Severity: enhancement
          Priority: P5 - low
         Component: Reports
          Assignee: koha-bugs at lists.koha-community.org
          Reporter: oleonard at myacpl.org
        QA Contact: testopia at bugs.koha-community.org

There are a few items on the reports home page which could be added to the
reports sidebar menu.

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Nov 21 14:36:45 2017
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 21 Nov 2017 13:36:45 +0000
Subject: [Koha-bugs] [Bug 19664] Reports sidebar menu should match list of
 reports on reports home page
In-Reply-To: <bug-19664-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-19664-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-19664-70-rwm9agvFLT@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19664

--- Comment #1 from Owen Leonard <oleonard at myacpl.org> ---
Created attachment 69245
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=69245&action=edit
Bug 19664: Reports sidebar menu should match list of reports on reports home
page

This patch makes the reports sidebar menu a little more consistent with
the reports home page menu by adding missing links to reports.

To test, observer the reports sidebar menu before and after the patch
and confirm that missing reports are linked in the update.

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Nov 21 14:36:43 2017
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 21 Nov 2017 13:36:43 +0000
Subject: [Koha-bugs] [Bug 19664] Reports sidebar menu should match list of
 reports on reports home page
In-Reply-To: <bug-19664-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-19664-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-19664-70-sk6xuP3u28@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19664

Owen Leonard <oleonard at myacpl.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
   Patch complexity|---                         |Trivial patch
             Status|ASSIGNED                    |Needs Signoff

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Nov 21 14:49:57 2017
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 21 Nov 2017 13:49:57 +0000
Subject: [Koha-bugs] [Bug 19669] New: Remove deprecated report
Message-ID: <bug-19669-70@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19669

            Bug ID: 19669
           Summary: Remove deprecated report
 Change sponsored?: ---
           Product: Koha
           Version: master
          Hardware: All
                OS: All
            Status: NEW
          Severity: minor
          Priority: P5 - low
         Component: Reports
          Assignee: koha-bugs at lists.koha-community.org
          Reporter: oleonard at myacpl.org
        QA Contact: testopia at bugs.koha-community.org

Koha has a report which isn't linked to from anywhere. A comment on Bug 840
says that the report is deprecated. I propose that thirteen years is enough of
a wait and we should probably go ahead and remove it.

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.

From bugzilla-daemon at bugs.koha-community.org  Tue Nov 21 14:51:11 2017
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 21 Nov 2017 13:51:11 +0000
Subject: [Koha-bugs] [Bug 19669] Remove deprecated checkouts by patron
	category report
In-Reply-To: <bug-19669-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-19669-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-19669-70-Lo2PGT2drW@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19669

Owen Leonard <oleonard at myacpl.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|NEW                         |ASSIGNED
            Summary|Remove deprecated report    |Remove deprecated checkouts
                   |                            |by patron category report

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.

From bugzilla-daemon at bugs.koha-community.org  Tue Nov 21 14:51:31 2017
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 21 Nov 2017 13:51:31 +0000
Subject: [Koha-bugs] [Bug 19669] Remove deprecated checkouts by patron
	category report
In-Reply-To: <bug-19669-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-19669-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-19669-70-JQJJGx25Ti@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19669

Owen Leonard <oleonard at myacpl.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
           Assignee|koha-bugs at lists.koha-commun |oleonard at myacpl.org
                   |ity.org                     |

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Nov 21 14:51:47 2017
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 21 Nov 2017 13:51:47 +0000
Subject: [Koha-bugs] [Bug 17721] Do we need utf8_bin collation on
	tagsubfield?
In-Reply-To: <bug-17721-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-17721-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-17721-70-zTnto1GPPg@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17721

Nicolas Legrand <nicolas.legrand at bulac.fr> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |nicolas.legrand at bulac.fr

--- Comment #1 from Nicolas Legrand <nicolas.legrand at bulac.fr> ---
We also use it a lot to describe our items. We have 995a, 995A and so on. I'm
not sure it's used with others french library with UNIMARC, but it's a
possibility.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Nov 21 14:52:01 2017
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 21 Nov 2017 13:52:01 +0000
Subject: [Koha-bugs] [Bug 17676] Default COLLATE for marc_subfield_structure
	is not set
In-Reply-To: <bug-17676-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-17676-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-17676-70-91qmNmCp3L@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17676

Nicolas Legrand <nicolas.legrand at bulac.fr> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
           See Also|                            |https://bugs.koha-community
                   |                            |.org/bugzilla3/show_bug.cgi
                   |                            |?id=19670

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Nov 21 14:52:01 2017
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 21 Nov 2017 13:52:01 +0000
Subject: [Koha-bugs] [Bug 19670] New: search_marc_map.marc_field should have
 COLLATE=utf8_bin
Message-ID: <bug-19670-70@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19670

            Bug ID: 19670
           Summary: search_marc_map.marc_field should have
                    COLLATE=utf8_bin
 Change sponsored?: ---
           Product: Koha
           Version: master
          Hardware: All
                OS: All
            Status: NEW
          Severity: trivial
          Priority: P5 - low
         Component: Searching - Elasticsearch
          Assignee: koha-bugs at lists.koha-community.org
          Reporter: nicolas.legrand at bulac.fr

With COLLATE=utf8_unicode_ci it's not possible to map fields with same letter
but different case (eg 995a and 995A) with the form of
elasticsearch/mappings.pl. Changing the collation in the database fix the
issue.

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Nov 21 14:55:20 2017
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 21 Nov 2017 13:55:20 +0000
Subject: [Koha-bugs] [Bug 17721] Do we need utf8_bin collation on
	tagsubfield?
In-Reply-To: <bug-17721-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-17721-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-17721-70-FlyB9E2CEF@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17721

--- Comment #2 from Nicolas Legrand <nicolas.legrand at bulac.fr> ---
ha and also no, you can't insert a 995a with a 995A when it's
collate=utf8_general_ci and the field is a key because it consider that 995a is
the same key as 995A.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Nov 21 14:57:56 2017
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 21 Nov 2017 13:57:56 +0000
Subject: [Koha-bugs] [Bug 19669] Remove deprecated checkouts by patron
	category report
In-Reply-To: <bug-19669-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-19669-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-19669-70-OtWofdNzOc@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19669

Owen Leonard <oleonard at myacpl.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|ASSIGNED                    |Needs Signoff
   Patch complexity|---                         |Trivial patch

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Nov 21 14:57:58 2017
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 21 Nov 2017 13:57:58 +0000
Subject: [Koha-bugs] [Bug 19669] Remove deprecated checkouts by patron
	category report
In-Reply-To: <bug-19669-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-19669-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-19669-70-7VSNR79WVh@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19669

--- Comment #1 from Owen Leonard <oleonard at myacpl.org> ---
Created attachment 69246
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=69246&action=edit
Bug 19669: Remove deprecated checkouts by patron category report

The checkouts by patron category report has been hidden and considered
deprecated since 2004. This patch removes it.

To test, apply the patch and confirm that nothing at all seems to have
changed and everything feels fine.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Nov 21 15:01:18 2017
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 21 Nov 2017 14:01:18 +0000
Subject: [Koha-bugs] [Bug 19671] New: Circulation wizard / issues_stats.pl
 does not populate itemtype descriptions correctly
Message-ID: <bug-19671-70@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19671

            Bug ID: 19671
           Summary: Circulation wizard / issues_stats.pl does not populate
                    itemtype descriptions correctly
 Change sponsored?: ---
           Product: Koha
           Version: master
          Hardware: All
                OS: All
            Status: NEW
          Severity: normal
          Priority: P5 - low
         Component: Reports
          Assignee: koha-bugs at lists.koha-community.org
          Reporter: nick at bywatersolutions.com
        QA Contact: testopia at bugs.koha-community.org

To recreate:
1 - Run the circulation wizard with itemtypes as columns, shelving locations as
rows - display on screen
2 - Note all itemtype values are blank
3 - Switch rows/columns - same issue

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Nov 21 15:04:00 2017
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 21 Nov 2017 14:04:00 +0000
Subject: [Koha-bugs] [Bug 17835] Move C4::Koha::GetItemTypes to
	Koha::ItemTypes
In-Reply-To: <bug-17835-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-17835-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-17835-70-AnBri3AKbA@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17835

Nick Clemens <nick at bywatersolutions.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Blocks|                            |19671


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19671
[Bug 19671] Circulation wizard / issues_stats.pl does not populate itemtype
descriptions correctly
-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Nov 21 15:04:02 2017
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 21 Nov 2017 14:04:02 +0000
Subject: [Koha-bugs] [Bug 19671] Circulation wizard / issues_stats.pl does
 not populate itemtype descriptions correctly
In-Reply-To: <bug-19671-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-19671-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-19671-70-v8dAfaFFdl@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19671

--- Comment #1 from Nick Clemens <nick at bywatersolutions.com> ---
Created attachment 69247
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=69247&action=edit
Bug 19671: Map itemtypes to hash for correct display in issues_stats.pl

To test:
1 - Run the circulation wizard with itemtypes as columns, shelving
locations as rows - display on screen
2 - Note all itemtype values are blank
3 - Switch rows/columns - same issue
4 - Apply patch
5 - Re-run reports
6 - Itemtypes should diplsay correctly

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Nov 21 15:04:00 2017
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 21 Nov 2017 14:04:00 +0000
Subject: [Koha-bugs] [Bug 19671] Circulation wizard / issues_stats.pl does
 not populate itemtype descriptions correctly
In-Reply-To: <bug-19671-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-19671-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-19671-70-DglGHKDsCI@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19671

Nick Clemens <nick at bywatersolutions.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|NEW                         |Needs Signoff
   Patch complexity|---                         |Small patch
         Depends on|                            |17835


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17835
[Bug 17835] Move C4::Koha::GetItemTypes to Koha::ItemTypes
-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.

From bugzilla-daemon at bugs.koha-community.org  Tue Nov 21 15:09:35 2017
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 21 Nov 2017 14:09:35 +0000
Subject: [Koha-bugs] [Bug 19671] Circulation wizard / issues_stats.pl does
 not populate itemtype descriptions correctly
In-Reply-To: <bug-19671-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-19671-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-19671-70-zZHD78Pweh@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19671

Nick Clemens <nick at bywatersolutions.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
           Assignee|koha-bugs at lists.koha-commun |nick at bywatersolutions.com
                   |ity.org                     |

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.

From bugzilla-daemon at bugs.koha-community.org  Tue Nov 21 15:15:57 2017
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 21 Nov 2017 14:15:57 +0000
Subject: [Koha-bugs] [Bug 19670] search_marc_map.marc_field should have
	COLLATE=utf8_bin
In-Reply-To: <bug-19670-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-19670-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-19670-70-o9XyuqmVdj@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19670

S?verine Queune <severine.queune at bulac.fr> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |severine.queune at bulac.fr

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Nov 21 15:16:27 2017
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 21 Nov 2017 14:16:27 +0000
Subject: [Koha-bugs] [Bug 17721] Do we need utf8_bin collation on
	tagsubfield?
In-Reply-To: <bug-17721-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-17721-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-17721-70-IX1Q6lBgaV@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17721

S?verine Queune <severine.queune at bulac.fr> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |severine.queune at bulac.fr

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Nov 21 15:37:49 2017
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 21 Nov 2017 14:37:49 +0000
Subject: [Koha-bugs] [Bug 19410] Koha::Objects needs a ->search_for_api
	method
In-Reply-To: <bug-19410-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-19410-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-19410-70-uQwyQUeZlO@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19410

--- Comment #10 from Julian Maurice <julian.maurice at biblibre.com> ---
Created attachment 69248
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=69248&action=edit
Bug 19410: Move search_for_api into a Mojo helper

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Nov 21 15:39:36 2017
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 21 Nov 2017 14:39:36 +0000
Subject: [Koha-bugs] [Bug 19410] Koha::Objects needs a ->search_for_api
	method
In-Reply-To: <bug-19410-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-19410-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-19410-70-NsXpbODa5m@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19410

--- Comment #11 from Julian Maurice <julian.maurice at biblibre.com> ---
The last patch is a proposal for moving search_for_api out of Koha::Objects.
Please tell me what you think.

(In reply to Tom?s Cohen Arazi from comment #9)
> I'm not sure how to call $plural_object :-P

I don't know either, I called it $objects_set ...

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Nov 21 15:44:52 2017
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 21 Nov 2017 14:44:52 +0000
Subject: [Koha-bugs] [Bug 17721] Do we need utf8_bin collation on
	tagsubfield?
In-Reply-To: <bug-17721-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-17721-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-17721-70-Q78OsEJkti@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17721

--- Comment #3 from Katrin Fischer <katrin.fischer at bsz-bw.de> ---
We need the table or the column to be case sensitive in order to be able to
configure, store and retrieve uppercase and lowercase subfields separately.

I am no MySQL expert, so can't tell what is the perfect type to use for that
use case.

Documenting the behaviour is of course always a good idea. A comment in
kohastructure.sql maybe?

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Nov 21 15:53:53 2017
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 21 Nov 2017 14:53:53 +0000
Subject: [Koha-bugs] [Bug 19663] Move JS to the footer: Reports
In-Reply-To: <bug-19663-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-19663-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-19663-70-53uCU0Gnlr@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19663

Owen Leonard <oleonard at myacpl.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|ASSIGNED                    |Needs Signoff
   Patch complexity|---                         |Medium patch

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Nov 21 15:53:55 2017
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 21 Nov 2017 14:53:55 +0000
Subject: [Koha-bugs] [Bug 19663] Move JS to the footer: Reports
In-Reply-To: <bug-19663-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-19663-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-19663-70-2i0TlOiLjg@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19663

--- Comment #1 from Owen Leonard <oleonard at myacpl.org> ---
Created attachment 69249
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=69249&action=edit
Bug 19663: Move JS to the footer: Reports

This patch modifies the staff client's reports templates so
that JavaScript is included in the footer instead of the header.

To test, apply the patch and test the JavaScript-driven features of
reports pages: All button controls, DataTables functionality, form
validation, etc.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Nov 21 16:10:55 2017
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 21 Nov 2017 15:10:55 +0000
Subject: [Koha-bugs] [Bug 19672] New: Move tools templates JavaScript to the
 footer: More MARC tools
Message-ID: <bug-19672-70@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19672

            Bug ID: 19672
           Summary: Move tools templates JavaScript to the footer: More
                    MARC tools
 Change sponsored?: ---
           Product: Koha
           Version: master
          Hardware: All
                OS: All
            Status: ASSIGNED
          Severity: enhancement
          Priority: P5 - low
         Component: Templates
          Assignee: oleonard at myacpl.org
          Reporter: oleonard at myacpl.org
        QA Contact: testopia at bugs.koha-community.org
                CC: testopia at bugs.koha-community.org
        Depends on: 19647
            Blocks: 17858

In order to conform to best practices for performance staff client template
javascript should be in the footer instead of the header.

This patch will do so for the more MARC-related templates in the "Catalog"
section of Tools.


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17858
[Bug 17858] Omnibus: Move staff client JavaScript to the footer
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19647
[Bug 19647] Move patron lists templates JS to the footer
-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Nov 21 16:10:55 2017
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 21 Nov 2017 15:10:55 +0000
Subject: [Koha-bugs] [Bug 19647] Move patron lists templates JS to the footer
In-Reply-To: <bug-19647-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-19647-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-19647-70-0bFdr8WH7c@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19647

Owen Leonard <oleonard at myacpl.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Blocks|                            |19672


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19672
[Bug 19672] Move tools templates JavaScript to the footer: More MARC tools
-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Nov 21 16:10:55 2017
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 21 Nov 2017 15:10:55 +0000
Subject: [Koha-bugs] [Bug 17858] Omnibus: Move staff client JavaScript to
	the footer
In-Reply-To: <bug-17858-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-17858-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-17858-70-GoG5lrbYv2@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17858

Owen Leonard <oleonard at myacpl.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
         Depends on|                            |19672


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19672
[Bug 19672] Move tools templates JavaScript to the footer: More MARC tools
-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Nov 21 16:23:21 2017
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 21 Nov 2017 15:23:21 +0000
Subject: [Koha-bugs] [Bug 19564] Fix extraction of sort order from sort
	condition name
In-Reply-To: <bug-19564-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-19564-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-19564-70-iKXKDjuVmT@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19564

--- Comment #7 from Nick Clemens <nick at bywatersolutions.com> ---
(In reply to Nick Clemens from comment #5)
> This works, I mean we need a callnum index, but it changes form not having a
> sort to having a sort on an undefined index :-) let me know what other bugs
> you are working on

I think I didn't finish my thought here, we need unit tests here to verify the
change, if you can provide those I will sign off. If you need any help with
them let me know.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Nov 21 16:26:28 2017
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 21 Nov 2017 15:26:28 +0000
Subject: [Koha-bugs] [Bug 19482] Elasticsearch - prevent removal / editing
 of required indexes
In-Reply-To: <bug-19482-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-19482-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-19482-70-xq4ska7gYg@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19482

--- Comment #6 from Nick Clemens <nick at bywatersolutions.com> ---
Created attachment 69250
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=69250&action=edit
Bug 19482 - Make reset mappings reset also reset fields

I think this makes sense, we should reset to the mappings file
completely

To test:
1 - Change a field label in es
2 - Save it
3 - Reset mapping
4 - Label should be reset

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Nov 21 16:28:47 2017
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 21 Nov 2017 15:28:47 +0000
Subject: [Koha-bugs] [Bug 19482] Elasticsearch - prevent removal / editing
 of required indexes
In-Reply-To: <bug-19482-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-19482-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-19482-70-a6HphdVuby@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19482

--- Comment #7 from Nick Clemens <nick at bywatersolutions.com> ---


(In reply to David Bourgault from comment #5)
> I applied the patch and update the database (updatedatabase.pl) however,
> even after reset-ing the mappings I could not get issues to show up as
> readonly. I tried reset-ing again (twice) to no avail. 

Indeed, it seems a reset does not actually perform a full reset, it only resets
the marc to field mappings

I added an initial patch to ensure that data would be updated, however, I am
wondering if we should alter reset to do a full reload, deleting all existing
and loading the file fresh? It hsould probably be its own bug if so

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Nov 21 16:34:40 2017
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 21 Nov 2017 15:34:40 +0000
Subject: [Koha-bugs] [Bug 19604] Elasticsearch Fixes for
 build_authorities_query for auth searching
In-Reply-To: <bug-19604-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-19604-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-19604-70-n91HSASToa@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19604

--- Comment #7 from Nick Clemens <nick at bywatersolutions.com> ---
(In reply to David Bourgault from comment #6)
> Tests passed, QA tools green.
> 
> However, whereas I had 1 exact 1, I now have 0 search results.
> 
> I tried reseting the mappings, I reindexed -d -a -v twice but I can't get it
> to find results.
> 
> Testing in Kibana with the query `Heading:*me*`, I got multiple results
> (including both 'me' and 'm?') so I don't think it's a problem specific to
> my index/database.
> 
> Failed QA :(

Can you let me know the exact search and terms you are using? and the data in
your DB? with patches applied and default data from kohadevbox I get results
for 'me' or 'm?' and all are as expected

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.

From bugzilla-daemon at bugs.koha-community.org  Tue Nov 21 16:44:21 2017
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 21 Nov 2017 15:44:21 +0000
Subject: [Koha-bugs] [Bug 12310] Accept different monetary formats as input
In-Reply-To: <bug-12310-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-12310-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-12310-70-hQXYBGHq26@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12310

Koha Team Lyon 3 <koha at univ-lyon3.fr> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
           See Also|                            |https://bugs.koha-community
                   |                            |.org/bugzilla3/show_bug.cgi
                   |                            |?id=19251

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Nov 21 16:44:21 2017
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 21 Nov 2017 15:44:21 +0000
Subject: [Koha-bugs] [Bug 19251] Show book drop information in the Checkout
	History
In-Reply-To: <bug-19251-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-19251-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-19251-70-IjeKGeFedQ@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19251

Koha Team Lyon 3 <koha at univ-lyon3.fr> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
           See Also|                            |https://bugs.koha-community
                   |                            |.org/bugzilla3/show_bug.cgi
                   |                            |?id=12310

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.

From bugzilla-daemon at bugs.koha-community.org  Tue Nov 21 16:57:35 2017
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 21 Nov 2017 15:57:35 +0000
Subject: [Koha-bugs] [Bug 19673] New: Patron batch modification tool cannot
 use authorised value "0"
Message-ID: <bug-19673-70@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19673

            Bug ID: 19673
           Summary: Patron batch modification tool cannot use authorised
                    value "0"
 Change sponsored?: ---
           Product: Koha
           Version: 16.05
          Hardware: All
                OS: All
            Status: NEW
          Severity: minor
          Priority: P5 - low
         Component: Patrons
          Assignee: koha-bugs at lists.koha-community.org
          Reporter: emma.perks at heartofengland.nhs.uk
        QA Contact: testopia at bugs.koha-community.org
                CC: gmcharlt at gmail.com, kyle.m.hall at gmail.com

If a patron attribute has the authorized value 0, using the Batch patron
modification tool does not save the value. 
Test case: Authorized values category YES_NO; No=0, Yes=1
Set patron attribute type to use the YES_NO category
Tools Batch patron modification
Select patrons
Set attribute to 0
Save
The attribute has not saved

Many thanks.

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Nov 21 17:00:02 2017
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 21 Nov 2017 16:00:02 +0000
Subject: [Koha-bugs] [Bug 19673] Patron batch modification tool cannot use
 authorised value "0"
In-Reply-To: <bug-19673-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-19673-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-19673-70-kZ7iLpWgXb@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19673

Emma Perks <emma.perks at heartofengland.nhs.uk> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |emma.perks at heartofengland.n
                   |                            |hs.uk

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Nov 21 17:00:21 2017
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 21 Nov 2017 16:00:21 +0000
Subject: [Koha-bugs] [Bug 19521] Partial fine payment is not working with
 comma decimal separator
In-Reply-To: <bug-19521-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-19521-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-19521-70-CKDMa9HjIT@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19521

Koha Team Lyon 3 <koha at univ-lyon3.fr> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
           See Also|                            |https://bugs.koha-community
                   |                            |.org/bugzilla3/show_bug.cgi
                   |                            |?id=12310

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.

From bugzilla-daemon at bugs.koha-community.org  Tue Nov 21 17:00:21 2017
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 21 Nov 2017 16:00:21 +0000
Subject: [Koha-bugs] [Bug 12310] Accept different monetary formats as input
In-Reply-To: <bug-12310-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-12310-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-12310-70-qYVTIygPuk@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12310

Koha Team Lyon 3 <koha at univ-lyon3.fr> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
           See Also|                            |https://bugs.koha-community
                   |                            |.org/bugzilla3/show_bug.cgi
                   |                            |?id=19521

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Nov 21 17:07:28 2017
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 21 Nov 2017 16:07:28 +0000
Subject: [Koha-bugs] [Bug 19521] Partial fine payment is not working with
 comma decimal separator
In-Reply-To: <bug-19521-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-19521-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-19521-70-S5UPcAftMf@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19521

--- Comment #8 from Koha Team Lyon 3 <koha at univ-lyon3.fr> ---
Hello,
I wonder if this problem wouldn't be fixed by BZ12310.
Perhaps, we should work on BZ12310 that solve more than this problem.
Sonia

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Nov 21 17:15:38 2017
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 21 Nov 2017 16:15:38 +0000
Subject: [Koha-bugs] [Bug 16538] Improve the style of progress bars
In-Reply-To: <bug-16538-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-16538-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-16538-70-Y3YejfI5ED@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16538

Owen Leonard <oleonard at myacpl.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Blocks|                            |19674


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19674
[Bug 19674] Broken indicators of changed fields in manage staged MARC records
template
-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Nov 21 17:15:38 2017
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 21 Nov 2017 16:15:38 +0000
Subject: [Koha-bugs] [Bug 19674] New: Broken indicators of changed fields in
 manage staged MARC records template
Message-ID: <bug-19674-70@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19674

            Bug ID: 19674
           Summary: Broken indicators of changed fields in manage staged
                    MARC records template
 Change sponsored?: ---
           Product: Koha
           Version: master
          Hardware: All
                OS: All
            Status: ASSIGNED
          Severity: minor
          Priority: P5 - low
         Component: Tools
          Assignee: koha-bugs at lists.koha-community.org
          Reporter: oleonard at myacpl.org
        QA Contact: testopia at bugs.koha-community.org
        Depends on: 16538

May patch for Bug 16538 removed some CSS which should have stayed. Without it,
the manage staged MARC records page always says that all matching options have
been modified.


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16538
[Bug 16538] Improve the style of progress bars
-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.

From bugzilla-daemon at bugs.koha-community.org  Tue Nov 21 17:20:53 2017
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 21 Nov 2017 16:20:53 +0000
Subject: [Koha-bugs] [Bug 19675] New: Cannot save notices when setting the
 TranslateNotices preference
Message-ID: <bug-19675-70@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19675

            Bug ID: 19675
           Summary: Cannot save notices when setting the TranslateNotices
                    preference
 Change sponsored?: ---
           Product: Koha
           Version: 17.05
          Hardware: All
                OS: All
            Status: NEW
          Severity: major
          Priority: P5 - low
         Component: Notices
          Assignee: koha-bugs at lists.koha-community.org
          Reporter: andreas.jonsson at kreablo.se
        QA Contact: testopia at bugs.koha-community.org

The lang parameter is missing in the where clause of the update statement.  The
below patch fixes the problem.

diff --git a/tools/letter.pl b/tools/letter.pl
index 5920a8437f..f89930472c 100755
--- a/tools/letter.pl
+++ b/tools/letter.pl
@@ -303,11 +303,11 @@ sub add_validate {
                 q{
                     UPDATE letter
                     SET branchcode = ?, module = ?, name = ?, is_html = ?,
title = ?, content = ?, lang = ?
-                    WHERE branchcode = ? AND module = ? AND code = ? AND
message_transport_type = ?
+                    WHERE branchcode = ? AND module = ? AND code = ? AND
message_transport_type = ? AND lang = ?
                 },
                 undef,
                 $branchcode || '', $module, $name, $is_html || 0, $title,
$content, $lang,
-                $branchcode, $oldmodule, $code, $mtt
+                $branchcode, $oldmodule, $code, $mtt, $lang
             );
         } else {
             $dbh->do(



To reproduce:

1. Enable TranslateNotices global preference.
2. Edit any notice message and save a translation.
3. Try updating any translation.  The save will fail and the log-file will
contain errors such as this:

DBIx::Class::Storage::DBI::select_single(): Query returned more than one row. 
SQL that returns multiple rows is DEPRECATED for ->find and ->single at
/usr/share/koha/lib/Koha/Objects.pm line 92
DBIx::Class::Storage::DBI::select_single(): Query returned more than one row. 
SQL that returns multiple rows is DEPRECATED for ->find and ->single at
/usr/share/koha/lib/Koha/Objects.pm line 92
DBD::mysql::db do failed: Duplicate entry 'circulation-ODUE--email-sv-SE' for
key 'PRIMARY' [for Statement "
                    UPDATE letter
                    SET branchcode = ?, module = ?, name = ?, is_html = ?,
title = ?, content = ?, lang = ?
                    WHERE branchcode = ? AND module = ? AND code = ? AND
message_transport_type = ?
                "] at /usr/share/koha/intranet/cgi-bin/tools/letter.pl line
302.
DBD::mysql::db do failed: Duplicate entry 'circulation-ODUE--email-en' for key
'PRIMARY' [for Statement "
                    UPDATE letter
                    SET branchcode = ?, module = ?, name = ?, is_html = ?,
title = ?, content = ?, lang = ?
                    WHERE branchcode = ? AND module = ? AND code = ? AND
message_transport_type = ?
                "] at /usr/share/koha/intranet/cgi-bin/tools/letter.pl line
302.

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Nov 21 17:21:11 2017
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 21 Nov 2017 16:21:11 +0000
Subject: [Koha-bugs] [Bug 19674] Broken indicators of changed fields in
 manage staged MARC records template
In-Reply-To: <bug-19674-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-19674-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-19674-70-GV6RIoAxkK@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19674

Owen Leonard <oleonard at myacpl.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
   Patch complexity|---                         |Trivial patch
             Status|ASSIGNED                    |Needs Signoff

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.

From bugzilla-daemon at bugs.koha-community.org  Tue Nov 21 17:21:13 2017
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 21 Nov 2017 16:21:13 +0000
Subject: [Koha-bugs] [Bug 19674] Broken indicators of changed fields in
 manage staged MARC records template
In-Reply-To: <bug-19674-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-19674-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-19674-70-1ZtQZWKXhe@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19674

--- Comment #1 from Owen Leonard <oleonard at myacpl.org> ---
Created attachment 69251
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=69251&action=edit
Bug 19674: Broken indicators of changed fields in manage staged MARC records
template

This patch returns some CSS to the manage staged MARC records template
which was incorrectly removed by Gug 16538.

To test, apply the patch and go to Tools -> Staged MARC management.
Choose a staged MARC file.

Changing any of the <select> fields in the first section should cause a
label to appear showing that the selection has changed, along with a
link to reset the option to its original state. Clicking 'Reset' should
make the label and the link disappear.

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.

From bugzilla-daemon at bugs.koha-community.org  Tue Nov 21 18:05:16 2017
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 21 Nov 2017 17:05:16 +0000
Subject: [Koha-bugs] [Bug 19672] Move tools templates JavaScript to the
 footer: More MARC tools
In-Reply-To: <bug-19672-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-19672-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-19672-70-yUlMeJe9DK@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19672

--- Comment #1 from Owen Leonard <oleonard at myacpl.org> ---
Created attachment 69252
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=69252&action=edit
Bug 19672: Move tools templates JavaScript to the footer: More MARC tools

This patch modifies some staff client templates from the "Tools"
section so that JavaScript is included in the footer instead of the
header.

- Automatic item modifications by age
- MARC modification templates
- Stage MARC records for import
- Staged MARC record management

To test, apply the patch and test the JavaScript-driven features of
each modified template: All button controls, DataTables functionality,
form validation, etc.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Nov 21 18:05:14 2017
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 21 Nov 2017 17:05:14 +0000
Subject: [Koha-bugs] [Bug 19672] Move tools templates JavaScript to the
 footer: More MARC tools
In-Reply-To: <bug-19672-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-19672-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-19672-70-Z9ngzNmws5@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19672

Owen Leonard <oleonard at myacpl.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
   Patch complexity|---                         |Small patch
             Status|ASSIGNED                    |Needs Signoff

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Nov 21 18:11:38 2017
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 21 Nov 2017 17:11:38 +0000
Subject: [Koha-bugs] [Bug 19676] New: Debian 9 vs. Plack vs. / tmp --
 attention to PrivateTmp for apache2
Message-ID: <bug-19676-70@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19676

            Bug ID: 19676
           Summary: Debian 9 vs. Plack vs. /tmp -- attention to PrivateTmp
                    for apache2
 Change sponsored?: ---
           Product: Koha
           Version: unspecified
          Hardware: All
                OS: All
            Status: NEW
          Severity: enhancement
          Priority: P5 - low
         Component: Architecture, internals, and plumbing
          Assignee: koha-bugs at lists.koha-community.org
          Reporter: januszop at gmail.com
        QA Contact: testopia at bugs.koha-community.org

Beware: in Debian 9 apache2 comes with PrivateTmp enabled by default.

As a consequence, there are issues when Plack is enabled for an instance, but
in Koha there is an interaction between Plack enabled and Plack blacklisted
stuff through /tmp directory.

Plack-ed scripts will write temporary files in "real" /tmp directory (as
pointed by Koha::UploadedFile::temporary_directory, i.e. File::Spec->tmpdir)
whereas Plack blacklisted scripts will understand /tmp as private tmp of
apache2, i.e. /tmp/systemd-private-?????????-apache2.service-????/tmp.

This happens for instance for stage-marc-import.pl -- in step 2 the script
won't find the marc file uploaded in step 1.

The simplest instant solution to this would be to disable PrivateTmp for
apache2 (this article gives a clue:
https://www.maxoberberger.net/blog/2017/10/debian-9-private-tmp.html), but
maybe there is a better option?

(When Plack is disabled everything seems to work fine apart of the fact that
the private tmp of apache2 is being used.)

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Nov 21 20:20:16 2017
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 21 Nov 2017 19:20:16 +0000
Subject: [Koha-bugs] [Bug 19410] Koha::Objects needs a ->search_for_api
	method
In-Reply-To: <bug-19410-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-19410-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-19410-70-BxbT5sYsti@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19410

Tom?s Cohen Arazi <tomascohen at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #67750|0                           |1
        is obsolete|                            |

--- Comment #12 from Tom?s Cohen Arazi <tomascohen at gmail.com> ---
Created attachment 69253
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=69253&action=edit
Bug 19410: Add Koha::Objects->search_for_api

Following the discussion about the best way to make things simpler for
developing the REST api, I quote Lari's email:

"As many other endpoint will have the exact same usage, by looking at your
example, I would prefer to avoid writing parameter / pagination / sorting /
header handling for each list operation in our API controllers. Do you think
it's possible to centralize all of this e.g. by passing $c into a customized
search sub? Perhaps in Koha::Objects?
so instead we could have something like (ignore my bad choice of naming)...:
sub list_vendors {
  my $c = shift->openapi->valid_input or return;
  my $args = $c->validation->output;
  my $vendors;

  return try {
    $vendors = Koha::Acquisition::Booksellers->api_list_search($c);
    return $c->render(status => 200, openapi => $vendors);
  } catch {
    ...
  }
}"

We all agreed we neeed something like that. Here's a possible implementation. I
take
advantage of the previously written Mojo helpers, that are fully covered by
tests.

I submit this early so anyone can take a look and gather ideas to make it even
better.
I'm already using it (effectively) for the /acquisitions/orders endpoint I'm
writing
on bug 18731.

Thanks!

Signed-off-by: Tomas Cohen Arazi <tomascohen at theke.io>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Nov 21 20:20:22 2017
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 21 Nov 2017 19:20:22 +0000
Subject: [Koha-bugs] [Bug 19410] Koha::Objects needs a ->search_for_api
	method
In-Reply-To: <bug-19410-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-19410-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-19410-70-0si4Hl4V8E@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19410

Tom?s Cohen Arazi <tomascohen at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #67751|0                           |1
        is obsolete|                            |

--- Comment #13 from Tom?s Cohen Arazi <tomascohen at gmail.com> ---
Created attachment 69254
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=69254&action=edit
Bug 19410: Unit tests

Signed-off-by: Tomas Cohen Arazi <tomascohen at theke.io>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Nov 21 20:20:29 2017
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 21 Nov 2017 19:20:29 +0000
Subject: [Koha-bugs] [Bug 19410] Koha::Objects needs a ->search_for_api
	method
In-Reply-To: <bug-19410-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-19410-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-19410-70-Aa2xAlsoNU@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19410

Tom?s Cohen Arazi <tomascohen at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #67798|0                           |1
        is obsolete|                            |

--- Comment #14 from Tom?s Cohen Arazi <tomascohen at gmail.com> ---
Created attachment 69255
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=69255&action=edit
Bug 19410: (follow-up) Fix typo in POD

Signed-off-by: Tomas Cohen Arazi <tomascohen at theke.io>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Nov 21 20:20:35 2017
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 21 Nov 2017 19:20:35 +0000
Subject: [Koha-bugs] [Bug 19410] Koha::Objects needs a ->search_for_api
	method
In-Reply-To: <bug-19410-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-19410-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-19410-70-qEL4GGYRa2@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19410

Tom?s Cohen Arazi <tomascohen at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #69248|0                           |1
        is obsolete|                            |

--- Comment #15 from Tom?s Cohen Arazi <tomascohen at gmail.com> ---
Created attachment 69256
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=69256&action=edit
Bug 19410: Move search_for_api into a Mojo helper

Signed-off-by: Tomas Cohen Arazi <tomascohen at theke.io>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Nov 21 20:20:41 2017
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 21 Nov 2017 19:20:41 +0000
Subject: [Koha-bugs] [Bug 19410] Koha::Objects needs a ->search_for_api
	method
In-Reply-To: <bug-19410-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-19410-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-19410-70-KpdjaoN2rB@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19410

--- Comment #16 from Tom?s Cohen Arazi <tomascohen at gmail.com> ---
Created attachment 69257
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=69257&action=edit
Bug 19410: (QA followup) Move build_query_params_from_api into a helper

This patch creates the 'build_query_params' helper, instead of the
original function in Koha::Objects.

Unit tests are removed for Koha::Objects::_build_query_params_from_api and
written for the helper plugin.

The objects.search helper gets a call to build_query_params added. Tests for it
updated to match this behaviour change.

To test:
- Apply this patches
- Run:
  $ kshell
 k$ prove t/Koha/REST/Plugin/Query.t \
          t/db_dependent/Koha/Objects.t \
          t/db_dependent/Koha/REST/Plugin/Objects.t
=> SUCCESS: Tests pass!
- Sign off :-D

Signed-off-by: Tomas Cohen Arazi <tomascohen at theke.io>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Nov 21 20:31:51 2017
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 21 Nov 2017 19:31:51 +0000
Subject: [Koha-bugs] [Bug 19410] Koha::Objects needs a ->search_for_api
	method
In-Reply-To: <bug-19410-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-19410-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-19410-70-1Dkd6XDLKb@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19410

Julian Maurice <julian.maurice at biblibre.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #69253|0                           |1
        is obsolete|                            |

--- Comment #17 from Julian Maurice <julian.maurice at biblibre.com> ---
Created attachment 69258
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=69258&action=edit
Bug 19410: Add Koha::Objects->search_for_api

Following the discussion about the best way to make things simpler for
developing the REST api, I quote Lari's email:

"As many other endpoint will have the exact same usage, by looking at your
example, I would prefer to avoid writing parameter / pagination / sorting /
header handling for each list operation in our API controllers. Do you think
it's possible to centralize all of this e.g. by passing $c into a customized
search sub? Perhaps in Koha::Objects?
so instead we could have something like (ignore my bad choice of naming)...:
sub list_vendors {
  my $c = shift->openapi->valid_input or return;
  my $args = $c->validation->output;
  my $vendors;

  return try {
    $vendors = Koha::Acquisition::Booksellers->api_list_search($c);
    return $c->render(status => 200, openapi => $vendors);
  } catch {
    ...
  }
}"

We all agreed we neeed something like that. Here's a possible implementation. I
take
advantage of the previously written Mojo helpers, that are fully covered by
tests.

I submit this early so anyone can take a look and gather ideas to make it even
better.
I'm already using it (effectively) for the /acquisitions/orders endpoint I'm
writing
on bug 18731.

Thanks!

Signed-off-by: Tomas Cohen Arazi <tomascohen at theke.io>
Signed-off-by: Julian Maurice <julian.maurice at biblibre.com>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Nov 21 20:31:56 2017
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 21 Nov 2017 19:31:56 +0000
Subject: [Koha-bugs] [Bug 19410] Koha::Objects needs a ->search_for_api
	method
In-Reply-To: <bug-19410-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-19410-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-19410-70-02VL5X9Rad@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19410

Julian Maurice <julian.maurice at biblibre.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #69254|0                           |1
        is obsolete|                            |

--- Comment #18 from Julian Maurice <julian.maurice at biblibre.com> ---
Created attachment 69259
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=69259&action=edit
Bug 19410: Unit tests

Signed-off-by: Tomas Cohen Arazi <tomascohen at theke.io>
Signed-off-by: Julian Maurice <julian.maurice at biblibre.com>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Nov 21 20:31:59 2017
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 21 Nov 2017 19:31:59 +0000
Subject: [Koha-bugs] [Bug 19410] Koha::Objects needs a ->search_for_api
	method
In-Reply-To: <bug-19410-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-19410-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-19410-70-jNRl7lEgsq@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19410

Julian Maurice <julian.maurice at biblibre.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #69255|0                           |1
        is obsolete|                            |

--- Comment #19 from Julian Maurice <julian.maurice at biblibre.com> ---
Created attachment 69260
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=69260&action=edit
Bug 19410: (follow-up) Fix typo in POD

Signed-off-by: Tomas Cohen Arazi <tomascohen at theke.io>
Signed-off-by: Julian Maurice <julian.maurice at biblibre.com>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Nov 21 20:32:02 2017
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 21 Nov 2017 19:32:02 +0000
Subject: [Koha-bugs] [Bug 12962] easier to see circ rule edits
In-Reply-To: <bug-12962-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-12962-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-12962-70-uciWdtELQg@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12962

Patrick Robitaille <patrick.robitaille at collecto.ca> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |patrick.robitaille at collecto
                   |                            |.ca

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Nov 21 20:32:03 2017
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 21 Nov 2017 19:32:03 +0000
Subject: [Koha-bugs] [Bug 19410] Koha::Objects needs a ->search_for_api
	method
In-Reply-To: <bug-19410-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-19410-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-19410-70-opwiYNeUCP@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19410

Julian Maurice <julian.maurice at biblibre.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #69256|0                           |1
        is obsolete|                            |

--- Comment #20 from Julian Maurice <julian.maurice at biblibre.com> ---
Created attachment 69261
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=69261&action=edit
Bug 19410: Move search_for_api into a Mojo helper

Signed-off-by: Tomas Cohen Arazi <tomascohen at theke.io>
Signed-off-by: Julian Maurice <julian.maurice at biblibre.com>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Nov 21 20:32:08 2017
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 21 Nov 2017 19:32:08 +0000
Subject: [Koha-bugs] [Bug 19410] Koha::Objects needs a ->search_for_api
	method
In-Reply-To: <bug-19410-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-19410-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-19410-70-xWNF6b6NB9@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19410

Julian Maurice <julian.maurice at biblibre.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #69257|0                           |1
        is obsolete|                            |

--- Comment #21 from Julian Maurice <julian.maurice at biblibre.com> ---
Created attachment 69262
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=69262&action=edit
Bug 19410: (QA followup) Move build_query_params_from_api into a helper

This patch creates the 'build_query_params' helper, instead of the
original function in Koha::Objects.

Unit tests are removed for Koha::Objects::_build_query_params_from_api and
written for the helper plugin.

The objects.search helper gets a call to build_query_params added. Tests for it
updated to match this behaviour change.

To test:
- Apply this patches
- Run:
  $ kshell
 k$ prove t/Koha/REST/Plugin/Query.t \
          t/db_dependent/Koha/Objects.t \
          t/db_dependent/Koha/REST/Plugin/Objects.t
=> SUCCESS: Tests pass!
- Sign off :-D

Signed-off-by: Tomas Cohen Arazi <tomascohen at theke.io>
Signed-off-by: Julian Maurice <julian.maurice at biblibre.com>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Nov 21 20:32:30 2017
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 21 Nov 2017 19:32:30 +0000
Subject: [Koha-bugs] [Bug 19410] Koha::Objects needs a ->search_for_api
	method
In-Reply-To: <bug-19410-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-19410-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-19410-70-5bnk0miyK0@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19410

Julian Maurice <julian.maurice at biblibre.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Needs Signoff               |Signed Off

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Nov 21 20:56:51 2017
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 21 Nov 2017 19:56:51 +0000
Subject: [Koha-bugs] [Bug 8676] show vendor name in source of acquisition
In-Reply-To: <bug-8676-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-8676-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-8676-70-BT8q41rKMd@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8676

--- Comment #5 from Owen Leonard <oleonard at myacpl.org> ---
Can anyone reproduce this error in current master?

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Nov 21 20:58:05 2017
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 21 Nov 2017 19:58:05 +0000
Subject: [Koha-bugs] [Bug 18820] The different parts in the main don' t
 automatically adjust with the available space.
In-Reply-To: <bug-18820-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-18820-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-18820-70-aKA9t0duEg@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18820

Owen Leonard <oleonard at myacpl.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
           Assignee|oleonard at myacpl.org         |dominic.pichette at inlibro.co
                   |                            |m

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Nov 21 21:00:19 2017
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 21 Nov 2017 20:00:19 +0000
Subject: [Koha-bugs] [Bug 7680] Create a PatronDefaultView preference to
 control whether patron links go to circ or patron details
In-Reply-To: <bug-7680-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-7680-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-7680-70-sLDtPbDTCE@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7680

Owen Leonard <oleonard at myacpl.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|In Discussion               |Failed QA

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Nov 21 21:01:16 2017
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 21 Nov 2017 20:01:16 +0000
Subject: [Koha-bugs] [Bug 5764] not for loan message in staff client repeated
In-Reply-To: <bug-5764-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-5764-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-5764-70-qxVMPpaWFR@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5764

Owen Leonard <oleonard at myacpl.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
         Resolution|---                         |WONTFIX
             Status|NEW                         |RESOLVED

-- 
You are receiving this mail because:
You are the QA Contact for the bug.
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Nov 21 21:01:59 2017
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 21 Nov 2017 20:01:59 +0000
Subject: [Koha-bugs] [Bug 19291] Make breadcrumbs for OPAC search history
 consistent with other patron account pages
In-Reply-To: <bug-19291-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-19291-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-19291-70-0YN9a7Ju89@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19291

Owen Leonard <oleonard at myacpl.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
            Summary|Make breadbrumbs for OPAC   |Make breadcrumbs for OPAC
                   |search history consistent   |search history consistent
                   |with other patron account   |with other patron account
                   |pages                       |pages
           Severity|enhancement                 |minor

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Nov 21 21:20:42 2017
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 21 Nov 2017 20:20:42 +0000
Subject: [Koha-bugs] [Bug 19643] Pagination buttons on staged marc
 management are stacking instead of inline
In-Reply-To: <bug-19643-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-19643-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-19643-70-pjl99XRG2v@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19643

--- Comment #4 from Nick Clemens <nick at bywatersolutions.com> ---
*** Bug 19622 has been marked as a duplicate of this bug. ***

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Nov 21 21:20:42 2017
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 21 Nov 2017 20:20:42 +0000
Subject: [Koha-bugs] [Bug 19622] Stage MARC records pagination
In-Reply-To: <bug-19622-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-19622-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-19622-70-eB2QwDpMZv@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19622

Nick Clemens <nick at bywatersolutions.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|NEW                         |RESOLVED
                 CC|                            |nick at bywatersolutions.com
         Resolution|---                         |DUPLICATE

--- Comment #1 from Nick Clemens <nick at bywatersolutions.com> ---


*** This bug has been marked as a duplicate of bug 19643 ***

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Nov 21 21:42:51 2017
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 21 Nov 2017 20:42:51 +0000
Subject: [Koha-bugs] [Bug 12566] Duplicate checks for Self Registered
	borrowers
In-Reply-To: <bug-12566-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-12566-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-12566-70-Lz3KN1JmDH@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12566

Liz Rea <liz at catalyst.net.nz> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
           Keywords|                            |Academy

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Nov 21 21:43:00 2017
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 21 Nov 2017 20:43:00 +0000
Subject: [Koha-bugs] [Bug 19660] Set borrower password on first login from
 self registration
In-Reply-To: <bug-19660-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-19660-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-19660-70-Bhh3IV3m4D@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19660

Liz Rea <liz at catalyst.net.nz> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
           Keywords|                            |Academy

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Nov 21 22:50:53 2017
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 21 Nov 2017 21:50:53 +0000
Subject: [Koha-bugs] [Bug 19503] Duplicating a dropdown menu subfield yields
 an empty subfield tag
In-Reply-To: <bug-19503-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-19503-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-19503-70-YyfCMTb451@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19503

Katrin Fischer <katrin.fischer at bsz-bw.de> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |katrin.fischer at bsz-bw.de

--- Comment #6 from Katrin Fischer <katrin.fischer at bsz-bw.de> ---

>I've tested versions 16.11.12 and 17.05.04 and they seem unaffected by this,
so I'm filing this bug against 16.05.

Same here, everything appears to work as expected.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Nov 21 22:51:00 2017
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 21 Nov 2017 21:51:00 +0000
Subject: [Koha-bugs] [Bug 19503] Duplicating a dropdown menu subfield yields
 an empty subfield tag
In-Reply-To: <bug-19503-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-19503-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-19503-70-lHbV3cXhGm@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19503

Katrin Fischer <katrin.fischer at bsz-bw.de> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
         Resolution|---                         |FIXED
             Status|Pushed to Stable            |RESOLVED

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Nov 21 23:06:36 2017
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 21 Nov 2017 22:06:36 +0000
Subject: [Koha-bugs] [Bug 19195] Noisy warns when creating or editing a
	basket
In-Reply-To: <bug-19195-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-19195-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-19195-70-V2b9Jrbjqq@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19195

Katrin Fischer <katrin.fischer at bsz-bw.de> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
           Severity|enhancement                 |minor

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Nov 22 01:53:18 2017
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 22 Nov 2017 00:53:18 +0000
Subject: [Koha-bugs] [Bug 19677] New: <angle brackets> in enumchron do not
 display in opac or staff side
Message-ID: <bug-19677-70@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19677

            Bug ID: 19677
           Summary: <angle brackets> in enumchron do not display in opac
                    or staff side
 Change sponsored?: ---
           Product: Koha
           Version: 17.05
          Hardware: All
                OS: All
            Status: NEW
          Severity: normal
          Priority: P5 - low
         Component: Templates
          Assignee: oleonard at myacpl.org
          Reporter: joy at bywatersolutions.com
        QA Contact: testopia at bugs.koha-community.org

Created attachment 69263
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=69263&action=edit
opac view of data inside <anglebranckets> missing

Libraries following the NISO standards are using <> in holdings data (normally
in the 952$h enumchron field.  The data can be entered and saved in the
database:

| enumchron                 |
+---------------------------+
| Volume 3. <Supplement 2a> |


But the data between the <> is not displayed on the staff side or in the OPAC.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Nov 22 07:09:33 2017
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 22 Nov 2017 06:09:33 +0000
Subject: [Koha-bugs] [Bug 19677] Angle brackets in enumchron do not display
 in opac or staff side
In-Reply-To: <bug-19677-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-19677-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-19677-70-9r5nbJjYTo@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19677

Katrin Fischer <katrin.fischer at bsz-bw.de> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
            Summary|<angle brackets> in         |Angle brackets in enumchron
                   |enumchron do not display in |do not display in opac or
                   |opac or staff side          |staff side
                 CC|                            |katrin.fischer at bsz-bw.de

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Nov 22 08:47:33 2017
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 22 Nov 2017 07:47:33 +0000
Subject: [Koha-bugs] [Bug 19663] Move JS to the footer: Reports
In-Reply-To: <bug-19663-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-19663-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-19663-70-rZL0zzoiF8@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19663

Claire Gravely <claire_gravely at hotmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Needs Signoff               |Signed Off

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Nov 22 08:47:36 2017
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 22 Nov 2017 07:47:36 +0000
Subject: [Koha-bugs] [Bug 19663] Move JS to the footer: Reports
In-Reply-To: <bug-19663-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-19663-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-19663-70-QieWS9waaE@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19663

Claire Gravely <claire_gravely at hotmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #69249|0                           |1
        is obsolete|                            |

--- Comment #2 from Claire Gravely <claire_gravely at hotmail.com> ---
Created attachment 69264
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=69264&action=edit
Bug 19663: Move JS to the footer: Reports

This patch modifies the staff client's reports templates so
that JavaScript is included in the footer instead of the header.

To test, apply the patch and test the JavaScript-driven features of
reports pages: All button controls, DataTables functionality, form
validation, etc.

Signed-off-by: Claire Gravely <claire.gravely at bsz-bw.de>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Nov 22 09:21:41 2017
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 22 Nov 2017 08:21:41 +0000
Subject: [Koha-bugs] [Bug 19652] Debug-level logging for response JSON
In-Reply-To: <bug-19652-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-19652-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-19652-70-AsZrahSE2H@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19652

Lari Taskula <lari.taskula at jns.fi> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #69233|0                           |1
        is obsolete|                            |

--- Comment #4 from Lari Taskula <lari.taskula at jns.fi> ---
Created attachment 69265
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=69265&action=edit
Bug 19652: REST API: Log request and response content

This patch adds request and response logger to REST API. It is useful for
viewing
parameters that came within the request, and the content that is about to be
rendered back.

To test:
1. prove t/db_dependent/api/v1.t
2. Configure log4perl configuration file for REST API and set log level to
DEBUG
3. Make any request to existing REST API endpoint
4. Observe response JSON in your log file

Example configuration:
log4perl.logger.rest = DEBUG, REST
log4perl.appender.REST=Log::Log4perl::Appender::File
log4perl.appender.REST.filename=/home/koha/koha-dev/var/log/rest.log
log4perl.appender.REST.create_at_logtime=true
log4perl.appender.REST.syswrite=true
log4perl.appender.REST.recreate=true
log4perl.appender.REST.mode=append
log4perl.appender.REST.layout=PatternLayout
log4perl.appender.REST.layout.ConversionPattern=[%d] [%p] %m %l %n
log4perl.appender.REST.utf8=1

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Nov 22 09:22:04 2017
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 22 Nov 2017 08:22:04 +0000
Subject: [Koha-bugs] [Bug 19652] REST API: Log request and response content
In-Reply-To: <bug-19652-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-19652-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-19652-70-fhxdPscZIs@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19652

Lari Taskula <lari.taskula at jns.fi> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
            Summary|Debug-level logging for     |REST API: Log request and
                   |response JSON               |response content

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Nov 22 09:26:44 2017
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 22 Nov 2017 08:26:44 +0000
Subject: [Koha-bugs] [Bug 19672] Move tools templates JavaScript to the
 footer: More MARC tools
In-Reply-To: <bug-19672-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-19672-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-19672-70-gRetEPvU6S@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19672

Claire Gravely <claire_gravely at hotmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Needs Signoff               |Signed Off

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Nov 22 09:26:47 2017
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 22 Nov 2017 08:26:47 +0000
Subject: [Koha-bugs] [Bug 19672] Move tools templates JavaScript to the
 footer: More MARC tools
In-Reply-To: <bug-19672-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-19672-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-19672-70-1pzDYfF4NZ@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19672

Claire Gravely <claire_gravely at hotmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #69252|0                           |1
        is obsolete|                            |

--- Comment #2 from Claire Gravely <claire_gravely at hotmail.com> ---
Created attachment 69266
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=69266&action=edit
Bug 19672: Move tools templates JavaScript to the footer: More MARC tools

This patch modifies some staff client templates from the "Tools"
section so that JavaScript is included in the footer instead of the
header.

- Automatic item modifications by age
- MARC modification templates
- Stage MARC records for import
- Staged MARC record management

To test, apply the patch and test the JavaScript-driven features of
each modified template: All button controls, DataTables functionality,
form validation, etc.

Signed-off-by: Claire Gravely <claire.gravely at bsz-bw.de>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Nov 22 09:35:36 2017
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 22 Nov 2017 08:35:36 +0000
Subject: [Koha-bugs] [Bug 19652] REST API: Log request and response content
In-Reply-To: <bug-19652-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-19652-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-19652-70-vDlYAHk0PX@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19652

Lari Taskula <lari.taskula at jns.fi> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #69265|0                           |1
        is obsolete|                            |

--- Comment #5 from Lari Taskula <lari.taskula at jns.fi> ---
Created attachment 69267
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=69267&action=edit
Bug 19652: REST API: Log request and response content

This patch adds request and response logger to REST API. It is useful for
viewing
parameters that came within the request, and the content that is about to be
rendered back.

To test:
1. prove t/db_dependent/api/v1.t
2. Configure log4perl configuration file for REST API and set log level to
DEBUG
3. Make any request to existing REST API endpoint
4. Observe response JSON in your log file

Example configuration:
log4perl.logger.rest = DEBUG, REST
log4perl.appender.REST=Log::Log4perl::Appender::File
log4perl.appender.REST.filename=/home/koha/koha-dev/var/log/rest.log
log4perl.appender.REST.create_at_logtime=true
log4perl.appender.REST.syswrite=true
log4perl.appender.REST.recreate=true
log4perl.appender.REST.mode=append
log4perl.appender.REST.layout=PatternLayout
log4perl.appender.REST.layout.ConversionPattern=[%d] [%p] %m %l %n
log4perl.appender.REST.utf8=1

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Nov 22 09:37:14 2017
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 22 Nov 2017 08:37:14 +0000
Subject: [Koha-bugs] [Bug 19671] Circulation wizard / issues_stats.pl does
 not populate itemtype descriptions correctly
In-Reply-To: <bug-19671-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-19671-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-19671-70-cn9xnSYjgr@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19671

Claire Gravely <claire_gravely at hotmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |claire_gravely at hotmail.com

--- Comment #2 from Claire Gravely <claire_gravely at hotmail.com> ---
Hullo,

I find that my itemtypes drop down list just shows blanks instead of the item
types with patch applied. When I run the report I get a column for Books in the
results but then a Blank column next to it.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Nov 22 09:48:04 2017
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 22 Nov 2017 08:48:04 +0000
Subject: [Koha-bugs] [Bug 19664] Reports sidebar menu should match list of
 reports on reports home page
In-Reply-To: <bug-19664-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-19664-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-19664-70-tNUjhkHftW@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19664

Claire Gravely <claire_gravely at hotmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #69245|0                           |1
        is obsolete|                            |

--- Comment #2 from Claire Gravely <claire_gravely at hotmail.com> ---
Created attachment 69268
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=69268&action=edit
Bug 19664: Reports sidebar menu should match list of reports on reports home
page

This patch makes the reports sidebar menu a little more consistent with
the reports home page menu by adding missing links to reports.

To test, observer the reports sidebar menu before and after the patch
and confirm that missing reports are linked in the update.

Signed-off-by: Claire Gravely <claire.gravely at bsz-bw.de>

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.

From bugzilla-daemon at bugs.koha-community.org  Wed Nov 22 09:48:01 2017
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 22 Nov 2017 08:48:01 +0000
Subject: [Koha-bugs] [Bug 19664] Reports sidebar menu should match list of
 reports on reports home page
In-Reply-To: <bug-19664-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-19664-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-19664-70-BIWpTiU1Qi@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19664

Claire Gravely <claire_gravely at hotmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Needs Signoff               |Signed Off

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.

From bugzilla-daemon at bugs.koha-community.org  Wed Nov 22 09:52:38 2017
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 22 Nov 2017 08:52:38 +0000
Subject: [Koha-bugs] [Bug 19674] Broken indicators of changed fields in
 manage staged MARC records template
In-Reply-To: <bug-19674-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-19674-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-19674-70-LW3e2YWMWn@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19674

Claire Gravely <claire_gravely at hotmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Needs Signoff               |Signed Off

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Nov 22 09:52:40 2017
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 22 Nov 2017 08:52:40 +0000
Subject: [Koha-bugs] [Bug 19674] Broken indicators of changed fields in
 manage staged MARC records template
In-Reply-To: <bug-19674-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-19674-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-19674-70-8ONkrCezIu@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19674

Claire Gravely <claire_gravely at hotmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #69251|0                           |1
        is obsolete|                            |

--- Comment #2 from Claire Gravely <claire_gravely at hotmail.com> ---
Created attachment 69269
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=69269&action=edit
Bug 19674: Broken indicators of changed fields in manage staged MARC records
template

This patch returns some CSS to the manage staged MARC records template
which was incorrectly removed by Gug 16538.

To test, apply the patch and go to Tools -> Staged MARC management.
Choose a staged MARC file.

Changing any of the <select> fields in the first section should cause a
label to appear showing that the selection has changed, along with a
link to reset the option to its original state. Clicking 'Reset' should
make the label and the link disappear.

Signed-off-by: Claire Gravely <claire.gravely at bsz-bw.de>

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.

From bugzilla-daemon at bugs.koha-community.org  Wed Nov 22 11:13:41 2017
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 22 Nov 2017 10:13:41 +0000
Subject: [Koha-bugs] [Bug 3777] Field Sizes Inconsistent
In-Reply-To: <bug-3777-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-3777-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-3777-70-OKE1Nnl5BK@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=3777

Jon Knight <J.P.Knight at lboro.ac.uk> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |J.P.Knight at lboro.ac.uk

--- Comment #12 from Jon Knight <J.P.Knight at lboro.ac.uk> ---
I'm just trawling through old REOPENed cases and I see that the current (17.05)
borrower schema still has the inconsistencies in the addresses.  As this was
reopened because it was proving to be an issue for some addresses longer than
100 characters, is it worth just attacking just those fields to make them all
match the address versions?

In other words make these field changes in the borrowers table schema:

B_address mediumtext NOT NULL,
B_address2 text,
B_city mediumtext NOT NULL,

and

altcontactaddress1 mediumtext NOT NULL,
altcontactaddress2 text,
altcontactaddress3 mediumtext NOT NULL,

-- 
You are receiving this mail because:
You are the QA Contact for the bug.
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Nov 22 11:24:55 2017
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 22 Nov 2017 10:24:55 +0000
Subject: [Koha-bugs] [Bug 19628] Move course reserves templates JS to the
	footer
In-Reply-To: <bug-19628-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-19628-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-19628-70-X5B8r8cWQY@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19628

Claire Gravely <claire_gravely at hotmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Needs Signoff               |Signed Off

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Nov 22 11:24:58 2017
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 22 Nov 2017 10:24:58 +0000
Subject: [Koha-bugs] [Bug 19628] Move course reserves templates JS to the
	footer
In-Reply-To: <bug-19628-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-19628-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-19628-70-ZwLumguxe5@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19628

Claire Gravely <claire_gravely at hotmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #69164|0                           |1
        is obsolete|                            |

--- Comment #2 from Claire Gravely <claire_gravely at hotmail.com> ---
Created attachment 69270
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=69270&action=edit
Bug 19628: Move course reserves templates JS to the footer

This patch modifies the staff client course reserves templates so that
JavaScript is included in the footer instead of the header.

To test, apply the patch and test the JavaScript-driven features of
each page: All button controls, DataTables, autocomplete, etc.

Signed-off-by: Claire Gravely <claire.gravely at bsz-bw.de>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Nov 22 11:25:41 2017
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 22 Nov 2017 10:25:41 +0000
Subject: [Koha-bugs] [Bug 3185] Mobile Library/Bookmobile Mode
In-Reply-To: <bug-3185-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-3185-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-3185-70-Hw2xGouZev@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=3185

Jon Knight <J.P.Knight at lboro.ac.uk> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |J.P.Knight at lboro.ac.uk

--- Comment #2 from Jon Knight <J.P.Knight at lboro.ac.uk> ---
Is this still required?  In the current version of Koha I can go into "Home ?
Administration ? Circulation and fine rules", select a particular library and
then set "Return policy" in the "Default checkout, hold and return policy for
<library>" to be "Item returns to issuing library".  If the particular library
in question is a mobile library van, would this not mean that books it issued
returned back to it?  I think this matches up with the original request from
seven years ago?

-- 
You are receiving this mail because:
You are the QA Contact for the bug.
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Nov 22 11:40:17 2017
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 22 Nov 2017 10:40:17 +0000
Subject: [Koha-bugs] [Bug 19657] Move lists templates JS to the footer
In-Reply-To: <bug-19657-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-19657-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-19657-70-a9kgIC5Lec@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19657

Claire Gravely <claire_gravely at hotmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #69238|0                           |1
        is obsolete|                            |

--- Comment #2 from Claire Gravely <claire_gravely at hotmail.com> ---
Created attachment 69271
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=69271&action=edit
Bug 19657: Move lists templates JS to the footer

This patch modifies the staff client's lists templates so that
JavaScript is included in the footer instead of the header.

To test, apply the patch and test the JavaScript-driven features of the
lists page: All button controls, DataTables functionality, form
validation, etc.

Signed-off-by: Claire Gravely <claire.gravely at bsz-bw.de>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Nov 22 11:40:14 2017
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 22 Nov 2017 10:40:14 +0000
Subject: [Koha-bugs] [Bug 19657] Move lists templates JS to the footer
In-Reply-To: <bug-19657-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-19657-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-19657-70-ywwwWeJici@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19657

Claire Gravely <claire_gravely at hotmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Needs Signoff               |Signed Off

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Nov 22 11:49:51 2017
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 22 Nov 2017 10:49:51 +0000
Subject: [Koha-bugs] [Bug 12497] Make OPAC search history feature accessible
 when it should
In-Reply-To: <bug-12497-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-12497-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-12497-70-NmPfqnTaFH@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12497

Gaetan Boisson <gaetan.boisson at biblibre.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |gaetan.boisson at biblibre.com
            Summary|OPAC search history page    |Make OPAC search history
                   |should only be accessible   |feature accessible when it
                   |when feature is activated   |should

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Nov 22 11:53:54 2017
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 22 Nov 2017 10:53:54 +0000
Subject: [Koha-bugs] [Bug 12497] Make OPAC search history feature accessible
 when it should
In-Reply-To: <bug-12497-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-12497-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-12497-70-fd9f0vc4BG@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12497

--- Comment #3 from Gaetan Boisson <gaetan.boisson at biblibre.com> ---
On additional issue is that if you have activated search history on the opac,
and have an opac set to private via opacpublic, then patrons can only access
their search history if they have the permission to manage borrowers.

To reproduce :
- set your opac to private via opacpublic
- activate EnableOpacSearchHistory
- log in your private opac with a user that has no permissions for the staff
interface
- search for something in the catalog
- the link for search history is now visible, but if you click on it, you will
get an access denied message

- log in to your private opac with a user that has the "borrowers" permission
- repeat above steps : you can now access your search history.

Since this issue and the fact that the url still responds when the syspref is
turned off, when it should  display an access denied page, can be fixed in the
same block of code, we will offer a patch for both issues at once.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Nov 22 11:54:56 2017
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 22 Nov 2017 10:54:56 +0000
Subject: [Koha-bugs] [Bug 12497] Make OPAC search history feature accessible
 when it should
In-Reply-To: <bug-12497-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-12497-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-12497-70-yb3hpqpmoa@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12497

Victor Grousset/tuxayo <victor.grousset at biblibre.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|NEW                         |ASSIGNED
           Assignee|oleonard at myacpl.org         |victor.grousset at biblibre.co
                   |                            |m
                 CC|                            |victor.grousset at biblibre.co
                   |                            |m

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Nov 22 13:05:05 2017
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 22 Nov 2017 12:05:05 +0000
Subject: [Koha-bugs] [Bug 19659] Move JS to the footer: Suggestions and tags
In-Reply-To: <bug-19659-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-19659-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-19659-70-CBOcwK5Fy1@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19659

Claire Gravely <claire_gravely at hotmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |claire_gravely at hotmail.com
             Status|Needs Signoff               |Failed QA

--- Comment #2 from Claire Gravely <claire_gravely at hotmail.com> ---
Getting JS ReferenceError: $ is not defined
suggestion.pl:554:5

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Nov 22 13:48:43 2017
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 22 Nov 2017 12:48:43 +0000
Subject: [Koha-bugs] [Bug 18591] Allow an arbitrary number of comments on
	ILLs
In-Reply-To: <bug-18591-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-18591-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-18591-70-31BTkQGJ9y@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18591

--- Comment #3 from Magnus Enger <magnus at libriotech.no> ---
Created attachment 69272
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=69272&action=edit
Bug 18591 - Database updates

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Nov 22 13:49:27 2017
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 22 Nov 2017 12:49:27 +0000
Subject: [Koha-bugs] [Bug 18591] Allow an arbitrary number of comments on
	ILLs
In-Reply-To: <bug-18591-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-18591-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-18591-70-iKqQ3ua6a5@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18591

Magnus Enger <magnus at libriotech.no> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #69234|0                           |1
        is obsolete|                            |
  Attachment #69272|0                           |1
        is obsolete|                            |

--- Comment #4 from Magnus Enger <magnus at libriotech.no> ---
Created attachment 69273
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=69273&action=edit
Bug 18591 - Database updates

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Nov 22 13:49:32 2017
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 22 Nov 2017 12:49:32 +0000
Subject: [Koha-bugs] [Bug 18591] Allow an arbitrary number of comments on
	ILLs
In-Reply-To: <bug-18591-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-18591-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-18591-70-jST9ArbI4t@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18591

--- Comment #5 from Magnus Enger <magnus at libriotech.no> ---
Created attachment 69274
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=69274&action=edit
Update Schema - DO NOT PUSH

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Nov 22 13:49:36 2017
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 22 Nov 2017 12:49:36 +0000
Subject: [Koha-bugs] [Bug 18591] Allow an arbitrary number of comments on
	ILLs
In-Reply-To: <bug-18591-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-18591-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-18591-70-CY4DSYo28T@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18591

--- Comment #6 from Magnus Enger <magnus at libriotech.no> ---
Created attachment 69275
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=69275&action=edit
Bug 18591 - Allow any number of comments on ILLs

This patch makes it possible to add arbitrary comments to ILL
requests. Comments are read only and displayed in chronological
order. Comments can be added by librarians, but also added automatically
based on comments in the different protocols, so that comments from the
lending library can also be added.

To test:
- Enable the ILL module ("ILLModule" syspref + config in koha-conf.xml)
- Install the Dummy backend from here:
  https://github.com/PTFS-Europe/Dummy
- Create a Dummy ILL request
- Add comments to the request, checking that the name and borrowernumber
  of the person that added the comment is displayed ok
- Check that the displayed date and time the comment was submitted follows
  the "dateformat" syspref
- On the "List requests" page, check that the correct number of comments
  is displayed in the "Comments" column
- Check that the tests pass:
  prove t/db_dependent/Illcomments.t

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Nov 22 13:51:00 2017
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 22 Nov 2017 12:51:00 +0000
Subject: [Koha-bugs] [Bug 15996] Bibliographic records diffing tool
In-Reply-To: <bug-15996-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-15996-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-15996-70-TMyfh8YXOO@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15996

Magnus Enger <magnus at libriotech.no> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |magnus at libriotech.no

--- Comment #3 from Magnus Enger <magnus at libriotech.no> ---
Should this be "Needs signoff"? Could you add a test plan?

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Nov 22 14:00:14 2017
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 22 Nov 2017 13:00:14 +0000
Subject: [Koha-bugs] [Bug 19410] Add a helper function for generating object
 searches for the API
In-Reply-To: <bug-19410-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-19410-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-19410-70-nHOYmyH13y@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19410

Tom?s Cohen Arazi <tomascohen at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
          Component|Architecture, internals,    |REST api
                   |and plumbing                |
         QA Contact|testopia at bugs.koha-communit |
                   |y.org                       |
            Summary|Koha::Objects needs a       |Add a helper function for
                   |->search_for_api method     |generating object searches
                   |                            |for the API

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Nov 22 14:01:42 2017
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 22 Nov 2017 13:01:42 +0000
Subject: [Koha-bugs] [Bug 19410] Add a helper function for generating object
 searches for the API
In-Reply-To: <bug-19410-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-19410-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-19410-70-MFJwLAImxO@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19410

Tom?s Cohen Arazi <tomascohen at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
   Patch complexity|Small patch                 |Medium patch

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Nov 22 14:28:39 2017
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 22 Nov 2017 13:28:39 +0000
Subject: [Koha-bugs] [Bug 19659] Move JS to the footer: Suggestions and tags
In-Reply-To: <bug-19659-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-19659-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-19659-70-216r81OYIb@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19659

Owen Leonard <oleonard at myacpl.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Failed QA                   |ASSIGNED

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Nov 22 14:32:15 2017
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 22 Nov 2017 13:32:15 +0000
Subject: [Koha-bugs] [Bug 19678] New: Clicking Cancel when adding New Course
 shows message Invalid Course!
Message-ID: <bug-19678-70@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19678

            Bug ID: 19678
           Summary: Clicking Cancel when adding New Course shows message
                    Invalid Course!
 Change sponsored?: ---
           Product: Koha
           Version: master
          Hardware: All
                OS: All
            Status: NEW
          Severity: enhancement
          Priority: P5 - low
         Component: Course reserves
          Assignee: koha-bugs at lists.koha-community.org
          Reporter: claire_gravely at hotmail.com
        QA Contact: testopia at bugs.koha-community.org

Clicking on the cancel link when adding a new course to course reserves
displays the message 'Invalid Course!'. It would be better if it redirected
back to the main Course Reserves page.

To reproduce: 
Go to Course Reserves
Click '+ New Course'
Cancel the process
You are shown 'Invalid Course!'

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Nov 22 14:32:38 2017
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 22 Nov 2017 13:32:38 +0000
Subject: [Koha-bugs] [Bug 19678] Clicking Cancel when adding New Course to
 course reserves shows message Invalid Course!
In-Reply-To: <bug-19678-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-19678-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-19678-70-N6wDLiIYNw@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19678

Claire Gravely <claire_gravely at hotmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
            Summary|Clicking Cancel when adding |Clicking Cancel when adding
                   |New Course shows message    |New Course to course
                   |Invalid Course!             |reserves shows message
                   |                            |Invalid Course!

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Nov 22 14:32:57 2017
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 22 Nov 2017 13:32:57 +0000
Subject: [Koha-bugs] [Bug 19678] Clicking Cancel when adding New Course to
 course reserves shows message Invalid Course!
In-Reply-To: <bug-19678-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-19678-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-19678-70-9Y5C34A1Lt@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19678

Claire Gravely <claire_gravely at hotmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
           Assignee|koha-bugs at lists.koha-commun |claire_gravely at hotmail.com
                   |ity.org                     |

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Nov 22 14:38:17 2017
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 22 Nov 2017 13:38:17 +0000
Subject: [Koha-bugs] [Bug 19659] Move JS to the footer: Suggestions and tags
In-Reply-To: <bug-19659-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-19659-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-19659-70-h6c0rL0eZO@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19659

Owen Leonard <oleonard at myacpl.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|ASSIGNED                    |Needs Signoff

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Nov 22 14:38:20 2017
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 22 Nov 2017 13:38:20 +0000
Subject: [Koha-bugs] [Bug 19659] Move JS to the footer: Suggestions and tags
In-Reply-To: <bug-19659-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-19659-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-19659-70-EOmZxXNWpZ@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19659

Owen Leonard <oleonard at myacpl.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #69240|0                           |1
        is obsolete|                            |

--- Comment #3 from Owen Leonard <oleonard at myacpl.org> ---
Created attachment 69276
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=69276&action=edit
Bug 19659: Move JS to the footer: Suggestions and tags

This patch modifies the staff client's suggestions and tags templates so
that JavaScript is included in the footer instead of the header.

This patch adds a new JS file, acquisitions-menu.js, which will be added
to each template which has the Acquisitions sidebar menu (in this case,
suggestions). Highlighting of the current page in the sidebar menu will
be broken for pages which have not been modified to use this file.

To test, apply the patch and test the JavaScript-driven features of
suggestions and tags pages: All button controls, DataTables
functionality, form validation, etc.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Nov 22 14:47:43 2017
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 22 Nov 2017 13:47:43 +0000
Subject: [Koha-bugs] [Bug 19016] Add a script to fix corrupted data
In-Reply-To: <bug-19016-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-19016-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-19016-70-7SRsj6P2kD@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19016

Oliver Bock <oliver.bock at aei.mpg.de> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |oliver.bock at aei.mpg.de

--- Comment #16 from Oliver Bock <oliver.bock at aei.mpg.de> ---
FWIW, I just tried the script with all the patches (up to now) and ran into a
FK constraint violation:


% ./cleanup_database.pl --fix-corrupted-data

 * Tables biblio/deletedbiblio: 1455
Updating biblio.biblionumber=1455 with new id 1516
DBD::mysql::st execute failed: Cannot add or update a child row: a foreign key
constraint fails (`koha_koha`.`items`, CONSTRAINT `items_ibfk_5` FOREIGN KEY
(`biblionumber`) REFERENCES `biblio` (`biblionumber`) ON DELETE CASCADE ON
UPDATE CASCADE) [for Statement "UPDATE biblio SET biblionumber = ? WHERE
biblionumber = ?" with ParamValues: 0=1516, 1=1455] at ./cleanup_database.pl
line 510, <DATA> line 755.
Something went wrong, rolling back!

 * Tables biblioitems/deletedbiblioitems: 1455
Updating biblioitems.biblioitemnumber=1455 with new id 1516

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Nov 22 14:56:14 2017
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 22 Nov 2017 13:56:14 +0000
Subject: [Koha-bugs] [Bug 19678] Clicking Cancel when adding New Course to
 course reserves shows message Invalid Course!
In-Reply-To: <bug-19678-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-19678-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-19678-70-qUHQxiNHGc@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19678

--- Comment #1 from Claire Gravely <claire_gravely at hotmail.com> ---
Created attachment 69277
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=69277&action=edit
Bug 19678: Clicking Cancel when adding New Course to course reserves shows
message Invalid Course!

Clicking on the cancel link when adding a new course to course reserves
displays the message 'Invalid Course!'. It would be better if it
redirected back to the main Course Reserves page.

This patch redirects the user back to the main course reserves page.

To Test:

1. Go to Course Reserves

2. Click '+ New Course'

3. Cancel the process

4. You are shown 'Invalid Course!'

5. Apply patch and repeat steps 1-3

6. You are redirected back to the main course reserves page

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Nov 22 14:56:35 2017
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 22 Nov 2017 13:56:35 +0000
Subject: [Koha-bugs] [Bug 19678] Clicking Cancel when adding New Course to
 course reserves shows message Invalid Course!
In-Reply-To: <bug-19678-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-19678-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-19678-70-KbYcZNjrq7@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19678

Claire Gravely <claire_gravely at hotmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|NEW                         |Needs Signoff

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Nov 22 15:34:55 2017
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 22 Nov 2017 14:34:55 +0000
Subject: [Koha-bugs] [Bug 19678] Clicking Cancel when adding New Course to
 course reserves shows message Invalid Course!
In-Reply-To: <bug-19678-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-19678-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-19678-70-HskofMO80T@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19678

Claire Gravely <claire_gravely at hotmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #69277|0                           |1
        is obsolete|                            |

--- Comment #2 from Claire Gravely <claire_gravely at hotmail.com> ---
Created attachment 69278
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=69278&action=edit
Bug 19678: Clicking Cancel when adding New Course to course reserves shows
message Invalid Course!

Clicking on the cancel link when adding a new course to course reserves
displays the message 'Invalid Course!'. It would be better if it
redirected back to the main Course Reserves page.

This patch redirects the user back to the main course reserves page.

To Test:

1. Go to Course Reserves

2. Click '+ New Course'

3. Cancel the process

4. You are shown 'Invalid Course!'

5. Apply patch and repeat steps 1-3

6. You are redirected back to the main course reserves page

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Nov 22 15:35:22 2017
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 22 Nov 2017 14:35:22 +0000
Subject: [Koha-bugs] [Bug 17656] Irregularities in serial prediction pattern
 are planned only for current subscription
In-Reply-To: <bug-17656-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-17656-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-17656-70-ze74qWCNA4@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17656

Koha Team Lyon 3 <koha at univ-lyon3.fr> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Signed Off                  |In Discussion

--- Comment #26 from Koha Team Lyon 3 <koha at univ-lyon3.fr> ---
Hello Alex,
For the three types of periodicity, the "permanent" irregularities on top of
table are kept over the renewal. This is working. But the detail of excluded
issues is not automatically set in relation with these ones (cf joined
image).We have to manually uncheck and recheck the "permanent" irregularities
to have the corresponding issues checked in the "Not published column".

That's a progress in the sense that there's a trace of the previous
configuration but the idea was to get all this automatically. would it be
possible ?

Olivier Crouzet

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Nov 22 15:39:23 2017
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 22 Nov 2017 14:39:23 +0000
Subject: [Koha-bugs] [Bug 17656] Irregularities in serial prediction pattern
 are planned only for current subscription
In-Reply-To: <bug-17656-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-17656-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-17656-70-LbNmFA0C7K@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17656

--- Comment #27 from Koha Team Lyon 3 <koha at univ-lyon3.fr> ---
Created attachment 69279
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=69279&action=edit
monthly irregularities test example

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Nov 22 15:43:01 2017
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 22 Nov 2017 14:43:01 +0000
Subject: [Koha-bugs] [Bug 10035] move or copy hard due date to be by patron
	category
In-Reply-To: <bug-10035-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-10035-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-10035-70-rQzZlzDFez@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10035

Marjorie Barry-Vila <marjorie.barry-vila at collecto.ca> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |marjorie.barry-vila at collect
                   |                            |o.ca

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Nov 22 15:44:03 2017
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 22 Nov 2017 14:44:03 +0000
Subject: [Koha-bugs] [Bug 15395] Allow correct handling of plural translation
In-Reply-To: <bug-15395-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-15395-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-15395-70-D0May5fRoj@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15395

Marjorie Barry-Vila <marjorie.barry-vila at collecto.ca> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |marjorie.barry-vila at collect
                   |                            |o.ca

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Nov 22 15:44:07 2017
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 22 Nov 2017 14:44:07 +0000
Subject: [Koha-bugs] [Bug 11285] Vocabulary disambiguation
In-Reply-To: <bug-11285-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-11285-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-11285-70-pudKozrDUQ@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11285

Marjorie Barry-Vila <marjorie.barry-vila at collecto.ca> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |marjorie.barry-vila at collect
                   |                            |o.ca

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Nov 22 15:51:06 2017
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 22 Nov 2017 14:51:06 +0000
Subject: [Koha-bugs] [Bug 19678] Clicking Cancel when adding New Course to
 course reserves shows message Invalid Course!
In-Reply-To: <bug-19678-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-19678-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-19678-70-RMHy7Ge8AF@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19678

Claire Gravely <claire_gravely at hotmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #69278|0                           |1
        is obsolete|                            |

--- Comment #3 from Claire Gravely <claire_gravely at hotmail.com> ---
Created attachment 69280
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=69280&action=edit
Bug 19678: Clicking Cancel when adding New Course to course reserves shows
message Invalid Course!

Clicking on the cancel link when adding a new course to course reserves
displays the message 'Invalid Course!'. It would be better if it
redirected back to the main Course Reserves page.

This patch redirects the user back to the main course reserves page.

To Test:

1. Go to Course Reserves

2. Click '+ New Course'

3. Cancel the process

4. You are shown 'Invalid Course!'

5. Apply patch and repeat steps 1-3

6. You are redirected back to the main course reserves page

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Nov 22 15:59:29 2017
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 22 Nov 2017 14:59:29 +0000
Subject: [Koha-bugs] [Bug 19678] Clicking Cancel when adding New Course to
 course reserves shows message Invalid Course!
In-Reply-To: <bug-19678-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-19678-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-19678-70-QM1JACIoT5@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19678

Owen Leonard <oleonard at myacpl.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Needs Signoff               |Signed Off
   Patch complexity|---                         |Trivial patch

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Nov 22 15:59:31 2017
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 22 Nov 2017 14:59:31 +0000
Subject: [Koha-bugs] [Bug 19678] Clicking Cancel when adding New Course to
 course reserves shows message Invalid Course!
In-Reply-To: <bug-19678-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-19678-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-19678-70-PzbQXXDF9E@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19678

Owen Leonard <oleonard at myacpl.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #69280|0                           |1
        is obsolete|                            |

--- Comment #4 from Owen Leonard <oleonard at myacpl.org> ---
Created attachment 69281
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=69281&action=edit
Bug 19678: Clicking Cancel when adding New Course to course reserves shows
message Invalid Course!

Clicking on the cancel link when adding a new course to course reserves
displays the message 'Invalid Course!'. It would be better if it
redirected back to the main Course Reserves page.

This patch redirects the user back to the main course reserves page.

To Test:

1. Go to Course Reserves

2. Click '+ New Course'

3. Cancel the process

4. You are shown 'Invalid Course!'

5. Apply patch and repeat steps 1-3

6. You are redirected back to the main course reserves page

Signed-off-by: Owen Leonard <oleonard at myacpl.org>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Nov 22 16:30:17 2017
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 22 Nov 2017 15:30:17 +0000
Subject: [Koha-bugs] [Bug 19410] Add a helper function for generating object
 searches for the API
In-Reply-To: <bug-19410-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-19410-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-19410-70-T0uB9j9C7D@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19410

Lari Taskula <lari.taskula at jns.fi> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #69258|0                           |1
        is obsolete|                            |

--- Comment #22 from Lari Taskula <lari.taskula at jns.fi> ---
Created attachment 69282
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=69282&action=edit
Bug 19410: Add Koha::Objects->search_for_api

Following the discussion about the best way to make things simpler for
developing the REST api, I quote Lari's email:

"As many other endpoint will have the exact same usage, by looking at your
example, I would prefer to avoid writing parameter / pagination / sorting /
header handling for each list operation in our API controllers. Do you think
it's possible to centralize all of this e.g. by passing $c into a customized
search sub? Perhaps in Koha::Objects?
so instead we could have something like (ignore my bad choice of naming)...:
sub list_vendors {
  my $c = shift->openapi->valid_input or return;
  my $args = $c->validation->output;
  my $vendors;

  return try {
    $vendors = Koha::Acquisition::Booksellers->api_list_search($c);
    return $c->render(status => 200, openapi => $vendors);
  } catch {
    ...
  }
}"

We all agreed we neeed something like that. Here's a possible implementation. I
take
advantage of the previously written Mojo helpers, that are fully covered by
tests.

I submit this early so anyone can take a look and gather ideas to make it even
better.
I'm already using it (effectively) for the /acquisitions/orders endpoint I'm
writing
on bug 18731.

Thanks!

Signed-off-by: Tomas Cohen Arazi <tomascohen at theke.io>
Signed-off-by: Julian Maurice <julian.maurice at biblibre.com>

Signed-off-by: Lari Taskula <lari.taskula at jns.fi>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Nov 22 16:30:32 2017
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 22 Nov 2017 15:30:32 +0000
Subject: [Koha-bugs] [Bug 19410] Add a helper function for generating object
 searches for the API
In-Reply-To: <bug-19410-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-19410-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-19410-70-7xKaQZBjFl@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19410

Lari Taskula <lari.taskula at jns.fi> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #69259|0                           |1
        is obsolete|                            |

--- Comment #23 from Lari Taskula <lari.taskula at jns.fi> ---
Created attachment 69283
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=69283&action=edit
Bug 19410: Unit tests

Signed-off-by: Tomas Cohen Arazi <tomascohen at theke.io>
Signed-off-by: Julian Maurice <julian.maurice at biblibre.com>

Signed-off-by: Lari Taskula <lari.taskula at jns.fi>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Nov 22 16:30:42 2017
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 22 Nov 2017 15:30:42 +0000
Subject: [Koha-bugs] [Bug 19410] Add a helper function for generating object
 searches for the API
In-Reply-To: <bug-19410-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-19410-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-19410-70-t8FvGcljkV@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19410

Lari Taskula <lari.taskula at jns.fi> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #69260|0                           |1
        is obsolete|                            |

--- Comment #24 from Lari Taskula <lari.taskula at jns.fi> ---
Created attachment 69284
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=69284&action=edit
Bug 19410: (follow-up) Fix typo in POD

Signed-off-by: Tomas Cohen Arazi <tomascohen at theke.io>
Signed-off-by: Julian Maurice <julian.maurice at biblibre.com>

Signed-off-by: Lari Taskula <lari.taskula at jns.fi>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Nov 22 16:30:50 2017
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 22 Nov 2017 15:30:50 +0000
Subject: [Koha-bugs] [Bug 19659] Move JS to the footer: Suggestions and tags
In-Reply-To: <bug-19659-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-19659-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-19659-70-LwKHeiGAG6@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19659

Claire Gravely <claire_gravely at hotmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #69276|0                           |1
        is obsolete|                            |

--- Comment #4 from Claire Gravely <claire_gravely at hotmail.com> ---
Created attachment 69285
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=69285&action=edit
Bug 19659: Move JS to the footer: Suggestions and tags

This patch modifies the staff client's suggestions and tags templates so
that JavaScript is included in the footer instead of the header.

This patch adds a new JS file, acquisitions-menu.js, which will be added
to each template which has the Acquisitions sidebar menu (in this case,
suggestions). Highlighting of the current page in the sidebar menu will
be broken for pages which have not been modified to use this file.

To test, apply the patch and test the JavaScript-driven features of
suggestions and tags pages: All button controls, DataTables
functionality, form validation, etc.

Signed-off-by: Claire Gravely <claire.gravely at bsz-bw.de>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Nov 22 16:30:48 2017
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 22 Nov 2017 15:30:48 +0000
Subject: [Koha-bugs] [Bug 19659] Move JS to the footer: Suggestions and tags
In-Reply-To: <bug-19659-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-19659-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-19659-70-RWzffli11L@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19659

Claire Gravely <claire_gravely at hotmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Needs Signoff               |Signed Off

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Nov 22 16:30:53 2017
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 22 Nov 2017 15:30:53 +0000
Subject: [Koha-bugs] [Bug 19410] Add a helper function for generating object
 searches for the API
In-Reply-To: <bug-19410-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-19410-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-19410-70-FvXRcTn5aW@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19410

Lari Taskula <lari.taskula at jns.fi> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #69261|0                           |1
        is obsolete|                            |

--- Comment #25 from Lari Taskula <lari.taskula at jns.fi> ---
Created attachment 69286
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=69286&action=edit
Bug 19410: Move search_for_api into a Mojo helper

Signed-off-by: Tomas Cohen Arazi <tomascohen at theke.io>
Signed-off-by: Julian Maurice <julian.maurice at biblibre.com>

Signed-off-by: Lari Taskula <lari.taskula at jns.fi>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Nov 22 16:31:05 2017
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 22 Nov 2017 15:31:05 +0000
Subject: [Koha-bugs] [Bug 19410] Add a helper function for generating object
 searches for the API
In-Reply-To: <bug-19410-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-19410-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-19410-70-WwE6nZ5yhq@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19410

Lari Taskula <lari.taskula at jns.fi> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #69262|0                           |1
        is obsolete|                            |

--- Comment #26 from Lari Taskula <lari.taskula at jns.fi> ---
Created attachment 69287
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=69287&action=edit
Bug 19410: (QA followup) Move build_query_params_from_api into a helper

This patch creates the 'build_query_params' helper, instead of the
original function in Koha::Objects.

Unit tests are removed for Koha::Objects::_build_query_params_from_api and
written for the helper plugin.

The objects.search helper gets a call to build_query_params added. Tests for it
updated to match this behaviour change.

To test:
- Apply this patches
- Run:
  $ kshell
 k$ prove t/Koha/REST/Plugin/Query.t \
          t/db_dependent/Koha/Objects.t \
          t/db_dependent/Koha/REST/Plugin/Objects.t
=> SUCCESS: Tests pass!
- Sign off :-D

Signed-off-by: Tomas Cohen Arazi <tomascohen at theke.io>
Signed-off-by: Julian Maurice <julian.maurice at biblibre.com>

Signed-off-by: Lari Taskula <lari.taskula at jns.fi>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Nov 22 17:18:24 2017
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 22 Nov 2017 16:18:24 +0000
Subject: [Koha-bugs] [Bug 19679] New: Move tools templates JavaScript to the
 footer: More MARC tools
Message-ID: <bug-19679-70@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19679

            Bug ID: 19679
           Summary: Move tools templates JavaScript to the footer: More
                    MARC tools
 Change sponsored?: ---
           Product: Koha
           Version: master
          Hardware: All
                OS: All
            Status: ASSIGNED
          Severity: enhancement
          Priority: P5 - low
         Component: Templates
          Assignee: oleonard at myacpl.org
          Reporter: oleonard at myacpl.org
        QA Contact: testopia at bugs.koha-community.org
                CC: testopia at bugs.koha-community.org
        Depends on: 19647
            Blocks: 17858

In order to conform to best practices for performance staff client template
javascript should be in the footer instead of the header.

This patch will do so for more Tools features.


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17858
[Bug 17858] Omnibus: Move staff client JavaScript to the footer
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19647
[Bug 19647] Move patron lists templates JS to the footer
-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Nov 22 17:18:24 2017
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 22 Nov 2017 16:18:24 +0000
Subject: [Koha-bugs] [Bug 19647] Move patron lists templates JS to the footer
In-Reply-To: <bug-19647-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-19647-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-19647-70-2I86ByagcT@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19647

Owen Leonard <oleonard at myacpl.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Blocks|                            |19679


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19679
[Bug 19679] Move tools templates JavaScript to the footer: More MARC tools
-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Nov 22 17:18:24 2017
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 22 Nov 2017 16:18:24 +0000
Subject: [Koha-bugs] [Bug 17858] Omnibus: Move staff client JavaScript to
	the footer
In-Reply-To: <bug-17858-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-17858-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-17858-70-8j1VbMNIhk@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17858

Owen Leonard <oleonard at myacpl.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
         Depends on|                            |19679


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19679
[Bug 19679] Move tools templates JavaScript to the footer: More MARC tools
-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Nov 22 17:19:04 2017
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 22 Nov 2017 16:19:04 +0000
Subject: [Koha-bugs] [Bug 19679] Move templates JavaScript to the footer:
 More tools templates
In-Reply-To: <bug-19679-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-19679-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-19679-70-zc0AJXI0lK@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19679

Owen Leonard <oleonard at myacpl.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
            Summary|Move tools templates        |Move templates JavaScript
                   |JavaScript to the footer:   |to the footer: More tools
                   |More tools templates        |templates

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Nov 22 17:18:53 2017
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 22 Nov 2017 16:18:53 +0000
Subject: [Koha-bugs] [Bug 19679] Move tools templates JavaScript to the
 footer: More tools templates
In-Reply-To: <bug-19679-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-19679-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-19679-70-HRarBNMaUg@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19679

Owen Leonard <oleonard at myacpl.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
            Summary|Move tools templates        |Move tools templates
                   |JavaScript to the footer:   |JavaScript to the footer:
                   |More MARC tools             |More tools templates

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Nov 22 17:30:48 2017
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 22 Nov 2017 16:30:48 +0000
Subject: [Koha-bugs] [Bug 19679] Move templates JavaScript to the footer:
 More tools templates
In-Reply-To: <bug-19679-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-19679-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-19679-70-cUMzLrEhEV@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19679

Owen Leonard <oleonard at myacpl.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
   Patch complexity|---                         |Small patch
             Status|ASSIGNED                    |Needs Signoff

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Nov 22 17:30:51 2017
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 22 Nov 2017 16:30:51 +0000
Subject: [Koha-bugs] [Bug 19679] Move templates JavaScript to the footer:
 More tools templates
In-Reply-To: <bug-19679-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-19679-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-19679-70-5LbtghFaof@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19679

--- Comment #1 from Owen Leonard <oleonard at myacpl.org> ---
Created attachment 69288
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=69288&action=edit
Bug 19679: Move templates JavaScript to the footer: More tools templates

This patch modifies more staff client tools templates so that
JavaScript is included in the footer instead of the header.

To test, apply the patch and test the JavaScript-driven features of
each modified template: All button controls, DataTables functionality,
form validation, etc.

  Export data
  Inventory
  Notices & slips
  Upload local cover image

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Nov 22 18:12:40 2017
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 22 Nov 2017 17:12:40 +0000
Subject: [Koha-bugs] [Bug 19680] New: Move JS to the footer: Patron and
	circulation tools
Message-ID: <bug-19680-70@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19680

            Bug ID: 19680
           Summary: Move JS to the footer: Patron and circulation tools
 Change sponsored?: ---
           Product: Koha
           Version: master
          Hardware: All
                OS: All
            Status: ASSIGNED
          Severity: enhancement
          Priority: P5 - low
         Component: Templates
          Assignee: oleonard at myacpl.org
          Reporter: oleonard at myacpl.org
        QA Contact: testopia at bugs.koha-community.org
                CC: testopia at bugs.koha-community.org
        Depends on: 19647
            Blocks: 17858

In order to conform to best practices for performance, staff client template
JavaScript should be in the footer instead of the header.

This patch will do so for some patron and circulation-related tools.


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17858
[Bug 17858] Omnibus: Move staff client JavaScript to the footer
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19647
[Bug 19647] Move patron lists templates JS to the footer
-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Nov 22 18:12:40 2017
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 22 Nov 2017 17:12:40 +0000
Subject: [Koha-bugs] [Bug 17858] Omnibus: Move staff client JavaScript to
	the footer
In-Reply-To: <bug-17858-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-17858-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-17858-70-gTCTfRbDTH@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17858

Owen Leonard <oleonard at myacpl.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
         Depends on|                            |19680


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19680
[Bug 19680] Move JS to the footer: Patron and circulation tools
-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Nov 22 18:12:40 2017
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 22 Nov 2017 17:12:40 +0000
Subject: [Koha-bugs] [Bug 19647] Move patron lists templates JS to the footer
In-Reply-To: <bug-19647-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-19647-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-19647-70-mtBgS0V0R9@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19647

Owen Leonard <oleonard at myacpl.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Blocks|                            |19680


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19680
[Bug 19680] Move JS to the footer: Patron and circulation tools
-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Nov 22 19:55:34 2017
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 22 Nov 2017 18:55:34 +0000
Subject: [Koha-bugs] [Bug 19681] New: label-item-search.pl result count
 formatting error when there is only one page
Message-ID: <bug-19681-70@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19681

            Bug ID: 19681
           Summary: label-item-search.pl result count formatting error
                    when there is only one page
 Change sponsored?: ---
           Product: Koha
           Version: master
          Hardware: All
                OS: All
            Status: ASSIGNED
          Severity: trivial
          Priority: P5 - low
         Component: Label/patron card printing
          Assignee: david.bourgault at inlibro.com
          Reporter: david.bourgault at inlibro.com
        QA Contact: testopia at bugs.koha-community.org

When doing an item search through label-item-search.pl, if there is a only one
page of results the formatting of the result count is weird.

To reproduce:
0) Go to Tools > Label creator > New > Label batch
1) Add items
2) Do a search that will return few items
3) The result count will read "Results through of X" instead of "Results 1
through X of X"

The error is also present on 16.05.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Nov 22 19:55:53 2017
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 22 Nov 2017 18:55:53 +0000
Subject: [Koha-bugs] [Bug 19681] label-item-search.pl result count
 formatting error when there is only one page
In-Reply-To: <bug-19681-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-19681-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-19681-70-qp2thMkcO8@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19681

David Bourgault <david.bourgault at inlibro.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |philippe.blouin at inlibro.com

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Nov 22 19:59:13 2017
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 22 Nov 2017 18:59:13 +0000
Subject: [Koha-bugs] [Bug 19681] label-item-search.pl result count
 formatting error when there is only one page
In-Reply-To: <bug-19681-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-19681-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-19681-70-AU9rxfq3KI@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19681

--- Comment #1 from David Bourgault <david.bourgault at inlibro.com> ---
Created attachment 69289
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=69289&action=edit
Bug 19681 - Correct result count formatting

This simply passes the missing information to the template.

Test plan:
0) Apply patch
1) Go to Tools > Label creator > New > Label batch
2) Press 'Add items'
3) Do a search that will return few items
4) The result count will read "Results 1 through X of X"

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Nov 22 19:59:26 2017
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 22 Nov 2017 18:59:26 +0000
Subject: [Koha-bugs] [Bug 19681] label-item-search.pl result count
 formatting error when there is only one page
In-Reply-To: <bug-19681-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-19681-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-19681-70-XeKgZoRWt3@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19681

David Bourgault <david.bourgault at inlibro.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|ASSIGNED                    |Needs Signoff

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Nov 22 20:07:00 2017
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 22 Nov 2017 19:07:00 +0000
Subject: [Koha-bugs] [Bug 19680] Move JS to the footer: Patron and
	circulation tools
In-Reply-To: <bug-19680-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-19680-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-19680-70-rxeUE1QUEC@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19680

Owen Leonard <oleonard at myacpl.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
   Patch complexity|---                         |Small patch
             Status|ASSIGNED                    |Needs Signoff

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Nov 22 20:07:02 2017
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 22 Nov 2017 19:07:02 +0000
Subject: [Koha-bugs] [Bug 19680] Move JS to the footer: Patron and
	circulation tools
In-Reply-To: <bug-19680-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-19680-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-19680-70-rCleLnJjyS@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19680

--- Comment #1 from Owen Leonard <oleonard at myacpl.org> ---
Created attachment 69290
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=69290&action=edit
Bug 19680: Move JS to the footer: Patron and circulation tools

This patch modifies more staff client patrons and circulation tools
templates so that JavaScript is included in the footer instead of the
header.

To test, apply the patch and test the JavaScript-driven features of
each modified template: All button controls, DataTables functionality,
form validation, etc.

  - Batch patron deletion/anonymization
  - Overdue notice/status triggers
  - Batch patron modification

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Nov 22 20:32:53 2017
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 22 Nov 2017 19:32:53 +0000
Subject: [Koha-bugs] [Bug 19641] Move patron templates to the footer
In-Reply-To: <bug-19641-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-19641-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-19641-70-zoLZACvyPu@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19641

Owen Leonard <oleonard at myacpl.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Blocks|                            |19682


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19682
[Bug 19682] Move JS to the footer: Two patron-related tools
-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Nov 22 20:32:53 2017
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 22 Nov 2017 19:32:53 +0000
Subject: [Koha-bugs] [Bug 19647] Move patron lists templates JS to the footer
In-Reply-To: <bug-19647-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-19647-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-19647-70-CDVToAS4O9@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19647

Owen Leonard <oleonard at myacpl.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Blocks|                            |19682


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19682
[Bug 19682] Move JS to the footer: Two patron-related tools
-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Nov 22 20:32:53 2017
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 22 Nov 2017 19:32:53 +0000
Subject: [Koha-bugs] [Bug 17858] Omnibus: Move staff client JavaScript to
	the footer
In-Reply-To: <bug-17858-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-17858-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-17858-70-xPIJxUcnSC@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17858

Owen Leonard <oleonard at myacpl.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
         Depends on|                            |19682


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19682
[Bug 19682] Move JS to the footer: Two patron-related tools
-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Nov 22 20:32:53 2017
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 22 Nov 2017 19:32:53 +0000
Subject: [Koha-bugs] [Bug 19682] New: Move JS to the footer: Two
	patron-related tools
Message-ID: <bug-19682-70@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19682

            Bug ID: 19682
           Summary: Move JS to the footer: Two patron-related tools
 Change sponsored?: ---
           Product: Koha
           Version: master
          Hardware: All
                OS: All
            Status: ASSIGNED
          Severity: enhancement
          Priority: P5 - low
         Component: Templates
          Assignee: oleonard at myacpl.org
          Reporter: oleonard at myacpl.org
        QA Contact: testopia at bugs.koha-community.org
                CC: dominic.pichette at inlibro.com,
                    testopia at bugs.koha-community.org
        Depends on: 19641, 19647
            Blocks: 17858

In order to conform to best practices for performance, staff client template
JavaScript should be in the footer instead of the header.

This patch will do so for two patron-related tools which also incorporate
elements from the Patrons module, requiring a dependency on Bug 19641: Import
patrons and Upload patron images.


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17858
[Bug 17858] Omnibus: Move staff client JavaScript to the footer
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19641
[Bug 19641] Move patron templates to the footer
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19647
[Bug 19647] Move patron lists templates JS to the footer
-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Nov 22 20:33:44 2017
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 22 Nov 2017 19:33:44 +0000
Subject: [Koha-bugs] [Bug 19683] New: Export.pl does not populate the
 Authority Types dropdown correctly
Message-ID: <bug-19683-70@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19683

            Bug ID: 19683
           Summary: Export.pl does not populate the Authority Types
                    dropdown correctly
 Change sponsored?: ---
           Product: Koha
           Version: master
          Hardware: All
                OS: All
            Status: NEW
          Severity: minor
          Priority: P5 - low
         Component: Tools
          Assignee: david.bourgault at inlibro.com
          Reporter: david.bourgault at inlibro.com
        QA Contact: testopia at bugs.koha-community.org
                CC: philippe.blouin at inlibro.com

When exporting Authorities, the authority_type dropdown that enables filtering
displays a list of blank values.

To reproduce:
0) Tools > Export > Export authority records
1) Authority Types dropdown is empty (except for "-- All --")

I've experienced the bug on 16.05 and master

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Nov 22 20:36:17 2017
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 22 Nov 2017 19:36:17 +0000
Subject: [Koha-bugs] [Bug 19683] Export.pl does not populate the Authority
 Types dropdown correctly
In-Reply-To: <bug-19683-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-19683-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-19683-70-AnV8RGAufD@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19683

--- Comment #1 from David Bourgault <david.bourgault at inlibro.com> ---
Created attachment 69291
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=69291&action=edit
Bug 19683 - Unbless authority_types search results

Fixes the bug by unblessing the authority types search results, and correcting
the variable names in the template.

To test:
0) Tools > Export > Export authority records
1) Authority Types dropdown is not empty

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Nov 22 20:36:32 2017
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 22 Nov 2017 19:36:32 +0000
Subject: [Koha-bugs] [Bug 19683] Export.pl does not populate the Authority
 Types dropdown correctly
In-Reply-To: <bug-19683-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-19683-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-19683-70-Dl4vVcNSUl@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19683

David Bourgault <david.bourgault at inlibro.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|NEW                         |Needs Signoff

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Nov 22 20:37:21 2017
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 22 Nov 2017 19:37:21 +0000
Subject: [Koha-bugs] [Bug 19682] Move JS to the footer: Two patron-related
	tools
In-Reply-To: <bug-19682-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-19682-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-19682-70-oCzNQddy4G@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19682

Owen Leonard <oleonard at myacpl.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
   Patch complexity|---                         |Small patch
             Status|ASSIGNED                    |Needs Signoff

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Nov 22 20:37:23 2017
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 22 Nov 2017 19:37:23 +0000
Subject: [Koha-bugs] [Bug 19682] Move JS to the footer: Two patron-related
	tools
In-Reply-To: <bug-19682-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-19682-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-19682-70-YsasaU9hS0@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19682

--- Comment #1 from Owen Leonard <oleonard at myacpl.org> ---
Created attachment 69292
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=69292&action=edit
Bug 19682: Move JS to the footer: Two patron-related tools

This patch modifies two patron-related tools templates in the staff
client so that JavaScript is included in the footer instead of the
header.

To test, apply the patch and test the JavaScript-driven features of
each modified template: All button controls, DataTables functionality,
form validation, etc.

  - Import patrons
  - Upload patron images

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Nov 22 20:43:38 2017
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 22 Nov 2017 19:43:38 +0000
Subject: [Koha-bugs] [Bug 19681] label-item-search.pl result count
 formatting error when there is only one page
In-Reply-To: <bug-19681-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-19681-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-19681-70-LeSzsyleZi@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19681

Owen Leonard <oleonard at myacpl.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Needs Signoff               |Signed Off
   Patch complexity|---                         |Trivial patch

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Nov 22 20:43:40 2017
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 22 Nov 2017 19:43:40 +0000
Subject: [Koha-bugs] [Bug 19681] label-item-search.pl result count
 formatting error when there is only one page
In-Reply-To: <bug-19681-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-19681-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-19681-70-Wtr5nAX7td@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19681

Owen Leonard <oleonard at myacpl.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #69289|0                           |1
        is obsolete|                            |

--- Comment #2 from Owen Leonard <oleonard at myacpl.org> ---
Created attachment 69293
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=69293&action=edit
Bug 19681 - Correct result count formatting

This simply passes the missing information to the template.

Test plan:
0) Apply patch
1) Go to Tools > Label creator > New > Label batch
2) Press 'Add items'
3) Do a search that will return few items
4) The result count will read "Results 1 through X of X"

Signed-off-by: Owen Leonard <oleonard at myacpl.org>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Nov 22 20:58:50 2017
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 22 Nov 2017 19:58:50 +0000
Subject: [Koha-bugs] [Bug 19681] label-item-search.pl result count
 formatting error when there is only one page
In-Reply-To: <bug-19681-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-19681-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-19681-70-wFLeGbisiN@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19681

David Bourgault <david.bourgault at inlibro.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #69293|0                           |1
        is obsolete|                            |

--- Comment #3 from David Bourgault <david.bourgault at inlibro.com> ---
Created attachment 69294
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=69294&action=edit
Bug 19681 - Correct result count formatting

Small correction, previous patch accidentally changed the file mode to 644.

--

This simply passes the missing information to the template.

Test plan:
0) Apply patch
1) Go to Tools > Label creator > New > Label batch
2) Press 'Add items'
3) Do a search that will return few items
4) The result count will read "Results 1 through X of X"

Signed-off-by: Owen Leonard <oleonard at myacpl.org>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Nov 22 21:17:43 2017
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 22 Nov 2017 20:17:43 +0000
Subject: [Koha-bugs] [Bug 18927] koha-rebuild-zebra is failing with "error
 retrieving biblio"
In-Reply-To: <bug-18927-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-18927-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-18927-70-pkU90WrVCU@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18927

Ian Bays <ian.bays at ptfs-europe.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |ian.bays at ptfs-europe.com

--- Comment #15 from Ian Bays <ian.bays at ptfs-europe.com> ---
After recent upgrade to 17.05.04.000 bulkmarcimport started to fail on all
items attempted to be added.

ERROR: Adding items to bib 1 failed: Undefined subroutine
&C4::Items::TransformMarcToKoha called at /usr/share/koha/lib/C4/Items.pm line
382, <GEN46> line 1

So I manually added the prefix and the next error came up:

ERROR: Adding items to bib 74925 failed: Undefined subroutine
&C4::Items::GetMarcStructure called at /usr/share/koha/lib/C4/Items.pm line
2307, <GEN46> line 14.

Manually adding the prefix to that line seems to have worked, but it does not
feel like the right solution.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Nov 22 21:46:33 2017
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 22 Nov 2017 20:46:33 +0000
Subject: [Koha-bugs] [Bug 14784] Missing checkin message for debarred
 patrons when issuing rules ' fine days = 0'
In-Reply-To: <bug-14784-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-14784-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-14784-70-nl2713VE6o@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14784

David Bourgault <david.bourgault at inlibro.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #68132|0                           |1
        is obsolete|                            |

--- Comment #27 from David Bourgault <david.bourgault at inlibro.com> ---
Created attachment 69295
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=69295&action=edit
Bug 14784 - Fix checkin message for debarred patrons

Tested and bug still exists, however previous patch did not apply and relied on
obsolete code.

Test plan:

Before

1) Select a user with active restrictions
2) Make sure finesday=0 for the user category
3) Checkout and return an item (not overdue) : a previous restriction reminder
will appear
4) Checkout and return an overdue item : no previous restriction reminder will
appear

After applying patch:
Same steps, but a reminder should appear for step 4)

I've also tested with finesday=1 with "no overdue", "grace period overdue" and
"long overdue" test
cases. The appropriate nessage appeared for each test.

P.S.: The "finesday" setting is called "Suspension days" in the web interface,
if you're searching
for it like I did...

Signed-off-by: Katrin Fischer <katrin.fischer.83 at web.de>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Nov 22 22:11:27 2017
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 22 Nov 2017 21:11:27 +0000
Subject: [Koha-bugs] [Bug 14784] Missing checkin message for debarred
 patrons when issuing rules ' fine days = 0'
In-Reply-To: <bug-14784-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-14784-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-14784-70-hZYUooPznn@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14784

David Bourgault <david.bourgault at inlibro.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #69295|0                           |1
        is obsolete|                            |

--- Comment #28 from David Bourgault <david.bourgault at inlibro.com> ---
Created attachment 69296
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=69296&action=edit
Bug 14784 - Fix checkin message for debarred patrons

After thinking about it I changed the code's behavior to always display a
reminder if the patron was previously debarred.
This makes sense to me (it's only a reminder) and it correctly stacks with
other messages.

--

Test plan:
Before

1) Select a user with active restrictions
2) Make sure finesday=0 for the user category
3) Checkout and return an item (not overdue) : a previous restriction reminder
will appear
4) Checkout and return an overdue item : no previous restriction reminder will
appear

After applying patch:
Same steps, but a reminder should appear for step 4)

I've also tested with finesday=1 with "no overdue", "grace period overdue" and
"long overdue" test
cases. The appropriate nessage appeared for each test.

P.S.: The "finesday" setting is called "Suspension days" in the web interface,
if you're searching
for it like I did...

Signed-off-by: Katrin Fischer <katrin.fischer.83 at web.de>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Nov 22 22:13:13 2017
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 22 Nov 2017 21:13:13 +0000
Subject: [Koha-bugs] [Bug 14784] Missing checkin message for debarred
 patrons when issuing rules ' fine days = 0'
In-Reply-To: <bug-14784-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-14784-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-14784-70-fc3nx6z66b@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14784

David Bourgault <david.bourgault at inlibro.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Failed QA                   |Needs Signoff

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Nov 22 22:38:25 2017
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 22 Nov 2017 21:38:25 +0000
Subject: [Koha-bugs] [Bug 12747] Add extra column in Z3950 search result
In-Reply-To: <bug-12747-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-12747-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-12747-70-T2WoZq3hKQ@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12747

David Bourgault <david.bourgault at inlibro.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Failed QA                   |Signed Off

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Nov 22 22:38:29 2017
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 22 Nov 2017 21:38:29 +0000
Subject: [Koha-bugs] [Bug 12747] Add extra column in Z3950 search result
In-Reply-To: <bug-12747-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-12747-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-12747-70-5AG2ncAqZD@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12747

--- Comment #63 from David Bourgault <david.bourgault at inlibro.com> ---
Created attachment 69297
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=69297&action=edit
Bug 12747 - Switch date field on marc flavour

Amended _add_rowdata to check only for the marcflavour-appropriate date field.
This makes the test pass without noise.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Nov 22 23:00:04 2017
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 22 Nov 2017 22:00:04 +0000
Subject: [Koha-bugs] [Bug 19466] Cardnumber auto calc is broken because
	field is required
In-Reply-To: <bug-19466-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-19466-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-19466-70-cETOro1y1b@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19466

--- Comment #1 from David Bourgault <david.bourgault at inlibro.com> ---
Created attachment 69298
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=69298&action=edit
Bug 19466 - Check if cardnumber mandatory

Turns out this isn't a bug, since it is caused by 'cardnumber' being in the
'BorrowerMandatoryField' syspref.

It is however confusing for the user that it suggested to leave the field blank
when the field is required. To alleviate this I added a condition to the code;
it will not suggest leaving the field blank if 'BorrowerMandatoryField'
contains 'cardnumber'.

To test:

Before:
0) Enable autoMemberNum
1) Add 'cardnumber' to BorrowerMandatoryField
2) Go to create a user: a message will appear suggesting you leave the
cardnumber field blank for autocalc, but when submitting the form it will show
as required.
Apply patch
2) Go to create a user: if 'cardnumber' is in BorrowerMandatoryField, the
suggestion will not be shown.

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Nov 22 23:01:03 2017
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 22 Nov 2017 22:01:03 +0000
Subject: [Koha-bugs] [Bug 19466] Cardnumber auto calc is broken because
	field is required
In-Reply-To: <bug-19466-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-19466-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-19466-70-rtBhkOK7h0@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19466

David Bourgault <david.bourgault at inlibro.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|NEW                         |Needs Signoff

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.

From bugzilla-daemon at bugs.koha-community.org  Wed Nov 22 23:27:02 2017
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 22 Nov 2017 22:27:02 +0000
Subject: [Koha-bugs] [Bug 13881] Add desk management
In-Reply-To: <bug-13881-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-13881-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-13881-70-cuYmJ7xM0i@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13881

Mike <black23 at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |black23 at gmail.com

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Nov 22 23:30:29 2017
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 22 Nov 2017 22:30:29 +0000
Subject: [Koha-bugs] [Bug 15516] Allow to reserve first available item from
 a group of titles
In-Reply-To: <bug-15516-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-15516-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-15516-70-vcKU2AKcvI@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15516

Radek ?iman (R-Bit Technology, s.r.o.) <rbit at rbit.cz> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |rbit at rbit.cz

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Nov 22 23:31:13 2017
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 22 Nov 2017 22:31:13 +0000
Subject: [Koha-bugs] [Bug 15516] Allow to reserve first available item from
 a group of titles
In-Reply-To: <bug-15516-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-15516-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-15516-70-oiwEXYLsMa@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15516

--- Comment #57 from Mike <black23 at gmail.com> ---
Can anobody move this bug ... its on very good way....


Thanks


Mike

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Nov 23 00:18:54 2017
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 22 Nov 2017 23:18:54 +0000
Subject: [Koha-bugs] [Bug 19466] Cardnumber auto calc is broken because
	field is required
In-Reply-To: <bug-19466-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-19466-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-19466-70-WJTm6lSylL@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19466

Dilan Johnpull? <dilan at calyx.net.au> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Needs Signoff               |Signed Off

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Nov 23 00:19:00 2017
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 22 Nov 2017 23:19:00 +0000
Subject: [Koha-bugs] [Bug 19466] Cardnumber auto calc is broken because
	field is required
In-Reply-To: <bug-19466-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-19466-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-19466-70-OXOOGbcbtW@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19466

Dilan Johnpull? <dilan at calyx.net.au> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #69298|0                           |1
        is obsolete|                            |

--- Comment #2 from Dilan Johnpull? <dilan at calyx.net.au> ---
Created attachment 69299
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=69299&action=edit
Bug 19466 - Check if cardnumber mandatory

Followed test plan and patch applies and functions as expected.
Signed-off-by: Dilan Johnpull? <dilan at calyx.net.au>

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Nov 23 11:00:47 2017
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 23 Nov 2017 10:00:47 +0000
Subject: [Koha-bugs] [Bug 19683] Export.pl does not populate the Authority
 Types dropdown correctly
In-Reply-To: <bug-19683-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-19683-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-19683-70-THch6W7JMo@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19683

Claire Gravely <claire_gravely at hotmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Needs Signoff               |Signed Off

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Nov 23 11:00:50 2017
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 23 Nov 2017 10:00:50 +0000
Subject: [Koha-bugs] [Bug 19683] Export.pl does not populate the Authority
 Types dropdown correctly
In-Reply-To: <bug-19683-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-19683-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-19683-70-aXuK9PrCu6@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19683

Claire Gravely <claire_gravely at hotmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #69291|0                           |1
        is obsolete|                            |

--- Comment #2 from Claire Gravely <claire_gravely at hotmail.com> ---
Created attachment 69300
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=69300&action=edit
Bug 19683 - Unbless authority_types search results

Fixes the bug by unblessing the authority types search results, and correcting
the variable names in the template.

To test:
0) Tools > Export > Export authority records
1) Authority Types dropdown is not empty

Signed-off-by: Claire Gravely <claire.gravely at bsz-bw.de>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Nov 23 11:24:25 2017
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 23 Nov 2017 10:24:25 +0000
Subject: [Koha-bugs] [Bug 19684] New: Colon char in MARC data breaks facets
Message-ID: <bug-19684-70@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19684

            Bug ID: 19684
           Summary: Colon char in MARC data breaks facets
 Change sponsored?: ---
           Product: Koha
           Version: master
          Hardware: All
                OS: All
            Status: NEW
          Severity: minor
          Priority: P5 - low
         Component: Searching
          Assignee: koha-bugs at lists.koha-community.org
          Reporter: fridolin.somers at biblibre.com
        QA Contact: testopia at bugs.koha-community.org

When a MARC data used in some facet contains colon char ":", this facet is
broken it leads to no result.
This is because all colon are replaced by = which is a CCL syntax char

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.

From bugzilla-daemon at bugs.koha-community.org  Thu Nov 23 11:25:29 2017
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 23 Nov 2017 10:25:29 +0000
Subject: [Koha-bugs] [Bug 19684] Colon char in MARC data breaks facets
In-Reply-To: <bug-19684-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-19684-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-19684-70-l67bVYii5T@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19684

Fridolin SOMERS <fridolin.somers at biblibre.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
           Assignee|koha-bugs at lists.koha-commun |fridolin.somers at biblibre.co
                   |ity.org                     |m

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.

From bugzilla-daemon at bugs.koha-community.org  Thu Nov 23 11:36:59 2017
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 23 Nov 2017 10:36:59 +0000
Subject: [Koha-bugs] [Bug 19684] Colon char in MARC data breaks facets
In-Reply-To: <bug-19684-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-19684-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-19684-70-tuA3bdRGdC@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19684

Fridolin SOMERS <fridolin.somers at biblibre.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
   Patch complexity|---                         |Trivial patch
             Status|NEW                         |Needs Signoff

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Nov 23 11:37:02 2017
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 23 Nov 2017 10:37:02 +0000
Subject: [Koha-bugs] [Bug 19684] Colon char in MARC data breaks facets
In-Reply-To: <bug-19684-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-19684-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-19684-70-kM18ETWDxR@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19684

--- Comment #1 from Fridolin SOMERS <fridolin.somers at biblibre.com> ---
Created attachment 69301
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=69301&action=edit
Bug 19684: Only replace first colon char in facets link

When a MARC data used in some facet contains colon char ":", this facet is
broken it leads to no result.
This is because all colon are replaced by = which is a CCL syntax char.

This patch corrects by replacing only first occurence of colon char, that is
the index not the data.

Test plan :
1) Create a record with subject "Ainur: Yavanna" (650$a for MARC21 or 600$a for
UNIMARC)
2) Index this record in Zebra
3) Perform a search that shows this subject in facets
4) Click on this facet link
5) You get the record as result

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Nov 23 13:10:48 2017
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 23 Nov 2017 12:10:48 +0000
Subject: [Koha-bugs] [Bug 19651] SIP/ILS/Item missing title
In-Reply-To: <bug-19651-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-19651-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-19651-70-sLQaseeF2x@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19651

--- Comment #1 from Stefan Berndtsson <stefan.berndtsson at ub.gu.se> ---
Created attachment 69302
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=69302&action=edit
Add title and author from biblio to SIP/ILS/Item.pm

Adding title and author manually lite this is a simple fix that solves the
problem.

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.

From bugzilla-daemon at bugs.koha-community.org  Thu Nov 23 14:05:21 2017
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 23 Nov 2017 13:05:21 +0000
Subject: [Koha-bugs] [Bug 19651] SIP/ILS/Item missing title
In-Reply-To: <bug-19651-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-19651-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-19651-70-K2E5wxrDmU@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19651

Benjamin Rokseth <benjamin.rokseth at kul.oslo.kommune.no> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |benjamin.rokseth at kul.oslo.k
                   |                            |ommune.no

--- Comment #2 from Benjamin Rokseth <benjamin.rokseth at kul.oslo.kommune.no> ---
We Oslo Public Library can confirm this is an issue. 
Problem is that $item->unblessed overloads $self, and thus no $self->{author}
or $self->{title} as was in GetBiblioFromItemnumber.

This solution is a workaround, probably needs rework, and tests, later. But
since release 17.11 is so close, and it will break any Item information
response and probably any self checkout device, I propose this be added as is.

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Nov 23 14:49:21 2017
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 23 Nov 2017 13:49:21 +0000
Subject: [Koha-bugs] [Bug 19651] SIP/ILS/Item missing title
In-Reply-To: <bug-19651-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-19651-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-19651-70-mIlX5jAEU9@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19651

Benjamin Rokseth <benjamin.rokseth at kul.oslo.kommune.no> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #69302|0                           |1
        is obsolete|                            |

--- Comment #3 from Benjamin Rokseth <benjamin.rokseth at kul.oslo.kommune.no> ---
Created attachment 69303
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=69303&action=edit
>From 3dab1160c4b71bc6f6e9893427f59acb50f3500b Mon Sep 17 00:00:00 2001 From:
Stefan Berndtsson <stefan.berndtsson at ub.gu.se> Date: Thu,23 Nov 2017 12:10:00
UTC Subject: [PATCH] Bug 19651 - SIP/ILS/Item missing title

Signed-off-by: Benjamin Rokseth <bensinober at gmail.com>

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Nov 23 14:50:25 2017
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 23 Nov 2017 13:50:25 +0000
Subject: [Koha-bugs] [Bug 19651] SIP/ILS/Item missing title
In-Reply-To: <bug-19651-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-19651-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-19651-70-848KD4sSzO@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19651

Benjamin Rokseth <benjamin.rokseth at kul.oslo.kommune.no> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #69303|From                        |[PATCH] Bug 19651 -
        description|3dab1160c4b71bc6f6e9893427f |SIP/ILS/Item missing title
                   |59acb50f3500b Mon Sep 17    |
                   |00:00:00 2001 From: Stefan  |
                   |Berndtsson                  |
                   |<stefan.berndtsson at ub.gu.se |
                   |> Date: Thu,23 Nov 2017     |
                   |12:10:00 UTC Subject:       |
                   |[PATCH] Bug 19651 -         |
                   |SIP/ILS/Item missing title  |

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Nov 23 14:55:08 2017
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 23 Nov 2017 13:55:08 +0000
Subject: [Koha-bugs] [Bug 19370] Add a helper function for translating
 order_by params into SQL ::Abstract
In-Reply-To: <bug-19370-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-19370-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-19370-70-8EXgKAugyq@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19370

--- Comment #12 from Tom?s Cohen Arazi <tomascohen at gmail.com> ---
Created attachment 69304
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=69304&action=edit
Bug 19370: (QA followup) Use OpenAPI's handling of pipe separated values

This patch changes the _order_by definition so it's values are handled
correctly by the Mojolicious::Plugin::OpenAPI plugin.

Code is adjusted to expect a list instead of a (to-be-splitted) string.

Tests are adjusted too.

Note: In the process I noticed + on the URL represents a space, so the
helper function is updated to handle both + and %2B as ascending.

To test:
- Run:
  $ kshell
 k$ prove t/Koha/REST/Plugin/Query.t
=> SUCCESS: Tests pass!
- Sign off :-D

Signed-off-by: Tomas Cohen Arazi <tomascohen at theke.io>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Nov 23 14:55:45 2017
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 23 Nov 2017 13:55:45 +0000
Subject: [Koha-bugs] [Bug 19651] SIP/ILS/Item missing title
In-Reply-To: <bug-19651-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-19651-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-19651-70-qO11PhJnSZ@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19651

Benjamin Rokseth <benjamin.rokseth at kul.oslo.kommune.no> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|NEW                         |Needs Signoff

--- Comment #4 from Benjamin Rokseth <benjamin.rokseth at kul.oslo.kommune.no> ---
Took the liberty of adding git bz required info to your patch. It is needed for
using git bz (https://wiki.koha-community.org/wiki/Git_bz_configuration) which
Koha community uses for bugtracking.

Basically it is email version of git issues, very old and tedioius, but this is
what is used.

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Nov 23 14:56:33 2017
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 23 Nov 2017 13:56:33 +0000
Subject: [Koha-bugs] [Bug 19651] SIP/ILS/Item missing title
In-Reply-To: <bug-19651-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-19651-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-19651-70-cBbP1YU3NX@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19651

Benjamin Rokseth <benjamin.rokseth at kul.oslo.kommune.no> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Needs Signoff               |Signed Off

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.

From bugzilla-daemon at bugs.koha-community.org  Thu Nov 23 15:03:14 2017
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 23 Nov 2017 14:03:14 +0000
Subject: [Koha-bugs] [Bug 19370] Add a helper function for translating
 order_by params into SQL ::Abstract
In-Reply-To: <bug-19370-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-19370-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-19370-70-iP2m2Tr3Hz@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19370

Tom?s Cohen Arazi <tomascohen at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #69304|0                           |1
        is obsolete|                            |

--- Comment #13 from Tom?s Cohen Arazi <tomascohen at gmail.com> ---
Created attachment 69305
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=69305&action=edit
Bug 19370: (QA followup) Use OpenAPI's handling of pipe separated values

This patch makes the helper handling _order_by params expect a list of
values instead of a (to-be-splitted) string.

The idea is that the OpenAPI plugin will take care of splitting
pipe-delimited values if the spec is correctly defined.

Note: In the process I noticed + on the URL represents a space, so the
helper function is updated to handle both + and %2B as ascending.

To test:
- Run:
  $ kshell
 k$ prove t/Koha/REST/Plugin/Query.t
=> SUCCESS: Tests pass!
- Sign off :-D

Signed-off-by: Tomas Cohen Arazi <tomascohen at theke.io>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Nov 23 15:04:19 2017
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 23 Nov 2017 14:04:19 +0000
Subject: [Koha-bugs] [Bug 19575] Use canonical field names and resolve
	aliased fields
In-Reply-To: <bug-19575-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-19575-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-19575-70-F07yuj9zDs@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19575

David Gustafsson <glasklas at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #69153|0                           |1
        is obsolete|                            |

--- Comment #9 from David Gustafsson <glasklas at gmail.com> ---
Created attachment 69306
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=69306&action=edit
Bug 19575: Use canonical field names and resolve aliased fields

Adjust elastic search mappings to more closely match Zebra equivalents
resolving serveral issues with coded Zebra searches in templates, and
sorting of search results in UI.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Nov 23 15:06:18 2017
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 23 Nov 2017 14:06:18 +0000
Subject: [Koha-bugs] [Bug 19370] Add a helper function for translating
 order_by params into SQL ::Abstract
In-Reply-To: <bug-19370-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-19370-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-19370-70-UORKJgqGd6@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19370

Tom?s Cohen Arazi <tomascohen at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #69305|0                           |1
        is obsolete|                            |

--- Comment #14 from Tom?s Cohen Arazi <tomascohen at gmail.com> ---
Created attachment 69307
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=69307&action=edit
Bug 19370: (QA followup) Use OpenAPI's handling of pipe separated values

This patch makes the helper handling _order_by params expect a list of
values instead of a (to-be-splitted) string.

The idea is that the OpenAPI plugin will take care of splitting
pipe-delimited values if the spec is correctly defined.

Note: In the process I noticed + on the URL represents a space, so the
helper function is updated to handle both + and %2B as ascending.

To test:
- Run:
  $ kshell
 k$ prove t/Koha/REST/Plugin/Query.t
=> SUCCESS: Tests pass!
- Sign off :-D

Signed-off-by: Tomas Cohen Arazi <tomascohen at theke.io>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Nov 23 15:08:17 2017
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 23 Nov 2017 14:08:17 +0000
Subject: [Koha-bugs] [Bug 19575] Use canonical field names and resolve
	aliased fields
In-Reply-To: <bug-19575-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-19575-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-19575-70-v4HiZXbxA5@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19575

--- Comment #10 from David Gustafsson <glasklas at gmail.com> ---
Wrote a script to extract mappings from biblio-koha-indexdefs.xml and convert
to mappings.yaml, left the fields with existing mapping-targets as they are
(even though discovered several discrepancies with the Zebra mappings) and
mostly just added the missing fields. Will now do more thorough local testing
so will probably adjust this patch some more before ready to be reviewed.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Nov 23 15:10:40 2017
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 23 Nov 2017 14:10:40 +0000
Subject: [Koha-bugs] [Bug 19608] Move admin templates JavaScript to the
	footer: The rest
In-Reply-To: <bug-19608-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-19608-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-19608-70-fEzUNFHjor@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19608

Claire Gravely <claire_gravely at hotmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Needs Signoff               |Signed Off

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Nov 23 15:10:43 2017
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 23 Nov 2017 14:10:43 +0000
Subject: [Koha-bugs] [Bug 19608] Move admin templates JavaScript to the
	footer: The rest
In-Reply-To: <bug-19608-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-19608-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-19608-70-5ZaBCkGumd@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19608

Claire Gravely <claire_gravely at hotmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #69144|0                           |1
        is obsolete|                            |

--- Comment #2 from Claire Gravely <claire_gravely at hotmail.com> ---
Created attachment 69308
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=69308&action=edit
Bug 19608 - Move admin templates JavaScript to the footer: The rest

This patch modifies the staff client administration templates so that
JavaScript is included in the footer instead of the header.

To test, apply the patch and test the JavaScript-driven features of the
modified templates: All button controls, DataTables functionality, tabs,
etc.

To test the changes to localization.tt you must have more than one
translation installed. Go to admin/itemtypes.pl, edit an itemtype, and
click the 'Translate into other languages' link.

To test the changes to sur_modmapping.tt, go to admin/z3950servers.pl
and create a new SRU server. Click the 'Modify' button next to 'SRU
Search fields mapping'

Signed-off-by: Claire Gravely <claire.gravely at bsz-bw.de>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Nov 23 15:18:35 2017
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 23 Nov 2017 14:18:35 +0000
Subject: [Koha-bugs] [Bug 18731] CRUD for acquisition orders
In-Reply-To: <bug-18731-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-18731-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-18731-70-plqQHus0px@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18731

Tom?s Cohen Arazi <tomascohen at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #69184|0                           |1
        is obsolete|                            |

--- Comment #4 from Tom?s Cohen Arazi <tomascohen at gmail.com> ---
Created attachment 69309
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=69309&action=edit
Bug 18731: /acquisitions/orders endpoint

This patches implement the /acquisitions/orders endpoint.
It uses the new pagination, query parsing and object searching plugins.

Sponsored-by: Camden County

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Nov 23 15:18:42 2017
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 23 Nov 2017 14:18:42 +0000
Subject: [Koha-bugs] [Bug 18731] CRUD for acquisition orders
In-Reply-To: <bug-18731-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-18731-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-18731-70-iuRIZ8rrxc@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18731

Tom?s Cohen Arazi <tomascohen at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #69185|0                           |1
        is obsolete|                            |

--- Comment #5 from Tom?s Cohen Arazi <tomascohen at gmail.com> ---
Created attachment 69310
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=69310&action=edit
Bug 18731: OpenAPI definitions

This patch introduces the OpenAPI definitions required for the orders
endpoint. It adds query parameters definitions for the reserved params:

- _match
- _order_by
- _page
- _per_page

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Nov 23 15:19:04 2017
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 23 Nov 2017 14:19:04 +0000
Subject: [Koha-bugs] [Bug 17614] Introduce multiple fine charging intervals
In-Reply-To: <bug-17614-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-17614-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-17614-70-u7qhcPRlMf@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17614

Fiona Borthwick <fiona.borthwick at ptfs-europe.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |fiona.borthwick at ptfs-europe
                   |                            |.com

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Nov 23 15:20:17 2017
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 23 Nov 2017 14:20:17 +0000
Subject: [Koha-bugs] [Bug 17614] Introduce multiple fine charging intervals
In-Reply-To: <bug-17614-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-17614-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-17614-70-pCzPD4zedJ@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17614

--- Comment #2 from Fiona Borthwick <fiona.borthwick at ptfs-europe.com> ---
We have a number of customers who would want to have a graduated fining
structure.  For example, charge ?0.25 as soon as item overdue and then
increment this on a weekly basis. Neither a 1 or 7 day interval achieves this.

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.

From bugzilla-daemon at bugs.koha-community.org  Thu Nov 23 15:29:14 2017
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 23 Nov 2017 14:29:14 +0000
Subject: [Koha-bugs] [Bug 17614] Introduce multiple fine charging intervals
In-Reply-To: <bug-17614-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-17614-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-17614-70-XcOC1yyXoG@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17614

--- Comment #3 from Katrin Fischer <katrin.fischer at bsz-bw.de> ---
Do they add 0.25 each time or does the amount vary?

We do a lot of weekly interval fines as it's very common in Germany. We are
using OverdueNoticeCalendar and finesCalendar set to calculate in days the
library is open. Then for a weekly interval use 5 if the library is closed on
weekends. This way if there are no additional holidays, the fines are always
incremented on the same day of the week and the notices can be timed to be sent
out on that day too.
Also set grace period to 0 and start at the begin of the interval!

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.

From bugzilla-daemon at bugs.koha-community.org  Thu Nov 23 15:31:21 2017
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 23 Nov 2017 14:31:21 +0000
Subject: [Koha-bugs] [Bug 18799] XSLTresultsdisplay hides the icons
In-Reply-To: <bug-18799-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-18799-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-18799-70-ZnxhQO3e0e@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18799

Victor Grousset/tuxayo <victor.grousset at biblibre.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |victor.grousset at biblibre.co
                   |                            |m
           Assignee|fridolin.somers at biblibre.co |victor.grousset at biblibre.co
                   |m                           |m

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Nov 23 15:31:57 2017
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 23 Nov 2017 14:31:57 +0000
Subject: [Koha-bugs] [Bug 19603] Move admin templates JavaScript to the
 footer: Patrons and circulation
In-Reply-To: <bug-19603-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-19603-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-19603-70-FeYyIAzHbl@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19603

Claire Gravely <claire_gravely at hotmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Needs Signoff               |Signed Off

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Nov 23 15:32:00 2017
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 23 Nov 2017 14:32:00 +0000
Subject: [Koha-bugs] [Bug 19603] Move admin templates JavaScript to the
 footer: Patrons and circulation
In-Reply-To: <bug-19603-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-19603-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-19603-70-olrEF4yTEq@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19603

Claire Gravely <claire_gravely at hotmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #69201|0                           |1
        is obsolete|                            |

--- Comment #7 from Claire Gravely <claire_gravely at hotmail.com> ---
Created attachment 69311
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=69311&action=edit
Bug 19603: Move admin templates JavaScript to the footer: Patrons and
circulation

This patch modifies the staff client patrons and circulation-related
administration templates so that JavaScript is included in the footer
instead of the header.

To test, apply the patch and test the JavaScript-driven features of
each modified template: All button controls, DataTables functionality,
tabs, etc.

Signed-off-by: Claire Gravely <claire.gravely at bsz-bw.de>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Nov 23 15:51:17 2017
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 23 Nov 2017 14:51:17 +0000
Subject: [Koha-bugs] [Bug 19685] New: Canceling a hold from the Hold Found
 popup does not alert librarian about next hold
Message-ID: <bug-19685-70@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19685

            Bug ID: 19685
           Summary: Canceling a hold from the Hold Found popup does not
                    alert librarian about next hold
 Change sponsored?: ---
           Product: Koha
           Version: 17.05
          Hardware: All
                OS: All
            Status: NEW
          Severity: enhancement
          Priority: P5 - low
         Component: Hold requests
          Assignee: koha-bugs at lists.koha-community.org
          Reporter: r.delahunty at arts.ac.uk
        QA Contact: testopia at bugs.koha-community.org
                CC: gmcharlt at gmail.com

While the problem where canceling a hold from the ?Holds awaiting pick-up?
report did not alert the librarian to additional users in the hold queue has
been resolved
(https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17010), there
remains a similar problem where the hold is cancelled from the Hold Found
pop-up. 

The local workflow is that the user decides s/he does not want the item after
all, takes it to the issue desk, and the item is scanned in. The item is found
as Awaiting Collection. A simple click on Cancel Hold results in the librarian
seeing a simple ?item returned? dialogue box. 

The subsequent hold is not fulfilled, and the item is re-shelved or sent back
to its home library for shelving there. We have advised staff to cancel holds
from the ?Holds awaiting pick-up? report until a resolution is found. 

Ray Delahunty
University of the Arts London

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Nov 23 15:51:52 2017
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 23 Nov 2017 14:51:52 +0000
Subject: [Koha-bugs] [Bug 19685] Canceling a hold from the Hold Found popup
 does not alert librarian about next hold
In-Reply-To: <bug-19685-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-19685-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-19685-70-qo5KnV8g8i@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19685

Ray Delahunty <r.delahunty at arts.ac.uk> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
           See Also|                            |https://bugs.koha-community
                   |                            |.org/bugzilla3/show_bug.cgi
                   |                            |?id=17010

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Nov 23 15:51:52 2017
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 23 Nov 2017 14:51:52 +0000
Subject: [Koha-bugs] [Bug 17010] Canceling a hold awaiting pickup no longer
 alerts librarian about next hold
In-Reply-To: <bug-17010-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-17010-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-17010-70-G6w8r5C1KR@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17010

Ray Delahunty <r.delahunty at arts.ac.uk> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
           See Also|                            |https://bugs.koha-community
                   |                            |.org/bugzilla3/show_bug.cgi
                   |                            |?id=19685

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Nov 23 16:23:45 2017
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 23 Nov 2017 15:23:45 +0000
Subject: [Koha-bugs] [Bug 19679] Move templates JavaScript to the footer:
 More tools templates
In-Reply-To: <bug-19679-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-19679-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-19679-70-uQp3gGk4if@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19679

Claire Gravely <claire_gravely at hotmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #69288|0                           |1
        is obsolete|                            |

--- Comment #2 from Claire Gravely <claire_gravely at hotmail.com> ---
Created attachment 69312
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=69312&action=edit
Bug 19679: Move templates JavaScript to the footer: More tools templates

This patch modifies more staff client tools templates so that
JavaScript is included in the footer instead of the header.

To test, apply the patch and test the JavaScript-driven features of
each modified template: All button controls, DataTables functionality,
form validation, etc.

  Export data
  Inventory
  Notices & slips
  Upload local cover image

Signed-off-by: Claire Gravely <claire.gravely at bsz-bw.de>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Nov 23 16:23:43 2017
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 23 Nov 2017 15:23:43 +0000
Subject: [Koha-bugs] [Bug 19679] Move templates JavaScript to the footer:
 More tools templates
In-Reply-To: <bug-19679-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-19679-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-19679-70-uOoRp0Rju3@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19679

Claire Gravely <claire_gravely at hotmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Needs Signoff               |Signed Off

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Nov 23 16:41:32 2017
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 23 Nov 2017 15:41:32 +0000
Subject: [Koha-bugs] [Bug 12497] Make OPAC search history feature accessible
 when it should
In-Reply-To: <bug-12497-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-12497-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-12497-70-OvsT99Tqax@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12497

--- Comment #4 from Victor Grousset/tuxayo <victor.grousset at biblibre.com> ---
Created attachment 69313
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=69313&action=edit
Bug 12497: Fix search history non-accessible when OPAC was private

(when the user didn't have the "borrowers" permission)

Test plan:
1. Set syspref "OpacPublic" to false (Disable)
2. Log in as a user without any permission
3. Try to access the search history. The link is next to "Log out"
4. Then you should see "Access denied"
5. Apply this patch
6. Refresh the page
7. Then you should see the search history

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Nov 23 16:44:38 2017
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 23 Nov 2017 15:44:38 +0000
Subject: [Koha-bugs] [Bug 12497] Make OPAC search history feature accessible
 when it should
In-Reply-To: <bug-12497-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-12497-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-12497-70-ubOiZ4fy2x@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12497

--- Comment #5 from Victor Grousset/tuxayo <victor.grousset at biblibre.com> ---
Origin of the permission issue on a private OPAC ("borrowers" permission
required):
http://git.koha-community.org/gitweb/?p=koha.git;a=blob;f=opac/opac-search-history.pl;h=fdf0701be32e7ebc4e6ef8198d460c820e228b0a;hb=feeafa8168965183ba8651cf3113c3c32af863ec#l42
http://git.koha-community.org/gitweb/?p=koha.git;a=commit;h=feeafa8168965183ba8651cf3113c3c32af863ec

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Nov 23 17:23:18 2017
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 23 Nov 2017 16:23:18 +0000
Subject: [Koha-bugs] [Bug 19575] Use canonical field names and resolve
	aliased fields
In-Reply-To: <bug-19575-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-19575-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-19575-70-kCxrpwuwfg@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19575

David Gustafsson <glasklas at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #69306|0                           |1
        is obsolete|                            |

--- Comment #11 from David Gustafsson <glasklas at gmail.com> ---
Created attachment 69314
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=69314&action=edit
Bug 19575: Use canonical field names and resolve aliased fields

Adjust elastic search mappings to more closely match Zebra equivalents
resolving serveral issues with coded Zebra searches in templates, and
sorting of search results in UI.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Nov 23 18:54:37 2017
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 23 Nov 2017 17:54:37 +0000
Subject: [Koha-bugs] [Bug 18731] CRUD for acquisition orders
In-Reply-To: <bug-18731-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-18731-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-18731-70-QBLjdWokkI@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18731

Tom?s Cohen Arazi <tomascohen at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|ASSIGNED                    |Needs Signoff

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Nov 23 18:55:02 2017
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 23 Nov 2017 17:55:02 +0000
Subject: [Koha-bugs] [Bug 19250] Add pagination to /acquisitions/vendors
In-Reply-To: <bug-19250-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-19250-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-19250-70-46HWjDnkSg@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19250

Tom?s Cohen Arazi <tomascohen at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
         Depends on|                            |18731


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18731
[Bug 18731] CRUD for acquisition orders
-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Nov 23 18:55:02 2017
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 23 Nov 2017 17:55:02 +0000
Subject: [Koha-bugs] [Bug 18731] CRUD for acquisition orders
In-Reply-To: <bug-18731-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-18731-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-18731-70-YMFUaygkAK@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18731

Tom?s Cohen Arazi <tomascohen at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Blocks|                            |19250


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19250
[Bug 19250] Add pagination to /acquisitions/vendors
-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Nov 23 20:58:14 2017
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 23 Nov 2017 19:58:14 +0000
Subject: [Koha-bugs] [Bug 19686] objects.search helper needs a to_model param
In-Reply-To: <bug-19686-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-19686-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-19686-70-0H4hCpK3Vj@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19686

Tom?s Cohen Arazi <tomascohen at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
         Depends on|                            |19410
           Assignee|koha-bugs at lists.koha-commun |tomascohen at gmail.com
                   |ity.org                     |


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19410
[Bug 19410] Add a helper function for generating object searches for the API
-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Nov 23 20:58:14 2017
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 23 Nov 2017 19:58:14 +0000
Subject: [Koha-bugs] [Bug 19410] Add a helper function for generating object
 searches for the API
In-Reply-To: <bug-19410-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-19410-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-19410-70-bDI9GOerga@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19410

Tom?s Cohen Arazi <tomascohen at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Blocks|                            |19686


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19686
[Bug 19686] objects.search helper needs a to_model param
-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Nov 23 20:58:00 2017
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 23 Nov 2017 19:58:00 +0000
Subject: [Koha-bugs] [Bug 19686] New: objects.search helper needs a to_model
	param
Message-ID: <bug-19686-70@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19686

            Bug ID: 19686
           Summary: objects.search helper needs a to_model param
 Change sponsored?: ---
           Product: Koha
           Version: master
          Hardware: All
                OS: All
            Status: NEW
          Severity: enhancement
          Priority: P5 - low
         Component: REST api
          Assignee: koha-bugs at lists.koha-community.org
          Reporter: tomascohen at gmail.com

Bug 19410 introduces a handy helper function to perform searches on
Koha::Objects-based clases, plus several add-ons making use of other helpers.

But it is still missing the ability to solve field mappings between the exposed
API and the DB structure.

We should add such a parameter.

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.

From bugzilla-daemon at bugs.koha-community.org  Thu Nov 23 21:18:33 2017
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 23 Nov 2017 20:18:33 +0000
Subject: [Koha-bugs] [Bug 19686] objects.search helper needs a to_model param
In-Reply-To: <bug-19686-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-19686-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-19686-70-JvVNZiYfNy@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19686

Tom?s Cohen Arazi <tomascohen at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |julian.maurice at biblibre.com
                   |                            |, lari.taskula at jns.fi,
                   |                            |matthias.meusburger at biblibr
                   |                            |e.com

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Nov 23 21:19:26 2017
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 23 Nov 2017 20:19:26 +0000
Subject: [Koha-bugs] [Bug 19686] objects.search helper needs a to_model param
In-Reply-To: <bug-19686-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-19686-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-19686-70-PW04i1rWpj@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19686

--- Comment #1 from Tom?s Cohen Arazi <tomascohen at gmail.com> ---
Created attachment 69315
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=69315&action=edit
Bug 19686: Unit tests

Signed-off-by: Tomas Cohen Arazi <tomascohen at theke.io>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Nov 23 21:19:33 2017
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 23 Nov 2017 20:19:33 +0000
Subject: [Koha-bugs] [Bug 19686] objects.search helper needs a to_model param
In-Reply-To: <bug-19686-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-19686-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-19686-70-cIaVtYz83G@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19686

--- Comment #2 from Tom?s Cohen Arazi <tomascohen at gmail.com> ---
Created attachment 69316
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=69316&action=edit
Bug 19686: Add objects.search a 'to_model' param

This patch introduces a new parameter to the objects.search Mojo helper.
The idea behind this, is that if there's any attribute name mapping
between the DB objects and the API exposed ones, we should be able to
pass it to objects.search so the filtering query params are mapped
correctly for building the DBIC query, like this example:

  my $patrons_set = Koha::Patrons->new;
  my @patrons = $c->objects->search( $patrons_set,
                                     \&to_model
                                    )->as_list;
  # and probably
  @patrons = map {to_api($_)} @patrons;

The to_model function needs to avoid autovivification, to prevent
messing with the query parameters (undef params).

To test:
- Apply this patches
- Run:
  $ kshell
 k$ prove t/db_dependent/Koha/REST/Plugin/Objects.t
=> SUCCESS: Tests pass! Params get mapped!
- Sign off :-D

Signed-off-by: Tomas Cohen Arazi <tomascohen at theke.io>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Nov 23 21:19:53 2017
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 23 Nov 2017 20:19:53 +0000
Subject: [Koha-bugs] [Bug 19686] objects.search helper needs a to_model param
In-Reply-To: <bug-19686-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-19686-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-19686-70-6iKUz6t3CW@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19686

Tom?s Cohen Arazi <tomascohen at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |tomascohen at gmail.com
             Status|NEW                         |Needs Signoff

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Nov 23 21:26:58 2017
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 23 Nov 2017 20:26:58 +0000
Subject: [Koha-bugs] [Bug 19250] Add pagination to /acquisitions/vendors
In-Reply-To: <bug-19250-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-19250-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-19250-70-JHF4BC6gfZ@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19250

Tom?s Cohen Arazi <tomascohen at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|NEW                         |Needs Signoff
         Depends on|18731, 19196, 19369, 19370, |19686
                   |18120                       |
   Patch complexity|---                         |Small patch


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18120
[Bug 18120] CRUD endpoint for vendors
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18731
[Bug 18731] CRUD for acquisition orders
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19196
[Bug 19196] Add pagination helpers
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19369
[Bug 19369] Add a helper function for translating pagination params into
SQL::Abstract
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19370
[Bug 19370] Add a helper function for translating order_by params into
SQL::Abstract
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19686
[Bug 19686] objects.search helper needs a to_model param
-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Nov 23 21:26:58 2017
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 23 Nov 2017 20:26:58 +0000
Subject: [Koha-bugs] [Bug 18120] CRUD endpoint for vendors
In-Reply-To: <bug-18120-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-18120-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-18120-70-7ZhH82FCP6@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18120

Tom?s Cohen Arazi <tomascohen at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Blocks|19250                       |


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19250
[Bug 19250] Add pagination to /acquisitions/vendors
-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Nov 23 21:26:58 2017
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 23 Nov 2017 20:26:58 +0000
Subject: [Koha-bugs] [Bug 18731] CRUD for acquisition orders
In-Reply-To: <bug-18731-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-18731-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-18731-70-iJAk6CiUd7@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18731

Tom?s Cohen Arazi <tomascohen at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Blocks|19250                       |


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19250
[Bug 19250] Add pagination to /acquisitions/vendors
-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Nov 23 21:26:58 2017
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 23 Nov 2017 20:26:58 +0000
Subject: [Koha-bugs] [Bug 19196] Add pagination helpers
In-Reply-To: <bug-19196-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-19196-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-19196-70-C6F5Ywahx8@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19196

Tom?s Cohen Arazi <tomascohen at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Blocks|19250                       |


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19250
[Bug 19250] Add pagination to /acquisitions/vendors
-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Nov 23 21:26:58 2017
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 23 Nov 2017 20:26:58 +0000
Subject: [Koha-bugs] [Bug 19369] Add a helper function for translating
 pagination params into SQL:: Abstract
In-Reply-To: <bug-19369-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-19369-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-19369-70-bVYJCjmDip@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19369

Tom?s Cohen Arazi <tomascohen at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Blocks|19250                       |


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19250
[Bug 19250] Add pagination to /acquisitions/vendors
-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Nov 23 21:26:58 2017
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 23 Nov 2017 20:26:58 +0000
Subject: [Koha-bugs] [Bug 19370] Add a helper function for translating
 order_by params into SQL ::Abstract
In-Reply-To: <bug-19370-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-19370-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-19370-70-EDqtqIHAwQ@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19370

Tom?s Cohen Arazi <tomascohen at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Blocks|19250                       |


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19250
[Bug 19250] Add pagination to /acquisitions/vendors
-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Nov 23 21:26:58 2017
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 23 Nov 2017 20:26:58 +0000
Subject: [Koha-bugs] [Bug 19686] objects.search helper needs a to_model param
In-Reply-To: <bug-19686-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-19686-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-19686-70-hK6NhZ5VXS@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19686

Tom?s Cohen Arazi <tomascohen at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Blocks|                            |19250


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19250
[Bug 19250] Add pagination to /acquisitions/vendors
-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Nov 23 21:27:03 2017
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 23 Nov 2017 20:27:03 +0000
Subject: [Koha-bugs] [Bug 19250] Add pagination to /acquisitions/vendors
In-Reply-To: <bug-19250-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-19250-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-19250-70-VrTWmGLdMX@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19250

--- Comment #1 from Tom?s Cohen Arazi <tomascohen at gmail.com> ---
Created attachment 69317
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=69317&action=edit
Bug 19250: Add /acquisitions/vendors pagination

This patch makes the /acquisitions/vendors endpoint paginated and handle
the new special params introduced by 19410: _match, _order_by_, _page
and _per_page.

To do so, the OpenAPI spec is updated with the new parameters, and
_to_model is rewritten to avoid autovivification, as required by the
extension of the objects.search helper, introduced by bug 19686.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Nov 23 22:12:11 2017
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 23 Nov 2017 21:12:11 +0000
Subject: [Koha-bugs] [Bug 16711] OPAC Password recovery: Handling if
 multiple accounts have the same mail address
In-Reply-To: <bug-16711-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-16711-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-16711-70-OO8a55tGVM@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16711

Mason James <mtj at kohaaloha.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |mtj at kohaaloha.com

--- Comment #30 from Mason James <mtj at kohaaloha.com> ---
Pushed to 16.05.x, for 16.05.16 release

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Nov 23 22:17:04 2017
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 23 Nov 2017 21:17:04 +0000
Subject: [Koha-bugs] [Bug 18726] OPAC XSS - biblionumber
In-Reply-To: <bug-18726-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-18726-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-18726-70-F7jLf9iZD7@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18726

Mason James <mtj at kohaaloha.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |mtj at kohaaloha.com

--- Comment #8 from Mason James <mtj at kohaaloha.com> ---
Pushed to 16.05.x, for 16.05.16 release

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Nov 23 22:20:35 2017
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 23 Nov 2017 21:20:35 +0000
Subject: [Koha-bugs] [Bug 19053] Auto renewal flag is not kept if a
 confirmation is needed
In-Reply-To: <bug-19053-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-19053-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-19053-70-mqLgVhKfqo@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19053

Mason James <mtj at kohaaloha.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |mtj at kohaaloha.com

--- Comment #7 from Mason James <mtj at kohaaloha.com> ---
Pushed to 16.05.x, for 16.05.17 release

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Nov 23 22:21:11 2017
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 23 Nov 2017 21:21:11 +0000
Subject: [Koha-bugs] [Bug 18741] Web installer does not load default data
In-Reply-To: <bug-18741-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-18741-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-18741-70-Ve5HLneGHK@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18741

Mason James <mtj at kohaaloha.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |mtj at kohaaloha.com

--- Comment #12 from Mason James <mtj at kohaaloha.com> ---
Pushed to 16.05.x, for 16.05.17 release

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Nov 23 22:21:36 2017
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 23 Nov 2017 21:21:36 +0000
Subject: [Koha-bugs] [Bug 18996] SIP sets ok flag to true for refused
 checkin for data corruption
In-Reply-To: <bug-18996-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-18996-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-18996-70-SXZdHhcEMc@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18996

--- Comment #49 from Mason James <mtj at kohaaloha.com> ---
Pushed to 16.05.x, for 16.05.17 release

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Nov 23 22:22:03 2017
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 23 Nov 2017 21:22:03 +0000
Subject: [Koha-bugs] [Bug 18921] Resolve a few warnings in C4/XSLT.pm
In-Reply-To: <bug-18921-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-18921-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-18921-70-LZOt49yM3y@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18921

Mason James <mtj at kohaaloha.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |mtj at kohaaloha.com

--- Comment #10 from Mason James <mtj at kohaaloha.com> ---
Pushed to 16.05.x, for 16.05.17 release

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Nov 23 22:22:28 2017
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 23 Nov 2017 21:22:28 +0000
Subject: [Koha-bugs] [Bug 18649] Translatability: Get rid of tt directive in
 translation for admin/ categories.tt and onboardingstep2.tt
In-Reply-To: <bug-18649-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-18649-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-18649-70-xzfJLPCzZ1@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18649

Mason James <mtj at kohaaloha.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |mtj at kohaaloha.com

--- Comment #37 from Mason James <mtj at kohaaloha.com> ---
Pushed to 16.05.x, for 16.05.17 release

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Nov 23 22:22:48 2017
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 23 Nov 2017 21:22:48 +0000
Subject: [Koha-bugs] [Bug 18652] Translatability: Get rid of tt directive in
 translation for uncertainprice.tt
In-Reply-To: <bug-18652-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-18652-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-18652-70-k7HgnODzCl@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18652

Mason James <mtj at kohaaloha.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |mtj at kohaaloha.com

--- Comment #15 from Mason James <mtj at kohaaloha.com> ---
Pushed to 16.05.x, for 16.05.17 release

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Nov 23 22:23:07 2017
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 23 Nov 2017 21:23:07 +0000
Subject: [Koha-bugs] [Bug 18660] Translatability: Get rid of template
 directives [ %% in translation for patroncards-errors.inc
In-Reply-To: <bug-18660-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-18660-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-18660-70-QusdTrXdat@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18660

Mason James <mtj at kohaaloha.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |mtj at kohaaloha.com

--- Comment #13 from Mason James <mtj at kohaaloha.com> ---
Pushed to 16.05.x, for 16.05.17 release

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Nov 23 22:23:30 2017
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 23 Nov 2017 21:23:30 +0000
Subject: [Koha-bugs] [Bug 18778] Translatability: Get rid of tt directive in
 translation for item-status.inc
In-Reply-To: <bug-18778-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-18778-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-18778-70-a8c4zRFS8I@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18778

Mason James <mtj at kohaaloha.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |mtj at kohaaloha.com

--- Comment #7 from Mason James <mtj at kohaaloha.com> ---
Pushed to 16.05.x, for 16.05.17 release

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Nov 23 22:27:18 2017
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 23 Nov 2017 21:27:18 +0000
Subject: [Koha-bugs] [Bug 17827] Untranslatable "by" in
	MARC21slim2intranetResults.xsl
In-Reply-To: <bug-17827-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-17827-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-17827-70-684h7w1fnK@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17827

Mason James <mtj at kohaaloha.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |mtj at kohaaloha.com

--- Comment #13 from Mason James <mtj at kohaaloha.com> ---
Pushed to 16.05.x, for 16.05.17 release

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Nov 23 22:27:37 2017
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 23 Nov 2017 21:27:37 +0000
Subject: [Koha-bugs] [Bug 18898] Some permissions for Reports can be bypassed
In-Reply-To: <bug-18898-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-18898-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-18898-70-LoX6WM7rq6@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18898

Mason James <mtj at kohaaloha.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |mtj at kohaaloha.com

--- Comment #10 from Mason James <mtj at kohaaloha.com> ---
Pushed to 16.05.x, for 16.05.17 release

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Nov 23 22:28:02 2017
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 23 Nov 2017 21:28:02 +0000
Subject: [Koha-bugs] [Bug 18906] Superlibrarian and budget_manage_all users
 should always see all funds
In-Reply-To: <bug-18906-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-18906-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-18906-70-0khQQRwAl2@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18906

Mason James <mtj at kohaaloha.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |mtj at kohaaloha.com

--- Comment #9 from Mason James <mtj at kohaaloha.com> ---
Pushed to 16.05.x, for 16.05.17 release

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Nov 23 22:28:21 2017
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 23 Nov 2017 21:28:21 +0000
Subject: [Koha-bugs] [Bug 18900] wrong number format in receiving order
In-Reply-To: <bug-18900-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-18900-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-18900-70-1YiBUjfY7c@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18900

Mason James <mtj at kohaaloha.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |mtj at kohaaloha.com

--- Comment #16 from Mason James <mtj at kohaaloha.com> ---
Pushed to 16.05.x, for 16.05.17 release

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Nov 23 22:28:46 2017
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 23 Nov 2017 21:28:46 +0000
Subject: [Koha-bugs] [Bug 19073] Can't change library with patron batch
	modification tool
In-Reply-To: <bug-19073-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-19073-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-19073-70-LBLLSjRsVB@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19073

Mason James <mtj at kohaaloha.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |mtj at kohaaloha.com

--- Comment #10 from Mason James <mtj at kohaaloha.com> ---
Pushed to 16.05.x, for 16.05.17 release

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Nov 23 22:53:27 2017
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 23 Nov 2017 21:53:27 +0000
Subject: [Koha-bugs] [Bug 19687] New: Recent upgrade to 17.05.04.000
 bulkmarcimport started to fail
Message-ID: <bug-19687-70@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19687

            Bug ID: 19687
           Summary: Recent upgrade to 17.05.04.000 bulkmarcimport started
                    to fail
 Change sponsored?: ---
           Product: Koha
           Version: master
          Hardware: All
                OS: All
            Status: NEW
          Severity: normal
          Priority: P5 - low
         Component: Architecture, internals, and plumbing
          Assignee: koha-bugs at lists.koha-community.org
          Reporter: mtj at kohaaloha.com
        QA Contact: testopia at bugs.koha-community.org

After recent upgrade to 17.05.04.000 bulkmarcimport started to fail on all
items attempted to be added.

ERROR: Adding items to bib 1 failed: Undefined subroutine
&C4::Items::TransformMarcToKoha called at /usr/share/koha/lib/C4/Items.pm line
382, <GEN46> line 1

So I manually added the prefix and the next error came up:

ERROR: Adding items to bib 74925 failed: Undefined subroutine
&C4::Items::GetMarcStructure called at /usr/share/koha/lib/C4/Items.pm line
2307, <GEN46> line 14.

Manually adding the prefix to that line seems to have worked, but it does not
feel like the right solution.

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Nov 23 22:54:38 2017
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 23 Nov 2017 21:54:38 +0000
Subject: [Koha-bugs] [Bug 18927] koha-rebuild-zebra is failing with "error
 retrieving biblio"
In-Reply-To: <bug-18927-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-18927-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-18927-70-srj0HZ7ods@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18927

Mason James <mtj at kohaaloha.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |mtj at kohaaloha.com

--- Comment #16 from Mason James <mtj at kohaaloha.com> ---
(In reply to Ian Bays from comment #15)
> After recent upgrade to 17.05.04.000 bulkmarcimport started to fail on all
> items attempted to be added.

i created a separate bug for this... bug 19687

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Nov 23 22:54:59 2017
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 23 Nov 2017 21:54:59 +0000
Subject: [Koha-bugs] [Bug 19687] Recent upgrade to 17.05.04.000
 bulkmarcimport started to fail
In-Reply-To: <bug-19687-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-19687-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-19687-70-YI73G1OuHP@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19687

Mason James <mtj at kohaaloha.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
         Depends on|                            |18927


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18927
[Bug 18927] koha-rebuild-zebra is failing with "error retrieving biblio"
-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.

From bugzilla-daemon at bugs.koha-community.org  Thu Nov 23 22:54:59 2017
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 23 Nov 2017 21:54:59 +0000
Subject: [Koha-bugs] [Bug 18927] koha-rebuild-zebra is failing with "error
 retrieving biblio"
In-Reply-To: <bug-18927-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-18927-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-18927-70-agQe7tqxPr@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18927

Mason James <mtj at kohaaloha.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Blocks|                            |19687


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19687
[Bug 19687] Recent upgrade to 17.05.04.000 bulkmarcimport started to fail
-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Nov 23 22:55:26 2017
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 23 Nov 2017 21:55:26 +0000
Subject: [Koha-bugs] [Bug 19687] Recent upgrade to 17.05.04.000
 bulkmarcimport started to fail
In-Reply-To: <bug-19687-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-19687-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-19687-70-5I2OmocyxH@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19687

Mason James <mtj at kohaaloha.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |ian.bays at ptfs-europe.com

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Nov 23 22:55:59 2017
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 23 Nov 2017 21:55:59 +0000
Subject: [Koha-bugs] [Bug 19651] SIP/ILS/Item missing title
In-Reply-To: <bug-19651-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-19651-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-19651-70-dKAKd50wK8@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19651

Katrin Fischer <katrin.fischer at bsz-bw.de> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |katrin.fischer at bsz-bw.de
           Severity|major                       |critical

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.

From bugzilla-daemon at bugs.koha-community.org  Thu Nov 23 22:57:16 2017
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 23 Nov 2017 21:57:16 +0000
Subject: [Koha-bugs] [Bug 18927] koha-rebuild-zebra is failing with "error
 retrieving biblio"
In-Reply-To: <bug-18927-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-18927-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-18927-70-SvdqEvJOI1@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18927

--- Comment #17 from Mason James <mtj at kohaaloha.com> ---
(In reply to Katrin Fischer from comment #11)
> This patch has been pushed to 16.11.x and will be in 16.11.12.

Pushed to 16.05.x, for 16.05.17 release

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Nov 23 22:58:21 2017
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 23 Nov 2017 21:58:21 +0000
Subject: [Koha-bugs] [Bug 18654] Translatability: Get rid of tt directives
 starting with [ %% in translation for itemsearch.tt
In-Reply-To: <bug-18654-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-18654-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-18654-70-zFO8daz94q@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18654

Mason James <mtj at kohaaloha.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |mtj at kohaaloha.com

--- Comment #16 from Mason James <mtj at kohaaloha.com> ---
Pushed to 16.05.x, for 16.05.17 release

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Nov 23 23:02:41 2017
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 23 Nov 2017 22:02:41 +0000
Subject: [Koha-bugs] [Bug 19086] Multiple cross-site scripting
	vulnerabilities
In-Reply-To: <bug-19086-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-19086-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-19086-70-JLa3lhHlXv@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19086

--- Comment #44 from Mason James <mtj at kohaaloha.com> ---
Pushed to 16.05.x, for 16.05.17 release

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Nov 23 23:03:09 2017
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 23 Nov 2017 22:03:09 +0000
Subject: [Koha-bugs] [Bug 19103] Stored XSS in itemtypes.pl -
 patron-attr-types.pl - matching-rules.pl
In-Reply-To: <bug-19103-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-19103-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-19103-70-Si5tuDKoWy@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19103

Mason James <mtj at kohaaloha.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |mtj at kohaaloha.com

--- Comment #14 from Mason James <mtj at kohaaloha.com> ---
Pushed to 16.05.x, for 16.05.17 release

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Nov 23 23:03:58 2017
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 23 Nov 2017 22:03:58 +0000
Subject: [Koha-bugs] [Bug 19108] Stored XSS in multiple scripts
In-Reply-To: <bug-19108-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-19108-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-19108-70-1nk6b0noLM@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19108

Mason James <mtj at kohaaloha.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |mtj at kohaaloha.com

--- Comment #27 from Mason James <mtj at kohaaloha.com> ---
Pushed to 16.05.x, for 16.05.17 release

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Nov 23 23:04:17 2017
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 23 Nov 2017 22:04:17 +0000
Subject: [Koha-bugs] [Bug 19125] XSS - members.pl
In-Reply-To: <bug-19125-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-19125-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-19125-70-yebRlpWyFr@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19125

Mason James <mtj at kohaaloha.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |mtj at kohaaloha.com

--- Comment #9 from Mason James <mtj at kohaaloha.com> ---
Pushed to 16.05.x, for 16.05.17 release

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Nov 23 23:04:38 2017
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 23 Nov 2017 22:04:38 +0000
Subject: [Koha-bugs] [Bug 19127] Stored XSS in csv-profiles.pl
In-Reply-To: <bug-19127-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-19127-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-19127-70-ZydPRwwrfx@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19127

Mason James <mtj at kohaaloha.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |mtj at kohaaloha.com

--- Comment #8 from Mason James <mtj at kohaaloha.com> ---
Pushed to 16.05.x, for 16.05.17 release

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Nov 23 23:05:00 2017
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 23 Nov 2017 22:05:00 +0000
Subject: [Koha-bugs] [Bug 19128] XSS - patron-attr-types.tt,
 authorised_values.tt and categories.tt
In-Reply-To: <bug-19128-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-19128-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-19128-70-IBhZm1UMWW@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19128

Mason James <mtj at kohaaloha.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |mtj at kohaaloha.com

--- Comment #8 from Mason James <mtj at kohaaloha.com> ---
Pushed to 16.05.x, for 16.05.17 release

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Nov 23 23:06:10 2017
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 23 Nov 2017 22:06:10 +0000
Subject: [Koha-bugs] [Bug 3185] Mobile Library/Bookmobile Mode
In-Reply-To: <bug-3185-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-3185-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-3185-70-uvIYdCQNcq@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=3185

Katrin Fischer <katrin.fischer at bsz-bw.de> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
         Resolution|---                         |FIXED
             Status|REOPENED                    |RESOLVED

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the QA Contact for the bug.

From bugzilla-daemon at bugs.koha-community.org  Thu Nov 23 23:06:52 2017
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 23 Nov 2017 22:06:52 +0000
Subject: [Koha-bugs] [Bug 19071] Fix Circulation/issue.t and
	Members/IssueSlip.t
In-Reply-To: <bug-19071-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-19071-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-19071-70-zglVmMbdWA@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19071

Mason James <mtj at kohaaloha.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |mtj at kohaaloha.com

--- Comment #12 from Mason James <mtj at kohaaloha.com> ---
Pushed to 16.05.x, for 16.05.18 release

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Nov 23 23:07:17 2017
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 23 Nov 2017 22:07:17 +0000
Subject: [Koha-bugs] [Bug 18941] C4:: Budgets GetBudgetByCode should return
 active budgets over inactive budgets
In-Reply-To: <bug-18941-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-18941-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-18941-70-PUlfpDjzVg@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18941

Mason James <mtj at kohaaloha.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |mtj at kohaaloha.com

--- Comment #13 from Mason James <mtj at kohaaloha.com> ---
Pushed to 16.05.x, for 16.05.18 release

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Nov 23 23:07:36 2017
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 23 Nov 2017 22:07:36 +0000
Subject: [Koha-bugs] [Bug 19027] Circulation rules: Better wording for
 standard rules for all libraries
In-Reply-To: <bug-19027-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-19027-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-19027-70-daRToDhciX@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19027

Mason James <mtj at kohaaloha.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |mtj at kohaaloha.com

--- Comment #12 from Mason James <mtj at kohaaloha.com> ---
Pushed to 16.05.x, for 16.05.18 release

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Nov 23 23:07:54 2017
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 23 Nov 2017 22:07:54 +0000
Subject: [Koha-bugs] [Bug 18469] Suspend all holds when specifying a date to
 resume hold does not keep date
In-Reply-To: <bug-18469-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-18469-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-18469-70-PpKuaKsDW6@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18469

Mason James <mtj at kohaaloha.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |mtj at kohaaloha.com

--- Comment #10 from Mason James <mtj at kohaaloha.com> ---
Pushed to 16.05.x, for 16.05.18 release

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Nov 23 23:08:14 2017
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 23 Nov 2017 22:08:14 +0000
Subject: [Koha-bugs] [Bug 9409] koha-create --request-db should be able to
 accept a dbhost option
In-Reply-To: <bug-9409-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-9409-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-9409-70-G9A5fN6eV7@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9409

Mason James <mtj at kohaaloha.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |mtj at kohaaloha.com

--- Comment #10 from Mason James <mtj at kohaaloha.com> ---
Pushed to 16.05.x, for 16.05.18 release

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Nov 23 23:08:37 2017
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 23 Nov 2017 22:08:37 +0000
Subject: [Koha-bugs] [Bug 19126] Fix Members.t with IndependentBranches set
In-Reply-To: <bug-19126-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-19126-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-19126-70-aJqI1ayQRR@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19126

Mason James <mtj at kohaaloha.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |mtj at kohaaloha.com

--- Comment #7 from Mason James <mtj at kohaaloha.com> ---
Pushed to 16.05.x, for 16.05.18 release

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Nov 23 23:08:58 2017
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 23 Nov 2017 22:08:58 +0000
Subject: [Koha-bugs] [Bug 19118] Due to wrong variable name passed vendor
 name is not coming in browser title bar
In-Reply-To: <bug-19118-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-19118-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-19118-70-RoL1M813uq@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19118

Mason James <mtj at kohaaloha.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |mtj at kohaaloha.com

--- Comment #10 from Mason James <mtj at kohaaloha.com> ---
Pushed to 16.05.x, for 16.05.18 release

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Nov 23 23:09:22 2017
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 23 Nov 2017 22:09:22 +0000
Subject: [Koha-bugs] [Bug 19088] plugins-upload.pl causes uninitialized
	value noise
In-Reply-To: <bug-19088-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-19088-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-19088-70-qUBJriBh3N@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19088

Mason James <mtj at kohaaloha.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |mtj at kohaaloha.com

--- Comment #11 from Mason James <mtj at kohaaloha.com> ---
Pushed to 16.05.x, for 16.05.18 release

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Nov 23 23:09:52 2017
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 23 Nov 2017 22:09:52 +0000
Subject: [Koha-bugs] [Bug 18687] Translatability: abbr tag should not
 contain lang attribute
In-Reply-To: <bug-18687-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-18687-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-18687-70-rMswTNnQQp@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18687

Mason James <mtj at kohaaloha.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |mtj at kohaaloha.com

--- Comment #8 from Mason James <mtj at kohaaloha.com> ---
Pushed to 16.05.x, for 16.05.18 release

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Nov 23 23:10:31 2017
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 23 Nov 2017 22:10:31 +0000
Subject: [Koha-bugs] [Bug 18754] Translatability: Get rid of exposed tt
 directives in opac-detail.tt
In-Reply-To: <bug-18754-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-18754-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-18754-70-Fh1NJVIwiO@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18754

Mason James <mtj at kohaaloha.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |mtj at kohaaloha.com

--- Comment #16 from Mason James <mtj at kohaaloha.com> ---
Pushed to 16.05.x, for 16.05.18 release

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Nov 23 23:10:49 2017
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 23 Nov 2017 22:10:49 +0000
Subject: [Koha-bugs] [Bug 18776] Translatability: Get rid of exposed tt
 directives in opac-advsearch.tt
In-Reply-To: <bug-18776-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-18776-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-18776-70-BMQTyTcGYm@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18776

Mason James <mtj at kohaaloha.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |mtj at kohaaloha.com

--- Comment #8 from Mason James <mtj at kohaaloha.com> ---
Pushed to 16.05.x, for 16.05.18 release

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Nov 23 23:11:06 2017
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 23 Nov 2017 22:11:06 +0000
Subject: [Koha-bugs] [Bug 18779] Translatability: Get rid of exposed tt
 directives in authorities-search-results.inc (OPAC)
In-Reply-To: <bug-18779-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-18779-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-18779-70-x5REJK8jA2@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18779

Mason James <mtj at kohaaloha.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |mtj at kohaaloha.com

--- Comment #10 from Mason James <mtj at kohaaloha.com> ---
Pushed to 16.05.x, for 16.05.18 release

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Nov 23 23:11:25 2017
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 23 Nov 2017 22:11:25 +0000
Subject: [Koha-bugs] [Bug 18780] Translatability: Get rid of exposed tt
 directive in masthead-langmenu.inc
In-Reply-To: <bug-18780-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-18780-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-18780-70-yvd9odu8cV@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18780

Mason James <mtj at kohaaloha.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |mtj at kohaaloha.com

--- Comment #7 from Mason James <mtj at kohaaloha.com> ---
Pushed to 16.05.x, for 16.05.18 release

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Nov 23 23:11:43 2017
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 23 Nov 2017 22:11:43 +0000
Subject: [Koha-bugs] [Bug 18781] Translatability: Get rid of exposed tt
 directives in openlibrary-readapi.inc
In-Reply-To: <bug-18781-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-18781-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-18781-70-TUtW0x5Ozf@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18781

Mason James <mtj at kohaaloha.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |mtj at kohaaloha.com

--- Comment #7 from Mason James <mtj at kohaaloha.com> ---
Pushed to 16.05.x, for 16.05.18 release

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Nov 23 23:12:07 2017
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 23 Nov 2017 22:12:07 +0000
Subject: [Koha-bugs] [Bug 18871] It is unclear how to view a patron list
In-Reply-To: <bug-18871-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-18871-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-18871-70-07D92lv3Er@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18871

Mason James <mtj at kohaaloha.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |mtj at kohaaloha.com

--- Comment #7 from Mason James <mtj at kohaaloha.com> ---
Pushed to 16.05.x, for 16.05.18 release

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Nov 23 23:12:24 2017
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 23 Nov 2017 22:12:24 +0000
Subject: [Koha-bugs] [Bug 18794] OAI/Server.t fails on slow servers
In-Reply-To: <bug-18794-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-18794-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-18794-70-D4kwPDEc0X@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18794

Mason James <mtj at kohaaloha.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |mtj at kohaaloha.com

--- Comment #10 from Mason James <mtj at kohaaloha.com> ---
Pushed to 16.05.x, for 16.05.18 release

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Nov 23 23:52:57 2017
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 23 Nov 2017 22:52:57 +0000
Subject: [Koha-bugs] [Bug 18308] Default value of minPasswordLength should
	be increased
In-Reply-To: <bug-18308-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-18308-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-18308-70-CESEmUmMxd@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18308

Alex Buckley <alexbuckley at catalyst.net.nz> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #68451|0                           |1
        is obsolete|                            |

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Nov 23 23:54:48 2017
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 23 Nov 2017 22:54:48 +0000
Subject: [Koha-bugs] [Bug 18308] Default value of minPasswordLength should
	be increased
In-Reply-To: <bug-18308-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-18308-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-18308-70-WbvTZScxXz@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18308

--- Comment #12 from Alex Buckley <alexbuckley at catalyst.net.nz> ---
Created attachment 69318
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=69318&action=edit
Bug 18308 - Added step to onboarding tool to set minPasswordLength

This patch increases the default minPasswordLength syspref value to 8
characters, for new installations.

The final (6th step) of the onboarding tool is now a password length
page where the default value of 8 can be altered. There is a security warning
in red recommending to the user they
keep the minimum length of the password at 8 characters or more.

This patch also removes the atomicupdate .sql file to be run in an update to
alter the default
minPasswordLength value for existing Koha installations, based on tester
feedback.

Test plan:
1. Create a patron with a password less than 3 characters in length and
notice that a red message is displayed by the input telling you that the
password must be 3 characters minimum length

2. Query the database "select value from systempreferences where
variable="minPasswordLength"; and notice the value is 3

3. Drop and recreate your database and restart memcached

4. Go through the web installer and onboarding tool. Noticing the last
step of the onboarding tool is to create a circulation rule

5. Apply patch

6. Repeat step 3

7. Go through the web installer and onboarding tool. Noticing the last
step of the onboarding tool is to set the minimum password length, the
numerical input element has a default value of 8 and notice that it will
go below 3

8. Repeat step 2 and notice the value is 8

9. In the onboarding tool change the minimum password length value to 7
and submit the form

10. Notice the completed page of the onboarding tool is displayed with
the message that the minimum password length has been set.

11. Repeat step 2 and notice the value is now 7.

12. Try to create a patron in Intranet and OPAC with a password less
than 7 characters and notice that a red message is displayed by the
input telling you that the password must be 7 characters minimum length

Sponsored-By: Catalyst IT

Sponsored-By: Catalyst IT

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Nov 23 23:55:17 2017
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 23 Nov 2017 22:55:17 +0000
Subject: [Koha-bugs] [Bug 18308] Default value of minPasswordLength should
	be increased
In-Reply-To: <bug-18308-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-18308-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-18308-70-nAx0To9qMR@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18308

--- Comment #13 from Alex Buckley <alexbuckley at catalyst.net.nz> ---
Created attachment 69319
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=69319&action=edit
Bug 18308 - Added warning and dialog alert

If an institution has a minPasswordLength which is < 8 characters then a
warning
will be set (which is visible in the intranet-error.log) and a dialog
alert div will display the warning to the user in the memberentry.pl
page in the intranet.

Test plan:
1. Ensure that your minPasswordLength is set to less than 8 characters.
This replicates the use case that a Koha instance is existing (i.e. not
a new Koha instance) and not gone through the password length step of
the onboarding tool (previous patch on this bug report) or that the
institituion is new but set a password length of less than 8 in the
onboarding tool

2. Go to the memberentry.pl page and notice that there is no warning
at the top of the page informing you that your minPasswordLength is less
than 8

3. Apply this patch

4. Refresh the memberentry.pl page and notice that there is a yellow
warning at the top of the page informing you that your minPasswordLength
syspref is less than 8

Sponsored-By: Catalyst IT

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Nov 24 00:05:56 2017
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 23 Nov 2017 23:05:56 +0000
Subject: [Koha-bugs] [Bug 19227] 00-merge-conflict-markers.t launches too
	many tests
In-Reply-To: <bug-19227-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-19227-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-19227-70-jjNeTaVjnp@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19227

Mason James <mtj at kohaaloha.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |mtj at kohaaloha.com

--- Comment #7 from Mason James <mtj at kohaaloha.com> ---
Pushed to 16.05.x, for 16.05.18 release

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Nov 24 00:06:12 2017
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 23 Nov 2017 23:06:12 +0000
Subject: [Koha-bugs] [Bug 19335] 00-merge-markers.t fails
In-Reply-To: <bug-19335-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-19335-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-19335-70-s1giw21MoJ@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19335

Mason James <mtj at kohaaloha.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |mtj at kohaaloha.com

--- Comment #8 from Mason James <mtj at kohaaloha.com> ---
Pushed to 16.05.x, for 16.05.18 release

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Nov 24 00:06:38 2017
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 23 Nov 2017 23:06:38 +0000
Subject: [Koha-bugs] [Bug 15924] Coce not enabled on lists
In-Reply-To: <bug-15924-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-15924-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-15924-70-sE1c8g0S1E@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15924

Mason James <mtj at kohaaloha.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |mtj at kohaaloha.com

--- Comment #11 from Mason James <mtj at kohaaloha.com> ---
Pushed to 16.05.x, for 16.05.18 release

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Nov 24 00:06:55 2017
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 23 Nov 2017 23:06:55 +0000
Subject: [Koha-bugs] [Bug 19007] Allow paypal payments via debit or credit
	card again
In-Reply-To: <bug-19007-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-19007-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-19007-70-AUwsJtjWm2@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19007

Mason James <mtj at kohaaloha.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |mtj at kohaaloha.com

--- Comment #11 from Mason James <mtj at kohaaloha.com> ---
Pushed to 16.05.x, for 16.05.18 release

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Nov 24 00:07:12 2017
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 23 Nov 2017 23:07:12 +0000
Subject: [Koha-bugs] [Bug 18812] SIP Patron status does not respect
	OverduesBlockCirc
In-Reply-To: <bug-18812-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-18812-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-18812-70-onXlE5X0vT@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18812

Mason James <mtj at kohaaloha.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |mtj at kohaaloha.com

--- Comment #7 from Mason James <mtj at kohaaloha.com> ---
Pushed to 16.05.x, for 16.05.18 release

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Nov 24 00:07:29 2017
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 23 Nov 2017 23:07:29 +0000
Subject: [Koha-bugs] [Bug 18621] After duplicate message system picks
 category expiry date rather than manual defined
In-Reply-To: <bug-18621-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-18621-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-18621-70-LsEhhcdtvI@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18621

Mason James <mtj at kohaaloha.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |mtj at kohaaloha.com

--- Comment #10 from Mason James <mtj at kohaaloha.com> ---
Pushed to 16.05.x, for 16.05.18 release

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Nov 24 00:07:46 2017
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 23 Nov 2017 23:07:46 +0000
Subject: [Koha-bugs] [Bug 9857] Did you mean? from authorities uses
	incorrect punctuation
In-Reply-To: <bug-9857-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-9857-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-9857-70-Vany7MpQER@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9857

Mason James <mtj at kohaaloha.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |mtj at kohaaloha.com

--- Comment #19 from Mason James <mtj at kohaaloha.com> ---
Pushed to 16.05.x, for 16.05.18 release

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Nov 24 00:08:09 2017
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 23 Nov 2017 23:08:09 +0000
Subject: [Koha-bugs] [Bug 19024] Order cancelled status is reset on basket
	close
In-Reply-To: <bug-19024-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-19024-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-19024-70-7Emd7R3J3r@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19024

Mason James <mtj at kohaaloha.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |mtj at kohaaloha.com

--- Comment #26 from Mason James <mtj at kohaaloha.com> ---
Pushed to 16.05.x, for 16.05.18 release

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Nov 24 00:08:29 2017
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 23 Nov 2017 23:08:29 +0000
Subject: [Koha-bugs] [Bug 16485] Collection column in Item search is always
	empty
In-Reply-To: <bug-16485-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-16485-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-16485-70-NjPjaRCO2B@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16485

Mason James <mtj at kohaaloha.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |mtj at kohaaloha.com

--- Comment #25 from Mason James <mtj at kohaaloha.com> ---
Pushed to 16.05.x, for 16.05.18 release

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Nov 24 00:08:46 2017
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 23 Nov 2017 23:08:46 +0000
Subject: [Koha-bugs] [Bug 18636] Can not save new patron on fresh install (
 Conflict between autoMemberNum and BorrowerMandatoryField)
In-Reply-To: <bug-18636-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-18636-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-18636-70-jY3WkKpcRx@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18636

Mason James <mtj at kohaaloha.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |mtj at kohaaloha.com

--- Comment #14 from Mason James <mtj at kohaaloha.com> ---
Pushed to 16.05.x, for 16.05.18 release

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Nov 24 00:09:03 2017
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 23 Nov 2017 23:09:03 +0000
Subject: [Koha-bugs] [Bug 18692] When SMS is enabled the OPAC messaging
 table is misaligned
In-Reply-To: <bug-18692-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-18692-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-18692-70-kBOxrn1ZYy@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18692

Mason James <mtj at kohaaloha.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |mtj at kohaaloha.com

--- Comment #23 from Mason James <mtj at kohaaloha.com> ---
Pushed to 16.05.x, for 16.05.18 release

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Nov 24 00:09:24 2017
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 23 Nov 2017 23:09:24 +0000
Subject: [Koha-bugs] [Bug 18946] Change language from external web fails
In-Reply-To: <bug-18946-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-18946-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-18946-70-yRfLoG5Mek@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18946

Mason James <mtj at kohaaloha.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |mtj at kohaaloha.com

--- Comment #11 from Mason James <mtj at kohaaloha.com> ---
Pushed to 16.05.x, for 16.05.18 release

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Nov 24 00:09:57 2017
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 23 Nov 2017 23:09:57 +0000
Subject: [Koha-bugs] [Bug 14316] Clarify meaning of record number in Batch
 record deletion tool
In-Reply-To: <bug-14316-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-14316-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-14316-70-Wy1MvD9DqI@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14316

Mason James <mtj at kohaaloha.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |mtj at kohaaloha.com

--- Comment #16 from Mason James <mtj at kohaaloha.com> ---
Pushed to 16.05.x, for 16.05.18 release

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Nov 24 00:10:19 2017
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 23 Nov 2017 23:10:19 +0000
Subject: [Koha-bugs] [Bug 19343] Private lists displayed in search results
	list
In-Reply-To: <bug-19343-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-19343-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-19343-70-0QFVkJfIOV@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19343

Mason James <mtj at kohaaloha.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |mtj at kohaaloha.com

--- Comment #20 from Mason James <mtj at kohaaloha.com> ---
Pushed to 16.05.x, for 16.05.18 release

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Nov 24 00:10:44 2017
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 23 Nov 2017 23:10:44 +0000
Subject: [Koha-bugs] [Bug 17834] Change library news text for single-branch
	libraries
In-Reply-To: <bug-17834-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-17834-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-17834-70-Wy25eY6G0V@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17834

Mason James <mtj at kohaaloha.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |mtj at kohaaloha.com

--- Comment #13 from Mason James <mtj at kohaaloha.com> ---
Pushed to 16.05.x, for 16.05.18 release

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Nov 24 00:11:18 2017
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 23 Nov 2017 23:11:18 +0000
Subject: [Koha-bugs] [Bug 19257] Warn when reopening a basket
In-Reply-To: <bug-19257-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-19257-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-19257-70-NgEFhWYrZb@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19257

Mason James <mtj at kohaaloha.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |mtj at kohaaloha.com

--- Comment #7 from Mason James <mtj at kohaaloha.com> ---
Pushed to 16.05.x, for 16.05.18 release

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Nov 24 00:11:02 2017
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 23 Nov 2017 23:11:02 +0000
Subject: [Koha-bugs] [Bug 19229] Clicking Cancel when editing course doesn'
 t take you back to the course
In-Reply-To: <bug-19229-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-19229-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-19229-70-rtlvioZEqC@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19229

Mason James <mtj at kohaaloha.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |mtj at kohaaloha.com

--- Comment #7 from Mason James <mtj at kohaaloha.com> ---
Pushed to 16.05.x, for 16.05.18 release

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Nov 24 00:11:41 2017
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 23 Nov 2017 23:11:41 +0000
Subject: [Koha-bugs] [Bug 18351] No warning when deleting budgets that have
 funds attached
In-Reply-To: <bug-18351-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-18351-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-18351-70-5YphAVF45d@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18351

Mason James <mtj at kohaaloha.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |mtj at kohaaloha.com

--- Comment #34 from Mason James <mtj at kohaaloha.com> ---
Pushed to 16.05.x, for 16.05.18 release

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Nov 24 00:15:27 2017
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 23 Nov 2017 23:15:27 +0000
Subject: [Koha-bugs] [Bug 19440] XISBN tests should skip if XISBN returns
	overlimit error
In-Reply-To: <bug-19440-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-19440-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-19440-70-UGXHEm1rkm@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19440

--- Comment #8 from Mason James <mtj at kohaaloha.com> ---
Pushed to 16.05.x, for 16.05.18 release

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Nov 24 00:15:44 2017
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 23 Nov 2017 23:15:44 +0000
Subject: [Koha-bugs] [Bug 19350] Holds without link in 773 trigger
	SQL::Abstract::puke
In-Reply-To: <bug-19350-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-19350-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-19350-70-6wUHOOAEgR@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19350

Mason James <mtj at kohaaloha.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |mtj at kohaaloha.com

--- Comment #10 from Mason James <mtj at kohaaloha.com> ---
Pushed to 16.05.x, for 16.05.18 release

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Nov 24 00:16:19 2017
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 23 Nov 2017 23:16:19 +0000
Subject: [Koha-bugs] [Bug 19418] Patron search is broken
In-Reply-To: <bug-19418-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-19418-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-19418-70-dGL4sNvrpV@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19418

Mason James <mtj at kohaaloha.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |mtj at kohaaloha.com

--- Comment #12 from Mason James <mtj at kohaaloha.com> ---
Pushed to 16.05.x, for 16.05.18 release

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Nov 24 00:16:37 2017
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 23 Nov 2017 23:16:37 +0000
Subject: [Koha-bugs] [Bug 19120] Order cancelled status is reset on basket
	open
In-Reply-To: <bug-19120-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-19120-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-19120-70-wvJ5eDVq5g@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19120

Mason James <mtj at kohaaloha.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |mtj at kohaaloha.com

--- Comment #11 from Mason James <mtj at kohaaloha.com> ---
Pushed to 16.05.x, for 16.05.18 release

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Nov 24 00:16:58 2017
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 23 Nov 2017 23:16:58 +0000
Subject: [Koha-bugs] [Bug 19323] subscription edit permission issue
In-Reply-To: <bug-19323-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-19323-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-19323-70-uVY3Wn0v6E@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19323

Mason James <mtj at kohaaloha.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |mtj at kohaaloha.com

--- Comment #8 from Mason James <mtj at kohaaloha.com> ---
Pushed to 16.05.x, for 16.05.18 release

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Nov 24 00:17:31 2017
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 23 Nov 2017 23:17:31 +0000
Subject: [Koha-bugs] [Bug 18956] Possible privacy breach with OPAC password
	recovery
In-Reply-To: <bug-18956-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-18956-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-18956-70-SAvGTC6M9R@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18956

Mason James <mtj at kohaaloha.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |mtj at kohaaloha.com

--- Comment #28 from Mason James <mtj at kohaaloha.com> ---
Pushed to 16.05.x, for 16.05.18 release

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Nov 24 00:17:50 2017
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 23 Nov 2017 23:17:50 +0000
Subject: [Koha-bugs] [Bug 19117] paycollect.pl is vulnerable for CSRF attacks
In-Reply-To: <bug-19117-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-19117-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-19117-70-G1YJOofAfY@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19117

Mason James <mtj at kohaaloha.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |mtj at kohaaloha.com

--- Comment #12 from Mason James <mtj at kohaaloha.com> ---
Pushed to 16.05.x, for 16.05.18 release

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Nov 24 00:18:06 2017
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 23 Nov 2017 23:18:06 +0000
Subject: [Koha-bugs] [Bug 19333] XSS vulnerability in opac-shelves
In-Reply-To: <bug-19333-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-19333-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-19333-70-1Y16bM1Hrf@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19333

Mason James <mtj at kohaaloha.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |mtj at kohaaloha.com

--- Comment #11 from Mason James <mtj at kohaaloha.com> ---
Pushed to 16.05.x, for 16.05.18 release

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Nov 24 00:19:33 2017
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 23 Nov 2017 23:19:33 +0000
Subject: [Koha-bugs] [Bug 17278] Limit to available items returns 0 results
In-Reply-To: <bug-17278-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-17278-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-17278-70-xMfsUi5N6Q@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17278

--- Comment #28 from Mason James <mtj at kohaaloha.com> ---
Pushed to 16.05.x, for 16.05.19 release

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Nov 24 00:19:55 2017
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 23 Nov 2017 23:19:55 +0000
Subject: [Koha-bugs] [Bug 19262] pod_spell.t does not work
In-Reply-To: <bug-19262-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-19262-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-19262-70-XB8YlrHa0O@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19262

Mason James <mtj at kohaaloha.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |mtj at kohaaloha.com

--- Comment #6 from Mason James <mtj at kohaaloha.com> ---
Pushed to 16.05.x, for 16.05.19 release

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Nov 24 00:20:12 2017
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 23 Nov 2017 23:20:12 +0000
Subject: [Koha-bugs] [Bug 18801] Merging authorities has an invalid
 'Default' type in the merge framework selector
In-Reply-To: <bug-18801-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-18801-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-18801-70-FMRsN8u39u@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18801

Mason James <mtj at kohaaloha.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |mtj at kohaaloha.com

--- Comment #12 from Mason James <mtj at kohaaloha.com> ---
Pushed to 16.05.x, for 16.05.19 release

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Nov 24 00:20:31 2017
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 23 Nov 2017 23:20:31 +0000
Subject: [Koha-bugs] [Bug 18584] Our legacy code contains trailing-spaces
In-Reply-To: <bug-18584-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-18584-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-18584-70-ErhUYPNsIx@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18584

--- Comment #19 from Mason James <mtj at kohaaloha.com> ---
Pushed to 16.05.x, for 16.05.19 release

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.

From bugzilla-daemon at bugs.koha-community.org  Fri Nov 24 00:20:46 2017
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 23 Nov 2017 23:20:46 +0000
Subject: [Koha-bugs] [Bug 19337] Allow basic_workflow.t be configured by ENV
In-Reply-To: <bug-19337-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-19337-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-19337-70-1uSdSb9ymY@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19337

Mason James <mtj at kohaaloha.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |mtj at kohaaloha.com

--- Comment #7 from Mason James <mtj at kohaaloha.com> ---
Pushed to 16.05.x, for 16.05.19 release

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Nov 24 00:21:02 2017
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 23 Nov 2017 23:21:02 +0000
Subject: [Koha-bugs] [Bug 15644] City dropdown default selection when
 modifying a patron matches only on city
In-Reply-To: <bug-15644-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-15644-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-15644-70-v4jfepDPam@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15644

Mason James <mtj at kohaaloha.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |mtj at kohaaloha.com

--- Comment #9 from Mason James <mtj at kohaaloha.com> ---
Pushed to 16.05.x, for 16.05.19 release

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Nov 24 00:21:20 2017
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 23 Nov 2017 23:21:20 +0000
Subject: [Koha-bugs] [Bug 16204] Show friendly error message when trying to
 edit record which no longer exists
In-Reply-To: <bug-16204-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-16204-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-16204-70-l396lqFKvY@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16204

Mason James <mtj at kohaaloha.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |mtj at kohaaloha.com

--- Comment #8 from Mason James <mtj at kohaaloha.com> ---
Pushed to 16.05.x, for 16.05.19 release

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Nov 24 00:21:37 2017
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 23 Nov 2017 23:21:37 +0000
Subject: [Koha-bugs] [Bug 19415] FindDuplicateAuthority is searching on
 biblioserver since 16.05
In-Reply-To: <bug-19415-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-19415-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-19415-70-l71wuvytxO@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19415

Mason James <mtj at kohaaloha.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |mtj at kohaaloha.com

--- Comment #11 from Mason James <mtj at kohaaloha.com> ---
Pushed to 16.05.x, for 16.05.19 release

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Nov 24 00:21:57 2017
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 23 Nov 2017 23:21:57 +0000
Subject: [Koha-bugs] [Bug 19195] Noisy warns when creating or editing a
	basket
In-Reply-To: <bug-19195-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-19195-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-19195-70-YCMNSdAdg6@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19195

Mason James <mtj at kohaaloha.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |mtj at kohaaloha.com

--- Comment #8 from Mason James <mtj at kohaaloha.com> ---
Pushed to 16.05.x, for 16.05.19 release

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Nov 24 00:22:18 2017
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 23 Nov 2017 23:22:18 +0000
Subject: [Koha-bugs] [Bug 16463] OPAC discharge page should warn the user
 about checkouts before they request
In-Reply-To: <bug-16463-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-16463-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-16463-70-cLsOuwIemd@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16463

Mason James <mtj at kohaaloha.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |mtj at kohaaloha.com

--- Comment #10 from Mason James <mtj at kohaaloha.com> ---
Pushed to 16.05.x, for 16.05.19 release

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Nov 24 00:22:36 2017
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 23 Nov 2017 23:22:36 +0000
Subject: [Koha-bugs] [Bug 19307] t/db_dependent/Circulation/
 NoIssuesChargeGuarantees.t fails if AllowFineOverride set to allow
In-Reply-To: <bug-19307-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-19307-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-19307-70-zzzbTji1rN@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19307

Mason James <mtj at kohaaloha.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |mtj at kohaaloha.com

--- Comment #9 from Mason James <mtj at kohaaloha.com> ---
Pushed to 16.05.x, for 16.05.19 release

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Nov 24 00:23:23 2017
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 23 Nov 2017 23:23:23 +0000
Subject: [Koha-bugs] [Bug 16726] Text in Preferences search box does not
	clear
In-Reply-To: <bug-16726-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-16726-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-16726-70-ldoKBkWpXw@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16726

Mason James <mtj at kohaaloha.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |mtj at kohaaloha.com

--- Comment #29 from Mason James <mtj at kohaaloha.com> ---
Pushed to 16.05.x, for 16.05.19 release

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Nov 24 00:23:42 2017
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 23 Nov 2017 23:23:42 +0000
Subject: [Koha-bugs] [Bug 19386] t/db_dependent/SIP/Patron.t is failing
	randomly
In-Reply-To: <bug-19386-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-19386-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-19386-70-u5eQMujwtC@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19386

Mason James <mtj at kohaaloha.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |mtj at kohaaloha.com

--- Comment #10 from Mason James <mtj at kohaaloha.com> ---
Pushed to 16.05.x, for 16.05.19 release

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Nov 24 00:24:02 2017
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 23 Nov 2017 23:24:02 +0000
Subject: [Koha-bugs] [Bug 19345] SendMail error does not display error
 message in password recovery
In-Reply-To: <bug-19345-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-19345-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-19345-70-4IdNAqog7d@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19345

Mason James <mtj at kohaaloha.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |mtj at kohaaloha.com

--- Comment #8 from Mason James <mtj at kohaaloha.com> ---
Pushed to 16.05.x, for 16.05.19 release

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Nov 24 00:24:19 2017
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 23 Nov 2017 23:24:19 +0000
Subject: [Koha-bugs] [Bug 17664] Silence non-zebra warnings in
	t/db_dependent/Search.t
In-Reply-To: <bug-17664-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-17664-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-17664-70-nxxSkB26ml@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17664

Mason James <mtj at kohaaloha.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |mtj at kohaaloha.com

--- Comment #13 from Mason James <mtj at kohaaloha.com> ---
Pushed to 16.05.x, for 16.05.19 release

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Nov 24 00:24:36 2017
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 23 Nov 2017 23:24:36 +0000
Subject: [Koha-bugs] [Bug 19193] When displaying the fines of the guarantee
 on the guarantor account, price is not in correct format.
In-Reply-To: <bug-19193-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-19193-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-19193-70-yuvKYFstDl@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19193

Mason James <mtj at kohaaloha.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |mtj at kohaaloha.com

--- Comment #10 from Mason James <mtj at kohaaloha.com> ---
Pushed to 16.05.x, for 16.05.19 release

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Nov 24 00:24:53 2017
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 23 Nov 2017 23:24:53 +0000
Subject: [Koha-bugs] [Bug 19423] DecreaseLoanHighHolds.t is failing randomly
In-Reply-To: <bug-19423-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-19423-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-19423-70-uR6QIx1Oqi@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19423

Mason James <mtj at kohaaloha.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |mtj at kohaaloha.com

--- Comment #5 from Mason James <mtj at kohaaloha.com> ---
Pushed to 16.05.x, for 16.05.19 release

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Nov 24 00:25:15 2017
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 23 Nov 2017 23:25:15 +0000
Subject: [Koha-bugs] [Bug 17610] [16.11.x] Allow the number of plack workers
 and max connections to be set in koha-conf.xml
In-Reply-To: <bug-17610-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-17610-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-17610-70-bTJg4IrP1z@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17610

Mason James <mtj at kohaaloha.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |mtj at kohaaloha.com

--- Comment #26 from Mason James <mtj at kohaaloha.com> ---
Pushed to 16.05.x, for 16.05.19 release

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Nov 24 00:25:32 2017
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 23 Nov 2017 23:25:32 +0000
Subject: [Koha-bugs] [Bug 18616] The "Add forgot password link to OPAC"
 should allow patrons to use their library card number in addition to
 username
In-Reply-To: <bug-18616-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-18616-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-18616-70-c8apif8H1W@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18616

Mason James <mtj at kohaaloha.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |mtj at kohaaloha.com

--- Comment #23 from Mason James <mtj at kohaaloha.com> ---
Pushed to 16.05.x, for 16.05.19 release

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Nov 24 00:46:42 2017
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 23 Nov 2017 23:46:42 +0000
Subject: [Koha-bugs] [Bug 18308] Default value of minPasswordLength should
	be increased
In-Reply-To: <bug-18308-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-18308-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-18308-70-KzmNqGpnhb@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18308

Alex Buckley <alexbuckley at catalyst.net.nz> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #69318|0                           |1
        is obsolete|                            |

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Nov 24 00:46:51 2017
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 23 Nov 2017 23:46:51 +0000
Subject: [Koha-bugs] [Bug 18308] Default value of minPasswordLength should
	be increased
In-Reply-To: <bug-18308-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-18308-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-18308-70-Ei9uLkvZKw@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18308

Alex Buckley <alexbuckley at catalyst.net.nz> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #69319|0                           |1
        is obsolete|                            |

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Nov 24 00:47:32 2017
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 23 Nov 2017 23:47:32 +0000
Subject: [Koha-bugs] [Bug 18308] Default value of minPasswordLength should
	be increased
In-Reply-To: <bug-18308-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-18308-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-18308-70-3tEJZgXt4S@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18308

--- Comment #14 from Alex Buckley <alexbuckley at catalyst.net.nz> ---
Created attachment 69320
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=69320&action=edit
Bug 18308 - Added step to onboarding tool to set minPasswordLength

This patch increases the default minPasswordLength syspref value to 8
characters, for new installations.

The final (6th step) of the onboarding tool is now a password length
page where the default value of 8 can be altered. There is a security warning
in red recommending to the user they
keep the minimum length of the password at 8 characters or more.

This patch also removes the atomicupdate .sql file to be run in an update to
alter the default
minPasswordLength value for existing Koha installations, based on tester
feedback.

Test plan:
1. Create a patron with a password less than 3 characters in length and
notice that a red message is displayed by the input telling you that the
password must be 3 characters minimum length

2. Query the database "select value from systempreferences where
variable="minPasswordLength"; and notice the value is 3

3. Drop and recreate your database and restart memcached

4. Go through the web installer and onboarding tool. Noticing the last
step of the onboarding tool is to create a circulation rule

5. Apply patch

6. Repeat step 3

7. Go through the web installer and onboarding tool. Noticing the last
step of the onboarding tool is to set the minimum password length, the
numerical input element has a default value of 8 and notice that it will
go below 3

8. Repeat step 2 and notice the value is 8

9. In the onboarding tool change the minimum password length value to 7
and submit the form

10. Notice the completed page of the onboarding tool is displayed with
the message that the minimum password length has been set.

11. Repeat step 2 and notice the value is now 7.

12. Try to create a patron in Intranet and OPAC with a password less
than 7 characters and notice that a red message is displayed by the
input telling you that the password must be 7 characters minimum length

Sponsored-By: Catalyst IT

Sponsored-By: Catalyst IT

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Nov 24 00:48:20 2017
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 23 Nov 2017 23:48:20 +0000
Subject: [Koha-bugs] [Bug 18308] Default value of minPasswordLength should
	be increased
In-Reply-To: <bug-18308-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-18308-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-18308-70-ar3j7EDGzn@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18308

--- Comment #15 from Alex Buckley <alexbuckley at catalyst.net.nz> ---
Created attachment 69321
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=69321&action=edit
Bug 18308 - Added warning and dialog alert

If an institution has a minPasswordLength which is < 8 characters then a
warning
will be set (which is visible in the intranet-error.log) and a dialog
alert div will display the warning to the user in the memberentry.pl
page in the intranet.

Test plan:
1. Ensure that your minPasswordLength is set to less than 8 characters.
This replicates the use case that a Koha instance is existing (i.e. not
a new Koha instance) and not gone through the password length step of
the onboarding tool (previous patch on this bug report) or that the
institituion is new but set a password length of less than 8 in the
onboarding tool

2. Go to the memberentry.pl page and notice that there is no warning
at the top of the page informing you that your minPasswordLength is less
than 8

3. Apply this patch

4. Refresh the memberentry.pl page and notice that there is a yellow
warning at the top of the page informing you that your minPasswordLength
syspref is less than 8

Sponsored-By: Catalyst IT

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Nov 24 01:55:00 2017
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 24 Nov 2017 00:55:00 +0000
Subject: [Koha-bugs] [Bug 19532] Recalls for Koha
In-Reply-To: <bug-19532-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-19532-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-19532-70-sNKXvE6tKY@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19532

--- Comment #21 from Aleisha Amohia <aleisha at catalyst.net.nz> ---
Created attachment 69322
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=69322&action=edit
Bug 19532: Recall pop up when checking in an item

When checking in an item on the staff side, the staff member will see a
pop up if there is a recall attached to that item. From here, they can
confirm the recall, setting the status to 'Waiting' and updating the
waitingdate. The item will still be checked in.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Nov 24 02:02:58 2017
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 24 Nov 2017 01:02:58 +0000
Subject: [Koha-bugs] [Bug 18308] Default value of minPasswordLength should
	be increased
In-Reply-To: <bug-18308-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-18308-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-18308-70-H2KaEmxZa7@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18308

Alex Buckley <alexbuckley at catalyst.net.nz> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #69320|0                           |1
        is obsolete|                            |

--- Comment #16 from Alex Buckley <alexbuckley at catalyst.net.nz> ---
Created attachment 69323
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=69323&action=edit
Bug 18308 - Added step to onboarding tool to set minPasswordLength

This patch increases the default minPasswordLength syspref value to 8
characters, for new installations.

The final (6th step) of the onboarding tool is now a password length
page where the default value of 8 can be altered. There is a security warning
in red recommending to the user they
keep the minimum length of the password at 8 characters or more.

This patch also removes the atomicupdate .sql file to be run in an update to
alter the default
minPasswordLength value for existing Koha installations, based on tester
feedback.

Test plan:
1. Create a patron with a password less than 3 characters in length and
notice that a red message is displayed by the input telling you that the
password must be 3 characters minimum length

2. Query the database "select value from systempreferences where
variable="minPasswordLength"; and notice the value is 3

3. Drop and recreate your database and restart memcached

4. Go through the web installer and onboarding tool. Noticing the last
step of the onboarding tool is to create a circulation rule

5. Apply patch

6. Repeat step 3

7. Go through the web installer and onboarding tool. Noticing the last
step of the onboarding tool is to set the minimum password length, the
numerical input element has a default value of 8 and notice that it will
go below 3

8. Repeat step 2 and notice the value is 8

9. In the onboarding tool change the minimum password length value to 7
and submit the form

10. Notice the completed page of the onboarding tool is displayed with
the message that the minimum password length has been set.

11. Repeat step 2 and notice the value is now 7.

12. Try to create a patron in Intranet and OPAC with a password less
than 7 characters and notice that a red message is displayed by the
input telling you that the password must be 7 characters minimum length

Sponsored-By: Catalyst IT

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Nov 24 02:05:12 2017
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 24 Nov 2017 01:05:12 +0000
Subject: [Koha-bugs] [Bug 18308] Default value of minPasswordLength should
	be increased
In-Reply-To: <bug-18308-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-18308-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-18308-70-IDL8Zjrm0Y@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18308

Alex Buckley <alexbuckley at catalyst.net.nz> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #69321|0                           |1
        is obsolete|                            |

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Nov 24 02:05:37 2017
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 24 Nov 2017 01:05:37 +0000
Subject: [Koha-bugs] [Bug 18308] Default value of minPasswordLength should
	be increased
In-Reply-To: <bug-18308-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-18308-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-18308-70-b0jdzg2xN2@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18308

--- Comment #17 from Alex Buckley <alexbuckley at catalyst.net.nz> ---
Created attachment 69324
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=69324&action=edit
Bug 18308 - Added warning and dialog alert

If an institution has a minPasswordLength which is < 8 characters then a
warning
will be set (which is visible in the intranet-error.log) and a dialog
alert div will display the warning to the user in the memberentry.pl
page in the intranet.

Test plan:
1. Ensure that your minPasswordLength is set to less than 8 characters.
This replicates the use case that a Koha instance is existing (i.e. not
a new Koha instance) and not gone through the password length step of
the onboarding tool (previous patch on this bug report) or that the
institituion is new but set a password length of less than 8 in the
onboarding tool

2. Go to the memberentry.pl page and notice that there is no warning
at the top of the page informing you that your minPasswordLength is less
than 8

3. Apply this patch

4. Refresh the memberentry.pl page and notice that there is a yellow
warning at the top of the page informing you that your minPasswordLength
syspref is less than 8

Sponsored-By: Catalyst IT

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Nov 24 02:07:43 2017
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 24 Nov 2017 01:07:43 +0000
Subject: [Koha-bugs] [Bug 18308] Default value of minPasswordLength should
	be increased
In-Reply-To: <bug-18308-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-18308-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-18308-70-tzngXHAroX@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18308

Alex Buckley <alexbuckley at catalyst.net.nz> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Failed QA                   |Needs Signoff

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Nov 24 02:53:45 2017
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 24 Nov 2017 01:53:45 +0000
Subject: [Koha-bugs] [Bug 19523] Koha:: Cache changes not passed to all
 plack workers with in-memory caching.
In-Reply-To: <bug-19523-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-19523-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-19523-70-OGLwJyrjNR@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19523

--- Comment #2 from Aleisha Amohia <aleisha at catalyst.net.nz> ---
Created attachment 69325
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=69325&action=edit
Bug 19532: Some fiddly fixes

Little typos etc

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.

From bugzilla-daemon at bugs.koha-community.org  Fri Nov 24 06:43:55 2017
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 24 Nov 2017 05:43:55 +0000
Subject: [Koha-bugs] [Bug 16330] REST API: add routes to add,
	update and delete patrons
In-Reply-To: <bug-16330-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-16330-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-16330-70-lgJJ6VgtvZ@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16330

Bob Birchall <bob at calyx.net.au> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |bob at calyx.net.au

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Nov 24 07:33:17 2017
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 24 Nov 2017 06:33:17 +0000
Subject: [Koha-bugs] [Bug 19688] New: OpacHiddenItems itype problems
Message-ID: <bug-19688-70@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19688

            Bug ID: 19688
           Summary: OpacHiddenItems itype problems
 Change sponsored?: ---
           Product: Koha
           Version: 16.11
          Hardware: All
                OS: All
            Status: NEW
          Severity: critical
          Priority: P5 - low
         Component: OPAC
          Assignee: oleonard at myacpl.org
          Reporter: kohadevinim at devinim.com.tr
        QA Contact: testopia at bugs.koha-community.org

I put the itype constraint to OpacHiddenItems of systempreferences.
Opac says that the result of the scan is not found if itype constraint finds
the first page.
There are actually 375 results.
When I activate the OpacHiddenItems profile, it should give 260 results.
But, the result is not found because the first 20 results are also included in
itype OpacHiddenItems.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Nov 24 07:47:29 2017
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 24 Nov 2017 06:47:29 +0000
Subject: [Koha-bugs] [Bug 19675] Cannot save notices when setting the
 TranslateNotices preference
In-Reply-To: <bug-19675-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-19675-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-19675-70-YjQeCno3ts@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19675

Magnus Enger <magnus at libriotech.no> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |magnus at libriotech.no

--- Comment #1 from Magnus Enger <magnus at libriotech.no> ---
Could you please attach the diff as a Git patch? There are some good tips about
the easiest way to do that here:
https://wiki.koha-community.org/wiki/Git_bz_configuration

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Nov 24 07:59:39 2017
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 24 Nov 2017 06:59:39 +0000
Subject: [Koha-bugs] [Bug 19655] To.json doesn't escape newlines which can
 create invalid JSON
In-Reply-To: <bug-19655-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-19655-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-19655-70-Opo6VZUh17@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19655

Marcel de Rooy <m.de.rooy at rijksmuseum.nl> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #69244|0                           |1
        is obsolete|                            |

--- Comment #3 from Marcel de Rooy <m.de.rooy at rijksmuseum.nl> ---
Created attachment 69326
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=69326&action=edit
Bug 19655 - To.json doesn't escape newlines which can create invalid JSON

JSON does not allow real line-breaks. If a field contains them and they are not
escaped, a JSON parser will be unable to convert the stringified JSON back into
an object.

This is clearly exemplified by the guarantor search, where a multi-line note on
the guarantor's record will break the ability to select that guarantor.

Test Plan:
1) Create Patron A with a "Circulation note" that has multiple lines in it
2) Create Patron B
3) Attempt to set Patron A to be the guarantor for Patron B
4) Note selecting the patron does nothing
5) Apply this patch
6) Repeat step 3
7) Selecting the guarantor now works!

Signed-off-by: Simon Pouchol <simon.pouchol at biblibre.com>

Signed-off-by: Marcel de Rooy <m.de.rooy at rijksmuseum.nl>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Nov 24 07:59:37 2017
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 24 Nov 2017 06:59:37 +0000
Subject: [Koha-bugs] [Bug 19655] To.json doesn't escape newlines which can
 create invalid JSON
In-Reply-To: <bug-19655-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-19655-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-19655-70-WTaOj94izA@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19655

Marcel de Rooy <m.de.rooy at rijksmuseum.nl> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Signed Off                  |Passed QA
   Patch complexity|---                         |Trivial patch

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Nov 24 07:59:51 2017
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 24 Nov 2017 06:59:51 +0000
Subject: [Koha-bugs] [Bug 19655] To.json doesn't escape newlines which can
 create invalid JSON
In-Reply-To: <bug-19655-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-19655-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-19655-70-2D9SANBCpl@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19655

Marcel de Rooy <m.de.rooy at rijksmuseum.nl> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
         QA Contact|testopia at bugs.koha-communit |m.de.rooy at rijksmuseum.nl
                   |y.org                       |
                 CC|                            |m.de.rooy at rijksmuseum.nl

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Nov 24 08:10:41 2017
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 24 Nov 2017 07:10:41 +0000
Subject: [Koha-bugs] [Bug 19651] SIP/ILS/Item missing title
In-Reply-To: <bug-19651-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-19651-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-19651-70-4JmvDmiA0u@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19651

Marcel de Rooy <m.de.rooy at rijksmuseum.nl> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
   Patch complexity|---                         |Trivial patch
             Status|Signed Off                  |Passed QA

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Nov 24 08:10:43 2017
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 24 Nov 2017 07:10:43 +0000
Subject: [Koha-bugs] [Bug 19651] SIP/ILS/Item missing title
In-Reply-To: <bug-19651-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-19651-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-19651-70-GmZT8vTDg1@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19651

--- Comment #5 from Marcel de Rooy <m.de.rooy at rijksmuseum.nl> ---
Created attachment 69327
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=69327&action=edit
Bug 19651: SIP/ILS/Item misses title and author

Signed-off-by: Benjamin Rokseth <bensinober at gmail.com>

Signed-off-by: Marcel de Rooy <m.de.rooy at rijksmuseum.nl>
Amended $item->biblio by $biblio.

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Nov 24 08:11:11 2017
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 24 Nov 2017 07:11:11 +0000
Subject: [Koha-bugs] [Bug 19651] SIP/ILS/Item missing title
In-Reply-To: <bug-19651-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-19651-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-19651-70-03LVWykAMV@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19651

Marcel de Rooy <m.de.rooy at rijksmuseum.nl> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |m.de.rooy at rijksmuseum.nl
         QA Contact|testopia at bugs.koha-communit |m.de.rooy at rijksmuseum.nl
                   |y.org                       |
           Assignee|koha-bugs at lists.koha-commun |stefan.berndtsson at ub.gu.se
                   |ity.org                     |

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Nov 24 08:11:27 2017
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 24 Nov 2017 07:11:27 +0000
Subject: [Koha-bugs] [Bug 19651] SIP/ILS/Item missing title
In-Reply-To: <bug-19651-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-19651-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-19651-70-FXESV4p6S8@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19651

Marcel de Rooy <m.de.rooy at rijksmuseum.nl> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #69303|0                           |1
        is obsolete|                            |

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Nov 24 09:11:15 2017
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 24 Nov 2017 08:11:15 +0000
Subject: [Koha-bugs] [Bug 19596] Internal server error if open order with
 deleted biblio / null biblionumber
In-Reply-To: <bug-19596-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-19596-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-19596-70-X6z0BjyIkH@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19596

Marcel de Rooy <m.de.rooy at rijksmuseum.nl> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
   Patch complexity|---                         |Trivial patch
             Status|Signed Off                  |Passed QA

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Nov 24 09:11:27 2017
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 24 Nov 2017 08:11:27 +0000
Subject: [Koha-bugs] [Bug 19596] Internal server error if open order with
 deleted biblio / null biblionumber
In-Reply-To: <bug-19596-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-19596-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-19596-70-PLyJD2oNpR@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19596

Marcel de Rooy <m.de.rooy at rijksmuseum.nl> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |m.de.rooy at rijksmuseum.nl
         QA Contact|testopia at bugs.koha-communit |m.de.rooy at rijksmuseum.nl
                   |y.org                       |

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Nov 24 09:11:18 2017
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 24 Nov 2017 08:11:18 +0000
Subject: [Koha-bugs] [Bug 19596] Internal server error if open order with
 deleted biblio / null biblionumber
In-Reply-To: <bug-19596-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-19596-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-19596-70-J80MSuGTVg@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19596

Marcel de Rooy <m.de.rooy at rijksmuseum.nl> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #69242|0                           |1
        is obsolete|                            |

--- Comment #6 from Marcel de Rooy <m.de.rooy at rijksmuseum.nl> ---
Created attachment 69328
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=69328&action=edit
Bug 19596 - Don't try to get hold or items count for non-existent biblios

Patch applies and works as expected.

Signed-off-by: Dilan Johnpull? <dilan at calyx.net.au>

Signed-off-by: Marcel de Rooy <m.de.rooy at rijksmuseum.nl>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Nov 24 09:23:23 2017
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 24 Nov 2017 08:23:23 +0000
Subject: [Koha-bugs] [Bug 19683] Export.pl does not populate the Authority
 Types dropdown correctly
In-Reply-To: <bug-19683-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-19683-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-19683-70-vrD8yABQOr@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19683

Marcel de Rooy <m.de.rooy at rijksmuseum.nl> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
   Patch complexity|---                         |Trivial patch
             Status|Signed Off                  |Passed QA

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Nov 24 09:23:26 2017
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 24 Nov 2017 08:23:26 +0000
Subject: [Koha-bugs] [Bug 19683] Export.pl does not populate the Authority
 Types dropdown correctly
In-Reply-To: <bug-19683-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-19683-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-19683-70-R9BdEaVjry@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19683

Marcel de Rooy <m.de.rooy at rijksmuseum.nl> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #69300|0                           |1
        is obsolete|                            |

--- Comment #3 from Marcel de Rooy <m.de.rooy at rijksmuseum.nl> ---
Created attachment 69329
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=69329&action=edit
Bug 19683 - Fix authority types in tools/export template

Fixes the bug by correcting the variable names in the template.

To test:
1) Tools > Export > Export authority records
2) Authority Types dropdown is not empty

Signed-off-by: Claire Gravely <claire.gravely at bsz-bw.de>

Signed-off-by: Marcel de Rooy <m.de.rooy at rijksmuseum.nl>
Amended: Changing the export script and unblessing is not needed.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Nov 24 09:23:53 2017
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 24 Nov 2017 08:23:53 +0000
Subject: [Koha-bugs] [Bug 19683] Export.pl does not populate the Authority
 Types dropdown correctly
In-Reply-To: <bug-19683-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-19683-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-19683-70-RTNz26i8cf@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19683

Marcel de Rooy <m.de.rooy at rijksmuseum.nl> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |m.de.rooy at rijksmuseum.nl
         QA Contact|testopia at bugs.koha-communit |m.de.rooy at rijksmuseum.nl
                   |y.org                       |
           Severity|minor                       |normal

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Nov 24 09:32:51 2017
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 24 Nov 2017 08:32:51 +0000
Subject: [Koha-bugs] [Bug 19646] value_builder marc21_linking_section
	template is broken
In-Reply-To: <bug-19646-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-19646-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-19646-70-g3zISUwwBR@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19646

Marcel de Rooy <m.de.rooy at rijksmuseum.nl> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #69194|0                           |1
        is obsolete|                            |

--- Comment #3 from Marcel de Rooy <m.de.rooy at rijksmuseum.nl> ---
Created attachment 69330
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=69330&action=edit
Bug 19646: fix value_builder marc21_linking_section template

When using marc21_linking_section cataloging plugin, you get the error :
Template process failed: undef error - The method selected is not
covered by tests! at /home/koha/src/C4/Templates.pm line 122.

It commes from [% IF ( itypeloo.selected ) %], selected is not defined
in itypeloo.

This patch removes this condition because all item types are fetched
from database, there is not one selected. It sets "All item types" as
selected. Also correctes two errors in HTML : ending form and div,
"<a_class=" instead of "<a class="

Test plan :
1) Use a MARC21 database
2) Define marc21_linking_section cataloging plugin in framework, on
   773$t for example
3) Create a new biblio record
4) Click on icon in 773$t
5) Check plugin works fine

Signed-off-by: Owen Leonard <oleonard at myacpl.org>

Signed-off-by: Marcel de Rooy <m.de.rooy at rijksmuseum.nl>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Nov 24 09:32:48 2017
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 24 Nov 2017 08:32:48 +0000
Subject: [Koha-bugs] [Bug 19646] value_builder marc21_linking_section
	template is broken
In-Reply-To: <bug-19646-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-19646-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-19646-70-cN4HWnPsl3@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19646

Marcel de Rooy <m.de.rooy at rijksmuseum.nl> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Signed Off                  |Passed QA

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Nov 24 09:32:56 2017
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 24 Nov 2017 08:32:56 +0000
Subject: [Koha-bugs] [Bug 19646] value_builder marc21_linking_section
	template is broken
In-Reply-To: <bug-19646-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-19646-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-19646-70-rzfQAj5uLx@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19646

--- Comment #4 from Marcel de Rooy <m.de.rooy at rijksmuseum.nl> ---
Created attachment 69331
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=69331&action=edit
Bug 19646: (QA follow-up) Fix tab character

Resolve qa tools warning:
 FAIL  
koha-tmpl/intranet-tmpl/prog/en/modules/cataloguing/value_builder/marc21_linking_section.tt
   FAIL   forbidden patterns
                forbidden pattern: tab char (line 172)

Signed-off-by: Marcel de Rooy <m.de.rooy at rijksmuseum.nl>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Nov 24 09:33:29 2017
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 24 Nov 2017 08:33:29 +0000
Subject: [Koha-bugs] [Bug 19646] value_builder marc21_linking_section
	template is broken
In-Reply-To: <bug-19646-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-19646-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-19646-70-2JQhCRbaxC@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19646

Marcel de Rooy <m.de.rooy at rijksmuseum.nl> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
         QA Contact|testopia at bugs.koha-communit |m.de.rooy at rijksmuseum.nl
                   |y.org                       |

--- Comment #5 from Marcel de Rooy <m.de.rooy at rijksmuseum.nl> ---
Changes do not seem to affect translation.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Nov 24 09:41:42 2017
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 24 Nov 2017 08:41:42 +0000
Subject: [Koha-bugs] [Bug 19689] New: Koha Offline Circulation Firefox
 plugin sends entries with wrong branchcode without error
Message-ID: <bug-19689-70@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19689

            Bug ID: 19689
           Summary: Koha Offline Circulation Firefox plugin sends entries
                    with wrong branchcode without error
 Change sponsored?: ---
           Product: Koha
           Version: master
          Hardware: All
                OS: All
            Status: NEW
          Severity: enhancement
          Priority: P5 - low
         Component: Circulation
          Assignee: koha-bugs at lists.koha-community.org
          Reporter: katrin.fischer at bsz-bw.de
        QA Contact: testopia at bugs.koha-community.org
                CC: gmcharlt at gmail.com, kyle.m.hall at gmail.com

The problem that appears most often with the Koha Offline Circulation Plugin is
that the libraries enter the wrong branchcode into the configuration. The
plugin will send those entries to Koha and they are added to the
pending_offline_operations table, but can't be seen in the GUI.
It would be nice if the tool showed an error message instead as the only way to
fix those entries is with SQL.

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Nov 24 09:41:56 2017
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 24 Nov 2017 08:41:56 +0000
Subject: [Koha-bugs] [Bug 19689] Koha Offline Circulation Firefox plugin
 sends entries with wrong branchcode without error
In-Reply-To: <bug-19689-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-19689-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-19689-70-WsZ0VqG0Ls@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19689

Katrin Fischer <katrin.fischer at bsz-bw.de> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |matthias.meusburger at biblibr
                   |                            |e.com

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Nov 24 10:24:40 2017
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 24 Nov 2017 09:24:40 +0000
Subject: [Koha-bugs] [Bug 19689] Koha Offline Circulation Firefox plugin
 sends entries with wrong branchcode without error
In-Reply-To: <bug-19689-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-19689-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-19689-70-ddsKkh8krs@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19689

--- Comment #1 from Matthias Meusburger <matthias.meusburger at biblibre.com> ---
That would need some work in Koha.

Either by having a REST api that would allow the KOCT plugin to check if the
branchcode is valid when saving the extension preferences.

Or by modifying the *OfflineOperation functions in C4/Circulation.pm to return
an error when the branchcode is invalid.

By the way, another enhancement would be to return appropriate http error codes
(like 401 when the authentication fails) because currently Koha always returns
200.

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.

From bugzilla-daemon at bugs.koha-community.org  Fri Nov 24 10:26:48 2017
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 24 Nov 2017 09:26:48 +0000
Subject: [Koha-bugs] [Bug 19689] Koha Offline Circulation Firefox plugin
 sends entries with wrong branchcode without error
In-Reply-To: <bug-19689-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-19689-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-19689-70-B1bP7cra9B@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19689

--- Comment #2 from Matthias Meusburger <matthias.meusburger at biblibre.com> ---

> Either by having a REST api that would allow the KOCT plugin to check if the
> branchcode is valid when saving the extension preferences.

Or better: by having a REST api that would allow to retrieve branches, so the
extension can have them in a dropdown list.

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.

From bugzilla-daemon at bugs.koha-community.org  Fri Nov 24 10:30:33 2017
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 24 Nov 2017 09:30:33 +0000
Subject: [Koha-bugs] [Bug 19640] IdRef webservice display is broken
In-Reply-To: <bug-19640-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-19640-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-19640-70-zSQB5Fp5Xn@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19640

Marcel de Rooy <m.de.rooy at rijksmuseum.nl> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Signed Off                  |Passed QA

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Nov 24 10:30:36 2017
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 24 Nov 2017 09:30:36 +0000
Subject: [Koha-bugs] [Bug 19640] IdRef webservice display is broken
In-Reply-To: <bug-19640-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-19640-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-19640-70-60qqZrsFFm@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19640

Marcel de Rooy <m.de.rooy at rijksmuseum.nl> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #69196|0                           |1
        is obsolete|                            |

--- Comment #4 from Marcel de Rooy <m.de.rooy at rijksmuseum.nl> ---
Created attachment 69332
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=69332&action=edit
Bug 19640: fix OPAC IdRef webservice display

The OPAC webservice IdRef display was broken.
The call returns results but citations where empty.
Maybe the webservice has changed.

This patch corrects the fetch of datas in result.
Also fixes a small HTML missing tag tr.
Also adds a comment with link to official doc :
http://documentation.abes.fr/aideidrefdeveloppeur/index.html#MicroWebBiblio

Test plan :
1) Enable system preference IdRef
2) Choose an existing PPN like 032581270
3) Look result on : https://www.idref.fr/services/biblio/032581270.json
4) Call in OPAC website : /cgi-bin/koha/opac-idref.pl?unimarc3=032581270
5) Without patch you see only one role containing empty rows
6) With patch you see all roles with correct rows

Signed-off-by: Simon Pouchol <simon.pouchol at biblibre.com>

Signed-off-by: Marcel de Rooy <m.de.rooy at rijksmuseum.nl>
Amended: removed unused @unimarc3 (not to be confused with $unimarc3).

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Nov 24 10:31:11 2017
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 24 Nov 2017 09:31:11 +0000
Subject: [Koha-bugs] [Bug 19640] IdRef webservice display is broken
In-Reply-To: <bug-19640-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-19640-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-19640-70-6FO6rPIOjY@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19640

Marcel de Rooy <m.de.rooy at rijksmuseum.nl> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |m.de.rooy at rijksmuseum.nl
           Severity|minor                       |normal
         QA Contact|testopia at bugs.koha-communit |m.de.rooy at rijksmuseum.nl
                   |y.org                       |

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Nov 24 10:33:12 2017
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 24 Nov 2017 09:33:12 +0000
Subject: [Koha-bugs] [Bug 19640] IdRef webservice display is broken
In-Reply-To: <bug-19640-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-19640-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-19640-70-govALdp4XB@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19640

--- Comment #5 from Marcel de Rooy <m.de.rooy at rijksmuseum.nl> ---
Does not seem to affect translation.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Nov 24 10:39:12 2017
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 24 Nov 2017 09:39:12 +0000
Subject: [Koha-bugs] [Bug 19681] label-item-search.pl result count
 formatting error when there is only one page
In-Reply-To: <bug-19681-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-19681-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-19681-70-1AtkZ3QDJk@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19681

Marcel de Rooy <m.de.rooy at rijksmuseum.nl> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Signed Off                  |Passed QA

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Nov 24 10:39:14 2017
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 24 Nov 2017 09:39:14 +0000
Subject: [Koha-bugs] [Bug 19681] label-item-search.pl result count
 formatting error when there is only one page
In-Reply-To: <bug-19681-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-19681-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-19681-70-xFWNysX6ka@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19681

Marcel de Rooy <m.de.rooy at rijksmuseum.nl> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #69294|0                           |1
        is obsolete|                            |

--- Comment #4 from Marcel de Rooy <m.de.rooy at rijksmuseum.nl> ---
Created attachment 69333
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=69333&action=edit
Bug 19681: Correct result count formatting

This simply passes the missing information to the template.

Test plan:
0) Apply patch
1) Go to Tools > Label creator > New > Label batch
2) Press 'Add items'
3) Do a search that will return few items
4) The result count will read "Results 1 through X of X"

Signed-off-by: Owen Leonard <oleonard at myacpl.org>

Signed-off-by: Marcel de Rooy <m.de.rooy at rijksmuseum.nl>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Nov 24 10:39:30 2017
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 24 Nov 2017 09:39:30 +0000
Subject: [Koha-bugs] [Bug 19681] label-item-search.pl result count
 formatting error when there is only one page
In-Reply-To: <bug-19681-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-19681-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-19681-70-H0Deznl3Ve@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19681

Marcel de Rooy <m.de.rooy at rijksmuseum.nl> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
         QA Contact|testopia at bugs.koha-communit |m.de.rooy at rijksmuseum.nl
                   |y.org                       |
                 CC|                            |m.de.rooy at rijksmuseum.nl

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Nov 24 11:03:37 2017
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 24 Nov 2017 10:03:37 +0000
Subject: [Koha-bugs] [Bug 4319] waiting items cannot be reserved
In-Reply-To: <bug-4319-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-4319-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-4319-70-k1uFmyDpmS@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=4319

--- Comment #54 from Marcel de Rooy <m.de.rooy at rijksmuseum.nl> ---
QA: Looking here now

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Nov 24 11:35:13 2017
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 24 Nov 2017 10:35:13 +0000
Subject: [Koha-bugs] [Bug 4319] waiting items cannot be reserved
In-Reply-To: <bug-4319-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-4319-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-4319-70-xxroKJ7i2d@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=4319

--- Comment #55 from Marcel de Rooy <m.de.rooy at rijksmuseum.nl> ---
+    OPACShowBarcode => C4::Context->preference("OPACShowBarcode")

Regression from a rebase ?

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Nov 24 12:15:48 2017
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 24 Nov 2017 11:15:48 +0000
Subject: [Koha-bugs] [Bug 12497] Make OPAC search history feature accessible
 when it should
In-Reply-To: <bug-12497-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-12497-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-12497-70-ehXBkn6Ig4@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12497

--- Comment #6 from Victor Grousset/tuxayo <victor.grousset at biblibre.com> ---
Created attachment 69334
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=69334&action=edit
Bug 12497: Fix OPAC search history reachable by URL even when disabled

Test plan:
1. Set EnableOpacSearchHistory syspref to "Keep"
2. Make a search in the OPAC
3. Go to /cgi-bin/koha/opac-search-history.pl
4. Set the EnableOpacSearchHistory syspref to "Don't keep"
5. Refresh the OPAC page to show that history is still accessible
6. Apply the patch
7. Refresh the OPAC page, you should end on the 404 page
8. Set EnableOpacSearchHistory syspref to "Keep"
9. Go to /cgi-bin/koha/opac-search-history.pl which should be reachable

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Nov 24 12:17:09 2017
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 24 Nov 2017 11:17:09 +0000
Subject: [Koha-bugs] [Bug 12497] Make OPAC search history feature accessible
 when it should
In-Reply-To: <bug-12497-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-12497-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-12497-70-OOjBPS5EMd@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12497

Victor Grousset/tuxayo <victor.grousset at biblibre.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|ASSIGNED                    |Needs Signoff

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Nov 24 12:29:24 2017
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 24 Nov 2017 11:29:24 +0000
Subject: [Koha-bugs] [Bug 19690] New: Smart rules: Term "If any unavailable"
 is confusing and just means No
Message-ID: <bug-19690-70@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19690

            Bug ID: 19690
           Summary: Smart rules: Term "If any unavailable" is confusing
                    and just means No
 Change sponsored?: ---
           Product: Koha
           Version: master
          Hardware: All
                OS: All
            Status: NEW
          Severity: normal
          Priority: P5 - low
         Component: System Administration
          Assignee: koha-bugs at lists.koha-community.org
          Reporter: m.de.rooy at rijksmuseum.nl
        QA Contact: testopia at bugs.koha-community.org
                CC: gmcharlt at gmail.com

Pertains to Allow on shelf holds.
Triggered by looking at bug 4319.

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Nov 24 12:29:50 2017
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 24 Nov 2017 11:29:50 +0000
Subject: [Koha-bugs] [Bug 4319] waiting items cannot be reserved
In-Reply-To: <bug-4319-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-4319-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-4319-70-NJkzp75LTU@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=4319

Marcel de Rooy <m.de.rooy at rijksmuseum.nl> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
           See Also|                            |https://bugs.koha-community
                   |                            |.org/bugzilla3/show_bug.cgi
                   |                            |?id=19690

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Nov 24 12:29:50 2017
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 24 Nov 2017 11:29:50 +0000
Subject: [Koha-bugs] [Bug 19690] Smart rules: Term "If any unavailable" is
 confusing and just means No
In-Reply-To: <bug-19690-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-19690-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-19690-70-LtXKuwzAxJ@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19690

Marcel de Rooy <m.de.rooy at rijksmuseum.nl> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
           See Also|                            |https://bugs.koha-community
                   |                            |.org/bugzilla3/show_bug.cgi
                   |                            |?id=4319

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.

From bugzilla-daemon at bugs.koha-community.org  Fri Nov 24 12:38:04 2017
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 24 Nov 2017 11:38:04 +0000
Subject: [Koha-bugs] [Bug 4319] waiting items cannot be reserved
In-Reply-To: <bug-4319-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-4319-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-4319-70-EIkpDGf8pP@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=4319

Marcel de Rooy <m.de.rooy at rijksmuseum.nl> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Signed Off                  |BLOCKED

--- Comment #56 from Marcel de Rooy <m.de.rooy at rijksmuseum.nl> ---
It would be more consistent if we should use IsItemOnHoldAndFound in
IsAvailableForItemLevelRequest instead of a Koha::Holds->search. We actually
should adjust that routine. It does the same.
The formerly used GetReserveStatus call returns false for transit holds. Now we
check the count on W and T. This actually makes me think that the report name
should reflect that; the real change is on the transit side.

Cannot finish this session now. Will try to finish monday. Parking it in
Blocked.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Nov 24 12:50:26 2017
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 24 Nov 2017 11:50:26 +0000
Subject: [Koha-bugs] [Bug 19690] Smart rules: Term "If any unavailable" is
 confusing and just means No
In-Reply-To: <bug-19690-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-19690-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-19690-70-IkAZKmuycL@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19690

Koha Team Lyon 3 <koha at univ-lyon3.fr> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |koha at univ-lyon3.fr

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Nov 24 13:22:37 2017
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 24 Nov 2017 12:22:37 +0000
Subject: [Koha-bugs] [Bug 18407] REST API: Include renewability information
	on checkouts
In-Reply-To: <bug-18407-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-18407-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-18407-70-OOkpAr8vzU@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18407

Tom?s Cohen Arazi <tomascohen at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |tomascohen at gmail.com
            Version|unspecified                 |master

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Nov 24 13:31:05 2017
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 24 Nov 2017 12:31:05 +0000
Subject: [Koha-bugs] [Bug 19661] Funds endpoint
In-Reply-To: <bug-19661-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-19661-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-19661-70-dp7t1WjHwQ@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19661

Tom?s Cohen Arazi <tomascohen at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |tomascohen at gmail.com
           Assignee|koha-bugs at lists.koha-commun |matthias.meusburger at biblibr
                   |ity.org                     |e.com

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Nov 24 14:58:25 2017
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 24 Nov 2017 13:58:25 +0000
Subject: [Koha-bugs] [Bug 19689] Koha Offline Circulation Firefox plugin
 sends entries with wrong branchcode without error
In-Reply-To: <bug-19689-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-19689-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-19689-70-0bH9ibwc63@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19689

--- Comment #3 from Katrin Fischer <katrin.fischer at bsz-bw.de> ---
Both sound good to me - error codes might be the easier to do for now.

We had at least 3 libraries running into this now.

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Nov 24 15:46:47 2017
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 24 Nov 2017 14:46:47 +0000
Subject: [Koha-bugs] [Bug 18017] [Unimarc] Importing biblios from Z39.50
 servers duplicates related authorities
In-Reply-To: <bug-18017-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-18017-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-18017-70-gENSdZmK2r@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18017

Victor Grousset/tuxayo <victor.grousset at biblibre.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
            Version|master                      |unspecified
                 CC|                            |victor.grousset at biblibre.co
                   |                            |m

--- Comment #5 from Victor Grousset/tuxayo <victor.grousset at biblibre.com> ---
After applying the patch, when reimporting, the authority of the main author is
still duplicated. (different id on the "Main Author" link)

I even re-indexed authorities after applying the patch.
./src/misc/migration_tools/rebuild_zebra.pl -r -a -v

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Nov 24 16:04:07 2017
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 24 Nov 2017 15:04:07 +0000
Subject: [Koha-bugs] [Bug 19691] New: Enforce OPAC SEARCH LIMIT server-side
Message-ID: <bug-19691-70@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19691

            Bug ID: 19691
           Summary: Enforce OPAC SEARCH LIMIT server-side
 Change sponsored?: ---
           Product: Koha
           Version: master
          Hardware: All
                OS: All
            Status: ASSIGNED
          Severity: enhancement
          Priority: P5 - low
         Component: Searching
          Assignee: david.bourgault at inlibro.com
          Reporter: david.bourgault at inlibro.com
        QA Contact: testopia at bugs.koha-community.org

Current behavior of the OPAC_SEARCH_LIMIT variable (set in httpd.conf) is to
add a hidden HTML input in masthead.inc.

This works, but makes it easy to override the limit by altering the URL.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Nov 24 16:21:18 2017
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 24 Nov 2017 15:21:18 +0000
Subject: [Koha-bugs] [Bug 19691] Enforce OPAC SEARCH LIMIT server-side
In-Reply-To: <bug-19691-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-19691-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-19691-70-xtU12SZtyS@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19691

David Bourgault <david.bourgault at inlibro.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
   Patch complexity|---                         |Small patch
             Status|ASSIGNED                    |Needs Signoff

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Nov 24 16:21:20 2017
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 24 Nov 2017 15:21:20 +0000
Subject: [Koha-bugs] [Bug 19691] Enforce OPAC SEARCH LIMIT server-side
In-Reply-To: <bug-19691-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-19691-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-19691-70-5W7EcUwH3P@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19691

--- Comment #1 from David Bourgault <david.bourgault at inlibro.com> ---
Created attachment 69335
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=69335&action=edit
Bug 19691 - Move code to opac-search.pl

Removes the hidden input from masthead.inc, and adds a line to opac-search.pl
to enforce the limit.

Test plan:
Before:
0) Set OPAC_SEARCH_LIMIT and OPAC_LIMIT_OVERRIDE to valid values in
koha-httpd.conf (they should be commented)
1) Reload apache
2) Perform a search in the OPAC. You'll see the limit you specified appended to
the URL and reflected in the results.
3) Manually remove the limit from the URL and load the page; the search results
will not reflect the limit.

After:
0) With the same apache config
1) Perform a search from the OPAC. The limit will not show up in the URL, but
will be reflected in the search results. There should be no way of
circumventing the limit.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Nov 24 16:21:33 2017
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 24 Nov 2017 15:21:33 +0000
Subject: [Koha-bugs] [Bug 19691] Enforce OPAC SEARCH LIMIT server-side
In-Reply-To: <bug-19691-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-19691-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-19691-70-7AE5Iz5GSP@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19691

David Bourgault <david.bourgault at inlibro.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |david.bourgault at inlibro.com

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Nov 24 16:51:55 2017
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 24 Nov 2017 15:51:55 +0000
Subject: [Koha-bugs] [Bug 19692] New: Unclosed div in opac-shelves.tt
Message-ID: <bug-19692-70@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19692

            Bug ID: 19692
           Summary: Unclosed div in opac-shelves.tt
 Change sponsored?: ---
           Product: Koha
           Version: master
          Hardware: All
                OS: All
            Status: NEW
          Severity: trivial
          Priority: P5 - low
         Component: Templates
          Assignee: oleonard at myacpl.org
          Reporter: victor.grousset at biblibre.com
        QA Contact: testopia at bugs.koha-community.org

It was found when customizing an instance.

The comment makes it clear that it should be a closing tag.

http://git.koha-community.org/gitweb/?p=koha.git;a=blob;f=koha-tmpl/opac-tmpl/bootstrap/en/modules/opac-shelves.tt;hb=570eb4026642f71e462c7746a9c91721aa9334c1#l725

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Nov 24 16:52:07 2017
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 24 Nov 2017 15:52:07 +0000
Subject: [Koha-bugs] [Bug 19692] Unclosed div in opac-shelves.tt
In-Reply-To: <bug-19692-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-19692-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-19692-70-jLigrplbA0@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19692

Victor Grousset/tuxayo <victor.grousset at biblibre.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
           Assignee|oleonard at myacpl.org         |victor.grousset at biblibre.co
                   |                            |m
             Status|NEW                         |ASSIGNED

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Nov 24 17:02:58 2017
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 24 Nov 2017 16:02:58 +0000
Subject: [Koha-bugs] [Bug 19692] Unclosed div in opac-shelves.tt
In-Reply-To: <bug-19692-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-19692-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-19692-70-t4suTf1ogF@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19692

--- Comment #1 from Victor Grousset/tuxayo <victor.grousset at biblibre.com> ---
Created attachment 69336
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=69336&action=edit
Bug 19692 : fix unclosed div in opac-shelves.tt

Test plan:
1. set syspref OpacKohaUrl to "Show"
2. Log into the OPAC
3. /cgi-bin/koha/opac-shelves.pl
4. Notice that "Powered by Koha" is not in the footer in this page.
  When on the other tabs it's in the footer (out of .main)
5. Apply this patch
6. Notice that "Powered by Koha" now in the footer in the "your lists" page

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Nov 24 17:04:51 2017
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 24 Nov 2017 16:04:51 +0000
Subject: [Koha-bugs] [Bug 19692] Unclosed div in opac-shelves.tt
In-Reply-To: <bug-19692-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-19692-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-19692-70-VSvw0MHFCN@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19692

Victor Grousset/tuxayo <victor.grousset at biblibre.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|ASSIGNED                    |Needs Signoff

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Nov 24 18:16:02 2017
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 24 Nov 2017 17:16:02 +0000
Subject: [Koha-bugs] [Bug 16330] REST API: add routes to add,
	update and delete patrons
In-Reply-To: <bug-16330-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-16330-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-16330-70-RKvPBEpAfF@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16330

--- Comment #52 from Tom?s Cohen Arazi <tomascohen at gmail.com> ---
(In reply to Blou from comment #51)
> If i understand correctly, this patch is "In Discussion" since March(2017)
> because of "borrowernumber vs patron_id".
> 
> Is it still on?  Has it been settled?  I'd love to test (live) this code,
> but I don't want to tell our associates to deploy on a naming convention
> that will change.  
> 
> Ready to sign off...

On my opinion this patches went too far (patron modifications are a different
entity) and updates should be constrained to authorized (by permission) users.

Cleanup is needed, and migration to OpenAPI plugin too.

Will try to work on this ASAP. Anyone willing to do it or help, please pm me

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Nov 24 19:42:17 2017
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 24 Nov 2017 18:42:17 +0000
Subject: [Koha-bugs] [Bug 17051] Default order biblio subfields in framework
In-Reply-To: <bug-17051-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-17051-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-17051-70-niRd8fSgjZ@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17051

Marjorie Barry-Vila <marjorie.barry-vila at collecto.ca> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
         Resolution|---                         |DUPLICATE
             Status|NEW                         |RESOLVED

--- Comment #1 from Marjorie Barry-Vila <marjorie.barry-vila at collecto.ca> ---


*** This bug has been marked as a duplicate of bug 8976 ***

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Nov 24 19:42:17 2017
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 24 Nov 2017 18:42:17 +0000
Subject: [Koha-bugs] [Bug 8976] Default sequence of subfields in cataloguing
	editor
In-Reply-To: <bug-8976-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-8976-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-8976-70-mqaL7K2Obo@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8976

--- Comment #4 from Marjorie Barry-Vila <marjorie.barry-vila at collecto.ca> ---
*** Bug 17051 has been marked as a duplicate of this bug. ***

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Nov 24 20:19:56 2017
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 24 Nov 2017 19:19:56 +0000
Subject: [Koha-bugs] [Bug 19692] Unclosed div in opac-shelves.tt
In-Reply-To: <bug-19692-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-19692-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-19692-70-U2lTq2ozEC@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19692

Dominic Pichette <dominic.pichette at inlibro.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #69336|0                           |1
        is obsolete|                            |

--- Comment #2 from Dominic Pichette <dominic.pichette at inlibro.com> ---
Created attachment 69337
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=69337&action=edit
Bug 19692 : fix unclosed div in opac-shelves.tt

Test plan:
1. set syspref OpacKohaUrl to "Show"
2. Log into the OPAC
3. /cgi-bin/koha/opac-shelves.pl
4. Notice that "Powered by Koha" is not in the footer in this page.
  When on the other tabs it's in the footer (out of .main)
5. Apply this patch
6. Notice that "Powered by Koha" now in the footer in the "your lists" page

Signed-off-by: Dominic Pichette <dominic at inlibro.com>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Nov 24 20:20:27 2017
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 24 Nov 2017 19:20:27 +0000
Subject: [Koha-bugs] [Bug 19692] Unclosed div in opac-shelves.tt
In-Reply-To: <bug-19692-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-19692-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-19692-70-B06Fff1fss@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19692

Dominic Pichette <dominic.pichette at inlibro.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Needs Signoff               |Signed Off
                 CC|                            |dominic.pichette at inlibro.co
                   |                            |m

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Nov 24 20:24:10 2017
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 24 Nov 2017 19:24:10 +0000
Subject: [Koha-bugs] [Bug 19563] Generation of sort_fields uses incorrect
	condition
In-Reply-To: <bug-19563-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-19563-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-19563-70-pRaPX6dS24@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19563

David Bourgault <david.bourgault at inlibro.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |david.bourgault at inlibro.com
             Status|Needs Signoff               |Signed Off

--- Comment #9 from David Bourgault <david.bourgault at inlibro.com> ---
Did I forget to set this as Signed-Off?

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Nov 24 20:31:50 2017
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 24 Nov 2017 19:31:50 +0000
Subject: [Koha-bugs] [Bug 17885] Koha::SearchEngine::Elasticsearch->
 reset_elasticsearch_mappings throws DBD::mysql Duplicate entry exceptions
In-Reply-To: <bug-17885-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-17885-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-17885-70-iAvU1KuxuN@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17885

David Bourgault <david.bourgault at inlibro.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #58941|0                           |1
        is obsolete|                            |

--- Comment #10 from David Bourgault <david.bourgault at inlibro.com> ---
Created attachment 69338
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=69338&action=edit
Bug 17885 - Koha::SearchEngine::Elasticsearch->reset_elasticsearch_mappings
throws DBD::mysql Duplicate entry exceptions

TEST PLAN:

a. perl -e 'use Koha::SearchEngine::Elasticsearch;
Koha::SearchEngine::Elasticsearch->reset_elasticsearch_mappings'
b. Run misc/devel/populate_db.pl on an already populated DB and you eventually
face this problem.

After this patch,
step a. works.

Signed-off-by: David Bourgault <david.bourgault at inlibro.com>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Nov 24 20:31:48 2017
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 24 Nov 2017 19:31:48 +0000
Subject: [Koha-bugs] [Bug 17885] Koha::SearchEngine::Elasticsearch->
 reset_elasticsearch_mappings throws DBD::mysql Duplicate entry exceptions
In-Reply-To: <bug-17885-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-17885-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-17885-70-sEZHCMIu0S@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17885

David Bourgault <david.bourgault at inlibro.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Needs Signoff               |Signed Off

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Nov 24 20:36:09 2017
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 24 Nov 2017 19:36:09 +0000
Subject: [Koha-bugs] [Bug 14784] Missing checkin message for debarred
 patrons when issuing rules ' fine days = 0'
In-Reply-To: <bug-14784-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-14784-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-14784-70-kNViWHHLep@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14784

David Bourgault <david.bourgault at inlibro.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
           Assignee|bouzid.fergani at inlibro.com  |david.bourgault at inlibro.com

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Nov 24 21:26:49 2017
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 24 Nov 2017 20:26:49 +0000
Subject: [Koha-bugs] [Bug 12497] Make OPAC search history feature accessible
 when it should
In-Reply-To: <bug-12497-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-12497-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-12497-70-JwKonmHhm2@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12497

David Bourgault <david.bourgault at inlibro.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #69313|0                           |1
        is obsolete|                            |

--- Comment #7 from David Bourgault <david.bourgault at inlibro.com> ---
Created attachment 69339
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=69339&action=edit
Bug 12497: Fix search history non-accessible when OPAC was private

(when the user didn't have the "borrowers" permission)

Test plan:
1. Set syspref "OpacPublic" to false (Disable)
2. Log in as a user without any permission
3. Try to access the search history. The link is next to "Log out"
4. Then you should see "Access denied"
5. Apply this patch
6. Refresh the page
7. Then you should see the search history

Signed-off-by: David Bourgault <david.bourgault at inlibro.com>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Nov 24 21:26:46 2017
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 24 Nov 2017 20:26:46 +0000
Subject: [Koha-bugs] [Bug 12497] Make OPAC search history feature accessible
 when it should
In-Reply-To: <bug-12497-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-12497-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-12497-70-EnQv6b33xh@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12497

David Bourgault <david.bourgault at inlibro.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Needs Signoff               |Signed Off

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Nov 24 21:27:00 2017
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 24 Nov 2017 20:27:00 +0000
Subject: [Koha-bugs] [Bug 12497] Make OPAC search history feature accessible
 when it should
In-Reply-To: <bug-12497-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-12497-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-12497-70-2hGiFE0xl3@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12497

David Bourgault <david.bourgault at inlibro.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #69334|0                           |1
        is obsolete|                            |

--- Comment #8 from David Bourgault <david.bourgault at inlibro.com> ---
Created attachment 69340
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=69340&action=edit
Bug 12497: Fix OPAC search history reachable by URL even when disabled

Test plan:
1. Set EnableOpacSearchHistory syspref to "Keep"
2. Make a search in the OPAC
3. Go to /cgi-bin/koha/opac-search-history.pl
4. Set the EnableOpacSearchHistory syspref to "Don't keep"
5. Refresh the OPAC page to show that history is still accessible
6. Apply the patch
7. Refresh the OPAC page, you should end on the 404 page
8. Set EnableOpacSearchHistory syspref to "Keep"
9. Go to /cgi-bin/koha/opac-search-history.pl which should be reachable

Signed-off-by: David Bourgault <david.bourgault at inlibro.com>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Nov 24 21:34:02 2017
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 24 Nov 2017 20:34:02 +0000
Subject: [Koha-bugs] [Bug 19686] objects.search helper needs a to_model param
In-Reply-To: <bug-19686-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-19686-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-19686-70-8rQh77rxlu@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19686

David Bourgault <david.bourgault at inlibro.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |david.bourgault at inlibro.com
             Status|Needs Signoff               |Patch doesn't apply

--- Comment #3 from David Bourgault <david.bourgault at inlibro.com> ---
fatal: sha1 information is lacking or useless
(t/db_dependent/Koha/REST/Plugin/Objects.t).

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Nov 24 21:51:15 2017
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 24 Nov 2017 20:51:15 +0000
Subject: [Koha-bugs] [Bug 12497] Make OPAC search history feature accessible
 when it should
In-Reply-To: <bug-12497-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-12497-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-12497-70-3eL5ePc9DO@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12497

Charles Farmer <charles.farmer at inlibro.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |charles.farmer at inlibro.com

--- Comment #9 from Charles Farmer <charles.farmer at inlibro.com> ---
Is this intended behavior to return a 404 whenever a systempreference blocks a
page in Koha? I feel like the template could simply state to users and admin
alike that search history is disabled, unless that's deemed too verbose for the
user's own good.

But it works, nonetheless, so I'm signing it off.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Nov 24 22:00:33 2017
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 24 Nov 2017 21:00:33 +0000
Subject: [Koha-bugs] [Bug 12497] Make OPAC search history feature accessible
 when it should
In-Reply-To: <bug-12497-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-12497-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-12497-70-KGPbS7oKJO@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12497

Charles Farmer <charles.farmer at inlibro.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #69339|0                           |1
        is obsolete|                            |

--- Comment #10 from Charles Farmer <charles.farmer at inlibro.com> ---
Created attachment 69341
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=69341&action=edit
Bug 12497: Fix search history non-accessible when OPAC was private

(when the user didn't have the "borrowers" permission)

Test plan:
1. Set syspref "OpacPublic" to false (Disable)
2. Log in as a user without any permission
3. Try to access the search history. The link is next to "Log out"
4. Then you should see "Access denied"
5. Apply this patch
6. Refresh the page
7. Then you should see the search history

Signed-off-by: David Bourgault <david.bourgault at inlibro.com>
Signed-off-by: Charles Farmer <charles.farmer at inLibro.com>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Nov 24 22:00:37 2017
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 24 Nov 2017 21:00:37 +0000
Subject: [Koha-bugs] [Bug 12497] Make OPAC search history feature accessible
 when it should
In-Reply-To: <bug-12497-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-12497-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-12497-70-UZmN53lij6@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12497

Charles Farmer <charles.farmer at inlibro.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #69340|0                           |1
        is obsolete|                            |

--- Comment #11 from Charles Farmer <charles.farmer at inlibro.com> ---
Created attachment 69342
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=69342&action=edit
Bug 12497: Fix OPAC search history reachable by URL even when disabled

Test plan:
1. Set EnableOpacSearchHistory syspref to "Keep"
2. Make a search in the OPAC
3. Go to /cgi-bin/koha/opac-search-history.pl
4. Set the EnableOpacSearchHistory syspref to "Don't keep"
5. Refresh the OPAC page to show that history is still accessible
6. Apply the patch
7. Refresh the OPAC page, you should end on the 404 page
8. Set EnableOpacSearchHistory syspref to "Keep"
9. Go to /cgi-bin/koha/opac-search-history.pl which should be reachable

Signed-off-by: David Bourgault <david.bourgault at inlibro.com>
Signed-off-by: Charles Farmer <charles.farmer at inLibro.com>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Nov 24 22:17:04 2017
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 24 Nov 2017 21:17:04 +0000
Subject: [Koha-bugs] [Bug 18458] Merging authority record incorrectly orders
	subfields
In-Reply-To: <bug-18458-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-18458-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-18458-70-VTnZp9jxlD@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18458

Janusz Kaczmarek <januszop at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |januszop at gmail.com

--- Comment #3 from Janusz Kaczmarek <januszop at gmail.com> ---
I would add to this: if a subfield precedes the controlled subfields (like $i
in 7XX, which comes before $a -- rare but will become more and more usual)
after merging will be moved to the end.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Nov 24 22:17:50 2017
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 24 Nov 2017 21:17:50 +0000
Subject: [Koha-bugs] [Bug 18308] Default value of minPasswordLength should
	be increased
In-Reply-To: <bug-18308-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-18308-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-18308-70-fKWmqhKmXG@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18308

Dominic Pichette <dominic.pichette at inlibro.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |dominic.pichette at inlibro.co
                   |                            |m

--- Comment #18 from Dominic Pichette <dominic.pichette at inlibro.com> ---
patch failed to install:

Applying: Bug 18308 - Added step to onboarding tool to set minPasswordLength
fatal: sha1 information is lacking or useless
(installer/data/mysql/sysprefs.sql).
error: could not build fake ancestor
Patch failed at 0001 Bug 18308 - Added step to onboarding tool to set
minPasswordLength

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Nov 24 23:28:31 2017
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 24 Nov 2017 22:28:31 +0000
Subject: [Koha-bugs] [Bug 14769] Authorities merge: Set correct indicators
 in biblio field
In-Reply-To: <bug-14769-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-14769-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-14769-70-znsdyQSoYB@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14769

Janusz Kaczmarek <januszop at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |januszop at gmail.com

--- Comment #10 from Janusz Kaczmarek <januszop at gmail.com> ---
Hello to all.  To not open a new bug I would like to submit here a patch that
should fix this painful and far-too-long-still-not-resolved issue.  The
proposed approach relies on authority records (which should be correct--that's
exactly why they are called 'authority' records).  Especially MARC 21 case, as
stated by Zeno, is more complex, specially for 6XX (2nd ind., $2 subfield etc.)

To test -- have some authority recs. with different tags (eg. 100, 130,
150), use them in biblio, especially in 6XX, 7XX (setting 2nd ind).
Have running indexer and proper value of AuthorityMergeLimit, i.e. not 0.
Then play with indicators in authorities. For MARC 21 auth used in 6XX
play also with 008/11 and 040 $f (if 008/11 set to 'z').  Have a look
at the results in biblio (see subfield $2 in MARC 21 6XX if 008/11 = z
and 040 $f defined).

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Nov 24 23:30:51 2017
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 24 Nov 2017 22:30:51 +0000
Subject: [Koha-bugs] [Bug 14769] Authorities merge: Set correct indicators
 in biblio field
In-Reply-To: <bug-14769-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-14769-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-14769-70-DLn9qHyupi@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14769

--- Comment #11 from Janusz Kaczmarek <januszop at gmail.com> ---
Created attachment 69343
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=69343&action=edit
14769: Authorities merge: Set correct indicators in biblio field

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Nov 24 23:53:21 2017
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 24 Nov 2017 22:53:21 +0000
Subject: [Koha-bugs] [Bug 14769] Authorities merge: Set correct indicators
 in biblio field
In-Reply-To: <bug-14769-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-14769-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-14769-70-22wZ2zgfA7@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14769

Janusz Kaczmarek <januszop at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|ASSIGNED                    |Needs Signoff

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Sat Nov 25 01:40:32 2017
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Sat, 25 Nov 2017 00:40:32 +0000
Subject: [Koha-bugs] [Bug 19693] New: authtypefrom incorrectly set when
 updating auth recs from file
Message-ID: <bug-19693-70@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19693

            Bug ID: 19693
           Summary: authtypefrom incorrectly set when updating auth recs
                    from file
 Change sponsored?: ---
           Product: Koha
           Version: unspecified
          Hardware: All
                OS: All
            Status: NEW
          Severity: trivial
          Priority: P5 - low
         Component: MARC Authority data support
          Assignee: koha-bugs at lists.koha-community.org
          Reporter: januszop at gmail.com
        QA Contact: testopia at bugs.koha-community.org

In those cases when authorities are updated by an external agency (or
even internally, by reviewing and correcting an exported authority file)
when the heading tag will be changed (seems odd but happens:

111 Congress ==> 110 Corporate body.Congress ;
100 Person ==> 110 Corporate body (a company named with person's name ;
151 City--object ==> 150 Object (city) etc.)

and then the authority record in Koha database will be updated with
bulkmarcimport or by calling directly ModAuthority from a custom script,
the merge function "doesn't know" that the change to the authority type 
has been made and, consequently, doesn't adequately change the tag in related
fields in biblio records (as it would if two different records 
with different authtypecode were merged with Koha interface).  

This is because at the moment when merge function is being called 
by ModAuthority
Koha::Authority::Types->find($autfrom->authtypecode)
Koha::Authority::Types->find($authto->authtypecode)
both have the same value (because $autfrom == $autfrom).

Therefore the authtype guessed from the old version of the record should
be considered.

To test:
1) have an authority record used in biblio;
   export it to file;
   change 1XX heading tag to different (but reasonable) value
   and possibly change also the content of the heading
   (one can delete also 942 but it doesn't matter);
   make bulkmarcimport.pl -a -update -file <modified_auth_file> and
   see that the tag in biblio record has not been changed (whereas
   the type of authority record did change);

2) make orders in database (so that the authority type and the tag of
the field in biblio record correspond); apply the patch;

3) repeat the test from 1).

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Sat Nov 25 01:42:57 2017
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Sat, 25 Nov 2017 00:42:57 +0000
Subject: [Koha-bugs] [Bug 19693] authtypefrom incorrectly set when updating
 auth recs from file
In-Reply-To: <bug-19693-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-19693-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-19693-70-zNN8nv7UJq@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19693

Janusz Kaczmarek <januszop at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|NEW                         |Needs Signoff
           Assignee|koha-bugs at lists.koha-commun |januszop at gmail.com
                   |ity.org                     |

--- Comment #1 from Janusz Kaczmarek <januszop at gmail.com> ---
Created attachment 69344
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=69344&action=edit
Bug 19693: authtypefrom incorrectly set when updating auth  from file

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Sat Nov 25 02:51:23 2017
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Sat, 25 Nov 2017 01:51:23 +0000
Subject: [Koha-bugs] [Bug 18458] Merging authority record incorrectly orders
	subfields
In-Reply-To: <bug-18458-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-18458-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-18458-70-3jXyjpeHLG@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18458

--- Comment #4 from Janusz Kaczmarek <januszop at gmail.com> ---
Created attachment 69345
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=69345&action=edit
Bug 18458 - Merging authority record incorrectly orders  subfields

While doing a merge, if a subfield(s) precedes the controlled subfields
(like $i before $a in 7XX, which comes before $a -- rare but will
become more and more usual) after merging will be moved to the end.
This is not right.

The patch (with AuthorityMergeMode == loose) make merge consider the
subfields order: all subfields which originally were found before
the first controlled subfield (e.g. $i before $a in 7XX / MARC 21)
will remain in the front, the rest of not controlled subfields that
should remain in the field will come after the subfields copied
from authority rec.

As a bonus, $9 will be placed at the end.

To test:
0) Have AuthorityMergeMode == loose;
1) Have some field in bibliorecord, controlled by an authority, with
extra subfield(s) (i.e. not present in authority rec.) placed at the
beginning of the field;
2) Open (not necessarily edit) and save the connected authority;
3) See that the extra subfieds were moved to the end of the field
   (and $9 is in the front);
4) Apply the patch;
5) Reorder subfields in biblio field;
6) Open (not necessarily edit) and save the connected authority;
7) See that the order has been conserved, additionally $9 the last
   subfield in the field.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Sat Nov 25 03:00:48 2017
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Sat, 25 Nov 2017 02:00:48 +0000
Subject: [Koha-bugs] [Bug 18458] Merging authority record incorrectly orders
	subfields
In-Reply-To: <bug-18458-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-18458-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-18458-70-XjkSZVTqP5@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18458

Janusz Kaczmarek <januszop at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|NEW                         |Needs Signoff

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Sun Nov 26 05:48:28 2017
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Sun, 26 Nov 2017 04:48:28 +0000
Subject: [Koha-bugs] [Bug 16702] Notice Triggers Issue: Delivery Mechanism
 Options Not Saving
In-Reply-To: <bug-16702-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-16702-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-16702-70-ur3jUhejVf@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16702

Yakub <brokenmoon7177 at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |brokenmoon7177 at gmail.com

--- Comment #3 from Yakub <brokenmoon7177 at gmail.com> ---
This issue can be fixed using mysql hack by renaming overduerules table to
old_overduerules then change back to overduerules.

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Sun Nov 26 15:26:11 2017
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Sun, 26 Nov 2017 14:26:11 +0000
Subject: [Koha-bugs] [Bug 17467] There should be a koha-zebra script to
 handle Zebra daemons for instances
In-Reply-To: <bug-17467-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-17467-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-17467-70-MgadMGxZ80@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17467

Jonathan Druart <jonathan.druart at bugs.koha-community.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
           Keywords|rel_17_11_candidate         |

--- Comment #29 from Jonathan Druart <jonathan.druart at bugs.koha-community.org> ---
Tomas, please add a text to go to the release notes.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Sun Nov 26 15:31:11 2017
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Sun, 26 Nov 2017 14:31:11 +0000
Subject: [Koha-bugs] [Bug 19234] Add query parameters handling helpers
In-Reply-To: <bug-19234-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-19234-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-19234-70-h2NuSM6756@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19234

Jonathan Druart <jonathan.druart at bugs.koha-community.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
           Keywords|rel_17_11_candidate         |

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Sun Nov 26 15:31:22 2017
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Sun, 26 Nov 2017 14:31:22 +0000
Subject: [Koha-bugs] [Bug 19555] Some changes to records are not reflected
	in OAI-PMH
In-Reply-To: <bug-19555-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-19555-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-19555-70-YruPb1ecIe@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19555

Jonathan Druart <jonathan.druart at bugs.koha-community.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
           Keywords|rel_17_11_candidate         |

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Sun Nov 26 15:31:33 2017
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Sun, 26 Nov 2017 14:31:33 +0000
Subject: [Koha-bugs] [Bug 19444] Automatic renewal script should not
 auto-renew if a patron' s record has expired
In-Reply-To: <bug-19444-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-19444-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-19444-70-1lkjC7u2zW@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19444

Jonathan Druart <jonathan.druart at bugs.koha-community.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
           Keywords|rel_17_11_candidate         |

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Sun Nov 26 15:31:45 2017
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Sun, 26 Nov 2017 14:31:45 +0000
Subject: [Koha-bugs] [Bug 18915] Creating a checkout note (patron note)
 sends an incomplete email message
In-Reply-To: <bug-18915-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-18915-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-18915-70-Kz29qhcrVM@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18915

Jonathan Druart <jonathan.druart at bugs.koha-community.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
           Keywords|rel_17_11_candidate         |

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Sun Nov 26 15:31:47 2017
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Sun, 26 Nov 2017 14:31:47 +0000
Subject: [Koha-bugs] [Bug 19496] Patron notes about item does not get
 emailed as indicated
In-Reply-To: <bug-19496-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-19496-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-19496-70-sZqIJ9eCLf@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19496

Jonathan Druart <jonathan.druart at bugs.koha-community.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
           Keywords|rel_17_11_candidate         |

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Sun Nov 26 15:31:51 2017
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Sun, 26 Nov 2017 14:31:51 +0000
Subject: [Koha-bugs] [Bug 18342] Set memcached as 'enabled' by default
In-Reply-To: <bug-18342-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-18342-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-18342-70-UPVpPcx2u4@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18342

Jonathan Druart <jonathan.druart at bugs.koha-community.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
           Keywords|rel_17_11_candidate         |

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Sun Nov 26 15:31:54 2017
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Sun, 26 Nov 2017 14:31:54 +0000
Subject: [Koha-bugs] [Bug 19462] Add a koha-elasticsearch command
In-Reply-To: <bug-19462-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-19462-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-19462-70-ENcebv9U9g@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19462

Jonathan Druart <jonathan.druart at bugs.koha-community.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
           Keywords|rel_17_11_candidate         |
                 CC|                            |jonathan.druart at bugs.koha-c
                   |                            |ommunity.org

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Sun Nov 26 15:32:06 2017
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Sun, 26 Nov 2017 14:32:06 +0000
Subject: [Koha-bugs] [Bug 12768] Replacement cost and processing fee
	management
In-Reply-To: <bug-12768-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-12768-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-12768-70-SLUJUo3uws@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12768

Jonathan Druart <jonathan.druart at bugs.koha-community.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
           Keywords|rel_17_11_candidate         |

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Sun Nov 26 15:32:10 2017
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Sun, 26 Nov 2017 14:32:10 +0000
Subject: [Koha-bugs] [Bug 17951] koha-create should create the template
 cache dir and configure it in koha-conf.xml
In-Reply-To: <bug-17951-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-17951-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-17951-70-YtSPT4Jx4F@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17951

Jonathan Druart <jonathan.druart at bugs.koha-community.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
           Keywords|rel_17_11_candidate         |

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Sun Nov 26 15:32:14 2017
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Sun, 26 Nov 2017 14:32:14 +0000
Subject: [Koha-bugs] [Bug 19278] Add a configurable default page size for
	endpoints
In-Reply-To: <bug-19278-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-19278-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-19278-70-N8uw7hDfZL@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19278

Jonathan Druart <jonathan.druart at bugs.koha-community.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
           Keywords|rel_17_11_candidate         |

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Sun Nov 26 15:32:18 2017
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Sun, 26 Nov 2017 14:32:18 +0000
Subject: [Koha-bugs] [Bug 19300] Move C4::Reserves::OPACItemHoldsAllowed to
 the code namespace
In-Reply-To: <bug-19300-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-19300-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-19300-70-TodS1SojrF@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19300

Jonathan Druart <jonathan.druart at bugs.koha-community.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
           Keywords|rel_17_11_candidate         |

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Sun Nov 26 15:32:30 2017
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Sun, 26 Nov 2017 14:32:30 +0000
Subject: [Koha-bugs] [Bug 19301] Move C4::Reserves::OnShelfHoldsAllowed to
 the code namespace
In-Reply-To: <bug-19301-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-19301-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-19301-70-4usdXHH0bi@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19301

Jonathan Druart <jonathan.druart at bugs.koha-community.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
           Keywords|rel_17_11_candidate         |

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Sun Nov 26 15:32:31 2017
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Sun, 26 Nov 2017 14:32:31 +0000
Subject: [Koha-bugs] [Bug 18888] Include the definition of currency in
	onboarding tool
In-Reply-To: <bug-18888-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-18888-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-18888-70-XMBn9AX8w6@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18888

Jonathan Druart <jonathan.druart at bugs.koha-community.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
           Keywords|rel_17_11_candidate         |

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Sun Nov 26 15:32:36 2017
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Sun, 26 Nov 2017 14:32:36 +0000
Subject: [Koha-bugs] [Bug 8995] Show OpenURL links in OPAC search results
In-Reply-To: <bug-8995-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-8995-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-8995-70-NvwJRJbkWT@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8995

Jonathan Druart <jonathan.druart at bugs.koha-community.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
           Keywords|rel_17_11_candidate         |

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Sun Nov 26 15:32:36 2017
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Sun, 26 Nov 2017 14:32:36 +0000
Subject: [Koha-bugs] [Bug 17981] Add the ability to preview generated notice
	templates
In-Reply-To: <bug-17981-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-17981-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-17981-70-DBFYvQ0Unq@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17981

Jonathan Druart <jonathan.druart at bugs.koha-community.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
           Keywords|rel_17_11_candidate         |

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Sun Nov 26 15:32:41 2017
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Sun, 26 Nov 2017 14:32:41 +0000
Subject: [Koha-bugs] [Bug 18007] Interface updates to notices and notice
	previews
In-Reply-To: <bug-18007-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-18007-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-18007-70-I6icyoIIIj@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18007

Jonathan Druart <jonathan.druart at bugs.koha-community.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
           Keywords|rel_17_11_candidate         |

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Sun Nov 26 15:42:45 2017
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Sun, 26 Nov 2017 14:42:45 +0000
Subject: [Koha-bugs] [Bug 18547] On shelf holds allowed > "If all
 unavailable" ignores default hold policy
In-Reply-To: <bug-18547-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-18547-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-18547-70-VXZOE7dwh3@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18547

Jonathan Druart <jonathan.druart at bugs.koha-community.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
           Keywords|rel_17_11_candidate         |

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Sun Nov 26 15:44:21 2017
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Sun, 26 Nov 2017 14:44:21 +0000
Subject: [Koha-bugs] [Bug 2093] Add OPAC dashboard for logged-in users
In-Reply-To: <bug-2093-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-2093-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-2093-70-Kj5efsDvUh@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=2093

Jonathan Druart <jonathan.druart at bugs.koha-community.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Text to go in the|                            |Add a summary to the OPAC
      release notes|                            |once the user has logged in
                   |                            |that
                   |                            |shows the users number
                   |                            |of checkouts, overdues,
                   |                            |holds pending, holds
                   |                            |waiting and total fines. It
                   |                            |can be turned on with the
                   |                            |new system preference
                   |                            |OPACUserSummary.
           Keywords|release-notes-needed        |

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Sun Nov 26 15:59:07 2017
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Sun, 26 Nov 2017 14:59:07 +0000
Subject: [Koha-bugs] [Bug 18357] On-site checkouts issues with 'Unlimited'
In-Reply-To: <bug-18357-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-18357-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-18357-70-2v1xpHAtGT@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18357

Jonathan Druart <jonathan.druart at bugs.koha-community.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
           Severity|normal                      |major

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Sun Nov 26 16:55:47 2017
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Sun, 26 Nov 2017 15:55:47 +0000
Subject: [Koha-bugs] [Bug 19655] To.json doesn't escape newlines which can
 create invalid JSON
In-Reply-To: <bug-19655-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-19655-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-19655-70-5jaS4ONQSs@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19655

--- Comment #4 from Jonathan Druart <jonathan.druart at bugs.koha-community.org> ---
Created attachment 69346
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=69346&action=edit
Bug 19655: Add tests

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Sun Nov 26 17:01:32 2017
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Sun, 26 Nov 2017 16:01:32 +0000
Subject: [Koha-bugs] [Bug 19655] To.json doesn't escape newlines which can
 create invalid JSON
In-Reply-To: <bug-19655-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-19655-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-19655-70-p4LTfTvV7L@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19655

Jonathan Druart <jonathan.druart at bugs.koha-community.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |jonathan.druart at bugs.koha-c
                   |                            |ommunity.org

--- Comment #5 from Jonathan Druart <jonathan.druart at bugs.koha-community.org> ---
I am not sure it is the best way to fix it.
1. We may encounter issues later using To.json on other values that use escaped
strings (ok we will update the code to make it works)
2. Maybe we should replace all \\ with \\\\

I will push as it and adapt later if needed.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Sun Nov 26 17:05:19 2017
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Sun, 26 Nov 2017 16:05:19 +0000
Subject: [Koha-bugs] [Bug 19651] SIP/ILS/Item missing title
In-Reply-To: <bug-19651-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-19651-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-19651-70-qvTgLYrEZE@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19651

Jonathan Druart <jonathan.druart at bugs.koha-community.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |jonathan.druart at bugs.koha-c
                   |                            |ommunity.org
         Depends on|                            |18276

--- Comment #6 from Jonathan Druart <jonathan.druart at bugs.koha-community.org> ---
Caused by bug 18276.


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18276
[Bug 18276] Koha::Biblio - Remove GetBiblioFromItemNumber
-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Sun Nov 26 17:05:19 2017
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Sun, 26 Nov 2017 16:05:19 +0000
Subject: [Koha-bugs] [Bug 18276] Koha::Biblio - Remove
	GetBiblioFromItemNumber
In-Reply-To: <bug-18276-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-18276-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-18276-70-YttKx2YKG2@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18276

Jonathan Druart <jonathan.druart at bugs.koha-community.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Blocks|                            |19651


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19651
[Bug 19651] SIP/ILS/Item missing title
-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Sun Nov 26 17:25:43 2017
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Sun, 26 Nov 2017 16:25:43 +0000
Subject: [Koha-bugs] [Bug 18131] Matching staged records when using elastic
	search fails
In-Reply-To: <bug-18131-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-18131-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-18131-70-MEE5bvopZG@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18131

Jonathan Druart <jonathan.druart at bugs.koha-community.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Passed QA                   |Pushed to Master

--- Comment #17 from Jonathan Druart <jonathan.druart at bugs.koha-community.org> ---
Pushed to master for 17.11, thanks to everybody involved!

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Sun Nov 26 17:25:50 2017
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Sun, 26 Nov 2017 16:25:50 +0000
Subject: [Koha-bugs] [Bug 18357] On-site checkouts issues with 'Unlimited'
In-Reply-To: <bug-18357-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-18357-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-18357-70-aL9s9GwxKq@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18357

Jonathan Druart <jonathan.druart at bugs.koha-community.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Passed QA                   |Pushed to Master

--- Comment #7 from Jonathan Druart <jonathan.druart at bugs.koha-community.org> ---
Pushed to master for 17.11, thanks to everybody involved!

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Sun Nov 26 17:25:56 2017
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Sun, 26 Nov 2017 16:25:56 +0000
Subject: [Koha-bugs] [Bug 18547] On shelf holds allowed > "If all
 unavailable" ignores default hold policy
In-Reply-To: <bug-18547-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-18547-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-18547-70-Xm82jRa8BY@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18547

Jonathan Druart <jonathan.druart at bugs.koha-community.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Passed QA                   |Pushed to Master

--- Comment #21 from Jonathan Druart <jonathan.druart at bugs.koha-community.org> ---
Pushed to master for 17.11, thanks to everybody involved!

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Sun Nov 26 17:26:02 2017
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Sun, 26 Nov 2017 16:26:02 +0000
Subject: [Koha-bugs] [Bug 18712] make test is failing with an empty DB -
	t/Matcher.t
In-Reply-To: <bug-18712-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-18712-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-18712-70-OxFDyDOUl2@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18712

Jonathan Druart <jonathan.druart at bugs.koha-community.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Passed QA                   |Pushed to Master

--- Comment #16 from Jonathan Druart <jonathan.druart at bugs.koha-community.org> ---
Pushed to master for 17.11, thanks to everybody involved!

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Sun Nov 26 17:26:22 2017
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Sun, 26 Nov 2017 16:26:22 +0000
Subject: [Koha-bugs] [Bug 19481] Elasticsearch - Set default fields for
 sorting in mappings.yaml
In-Reply-To: <bug-19481-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-19481-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-19481-70-iiGSUs0b9U@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19481

Jonathan Druart <jonathan.druart at bugs.koha-community.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Passed QA                   |Pushed to Master

--- Comment #10 from Jonathan Druart <jonathan.druart at bugs.koha-community.org> ---
Pushed to master for 17.11, thanks to everybody involved!

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Sun Nov 26 17:26:25 2017
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Sun, 26 Nov 2017 16:26:25 +0000
Subject: [Koha-bugs] [Bug 19651] SIP/ILS/Item missing title
In-Reply-To: <bug-19651-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-19651-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-19651-70-E9t1WDJdKw@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19651

--- Comment #7 from Jonathan Druart <jonathan.druart at bugs.koha-community.org> ---
Patch pushed to Master!
Thanks Stephan and congrats for your first patch in!

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Sun Nov 26 17:26:28 2017
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Sun, 26 Nov 2017 16:26:28 +0000
Subject: [Koha-bugs] [Bug 19536] Odd number of elements in anonymous hash in
	svc/bib
In-Reply-To: <bug-19536-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-19536-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-19536-70-U54XuYtvtZ@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19536

Jonathan Druart <jonathan.druart at bugs.koha-community.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Passed QA                   |Pushed to Master

--- Comment #4 from Jonathan Druart <jonathan.druart at bugs.koha-community.org> ---
Pushed to master for 17.11, thanks to everybody involved!

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Sun Nov 26 17:26:33 2017
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Sun, 26 Nov 2017 16:26:33 +0000
Subject: [Koha-bugs] [Bug 19559] Elasticsearch QueryAutoTruncate truncate
 field names with hyphens if data is quoted
In-Reply-To: <bug-19559-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-19559-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-19559-70-905o28vyLr@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19559

Jonathan Druart <jonathan.druart at bugs.koha-community.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Passed QA                   |Pushed to Master

--- Comment #11 from Jonathan Druart <jonathan.druart at bugs.koha-community.org> ---
Pushed to master for 17.11, thanks to everybody involved!

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Sun Nov 26 17:26:35 2017
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Sun, 26 Nov 2017 16:26:35 +0000
Subject: [Koha-bugs] [Bug 19651] SIP/ILS/Item missing title
In-Reply-To: <bug-19651-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-19651-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-19651-70-rXKAZvSIPX@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19651

Jonathan Druart <jonathan.druart at bugs.koha-community.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Passed QA                   |Pushed to Master

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Sun Nov 26 17:26:39 2017
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Sun, 26 Nov 2017 16:26:39 +0000
Subject: [Koha-bugs] [Bug 19596] Internal server error if open order with
 deleted biblio / null biblionumber
In-Reply-To: <bug-19596-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-19596-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-19596-70-LEYM3JfZkc@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19596

Jonathan Druart <jonathan.druart at bugs.koha-community.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Passed QA                   |Pushed to Master

--- Comment #7 from Jonathan Druart <jonathan.druart at bugs.koha-community.org> ---
Pushed to master for 17.11, thanks to everybody involved!

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Sun Nov 26 17:26:45 2017
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Sun, 26 Nov 2017 16:26:45 +0000
Subject: [Koha-bugs] [Bug 19626] Database update for bug 12063 incorrectly
 calculates expirationdate for holds
In-Reply-To: <bug-19626-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-19626-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-19626-70-P8wA1bYUq2@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19626

Jonathan Druart <jonathan.druart at bugs.koha-community.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Passed QA                   |Pushed to Master

--- Comment #7 from Jonathan Druart <jonathan.druart at bugs.koha-community.org> ---
Pushed to master for 17.11, thanks to everybody involved!

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Sun Nov 26 17:26:59 2017
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Sun, 26 Nov 2017 16:26:59 +0000
Subject: [Koha-bugs] [Bug 19655] To.json doesn't escape newlines which can
 create invalid JSON
In-Reply-To: <bug-19655-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-19655-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-19655-70-p914W4ON2S@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19655

Jonathan Druart <jonathan.druart at bugs.koha-community.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Passed QA                   |Pushed to Master

--- Comment #6 from Jonathan Druart <jonathan.druart at bugs.koha-community.org> ---
Pushed to master for 17.11, thanks to everybody involved!

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Sun Nov 26 17:29:36 2017
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Sun, 26 Nov 2017 16:29:36 +0000
Subject: [Koha-bugs] [Bug 18308] Default value of minPasswordLength should
	be increased
In-Reply-To: <bug-18308-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-18308-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-18308-70-kpjdLXZnCC@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18308

Jonathan Druart <jonathan.druart at bugs.koha-community.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Needs Signoff               |Patch doesn't apply

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Sun Nov 26 18:02:48 2017
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Sun, 26 Nov 2017 17:02:48 +0000
Subject: [Koha-bugs] [Bug 19514] No Password restrictions in onboarding tool
 patron creation
In-Reply-To: <bug-19514-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-19514-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-19514-70-Ufe2HbrAkd@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19514

Jonathan Druart <jonathan.druart at bugs.koha-community.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
           Severity|critical                    |major

--- Comment #11 from Jonathan Druart <jonathan.druart at bugs.koha-community.org> ---
Lowering severity, this does not appear critical to me.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Sun Nov 26 18:05:41 2017
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Sun, 26 Nov 2017 17:05:41 +0000
Subject: [Koha-bugs] [Bug 19675] Cannot save notices when setting the
 TranslateNotices preference
In-Reply-To: <bug-19675-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-19675-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-19675-70-PiU1fGyouG@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19675

Jonathan Druart <jonathan.druart at bugs.koha-community.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
            Version|17.05                       |master
                 CC|                            |jonathan.druart at bugs.koha-c
                   |                            |ommunity.org

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.

From bugzilla-daemon at bugs.koha-community.org  Sun Nov 26 18:12:15 2017
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Sun, 26 Nov 2017 17:12:15 +0000
Subject: [Koha-bugs] [Bug 19675] Cannot save notices when setting the
 TranslateNotices preference
In-Reply-To: <bug-19675-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-19675-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-19675-70-WSkEW1YD9S@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19675

--- Comment #2 from Jonathan Druart <jonathan.druart at bugs.koha-community.org> ---
Created attachment 69347
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=69347&action=edit
Bug 19675: Fix update notice templates when they are translatable

Avoid the following error:
DBD::mysql::db do failed: Duplicate entry
'acquisition-xxx--email-default' for key 'PRIMARY' [for Statement "

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Sun Nov 26 18:12:00 2017
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Sun, 26 Nov 2017 17:12:00 +0000
Subject: [Koha-bugs] [Bug 19675] Cannot save notices when setting the
 TranslateNotices preference
In-Reply-To: <bug-19675-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-19675-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-19675-70-qtOH8SPYVc@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19675

Jonathan Druart <jonathan.druart at bugs.koha-community.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|NEW                         |Needs Signoff

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Sun Nov 26 18:12:37 2017
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Sun, 26 Nov 2017 17:12:37 +0000
Subject: [Koha-bugs] [Bug 19675] Cannot save notices when setting the
 TranslateNotices preference
In-Reply-To: <bug-19675-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-19675-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-19675-70-bXjr0RbN2G@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19675

Jonathan Druart <jonathan.druart at bugs.koha-community.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
           Assignee|koha-bugs at lists.koha-commun |andreas.jonsson at kreablo.se
                   |ity.org                     |

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Sun Nov 26 18:14:07 2017
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Sun, 26 Nov 2017 17:14:07 +0000
Subject: [Koha-bugs] [Bug 19675] Cannot save notices when setting the
 TranslateNotices preference
In-Reply-To: <bug-19675-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-19675-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-19675-70-DJJBEDQPCG@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19675

Jonathan Druart <jonathan.druart at bugs.koha-community.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Needs Signoff               |Signed Off

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Sun Nov 26 18:14:12 2017
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Sun, 26 Nov 2017 17:14:12 +0000
Subject: [Koha-bugs] [Bug 19675] Cannot save notices when setting the
 TranslateNotices preference
In-Reply-To: <bug-19675-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-19675-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-19675-70-ZjfPWOdUN5@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19675

Jonathan Druart <jonathan.druart at bugs.koha-community.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #69347|0                           |1
        is obsolete|                            |

--- Comment #3 from Jonathan Druart <jonathan.druart at bugs.koha-community.org> ---
Created attachment 69348
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=69348&action=edit
Bug 19675: Fix update notice templates when they are translatable

Avoid the following error:
DBD::mysql::db do failed: Duplicate entry
'acquisition-xxx--email-default' for key 'PRIMARY' [for Statement "

Signed-off-by: Jonathan Druart <jonathan.druart at bugs.koha-community.org>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Sun Nov 26 18:14:44 2017
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Sun, 26 Nov 2017 17:14:44 +0000
Subject: [Koha-bugs] [Bug 19675] Cannot save notices when setting the
 TranslateNotices preference
In-Reply-To: <bug-19675-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-19675-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-19675-70-QqZbaBZyRq@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19675

Jonathan Druart <jonathan.druart at bugs.koha-community.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Signed Off                  |Passed QA
         Depends on|                            |17762

--- Comment #4 from Jonathan Druart <jonathan.druart at bugs.koha-community.org> ---
Skipping QA.


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17762
[Bug 17762] Ability to translate notices
-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Sun Nov 26 18:14:44 2017
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Sun, 26 Nov 2017 17:14:44 +0000
Subject: [Koha-bugs] [Bug 17762] Ability to translate notices
In-Reply-To: <bug-17762-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-17762-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-17762-70-7buuG99MAa@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17762

Jonathan Druart <jonathan.druart at bugs.koha-community.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Blocks|                            |19675


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19675
[Bug 19675] Cannot save notices when setting the TranslateNotices preference
-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Sun Nov 26 18:21:41 2017
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Sun, 26 Nov 2017 17:21:41 +0000
Subject: [Koha-bugs] [Bug 19693] authtypefrom incorrectly set when updating
 auth recs from file
In-Reply-To: <bug-19693-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-19693-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-19693-70-EMO3lNmAH5@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19693

Janusz Kaczmarek <januszop at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #69344|0                           |1
        is obsolete|                            |

--- Comment #2 from Janusz Kaczmarek <januszop at gmail.com> ---
Created attachment 69349
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=69349&action=edit
Bug 19693: authtypefrom incorrectly set when updating auth from file

A corrected version.  It is more safe to use the GuessAuthTypeCode function
only if really needed, i.e. when merging to itself (especially when using some
non standard authority types that for some reason are not covered in
GuessAuthTypeCode).

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Sun Nov 26 18:32:26 2017
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Sun, 26 Nov 2017 17:32:26 +0000
Subject: [Koha-bugs] [Bug 19693] authtypefrom incorrectly set when updating
 auth recs from file
In-Reply-To: <bug-19693-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-19693-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-19693-70-AnQKPYs7Cm@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19693

Janusz Kaczmarek <januszop at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #69349|0                           |1
        is obsolete|                            |

--- Comment #3 from Janusz Kaczmarek <januszop at gmail.com> ---
Created attachment 69350
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=69350&action=edit
Bug 19693: authtypefrom incorrectly set when updating auth  from file

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Sun Nov 26 19:14:34 2017
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Sun, 26 Nov 2017 18:14:34 +0000
Subject: [Koha-bugs] [Bug 17602] Integrate support for
	OneClickdigital/Recorded Books API
In-Reply-To: <bug-17602-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-17602-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-17602-70-AT3cxIcCCT@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17602

Jonathan Druart <jonathan.druart at bugs.koha-community.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Needs Signoff               |ASSIGNED

--- Comment #64 from Jonathan Druart <jonathan.druart at bugs.koha-community.org> ---
(In reply to Srdjan Jankovic from comment #63)
> (In reply to Jonathan Druart from comment #61)
> > Some additional remarks:
> > 1. At some point I got the following error:
> > {"error":"Checkout item already exists"}Status: 200 OK
> 
> I have to let Nick decide on that one

Nick?

> > 2. Strings from .js files are not translatable, `git grep MSG_` to know how
> > to make them translatable.
> 
> Done. Please let me know if it's not what you had in mind.

I am not sure to understand what you did, I already fixed the some translations
(patch "Bug 17602: Ease translation") from .tt, you needed to fix the strings
in .js files (.inc and .tt were ok)

> > 3. I see code related to pagination, but I do not see the previous/next
> > buttons. I only see the OPACnumSearchResults first results.
> 
> Yes, at some stage the idea was to integrate all external searches into the
> main results page, so I stopped short of implementing paging - will be
> thrown away. Is it acceptable to leave as is?

I do not think we should integrate code that is not used.

> > And a question:
> > Koha/ExternalContent/RecordedBooks.pm
> >  76                 user_agent_params => { agent => $class->agent_string }
> > Where is this used?
> 
> It is a param for WebService::ILS. Cannot remember any more, possibly was a
> requirement for a provider that even did not get implemented.

So we remove?

Moving out the NSO queue.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Sun Nov 26 19:19:08 2017
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Sun, 26 Nov 2017 18:19:08 +0000
Subject: [Koha-bugs] [Bug 17047] Mana Knowledge Base : share data
In-Reply-To: <bug-17047-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-17047-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-17047-70-MJAs6yGAaI@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17047

--- Comment #177 from Jonathan Druart <jonathan.druart at bugs.koha-community.org> ---
Can I get an answer to my comments 162-164?

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Sun Nov 26 19:19:47 2017
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Sun, 26 Nov 2017 18:19:47 +0000
Subject: [Koha-bugs] [Bug 19439] Some error responses from opac/unapi get
	lost in eval
In-Reply-To: <bug-19439-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-19439-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-19439-70-cmRYJiXTSe@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19439

Jonathan Druart <jonathan.druart at bugs.koha-community.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
           Severity|enhancement                 |major

--- Comment #7 from Jonathan Druart <jonathan.druart at bugs.koha-community.org> ---
Yes, but too late for 17.11.00 now.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Sun Nov 26 19:55:08 2017
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Sun, 26 Nov 2017 18:55:08 +0000
Subject: [Koha-bugs] [Bug 19675] Cannot save notices when setting the
 TranslateNotices preference
In-Reply-To: <bug-19675-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-19675-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-19675-70-yPADQmuTX3@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19675

Jonathan Druart <jonathan.druart at bugs.koha-community.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Passed QA                   |Pushed to Master

--- Comment #5 from Jonathan Druart <jonathan.druart at bugs.koha-community.org> ---
Path pushed to master for 17.11, thanks Andreas and congrats for your first
patch in!

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Sun Nov 26 20:38:09 2017
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Sun, 26 Nov 2017 19:38:09 +0000
Subject: [Koha-bugs] [Bug 7143] Bug for tracking changes to the about page
In-Reply-To: <bug-7143-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-7143-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-7143-70-Rzx9Y4Iqjo@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7143

--- Comment #378 from Jonathan Druart <jonathan.druart at bugs.koha-community.org> ---
Created attachment 69351
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=69351&action=edit
Bug 7143: Update timeline (2 new devs)

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.

From bugzilla-daemon at bugs.koha-community.org  Sun Nov 26 20:39:25 2017
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Sun, 26 Nov 2017 19:39:25 +0000
Subject: [Koha-bugs] [Bug 7143] Bug for tracking changes to the about page
In-Reply-To: <bug-7143-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-7143-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-7143-70-SsrHx2SUS5@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7143

--- Comment #379 from Jonathan Druart <jonathan.druart at bugs.koha-community.org> ---
(In reply to Jonathan Druart from comment #378)
> Created attachment 69351 [details] [review]
> Bug 7143: Update timeline (2 new devs)

Patch pushed to master for 17.11.

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.

From bugzilla-daemon at bugs.koha-community.org  Sun Nov 26 21:26:51 2017
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Sun, 26 Nov 2017 20:26:51 +0000
Subject: [Koha-bugs] [Bug 19675] Cannot save notices when setting the
 TranslateNotices preference
In-Reply-To: <bug-19675-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-19675-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-19675-70-Rr3TIaKZbx@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19675

--- Comment #6 from Andreas Jonsson <andreas.jonsson at kreablo.se> ---

Thanks you for pushing this so swiftly!

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Nov 27 01:24:29 2017
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 27 Nov 2017 00:24:29 +0000
Subject: [Koha-bugs] [Bug 17602] Integrate support for
	OneClickdigital/Recorded Books API
In-Reply-To: <bug-17602-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-17602-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-17602-70-eCAbXaBpJz@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17602

--- Comment #65 from Srdjan Jankovic <srdjan at catalyst.net.nz> ---
(In reply to Jonathan Druart from comment #64)

> I am not sure to understand what you did, I already fixed the some
> translations (patch "Bug 17602: Ease translation") from .tt, you needed to
> fix the strings in .js files (.inc and .tt were ok)

Right. Ok, before I do that. how do we handle messages that are the same in
both OPAC and intranet?

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Nov 27 01:25:52 2017
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 27 Nov 2017 00:25:52 +0000
Subject: [Koha-bugs] [Bug 18889] Item number in biblio description in fine
	page
In-Reply-To: <bug-18889-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-18889-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-18889-70-QsBCK0vyQo@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18889

Alex Buckley <alexbuckley at catalyst.net.nz> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|ASSIGNED                    |Needs Signoff
                 CC|                            |alexbuckley at catalyst.net.nz

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Nov 27 01:25:35 2017
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 27 Nov 2017 00:25:35 +0000
Subject: [Koha-bugs] [Bug 18889] Item number in biblio description in fine
	page
In-Reply-To: <bug-18889-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-18889-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-18889-70-gG98gx6Tt6@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18889

--- Comment #1 from Alex Buckley <alexbuckley at catalyst.net.nz> ---
Created attachment 69352
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=69352&action=edit
Bug 18889 - Storing and display of barcode with fines in intranet

Test plan:
1. Create a manual invoice fine making sure you enter in a barcode value

2. Go to the 'Pay fines' tab and notice that the barcode value is not
displayed

3. Apply patch

4. Update your database by running the updatedatabase.pl script in
koha-shell

This will run the atomicupdate file
bug_18889_added_barcode_field_to_accountlines.sql which contains the
database changes

5. Update your DBIx by running the command (in the Koha root directory):
misc/devel/update_dbix_class_files.pl --db_name=<dbname> --db_user=<dbuser>
--db_pass=<dbpass>

6. Repeat step 1 and 2 and notice that there is a new front end column
in the 'Pay fines' page which displays the item barcode

Sponsored-By: Catalyst IT

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Nov 27 01:35:28 2017
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 27 Nov 2017 00:35:28 +0000
Subject: [Koha-bugs] [Bug 18308] Default value of minPasswordLength should
	be increased
In-Reply-To: <bug-18308-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-18308-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-18308-70-uvUiCbMTe6@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18308

Alex Buckley <alexbuckley at catalyst.net.nz> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
         Depends on|                            |19514


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19514
[Bug 19514] No Password restrictions in onboarding tool patron creation
-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Nov 27 01:35:28 2017
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 27 Nov 2017 00:35:28 +0000
Subject: [Koha-bugs] [Bug 19514] No Password restrictions in onboarding tool
 patron creation
In-Reply-To: <bug-19514-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-19514-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-19514-70-CPy36ZAcCN@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19514

Alex Buckley <alexbuckley at catalyst.net.nz> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Blocks|                            |18308


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18308
[Bug 18308] Default value of minPasswordLength should be increased
-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Nov 27 01:37:22 2017
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 27 Nov 2017 00:37:22 +0000
Subject: [Koha-bugs] [Bug 18308] Default value of minPasswordLength should
	be increased
In-Reply-To: <bug-18308-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-18308-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-18308-70-fIw8oyYgtE@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18308

Alex Buckley <alexbuckley at catalyst.net.nz> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Patch doesn't apply         |Needs Signoff

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Nov 27 01:51:50 2017
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 27 Nov 2017 00:51:50 +0000
Subject: [Koha-bugs] [Bug 19532] Recalls for Koha
In-Reply-To: <bug-19532-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-19532-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-19532-70-xKBnNoQ0xT@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19532

--- Comment #22 from Aleisha Amohia <aleisha at catalyst.net.nz> ---
Created attachment 69353
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=69353&action=edit
Bug 19532: Send notice to user to return a recalled item

When the recall is placed in the OPAC, a RETURN_RECALLED_ITEM notice is
sent to the user who has the item checked out, with the updated due
date.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Nov 27 02:21:08 2017
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 27 Nov 2017 01:21:08 +0000
Subject: [Koha-bugs] [Bug 19532] Recalls for Koha
In-Reply-To: <bug-19532-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-19532-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-19532-70-WhMtpq49Gy@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19532

--- Comment #23 from Aleisha Amohia <aleisha at catalyst.net.nz> ---
Created attachment 69354
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=69354&action=edit
Bug 19532: Send notice to user to pickup recalled returned item

Send a PICKUP_RECALLED_ITEM notice to the user who requested a recall
when the item is checked in.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Nov 27 02:33:59 2017
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 27 Nov 2017 01:33:59 +0000
Subject: [Koha-bugs] [Bug 17602] Integrate support for
	OneClickdigital/Recorded Books API
In-Reply-To: <bug-17602-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-17602-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-17602-70-xkRGYIjU3L@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17602

--- Comment #66 from Tom?s Cohen Arazi <tomascohen at gmail.com> ---
(In reply to Srdjan Jankovic from comment #65)
> (In reply to Jonathan Druart from comment #64)
> 
> > I am not sure to understand what you did, I already fixed the some
> > translations (patch "Bug 17602: Ease translation") from .tt, you needed to
> > fix the strings in .js files (.inc and .tt were ok)
> 
> Right. Ok, before I do that. how do we handle messages that are the same in
> both OPAC and intranet?

I suggest you just duplicate them.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Nov 27 03:34:49 2017
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 27 Nov 2017 02:34:49 +0000
Subject: [Koha-bugs] [Bug 7046] subscription renewal period should be a pull
	down
In-Reply-To: <bug-7046-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-7046-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-7046-70-3cePF0kcoc@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7046

--- Comment #5 from Alex Buckley <alexbuckley at catalyst.net.nz> ---
Created attachment 69355
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=69355&action=edit
Bug 7046 - Added subscription length dropdown box

-- 
You are receiving this mail because:
You are the QA Contact for the bug.
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Nov 27 05:08:34 2017
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 27 Nov 2017 04:08:34 +0000
Subject: [Koha-bugs] [Bug 7046] subscription renewal period should be a pull
	down
In-Reply-To: <bug-7046-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-7046-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-7046-70-rjfaWt6tWC@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7046

Alex Buckley <alexbuckley at catalyst.net.nz> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |alexbuckley at catalyst.net.nz
  Attachment #69355|0                           |1
        is obsolete|                            |

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the QA Contact for the bug.

From bugzilla-daemon at bugs.koha-community.org  Mon Nov 27 05:08:53 2017
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 27 Nov 2017 04:08:53 +0000
Subject: [Koha-bugs] [Bug 7046] subscription renewal period should be a pull
	down
In-Reply-To: <bug-7046-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-7046-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-7046-70-VdmDyLwB0j@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7046

--- Comment #6 from Alex Buckley <alexbuckley at catalyst.net.nz> ---
Created attachment 69356
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=69356&action=edit
Bug 7046 - Implemented dropdown sub length element

To make this work I moved the _get_sub_length function from
subscription-add.pl to C4/Serials.pm so that the subscription-renew.pl
script could also call it to store the sublength for the appropriate
field of the subscriptions database table.

Test plan:
1. Create a subscription and notice that there is a dropdown box for sub
length containing the values: issues, weeks, months

2. Renew the subscription and notice that there are 3 input text boxes:
'number of num', 'number of weeks' and 'number of months'

3. Input a 'Number of weeks' value of 2

4. Query the subscription database table and notice that the value of 2
has been stored in the weeklength field for the subscription record you
just renewed

5. Apply the patch

6. Renew the subscription and notice that there is now a sublength dropdown box
containing issues, weeks and months

7. Set the month value to 3

8. Query the database and notice that 3 was stored in the monthlength
field for the subscription record

9. Create a new subscription and select the sub length values of issues
and 3

10. Query the database and notice that the numberlength field for the
subscription you just created is set to 3 showing that the sublength
dropbox is still working for creating a new subscription

Sponsored-By: Catalyst IT

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the QA Contact for the bug.

From bugzilla-daemon at bugs.koha-community.org  Mon Nov 27 05:13:21 2017
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 27 Nov 2017 04:13:21 +0000
Subject: [Koha-bugs] [Bug 7046] subscription renewal period should be a pull
	down
In-Reply-To: <bug-7046-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-7046-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-7046-70-Z1iT529IVx@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7046

Alex Buckley <alexbuckley at catalyst.net.nz> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|NEW                         |Needs Signoff

-- 
You are receiving this mail because:
You are the QA Contact for the bug.
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Nov 27 05:41:17 2017
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 27 Nov 2017 04:41:17 +0000
Subject: [Koha-bugs] [Bug 17602] Integrate support for
	OneClickdigital/Recorded Books API
In-Reply-To: <bug-17602-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-17602-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-17602-70-TvuuZVt2cS@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17602

Srdjan Jankovic <srdjan at catalyst.net.nz> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #69101|0                           |1
        is obsolete|                            |

--- Comment #67 from Srdjan Jankovic <srdjan at catalyst.net.nz> ---
Created attachment 69357
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=69357&action=edit
Bug 17602: Translations rework

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Nov 27 05:41:29 2017
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 27 Nov 2017 04:41:29 +0000
Subject: [Koha-bugs] [Bug 17602] Integrate support for
	OneClickdigital/Recorded Books API
In-Reply-To: <bug-17602-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-17602-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-17602-70-pomUm7mE14@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17602

--- Comment #68 from Srdjan Jankovic <srdjan at catalyst.net.nz> ---
Created attachment 69358
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=69358&action=edit
Bug 17602: fix RecordedBooks results pagination

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Nov 27 05:41:41 2017
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 27 Nov 2017 04:41:41 +0000
Subject: [Koha-bugs] [Bug 17602] Integrate support for
	OneClickdigital/Recorded Books API
In-Reply-To: <bug-17602-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-17602-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-17602-70-bT8hJwZ0iB@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17602

--- Comment #69 from Srdjan Jankovic <srdjan at catalyst.net.nz> ---
Created attachment 69359
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=69359&action=edit
Bug 17602: Removed unused param to RecordedBooks API

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Nov 27 05:43:32 2017
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 27 Nov 2017 04:43:32 +0000
Subject: [Koha-bugs] [Bug 17602] Integrate support for
	OneClickdigital/Recorded Books API
In-Reply-To: <bug-17602-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-17602-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-17602-70-ji6fv2g9Xt@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17602

--- Comment #70 from Srdjan Jankovic <srdjan at catalyst.net.nz> ---
(In reply to Jonathan Druart from comment #64)

> > > 2. Strings from .js files are not translatable, `git grep MSG_` to know how
> > > to make them translatable.
> > 
> > Done. Please let me know if it's not what you had in mind.
> 
> I am not sure to understand what you did, I already fixed the some
> translations (patch "Bug 17602: Ease translation") from .tt, you needed to
> fix the strings in .js files (.inc and .tt were ok)

This should be fine now.

> 
> > > 3. I see code related to pagination, but I do not see the previous/next
> > > buttons. I only see the OPACnumSearchResults first results.
> > 
> > Yes, at some stage the idea was to integrate all external searches into the
> > main results page, so I stopped short of implementing paging - will be
> > thrown away. Is it acceptable to leave as is?
> 
> I do not think we should integrate code that is not used.

Actually that was a bug. Fixed.

> 
> > > And a question:
> > > Koha/ExternalContent/RecordedBooks.pm
> > >  76                 user_agent_params => { agent => $class->agent_string }
> > > Where is this used?
> > 
> > It is a param for WebService::ILS. Cannot remember any more, possibly was a
> > requirement for a provider that even did not get implemented.
> 
> So we remove?

Removed.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Nov 27 09:57:11 2017
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 27 Nov 2017 08:57:11 +0000
Subject: [Koha-bugs] [Bug 19618] Automatic/standing holds
In-Reply-To: <bug-19618-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-19618-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-19618-70-o3VKt3IcPX@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19618

Magnus Enger <magnus at libriotech.no> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |magnus at libriotech.no

--- Comment #1 from Magnus Enger <magnus at libriotech.no> ---
Not sure I understand this one. Is it similar/related to Bug 8809 - Cascading
Holds?

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Nov 27 09:58:16 2017
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 27 Nov 2017 08:58:16 +0000
Subject: [Koha-bugs] [Bug 19605] ILL backends should be pluggable through
 regular Koha plugins
In-Reply-To: <bug-19605-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-19605-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-19605-70-C61Fy8BnOD@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19605

Magnus Enger <magnus at libriotech.no> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |magnus at libriotech.no

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Nov 27 09:58:27 2017
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 27 Nov 2017 08:58:27 +0000
Subject: [Koha-bugs] [Bug 19588] There is no ILL requests history
In-Reply-To: <bug-19588-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-19588-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-19588-70-WsLbovIa4W@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19588

Magnus Enger <magnus at libriotech.no> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |magnus at libriotech.no

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Nov 27 09:58:38 2017
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 27 Nov 2017 08:58:38 +0000
Subject: [Koha-bugs] [Bug 19587] "Place request with partners" button must
 be hidden if no partners defined
In-Reply-To: <bug-19587-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-19587-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-19587-70-XMdw0Djojd@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19587

Magnus Enger <magnus at libriotech.no> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |magnus at libriotech.no

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Nov 27 10:40:16 2017
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 27 Nov 2017 09:40:16 +0000
Subject: [Koha-bugs] [Bug 14769] Authorities merge: Set correct indicators
 in biblio field
In-Reply-To: <bug-14769-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-14769-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-14769-70-e02YKb375E@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14769

--- Comment #12 from Marcel de Rooy <m.de.rooy at rijksmuseum.nl> ---
(In reply to Janusz Kaczmarek from comment #10)
> Hello to all.  To not open a new bug I would like to submit here a patch
> that should fix this painful and far-too-long-still-not-resolved issue.  The
> proposed approach relies on authority records (which should be
> correct--that's exactly why they are called 'authority' records). 
> Especially MARC 21 case, as stated by Zeno, is more complex, specially for
> 6XX (2nd ind., $2 subfield etc.)
> 
> To test -- have some authority recs. with different tags (eg. 100, 130,
> 150), use them in biblio, especially in 6XX, 7XX (setting 2nd ind).
> Have running indexer and proper value of AuthorityMergeLimit, i.e. not 0.
> Then play with indicators in authorities. For MARC 21 auth used in 6XX
> play also with 008/11 and 040 $f (if 008/11 set to 'z').  Have a look
> at the results in biblio (see subfield $2 in MARC 21 6XX if 008/11 = z
> and 040 $f defined).

Hi Janusz
Thx for submitting this proposal. It really looks interesting. Will need more
time to have a closer look, but I am glad that we take a next step.
Quick question: The patch is MARC21 oriented; what about the UNIMARC side ?

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Nov 27 10:55:26 2017
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 27 Nov 2017 09:55:26 +0000
Subject: [Koha-bugs] [Bug 17721] Do we need utf8_bin collation on
	tagsubfield?
In-Reply-To: <bug-17721-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-17721-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-17721-70-GheYRGI7U3@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17721

--- Comment #4 from Marcel de Rooy <m.de.rooy at rijksmuseum.nl> ---
(In reply to Katrin Fischer from comment #3)
> We need the table or the column to be case sensitive in order to be able to
> configure, store and retrieve uppercase and lowercase subfields separately.
> 
> I am no MySQL expert, so can't tell what is the perfect type to use for that
> use case.
> 
> Documenting the behaviour is of course always a good idea. A comment in
> kohastructure.sql maybe?

I am all for a comment at least.
As mentioned before, using uppercase subfields is not MARC conform.
https://www.loc.gov/marc/96principl.html tells me:
===
Subfield codes in the MARC 21 formats consist of two characters--a delimiter
[1F(16), 8-bit], followed by a data element identifier. A data element
identifier may be any lowercase alphabetic or numeric character.
===
Dont be confused about the delimiter. The last sentence about data element is
important.

Since many libraries seem to use the concept, we could permit it (somewhat
reluctantly). A comment that we use this collation for that reason should be
added in kohastructure.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Nov 27 11:21:56 2017
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 27 Nov 2017 10:21:56 +0000
Subject: [Koha-bugs] [Bug 18458] Merging authority record incorrectly orders
	subfields
In-Reply-To: <bug-18458-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-18458-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-18458-70-VW8cJKI9yW@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18458

Marcel de Rooy <m.de.rooy at rijksmuseum.nl> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Needs Signoff               |Failed QA

--- Comment #5 from Marcel de Rooy <m.de.rooy at rijksmuseum.nl> ---
Janusz,
Thx again for this patch.
I am not so sure though if your code really makes sub merge easier (it is hard
enough already).
Couldnt we do the following in order to keep the order intact:

Copy all fields in original order including $9.
Overwrite the authority controlled fields. If $overwrite, delete a subfield
that is not controlled (only skip $9). [A hypothetical question: what about
repeated subfields?]
Update $9 finally.

Another thing:
-                    append_fields_ordered( $marcrecord, $field_to );
+                    $marcrecord->insert_fields_ordered($field_to);
This is a regression. Look at the comments in append_fields_ordered. You change
the order of fields here.

Finally, we need some tests to support your changes. Have a look at
t/db_dependent/Authority/Merge.t :)

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Nov 27 11:51:49 2017
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 27 Nov 2017 10:51:49 +0000
Subject: [Koha-bugs] [Bug 18547] On shelf holds allowed > "If all
 unavailable" ignores default hold policy
In-Reply-To: <bug-18547-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-18547-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-18547-70-jv6HXHtsv7@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18547

--- Comment #22 from Marcel de Rooy <m.de.rooy at rijksmuseum.nl> ---
I was looking at 4319 that also proposes changes for this sub in Reserves, and
somehow came here.

The changes here seem too selective to me.

Why are you looking at $branchitemrule->{holdallowed} == 1 only? Why do you not
check the 0 value (no holds allowed) ? And why do you add this test only for If
all unavailable? Should it not be tested globally, over the different values of
On shelf holds allowed?

Does not look good to me. Do I overlook something ?

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Nov 27 11:52:43 2017
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 27 Nov 2017 10:52:43 +0000
Subject: [Koha-bugs] [Bug 18547] On shelf holds allowed > "If all
 unavailable" ignores default hold policy
In-Reply-To: <bug-18547-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-18547-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-18547-70-p3Smvshu5E@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18547

Marcel de Rooy <m.de.rooy at rijksmuseum.nl> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
           Keywords|Academy                     |

--- Comment #23 from Marcel de Rooy <m.de.rooy at rijksmuseum.nl> ---
Removed Academy. Should (generally) not be added to Holds patches.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Nov 27 11:59:08 2017
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 27 Nov 2017 10:59:08 +0000
Subject: [Koha-bugs] [Bug 4319] waiting items cannot be reserved
In-Reply-To: <bug-4319-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-4319-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-4319-70-O71j41JsOv@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=4319

Marcel de Rooy <m.de.rooy at rijksmuseum.nl> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
           See Also|                            |https://bugs.koha-community
                   |                            |.org/bugzilla3/show_bug.cgi
                   |                            |?id=18547

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Nov 27 11:59:08 2017
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 27 Nov 2017 10:59:08 +0000
Subject: [Koha-bugs] [Bug 18547] On shelf holds allowed > "If all
 unavailable" ignores default hold policy
In-Reply-To: <bug-18547-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-18547-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-18547-70-Lpw3HIoiFT@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18547

Marcel de Rooy <m.de.rooy at rijksmuseum.nl> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
           See Also|                            |https://bugs.koha-community
                   |                            |.org/bugzilla3/show_bug.cgi
                   |                            |?id=4319

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Nov 27 11:59:47 2017
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 27 Nov 2017 10:59:47 +0000
Subject: [Koha-bugs] [Bug 4319] waiting items cannot be reserved
In-Reply-To: <bug-4319-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-4319-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-4319-70-jR3kSa5TDA@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=4319

--- Comment #57 from Marcel de Rooy <m.de.rooy at rijksmuseum.nl> ---
Conflicts now with just pushed 18547

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Nov 27 12:27:10 2017
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 27 Nov 2017 11:27:10 +0000
Subject: [Koha-bugs] [Bug 19234] Add query parameters handling helpers
In-Reply-To: <bug-19234-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-19234-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-19234-70-Ph5Lzq6eEB@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19234

Kyle M Hall <kyle at bywatersolutions.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Signed Off                  |Passed QA

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Nov 27 12:27:13 2017
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 27 Nov 2017 11:27:13 +0000
Subject: [Koha-bugs] [Bug 19234] Add query parameters handling helpers
In-Reply-To: <bug-19234-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-19234-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-19234-70-yUQyRGHkOF@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19234

Kyle M Hall <kyle at bywatersolutions.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #67785|0                           |1
        is obsolete|                            |
  Attachment #67786|0                           |1
        is obsolete|                            |
  Attachment #67787|0                           |1
        is obsolete|                            |

--- Comment #29 from Kyle M Hall <kyle at bywatersolutions.com> ---
Created attachment 69360
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=69360&action=edit
Bug 19234: Unit tests for query parameters handling helpers

This patch adds unit tests for the new query parameters handling Mojo plugin.

Sponsored-by: Camden County
Sponsored-by: ByWater Solutions

Signed-off-by: Kyle M Hall <kyle at bywatersolutions.com>
Signed-off-by: Tomas Cohen Arazi <tomascohen at theke.io>

Signed-off-by: Kyle M Hall <kyle at bywatersolutions.com>

Signed-off-by: Lari Taskula <lari.taskula at jns.fi>

Signed-off-by: Kyle M Hall <kyle at bywatersolutions.com>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Nov 27 12:27:20 2017
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 27 Nov 2017 11:27:20 +0000
Subject: [Koha-bugs] [Bug 19234] Add query parameters handling helpers
In-Reply-To: <bug-19234-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-19234-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-19234-70-hll3g0BGSI@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19234

--- Comment #30 from Kyle M Hall <kyle at bywatersolutions.com> ---
Created attachment 69361
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=69361&action=edit
Bug 19234: Add query parameters handling helpers

This patch introduces a Mojolicious plugin to be used on the REST api.
It adds a helper method:

generate_dbic_query
===================

When used, it generates what's needed to perform a search on
DBIC/Koha::Objects like this:

    my $params  = $c->validation->output;
    my ($filtered_params, $reserved_params) =
$c->extract_reserved_params($params);

    my $filter = do_smth($filtered_params, $reserved_params);
    my $attributes = do_smth_reserved($reserved_params);

    my $patrons = Koha::Patrons->search( $filter, $attributes );

It introduces reserved param names:
- _match
- _order_by
- _page
- _per_page

They are reserved for later usage (pagination, matching algorithm on building
DB queries)

All the plugin's behaviour is tested.

To test:
- Run:
  $ sudo koha-shell kohadev
 k$ cd kohaclone
 k$ prove t/Koha/REST/Plugin/Query.t
=> SUCCESS: Tests pass!
- Sign off :-D

Sponsored-by: ByWater solutions
Sponsored-by: Camden County

Signed-off-by: Kyle M Hall <kyle at bywatersolutions.com>
Signed-off-by: Tomas Cohen Arazi <tomascohen at theke.io>

Signed-off-by: Kyle M Hall <kyle at bywatersolutions.com>

Signed-off-by: Lari Taskula <lari.taskula at jns.fi>

Signed-off-by: Kyle M Hall <kyle at bywatersolutions.com>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Nov 27 12:27:23 2017
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 27 Nov 2017 11:27:23 +0000
Subject: [Koha-bugs] [Bug 19234] Add query parameters handling helpers
In-Reply-To: <bug-19234-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-19234-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-19234-70-7EowfueMQC@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19234

--- Comment #31 from Kyle M Hall <kyle at bywatersolutions.com> ---
Created attachment 69362
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=69362&action=edit
Bug 19234: (followup) Make Query plugin available to endpoints

Signed-off-by: Kyle M Hall <kyle at bywatersolutions.com>

Signed-off-by: Kyle M Hall <kyle at bywatersolutions.com>

Signed-off-by: Lari Taskula <lari.taskula at jns.fi>

Signed-off-by: Kyle M Hall <kyle at bywatersolutions.com>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Nov 27 12:33:49 2017
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 27 Nov 2017 11:33:49 +0000
Subject: [Koha-bugs] [Bug 19694] New: Edited shipping cost in invoice
	doesn't save
Message-ID: <bug-19694-70@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19694

            Bug ID: 19694
           Summary: Edited shipping cost in invoice doesn't save
 Change sponsored?: ---
           Product: Koha
           Version: master
          Hardware: All
                OS: All
            Status: NEW
          Severity: major
          Priority: P5 - low
         Component: Acquisitions
          Assignee: koha-bugs at lists.koha-community.org
          Reporter: katrin.fischer at bsz-bw.de
        QA Contact: testopia at bugs.koha-community.org

If you change the shipping cost in an existing invoice, the page reloads on
saving and gives you a success message, but the amount stays the same.

Tested so far in 16.11.13 and 3.22.18.

To test:
- Search for an existing invoice
- Show details
- Changing shipping cost
- Save
- Verify the old amount is still shown, although there is a success message on
top

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Nov 27 12:35:47 2017
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 27 Nov 2017 11:35:47 +0000
Subject: [Koha-bugs] [Bug 19369] Add a helper function for translating
 pagination params into SQL:: Abstract
In-Reply-To: <bug-19369-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-19369-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-19369-70-IOrUnlnCzu@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19369

Kyle M Hall <kyle at bywatersolutions.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Signed Off                  |Passed QA

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Nov 27 12:35:50 2017
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 27 Nov 2017 11:35:50 +0000
Subject: [Koha-bugs] [Bug 19369] Add a helper function for translating
 pagination params into SQL:: Abstract
In-Reply-To: <bug-19369-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-19369-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-19369-70-zS1hD2Icki@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19369

Kyle M Hall <kyle at bywatersolutions.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #67544|0                           |1
        is obsolete|                            |

--- Comment #7 from Kyle M Hall <kyle at bywatersolutions.com> ---
Created attachment 69363
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=69363&action=edit
Bug 19369: Unit tests

Signed-off-by: Lari Taskula <lari.taskula at jns.fi>

Signed-off-by: Kyle M Hall <kyle at bywatersolutions.com>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Nov 27 12:35:56 2017
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 27 Nov 2017 11:35:56 +0000
Subject: [Koha-bugs] [Bug 19369] Add a helper function for translating
 pagination params into SQL:: Abstract
In-Reply-To: <bug-19369-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-19369-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-19369-70-9gWmgtdEF7@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19369

Kyle M Hall <kyle at bywatersolutions.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #67545|0                           |1
        is obsolete|                            |

--- Comment #8 from Kyle M Hall <kyle at bywatersolutions.com> ---
Created attachment 69364
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=69364&action=edit
Bug 19369: Add helper function for pagination attributes generation

This patch introduces a new helper function to the
Koha::REST::Plugin::Pagination
plugin, called 'dbic_merge_pagination'.

This simple function adds SQL::Abstract pagination attributes ('page' and
'rows') to the
passed $filter hashref.

To test:
- Apply this patches
- Run:
  $ koha-shell kohadev
 k$ cd kohaclone
 k$ prove t/Koha/REST/Plugin/Pagination.t
=> SUCCESS: Tests pass!
- Sign off :-D

Sponsored-by: Camden County

Signed-off-by: Lari Taskula <lari.taskula at jns.fi>

Signed-off-by: Kyle M Hall <kyle at bywatersolutions.com>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Nov 27 12:37:22 2017
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 27 Nov 2017 11:37:22 +0000
Subject: [Koha-bugs] [Bug 19278] Add a configurable default page size for
	endpoints
In-Reply-To: <bug-19278-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-19278-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-19278-70-1M6OxEhT8e@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19278

Kyle M Hall <kyle at bywatersolutions.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Signed Off                  |Passed QA

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Nov 27 12:37:24 2017
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 27 Nov 2017 11:37:24 +0000
Subject: [Koha-bugs] [Bug 19278] Add a configurable default page size for
	endpoints
In-Reply-To: <bug-19278-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-19278-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-19278-70-BSi0ZY4TrJ@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19278

Kyle M Hall <kyle at bywatersolutions.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #67790|0                           |1
        is obsolete|                            |
  Attachment #67791|0                           |1
        is obsolete|                            |
  Attachment #67792|0                           |1
        is obsolete|                            |
  Attachment #67793|0                           |1
        is obsolete|                            |

--- Comment #22 from Kyle M Hall <kyle at bywatersolutions.com> ---
Created attachment 69365
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=69365&action=edit
Bug 19278: Add RESTdefaultPageSize syspref

Signed-off-by: Lari Taskula <lari.taskula at jns.fi>

Signed-off-by: Kyle M Hall <kyle at bywatersolutions.com>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Nov 27 12:37:31 2017
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 27 Nov 2017 11:37:31 +0000
Subject: [Koha-bugs] [Bug 19278] Add a configurable default page size for
	endpoints
In-Reply-To: <bug-19278-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-19278-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-19278-70-3qIRGtLgZo@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19278

--- Comment #23 from Kyle M Hall <kyle at bywatersolutions.com> ---
Created attachment 69366
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=69366&action=edit
Bug 19278: Unit tests

This patch introduces tests for a behaviour change in
Koha::REST::Plugin::Pagination.

To test:
- Run:
  $ sudo koha-shell kohadev
 k$ cd kohaclone
 k$ prove t/Koha/REST/Plugin/Pagination.t
=> FAIL: Tests should fail without the followup patch applied

Sponsored-by: Camden County
Sponsored-by: Bywater Solutions

Signed-off-by: Lari Taskula <lari.taskula at jns.fi>

Signed-off-by: Kyle M Hall <kyle at bywatersolutions.com>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Nov 27 12:37:34 2017
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 27 Nov 2017 11:37:34 +0000
Subject: [Koha-bugs] [Bug 19278] Add a configurable default page size for
	endpoints
In-Reply-To: <bug-19278-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-19278-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-19278-70-62x1gCDQq7@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19278

--- Comment #24 from Kyle M Hall <kyle at bywatersolutions.com> ---
Created attachment 69367
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=69367&action=edit
Bug 19278: Make the pagination plugin use RESTdefaultPageSize

This bug introduces a new syspref RESTdefaultPageSize that is used on
the Koha::REST::Plugin::Pagination plugin to default to a valid value
for the page size if the param is not present on the query.

This patch also considers the situation in which no 'page' param is
passed, and no header should be added.

To test:
- Run:
  $ sudo koha-shell kohadev
 k$ cd kohaclone
 k$ prove t/Koha/REST/Plugin/Pagination.t
=> FAIL: Tests fail because the plugin doesn't behave as the tests
expect.
- Apply this patch
- Run:
 k$ prove t/Koha/REST/Plugin/Pagination.t
=> SUCCESS: Tests pass!
- Sign off :-D

Sponsored-by: Camden County
Sponsored-by: ByWater Solutions

Signed-off-by: Lari Taskula <lari.taskula at jns.fi>

Signed-off-by: Kyle M Hall <kyle at bywatersolutions.com>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Nov 27 12:37:37 2017
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 27 Nov 2017 11:37:37 +0000
Subject: [Koha-bugs] [Bug 19278] Add a configurable default page size for
	endpoints
In-Reply-To: <bug-19278-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-19278-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-19278-70-cXj7S9Wnn5@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19278

--- Comment #25 from Kyle M Hall <kyle at bywatersolutions.com> ---
Created attachment 69368
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=69368&action=edit
Bug 19278: Mention RESTdefaultPageSize in POD

This patch adds information about RESTdefaultPageSize usage
when the per_page parameter is absent on the query.

Signed-off-by: Lari Taskula <lari.taskula at jns.fi>

Signed-off-by: Kyle M Hall <kyle at bywatersolutions.com>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Nov 27 12:41:12 2017
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 27 Nov 2017 11:41:12 +0000
Subject: [Koha-bugs] [Bug 19695] New: Uncertain prices should not use find
 in list context
Message-ID: <bug-19695-70@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19695

            Bug ID: 19695
           Summary: Uncertain prices should not use find in list context
 Change sponsored?: ---
           Product: Koha
           Version: master
          Hardware: All
                OS: All
            Status: NEW
          Severity: normal
          Priority: P5 - low
         Component: Acquisitions
          Assignee: koha-bugs at lists.koha-community.org
          Reporter: stefan.berndtsson at ub.gu.se
        QA Contact: testopia at bugs.koha-community.org

When clicking on Uncertain prices button from a basket, the log fails with the
following message:
Cannot use "->find" in list context at <path>/acqui/uncertainprice.pl line 76.

Similar to Bug 18179.

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Nov 27 12:41:44 2017
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 27 Nov 2017 11:41:44 +0000
Subject: [Koha-bugs] [Bug 19695] Uncertain prices should not use find in
	list context
In-Reply-To: <bug-19695-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-19695-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-19695-70-6lINkDmEP6@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19695

--- Comment #1 from Stefan Berndtsson <stefan.berndtsson at ub.gu.se> ---
Created attachment 69369
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=69369&action=edit
Fix another instance of ->find in list context.

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Nov 27 12:43:45 2017
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 27 Nov 2017 11:43:45 +0000
Subject: [Koha-bugs] [Bug 4319] waiting items cannot be reserved
In-Reply-To: <bug-4319-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-4319-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-4319-70-yfPwrcMn3l@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=4319

Marcel de Rooy <m.de.rooy at rijksmuseum.nl> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|BLOCKED                     |Failed QA

--- Comment #58 from Marcel de Rooy <m.de.rooy at rijksmuseum.nl> ---
Are you fixing a missing status (Transit) from GetReserveStatus by working
around it in IsAvailableForItemLevelRequest ? (See above too)
What about other calls of GetReserveStatus ?

-                [% IF ( AllowOnShelfHolds OR ItemsIssued ) %]
+                [% IF ( AllowOnShelfHolds OR ItemsIssued OR
ItemsWaitingOrInTransit ) %]
Would it be easier to just have one template var for this?

+my $itemsWaitingOrInTransit = Koha::Holds->search(
+    {
+        biblionumber => $biblionumber,
+        found => ['W', 'T']
+    })->count();
+unless ($itemsWaitingOrInTransit) {
+    foreach my $item ( Koha::Items->search(biblionumber => $biblionumber) ) {
+        $itemsWaitingOrInTransit = 1 if $item->get_transfer;
+    }
+}
Move this code into a sub ? And test it ?

I think we are too late anyway to get this into the new release. Some of the
points mentioned are no blockers, but imo the code still needs some attention.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Nov 27 12:46:28 2017
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 27 Nov 2017 11:46:28 +0000
Subject: [Koha-bugs] [Bug 4319] waiting items cannot be reserved
In-Reply-To: <bug-4319-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-4319-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-4319-70-s5tCWQlJht@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=4319

--- Comment #59 from Katrin Fischer <katrin.fischer at bsz-bw.de> ---
I know quite a few libraries of ours would be happy to see this fixed. As it is
classified as a bugfix (correctly) it could still go into 17.11.x later on.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Nov 27 13:01:01 2017
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 27 Nov 2017 12:01:01 +0000
Subject: [Koha-bugs] [Bug 18822] Advanced editor - Rancor - searching broken
 under Elasticsearch
In-Reply-To: <bug-18822-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-18822-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-18822-70-V8vb1QiAlf@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18822

--- Comment #10 from Marcel de Rooy <m.de.rooy at rijksmuseum.nl> ---
+        my $fixed_rec;
+        eval { $fixed_rec = MARC::Record::new_from_xml( $set->{hits}->[$j],
'UTF-8' ) };
+        $set->{hits}->[$j] = $fixed_rec unless $@;

No way to know what to expect ? Is it from internal or external ? Do we have
properties of these external ones ?
And can we check ref($set->{hits}->[$j]) to see if it is already MARC::Record ?

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Nov 27 13:04:13 2017
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 27 Nov 2017 12:04:13 +0000
Subject: [Koha-bugs] [Bug 18816] Make CataloguingLog work in production by
 preventing circulation from spamming the log
In-Reply-To: <bug-18816-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-18816-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-18816-70-J0tQCsHRIW@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18816

Marcel de Rooy <m.de.rooy at rijksmuseum.nl> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
           Severity|normal                      |enhancement
                 CC|                            |m.de.rooy at rijksmuseum.nl

--- Comment #11 from Marcel de Rooy <m.de.rooy at rijksmuseum.nl> ---
This imo is an enhancement.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Nov 27 13:09:39 2017
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 27 Nov 2017 12:09:39 +0000
Subject: [Koha-bugs] [Bug 18907] Warning "dpkg-source: warning: relation <
 is deprecated: use < < or <="
In-Reply-To: <bug-18907-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-18907-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-18907-70-9JknSfVEef@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18907

Marcel de Rooy <m.de.rooy at rijksmuseum.nl> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #68807|0                           |1
        is obsolete|                            |
  Attachment #68808|0                           |1
        is obsolete|                            |

--- Comment #6 from Marcel de Rooy <m.de.rooy at rijksmuseum.nl> ---
Created attachment 69370
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=69370&action=edit
Bug 18907: Build has deprecating message

Following the instructions at:
https://wiki.koha-community.org/wiki/Building_Debian_Packages_-_The_Easy_Way
Receiving the following message in the build:
dpkg-source: warning: relation < is deprecated: use << or <=

This patch tweaks the list-deps.
git diff origin/master -- debian/list-deps shows just the one line
changed from < to << as per the messages suggestion and eythian's
suggestion on IRC:
http://irc.koha-community.org/koha/2017-07-06#i_1950698

The control file can be regenerated from the command-line:
./debian/update-control
However, it will be attached separately.

Signed-off-by: Josef Moravec <josef.moravec at gmail.com>

Signed-off-by: Marcel de Rooy <m.de.rooy at rijksmuseum.nl>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Nov 27 13:09:36 2017
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 27 Nov 2017 12:09:36 +0000
Subject: [Koha-bugs] [Bug 18907] Warning "dpkg-source: warning: relation <
 is deprecated: use < < or <="
In-Reply-To: <bug-18907-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-18907-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-18907-70-N6kRtGhGQg@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18907

Marcel de Rooy <m.de.rooy at rijksmuseum.nl> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Signed Off                  |Passed QA
   Patch complexity|---                         |Trivial patch

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Nov 27 13:10:00 2017
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 27 Nov 2017 12:10:00 +0000
Subject: [Koha-bugs] [Bug 18907] Warning "dpkg-source: warning: relation <
 is deprecated: use < < or <="
In-Reply-To: <bug-18907-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-18907-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-18907-70-SQE3QUqK5P@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18907

Marcel de Rooy <m.de.rooy at rijksmuseum.nl> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
         QA Contact|testopia at bugs.koha-communit |m.de.rooy at rijksmuseum.nl
                   |y.org                       |
                 CC|                            |m.de.rooy at rijksmuseum.nl

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Nov 27 13:12:11 2017
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 27 Nov 2017 12:12:11 +0000
Subject: [Koha-bugs] [Bug 19551] Cash register report has bad erroneous
 results from wrong order of operations
In-Reply-To: <bug-19551-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-19551-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-19551-70-o0JN0rJpb0@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19551

Marcel de Rooy <m.de.rooy at rijksmuseum.nl> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #68876|0                           |1
        is obsolete|                            |

--- Comment #3 from Marcel de Rooy <m.de.rooy at rijksmuseum.nl> ---
Created attachment 69371
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=69371&action=edit
Bug 19551 - Fix wrong order of operations in cash register report

To test:
1 - Find or create a fine for a patron
2 - Write it off
3 - Home -> Reports -> Cash register
4 - Fill in current date and transaction type 'Write off'
5 - Click Submit
-- see your write off
6 - Fill in previous dates and transaction type 'Write off'
7 - Click Submit
-- see your write off (bad)
8 - Apply patch
9 - Rerun steps 3-7
-- write only visible for current date.

Signed-off-by: Mark Tompsett <mtompset at hotmail.com>

Signed-off-by: Marcel de Rooy <m.de.rooy at rijksmuseum.nl>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Nov 27 13:12:09 2017
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 27 Nov 2017 12:12:09 +0000
Subject: [Koha-bugs] [Bug 19551] Cash register report has bad erroneous
 results from wrong order of operations
In-Reply-To: <bug-19551-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-19551-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-19551-70-DPvg9cKJqN@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19551

Marcel de Rooy <m.de.rooy at rijksmuseum.nl> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Signed Off                  |Passed QA

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Nov 27 13:12:30 2017
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 27 Nov 2017 12:12:30 +0000
Subject: [Koha-bugs] [Bug 19551] Cash register report has bad erroneous
 results from wrong order of operations
In-Reply-To: <bug-19551-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-19551-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-19551-70-jK16rrEUMd@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19551

Marcel de Rooy <m.de.rooy at rijksmuseum.nl> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
         QA Contact|testopia at bugs.koha-communit |m.de.rooy at rijksmuseum.nl
                   |y.org                       |
                 CC|                            |m.de.rooy at rijksmuseum.nl

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Nov 27 13:25:44 2017
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 27 Nov 2017 12:25:44 +0000
Subject: [Koha-bugs] [Bug 19533] Hold pulldown for itemtype is empty if hold
 placement needs override
In-Reply-To: <bug-19533-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-19533-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-19533-70-1U2HS15Wju@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19533

Marcel de Rooy <m.de.rooy at rijksmuseum.nl> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Signed Off                  |Passed QA

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Nov 27 13:26:03 2017
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 27 Nov 2017 12:26:03 +0000
Subject: [Koha-bugs] [Bug 19533] Hold pulldown for itemtype is empty if hold
 placement needs override
In-Reply-To: <bug-19533-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-19533-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-19533-70-3dToBpK4iB@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19533

Marcel de Rooy <m.de.rooy at rijksmuseum.nl> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |m.de.rooy at rijksmuseum.nl
         QA Contact|testopia at bugs.koha-communit |m.de.rooy at rijksmuseum.nl
                   |y.org                       |

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Nov 27 13:25:46 2017
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 27 Nov 2017 12:25:46 +0000
Subject: [Koha-bugs] [Bug 19533] Hold pulldown for itemtype is empty if hold
 placement needs override
In-Reply-To: <bug-19533-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-19533-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-19533-70-qYeZSBinPM@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19533

Marcel de Rooy <m.de.rooy at rijksmuseum.nl> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #68805|0                           |1
        is obsolete|                            |

--- Comment #5 from Marcel de Rooy <m.de.rooy at rijksmuseum.nl> ---
Created attachment 69372
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=69372&action=edit
Bug 19533 - Hold pulldown for itemtype is empty if hold placement needs
override

Test Plan:
1) Enable AllowHoldPolicyOverride
2) Enable AllowHoldItemTypeSelection
3) Create a situation where adding a hold for a patron would trigger a
tooManyReserves
   warning.
4) Note the itemtype pulldown is empty
5) Apply this patch
6) Reload the page
7) Itemtype pulldown should have values

Signed-off-by: Katrin Fischer <katrin.fischer.83 at web.de>

Signed-off-by: Marcel de Rooy <m.de.rooy at rijksmuseum.nl>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Nov 27 13:30:27 2017
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 27 Nov 2017 12:30:27 +0000
Subject: [Koha-bugs] [Bug 19696] New: HoldsQueue.t is failing randomly
Message-ID: <bug-19696-70@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19696

            Bug ID: 19696
           Summary: HoldsQueue.t is failing randomly
 Change sponsored?: ---
           Product: Koha
           Version: unspecified
          Hardware: All
                OS: All
            Status: NEW
          Severity: normal
          Priority: P5 - low
         Component: Test Suite
          Assignee: chris at bigballofwax.co.nz
          Reporter: jonathan.druart at bugs.koha-community.org
        QA Contact: testopia at bugs.koha-community.org

https://jenkins.koha-community.org/job/Koha_Master_D8/294/console

#   Failed test 'Holds queue filling 1st correct hold for default holds policy
'from home library''
#   at t/db_dependent/HoldsQueue.t line 295.
#          got: 'ig5lWyedNiY9jjrOLHEZQMJ'
#     expected: 'b_8YX7Q_M7PjVyGxX9BsaKf'

#   Failed test 'Holds queue filling 2nd correct hold for default holds policy
'from home library''
#   at t/db_dependent/HoldsQueue.t line 296.
#          got: 'b_8YX7Q_M7PjVyGxX9BsaKf'
#     expected: 'ig5lWyedNiY9jjrOLHEZQMJ'
# Looks like you failed 2 tests of 44.
[19:04:35] t/db_dependent/HoldsQueue.t .................................... 
Dubious, test returned 2 (wstat 512, 0x200)
Failed 2/44 subtests

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Nov 27 13:48:51 2017
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 27 Nov 2017 12:48:51 +0000
Subject: [Koha-bugs] [Bug 19530] Prevent multiple transfers from existing
	for one item
In-Reply-To: <bug-19530-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-19530-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-19530-70-GiFXIOATZt@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19530

Marcel de Rooy <m.de.rooy at rijksmuseum.nl> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |m.de.rooy at rijksmuseum.nl
             Status|Signed Off                  |Failed QA

--- Comment #5 from Marcel de Rooy <m.de.rooy at rijksmuseum.nl> ---
    $dbh->do("UPDATE branchtransfers SET datearrived = NOW(), comments = ?
WHERE itemnumber = ?", undef, "Canceled, new transfer from $frombranch to
$tobranch created", $itemnumber);

We should at least limit this update by adding datearrived IS NULL. No need to
update here all arrived items.
In this case you might even wonder if you should not DELETE those records
instead?
I am wondering if transferbook (the sub calling ModItemTransfer) should check
if there is no open transfer in the table. It is possible to add multiple
transfers by selecting different destinations. What do you think?

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Nov 27 14:04:36 2017
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 27 Nov 2017 13:04:36 +0000
Subject: [Koha-bugs] [Bug 19692] Unclosed div in opac-shelves.tt
In-Reply-To: <bug-19692-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-19692-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-19692-70-rKwmWqvGSL@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19692

Marcel de Rooy <m.de.rooy at rijksmuseum.nl> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #69337|0                           |1
        is obsolete|                            |

--- Comment #3 from Marcel de Rooy <m.de.rooy at rijksmuseum.nl> ---
Created attachment 69376
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=69376&action=edit
Bug 19692 : fix unclosed div in opac-shelves.tt

Test plan:
1. set syspref OpacKohaUrl to "Show"
2. Log into the OPAC
3. /cgi-bin/koha/opac-shelves.pl
4. Notice that "Powered by Koha" is not in the footer in this page.
  When on the other tabs it's in the footer (out of .main)
5. Apply this patch
6. Notice that "Powered by Koha" now in the footer in the "your lists" page

Signed-off-by: Dominic Pichette <dominic at inlibro.com>

Signed-off-by: Marcel de Rooy <m.de.rooy at rijksmuseum.nl>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Nov 27 14:04:34 2017
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 27 Nov 2017 13:04:34 +0000
Subject: [Koha-bugs] [Bug 19692] Unclosed div in opac-shelves.tt
In-Reply-To: <bug-19692-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-19692-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-19692-70-kZDVXvomiD@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19692

Marcel de Rooy <m.de.rooy at rijksmuseum.nl> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
   Patch complexity|---                         |Trivial patch
             Status|Signed Off                  |Passed QA

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Nov 27 14:04:46 2017
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 27 Nov 2017 13:04:46 +0000
Subject: [Koha-bugs] [Bug 19692] Unclosed div in opac-shelves.tt
In-Reply-To: <bug-19692-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-19692-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-19692-70-xS94P6szgU@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19692

Marcel de Rooy <m.de.rooy at rijksmuseum.nl> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
         QA Contact|testopia at bugs.koha-communit |m.de.rooy at rijksmuseum.nl
                   |y.org                       |
                 CC|                            |m.de.rooy at rijksmuseum.nl

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Nov 27 14:10:51 2017
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 27 Nov 2017 13:10:51 +0000
Subject: [Koha-bugs] [Bug 19621] Routing lists tab not present when viewing
 'Holds history' tab for a patron
In-Reply-To: <bug-19621-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-19621-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-19621-70-Wb2NNX9CtV@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19621

Marcel de Rooy <m.de.rooy at rijksmuseum.nl> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
           Severity|minor                       |enhancement
                 CC|                            |m.de.rooy at rijksmuseum.nl

--- Comment #3 from Marcel de Rooy <m.de.rooy at rijksmuseum.nl> ---
Seems an enh to me

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Nov 27 14:12:28 2017
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 27 Nov 2017 13:12:28 +0000
Subject: [Koha-bugs] [Bug 18993] Bump libtest-simple-perl to 1.302073
In-Reply-To: <bug-18993-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-18993-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-18993-70-LAZ0cJbd62@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18993

--- Comment #25 from Marcel de Rooy <m.de.rooy at rijksmuseum.nl> ---
What is the current status here? This seems to be needed for two bugs which are
blocked/in discussion..

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Nov 27 14:14:46 2017
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 27 Nov 2017 13:14:46 +0000
Subject: [Koha-bugs] [Bug 18993] Bump libtest-simple-perl to 1.302073
In-Reply-To: <bug-18993-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-18993-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-18993-70-NP5CkVO94J@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18993

Julian Maurice <julian.maurice at biblibre.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Signed Off                  |Passed QA

--- Comment #26 from Julian Maurice <julian.maurice at biblibre.com> ---
Ah I forgot to change status to Passed QA.
Fixed! Thanks Marcel

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Nov 27 14:15:22 2017
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 27 Nov 2017 13:15:22 +0000
Subject: [Koha-bugs] [Bug 19643] Pagination buttons on staged marc
 management are stacking instead of inline
In-Reply-To: <bug-19643-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-19643-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-19643-70-7kxvEf7mYz@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19643

Marcel de Rooy <m.de.rooy at rijksmuseum.nl> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Signed Off                  |Passed QA

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Nov 27 14:15:25 2017
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 27 Nov 2017 13:15:25 +0000
Subject: [Koha-bugs] [Bug 19643] Pagination buttons on staged marc
 management are stacking instead of inline
In-Reply-To: <bug-19643-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-19643-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-19643-70-TwoyQbTIP0@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19643

Marcel de Rooy <m.de.rooy at rijksmuseum.nl> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #69187|0                           |1
        is obsolete|                            |

--- Comment #5 from Marcel de Rooy <m.de.rooy at rijksmuseum.nl> ---
Created attachment 69377
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=69377&action=edit
Bug 19643: Pagination buttons on staged marc management are stacking instead of
inline

This patch modifies the template for staged MARC import management to
correct a problem with the style of pagination links.

To test you must have more than 25 staged imports. Go to Tools -> Staged
MARC management. The pagination links, both at the top and the bottom,
should look correct (use multi-page SQL report results for reference).

Signed-off-by: Nick Clemens <nick at bywatersolutions.com>

Signed-off-by: Marcel de Rooy <m.de.rooy at rijksmuseum.nl>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Nov 27 14:16:15 2017
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 27 Nov 2017 13:16:15 +0000
Subject: [Koha-bugs] [Bug 19643] Pagination buttons on staged marc
 management are stacking instead of inline
In-Reply-To: <bug-19643-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-19643-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-19643-70-QEFq3YyLWe@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19643

Marcel de Rooy <m.de.rooy at rijksmuseum.nl> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
         QA Contact|testopia at bugs.koha-communit |m.de.rooy at rijksmuseum.nl
                   |y.org                       |
                 CC|                            |m.de.rooy at rijksmuseum.nl

--- Comment #6 from Marcel de Rooy <m.de.rooy at rijksmuseum.nl> ---
Removes the string "Page". Should not hinder translation imo.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Nov 27 14:19:34 2017
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 27 Nov 2017 13:19:34 +0000
Subject: [Koha-bugs] [Bug 17467] Introduce a single koha-zebra script to
 handle Zebra daemons for instances
In-Reply-To: <bug-17467-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-17467-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-17467-70-FHyBx5PKZ6@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17467

Tom?s Cohen Arazi <tomascohen at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
            Summary|There should be a           |Introduce a single
                   |koha-zebra script to handle |koha-zebra script to handle
                   |Zebra daemons for instances |Zebra daemons for instances

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Nov 27 14:20:59 2017
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 27 Nov 2017 13:20:59 +0000
Subject: [Koha-bugs] [Bug 19674] Broken indicators of changed fields in
 manage staged MARC records template
In-Reply-To: <bug-19674-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-19674-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-19674-70-KnCZuKvNTN@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19674

Marcel de Rooy <m.de.rooy at rijksmuseum.nl> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #69269|0                           |1
        is obsolete|                            |

--- Comment #3 from Marcel de Rooy <m.de.rooy at rijksmuseum.nl> ---
Created attachment 69378
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=69378&action=edit
Bug 19674: Broken indicators of changed fields in manage staged MARC records
template

This patch returns some CSS to the manage staged MARC records template
which was incorrectly removed by Gug 16538.

To test, apply the patch and go to Tools -> Staged MARC management.
Choose a staged MARC file.

Changing any of the <select> fields in the first section should cause a
label to appear showing that the selection has changed, along with a
link to reset the option to its original state. Clicking 'Reset' should
make the label and the link disappear.

Signed-off-by: Claire Gravely <claire.gravely at bsz-bw.de>

Signed-off-by: Marcel de Rooy <m.de.rooy at rijksmuseum.nl>

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Nov 27 14:20:56 2017
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 27 Nov 2017 13:20:56 +0000
Subject: [Koha-bugs] [Bug 19674] Broken indicators of changed fields in
 manage staged MARC records template
In-Reply-To: <bug-19674-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-19674-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-19674-70-Try26BVxxq@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19674

Marcel de Rooy <m.de.rooy at rijksmuseum.nl> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Signed Off                  |Passed QA

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Nov 27 14:21:22 2017
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 27 Nov 2017 13:21:22 +0000
Subject: [Koha-bugs] [Bug 19674] Broken indicators of changed fields in
 manage staged MARC records template
In-Reply-To: <bug-19674-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-19674-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-19674-70-q8TxUDzhxo@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19674

Marcel de Rooy <m.de.rooy at rijksmuseum.nl> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
         QA Contact|testopia at bugs.koha-communit |m.de.rooy at rijksmuseum.nl
                   |y.org                       |
           Assignee|koha-bugs at lists.koha-commun |oleonard at myacpl.org
                   |ity.org                     |
                 CC|                            |m.de.rooy at rijksmuseum.nl

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Nov 27 14:27:32 2017
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 27 Nov 2017 13:27:32 +0000
Subject: [Koha-bugs] [Bug 19692] Unclosed div in opac-shelves.tt
In-Reply-To: <bug-19692-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-19692-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-19692-70-49hQsSCBSF@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19692

Victor Grousset/tuxayo <victor.grousset at biblibre.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #69376|0                           |1
        is obsolete|                            |

--- Comment #4 from Victor Grousset/tuxayo <victor.grousset at biblibre.com> ---
Created attachment 69379
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=69379&action=edit
Bug 19692 : fix unclosed div in opac-shelves.tt

Test plan:
1. set syspref OpacKohaUrl to "Show"
2. Log into the OPAC
3. /cgi-bin/koha/opac-shelves.pl
4. Notice that "Powered by Koha" is not in the footer in this page.
  When on the other tabs it's in the footer (out of .main)
5. Apply this patch
6. Notice that "Powered by Koha" now in the footer in the "your lists" page

Signed-off-by: Dominic Pichette <dominic at inlibro.com>

Signed-off-by: Marcel de Rooy <m.de.rooy at rijksmuseum.nl>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Nov 27 14:28:15 2017
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 27 Nov 2017 13:28:15 +0000
Subject: [Koha-bugs] [Bug 17467] Introduce a single koha-zebra script to
 handle Zebra daemons for instances
In-Reply-To: <bug-17467-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-17467-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-17467-70-nv2PEbNcj5@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17467

Tom?s Cohen Arazi <tomascohen at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Text to go in the|                            |To ease multi-tenant sites
      release notes|                            |maintenance, several handy
                   |                            |scripts were introduced.
                   |                            |For handling Zebra, 4
                   |                            |scripts were introduced:
                   |                            |koha-start-zebra,
                   |                            |koha-stop-zebra,
                   |                            |koha-restart-zebra and
                   |                            |koha-rebuild-zebra.
                   |                            |This
                   |                            |patch introduces a new
                   |                            |script, koha-zebra, that
                   |                            |unifies those actions
                   |                            |regarding Zebra daemons on
                   |                            |a per instance base,
                   |                            |through the use of option
                   |                            |switches.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Nov 27 14:29:17 2017
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 27 Nov 2017 13:29:17 +0000
Subject: [Koha-bugs] [Bug 19692] Unclosed div in opac-shelves.tt
In-Reply-To: <bug-19692-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-19692-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-19692-70-e6wAgPd64m@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19692

--- Comment #5 from Victor Grousset/tuxayo <victor.grousset at biblibre.com> ---
I've changed the author of the commit to Simon Pouchol (the work was on my
machine).
That might be their first contribution to the codebase, that's why it might
matters :)

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Nov 27 14:29:43 2017
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 27 Nov 2017 13:29:43 +0000
Subject: [Koha-bugs] [Bug 12497] Make OPAC search history feature accessible
 when it should
In-Reply-To: <bug-12497-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-12497-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-12497-70-5BHePNQDXy@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12497

Marcel de Rooy <m.de.rooy at rijksmuseum.nl> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |m.de.rooy at rijksmuseum.nl

--- Comment #12 from Marcel de Rooy <m.de.rooy at rijksmuseum.nl> ---
(In reply to Charles Farmer from comment #9)
> Is this intended behavior to return a 404 whenever a systempreference blocks
> a page in Koha? I feel like the template could simply state to users and
> admin alike that search history is disabled, unless that's deemed too
> verbose for the user's own good.
> 
> But it works, nonetheless, so I'm signing it off.

You will find more examples like:

if ( ! C4::Context->preference('suggestion') ) {
    print $input->redirect("/cgi-bin/koha/errors/404.pl");
    exit;
}

But you are right, nice is something else :)

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Nov 27 14:31:56 2017
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 27 Nov 2017 13:31:56 +0000
Subject: [Koha-bugs] [Bug 12497] Make OPAC search history feature accessible
 when it should
In-Reply-To: <bug-12497-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-12497-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-12497-70-4ziTTG08VT@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12497

Marcel de Rooy <m.de.rooy at rijksmuseum.nl> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Signed Off                  |Passed QA

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Nov 27 14:31:59 2017
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 27 Nov 2017 13:31:59 +0000
Subject: [Koha-bugs] [Bug 12497] Make OPAC search history feature accessible
 when it should
In-Reply-To: <bug-12497-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-12497-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-12497-70-9okc37cnFr@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12497

Marcel de Rooy <m.de.rooy at rijksmuseum.nl> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #69341|0                           |1
        is obsolete|                            |

--- Comment #13 from Marcel de Rooy <m.de.rooy at rijksmuseum.nl> ---
Created attachment 69380
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=69380&action=edit
Bug 12497: Fix search history non-accessible when OPAC was private

(when the user didn't have the "borrowers" permission)

Test plan:
1. Set syspref "OpacPublic" to false (Disable)
2. Log in as a user without any permission
3. Try to access the search history. The link is next to "Log out"
4. Then you should see "Access denied"
5. Apply this patch
6. Refresh the page
7. Then you should see the search history

Signed-off-by: David Bourgault <david.bourgault at inlibro.com>
Signed-off-by: Charles Farmer <charles.farmer at inLibro.com>

Signed-off-by: Marcel de Rooy <m.de.rooy at rijksmuseum.nl>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Nov 27 14:32:04 2017
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 27 Nov 2017 13:32:04 +0000
Subject: [Koha-bugs] [Bug 12497] Make OPAC search history feature accessible
 when it should
In-Reply-To: <bug-12497-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-12497-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-12497-70-PVumRrHKqj@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12497

Marcel de Rooy <m.de.rooy at rijksmuseum.nl> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #69342|0                           |1
        is obsolete|                            |

--- Comment #14 from Marcel de Rooy <m.de.rooy at rijksmuseum.nl> ---
Created attachment 69381
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=69381&action=edit
Bug 12497: Fix OPAC search history reachable by URL even when disabled

Test plan:
1. Set EnableOpacSearchHistory syspref to "Keep"
2. Make a search in the OPAC
3. Go to /cgi-bin/koha/opac-search-history.pl
4. Set the EnableOpacSearchHistory syspref to "Don't keep"
5. Refresh the OPAC page to show that history is still accessible
6. Apply the patch
7. Refresh the OPAC page, you should end on the 404 page
8. Set EnableOpacSearchHistory syspref to "Keep"
9. Go to /cgi-bin/koha/opac-search-history.pl which should be reachable

Signed-off-by: David Bourgault <david.bourgault at inlibro.com>
Signed-off-by: Charles Farmer <charles.farmer at inLibro.com>

Signed-off-by: Marcel de Rooy <m.de.rooy at rijksmuseum.nl>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Nov 27 14:32:25 2017
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 27 Nov 2017 13:32:25 +0000
Subject: [Koha-bugs] [Bug 12497] Make OPAC search history feature accessible
 when it should
In-Reply-To: <bug-12497-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-12497-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-12497-70-G15NwnBNRL@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12497

Marcel de Rooy <m.de.rooy at rijksmuseum.nl> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
         QA Contact|testopia at bugs.koha-communit |m.de.rooy at rijksmuseum.nl
                   |y.org                       |

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Nov 27 14:32:46 2017
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 27 Nov 2017 13:32:46 +0000
Subject: [Koha-bugs] [Bug 12497] Make OPAC search history feature accessible
 when it should
In-Reply-To: <bug-12497-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-12497-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-12497-70-wBvN5jMiIJ@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12497

Marcel de Rooy <m.de.rooy at rijksmuseum.nl> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
   Patch complexity|---                         |Trivial patch

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Nov 27 14:46:14 2017
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 27 Nov 2017 13:46:14 +0000
Subject: [Koha-bugs] [Bug 19697] New: Move template JavaScript to the
 footer: Search results
Message-ID: <bug-19697-70@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19697

            Bug ID: 19697
           Summary: Move template JavaScript to the footer: Search results
 Change sponsored?: ---
           Product: Koha
           Version: master
          Hardware: All
                OS: All
            Status: ASSIGNED
          Severity: enhancement
          Priority: P5 - low
         Component: Templates
          Assignee: oleonard at myacpl.org
          Reporter: oleonard at myacpl.org
        QA Contact: testopia at bugs.koha-community.org
                CC: testopia at bugs.koha-community.org
            Blocks: 17858

In order to conform to best practices for performance staff client template
javascript should be in the footer instead of the header.

This patch will do so for the catalog search results page.


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17858
[Bug 17858] Omnibus: Move staff client JavaScript to the footer
-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Nov 27 14:46:14 2017
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 27 Nov 2017 13:46:14 +0000
Subject: [Koha-bugs] [Bug 17858] Omnibus: Move staff client JavaScript to
	the footer
In-Reply-To: <bug-17858-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-17858-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-17858-70-9FUws7s2A0@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17858

Owen Leonard <oleonard at myacpl.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
         Depends on|                            |19697


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19697
[Bug 19697] Move template JavaScript to the footer: Search results
-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Nov 27 15:03:12 2017
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 27 Nov 2017 14:03:12 +0000
Subject: [Koha-bugs] [Bug 19698] New: "Add message" for patron don' t use
 OPAC description if message type is OPAC
Message-ID: <bug-19698-70@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19698

            Bug ID: 19698
           Summary: "Add message" for patron don't use OPAC description if
                    message type is OPAC
 Change sponsored?: ---
           Product: Koha
           Version: master
          Hardware: All
                OS: All
            Status: NEW
          Severity: enhancement
          Priority: P5 - low
         Component: Patrons
          Assignee: koha-bugs at lists.koha-community.org
          Reporter: sophie.meynieux at biblibre.com
        QA Contact: testopia at bugs.koha-community.org
                CC: gmcharlt at gmail.com, kyle.m.hall at gmail.com

If you want to add a message to a patron, you can choose OPAC or intranet
message type.
Predefined messages are defined in BOR_NOTES authorised value. 
But OPAC description is never used even if message type is OPAC

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.

From bugzilla-daemon at bugs.koha-community.org  Mon Nov 27 15:03:55 2017
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 27 Nov 2017 14:03:55 +0000
Subject: [Koha-bugs] [Bug 19698] "Add message" for patron don' t use OPAC
 description if message type is OPAC
In-Reply-To: <bug-19698-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-19698-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-19698-70-7YmG7ZWr6V@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19698

Sophie MEYNIEUX <sophie.meynieux at biblibre.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
           Severity|enhancement                 |normal

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Nov 27 15:08:39 2017
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 27 Nov 2017 14:08:39 +0000
Subject: [Koha-bugs] [Bug 19699] New: Missing FK on messages table
Message-ID: <bug-19699-70@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19699

            Bug ID: 19699
           Summary: Missing FK on messages table
 Change sponsored?: ---
           Product: Koha
           Version: master
          Hardware: All
                OS: All
            Status: NEW
          Severity: minor
          Priority: P5 - low
         Component: Patrons
          Assignee: koha-bugs at lists.koha-community.org
          Reporter: sophie.meynieux at biblibre.com
        QA Contact: testopia at bugs.koha-community.org
                CC: gmcharlt at gmail.com, kyle.m.hall at gmail.com

Messages table contains messages for patrons. 
There is no FK between borrowers and messages on borrowernumber, so when a
borrower is deleted, associated messages remains indefinitely in messages
table.

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Nov 27 15:14:34 2017
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 27 Nov 2017 14:14:34 +0000
Subject: [Koha-bugs] [Bug 19690] Smart rules: Term "If any unavailable" is
 confusing and just means No
In-Reply-To: <bug-19690-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-19690-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-19690-70-U4vW9RbiYs@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19690

--- Comment #1 from Marcel de Rooy <m.de.rooy at rijksmuseum.nl> ---
Created attachment 69382
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=69382&action=edit
Bug 19690: Smart rules: Term "If any unavailable" is confusing and just means
No

This patch replaces the term by No.
Also "If all unavailable" is refined to "Only if other items unavailable".
The online help text is adjusted.
Two comments in DisallowHoldIfItemsAvailable.t are adjusted too.

Test plan:
Go to smart rules, look at on shelf holds.
Read the help text for this page.

Signed-off-by: Marcel de Rooy <m.de.rooy at rijksmuseum.nl>

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.

From bugzilla-daemon at bugs.koha-community.org  Mon Nov 27 15:14:31 2017
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 27 Nov 2017 14:14:31 +0000
Subject: [Koha-bugs] [Bug 19690] Smart rules: Term "If any unavailable" is
 confusing and just means No
In-Reply-To: <bug-19690-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-19690-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-19690-70-yA8xyrnEDp@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19690

Marcel de Rooy <m.de.rooy at rijksmuseum.nl> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|NEW                         |Needs Signoff
   Patch complexity|---                         |Trivial patch

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Nov 27 15:15:19 2017
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 27 Nov 2017 14:15:19 +0000
Subject: [Koha-bugs] [Bug 19690] Smart rules: Term "If any unavailable" is
 confusing and just means No
In-Reply-To: <bug-19690-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-19690-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-19690-70-bHcK3yHLFn@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19690

Marcel de Rooy <m.de.rooy at rijksmuseum.nl> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
           Assignee|koha-bugs at lists.koha-commun |m.de.rooy at rijksmuseum.nl
                   |ity.org                     |

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Nov 27 15:21:24 2017
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 27 Nov 2017 14:21:24 +0000
Subject: [Koha-bugs] [Bug 19287] Add ability to mark an item 'Lost' from
 'Holds awaiting pickup ' list
In-Reply-To: <bug-19287-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-19287-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-19287-70-174XaXrC0a@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19287

--- Comment #29 from Katrin Fischer <katrin.fischer at bsz-bw.de> ---
I like 1) and 4).
1) would allow to set different values depending on the problem that appeared
when trying to pull the book.
3) / 4) would be more automated as the values would be configured, which is
also nice and wouldn't clutter up the interface.

I don't have a clear preference between those 3 at the moment.

I don't like reusing the long overdue pref 2) as it's often a specific lost
value not used otherwise. Often libaries distinguish between not returned by
user (lost) and not found on the shelf/misplaced items (missing) or move to
different lost status depending on the time it's been not found / times it has
been searched for.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Nov 27 15:24:13 2017
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 27 Nov 2017 14:24:13 +0000
Subject: [Koha-bugs] [Bug 19698] "Add message" for patron don' t use OPAC
 description if message type is OPAC
In-Reply-To: <bug-19698-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-19698-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-19698-70-Rdu5Ljp8tn@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19698

Axelle Aix-Marseille Universit? <axelle.clarisse at univ-amu.fr> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |axelle.clarisse at univ-amu.fr

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Nov 27 15:24:32 2017
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 27 Nov 2017 14:24:32 +0000
Subject: [Koha-bugs] [Bug 19699] Missing FK on messages table
In-Reply-To: <bug-19699-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-19699-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-19699-70-1R2yBDZGM1@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19699

Axelle Aix-Marseille Universit? <axelle.clarisse at univ-amu.fr> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |axelle.clarisse at univ-amu.fr

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Nov 27 15:38:16 2017
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 27 Nov 2017 14:38:16 +0000
Subject: [Koha-bugs] [Bug 19370] Add a helper function for translating
 order_by params into SQL ::Abstract
In-Reply-To: <bug-19370-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-19370-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-19370-70-3gQ68VENAC@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19370

Tom?s Cohen Arazi <tomascohen at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #69307|0                           |1
        is obsolete|                            |

--- Comment #15 from Tom?s Cohen Arazi <tomascohen at gmail.com> ---
Created attachment 69383
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=69383&action=edit
Bug 19370: (QA followup) Use OpenAPI's handling of pipe separated values

This patch makes the helper handling _order_by params expect a list of
values instead of a (to-be-splitted) string.

The idea is that the OpenAPI plugin will take care of splitting
pipe-delimited values if the spec is correctly defined.

Note: In the process I noticed + on the URL represents a space, so the
helper function is updated to handle both + and %2B as ascending.

To test:
- Run:
  $ kshell
 k$ prove t/Koha/REST/Plugin/Query.t
=> SUCCESS: Tests pass!
- Sign off :-D

Edit: Removed rebasing leftover making the tests fail.

Signed-off-by: Tomas Cohen Arazi <tomascohen at theke.io>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Nov 27 15:40:35 2017
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 27 Nov 2017 14:40:35 +0000
Subject: [Koha-bugs] [Bug 19370] Add a helper function for translating
 order_by params into SQL ::Abstract
In-Reply-To: <bug-19370-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-19370-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-19370-70-ydjgpnPuN7@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19370

Tom?s Cohen Arazi <tomascohen at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #69383|0                           |1
        is obsolete|                            |

--- Comment #16 from Tom?s Cohen Arazi <tomascohen at gmail.com> ---
Created attachment 69384
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=69384&action=edit
Bug 19370: (QA followup) Use OpenAPI's handling of pipe separated values

This patch makes the helper handling _order_by params expect a list of
values instead of a (to-be-splitted) string.

The idea is that the OpenAPI plugin will take care of splitting
pipe-delimited values if the spec is correctly defined.

Note: In the process I noticed + on the URL represents a space, so the
helper function is updated to handle both + and %2B as ascending.

To test:
- Run:
  $ kshell
 k$ prove t/Koha/REST/Plugin/Query.t
=> SUCCESS: Tests pass!
- Sign off :-D

Edit: Removed rebasing leftover making the tests fail.

Signed-off-by: Tomas Cohen Arazi <tomascohen at theke.io>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Nov 27 15:42:18 2017
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 27 Nov 2017 14:42:18 +0000
Subject: [Koha-bugs] [Bug 17530] Don't show 'article request' link when no
 article requests are permitted
In-Reply-To: <bug-17530-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-17530-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-17530-70-RN74XybszV@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17530

Owen Leonard <oleonard at myacpl.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
            Version|unspecified                 |master
           Severity|enhancement                 |normal

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Nov 27 15:48:48 2017
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 27 Nov 2017 14:48:48 +0000
Subject: [Koha-bugs] [Bug 19410] Add a helper function for generating object
 searches for the API
In-Reply-To: <bug-19410-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-19410-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-19410-70-YEcijBL4dJ@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19410

Tom?s Cohen Arazi <tomascohen at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #69282|0                           |1
        is obsolete|                            |

--- Comment #27 from Tom?s Cohen Arazi <tomascohen at gmail.com> ---
Created attachment 69385
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=69385&action=edit
Bug 19410: Add Koha::Objects->search_for_api

Following the discussion about the best way to make things simpler for
developing the REST api, I quote Lari's email:

"As many other endpoint will have the exact same usage, by looking at your
example, I would prefer to avoid writing parameter / pagination / sorting /
header handling for each list operation in our API controllers. Do you think
it's possible to centralize all of this e.g. by passing $c into a customized
search sub? Perhaps in Koha::Objects?
so instead we could have something like (ignore my bad choice of naming)...:
sub list_vendors {
  my $c = shift->openapi->valid_input or return;
  my $args = $c->validation->output;
  my $vendors;

  return try {
    $vendors = Koha::Acquisition::Booksellers->api_list_search($c);
    return $c->render(status => 200, openapi => $vendors);
  } catch {
    ...
  }
}"

We all agreed we neeed something like that. Here's a possible implementation. I
take
advantage of the previously written Mojo helpers, that are fully covered by
tests.

I submit this early so anyone can take a look and gather ideas to make it even
better.
I'm already using it (effectively) for the /acquisitions/orders endpoint I'm
writing
on bug 18731.

Thanks!

Signed-off-by: Tomas Cohen Arazi <tomascohen at theke.io>
Signed-off-by: Julian Maurice <julian.maurice at biblibre.com>

Signed-off-by: Lari Taskula <lari.taskula at jns.fi>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Nov 27 15:48:56 2017
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 27 Nov 2017 14:48:56 +0000
Subject: [Koha-bugs] [Bug 19410] Add a helper function for generating object
 searches for the API
In-Reply-To: <bug-19410-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-19410-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-19410-70-La4i3NUxcA@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19410

Tom?s Cohen Arazi <tomascohen at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #69283|0                           |1
        is obsolete|                            |

--- Comment #28 from Tom?s Cohen Arazi <tomascohen at gmail.com> ---
Created attachment 69386
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=69386&action=edit
Bug 19410: Unit tests

Signed-off-by: Tomas Cohen Arazi <tomascohen at theke.io>
Signed-off-by: Julian Maurice <julian.maurice at biblibre.com>

Signed-off-by: Lari Taskula <lari.taskula at jns.fi>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Nov 27 15:49:02 2017
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 27 Nov 2017 14:49:02 +0000
Subject: [Koha-bugs] [Bug 19410] Add a helper function for generating object
 searches for the API
In-Reply-To: <bug-19410-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-19410-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-19410-70-jPKXwIGTwo@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19410

Tom?s Cohen Arazi <tomascohen at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #69284|0                           |1
        is obsolete|                            |

--- Comment #29 from Tom?s Cohen Arazi <tomascohen at gmail.com> ---
Created attachment 69387
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=69387&action=edit
Bug 19410: (follow-up) Fix typo in POD

Signed-off-by: Tomas Cohen Arazi <tomascohen at theke.io>
Signed-off-by: Julian Maurice <julian.maurice at biblibre.com>

Signed-off-by: Lari Taskula <lari.taskula at jns.fi>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Nov 27 15:49:11 2017
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 27 Nov 2017 14:49:11 +0000
Subject: [Koha-bugs] [Bug 19410] Add a helper function for generating object
 searches for the API
In-Reply-To: <bug-19410-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-19410-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-19410-70-CbBVTo5hhl@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19410

Tom?s Cohen Arazi <tomascohen at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #69286|0                           |1
        is obsolete|                            |

--- Comment #30 from Tom?s Cohen Arazi <tomascohen at gmail.com> ---
Created attachment 69388
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=69388&action=edit
Bug 19410: Move search_for_api into a Mojo helper

Signed-off-by: Tomas Cohen Arazi <tomascohen at theke.io>
Signed-off-by: Julian Maurice <julian.maurice at biblibre.com>

Signed-off-by: Lari Taskula <lari.taskula at jns.fi>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Nov 27 15:49:17 2017
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 27 Nov 2017 14:49:17 +0000
Subject: [Koha-bugs] [Bug 19410] Add a helper function for generating object
 searches for the API
In-Reply-To: <bug-19410-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-19410-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-19410-70-R96WOl3PxO@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19410

Tom?s Cohen Arazi <tomascohen at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #69287|0                           |1
        is obsolete|                            |

--- Comment #31 from Tom?s Cohen Arazi <tomascohen at gmail.com> ---
Created attachment 69389
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=69389&action=edit
Bug 19410: (QA followup) Move build_query_params_from_api into a helper

This patch creates the 'build_query_params' helper, instead of the
original function in Koha::Objects.

Unit tests are removed for Koha::Objects::_build_query_params_from_api and
written for the helper plugin.

The objects.search helper gets a call to build_query_params added. Tests for it
updated to match this behaviour change.

To test:
- Apply this patches
- Run:
  $ kshell
 k$ prove t/Koha/REST/Plugin/Query.t \
          t/db_dependent/Koha/Objects.t \
          t/db_dependent/Koha/REST/Plugin/Objects.t
=> SUCCESS: Tests pass!
- Sign off :-D

Signed-off-by: Tomas Cohen Arazi <tomascohen at theke.io>
Signed-off-by: Julian Maurice <julian.maurice at biblibre.com>

Signed-off-by: Lari Taskula <lari.taskula at jns.fi>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Nov 27 15:51:15 2017
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 27 Nov 2017 14:51:15 +0000
Subject: [Koha-bugs] [Bug 19686] objects.search helper needs a to_model param
In-Reply-To: <bug-19686-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-19686-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-19686-70-pnOpHdt0jn@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19686

Tom?s Cohen Arazi <tomascohen at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Patch doesn't apply         |Needs Signoff

--- Comment #4 from Tom?s Cohen Arazi <tomascohen at gmail.com> ---
David, please apply the dependencies in this specific order:

- 19234
- 19369
- 19287
- 19370
- 19410

I've just tested it and it applies correctly.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Nov 27 16:09:17 2017
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 27 Nov 2017 15:09:17 +0000
Subject: [Koha-bugs] [Bug 19496] Patron notes about item does not get
 emailed as indicated
In-Reply-To: <bug-19496-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-19496-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-19496-70-QOtPhwSLNm@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19496

Jonathan Druart <jonathan.druart at bugs.koha-community.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
           Severity|normal                      |major

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Nov 27 16:10:10 2017
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 27 Nov 2017 15:10:10 +0000
Subject: [Koha-bugs] [Bug 18915] Creating a checkout note (patron note)
 sends an incomplete email message
In-Reply-To: <bug-18915-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-18915-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-18915-70-IeyZyTvtYI@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18915

Jonathan Druart <jonathan.druart at bugs.koha-community.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
           Severity|normal                      |major

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Nov 27 16:10:14 2017
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 27 Nov 2017 15:10:14 +0000
Subject: [Koha-bugs] [Bug 19697] Move template JavaScript to the footer:
	Search results
In-Reply-To: <bug-19697-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-19697-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-19697-70-bB2uZUw0ZJ@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19697

Owen Leonard <oleonard at myacpl.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
   Patch complexity|---                         |Small patch
             Status|ASSIGNED                    |Needs Signoff

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Nov 27 16:10:17 2017
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 27 Nov 2017 15:10:17 +0000
Subject: [Koha-bugs] [Bug 19697] Move template JavaScript to the footer:
	Search results
In-Reply-To: <bug-19697-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-19697-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-19697-70-YL64iKW7xW@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19697

--- Comment #1 from Owen Leonard <oleonard at myacpl.org> ---
Created attachment 69390
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=69390&action=edit
Bug 19697: Move template JavaScript to the footer: Search results

This patch modifies the staff client catalog search results template so
that JavaScript is included in the footer instead of the header.

To test, apply the patch and test the various JavaScript-driven features
of the results page: Floating toolbar, cart, lists, cover images, search
to hold, etc.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Nov 27 16:11:28 2017
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 27 Nov 2017 15:11:28 +0000
Subject: [Koha-bugs] [Bug 17858] Omnibus: Move staff client JavaScript to
	the footer
In-Reply-To: <bug-17858-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-17858-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-17858-70-M0sGUEh4ob@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17858

Owen Leonard <oleonard at myacpl.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
         Depends on|                            |19700


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19700
[Bug 19700] Move template JavaScript to the footer: Some circulation pages
-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Nov 27 16:11:28 2017
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 27 Nov 2017 15:11:28 +0000
Subject: [Koha-bugs] [Bug 19700] New: Move template JavaScript to the
 footer: Some circulation pages
Message-ID: <bug-19700-70@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19700

            Bug ID: 19700
           Summary: Move template JavaScript to the footer: Some
                    circulation pages
 Change sponsored?: ---
           Product: Koha
           Version: master
          Hardware: All
                OS: All
            Status: ASSIGNED
          Severity: enhancement
          Priority: P5 - low
         Component: Templates
          Assignee: oleonard at myacpl.org
          Reporter: oleonard at myacpl.org
        QA Contact: testopia at bugs.koha-community.org
                CC: testopia at bugs.koha-community.org
            Blocks: 17858

In order to conform to best practices for performance staff client template
javascript should be in the footer instead of the header.

This patch will do so for some circulation pages.


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17858
[Bug 17858] Omnibus: Move staff client JavaScript to the footer
-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Nov 27 16:39:36 2017
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 27 Nov 2017 15:39:36 +0000
Subject: [Koha-bugs] [Bug 17373] Elasticsearch - Authority mappings for
	UNIMARC
In-Reply-To: <bug-17373-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-17373-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-17373-70-A5ONCpVr6S@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17373

claire.hernandez at biblibre.com <claire.hernandez at biblibre.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |claire.hernandez at biblibre.c
                   |                            |om

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Nov 27 16:43:28 2017
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 27 Nov 2017 15:43:28 +0000
Subject: [Koha-bugs] [Bug 19015] Searches fail with error Fielddata is
 disabled on text fields by default for elastic search 5.3 and 5.4
In-Reply-To: <bug-19015-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-19015-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-19015-70-uaqrrfcDGb@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19015

claire.hernandez at biblibre.com <claire.hernandez at biblibre.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |claire.hernandez at biblibre.c
                   |                            |om

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Nov 27 17:35:21 2017
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 27 Nov 2017 16:35:21 +0000
Subject: [Koha-bugs] [Bug 14769] Authorities merge: Set correct indicators
 in biblio field
In-Reply-To: <bug-14769-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-14769-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-14769-70-nChpGAY1Tz@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14769

--- Comment #13 from Janusz Kaczmarek <januszop at gmail.com> ---
> Thx for submitting this proposal. It really looks interesting. Will need
> more time to have a closer look, but I am glad that we take a next step.
> Quick question: The patch is MARC21 oriented; what about the UNIMARC side ?

Hi Marcel,

Thank you for your comments.  To answer your question, UNIMARC is covered here
in the same way as it is covered in the enhancement introduced with Bug 5262
four years ago (see the discussion there)--at that time I worked mainly in
UNIMARC environment, so I hope it shouldn't be very wrong also now.  (BTW, see
the initial message of Julian.)  UNIMARC is rather straightforward here.  It is
MARC 21 that makes things more complicated.

But really, I should probably reconsider operations on $2 for UNIMARC subject
headings fields in respect to 152 $b in UNIMARC authority record. 

In 2013, also, Magnus reported: "NORMARC does not support authorities at all at
the moment" (still from Bug 5262 discussion).

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Nov 27 17:35:55 2017
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 27 Nov 2017 16:35:55 +0000
Subject: [Koha-bugs] [Bug 19701] New: Modify patron loses password in
	Microsoft Edge
Message-ID: <bug-19701-70@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19701

            Bug ID: 19701
           Summary: Modify patron loses password in Microsoft Edge
 Change sponsored?: ---
           Product: Koha
           Version: 16.05
          Hardware: PC
                OS: Windows
            Status: NEW
          Severity: minor
          Priority: P5 - low
         Component: Browser compatibility
          Assignee: oleonard at myacpl.org
          Reporter: emma.perks at heartofengland.nhs.uk
        QA Contact: testopia at bugs.koha-community.org

In Microsoft Edge editing a patron record takes away the password and you have
to add it back in before you can save the record.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Nov 27 17:46:10 2017
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 27 Nov 2017 16:46:10 +0000
Subject: [Koha-bugs] [Bug 19370] Add a helper function for translating
 order_by params into SQL ::Abstract
In-Reply-To: <bug-19370-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-19370-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-19370-70-o1qM6Qsj9K@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19370

Kyle M Hall <kyle at bywatersolutions.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Signed Off                  |Passed QA

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Nov 27 17:46:13 2017
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 27 Nov 2017 16:46:13 +0000
Subject: [Koha-bugs] [Bug 19370] Add a helper function for translating
 order_by params into SQL ::Abstract
In-Reply-To: <bug-19370-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-19370-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-19370-70-GSdSs9gJyt@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19370

Kyle M Hall <kyle at bywatersolutions.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #67782|0                           |1
        is obsolete|                            |
  Attachment #67783|0                           |1
        is obsolete|                            |
  Attachment #67784|0                           |1
        is obsolete|                            |
  Attachment #69384|0                           |1
        is obsolete|                            |

--- Comment #17 from Kyle M Hall <kyle at bywatersolutions.com> ---
Created attachment 69391
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=69391&action=edit
Bug 19370: Unit tests

Signed-off-by: Lari Taskula <lari.taskula at jns.fi>

Signed-off-by: Kyle M Hall <kyle at bywatersolutions.com>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Nov 27 17:46:19 2017
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 27 Nov 2017 16:46:19 +0000
Subject: [Koha-bugs] [Bug 19370] Add a helper function for translating
 order_by params into SQL ::Abstract
In-Reply-To: <bug-19370-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-19370-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-19370-70-W8wM508KyF@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19370

--- Comment #18 from Kyle M Hall <kyle at bywatersolutions.com> ---
Created attachment 69392
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=69392&action=edit
Bug 19370: Add helper function for order_by attribute generation

This patch introduces a helper function called 'dbic_merge_sorting'
to Koha::REST::Plugin::Query.

This simple function adds SQL::Abstract order_by attribute to the passed
$filter hashref, as explained in the POD.

It introduces a syntax for passing sorting params on the request to the REST
api.
The proposed syntax has been found in the wild, and is pretty trivial to
parse/work with:

    GET /api/v1/<endpoint>?order_by=+column_1|-column_2|column_3

As explained on the POD, + stands for 'asc' and - for 'desc'. If ommited, it
defaults to the
DB engine default (usually asc).

To test:
- Apply this patches
- Run:
  $ sudo koha-shell kohadev
 k$ cd kohaclone
 k$ prove t/Koha/REST/Plugin/Query.t
=> SUCCESS: Tests pass! And they make sense! :-P
- Sign off :-D

Edit: renamed params to match DBIC terminology. My bad :-D (tcohen)

Sponsored-by: Camden County

Signed-off-by: Lari Taskula <lari.taskula at jns.fi>

Signed-off-by: Kyle M Hall <kyle at bywatersolutions.com>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Nov 27 17:46:22 2017
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 27 Nov 2017 16:46:22 +0000
Subject: [Koha-bugs] [Bug 19370] Add a helper function for translating
 order_by params into SQL ::Abstract
In-Reply-To: <bug-19370-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-19370-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-19370-70-IIlEzj3r7P@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19370

--- Comment #19 from Kyle M Hall <kyle at bywatersolutions.com> ---
Created attachment 69393
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=69393&action=edit
Bug 19370: Remove undefined variable warning

Signed-off-by: Tomas Cohen Arazi <tomascohen at theke.io>

Signed-off-by: Lari Taskula <lari.taskula at jns.fi>

Signed-off-by: Kyle M Hall <kyle at bywatersolutions.com>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Nov 27 17:46:25 2017
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 27 Nov 2017 16:46:25 +0000
Subject: [Koha-bugs] [Bug 19370] Add a helper function for translating
 order_by params into SQL ::Abstract
In-Reply-To: <bug-19370-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-19370-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-19370-70-4uFFhYwdlt@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19370

--- Comment #20 from Kyle M Hall <kyle at bywatersolutions.com> ---
Created attachment 69394
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=69394&action=edit
Bug 19370: (QA followup) Use OpenAPI's handling of pipe separated values

This patch makes the helper handling _order_by params expect a list of
values instead of a (to-be-splitted) string.

The idea is that the OpenAPI plugin will take care of splitting
pipe-delimited values if the spec is correctly defined.

Note: In the process I noticed + on the URL represents a space, so the
helper function is updated to handle both + and %2B as ascending.

To test:
- Run:
  $ kshell
 k$ prove t/Koha/REST/Plugin/Query.t
=> SUCCESS: Tests pass!
- Sign off :-D

Edit: Removed rebasing leftover making the tests fail.

Signed-off-by: Tomas Cohen Arazi <tomascohen at theke.io>

Signed-off-by: Kyle M Hall <kyle at bywatersolutions.com>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Nov 27 18:16:46 2017
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 27 Nov 2017 17:16:46 +0000
Subject: [Koha-bugs] [Bug 19700] Move template JavaScript to the footer:
 Some circulation pages
In-Reply-To: <bug-19700-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-19700-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-19700-70-Tdp0U4rbl1@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19700

Owen Leonard <oleonard at myacpl.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
   Patch complexity|---                         |Medium patch
             Status|ASSIGNED                    |Needs Signoff

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Nov 27 18:16:49 2017
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 27 Nov 2017 17:16:49 +0000
Subject: [Koha-bugs] [Bug 19700] Move template JavaScript to the footer:
 Some circulation pages
In-Reply-To: <bug-19700-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-19700-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-19700-70-fqi6KfUjYU@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19700

--- Comment #1 from Owen Leonard <oleonard at myacpl.org> ---
Created attachment 69395
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=69395&action=edit
Bug 19700: Move template JavaScript to the footer: Some circulation pages

This patch modifies some staff client circulation templates so that
JavaScript is included in the footer instead of the header.

To test, apply the patch and test the JavaScript-driven features of the
modified templates: All button controls, DataTables functionality, tabs,
etc.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Nov 27 18:17:44 2017
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 27 Nov 2017 17:17:44 +0000
Subject: [Koha-bugs] [Bug 19695] Uncertain prices should not use find in
	list context
In-Reply-To: <bug-19695-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-19695-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-19695-70-CfryUYeXjV@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19695

Jonathan Druart <jonathan.druart at bugs.koha-community.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
           Assignee|koha-bugs at lists.koha-commun |stefan.berndtsson at ub.gu.se
                   |ity.org                     |
             Status|NEW                         |Needs Signoff
                 CC|                            |jonathan.druart at bugs.koha-c
                   |                            |ommunity.org
           Severity|normal                      |critical

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.

From bugzilla-daemon at bugs.koha-community.org  Mon Nov 27 18:18:20 2017
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 27 Nov 2017 17:18:20 +0000
Subject: [Koha-bugs] [Bug 18539] Forbid Koha::Objects->find calls in list
	context
In-Reply-To: <bug-18539-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-18539-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-18539-70-d7Uroc07AM@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18539

Jonathan Druart <jonathan.druart at bugs.koha-community.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Blocks|                            |19695


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19695
[Bug 19695] Uncertain prices should not use find in list context
-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Nov 27 18:18:20 2017
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 27 Nov 2017 17:18:20 +0000
Subject: [Koha-bugs] [Bug 19695] Uncertain prices should not use find in
	list context
In-Reply-To: <bug-19695-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-19695-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-19695-70-xfNYDGjgJb@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19695

Jonathan Druart <jonathan.druart at bugs.koha-community.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
         Depends on|                            |18539


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18539
[Bug 18539] Forbid Koha::Objects->find calls in list context
-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Nov 27 18:20:08 2017
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 27 Nov 2017 17:20:08 +0000
Subject: [Koha-bugs] [Bug 18458] Merging authority record incorrectly orders
	subfields
In-Reply-To: <bug-18458-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-18458-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-18458-70-Z5oOUPyozS@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18458

--- Comment #6 from Janusz Kaczmarek <januszop at gmail.com> ---
(In reply to Marcel de Rooy from comment #5)
> Janusz,
> Thx again for this patch.
> I am not so sure though if your code really makes sub merge easier (it is
> hard enough already).
> Couldnt we do the following in order to keep the order intact:
> 
> Copy all fields in original order including $9.
> Overwrite the authority controlled fields. If $overwrite, delete a subfield
> that is not controlled (only skip $9). [A hypothetical question: what about
> repeated subfields?]
> Update $9 finally.
> 
> Another thing:
> -                    append_fields_ordered( $marcrecord, $field_to );
> +                    $marcrecord->insert_fields_ordered($field_to);
> This is a regression. Look at the comments in append_fields_ordered. You
> change the order of fields here.
> 
> Finally, we need some tests to support your changes. Have a look at
> t/db_dependent/Authority/Merge.t :)

Hi Marcel,

Thank you for your comments.  From the bottom up:

You are right--but I have never done it (the t/ story) :(

append_fields_ordered -- you are right, I mixed it with append_fields -- and
this is what I wouldn't like here, hence the correction that turns out to be
regression. 

Hmmm, and what does it mean indeed "controlled" at all?  Because even with the
current approach we do not "clear" obviously controlled subfields that had been
introduced by mistake by a cataloger.  (E.g. if there is $a-$d in personal name
authority record, but a cataloger by mistake put additional $c by hand, $c will
not disappear after a "refreshing" merge; it disappears only if it was $a-$c
first in authority and then becomes $a-$d).  But anyway, it is definitely
better now than it was before your corrections.  But--wouldn't we need
something like: C4/Heading/MARC21.pm (which is used for linking) to clearly
state what is controlled?--I now, it is hardcoded, but MARC itself is hardcoded
too, i.e. title is in 245 $a (resp. 200 $a) etc.

Again, I feel like my proposal is more error-proof.  I mean: controlled
subfields form always a coherent block (do they?).  So, if a cataloger puts, by
mistake, an uncontrolled subfield between controlled subfields (which is not
very rare in standard Koha editor)--it will go to the end after my merge (which
was most probably his/hers intention).  Only if he/she puts an uncontrolled
introductory subfield at the beginning, it will remain there.

And, if $overwrite, it is no sense at all to copy the original field--it seems
to me it even more complicated than my approach, that I like ;)  And even
worse: with your proposal there is no simple way to cope with potentially
repeated subdields (e.g. $x) that would be subject to changed. 

And as to $9--yes, we like to have it at the very end (since it it totally non
standard and since it blemish the Labeled MARC view! :) 

So, to sum up: I would willingly return to append_fields_ordered, but if I
could ask for suggestions on how to prepare t/, would be great. 

I would appreciate your comments.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Nov 27 18:23:37 2017
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 27 Nov 2017 17:23:37 +0000
Subject: [Koha-bugs] [Bug 19695] Uncertain prices should not use find in
	list context
In-Reply-To: <bug-19695-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-19695-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-19695-70-sECJJm3N9y@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19695

Jonathan Druart <jonathan.druart at bugs.koha-community.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Needs Signoff               |Signed Off

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Nov 27 18:23:42 2017
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 27 Nov 2017 17:23:42 +0000
Subject: [Koha-bugs] [Bug 19695] Uncertain prices should not use find in
	list context
In-Reply-To: <bug-19695-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-19695-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-19695-70-VH5OSkNFpz@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19695

Jonathan Druart <jonathan.druart at bugs.koha-community.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #69369|0                           |1
        is obsolete|                            |

--- Comment #2 from Jonathan Druart <jonathan.druart at bugs.koha-community.org> ---
Created attachment 69396
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=69396&action=edit
Bug 19695: Fix another instance of ->find in list context (uncertainprice.pl)

Signed-off-by: Jonathan Druart <jonathan.druart at bugs.koha-community.org>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Nov 27 18:24:36 2017
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 27 Nov 2017 17:24:36 +0000
Subject: [Koha-bugs] [Bug 19695] Uncertain prices should not use find in
	list context
In-Reply-To: <bug-19695-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-19695-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-19695-70-IAbWCfni5b@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19695

Jonathan Druart <jonathan.druart at bugs.koha-community.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Signed Off                  |Passed QA

--- Comment #3 from Jonathan Druart <jonathan.druart at bugs.koha-community.org> ---
Trivial, skipping QA.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Nov 27 18:26:25 2017
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 27 Nov 2017 17:26:25 +0000
Subject: [Koha-bugs] [Bug 19695] Uncertain prices should not use find in
	list context
In-Reply-To: <bug-19695-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-19695-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-19695-70-4UCJuULO3b@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19695

Jonathan Druart <jonathan.druart at bugs.koha-community.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Passed QA                   |Pushed to Master

--- Comment #4 from Jonathan Druart <jonathan.druart at bugs.koha-community.org> ---
Patch pushed to master for 17.11, thanks Stefan!

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Nov 27 18:37:01 2017
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 27 Nov 2017 17:37:01 +0000
Subject: [Koha-bugs] [Bug 19629] No translatable notification in overdue
	notices
In-Reply-To: <bug-19629-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-19629-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-19629-70-hgXrRrj9Hb@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19629

Jonathan Druart <jonathan.druart at bugs.koha-community.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |jonathan.druart at bugs.koha-c
                   |                            |ommunity.org

--- Comment #1 from Jonathan Druart <jonathan.druart at bugs.koha-community.org> ---
Will be easy to do using the TT syntax.

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Nov 27 18:39:00 2017
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 27 Nov 2017 17:39:00 +0000
Subject: [Koha-bugs] [Bug 19578] TT syntax for notices - There is no way to
 pre-process DB fields
In-Reply-To: <bug-19578-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-19578-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-19578-70-JmAxZCxfaB@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19578

Jonathan Druart <jonathan.druart at bugs.koha-community.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|In Discussion               |Needs Signoff

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Nov 27 18:40:42 2017
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 27 Nov 2017 17:40:42 +0000
Subject: [Koha-bugs] [Bug 19575] Use canonical field names and resolve
	aliased fields
In-Reply-To: <bug-19575-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-19575-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-19575-70-9DeAcwqI8h@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19575

Jonathan Druart <jonathan.druart at bugs.koha-community.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |jonathan.druart at bugs.koha-c
                   |                            |ommunity.org,
                   |                            |nick at bywatersolutions.com

--- Comment #12 from Jonathan Druart <jonathan.druart at bugs.koha-community.org> ---
Is this ready for signoff?

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Nov 27 18:42:13 2017
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 27 Nov 2017 17:42:13 +0000
Subject: [Koha-bugs] [Bug 19546] Can't locate
 Mojolicious/Plugin/Koha/REST/Plugin/ Pagination.pm breaks opac and staff
In-Reply-To: <bug-19546-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-19546-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-19546-70-RDD4wgTFU5@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19546

Jonathan Druart <jonathan.druart at bugs.koha-community.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |jonathan.druart at bugs.koha-c
                   |                            |ommunity.org
             Status|NEW                         |RESOLVED
         Resolution|---                         |WORKSFORME

--- Comment #6 from Jonathan Druart <jonathan.druart at bugs.koha-community.org> ---
Closing, please reopen if it appears again.

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.

From bugzilla-daemon at bugs.koha-community.org  Mon Nov 27 18:43:01 2017
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 27 Nov 2017 17:43:01 +0000
Subject: [Koha-bugs] [Bug 19402] Date of birth datepicker year range
 depending on current value
In-Reply-To: <bug-19402-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-19402-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-19402-70-bjOv5KEwwz@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19402

Jonathan Druart <jonathan.druart at bugs.koha-community.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
         Resolution|---                         |INVALID
             Status|In Discussion               |RESOLVED

--- Comment #5 from Jonathan Druart <jonathan.druart at bugs.koha-community.org> ---
Closing, please reopen if still needed.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Nov 27 18:44:02 2017
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 27 Nov 2017 17:44:02 +0000
Subject: [Koha-bugs] [Bug 19252] Upgrading message shows identical version
In-Reply-To: <bug-19252-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-19252-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-19252-70-KvP1kKImVk@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19252

Jonathan Druart <jonathan.druart at bugs.koha-community.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|NEW                         |RESOLVED
         Resolution|---                         |INVALID

--- Comment #3 from Jonathan Druart <jonathan.druart at bugs.koha-community.org> ---
Closing, please reopen if it appears again.

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.

From bugzilla-daemon at bugs.koha-community.org  Mon Nov 27 18:52:42 2017
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 27 Nov 2017 17:52:42 +0000
Subject: [Koha-bugs] [Bug 15814] Templates for MARC modification: Edit
 action does not work when Description contains '
In-Reply-To: <bug-15814-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-15814-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-15814-70-O8e9aphAVc@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15814

Jonathan Druart <jonathan.druart at bugs.koha-community.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |jonathan.druart at bugs.koha-c
                   |                            |ommunity.org

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Nov 27 19:34:34 2017
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 27 Nov 2017 18:34:34 +0000
Subject: [Koha-bugs] [Bug 19621] Routing lists tab not present when viewing
 'Holds history' tab for a patron
In-Reply-To: <bug-19621-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-19621-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-19621-70-iU8Z3FUgex@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19621

--- Comment #4 from Nick Clemens <nick at bywatersolutions.com> ---
I's argue for bug - it appears on all other tabs and disappears on one, not
adding a new page, just fixing to how it 'should' work

It does hit a few pages, so fine either way

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Nov 27 19:46:11 2017
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 27 Nov 2017 18:46:11 +0000
Subject: [Koha-bugs] [Bug 19410] Add a helper function for generating object
 searches for the API
In-Reply-To: <bug-19410-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-19410-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-19410-70-3bYRcYr7QA@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19410

Kyle M Hall <kyle at bywatersolutions.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #69385|0                           |1
        is obsolete|                            |
  Attachment #69386|0                           |1
        is obsolete|                            |
  Attachment #69387|0                           |1
        is obsolete|                            |
  Attachment #69388|0                           |1
        is obsolete|                            |
  Attachment #69389|0                           |1
        is obsolete|                            |

--- Comment #32 from Kyle M Hall <kyle at bywatersolutions.com> ---
Created attachment 69397
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=69397&action=edit
Bug 19410: Add Koha::Objects->search_for_api

Following the discussion about the best way to make things simpler for
developing the REST api, I quote Lari's email:

"As many other endpoint will have the exact same usage, by looking at your
example, I would prefer to avoid writing parameter / pagination / sorting /
header handling for each list operation in our API controllers. Do you think
it's possible to centralize all of this e.g. by passing $c into a customized
search sub? Perhaps in Koha::Objects?
so instead we could have something like (ignore my bad choice of naming)...:
sub list_vendors {
  my $c = shift->openapi->valid_input or return;
  my $args = $c->validation->output;
  my $vendors;

  return try {
    $vendors = Koha::Acquisition::Booksellers->api_list_search($c);
    return $c->render(status => 200, openapi => $vendors);
  } catch {
    ...
  }
}"

We all agreed we neeed something like that. Here's a possible implementation. I
take
advantage of the previously written Mojo helpers, that are fully covered by
tests.

I submit this early so anyone can take a look and gather ideas to make it even
better.
I'm already using it (effectively) for the /acquisitions/orders endpoint I'm
writing
on bug 18731.

Thanks!

Signed-off-by: Tomas Cohen Arazi <tomascohen at theke.io>
Signed-off-by: Julian Maurice <julian.maurice at biblibre.com>

Signed-off-by: Lari Taskula <lari.taskula at jns.fi>

Signed-off-by: Kyle M Hall <kyle at bywatersolutions.com>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Nov 27 19:46:19 2017
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 27 Nov 2017 18:46:19 +0000
Subject: [Koha-bugs] [Bug 19410] Add a helper function for generating object
 searches for the API
In-Reply-To: <bug-19410-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-19410-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-19410-70-eNmJlY73To@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19410

--- Comment #33 from Kyle M Hall <kyle at bywatersolutions.com> ---
Created attachment 69398
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=69398&action=edit
Bug 19410: Unit tests

Signed-off-by: Tomas Cohen Arazi <tomascohen at theke.io>
Signed-off-by: Julian Maurice <julian.maurice at biblibre.com>

Signed-off-by: Lari Taskula <lari.taskula at jns.fi>

Signed-off-by: Kyle M Hall <kyle at bywatersolutions.com>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Nov 27 19:46:22 2017
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 27 Nov 2017 18:46:22 +0000
Subject: [Koha-bugs] [Bug 19410] Add a helper function for generating object
 searches for the API
In-Reply-To: <bug-19410-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-19410-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-19410-70-aGVdzjbD0n@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19410

--- Comment #34 from Kyle M Hall <kyle at bywatersolutions.com> ---
Created attachment 69399
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=69399&action=edit
Bug 19410: (follow-up) Fix typo in POD

Signed-off-by: Tomas Cohen Arazi <tomascohen at theke.io>
Signed-off-by: Julian Maurice <julian.maurice at biblibre.com>

Signed-off-by: Lari Taskula <lari.taskula at jns.fi>

Signed-off-by: Kyle M Hall <kyle at bywatersolutions.com>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Nov 27 19:46:08 2017
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 27 Nov 2017 18:46:08 +0000
Subject: [Koha-bugs] [Bug 19410] Add a helper function for generating object
 searches for the API
In-Reply-To: <bug-19410-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-19410-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-19410-70-59UjRRUoii@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19410

Kyle M Hall <kyle at bywatersolutions.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Signed Off                  |Passed QA

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Nov 27 19:46:25 2017
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 27 Nov 2017 18:46:25 +0000
Subject: [Koha-bugs] [Bug 19410] Add a helper function for generating object
 searches for the API
In-Reply-To: <bug-19410-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-19410-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-19410-70-uB1NP7yWwr@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19410

--- Comment #35 from Kyle M Hall <kyle at bywatersolutions.com> ---
Created attachment 69400
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=69400&action=edit
Bug 19410: Move search_for_api into a Mojo helper

Signed-off-by: Tomas Cohen Arazi <tomascohen at theke.io>
Signed-off-by: Julian Maurice <julian.maurice at biblibre.com>

Signed-off-by: Lari Taskula <lari.taskula at jns.fi>

Signed-off-by: Kyle M Hall <kyle at bywatersolutions.com>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Nov 27 19:46:28 2017
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 27 Nov 2017 18:46:28 +0000
Subject: [Koha-bugs] [Bug 19410] Add a helper function for generating object
 searches for the API
In-Reply-To: <bug-19410-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-19410-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-19410-70-hScwRmlsdw@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19410

--- Comment #36 from Kyle M Hall <kyle at bywatersolutions.com> ---
Created attachment 69401
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=69401&action=edit
Bug 19410: (QA followup) Move build_query_params_from_api into a helper

This patch creates the 'build_query_params' helper, instead of the
original function in Koha::Objects.

Unit tests are removed for Koha::Objects::_build_query_params_from_api and
written for the helper plugin.

The objects.search helper gets a call to build_query_params added. Tests for it
updated to match this behaviour change.

To test:
- Apply this patches
- Run:
  $ kshell
 k$ prove t/Koha/REST/Plugin/Query.t \
          t/db_dependent/Koha/Objects.t \
          t/db_dependent/Koha/REST/Plugin/Objects.t
=> SUCCESS: Tests pass!
- Sign off :-D

Signed-off-by: Tomas Cohen Arazi <tomascohen at theke.io>
Signed-off-by: Julian Maurice <julian.maurice at biblibre.com>

Signed-off-by: Lari Taskula <lari.taskula at jns.fi>

Signed-off-by: Kyle M Hall <kyle at bywatersolutions.com>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Nov 27 19:52:40 2017
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 27 Nov 2017 18:52:40 +0000
Subject: [Koha-bugs] [Bug 19410] Add a helper function for generating object
 searches for the API
In-Reply-To: <bug-19410-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-19410-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-19410-70-cFPxiLtVfn@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19410

--- Comment #37 from Kyle M Hall <kyle at bywatersolutions.com> ---
I think rather than calling _to_model in each Controller, we should move that
call to Koha::REST::Plugin::Objects, something like

diff --git a/Koha/REST/Plugin/Objects.pm b/Koha/REST/Plugin/Objects.pm
index eb3f951..163e364 100644
--- a/Koha/REST/Plugin/Objects.pm
+++ b/Koha/REST/Plugin/Objects.pm
@@ -45,7 +45,7 @@ sub register {
         'objects.search' => sub {
             my ( $c, $objects_set ) = @_;

-            my $args = $c->validation->output;
+            my $args = $objects_set->_to_model( $c->validation->output );
             my $attributes = {};

and change the extract to
my ($params, $reserved_params) = $c->extract_reserved_params(
$c->validation->output );
or something like that so the above 'patch' doesn't break it.

We could add _to_model to a parent class of the modules in Koha::REST::V1 that
essentially does nothing, and then each child class could override it with any
customizations if necessary.

That would simplify the code, and allow customization easily, if it is needed.
If it isn't the class just won't have a _to_model method.

This is probably better to implement in a followup bug report. That patches
themselves appear to work great!

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Nov 27 20:50:50 2017
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 27 Nov 2017 19:50:50 +0000
Subject: [Koha-bugs] [Bug 18609] Make attachment of MARC records for
 list/cart email optional
In-Reply-To: <bug-18609-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-18609-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-18609-70-3hKo7Opxf4@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18609

Owen Leonard <oleonard at myacpl.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
            Summary|Make attachement of MARC    |Make attachment of MARC
                   |records for list/cart email |records for list/cart email
                   |optional                    |optional

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Nov 27 21:45:55 2017
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 27 Nov 2017 20:45:55 +0000
Subject: [Koha-bugs] [Bug 19575] Use canonical field names and resolve
	aliased fields
In-Reply-To: <bug-19575-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-19575-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-19575-70-oqMeAiecZd@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19575

--- Comment #13 from David Gustafsson <glasklas at gmail.com> ---
Sorry, should have been more clear about that. Yes, this is ready for signoff.
There is still some stuff I left out of this patch, like:

- New mappings for other marc-flavours than marc21 extracted from
biblio-koha-indexdefs.xml
- Correction for some existing mappings (I think some offsets are off by one
for example)
- New mappings and posssible corrections for authorities

But if this get reviewed and committed I can open new bug-reports for those
once I have time to further polish the extraction-script.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Nov 27 22:04:27 2017
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 27 Nov 2017 21:04:27 +0000
Subject: [Koha-bugs] [Bug 19702] New: Basket not displaying correctly on
	home page
Message-ID: <bug-19702-70@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19702

            Bug ID: 19702
           Summary: Basket not displaying correctly on home page
 Change sponsored?: ---
           Product: Koha
           Version: master
          Hardware: All
                OS: All
            Status: NEW
          Severity: minor
          Priority: P5 - low
         Component: OPAC
          Assignee: david.bourgault at inlibro.com
          Reporter: david.bourgault at inlibro.com
        QA Contact: testopia at bugs.koha-community.org
                CC: philippe.blouin at inlibro.com

When viewing the "base url" of the OPAC catalog, the basket is not displayed
correctly:

Say your website is `opac.books.com`, the basket will be displayed correctly
for all page under `opac.books.com/cgi-bin/koha/` but not on `opac.books.com/`

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Nov 27 22:13:33 2017
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 27 Nov 2017 21:13:33 +0000
Subject: [Koha-bugs] [Bug 19702] Basket not displaying correctly on home page
In-Reply-To: <bug-19702-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-19702-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-19702-70-Io6jRV45k9@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19702

David Bourgault <david.bourgault at inlibro.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|NEW                         |Needs Signoff

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Nov 27 22:13:35 2017
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 27 Nov 2017 21:13:35 +0000
Subject: [Koha-bugs] [Bug 19702] Basket not displaying correctly on home page
In-Reply-To: <bug-19702-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-19702-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-19702-70-BaMKlF6mY9@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19702

--- Comment #1 from David Bourgault <david.bourgault at inlibro.com> ---
Created attachment 69402
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=69402&action=edit
Bug 19702 - Correct cookie path in Basket.js

This corrects the cookie path in bootstrap/js/basket.js. It used to take the
default value (current page path), but will now be "/"

Test plan:
0) Visit the OPAC, add a book to your basket
1) Navigate to the OPAC's homepage (www.domain.com, without the /cgi-bin/koha)
    -> The basket will display as empty
2) Apply patch
3) Clear your cookies and your cache
4) Redo step 1)
    -> Basket will display correctly

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Nov 27 22:23:42 2017
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 27 Nov 2017 21:23:42 +0000
Subject: [Koha-bugs] [Bug 19703] New: Some items have the incorrect item
 type displayed in the 'Most popular' section in OPAC
Message-ID: <bug-19703-70@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19703

            Bug ID: 19703
           Summary: Some items have the incorrect item type displayed in
                    the 'Most popular' section in OPAC
 Change sponsored?: ---
           Product: Koha
           Version: 17.05
          Hardware: All
                OS: All
            Status: NEW
          Severity: enhancement
          Priority: P5 - low
         Component: OPAC
          Assignee: oleonard at myacpl.org
          Reporter: alexbuckley at catalyst.net.nz
        QA Contact: testopia at bugs.koha-community.org

Where there are several bibliographic records with associated items of
different itemtypes then Most popular displays the incorrect itemtype.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Nov 27 22:39:28 2017
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 27 Nov 2017 21:39:28 +0000
Subject: [Koha-bugs] [Bug 19704] New: OPACs most popular feature is
 displaying links to items set to be hidden in the opachiddenitems syspref
 which gives 404 errors when links are clicked
Message-ID: <bug-19704-70@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19704

            Bug ID: 19704
           Summary: OPACs most popular feature is displaying links to
                    items set to be hidden in the opachiddenitems syspref
                    which gives 404 errors when links are clicked
 Change sponsored?: ---
           Product: Koha
           Version: 17.05
          Hardware: All
                OS: All
            Status: NEW
          Severity: normal
          Priority: P3
         Component: OPAC
          Assignee: oleonard at myacpl.org
          Reporter: alexbuckley at catalyst.net.nz
        QA Contact: testopia at bugs.koha-community.org

When a library item has multiple bibliographic records and associated items
with differing item types (e.g. fiction and express fiction and non-fiction)
the Most popular feature is displaying links to items which are set to be
hidden in the opachiddenitems syspref.

When the user clicks on the link to these items a 404 error is displayed to the
user. 

Therefore the most popular feature is incorrectly displaying links to hidden
items.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Nov 27 22:48:43 2017
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 27 Nov 2017 21:48:43 +0000
Subject: [Koha-bugs] [Bug 19703] Some items have the incorrect item type
 displayed in the ' Most popular' section in OPAC
In-Reply-To: <bug-19703-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-19703-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-19703-70-zX78dPqLhO@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19703

--- Comment #1 from Alex Buckley <alexbuckley at catalyst.net.nz> ---
Created attachment 69403
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=69403&action=edit
All the item types of fiction in this screenshot should be Express fiction &
Non-fiction

In this Koha instance the item type 'Express fiction & Non-fiction' are set to
be hidden by the opachiddenitems syspref.

All items in the screenshot of the Most popular section of OPAC except for
Fifty fifty are giving a 404 error. That is because Most popular feature is
incorrectly displaying hidden items (see bug 19704).

All of these items have multiple bibliographic records with associated items
with differing itemtypes. 

For example 'the store' item has 3 bibliographic records with 1 item with the
itemtype 'talking book', another item with the item type 'fiction' and another
4 item records with the item type 'Express fiction and non-fiction'. Now the
itemtype 'express fiction and non-fiction' is set to be hidden in
opachiddenitems syspref. 

The itemtype for 'The store' in the screenshot is incorrect because it is
giving a 404 error when selected (this means it is item type 'express fiction
and non-fiction'), however the Most popular feature is displaying an item type
of 'fiction'.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Nov 27 22:58:08 2017
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 27 Nov 2017 21:58:08 +0000
Subject: [Koha-bugs] [Bug 19575] Use canonical field names and resolve
	aliased fields
In-Reply-To: <bug-19575-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-19575-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-19575-70-jbinjcAvKl@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19575

--- Comment #14 from Jonathan Druart <jonathan.druart at bugs.koha-community.org> ---
(In reply to David Gustafsson from comment #13)
> But if this get reviewed and committed I can open new bug-reports for those
> once I have time to further polish the extraction-script.

Can you share the script?

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Nov 27 23:10:38 2017
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 27 Nov 2017 22:10:38 +0000
Subject: [Koha-bugs] [Bug 19496] Patron notes about item does not get
 emailed as indicated
In-Reply-To: <bug-19496-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-19496-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-19496-70-BtxLPSynpv@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19496

Aleisha Amohia <aleisha at catalyst.net.nz> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
   Patch complexity|---                         |Small patch
             Status|ASSIGNED                    |Needs Signoff

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Nov 27 23:10:41 2017
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 27 Nov 2017 22:10:41 +0000
Subject: [Koha-bugs] [Bug 19496] Patron notes about item does not get
 emailed as indicated
In-Reply-To: <bug-19496-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-19496-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-19496-70-PYK3nExCZR@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19496

--- Comment #2 from Aleisha Amohia <aleisha at catalyst.net.nz> ---
Created attachment 69404
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=69404&action=edit
Bug 19496: Fixing to_address for patron notes

This patch ensures the patron note to_address is the branch email or the
Koha Admin email, and the from_address is the patron's email.

To test:
1) Ensure syspref 'allowcheckoutnotes' is turned on
2) Go to OPAC, leave a note on a checkout
3) Confirm that the note is received (in mysql message_queue) but the
to_address is the patron's email - this is wrong
4) Apply patch and refresh OPAC
5) Leave a note on a checkout
6) Confirm that the note is received in message queue
7) Confirm that the to_address is one of:
- branch email
- branch reply to
- syspref ReplytoDefault
- syspref KohaAdminEmailAddress
8) Confirm that the from_address is one of:
- patron email
- patron emailpro
- patron B_email

Sponsored-by: Catalyst IT

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Nov 27 23:11:53 2017
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 27 Nov 2017 22:11:53 +0000
Subject: [Koha-bugs] [Bug 19496] Patron notes about item does not get
 emailed as indicated
In-Reply-To: <bug-19496-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-19496-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-19496-70-Ks3OqTaeJ1@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19496

Aleisha Amohia <aleisha at catalyst.net.nz> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Change sponsored?|---                         |Sponsored

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Nov 27 23:21:55 2017
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 27 Nov 2017 22:21:55 +0000
Subject: [Koha-bugs] [Bug 19532] Recalls for Koha
In-Reply-To: <bug-19532-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-19532-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-19532-70-pr8gjOhNzP@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19532

--- Comment #24 from Aleisha Amohia <aleisha at catalyst.net.nz> ---
Created attachment 69405
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=69405&action=edit
Bug 19532: Flagging recall as 'old' when expired or cancelled

Set 'old' flag to 1 if cancelling or expiring a recall

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Nov 27 23:34:02 2017
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 27 Nov 2017 22:34:02 +0000
Subject: [Koha-bugs] [Bug 8571] Add search suggestions on the OPAC ("Did you
 mean?" feature)
In-Reply-To: <bug-8571-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-8571-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-8571-70-IkDxUkbjWg@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8571

Eric Phetteplace <ephetteplace at cca.edu> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |ephetteplace at cca.edu

--- Comment #9 from Eric Phetteplace <ephetteplace at cca.edu> ---
It seems like this feature is now included in Koha. OK to close the bug? Or is
this useful as a general discussion place for the feature? I wanted to comment
on another, more specific, issue as I think we can agree Koha now does search
suggestions but the manner in which it does so can be discussed separately.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Nov 27 23:34:43 2017
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 27 Nov 2017 22:34:43 +0000
Subject: [Koha-bugs] [Bug 19705] New: DecreaseLoanHighHolds.t is still
	failing randomly
Message-ID: <bug-19705-70@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19705

            Bug ID: 19705
           Summary: DecreaseLoanHighHolds.t is still failing randomly
 Change sponsored?: ---
           Product: Koha
           Version: unspecified
          Hardware: All
                OS: All
            Status: NEW
          Severity: enhancement
          Priority: P5 - low
         Component: Test Suite
          Assignee: chris at bigballofwax.co.nz
          Reporter: jonathan.druart at bugs.koha-community.org
        QA Contact: testopia at bugs.koha-community.org

https://jenkins.koha-community.org/job/Koha_Master_D8/298/console

#   Failed test 'Static mode should exceed threshold'
#   at t/db_dependent/DecreaseLoanHighHolds.t line 125.
#          got: '0'
#     expected: '1'

#   Failed test 'Should have duration of 1'
#   at t/db_dependent/DecreaseLoanHighHolds.t line 127.
#          got: '0'
#     expected: '1'

#   Failed test 'due_date should be a DateTime object'
#   at t/db_dependent/DecreaseLoanHighHolds.t line 128.
#          got: ''
#     expected: 'DateTime'
Can't call method "hour" on an undefined value at
t/db_dependent/DecreaseLoanHighHolds.t line 131.
# Looks like your test exited with 255 just after 5.
[18:52:27] t/db_dependent/DecreaseLoanHighHolds.t ......................... 
Dubious, test returned 255 (wstat 65280, 0xff00)
Failed 15/17 subtests

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Nov 27 23:34:57 2017
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 27 Nov 2017 22:34:57 +0000
Subject: [Koha-bugs] [Bug 19705] DecreaseLoanHighHolds.t is still failing
	randomly
In-Reply-To: <bug-19705-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-19705-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-19705-70-H1t00e291z@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19705

Jonathan Druart <jonathan.druart at bugs.koha-community.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
         Depends on|                            |19423


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19423
[Bug 19423] DecreaseLoanHighHolds.t is failing randomly
-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Nov 27 23:34:57 2017
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 27 Nov 2017 22:34:57 +0000
Subject: [Koha-bugs] [Bug 19423] DecreaseLoanHighHolds.t is failing randomly
In-Reply-To: <bug-19423-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-19423-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-19423-70-ytu9GEu0Ux@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19423

Jonathan Druart <jonathan.druart at bugs.koha-community.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Blocks|                            |19705


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19705
[Bug 19705] DecreaseLoanHighHolds.t is still failing randomly
-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Nov 27 23:35:05 2017
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 27 Nov 2017 22:35:05 +0000
Subject: [Koha-bugs] [Bug 19705] DecreaseLoanHighHolds.t is still failing
	randomly
In-Reply-To: <bug-19705-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-19705-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-19705-70-GAQSxkNKRs@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19705

Jonathan Druart <jonathan.druart at bugs.koha-community.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
           Severity|enhancement                 |normal

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Nov 27 23:47:02 2017
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 27 Nov 2017 22:47:02 +0000
Subject: [Koha-bugs] [Bug 19575] Use canonical field names and resolve
	aliased fields
In-Reply-To: <bug-19575-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-19575-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-19575-70-is0fAFHHAP@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19575

--- Comment #15 from David Gustafsson <glasklas at gmail.com> ---
Yes, I was thinking to do so, though it is only a quick and dirty script in
Ruby (should perhaps be re-written in perl if to be included in Koha-repo), and
though would clean it up just a little bit more, remove some hard-coded stuff,
add some simple command line options etc. But will post a link to git-repo with
said script once removed the worst ugliness.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Nov 28 00:18:57 2017
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 27 Nov 2017 23:18:57 +0000
Subject: [Koha-bugs] [Bug 19690] Smart rules: Term "If any unavailable" is
 confusing and just means No
In-Reply-To: <bug-19690-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-19690-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-19690-70-TZDgoXkkOl@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19690

Katrin Fischer <katrin.fischer at bsz-bw.de> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |katrin.fischer at bsz-bw.de

--- Comment #2 from Katrin Fischer <katrin.fischer at bsz-bw.de> ---
I think the patch is actually wrong:

[% ELSIF rule.onshelfholds == 2 %]
- If all unavailable
+ Only if other items unavailable
[% ELSE %]
-  If any unavailable
+  No

OnShelfHolds Allowed
If all unavailable = No (no onshelf holds are allowed)
If any anavailable = If at least one is checked out
Yes = It doesn't matter if anything is checked out or not (also yes is good
here)

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Nov 28 00:19:06 2017
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 27 Nov 2017 23:19:06 +0000
Subject: [Koha-bugs] [Bug 19690] Smart rules: Term "If any unavailable" is
 confusing and just means No
In-Reply-To: <bug-19690-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-19690-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-19690-70-9146yUFwNn@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19690

Katrin Fischer <katrin.fischer at bsz-bw.de> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Needs Signoff               |Failed QA

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Nov 28 00:22:28 2017
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 27 Nov 2017 23:22:28 +0000
Subject: [Koha-bugs] [Bug 19699] Missing FK on messages table
In-Reply-To: <bug-19699-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-19699-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-19699-70-SFyCgRe6AZ@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19699

Katrin Fischer <katrin.fischer at bsz-bw.de> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |katrin.fischer at bsz-bw.de
             Status|NEW                         |RESOLVED
         Resolution|---                         |DUPLICATE

--- Comment #1 from Katrin Fischer <katrin.fischer at bsz-bw.de> ---
Hi Sophie, this is a duplicate to bug 13515.

*** This bug has been marked as a duplicate of bug 13515 ***

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Nov 28 00:22:28 2017
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 27 Nov 2017 23:22:28 +0000
Subject: [Koha-bugs] [Bug 13515] Table messages is missing FK constraints
 and is never cleaned up
In-Reply-To: <bug-13515-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-13515-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-13515-70-fFXjk8lVLD@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13515

Katrin Fischer <katrin.fischer at bsz-bw.de> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |sophie.meynieux at biblibre.co
                   |                            |m

--- Comment #1 from Katrin Fischer <katrin.fischer at bsz-bw.de> ---
*** Bug 19699 has been marked as a duplicate of this bug. ***

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Nov 28 00:48:07 2017
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 27 Nov 2017 23:48:07 +0000
Subject: [Koha-bugs] [Bug 17176] Did you mean searches should respect
 UseAuthoritiesForTracings and search by terms instead of numbers
In-Reply-To: <bug-17176-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-17176-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-17176-70-r9jK7x4TD4@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17176

Eric Phetteplace <ephetteplace at cca.edu> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |ephetteplace at cca.edu

--- Comment #1 from Eric Phetteplace <ephetteplace at cca.edu> ---
Bumping this issue. This has a negative user experience impact for us because
some of the "did you mean" results are authority records that aren't used in
any of our bibs?so the "did you mean" links to an empty result set, which is
confusing and frustrating. It'd be better to not allow suggestions that have no
associated bib records.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Nov 28 00:52:55 2017
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 27 Nov 2017 23:52:55 +0000
Subject: [Koha-bugs] [Bug 12349] Link patron name on suggestions
In-Reply-To: <bug-12349-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-12349-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-12349-70-WaXDU9vcP5@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12349

Katrin Fischer <katrin.fischer at bsz-bw.de> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |katrin.fischer at bsz-bw.de
            Summary|patron name on suggestions  |Link patron name on
                   |should be linked            |suggestions

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Nov 28 00:55:41 2017
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 27 Nov 2017 23:55:41 +0000
Subject: [Koha-bugs] [Bug 18399] Add reasons on edit suggestion page
In-Reply-To: <bug-18399-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-18399-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-18399-70-O8a0y2nszg@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18399

Katrin Fischer <katrin.fischer at bsz-bw.de> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |katrin.fischer at bsz-bw.de
            Summary|Reason is missing in        |Add reasons on edit
                   |suggestion management part  |suggestion page

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Nov 28 00:57:16 2017
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 27 Nov 2017 23:57:16 +0000
Subject: [Koha-bugs] [Bug 17969] Refactor the way the items.content
 placeholder is generated
In-Reply-To: <bug-17969-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-17969-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-17969-70-iCx3k5yd3G@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17969

Katrin Fischer <katrin.fischer at bsz-bw.de> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
            Summary|Refactor the way            |Refactor the way the
                   |<<items.content>> is        |items.content placeholder
                   |generated                   |is generated
                 CC|                            |katrin.fischer at bsz-bw.de

--- Comment #12 from Katrin Fischer <katrin.fischer at bsz-bw.de> ---
<< >> in the title were not working well with the html version of the release
notes.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Nov 28 01:02:25 2017
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 28 Nov 2017 00:02:25 +0000
Subject: [Koha-bugs] [Bug 17039] Add cancel/new item option when editing an
	item
In-Reply-To: <bug-17039-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-17039-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-17039-70-6Sb7VUz59K@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17039

Katrin Fischer <katrin.fischer at bsz-bw.de> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
            Summary|No cancel/new item option   |Add cancel/new item option
                   |when editing an item        |when editing an item

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Nov 28 01:03:29 2017
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 28 Nov 2017 00:03:29 +0000
Subject: [Koha-bugs] [Bug 18881] Remove dead code in circ/view_holdsqueue.pl
In-Reply-To: <bug-18881-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-18881-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-18881-70-QAaIpq09kR@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18881

Katrin Fischer <katrin.fischer at bsz-bw.de> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
          Component|Circulation                 |Architecture, internals,
                   |                            |and plumbing

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Nov 28 01:09:21 2017
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 28 Nov 2017 00:09:21 +0000
Subject: [Koha-bugs] [Bug 18877] Add documentation on dbhost for koha-create
	help
In-Reply-To: <bug-18877-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-18877-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-18877-70-07yvtIxslw@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18877

Katrin Fischer <katrin.fischer at bsz-bw.de> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |katrin.fischer at bsz-bw.de,
                   |                            |robin at catalyst.net.nz
          Component|Installation and upgrade    |Command-line Utilities
                   |(command-line installer)    |

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Nov 28 01:10:31 2017
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 28 Nov 2017 00:10:31 +0000
Subject: [Koha-bugs] [Bug 19669] Remove deprecated checkouts by patron
	category report
In-Reply-To: <bug-19669-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-19669-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-19669-70-oboflCfkae@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19669

Dilan Johnpull? <dilan at calyx.net.au> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Needs Signoff               |Signed Off

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Nov 28 01:10:35 2017
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 28 Nov 2017 00:10:35 +0000
Subject: [Koha-bugs] [Bug 19669] Remove deprecated checkouts by patron
	category report
In-Reply-To: <bug-19669-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-19669-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-19669-70-cbYkW4YFAt@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19669

Dilan Johnpull? <dilan at calyx.net.au> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #69246|0                           |1
        is obsolete|                            |

--- Comment #2 from Dilan Johnpull? <dilan at calyx.net.au> ---
Created attachment 69406
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=69406&action=edit
Bug 19669: Remove deprecated checkouts by patron category report

Patch applies. Reports and general OPAC and staff client functionality is
intact.
Signed-off-by: Dilan Johnpull? <dilan at calyx.net.au>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Nov 28 01:28:12 2017
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 28 Nov 2017 00:28:12 +0000
Subject: [Koha-bugs] [Bug 19702] Basket not displaying correctly on home page
In-Reply-To: <bug-19702-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-19702-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-19702-70-DaXjTSSx1K@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19702

Dilan Johnpull? <dilan at calyx.net.au> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Needs Signoff               |Signed Off

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Nov 28 01:28:16 2017
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 28 Nov 2017 00:28:16 +0000
Subject: [Koha-bugs] [Bug 19702] Basket not displaying correctly on home page
In-Reply-To: <bug-19702-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-19702-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-19702-70-B88LUgQsiO@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19702

Dilan Johnpull? <dilan at calyx.net.au> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #69402|0                           |1
        is obsolete|                            |

--- Comment #2 from Dilan Johnpull? <dilan at calyx.net.au> ---
Created attachment 69407
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=69407&action=edit
Bug 19702 - Correct cookie path in Basket.js

Patch applies without issue and functions as descibed.
Signed-off-by: Dilan Johnpull? <dilan at calyx.net.au>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Nov 28 02:11:04 2017
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 28 Nov 2017 01:11:04 +0000
Subject: [Koha-bugs] [Bug 7046] subscription renewal period should be a pull
	down
In-Reply-To: <bug-7046-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-7046-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-7046-70-dOaW3SxzGb@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7046

Dilan Johnpull? <dilan at calyx.net.au> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Needs Signoff               |Signed Off

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the QA Contact for the bug.

From bugzilla-daemon at bugs.koha-community.org  Tue Nov 28 02:11:08 2017
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 28 Nov 2017 01:11:08 +0000
Subject: [Koha-bugs] [Bug 7046] subscription renewal period should be a pull
	down
In-Reply-To: <bug-7046-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-7046-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-7046-70-0XH2svz2jo@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7046

Dilan Johnpull? <dilan at calyx.net.au> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #69356|0                           |1
        is obsolete|                            |

--- Comment #7 from Dilan Johnpull? <dilan at calyx.net.au> ---
Created attachment 69408
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=69408&action=edit
Bug 7046 - Implemented dropdown sub length element

Patch applies and functions as expected in line with test plan.
Signed-off-by: Dilan Johnpull? <dilan at calyx.net.au>

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the QA Contact for the bug.

From bugzilla-daemon at bugs.koha-community.org  Tue Nov 28 02:39:14 2017
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 28 Nov 2017 01:39:14 +0000
Subject: [Koha-bugs] [Bug 19532] Recalls for Koha
In-Reply-To: <bug-19532-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-19532-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-19532-70-briAXduAPS@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19532

--- Comment #25 from Aleisha Amohia <aleisha at catalyst.net.nz> ---
Created attachment 69409
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=69409&action=edit
Bug 19532: Cronjob to check for overdue recalls

This patch adds a check to the overdue_notices cronjob, so if any of the
overdue issues are also recalls, the status will be set to O (overdue)

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Nov 28 05:10:22 2017
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 28 Nov 2017 04:10:22 +0000
Subject: [Koha-bugs] [Bug 19532] Recalls for Koha
In-Reply-To: <bug-19532-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-19532-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-19532-70-dcJI8AHJby@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19532

--- Comment #26 from Aleisha Amohia <aleisha at catalyst.net.nz> ---
Created attachment 69410
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=69410&action=edit
Bug 19532: Tests for Koha/Recalls

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Nov 28 05:21:27 2017
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 28 Nov 2017 04:21:27 +0000
Subject: [Koha-bugs] [Bug 19532] Recalls for Koha
In-Reply-To: <bug-19532-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-19532-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-19532-70-wallB7j1ng@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19532

--- Comment #27 from Aleisha Amohia <aleisha at catalyst.net.nz> ---
Created attachment 69411
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=69411&action=edit
Bug 19532: Nice message if no recalls for opac recalls history

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Nov 28 05:38:46 2017
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 28 Nov 2017 04:38:46 +0000
Subject: [Koha-bugs] [Bug 19532] Recalls for Koha
In-Reply-To: <bug-19532-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-19532-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-19532-70-V3ZNDw05hx@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19532

Aleisha Amohia <aleisha at catalyst.net.nz> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|ASSIGNED                    |Needs Signoff

--- Comment #28 from Aleisha Amohia <aleisha at catalyst.net.nz> ---
I believe that this feature is now ready to test. I'll be away for the next
couple of weeks, but feel free to test and leave any
feedback/comments/questions/ideas that I can come back to when I return.
Note: when testing, it will be very helpful to keep the OPAC and the Staff
Client open in 2 separate tabs or browsers. you will also need 2 borrowers,
where at least one has superlibrarian privileges.

TEST PLAN:

1. Enable the UseRecalls syspref
2. Go to Circulation and Fines Rules. Put some numbers in the recalls fields
(recall due date interval, recall overdue fine amount, recall pickup period)
3. Put a number in the RecallsMaxPickUpDelay syspref. This will be the default
number of days used if the recall pickup period isn't set in Step 2
4. Check out an item to a patron
5. Go to that item's detail page in the OPAC. Notice the holdings table says
'Checked out'
6. Log in to the OPAC with another patron and go back to that detail page. The
holdings table should now have a Recall link next to the 'Checked out' text
7. Click the Recall button and confirm the Recall
8. Go to the user's opac summary and confirm there is now a Recalls tab, with
the correct number of recalls (should be 1).
9. Test cancelling the recall by clicking Cancel. Confirm the recall has been
cancelled. Repeat steps 6 and 7.
10. In the left navigation, there will also be a 'recalls history' tab. Click
it. There should be a log, similar to reading history, with the cancelled
recall and the new recall in it. Confirm all information is correct
11. Again, test cancelling the recall. Repeat steps 6 and 7.
12. In the staff interface, go to the logged in user's checkouts. Confirm you
can see a new Recalls tab, with the active (not cancelled) recall in the table.
Should be the same for the details tab also.
13. Test cancelling works for both of these again, and making new recalls
again.
14. Check in the recalled item. You should see a pop up, asking to confirm the
recall as waiting. Click confirm.
15. Go to the Circulation main page. You should see 3 new reports: recalls
queue, overdue recalls and recalls awaiting pickup
16. Go to the recalls queue, confirm you can see an entire history of recalls
at your library. Confirm cancel works when selecting checkboxes and clicking
the multiple button. If you do this, you'll need to place the recall again and
check the item in again
17. Go to recalls awaiting pickup. You should see the recall under the recalls
waiting tab
18. in Mysql, set the waitingdate for your recall to be more than 'recall
pickup period' days before today's date
19. Refresh the recalls awaiting pickup page. You should see the recall under
the recalls waiting tab, and the recalls waiting more than X days tab.
20. expire the recall. confirm this is expired by checking the recalls queue
21. place another recall, but do not check it in
22. in mysql, set the date_due of the checkout (issues table) to be at least
'recall due date interval' number of days before today's date
23. run the overdue_notices.pl cronjob
24. go to the overdue recalls circ report and confirm your recall shows there
25. try cancelling the recall here also
26. in mysql, check the message_queue and confirm there have been the
appropriate number of RETURN_RECALLED_ITEM and PICKUP_RECALLED_ITEM notices
sent with the correct to and from addresses and other content
27. test t/db_dependent/Koha/Recalls.t

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Nov 28 07:54:14 2017
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 28 Nov 2017 06:54:14 +0000
Subject: [Koha-bugs] [Bug 19706] New: Item search: Unsupported format html
Message-ID: <bug-19706-70@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19706

            Bug ID: 19706
           Summary: Item search: Unsupported format html
 Change sponsored?: ---
           Product: Koha
           Version: 17.05
          Hardware: PC
                OS: Linux
            Status: NEW
          Severity: critical
          Priority: P5 - low
         Component: Cataloging
          Assignee: koha-bugs at lists.koha-community.org
          Reporter: elias.dehler at thulb.uni-jena.de
        QA Contact: testopia at bugs.koha-community.org
                CC: m.de.rooy at rijksmuseum.nl

After upgrading to 17.05.06.000 Item search no longer works, as long as screen
is selected.
CSV and Barcodes file working as intended.

When screen is the selected output you get the following software error:
Unsupported format html at
/usr/share/koha/intranet/cgi-bin/catalogue/itemsearch.pl line 41.

Steps to reproduce:

1. upgrade to 17.05.06.000

2. in the intra: search -> item search

3. leave everything as it is and click search

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Nov 28 08:08:08 2017
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 28 Nov 2017 07:08:08 +0000
Subject: [Koha-bugs] [Bug 13515] Table messages is missing FK constraints
 and is never cleaned up
In-Reply-To: <bug-13515-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-13515-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-13515-70-dPNUHpjs0g@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13515

Axelle Aix-Marseille Universit? <axelle.clarisse at univ-amu.fr> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |axelle.clarisse at univ-amu.fr

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Nov 28 08:12:35 2017
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 28 Nov 2017 07:12:35 +0000
Subject: [Koha-bugs] [Bug 18860] OPAC Messaging Settings table is not styled
	with thead
In-Reply-To: <bug-18860-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-18860-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-18860-70-kSUPBn88bz@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18860

Katrin Fischer <katrin.fischer at bsz-bw.de> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |katrin.fischer at bsz-bw.de
            Summary|OPAC Messaging Settings     |OPAC Messaging Settings
                   |table is not styled with    |table is not styled with
                   |<thead>                     |thead

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Nov 28 08:12:48 2017
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 28 Nov 2017 07:12:48 +0000
Subject: [Koha-bugs] [Bug 16759] Make OPAC holdings table configurable
In-Reply-To: <bug-16759-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-16759-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-16759-70-oZ4cEKXrOD@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16759

Katrin Fischer <katrin.fischer at bsz-bw.de> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |katrin.fischer at bsz-bw.de
            Summary|Make opac holdings table    |Make OPAC holdings table
                   |configurable                |configurable

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Nov 28 08:12:58 2017
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 28 Nov 2017 07:12:58 +0000
Subject: [Koha-bugs] [Bug 18949] OPAC MARC details holdings table is not
 styled with thead
In-Reply-To: <bug-18949-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-18949-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-18949-70-2CphYUwSVY@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18949

Katrin Fischer <katrin.fischer at bsz-bw.de> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
            Summary|OPAC MARC details holdings  |OPAC MARC details holdings
                   |table is not styled with    |table is not styled with
                   |<thead>                     |thead
                 CC|                            |katrin.fischer at bsz-bw.de

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Nov 28 08:13:39 2017
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 28 Nov 2017 07:13:39 +0000
Subject: [Koha-bugs] [Bug 19532] Recalls for Koha
In-Reply-To: <bug-19532-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-19532-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-19532-70-mEN9wrjwSG@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19532

Petter Goks?yr ?sen <boutrosboutrosboutros at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |boutrosboutrosboutros at gmail
                   |                            |.com

--- Comment #29 from Petter Goks?yr ?sen <boutrosboutrosboutros at gmail.com> ---
Quick comment:
Given the troubles we have with duplicate primary keys in old/deleted tables,
would't it be better to drop the old_recalls table, and keep it in one table,
with a flag denoting if the recall is deleted or not?

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Nov 28 08:15:15 2017
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 28 Nov 2017 07:15:15 +0000
Subject: [Koha-bugs] [Bug 14919] Holds history for patrons
In-Reply-To: <bug-14919-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-14919-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-14919-70-YYrVIKPdie@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14919

Katrin Fischer <katrin.fischer at bsz-bw.de> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
            Summary|Holds history for patron    |Holds history for patrons

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Nov 28 08:14:59 2017
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 28 Nov 2017 07:14:59 +0000
Subject: [Koha-bugs] [Bug 13572] Add not-expired parameter to
 borrowers-force-messaging-defaults script
In-Reply-To: <bug-13572-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-13572-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-13572-70-diIPuoELDT@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13572

Katrin Fischer <katrin.fischer at bsz-bw.de> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |katrin.fischer at bsz-bw.de
            Summary|Add not-expired parameter   |Add not-expired parameter
                   |to                          |to
                   |force_borrower_messaging_de |borrowers-force-messaging-d
                   |faults script               |efaults script

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Nov 28 08:15:57 2017
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 28 Nov 2017 07:15:57 +0000
Subject: [Koha-bugs] [Bug 16755] allow SIP2 field DA (hold patron name) to
	be customized
In-Reply-To: <bug-16755-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-16755-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-16755-70-8zJWf8tPZL@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16755

Katrin Fischer <katrin.fischer at bsz-bw.de> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |katrin.fischer at bsz-bw.de
            Summary|allow SIP2 field DA ( hold  |allow SIP2 field DA (hold
                   |patron name ) to be         |patron name) to be
                   |customized                  |customized

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Nov 28 08:16:08 2017
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 28 Nov 2017 07:16:08 +0000
Subject: [Koha-bugs] [Bug 16755] Allow SIP2 field DA (hold patron name) to
	be customized
In-Reply-To: <bug-16755-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-16755-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-16755-70-ZVZZOklVJi@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16755

Katrin Fischer <katrin.fischer at bsz-bw.de> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
            Summary|allow SIP2 field DA (hold   |Allow SIP2 field DA (hold
                   |patron name) to be          |patron name) to be
                   |customized                  |customized

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Nov 28 08:16:22 2017
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 28 Nov 2017 07:16:22 +0000
Subject: [Koha-bugs] [Bug 18104] Allow SIP2 field AE (personal name ) to be
	customized
In-Reply-To: <bug-18104-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-18104-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-18104-70-RqunRAUqct@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18104

Katrin Fischer <katrin.fischer at bsz-bw.de> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |katrin.fischer at bsz-bw.de
            Summary|allow SIP2 field AE         |Allow SIP2 field AE
                   |(personal name ) to be      |(personal name ) to be
                   |customized                  |customized

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Nov 28 08:16:28 2017
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 28 Nov 2017 07:16:28 +0000
Subject: [Koha-bugs] [Bug 18104] Allow SIP2 field AE (personal name) to be
	customized
In-Reply-To: <bug-18104-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-18104-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-18104-70-GvHYK4iC2n@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18104

Katrin Fischer <katrin.fischer at bsz-bw.de> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
            Summary|Allow SIP2 field AE         |Allow SIP2 field AE
                   |(personal name ) to be      |(personal name) to be
                   |customized                  |customized

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Nov 28 08:17:47 2017
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 28 Nov 2017 07:17:47 +0000
Subject: [Koha-bugs] [Bug 18857] Have "actions" at both ends of the
 circulation rules table
In-Reply-To: <bug-18857-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-18857-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-18857-70-04K84Qtxi4@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18857

Katrin Fischer <katrin.fischer at bsz-bw.de> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |katrin.fischer at bsz-bw.de
          Component|Staff Client                |System Administration

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Nov 28 08:18:20 2017
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 28 Nov 2017 07:18:20 +0000
Subject: [Koha-bugs] [Bug 10132] Add option to set MarcOrgCode on branch
	level
In-Reply-To: <bug-10132-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-10132-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-10132-70-U2TVZ4fyLb@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10132

Katrin Fischer <katrin.fischer at bsz-bw.de> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
            Summary|MarcOrgCode would be useful |Add option to set
                   |on branch level             |MarcOrgCode on branch level

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Nov 28 08:19:14 2017
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 28 Nov 2017 07:19:14 +0000
Subject: [Koha-bugs] [Bug 19461] Add floating toolbar to staff client
 catalog search results
In-Reply-To: <bug-19461-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-19461-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-19461-70-8cKSzqNGHZ@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19461

Katrin Fischer <katrin.fischer at bsz-bw.de> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
           Assignee|oleonard at myacpl.org         |koha-bugs at lists.koha-commun
                   |                            |ity.org
          Component|Templates                   |Staff Client
                 CC|                            |gmcharlt at gmail.com,
                   |                            |katrin.fischer at bsz-bw.de

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.

From bugzilla-daemon at bugs.koha-community.org  Tue Nov 28 08:19:37 2017
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 28 Nov 2017 07:19:37 +0000
Subject: [Koha-bugs] [Bug 19461] Add floating toolbar to staff client
 catalog search results
In-Reply-To: <bug-19461-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-19461-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-19461-70-TlMvDFNXdz@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19461

Katrin Fischer <katrin.fischer at bsz-bw.de> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
          Component|Staff Client                |Searching

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Nov 28 08:20:28 2017
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 28 Nov 2017 07:20:28 +0000
Subject: [Koha-bugs] [Bug 18917] Use font awesome buttons in CSV profiles
In-Reply-To: <bug-18917-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-18917-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-18917-70-csrTnCV6Vl@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18917

Katrin Fischer <katrin.fischer at bsz-bw.de> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
            Summary|use font awesome buttons in |Use font awesome buttons in
                   |CSV profiles                |CSV profiles
                 CC|                            |katrin.fischer at bsz-bw.de

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Nov 28 08:20:59 2017
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 28 Nov 2017 07:20:59 +0000
Subject: [Koha-bugs] [Bug 19022] Improve location and author display in
	inventory tool
In-Reply-To: <bug-19022-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-19022-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-19022-70-VT1wtsBxYV@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19022

Katrin Fischer <katrin.fischer at bsz-bw.de> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |katrin.fischer at bsz-bw.de
            Summary|inventory location and      |Improve location and author
                   |author display              |display in inventory tool

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Nov 28 08:22:40 2017
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 28 Nov 2017 07:22:40 +0000
Subject: [Koha-bugs] [Bug 19697] Move template JavaScript to the footer:
	Search results
In-Reply-To: <bug-19697-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-19697-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-19697-70-GxvHSj2A9w@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19697

Claire Gravely <claire_gravely at hotmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Needs Signoff               |Signed Off

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Nov 28 08:22:43 2017
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 28 Nov 2017 07:22:43 +0000
Subject: [Koha-bugs] [Bug 19697] Move template JavaScript to the footer:
	Search results
In-Reply-To: <bug-19697-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-19697-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-19697-70-tgprrUqPGy@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19697

Claire Gravely <claire_gravely at hotmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #69390|0                           |1
        is obsolete|                            |

--- Comment #2 from Claire Gravely <claire_gravely at hotmail.com> ---
Created attachment 69412
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=69412&action=edit
Bug 19697: Move template JavaScript to the footer: Search results

This patch modifies the staff client catalog search results template so
that JavaScript is included in the footer instead of the header.

To test, apply the patch and test the various JavaScript-driven features
of the results page: Floating toolbar, cart, lists, cover images, search
to hold, etc.

Signed-off-by: Claire Gravely <claire.gravely at bsz-bw.de>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Nov 28 08:24:56 2017
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 28 Nov 2017 07:24:56 +0000
Subject: [Koha-bugs] [Bug 18900] Wrong number format in receiving order
In-Reply-To: <bug-18900-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-18900-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-18900-70-LJu4KJaWSG@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18900

Katrin Fischer <katrin.fischer at bsz-bw.de> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
            Summary|wrong number format in      |Wrong number format in
                   |receiving order             |receiving order

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Nov 28 08:25:09 2017
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 28 Nov 2017 07:25:09 +0000
Subject: [Koha-bugs] [Bug 18955] Autocomplete is on in OPAC password recovery
In-Reply-To: <bug-18955-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-18955-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-18955-70-sC2R0rJtab@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18955

Katrin Fischer <katrin.fischer at bsz-bw.de> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
            Summary|autocomplete is on in OPAC  |Autocomplete is on in OPAC
                   |password recovery           |password recovery

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Nov 28 08:25:16 2017
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 28 Nov 2017 07:25:16 +0000
Subject: [Koha-bugs] [Bug 19235] Password visible in OPAC self registration
In-Reply-To: <bug-19235-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-19235-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-19235-70-qLRiHjZdbf@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19235

Katrin Fischer <katrin.fischer at bsz-bw.de> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
            Summary|password visible in OPAC    |Password visible in OPAC
                   |self registration           |self registration

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Nov 28 08:25:55 2017
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 28 Nov 2017 07:25:55 +0000
Subject: [Koha-bugs] [Bug 19323] Subscription edit permission issue
In-Reply-To: <bug-19323-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-19323-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-19323-70-2dmd0Ey7Kd@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19323

Katrin Fischer <katrin.fischer at bsz-bw.de> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
            Summary|subscription edit           |Subscription edit
                   |permission issue            |permission issue

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Nov 28 08:26:04 2017
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 28 Nov 2017 07:26:04 +0000
Subject: [Koha-bugs] [Bug 18851] Use Test::DBIx::Class in tests breaks
	packaging
In-Reply-To: <bug-18851-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-18851-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-18851-70-bBJwInxXuc@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18851

Katrin Fischer <katrin.fischer at bsz-bw.de> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
            Summary|use Test::DBIx::Class in    |Use Test::DBIx::Class in
                   |tests breaks packaging      |tests breaks packaging
                 CC|                            |katrin.fischer at bsz-bw.de

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Nov 28 08:26:15 2017
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 28 Nov 2017 07:26:15 +0000
Subject: [Koha-bugs] [Bug 19373] CAS login for staff interface always goes
	back to home
In-Reply-To: <bug-19373-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-19373-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-19373-70-oe1JfDazg0@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19373

Katrin Fischer <katrin.fischer at bsz-bw.de> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |katrin.fischer at bsz-bw.de
            Summary|CAS Login for staff         |CAS login for staff
                   |interface always go back to |interface always goes back
                   |home.                       |to home

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Nov 28 08:26:22 2017
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 28 Nov 2017 07:26:22 +0000
Subject: [Koha-bugs] [Bug 18629] Translatability: Fix problems with web
	installer 17.05
In-Reply-To: <bug-18629-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-18629-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-18629-70-3Nfif0UHKl@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18629

Katrin Fischer <katrin.fischer at bsz-bw.de> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Text to go in the|Fix translatability issues  |
      release notes|with web installer.         |

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Nov 28 11:14:22 2017
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 28 Nov 2017 10:14:22 +0000
Subject: [Koha-bugs] [Bug 18007] Interface updates to notices and notice
	previews
In-Reply-To: <bug-18007-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-18007-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-18007-70-djJB1XqZMH@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18007

Claire Gravely <claire_gravely at hotmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Needs Signoff               |Signed Off

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Nov 28 11:14:26 2017
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 28 Nov 2017 10:14:26 +0000
Subject: [Koha-bugs] [Bug 18007] Interface updates to notices and notice
	previews
In-Reply-To: <bug-18007-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-18007-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-18007-70-44Y9hO6Jbc@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18007

Claire Gravely <claire_gravely at hotmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #68083|0                           |1
        is obsolete|                            |

--- Comment #5 from Claire Gravely <claire_gravely at hotmail.com> ---
Created attachment 69413
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=69413&action=edit
Bug 18007: Interface updates to notices and notice previews

This patch makes changes to the form for adding and editing notices, and
to the template for viewing a rendered preview of notices.

- Preview now shows side-by-side comparisons
- JavaScript has been movied out of template into separate file
- Validation of the add/edit form improved through use of validation
  plugin
- There is now better visual feedback for AJAX form checks

To test, apply the patch on top of those for Bug 17981

- Add a new notice.
  - Confirm that the form can't be submitted without data in the "code"
    and "name" fields.
  - Confirm that the form can't be submitted without filling in at least
    one message template (subject and body).
  - Confirm that you cannot submit the form while using an
    existing notice code.
  - Follow Bug 17981's test plan for testing the preview function.
    Confirm that the preview loads correctly and looks correct.

Signed-off-by: Claire Gravely <claire.gravely at bsz-bw.de>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Nov 28 11:40:47 2017
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 28 Nov 2017 10:40:47 +0000
Subject: [Koha-bugs] [Bug 19707] New: "merge",
 "revert" and "add" operations for synchronizing Elasticsearch
 mappings stored in database with mappings.yaml
Message-ID: <bug-19707-70@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19707

            Bug ID: 19707
           Summary: "merge", "revert" and "add" operations for
                    synchronizing Elasticsearch mappings stored in
                    database with mappings.yaml
 Change sponsored?: ---
           Product: Koha
           Version: master
          Hardware: All
                OS: All
            Status: NEW
          Severity: enhancement
          Priority: P5 - low
         Component: Searching - Elasticsearch
          Assignee: koha-bugs at lists.koha-community.org
          Reporter: glasklas at gmail.com

It would be nice to have the option to synchronize possible upstream mappings
with local onces, without overwritning local changes, so wrote this patch to
"merge", "revert" and "add" operations for synchronizing Elasticsearch mappings
stored in database with mappings.yaml

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.

From bugzilla-daemon at bugs.koha-community.org  Tue Nov 28 11:46:31 2017
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 28 Nov 2017 10:46:31 +0000
Subject: [Koha-bugs] [Bug 19707] Add new operations for synchronizing
 Elasticsearch mappings
In-Reply-To: <bug-19707-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-19707-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-19707-70-jbqaawIeEY@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19707

David Gustafsson <glasklas at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
            Summary|"merge", "revert" and "add" |Add new operations for
                   |operations for              |synchronizing Elasticsearch
                   |synchronizing Elasticsearch |mappings
                   |mappings stored in database |
                   |with mappings.yaml          |

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.

From bugzilla-daemon at bugs.koha-community.org  Tue Nov 28 11:48:30 2017
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 28 Nov 2017 10:48:30 +0000
Subject: [Koha-bugs] [Bug 19707] Add new operations for synchronizing
 Elasticsearch mappings
In-Reply-To: <bug-19707-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-19707-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-19707-70-iP9DWakh9W@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19707

--- Comment #1 from David Gustafsson <glasklas at gmail.com> ---
Created attachment 69414
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=69414&action=edit
Bug 19707 - Add new operations for synchronizing Elasticsearch mappings

Add new "merge", "revert" and "add" operations for synchronizing
Elasticsearch mappings stored in database with mappings.yaml

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Nov 28 12:02:54 2017
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 28 Nov 2017 11:02:54 +0000
Subject: [Koha-bugs] [Bug 19707] Add new operations for synchronizing
 Elasticsearch mappings
In-Reply-To: <bug-19707-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-19707-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-19707-70-w1M3uVt6X3@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19707

--- Comment #2 from David Gustafsson <glasklas at gmail.com> ---
"add": Only new fields will be added (present in mappings.yaml but not in
database), mappings for fields stored in database will be left untouched.

"revert": Mappings for all fields in mappings.yaml will be reverted, mappings
restored to default onces, and local modifications of those mappings removed.

"merge": New mappings for fields present in mappings.yaml will be merged in,
keeping any local modifications of marc targets (this could also include old
problematic mappings later fixed in mappings.yaml, so should be used with some
caution).

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Nov 28 13:53:18 2017
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 28 Nov 2017 12:53:18 +0000
Subject: [Koha-bugs] [Bug 19532] Recalls for Koha
In-Reply-To: <bug-19532-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-19532-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-19532-70-poB8MFlPyP@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19532

--- Comment #30 from Jonathan Druart <jonathan.druart at bugs.koha-community.org> ---
(In reply to Petter Goks?yr ?sen from comment #29)
> Quick comment:
> Given the troubles we have with duplicate primary keys in old/deleted
> tables, would't it be better to drop the old_recalls table, and keep it in
> one table, with a flag denoting if the recall is deleted or not?

Yes, see comment 5 as well.
Aleisha, did you consider this alternative?

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Nov 28 15:10:15 2017
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 28 Nov 2017 14:10:15 +0000
Subject: [Koha-bugs] [Bug 19641] Move patron templates to the footer
In-Reply-To: <bug-19641-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-19641-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-19641-70-Fq31BMs3ax@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19641

Claire Gravely <claire_gravely at hotmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Needs Signoff               |Signed Off

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Nov 28 15:10:19 2017
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 28 Nov 2017 14:10:19 +0000
Subject: [Koha-bugs] [Bug 19641] Move patron templates to the footer
In-Reply-To: <bug-19641-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-19641-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-19641-70-fXQlHcIuy5@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19641

Claire Gravely <claire_gravely at hotmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #69200|0                           |1
        is obsolete|                            |

--- Comment #2 from Claire Gravely <claire_gravely at hotmail.com> ---
Created attachment 69415
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=69415&action=edit
Bug 19641: Move patron templates to the footer

This patch modifies the staff client patron module templates so that
JavaScript is included in the footer instead of the header.

This patch touches a lot of files because the changes are all
interdependent, affecting a couple of module-wide include files.

To test, apply the patch and test the JavaScript-driven features of the
modified templates: All button controls, DataTables functionality, tabs,
etc.

Patrons -> Patrons home, patron search results
  -> Manage pending modification requests
  -> Patron detail page
    -> Edit patron
      -> Set guarantor
    -> Fines
       -> Account, Pay fines, Create manual invoice, Create manual
          credit
       -> Print receipts for different kinds of charges
    -> Routing lists
    -> Circulation history
    -> Holds history
    -> Notices
    -> Statistics
    -> Files
    -> Purchase suggestions
    -> Discharges
    -> Housebound
    -> Set permissions
    -> Change password
    -> Print summary, slips, and overdues
    -> Update child to adult patron type

Patron toolbar and patron search bar operations should work correctly on
all pages.

This patch also updates the template for searching the Norwegian
national patron database, but it has NOT been tested.

Signed-off-by: Claire Gravely <claire.gravely at bsz-bw.de>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Nov 28 15:23:09 2017
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 28 Nov 2017 14:23:09 +0000
Subject: [Koha-bugs] [Bug 19575] Use canonical field names and resolve
	aliased fields
In-Reply-To: <bug-19575-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-19575-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-19575-70-huWUlBZgG7@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19575

--- Comment #16 from David Gustafsson <glasklas at gmail.com> ---
https://github.com/ub-digit/koha-indexdefs-to-mappings-yaml

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Nov 28 15:32:05 2017
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 28 Nov 2017 14:32:05 +0000
Subject: [Koha-bugs] [Bug 2093] Add OPAC dashboard for logged-in users
In-Reply-To: <bug-2093-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-2093-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-2093-70-kPd4vrLFEQ@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=2093

Jonathan Druart <jonathan.druart at bugs.koha-community.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
           Severity|enhancement                 |new feature

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Nov 28 15:32:21 2017
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 28 Nov 2017 14:32:21 +0000
Subject: [Koha-bugs] [Bug 14919] Holds history for patrons
In-Reply-To: <bug-14919-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-14919-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-14919-70-al9YcFg19w@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14919

Jonathan Druart <jonathan.druart at bugs.koha-community.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Text to go in the|This enhancement adds new   |This new feature adds new
      release notes|page called "Holds          |page called "Holds
                   |history". The page is       |history". The page is
                   |accessible from left menu   |accessible from left menu
                   |on every patron related     |on every patron related
                   |page. It allows librarians  |page. It allows librarians
                   |to see the history of all   |to see the history of all
                   |holds of given patron, with |holds of given patron, with
                   |the actual status. It could |the actual status. It could
                   |be useful especially when   |be useful especially when
                   |the hold is cancelled.      |the hold is cancelled.
                   |Before this patch the hold  |Before this patch the hold
                   |just disappeared when       |just disappeared when
                   |cancelled (automatically or |cancelled (automatically or
                   |manually).                  |manually).
           Severity|enhancement                 |new feature

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Nov 28 15:34:48 2017
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 28 Nov 2017 14:34:48 +0000
Subject: [Koha-bugs] [Bug 19690] Smart rules: Term "If any unavailable" is
 confusing and just means No
In-Reply-To: <bug-19690-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-19690-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-19690-70-WVO4Hs8GpQ@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19690

--- Comment #3 from Marcel de Rooy <m.de.rooy at rijksmuseum.nl> ---
Please have a look at the code in IsAvailableForItemLevelRequest:

    } elsif ( $on_shelf_holds == 2 ) {
        my @items = ...
        my $any_available = 0;
        foreach my $i (@items) {
...
            $any_available = 1
              unless $i->itemlost
...
        }
        return $any_available ? 0 : 1;
    }

The variable name could put you on the wrong track, but 2 == all_unavailable.
What does the above say? If you choose for all_unavailable and there is at
lease one item available ("On shelf"), you cannot place the hold. If all are
unavailable, you can place the item level hold.

Finally, we have the remaining case (on_shelf_holds == 0 /"If any
unavailable"):

    return $item->{onloan} || GetReserveStatus($item->{itemnumber}) eq
"Waiting"

The item level hold is only allowed now if the current item is on loan or
waiting. (Using the term "any" here is making no sense to me..)

===
What makes it more complicated, is the use of the sub OnShelfHoldsAllowed in
Koha (opac-detail, opac-shelves). In opac-detail-sidebar.inc the following test
is used before displaying a place hold link:
[% IF ( AllowOnShelfHolds OR ItemsIssued ) %]
opac-shelves does more or less the same by first testing allow_onshelf_holds
and testing if issued in the else branch.
Note that in these tests the values 1 and 2 are just interpreted as one case
(shelf holds are allowed).

===
Conclusion: The name is confusing/misleading. This is partially hidden by the
obscure use of onshelfholds in other places. We cannot solve this by a rename
only. So I am leaving it as-is.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Nov 28 15:38:36 2017
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 28 Nov 2017 14:38:36 +0000
Subject: [Koha-bugs] [Bug 19690] Smart rules: Term "If any unavailable" is
	confusing
In-Reply-To: <bug-19690-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-19690-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-19690-70-3HhyQP3svt@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19690

Marcel de Rooy <m.de.rooy at rijksmuseum.nl> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
            Summary|Smart rules: Term "If any   |Smart rules: Term "If any
                   |unavailable" is confusing   |unavailable" is confusing
                   |and just means No           |

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Nov 28 15:38:39 2017
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 28 Nov 2017 14:38:39 +0000
Subject: [Koha-bugs] [Bug 15685] Allow creation of items (AcqCreateItem) to
 be customizable per-basket
In-Reply-To: <bug-15685-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-15685-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-15685-70-ryv5Q22jT5@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15685

Jonathan Druart <jonathan.druart at bugs.koha-community.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
           Severity|enhancement                 |new feature

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Nov 28 15:38:46 2017
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 28 Nov 2017 14:38:46 +0000
Subject: [Koha-bugs] [Bug 10132] Add option to set MarcOrgCode on branch
	level
In-Reply-To: <bug-10132-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-10132-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-10132-70-yKhuMhxgqj@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10132

Tom?s Cohen Arazi <tomascohen at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Text to go in the|                            |This development allows
      release notes|                            |setting different MARC
                   |                            |organization codes
                   |                            |(http://www.loc.gov/marc/or
                   |                            |ganizations) for each
                   |                            |library/branch, instead of
                   |                            |only the globally
                   |                            |configured 'MARCOrgCode'
                   |                            |syspref. This is
                   |                            |particularly useful for
                   |                            |consortia with different
                   |                            |libraries and different
                   |                            |MARC organization codes.
           Severity|enhancement                 |new feature

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Nov 28 15:38:56 2017
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 28 Nov 2017 14:38:56 +0000
Subject: [Koha-bugs] [Bug 19690] Smart rules: Term "If any unavailable" is
	confusing
In-Reply-To: <bug-19690-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-19690-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-19690-70-5jZjYzLBLr@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19690

Marcel de Rooy <m.de.rooy at rijksmuseum.nl> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #69382|0                           |1
        is obsolete|                            |

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Nov 28 15:39:13 2017
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 28 Nov 2017 14:39:13 +0000
Subject: [Koha-bugs] [Bug 19690] Smart rules: Term "If any unavailable" is
	confusing
In-Reply-To: <bug-19690-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-19690-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-19690-70-1jyTav8W7p@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19690

Marcel de Rooy <m.de.rooy at rijksmuseum.nl> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Failed QA                   |ASSIGNED

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Nov 28 15:39:22 2017
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 28 Nov 2017 14:39:22 +0000
Subject: [Koha-bugs] [Bug 19690] Smart rules: Term "If any unavailable" is
	confusing
In-Reply-To: <bug-19690-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-19690-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-19690-70-il8lgWQTyv@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19690

Marcel de Rooy <m.de.rooy at rijksmuseum.nl> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|ASSIGNED                    |NEW

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Nov 28 15:39:39 2017
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 28 Nov 2017 14:39:39 +0000
Subject: [Koha-bugs] [Bug 19690] Smart rules: Term "If any unavailable" is
	confusing
In-Reply-To: <bug-19690-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-19690-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-19690-70-Vq8m0pRCRj@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19690

Marcel de Rooy <m.de.rooy at rijksmuseum.nl> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
           Assignee|m.de.rooy at rijksmuseum.nl    |koha-bugs at lists.koha-commun
                   |                            |ity.org

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Nov 28 15:39:50 2017
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 28 Nov 2017 14:39:50 +0000
Subject: [Koha-bugs] [Bug 19690] Smart rules: Term "If any unavailable" is
	confusing
In-Reply-To: <bug-19690-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-19690-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-19690-70-yg62prUCY2@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19690

Marcel de Rooy <m.de.rooy at rijksmuseum.nl> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
   Patch complexity|Trivial patch               |---

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Nov 28 15:43:09 2017
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 28 Nov 2017 14:43:09 +0000
Subject: [Koha-bugs] [Bug 19462] Add a koha-elasticsearch command
In-Reply-To: <bug-19462-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-19462-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-19462-70-ZAsz9k4GXx@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19462

Tom?s Cohen Arazi <tomascohen at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Text to go in the|                            |A new command-line script
      release notes|                            |is added for handling
                   |                            |Elasticsearch
                   |                            |indexing-related tasks for
                   |                            |each Koha instance.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Nov 28 15:49:58 2017
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 28 Nov 2017 14:49:58 +0000
Subject: [Koha-bugs] [Bug 19033] XSS Flaws in Currencies and exchange page
In-Reply-To: <bug-19033-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-19033-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-19033-70-N0AxVxFUYV@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19033

Tom?s Cohen Arazi <tomascohen at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
           Severity|enhancement                 |major

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Nov 28 15:50:07 2017
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 28 Nov 2017 14:50:07 +0000
Subject: [Koha-bugs] [Bug 19034] XSS Flaws in- Cities - Z39.50/ SRU servers
 administration - Patron categories pages
In-Reply-To: <bug-19034-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-19034-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-19034-70-KUgkTfmoVD@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19034

Tom?s Cohen Arazi <tomascohen at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
           Severity|enhancement                 |major

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Nov 28 15:50:15 2017
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 28 Nov 2017 14:50:15 +0000
Subject: [Koha-bugs] [Bug 19050] XSS Flaws in Quick spine label creator
In-Reply-To: <bug-19050-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-19050-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-19050-70-JN8RiCm6qd@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19050

Tom?s Cohen Arazi <tomascohen at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
           Severity|enhancement                 |major

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Nov 28 15:50:23 2017
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 28 Nov 2017 14:50:23 +0000
Subject: [Koha-bugs] [Bug 19051] XSS Flaws in - Batch record deletion page -
 Batch item deletion page - Batch item modification page
In-Reply-To: <bug-19051-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-19051-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-19051-70-SGhVc891mD@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19051

Tom?s Cohen Arazi <tomascohen at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
           Severity|enhancement                 |major

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Nov 28 15:50:30 2017
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 28 Nov 2017 14:50:30 +0000
Subject: [Koha-bugs] [Bug 19052] XSS Flaws in - vendor search page - Invoice
	search page
In-Reply-To: <bug-19052-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-19052-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-19052-70-1uOKjbciWX@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19052

Tom?s Cohen Arazi <tomascohen at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
           Severity|enhancement                 |major

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Nov 28 15:50:38 2017
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 28 Nov 2017 14:50:38 +0000
Subject: [Koha-bugs] [Bug 19054] XSS Flaws in Report - Top Most-circulated
	items
In-Reply-To: <bug-19054-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-19054-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-19054-70-W0DRCrHd3k@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19054

Tom?s Cohen Arazi <tomascohen at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
           Severity|enhancement                 |major

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Nov 28 15:50:48 2017
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 28 Nov 2017 14:50:48 +0000
Subject: [Koha-bugs] [Bug 19078] XSS Flaws in System preferences
In-Reply-To: <bug-19078-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-19078-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-19078-70-cF6QyWFCY2@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19078

Tom?s Cohen Arazi <tomascohen at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
           Severity|enhancement                 |major

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Nov 28 15:50:55 2017
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 28 Nov 2017 14:50:55 +0000
Subject: [Koha-bugs] [Bug 19100] XSS Flaws in memberentry.pl
In-Reply-To: <bug-19100-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-19100-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-19100-70-ovZs8NCeGo@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19100

Tom?s Cohen Arazi <tomascohen at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
           Severity|enhancement                 |major
                 CC|                            |tomascohen at gmail.com

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Nov 28 15:51:08 2017
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 28 Nov 2017 14:51:08 +0000
Subject: [Koha-bugs] [Bug 19105] XSS Stored in holidays.pl
In-Reply-To: <bug-19105-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-19105-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-19105-70-2D8YfWHZAa@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19105

Tom?s Cohen Arazi <tomascohen at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
           Severity|enhancement                 |major
                 CC|                            |tomascohen at gmail.com

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Nov 28 15:51:17 2017
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 28 Nov 2017 14:51:17 +0000
Subject: [Koha-bugs] [Bug 19112] Stored XSS in basketheader.pl
In-Reply-To: <bug-19112-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-19112-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-19112-70-Vs8KplCCEX@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19112

Tom?s Cohen Arazi <tomascohen at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
           Severity|enhancement                 |major
                 CC|                            |tomascohen at gmail.com

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Nov 28 15:51:32 2017
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 28 Nov 2017 14:51:32 +0000
Subject: [Koha-bugs] [Bug 19114] Stored XSS in parcels.pl
In-Reply-To: <bug-19114-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-19114-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-19114-70-vykkBKk1sn@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19114

Tom?s Cohen Arazi <tomascohen at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |tomascohen at gmail.com
           Severity|enhancement                 |major

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Nov 28 16:00:37 2017
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 28 Nov 2017 15:00:37 +0000
Subject: [Koha-bugs] [Bug 16069] XSS issue in basket.pl page
In-Reply-To: <bug-16069-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-16069-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-16069-70-D47QGXU2pO@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16069

Tom?s Cohen Arazi <tomascohen at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |tomascohen at gmail.com
           Severity|normal                      |major

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Nov 28 16:00:45 2017
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 28 Nov 2017 15:00:45 +0000
Subject: [Koha-bugs] [Bug 18726] OPAC XSS - biblionumber
In-Reply-To: <bug-18726-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-18726-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-18726-70-NFUQ7bdVPn@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18726

Tom?s Cohen Arazi <tomascohen at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
           Severity|normal                      |major
                 CC|                            |tomascohen at gmail.com

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Nov 28 16:01:09 2017
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 28 Nov 2017 15:01:09 +0000
Subject: [Koha-bugs] [Bug 19035] Stored XSS in patron lists -  lists.pl
In-Reply-To: <bug-19035-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-19035-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-19035-70-VO1V8XypGZ@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19035

Tom?s Cohen Arazi <tomascohen at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |tomascohen at gmail.com
           Severity|normal                      |major

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Nov 28 16:01:17 2017
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 28 Nov 2017 15:01:17 +0000
Subject: [Koha-bugs] [Bug 19079] XSS Flaws in Membership page
In-Reply-To: <bug-19079-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-19079-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-19079-70-iatR2lki3V@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19079

Tom?s Cohen Arazi <tomascohen at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
           Severity|normal                      |major

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Nov 28 16:01:35 2017
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 28 Nov 2017 15:01:35 +0000
Subject: [Koha-bugs] [Bug 19103] Stored XSS in itemtypes.pl -
 patron-attr-types.pl - matching-rules.pl
In-Reply-To: <bug-19103-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-19103-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-19103-70-tGaQJKG6Xr@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19103

Tom?s Cohen Arazi <tomascohen at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
           Severity|normal                      |major

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Nov 28 16:01:43 2017
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 28 Nov 2017 15:01:43 +0000
Subject: [Koha-bugs] [Bug 19108] Stored XSS in multiple scripts
In-Reply-To: <bug-19108-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-19108-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-19108-70-kSJVCEgLvg@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19108

Tom?s Cohen Arazi <tomascohen at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
           Severity|normal                      |major

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Nov 28 16:01:26 2017
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 28 Nov 2017 15:01:26 +0000
Subject: [Koha-bugs] [Bug 19086] Multiple cross-site scripting
	vulnerabilities
In-Reply-To: <bug-19086-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-19086-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-19086-70-jV7Fi94S5G@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19086

Tom?s Cohen Arazi <tomascohen at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
           Severity|normal                      |major

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.

From bugzilla-daemon at bugs.koha-community.org  Tue Nov 28 16:01:51 2017
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 28 Nov 2017 15:01:51 +0000
Subject: [Koha-bugs] [Bug 19110] XSS Stored in branches.pl
In-Reply-To: <bug-19110-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-19110-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-19110-70-52FK3eNB5M@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19110

Tom?s Cohen Arazi <tomascohen at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
           Severity|normal                      |major
                 CC|                            |tomascohen at gmail.com

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Nov 28 16:01:58 2017
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 28 Nov 2017 15:01:58 +0000
Subject: [Koha-bugs] [Bug 19125] XSS - members.pl
In-Reply-To: <bug-19125-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-19125-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-19125-70-FK1qPTOFNp@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19125

Tom?s Cohen Arazi <tomascohen at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
           Severity|normal                      |major

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Nov 28 16:02:06 2017
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 28 Nov 2017 15:02:06 +0000
Subject: [Koha-bugs] [Bug 19127] Stored XSS in csv-profiles.pl
In-Reply-To: <bug-19127-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-19127-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-19127-70-VMoNP4X0lm@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19127

Tom?s Cohen Arazi <tomascohen at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
           Severity|normal                      |major

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Nov 28 16:02:17 2017
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 28 Nov 2017 15:02:17 +0000
Subject: [Koha-bugs] [Bug 19128] XSS - patron-attr-types.tt,
 authorised_values.tt and categories.tt
In-Reply-To: <bug-19128-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-19128-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-19128-70-B8hrhutPTq@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19128

Tom?s Cohen Arazi <tomascohen at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
           Severity|normal                      |major

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Nov 28 16:02:27 2017
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 28 Nov 2017 15:02:27 +0000
Subject: [Koha-bugs] [Bug 19333] XSS vulnerability in opac-shelves
In-Reply-To: <bug-19333-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-19333-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-19333-70-DfOOoKF0Se@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19333

Tom?s Cohen Arazi <tomascohen at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
           Severity|normal                      |major
                 CC|                            |tomascohen at gmail.com

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Nov 28 16:02:35 2017
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 28 Nov 2017 15:02:35 +0000
Subject: [Koha-bugs] [Bug 18653] Possible privacy breach with OPAC password
	recovery
In-Reply-To: <bug-18653-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-18653-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-18653-70-NCQY6i1qTN@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18653

Tom?s Cohen Arazi <tomascohen at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |tomascohen at gmail.com
           Severity|normal                      |major

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Nov 28 16:09:47 2017
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 28 Nov 2017 15:09:47 +0000
Subject: [Koha-bugs] [Bug 19173] Make OPAC online payments pluggable
In-Reply-To: <bug-19173-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-19173-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-19173-70-YybTim1Z08@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19173

Tom?s Cohen Arazi <tomascohen at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Text to go in the|                            |This development allows
      release notes|                            |adding new payment methods
                   |                            |through the use of Koha
                   |                            |plugins. It provides
                   |                            |institutions with more
                   |                            |flexibility and an easier
                   |                            |path to integrate local
                   |                            |payment methods.
         QA Contact|testopia at bugs.koha-communit |tomascohen at gmail.com
                   |y.org                       |
           Severity|enhancement                 |new feature

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Nov 28 16:10:01 2017
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 28 Nov 2017 15:10:01 +0000
Subject: [Koha-bugs] [Bug 18653] Possible privacy breach with OPAC password
	recovery
In-Reply-To: <bug-18653-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-18653-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-18653-70-ghJFhZpyDg@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18653

Jonathan Druart <jonathan.druart at bugs.koha-community.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Text to go in the|Remove the possibility to   |
      release notes|find out an email address   |
                   |related to a library        |
                   |account by guessing user    |
                   |names in OPAC password      |
                   |recovery.                   |

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Nov 28 16:50:23 2017
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 28 Nov 2017 15:50:23 +0000
Subject: [Koha-bugs] [Bug 18137] Migrate from Mojolicious::Plugin::Swagger2
 to Mojolicious:: Plugin::OpenAPI
In-Reply-To: <bug-18137-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-18137-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-18137-70-VdzkvzhJsN@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18137

Tom?s Cohen Arazi <tomascohen at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
            Summary|REST API: Migrate from      |Migrate from
                   |Mojolicious::Plugin::Swagge |Mojolicious::Plugin::Swagge
                   |r2 to                       |r2 to
                   |Mojolicious::Plugin::OpenAP |Mojolicious::Plugin::OpenAP
                   |I                           |I

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Nov 28 17:03:43 2017
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 28 Nov 2017 16:03:43 +0000
Subject: [Koha-bugs] [Bug 19708] New: Printing code improvements in
	opac-basket.tt
Message-ID: <bug-19708-70@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19708

            Bug ID: 19708
           Summary: Printing code improvements in opac-basket.tt
 Change sponsored?: ---
           Product: Koha
           Version: master
          Hardware: All
                OS: All
            Status: ASSIGNED
          Severity: enhancement
          Priority: P5 - low
         Component: OPAC
          Assignee: david.bourgault at inlibro.com
          Reporter: david.bourgault at inlibro.com
        QA Contact: testopia at bugs.koha-community.org

The code for the printing function in opac-basket.tt contains a lot of useless
branching.

Additionally when printing a short basket (e.g.: 1 notice only), it will still
print on two pages.

To reproduce:
0) Add an item to your basket
1) Print basket: there will be an extra blank page after the basket.
(This happens on Chrome and Firefox, I have not tested on other browsers)

Patch will follow shortly.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Nov 28 17:04:55 2017
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 28 Nov 2017 16:04:55 +0000
Subject: [Koha-bugs] [Bug 19653] Move tools templates JavaScript to the
 footer: Additional tools
In-Reply-To: <bug-19653-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-19653-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-19653-70-WTTUkleCt2@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19653

Owen Leonard <oleonard at myacpl.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|ASSIGNED                    |Needs Signoff
   Patch complexity|---                         |Small patch

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Nov 28 17:04:58 2017
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 28 Nov 2017 16:04:58 +0000
Subject: [Koha-bugs] [Bug 19653] Move tools templates JavaScript to the
 footer: Additional tools
In-Reply-To: <bug-19653-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-19653-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-19653-70-ZsdYn70DZR@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19653

--- Comment #1 from Owen Leonard <oleonard at myacpl.org> ---
Created attachment 69416
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=69416&action=edit
Bug 19653: Move tools templates JavaScript to the footer: Additional tools

This patch modifies the staff client "Additional tools" templates so
that JavaScript is included in the footer instead of the header:

- Calendar
- CSV profiles
- Log viewer
- News
- Task scheduler
- Edit quotes for QOTD feature
- Upload

Note that the log viewer template has been modified so that the
"interface" variable (passed to the template to provide the correct path
to staff client assets) isn't overwritten by an "interface" variable
required by the log viewer.

To test, apply the patch and test the JavaScript-driven features of
each modified template: All button controls, DataTables functionality,
form validation, etc.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Nov 28 17:08:05 2017
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 28 Nov 2017 16:08:05 +0000
Subject: [Koha-bugs] [Bug 19709] New: Move template JavaScript to the
	footer: Labels
Message-ID: <bug-19709-70@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19709

            Bug ID: 19709
           Summary: Move template JavaScript to the footer: Labels
 Change sponsored?: ---
           Product: Koha
           Version: master
          Hardware: All
                OS: All
            Status: ASSIGNED
          Severity: enhancement
          Priority: P5 - low
         Component: Templates
          Assignee: oleonard at myacpl.org
          Reporter: oleonard at myacpl.org
        QA Contact: testopia at bugs.koha-community.org
                CC: dominic.pichette at inlibro.com,
                    jonathan.druart at bugs.koha-community.org,
                    nick at bywatersolutions.com, simon.pouchol at biblibre.com,
                    testopia at bugs.koha-community.org
        Depends on: 19647
            Blocks: 17858

In order to conform to best practices for performance staff client template
javascript should be in the footer instead of the header.

This patch will do so for label creator templates.


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17858
[Bug 17858] Omnibus: Move staff client JavaScript to the footer
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19647
[Bug 19647] Move patron lists templates JS to the footer
-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Nov 28 17:08:05 2017
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 28 Nov 2017 16:08:05 +0000
Subject: [Koha-bugs] [Bug 19647] Move patron lists templates JS to the footer
In-Reply-To: <bug-19647-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-19647-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-19647-70-uGQ6GXOAuE@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19647

Owen Leonard <oleonard at myacpl.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Blocks|                            |19709


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19709
[Bug 19709] Move template JavaScript to the footer: Labels
-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Nov 28 17:08:05 2017
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 28 Nov 2017 16:08:05 +0000
Subject: [Koha-bugs] [Bug 17858] Omnibus: Move staff client JavaScript to
	the footer
In-Reply-To: <bug-17858-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-17858-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-17858-70-bBNA87h6KS@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17858

Owen Leonard <oleonard at myacpl.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
         Depends on|                            |19709


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19709
[Bug 19709] Move template JavaScript to the footer: Labels
-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Nov 28 17:28:15 2017
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 28 Nov 2017 16:28:15 +0000
Subject: [Koha-bugs] [Bug 19708] Printing code improvements in opac-basket.tt
In-Reply-To: <bug-19708-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-19708-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-19708-70-V766RRWcyM@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19708

--- Comment #1 from David Bourgault <david.bourgault at inlibro.com> ---
Created attachment 69417
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=69417&action=edit
Bug 19708 - Remove useless code from opac-basket

This removes a lot of useless code relating to the print function from
opac-basket.tt, opac-basket.pl and opac/basket.js.

It also fixes the CSS so that no extra blank page is printed.

To test:
0) Add an item to your cart
1) Print your basket
    Note the appearance of the page. There will be an extra blank page.
2) Apply patch
3) Reload basket
4) Print your basket
    The appearce should be identical. The extra blank page is gone.

This only affects the OPAC.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Nov 28 17:28:13 2017
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 28 Nov 2017 16:28:13 +0000
Subject: [Koha-bugs] [Bug 19708] Printing code improvements in opac-basket.tt
In-Reply-To: <bug-19708-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-19708-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-19708-70-zn0TBSeRhN@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19708

David Bourgault <david.bourgault at inlibro.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
   Patch complexity|---                         |Small patch
             Status|ASSIGNED                    |Needs Signoff

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Nov 28 17:28:32 2017
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 28 Nov 2017 16:28:32 +0000
Subject: [Koha-bugs] [Bug 19708] Printing code improvements in opac-basket.tt
In-Reply-To: <bug-19708-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-19708-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-19708-70-FdYnpXgOFZ@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19708

David Bourgault <david.bourgault at inlibro.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |david.bourgault at inlibro.com
                   |                            |,
                   |                            |philippe.blouin at inlibro.com

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Nov 28 19:01:02 2017
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 28 Nov 2017 18:01:02 +0000
Subject: [Koha-bugs] [Bug 19709] Move template JavaScript to the footer:
	Labels
In-Reply-To: <bug-19709-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-19709-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-19709-70-A7x7DFzvsI@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19709

Owen Leonard <oleonard at myacpl.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
         Depends on|                            |19608


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19608
[Bug 19608] Move admin templates JavaScript to the footer: The rest
-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Nov 28 19:01:02 2017
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 28 Nov 2017 18:01:02 +0000
Subject: [Koha-bugs] [Bug 19608] Move admin templates JavaScript to the
	footer: The rest
In-Reply-To: <bug-19608-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-19608-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-19608-70-APFms3bb94@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19608

Owen Leonard <oleonard at myacpl.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Blocks|                            |19709


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19709
[Bug 19709] Move template JavaScript to the footer: Labels
-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Nov 28 19:02:18 2017
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 28 Nov 2017 18:02:18 +0000
Subject: [Koha-bugs] [Bug 19709] Move template JavaScript to the footer:
	Labels
In-Reply-To: <bug-19709-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-19709-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-19709-70-MKJUocOGjq@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19709

Owen Leonard <oleonard at myacpl.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
   Patch complexity|---                         |Small patch
             Status|ASSIGNED                    |Needs Signoff

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Nov 28 19:02:21 2017
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 28 Nov 2017 18:02:21 +0000
Subject: [Koha-bugs] [Bug 19709] Move template JavaScript to the footer:
	Labels
In-Reply-To: <bug-19709-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-19709-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-19709-70-NStG8QZwzS@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19709

--- Comment #1 from Owen Leonard <oleonard at myacpl.org> ---
Created attachment 69418
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=69418&action=edit
Bug 19709 - Move template JavaScript to the footer: Labels

This patch modifies the staff client label creator templates so that
JavaScript is included in the footer instead of the header.

To test, apply the patch and test the JavaScript-driven features of
each modified template: All button controls, DataTables functionality,
form validation, etc.

- Creating and managing layouts
- Creating and managing batches
- Creating and managing templates
- Creating and managing printer profiles
- Creating quick spine labels

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Nov 28 19:35:02 2017
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 28 Nov 2017 18:35:02 +0000
Subject: [Koha-bugs] [Bug 19710] New: Move plugins templates to the footer
Message-ID: <bug-19710-70@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19710

            Bug ID: 19710
           Summary: Move plugins templates to the footer
 Change sponsored?: ---
           Product: Koha
           Version: master
          Hardware: All
                OS: All
            Status: ASSIGNED
          Severity: enhancement
          Priority: P5 - low
         Component: Templates
          Assignee: oleonard at myacpl.org
          Reporter: oleonard at myacpl.org
        QA Contact: testopia at bugs.koha-community.org
                CC: testopia at bugs.koha-community.org
        Depends on: 19647
            Blocks: 17858

In order to conform to best practices for performance staff client template
javascript should be in the footer instead of the header.

This patch will do so for plugins templates.


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17858
[Bug 17858] Omnibus: Move staff client JavaScript to the footer
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19647
[Bug 19647] Move patron lists templates JS to the footer
-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Nov 28 19:35:02 2017
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 28 Nov 2017 18:35:02 +0000
Subject: [Koha-bugs] [Bug 17858] Omnibus: Move staff client JavaScript to
	the footer
In-Reply-To: <bug-17858-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-17858-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-17858-70-igDzr0J2j4@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17858

Owen Leonard <oleonard at myacpl.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
         Depends on|                            |19710


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19710
[Bug 19710] Move plugins templates to the footer
-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Nov 28 19:35:02 2017
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 28 Nov 2017 18:35:02 +0000
Subject: [Koha-bugs] [Bug 19647] Move patron lists templates JS to the footer
In-Reply-To: <bug-19647-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-19647-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-19647-70-UE1cp8W5Fy@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19647

Owen Leonard <oleonard at myacpl.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Blocks|                            |19710


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19710
[Bug 19710] Move plugins templates to the footer
-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Nov 28 20:16:12 2017
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 28 Nov 2017 19:16:12 +0000
Subject: [Koha-bugs] [Bug 19710] Move plugins templates javascript to the
	footer
In-Reply-To: <bug-19710-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-19710-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-19710-70-QETxMPnKlE@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19710

Owen Leonard <oleonard at myacpl.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
            Summary|Move plugins templates to   |Move plugins templates
                   |the footer                  |javascript to the footer

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Nov 28 20:17:07 2017
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 28 Nov 2017 19:17:07 +0000
Subject: [Koha-bugs] [Bug 19710] Move plugins templates javascript to the
	footer
In-Reply-To: <bug-19710-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-19710-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-19710-70-0RdV56yukV@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19710

Owen Leonard <oleonard at myacpl.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
   Patch complexity|---                         |Small patch
             Status|ASSIGNED                    |Needs Signoff

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Nov 28 20:17:09 2017
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 28 Nov 2017 19:17:09 +0000
Subject: [Koha-bugs] [Bug 19710] Move plugins templates javascript to the
	footer
In-Reply-To: <bug-19710-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-19710-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-19710-70-JlyOMC7lOK@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19710

--- Comment #1 from Owen Leonard <oleonard at myacpl.org> ---
Created attachment 69419
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=69419&action=edit
Bug 19710: Move plugins templates javascript to the footer

This patch modifies the staff client plugins template so that
JavaScript is included in the footer instead of the header.

To test, apply the patch and test the JavaScript-driven features of
the modified template:

- The plugins link should be bold in the sidebar menu.
- Choosing "Uninstall" for an installed plugin should trigger a
  confirmation alert.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Nov 28 21:10:26 2017
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 28 Nov 2017 20:10:26 +0000
Subject: [Koha-bugs] [Bug 19711] New: Too large a fine causes internal
 server error when viewing patron
Message-ID: <bug-19711-70@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19711

            Bug ID: 19711
           Summary: Too large a fine causes internal server error when
                    viewing patron
 Change sponsored?: ---
           Product: Koha
           Version: master
          Hardware: All
                OS: All
            Status: NEW
          Severity: normal
          Priority: P5 - low
         Component: Fines and fees
          Assignee: koha-bugs at lists.koha-community.org
          Reporter: nick at bywatersolutions.com
        QA Contact: testopia at bugs.koha-community.org

To recreate:
1 - Add a manual fine of 100000000000000 to a patron
2 - Get internal error for patron
3 - Try searching for patron with search that would return several borrowers,
table is broken

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Nov 28 21:10:36 2017
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 28 Nov 2017 20:10:36 +0000
Subject: [Koha-bugs] [Bug 19646] value_builder marc21_linking_section
	template is broken
In-Reply-To: <bug-19646-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-19646-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-19646-70-KE28OVsM0E@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19646

Jonathan Druart <jonathan.druart at bugs.koha-community.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |jonathan.druart at bugs.koha-c
                   |                            |ommunity.org

--- Comment #6 from Jonathan Druart <jonathan.druart at bugs.koha-community.org> ---
Erk, I missed this one!

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Nov 28 21:10:54 2017
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 28 Nov 2017 20:10:54 +0000
Subject: [Koha-bugs] [Bug 19711] Too large a fine causes internal server
 error when viewing patron
In-Reply-To: <bug-19711-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-19711-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-19711-70-k6m9vbqoxR@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19711

Nick Clemens <nick at bywatersolutions.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |kyle at bywatersolutions.com

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Nov 28 21:25:27 2017
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 28 Nov 2017 20:25:27 +0000
Subject: [Koha-bugs] [Bug 11210] Allow partial writeoff
In-Reply-To: <bug-11210-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-11210-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-11210-70-5uk7jObaol@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11210

Kyle M Hall <kyle at bywatersolutions.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #69090|0                           |1
        is obsolete|                            |

--- Comment #10 from Kyle M Hall <kyle at bywatersolutions.com> ---
Created attachment 69420
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=69420&action=edit
Bug 11210 - Writeoff partial amounts

Minor changes to pay.pl and paycollect.tt to allow writing off a partial amount
of a fine.

Test plan:
0) Go to the Fines tab of a test patron's profile
1) Create a fine if there are none (under the Manual invoice tab)
2) Go to the "Pay fines" tab
3) Press the write off button on the corresponding account line

Without patch, you'll be asked to confirm, but will not be able to edit the
amount
With patch, you'll be able to edit the amount.

Followed test plan, patch worked as described. Also ran QA test tool and
modified files passed

Signed-off-by: Simon Pouchol <simon.pouchol at biblibre.com>

Signed-off-by: Kyle M Hall <kyle at bywatersolutions.com>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Nov 28 21:25:24 2017
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 28 Nov 2017 20:25:24 +0000
Subject: [Koha-bugs] [Bug 11210] Allow partial writeoff
In-Reply-To: <bug-11210-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-11210-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-11210-70-clm1DZiCfM@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11210

Kyle M Hall <kyle at bywatersolutions.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Signed Off                  |Passed QA

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Nov 28 21:35:51 2017
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 28 Nov 2017 20:35:51 +0000
Subject: [Koha-bugs] [Bug 19532] Recalls for Koha
In-Reply-To: <bug-19532-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-19532-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-19532-70-iFyUeHEylW@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19532

Chris Cormack <chris at bigballofwax.co.nz> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |chris at bigballofwax.co.nz

--- Comment #31 from Chris Cormack <chris at bigballofwax.co.nz> ---
(In reply to Jonathan Druart from comment #30)
> (In reply to Petter Goks?yr ?sen from comment #29)
> > Quick comment:
> > Given the troubles we have with duplicate primary keys in old/deleted
> > tables, would't it be better to drop the old_recalls table, and keep it in
> > one table, with a flag denoting if the recall is deleted or not?
> 
> Yes, see comment 5 as well.
> Aleisha, did you consider this alternative?

We did, but the reason old_issues exists, is because keeping it one massive
table becomes really slow quite fast.

With recalls this probably will take longer to be a problem, but having
circulation stuff slowed down (specifically returns) by having millions of rows
to check through was the reason the issues table was split in the first place.
I don't believe one table that grows forever for circulation is a viable fix.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Nov 28 22:27:07 2017
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 28 Nov 2017 21:27:07 +0000
Subject: [Koha-bugs] [Bug 19690] Smart rules: Term "If any unavailable" is
	confusing
In-Reply-To: <bug-19690-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-19690-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-19690-70-d8qM3OywGq@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19690

--- Comment #4 from Katrin Fischer <katrin.fischer at bsz-bw.de> ---
Sorry, you lost me :(

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.

From bugzilla-daemon at bugs.koha-community.org  Wed Nov 29 00:55:16 2017
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 28 Nov 2017 23:55:16 +0000
Subject: [Koha-bugs] [Bug 19583] Report updater triggers on
	auth_header.marcxml
In-Reply-To: <bug-19583-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-19583-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-19583-70-kKGmrsYc6E@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19583

Barton Chittenden <barton at bywatersolutions.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
           Severity|enhancement                 |minor

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Nov 29 07:14:04 2017
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 29 Nov 2017 06:14:04 +0000
Subject: [Koha-bugs] [Bug 19532] Recalls for Koha
In-Reply-To: <bug-19532-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-19532-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-19532-70-svCmjE1iM9@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19532

--- Comment #32 from Petter Goks?yr ?sen <boutrosboutrosboutros at gmail.com> ---
Fair enough, but optimizing by allowing for potential data corruption seems the
wrong way to optimize to me :)

Isn't data integrity is more important?

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Nov 29 07:18:24 2017
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 29 Nov 2017 06:18:24 +0000
Subject: [Koha-bugs] [Bug 19532] Recalls for Koha
In-Reply-To: <bug-19532-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-19532-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-19532-70-QIQ3Ud3INN@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19532

--- Comment #33 from Chris Cormack <chris at bigballofwax.co.nz> ---
(In reply to Petter Goks?yr ?sen from comment #32)
> Fair enough, but optimizing by allowing for potential data corruption seems
> the wrong way to optimize to me :)
> 
> Isn't data integrity is more important?

It was fine for 15 years, until mysql changed things. And after that we didn't
have any data loss until we rushed a fix.
A combined table is not a valid fix, you can have all the data integrity you
want if the system is too slow to use. We should come up with an actual
solution.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Nov 29 07:23:39 2017
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 29 Nov 2017 06:23:39 +0000
Subject: [Koha-bugs] [Bug 19532] Recalls for Koha
In-Reply-To: <bug-19532-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-19532-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-19532-70-0XktiFzwle@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19532

--- Comment #34 from Petter Goks?yr ?sen <boutrosboutrosboutros at gmail.com> ---
Yeah, this probably needs a broader discussion, best handeled elsewhere. I'll
leave it for now and let this bug be about recalls :)

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Nov 29 12:33:33 2017
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 29 Nov 2017 11:33:33 +0000
Subject: [Koha-bugs] [Bug 16284] Borrower Previously Checked Out: Serials
In-Reply-To: <bug-16284-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-16284-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-16284-70-EGNY7YoVE4@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16284

Victor Grousset/tuxayo <victor.grousset at biblibre.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |victor.grousset at biblibre.co
                   |                            |m

--- Comment #2 from Victor Grousset/tuxayo <victor.grousset at biblibre.com> ---
Just some info about the context:

?In discussion of Bug 6909, Radek ?iman raised the following additional
concerns around CheckPreviousCheckouts functionality?

It was actually in bug 6906
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6906#c27

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.

From bugzilla-daemon at bugs.koha-community.org  Wed Nov 29 13:10:59 2017
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 29 Nov 2017 12:10:59 +0000
Subject: [Koha-bugs] [Bug 19690] Smart rules: Term "If any unavailable" is
	confusing
In-Reply-To: <bug-19690-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-19690-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-19690-70-ErvHZ1pUBB@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19690

--- Comment #5 from Marcel de Rooy <m.de.rooy at rijksmuseum.nl> ---
(In reply to Katrin Fischer from comment #4)
> Sorry, you lost me :(

Well, this confirms that the term confusing is quite correct! :)

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Nov 29 13:13:13 2017
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 29 Nov 2017 12:13:13 +0000
Subject: [Koha-bugs] [Bug 19646] value_builder marc21_linking_section
	template is broken
In-Reply-To: <bug-19646-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-19646-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-19646-70-RlT4Chf4wv@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19646

--- Comment #7 from Marcel de Rooy <m.de.rooy at rijksmuseum.nl> ---
(In reply to Jonathan Druart from comment #6)
> Erk, I missed this one!

You missed much more. Too bad.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Nov 29 13:53:33 2017
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 29 Nov 2017 12:53:33 +0000
Subject: [Koha-bugs] [Bug 17721] Do we need utf8_bin collation on
	tagsubfield?
In-Reply-To: <bug-17721-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-17721-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-17721-70-YVhrzoufTe@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17721

--- Comment #5 from Nicolas Legrand <nicolas.legrand at bulac.fr> ---
I don't see any such limitation in UNIMARC standard. Unfortunately, I don't
have a ISO 2709 version right now so I can't check there too.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Nov 29 14:44:06 2017
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 29 Nov 2017 13:44:06 +0000
Subject: [Koha-bugs] [Bug 19411] opac-shelves.tt : the opaccredits block
 should be outside of the main <div>
In-Reply-To: <bug-19411-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-19411-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-19411-70-rQe9NMq7fj@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19411

--- Comment #2 from Owen Leonard <oleonard at myacpl.org> ---
I don't see a different between opac-shelves.tt, opac-advsearch.tt, and
opac-main.tt in the placement of opaccredits. Could you double-check? Do you
have any custom HTML (opacheader, opacmain, etc.) which might be causing the
HTML to be off?

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Nov 29 14:45:48 2017
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 29 Nov 2017 13:45:48 +0000
Subject: [Koha-bugs] [Bug 19710] Move plugins templates javascript to the
	footer
In-Reply-To: <bug-19710-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-19710-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-19710-70-hF88ozZqbQ@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19710

Claire Gravely <claire_gravely at hotmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Needs Signoff               |Signed Off

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Nov 29 14:45:51 2017
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 29 Nov 2017 13:45:51 +0000
Subject: [Koha-bugs] [Bug 19710] Move plugins templates javascript to the
	footer
In-Reply-To: <bug-19710-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-19710-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-19710-70-PkQATgcENH@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19710

Claire Gravely <claire_gravely at hotmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #69419|0                           |1
        is obsolete|                            |

--- Comment #2 from Claire Gravely <claire_gravely at hotmail.com> ---
Created attachment 69421
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=69421&action=edit
Bug 19710: Move plugins templates javascript to the footer

This patch modifies the staff client plugins template so that
JavaScript is included in the footer instead of the header.

To test, apply the patch and test the JavaScript-driven features of
the modified template:

- The plugins link should be bold in the sidebar menu.
- Choosing "Uninstall" for an installed plugin should trigger a
  confirmation alert.

Signed-off-by: Claire Gravely <claire.gravely at bsz-bw.de>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Nov 29 14:55:25 2017
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 29 Nov 2017 13:55:25 +0000
Subject: [Koha-bugs] [Bug 19712] New: Fix command line options of
 delete_records_via_leader.pl
Message-ID: <bug-19712-70@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19712

            Bug ID: 19712
           Summary: Fix command line options of
                    delete_records_via_leader.pl
 Change sponsored?: ---
           Product: Koha
           Version: master
          Hardware: All
                OS: All
            Status: NEW
          Severity: normal
          Priority: P5 - low
         Component: Command-line Utilities
          Assignee: koha-bugs at lists.koha-community.org
          Reporter: magnus at libriotech.no
        QA Contact: testopia at bugs.koha-community.org
                CC: robin at catalyst.net.nz

1. This code:

  56  if ( $help || !$confirm ) {
  57 
...
  70     exit();
  71 }

means that unless you specify --confirm you will never be able to run the
script - it will just print the usage and exit. That means --test is useless. 

2. The script has both of these options:

     -c --confirm: Script will do nothing without this parameter
     -t --test: Test mode, does not delete records.

What happens if you specify both? Or none? I think test mode should be the
default (when no options are specified) and changes to the database should only
be done when --confirm is specified. This would be consistent with other
scripts, I think.

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Nov 29 15:10:34 2017
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 29 Nov 2017 14:10:34 +0000
Subject: [Koha-bugs] [Bug 12513] PROG/CCSR deprecation: Remove
 OpacShowLibrariesPulldownMobile system preference
In-Reply-To: <bug-12513-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-12513-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-12513-70-nNVWojagoi@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12513

Jonathan Druart <jonathan.druart at bugs.koha-community.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Blocks|                            |19713


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19713
[Bug 19713] 2 occurrences of OpacShowLibrariesPulldownMobile have not been
removed
-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Nov 29 15:10:34 2017
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 29 Nov 2017 14:10:34 +0000
Subject: [Koha-bugs] [Bug 19713] New: 2 occurrences of
 OpacShowLibrariesPulldownMobile have not been removed
Message-ID: <bug-19713-70@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19713

            Bug ID: 19713
           Summary: 2 occurrences of OpacShowLibrariesPulldownMobile have
                    not been removed
 Change sponsored?: ---
           Product: Koha
           Version: unspecified
          Hardware: All
                OS: All
            Status: NEW
          Severity: trivial
          Priority: P5 - low
         Component: Architecture, internals, and plumbing
          Assignee: koha-bugs at lists.koha-community.org
          Reporter: jonathan.druart at bugs.koha-community.org
        QA Contact: testopia at bugs.koha-community.org
        Depends on: 12513

t/db_dependent/UsageStats.t:        OpacShowLibrariesPulldownMobile
C4/UsageStats.pm:        OpacShowLibrariesPulldownMobile


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12513
[Bug 12513] PROG/CCSR deprecation: Remove OpacShowLibrariesPulldownMobile
system preference
-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Nov 29 15:12:48 2017
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 29 Nov 2017 14:12:48 +0000
Subject: [Koha-bugs] [Bug 19714] New: 2 occurrences of memberofinstitution
 have not been removed
Message-ID: <bug-19714-70@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19714

            Bug ID: 19714
           Summary: 2 occurrences of memberofinstitution have not been
                    removed
 Change sponsored?: ---
           Product: Koha
           Version: unspecified
          Hardware: All
                OS: All
            Status: NEW
          Severity: trivial
          Priority: P5 - low
         Component: Architecture, internals, and plumbing
          Assignee: koha-bugs at lists.koha-community.org
          Reporter: jonathan.druart at bugs.koha-community.org
        QA Contact: testopia at bugs.koha-community.org
        Depends on: 11751

C4/UsageStats.pm:        memberofinstitution
t/db_dependent/UsageStats.t:        memberofinstitution


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11751
[Bug 11751] Some code related to "institution" is unused and obsolete
-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.

From bugzilla-daemon at bugs.koha-community.org  Wed Nov 29 15:12:48 2017
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 29 Nov 2017 14:12:48 +0000
Subject: [Koha-bugs] [Bug 11751] Some code related to "institution" is
 unused and obsolete
In-Reply-To: <bug-11751-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-11751-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-11751-70-OnXDtGnGum@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11751

Jonathan Druart <jonathan.druart at bugs.koha-community.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Blocks|                            |19714


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19714
[Bug 19714] 2 occurrences of memberofinstitution have not been removed
-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Nov 29 15:14:56 2017
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 29 Nov 2017 14:14:56 +0000
Subject: [Koha-bugs] [Bug 19411] opac-shelves.tt : the opaccredits block
 should be outside of the main <div>
In-Reply-To: <bug-19411-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-19411-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-19411-70-9qsRZoX5tl@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19411

--- Comment #3 from David Bourgault <david.bourgault at inlibro.com> ---
Created attachment 69422
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=69422&action=edit
opac-shelves.tt in Chrome element inspector

It might have been my database causing the issue in opac-advsearch.tt, but
after clearing all html/css/js from my database, on master branch I could still
reproduce the issue for opac-shelves.tt

As you can see in the file attached, the comment for closing main is two levels
deeper than it should.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Nov 29 17:13:12 2017
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 29 Nov 2017 16:13:12 +0000
Subject: [Koha-bugs] [Bug 19014] Patrons should not get a on_reserve
 notification if the checkout is due in the future
In-Reply-To: <bug-19014-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-19014-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-19014-70-pRehZS1OFe@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19014

Jonathan Druart <jonathan.druart at bugs.koha-community.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Failed QA                   |Needs Signoff

--- Comment #6 from Jonathan Druart <jonathan.druart at bugs.koha-community.org> ---
(In reply to Caroline Cyr La Rose from comment #5)
> Hi Jonathan,
> 
> I'm having trouble testing this. Which cron job are we supposed to run? Is
> it automatic_renewals.pl --send-notices?

Yes

> Furthermore, I had an item due in the future (in december) and I still
> received a notice saying the auto renewal failed because I had fines (which
> was true). But why would it try to renew something due in december?

You need to tune that using the 'No automatic renewal before/after' settings.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Nov 29 18:00:52 2017
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 29 Nov 2017 17:00:52 +0000
Subject: [Koha-bugs] [Bug 15381] Move the authority types related code to
 Koha::Authority::Type [s] - part 2
In-Reply-To: <bug-15381-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-15381-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-15381-70-lOL45yZqai@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15381

Jonathan Druart <jonathan.druart at bugs.koha-community.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Blocks|                            |19683


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19683
[Bug 19683] Export.pl does not populate the Authority Types dropdown correctly
-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Nov 29 18:00:52 2017
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 29 Nov 2017 17:00:52 +0000
Subject: [Koha-bugs] [Bug 19683] Export.pl does not populate the Authority
 Types dropdown correctly
In-Reply-To: <bug-19683-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-19683-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-19683-70-Kn5LkIe8Tc@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19683

Jonathan Druart <jonathan.druart at bugs.koha-community.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |jonathan.druart at bugs.koha-c
                   |                            |ommunity.org
         Depends on|                            |15381

--- Comment #4 from Jonathan Druart <jonathan.druart at bugs.koha-community.org> ---
Caused by commit 7283069a9d3b2ffb2edc31022d96bb4aea107098
Bug 15381: Remove getauthtypes and getauthtype


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15381
[Bug 15381] Move the authority types related code to Koha::Authority::Type[s] -
part 2
-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Nov 29 18:10:09 2017
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 29 Nov 2017 17:10:09 +0000
Subject: [Koha-bugs] [Bug 19646] value_builder marc21_linking_section
	template is broken
In-Reply-To: <bug-19646-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-19646-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-19646-70-ONah8Y8dry@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19646

Jonathan Druart <jonathan.druart at bugs.koha-community.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
           Severity|normal                      |major
         Depends on|                            |14828

--- Comment #8 from Jonathan Druart <jonathan.druart at bugs.koha-community.org> ---
Caused by commit aafe73eefb5151454fa8957bf188768324d23955
Bug 14828: Use Koha::ItemType[s] everywhere C4::ItemType was used


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14828
[Bug 14828] Move the item types related code to Koha::ItemTypes
-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Nov 29 18:10:09 2017
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 29 Nov 2017 17:10:09 +0000
Subject: [Koha-bugs] [Bug 14828] Move the item types related code to
	Koha::ItemTypes
In-Reply-To: <bug-14828-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-14828-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-14828-70-wBwRwo0rP9@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14828

Jonathan Druart <jonathan.druart at bugs.koha-community.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Blocks|                            |19646


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19646
[Bug 19646] value_builder marc21_linking_section template is broken
-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Nov 29 18:21:58 2017
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 29 Nov 2017 17:21:58 +0000
Subject: [Koha-bugs] [Bug 18856] Cancel Waiting Hold in OPAC does not give
	useful message
In-Reply-To: <bug-18856-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-18856-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-18856-70-Ix40V8mc3p@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18856

Jonathan Druart <jonathan.druart at bugs.koha-community.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Passed QA                   |In Discussion
                 CC|                            |jonathan.druart at bugs.koha-c
                   |                            |ommunity.org

--- Comment #8 from Jonathan Druart <jonathan.druart at bugs.koha-community.org> ---
What about the other occurrence of is_cancelable in the same template file?

 695 [% IF ( RESERVE.is_cancelable ) %]

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Nov 29 18:48:46 2017
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 29 Nov 2017 17:48:46 +0000
Subject: [Koha-bugs] [Bug 19560] Unable to delete library when branchcode
 contains special characters
In-Reply-To: <bug-19560-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-19560-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-19560-70-R6N9wprBkG@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19560

Jonathan Druart <jonathan.druart at bugs.koha-community.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |jonathan.druart at bugs.koha-c
                   |                            |ommunity.org
             Status|Passed QA                   |In Discussion

--- Comment #7 from Jonathan Druart <jonathan.druart at bugs.koha-community.org> ---
This patch does 2 things:
1. Only accept few chars for branchcode (accentuated chars are rejected)
2. Fix the deletion problem if a branchcode contains special characters

It may be a problem for non latin alphabets to restrict as possiblities. Do we
have known problems with branchcode containing special chars?

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Nov 29 18:56:02 2017
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 29 Nov 2017 17:56:02 +0000
Subject: [Koha-bugs] [Bug 19532] Recalls for Koha
In-Reply-To: <bug-19532-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-19532-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-19532-70-py3lwqtk7h@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19532

--- Comment #35 from Tom?s Cohen Arazi <tomascohen at gmail.com> ---
Comment on attachment 68572
  --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=68572
Bug 19532: Module files for Recall and OldRecall

>Koha/Recall.pm
>Koha/Recalls.pm
>Koha/Old/Recall.pm
>Koha/Old/Recalls.pm
>and the schema files for Recall and OldRecall.

I agree we should avoid old_*, probably index definitions are relevant for
performance (speed, because they will eat more hard disk space of course).

>+=head2 Class Methods

This are usually labeled 'Internal methods', to distinguish them from public
'Class methods'. Fix the case.

>+=head3 type
>+
>+=cut
>+
>+sub type {
>+    return 'OldRecall';
>+}

This should be called '_type'. Look at Koha/Object.pm:260, a sample place it is
used. If it is not well documented, please file a bug for it!

>+=head2 found
>+
>+  data_type: 'varchar'
>+  is_nullable: 1
>+  size: 1

Please use tinyint(1) for booleans. While it is not a real type (it is an
integer with a mask), it clearly denotes its use. If you plan to expose this
through the api, having it be VARCHAR will make our stack consider it a string.
If you set it a numeric type, then we can add:

__PACKAGE_->add_columns({

  '+found' => { is_boolean => 1 }

});

to the schema file, and thus it is considered a Boolean when rendering on the
API.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Nov 29 19:00:16 2017
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 29 Nov 2017 18:00:16 +0000
Subject: [Koha-bugs] [Bug 19532] Recalls for Koha
In-Reply-To: <bug-19532-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-19532-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-19532-70-DUoQ99QPUj@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19532

--- Comment #36 from Tom?s Cohen Arazi <tomascohen at gmail.com> ---
Comment on attachment 69102
  --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=69102
Bug 19532: Cancel recall and see recalls in OPAC


>+=head3 branch
>+
>+Returns the related Koha::Library object for this Hold
>+
>+=cut
>+
>+sub branch {
>+    my ($self) = @_;
>+
>+    $self->{_branch} ||= Koha::Libraries->find( $self->branchcode() );
>+
>+    return $self->{_branch};
>+}

Please call this method 'library' instead, and 'patron' instead of 'borrower'
on the followup.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Nov 29 19:05:57 2017
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 29 Nov 2017 18:05:57 +0000
Subject: [Koha-bugs] [Bug 19560] Unable to delete library when branchcode
 contains special characters
In-Reply-To: <bug-19560-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-19560-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-19560-70-VyHtPr69V1@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19560

--- Comment #8 from Joy Nelson <joy at bywatersolutions.com> ---
Jonathon,
I encountered this because a library was adding a branch for "Art &
Architecture" as A&A
When they decided to go with a different naming convention, they were unable to
delete the branch.

joy


(In reply to Jonathan Druart from comment #7)
> This patch does 2 things:
> 1. Only accept few chars for branchcode (accentuated chars are rejected)
> 2. Fix the deletion problem if a branchcode contains special characters
> 
> It may be a problem for non latin alphabets to restrict as possiblities. Do
> we have known problems with branchcode containing special chars?

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Nov 29 19:25:05 2017
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 29 Nov 2017 18:25:05 +0000
Subject: [Koha-bugs] [Bug 19560] Unable to delete library when branchcode
 contains special characters
In-Reply-To: <bug-19560-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-19560-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-19560-70-fQBDjj7Uiu@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19560

--- Comment #9 from Jonathan Druart <jonathan.druart at bugs.koha-community.org> ---
Created attachment 69423
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=69423&action=edit
Bug 19560: Correctly escape branchcode in admin/branches.pl

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Nov 29 19:26:51 2017
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 29 Nov 2017 18:26:51 +0000
Subject: [Koha-bugs] [Bug 19560] Unable to delete library when branchcode
 contains special characters
In-Reply-To: <bug-19560-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-19560-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-19560-70-WDmhYjgBGu@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19560

--- Comment #10 from Jonathan Druart <jonathan.druart at bugs.koha-community.org> ---
Joy, What I tried to say is: If we escape correctly the variable, we will not
have problem to delete a library with branchcode=A&A, see the follow-up.
I am so wondering if it is really useful to restrict the code to a-Z0-9_-

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Nov 29 19:33:16 2017
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 29 Nov 2017 18:33:16 +0000
Subject: [Koha-bugs] [Bug 19560] Unable to delete library when branchcode
 contains special characters
In-Reply-To: <bug-19560-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-19560-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-19560-70-ZB3zH2t4ZP@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19560

--- Comment #11 from Joy Nelson <joy at bywatersolutions.com> ---
Ah!  I see.  Yes, escaping or restricting would work.  I can't say I have a
preference in the matter.  

Thanks!
joy

(In reply to Jonathan Druart from comment #10)
> Joy, What I tried to say is: If we escape correctly the variable, we will
> not have problem to delete a library with branchcode=A&A, see the follow-up.
> I am so wondering if it is really useful to restrict the code to a-Z0-9_-

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Nov 29 20:42:36 2017
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 29 Nov 2017 19:42:36 +0000
Subject: [Koha-bugs] [Bug 7317] Add an Interlibrary Loan Module to
	Circulation and OPAC
In-Reply-To: <bug-7317-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-7317-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-7317-70-aibEI7Ubvd@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7317

J Schmidt <jschmidt at switchinc.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |jschmidt at switchinc.org

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Nov 29 20:43:08 2017
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 29 Nov 2017 19:43:08 +0000
Subject: [Koha-bugs] [Bug 2093] Add OPAC dashboard for logged-in users
In-Reply-To: <bug-2093-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-2093-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-2093-70-8rmoIUWwf7@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=2093

J Schmidt <jschmidt at switchinc.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |jschmidt at switchinc.org

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Nov 29 21:13:57 2017
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 29 Nov 2017 20:13:57 +0000
Subject: [Koha-bugs] =?utf-8?q?=5BBug_19715=5D_New=3A_Add_the_amount_of_co?=
 =?utf-8?q?ntract=27s_on_the_vendor=27_s_d=C3=A9tails_page=2E?=
Message-ID: <bug-19715-70@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19715

            Bug ID: 19715
           Summary: Add the amount of contract's on the vendor's d?tails
                    page.
 Change sponsored?: ---
           Product: Koha
           Version: unspecified
          Hardware: All
                OS: All
            Status: NEW
          Severity: enhancement
          Priority: P5 - low
         Component: Acquisitions
          Assignee: koha-bugs at lists.koha-community.org
          Reporter: patrick.robitaille at collecto.ca
        QA Contact: testopia at bugs.koha-community.org

Hi, 

In a vendor's page details, we can regist informations about contracts. We can
already add some informations like the contact details and ordering
informations but It would be nice to have the possibility to regist more
contract's informations. We could add somne champs fot the amount of the
contract. Afther that we could use this information as a limit not to exceed
when we make orders with this vendor. 

Patrick

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.

From bugzilla-daemon at bugs.koha-community.org  Wed Nov 29 21:16:04 2017
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 29 Nov 2017 20:16:04 +0000
Subject: [Koha-bugs] =?utf-8?q?=5BBug_19715=5D_Add_the_amount_of_contract?=
 =?utf-8?q?=27s_in_the_vendor=27_s_d=C3=A9tails_page=2E?=
In-Reply-To: <bug-19715-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-19715-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-19715-70-6bm486UUWS@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19715

Patrick Robitaille <patrick.robitaille at collecto.ca> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
            Summary|Add the amount of           |Add the amount of
                   |contract's on the vendor's  |contract's in the vendor's
                   |d?tails page.               |d?tails page.

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.

From bugzilla-daemon at bugs.koha-community.org  Wed Nov 29 21:16:37 2017
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 29 Nov 2017 20:16:37 +0000
Subject: [Koha-bugs] [Bug 19318] Add ability to use custom file upload paths
In-Reply-To: <bug-19318-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-19318-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-19318-70-SdEKlM8hjS@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19318

Marjorie Barry-Vila <marjorie.barry-vila at collecto.ca> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |marjorie.barry-vila at collect
                   |                            |o.ca

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Nov 29 21:20:06 2017
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 29 Nov 2017 20:20:06 +0000
Subject: [Koha-bugs] [Bug 19716] New: Add option to send header line for CSV
	output
Message-ID: <bug-19716-70@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19716

            Bug ID: 19716
           Summary: Add option to send header line for CSV output
 Change sponsored?: ---
           Product: Koha
           Version: master
          Hardware: All
                OS: All
            Status: NEW
          Severity: enhancement
          Priority: P5 - low
         Component: Reports
          Assignee: koha-bugs at lists.koha-community.org
          Reporter: kyle at bywatersolutions.com
        QA Contact: testopia at bugs.koha-community.org

Currently, if outputting a CSV file using runreport.pl, you need to look at the
report used to know what each column means. It would be nice if we could
include column headers.

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Nov 29 21:21:51 2017
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 29 Nov 2017 20:21:51 +0000
Subject: [Koha-bugs] [Bug 19716] Add option to send header line for CSV
	output
In-Reply-To: <bug-19716-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-19716-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-19716-70-ExSpOk7pzO@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19716

Kyle M Hall <kyle at bywatersolutions.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|NEW                         |Needs Signoff

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.

From bugzilla-daemon at bugs.koha-community.org  Wed Nov 29 21:21:54 2017
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 29 Nov 2017 20:21:54 +0000
Subject: [Koha-bugs] [Bug 19716] Add option to send header line for CSV
	output
In-Reply-To: <bug-19716-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-19716-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-19716-70-7Jo4S2UcUI@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19716

--- Comment #1 from Kyle M Hall <kyle at bywatersolutions.com> ---
Created attachment 69424
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=69424&action=edit
Bug 19716 - Add option to send header line for CSV output

Currently, if outputting a CSV file using runreport.pl, you need to look at the
report used to know what each column means. It would be nice if we could
include column headers.

Test Plan:
1) Apply this patch
2) Try using runreport.pl with --format csv --csv-header

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.

From bugzilla-daemon at bugs.koha-community.org  Wed Nov 29 21:26:34 2017
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 29 Nov 2017 20:26:34 +0000
Subject: [Koha-bugs] [Bug 18081] [omnibus] GDPR (General Data Protection
	Regulation)
In-Reply-To: <bug-18081-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-18081-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-18081-70-Pu7Eb5E78a@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18081

Mike <black23 at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |jonathan.druart at bugs.koha-c
                   |                            |ommunity.org,
                   |                            |paul.poulain at biblibre.com
             Status|NEW                         |In Discussion
            Summary|New EU General Data         |[omnibus] GDPR (General
                   |Protection Regulation 2018  |Data Protection Regulation)

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Nov 29 23:04:11 2017
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 29 Nov 2017 22:04:11 +0000
Subject: [Koha-bugs] [Bug 19717] New: Dependency on deprecated Swagger2
 whose installation fails
Message-ID: <bug-19717-70@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19717

            Bug ID: 19717
           Summary: Dependency on deprecated Swagger2 whose installation
                    fails
 Change sponsored?: ---
           Product: Koha
           Version: 17.05
          Hardware: All
                OS: All
            Status: NEW
          Severity: enhancement
          Priority: P5 - low
         Component: Packaging
          Assignee: koha-bugs at lists.koha-community.org
          Reporter: federicoleva at tiscali.it
        QA Contact: testopia at bugs.koha-community.org
                CC: mirko at abunchofthings.net

Created attachment 69425
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=69425&action=edit
Assorted failures

I'm installing koha 17.05 on fedora 25 and the web installer complains I didn't
install Swagger2. CPAN logs are very keen on informing me repeatedly that
"Mojolicious::Plugin::Swagger2 is deprecated in favor of 
Mojolicious::Plugin::OpenAPI".

If I do "cpanm experimental Test::Mojo", then "cpanm
Mojolicious::Plugin::Swagger2" fails with just one test failure, so I'm forced
to use the -n option to disable the tests.

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Nov 29 23:18:40 2017
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 29 Nov 2017 22:18:40 +0000
Subject: [Koha-bugs] [Bug 19718] New: Create message for patrons with
 multiple holds on the same item
Message-ID: <bug-19718-70@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19718

            Bug ID: 19718
           Summary: Create message for patrons with multiple holds on the
                    same item
 Change sponsored?: ---
           Product: Koha
           Version: 17.05
          Hardware: All
                OS: All
            Status: NEW
          Severity: enhancement
          Priority: P5 - low
         Component: Hold requests
          Assignee: koha-bugs at lists.koha-community.org
          Reporter: karen at bywatersolutions.com
        QA Contact: testopia at bugs.koha-community.org
                CC: gmcharlt at gmail.com

One of our partners allows 3 holds per record. They have noticed that patrons
will place multiple holds on an item that they have already placed on hold. 

They would like for Koha to display a message to the patron when they place a
hold on an item they already have on hold. Their suggested message is "You
already have placed a hold on this record. Are you sure you want to place
another?"

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.

From bugzilla-daemon at bugs.koha-community.org  Thu Nov 30 03:00:15 2017
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 30 Nov 2017 02:00:15 +0000
Subject: [Koha-bugs] [Bug 18308] Default value of minPasswordLength should
	be increased
In-Reply-To: <bug-18308-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-18308-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-18308-70-rhelMgol7t@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18308

--- Comment #19 from Alex Buckley <alexbuckley at catalyst.net.nz> ---
Hi Dominic 

thanks for testing the patch, can you please try again and apply bug 19514
first.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Nov 30 03:00:55 2017
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 30 Nov 2017 02:00:55 +0000
Subject: [Koha-bugs] [Bug 18889] Item number in biblio description in fine
	page
In-Reply-To: <bug-18889-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-18889-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-18889-70-u1MLAN7JVK@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18889

Alex Buckley <alexbuckley at catalyst.net.nz> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
           Assignee|amitddng135 at gmail.com       |alexbuckley at catalyst.net.nz

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Nov 30 04:08:44 2017
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 30 Nov 2017 03:08:44 +0000
Subject: [Koha-bugs] [Bug 19532] Recalls for Koha
In-Reply-To: <bug-19532-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-19532-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-19532-70-tLqRVfIbQL@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19532

--- Comment #37 from Liz Rea <liz at catalyst.net.nz> ---
These are functionality notes for Aleisha

OPAC client view:

We probably want to show the borrower when the book is now expected to be
returned by on /cgi-bin/koha/opac-recalls.pl

Staff views:

- syspref needs to be defaulted to off please :)

/cgi-bin/koha/circ/recalls_queue.pl
- probably want to see the new due date here as well

/cgi-bin/koha/catalogue/detail.pl?biblionumber=16
- do we want to see what the old due date was here? (to think about, not
required)
- Probably want to show somewhere in the item table that there is a recall, and
for whom (kinda like we do with holds)
- do we want a tab on the detail page that shows all of the recalls for this
biblio, and who they are for?

General questions: 

- If we add an item with the same item type to a biblio that has a recall,
should checking in this newly available item trigger the recall to be filled?

I'm out of time for this run at it, but honestly what a great first whack at
it.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Nov 30 08:29:49 2017
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 30 Nov 2017 07:29:49 +0000
Subject: [Koha-bugs] [Bug 19709] Move template JavaScript to the footer:
	Labels
In-Reply-To: <bug-19709-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-19709-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-19709-70-RnWdgiBJTx@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19709

Katrin Fischer <katrin.fischer at bsz-bw.de> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |katrin.fischer at bsz-bw.de
           Keywords|                            |Academy

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Nov 30 08:30:12 2017
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 30 Nov 2017 07:30:12 +0000
Subject: [Koha-bugs] [Bug 19708] Printing code improvements in opac-basket.tt
In-Reply-To: <bug-19708-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-19708-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-19708-70-HtbBl3xXl0@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19708

Katrin Fischer <katrin.fischer at bsz-bw.de> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
           Keywords|                            |Academy
                 CC|                            |katrin.fischer at bsz-bw.de

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Nov 30 08:30:41 2017
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 30 Nov 2017 07:30:41 +0000
Subject: [Koha-bugs] [Bug 19684] Colon char in MARC data breaks facets
In-Reply-To: <bug-19684-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-19684-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-19684-70-iCIVVtnCnl@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19684

Katrin Fischer <katrin.fischer at bsz-bw.de> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |katrin.fischer at bsz-bw.de
           Keywords|                            |Academy

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Nov 30 09:39:09 2017
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 30 Nov 2017 08:39:09 +0000
Subject: [Koha-bugs] [Bug 19717] Dependency on deprecated Swagger2 whose
 installation fails
In-Reply-To: <bug-19717-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-19717-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-19717-70-An2qJ1ibJT@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19717

Zeno Tajoli <z.tajoli at cineca.it> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |z.tajoli at cineca.it

--- Comment #1 from Zeno Tajoli <z.tajoli at cineca.it> ---
I suggest you to use 17.11, where we drop Swagger2 and we use OpenAPI

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.

From bugzilla-daemon at bugs.koha-community.org  Thu Nov 30 09:39:29 2017
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 30 Nov 2017 08:39:29 +0000
Subject: [Koha-bugs] [Bug 19717] Dependency on deprecated Swagger2 whose
 installation fails
In-Reply-To: <bug-19717-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-19717-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-19717-70-vjyy816MVA@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19717

Zeno Tajoli <z.tajoli at cineca.it> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
         Resolution|---                         |WONTFIX
             Status|NEW                         |RESOLVED

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Nov 30 12:22:33 2017
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 30 Nov 2017 11:22:33 +0000
Subject: [Koha-bugs] [Bug 19716] Add option to send header line for CSV
	output
In-Reply-To: <bug-19716-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-19716-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-19716-70-DNOCJBdgUD@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19716

Kyle M Hall <kyle at bywatersolutions.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
           Assignee|koha-bugs at lists.koha-commun |kyle at bywatersolutions.com
                   |ity.org                     |

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.

From bugzilla-daemon at bugs.koha-community.org  Thu Nov 30 12:28:29 2017
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 30 Nov 2017 11:28:29 +0000
Subject: [Koha-bugs] =?utf-8?q?=5BBug_19719=5D_New=3A__Add_a_=E2=80=98Coll?=
 =?utf-8?q?ection=E2=80=99_column_in_the_patron_loans_data_table=2E?=
Message-ID: <bug-19719-70@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19719

            Bug ID: 19719
           Summary: Add a ?Collection? column in the patron loans data
                    table.
 Change sponsored?: ---
           Product: Koha
           Version: master
          Hardware: All
                OS: All
            Status: NEW
          Severity: enhancement
          Priority: P5 - low
         Component: Architecture, internals, and plumbing
          Assignee: jesse at bywatersolutions.com
          Reporter: kyle at bywatersolutions.com
        QA Contact: testopia at bugs.koha-community.org

1 - Add the Collection code (ccode) to the issues table

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Nov 30 12:28:29 2017
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 30 Nov 2017 11:28:29 +0000
Subject: [Koha-bugs] [Bug 19720] New: Holds not re-routing properly
Message-ID: <bug-19720-70@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19720

            Bug ID: 19720
           Summary: Holds not re-routing properly
 Change sponsored?: ---
           Product: Koha
           Version: master
          Hardware: All
                OS: All
            Status: NEW
          Severity: enhancement
          Priority: P5 - low
         Component: Architecture, internals, and plumbing
          Assignee: jesse at bywatersolutions.com
          Reporter: kyle at bywatersolutions.com
        QA Contact: testopia at bugs.koha-community.org

1 - When a waiting hold is checked in at another library revert the waiting
status

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Nov 30 14:44:18 2017
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 30 Nov 2017 13:44:18 +0000
Subject: [Koha-bugs] [Bug 19721] New: Tabulation in the description of a
 patron category breaks the patron search. Cause : tabs must be escaped in
 JSON
Message-ID: <bug-19721-70@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19721

            Bug ID: 19721
           Summary: Tabulation in the description of a patron category
                    breaks the patron search. Cause: tabs must be escaped
                    in JSON
 Change sponsored?: ---
           Product: Koha
           Version: master
          Hardware: All
                OS: All
            Status: NEW
          Severity: major
          Priority: P5 - low
         Component: Patrons
          Assignee: koha-bugs at lists.koha-community.org
          Reporter: victor.grousset at biblibre.com
        QA Contact: testopia at bugs.koha-community.org
                CC: gmcharlt at gmail.com, kyle.m.hall at gmail.com

=== Reproduce ===
1. Go to staff: /cgi-bin/koha/admin/categories.pl
2. Edit a category with existing patrons
3. Add a tab in the description
   here is one to copy for convenience: "       "
4. Save the category
5. Go to /cgi-bin/koha/members/members-home.pl
6. Filters ? Category ? select the just edited one
7. Hit search, just below
8. Then you should see "Processing..."
   As if the request was still running forever

=== Cause ===
In the browser dev tools, we can see that the XRH request to "search" actually
comes back.
The response seems normal.
Except that Firefox warns "SyntaxError: JSON.parse: bad control character in
string literal at line 23 column 29 of the JSON data"
Which points to our tab.
Which invalidates the JSON:
https://stackoverflow.com/questions/19799006/unable-to-parse-tab-in-json-files#19799355

> The whitespace characters are: character tabulation (U+0009), line feed (U+000A), carriage return (U+000D), and space (U+0020).
> Whitespace is not allowed within any token, except that space is allowed in strings.

=== Workaround ===
Remove the tab from the description of the category.
In /cgi-bin/koha/admin/categories.pl
One can use the filter in the table (called search).
And search for a tab "  " to get the "corrupted" ones.


=== Fix ===
It seems that we should escape the tabs (and CRs(\r) and LFs(\n))
Or just get rid of them.

Another question is where?
- Where the category form is processed?
  - early in the upper layers? (when the request just comes)
  - or in the lower layers? (if the category is managed by the ORM)
- In the database itself with a trigger?
- Other ideas?

=== Going further ===
How to find which other bugs like this one might cause hard to diagnose issues?

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Nov 30 16:17:39 2017
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 30 Nov 2017 15:17:39 +0000
Subject: [Koha-bugs] [Bug 19717] Dependency on deprecated Swagger2 whose
 installation fails
In-Reply-To: <bug-19717-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-19717-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-19717-70-WUOULkZpyi@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19717

--- Comment #2 from Federico Leva <federicoleva at tiscali.it> ---
Good to know, I'll configure my system to install OpenAPI and do without
Swagger2 when it installs 17.11+.

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.

From bugzilla-daemon at bugs.koha-community.org  Thu Nov 30 16:54:04 2017
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 30 Nov 2017 15:54:04 +0000
Subject: [Koha-bugs] [Bug 19722] New: Add a MaxItemsToDisplayForBatchMod
	preference
Message-ID: <bug-19722-70@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19722

            Bug ID: 19722
           Summary: Add a MaxItemsToDisplayForBatchMod preference
 Change sponsored?: ---
           Product: Koha
           Version: master
          Hardware: All
                OS: All
            Status: NEW
          Severity: enhancement
          Priority: P5 - low
         Component: Tools
          Assignee: nick at bywatersolutions.com
          Reporter: nick at bywatersolutions.com
        QA Contact: testopia at bugs.koha-community.org

The tool is setup to run in the background for actual modifications, but
displaying the items beforehand can take too long and cause timeouts.

We should add a syspref and use similar functionality from batch delete items
where one can edit more than is viewed

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Nov 30 16:54:39 2017
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 30 Nov 2017 15:54:39 +0000
Subject: [Koha-bugs] [Bug 19722] Add a MaxItemsToDisplayForBatchMod
	preference
In-Reply-To: <bug-19722-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-19722-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-19722-70-Km3KmYe6Xd@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19722

Nick Clemens <nick at bywatersolutions.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
           See Also|                            |https://bugs.koha-community
                   |                            |.org/bugzilla3/show_bug.cgi
                   |                            |?id=11490

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Nov 30 16:54:39 2017
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 30 Nov 2017 15:54:39 +0000
Subject: [Koha-bugs] [Bug 11490] MaxItemsForBatch should be split into two
	new prefs
In-Reply-To: <bug-11490-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-11490-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-11490-70-qh6OTGXjzK@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11490

Nick Clemens <nick at bywatersolutions.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
           See Also|                            |https://bugs.koha-community
                   |                            |.org/bugzilla3/show_bug.cgi
                   |                            |?id=19722

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Nov 30 16:59:41 2017
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 30 Nov 2017 15:59:41 +0000
Subject: [Koha-bugs] [Bug 15516] Allow to reserve first available item from
 a group of titles
In-Reply-To: <bug-15516-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-15516-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-15516-70-YM8i3bpZjg@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15516

Fiona Borthwick <fiona.borthwick at ptfs-europe.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |fiona.borthwick at ptfs-europe
                   |                            |.com

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Nov 30 20:24:17 2017
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 30 Nov 2017 19:24:17 +0000
Subject: [Koha-bugs] [Bug 19723] New: Use tab key to navigate only in
	subfields
Message-ID: <bug-19723-70@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19723

            Bug ID: 19723
           Summary: Use tab key to navigate only in subfields
 Change sponsored?: ---
           Product: Koha
           Version: unspecified
          Hardware: All
                OS: All
            Status: NEW
          Severity: enhancement
          Priority: P5 - low
         Component: Cataloging
          Assignee: koha-bugs at lists.koha-community.org
          Reporter: patrick.robitaille at collecto.ca
        QA Contact: testopia at bugs.koha-community.org
                CC: m.de.rooy at rijksmuseum.nl

Hi,

Before version 3.12 In authorities module, we could use tab key to navigate
only in subfield's boxs. Now this fonction dosn't work anymore. that was very
usefull and could allowed to save time. It would be nice if the tab key could
only navigate from subfield to subfield in the authorities module when your are
in edit mod. It would be nice if the tab key works like this in the cataloging
module on edit mode too. It would be less manipulation of the mouse like this.

For testing, when you are on a record in edit mode, th tab key goes everywhere
down the fields and it's a long time before going from one subfield to another.
Its the same things in the authorities module. 

Patrick,

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Nov 30 20:48:06 2017
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 30 Nov 2017 19:48:06 +0000
Subject: [Koha-bugs] [Bug 19532] Recalls for Koha
In-Reply-To: <bug-19532-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-19532-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-19532-70-kYd99qP1gO@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19532

Owen Leonard <oleonard at myacpl.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Needs Signoff               |Patch doesn't apply

--- Comment #38 from Owen Leonard <oleonard at myacpl.org> ---
I can't get this to apply!

Apply? [(y)es, (n)o, (i)nteractive] y
Applying: Bug 19532: Database updates
Applying: Bug 19532: Notices for recalls
Applying: Bug 19532: Module files for Recall and OldRecall
Applying: Bug 19532: Some DB fixes
Applying: Bug 19532: Some module fixes
Applying: Bug 19532: Circulation rules
fatal: sha1 information is lacking or useless
(Koha/Schema/Result/Issuingrule.pm).
Repository lacks necessary blobs to fall back on 3-way merge.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Nov 30 22:38:05 2017
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 30 Nov 2017 21:38:05 +0000
Subject: [Koha-bugs] [Bug 19532] Recalls for Koha
In-Reply-To: <bug-19532-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-19532-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-19532-70-OOphlJ9a6i@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19532

--- Comment #39 from Liz Rea <liz at catalyst.net.nz> ---
Hi Owen,

This patch: 
 Bug 19532: Circulation rules (8.52 KB, patch) 

Is out of band and doesn't work properly. We did some heroics at Catalyst
because we needed to do some testing on this bug, but that patch will need to
be fixed by Aleisha.

Cheers,
Liz

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Nov 30 22:39:00 2017
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 30 Nov 2017 21:39:00 +0000
Subject: [Koha-bugs] [Bug 19532] Recalls for Koha
In-Reply-To: <bug-19532-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-19532-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-19532-70-NHUcPXejn0@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19532

--- Comment #40 from Liz Rea <liz at catalyst.net.nz> ---
(Basically, if you skip that one, the rest will apply. Then you just have to
sort out what the bad patch was trying to do, and add that back in.)

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Nov 30 23:39:25 2017
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 30 Nov 2017 22:39:25 +0000
Subject: [Koha-bugs] [Bug 18947] Unexpected Active Directory LDAP
 authentication failure mode
In-Reply-To: <bug-18947-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-18947-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-18947-70-fPyoxHsb01@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18947

Liz Rea <liz at catalyst.net.nz> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |liz at catalyst.net.nz

--- Comment #2 from Liz Rea <liz at catalyst.net.nz> ---
Thanks for writing this down Nick, just had this problem and couldn't even get
in with the DB admin.

-- 
You are receiving this mail because:
You are watching all bug changes.