[Koha-bugs] [Bug 19176] Dates comparison fails on slow server

[bugzilla-daemon at bugs.koha-community.org]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19176

Marcel de Rooy <m.de.rooy at rijksmuseum.nl> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |m.de.rooy at rijksmuseum.nl

--- Comment #26 from Marcel de Rooy <m.de.rooy at rijksmuseum.nl> ---
Just a few (minor) comments from looking at t::lib::Dates

Test::More seems not to be used.
$description is not used either, and if I am not mistaken is never passed too.
POD says that date is truncated to minutes, but the code compares epoch times
(which are seconds) and than rather out of the blue ignores a difference of
less than 6 seconds (why 6) ? A comment in the code would be helpful too. The
POD is no longer true.

If I understood well, Julian asked to remove the floating timezones. It seems
to me that you'd better compare dates in floating however. (See similar problem
with DST boundaries on earlier pushed report.) And yes, you should clone the
dates when changing timezone and comparing.

-- 
You are receiving this mail because:
You are watching all bug changes.