[Koha-bugs] [Bug 18915] Creating a checkout note (patron note) sends an incomplete email message

bugzilla-daemon at bugs.koha-community.org bugzilla-daemon at bugs.koha-community.org
Thu Nov 2 13:42:53 CET 2017


https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18915

--- Comment #8 from M. Tompsett <mtompset at hotmail.com> ---
Comment on attachment 66518
  --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=66518
Bug 18915: Fix checkout note email message

Review of attachment 66518:
 --> (https://bugs.koha-community.org/bugzilla3/page.cgi?id=splinter.html&bug=18915&attachment=66518)
-----------------------------------------------------------------

::: installer/data/mysql/updatedatabase.pl
@@ +14308,4 @@
>  
>      $dbh->do(q|
>          INSERT IGNORE INTO letter (`module`, `code`, `branchcode`, `name`, `is_html`, `title`, `content`, `message_transport_type`)
> +        VALUES ('circulation', 'CHECKOUT_NOTE', '', 'Checkout note on item set by patron', '0', 'Checkout note', '<<borrowers.firstname>> <<borrowers.surname>> has added a note to the item <<biblio.title>> - <<biblio.author>> (<<biblio.biblionumber>>).','email');

I don't think updatedatabase should be modified like this. This is already
done. You add a new DB update which tweaks PATRON_NOTE into CHECKOUT_NOTE, if
this is correct logic.

::: opac/svc/patron_notes
@@ +82,4 @@
>                  my $biblionumber = $issue->item->biblionumber;
>                  my $letter = C4::Letters::GetPreparedLetter (
>                      module => 'circulation',
> +                    letter_code => 'CHECKOUT_NOTE',

Why even change the letter code, given that you aren't changing the svc name?

-- 
You are receiving this mail because:
You are watching all bug changes.


More information about the Koha-bugs mailing list